Page MenuHomePhabricator

Lucas_Werkmeister_WMDE (Lucas Werkmeister (WMDE))
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 3 2017, 2:45 PM (115 w, 2 d)
Availability
Available
IRC Nick
Lucas_WMDE
LDAP User
Lucas Werkmeister (WMDE)
MediaWiki User
Lucas Werkmeister (WMDE) [ Global Accounts ]

Software developer on the Wikidata team at Wikimedia Germany. Private account: @LucasWerkmeister.

Recent Activity

Today

Lucas_Werkmeister_WMDE added a comment to T223149: Use singular they in CC0 explanation.

This is now live \o/ https://commons.wikimedia.org/wiki/Template:Cc-zero

Wed, Jun 19, 6:50 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), WikimediaMessages, I18n, WMF-Legal

Yesterday

Lucas_Werkmeister_WMDE added a comment to T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field.

Is it causing any problems?

Tue, Jun 18, 6:07 PM · Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE renamed T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field from JSON results serializer in Wikidata generates an extra "datatype" field to JSON results serializer in Wikidata Query Service generates an extra "datatype" field.
Tue, Jun 18, 3:16 PM · Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE added a comment to T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field.

BTW: This affect the ShEx validator.

Tue, Jun 18, 3:15 PM · Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field.
Tue, Jun 18, 3:13 PM · Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE added a project to T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field: Wikidata-Query-Service.
Tue, Jun 18, 3:05 PM · Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE closed T185628: jquery.wikibase.entityview.js should not use deprecated jQuery.expr[':'] as Resolved.

This was fixed in Wikibase a while ago with Iefeaad9751 and Iab2227fbd4 – I wasn’t aware of this task at the time, otherwise I would’ve mentioned it in the commit message.

Tue, Jun 18, 2:55 PM · MediaWiki-extensions-WikibaseView, Wikidata, JavaScript
Lucas_Werkmeister_WMDE closed T185628: jquery.wikibase.entityview.js should not use deprecated jQuery.expr[':'], a subtask of T169385: jQuery 3 migration warnings, as Resolved.
Tue, Jun 18, 2:55 PM · MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Wikimedia-General-or-Unknown, Technical-Debt
Lucas_Werkmeister_WMDE updated the task description for T226017: Barchart no longer works in Wikidata Query Service.
Tue, Jun 18, 1:12 PM · Wikidata, Wikidata Query UI
Lucas_Werkmeister_WMDE added a comment to T224832: Connect template parameter to corresponding Wikidata property.

Do we want to get our data from the href or data-attributes? (I like href, because then we can ensure correct no-js behaviour. But they cannot edit this without js on wikidata.org either...)

Tue, Jun 18, 10:35 AM · Wikidata Bridge Sprint 0, Wikidata

Mon, Jun 17

Lucas_Werkmeister_WMDE closed T225805: DatabaseTermIdsAcquirer fails on terms longer than 255 bytes as Resolved.
Mon, Jun 17, 5:38 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata wb_terms Trailblazing, Wikidata
Lucas_Werkmeister_WMDE edited projects for T225883: Wikidata Query Service results should be capable of displaying a report title (new feature request) , added: Wikidata Query UI; removed Wikidata-Query-Service.
Mon, Jun 17, 1:33 PM · Wikidata Query UI, Wikidata

Fri, Jun 14

Lucas_Werkmeister_WMDE updated the task description for T133777: Tools that should get archived/deleted (tracking).
Fri, Jun 14, 5:27 PM · Cleanup, Tracking-Neverending, Toolforge
Lucas_Werkmeister_WMDE added a subtask for T133777: Tools that should get archived/deleted (tracking): T225838: Delete RhinosF1's toolforge projects.
Fri, Jun 14, 5:21 PM · Cleanup, Tracking-Neverending, Toolforge
Lucas_Werkmeister_WMDE added a parent task for T225838: Delete RhinosF1's toolforge projects: T133777: Tools that should get archived/deleted (tracking).
Fri, Jun 14, 5:21 PM · Tools, Toolforge (Tools to be deleted)
Lucas_Werkmeister_WMDE updated the task description for T225805: DatabaseTermIdsAcquirer fails on terms longer than 255 bytes.
Fri, Jun 14, 3:07 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata wb_terms Trailblazing, Wikidata
Lucas_Werkmeister_WMDE moved T225805: DatabaseTermIdsAcquirer fails on terms longer than 255 bytes from In Progress to In Review on the Wikidata wb_terms Trailblazing board.
Fri, Jun 14, 1:33 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata wb_terms Trailblazing, Wikidata
Lucas_Werkmeister_WMDE claimed T225805: DatabaseTermIdsAcquirer fails on terms longer than 255 bytes.
Fri, Jun 14, 1:15 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata wb_terms Trailblazing, Wikidata
Lucas_Werkmeister_WMDE created T225805: DatabaseTermIdsAcquirer fails on terms longer than 255 bytes.
Fri, Jun 14, 12:34 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata wb_terms Trailblazing, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T225796: Wikibase and Lexeme browser tests are failing with `failed-save: The save has failed.`.
Fri, Jun 14, 11:06 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-production-error (Shared Build Failure), User-zeljkofilipin, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Thu, Jun 13

Lucas_Werkmeister_WMDE moved T225603: Wire up read logic for normalized storage in Wikibase from In Progress to In Review on the Wikidata wb_terms Trailblazing board.
Thu, Jun 13, 3:14 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE updated the task description for T225717: Implement DatabaseTermIdsResolver::resolveTermsViaJoin.
Thu, Jun 13, 1:05 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE updated the task description for T225717: Implement DatabaseTermIdsResolver::resolveTermsViaJoin.
Thu, Jun 13, 1:05 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE added a comment to T225003: Implement PropertyLabelResolver using normalized storage.

Rough sketch with Alaa – here, DatabaseTermIdsResolver gets the extra join conditions, and DatabasePropertyTermStore would call that special method if it detects its injected TermIdsResolver is a DatabaseTermIdsResolver.

Thu, Jun 13, 11:25 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE added a comment to T225003: Implement PropertyLabelResolver using normalized storage.

Yeah, that’s what I meant with this part of the task description:

Thu, Jun 13, 11:11 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata, Wikidata wb_terms Trailblazing

Wed, Jun 12

Lucas_Werkmeister_WMDE added a comment to T225244: Travis CI failures in ApiQueryLanguageinfoTest.

I guess building of pull requests should now be turned off again.

Wed, Jun 12, 5:17 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-production-error (Shared Build Failure), MediaWiki-Internationalization, MediaWiki-API
Lucas_Werkmeister_WMDE closed T225244: Travis CI failures in ApiQueryLanguageinfoTest as Resolved.

Travis is green again :)

Wed, Jun 12, 5:15 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-production-error (Shared Build Failure), MediaWiki-Internationalization, MediaWiki-API
Lucas_Werkmeister_WMDE claimed T225603: Wire up read logic for normalized storage in Wikibase.

Well, this also still needs to be wired up so that DataAccessSettings::useNormalizedPropertyTerms() can actually return true. I’m still working on that part, so re-claiming the task.

Wed, Jun 12, 4:24 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE closed T223214: Start converting Wikibase extensions to use extension registration as Resolved.

Done – this task was only for starting the conversion, and with all the patches here being merged, I think we can close it. Hopefully we can continue with the conversion soon.

Wed, Jun 12, 3:45 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata-Campsite (Wikidata-TechDebt-Exploration), Patch-For-Review, Wikimedia-Hackathon-2019, Technical-Debt, wikidata-tech-focus, MediaWiki-extensions-WikibaseRepository, Wikidata, MediaWiki-extensions-WikibaseClient
Lucas_Werkmeister_WMDE closed T223214: Start converting Wikibase extensions to use extension registration, a subtask of T88258: Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration, as Resolved.
Wed, Jun 12, 3:45 PM · Story, Technical-Debt, wikidata-tech-focus, Wikidata-Campsite, Wikidata-Turtles-Tech-Debt, Wikidata-Ministry-Of-Magic-Tech-Debt, Wikidata-Sprint-2017-12-20, Wikidata-Sprint-2015-08-11, Wikidata-Sprint-2015-06-30, Wikidata-Sprint-2015-06-16, Wikidata-Sprint-2015-06-02, MediaWiki-extensions-WikibaseRepository, Wikidata, MediaWiki-extensions-WikibaseClient
Lucas_Werkmeister_WMDE added a comment to T225603: Wire up read logic for normalized storage in Wikibase.

It looks like the current BufferingTermLookup is set up in two places:

Wed, Jun 12, 11:46 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE moved T225603: Wire up read logic for normalized storage in Wikibase from Backlog to Ready to go [prioritized] on the Wikidata wb_terms Trailblazing board.
Wed, Jun 12, 10:41 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE created T225603: Wire up read logic for normalized storage in Wikibase.
Wed, Jun 12, 10:41 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE moved T221748: explain in detail how tool builders can test their work in the test env. from In Progress to Done on the Wikidata wb_terms Trailblazing board.
Wed, Jun 12, 10:36 AM · Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE moved T221746: provide detailed explanation of the migration plan from In Review to Done on the Wikidata wb_terms Trailblazing board.
Wed, Jun 12, 10:36 AM · Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE moved T221747: provide some sample common-case queries from In Review to Done on the Wikidata wb_terms Trailblazing board.
Wed, Jun 12, 10:36 AM · User-Ladsgroup, Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE moved T225223: Change DatabaseTermIdsAcquirer restoration logic to use only master DB when restoring ids from In Review to Done on the Wikidata wb_terms Trailblazing board.
Wed, Jun 12, 10:36 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE moved T219122: [Checkpoint 4] Refactor Write & Migration code for Items from In Progress to Done on the Wikidata wb_terms Trailblazing board.
Wed, Jun 12, 10:31 AM · Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE moved T219121: [Checkpoint 2] Refactor Write & Migration code for Properties from In Review to Done on the Wikidata wb_terms Trailblazing board.
Wed, Jun 12, 10:31 AM · Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE closed T220150: [Story] Clean up unused records as Resolved.

This was tested in T225084: Test write logic on test node, so I think we can close the task.

Wed, Jun 12, 10:29 AM · Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE closed T220150: [Story] Clean up unused records, a subtask of T219121: [Checkpoint 2] Refactor Write & Migration code for Properties, as Resolved.
Wed, Jun 12, 10:29 AM · Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE added a comment to T225574: The SiteConfiguration class (wgConf) should not skip extraction if default is specified as null.

I think SiteConfiguration::getSetting() uses null to mean that no setting of that name exists (though it’s not mentioned in the documentation comments), that’s probably why getAll() and extractGlobalSetting() check is_null( $value ). If we still want to allow callers to distinguish between “setting is null” and “setting is missing”, then perhaps a different signature might be necessary:

Wed, Jun 12, 10:14 AM · Core Platform Team, MediaWiki-Configuration
Lucas_Werkmeister_WMDE added a comment to T225084: Test write logic on test node.

Great, thanks for testing!

Wed, Jun 12, 10:04 AM · Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE added a comment to T225244: Travis CI failures in ApiQueryLanguageinfoTest.

Travis build succeeded except for the PHP 7.3 version, but that seems to be failing for unrelated reasons.

Wed, Jun 12, 8:11 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-production-error (Shared Build Failure), MediaWiki-Internationalization, MediaWiki-API

Tue, Jun 11

Lucas_Werkmeister_WMDE added a comment to T225244: Travis CI failures in ApiQueryLanguageinfoTest.

Thanks! I updated #101 accordingly – so far the Travis job is stuck being queued, but hopefully it’ll start soonish and tell us whether that fully fixes the problem.

Tue, Jun 11, 4:52 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-production-error (Shared Build Failure), MediaWiki-Internationalization, MediaWiki-API
Lucas_Werkmeister_WMDE updated the task description for T225523: U+0200F in query service response for GND ID.
Tue, Jun 11, 3:31 PM · Discovery-Wikidata-Query-Service-Sprint, Wikidata, Wikidata-Query-Service
Lucas_Werkmeister_WMDE added a comment to T225084: Test write logic on test node.

And cleanup also seems to work fairly well – wbx_text rows for the old versions of the labels I edited are gone.

Tue, Jun 11, 2:43 PM · Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE moved T225084: Test write logic on test node from In Progress to In Review on the Wikidata wb_terms Trailblazing board.
Tue, Jun 11, 2:04 PM · Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE added a comment to T225084: Test write logic on test node.

And items like Item:Q1 seem to work just as well after I enabled item migration.

Tue, Jun 11, 2:04 PM · Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE added a comment to T225084: Test write logic on test node.

Property writing seems to work now – I updated the install and then edited the English label of Property:P1 a few times, and after each edit the following query returned the correct text:

Tue, Jun 11, 1:59 PM · Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE closed T225348: Remove Database{Property,Item}TermStore transactions control code as Resolved.
Tue, Jun 11, 1:51 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE closed T225348: Remove Database{Property,Item}TermStore transactions control code, a subtask of T225084: Test write logic on test node, as Resolved.
Tue, Jun 11, 1:51 PM · Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE moved T225003: Implement PropertyLabelResolver using normalized storage from In Review to In Progress on the Wikidata wb_terms Trailblazing board.
Tue, Jun 11, 1:20 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE added a comment to T225003: Implement PropertyLabelResolver using normalized storage.

That makes sense to me – it also matches TermBuffer’s array $termTypes = null, array $languageCodes = null arguments. A separate method doesn’t seem necessary, and a cloning setter seems harder to use to me. And a TermIdsResolverFilter interface doesn’t really work, I think, because you can’t actually inject arbitrary instances of the interface there, the implementation will have to know how to filter for it in the database. (Also, that would open the door to a MatchingPrefixTermIdsResolverFilter, i. e. a kind of search, which we don’t actually want to support as far as I understand.)

Tue, Jun 11, 11:12 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE moved T225348: Remove Database{Property,Item}TermStore transactions control code from In Progress to In Review on the Wikidata wb_terms Trailblazing board.
Tue, Jun 11, 11:02 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE claimed T225348: Remove Database{Property,Item}TermStore transactions control code.
Tue, Jun 11, 10:39 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE added a comment to T225348: Remove Database{Property,Item}TermStore transactions control code.

I think removing it is fine for now. Also, this means we can likely (partially) revert Ic25f4817ae: Inject ILBFactory, not ILoadBalancer, into stores, since we won’t need the transaction methods anymore. (Or should we still inject an ILBFactory? I really don’t understand the difference between the two classes, but in all the other classes we added, we inject an ILoadBalancer.)

Tue, Jun 11, 10:23 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE triaged T217018: Upgrade Wikibase extension to use newer phan as High priority.
Tue, Jun 11, 10:19 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata-Campsite (Wikidata-TechDebt-Exploration), Wikidata, phan
Lucas_Werkmeister_WMDE closed T170281: Raise PHP version requirement of Wikibase (and its related extensions) to 5.6 as Resolved.

I think so – looks like this was done in I228e201b73.

Tue, Jun 11, 10:14 AM · MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, Wikidata

Fri, Jun 7

Lucas_Werkmeister_WMDE added a comment to T225244: Travis CI failures in ApiQueryLanguageinfoTest.

Okay, the Language::getLocalisationCache()->unloadAll(); doesn’t seem to make a difference. But I can keep trying more things (and adding debug code) on GitHub now that pull request building is enabled… though I don’t know how much time I’ll have for this :/

Fri, Jun 7, 5:52 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-production-error (Shared Build Failure), MediaWiki-Internationalization, MediaWiki-API
Lucas_Werkmeister_WMDE closed T225312: role::wikibase in wikidata-dev Cloud VPS project broken (⇒ can’t SSH into wikibase-* instances) as Resolved.
Fri, Jun 7, 5:37 PM · Puppet, Cloud-VPS, Wikidata
Lucas_Werkmeister_WMDE added a comment to T225312: role::wikibase in wikidata-dev Cloud VPS project broken (⇒ can’t SSH into wikibase-* instances).

Okay, I think I’ve figured out the most important parts. Basically, you don’t want to name your instance wikibase-something; however, if you do, I’ve now set some default config that at least lets you SSH into the instance, and added some documentation at https://wikitech.wikimedia.org/wiki/Nova_Resource:Wikidata-dev/Documentation#wikibase*.

Fri, Jun 7, 5:37 PM · Puppet, Cloud-VPS, Wikidata
Lucas_Werkmeister_WMDE renamed T225312: role::wikibase in wikidata-dev Cloud VPS project broken (⇒ can’t SSH into wikibase-* instances) from role::wikibase in wikidata-dev Cloud VPS project broken to role::wikibase in wikidata-dev Cloud VPS project broken (⇒ can’t SSH into wikibase-* instances).
Fri, Jun 7, 4:51 PM · Puppet, Cloud-VPS, Wikidata
Lucas_Werkmeister_WMDE closed T225307: Can't SSH to new instances as Resolved.

My wikibase-dev issue turns out to be specific to that project, see T225312: role::wikibase in wikidata-dev Cloud VPS project broken (⇒ can’t SSH into wikibase-* instances), and @Samwalton9’s issue appears to have resolved itself according to discussion in #wikimedia-cloud, so I guess we can close this.

Fri, Jun 7, 4:49 PM · Cloud-VPS
Lucas_Werkmeister_WMDE added a comment to T225312: role::wikibase in wikidata-dev Cloud VPS project broken (⇒ can’t SSH into wikibase-* instances).

I tried this out by creating other-test-T225307 and wikibase-test-T225307 instances; other-test-T225307 worked fine, wikibase-test-T225307 doesn’t. (I’m deleting other-test-T225307 now, but wikibase-test-T225307 can stay around for a bit, in case someone wants to investigate it further.)

Fri, Jun 7, 4:48 PM · Puppet, Cloud-VPS, Wikidata
Lucas_Werkmeister_WMDE created T225312: role::wikibase in wikidata-dev Cloud VPS project broken (⇒ can’t SSH into wikibase-* instances).
Fri, Jun 7, 4:46 PM · Puppet, Cloud-VPS, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T225307: Can't SSH to new instances.
Fri, Jun 7, 3:28 PM · Cloud-VPS
Lucas_Werkmeister_WMDE updated the task description for T172368: [Task] Make the Wikibase.git code base PSR-4 compatible.
Fri, Jun 7, 3:18 PM · Technical-Debt, wikidata-tech-focus, Patch-For-Review, patch-welcome, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE added a comment to T225244: Travis CI failures in ApiQueryLanguageinfoTest.

Now it’s building, thanks.

Fri, Jun 7, 1:54 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-production-error (Shared Build Failure), MediaWiki-Internationalization, MediaWiki-API
Lucas_Werkmeister_WMDE added a comment to T225244: Travis CI failures in ApiQueryLanguageinfoTest.

I opened #101, but the Travis pull requests page says “no pull request builds for this repository”, and the “requests” list explains:

Fri, Jun 7, 1:30 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-production-error (Shared Build Failure), MediaWiki-Internationalization, MediaWiki-API
Lucas_Werkmeister_WMDE updated subscribers of T224525: Error when running a clean wikibase-docker image: Config.getConfig is not a function.
Fri, Jun 7, 10:25 AM · Wikibase-Containers, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T225289: Wikibase extension type no longer translated on Special:Version.
Fri, Jun 7, 10:10 AM · Wikidata-Campsite, Shape Expressions, Wikidata
Lucas_Werkmeister_WMDE created T225289: Wikibase extension type no longer translated on Special:Version.
Fri, Jun 7, 10:10 AM · Wikidata-Campsite, Shape Expressions, Wikidata
Lucas_Werkmeister_WMDE added a comment to T225212: Specify $wgWBRepoSettings['conceptBaseUri'].

I'm not sure what level exactly it logs at, but it at very least debug logs… and given we resolve this on almost every Wikidata related request, we should try to avoid this also for performance reasons (even if no one listens to that log).

Fri, Jun 7, 7:53 AM · Wikidata
Lucas_Werkmeister_WMDE added a comment to T225244: Travis CI failures in ApiQueryLanguageinfoTest.

Failed asserting that an array does not have the key 'warnings'.

Fri, Jun 7, 7:50 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-production-error (Shared Build Failure), MediaWiki-Internationalization, MediaWiki-API
Lucas_Werkmeister_WMDE closed T225001: Implement PrefetchingTermLookup for properties using normalized storage as Resolved.

It might need more optimizations, but that should be a separate task.

Fri, Jun 7, 7:37 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE closed T225001: Implement PrefetchingTermLookup for properties using normalized storage, a subtask of T219303: [Checkpoint 5] Update Read Logic, as Resolved.
Fri, Jun 7, 7:36 AM · Wikidata, Wikidata wb_terms Trailblazing

Thu, Jun 6

Lucas_Werkmeister_WMDE added a comment to T221704: Update wikibase logic to queue a deferred update for cleanup after updating/delete terms in terms store.

I think we should decline this task – it turns out Wikibase already defers the whole terms update, so there’s no point in deferring just the cleanup part even further IMHO. (See also T225084#5240930.)

Thu, Jun 6, 4:21 PM · Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE added a comment to T225084: Test write logic on test node.

I think I’ve figured it out. Stacktrace from log/debug-termwiki.log:

Thu, Jun 6, 4:20 PM · Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE added a comment to T225084: Test write logic on test node.

The tests are working:

Thu, Jun 6, 3:39 PM · Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE moved T225050: Update DatabaseItemTermStore and DatabasePropertyTermStore to use callback logic in DatabaseTermIdsAcquirer from In Progress to In Review on the Wikidata wb_terms Trailblazing board.
Thu, Jun 6, 3:29 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE added a comment to T223214: Start converting Wikibase extensions to use extension registration.

I just rebased the chain because it conflicted with Iabc6aaeb76. Can we get this merged soon to avoid further conflicts?

Thu, Jun 6, 3:05 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata-Campsite (Wikidata-TechDebt-Exploration), Patch-For-Review, Wikimedia-Hackathon-2019, Technical-Debt, wikidata-tech-focus, MediaWiki-extensions-WikibaseRepository, Wikidata, MediaWiki-extensions-WikibaseClient
Lucas_Werkmeister_WMDE updated the task description for T225212: Specify $wgWBRepoSettings['conceptBaseUri'].
Thu, Jun 6, 1:40 PM · Wikidata
Lucas_Werkmeister_WMDE created T225212: Specify $wgWBRepoSettings['conceptBaseUri'].
Thu, Jun 6, 1:36 PM · Wikidata
Lucas_Werkmeister_WMDE created T225207: Enable scap to roll back broken changes to MediaWiki.
Thu, Jun 6, 1:26 PM · Scap, Release-Engineering-Team, Operations
Lucas_Werkmeister_WMDE moved T219122: [Checkpoint 4] Refactor Write & Migration code for Items from Ready to go [prioritized] to In Progress on the Wikidata wb_terms Trailblazing board.
Thu, Jun 6, 12:57 PM · Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE moved T225002: Implement PrefetchingTermLookup for items using normalized storage from Ready to go [prioritized] to Backlog on the Wikidata wb_terms Trailblazing board.
Thu, Jun 6, 12:56 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE moved T219121: [Checkpoint 2] Refactor Write & Migration code for Properties from Ready to go [prioritized] to In Progress on the Wikidata wb_terms Trailblazing board.
Thu, Jun 6, 12:56 PM · Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE moved T219303: [Checkpoint 5] Update Read Logic from Ready to go [prioritized] to In Progress on the Wikidata wb_terms Trailblazing board.
Thu, Jun 6, 12:56 PM · Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE moved T220150: [Story] Clean up unused records from Ready to go [prioritized] to In Progress on the Wikidata wb_terms Trailblazing board.
Thu, Jun 6, 12:55 PM · Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE added a comment to T225050: Update DatabaseItemTermStore and DatabasePropertyTermStore to use callback logic in DatabaseTermIdsAcquirer.

Oh, there’s an issue with this though: in the callback, we don’t have the property ID to which the terms belong… I think it actually needs to be a second argument to acquireTermIds(), not a persistent attribute of the acquirer?

Thu, Jun 6, 11:45 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE added a comment to T225000: Introduce way to bulk-lookup terms in normalized schema.

Well, the third patch is still waiting for gate-and-submit to finish…

Thu, Jun 6, 11:16 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE updated the task description for T225000: Introduce way to bulk-lookup terms in normalized schema.
Thu, Jun 6, 11:16 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE claimed T225050: Update DatabaseItemTermStore and DatabasePropertyTermStore to use callback logic in DatabaseTermIdsAcquirer.

I’ll go with my suggested variant of the first version – I think that’s very clean and shouldn’t be too much effort.

Thu, Jun 6, 10:26 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE edited projects for T225171: Wikidata query service should recognize 429 errors, added: Wikidata Query UI; removed Wikidata-Query-Service.

I don’t see why we would need to investigate anything, to be honest – this task as I understand it isn’t about preventing those 429 errors, it’s about showing them to the user a bit more nicely, just like we detect timeouts and show a special error message.

Thu, Jun 6, 9:30 AM · Wikidata Query UI, User-DannyS712, Wikidata

Wed, Jun 5

Lucas_Werkmeister_WMDE moved T225001: Implement PrefetchingTermLookup for properties using normalized storage from In Progress to In Review on the Wikidata wb_terms Trailblazing board.
Wed, Jun 5, 5:23 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE claimed T225001: Implement PrefetchingTermLookup for properties using normalized storage.
Wed, Jun 5, 3:25 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE added a comment to T225050: Update DatabaseItemTermStore and DatabasePropertyTermStore to use callback logic in DatabaseTermIdsAcquirer.

As a slight variation of the first suggestion – if there’s an addTermIdsConsumerCallback() method, I think we could remove the constructor parameter again. After all, we wouldn’t use it in the WikibaseRepo use case, as far as I understand.

Wed, Jun 5, 3:23 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE added a comment to T225084: Test write logic on test node.

Damn, I also thought it would be due to that patch…

Wed, Jun 5, 3:20 PM · Wikidata wb_terms Trailblazing
Lucas_Werkmeister_WMDE updated the task description for T225000: Introduce way to bulk-lookup terms in normalized schema.
Wed, Jun 5, 2:46 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikidata, Wikidata wb_terms Trailblazing