Page MenuHomePhabricator

Lucas_Werkmeister_WMDE (Lucas Werkmeister (WMDE))
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 3 2017, 2:45 PM (149 w, 6 d)
Availability
Available
IRC Nick
Lucas_WMDE
LDAP User
Lucas Werkmeister (WMDE)
MediaWiki User
Lucas Werkmeister (WMDE) [ Global Accounts ]

Software developer on the Wikidata team at Wikimedia Germany. Private account: @LucasWerkmeister.

Recent Activity

Fri, Feb 14

Lucas_Werkmeister_WMDE updated subscribers of T245245: Message Wikibase-error-ui-no-external-page shows literal $1 and $2 instead of values.

Reverting rEWBA66bcfe6704a8: Add errorformat parameter to wikibase API requests fixes the issue for me locally, so this seems to be fallout from T242769: Wikibase UI API calls should request a specific errorformat. Apparently we take the parameters for the message from the error returned by the API, so it seems that with the new error format we no longer get the parameters, or something like that.

Fri, Feb 14, 6:39 PM · Wikidata-Campsite, I18n, Wikidata
Lucas_Werkmeister_WMDE moved T244992: Incorporate new component library release in bridge from Doing to Peer Review on the Wikidata-Bridge-Sprint-14 board.
Fri, Feb 14, 3:01 PM · Patch-For-Review, Wikidata-Bridge-Sprint-14, Wikidata
Lucas_Werkmeister_WMDE claimed T244992: Incorporate new component library release in bridge.
Fri, Feb 14, 2:49 PM · Patch-For-Review, Wikidata-Bridge-Sprint-14, Wikidata
Lucas_Werkmeister_WMDE moved T244989: Release component lib from Doing to Peer Review on the Wikidata-Bridge-Sprint-14 board.
Fri, Feb 14, 1:22 PM · Patch-For-Review, Wikidata-Bridge-Sprint-14, Wikidata
Lucas_Werkmeister_WMDE claimed T244989: Release component lib.
Fri, Feb 14, 1:14 PM · Patch-For-Review, Wikidata-Bridge-Sprint-14, Wikidata
Lucas_Werkmeister_WMDE updated the cover image for T238662: Step 1: make edit based on fix/update choice (impact: high).
Fri, Feb 14, 1:04 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Wikidata-Bridge-Sprint-14, Patch-For-Review, Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE closed T244991: Implement changes in component library, a subtask of T243192: font size adjustments, as Resolved.
Fri, Feb 14, 12:57 PM · Wikidata-Bridge-Sprint-14, Wikidata
Lucas_Werkmeister_WMDE closed T244991: Implement changes in component library as Resolved.
Fri, Feb 14, 12:57 PM · Wikidata-Bridge-Sprint-14, Wikidata
Lucas_Werkmeister_WMDE updated the cover image for T238662: Step 1: make edit based on fix/update choice (impact: high).
Fri, Feb 14, 12:54 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Wikidata-Bridge-Sprint-14, Patch-For-Review, Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE updated the cover image for T238662: Step 1: make edit based on fix/update choice (impact: high).
Fri, Feb 14, 12:49 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Wikidata-Bridge-Sprint-14, Patch-For-Review, Wikidata-Bridge-Sprint-13, Wikidata

Thu, Feb 13

Lucas_Werkmeister_WMDE committed rEBQC16a0a362e06a: Don’t cache results with non-local sources (authored by Lucas_Werkmeister_WMDE).
Don’t cache results with non-local sources
Thu, Feb 13, 4:30 PM
Lucas_Werkmeister_WMDE updated the task description for T245135: Too many values for wikibase:geoLatitude and wikibase:geoLongitude in WDQS.
Thu, Feb 13, 11:19 AM · Wikidata, Wikidata-Query-Service
Lucas_Werkmeister_WMDE added a comment to T245135: Too many values for wikibase:geoLatitude and wikibase:geoLongitude in WDQS.

This is due to T174504 (see especially T174504#5534713) and should be resolved with the next full WDQS reload, which will hopefully happen soon (cf. T230588#5534626).

Thu, Feb 13, 11:17 AM · Wikidata, Wikidata-Query-Service

Wed, Feb 12

Lucas_Werkmeister_WMDE added a comment to T239421: Step 1: mobile fixes (impact: medium).

@Michael Is this ready for Verification already or is more work still missing?

Wed, Feb 12, 5:44 PM · Patch-For-Review, User-Michael, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Wikidata-Bridge-Sprint-14, Wikidata
Lucas_Werkmeister_WMDE moved T244991: Implement changes in component library from Doing to Peer Review on the Wikidata-Bridge-Sprint-14 board.
Wed, Feb 12, 5:10 PM · Wikidata-Bridge-Sprint-14, Wikidata
Lucas_Werkmeister_WMDE claimed T244991: Implement changes in component library.
Wed, Feb 12, 2:39 PM · Wikidata-Bridge-Sprint-14, Wikidata
Lucas_Werkmeister_WMDE moved T240340: Host bridge storybook on doc.wikimedia.org from To do to Done on the Wikidata-Bridge-Sprint-14 board.
Wed, Feb 12, 2:35 PM · Wikidata-Bridge-Sprint-14, Wikidata-Bridge-Sprint-13, User-Michael, Documentation, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), wikidata-tech-focus, Wikidata
Lucas_Werkmeister_WMDE closed T240340: Host bridge storybook on doc.wikimedia.org as Resolved.
Wed, Feb 12, 2:35 PM · Wikidata-Bridge-Sprint-14, Wikidata-Bridge-Sprint-13, User-Michael, Documentation, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), wikidata-tech-focus, Wikidata
Lucas_Werkmeister_WMDE added a subtask for T240340: Host bridge storybook on doc.wikimedia.org: T245026: Archive/delete tool wikibase-databridge-storybook.
Wed, Feb 12, 2:30 PM · Wikidata-Bridge-Sprint-14, Wikidata-Bridge-Sprint-13, User-Michael, Documentation, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), wikidata-tech-focus, Wikidata
Lucas_Werkmeister_WMDE added a parent task for T245026: Archive/delete tool wikibase-databridge-storybook: T240340: Host bridge storybook on doc.wikimedia.org.
Wed, Feb 12, 2:30 PM · Cleanup, Tools, Toolforge (Tools to be deleted)
Lucas_Werkmeister_WMDE created T245026: Archive/delete tool wikibase-databridge-storybook.
Wed, Feb 12, 2:30 PM · Cleanup, Tools, Toolforge (Tools to be deleted)
Lucas_Werkmeister_WMDE closed T244924: wikibase:label autovariables and sparql aggregation function like group_concat don’t work together as Invalid.

Not a bug, as explained above and on project chat. I’ve expanded the documentation a bit, hopefully that helps.

Wed, Feb 12, 12:36 PM · Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244916: (Property|Item)TermStore::getTerms() is unused.

If this is done, I’d say the interface(s) should be renamed, because having a “store” that’s write-only and doesn’t support reads doesn’t make sense to me.

Wed, Feb 12, 11:44 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Wikidata, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
Lucas_Werkmeister_WMDE archived Wikidata-Bridge-Sprint-13.
Wed, Feb 12, 11:32 AM

Tue, Feb 11

Lucas_Werkmeister_WMDE added a comment to T227083: Termbox should hide non-supported languages.

FWIW, Jakob’s comment at T217770#5778186 seems to mention the ?uselang “hack” as something that still needs to be cleaned up, so maybe that was never intended to be in scope of this task?

Tue, Feb 11, 6:01 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244856: Prefer relevant unit suggestions over other entities.

I think the unit conversions are also ultimately derived from the Wikidata statements (rOMWCa15236c286d8: Add more units for conversion indicates a maintenance script), but I don’t know the details. I just think it would be nice to avoid an extra config if we already have the unit conversions (but up to you, of course).

Tue, Feb 11, 2:20 PM · Wikidata, MediaWiki-extensions-PropertySuggester, Structured Data Engineering, Structured-Data-Backlog (Current Work)
Lucas_Werkmeister_WMDE added a comment to T244856: Prefer relevant unit suggestions over other entities.

It might be possible to use the unit conversions (UnitStorage interface) for this – any item with a unit conversion from (centimeter) or to it (meter) is probably a useful unit.

Tue, Feb 11, 2:12 PM · Wikidata, MediaWiki-extensions-PropertySuggester, Structured Data Engineering, Structured-Data-Backlog (Current Work)
Lucas_Werkmeister_WMDE added a comment to T238662: Step 1: make edit based on fix/update choice (impact: high).

Unassigned myself – anyone is free to pick up #2 and #3.

Tue, Feb 11, 12:05 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Wikidata-Bridge-Sprint-14, Patch-For-Review, Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE placed T238662: Step 1: make edit based on fix/update choice (impact: high) up for grabs.
Tue, Feb 11, 12:04 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Wikidata-Bridge-Sprint-14, Patch-For-Review, Wikidata-Bridge-Sprint-13, Wikidata

Mon, Feb 10

Lucas_Werkmeister_WMDE moved T238662: Step 1: make edit based on fix/update choice (impact: high) from Doing to Peer Review on the Wikidata-Bridge-Sprint-13 board.
Mon, Feb 10, 5:08 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Wikidata-Bridge-Sprint-14, Patch-For-Review, Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE claimed T238662: Step 1: make edit based on fix/update choice (impact: high).
Mon, Feb 10, 3:39 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Wikidata-Bridge-Sprint-14, Patch-For-Review, Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE added a comment to T240340: Host bridge storybook on doc.wikimedia.org.

remove existing storybook installation on toolforge

Mon, Feb 10, 3:35 PM · Wikidata-Bridge-Sprint-14, Wikidata-Bridge-Sprint-13, User-Michael, Documentation, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), wikidata-tech-focus, Wikidata
Lucas_Werkmeister_WMDE added a comment to T233295: Step 1: Add label of property to header message (impact: low).

i noticed this as well. i am not how costly it would e to improve this and depending on that whether @Lydia_Pintscher
sees this as part of step 1 or not.

Mon, Feb 10, 3:30 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T237433: Step 1: Loading bar for saving (impact: low).
Mon, Feb 10, 2:52 PM · Wikidata, Wikidata-Bridge
Lucas_Werkmeister_WMDE assigned T240340: Host bridge storybook on doc.wikimedia.org to Michael.
Mon, Feb 10, 2:42 PM · Wikidata-Bridge-Sprint-14, Wikidata-Bridge-Sprint-13, User-Michael, Documentation, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), wikidata-tech-focus, Wikidata
Lucas_Werkmeister_WMDE edited projects for T238662: Step 1: make edit based on fix/update choice (impact: high), added: Wikidata-Bridge-Sprint-13; removed Wikidata-Bridge.
Mon, Feb 10, 2:41 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Wikidata-Bridge-Sprint-14, Patch-For-Review, Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE added a comment to T238662: Step 1: make edit based on fix/update choice (impact: high).

We were unable to find any split more fine-grained than this in the task breakdown:

Mon, Feb 10, 2:41 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Wikidata-Bridge-Sprint-14, Patch-For-Review, Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE added a comment to T238662: Step 1: make edit based on fix/update choice (impact: high).

Notes from task breakdown:

Mon, Feb 10, 2:29 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Wikidata-Bridge-Sprint-14, Patch-For-Review, Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T238662: Step 1: make edit based on fix/update choice (impact: high).
Mon, Feb 10, 2:07 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Wikidata-Bridge-Sprint-14, Patch-For-Review, Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE moved T233295: Step 1: Add label of property to header message (impact: low) from Peer Review to Verification on the Wikidata-Bridge-Sprint-13 board.
Mon, Feb 10, 1:52 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE added a comment to T242747: Step 1: bail-out path for novalue/somevalue in the main snak (impact: medium).

You’re right – I’ve added a separate novalue link now.

Mon, Feb 10, 1:48 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE added a comment to T242747: Step 1: bail-out path for novalue/somevalue in the main snak (impact: medium).

somevalue is the internal name of “unknown value”.

Mon, Feb 10, 12:56 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244572: Reading constraint definitions from the database of another wiki doesn't work.

I created T244726: WikibaseQualityConstraints can’t cache constraint results in federated setups for the bug described above.

Mon, Feb 10, 12:03 PM · Wikidata-Campsite, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE created T244726: WikibaseQualityConstraints can’t cache constraint results in federated setups.
Mon, Feb 10, 12:03 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244572: Reading constraint definitions from the database of another wiki doesn't work.
stack trace
InvalidArgumentException at /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityMetaDataLookup.php(237)
#0 /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityMetaDataLookup.php(228): Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup->assertEntityIdFromKnownSource(Wikibase\DataModel\Entity\PropertyId)
#1 /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityMetaDataLookup.php(222): Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup->assertCanHandleEntityId(Wikibase\DataModel\Entity\PropertyId)
#2 /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/Store/Sql/WikiPageEntityMetaDataLookup.php(188): Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup->assertCanHandleEntityIds(array)
#3 /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/Store/Sql/TypeDispatchingWikiPageEntityMetaDataAccessor.php(135): Wikibase\Lib\Store\Sql\WikiPageEntityMetaDataLookup->loadLatestRevisionIds(array, string)
#4 /srv/mediawiki/php-master/extensions/Wikibase/lib/includes/Store/Sql/PrefetchingWikiPageEntityMetaDataAccessor.php(253): Wikibase\Lib\Store\Sql\TypeDispatchingWikiPageEntityMetaDataAccessor->loadLatestRevisionIds(array, string)
#5 /srv/mediawiki/php-master/extensions/WikibaseQualityConstraints/src/Api/CachingResultsSource.php(469): Wikibase\Lib\Store\Sql\PrefetchingWikiPageEntityMetaDataAccessor->loadLatestRevisionIds(array, string)
#6 /srv/mediawiki/php-master/extensions/WikibaseQualityConstraints/src/Api/CachingResultsSource.php(289): WikibaseQuality\ConstraintReport\Api\CachingResultsSource->getLatestRevisionIds(array)
#7 /srv/mediawiki/php-master/extensions/WikibaseQualityConstraints/src/Api/CachingResultsSource.php(239): WikibaseQuality\ConstraintReport\Api\CachingResultsSource->storeResults(Wikibase\MediaInfo\DataModel\MediaInfoId, WikibaseQuality\ConstraintReport\ConstraintCheck\Cache\CachedCheckResults)
#8 /srv/mediawiki/php-master/extensions/WikibaseQualityConstraints/src/Api/CachingResultsSource.php(167): WikibaseQuality\ConstraintReport\Api\CachingResultsSource->getAndStoreResults(array, array, NULL, array)
#9 /srv/mediawiki/php-master/extensions/WikibaseQualityConstraints/src/Api/CheckConstraints.php(172): WikibaseQuality\ConstraintReport\Api\CachingResultsSource->getResults(array, array, NULL, array)
#10 /srv/mediawiki/php-master/includes/api/ApiMain.php(1586): WikibaseQuality\ConstraintReport\Api\CheckConstraints->execute()
#11 /srv/mediawiki/php-master/includes/api/ApiMain.php(522): ApiMain->executeAction()
#12 /srv/mediawiki/php-master/includes/api/ApiMain.php(493): ApiMain->executeActionWithErrorHandling()
#13 /srv/mediawiki/php-master/api.php(84): ApiMain->execute()
#14 /srv/mediawiki/w/api.php(3): require(string)
#15 {main}
Mon, Feb 10, 11:31 AM · Wikidata-Campsite, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244572: Reading constraint definitions from the database of another wiki doesn't work.

Hm, now there’s an exception:

Mon, Feb 10, 11:05 AM · Wikidata-Campsite, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T243701: Wikidata maxlag repeatedly over 5s since Jan20, 2020 (primarily caused by the query service).

Either the lag in WDQS needs to be fixed, or we need to introduce some scaling factor in Wikibase so that lag is usually under 5s like we have for the job queue.

Mon, Feb 10, 11:03 AM · Wikidata-Campsite, Traffic, Operations, Performance Issue, Discovery, Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244341: Wikibase RDF dump: stop using blank nodes for encoding unknown values and OWL constraints.

Why would we call them “blank values” if we’re transitioning away from blank nodes as the underlying mechanism?

Mon, Feb 10, 10:59 AM · Wikidata-Query-Service, Wikidata

Fri, Feb 7

Lucas_Werkmeister_WMDE moved T233295: Step 1: Add label of property to header message (impact: low) from Doing to Peer Review on the Wikidata-Bridge-Sprint-13 board.
Fri, Feb 7, 6:19 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244580: Requesting administrator access for Lucas Werkmeister (WMDE).

Great, thank you :)

Fri, Feb 7, 5:51 PM · wikitech.wikimedia.org
Lucas_Werkmeister_WMDE moved T240212: Step 1: bail-out for statement groups with more than one value (impact: high) from Peer Review to Verification on the Wikidata-Bridge-Sprint-13 board.
Fri, Feb 7, 5:24 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE moved T242747: Step 1: bail-out path for novalue/somevalue in the main snak (impact: medium) from Peer Review to Verification on the Wikidata-Bridge-Sprint-13 board.
Fri, Feb 7, 5:24 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE moved T238660: Step 1: bail-out path for deprecated main snaks (impact: medium) from Peer Review to Verification on the Wikidata-Bridge-Sprint-13 board.
Fri, Feb 7, 5:24 PM · Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE moved T235753: Step 1: Bail-out path for unsupported datatypes (impact: high) from Peer Review to Verification on the Wikidata-Bridge-Sprint-13 board.
Fri, Feb 7, 5:23 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata-Bridge-Sprint-12, Wikidata
Lucas_Werkmeister_WMDE moved T233295: Step 1: Add label of property to header message (impact: low) from To do to Doing on the Wikidata-Bridge-Sprint-13 board.
Fri, Feb 7, 4:52 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE claimed T233295: Step 1: Add label of property to header message (impact: low).
Fri, Feb 7, 4:52 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE moved T235753: Step 1: Bail-out path for unsupported datatypes (impact: high) from Doing to Peer Review on the Wikidata-Bridge-Sprint-13 board.
Fri, Feb 7, 4:51 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata-Bridge-Sprint-12, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244580: Requesting administrator access for Lucas Werkmeister (WMDE).

contentadmin, I suppose (I wasn’t aware of the difference before).

Fri, Feb 7, 4:46 PM · wikitech.wikimedia.org
Lucas_Werkmeister_WMDE created T244580: Requesting administrator access for Lucas Werkmeister (WMDE).
Fri, Feb 7, 3:43 PM · wikitech.wikimedia.org
Lucas_Werkmeister_WMDE updated subscribers of T244341: Wikibase RDF dump: stop using blank nodes for encoding unknown values and OWL constraints.

CCing @mkroetzsch and @Denny for input on the RDF model – they probably have some use cases in mind.

Fri, Feb 7, 2:31 PM · Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244572: Reading constraint definitions from the database of another wiki doesn't work.

Hm, it reports results too:

the status is reported as “not implemented”

Fri, Feb 7, 1:30 PM · Wikidata-Campsite, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244572: Reading constraint definitions from the database of another wiki doesn't work.

But it looks like the constraint type is broken?

>>> $results[0]->getConstraint()->getConstraintTypeItemId()
=> "One of"

That’s not an item ID; presumably, that’s why the status is reported as “not implemented”:

>>> $results[0]->getStatus()
=> "todo"
Fri, Feb 7, 1:17 PM · Wikidata-Campsite, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244572: Reading constraint definitions from the database of another wiki doesn't work.

Ah, but Beta Commons has no idea that Q505107 means “one of” – InitialiseSettings-labs.php only configures that for Beta Wikidata:

Fri, Feb 7, 1:15 PM · Wikidata-Campsite, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244572: Reading constraint definitions from the database of another wiki doesn't work.

Hm, it reports results too:

Fri, Feb 7, 1:10 PM · Wikidata-Campsite, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244572: Reading constraint definitions from the database of another wiki doesn't work.

Hm, it looks to me like the “reading constraint definitions” part itself is working:

Fri, Feb 7, 1:05 PM · Wikidata-Campsite, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244529: mw.wikibase.getLabelByLang not return item label for some items, because MIGRATION_WRITE_NEW is being deployed with train for wmf.18.

Might be the same thing as T244115: Investigate & Fix holes for aliases in new property terms table (take 3)?

Fri, Feb 7, 10:24 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), MediaWiki-extensions-WikibaseRepository, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Regression, Wikidata

Thu, Feb 6

Lucas_Werkmeister_WMDE committed rEWLC2e5d02ff0783: Update namespace for PrefetchingTermLookup & fix tests (authored by Lucas_Werkmeister_WMDE).
Update namespace for PrefetchingTermLookup & fix tests
Thu, Feb 6, 6:25 PM
Lucas_Werkmeister_WMDE added a comment to T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo.
  • Virtual usages comes into play here.

Being connected via sitelink is the original "virtual usage" considered by AffectedPagesFinder. We discussed also treating the description from wikidata as a virtual usage, since it's visible in the mobile view. Don't remember how that played out.

Thu, Feb 6, 1:14 PM · Core Platform Team Workboards (Clinic Duty Team), User-Addshore, Wikidata-Campsite, Commons, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244479: Argument 5 passed to Wikibase\Lexeme\Search\Elastic\LexemeSearchEntity::__construct() must be an instance of Wikibase\Lib\Store\PrefetchingTermLookup, instance of Wikibase\DataAccess\ByTypeDispatchingPrefetchingTermLookup given, called in /srv/mediawiki/php-1.35.0-wmf.18/extensions/WikibaseLexemeCirrusSearch/WikibaseSearch.entitytypes.repo.php on line 41.

I assume this is what caused https://twitter.com/fnielsen/status/1225404037622849536, because in the error logs I saw this:

Thu, Feb 6, 1:08 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikimedia-production-error
Lucas_Werkmeister_WMDE added a comment to T32238: Create method to get directionality of message including the fallback tree.

This task so far talks only about the directionality of a message; however, I imagine getting its language its also important, so we can set the correct lang attribute if necessary, e. g. for screenreaders. (For example, T32182: Untranslated gadget descriptions have incorrect directionality in RTL user languages was mostly fixed by applying dir="auto", but the language of untranslated gadget descriptions remains unchanged (i. e., the page content language, not the language of the message that was actually used)).

Thu, Feb 6, 12:58 PM · RTL, I18n, MediaWiki-Internationalization
Lucas_Werkmeister_WMDE added a comment to T32182: Untranslated gadget descriptions have incorrect directionality in RTL user languages.

Do we still need to wait, or did browsers other than Chrome and HTML5 catch up?

Thu, Feb 6, 12:51 PM · RTL, I18n, MediaWiki-extensions-Gadgets
Lucas_Werkmeister_WMDE updated the task description for T32238: Create method to get directionality of message including the fallback tree.
Thu, Feb 6, 12:24 PM · RTL, I18n, MediaWiki-Internationalization
Lucas_Werkmeister_WMDE closed T244342: Reduce duplication in bail-out errors as Resolved.

sounds good to me 👍

Thu, Feb 6, 10:55 AM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE closed T244342: Reduce duplication in bail-out errors, a subtask of T238660: Step 1: bail-out path for deprecated main snaks (impact: medium), as Resolved.
Thu, Feb 6, 10:55 AM · Wikidata-Bridge-Sprint-13, Wikidata

Wed, Feb 5

Lucas_Werkmeister_WMDE added a comment to T244341: Wikibase RDF dump: stop using blank nodes for encoding unknown values and OWL constraints.

Yeah, I also thought of encoding the statement ID in it, but the STRSTARTS is a bit ugly. Also, this doesn’t provide an obvious path for unknown values used in qualifiers and references… what could those use? (I assume the main requirement for the updater is that, whatever these IDs look like, they should remain stable between RDF exports of different revisions?)

Wed, Feb 5, 6:27 PM · Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE moved T242747: Step 1: bail-out path for novalue/somevalue in the main snak (impact: medium) from Doing to Peer Review on the Wikidata-Bridge-Sprint-13 board.
Wed, Feb 5, 3:57 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE moved T244342: Reduce duplication in bail-out errors from Peer Review to Verification on the Wikidata-Bridge-Sprint-13 board.

@Michael @Tonina_Zhelyazkova_WMDE do we want to reduce any more duplication (e. g. in the <template> and <script> parts) or is this enough?

Wed, Feb 5, 3:15 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE added a comment to T235753: Step 1: Bail-out path for unsupported datatypes (impact: high).

Uh, another thing… we still need to pass the property label into the message, rather than the property ID. IIRC we said during code review that we were going to do that in a separate change – well, we still have to do it :)

Wed, Feb 5, 2:57 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata-Bridge-Sprint-12, Wikidata
Lucas_Werkmeister_WMDE moved T235753: Step 1: Bail-out path for unsupported datatypes (impact: high) from Verification to To do on the Wikidata-Bridge-Sprint-13 board.

So either we apply the same fix (scale the margin appropriately to cancel out the font size), or we rethink this whole px-to-em business, because at least I don’t understand it at all.

Wed, Feb 5, 2:25 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata-Bridge-Sprint-12, Wikidata
Lucas_Werkmeister_WMDE added a comment to T235753: Step 1: Bail-out path for unsupported datatypes (impact: high).

Ah, I see – seems to be the same issue as the one fixed in fix vertical spacing for the button: the element (in this case, the heading) has a font-size, which throws off the size of the margin.

Wed, Feb 5, 2:25 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata-Bridge-Sprint-12, Wikidata
Lucas_Werkmeister_WMDE moved T242747: Step 1: bail-out path for novalue/somevalue in the main snak (impact: medium) from To do to Doing on the Wikidata-Bridge-Sprint-13 board.
Wed, Feb 5, 2:11 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE claimed T242747: Step 1: bail-out path for novalue/somevalue in the main snak (impact: medium).
Wed, Feb 5, 2:11 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE added a comment to T243223: Occasional Selenium build failures related to temporary directories / no space left.

Now on integration-agent-docker-1006.

Wed, Feb 5, 2:00 PM · Continuous-Integration-Infrastructure
Lucas_Werkmeister_WMDE moved T235753: Step 1: Bail-out path for unsupported datatypes (impact: high) from Peer Review to Verification on the Wikidata-Bridge-Sprint-13 board.
Wed, Feb 5, 1:47 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata-Bridge-Sprint-12, Wikidata
Lucas_Werkmeister_WMDE moved T244342: Reduce duplication in bail-out errors from Doing to Peer Review on the Wikidata-Bridge-Sprint-13 board.
Wed, Feb 5, 1:44 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244341: Wikibase RDF dump: stop using blank nodes for encoding unknown values and OWL constraints.

And

SELECT ?human
WHERE { ?human wdt:P106 ?o }

Would now mean: All entities with a known occupation
As opposed to All entities with a known or unkown occupation
which should be written as:

SELECT ?human
WHERE { {?human wdt:P106 ?o} union {?human a wdunk:P106} }
Wed, Feb 5, 1:26 PM · Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE claimed T244342: Reduce duplication in bail-out errors.

I have an idea for how to do this, and it seems to work, but I need to wait until the other spacing fixes are merged (currently in gate-and-submit) before I can upload it.

Wed, Feb 5, 1:03 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244019: Inconsistent user permissions for users who were recently added to a new group.

I’d say that’s up to the train… manager? person? Anyways, up to you :)

Wed, Feb 5, 10:50 AM · MediaWiki-User-management
Lucas_Werkmeister_WMDE updated subscribers of T244263: Document when, where and how changes to the API are announced.
Wed, Feb 5, 10:43 AM · Core Platform Team Workboards (Clinic Duty Team), Documentation
Lucas_Werkmeister_WMDE moved T237507: Step 1: Let the user know when they're blocked on the client from To do to Verification on the Wikidata-Bridge-Sprint-13 board.
Wed, Feb 5, 10:37 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Wikidata-Bridge-Sprint-13, Wikidata-Bridge-Sprint-12, Wikidata
Lucas_Werkmeister_WMDE created T244342: Reduce duplication in bail-out errors.
Wed, Feb 5, 10:36 AM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata

Tue, Feb 4

Lucas_Werkmeister_WMDE created T244271: Inputbox input and button can be misaligned due to floating elements.
Tue, Feb 4, 6:34 PM · MediaWiki-extensions-InputBox
Lucas_Werkmeister_WMDE closed T242843: Display UNSUPPORTED_ENTITY_DATA error in ErrorWrapper, a subtask of T235753: Step 1: Bail-out path for unsupported datatypes (impact: high), as Resolved.
Tue, Feb 4, 4:45 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Wikidata-Bridge-Sprint-13, Wikidata-Bridge-Sprint-12, Wikidata
Lucas_Werkmeister_WMDE closed T242843: Display UNSUPPORTED_ENTITY_DATA error in ErrorWrapper as Resolved.
Tue, Feb 4, 4:45 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Wikidata-Bridge-Sprint-13, Wikidata-Bridge-Sprint-12, Wikidata
Lucas_Werkmeister_WMDE added a comment to T238660: Step 1: bail-out path for deprecated main snaks (impact: medium).

Should the heading really be “Editing the value for $property is not supported”? That’s the same heading as for unsupported datatypes (T235753), but in this case, the problem isn’t the property, it’s the particular statement.

Tue, Feb 4, 3:55 PM · Wikidata-Bridge-Sprint-13, Wikidata
Lucas_Werkmeister_WMDE added a comment to T237507: Step 1: Let the user know when they're blocked on the client.

@Lucas_Werkmeister_WMDE do you want to make an extra ticket for this? since this was not part of the initial AC

Tue, Feb 4, 3:47 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Wikidata-Bridge-Sprint-13, Wikidata-Bridge-Sprint-12, Wikidata
Lucas_Werkmeister_WMDE added a comment to T237507: Step 1: Let the user know when they're blocked on the client.

currently looks like this in my browser (firefox)

Tue, Feb 4, 3:36 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Wikidata-Bridge-Sprint-13, Wikidata-Bridge-Sprint-12, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T234804: Aliases are not wrapping nicely (both in reading and editing mode).
Tue, Feb 4, 10:54 AM · Wikidata-Campsite, Regression, WMDE-Design, Design, Wikidata

Mon, Feb 3

Lucas_Werkmeister_WMDE moved T242843: Display UNSUPPORTED_ENTITY_DATA error in ErrorWrapper from Doing to Peer Review on the Wikidata-Bridge-Sprint-13 board.
Mon, Feb 3, 5:34 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Wikidata-Bridge-Sprint-13, Wikidata-Bridge-Sprint-12, Wikidata
Lucas_Werkmeister_WMDE added a comment to T237507: Step 1: Let the user know when they're blocked on the client.

we only pass in a DOM element with the user name, not anything that could be passed into {{GENDER}}.

Mon, Feb 3, 5:30 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Wikidata-Bridge-Sprint-13, Wikidata-Bridge-Sprint-12, Wikidata