Lucas_Werkmeister_WMDE (Lucas Werkmeister (WMDE))
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 3 2017, 2:45 PM (46 w, 3 d)
Availability
Available
IRC Nick
Lucas_WMDE
LDAP User
Unknown
MediaWiki User
Lucas Werkmeister (WMDE)

Recent Activity

Today

Lucas_Werkmeister_WMDE added a comment to T185712: Make Context serializable.

Okay, so how about this:

Fri, Feb 23, 2:17 PM · Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T187876: Improve Graph Explorer on Query.Wikidata.org.

The primary repository is in Gerrit, but the GitHub mirror is wikimedia/wikidata-query-gui. The graph explorer is in GraphResultBrowserNodeBrowser.js, I think (but I’m not quite sure).

Fri, Feb 23, 1:55 PM · Google-Summer-of-Code (2018), Wikidata Query UI
Lucas_Werkmeister_WMDE added a comment to T184812: Enable constraint result caching on Wikidata.

I think we can proceed with this – all the blockers should be addressed, though sometimes temporarily:

Fri, Feb 23, 1:42 PM · Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikidata-Sprint-2018-01-31, Wikidata-Sprint-2018-01-17, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T185712: Make Context serializable.

I don’t fully understand your proposal yet… what would be the use of newFromContext? Would you store the resulting Context object directly in the cache, instead of serializing it into some array form?

Fri, Feb 23, 11:34 AM · Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE closed T187717: Change the default date setting of Timeline View in the Wikidata Query Service as Resolved.

Should be fixed (though not deployed yet).

Fri, Feb 23, 11:18 AM · Patch-For-Review, Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE closed T187057: Constraint check results involving the current time are cached indiscriminately [M], a subtask of T184812: Enable constraint result caching on Wikidata, as Resolved.
Fri, Feb 23, 11:12 AM · Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikidata-Sprint-2018-01-31, Wikidata-Sprint-2018-01-17, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE closed T187057: Constraint check results involving the current time are cached indiscriminately [M] as Resolved.

All subtasks done, should be fixed now.

Fri, Feb 23, 11:12 AM · Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE moved T187186: Use ViolationMessage in ConstraintParameterException from Review to Done on the Wikidata-Sprint-2018-02-14 board.
Fri, Feb 23, 11:12 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE closed T187201: Remove message argument related parts of ConstraintParameterRenderer as Resolved.
Fri, Feb 23, 11:11 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE closed T187201: Remove message argument related parts of ConstraintParameterRenderer, a subtask of T185710: Introduce class for constraint violation messages, as Resolved.
Fri, Feb 23, 11:11 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Wikidata-Sprint-2018-01-31, Wikidata-Sprint-2018-01-17, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE closed T187186: Use ViolationMessage in ConstraintParameterException as Resolved.
Fri, Feb 23, 11:11 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE closed T187186: Use ViolationMessage in ConstraintParameterException, a subtask of T185710: Introduce class for constraint violation messages, as Resolved.
Fri, Feb 23, 11:11 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Wikidata-Sprint-2018-01-31, Wikidata-Sprint-2018-01-17, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T187186: Use ViolationMessage in ConstraintParameterException.
Fri, Feb 23, 11:10 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE moved T187201: Remove message argument related parts of ConstraintParameterRenderer from Review to Done on the Wikidata-Sprint-2018-02-14 board.
Fri, Feb 23, 11:02 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE closed T187061: Don’t cache constraint check results involving current time whose validity will change soon as Resolved.

Nevermind, it works as intended, my cached value was from a version of the code without this fix so it was missing the futureTime indication.

Fri, Feb 23, 10:56 AM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE closed T187061: Don’t cache constraint check results involving current time whose validity will change soon, a subtask of T187057: Constraint check results involving the current time are cached indiscriminately [M], as Resolved.
Fri, Feb 23, 10:56 AM · Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T188046: Simple English localization gets date format from previous localization.

That’s because moment.js doesn’t know about the simple language code, so moment.locale( 'simple' ) doesn’t have any effect and leaves it at the previous locale.

Fri, Feb 23, 10:30 AM · Wikidata Query UI
Lucas_Werkmeister_WMDE added a comment to T187775: Investigation: Constraints for a database schema to store representations of a Lexeme.

(Minor comment – the MediaWiki database coding conventions prefer singular table names, i. e. wbl_lexeme and wbl_lemma. But I don’t know if there’s a different convention within Wikibase.)

Fri, Feb 23, 10:22 AM · Wikidata-Sprint-2018-02-14, Lexicographical data, Wikidata
Lucas_Werkmeister_WMDE added a comment to T187061: Don’t cache constraint check results involving current time whose validity will change soon.

Well, this doesn’t seem to be working completely… I added a “21 February 2018” statement on 20 February 2018, and today, on 23 February 2018, I still see the same violation message:

Fri, Feb 23, 10:12 AM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE reopened T186949: Zuul no longer starts gate-and-submit when parent is in gate-and-submit pipeline as "Open".

For example, this chain (or this change).

Fri, Feb 23, 9:30 AM · Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure, Zuul

Tue, Feb 20

This is a test notification, sent at Tue, Feb 20, 18:01.
Tue, Feb 20, 5:01 PM
Lucas_Werkmeister_WMDE added a comment to T187061: Don’t cache constraint check results involving current time whose validity will change soon.

I think this should be working now, but I’ll try a manual test, just to make sure.

Tue, Feb 20, 4:50 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE created T187802: [AG] Extra quotation mark in background image attributions.
Tue, Feb 20, 4:29 PM · Tool-Attribution-Generator, TCB-Team
Lucas_Werkmeister_WMDE added a comment to T185712: Make Context serializable.

I admit I’m tempted to go with the much simpler … fake EntityDocument …

Tue, Feb 20, 4:22 PM · Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated subscribers of T185712: Make Context serializable.

what do we do?

Tue, Feb 20, 4:16 PM · Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE created T187793: Inject IContextSource into ViolationMessageRenderer.
Tue, Feb 20, 3:33 PM · Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE added a comment to T185712: Make Context serializable.

I’m not sure how this would look – non-static serialize and static deserialize methods on Context and its subclasses? Or should it be a separate kind of ContextSerialization service? I think my colleagues know more about this than me, there’s a lot of serialization going on in Wikibase ;)

Tue, Feb 20, 3:11 PM · Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T187775: Investigation: Constraints for a database schema to store representations of a Lexeme.

There is only one lemma per Lexeme (in only one language)

Tue, Feb 20, 2:44 PM · Wikidata-Sprint-2018-02-14, Lexicographical data, Wikidata
Lucas_Werkmeister_WMDE closed T185711: Make Constraint serializable as Resolved.
Tue, Feb 20, 12:56 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikidata-Sprint-2018-02-14, Patch-For-Review, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE closed T185711: Make Constraint serializable, a subtask of T185709: Cache CheckResult serializations per-entity in ObjectCache, as Resolved.
Tue, Feb 20, 12:56 PM · Wikidata-Sprint-2018-01-31, Wikidata-Sprint-2018-01-17, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE moved T187201: Remove message argument related parts of ConstraintParameterRenderer from In Progress to Review on the Wikidata-Sprint-2018-02-14 board.
Tue, Feb 20, 10:59 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T187061: Don’t cache constraint check results involving current time whose validity will change soon.
Tue, Feb 20, 10:58 AM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata

Mon, Feb 19

Lucas_Werkmeister_WMDE updated the task description for T187061: Don’t cache constraint check results involving current time whose validity will change soon.
Mon, Feb 19, 5:50 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T187186: Use ViolationMessage in ConstraintParameterException.
Mon, Feb 19, 5:46 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T187186: Use ViolationMessage in ConstraintParameterException.
Mon, Feb 19, 5:44 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE moved T185711: Make Constraint serializable from Backlog to Review on the Wikidata-Sprint-2018-02-14 board.
Mon, Feb 19, 5:44 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikidata-Sprint-2018-02-14, Patch-For-Review, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE claimed T185711: Make Constraint serializable.
Mon, Feb 19, 5:44 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikidata-Sprint-2018-02-14, Patch-For-Review, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T186949: Zuul no longer starts gate-and-submit when parent is in gate-and-submit pipeline.

I’m still experiencing the same behavior of changes further up a chain not being automatically submitted… should I open a new task for that?

Mon, Feb 19, 5:41 PM · Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure, Zuul
Lucas_Werkmeister_WMDE committed rWDQG4288a3db6dea: Bring date formatting closer to Wikibase (authored by Lucas_Werkmeister_WMDE).
Bring date formatting closer to Wikibase
Mon, Feb 19, 1:40 PM
Lucas_Werkmeister_WMDE committed rWDQG122a3479811c: Bring date formatting closer to Wikibase (authored by Lucas_Werkmeister_WMDE).
Bring date formatting closer to Wikibase
Mon, Feb 19, 1:31 PM
Lucas_Werkmeister_WMDE added a comment to T187717: Change the default date setting of Timeline View in the Wikidata Query Service.

That’s just the default English date format of moment.js, independent of the timeline view (you see the same format in the table view as well, for example). If you select a different language, you might get a more suitable format (French gets «26 avr. 1779», for example), but I agree that we should change the English format, to match Wikibase itself (“26 April 1779”).

Mon, Feb 19, 1:21 PM · Patch-For-Review, Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T187186: Use ViolationMessage in ConstraintParameterException.
Mon, Feb 19, 12:55 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE moved T187201: Remove message argument related parts of ConstraintParameterRenderer from Backlog to In Progress on the Wikidata-Sprint-2018-02-14 board.
Mon, Feb 19, 12:49 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE claimed T187201: Remove message argument related parts of ConstraintParameterRenderer.
Mon, Feb 19, 12:49 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE claimed T187186: Use ViolationMessage in ConstraintParameterException.
Mon, Feb 19, 12:49 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T187186: Use ViolationMessage in ConstraintParameterException.
Mon, Feb 19, 11:51 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a project to T187652: exportEntityMapping does not work with $wgDBprefix: Wikibase-Quality.
Mon, Feb 19, 10:24 AM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata

Fri, Feb 16

Lucas_Werkmeister_WMDE moved T187186: Use ViolationMessage in ConstraintParameterException from In Progress to Review on the Wikidata-Sprint-2018-02-14 board.
Fri, Feb 16, 5:27 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T187186: Use ViolationMessage in ConstraintParameterException.
Fri, Feb 16, 5:27 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T187186: Use ViolationMessage in ConstraintParameterException.

Regarding the transition period… I’m not sure if we even need to have one. At some point we will have to throw out invalid CPEs, and just doing it up-front shouldn’t hurt too much, I think. We have plenty of other checks that always hit WDQS, so I think a few more queries to WDQS should be acceptable. (Keep in mind that the CPE only happens in the first place in case of an invalid regex, which should be rare.)

Fri, Feb 16, 3:19 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE moved T187061: Don’t cache constraint check results involving current time whose validity will change soon from In Progress to Review on the Wikidata-Sprint-2018-02-14 board.
Fri, Feb 16, 2:54 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T187061: Don’t cache constraint check results involving current time whose validity will change soon.
Fri, Feb 16, 2:54 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T187529: Support non-Gregorian calendars in range checkers.

The conversion for RDF happens in JulianDateTimeValueCleaner – unfortunately, it returns an xsd:dateTime string, which isn’t immediately reusable as a TimeValue timestamp… I hope it won’t be too hard to adapt, though.

Fri, Feb 16, 11:23 AM · Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE created T187529: Support non-Gregorian calendars in range checkers.
Fri, Feb 16, 11:16 AM · Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE added a comment to T187061: Don’t cache constraint check results involving current time whose validity will change soon.

A TimeValue already represents exactly the TimeValue on which that same value changes from being in the future to being in the past!

Fri, Feb 16, 10:53 AM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata

Thu, Feb 15

Lucas_Werkmeister_WMDE added a comment to T187061: Don’t cache constraint check results involving current time whose validity will change soon.

Wait, I’m stupid… this is easy!

Thu, Feb 15, 5:29 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE closed T187058: Introduce separate messages for range violations involving current time as Resolved.
Thu, Feb 15, 4:17 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE closed T187058: Introduce separate messages for range violations involving current time, a subtask of T187057: Constraint check results involving the current time are cached indiscriminately [M], as Resolved.
Thu, Feb 15, 4:17 PM · Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T187061: Don’t cache constraint check results involving current time whose validity will change soon.

Implementation sketch:

Thu, Feb 15, 3:30 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE moved T187061: Don’t cache constraint check results involving current time whose validity will change soon from Backlog to In Progress on the Wikidata-Sprint-2018-02-14 board.
Thu, Feb 15, 1:49 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE claimed T187061: Don’t cache constraint check results involving current time whose validity will change soon.
Thu, Feb 15, 1:49 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T185696: Change default scope of “distinct values” constraint to main snak only.
Thu, Feb 15, 1:45 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Wikidata-Sprint-2018-01-31, Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata

Wed, Feb 14

Lucas_Werkmeister_WMDE moved T187058: Introduce separate messages for range violations involving current time from In Progress to Review on the Wikidata-Sprint-2018-02-14 board.
Wed, Feb 14, 5:05 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE claimed T187057: Constraint check results involving the current time are cached indiscriminately [M].
Wed, Feb 14, 5:05 PM · Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE moved T187058: Introduce separate messages for range violations involving current time from Backlog to In Progress on the Wikidata-Sprint-2018-02-14 board.
Wed, Feb 14, 5:05 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE claimed T187058: Introduce separate messages for range violations involving current time.
Wed, Feb 14, 5:04 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T187303: IRC log browser “could not connect” error.

It’s working for me right now…

Wed, Feb 14, 4:22 PM · WM-Bot
Lucas_Werkmeister_WMDE added a comment to T187314: Display labels for entity values at result visualisation step in Wikibase Query Engine.

I’m not convinced moving labels to the query service UI is the right solution here… most of the problems you describe can be solved instead by optimizing the query, using subqueries to only run the label service very late in the query execution. We even have a task for automating that optimization, T166139.

Wed, Feb 14, 1:48 PM · User-Smalyshev, Wikidata Query UI, Discovery, Wikidata
Lucas_Werkmeister_WMDE edited projects for T187314: Display labels for entity values at result visualisation step in Wikibase Query Engine, added: Wikidata Query UI; removed Wikidata-Query-Service.
Wed, Feb 14, 1:37 PM · User-Smalyshev, Wikidata Query UI, Discovery, Wikidata
Lucas_Werkmeister_WMDE awarded T187052: UrlShortener: Code stewardship review. a Love token.
Wed, Feb 14, 12:54 PM · Code-Stewardship-Reviews, MediaWiki-extensions-UrlShortener
Lucas_Werkmeister_WMDE closed T186008: Remove range in numerical notation from violation messages as Resolved.

Done.

Wed, Feb 14, 12:02 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE closed T186008: Remove range in numerical notation from violation messages, a subtask of T187058: Introduce separate messages for range violations involving current time, as Resolved.
Wed, Feb 14, 12:02 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T187303: IRC log browser “could not connect” error.

Thanks!

Wed, Feb 14, 11:52 AM · WM-Bot
Lucas_Werkmeister_WMDE moved T186008: Remove range in numerical notation from violation messages from In Progress to Review on the Wikidata-Sprint-2018-02-14 board.
Wed, Feb 14, 11:44 AM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE moved T186008: Remove range in numerical notation from violation messages from Backlog to In Progress on the Wikidata-Sprint-2018-02-14 board.
Wed, Feb 14, 11:40 AM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE added a parent task for T186008: Remove range in numerical notation from violation messages: T187058: Introduce separate messages for range violations involving current time.
Wed, Feb 14, 11:39 AM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE added a subtask for T187058: Introduce separate messages for range violations involving current time: T186008: Remove range in numerical notation from violation messages.
Wed, Feb 14, 11:39 AM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a project to T186008: Remove range in numerical notation from violation messages: Wikidata-Sprint-2018-02-14.

Picking this up now because it touches the same messages as T187058: Introduce separate messages for range violations involving current time, so let’s do this part first.

Wed, Feb 14, 11:39 AM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE moved T187186: Use ViolationMessage in ConstraintParameterException from Backlog to Review on the Wikidata-Sprint-2018-02-14 board.
Wed, Feb 14, 10:59 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T187186: Use ViolationMessage in ConstraintParameterException.
Wed, Feb 14, 10:49 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE created T187303: IRC log browser “could not connect” error.
Wed, Feb 14, 10:31 AM · WM-Bot

Tue, Feb 13

Lucas_Werkmeister_WMDE added a comment to T187186: Use ViolationMessage in ConstraintParameterException.

Actually, the transition period will have to be a bit longer, since we need to support pre-rendered messages out of the SparqlHelper regexp cache for at least the duration of one deployment. And in fact we might need to find some mechanism to explicitly evict such old entries, otherwise the more commonly used ones might stay in cache for a long time.

Tue, Feb 13, 5:11 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE moved T185999: Make ViolationMessage serializable from Review to Done on the Wikidata-Sprint-2018-01-31 board.
Tue, Feb 13, 5:03 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Wikidata-Sprint-2018-01-31, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE closed T185999: Make ViolationMessage serializable as Resolved.

Should be done now. Injecting a serialize and deserializer where needed can be done as part of other tasks.

Tue, Feb 13, 4:59 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Wikidata-Sprint-2018-01-31, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE closed T185999: Make ViolationMessage serializable, a subtask of T185710: Introduce class for constraint violation messages, as Resolved.
Tue, Feb 13, 4:59 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Wikidata-Sprint-2018-01-31, Wikidata-Sprint-2018-01-17, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T185999: Make ViolationMessage serializable.
Tue, Feb 13, 4:53 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Wikidata-Sprint-2018-01-31, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T168240: WBQC test improvements.

We still have some uses of JsonEntityLookup in the tests, so that part of the original task description is still open. Apart from that, I’ve kinda been using this task as a catch-all for various stuff I did in the tests… not sure if that makes sense.

Tue, Feb 13, 3:34 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE closed T185710: Introduce class for constraint violation messages as Resolved.

Closing this – the checkers all use ViolationMessage now, and we have dedicated subtasks for the rest that needs to be done.

Tue, Feb 13, 2:46 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Wikidata-Sprint-2018-01-31, Wikidata-Sprint-2018-01-17, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE closed T185710: Introduce class for constraint violation messages, a subtask of T185709: Cache CheckResult serializations per-entity in ObjectCache, as Resolved.
Tue, Feb 13, 2:46 PM · Wikidata-Sprint-2018-01-31, Wikidata-Sprint-2018-01-17, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T185710: Introduce class for constraint violation messages.
Tue, Feb 13, 2:45 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Wikidata-Sprint-2018-01-31, Wikidata-Sprint-2018-01-17, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE triaged T187202: Remove injected ConstraintParameterRenderer from checkers and helpers as Normal priority.
Tue, Feb 13, 2:44 PM · Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE triaged T187201: Remove message argument related parts of ConstraintParameterRenderer as Normal priority.
Tue, Feb 13, 2:42 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T187186: Use ViolationMessage in ConstraintParameterException.
Tue, Feb 13, 2:35 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T187186: Use ViolationMessage in ConstraintParameterException.
Tue, Feb 13, 2:34 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Wikidata-Sprint-2018-02-14, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T187199: Remove support for plain string messages from ViolationMessageRenderer.
Tue, Feb 13, 2:33 PM · Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T185999: Make ViolationMessage serializable.
Tue, Feb 13, 12:57 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Wikidata-Sprint-2018-01-31, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE added a comment to T186949: Zuul no longer starts gate-and-submit when parent is in gate-and-submit pipeline.

Hm, but now when I poked this change, the next one also got gate-and-submit. Did you change anything to fix this? :)

Tue, Feb 13, 12:52 PM · Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure, Zuul
Lucas_Werkmeister_WMDE added a comment to T186949: Zuul no longer starts gate-and-submit when parent is in gate-and-submit pipeline.

Same thing seems to happen in this chain as well – later changes in the chain that already had a +2 didn’t move into gate-and-submit when the base change got +2ed.

Tue, Feb 13, 12:42 PM · Release-Engineering-Team (Kanban), Continuous-Integration-Infrastructure, Zuul
Lucas_Werkmeister_WMDE updated the task description for T185999: Make ViolationMessage serializable.
Tue, Feb 13, 11:51 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Wikidata-Sprint-2018-01-31, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE moved T185710: Introduce class for constraint violation messages from Review to Backlog on the Wikidata-Sprint-2018-01-31 board.
Tue, Feb 13, 11:08 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Wikidata-Sprint-2018-01-31, Wikidata-Sprint-2018-01-17, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata