Page MenuHomePhabricator

Lucas_Werkmeister_WMDE (Lucas Werkmeister (WMDE))
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 3 2017, 2:45 PM (214 w, 4 d)
Availability
Available
IRC Nick
Lucas_WMDE
LDAP User
Lucas Werkmeister (WMDE)
MediaWiki User
Lucas Werkmeister (WMDE) [ Global Accounts ]

Software developer on the Wikidata team at Wikimedia Germany (he/him, Berlin timezone). Private account: @LucasWerkmeister.

Recent Activity

Today

Lucas_Werkmeister_WMDE moved T282564: Move some validation of properties for the payload from EditEndpoint to EditRequest from Doing to Review on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.

https://github.com/wmde/WikibaseReconcileEdit/pull/26

Fri, May 14, 5:09 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE claimed T282564: Move some validation of properties for the payload from EditEndpoint to EditRequest .
Fri, May 14, 1:41 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE added a comment to T282564: Move some validation of properties for the payload from EditEndpoint to EditRequest .

Hm, on second thought, I’m not sure EditRequest / UrlInputEditRequest itself is the best place for all this parsing logic. Parsing the request requires some services (at least propertyDataTypeLookup, maybe also fullWikibaseItemInput and minimalItemInput), but if the parsing happens in a class that also gets the request as a constructor parameter, then we can’t add that class to the service container (since there we don’t have the request yet), and instead EditEndpoint will awkwardly have to pass the services to it.

Fri, May 14, 1:22 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE updated the task description for T282859: Investigate using Ansible-Roles for cloud deployment.
Fri, May 14, 11:56 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE removed a project from T282859: Investigate using Ansible-Roles for cloud deployment: Epic.
Fri, May 14, 11:24 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE added a comment to T278026: Rename DB_MASTER to DB_PRIMARY.

There are also several ILoadBalancer methods with “master”:

Fri, May 14, 11:00 AM · User-Majavah, MW-1.31-release-notes, MW-1.35-notes, MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Patch-For-Review, MW-1.36-release, Platform Team Workboards (Clinic Duty Team), MW-1.31-release, MW-1.35-release, Wikimedia-Rdbms, Voice & Tone
Lucas_Werkmeister_WMDE added a comment to T204792: [20h] Why is the url key undefined in language objects for categories?.

Thanks. I’ll copy one comment here, since it seems more relevant for anyone else looking at this task (emphasis mine):

Fri, May 14, 10:27 AM · Platform Team Workboards (MW Expedition), wdwb-tech, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Readers-Web-Backlog (Tracking), Wikidata, Wikimedia-production-error
Lucas_Werkmeister_WMDE added a subtask for T282233: Refactor existing codebase: T282564: Move some validation of properties for the payload from EditEndpoint to EditRequest .
Fri, May 14, 10:19 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE added a parent task for T282564: Move some validation of properties for the payload from EditEndpoint to EditRequest : T282233: Refactor existing codebase.
Fri, May 14, 10:19 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE added a comment to T282564: Move some validation of properties for the payload from EditEndpoint to EditRequest .

It’s not yet clear to me how error handling is supposed to work in the MediaWiki REST API. A REST handler itself (Handler subclass) is supposed to throw an HttpException, ideally a LocalizedHttpException, to return an HTTP error response, ideally with a localized error message. That’s what we currently do (at least insofar as we’ve converted die() calls to those exceptions, see T281804). But what are classes which are used by a REST handler supposed to do?

Fri, May 14, 9:43 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282854: Move PHPUnit tests below tests/phpunit/ from Doing to Review on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.

https://github.com/wmde/WikibaseReconcileEdit/pull/24

Fri, May 14, 9:21 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE claimed T282854: Move PHPUnit tests below tests/phpunit/.
Fri, May 14, 9:18 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE created T282854: Move PHPUnit tests below tests/phpunit/.
Fri, May 14, 9:12 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282851: Remove MockEditDiskRequest from Doing to Review on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.

https://github.com/wmde/WikibaseReconcileEdit/pull/23

Fri, May 14, 9:01 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE claimed T282851: Remove MockEditDiskRequest.
Fri, May 14, 8:48 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE created T282851: Remove MockEditDiskRequest.
Fri, May 14, 8:46 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE closed T282244: Inject Wikibase services into WikibaseReconcileEdit classes as Resolved.

This is done now, as far as I can tell.

Fri, May 14, 8:33 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE closed T282244: Inject Wikibase services into WikibaseReconcileEdit classes, a subtask of T282233: Refactor existing codebase, as Resolved.
Fri, May 14, 8:33 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282553: Try swapping EntityRevisionLookup with EntityLookup to replace TODO in ReconciliationService from Review to Done on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.
Fri, May 14, 8:22 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282551: Add unit tests for WikibaseReconcileEditServices from Review to Done on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.
Fri, May 14, 8:22 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282650: Compare el_to in ExternalLinks from Verify to Done on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.
Fri, May 14, 8:22 AM · wdwb-tech (wdwb-tech (small tasks)), Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)

Wed, May 12

Lucas_Werkmeister_WMDE moved T282244: Inject Wikibase services into WikibaseReconcileEdit classes from Review to Doing on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.
Wed, May 12, 3:20 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282553: Try swapping EntityRevisionLookup with EntityLookup to replace TODO in ReconciliationService from Doing to Review on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.

https://github.com/wmde/WikibaseReconcileEdit/pull/21

Wed, May 12, 3:19 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE claimed T282553: Try swapping EntityRevisionLookup with EntityLookup to replace TODO in ReconciliationService.
Wed, May 12, 2:52 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE added a subtask for T282233: Refactor existing codebase: T282553: Try swapping EntityRevisionLookup with EntityLookup to replace TODO in ReconciliationService.
Wed, May 12, 2:47 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE added a parent task for T282553: Try swapping EntityRevisionLookup with EntityLookup to replace TODO in ReconciliationService: T282233: Refactor existing codebase.
Wed, May 12, 2:47 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282412: Inject dependencies into SimplePutStrategy from Doing to Review on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.

https://github.com/wmde/WikibaseReconcileEdit/pull/20

Wed, May 12, 2:42 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282408: Split SimplePutStrategy into separate service from Doing to Review on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.

https://github.com/wmde/WikibaseReconcileEdit/pull/20

Wed, May 12, 2:42 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE claimed T282412: Inject dependencies into SimplePutStrategy.
Wed, May 12, 2:37 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE claimed T282408: Split SimplePutStrategy into separate service.
Wed, May 12, 2:19 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282650: Compare el_to in ExternalLinks from Review to Verify on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.
Wed, May 12, 2:13 PM · wdwb-tech (wdwb-tech (small tasks)), Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE added a comment to T144248: No RDF builder defined for data type globe-coordinate nor for value type bad in DispatchingValueSnakRdfBuilder::getValueBuilder.

Come up with a plan of attack for the malformed values & get them out of the existing revisions set

Wed, May 12, 1:32 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wdwb-tech, Regression, DataValues, Wikidata-Sprint-2016-09-21, MediaWiki-extensions-WikibaseRepository, Wikidata, Wikimedia-production-error
Lucas_Werkmeister_WMDE moved T282244: Inject Wikibase services into WikibaseReconcileEdit classes from Doing to Review on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.
Wed, May 12, 12:38 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE added a comment to T282244: Inject Wikibase services into WikibaseReconcileEdit classes.

Minor improvement: https://github.com/wmde/WikibaseReconcileEdit/pull/19

Wed, May 12, 12:38 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE closed T281874: Set up CI for WikibaseReconcileEdit as Resolved.
Wed, May 12, 9:48 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)

Tue, May 11

Lucas_Werkmeister_WMDE added a comment to T282232: Reconcile Item Statement Values.

WIP at https://github.com/wmde/WikibaseReconcileEdit/pull/17

Tue, May 11, 3:28 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE closed T282243: Split up EditEndpoint.php reconciliation logic into its own service as Resolved.
Tue, May 11, 1:45 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE closed T282243: Split up EditEndpoint.php reconciliation logic into its own service, a subtask of T282233: Refactor existing codebase, as Resolved.
Tue, May 11, 1:45 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282551: Add unit tests for WikibaseReconcileEditServices from Doing to Review on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.

https://github.com/wmde/WikibaseReconcileEdit/pull/16

Tue, May 11, 1:29 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE claimed T282551: Add unit tests for WikibaseReconcileEditServices.
Tue, May 11, 1:13 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE created T282551: Add unit tests for WikibaseReconcileEditServices.
Tue, May 11, 1:11 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE closed T282411: Inject dependencies into FullWikibaseItemInput and MinimalItemInput as Resolved.
Tue, May 11, 11:07 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE closed T282411: Inject dependencies into FullWikibaseItemInput and MinimalItemInput, a subtask of T282244: Inject Wikibase services into WikibaseReconcileEdit classes, as Resolved.
Tue, May 11, 11:07 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE closed T282409: Refactor FullWikibaseItemInput & MinimalItemInput into services as Resolved.
Tue, May 11, 11:07 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE closed T282409: Refactor FullWikibaseItemInput & MinimalItemInput into services, a subtask of T282233: Refactor existing codebase, as Resolved.
Tue, May 11, 11:07 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE closed T282437: Inject TitleFactory into EditEndpoint and use it efficiently, a subtask of T282233: Refactor existing codebase, as Resolved.
Tue, May 11, 9:43 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE closed T282437: Inject TitleFactory into EditEndpoint and use it efficiently as Resolved.
Tue, May 11, 9:43 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE added a comment to T281874: Set up CI for WikibaseReconcileEdit.

CI can be seen in action here: https://github.com/wmde/WikibaseReconcileEdit/actions/

Tue, May 11, 7:53 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)

Mon, May 10

Lucas_Werkmeister_WMDE moved T282437: Inject TitleFactory into EditEndpoint and use it efficiently from Doing to Review on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.

https://github.com/wmde/WikibaseReconcileEdit/pull/15

Mon, May 10, 3:36 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE claimed T282437: Inject TitleFactory into EditEndpoint and use it efficiently.
Mon, May 10, 3:16 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE added a comment to T282232: Reconcile Item Statement Values.

This task is blocked by T282233: Refactor existing codebase

Mon, May 10, 1:58 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE created T282437: Inject TitleFactory into EditEndpoint and use it efficiently.
Mon, May 10, 11:00 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282101: Namespaces not following PSR4 from Backlog to OPEN!NEXT Hike Sprint 1 on the Wikibase OPEN!NEXT board.
Mon, May 10, 10:56 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE committed rEPS277ff02acca4: Get EntityLookup directly from WikibaseRepo (authored by Lucas_Werkmeister_WMDE).
Get EntityLookup directly from WikibaseRepo
Mon, May 10, 10:37 AM
Lucas_Werkmeister_WMDE added a comment to T282232: Reconcile Item Statement Values.

Without this task, the second payload would have to look like this:

Mon, May 10, 10:37 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE added a comment to T282232: Reconcile Item Statement Values.

Example scenario: suppose the wiki has two properties, P1 and P2. P1 has type URL, and that URL is used for reconciliation, and P2 has type Item.

Mon, May 10, 10:33 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282244: Inject Wikibase services into WikibaseReconcileEdit classes from Sprint Backlog to Doing on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.
Mon, May 10, 10:08 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T281798: Add end to end integration test for WikibaseReconcileEdit API from Sprint Backlog to Verify on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.
Mon, May 10, 10:08 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T281804: Replace die() with proper error reporting from Sprint Backlog to Doing on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.
Mon, May 10, 10:08 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T281874: Set up CI for WikibaseReconcileEdit from Sprint Backlog to Verify on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.
Mon, May 10, 10:08 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282243: Split up EditEndpoint.php reconciliation logic into its own service from Sprint Backlog to Doing on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.
Mon, May 10, 10:08 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282409: Refactor FullWikibaseItemInput & MinimalItemInput into services from Sprint Backlog to Review on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.
Mon, May 10, 10:08 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282411: Inject dependencies into FullWikibaseItemInput and MinimalItemInput from Sprint Backlog to Review on the Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1) board.
Mon, May 10, 10:08 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282411: Inject dependencies into FullWikibaseItemInput and MinimalItemInput from Doing to Ready for Review on the Wikibase OPEN!NEXT board.

https://github.com/wmde/WikibaseReconcileEdit/pull/13

Mon, May 10, 9:55 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T282409: Refactor FullWikibaseItemInput & MinimalItemInput into services from Doing to Ready for Review on the Wikibase OPEN!NEXT board.

https://github.com/wmde/WikibaseReconcileEdit/pull/13

Mon, May 10, 9:55 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE claimed T282411: Inject dependencies into FullWikibaseItemInput and MinimalItemInput.
Mon, May 10, 9:41 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE claimed T282409: Refactor FullWikibaseItemInput & MinimalItemInput into services.
Mon, May 10, 9:31 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE created T282412: Inject dependencies into SimplePutStrategy.
Mon, May 10, 9:24 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE created T282411: Inject dependencies into FullWikibaseItemInput and MinimalItemInput.
Mon, May 10, 9:24 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE added a comment to T170401: Ignore deprecated statements when checking “type” and “value type” constraints.

But I worry that replacing wdt:P279 with (p:P279/ps:P279) will also degrade performance significantly.

Mon, May 10, 8:39 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE moved T282244: Inject Wikibase services into WikibaseReconcileEdit classes from Verification to Doing on the Wikibase OPEN!NEXT board.

Not done yet IMHO (but waiting for T282243 for now).

Mon, May 10, 8:35 AM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)

Fri, May 7

Lucas_Werkmeister_WMDE added a comment to T282222: SPARQL query for all painting stopped returning results.

The above log message notwithstanding, this still seems to be happening (and still with x-served-by: wdqs1012). I assume it’s not related to any particular query, but in case it is, I last saw it with https://w.wiki/3H$A (source).

Fri, May 7, 4:06 PM · Wikidata, Wikidata-Query-Service
Lucas_Werkmeister_WMDE moved T282244: Inject Wikibase services into WikibaseReconcileEdit classes from Doing to Ready for Review on the Wikibase OPEN!NEXT board.
Fri, May 7, 3:17 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE added a comment to T282244: Inject Wikibase services into WikibaseReconcileEdit classes.

First pull request, for EditEndpoint, is at https://github.com/wmde/WikibaseReconcileEdit/pull/11; I think injecting services into other classes (FullWikibaseItemInput/MinimalItemInput, SimplePutStrategy) needs to wait until those classes themselves have been moved to the service container (T282243).

Fri, May 7, 3:17 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE claimed T282244: Inject Wikibase services into WikibaseReconcileEdit classes.
Fri, May 7, 2:28 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE created T282244: Inject Wikibase services into WikibaseReconcileEdit classes.
Fri, May 7, 2:27 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE placed T281804: Replace die() with proper error reporting up for grabs.

Not done yet.

Fri, May 7, 1:20 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE added a comment to T170401: Ignore deprecated statements when checking “type” and “value type” constraints.

I don’t think that’s possible in SPARQL…

Fri, May 7, 11:52 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE updated subscribers of T282222: SPARQL query for all painting stopped returning results.

CC @RKemper according to the wdqs1012 SAL (related to T280382 apparently)

Fri, May 7, 9:32 AM · Wikidata, Wikidata-Query-Service
Lucas_Werkmeister_WMDE added a comment to T282222: SPARQL query for all painting stopped returning results.

When I run the query, I get the header:

Fri, May 7, 9:31 AM · Wikidata, Wikidata-Query-Service
Lucas_Werkmeister_WMDE added a comment to T280230: Query Builder top banner.

Should this appear on all installations of the query service UI, or only on query.wikidata.org? I feel like it should be specific to WDQS, but the current Gerrit change doesn’t make that configurable.

Fri, May 7, 8:36 AM · Patch-For-Review, Wikidata, Wikidata Query Builder
Lucas_Werkmeister_WMDE added a comment to T170401: Ignore deprecated statements when checking “type” and “value type” constraints.

What if there are normal-rank and preferred-rank “subclass of” statements on the same item? The query service implementation would only use the preferred-rank statements – should the PHP version do the same?

Fri, May 7, 8:13 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata

Thu, May 6

Lucas_Werkmeister_WMDE moved T281798: Add end to end integration test for WikibaseReconcileEdit API from Doing to Ready for Review on the Wikibase OPEN!NEXT board.

https://github.com/wmde/WikibaseReconcileEdit/pull/7

Thu, May 6, 4:17 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE claimed T281798: Add end to end integration test for WikibaseReconcileEdit API.
Thu, May 6, 4:02 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE moved T281874: Set up CI for WikibaseReconcileEdit from Ready for Review to Verification on the Wikibase OPEN!NEXT board.
Thu, May 6, 3:32 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE awarded T279829: Enable magic word SHORTDESC on German-language Wikipedia a Dislike token.
Thu, May 6, 3:31 PM · User-Urbanecm, User-Luke081515, wdwb-tech, Wikidata, Wikimedia-Site-requests
Lucas_Werkmeister_WMDE added a comment to T268791: Allow Api-User-Agent header in API Gateway requests.

Does this task also cover the MediaWiki REST API?

Thu, May 6, 3:22 PM · Platform Team Initiatives (API Gateway)
Lucas_Werkmeister_WMDE moved T281804: Replace die() with proper error reporting from Doing to Ready for Review on the Wikibase OPEN!NEXT board.
Thu, May 6, 3:05 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)

Wed, May 5

Lucas_Werkmeister_WMDE closed T237639: dispatchChanges.php accesses setting that’s not set in default Wikibase config as Resolved.

Fixed by @hoo in If5908d09c2 just a week ago, as it happens :)

Wed, May 5, 3:36 PM · Wikidata
Lucas_Werkmeister_WMDE claimed T281804: Replace die() with proper error reporting.

I’ll get started on this, but I think this can be done in several parts, given that the die() calls are currently a bit scattered across the codebase.

Wed, May 5, 3:05 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE closed T281796: Update WikibaseReconcileEdit for latest state of service migration as Declined.

We’re targeting REL1_35, at least for now, so there’s no Wikibase services to use.

Wed, May 5, 2:06 PM · Wikibase OPEN!NEXT
Lucas_Werkmeister_WMDE created T281985: Enable eslint rules for wikidata/query/gui.git.
Wed, May 5, 1:41 PM · wdwb-tech, Wikidata, Wikidata Query UI
Lucas_Werkmeister_WMDE added a comment to T262489: Multiple TypeError: wikibase.quality is undefined errors on page load.

I can still reproduce it by visiting https://commons.m.wikimedia.org/wiki/File:%27%27Newspaper_Reader%27%27_by_J._Seward_Johnson_Jr._(1975).jpg. Note that the message are classified as warnings in the console, not errors, so you might need to tweak the console settings so they’re not hidden.

Wed, May 5, 9:34 AM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, wdwb-tech, Wikidata, JavaScript, Wikimedia-production-error, WikibaseMediaInfo

Tue, May 4

Lucas_Werkmeister_WMDE added a comment to T281874: Set up CI for WikibaseReconcileEdit.

Probably requires us to know which MediaWiki/Wikibase version we’re targeting (1.36? master? 1.35?).

Tue, May 4, 2:32 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE created T281874: Set up CI for WikibaseReconcileEdit.
Tue, May 4, 2:32 PM · Wikibase OPEN!NEXT (OPEN!NEXT Hike Sprint 1)
Lucas_Werkmeister_WMDE added a project to T262489: Multiple TypeError: wikibase.quality is undefined errors on page load: Wikibase-Quality-Constraints.
Tue, May 4, 10:27 AM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, wdwb-tech, Wikidata, JavaScript, Wikimedia-production-error, WikibaseMediaInfo
Lucas_Werkmeister_WMDE updated the task description for T262489: Multiple TypeError: wikibase.quality is undefined errors on page load.
Tue, May 4, 10:26 AM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, wdwb-tech, Wikidata, JavaScript, Wikimedia-production-error, WikibaseMediaInfo
Lucas_Werkmeister_WMDE updated the task description for T277464: Multiple Wikibase service wiring tests fail when run as unit tests.
Tue, May 4, 9:47 AM · Wikidata-Campsite, wdwb-tech, MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Wikibase Service Migration, Wikidata
Lucas_Werkmeister_WMDE closed T281341: Migrate TermInLangIdsResolver to service container as Resolved.
Tue, May 4, 9:45 AM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Wikidata, Wikibase Service Migration
Lucas_Werkmeister_WMDE updated the task description for T277731: WikibaseRepo + WikibaseClient: Remove SingleEntitySourceServicesFactory Service.
Tue, May 4, 9:45 AM · Wikidata-Campsite, wdwb-tech, Wikidata, Wikibase Service Migration