Page MenuHomePhabricator

Lucas_Werkmeister_WMDE (Lucas Werkmeister (WMDE))
closing tasks for open data

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 3 2017, 2:45 PM (311 w, 5 d)
Availability
Available
IRC Nick
Lucas_WMDE
LDAP User
Lucas Werkmeister (WMDE)
MediaWiki User
Lucas Werkmeister (WMDE) [ Global Accounts ]

Software developer on the Wikidata team at Wikimedia Germany (he/him, Berlin timezone). Private account: @LucasWerkmeister.

Recent Activity

Fri, Mar 24

Lucas_Werkmeister_WMDE added a comment to T332575: Chore: Update dependencies in Query Builder.

If there are open Addbot patches

Fri, Mar 24, 3:50 PM · Patch-For-Review, User-Michael, Wikidata Dev Team (Sprint-∞), Wikidata Query Builder, wdwb-tech, wmde-wikidata-tech, Wikidata
Lucas_Werkmeister_WMDE closed T332999: 404 on https://mismatch-finder.toolforge.org/ as Resolved.

Apparently the GitHub action deploying the new version had a strange error (both in the “staging” and “production” runs):

image.png (148×530 px, 26 KB)

Fri, Mar 24, 2:44 PM · Mismatch Finder, Wikidata, Wikidata Dev Team
Lucas_Werkmeister_WMDE added a comment to T214068: Display Zuul status of jobs for a change on Gerrit UI.

Very cool, thank you!

Fri, Mar 24, 9:37 AM · Patch-For-Review, Release-Engineering-Team (Seen), Gerrit, Zuul, Continuous-Integration-Infrastructure
Lucas_Werkmeister_WMDE updated the task description for T332941: Warning: SQLPlatform::isWriteQuery fallback to regex (from Wikibase EntityUsageTable).
Fri, Mar 24, 9:03 AM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), wdwb-tech, Wikidata, MediaWiki-extensions-WikibaseClient, Performance-Team (Radar)
Lucas_Werkmeister_WMDE added a project to T332941: Warning: SQLPlatform::isWriteQuery fallback to regex (from Wikibase EntityUsageTable): wdwb-tech.
Fri, Mar 24, 9:00 AM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), wdwb-tech, Wikidata, MediaWiki-extensions-WikibaseClient, Performance-Team (Radar)

Thu, Mar 23

Lucas_Werkmeister_WMDE added a comment to T328148: LangSelector added to Query Builder.

Oh, I didn’t realize that the branch-deploy npm script runs as part of CI test builds. You should be able to see the language selector here, then: https://901247--clicky-sparqly.netlify.app/

Thu, Mar 23, 4:25 PM · Patch-For-Review, Wikidata Dev Team (Sprint-∞), Wikidata Query Builder, Wikidata
Lucas_Werkmeister_WMDE added a comment to T328148: LangSelector added to Query Builder.

We intentionally haven’t deployed it to https://query.wikidata.org/querybuilder/ yet. I guess the easiest way to verify it would be via Netlify, similar to T324653, but I don’t know how to publish it there.

Thu, Mar 23, 4:04 PM · Patch-For-Review, Wikidata Dev Team (Sprint-∞), Wikidata Query Builder, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T332881: [Session] Improve your technical writing.
Thu, Mar 23, 1:55 PM · Wikimedia-Hackathon-2023
Lucas_Werkmeister_WMDE updated the task description for T332876: [Session] What i've learned from being a Wikimedia tool dev for nine years.
Thu, Mar 23, 1:55 PM · Wikimedia-Hackathon-2023
Lucas_Werkmeister_WMDE renamed T293259: Make EntityId (ItemId etc.) not equal to its serialization by changing its string representation from Make EntityId not equal to its serialization to Make EntityId (ItemId etc.) not equal to its serialization by changing its string representation.
Thu, Mar 23, 11:41 AM · Sustainability (Incident Followup), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE added a comment to T329167: Wikibase Repository: The collapse button in sitelinks view become invisible, overlapped by the sitelinks heading.

Change 897906 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Move sitelinks collapse toggle into heading using placeholder

https://gerrit.wikimedia.org/r/897906

Thu, Mar 23, 11:12 AM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Wikidata Dev Team, Patch-For-Review, good first task, User-ItamarWMDE, patch-welcome, Wikidata, MediaWiki-extensions-WikibaseRepository
Lucas_Werkmeister_WMDE updated the task description for T332079: [Session] IP Masking.
Thu, Mar 23, 10:47 AM · Wikimedia-Hackathon-2023

Wed, Mar 22

Lucas_Werkmeister_WMDE added a comment to T332702: Ensure content languages are sorted by language code.

Change 901555 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] WIP: Ensure content languages are sorted by language code

https://gerrit.wikimedia.org/r/901555

Wed, Mar 22, 1:39 PM · Wikidata Dev Team, Patch-For-Review, Wikidata, Wikidata-Campsite

Tue, Mar 21

Lucas_Werkmeister_WMDE added a subtask for T319381: Replace or remove deprecated mediawiki.ui Less variables: T332608: Review EntitySchema change to replace 'mediawiki.ui/variables' call with skin variables.
Tue, Mar 21, 4:00 PM · UploadWizard, Patch-For-Review, MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), Design-Systems-Team, Growth-Team, RelatedArticles, GrowthExperiments, CirrusSearch, MediaWiki-extensions-GettingStarted, Page-Previews, ContentTranslation, good first task, CSS
Lucas_Werkmeister_WMDE added a parent task for T332608: Review EntitySchema change to replace 'mediawiki.ui/variables' call with skin variables: T319381: Replace or remove deprecated mediawiki.ui Less variables.
Tue, Mar 21, 3:59 PM · Wikidata Dev Team, wdwb-tech, Shape Expressions, Wikidata
Lucas_Werkmeister_WMDE committed R2307:ba986e3595ce: Add .mailmap file (authored by Lucas_Werkmeister_WMDE).
Add .mailmap file
Tue, Mar 21, 12:21 PM
Lucas_Werkmeister_WMDE committed R2307:66765dcae622: Merge branch 'peterbowman-master-patch-61675' into 'master' (authored by Lucas_Werkmeister_WMDE).
Merge branch 'peterbowman-master-patch-61675' into 'master'
Tue, Mar 21, 11:53 AM

Mon, Mar 20

Lucas_Werkmeister_WMDE moved T328148: LangSelector added to Query Builder from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board.

The basic query builder is merged; still missing are keyboard navigation, possibly further mobile / RTL changes, and also probably saving the selected language in local storage (or a cookie or whatever).

Mon, Mar 20, 6:12 PM · Patch-For-Review, Wikidata Dev Team (Sprint-∞), Wikidata Query Builder, Wikidata
Lucas_Werkmeister_WMDE closed T331309: QueryBuilder: Wire query parameter uselang to LanguageSelector button in QB as Resolved.

This turned out to happen naturally as part of T328148: LangSelector added to Query Builder; Add autonym in Language Selector Button includes a test for it.

Mon, Mar 20, 6:09 PM · Wikidata Dev Team (Sprint-∞), Wikidata
Lucas_Werkmeister_WMDE closed T331309: QueryBuilder: Wire query parameter uselang to LanguageSelector button in QB, a subtask of T328764: Implement custom LanguageSelector component, as Resolved.
Mon, Mar 20, 6:09 PM · Wikidata Dev Team (Sprint-∞), Wikidata
Lucas_Werkmeister_WMDE added a comment to T299077: CI job wmf-quibble-selenium-php72-docker get a deadlock on `change_tag_def` (NameTableStore).

Hm, if this is still happening according to T332540 after the above change was merged, then that might not have been enough to fix the issue :(

Mon, Mar 20, 6:05 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), wdwb-tech, Wikidata, MediaWiki-extensions-WikibaseClient, Browser-Tests, MediaWiki-Core-Tests, ci-test-error
Lucas_Werkmeister_WMDE removed a project from T332609: Reconsider using Husky in EntitySchema extension: Wikidata Analytics.
Mon, Mar 20, 4:31 PM · Wikidata, Wikidata Dev Team, wdwb-tech, Shape Expressions
Lucas_Werkmeister_WMDE added a comment to T332609: Reconsider using Husky in EntitySchema extension.

We currently use Husky v1, which installs itself by generating a script for every possible Git hook in .git/hooks/, silently overwriting any already existing hook there. The latest version is v8, which works differently: it changes the core.hooksPath Git config to point to .husky (see this blog post for details), which turns the hook in .git/hooks/commit-msg into dead code.

Mon, Mar 20, 4:28 PM · Wikidata, Wikidata Dev Team, wdwb-tech, Shape Expressions
Lucas_Werkmeister_WMDE created T332609: Reconsider using Husky in EntitySchema extension.
Mon, Mar 20, 4:25 PM · Wikidata, Wikidata Dev Team, wdwb-tech, Shape Expressions
Lucas_Werkmeister_WMDE created T332608: Review EntitySchema change to replace 'mediawiki.ui/variables' call with skin variables.
Mon, Mar 20, 4:19 PM · Wikidata Dev Team, wdwb-tech, Shape Expressions, Wikidata
Lucas_Werkmeister_WMDE reopened T332123: Ambiguous month names in Mooré/Mossi (mos) and Setswana/Tswana (tn) as "Open".

Mossi is fixed (good), but Tswana is still open AFAICT.

Mon, Mar 20, 10:19 AM · MediaWiki-Internationalization, I18n
Lucas_Werkmeister_WMDE added a comment to T332510: Show an example of a correct value in regex constraint violation messages.

Regex Format constraints currently show only the regex.

Mon, Mar 20, 10:17 AM · Wikidata, Wikibase-Quality-Constraints

Thu, Mar 16

Lucas_Werkmeister_WMDE added a comment to T331621: CI: Don't show PHPUnit progress.

Depending on how we implement a no-verbose-printing-by-default setup, you could set something like putenv( 'MW_PHPUNIT_VERBOSE="1"' ) somewhere in Wikibase's setup code when debugging a task, to swtich back on the dot printing. Would that be acceptable?

Thu, Mar 16, 5:13 PM · Patch-For-Review, MediaWiki-Core-Tests, Developer Productivity
Lucas_Werkmeister_WMDE created T332330: Rename classes / files from Schema to EntitySchema.
Thu, Mar 16, 5:04 PM · wmde-wikidata-tech, Wikidata, Shape Expressions
Lucas_Werkmeister_WMDE closed T312359: [ES-M1] Migrate usage of Database::select to SelectQueryBuilder in EntitySchema as Resolved.

I tried updating the ->update() call in SqlIdGenerator, but ran into problems (T332329). I think we can consider this task done in the meantime; git grep -Fe '->select' doesn’t find any remaining unconverted uses.

Thu, Mar 16, 4:20 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Shape Expressions (M1: technical preparation), Wikidata Dev Team (Sprint-∞), wmde-wikidata-tech, Wikidata, wdwb-tech, Technical-Debt
Lucas_Werkmeister_WMDE closed T312359: [ES-M1] Migrate usage of Database::select to SelectQueryBuilder in EntitySchema, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Resolved.
Thu, Mar 16, 4:19 PM · MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Lucas_Werkmeister_WMDE added a comment to T332329: UpdateQueryBuilder does not support IDatabase::ALL_ROWS updates.

It turns out that SelectQueryBuilder also doesn’t support ->where( $dbr::ALL_ROWS ), though it’s not as much of a problem there because you can just omit the ->where() call.

Thu, Mar 16, 4:17 PM · Performance-Team (Radar), MediaWiki-libs-Rdbms
Lucas_Werkmeister_WMDE created T332329: UpdateQueryBuilder does not support IDatabase::ALL_ROWS updates.
Thu, Mar 16, 4:15 PM · Performance-Team (Radar), MediaWiki-libs-Rdbms
Lucas_Werkmeister_WMDE added a comment to T332129: ParserIntegrationTest failures in Wikibase gate-and-submit php81 jobs: Failed asserting that two strings are equal.

Apparently these test failures are due to the test changes? When I [revert them](I3a2b3655cecd12fa91d2c58c04479e1e4fd2bb91), check php passes again. o_O

Thu, Mar 16, 3:53 PM · Wikidata
Lucas_Werkmeister_WMDE added a comment to T331621: CI: Don't show PHPUnit progress.

I agree that scrolling through the progress indicators is annoying when looking for test results, but I also find it quite helpful while the tests are still running.

Agreed. It’s also useful when tracking down a particular test failure (perhaps one that only affects CI), to see if CI already reached that test (whether it passed, failed, errored, or totally crashed) or not yet.

Thu, Mar 16, 3:35 PM · Patch-For-Review, MediaWiki-Core-Tests, Developer Productivity

Wed, Mar 15

Lucas_Werkmeister_WMDE added a member for Trusted-Contributors: oleksandr_tsyba_WMDE.
Wed, Mar 15, 6:09 PM
Lucas_Werkmeister_WMDE added a comment to T299077: CI job wmf-quibble-selenium-php72-docker get a deadlock on `change_tag_def` (NameTableStore).

I’m pretty confused by the Gerrit discussion on that old change, but if I understand correctly, I guess we can just remove the transaction around the big loop in run()? Having beginAtomic() / endAtomic() around the entire contents of run() doesn’t seem very useful indeed.

Wed, Mar 15, 12:50 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), wdwb-tech, Wikidata, MediaWiki-extensions-WikibaseClient, Browser-Tests, MediaWiki-Core-Tests, ci-test-error
Lucas_Werkmeister_WMDE added a comment to T331268: Migrate testwikidata to Kubernetes.

FWIW, I tried running our browser test suite against Wikidata.

Wed, Mar 15, 12:24 PM · SRE, Traffic, Wikidata, serviceops, MW-on-K8s, wdwb-tech
Lucas_Werkmeister_WMDE closed T332129: ParserIntegrationTest failures in Wikibase gate-and-submit php81 jobs: Failed asserting that two strings are equal as Invalid.

Okay, looks like it’s not a general problem after all. Must be something wrong with my change, though I have no idea what…

Wed, Mar 15, 11:40 AM · Wikidata
Lucas_Werkmeister_WMDE added a comment to T332129: ParserIntegrationTest failures in Wikibase gate-and-submit php81 jobs: Failed asserting that two strings are equal.

No error in the php81 gate-and-submit for this tiny change so far either…

Wed, Mar 15, 11:32 AM · Wikidata
Lucas_Werkmeister_WMDE removed a project from T332129: ParserIntegrationTest failures in Wikibase gate-and-submit php81 jobs: Failed asserting that two strings are equal: ci-test-error (WMF-deployed Build Failure).

Okay, both the test and php pipelines succeeded there now. Untagging shared build failure while it’s unclear that it really affects more than just the one change. Let’s wait for a proper gate-and-submit on another Wikibase change and see how that goes.

Wed, Mar 15, 11:12 AM · Wikidata
Lucas_Werkmeister_WMDE added a comment to T332129: ParserIntegrationTest failures in Wikibase gate-and-submit php81 jobs: Failed asserting that two strings are equal.

Hmm, it doesn’t seem to happen in the check php build for the above change so far. Perhaps there’s some unexpected issue with the Gerrit change where the gate-and-submit errors happened?

Wed, Mar 15, 11:09 AM · Wikidata
Lucas_Werkmeister_WMDE created T332129: ParserIntegrationTest failures in Wikibase gate-and-submit php81 jobs: Failed asserting that two strings are equal.
Wed, Mar 15, 10:55 AM · Wikidata
Lucas_Werkmeister_WMDE created T332123: Ambiguous month names in Mooré/Mossi (mos) and Setswana/Tswana (tn).
Wed, Mar 15, 9:54 AM · MediaWiki-Internationalization, I18n
Lucas_Werkmeister_WMDE added a comment to T332054: Codesearch frontend still says β in title after promotion to codesearch.wmcloud.org.

(Looks like https://gerrit.wikimedia.org/r/c/labs/codesearch/+/898060 is the relevant Gerrit change.)

Wed, Mar 15, 9:09 AM · VPS-project-Codesearch
Lucas_Werkmeister_WMDE closed T332054: Codesearch frontend still says β in title after promotion to codesearch.wmcloud.org as Resolved.

I guess so? Looks fine here as well now.

Wed, Mar 15, 9:08 AM · VPS-project-Codesearch

Tue, Mar 14

Lucas_Werkmeister_WMDE created T332054: Codesearch frontend still says β in title after promotion to codesearch.wmcloud.org.
Tue, Mar 14, 4:36 PM · VPS-project-Codesearch
Lucas_Werkmeister_WMDE added a comment to T331985: Shift or control click on the submit button on Special:NewLexeme does not behave as expected.

It should behave the same way that shift-click or control-click normally behaves on buttons, opening the new lexeme in a new tab or new background tab.

Tue, Mar 14, 12:42 PM · Wikidata, Special:NewLexeme revival, Wikidata Lexicographical data
Lucas_Werkmeister_WMDE added a comment to T214002: Wikidata web form recognizes Japanese date 2001年8月31日 but not 2016年7月1日.

So the first of the above changes, Make DateFormatParser accept more Asian/Chinese date formats, enables Wikibase to parse dates like “2023年3月12日” in Japanese as 2023-03-12. That change seems unproblematic and is good to go, I think.

Tue, Mar 14, 11:54 AM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Wikidata Dev Team, DataValues, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T331903: Remove DataAccessServices, WikibaseServices, MultipleEntitySourceServices.
Tue, Mar 14, 9:42 AM · Technical-Debt, wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T331903: Remove DataAccessServices, WikibaseServices, MultipleEntitySourceServices.
Tue, Mar 14, 9:42 AM · Technical-Debt, wdwb-tech, Wikidata

Mon, Mar 13

Lucas_Werkmeister_WMDE added a comment to T273193: Enroll Lucas Werkmeister’s YubiKey for production access.

(FWIW, the same YubiKey now does require touch as expected – ever since I got a new work laptop, IIRC. Slightly weird but not the end of the world.)

Mon, Mar 13, 5:55 PM · SRE, SRE-Access-Requests, WMDE
Lucas_Werkmeister_WMDE added a comment to T330624: [ES-M1] Update `mediawiki-codesniffer` in EntitySchema extension.

Change 897956 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/EntitySchema@master] Enforce trailing commas in multi-line arrays

https://gerrit.wikimedia.org/r/897956

Mon, Mar 13, 5:50 PM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), User-Michael, Shape Expressions (M1: technical preparation), Wikidata Dev Team (Sprint-∞), Wikidata, wmde-wikidata-tech
Lucas_Werkmeister_WMDE created T331903: Remove DataAccessServices, WikibaseServices, MultipleEntitySourceServices.
Mon, Mar 13, 5:15 PM · Technical-Debt, wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE added a comment to T328764: Implement custom LanguageSelector component.

Should the current user interface language be part of the shareable link or not?

Mon, Mar 13, 5:01 PM · Wikidata Dev Team (Sprint-∞), Wikidata
Lucas_Werkmeister_WMDE updated the task description for T331865: [Session] Community configuration – letting communities take control by JSON configuration.
Mon, Mar 13, 3:38 PM · Growth-Team, GrowthExperiments-CommunityConfiguration, User-Urbanecm, Wikimedia-Hackathon-2023
Lucas_Werkmeister_WMDE added a parent task for T328295: Migrate wikibase/termbox to newer Node.js version: T308371: Migrate node-based services in production to node16.
Mon, Mar 13, 1:57 PM · serviceops-radar, Wikidata, wdwb-tech
Lucas_Werkmeister_WMDE added a subtask for T308371: Migrate node-based services in production to node16: T328295: Migrate wikibase/termbox to newer Node.js version.
Mon, Mar 13, 1:57 PM · Patch-For-Review, serviceops
Lucas_Werkmeister_WMDE updated the task description for T308371: Migrate node-based services in production to node16.
Mon, Mar 13, 1:56 PM · Patch-For-Review, serviceops
Lucas_Werkmeister_WMDE updated the task description for T306995: Migrate node-based services in production to node14.
Mon, Mar 13, 1:56 PM · Patch-For-Review, serviceops, SRE
Lucas_Werkmeister_WMDE closed T328295: Migrate wikibase/termbox to newer Node.js version as Resolved.

I believe this is done now, all production environments use docker-registry.discovery.wmnet/wikimedia/wikibase-termbox:2023-03-06-101138-production which is based on Node 16.

Mon, Mar 13, 1:56 PM · serviceops-radar, Wikidata, wdwb-tech
Lucas_Werkmeister_WMDE closed T328295: Migrate wikibase/termbox to newer Node.js version, a subtask of T306995: Migrate node-based services in production to node14, as Resolved.
Mon, Mar 13, 1:55 PM · Patch-For-Review, serviceops, SRE

Thu, Mar 9

Lucas_Werkmeister_WMDE added a comment to T331621: CI: Don't show PHPUnit progress.

I agree that scrolling through the progress indicators is annoying when looking for test results, but I also find it quite helpful while the tests are still running.

Thu, Mar 9, 4:14 PM · Patch-For-Review, MediaWiki-Core-Tests, Developer Productivity
Lucas_Werkmeister_WMDE created T331615: fresh-node breaks when path contains spaces.
Thu, Mar 9, 11:47 AM · Performance-Team-onboarding, Performance-Team, Fresh
Lucas_Werkmeister_WMDE added a comment to T330426: selenium-daily Jenkins jobs failing with `node: ../src/coroutine.cc:134: void* find_thread_id_key(void*): Assertion `thread_id_key != 0x7777' failed`.

selenium-daily-beta-WikibaseLexeme (various error messages)

Thu, Mar 9, 11:22 AM · MediaWiki-Core-Tests, Browser-Tests, User-zeljkofilipin, ci-test-error, Quality-and-Test-Engineering-Team (QTE), Page-Previews, MinervaNeue, Readers-Web-Backlog
Lucas_Werkmeister_WMDE added a comment to T331405: Query service maxlag calculation should exclude datacenters that don't receive traffic and where the updater is turned off.

Can I take one step back and ask what are you using this max lag measure for, and how?

Thu, Mar 9, 11:17 AM · serviceops, wdwb-tech, Wikidata.org, Wikidata-Query-Service, Wikidata

Tue, Mar 7

Lucas_Werkmeister_WMDE committed rWBTB24843df171f2: Remove @vue/cli-plugin-unit-jest (authored by Lucas_Werkmeister_WMDE).
Remove @vue/cli-plugin-unit-jest
Tue, Mar 7, 3:37 PM
Lucas_Werkmeister_WMDE committed rWBTB75388991b8c4: Update Node version in docker/Dockerfile-node (authored by Lucas_Werkmeister_WMDE).
Update Node version in docker/Dockerfile-node
Tue, Mar 7, 3:33 PM
Lucas_Werkmeister_WMDE added a comment to T331423: Add proper cache related headers in nginx config for UI.

Just leaving a pointer here that for Wikidata production we solved essentially the same issue in T301461. (TL;DR: we also went for Cache-Control: no-cache. Keep in mind that applies not only to index.html but also to embed.html!)

Tue, Mar 7, 3:07 PM · Wikibase.cloud
Lucas_Werkmeister_WMDE added a project to T331405: Query service maxlag calculation should exclude datacenters that don't receive traffic and where the updater is turned off: Sustainability (Incident Followup).

Tagging this as an incident follow-up – while the maxlag was high, edits slowed down drastically (which is the correct response to high maxlag ^^) – see Grafana:

image.png (753×1 px, 148 KB)

Tue, Mar 7, 11:58 AM · serviceops, wdwb-tech, Wikidata.org, Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T331405: Query service maxlag calculation should exclude datacenters that don't receive traffic and where the updater is turned off.
Tue, Mar 7, 11:56 AM · serviceops, wdwb-tech, Wikidata.org, Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T331405: Query service maxlag calculation should exclude datacenters that don't receive traffic and where the updater is turned off.
Tue, Mar 7, 11:54 AM · serviceops, wdwb-tech, Wikidata.org, Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE created T331405: Query service maxlag calculation should exclude datacenters that don't receive traffic and where the updater is turned off.
Tue, Mar 7, 11:52 AM · serviceops, wdwb-tech, Wikidata.org, Wikidata-Query-Service, Wikidata

Mon, Mar 6

Lucas_Werkmeister_WMDE added a project to T314987: Wikibase GitHub workflow that extracts library commits is broken: Wikibase Suite.

double check if any commits were missed while it was broken and if so, push them to the respective places

Did we do this?

Mon, Mar 6, 2:25 PM · Wikibase Suite, MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), Patch-For-Review, Wikidata, wdwb-tech
Lucas_Werkmeister_WMDE added a comment to T314987: Wikibase GitHub workflow that extracts library commits is broken.

It’s finally working again.

image.png (254×292 px, 18 KB)

Mon, Mar 6, 11:37 AM · Wikibase Suite, MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), Patch-For-Review, Wikidata, wdwb-tech
Lucas_Werkmeister_WMDE added a comment to T328281: [WDQS-GUI] Perform update of `bootstrap-table`.

Apparently there’s a v1.21.3 now (Dependabot change), we can check if that still has the regression or not.

Mon, Mar 6, 11:27 AM · Wikidata Dev Team, wmde-wikidata-tech, Wikidata, Wikidata Query UI
Lucas_Werkmeister_WMDE placed T309176: Fix Typescript compiler warnings/errors in Termbox CI tests up for grabs.
Mon, Mar 6, 11:11 AM · Patch-For-Review, Wikidata Dev Team (Sprint-∞), Wikidata, Wikidata-Termbox, wmde-wikidata-tech
Lucas_Werkmeister_WMDE reopened T309176: Fix Typescript compiler warnings/errors in Termbox CI tests as "Open".

It looks like the Jest 28 upgrade only changed the meaning of the diagnostics: false flag in jest.config.js to also hide all the TS errors. If that flag is removed (which we ultimately want), then the errors are still there 😩

Mon, Mar 6, 11:03 AM · Patch-For-Review, Wikidata Dev Team (Sprint-∞), Wikidata, Wikidata-Termbox, wmde-wikidata-tech
Lucas_Werkmeister_WMDE set the point value for T329553: Wikidata Termbox pipeline tests fail with dependency errors in npm dedupe to 8.

Pulling into the sprint to reflect that we worked on it; post-hoc estimated as “no smaller than 5 and no bigger than 8”.

Mon, Mar 6, 10:44 AM · Wikidata Dev Team (Sprint-∞), User-Michael, Patch-For-Review, ci-test-error, wdwb-tech, Wikidata, wmde-wikidata-tech, Release Pipeline (Blubber), Wikidata-Termbox
Lucas_Werkmeister_WMDE moved T329553: Wikidata Termbox pipeline tests fail with dependency errors in npm dedupe from Parents/Waiting to Our work done on the Wikidata Dev Team (Sprint-∞) board.
Mon, Mar 6, 10:44 AM · Wikidata Dev Team (Sprint-∞), User-Michael, Patch-For-Review, ci-test-error, wdwb-tech, Wikidata, wmde-wikidata-tech, Release Pipeline (Blubber), Wikidata-Termbox
Lucas_Werkmeister_WMDE added a comment to T314987: Wikibase GitHub workflow that extracts library commits is broken.

Also https://github.com/wmde/git-monorepo-splice-docker-action/pull/2.

Mon, Mar 6, 10:41 AM · Wikibase Suite, MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), Patch-For-Review, Wikidata, wdwb-tech
Lucas_Werkmeister_WMDE created T331276: [Session] Cool new things in MediaWiki code.
Mon, Mar 6, 10:33 AM · Wikimedia-Hackathon-2023
Lucas_Werkmeister_WMDE created T331275: [Session] Cool new things in PHP.
Mon, Mar 6, 10:33 AM · Wikimedia-Hackathon-2023
Lucas_Werkmeister_WMDE committed rWBTB3985aa9774ff: Update Jest to version 28 (authored by Lucas_Werkmeister_WMDE).
Update Jest to version 28
Mon, Mar 6, 10:27 AM
Lucas_Werkmeister_WMDE closed T309176: Fix Typescript compiler warnings/errors in Termbox CI tests as Resolved.

@Michael managed to fix T329553 (unblocking this task), and the Jest 28 upgrade indeed got rid of all the TS2307 / “cannot find module” errors. (There are plenty of new errors from sass about the / syntax being deprecated, but that’s a separate issue.)

Mon, Mar 6, 10:19 AM · Patch-For-Review, Wikidata Dev Team (Sprint-∞), Wikidata, Wikidata-Termbox, wmde-wikidata-tech
Lucas_Werkmeister_WMDE closed T329553: Wikidata Termbox pipeline tests fail with dependency errors in npm dedupe as Resolved.
Mon, Mar 6, 10:11 AM · Wikidata Dev Team (Sprint-∞), User-Michael, Patch-For-Review, ci-test-error, wdwb-tech, Wikidata, wmde-wikidata-tech, Release Pipeline (Blubber), Wikidata-Termbox
Lucas_Werkmeister_WMDE closed T329553: Wikidata Termbox pipeline tests fail with dependency errors in npm dedupe, a subtask of T309176: Fix Typescript compiler warnings/errors in Termbox CI tests, as Resolved.
Mon, Mar 6, 10:11 AM · Patch-For-Review, Wikidata Dev Team (Sprint-∞), Wikidata, Wikidata-Termbox, wmde-wikidata-tech

Fri, Mar 3

Lucas_Werkmeister_WMDE added projects to T331116: offboarding for Tobias Schumann (contractor for Wikimedia Deutschland): SRE-Access-Requests, SRE.
Fri, Mar 3, 11:29 AM · SRE, SRE-Access-Requests
Lucas_Werkmeister_WMDE added a comment to T325988: MonthNameUnlocalizer may unlocalize dates in an undesired way.

Proposed fix: https://github.com/wmde/Time/pull/167

Fri, Mar 3, 11:06 AM · Patch-For-Review, Wikidata
Lucas_Werkmeister_WMDE created T331102: Complete offboarding for Jonas Kress.
Fri, Mar 3, 10:00 AM · SRE, SRE-Access-Requests
Lucas_Werkmeister_WMDE updated subscribers of T331081: shell user "toan" - address couldn't be found.

FWIW, @toan is indeed no longer working at WMDE. I’ll see if I can find someone on our side who knows more about the offboarding process.

Fri, Mar 3, 9:39 AM · SRE, SRE-Access-Requests

Thu, Mar 2

Lucas_Werkmeister_WMDE closed T330410: Clean up last remnants of Special:UnconnectedPages / unexpectedUnconnectedPageProp migration, a subtask of T300770: Special:UnconnectedPages for main namespace is slow (ca. 10 seconds), as Resolved.
Thu, Mar 2, 2:31 PM · Wikidata Dev Team (Sprint-∞), SecTeam-Processed, Wikimedia-Slow-DB-Query, MediaWiki-extensions-WikibaseClient, Wikidata, Vuln-DoS, Security
Lucas_Werkmeister_WMDE closed T330410: Clean up last remnants of Special:UnconnectedPages / unexpectedUnconnectedPageProp migration as Resolved.
Thu, Mar 2, 2:31 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Technical-Debt, wmde-wikidata-tech, MediaWiki-extensions-WikibaseClient, Wikidata, wdwb-tech
Lucas_Werkmeister_WMDE updated subscribers of T331020: diffConfig broken due to git stash failure.

CC @Krinkle and @Ladsgroup from build: Change diffConfig to use git-stash instead of git-add yesterday.

Thu, Mar 2, 2:22 PM · Continuous-Integration-Config
Lucas_Werkmeister_WMDE created T331020: diffConfig broken due to git stash failure.
Thu, Mar 2, 2:20 PM · Continuous-Integration-Config
Lucas_Werkmeister_WMDE closed T330752: Remove master branch from wikidata/query-builder/deploy.git as Resolved.

Mentioned in SAL (#wikimedia-releng) [2023-03-02T12:39:16Z] <Luca> wikidata/query-builder/deploy.git: changed HEAD from master to production # T330752

Thu, Mar 2, 12:42 PM · Gerrit, wmde-wikidata-tech, wdwb-tech, Wikidata Query Builder, Wikidata

Wed, Mar 1

Lucas_Werkmeister_WMDE added a comment to T327511: Query Service text wrapping issue on Chrome.

We can only use overflow-wrap: anywhere; on item links and it solves wrapping problem without breaking table layout.

Code:

a.item-link {
  overflow-wrap: anywhere;
}

Screenshots:

image.png (475×1 px, 120 KB)

image.png (187×1 px, 39 KB)

Wed, Mar 1, 4:02 PM · Wikidata Dev Team (Sprint-∞), Wikidata, Wikidata Query UI
Lucas_Werkmeister_WMDE updated subscribers of T330859: MWException: Wikibase\Lib\LanguageWithConversion::validateLanguageCode: invalid language code core-recon/wd-recon-lang.

While we should of course handle this without crashing, it’s also clearly not a valid request: the code that is making these API requests is also broken. From GitHub search, wd-recon-lang seems to come from OpenRefine, especially the preview-renderer:

Wed, Mar 1, 3:29 PM · Patch-For-Review, wdwb-tech, MediaWiki-Language-converter, Wikidata, Wikimedia-production-error
Michael awarded T330752: Remove master branch from wikidata/query-builder/deploy.git a Like token.
Wed, Mar 1, 2:50 PM · Gerrit, wmde-wikidata-tech, wdwb-tech, Wikidata Query Builder, Wikidata
Lucas_Werkmeister_WMDE added a comment to T330859: MWException: Wikibase\Lib\LanguageWithConversion::validateLanguageCode: invalid language code core-recon/wd-recon-lang.

Can be reproduced locally with something like { "lang": "core-recon/wd-recon-lang" } in the options parameter, e.g.:

Wed, Mar 1, 12:15 PM · Patch-For-Review, wdwb-tech, MediaWiki-Language-converter, Wikidata, Wikimedia-production-error