Private account: @LucasWerkmeister.
This probably means setting wmgUseWikibaseSchema to true for wikidatawiki in InitialiseSettings.php.
This probably means setting wmgUseWikibaseSchema to true for testwikidatawiki in InitialiseSettings.php.
We shouldn’t spend more than 1 day on this.
This has been deployed for about two weeks now, I believe, with no reported regressions as far as I’m aware. I think we can close this task :)
Any suggestions for specific improvements?
It turns out there’s no regular train this week (releng offsite), so I’ll backport the patch that unconditionally enables the feature in WBQC and SWAT that on Thursday.
To be honest, I’m starting to doubt the usefulness of this commenting-out spree. There are now more commented-out scenarios than ones left active, and the way that different test failures appear and vanish between test runs makes me think that most of the failures aren’t related to any individual test.
Okay, current status:
Should we switch the violation message to the version without separators if we’re not checking the main statement? Or should the check be done differently?
Seems to work so far, thank you :)
Thu, Apr 18
Might be worth wrapping this up in a maintenance script:
I was able to do it locally with the following code:
Moving to Verification – let’s see what the next daily CI run looks like…
Unfortunately the ChangeOp approach seems to have the same problem: it uses the base revision, not the parent revision, to check if the label and the description are the same :(
Moving to the “stalled” column, since I don’t think we’re doing anything here at the moment – it’s just waiting for 1.34.0-wmf.1 to reach group1 (currently blocked on several tasks, see T220726: 1.34.0-wmf.1 deployment blockers).
Doesn’t seem to be happening anymore, so let’s just close this, I guess.
Wed, Apr 17
Some recent patches don’t experience this error anymore, so downgrading priority. I figure we can close this tomorrow afternoon if we don’t observe the error again.
Another list @ https://integration.wikimedia.org/ci/job/selenium-Wikibase-chrome/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=DebianJessie%20&&%20contintLabsSlave/547/testReport/ – contains some tests that weren’t failing in the other list and vice versa, so apparently this whole business is flaky as well, great :(
Recent list of failed tests @ https://integration.wikimedia.org/ci/job/selenium-Wikibase-chrome/BROWSER=chrome,MEDIAWIKI_ENVIRONMENT=beta,PLATFORM=Linux,label=DebianJessie%20&&%20contintLabsSlave/548/testReport/
Might be related to the OOUI v0.31.4 update which was merged earlier today (Ic94a2f6790). Unfortunately, I can’t reproduce the failure locally at the moment.
T87985: Convert Translate to use extension registration has an interesting proposal for how to do the migration: instead of trying to convert the whole file at once, which results in a huge patch that’s hard to review and grows stale quickly, start with an empty extension-wip.json file, load that from the PHP entrypoint, and then start moving parts of the extension registration from PHP to JSON one by one, until the PHP file is just the wfLoadExtension() call and extension-wip.json can be renamed to a proper extension.json. It looks like that approach was pretty successful for the Translate extension, so I think we should follow it here as well.
Forgot to attach the task on the last message:
Yep, mediawiki-vagrant was updated two days ago in e7f3fd5824.
Apparently the ObjectFactory class was removed in Ibfdb55101c, it had been deprecated in favor of \Wikimedia\ObjectFactory a while ago. I would assume that mediawiki-vagrant has already been updated for this, so let’s see if I can update our install…
Now enabled on Test Wikidata.
Is this a duplicate of T221126: Improve error reporting on URL shortener?
Tue, Apr 16
git bisect in OOUI points at rGOJU2d4c8af00035: MenuTagMSW: Use 'highlightOnFilter' flag in MenuSelectWidget, so CCing author @Esanders and +2er @Mooeypoo for their information, since this might affect other OOUI users as well and I don’t know if the OOUI team wants to backport the fix somewhere or anything like that.