Page MenuHomePhabricator

Lucas_Werkmeister_WMDE (Lucas Werkmeister (WMDE))
closing tasks for open data

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 3 2017, 2:45 PM (322 w, 2 d)
Availability
Available
IRC Nick
Lucas_WMDE
LDAP User
Lucas Werkmeister (WMDE)
MediaWiki User
Lucas Werkmeister (WMDE) [ Global Accounts ]

Software developer on the Wikidata team at Wikimedia Germany (he/him, Berlin timezone). Private account: @LucasWerkmeister.

Recent Activity

Yesterday

Lucas_Werkmeister_WMDE added a comment to T338222: Chore: Update dependencies in Mismatch Finder.

sail again: https://github.com/wmde/wikidata-mismatch-finder/pull/621

Wed, Jun 7, 2:52 PM · Wikidata Dev Team (Sprint-∞), Mismatch Finder, wdwb-tech, wmde-wikidata-tech, Wikidata
Lucas_Werkmeister_WMDE added a comment to T338222: Chore: Update dependencies in Mismatch Finder.

types: https://github.com/wmde/wikidata-mismatch-finder/pull/620

Wed, Jun 7, 2:37 PM · Wikidata Dev Team (Sprint-∞), Mismatch Finder, wdwb-tech, wmde-wikidata-tech, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T338301: Wikibase allows edits with nonempty “repository names” in entity IDs.
Wed, Jun 7, 12:45 PM · Technical-Debt, wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE moved T338222: Chore: Update dependencies in Mismatch Finder from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.
Wed, Jun 7, 12:27 PM · Wikidata Dev Team (Sprint-∞), Mismatch Finder, wdwb-tech, wmde-wikidata-tech, Wikidata
Lucas_Werkmeister_WMDE added a comment to T338222: Chore: Update dependencies in Mismatch Finder.

Build related: https://github.com/wmde/wikidata-mismatch-finder/pull/618

Wed, Jun 7, 12:27 PM · Wikidata Dev Team (Sprint-∞), Mismatch Finder, wdwb-tech, wmde-wikidata-tech, Wikidata
Lucas_Werkmeister_WMDE moved T338222: Chore: Update dependencies in Mismatch Finder from Tech Verification to Doing on the Wikidata Dev Team (Sprint-∞) board.

This isn’t close to being done yet, I just didn’t want to put up additional PRs while the first ones were open.

Wed, Jun 7, 12:18 PM · Wikidata Dev Team (Sprint-∞), Mismatch Finder, wdwb-tech, wmde-wikidata-tech, Wikidata
Lucas_Werkmeister_WMDE added a parent task for T338223: Wikibase REST and action api allow adding statements with wikibase-item values that are not valid item ids: T338301: Wikibase allows edits with nonempty “repository names” in entity IDs.
Wed, Jun 7, 10:07 AM · Patch-For-Review, Wikibase REST API, Wikidata
Lucas_Werkmeister_WMDE added a parent task for T338255: Lexemes (some?) are not properly indexed by CirrusSearch: T338301: Wikibase allows edits with nonempty “repository names” in entity IDs.
Wed, Jun 7, 10:07 AM · Wikidata Lexicographical data, Wikidata, CirrusSearch, Discovery-Search
Lucas_Werkmeister_WMDE added subtasks for T338301: Wikibase allows edits with nonempty “repository names” in entity IDs: T338223: Wikibase REST and action api allow adding statements with wikibase-item values that are not valid item ids, T338255: Lexemes (some?) are not properly indexed by CirrusSearch.
Wed, Jun 7, 10:07 AM · Technical-Debt, wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE created T338301: Wikibase allows edits with nonempty “repository names” in entity IDs.
Wed, Jun 7, 10:06 AM · Technical-Debt, wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE added a comment to T338223: Wikibase REST and action api allow adding statements with wikibase-item values that are not valid item ids.

Maybe it would be simpler to instead implement another validator that asserts the repo name is empty in new edits, for instance?

Wed, Jun 7, 9:54 AM · Patch-For-Review, Wikibase REST API, Wikidata
Lucas_Werkmeister_WMDE moved T335754: All icons in Language Selector component are missing from Doing to Product Verification on the Wikidata Dev Team (Sprint-∞) board.

Should be deployed now.

Wed, Jun 7, 9:34 AM · Wikidata Dev Team (Sprint-∞), Wikidata, Wikidata Query Builder
Lucas_Werkmeister_WMDE updated subscribers of T338255: Lexemes (some?) are not properly indexed by CirrusSearch.

I think I just fixed that particular lexeme by pasting the result of

Wed, Jun 7, 9:33 AM · Wikidata Lexicographical data, Wikidata, CirrusSearch, Discovery-Search
Lucas_Werkmeister_WMDE moved T335754: All icons in Language Selector component are missing from Product Verification to Doing on the Wikidata Dev Team (Sprint-∞) board.

I think this needs to be deployed before it can be product verified (at least, it doesn’t seem to be fixed on https://query.wikidata.org/querybuilder/ yet).

Wed, Jun 7, 9:15 AM · Wikidata Dev Team (Sprint-∞), Wikidata, Wikidata Query Builder
Lucas_Werkmeister_WMDE added a project to T338255: Lexemes (some?) are not properly indexed by CirrusSearch: Wikidata Lexicographical data.
Wed, Jun 7, 9:13 AM · Wikidata Lexicographical data, Wikidata, CirrusSearch, Discovery-Search
Lucas_Werkmeister_WMDE added a comment to T338255: Lexemes (some?) are not properly indexed by CirrusSearch.

Logstash for reqId 8217e332-56bf-4ec3-8d5e-4b78b07808d8:

Wed, Jun 7, 9:13 AM · Wikidata Lexicographical data, Wikidata, CirrusSearch, Discovery-Search

Tue, Jun 6

Lucas_Werkmeister_WMDE added a comment to T338222: Chore: Update dependencies in Mismatch Finder.

Sail: https://github.com/wmde/wikidata-mismatch-finder/pull/617

Tue, Jun 6, 3:50 PM · Wikidata Dev Team (Sprint-∞), Mismatch Finder, wdwb-tech, wmde-wikidata-tech, Wikidata
Lucas_Werkmeister_WMDE moved T338222: Chore: Update dependencies in Mismatch Finder from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.

ESLint: https://github.com/wmde/wikidata-mismatch-finder/pull/616

Tue, Jun 6, 3:27 PM · Wikidata Dev Team (Sprint-∞), Mismatch Finder, wdwb-tech, wmde-wikidata-tech, Wikidata
Lucas_Werkmeister_WMDE claimed T338222: Chore: Update dependencies in Mismatch Finder.
Tue, Jun 6, 3:22 PM · Wikidata Dev Team (Sprint-∞), Mismatch Finder, wdwb-tech, wmde-wikidata-tech, Wikidata
Lucas_Werkmeister_WMDE edited projects for T338222: Chore: Update dependencies in Mismatch Finder, added: Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
Tue, Jun 6, 3:22 PM · Wikidata Dev Team (Sprint-∞), Mismatch Finder, wdwb-tech, wmde-wikidata-tech, Wikidata
Lucas_Werkmeister_WMDE added a comment to T338223: Wikibase REST and action api allow adding statements with wikibase-item values that are not valid item ids.

(While I’ve now gone down a bit further into the “let’s disallow nonempty repo names entity IDs” rabbit hole, that doesn’t have to be the only solution. Maybe it would be simpler to instead implement another validator that asserts the repo name is empty in new edits, for instance?)

Tue, Jun 6, 3:13 PM · Patch-For-Review, Wikibase REST API, Wikidata
Lucas_Werkmeister_WMDE closed T338213: CI + Beta errors: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars() as Resolved.

I think this is resolved now.

Tue, Jun 6, 1:40 PM · ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE added a comment to T338223: Wikibase REST and action api allow adding statements with wikibase-item values that are not valid item ids.

Apparently we had already planned to remove support for “old federation” methods: T291823: Remove "old federation" methods from EntityId

Tue, Jun 6, 12:59 PM · Patch-For-Review, Wikibase REST API, Wikidata
Lucas_Werkmeister_WMDE added a comment to T338223: Wikibase REST and action api allow adding statements with wikibase-item values that are not valid item ids.

Change 927654 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Drop support for repo names in entity IDs

https://gerrit.wikimedia.org/r/927654

Tue, Jun 6, 12:51 PM · Patch-For-Review, Wikibase REST API, Wikidata
Lucas_Werkmeister_WMDE added a comment to T338223: Wikibase REST and action api allow adding statements with wikibase-item values that are not valid item ids.

Okay, it is reproducible with { "entity-type": "item", "id": "foobar:Q50" } as the value in the wbeditentity payload. (If you leave foobar empty, i.e. "id": ":Q50", you just get a normal, working statement.) I expect this is related to the remnants of “entity IDs with repository names” that we still have in the code (before we decided to do federation differently), and I have a feeling it’s pretty much unrelated to the REST API issue.

Tue, Jun 6, 12:39 PM · Patch-For-Review, Wikibase REST API, Wikidata
Lucas_Werkmeister_WMDE added a comment to T338223: Wikibase REST and action api allow adding statements with wikibase-item values that are not valid item ids.

I can’t reproduce this using the action API – both wbeditentity (as mentioned in the task description) and wbsetclaimvalue give me an error like this:

Tue, Jun 6, 12:29 PM · Patch-For-Review, Wikibase REST API, Wikidata
Lucas_Werkmeister_WMDE closed T332554: [ES-M3] EntitySchema: update linter configuration as Resolved.

I think this is done.

Tue, Jun 6, 12:23 PM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), Wikidata Dev Team (Sprint-∞), User-Michael, Shape Expressions (M3: EntitySchemas shown as labels instead of ID), wmde-wikidata-tech, Wikidata
Lucas_Werkmeister_WMDE closed T336760: Wikidata: enable fix for `list=wbsubscribers` response format as Resolved.

This is deployed and the API result looks good now.

Tue, Jun 6, 12:23 PM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.7; 2023-05-01), Wikidata Dev Team (Sprint-∞), wmde-wikidata-tech, MediaWiki-Action-API, MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE closed T336760: Wikidata: enable fix for `list=wbsubscribers` response format, a subtask of T300458: [API] Inconsistencies in response of `list=wbsubscribers` API Query module, as Resolved.
Tue, Jun 6, 12:21 PM · MW-1.41-notes (1.41.0-wmf.7; 2023-05-01), Patch-For-Review, Wikidata Dev Team (Sprint-∞), wmde-wikidata-tech, MediaWiki-Action-API, MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T337717: Phan failing on Wikibase after ConnectionManager::getReadConnection() changed return type.
Tue, Jun 6, 10:10 AM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), MediaWiki-libs-Rdbms, Performance-Team, ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE closed T337717: Phan failing on Wikibase after ConnectionManager::getReadConnection() changed return type as Resolved.

I think that’s it!

Tue, Jun 6, 10:10 AM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), MediaWiki-libs-Rdbms, Performance-Team, ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE lowered the priority of T338213: CI + Beta errors: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars() from Unbreak Now! to High.
Tue, Jun 6, 9:58 AM · ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE updated subscribers of T338213: CI + Beta errors: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars().

I think I actually found a fix for the original patch (though @daniel and/or @tstarling should definitely take a closer look) – let’s see if CI likes that. (But the revert can still finish going through gate-and-submit.)

Tue, Jun 6, 9:30 AM · ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T338213: CI + Beta errors: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars().
Tue, Jun 6, 9:22 AM · ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE added a comment to T338213: CI + Beta errors: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars().

Hmm, beta wikis are offline too with a similar error:

[ZH73@OA1dX58GXh@K8XaKgAAAJA] /wiki/Main_Page Error: Call to undefined method MediaWiki\Extension\TorBlock\TorBlockAbuseFilterHooks::onAbuseFilter-builder()
...
Tue, Jun 6, 9:17 AM · ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE renamed T338213: CI + Beta errors: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars() from Wikibase CI failing: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars() to CI + Beta errors: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars().
Tue, Jun 6, 9:17 AM · ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE added a comment to T337527: 1.41.0-wmf.13 deployment blockers.

This code is used for all hooks, it is exercised hundreds of times with every request, and most test cases. If somethign is wrong with it, we will know very soon.

Tue, Jun 6, 9:14 AM · Release-Engineering-Team (They Live 🕶️🧟), Release, Train Deployments
Lucas_Werkmeister_WMDE added a comment to T338213: CI + Beta errors: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars().

Okay, I can reproduce it locally by running the Wikibase test repo/tests/phpunit/includes/Store/Sql/WikiPageEntityStoreTest.php --filter testDeleteEntity, and reverting “Simplify HookContainer” in core indeed fixes the test again.

Tue, Jun 6, 9:12 AM · ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE added a comment to T338213: CI + Beta errors: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars().

Aha, we can get a PHP stack trace from the noselenium artifacts mw-error.log:

Tue, Jun 6, 9:09 AM · ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE added a comment to T338213: CI + Beta errors: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars().

E.g. on this Wikibase change, several of the main test builds failed. The error message quoted above can be seen in selenium and in apitests, but neither of those give us a PHP stack trace unfortunately (unless it’s somewhere in the artifacts?); the noselenium job has plenty of errors, but eventually PHPUnit dies completely before it can print any of the details:

Tue, Jun 6, 9:07 AM · ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE updated subscribers of T338213: CI + Beta errors: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars().

Possibly related to @daniel’s Simplify HookContainer? That was merged very recently, whereas I don’t see any recent changes in AbuseFilter or CentralAuth that look related at a glance. (From the error message, the simplified HookContainer might be missing some code to replace the - with _ in onAbuseFilter-generateUserVars?)

Tue, Jun 6, 9:02 AM · ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE created T338213: CI + Beta errors: Call to undefined method MediaWiki\Extension\CentralAuth\Hooks\Handlers\AbuseFilterHookHandler::onAbuseFilter-generateUserVars().
Tue, Jun 6, 9:01 AM · ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE added a comment to T300460: [API] WikibaseClient: wblistentityusage API module adds its results to the `query.pages` key in response.

This is done, isn’t it? (The cleanup ApiListEntityUsage: Remove legacy prefix was attached to the sibling task T196962.)

Tue, Jun 6, 8:55 AM · Wikidata Dev Team, MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), wmde-wikidata-tech, Wikimedia-production-error, MediaWiki-Action-API, MediaWiki-extensions-WikibaseClient, wdwb-tech, Wikidata

Mon, Jun 5

Lucas_Werkmeister_WMDE moved T335754: All icons in Language Selector component are missing from Parents/Waiting to Peer Review on the Wikidata Dev Team (Sprint-∞) board.
Mon, Jun 5, 2:27 PM · Wikidata Dev Team (Sprint-∞), Wikidata, Wikidata Query Builder
Lucas_Werkmeister_WMDE claimed T335754: All icons in Language Selector component are missing.
Mon, Jun 5, 2:23 PM · Wikidata Dev Team (Sprint-∞), Wikidata, Wikidata Query Builder
Lucas_Werkmeister_WMDE moved T171140: Enable Wikidata support for Outreach Wiki from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board.

Tested during deployment with this Wikidata sandbox item edit and this outreachwiki sandbox page edit.

Mon, Jun 5, 1:15 PM · Wikidata Dev Team (Sprint-∞), User-ItamarWMDE, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), wdwb-tech, Wikimedia-Site-requests, Wikidata
Lucas_Werkmeister_WMDE awarded T338133: Add a "Thanks" token a Like token.
Mon, Jun 5, 10:57 AM · Phabricator
Lucas_Werkmeister_WMDE moved T171140: Enable Wikidata support for Outreach Wiki from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.
Mon, Jun 5, 9:56 AM · Wikidata Dev Team (Sprint-∞), User-ItamarWMDE, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), wdwb-tech, Wikimedia-Site-requests, Wikidata
Lucas_Werkmeister_WMDE claimed T171140: Enable Wikidata support for Outreach Wiki.

I squashed the two remaining config changes into one (Make outreachwiki a multilingual Wikidata client), since I think it makes more sense to deploy them together anyways. Scheduled for the UTC afternoon deployment window later today.

Mon, Jun 5, 9:28 AM · Wikidata Dev Team (Sprint-∞), User-ItamarWMDE, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), wdwb-tech, Wikimedia-Site-requests, Wikidata
Lucas_Werkmeister_WMDE added a comment to T332329: Implement support for IDatabase::ALL_ROWS in UpdateQueryBuilder.

I agree skipping a chainable method call is suboptimal, but I don't see a way to support that without a compromise. E.g. making the method nullable would introduce a significant surface for mistakes (footgun) with surprising side-effects that may be difficult to detect prior to affecting production.

Mon, Jun 5, 8:54 AM · Performance-Team (Radar), MediaWiki-libs-Rdbms

Fri, Jun 2

Lucas_Werkmeister_WMDE added a comment to T332329: Implement support for IDatabase::ALL_ROWS in UpdateQueryBuilder.

Just ran into this again while trying to convert

Fri, Jun 2, 12:35 PM · Performance-Team (Radar), MediaWiki-libs-Rdbms
Lucas_Werkmeister_WMDE edited projects for T338018: exampleTable's text should be selectable, added: Wikidata Query UI; removed Wikidata-Query-Service.
Fri, Jun 2, 10:44 AM · Wikidata, Wikidata Query UI
Lucas_Werkmeister_WMDE added a comment to T337760: Wikidata: Add pagelang right to wikidata-staff group.

Thanks, I didn’t know about that settings. But it looks like it only lets us inherit from one other group, not several?

Fri, Jun 2, 9:18 AM · wdwb-tech, Wikidata, Wikidata.org, Wikimedia-Site-requests
Lucas_Werkmeister_WMDE awarded T337986: Enhance tokens by adding rainbow-related ones a Stroopwafel token.
Fri, Jun 2, 9:13 AM · Phabricator

Thu, Jun 1

Lucas_Werkmeister_WMDE closed T337153: Make PHPUnit dataProvider static in WikibaseQualityConstraints tests as Resolved.
Thu, Jun 1, 7:55 AM · MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), wdwb-tech, Wikidata, Wikibase-Quality-Constraints
Lucas_Werkmeister_WMDE closed T337153: Make PHPUnit dataProvider static in WikibaseQualityConstraints tests, a subtask of T332865: PHPUnit data providers should be simple static functions that return plain data, as Resolved.
Thu, Jun 1, 7:55 AM · MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), Patch-For-Review, MediaWiki-General

Wed, May 31

Lucas_Werkmeister_WMDE added a comment to T336227: [ES-M2]: Update the EntitySchema data type name.

Should the entry in Special:ListDatatypes also change accordingly? (Message: wikibase-listdatatypes-entity-schema-head)

Wed, May 31, 2:30 PM · MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), Wikidata Dev Team (Sprint-∞), Shape Expressions (M2: Linking to EntitySchemas in statements), Wikidata

Tue, May 30

Lucas_Werkmeister_WMDE changed the status of T337760: Wikidata: Add pagelang right to wikidata-staff group from Open to Stalled.

Let’s leave some time for people to object on-wiki (maybe a week or so).

Tue, May 30, 4:03 PM · wdwb-tech, Wikidata, Wikidata.org, Wikimedia-Site-requests
Lucas_Werkmeister_WMDE added a project to T337760: Wikidata: Add pagelang right to wikidata-staff group: Wikidata.org.
Tue, May 30, 4:01 PM · wdwb-tech, Wikidata, Wikidata.org, Wikimedia-Site-requests
Lucas_Werkmeister_WMDE created T337760: Wikidata: Add pagelang right to wikidata-staff group.
Tue, May 30, 4:01 PM · wdwb-tech, Wikidata, Wikidata.org, Wikimedia-Site-requests
Lucas_Werkmeister_WMDE added a comment to T337154: Make PHPUnit dataProvider static in Wikibase tests.

It turns out this task has also (like T337153) had some initial work done already: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/921633

Tue, May 30, 3:33 PM · MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), wdwb-tech, Wikidata, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient
Lucas_Werkmeister_WMDE added a comment to T337154: Make PHPUnit dataProvider static in Wikibase tests.

Note: the vast majority of data providers in Wikibase are named either provideSomething or somethingProvider, so searching for public function provide or public function .*Provider\( should find the majority of functions that haven’t been converted yet. (git grep '@data[pP]rovider' | grep -v -e '@data[pP]rovider provide' -e '@data[pP]rovider .*Provider\b' shows a few dozen other data providers that are named differently; those will have to be checked manually whether they’re static or not, as it can’t be seen from the @dataProvider line.)

Tue, May 30, 11:45 AM · MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), wdwb-tech, Wikidata, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient
Lucas_Werkmeister_WMDE moved T330193: MUL - Make Special:SetLabelDescriptionAliases ready for `mul` language code from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board.
Tue, May 30, 11:36 AM · MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), Wikidata Dev Team (Sprint-∞), Wikidata, Wikidata-Campsite
Lucas_Werkmeister_WMDE changed the status of T335107: Remove temporary feature flag for Entity Labels in parsed edit summaries in API requests again, a subtask of T327062: Show entity labels in parsed edit summaries in API requests as well, from Open to Stalled.
Tue, May 30, 11:35 AM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), User-Michael, User-ItamarWMDE, Wikidata Dev Team (Sprint-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE changed the status of T335107: Remove temporary feature flag for Entity Labels in parsed edit summaries in API requests again from Open to Stalled.

Stalled until 1.41.0-wmf.12 is fully rolled out, i.e. we can probably deploy the config change after June 12.

Tue, May 30, 11:35 AM · MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), Patch-For-Review, Wikidata Dev Team (Sprint-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE changed the status of T335783: Remove temporary feature flag for wbsubscribers API output path, a subtask of T300458: [API] Inconsistencies in response of `list=wbsubscribers` API Query module, from Open to Stalled.
Tue, May 30, 11:34 AM · MW-1.41-notes (1.41.0-wmf.7; 2023-05-01), Patch-For-Review, Wikidata Dev Team (Sprint-∞), wmde-wikidata-tech, MediaWiki-Action-API, MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE changed the status of T335783: Remove temporary feature flag for wbsubscribers API output path from Open to Stalled.

Stalled until 1.41.0-wmf.12 is fully rolled out, i.e. we can probably deploy the config change after June 12.

Tue, May 30, 11:34 AM · MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), Patch-For-Review, Wikidata Dev Team (Sprint-∞), wmde-wikidata-tech, MediaWiki-Action-API, MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE added a project to T337154: Make PHPUnit dataProvider static in Wikibase tests: wdwb-tech.
Tue, May 30, 11:28 AM · MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), wdwb-tech, Wikidata, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient
Lucas_Werkmeister_WMDE added a project to T337153: Make PHPUnit dataProvider static in WikibaseQualityConstraints tests: wdwb-tech.
Tue, May 30, 11:28 AM · MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), wdwb-tech, Wikidata, Wikibase-Quality-Constraints
Lucas_Werkmeister_WMDE added a project to T337151: Make PHPUnit dataProvider static in WikibaseLexeme tests: wdwb-tech.
Tue, May 30, 11:27 AM · wdwb-tech, Wikidata, Wikidata Lexicographical data
Lucas_Werkmeister_WMDE added a project to T337150: Make PHPUnit dataProvider static in Wikidata.org tests: wdwb-tech.
Tue, May 30, 11:27 AM · wdwb-tech, Wikidata, Wikidata.org
Lucas_Werkmeister_WMDE added a project to T337148: Make PHPUnit dataProvider static in WikibaseCirrusSearch tests: wdwb-tech.
Tue, May 30, 11:26 AM · wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T337717: Phan failing on Wikibase after ConnectionManager::getReadConnection() changed return type.
Tue, May 30, 10:43 AM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), MediaWiki-libs-Rdbms, Performance-Team, ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE removed a project from T337717: Phan failing on Wikibase after ConnectionManager::getReadConnection() changed return type: Wikidata Dev Team (Sprint-∞).
Tue, May 30, 10:43 AM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), MediaWiki-libs-Rdbms, Performance-Team, ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE moved T337717: Phan failing on Wikibase after ConnectionManager::getReadConnection() changed return type from Parents/Waiting to Peer Review on the Wikidata Dev Team (Sprint-∞) board.
Tue, May 30, 10:14 AM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), MediaWiki-libs-Rdbms, Performance-Team, ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE added a project to T337717: Phan failing on Wikibase after ConnectionManager::getReadConnection() changed return type: Wikidata Dev Team (Sprint-∞).
Tue, May 30, 10:14 AM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), MediaWiki-libs-Rdbms, Performance-Team, ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE added a comment to T337717: Phan failing on Wikibase after ConnectionManager::getReadConnection() changed return type.

So, to recap the current changes I uploaded:

Tue, May 30, 10:12 AM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), MediaWiki-libs-Rdbms, Performance-Team, ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE added a comment to T337717: Phan failing on Wikibase after ConnectionManager::getReadConnection() changed return type.

(Though I suppose we could temporarily work around it in Wikibase with a Phan cast.)

Tue, May 30, 10:01 AM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), MediaWiki-libs-Rdbms, Performance-Team, ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE added a project to T337717: Phan failing on Wikibase after ConnectionManager::getReadConnection() changed return type: MediaWiki-libs-Rdbms.

Uggghhhh, but the needed MediaWiki core change fails with:

Tue, May 30, 9:51 AM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), MediaWiki-libs-Rdbms, Performance-Team, ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE claimed T337717: Phan failing on Wikibase after ConnectionManager::getReadConnection() changed return type.
Tue, May 30, 9:47 AM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), MediaWiki-libs-Rdbms, Performance-Team, ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE added a comment to T337717: Phan failing on Wikibase after ConnectionManager::getReadConnection() changed return type.

Ok, some of this is just that other parameter types need to be changed from IDatabase to IReadableDatabase, no big deal.

Tue, May 30, 9:22 AM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), MediaWiki-libs-Rdbms, Performance-Team, ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata
Lucas_Werkmeister_WMDE created T337717: Phan failing on Wikibase after ConnectionManager::getReadConnection() changed return type.
Tue, May 30, 9:08 AM · MW-1.41-notes (1.41.0-wmf.13; 2023-06-13), MediaWiki-libs-Rdbms, Performance-Team, ci-test-error (WMF-deployed Build Failure), wdwb-tech, Wikidata

Fri, May 26

Lucas_Werkmeister_WMDE added a comment to T336736: Migrate to IConnectionProvider in ConnectionManager and DomainDb (RepoDomainDb / ClientDomainDb).

Grmbl, and ConnectionManager also isn’t as easy as I thought. It currently takes an ILoadBalancer, not an ILoadBalancerFactory; and Cognate (in its ServiceWiring.php) relies on the ability to pass in an external LB (if $wgCognateCluster is configured, which it is in production: extension1) rather than a main LB, so I don’t see how it can be migrated to the IConnectionProvider interface :(

Fri, May 26, 3:40 PM · MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), Wikimedia-Hackathon-2023, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, wdwb-tech, Wikidata, Platform Engineering
Lucas_Werkmeister_WMDE added a comment to T336736: Migrate to IConnectionProvider in ConnectionManager and DomainDb (RepoDomainDb / ClientDomainDb).

And ItemsPerSiteBuilder which is used in a maint script which you can add $this->waitForReplication in that maint script and be done with it.

Fri, May 26, 3:35 PM · MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), Wikimedia-Hackathon-2023, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, wdwb-tech, Wikidata, Platform Engineering
Lucas_Werkmeister_WMDE changed the status of T335107: Remove temporary feature flag for Entity Labels in parsed edit summaries in API requests again from Stalled to Open.
Fri, May 26, 2:56 PM · MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), Patch-For-Review, Wikidata Dev Team (Sprint-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE changed the status of T335107: Remove temporary feature flag for Entity Labels in parsed edit summaries in API requests again, a subtask of T327062: Show entity labels in parsed edit summaries in API requests as well, from Stalled to Open.
Fri, May 26, 2:56 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), User-Michael, User-ItamarWMDE, Wikidata Dev Team (Sprint-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE added a comment to T327062: Show entity labels in parsed edit summaries in API requests as well.

Seems to work fine in SpeedPatrolling, for example:

image.png (290×1 px, 44 KB)

Fri, May 26, 2:50 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), User-Michael, User-ItamarWMDE, Wikidata Dev Team (Sprint-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE moved T335783: Remove temporary feature flag for wbsubscribers API output path from Doing to Peer Review on the Wikidata Dev Team (Sprint-∞) board.
Fri, May 26, 2:45 PM · MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), Patch-For-Review, Wikidata Dev Team (Sprint-∞), wmde-wikidata-tech, MediaWiki-Action-API, MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE changed the status of T335783: Remove temporary feature flag for wbsubscribers API output path, a subtask of T300458: [API] Inconsistencies in response of `list=wbsubscribers` API Query module, from Stalled to Open.
Fri, May 26, 2:40 PM · MW-1.41-notes (1.41.0-wmf.7; 2023-05-01), Patch-For-Review, Wikidata Dev Team (Sprint-∞), wmde-wikidata-tech, MediaWiki-Action-API, MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE updated subscribers of T335783: Remove temporary feature flag for wbsubscribers API output path.
Fri, May 26, 2:40 PM · MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), Patch-For-Review, Wikidata Dev Team (Sprint-∞), wmde-wikidata-tech, MediaWiki-Action-API, MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE changed the status of T335783: Remove temporary feature flag for wbsubscribers API output path from Stalled to Open.
Fri, May 26, 2:40 PM · MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), Patch-For-Review, Wikidata Dev Team (Sprint-∞), wmde-wikidata-tech, MediaWiki-Action-API, MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE closed T337118: Toolhub links to user pages in tool history using HTTP instead of HTTPS as Resolved.

Looks like the fix is now deployed and working \o/

Fri, May 26, 2:02 PM · Wikimedia-Hackathon-2023, Toolhub
Lucas_Werkmeister_WMDE updated the task description for T335735: Chore: Update dependencies in new-lexeme-special-page.git.
Fri, May 26, 1:59 PM · Patch-For-Review, Wikidata Dev Team (Sprint-∞), Wikidata Lexicographical data, Special:NewLexeme revival, wdwb-tech, wmde-wikidata-tech, Wikidata
Lucas_Werkmeister_WMDE closed T335735: Chore: Update dependencies in new-lexeme-special-page.git as Resolved.

I think this is all done.

Fri, May 26, 1:58 PM · Patch-For-Review, Wikidata Dev Team (Sprint-∞), Wikidata Lexicographical data, Special:NewLexeme revival, wdwb-tech, wmde-wikidata-tech, Wikidata
Lucas_Werkmeister_WMDE moved T337081: "Add interlanguage link" shows a bubble: "An unknown error occurred" from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board.
Fri, May 26, 1:56 PM · Wikimedia-Hackathon-2023, MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), User-notice, Wikidata Dev Team (Sprint-∞), Wikidata, MediaWiki-extensions-WikibaseClient
Lucas_Werkmeister_WMDE moved T335857: Document how to add languages to Wikibase/Wikidata from Peer Review to Tech Verification on the Wikidata Dev Team (Sprint-∞) board.
Fri, May 26, 1:56 PM · Language codes, MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), User-Noarave, Wikidata Dev Team (Sprint-∞), Wikidata Lexicographical data, Wikidata, wmde-wikidata-tech
Lucas_Werkmeister_WMDE moved T196962: Module prefix 'wbeu' is shared between Wikibase\Client\Api\ApiListEntityUsage and Wikibase\Client\Api\ApiPropsEntityUsage from Peer Review to Product Verification on the Wikidata Dev Team (Sprint-∞) board.
Fri, May 26, 1:56 PM · MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), Wikidata Dev Team (Sprint-∞), wmde-wikidata-tech, User-ItamarWMDE, wdwb-tech, Patch-For-Review, MediaWiki-extensions-WikibaseClient, Wikidata
Lucas_Werkmeister_WMDE added a comment to T337548: LanguageSelector menu gets focus on Chrome in Ubuntu.

Hm, I can’t reproduce this in Chromium 113.0.5672.126 on Ubuntu 23.04.

Fri, May 26, 12:44 PM · Wikidata, Wikidata Dev Team
Lucas_Werkmeister_WMDE added a project to T337540: File with percentage sign in file name does not open: "URIError: malformed URI sequence": MediaViewer.
Fri, May 26, 10:14 AM · MediaViewer
Lucas_Werkmeister_WMDE added a comment to T337081: "Add interlanguage link" shows a bubble: "An unknown error occurred".

For a few days earlier this month, the "Add interlanguage link" item in the Tools menu did not work properly. This has now been fixed.

Fri, May 26, 10:12 AM · Wikimedia-Hackathon-2023, MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), User-notice, Wikidata Dev Team (Sprint-∞), Wikidata, MediaWiki-extensions-WikibaseClient