Page MenuHomePhabricator

Lucas_Werkmeister_WMDE (Lucas Werkmeister (WMDE))
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 3 2017, 2:45 PM (132 w, 3 d)
Availability
Available
IRC Nick
Lucas_WMDE
LDAP User
Lucas Werkmeister (WMDE)
MediaWiki User
Lucas Werkmeister (WMDE) [ Global Accounts ]

Software developer on the Wikidata team at Wikimedia Germany. Private account: @LucasWerkmeister.

Recent Activity

Today

Lucas_Werkmeister_WMDE added a comment to T235056: Make app change button attributes depending on dirty state of store.

I have to leave now, but the core of this task is pretty simple:

Thu, Oct 17, 4:17 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE claimed T235056: Make app change button attributes depending on dirty state of store.
Thu, Oct 17, 3:57 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE merged T235767: Attach event handlers to Data Bridge links as soon as possible into T235765: Attach link listeners sooner.
Thu, Oct 17, 2:22 PM · Wikidata, Wikidata-Bridge
Lucas_Werkmeister_WMDE merged task T235767: Attach event handlers to Data Bridge links as soon as possible into T235765: Attach link listeners sooner.
Thu, Oct 17, 2:22 PM · Wikidata-Bridge, Wikidata
Lucas_Werkmeister_WMDE added a comment to T233305: delayed kicking in of Bridge.

Is there a majority to create tickets for the two bold statements (pun intended)?

Thu, Oct 17, 2:22 PM · Wikidata-Bridge-Sprint-7, Wikidata-Bridge-Sprint-6, Wikidata
Lucas_Werkmeister_WMDE created T235767: Attach event handlers to Data Bridge links as soon as possible.
Thu, Oct 17, 2:19 PM · Wikidata-Bridge, Wikidata
Lucas_Werkmeister_WMDE added a comment to T235055: Create progressive disabled version of save button.

I created T235763: Investigate broken Wikidata Bridge Storybook updates for looking into the broken storybook further.

Thu, Oct 17, 2:12 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE created T235763: Investigate broken Wikidata Bridge Storybook updates.
Thu, Oct 17, 2:11 PM · Wikidata-Bridge, Wikidata
Lucas_Werkmeister_WMDE added a comment to T233305: delayed kicking in of Bridge.

We should be able to find a configuration that works for us, instead of us working around the tool chain we picked to help us.

Thu, Oct 17, 12:16 PM · Wikidata-Bridge-Sprint-7, Wikidata-Bridge-Sprint-6, Wikidata

Yesterday

MarcoAurelio awarded T235674: Beta cluster doesn’t update since ca. 2019-10-15 21:00 UTC a Barnstar token.
Wed, Oct 16, 8:00 PM · Patch-For-Review, Release-Engineering-Team-TODO (201910), Beta-Cluster-Infrastructure
Lucas_Werkmeister_WMDE added a comment to T235055: Create progressive disabled version of save button.

Same problem here, I couldn’t get it to work (using jsub didn’t help either). For now I’d hope that it’s a temporary problem with Toolforge, and retry later?

Wed, Oct 16, 5:58 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE moved T235110: Constraint results are not cached from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Can be verified via Grafana once it’s deployed.

Wed, Oct 16, 5:57 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikidata
Lucas_Werkmeister_WMDE committed rEBQCcf559ed9c713: Revert "Add HTTP header indicating gadget to API requests" (authored by Lucas_Werkmeister_WMDE).
Revert "Add HTTP header indicating gadget to API requests"
Wed, Oct 16, 5:51 PM
Lucas_Werkmeister_WMDE committed rEBQC9317078c38ca: Cache suggestion constraint results too (authored by Lucas_Werkmeister_WMDE).
Cache suggestion constraint results too
Wed, Oct 16, 5:51 PM
Lucas_Werkmeister_WMDE created T235674: Beta cluster doesn’t update since ca. 2019-10-15 21:00 UTC.
Wed, Oct 16, 4:40 PM · Patch-For-Review, Release-Engineering-Team-TODO (201910), Beta-Cluster-Infrastructure
Lucas_Werkmeister_WMDE added a comment to T235055: Create progressive disabled version of save button.

Shouldn’t this go into the Verification column for UX to review the button?

Wed, Oct 16, 4:02 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE added a comment to T128486: [Story] Purge Special:EntityData JSON after edit.

That’s a possible workaround, of course, but it causes additional network traffic and server load.

Wed, Oct 16, 4:01 PM · Wikidata-Bridge, Story, MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE added a comment to T235622: scrollbar breaks the modal.

South of, I assume – that is, only the content excluding the header should be scrollable.

Wed, Oct 16, 3:41 PM · Wikidata, Wikidata-Bridge
Lucas_Werkmeister_WMDE added a comment to T235154: show error when editor can't edit the statement because of permission errors on the repository.

In MediaWiki core, uneditable pages display two messages: permissionserrorstext-withaction, the generic “you can’t edit this”, and then protectedpagetext or blockedtext (and cascadeprotected in case of cascade protection) with parameters detailing the cause. We should do something similar in Data Bridge, but with bridge-specific messages. The messages should also be read from the client wiki, not the repo wiki, so they can be customized via the MediaWiki namespace. @Charlie_WMDE and @Lydia_Pintscher will define the initial content of those messages, based on the MediaWiki versions, before the next story time (2019-10-22).

Wed, Oct 16, 3:28 PM · Wikidata, Wikidata-Bridge
Lucas_Werkmeister_WMDE closed T192452: Find out how many external uses the wbcheckconstraints API action has as Declined.

This never went anywhere, and I don’t think it’s really needed anymore – we’ve heard through other means that there are external users of the constraints API, so treating it as a stable interface really is the right thing to do. Closing.

Wed, Oct 16, 2:44 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE created T235651: Update wikidata-query-gui-build job versions (from Jessie, Node v6, npm v3).
Wed, Oct 16, 1:37 PM · Wikidata, Continuous-Integration-Config, Wikidata Query UI
Lucas_Werkmeister_WMDE created T235639: Decouple Query Service UI deployment from Query Service deployment.
Wed, Oct 16, 1:02 PM · Technical-Debt, Wikidata, Wikidata Query UI
Lucas_Werkmeister_WMDE updated the task description for T88258: Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration.
Wed, Oct 16, 11:54 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, Wikidata-Trailblazing-Exploration, Story, Technical-Debt, wikidata-tech-focus, Wikidata-Turtles-Tech-Debt, Wikidata-Ministry-Of-Magic-Tech-Debt, Wikidata-Sprint-2017-12-20, Wikidata-Sprint-2015-08-11, Wikidata-Sprint-2015-06-30, Wikidata-Sprint-2015-06-16, Wikidata-Sprint-2015-06-02, MediaWiki-extensions-WikibaseRepository, Wikidata, MediaWiki-extensions-WikibaseClient
Lucas_Werkmeister_WMDE added a comment to T87875: Convert all Wikimedia-deployed extensions and skins to use extension registration.

Four PHP entry points left in production:

Wed, Oct 16, 11:53 AM · MediaWiki-extensions-General, Goal, MediaWiki-Configuration
Lucas_Werkmeister_WMDE closed T228412: Deploy Citoid Wikibase integration to Test Wikidata, a subtask of T228414: Deploy Citoid Wikibase integration, as Resolved.
Wed, Oct 16, 11:38 AM · Wikidata, Citoid
Lucas_Werkmeister_WMDE closed T228412: Deploy Citoid Wikibase integration to Test Wikidata as Resolved.
Wed, Oct 16, 11:38 AM · Wikidata, Citoid
Lucas_Werkmeister_WMDE added a comment to T234345: Figure out what to do with `fatalmonitor` script.

Now the script itself has been removed from mwlog1001, it seems.

Wed, Oct 16, 11:00 AM · MediaWiki-SWAT-deployments, Deployments
Lucas_Werkmeister_WMDE updated the task description for T235622: scrollbar breaks the modal.
Wed, Oct 16, 10:58 AM · Wikidata, Wikidata-Bridge
Lucas_Werkmeister_WMDE renamed T235623: header height too big from header hight too big to header height too big.
Wed, Oct 16, 10:56 AM · Wikidata, Wikidata-Bridge
Lucas_Werkmeister_WMDE added a comment to T233305: delayed kicking in of Bridge.

I couldn’t figure out how to make it part of the app module, but extracting the dispatcher into a separate module reduces the size of the init module substantially:

Wed, Oct 16, 10:53 AM · Wikidata-Bridge-Sprint-7, Wikidata-Bridge-Sprint-6, Wikidata
Lucas_Werkmeister_WMDE closed T234094: Wikidata "Duplicate references" gadget hangs on saving copied reference as Resolved.
Wed, Oct 16, 9:36 AM · User-Ladsgroup, Wikidata-Gadgets, Wikidata.org, Wikidata-Campsite, RL Module Terminators Trailblazing, Wikidata

Tue, Oct 15

Lucas_Werkmeister_WMDE closed T235532: Export CI=true environment variable in Wikimedia CI as Resolved.

Okay, https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/24694/consoleFull has progressed far enough to see the effect of this build. There’s still some logspam due to the existence of the core-js postinstall script –

Tue, Oct 15, 6:41 PM · Release-Engineering-Team-TODO (201910), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Config
Lucas_Werkmeister_WMDE moved T229241: restrict length of string value input from Doing to Verification on the Wikidata-Bridge-Sprint-7 board.
Tue, Oct 15, 6:36 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE closed T235037: Set up RepoConfigRepository in init and pass into launch / app, a subtask of T229241: restrict length of string value input, as Resolved.
Tue, Oct 15, 6:36 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE closed T235037: Set up RepoConfigRepository in init and pass into launch / app as Resolved.
Tue, Oct 15, 6:36 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE closed T235040: Get max string length from store to ResizingTextField, a subtask of T229241: restrict length of string value input, as Resolved.
Tue, Oct 15, 6:35 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE closed T235040: Get max string length from store to ResizingTextField as Resolved.
Tue, Oct 15, 6:35 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE closed T235038: Read RepoConfigRepository in bridge init action and store config, a subtask of T229241: restrict length of string value input, as Resolved.
Tue, Oct 15, 6:35 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE closed T235038: Read RepoConfigRepository in bridge init action and store config as Resolved.
Tue, Oct 15, 6:35 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE added a comment to T235532: Export CI=true environment variable in Wikimedia CI.

Thanks, I’ll try to find some Wikibase build to trigger.

Tue, Oct 15, 6:13 PM · Release-Engineering-Team-TODO (201910), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Config
Lucas_Werkmeister_WMDE added a comment to T235540: SPARQL query causes StackOverflowError and fails to execute.

@Evilricepuddin workaround: in

Tue, Oct 15, 6:07 PM · Wikidata, Wikidata-Query-Service
Lucas_Werkmeister_WMDE added a comment to T235540: SPARQL query causes StackOverflowError and fails to execute.

Ah, thanks – in that case, the method was introduced in I0605e725c4 to fix T172113: ConcurrentModificationException on non-grouping query with aggregates in SELECT.

Tue, Oct 15, 6:05 PM · Wikidata, Wikidata-Query-Service
Lucas_Werkmeister_WMDE updated subscribers of T235540: SPARQL query causes StackOverflowError and fails to execute.

Possibly related to @Igorkim78’s work in T168876: MWAPI service throws “could not find binding for parameter” if optimizer is not disabled? I306907e175 mentions that class, at least. (The upstream version of StaticAnalysis doesn’t have a collectVarsFromExpressions method, by the way, so I’m not sure what version of the class we’re using and what repository it’s in.)

Tue, Oct 15, 5:56 PM · Wikidata, Wikidata-Query-Service
Lucas_Werkmeister_WMDE updated the task description for T140852: Load all Wikimedia-deployed extensions and skins via extension registration.
Tue, Oct 15, 5:42 PM · Patch-For-Review, MediaWiki-extensions-General, Goal, Wikimedia-Site-requests
Lucas_Werkmeister_WMDE added a comment to T87915: Convert FlaggedRevs to use extension registration.

Note: the migration was finished in https://gerrit.wikimedia.org/r/514508, which was not attached to this task. (Also, the PHP entry point is still used in production, but I figure it’s not worth reopening this task for that.)

Tue, Oct 15, 5:32 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), MediaWiki-extensions-FlaggedRevs
Lucas_Werkmeister_WMDE moved T235037: Set up RepoConfigRepository in init and pass into launch / app from Doing to Peer Review on the Wikidata-Bridge-Sprint-7 board.
Tue, Oct 15, 5:02 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE added a comment to T235037: Set up RepoConfigRepository in init and pass into launch / app.

(it was rather more than one line, especially when including the changes it required in other commits)

Tue, Oct 15, 5:02 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE claimed T235037: Set up RepoConfigRepository in init and pass into launch / app.
Tue, Oct 15, 4:13 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE created T235532: Export CI=true environment variable in Wikimedia CI.
Tue, Oct 15, 4:04 PM · Release-Engineering-Team-TODO (201910), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Config
Lucas_Werkmeister_WMDE updated subscribers of T235152: don't show bridge edit pens when editor can't edit the article.

The discussion in T231209 assumes that we do this via JS, by checking mw.config.get( 'wgIsProbablyEditable' ). But I think we can do this via CSS, depending on the mw-editable class on the surrounding body (added in T208315) – that CSS could either be part of the init module, or be added PHP-side so it doesn’t even have to wait for ResourceLoader. I think this would be more efficient and better for the user (no flash of unhidden edit buttons before we get around to hiding them).

Tue, Oct 15, 1:06 PM · Wikidata, Wikidata-Bridge
Lucas_Werkmeister_WMDE added a comment to T233305: delayed kicking in of Bridge.

Good point – perhaps we can build another commonjs bundle and include that in the app ResourceLoader module.

Tue, Oct 15, 12:41 PM · Wikidata-Bridge-Sprint-7, Wikidata-Bridge-Sprint-6, Wikidata

Mon, Oct 14

Lucas_Werkmeister_WMDE moved T235038: Read RepoConfigRepository in bridge init action and store config from Doing to Peer Review on the Wikidata-Bridge-Sprint-7 board.
Mon, Oct 14, 5:08 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE moved T235040: Get max string length from store to ResizingTextField from Doing to Peer Review on the Wikidata-Bridge-Sprint-7 board.
Mon, Oct 14, 4:26 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE claimed T235040: Get max string length from store to ResizingTextField.
Mon, Oct 14, 3:35 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE moved T235038: Read RepoConfigRepository in bridge init action and store config from Peer Review to Doing on the Wikidata-Bridge-Sprint-7 board.
Mon, Oct 14, 3:33 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE added a comment to T235037: Set up RepoConfigRepository in init and pass into launch / app.

This should already be enough to unblock T235038: Read RepoConfigRepository in bridge init action and store config, though.

Mon, Oct 14, 3:33 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE placed T235037: Set up RepoConfigRepository in init and pass into launch / app up for grabs.
Mon, Oct 14, 3:18 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE moved T235038: Read RepoConfigRepository in bridge init action and store config from Doing to Peer Review on the Wikidata-Bridge-Sprint-7 board.
Mon, Oct 14, 2:41 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE claimed T235038: Read RepoConfigRepository in bridge init action and store config.
Mon, Oct 14, 1:24 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE added a comment to T235038: Read RepoConfigRepository in bridge init action and store config.

In principle, I think we could read the configuration asynchronously, just like we read the property label asynchronously, and update the input’s maxlength once we know it. But once we implement T235154, we’ll probably want to combine the API calls, and those ones should definitely be blocking, so we might as well make this blocking as well. It shouldn’t take too long anyways, hopefully.

Mon, Oct 14, 1:18 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE added a comment to T235037: Set up RepoConfigRepository in init and pass into launch / app.

The above change only implements part of this task – the rest is blocked on T235036: Implement RepoConfigRepository via wbdatabridgeconfig API. This should already be enough to unblock T235038: Read RepoConfigRepository in bridge init action and store config, though.

Mon, Oct 14, 12:58 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE moved T235037: Set up RepoConfigRepository in init and pass into launch / app from Doing to Peer Review on the Wikidata-Bridge-Sprint-7 board.
Mon, Oct 14, 12:57 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE claimed T235037: Set up RepoConfigRepository in init and pass into launch / app.
Mon, Oct 14, 12:47 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE added a comment to T234769: Localise Scribunto strings for ban.

Note: the above change is only on master, not on 1.35.0-wmf.1, so banwiki will exist without localized Scribunto strings for a few days, if I’m not mistaken.

Mon, Oct 14, 12:23 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), I18n, MediaWiki-extensions-Scribunto
Lucas_Werkmeister_WMDE closed T235034: Add wbdatabridgeconfig API to repo, a subtask of T229241: restrict length of string value input, as Resolved.
Mon, Oct 14, 12:11 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE closed T235034: Add wbdatabridgeconfig API to repo as Resolved.
Mon, Oct 14, 12:11 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE added a comment to T228412: Deploy Citoid Wikibase integration to Test Wikidata.

As pointed out in the Gerrit comments, $wgWBCitoidFullRestbaseURL still needs to be set (most likely to http://en.wikipedia.org/api/rest_) to fully enable Citoid integration on Test Wikidata.

Mon, Oct 14, 11:52 AM · Wikidata, Citoid
Lucas_Werkmeister_WMDE added a comment to T234345: Figure out what to do with `fatalmonitor` script.

And this version of the link only shows the past 5 minutes and auto-updates itself every 5 seconds:

Mon, Oct 14, 11:49 AM · MediaWiki-SWAT-deployments, Deployments
Lucas_Werkmeister_WMDE added a comment to T235389: IP Address ranges (CIDR) are stored as strings and cannot be queried.

This is problematic though, as that database would not be part of Wikimedia production and therefore cannot be accessed from another wiki directly.

Mon, Oct 14, 11:28 AM · Wikidata, MediaWiki-extensions-WikibaseRepository

Fri, Oct 11

Lucas_Werkmeister_WMDE added a comment to T234313: Delete wikidata-shex test system.

Some parts of the config might also be useful elsewhere.

Fri, Oct 11, 6:32 PM · Wikidata, Cloud-VPS, Shape Expressions
Lucas_Werkmeister_WMDE closed T234313: Delete wikidata-shex test system as Resolved.
Fri, Oct 11, 6:24 PM · Wikidata, Cloud-VPS, Shape Expressions
Lucas_Werkmeister_WMDE added a comment to T222416: WikibaseMediaInfo test MultiLingualCaptionsTest fails.

Yeah, I think there’s some off-by-one errors in the dictionary line selection:

Fri, Oct 11, 5:28 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, ci-test-error, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikimedia-production-error (Shared Build Failure), WikibaseMediaInfo
Lucas_Werkmeister_WMDE added a comment to T222416: WikibaseMediaInfo test MultiLingualCaptionsTest fails.

But it looks like RandomImageGenerator::getRandomFilenames() always generates file names from a pair of words, e. g. foo_bar.jpg.

Fri, Oct 11, 5:12 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, ci-test-error, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikimedia-production-error (Shared Build Failure), WikibaseMediaInfo
Lucas_Werkmeister_WMDE added a comment to T222581: Missing prerequisites in installation guide.

The above patch removes the fibers dependency completely, hopefully that works better on newer node versions – can one of you try it out?

Fri, Oct 11, 4:59 PM · Patch-For-Review, Wikidata-Campsite, Wikidata, Wikidata Query UI
Lucas_Werkmeister_WMDE added a comment to T185508: Show “internal” API module help flag in Special:ApiSandbox.

Seems to be working on Beta.

Fri, Oct 11, 3:24 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Lucas_Werkmeister_WMDE added a comment to T233395: more precise edit summaries for Bridge edits.

Story writing remark: This may need an investigation as to why we are currently not getting more specific edit summaries. Shouldn't there be a diff happening on the server side?

Fri, Oct 11, 12:49 PM · Wikidata, Wikidata-Bridge
Lucas_Werkmeister_WMDE closed T235035: Define RepoConfigRepository interface, a subtask of T229241: restrict length of string value input, as Resolved.
Fri, Oct 11, 12:12 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE closed T235035: Define RepoConfigRepository interface as Resolved.
Fri, Oct 11, 12:12 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE added a comment to T233003: Step 1: WikibaseQualityConstraints should link using SpecialMyLanguage.

Side note: the link is a bit broken anyways at the moment… it links to Wikidata’s Help:Property constraints portal/constraint item ID, and there are redirects from the item IDs to the real documentation subpages, but that only works when the same constraint item ID as on Wikidata is used – for example, on my local test wiki, the “format constraint” item is Q251, so the help link sends me to Help:Property constraints portal/Q251, which doesn’t exist. I suppose fixing that is out of the scope of this task, though.

Fri, Oct 11, 10:49 AM · Wikibase-Quality-Constraints, Wikidata, Wikidata Tainted References
Lucas_Werkmeister_WMDE updated the task description for T233003: Step 1: WikibaseQualityConstraints should link using SpecialMyLanguage.
Fri, Oct 11, 10:46 AM · Wikibase-Quality-Constraints, Wikidata, Wikidata Tainted References

Thu, Oct 10

Lucas_Werkmeister_WMDE added a comment to T185508: Show “internal” API module help flag in Special:ApiSandbox.

Yeah, I noticed while working on the above patch how little this actually has to do with the API sandbox itself :)

Thu, Oct 10, 4:05 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Lucas_Werkmeister_WMDE added a comment to T185508: Show “internal” API module help flag in Special:ApiSandbox.

Hm, this is a bit tricky because there’s some correspondence between “this module is deprecated” (make isDeprecated() return true) and “the parameter value specifying this module is deprecated” (ApiBase::PARAM_DEPRECATED), whereas there’s no such thing as internal parameter values. I’m not yet sure if that’s a big problem.

Thu, Oct 10, 3:31 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Lucas_Werkmeister_WMDE closed T235039: Add maxlength attribute to ResizingTextField, a subtask of T229241: restrict length of string value input, as Resolved.
Thu, Oct 10, 3:12 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE closed T235039: Add maxlength attribute to ResizingTextField as Resolved.
Thu, Oct 10, 3:12 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), User-Michael, Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE added a comment to T185508: Show “internal” API module help flag in Special:ApiSandbox.

The 'internal' flag isn't available when building the list. You'd have to adjust the output from action=paraminfo for submodule-type parameters to somehow include it.

Thu, Oct 10, 3:05 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Lucas_Werkmeister_WMDE renamed T185508: Show “internal” API module help flag in Special:ApiSandbox from Show “internal” and other API module help flags in Special:ApiSandbox to Show “internal” API module help flag in Special:ApiSandbox.
Thu, Oct 10, 2:23 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Lucas_Werkmeister_WMDE moved T235034: Add wbdatabridgeconfig API to repo from Doing to Peer Review on the Wikidata-Bridge-Sprint-7 board.
Thu, Oct 10, 2:23 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Wikidata-Bridge-Sprint-7, Wikidata
Restricted Application added a project to T185508: Show “internal” API module help flag in Special:ApiSandbox: Core Platform Team.

Unless someone has a better suggestion, I’d display internal modules similar to deprecated ones: ordered at the end of the module list, strikethrough on the label, and with a bold red notice before the summary message. (If we’re feeling adventurous, make the notice yellow instead of red?)

Thu, Oct 10, 2:10 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Lucas_Werkmeister_WMDE added a comment to T235034: Add wbdatabridgeconfig API to repo.

Depends on whether submodules can be marked as internal, though.

Thu, Oct 10, 1:16 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE claimed T235034: Add wbdatabridgeconfig API to repo.
Thu, Oct 10, 12:05 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE closed T235033: Set dataBridgeEnabled repo setting on Beta, a subtask of T229241: restrict length of string value input, as Resolved.
Thu, Oct 10, 11:44 AM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE closed T235033: Set dataBridgeEnabled repo setting on Beta as Resolved.

Looks okay on Beta now.

Thu, Oct 10, 11:44 AM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE moved T235033: Set dataBridgeEnabled repo setting on Beta from Doing to Verification on the Wikidata-Bridge-Sprint-7 board.
Thu, Oct 10, 11:42 AM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE moved T235033: Set dataBridgeEnabled repo setting on Beta from Verification to Doing on the Wikidata-Bridge-Sprint-7 board.
Thu, Oct 10, 11:36 AM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE moved T235033: Set dataBridgeEnabled repo setting on Beta from Doing to Verification on the Wikidata-Bridge-Sprint-7 board.

Moving to verification for checking if the setting is true on Beta, once the automatic sync has deployed the changes there.

Thu, Oct 10, 11:24 AM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE added a comment to T235159: Enable write access for Mathew.onipe(onimisionipe) and gehel on wikidata gui repo.

…though they might not necessarily know what to do with it :)

Thu, Oct 10, 10:45 AM · Discovery-Search (Current work), Wikidata-Query-Service, Gerrit-Privilege-Requests, Wikidata
Lucas_Werkmeister_WMDE claimed T235033: Set dataBridgeEnabled repo setting on Beta.
Thu, Oct 10, 10:41 AM · Wikidata-Bridge-Sprint-7, Wikidata

Wed, Oct 9

Lucas_Werkmeister_WMDE closed T235032: Add dataBridgeEnabled setting to repo config, a subtask of T229241: restrict length of string value input, as Resolved.
Wed, Oct 9, 4:16 PM · Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE closed T235032: Add dataBridgeEnabled setting to repo config as Resolved.
Wed, Oct 9, 4:16 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Wikidata-Bridge-Sprint-7, Wikidata
Lucas_Werkmeister_WMDE claimed T235110: Constraint results are not cached.
Wed, Oct 9, 4:07 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikidata