Page MenuHomePhabricator

Lucas_Werkmeister_WMDE (Lucas Werkmeister (WMDE))
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 3 2017, 2:45 PM (164 w, 6 d)
Availability
Available
IRC Nick
Lucas_WMDE
LDAP User
Lucas Werkmeister (WMDE)
MediaWiki User
Lucas Werkmeister (WMDE) [ Global Accounts ]

Software developer on the Wikidata team at Wikimedia Germany. Private account: @LucasWerkmeister.

Recent Activity

Fri, May 29

Lucas_Werkmeister_WMDE added a comment to T254027: Can we scrap the `wikidata/query/gui-deploy` repo, or is it being used?.

It is used, but with the deployment branch, not the master branch: https://gerrit.wikimedia.org/r/plugins/gitiles/wikidata/query/gui-deploy/+log/production

Fri, May 29, 5:30 PM · Patch-For-Review, Continuous-Integration-Config, Wikidata, Discovery-Search, Wikidata-Campsite, Wikidata-Query-Service
Lucas_Werkmeister_WMDE updated the task description for T253211: Use of modern TypeScript (syntax).
Fri, May 29, 5:06 PM · Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE updated the task description for T253211: Use of modern TypeScript (syntax).
Fri, May 29, 4:19 PM · Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE claimed T253207: Centralize Wikibase types of Data Bridge.

Should’ve claimed this and moved it to Doing a few hours ago, sorry. But here it is.

Fri, May 29, 3:53 PM · Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE updated the task description for T253207: Centralize Wikibase types of Data Bridge.
Fri, May 29, 3:53 PM · Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE closed T253202: dist/ size (both init and app module) as Resolved.

I think this can be closed now, we’ve made a lot of improvements here.

Fri, May 29, 9:46 AM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE closed T253846: Serve modern JavaScript to modern clients, a subtask of T253202: dist/ size (both init and app module), as Resolved.
Fri, May 29, 9:37 AM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE closed T253846: Serve modern JavaScript to modern clients as Resolved.

Seems to be working on Beta, including in IE11.

Fri, May 29, 9:37 AM · Bridge Technical Improvements

Thu, May 28

Lucas_Werkmeister_WMDE added a subtask for T253202: dist/ size (both init and app module): T253846: Serve modern JavaScript to modern clients.
Thu, May 28, 4:18 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE added a parent task for T253846: Serve modern JavaScript to modern clients: T253202: dist/ size (both init and app module).
Thu, May 28, 4:18 PM · Bridge Technical Improvements
Lucas_Werkmeister_WMDE updated the task description for T253211: Use of modern TypeScript (syntax).
Thu, May 28, 3:22 PM · Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE moved T253211: Use of modern TypeScript (syntax) from To do to Peer Review on the Bridge Technical Improvements board.
Thu, May 28, 3:20 PM · Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE added a comment to T253211: Use of modern TypeScript (syntax).

I’ll pick the readonly part, since it seems relatively easy to grep for that.

Thu, May 28, 1:59 PM · Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE added a comment to T253646: element ("#data-bridge-app") still displayed after 10000ms.

Apparently the screenshot looks like this:


Video is here (it doesn’t play in my Firefox but works in VLC after downloading).

Thu, May 28, 1:52 PM · Bridge Technical Improvements, Wikidata-Campsite, ci-test-error (WMF-deployed Build Failure), Wikidata
Lucas_Werkmeister_WMDE placed T253208: Split off more page objects in Data Bridge browser tests up for grabs.

Both of the above changes got +2ed, so unassigning myself and moving back to TODO. (I think there’s still a few page objects to be extracted, though we’re probably getting diminishing returns already.)

Thu, May 28, 1:40 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Bridge Technical Improvements
Lucas_Werkmeister_WMDE moved T253202: dist/ size (both init and app module) from Doing to Peer Review on the Bridge Technical Improvements board.
Thu, May 28, 1:34 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE moved T253846: Serve modern JavaScript to modern clients from Doing to Peer Review on the Bridge Technical Improvements board.
Thu, May 28, 11:18 AM · Bridge Technical Improvements
Lucas_Werkmeister_WMDE moved T253846: Serve modern JavaScript to modern clients from To do to Doing on the Bridge Technical Improvements board.
Thu, May 28, 10:47 AM · Bridge Technical Improvements
Lucas_Werkmeister_WMDE created T253846: Serve modern JavaScript to modern clients.
Thu, May 28, 10:47 AM · Bridge Technical Improvements
Lucas_Werkmeister_WMDE updated the task description for T253210: backlog of unmerged Gerrit changes.
Thu, May 28, 10:19 AM · Bridge Technical Improvements
Lucas_Werkmeister_WMDE added a comment to T253211: Use of modern TypeScript (syntax).
  • the Omit helper type: Omit<TypeName, "memberName">; I think I introduced a duplicate of that in MwApiParameters, something like MwApiParamsWithout?
Thu, May 28, 10:11 AM · Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE added a comment to T253211: Use of modern TypeScript (syntax).

Regarding assertion signatures, I left them out of my list because I didn’t remember any assertion functions we had, and so I thought the ability to correctly type them wasn’t very important. But maybe we want to refactor some of our current type checking functions (returning x is Type), when they are called only to throw an error if they don’t match, into assertion funtions?

Thu, May 28, 9:58 AM · Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE added a comment to T253211: Use of modern TypeScript (syntax).

Thanks! I spotted additionally:

Thu, May 28, 9:57 AM · Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE updated the task description for T253211: Use of modern TypeScript (syntax).
Thu, May 28, 9:51 AM · Patch-For-Review, Bridge Technical Improvements

Wed, May 27

Lucas_Werkmeister_WMDE closed T253771: WDQS gives dates that are two days ealier than reported on the item page and the API as Resolved.
Wed, May 27, 5:23 PM · Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T253210: backlog of unmerged Gerrit changes.
Wed, May 27, 5:20 PM · Bridge Technical Improvements
Lucas_Werkmeister_WMDE added a comment to T253771: WDQS gives dates that are two days ealier than reported on the item page and the API.

The user interface and the API show you the original date value and its calendar model, which in this case is the Julian calendar. The RDF export, on the other hand, always converts dates to the proleptic Gregorian calendar (source). I assume that’s the cause for this apparent discrepancy (two days sounds roughly in the right ballpark for a date some half a century after Caesar’s death).

Wed, May 27, 5:05 PM · Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T253771: WDQS gives dates that are two days ealier than reported on the item page and the API.
Wed, May 27, 5:00 PM · Wikidata-Query-Service, Wikidata
Lucas_Werkmeister_WMDE added a comment to T253766: Exception thrown by TermStoreWriterFactory when using API on commons beta cluster.

The code throwing the exception:

Wed, May 27, 4:49 PM · WMDE-QWERTY-Sprint-2020-05-27, Beta-Cluster-Infrastructure, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T253210: backlog of unmerged Gerrit changes.
Wed, May 27, 2:07 PM · Bridge Technical Improvements
Lucas_Werkmeister_WMDE closed T253205: Evaluate libraries as alternative to home-grown error serialization as Resolved.
Wed, May 27, 12:54 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE updated the task description for T253210: backlog of unmerged Gerrit changes.
Wed, May 27, 12:52 PM · Bridge Technical Improvements
Lucas_Werkmeister_WMDE updated the task description for T253210: backlog of unmerged Gerrit changes.
Wed, May 27, 12:39 PM · Bridge Technical Improvements
Lucas_Werkmeister_WMDE added a comment to T253211: Use of modern TypeScript (syntax).

I think the notable changes are:

Wed, May 27, 11:41 AM · Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE added a comment to T251514: UI for SPARQL Endpoint for Commons.

in the wdqs gui the search ultimately happens here https://github.com/wikimedia/wikidata-query-gui/blob/b49263487713775140201c8adb7bc3fcf1c67fd8/wikibase/queryService/api/Wikibase.js#L81-L97 right now always hardcoded to wikidata.org

Wed, May 27, 11:28 AM · Wikidata, Wikidata-Query-Service
Lucas_Werkmeister_WMDE added a comment to T253205: Evaluate libraries as alternative to home-grown error serialization.

(We should probably also have tests for this, if we don’t have them already.)

Wed, May 27, 11:18 AM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE added a comment to T253718: WDQ should reject invalid datetime literals.

This is probably a Blazegraph thing, not sure how much influence we have over it. But I disagree that it should be fixed – FILTER(?dateOfDeath >= "2020-01-01"^^xsd:dateTime) is much more convenient to write, and in my opinion also more legible, than FILTER(?dateOfDeath >= "2020-01-01T00:00:00"^^xsd:dateTime).

Wed, May 27, 9:41 AM · Wikidata, Wikidata-Query-Service

Tue, May 26

Lucas_Werkmeister_WMDE moved T253208: Split off more page objects in Data Bridge browser tests from Doing to Peer Review on the Bridge Technical Improvements board.
Tue, May 26, 4:20 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Bridge Technical Improvements
Lucas_Werkmeister_WMDE claimed T253208: Split off more page objects in Data Bridge browser tests.
Tue, May 26, 3:46 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Bridge Technical Improvements
Lucas_Werkmeister_WMDE closed T252079: mw.wikibase.getLabelByLang('Q1','en') returning nil today as Resolved.

The test cases linked in the task description work again, and this bug is/was severe enough that if it still happened, I’m sure we would’ve heard of it. That’s good enough for me, at least.

Tue, May 26, 10:24 AM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Wikibase - Federated Properties (Sprint 5/6 (Hike 1)), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
Lucas_Werkmeister_WMDE changed the status of T248840: Don’t polyfill Promise in Bridge modules from Open to Stalled.
Tue, May 26, 9:15 AM · Patch-For-Review, Bridge Technical Improvements, wikidata-tech-focus, Wikidata
Lucas_Werkmeister_WMDE changed the status of T248840: Don’t polyfill Promise in Bridge modules, a subtask of T246456: Performance review of Wikidata Bridge, from Open to Stalled.
Tue, May 26, 9:15 AM · Wikidata, Wikidata-Bridge, Performance-Team
Lucas_Werkmeister_WMDE moved T248840: Don’t polyfill Promise in Bridge modules from To do to Doing on the Bridge Technical Improvements board.
Tue, May 26, 9:15 AM · Patch-For-Review, Bridge Technical Improvements, wikidata-tech-focus, Wikidata
Lucas_Werkmeister_WMDE added a comment to T248840: Don’t polyfill Promise in Bridge modules.

Thanks Michael, that all sounds right to me. I uploaded the partial patch above, though without the upstream change it doesn’t reduce the dist/ size at all.

Tue, May 26, 8:29 AM · Patch-For-Review, Bridge Technical Improvements, wikidata-tech-focus, Wikidata
Lucas_Werkmeister_WMDE added a comment to T232584: Step 1: Production deployment checklist.

Also, we still need the “Data Bridge” tag to be created on Wikidata. I guess one of us (Léa) should ask on WD:AN?

Tue, May 26, 8:12 AM · Patch-For-Review, wikidata-tech-focus, Wikidata, Wikidata-Bridge
Lucas_Werkmeister_WMDE added a comment to T232584: Step 1: Production deployment checklist.

@Lydia_Pintscher: my second config change above also enables the feature for Wikidata itself. Does that make sense or should Wikidata wait until later? (Technically, I think it would be possible to enable the repo-only parts, which cawiki needs to function, from the client parts, but I don’t know if that makes much sense.)

Only allowing it on Catalan would be best but if it's a significant amount of effort to make that happen then I'd say we can live with it.

Tue, May 26, 7:33 AM · Patch-For-Review, wikidata-tech-focus, Wikidata, Wikidata-Bridge

Mon, May 25

Lucas_Werkmeister_WMDE added a comment to T248840: Don’t polyfill Promise in Bridge modules.

See also this AC/DC commit, where I excluded the Promise polyfill in a plain webpack project. Hopefully it’s not a lot more complicated in conjunction with vue-cli-service.

Mon, May 25, 12:40 PM · Patch-For-Review, Bridge Technical Improvements, wikidata-tech-focus, Wikidata
Lucas_Werkmeister_WMDE updated subscribers of T232584: Step 1: Production deployment checklist.

@Lydia_Pintscher: my second config change above also enables the feature for Wikidata itself. Does that make sense or should Wikidata wait until later? (Technically, I think it would be possible to enable the repo-only parts, which cawiki needs to function, from the client parts, but I don’t know if that makes much sense.)

Mon, May 25, 9:11 AM · Patch-For-Review, wikidata-tech-focus, Wikidata, Wikidata-Bridge

Wed, May 20

Lucas_Werkmeister_WMDE closed T252683: Track errors people encounter when using the Bridge as Resolved.

Then I think this is done!

Wed, May 20, 4:53 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), User-Michael, Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE moved T252683: Track errors people encounter when using the Bridge from Peer Review to Doing on the Wikidata-Bridge-Sprint-20 board.

Changes are merged, I guess we still need to actually create the graph?

Wed, May 20, 1:53 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), User-Michael, Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE created T253208: Split off more page objects in Data Bridge browser tests.
Wed, May 20, 10:20 AM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Bridge Technical Improvements
Lucas_Werkmeister_WMDE created T253207: Centralize Wikibase types of Data Bridge.
Wed, May 20, 10:20 AM · Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE created T253206: Centralize MediaWiki types of Data Bridge.
Wed, May 20, 10:20 AM · Bridge Technical Improvements
Lucas_Werkmeister_WMDE created T253205: Evaluate libraries as alternative to home-grown error serialization.
Wed, May 20, 10:20 AM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Patch-For-Review, Bridge Technical Improvements
Lucas_Werkmeister_WMDE created T253204: Provide observability of Data Bridge bundle sizes over time.
Wed, May 20, 10:20 AM · Patch-For-Review, Bridge Technical Improvements

Tue, May 19

Lucas_Werkmeister_WMDE committed rEWCS49044e4cea3e: Update for namespace moves (authored by Lucas_Werkmeister_WMDE).
Update for namespace moves
Tue, May 19, 3:52 PM
Lucas_Werkmeister_WMDE moved T249343: Can not "Publish changes" - RadioInput selection not detected in IE11 from To Do to Done on the Wikibase-VueJs-Components board.
Tue, May 19, 2:24 PM · Patch-For-Review, Wikidata-Bridge-Sprint-20, wikidata-tech-focus, Wikibase-VueJs-Components, Browser-Support-Internet-Explorer, Wikidata
Lucas_Werkmeister_WMDE closed T249343: Can not "Publish changes" - RadioInput selection not detected in IE11 as Resolved.

Verified in a Win10 VM that Data Bridge is usable now.

Tue, May 19, 2:23 PM · Patch-For-Review, Wikidata-Bridge-Sprint-20, wikidata-tech-focus, Wikibase-VueJs-Components, Browser-Support-Internet-Explorer, Wikidata
Lucas_Werkmeister_WMDE moved T249343: Can not "Publish changes" - RadioInput selection not detected in IE11 from Peer Review to Verification on the Wikidata-Bridge-Sprint-20 board.
Tue, May 19, 2:17 PM · Patch-For-Review, Wikidata-Bridge-Sprint-20, wikidata-tech-focus, Wikibase-VueJs-Components, Browser-Support-Internet-Explorer, Wikidata
Lucas_Werkmeister_WMDE added a comment to T244361: Step 1: Error messages: Edit conflict (on save).

The only way we’ve found so far is to go to the item in the second tab and completely remove the statement that’s being edited in the first tab. (See also T252433, especially the “problem” section.)

Tue, May 19, 1:35 PM · Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE added a comment to T253064: Declaration of function onLoginFormValidErrorMessages($messages) : void should be compatible with function onLoginFormValidErrorMessages(array $messages).

Ugh. Quoting myself from the commit message:

Tue, May 19, 1:32 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Campsite, Wikidata, MediaWiki-extensions-WikibaseClient

Mon, May 18

Lucas_Werkmeister_WMDE closed T252449: DataBridgePage.bridge.isDisplayed() test failure as Resolved.

No further reports in almost a week, let’s close this I guess. (If anyone sees it feel free to reopen, or create a new task.)

Mon, May 18, 5:42 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Wikidata-Bridge-Sprint-19, ci-test-error (WMF-deployed Build Failure), Wikidata
Lucas_Werkmeister_WMDE moved T198703: Form grammatical features: Form field labels not connected from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, May 18, 5:41 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wikidata-tech-focus, Wikidata, Lexicographical data
Lucas_Werkmeister_WMDE added a comment to T252996: Bridge: rename "wrong value" into "incorrect value".

Second Gerrit change is still open…

Mon, May 18, 5:40 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE moved T247690: Detail of error message is no longer shown in Wikidata edit interface from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Should be possible to verify on Beta now; I’ve set up an AbuseFilter on Beta that mirrors the P​21 one on Wikidata, so if you try to add “sex or gender” (here, P​963) with an invalid value (e. g. Q​6) to an item, you should get an error, and see the detail in the error message.

Mon, May 18, 5:21 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Regression, Wikidata
Lucas_Werkmeister_WMDE moved T244361: Step 1: Error messages: Edit conflict (on save) from Doing to Verification on the Wikidata-Bridge-Sprint-20 board.
Mon, May 18, 4:14 PM · Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE closed T251401: Wire up the merge conflict error in ErrorWrapper as Resolved.
Mon, May 18, 4:14 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE closed T251401: Wire up the merge conflict error in ErrorWrapper, a subtask of T244361: Step 1: Error messages: Edit conflict (on save), as Resolved.
Mon, May 18, 4:14 PM · Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE closed T251402: Reload page in case reload button or x button gets clicked as Resolved.
Mon, May 18, 4:14 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE closed T251402: Reload page in case reload button or x button gets clicked, a subtask of T244361: Step 1: Error messages: Edit conflict (on save), as Resolved.
Mon, May 18, 4:14 PM · Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE added a comment to T252800: Regression: Option add links in other languages has disappeared.

Note that there’s no train this week (releng offsite, apparently), so this would remain unfixed until next Wednesday/Thursday.

Mon, May 18, 3:17 PM · Notice, Language-Team, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Patch-For-Review, Regression, Readers-Web-Backlog (Kanbanana-2019-20-Q4), Vector, Wikidata
Lucas_Werkmeister_WMDE moved T252996: Bridge: rename "wrong value" into "incorrect value" from Doing to Peer Review on the Wikidata-Bridge-Sprint-20 board.
Mon, May 18, 3:01 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE claimed T252996: Bridge: rename "wrong value" into "incorrect value".
Mon, May 18, 2:53 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE closed T252803: AffectedPagesFinder: Call to a member function exists() on null as Resolved.

No new occurrences, seems to be fixed indeed.

Mon, May 18, 1:22 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), MediaWiki-extensions-WikibaseClient, Wikidata-Campsite, Wikidata, Wikimedia-production-error
Lucas_Werkmeister_WMDE added a comment to T252803: AffectedPagesFinder: Call to a member function exists() on null.

Backport deployed. In the past 24 hours, Logstash has mostly had a handful of occurrences of this per hour (from group0 and group1); I’ll check later if those are gone now.

Mon, May 18, 11:32 AM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), MediaWiki-extensions-WikibaseClient, Wikidata-Campsite, Wikidata, Wikimedia-production-error
Lucas_Werkmeister_WMDE moved T247250: Step 1: Error messages: user is logged out but can continue editing as IP or log in (on save) from Doing to Verification on the Wikidata-Bridge-Sprint-20 board.
Mon, May 18, 10:07 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata-Bridge-Sprint-19, Wikidata
Lucas_Werkmeister_WMDE closed T251397: Wire dedicated error component into ErrorWrapper as Resolved.
Mon, May 18, 10:06 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata-Bridge-Sprint-19, Wikidata
Lucas_Werkmeister_WMDE closed T251397: Wire dedicated error component into ErrorWrapper, a subtask of T247250: Step 1: Error messages: user is logged out but can continue editing as IP or log in (on save), as Resolved.
Mon, May 18, 10:06 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata-Bridge-Sprint-19, Wikidata

Fri, May 15

Lucas_Werkmeister_WMDE closed T227952: Autocomplete SPARQL variables names inside BMP as Resolved.

This was deployed last week and is working now (example).

Fri, May 15, 4:20 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Patch-For-Review, Wikidata
Lucas_Werkmeister_WMDE moved T249343: Can not "Publish changes" - RadioInput selection not detected in IE11 from Doing to Peer Review on the Wikidata-Bridge-Sprint-20 board.
Fri, May 15, 12:35 PM · Patch-For-Review, Wikidata-Bridge-Sprint-20, wikidata-tech-focus, Wikibase-VueJs-Components, Browser-Support-Internet-Explorer, Wikidata
Lucas_Werkmeister_WMDE claimed T249343: Can not "Publish changes" - RadioInput selection not detected in IE11.
Fri, May 15, 12:26 PM · Patch-For-Review, Wikidata-Bridge-Sprint-20, wikidata-tech-focus, Wikibase-VueJs-Components, Browser-Support-Internet-Explorer, Wikidata
Lucas_Werkmeister_WMDE moved T244361: Step 1: Error messages: Edit conflict (on save) from To do to Doing on the Wikidata-Bridge-Sprint-20 board.
Fri, May 15, 11:51 AM · Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE moved T251402: Reload page in case reload button or x button gets clicked from Doing to Peer Review on the Wikidata-Bridge-Sprint-20 board.
Fri, May 15, 11:50 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE moved T251401: Wire up the merge conflict error in ErrorWrapper from Doing to Peer Review on the Wikidata-Bridge-Sprint-20 board.
Fri, May 15, 11:50 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE claimed T251401: Wire up the merge conflict error in ErrorWrapper.
Fri, May 15, 10:39 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE claimed T251402: Reload page in case reload button or x button gets clicked.
Fri, May 15, 10:21 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE closed T252499: Purge page as soon as edit conflict is detected, a subtask of T244361: Step 1: Error messages: Edit conflict (on save), as Resolved.
Fri, May 15, 10:14 AM · Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE closed T252499: Purge page as soon as edit conflict is detected as Resolved.
Fri, May 15, 10:14 AM · User-Michael, Wikidata-Bridge-Sprint-20, Wikidata
Lucas_Werkmeister_WMDE merged T252750: Commons categories not linked to any wikidata element no longer display in side menu 'In Wikipedia Edit links' into T252800: Regression: Option add links in other languages has disappeared.
Fri, May 15, 9:59 AM · Notice, Language-Team, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Patch-For-Review, Regression, Readers-Web-Backlog (Kanbanana-2019-20-Q4), Vector, Wikidata
Lucas_Werkmeister_WMDE merged task T252750: Commons categories not linked to any wikidata element no longer display in side menu 'In Wikipedia Edit links' into T252800: Regression: Option add links in other languages has disappeared.
Fri, May 15, 9:59 AM · Wikidata-Campsite, Wikidata, Commons
Lucas_Werkmeister_WMDE added a comment to T252750: Commons categories not linked to any wikidata element no longer display in side menu 'In Wikipedia Edit links'.

T252800: Regression: Option add links in other languages has disappeared seems to be the same issue, and given that that task already has Gerrit changes attached, let’s merge this one into that one, though this one was created earlier.

Fri, May 15, 9:59 AM · Wikidata-Campsite, Wikidata, Commons
Lucas_Werkmeister_WMDE lowered the priority of T252803: AffectedPagesFinder: Call to a member function exists() on null from Unbreak Now! to High.

Backport scheduled for Monday’s EU SWAT. Lowering priority since I don’t think this needs any further action at the moment.

Fri, May 15, 9:54 AM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), MediaWiki-extensions-WikibaseClient, Wikidata-Campsite, Wikidata, Wikimedia-production-error

Thu, May 14

Lucas_Werkmeister_WMDE closed T251395: Wire up the "login" button in dedicated error component, a subtask of T247250: Step 1: Error messages: user is logged out but can continue editing as IP or log in (on save), as Resolved.
Thu, May 14, 11:01 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata-Bridge-Sprint-19, Wikidata
Lucas_Werkmeister_WMDE closed T251395: Wire up the "login" button in dedicated error component as Resolved.
Thu, May 14, 11:00 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata-Bridge-Sprint-19, Wikidata
Lucas_Werkmeister_WMDE moved T247250: Step 1: Error messages: user is logged out but can continue editing as IP or log in (on save) from Peer Review to Doing on the Wikidata-Bridge-Sprint-20 board.
Thu, May 14, 10:43 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata-Bridge-Sprint-19, Wikidata
Lucas_Werkmeister_WMDE closed T251399: Create dedicate component to show merge conflict error as Resolved.
Thu, May 14, 10:04 AM · Wikidata-Bridge-Sprint-20, Wikidata-Bridge-Sprint-19, Wikidata
Lucas_Werkmeister_WMDE closed T251399: Create dedicate component to show merge conflict error, a subtask of T244361: Step 1: Error messages: Edit conflict (on save), as Resolved.
Thu, May 14, 10:04 AM · Wikidata-Bridge-Sprint-20, Wikidata

Wed, May 13

Lucas_Werkmeister_WMDE created T252686: extension.json did not pass validation: The property HookHandlers is not defined and the definition does not allow additional properties.
Wed, May 13, 4:15 PM · MediaWiki-Core-Hooks, Dependency injection, Core Platform Team Workboards (Clinic Duty Team)
Lucas_Werkmeister_WMDE moved T251395: Wire up the "login" button in dedicated error component from Doing to Peer Review on the Wikidata-Bridge-Sprint-19 board.
Wed, May 13, 10:02 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata-Bridge-Sprint-19, Wikidata
Lucas_Werkmeister_WMDE claimed T251395: Wire up the "login" button in dedicated error component.
Wed, May 13, 7:22 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikidata-Bridge-Sprint-20, Wikidata-Bridge-Sprint-19, Wikidata