Lucas_Werkmeister_WMDE (Lucas Werkmeister (WMDE))
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 3 2017, 2:45 PM (88 w, 3 h)
Availability
Available
IRC Nick
Lucas_WMDE
LDAP User
Lucas Werkmeister (WMDE)
MediaWiki User
Lucas Werkmeister (WMDE) [ Global Accounts ]

Private account: @LucasWerkmeister.

Recent Activity

Today

Lucas_Werkmeister_WMDE moved T211120: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via Special Pages from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Moving to Review column, because the first two patches are ready for review, I think. The third part will have to wait for the wdio-wikibase package to be extracted (T200011).

Mon, Dec 10, 5:43 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Test-Coverage, Wikidata
Lucas_Werkmeister_WMDE changed the status of T209504: Perform more constraint type checks in PHP before falling back to SPARQL from Open to Stalled.

Waiting for train deployment. Then we can go ahead with the next config change either on Thursday or next week.

Mon, Dec 10, 5:28 PM · Patch-For-Review, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE added a comment to T210836: +2 for Lucas_Werkmeister_WMDE in mediawiki/*.

Thanks!

Mon, Dec 10, 5:14 PM · User-Ladsgroup, Repository-Ownership-Requests
Lucas_Werkmeister_WMDE created T211608: Move includes/services/ into includes/libs/.
Mon, Dec 10, 4:39 PM · Patch-For-Review, Librarization, MediaWiki-ServiceContainer
Lucas_Werkmeister_WMDE moved T209504: Perform more constraint type checks in PHP before falling back to SPARQL from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Dec 10, 4:00 PM · Patch-For-Review, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE claimed T209504: Perform more constraint type checks in PHP before falling back to SPARQL.

Yes, if we track the number of entities, we should be able to get different percentiles in Grafana. I’ll upload a patch for this, hopefully we can get it merged in time for this week’s train.

Mon, Dec 10, 2:38 PM · Patch-For-Review, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE moved T154660: Increase length limit for external identifier, string and URL datatype from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Dec 10, 2:31 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE claimed T154660: Increase length limit for external identifier, string and URL datatype.

Apparently, the string length validator now looks like this in production:

Mon, Dec 10, 2:18 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE moved T207749: Improve code examples of the Wikidata Query UI from Peer Review to To Do on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Dec 10, 1:53 PM · Patch-For-Review, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Google-Code-in-2018, Need-volunteer, Wikidata, Wikidata Query UI
Lucas_Werkmeister_WMDE updated the task description for T207749: Improve code examples of the Wikidata Query UI.
Mon, Dec 10, 1:53 PM · Patch-For-Review, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Google-Code-in-2018, Need-volunteer, Wikidata, Wikidata Query UI
Lucas_Werkmeister_WMDE added a comment to T209504: Perform more constraint type checks in PHP before falling back to SPARQL.

Hm, perhaps it would be good to have some tracking on the number of entities processed in PHP before we increase the limit further. What do you think?

Mon, Dec 10, 1:52 PM · Patch-For-Review, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T211575: Enable IPv6 on tools.wmflabs.org.
Mon, Dec 10, 11:56 AM · Toolforge, IPv6
Lucas_Werkmeister_WMDE added a parent task for T37947: Enable ipv6 on labs: T211575: Enable IPv6 on tools.wmflabs.org.
Mon, Dec 10, 11:54 AM · Operations, Cloud-Services, IPv6, Cloud-VPS
Lucas_Werkmeister_WMDE added a subtask for T211575: Enable IPv6 on tools.wmflabs.org: T37947: Enable ipv6 on labs.
Mon, Dec 10, 11:54 AM · Toolforge, IPv6
Lucas_Werkmeister_WMDE added a project to T211575: Enable IPv6 on tools.wmflabs.org: Toolforge.
Mon, Dec 10, 11:54 AM · Toolforge, IPv6
Lucas_Werkmeister_WMDE updated the task description for T210503: Wikidata Query UI code sample tests are disabled everywhere.
Mon, Dec 10, 11:51 AM · Patch-For-Review, Wikidata, Wikidata Query UI
Lucas_Werkmeister_WMDE updated the task description for T207850: Consolidate the log groups used within Wikibase & Wikibase extensions..
Mon, Dec 10, 11:34 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata, User-Addshore

Thu, Dec 6

Lucas_Werkmeister_WMDE added a comment to T209880: [Investigation - 8h] technical overview of current db based Wikibase federation & blockers to get to an API based federation.

Hm, I don’t think that’s something we need to deal with at the Wikibase level… I feel like this is something that’s best dealt with at the HTTP proxy level. Apart from the other repo’s IP address (that the request is coming from), the current instance doesn’t necessarily know anything about the other repo anyways, does it?

Thu, Dec 6, 4:20 PM · User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Spike, Wikidata
Lucas_Werkmeister_WMDE committed rWDQG957c4a43809a: Clean up some constructor parameters and class members (authored by Lucas_Werkmeister_WMDE).
Clean up some constructor parameters and class members
Thu, Dec 6, 3:32 PM
Lucas_Werkmeister_WMDE updated the task description for T211120: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via Special Pages.
Thu, Dec 6, 2:58 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Test-Coverage, Wikidata
Lucas_Werkmeister_WMDE moved T209958: Write a maintenance script to create entities needed for WikibaseQualityConstraints configuration from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Thu, Dec 6, 12:13 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikibase-Quality-Constraints
Lucas_Werkmeister_WMDE updated the task description for T209958: Write a maintenance script to create entities needed for WikibaseQualityConstraints configuration.
Thu, Dec 6, 12:12 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikibase-Quality-Constraints

Wed, Dec 5

Lucas_Werkmeister_WMDE added a comment to T194178: Make WDQS UI page title configurable.

Lydia says we can just change the brand to include the word “service” – see the above change.

Wed, Dec 5, 7:09 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE committed rWDQG0b6e4cb55e25: Change “Wikidata Query” to “Wikidata Query Service” (authored by Lucas_Werkmeister_WMDE).
Change “Wikidata Query” to “Wikidata Query Service”
Wed, Dec 5, 7:09 PM
Lucas_Werkmeister_WMDE added a comment to T210953: Wikidata is editable for blocked users.

Yes, but it’s a similar class of potential error, if I understand correctly, just not as critical.

Wed, Dec 5, 6:29 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata, Security
Lucas_Werkmeister_WMDE updated the task description for T211120: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via Special Pages.
Wed, Dec 5, 6:27 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Test-Coverage, Wikidata
Lucas_Werkmeister_WMDE added a comment to T209880: [Investigation - 8h] technical overview of current db based Wikibase federation & blockers to get to an API based federation.

I don’t understand this part:

Wed, Dec 5, 4:32 PM · User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Spike, Wikidata
Lucas_Werkmeister_WMDE added a comment to T210953: Wikidata is editable for blocked users.

@Tchanders FYI, in another change we noticed that we’d also failed to override requiresWrite – could that require a similar investigation?

Wed, Dec 5, 4:28 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata, Security
Lucas_Werkmeister_WMDE moved T204066: Make Lexemes appear in global usage of Commons files from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Dec 5, 4:13 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Multimedia, Wikidata, CommonsMetadata, Lexicographical data
Lucas_Werkmeister_WMDE moved T208953: Validate that lexeme language and lexical category, as well as form grammatical features, are existing items from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Dec 5, 4:12 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Lexicographical data, Wikidata
Lucas_Werkmeister_WMDE moved T194178: Make WDQS UI page title configurable from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Wed, Dec 5, 4:09 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE added a comment to T194178: Make WDQS UI page title configurable.

Note: as currently implemented, this will change the title on query.wikidata.org from “Wikidata Query Service” to “Wikidata Query”, without the “Service” (because that’s the name that’s displayed in the upper left corner, between the logo and the “examples” button). We may need to split the “brand” into two different strings to preserve the current WDQS behavior.

Wed, Dec 5, 1:37 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T194178: Make WDQS UI page title configurable.
Wed, Dec 5, 1:33 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE claimed T211120: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via Special Pages.
Wed, Dec 5, 1:32 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Test-Coverage, Wikidata
Lucas_Werkmeister_WMDE committed rWDQG6317a8c530f2: Set document title without jQuery (authored by Lucas_Werkmeister_WMDE).
Set document title without jQuery
Wed, Dec 5, 1:27 PM
Lucas_Werkmeister_WMDE updated the task description for T194178: Make WDQS UI page title configurable.
Wed, Dec 5, 1:26 PM · User-Ladsgroup, Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Wikidata

Tue, Dec 4

Lucas_Werkmeister_WMDE requested review of D1130: Fix typo.
Tue, Dec 4, 5:02 PM
Lucas_Werkmeister_WMDE awarded T211126: Add Greta Doçi to the ldap/wmde and ldap/nda groups a Like token.
Tue, Dec 4, 4:31 PM · User-jijiki, LDAP-Access-Requests
Lucas_Werkmeister_WMDE added a comment to T211120: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via Special Pages.

Note: users can block and unblock themselves (I just tested it on my local wiki), so we should be able to test this using the regular test account, assuming that’s an admin. (To be safe, make the block expire soon, so that we don’t leave an indefinitely blocked user behind if a test fails.)

Tue, Dec 4, 4:26 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Test-Coverage, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T211120: Create integration/edge-to-edge ensuring blocked users cannot edit Wikibase entities via Special Pages.
Tue, Dec 4, 4:06 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Test-Coverage, Wikidata
Lucas_Werkmeister_WMDE updated subscribers of T208953: Validate that lexeme language and lexical category, as well as form grammatical features, are existing items.
Tue, Dec 4, 3:57 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Lexicographical data, Wikidata
Lucas_Werkmeister_WMDE created T211123: copyright.html is missing style sheets.
Tue, Dec 4, 3:31 PM · Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE added a comment to T154660: Increase length limit for external identifier, string and URL datatype.

Um, actually, way longer strings are apparently still permitted…?

Tue, Dec 4, 2:45 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE added a comment to T154660: Increase length limit for external identifier, string and URL datatype.

I believe it’s 1500 characters (example edit), for monolingual text, strings, and URLs.

Tue, Dec 4, 2:41 PM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE added a comment to T211089: Messages in #wikimedia-releng are logged twice.

Thanks! I’ll let you know if I notice it in other channels, but I’m not currently aware of any.

Tue, Dec 4, 11:51 AM · WM-Bot
Lucas_Werkmeister_WMDE closed T207484: API to efficiently format large numbers of entity IDs as Resolved.

@Pintoch thanks for reminding me that I still needed to send the announcement ;) closing now.

Tue, Dec 4, 11:49 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T208953: Validate that lexeme language and lexical category, as well as form grammatical features, are existing items.
Tue, Dec 4, 11:15 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Lexicographical data, Wikidata
Lucas_Werkmeister_WMDE added a comment to T179263: Make the URL in wdqs-gui for fetching examples configurable .

But that’ll require us to rework the whole deployment process of the WDQS UI, and place extra requirements on third-party installs as well (a static site can be served from any service provider). We already have a build step before deployment – we could also apply the necessary adjustments there.

Tue, Dec 4, 11:12 AM · User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata Query UI, Discovery, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T209958: Write a maintenance script to create entities needed for WikibaseQualityConstraints configuration.
Tue, Dec 4, 10:57 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikibase-Quality-Constraints
Lucas_Werkmeister_WMDE closed T210858: "Restore previous query" icon should be grayed out when there's no query to restore as Resolved.
Tue, Dec 4, 10:43 AM · Patch-For-Review, Wikidata, Wikidata Query UI
Lucas_Werkmeister_WMDE closed T195485: Don’t select term_entity_type in TermSqlIndex as Resolved.

I think so, yes.

Tue, Dec 4, 10:43 AM · MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), Patch-For-Review, MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE closed T195485: Don’t select term_entity_type in TermSqlIndex, a subtask of T194273: Clean up indexes of wb_terms table, as Resolved.
Tue, Dec 4, 10:43 AM · User-Ladsgroup, MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review, DBA, MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE created T211089: Messages in #wikimedia-releng are logged twice.
Tue, Dec 4, 10:36 AM · WM-Bot

Mon, Dec 3

Lucas_Werkmeister_WMDE added a comment to T40971: API: Access old versions of entities.

For the record: in Special:EntityData, this has been available since I247191817f (early 2013) via the oldid or revision URL query parameter (example). It’s only missing in the API (wbgetentities).

Mon, Dec 3, 6:02 PM · Wikidata, MediaWiki-extensions-WikibaseRepository
Lucas_Werkmeister_WMDE added a comment to T210901: Stale reads for WDQS Updater.

We currently don't enable access to old revisions via any API T40971

Mon, Dec 3, 5:52 PM · User-Smalyshev, Patch-For-Review, Wikidata, Wikidata-Query-Service
Lucas_Werkmeister_WMDE added a comment to T150618: Provide HD logos for all projects.

The HD logo for itwikisource, deployed to the debug server earlier today as part of this change, looked broken (screenshot at 150% zoom):

Mon, Dec 3, 5:39 PM · User-Zoranzoki21, Patch-For-Review, User-Urbanecm, Google-Code-in-2018, Goal, Wikimedia-Site-requests
Lucas_Werkmeister_WMDE moved T204728: Make WikibaseQualityConstraints extension installable with data-value/time ~1.0 from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Dec 3, 4:24 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Patch-For-Review, Wikidata, DataValues
Lucas_Werkmeister_WMDE added a comment to T210953: Wikidata is editable for blocked users.

FWIW, I can tell you that CheckConstraintsRdf in WikibaseQualityConstraints is safe (it’s a read-only action), and I’m confident it has no subclasses (it would not make sense for any other extension to subclass it).

Mon, Dec 3, 4:05 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata, Security
Lucas_Werkmeister_WMDE updated the task description for T209525: Migrate tag_summary usage to change_tag and drop the table.
Mon, Dec 3, 3:59 PM · User-Marostegui, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Patch-For-Review, MediaWiki-Change-tagging
Lucas_Werkmeister_WMDE added a comment to T210953: Wikidata is editable for blocked users.

@Addshore’s patch is already merged (on master – the wmf.6 backport is abandoned).

Mon, Dec 3, 3:51 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Anti-Harassment (AHT Sprint 34), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata, Security
Lucas_Werkmeister_WMDE moved T204727: Make Wikibase extension installable with data-value/time ~1.0 from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Dec 3, 3:43 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Patch-For-Review, Wikidata, DataValues
Lucas_Werkmeister_WMDE updated the task description for T204727: Make Wikibase extension installable with data-value/time ~1.0.
Mon, Dec 3, 3:42 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Patch-For-Review, Wikidata, DataValues
Lucas_Werkmeister_WMDE updated the task description for T204728: Make WikibaseQualityConstraints extension installable with data-value/time ~1.0.
Mon, Dec 3, 3:42 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Patch-For-Review, Wikidata, DataValues
Lucas_Werkmeister_WMDE updated the task description for T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId.
Mon, Dec 3, 3:21 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Wikidata-Ministry-Of-Magic, Patch-For-Review, Wikimedia-production-error, MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId.
Mon, Dec 3, 3:11 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Wikidata-Ministry-Of-Magic, Patch-For-Review, Wikimedia-production-error, MediaWiki-extensions-WikibaseRepository, Wikidata
Lucas_Werkmeister_WMDE closed T208918: wbcheckconstraints API failure: ContemporaryChecker.php Call to getStatements() on non-object as Resolved.

No more errors in Logstash since the 29th, when Wikidata went back on wmf.6 (after some unrelated issues). Checking constraints on Q2518823 works now (and the item still features a value for a deleted item). Looks fixed to me.

Mon, Dec 3, 2:56 PM · User-Michael, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseRepository, Wikibase-Quality-Constraints, Wikimedia-production-error
Lucas_Werkmeister_WMDE closed T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries as Resolved.

I don’t think we’ll be able to see this in Grafana (Network traffic panel), query traffic from WBQC is probably not significant next to other query traffic and updater traffic. Closing.

Mon, Dec 3, 2:48 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE moved T204109: Investigate some Wikidata write api queries taking over 30 seconds. (In EntityContent::collectValues?) from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

As far as I can tell, all the changes relevant to this task are merged now (there are still some open for the subtask T205252). Moving to the verification column – hopefully we should see the Grafana stats improve once this goes out with the train.

Mon, Dec 3, 2:38 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Performance-Team (Radar), User-Addshore, Patch-For-Review, wikidata-tech-focus, Wikidata
Lucas_Werkmeister_WMDE awarded T211014: Requesting access to deployment for Christoph Jauera (WMDE-Fisch) a Like token.
Mon, Dec 3, 2:27 PM · Release-Engineering-Team (Watching / External), User-jijiki, Patch-For-Review, SRE-Access-Requests, Operations
Lucas_Werkmeister_WMDE moved T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries from To Do to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Dec 3, 2:03 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE moved T209504: Perform more constraint type checks in PHP before falling back to SPARQL from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Mon, Dec 3, 2:03 PM · Patch-For-Review, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE placed T204066: Make Lexemes appear in global usage of Commons files up for grabs.
Mon, Dec 3, 2:02 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Multimedia, Wikidata, CommonsMetadata, Lexicographical data
Lucas_Werkmeister_WMDE committed rEWLE58fd9aff91bf: Validate that lexeme language and lexical category are existing items (authored by Ladsgroup).
Validate that lexeme language and lexical category are existing items
Mon, Dec 3, 1:56 PM
Lucas_Werkmeister_WMDE updated the task description for T208953: Validate that lexeme language and lexical category, as well as form grammatical features, are existing items.
Mon, Dec 3, 1:56 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Lexicographical data, Wikidata
Lucas_Werkmeister_WMDE updated the task description for T208953: Validate that lexeme language and lexical category, as well as form grammatical features, are existing items.
Mon, Dec 3, 1:55 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Lexicographical data, Wikidata
Lucas_Werkmeister_WMDE changed the status of T204317: Don’t send SPARQL prefixes with WikibaseQualityConstraints queries from Stalled to Open.

Forgot to unstall this – should be deployed now, I’ll check Grafana in a few hours to see if I can see any trace of this change at all, but otherwise it should hopefully Just Work™.

Mon, Dec 3, 1:07 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE added a comment to T203400: Provide more useful redirects for property predicates (wdt:…, p:…, etc.).

But /prop/direct/P279 gives no RDF, just HTML

Mon, Dec 3, 11:54 AM · Wikidata
Lucas_Werkmeister_WMDE closed T190795: Add tool to write MassMessage to all pages linked to a Wikidata item as Resolved.

I think we can close this task – the tool exists (https://tools.wmflabs.org/wdmm/), and all the features from the task description are available, except for directly sending the MassMessage (optional).

Mon, Dec 3, 11:41 AM · Wikidata
Lucas_Werkmeister_WMDE added a comment to T210139: Facebook adds fbclid ==> you cant paste in WDQS tiny URLSs.

Why should we do this in the proxy? Much easier to do it in the web UI IMHO.

Mon, Dec 3, 10:42 AM · Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE added a comment to T203400: Provide more useful redirects for property predicates (wdt:…, p:…, etc.).

For RDF users , this is really blocking.

Mon, Dec 3, 10:25 AM · Wikidata
Lucas_Werkmeister_WMDE updated the task description for T203400: Provide more useful redirects for property predicates (wdt:…, p:…, etc.).
Mon, Dec 3, 10:12 AM · Wikidata

Sun, Dec 2

Lucas_Werkmeister_WMDE added projects to T210929: Timeout exceeded for WikibaseReferenceOnProtectedPage Selenium test: Wikidata-Campsite, Continuous-Integration-Config.

Link to one of the failing jobs, for convenience:

Sun, Dec 2, 4:28 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, User-Michael, Continuous-Integration-Config, Wikidata-Campsite, Wikimedia-production-error (Shared Build Failure), MediaWiki-extensions-WikibaseRepository, Wikidata
Pintoch awarded T207484: API to efficiently format large numbers of entity IDs a 100 token.
Sun, Dec 2, 2:18 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
Pintoch awarded T207484: API to efficiently format large numbers of entity IDs a Orange Medal token.
Sun, Dec 2, 2:17 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata
Pintoch awarded T207484: API to efficiently format large numbers of entity IDs a Love token.
Sun, Dec 2, 2:17 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Wikidata

Sat, Dec 1

Lucas_Werkmeister_WMDE added a comment to T184933: Display map for geocoordinate statements.

I don’t think so, why? The already merged patches are mostly for displaying coordinates on the repo, whereas the linked chain is for the client, if I understand correctly.

Sat, Dec 1, 9:38 AM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Maps, Wikidata, Wikidata-Gadgets

Fri, Nov 30

Lucas_Werkmeister_WMDE closed T210645: .toolbar overlaps .popover on the Wikidata Query UI as Resolved.
Fri, Nov 30, 5:48 PM · Patch-For-Review, Wikidata, Wikidata Query UI
Lucas_Werkmeister_WMDE added a comment to T210634: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds.

The change adding the test was reverted in Id2eeeb781b (I’m not sure why @gerritbot didn’t leave a comment), and since then I haven’t seen any more occurrences of this bug, so the CI issue seems to be resolved.

Fri, Nov 30, 5:48 PM · Patch-For-Review, Continuous-Integration-Config, MediaWiki-extensions-Scribunto, Wikidata
Lucas_Werkmeister_WMDE added a comment to T204109: Investigate some Wikidata write api queries taking over 30 seconds. (In EntityContent::collectValues?).
Fri, Nov 30, 5:16 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Performance-Team (Radar), User-Addshore, Patch-For-Review, wikidata-tech-focus, Wikidata
Lucas_Werkmeister_WMDE committed rEWBI70c5859bf431: Update Wikibase CodeSniffer to 0.5.1 (authored by Lucas_Werkmeister_WMDE).
Update Wikibase CodeSniffer to 0.5.1
Fri, Nov 30, 4:31 PM
Lucas_Werkmeister_WMDE moved T209504: Perform more constraint type checks in PHP before falling back to SPARQL from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Config change is reviewed and will be deployed with Monday’s EU SWAT, so moving out of the review column for now.

Fri, Nov 30, 2:48 PM · Patch-For-Review, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE committed rEWLEabcd2635fa48: Update Wikibase CodeSniffer to 0.5.1 (authored by Lucas_Werkmeister_WMDE).
Update Wikibase CodeSniffer to 0.5.1
Fri, Nov 30, 2:44 PM
Lucas_Werkmeister_WMDE reopened T208253: [Wikibase] Update wikibase/wikibase-codesniffer to ^0.5.0/0.5.1 as "Open".

WikibaseCodeSniffer now has a 0.5.1 release to pull in MediaWiki CodeSniffer 19.1.0 (thanks for the issue @Umherirrender!), so let’s reopen this task to track all the repositories that now need to pull in 0.5.1 instead of 0.5.0.

Fri, Nov 30, 2:40 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), wikidata-tech-focus, Patch-For-Review, Wikidata, PHP 7.3 support
Lucas_Werkmeister_WMDE reopened T208253: [Wikibase] Update wikibase/wikibase-codesniffer to ^0.5.0/0.5.1, a subtask of T208234: MediaWiki codesniffer fails on php7.3: PHP Fatal error: Uncaught PHP_CodeSniffer\Exceptions\RuntimeException: "continue" targeting switch is equivalent to "break"., as Open.
Fri, Nov 30, 2:39 PM · MediaWiki-Codesniffer, PHP 7.3 support
Lucas_Werkmeister_WMDE added a comment to T210836: +2 for Lucas_Werkmeister_WMDE in mediawiki/*.

(Minor note to avoid potential confusion: I also have non-work accounts, “LucasWerkmeister” on Phabricator and “Lucas Werkmeister <mail@lucaswerkmeister.de>” on Gerrit – those should not get any special rights, since I only rarely use them.)

Fri, Nov 30, 12:38 PM · User-Ladsgroup, Repository-Ownership-Requests
Lucas_Werkmeister_WMDE added a comment to T210692: WDQS should not add (...) to VALUES.

I feel like two things are being conflated here… there are two changes made by the automatic formatting: the variable and values are parenthesized, and the list is split across multiple lines. The title and the beginning of the task description only talk about the parentheses, but then the rationale only explains why the multi-line change is bad…

Fri, Nov 30, 11:55 AM · Wikidata Query UI, Wikidata
Lucas_Werkmeister_WMDE added a comment to T209368: Investigate wbformatvalue behaviour regarding datatype and datavalue type.

No, but I think the data value is supposed to be useful on its own as well, that’s why it has its own type information.

Fri, Nov 30, 11:53 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Spike, Lexicographical data, Wikidata
Lucas_Werkmeister_WMDE added a comment to T209504: Perform more constraint type checks in PHP before falling back to SPARQL.

The only thing we have right now is the number of checks that stayed within the threshold vs. the number of checks that exceeded it. Do you think we should add additional tracking before deploying the config change?

Fri, Nov 30, 11:52 AM · Patch-For-Review, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata
Lucas_Werkmeister_WMDE moved T184933: Display map for geocoordinate statements from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Fri, Nov 30, 11:07 AM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Maps, Wikidata, Wikidata-Gadgets

Thu, Nov 29

Lucas_Werkmeister_WMDE added a comment to T210679: Make WDQS auto-completion keyboard shortcut configurable.

See also T203320: Ctrl/Control-Space is overridden by keyboard layout changing shortcut on macOS. (I’m not sure if the two tasks should be merged or kept separate, but they’re definitely related.)

Thu, Nov 29, 1:44 PM · Wikidata Query UI, Wikidata