Page MenuHomePhabricator

LuciferianThomas (Thomas Tam)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 13 2020, 8:45 AM (191 w, 1 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
LuciferianThomas [ Global Accounts ]

Recent Activity

Apr 1 2024

LuciferianThomas added a comment to T359998: Install ContactPage on zhwiki and add contact form.

@Ammarpad any updates on this task? We are waiting for the setup for this task before changing our IPBE application procedure platform.

Apr 1 2024, 10:53 AM · Wikimedia-Extension-setup, IP-Blocking-Impacts, Chinese-Sites, Wikimedia-Site-requests

Mar 22 2024

LuciferianThomas added a comment to T359998: Install ContactPage on zhwiki and add contact form.

The hide-if statement of reason field is commented out as we can't figure out how to hide it if gfw is empty. We would like assistance to set up that parameter.

hide-if logic does not currently support multi-value fields, so it cannot be used with gfw field

Mar 22 2024, 4:11 PM · Wikimedia-Extension-setup, IP-Blocking-Impacts, Chinese-Sites, Wikimedia-Site-requests

Mar 14 2024

LuciferianThomas updated the task description for T359998: Install ContactPage on zhwiki and add contact form.
Mar 14 2024, 8:28 AM · Wikimedia-Extension-setup, IP-Blocking-Impacts, Chinese-Sites, Wikimedia-Site-requests

Mar 13 2024

LuciferianThomas created T359998: Install ContactPage on zhwiki and add contact form.
Mar 13 2024, 2:38 AM · Wikimedia-Extension-setup, IP-Blocking-Impacts, Chinese-Sites, Wikimedia-Site-requests

Dec 15 2023

LuciferianThomas added a comment to T276782: FlaggedRevs: reviewAllPages.php CommentStore.php: $row does not contain fields needed for comment rev_comment.

@adrelanos are you able to replicate the problem without FlaggedRevs enabled?

No. I don't have any similar issues without FlaggedRevisions. And I wouldn't know how to reproduce this issue without FlaggedRevisions. Because only by running php reviewAllPages.php --username Patrick this issue happened. And the reviewAllPages.php comes within the FlaggedRevisions folder.

Or do you mean I should test disable the FlaggedRevisions in mediawiki config and then run reviewAllPages.php?

Dec 15 2023, 12:30 PM · MediaWiki-extensions-FlaggedRevs

Dec 14 2023

LuciferianThomas added a comment to T276782: FlaggedRevs: reviewAllPages.php CommentStore.php: $row does not contain fields needed for comment rev_comment.

I tried commenting out all lines in my configuration that are loading extensions, and the issue persists. Looking back at T252043, the issue appeared since 1.35, so is it possible to be as T276782#6891983 outlined, having a issue with scripts not updated with the new database structure?

Dec 14 2023, 7:22 AM · MediaWiki-extensions-FlaggedRevs
LuciferianThomas added a comment to T276782: FlaggedRevs: reviewAllPages.php CommentStore.php: $row does not contain fields needed for comment rev_comment.

re @Samwilson no, not at all.

wfLoadExtensions( [
	// 'AbuseFilter',
	'AntiSpoof', 'Cite', 'CodeEditor',
	'CodeMirror', 'CSS', 'DisplayTitle',
	'Elastica', 'GeoData', 'Interwiki',
	'JsonConfig', 'Kartographer',
	'LabeledSectionTransclusion',
	// 'Loops',
	'NativeSvgHandler', 'NoTitle', 'Nuke',
	'ParserFunctions', 'PdfHandler',
	// 'ProtectSite',
	'Scribunto', 'SyntaxHighlight',
	'TabberNeue', 'TemplateData',
	'TemplateStyles', 'TemplateStylesExtender',
	'Translate', 'UniversalLanguageSelector',
	'UrlShortener',
	'VisualEditor', 'WikiEditor'
] );

This is all I have.

Dec 14 2023, 7:06 AM · MediaWiki-extensions-FlaggedRevs
LuciferianThomas added a comment to T276782: FlaggedRevs: reviewAllPages.php CommentStore.php: $row does not contain fields needed for comment rev_comment.

Also getting the same issue after trying to use rebuildall.php with importDump.php with MediaWiki 1.41-beta releases. Is there any immediate hotfix that I can work with to get around the issue and use the rebuild script?

Dec 14 2023, 6:49 AM · MediaWiki-extensions-FlaggedRevs

Dec 11 2023

LuciferianThomas created T353120: Enable action blocks in Chinese Wikipedia.
Dec 11 2023, 4:17 AM · Wikimedia-Site-requests, Chinese-Sites, Anti-Harassment

Jul 3 2023

LuciferianThomas changed the status of T331289: Request for zhwiki to be added to CopyPatrol from Stalled to Open.

It doesn't look like there's something blocking progress to have this task stalled, more like it's just not yet done.

Jul 3 2023, 9:30 AM · Chinese-Sites, CopyPatrol, Community-Tech

Jan 20 2023

LuciferianThomas added a comment to T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).

The next time the broken option is changed, it would fix itself.

The main problem is when this happens with VE options, VE won't load at all, essentially bricking the options (options can only be changed when VE is loaded), leaving the API as the only way to fix things.

Jan 20 2023, 9:17 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites

Jan 16 2023

LuciferianThomas added a comment to T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).

I don't think the truncated Chinese character is specifically the problem, I feel like it's more likely to be JS running JSON.parse on the preference value and resulting in an error.

Jan 16 2023, 4:03 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites

Jan 15 2023

LuciferianThomas added a comment to T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).

I didn't reset all preferences, the only thing I did reset was that specific preference string. I believe that is what caused my bricked preferences - failed to parse a (JSON) string type from the string-typed value when starting 2017 editor. I suppose it's normally saved like "visualeditor-findAndReplace-findText": "\\"[escaped content]\\"", but the latter escaped closing quotation mark was purged by overflowing the maximum length of preference strings I think? And such leaves me with "visualeditor-findAndReplace-findText": "\\"[very very long escaped content]" which is not a proper type and can't be parsed.

Jan 15 2023, 11:59 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites
LuciferianThomas added a comment to T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).

Aha, found the problem. I have visualeditor-findAndReplace-findText filled with a very long string (probably accidentally copy-pasted). Setting it to a blank string fixed things... I think.

Jan 15 2023, 1:48 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites

Jan 14 2023

LuciferianThomas added a comment to T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).

@Func is there a way for me to completely reset my preferences for zhwiki specifically so I can get out of the bricked situation? It's been annoying having 2017 editor broken.

Jan 14 2023, 4:01 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites

Jan 13 2023

LuciferianThomas removed a watcher for Chinese-Sites: LuciferianThomas.
Jan 13 2023, 5:13 PM
LuciferianThomas added a comment to T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).

I feel like what broke all of the above would be the latest 1.40.0-wmf.18 version, since before that range of deployment dates I don't feel like there are any of such issues.

Jan 13 2023, 4:54 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites
LuciferianThomas reopened T326788: Unexpected "Page contents not supported in other languages" in non-article namespace as "Open".

Reopening per T326696#8522469, this is not a simple duplicate. @Bugreporter, T275147 is for developers to determine what to put for the empty state, and this is a bug report for interwiki and language links not loading on specific sites. I have faced the exact same issue on Chinese Wikipedia where language and interwiki links would not load under the Vector 2022 skin even on pages with linked pages. Example being while using Vector 2022 (e.g. on https://zh.wikipedia.org/wiki/Wikipedia:关于?useskin=vector-2022) shows the abovementioned empty menu incorrectly, while the old Vector skin can show such links (https://zh.wikipedia.org/wiki/Wikipedia:关于?useskin=vector).

image.png (854×1 px, 386 KB)
image.png (1×1 px, 1 MB)
Using Vector 2022, no links shownUsing old Vector, links correctly listed
Jan 13 2023, 4:43 AM · Desktop Improvements (Vector 2022), UniversalLanguageSelector, Wikimedia-Incident, Language-Team (Language-2023-January-March), MW-1.40-notes (1.40.0-wmf.19; 2023-01-16)
LuciferianThomas added a comment to T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).

Hey there @Func, I noticed that my interwiki language menu has also been bricked in the same way as T326788. Is it possible that these issues could be inter-related?
Nevermind, I tried checking it while logged out and it seems like they aren't related, and it seems to happen consistently across zhwikipedia, reopened that task instead.

Jan 13 2023, 4:28 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites

Jan 12 2023

LuciferianThomas added a comment to T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).

@Func I understand the part that my preferences are likely bricked somewhere - I guessed this is the most likely option given that the issue is across devices for me. However I do not particularly understand how to use the abovementioned task. I've searched up mw.user.options.set in the page HTML and found one blank call mw.user.options.set(), yet the line has tokens in it and I'm better off not sharing it (line starts with (RLQ=window.RLQ||[])).

Jan 12 2023, 6:38 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites
LuciferianThomas added a comment to T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).
[Intervention] Images loaded lazily and replaced with placeholders. Load events are deferred. See https://go.microsoft.com/fwlink/?linkid=2048113
load.php?lang=zh-hk&modules=ext.CodeMirror%2Ccharinsert%2CeventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.CodeMirror.data%2Clib%7Cext.CodeMirror.mode.mediawiki%7Cext.centralNotice.geoIP%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.cx.eventlogging.campaigns%7Cext.discussionTools.init%7Cext.echo.api%2Cinit%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cjquery%2Cmoment%2Coojs%2Coojs-ui-core%2Coojs-ui-windows%2Crangefix%7Cjquery.client%2Ccookie%2CtextSelection%2Cui%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cstorage%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-editing-styling%2Cindicators%7Cskins.vector.es6%2Cjs%7Cskins.vector.icons.js&skin=vector-2022&version=1bj5z:1247
Jan 12 2023, 6:07 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites
LuciferianThomas added a comment to T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).

@Aklapper Added, though I don't see the point when literally every single page edit action and IP contribution page is broken.

Jan 12 2023, 4:04 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites
LuciferianThomas updated the task description for T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).
Jan 12 2023, 4:03 PM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites
LuciferianThomas added a comment to T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).

@Aklapper Thanks for the notification, edited the request. I can't really fill in any steps to reproduce the issue as I didn't do anything specific to break it, it was working as intended until some random time where I changed nothing.

Jan 12 2023, 4:01 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites
LuciferianThomas updated the task description for T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).
Jan 12 2023, 4:00 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites

Jan 11 2023

LuciferianThomas updated the task description for T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).
Jan 11 2023, 1:47 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites
LuciferianThomas updated the task description for T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).
Jan 11 2023, 1:46 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites
LuciferianThomas created T326696: User options supplied to client side empty due to json encoding errors (multibyte character cut in half).
Jan 11 2023, 1:46 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), MW-1.40-notes, MW-1.39-notes, Performance-Team (Radar), MediaWiki-Core-Preferences, Chinese-Sites

Jun 15 2022

LuciferianThomas updated LuciferianThomas.
Jun 15 2022, 11:15 AM
LuciferianThomas added a watcher for Chinese-Sites: LuciferianThomas.
Jun 15 2022, 9:11 AM

Apr 28 2022

LuciferianThomas added a comment to T307007: Enable "auto-block" feature for AbuseFilter on Chinese Wikiversity.

@Stang I think it would be fine to configure it in the same way as Chinese Wikipedia.

Apr 28 2022, 2:29 AM · Wikimedia-Site-requests, Chinese-Sites

May 10 2021

LuciferianThomas added a comment to T265332: Incorrect font used in color-coded 2017 Wikitext Editor.

@matmarex
I finally found out what exactly the problem is.
Using Traditional Chinese and Simplified Chinese as display language, the fonts used are also different.
When using Traditional Chinese (incl. Trad. Chinese (Taiwan), Trad. Chinese (Hong Kong), Trad. Chinese (Macao)) as display language on Chinese wikis, the editor first loads with the Simplified Chinese font by default and then the syntax highlight overlay uses the Traditional Chinese font. Since the two fonts have different character widths, the editor doesn't actually match with the overlay. I can also reproduce this even in Fandom which also supports syntax highlighting. Please check if you can reproduce this again using Traditional Chinese as the display language.

May 10 2021, 8:17 AM · Chinese-Sites, Editing-team, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Jan 11 2021

LuciferianThomas renamed T265332: Incorrect font used in color-coded 2017 Wikitext Editor from Incorrect display of full-width punctuation on 2017 Wikitext Editor to Incorrect font used in color-coded 2017 Wikitext Editor.
Jan 11 2021, 11:55 PM · Chinese-Sites, Editing-team, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
LuciferianThomas added a comment to T265332: Incorrect font used in color-coded 2017 Wikitext Editor.

@matmarex

Jan 11 2021, 10:50 AM · Chinese-Sites, Editing-team, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
LuciferianThomas added a comment to T265332: Incorrect font used in color-coded 2017 Wikitext Editor.

Thread bump and update: it seems to using the very same font for any configurations of edit tool font set in my preferences (on zhwiki), and in fact has a different character spacing causing the shift. Any idea what could fix this?

Jan 11 2021, 10:49 AM · Chinese-Sites, Editing-team, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Nov 3 2020

LuciferianThomas added a comment to T265332: Incorrect font used in color-coded 2017 Wikitext Editor.

Btw, in enwp, it does correctly use monospace fonts so that isn't a problem, but this problem exists in zhwp where it's not using monospace fonts as configured.

Nov 3 2020, 10:15 AM · Chinese-Sites, Editing-team, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Oct 26 2020

LuciferianThomas added a comment to T265332: Incorrect font used in color-coded 2017 Wikitext Editor.

So... are there any ways to solve this problem?

Oct 26 2020, 9:03 AM · Chinese-Sites, Editing-team, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Oct 17 2020

LuciferianThomas added a comment to T265332: Incorrect font used in color-coded 2017 Wikitext Editor.

It is actually not using monospace fonts as set in my preferences.

Oct 17 2020, 10:33 AM · Chinese-Sites, Editing-team, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Oct 16 2020

LuciferianThomas added a comment to T265332: Incorrect font used in color-coded 2017 Wikitext Editor.

Anyways, I suppose it should actually force the use of a (common) fixed-width monospace font instead of somehow using weird fonts that mess things up?

Oct 16 2020, 6:57 AM · Chinese-Sites, Editing-team, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Oct 15 2020

LuciferianThomas added a comment to T265332: Incorrect font used in color-coded 2017 Wikitext Editor.

Yes, I did actually experience this on multiple devices, from desktop computers to computer tablets.

Oct 15 2020, 7:09 AM · Chinese-Sites, Editing-team, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Oct 13 2020

LuciferianThomas created T265332: Incorrect font used in color-coded 2017 Wikitext Editor.
Oct 13 2020, 9:01 AM · Chinese-Sites, Editing-team, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor