Page MenuHomePhabricator

MSG17
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jan 29 2019, 10:01 PM (130 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
MSG17 [ Global Accounts ]

Recent Activity

Jan 11 2020

MSG17 updated the task description for T242501: Repeated 503 Errors.
Jan 11 2020, 3:56 AM · Community-Tech, SVG Translate Tool
MSG17 created T242501: Repeated 503 Errors.
Jan 11 2020, 3:55 AM · Community-Tech, SVG Translate Tool

Aug 2 2019

Kozuch awarded T214984: PHP7's stricter JSON parsing breaks some wiki content a Like token.
Aug 2 2019, 7:48 PM · MediaWiki-extensions-Graph, Maps (Kartographer), PHP 7.2 support

Feb 13 2019

MSG17 added a comment to T214984: PHP7's stricter JSON parsing breaks some wiki content.

OK, so for some reason the way the highway system parameter is being called is causing issues. If the highway system parameter is specified, it will break, but if I don't supply a parameter and let the Wikidata template find it (it looks for the ID for property P16) it will work. Interesting...

Feb 13 2019, 12:16 PM · MediaWiki-extensions-Graph, Maps (Kartographer), PHP 7.2 support

Feb 12 2019

MSG17 added a comment to T214984: PHP7's stricter JSON parsing breaks some wiki content.

Yeah, it looks like the spaces for assigning a Wikidata ID for the highway system property (P16) to show was the issue. It must have caused a syntax issue with the stricter parser.

Feb 12 2019, 12:50 PM · MediaWiki-extensions-Graph, Maps (Kartographer), PHP 7.2 support
MSG17 added a comment to T214984: PHP7's stricter JSON parsing breaks some wiki content.

OK, I fixed the thumbnail issue by removing some trailing spaces:

Feb 12 2019, 12:31 PM · MediaWiki-extensions-Graph, Maps (Kartographer), PHP 7.2 support

Feb 8 2019

MSG17 added a comment to T214984: PHP7's stricter JSON parsing breaks some wiki content.

The small empty map on the article is the issue - something is wrong with a parameter, so that small map doesn't get rendered while the full screen one is now properly rendered. That small map basically uses an image of what the map would normally display in order to cut down loading times and avoid accidentally moving the map window to focus elsewhere.

Feb 8 2019, 8:13 PM · MediaWiki-extensions-Graph, Maps (Kartographer), PHP 7.2 support
MSG17 added a comment to T214984: PHP7's stricter JSON parsing breaks some wiki content.

Weirdly enough, the pre-rendered map now works in my sandbox on English Wikipedia, but nowhere else with the highway systems template. Maybe something to do with the Wikidata ID entry? My sandbox page doesn't have a Wikidata ID, but the other pages I looked at did.

Feb 8 2019, 3:18 PM · MediaWiki-extensions-Graph, Maps (Kartographer), PHP 7.2 support
MSG17 added a comment to T214984: PHP7's stricter JSON parsing breaks some wiki content.

Yeah, even in HHVM the thumbnail doesn't render correctly (unless you are in editing mode, because there the thumbnail is actually a smaller dynmap and not an image). Still, thanks for fixing the dynmap.

Feb 8 2019, 12:11 PM · MediaWiki-extensions-Graph, Maps (Kartographer), PHP 7.2 support

Feb 7 2019

MSG17 added a comment to T214984: PHP7's stricter JSON parsing breaks some wiki content.

@TheDJ Thank you for fixing the trailing commas. I did figure it was related to comma placement in some way, but I mostly focused my efforts on commas with spaces before them. I will look at reimplementation, especially since there is still an error produced by the highway systems template in PHP7.

Feb 7 2019, 12:33 PM · MediaWiki-extensions-Graph, Maps (Kartographer), PHP 7.2 support

Feb 6 2019

MSG17 added a comment to T214984: PHP7's stricter JSON parsing breaks some wiki content.

@Jdforrester-WMF - That makes sense, so I guess the next step is to look at how to get the JSON and modify the template code to make it output correctly.

Feb 6 2019, 8:27 PM · MediaWiki-extensions-Graph, Maps (Kartographer), PHP 7.2 support

Jan 30 2019

MSG17 created T214984: PHP7's stricter JSON parsing breaks some wiki content.
Jan 30 2019, 7:07 PM · MediaWiki-extensions-Graph, Maps (Kartographer), PHP 7.2 support