Page MenuHomePhabricator

Magul (Magul)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 13 2016, 1:35 PM (156 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Magul [ Global Accounts ]

Recent Activity

Jul 15 2018

Magul removed a watcher for Pywikibot: Magul.
Jul 15 2018, 1:27 PM

Dec 5 2017

Lokal_Profil awarded T154771: Abandon support for Python 2.6 a Like token.
Dec 5 2017, 9:17 AM · Pywikibot-Announce, Patch-For-Review, Pywikibot
whym awarded T154771: Abandon support for Python 2.6 a Cookie token.
Dec 5 2017, 7:41 AM · Pywikibot-Announce, Patch-For-Review, Pywikibot

Jul 10 2017

Dalba awarded T154771: Abandon support for Python 2.6 a Like token.
Jul 10 2017, 11:49 AM · Pywikibot-Announce, Patch-For-Review, Pywikibot

Jun 1 2017

Sn1per awarded T151145: Make Travis (and Appveyor) pass again a Party Time token.
Jun 1 2017, 3:48 AM · Pywikibot-tests, Pywikibot

Apr 19 2017

Magul added a comment to T151145: Make Travis (and Appveyor) pass again.

We have still few issues in Appveyor and should revalidate all open subtasks here (as they propably should be closed), but that looks like real milestone for this project. We should treat right now any Travis failure as blocker (at least till we move to Wikimedia CI) and try to make all tests properly mocked.

Apr 19 2017, 2:54 PM · Pywikibot-tests, Pywikibot
Magul updated subscribers of T151145: Make Travis (and Appveyor) pass again.

@Dalba that's huge! https://travis-ci.org/wikimedia/pywikibot-core/builds/223520844

Apr 19 2017, 2:34 PM · Pywikibot-tests, Pywikibot

Mar 29 2017

Magul awarded T161692: Travis builds for github forks of pywikibot-core fail with NoUsername error a Love token.
Mar 29 2017, 1:09 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul added a subtask for T151145: Make Travis (and Appveyor) pass again: T161692: Travis builds for github forks of pywikibot-core fail with NoUsername error.
Mar 29 2017, 1:09 PM · Pywikibot-tests, Pywikibot
Magul added a parent task for T161692: Travis builds for github forks of pywikibot-core fail with NoUsername error: T151145: Make Travis (and Appveyor) pass again.
Mar 29 2017, 1:09 PM · Patch-For-Review, Pywikibot-tests, Pywikibot

Mar 21 2017

Magul added a comment to T160997: Migrate pywikibot from RCStream to EventStreams.

Isn't it a dup for T158943 ?

Mar 21 2017, 2:23 PM · Wikimedia-Stream, Pywikibot

Mar 8 2017

Magul merged T151370: VersionConflict during installation of more current PyOpenSSL into T159808: pkg_resources.VersionConflict for pyOpenSSL.
Mar 8 2017, 4:43 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul merged task T151370: VersionConflict during installation of more current PyOpenSSL into T159808: pkg_resources.VersionConflict for pyOpenSSL.
Mar 8 2017, 4:43 PM · Pywikibot-tests, Pywikibot

Feb 24 2017

Magul added a comment to T158944: Verifying i18n commits is broken.

Basically it looks, that for pywikibot/i18n git submodule update --init is failing.

Feb 24 2017, 12:46 PM · translatewiki.net, Pywikibot, Pywikibot-i18n
Magul added a comment to T158944: Verifying i18n commits is broken.

Yep, but it was reintroduced in the very next commit, so we should figure out why, because I don't believe that another removal will resolve this issue permanently.

Feb 24 2017, 12:45 PM · translatewiki.net, Pywikibot, Pywikibot-i18n
Magul added a project to T158944: Verifying i18n commits is broken: translatewiki.net.
Feb 24 2017, 12:30 PM · translatewiki.net, Pywikibot, Pywikibot-i18n
Magul added a comment to T158944: Verifying i18n commits is broken.

OK, I can confirm, that

Warning: Unable to read "/home/tmagulski/Dokumenty/magul/i18n/core_stable/qqq.json" file (Error code: ENOENT). Use --force to continue.

was occuring since @Dalba change (rPWINcd138ef95047) and was reintroduced in direct child of it (rPWIN23b8beeeeb57)

Feb 24 2017, 10:24 AM · translatewiki.net, Pywikibot, Pywikibot-i18n
Magul updated subscribers of T158944: Verifying i18n commits is broken.

I've digged one revert from last December (rPWINcd138ef95047e2b4e304d934f640f90e1abf68a3) that looks like something connected.

Feb 24 2017, 10:11 AM · translatewiki.net, Pywikibot, Pywikibot-i18n

Feb 21 2017

Magul added a comment to T158519: Lot of AssertionError: "^$" does not match "None" on Travis CI.

@Phantom42 Yes, I agree. Actually if You would read my comments above, I done the same research few days ago.

Feb 21 2017, 11:50 PM · Patch-For-Review, Pywikibot-tests, Pywikibot

Feb 19 2017

Magul added a comment to T158519: Lot of AssertionError: "^$" does not match "None" on Travis CI.

I've checked on Py2,6 and Py2.7 and str(StopIteration()) results with '' so this assertion should be meet in either way. I also checked, that we use unittest2 as unittest for Python versions lower then 2.7.3. I believe problem could be somwhere there.

Feb 19 2017, 11:48 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul added a comment to T158519: Lot of AssertionError: "^$" does not match "None" on Travis CI.

This particular line that is failing has been introduced in our code in rPWBC2c33f951

Feb 19 2017, 11:16 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul updated subscribers of T158519: Lot of AssertionError: "^$" does not match "None" on Travis CI.

I've checked few dozens of builds on our Travis and it looks, that this one first occurs in here. The commit that introduced it was fix for Py2.6 support after introduction of pytest-httpbin.

Feb 19 2017, 10:59 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul created T158519: Lot of AssertionError: "^$" does not match "None" on Travis CI.
Feb 19 2017, 10:26 PM · Patch-For-Review, Pywikibot-tests, Pywikibot

Feb 4 2017

Magul added a comment to T157188: AttributeError: can't set attribute on Travis.

Great!

Feb 4 2017, 2:16 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul updated subscribers of T157188: AttributeError: can't set attribute on Travis.

It occurs after change rPWBC5138dd7351c9a7eb21791dcfb3b64e276e6bb445 (gerrit: https://gerrit.wikimedia.org/r/#/c/332384/)

Feb 4 2017, 1:45 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul created T157188: AttributeError: can't set attribute on Travis.
Feb 4 2017, 1:33 PM · Patch-For-Review, Pywikibot-tests, Pywikibot

Jan 13 2017

Magul added a comment to T154771: Abandon support for Python 2.6.

Ok @Xqt I upload patch that abandon 2.6 and introduce 3.6 on our Travis CI and Appveyor CI. Feel free to review.

Jan 13 2017, 1:00 AM · Pywikibot-Announce, Patch-For-Review, Pywikibot
Magul added a comment to T154412: Pywikibot should warn if six is not installed.

Is there any reason to inform user in any other fashion then ImportError and is there any particular reason that it should be implemented for six package and not some else?

Jan 13 2017, 12:35 AM · Pywikibot

Jan 12 2017

Magul updated the task description for T154771: Abandon support for Python 2.6.
Jan 12 2017, 10:52 PM · Pywikibot-Announce, Patch-For-Review, Pywikibot
Magul edited parent tasks for T103064: Measure current usage of Python 2.6 vs 2.7, added: T154771: Abandon support for Python 2.6; removed: T103063: Drop py2.6 support.
Jan 12 2017, 10:45 PM · Pywikibot
Magul removed a subtask for T103063: Drop py2.6 support: T103064: Measure current usage of Python 2.6 vs 2.7.
Jan 12 2017, 10:45 PM · Pywikibot
Magul added a subtask for T154771: Abandon support for Python 2.6: T103064: Measure current usage of Python 2.6 vs 2.7.
Jan 12 2017, 10:45 PM · Pywikibot-Announce, Patch-For-Review, Pywikibot
Magul added a comment to T154771: Abandon support for Python 2.6.

It looks like Your patch requires rebase and it should also remove Python 2.6 from Travis CI and Appveyor CI.

Jan 12 2017, 7:16 PM · Pywikibot-Announce, Patch-For-Review, Pywikibot
Magul closed T154947: testNamespaceAliases fails on Travis as Resolved.
Jan 12 2017, 7:07 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul closed T154947: testNamespaceAliases fails on Travis, a subtask of T151145: Make Travis (and Appveyor) pass again, as Resolved.
Jan 12 2017, 7:07 PM · Pywikibot-tests, Pywikibot
Magul added a comment to T154947: testNamespaceAliases fails on Travis.

@Dereckson You have my full support on that. Actually we right now have little (or no) unittests in pywikibot and I would like to change it.

Jan 12 2017, 11:13 AM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul added a comment to T154947: testNamespaceAliases fails on Travis.

I was going create this patch, but You're welcome to do it also, I will just review it (remember about sorting list).

Jan 12 2017, 9:42 AM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul closed T154955: Possible regression after changes in language code for Norwegian wiki as Resolved.
Jan 12 2017, 1:04 AM · Wikimedia-Language-setup

Jan 11 2017

Magul added a comment to T154955: Possible regression after changes in language code for Norwegian wiki.

So can we close this issue? What do You think? @jhsoby ?

Jan 11 2017, 11:33 PM · Wikimedia-Language-setup
Magul added a comment to T154955: Possible regression after changes in language code for Norwegian wiki.

Yep, You're most probably right. I will create patch for this test in Pywikibot

Jan 11 2017, 11:33 PM · Wikimedia-Language-setup

Jan 10 2017

Magul added a comment to T154955: Possible regression after changes in language code for Norwegian wiki.

In Pywikibot we run whole test suit on Travis after every merge. This build is the first one that have this test failing. Previous one didn't fail on that.

Jan 10 2017, 2:45 PM · Wikimedia-Language-setup
Magul created T154955: Possible regression after changes in language code for Norwegian wiki.
Jan 10 2017, 12:26 AM · Wikimedia-Language-setup

Jan 9 2017

Magul closed T151850: not found pywikibot.specialbots module as Invalid.

Closing it as invalid, because there were no activity for over a month from @Shizhao and I was not able to reproduce it.

Jan 9 2017, 10:46 PM · Pywikibot
Magul created T154947: testNamespaceAliases fails on Travis.
Jan 9 2017, 10:35 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul reassigned T151369: test_search_where is failing on Travis from Magul to Dalba.
Jan 9 2017, 10:26 PM · Pywikibot-tests, Pywikibot
Magul closed T151369: test_search_where is failing on Travis as Resolved.

@Dalba found a reason why we have problems and remove 2 tests. I'm closing it as resolved.

Jan 9 2017, 10:25 PM · Pywikibot-tests, Pywikibot
Magul closed T151369: test_search_where is failing on Travis, a subtask of T151145: Make Travis (and Appveyor) pass again, as Resolved.
Jan 9 2017, 10:25 PM · Pywikibot-tests, Pywikibot

Jan 7 2017

Magul added a comment to T85328: PEP-8 compliance.

@Huji I'm aware that we are running 4 jobs to verify any gerrit patch, but haven't found time to check how they are defined. There is also plan to move the whole testing procedure to Wikimedia CI infrastructure (see task T132138), so if You have time to update our jobs there that will be really big step in right direction.

Jan 7 2017, 3:11 PM · Pywikibot

Jan 6 2017

Magul added a comment to T85328: PEP-8 compliance.

Hi @Huji I don't remember if it is actually pointed out in original PEP-8 document but it was introduced in pycodestyle (formerly known as pep8, changed on direct Guido's requests) as warning W292.

Jan 6 2017, 6:26 PM · Pywikibot
Magul added a project to T154771: Abandon support for Python 2.6: Pywikibot.
Jan 6 2017, 2:35 PM · Pywikibot-Announce, Patch-For-Review, Pywikibot
Magul created T154771: Abandon support for Python 2.6.
Jan 6 2017, 2:07 PM · Pywikibot-Announce, Patch-For-Review, Pywikibot

Jan 1 2017

Magul closed T138911: isbn.py -to13 has fatal error when processing an ISBN13 as Resolved.
Jan 1 2017, 1:12 PM · Patch-For-Review, good first bug, Pywikibot-Scripts, Pywikibot
Magul closed T152996: newitem.py -touch crashes on locked pages as Resolved.
Jan 1 2017, 12:56 PM · Patch-For-Review, Pywikibot-Wikidata, Pywikibot, Pywikibot-touch.py

Dec 29 2016

Magul added a comment to T152996: newitem.py -touch crashes on locked pages.

@Lokal_Profil and where is this @Dalba commnet? I cannot see it here or on gerrit.

Dec 29 2016, 9:10 AM · Patch-For-Review, Pywikibot-Wikidata, Pywikibot, Pywikibot-touch.py

Dec 23 2016

Magul added a comment to T152996: newitem.py -touch crashes on locked pages.

I'm happy to merge as is. Consistently applying the 80 char limit trumps the minor aesthetic loss in this particular case.

Dec 23 2016, 8:07 PM · Patch-For-Review, Pywikibot-Wikidata, Pywikibot, Pywikibot-touch.py

Dec 21 2016

Magul added a comment to T106121: RFC removing old code / code cleanup.

Great, thank You!

Dec 21 2016, 10:09 PM · Pywikibot-RfCs, Patch-For-Review, Proposal, Pywikibot
Magul closed T153838: AttributeError: 'DummyThrottle' object has no attribute '_lagvalue' in test_valid_lagpattern as Resolved.
Dec 21 2016, 9:47 PM · Patch-For-Review, Pywikibot, Pywikibot-tests
Magul closed T153838: AttributeError: 'DummyThrottle' object has no attribute '_lagvalue' in test_valid_lagpattern, a subtask of T151145: Make Travis (and Appveyor) pass again, as Resolved.
Dec 21 2016, 9:47 PM · Pywikibot-tests, Pywikibot
Magul added a comment to T151369: test_search_where is failing on Travis.

Shit, I haven't test it, just assumed, that it will work. I will looks further into it. :/

Dec 21 2016, 8:27 PM · Pywikibot-tests, Pywikibot
Magul added a comment to T153891: generate_family_file.py crashes for a private wiki.

Primary repository is available here: ssh://gerrit.wikimedia.org:29418/pywikibot/core

Dec 21 2016, 8:07 PM · Pywikibot
Magul added a comment to T153891: generate_family_file.py crashes for a private wiki.

@maiden_taiwan I see that You're testing today a lot with 2.0rc5 release. Could You test it also on tip of master branch?

Dec 21 2016, 7:48 PM · Pywikibot
Magul edited parent tasks for T128994: Some proofread page tests are writing to the wiki without being declared as write tests, added: T152961: Improve tests suite; removed: T128986: proofread page tests fail if username is not present.
Dec 21 2016, 3:56 PM · Pywikibot-tests, Pywikibot
Magul added a subtask for T152961: Improve tests suite: T128994: Some proofread page tests are writing to the wiki without being declared as write tests.
Dec 21 2016, 3:56 PM · Pywikibot-tests, Pywikibot
Magul removed a subtask for T128986: proofread page tests fail if username is not present: T128994: Some proofread page tests are writing to the wiki without being declared as write tests.
Dec 21 2016, 3:56 PM · Pywikibot-tests, Pywikibot
Magul renamed T151110: RFC: Regressions of core should be rethought or solved from RFC: Regressions of core should be rethinked or solved to RFC: Regressions of core should be rethought or solved.
Dec 21 2016, 2:04 PM · Pywikibot-compat-to-core, Pywikibot, Pywikibot-RfCs
Magul added a comment to T106121: RFC removing old code / code cleanup.

I don't agree. The whole thing with releases is just a giant time sink. We just killed off compat to not have to worry about multiple versions any more. I'd rather have people spend time on improving Pywikibot and fixing bugs, than waste time on some release nobody uses anyway. No, I'm not going to pin on some old version. Pywikibot you run on master. If you run into an issue, you update it to the latest version. If you run into the same issue again, you file a bug and get it fixed. If people are not able to do a simple git clone/git pull, they shouldn't be running Pywikibot at all (or just http://paws.wmflabs.org/).
We tried releases, we failed, let's abandon it.

Dec 21 2016, 1:59 PM · Pywikibot-RfCs, Patch-For-Review, Proposal, Pywikibot

Dec 19 2016

Magul closed T152435: super setUp()s and tearDown()s in unit test cases as Resolved.
Dec 19 2016, 5:38 PM · Patch-For-Review, Google-Code-In-2016, good first bug, Pywikibot-tests

Dec 18 2016

Magul created T153594: No disambiguation category name found' not found in 'No wikidata qualifier found for disambiguation category name in wikidata_family file' on Travis.
Dec 18 2016, 2:44 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul created T153593: UnboundLocalError on Travis.
Dec 18 2016, 2:04 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul created T153592: test_load_from_pageids_pipe_separated is failing on Travis.
Dec 18 2016, 2:02 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul updated subscribers of T152996: newitem.py -touch crashes on locked pages.
Dec 18 2016, 12:24 PM · Patch-For-Review, Pywikibot-Wikidata, Pywikibot, Pywikibot-touch.py
Magul updated subscribers of T152996: newitem.py -touch crashes on locked pages.

@Dalba , @Xqt could check this review? There is a question about 79-characters limitation - do we want to always stick to it or do we aproach this limitation in more liberal way?

Dec 18 2016, 11:33 AM · Patch-For-Review, Pywikibot-Wikidata, Pywikibot, Pywikibot-touch.py
Magul merged T129732: test_search_where fails due to differing results into T151369: test_search_where is failing on Travis.
Dec 18 2016, 10:52 AM · Pywikibot-tests, Pywikibot
Magul merged task T129732: test_search_where fails due to differing results into T151369: test_search_where is failing on Travis.
Dec 18 2016, 10:52 AM · Pywikibot-tests, Pywikibot
Magul added a parent task for T129732: test_search_where fails due to differing results: T151145: Make Travis (and Appveyor) pass again.
Dec 18 2016, 10:51 AM · Pywikibot-tests, Pywikibot
Magul added a subtask for T151145: Make Travis (and Appveyor) pass again: T129732: test_search_where fails due to differing results.
Dec 18 2016, 10:51 AM · Pywikibot-tests, Pywikibot
Magul removed a subtask for T129732: test_search_where fails due to differing results: T151145: Make Travis (and Appveyor) pass again.
Dec 18 2016, 10:51 AM · Pywikibot-tests, Pywikibot
Magul removed a parent task for T151145: Make Travis (and Appveyor) pass again: T129732: test_search_where fails due to differing results.
Dec 18 2016, 10:51 AM · Pywikibot-tests, Pywikibot
Magul added a subtask for T129732: test_search_where fails due to differing results: T151145: Make Travis (and Appveyor) pass again.
Dec 18 2016, 10:50 AM · Pywikibot-tests, Pywikibot
Magul added a parent task for T151145: Make Travis (and Appveyor) pass again: T129732: test_search_where fails due to differing results.
Dec 18 2016, 10:50 AM · Pywikibot-tests, Pywikibot

Dec 17 2016

Magul added a comment to T150299: Interwiki link with p.title(asLink=True).

@Mayank.jindal5 first of all, You should listen to @Framawiki advice and get used look for answers on our IRC channel.

Dec 17 2016, 4:07 PM · Patch-For-Review, good first bug, Pywikibot
Magul added a comment to T151369: test_search_where is failing on Travis.

I've tested 707 sites (all production sites: commons, wikidata, wikipedia, wikivoyage, wiktionary, wikibooks, wikinews, wikiquote, wikisource, wikiversity). The whole test takes around 25 minuts.

Dec 17 2016, 3:36 PM · Pywikibot-tests, Pywikibot
Magul added a project to P4646 test_T151369.py result: Pywikibot.
Dec 17 2016, 3:35 PM · Chinese-Sites, Pywikibot
Magul created P4646 test_T151369.py result.
Dec 17 2016, 3:25 PM · Chinese-Sites, Pywikibot
Magul created P4645 test_T151369.py.
Dec 17 2016, 3:20 PM · Pywikibot
Magul added a comment to T153501: TestSiteGenerators.testLinkMethods is failing on Travis CI.
Dec 17 2016, 1:43 AM · Patch-For-Review, Pywikibot-tests, Pywikibot

Dec 16 2016

Magul created T153501: TestSiteGenerators.testLinkMethods is failing on Travis CI.
Dec 16 2016, 10:00 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul closed T153470: UnknownSite on Travis CI as Resolved.
Dec 16 2016, 9:12 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul closed T153470: UnknownSite on Travis CI, a subtask of T151145: Make Travis (and Appveyor) pass again, as Resolved.
Dec 16 2016, 9:12 PM · Pywikibot-tests, Pywikibot
Magul updated subscribers of T128986: proofread page tests fail if username is not present.

Change 327777 had a related patch set uploaded (by Mpaa):
Fix proofreadpage.purge()
https://gerrit.wikimedia.org/r/327777

Dec 16 2016, 7:19 PM · Pywikibot-tests, Pywikibot
Magul added a comment to T150299: Interwiki link with p.title(asLink=True).

@Mayank.jindal5 for your comfort it would be great if You could install virtualenv and create one for pywikibot (see: 1).

Dec 16 2016, 5:09 PM · Patch-For-Review, good first bug, Pywikibot
Magul created T153470: UnknownSite on Travis CI.
Dec 16 2016, 4:21 PM · Patch-For-Review, Pywikibot-tests, Pywikibot
Magul moved T153308: Install requests_oauthlib at Toollabs exec nodes from Backlog to Wikimedia prod/Cloud Services issues on the Pywikibot board.
Dec 16 2016, 3:15 PM · Pywikibot, Toolforge
Magul claimed T152996: newitem.py -touch crashes on locked pages.
Dec 16 2016, 3:02 PM · Patch-For-Review, Pywikibot-Wikidata, Pywikibot, Pywikibot-touch.py
Magul added a comment to T150299: Interwiki link with p.title(asLink=True).

Hi @Mayank.jindal5, nice to see You here. Have fun trying to solve this issue, and if You would have any specific question, don't hesitate to ask.

Dec 16 2016, 1:54 PM · Patch-For-Review, good first bug, Pywikibot
Magul edited parent tasks for T74861: travis-ci builds stall occasionally, added: T152961: Improve tests suite; removed: T151145: Make Travis (and Appveyor) pass again.
Dec 16 2016, 1:27 AM · Pywikibot-archivebot.py, Pywikibot-tests, Pywikibot, Pywikibot-network
Magul removed a subtask for T151145: Make Travis (and Appveyor) pass again: T74861: travis-ci builds stall occasionally.
Dec 16 2016, 1:27 AM · Pywikibot-tests, Pywikibot
Magul added a subtask for T152961: Improve tests suite: T74861: travis-ci builds stall occasionally.
Dec 16 2016, 1:27 AM · Pywikibot-tests, Pywikibot
Magul added a comment to T74861: travis-ci builds stall occasionally.

Issue about TestFactoryGenerator::test_random_generator_ns_multi was resolved in T150892.

Dec 16 2016, 1:26 AM · Pywikibot-archivebot.py, Pywikibot-tests, Pywikibot, Pywikibot-network
Magul added a comment to T74861: travis-ci builds stall occasionally.

In last 7 months there were more then 200 occurrences of The build has been terminated (around 5 months ago, build #3545 practically every build has stalled). I have examined almost 100 of them.

Dec 16 2016, 1:22 AM · Pywikibot-archivebot.py, Pywikibot-tests, Pywikibot, Pywikibot-network