Mainframe98 (Klaas Skelte van der Werf)
Administrator on MediaWiki.org and volunteer developer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
May 18 2016, 8:19 PM (109 w, 1 d)
Availability
Available
IRC Nick
Mainframe98
LDAP User
Mainframe98
MediaWiki User
Mainframe98

Recent Activity

Today

Mainframe98 added a project to T197860: Special:Userrights does not display temporary groups if the user is in no non-temporary, non-automatic groups: MediaWiki-User-management.
Thu, Jun 21, 12:30 PM · Patch-For-Review, MediaWiki-Platform-Team (MWPT-Q4-Apr-Jun-2018), MediaWiki-Special-pages

Mon, Jun 18

Mainframe98 added a comment to T196855: Diffusion commits stuck in 'Importing...' status for too long.

It appears that the history of rMW is still stuck on importing, and no commits are listed after Monday, June 11. Gerrit correctly reports commits after that date: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/. Is there something that is still missing?

Mon, Jun 18, 8:18 AM · Diffusion

Sun, Jun 17

Mainframe98 updated the task description for T197533: SpecialPage::getTitle Deprecation warning in UserExport.
Sun, Jun 17, 8:53 AM · User-MarcoAurelio, MediaWiki-extensions-Other
Mainframe98 created T197533: SpecialPage::getTitle Deprecation warning in UserExport.
Sun, Jun 17, 8:52 AM · User-MarcoAurelio, MediaWiki-extensions-Other

Fri, Jun 15

Mainframe98 added projects to T197464: DBQuery error on Commons: "Error: 1205 Lock wait timeout exceeded": Commons, MediaWiki-File-management, MediaWiki-Page-deletion.
Fri, Jun 15, 12:02 PM · Wikimedia-log-errors, MediaWiki-Page-deletion, MediaWiki-File-management, Commons, Multimedia
Mainframe98 claimed T184601: Nostalgia shows MediaWikiUI button for the special page selector.
Fri, Jun 15, 8:23 AM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Nostalgia

Mon, Jun 11

Gerrit Code Review <gerrit@wikimedia.org> committed rEATC2ec6d797b02e: Update patch set 6 (authored by Mainframe98).
Update patch set 6
Mon, Jun 11, 6:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEATC6c12dabff6b0: Update patch set 6 (authored by Mainframe98).
Update patch set 6
Mon, Jun 11, 6:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEATC07fbd3f616e6: Update patch set 5 (authored by Mainframe98).
Update patch set 5
Mon, Jun 11, 6:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEATC1e7b863e25a2: Update patch set 4 (authored by Mainframe98).
Update patch set 4
Mon, Jun 11, 6:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEATC38c25553779c: Update patch set 4 (authored by Mainframe98).
Update patch set 4
Mon, Jun 11, 6:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEATC0ca5e0f9a4d9: Update patch set 4 (authored by Mainframe98).
Update patch set 4
Mon, Jun 11, 6:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEATC578ce8df2fb2: Update patch set 3 (authored by Mainframe98).
Update patch set 3
Mon, Jun 11, 6:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEATC7a1cfa514f38: Update patch set 2 (authored by Mainframe98).
Update patch set 2
Mon, Jun 11, 6:20 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEATC7041a714834a: Update patch set 1 (authored by Mainframe98).
Update patch set 1
Mon, Jun 11, 6:20 PM

Sat, Jun 9

Mainframe98 awarded T196812: Make PolyGerrit the default ui a Love token.
Sat, Jun 9, 6:01 PM · Release-Engineering-Team, User-notice, Patch-For-Review, Gerrit
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTPd979ff5b7435: Update patch set 1 (authored by Mainframe98).
Update patch set 1
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTPa232febdcc36: Update patch set 1 (authored by Mainframe98).
Update patch set 1
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTP66d86ba55f2a: Create change (authored by Mainframe98).
Create change
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTP4cff9d169988: Update patch set 1 (authored by Mainframe98).
Update patch set 1
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTP06a7b7eda9af: Update patch set 1 (authored by Mainframe98).
Update patch set 1
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTP2872ab38851c: Final NoteDb migration updates (authored by Mainframe98).
Final NoteDb migration updates
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTP6a86f0e7a48f: Update patch set 1 (authored by Mainframe98).
Update patch set 1
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTPa8e0c9abb977: Create change (authored by Mainframe98).
Create change
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTP334a399d330b: Update patch set 1 (authored by Mainframe98).
Update patch set 1
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTP972af6c4939b: Create change (authored by Mainframe98).
Create change
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTP428d5e5c9f17: Final NoteDb migration updates (authored by Mainframe98).
Final NoteDb migration updates
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTP8dd8c827564f: Update patch set 1 (authored by Mainframe98).
Update patch set 1
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTP499dbbafa9a0: Create change (authored by Mainframe98).
Create change
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTP50de98b8447e: Update patch set 2 (authored by Mainframe98).
Update patch set 2
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTPebbaaad9a0e2: Final NoteDb migration updates (authored by Mainframe98).
Final NoteDb migration updates
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTP049db82ddb26: Update patch set 2 (authored by Mainframe98).
Update patch set 2
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTPfa164372382f: Create patch set 2 (authored by Mainframe98).
Create patch set 2
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTPeda7a1a40477: Create change (authored by Mainframe98).
Create change
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTPff5d8f732a51: Final NoteDb migration updates (authored by Mainframe98).
Final NoteDb migration updates
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTPe9cf0ee795e5: Update patch set 1 (authored by Mainframe98).
Update patch set 1
Sat, Jun 9, 10:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEOTP631c2891ef58: Create change (authored by Mainframe98).
Create change
Sat, Jun 9, 10:27 AM

Tue, Jun 5

Mainframe98 awarded T193572: Make mediawiki-l archives indexed by search engines a Like token.
Tue, Jun 5, 10:46 AM · Operations, Patch-For-Review, Wikimedia-Mailing-lists

Mon, Jun 4

Mainframe98 added a project to T196326: Change logo of mxwikimedia: Wikimedia-Site-requests.
Mon, Jun 4, 5:16 AM · User-Urbanecm, Wikimedia-Site-requests

Sun, Jun 3

Mainframe98 added a comment to T196225: InitialiseSettings.php and a few of other files are executable.

@Urbanecm Excellent, thank you!

Sun, Jun 3, 6:32 PM · Wikimedia-Site-requests, User-Urbanecm
Mainframe98 added a comment to T184884: User account on MediaWiki shows it has two edits, but nothing visible in deleted contributions.

Something fishy is going on.
When a user is expected to have no deleted contributions, Special:DeletedContributions should show the message nocontribs, but that message is not shown on https://www.mediawiki.org/wiki/Special:DeletedContributions/JamieCarollKrol. It shows the output of an empty pager instead. Compare to https://www.mediawiki.org/wiki/Special:DeletedContributions/MainframeBot.

Sun, Jun 3, 2:53 PM · XTools, MediaWiki-extensions-CentralAuth

Sat, Jun 2

Mainframe98 added a comment to T196225: InitialiseSettings.php and a few of other files are executable.

And the test is picked up correctly by Jenkins, and the test fails as expected: https://integration.wikimedia.org/ci/job/operations-mw-config-composer-test-docker/3938/console.

Sat, Jun 2, 3:38 PM · Wikimedia-Site-requests, User-Urbanecm
Mainframe98 added a comment to T196225: InitialiseSettings.php and a few of other files are executable.

Running minus-x shows that a total of four files within the repository should not be executable (according to minus-x):

Are you sure that mediawiki-config/rpc/RunSingleJob.php and mediawiki-config/rpc/RunJobs.php are not to be executable? I don't know, I'm just asking.

Sat, Jun 2, 3:36 PM · Wikimedia-Site-requests, User-Urbanecm
Mainframe98 added a comment to T196225: InitialiseSettings.php and a few of other files are executable.

Running minus-x shows that a total of four files within the repository should not be executable (according to minus-x):

mediawiki-config/wmf-config/InitialiseSettings.php should not be executable
mediawiki-config/rpc/RunJobs.php should not be executable
mediawiki-config/rpc/RunSingleJob.php should not be executable
mediawiki-config/docroot/noc/conf/InitialiseSettings.php.txt should not be executable

I'll prep a patch that will add minus-x.

Sat, Jun 2, 3:26 PM · Wikimedia-Site-requests, User-Urbanecm
Mainframe98 added a comment to T196225: InitialiseSettings.php and a few of other files are executable.

As rOMWC has a composer.json file, should MinusX be added so this can be checked by the tests? It should probably be run as part of the operations-mw-config-composer-test-docker test.

Sat, Jun 2, 1:47 PM · Wikimedia-Site-requests, User-Urbanecm

Fri, Jun 1

Mainframe98 merged T196148: "Restore all default settings" button not wide enough; button text cut at the end into T195977: Button "Restore all settings" does not have enough width for its text.
Fri, Jun 1, 12:22 PM · MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), Patch-For-Review, CSS, MediaWiki-User-preferences
Mainframe98 merged task T196148: "Restore all default settings" button not wide enough; button text cut at the end into T195977: Button "Restore all settings" does not have enough width for its text.
Fri, Jun 1, 12:22 PM · Regression, OOUI, MediaWiki-User-preferences

Fri, May 25

Mainframe98 added a comment to T195580: Can't edit preferences on Beta Cluster due to PHP fatal error.

This is probably related to rMWc513ec19efa7: Restore 'PreferencesForm' as alias for 'PreferencesFormLegacy', which attempted to resolve this with a class alias by having PreferencesForm extend PreferencesFormLegacy. (https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/specials/forms/PreferencesFormLegacy.php$152)

Fri, May 25, 1:13 PM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), MediaWiki-User-preferences, Page-Previews, Beta-Cluster-reproducible

Thu, May 24

Mainframe98 added a comment to T195520: Multiple projects reporting Cannot access the database: No working replica DB server.

Still intermittently receiving this error while attempting to combat spam.

Thu, May 24, 7:57 PM · User-Addshore, Wikidata-Campsite, MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Wikidata-Ministry-Of-Magic, Wikimedia-Incident, Wikidata, Patch-For-Review, Wikimedia-General-or-Unknown, Wikimedia-log-errors, Operations
Mainframe98 added a watcher for MediaWiki-ServiceContainer: Mainframe98.
Thu, May 24, 9:57 AM

May 15 2018

Mainframe98 added a comment to T194727: Archive the Sort extension.

Thank you!

May 15 2018, 10:58 AM · User-MarcoAurelio, MediaWiki-extensions-Sort, Cleanup
Mainframe98 assigned T194727: Archive the Sort extension to MarcoAurelio.

I didn't realize that rSVN is archived as a whole. Adding an OBSOLETE file is pretty pointless then, if not impossible.

May 15 2018, 10:18 AM · User-MarcoAurelio, MediaWiki-extensions-Sort, Cleanup
Mainframe98 updated the task description for T194727: Archive the Sort extension.
May 15 2018, 8:02 AM · User-MarcoAurelio, MediaWiki-extensions-Sort, Cleanup
Mainframe98 updated the task description for T194727: Archive the Sort extension.
May 15 2018, 7:56 AM · User-MarcoAurelio, MediaWiki-extensions-Sort, Cleanup
Mainframe98 created T194727: Archive the Sort extension.
May 15 2018, 7:56 AM · User-MarcoAurelio, MediaWiki-extensions-Sort, Cleanup
Mainframe98 added a member for Cleanup: Mainframe98.
May 15 2018, 7:48 AM

May 6 2018

Mainframe98 added a comment to T193989: Extension:ApiExplorer is missing licensing.

Wikia sunset this extension with #14551. It does not appear to ever have a license specified, but Wikia kept the extension in their main App repository, which means it falls under the GPL 2.0-or-later license of that repository.
Considering Wikia has sunset the extension (and the now integrated ApiSandbox extension is arguably more complete and supported), we should consider doing the same.

May 6 2018, 7:28 PM · MediaWiki-extensions-Other, Software-Licensing

Apr 23 2018

Mainframe98 added a comment to T189366: OOUI styles aren't available separately for certain modules.

Will be fixed if the patch for T192769: Special:Preferences: OOUI tabs cause a FOUC because the PHP side doesn't hack in their HTML, unlike the non-OOUI tabs gets merged; https://gerrit.wikimedia.org/r/c/428326.

Apr 23 2018, 12:44 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review, OOUI
Mainframe98 added a comment to T192754: Regression: OOUI checkboxes collapsing.

The php part is provided via composer, since it is not listed in autoload.php. (And PhpStorm doesn't complain about duplicate definitions)
The JavaScript and stylesheets are, according to Resources.php, provided via resources/lib. There are no PHP files in there, so those are provided using composer. Perhaps that is because vendor/ doesn't need to be web-accessible this way?

Apr 23 2018, 10:09 AM · MediaWiki-General-or-Unknown, OOUI
Mainframe98 added a comment to T192754: Regression: OOUI checkboxes collapsing.

I have experienced this as well, and fixed it by running composer update.

Apr 23 2018, 4:46 AM · MediaWiki-General-or-Unknown, OOUI

Apr 22 2018

Mainframe98 triaged T192467: Remove unused configuration global $wgSiteSupportPage as Normal priority.

Then, all that's left is removing from InitialiseSettings.php.

Apr 22 2018, 10:16 AM · Wikimedia-Site-requests, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Technical-Debt

Apr 19 2018

Mainframe98 updated the task description for T192467: Remove unused configuration global $wgSiteSupportPage.
Apr 19 2018, 11:48 AM · Wikimedia-Site-requests, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Technical-Debt
Mainframe98 updated subscribers of T192467: Remove unused configuration global $wgSiteSupportPage.

@Krinkle You've added the MW-1.31-release project, so does that mean this should also be back-ported to 1.31?

Apr 19 2018, 11:43 AM · Wikimedia-Site-requests, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Technical-Debt

Apr 18 2018

Mainframe98 moved T192467: Remove unused configuration global $wgSiteSupportPage from Unsorted to Deprecate / Remove on the Technical-Debt board.
Apr 18 2018, 5:07 PM · Wikimedia-Site-requests, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Technical-Debt
Mainframe98 updated the task description for T192467: Remove unused configuration global $wgSiteSupportPage.
Apr 18 2018, 4:11 PM · Wikimedia-Site-requests, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Technical-Debt
Mainframe98 created T192467: Remove unused configuration global $wgSiteSupportPage.
Apr 18 2018, 3:59 PM · Wikimedia-Site-requests, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Technical-Debt

Apr 6 2018

Mainframe98 created T191622: Add support for truncating tables.
Apr 6 2018, 12:06 PM · MediaWiki-Database

Mar 22 2018

Mainframe98 added a project to T171666: Implement HTMLFormFieldCloner in OOUIHTMLForm: OOUI.
Mar 22 2018, 7:52 PM · OOUI, MediaWiki-HTMLForm
Mainframe98 created T190417: CheckboxMultiSelectInputWidget doesn't disable when infusing a disabled HTMLMultiSelectField.
Mar 22 2018, 3:30 PM · OOUI

Mar 10 2018

Mainframe98 created T189366: OOUI styles aren't available separately for certain modules.
Mar 10 2018, 9:15 AM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review, OOUI

Mar 6 2018

Mainframe98 added a comment to T188983: Special:Upload on Wikimedia Commons is unusable in languages in which MediaWiki:Licenses isn't explicitly translated.

Same topic: T188822.

Mar 6 2018, 11:10 AM · MediaWiki-Uploading, I18n, Commons, Multimedia

Feb 24 2018

Mainframe98 added a comment to T186963: MWException: CAS update failed on user_touched for user ID '3' (read from replica); the version of the user to be saved is older than the current version.

I've let Jenkins recheck today, which resulted in a +2. I assume rMWe93841a621ca: Force READ_LATEST for User::newFromId() if writes had been done and/or rMW61b0c1930626: Have User::createNew() load the object from master contributed to this. Proposing to close as Resolved.

Feb 24 2018, 11:48 AM · User-MarcoAurelio, Language-Team, MediaWiki-extensions-TranslationNotifications

Feb 23 2018

Mainframe98 added a project to T188129: Request for allowance of multiple account registers from same IP for 2018-02-27: Wikimedia-Site-requests.
Feb 23 2018, 6:51 PM · Patch-For-Review, User-Urbanecm, Wikimedia-Site-requests

Feb 10 2018

Mainframe98 cancelled E825: Spam.
Feb 10 2018, 4:21 PM
Mainframe98 renamed E825: Spam from [Watch/Free] Eastern Washington vs Idaho Live Stream Online Game TV to Spam.
Feb 10 2018, 4:21 PM
Mainframe98 renamed E826: Spam from (Watch/TV)..England vs Wales Live Stream Free Six Nations 2018 to Spam.
Feb 10 2018, 4:20 PM
Mainframe98 cancelled E826: Spam.
Feb 10 2018, 4:20 PM

Feb 8 2018

Mainframe98 added a comment to T185652: AutoProxyBlock uses unserialization on externally obtained php code.

@gerritbot seems to have caught the cherry-pick, so I assume that it went fine. Apparently, git got confused about a function named onRecentChangeSave. The good news is that the docs on cherry-picking are still accurate.

Feb 8 2018, 12:19 PM · Vuln-Inject, Security-Extensions, Patch-For-Review, MediaWiki-extensions-Other, Security
Mainframe98 added a comment to T185652: AutoProxyBlock uses unserialization on externally obtained php code.

It’s not letting me do it, I’m given the same error message you’ve gotten.

Feb 8 2018, 11:33 AM · Vuln-Inject, Security-Extensions, Patch-For-Review, MediaWiki-extensions-Other, Security
Mainframe98 added a comment to T185652: AutoProxyBlock uses unserialization on externally obtained php code.

@Mainframe98 I've uploaded your patch at https://gerrit.wikimedia.org/r/#/c/408941/ and @Bawolff merged it. I think it respects your authorship as you're listed as the author, but I'm listed as the "owner" (I guess it's because the patch was uploaded using my ssh key). Let me know if we should revert/etc. I don't want to take credit for things I didn't do.

Feb 8 2018, 9:22 AM · Vuln-Inject, Security-Extensions, Patch-For-Review, MediaWiki-extensions-Other, Security

Feb 5 2018

Mainframe98 added a comment to T185652: AutoProxyBlock uses unserialization on externally obtained php code.

Taking a closer look at the patch, shouldn't this supply a second argument of true to json_decode to force it into associative mode? The rest of the code seems to treat the result as an associative array.

Feb 5 2018, 5:44 PM · Vuln-Inject, Security-Extensions, Patch-For-Review, MediaWiki-extensions-Other, Security
Mainframe98 added a comment to T185652: AutoProxyBlock uses unserialization on externally obtained php code.

How do I get it merged quickly? All https://www.mediawiki.org/wiki/Reporting_security_bugs tells me is that I shouldn't upload it to Gerrit.

Feb 5 2018, 4:49 PM · Vuln-Inject, Security-Extensions, Patch-For-Review, MediaWiki-extensions-Other, Security

Feb 3 2018

Mainframe98 awarded T186315: Create composer package that contains most of the MediaWiki extension phan config instead of copy/pasting it each time a Like token.
Feb 3 2018, 9:16 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, MediaWiki-extensions-General, Continuous-Integration-Infrastructure

Jan 30 2018

Mainframe98 added a comment to T185652: AutoProxyBlock uses unserialization on externally obtained php code.

However, for best security, one should also urlencode stuff when building the url. e.g. on line 117, instead of manually turning the array to a url, it should use wfArrayToCgi

Done in:

Jan 30 2018, 9:54 AM · Vuln-Inject, Security-Extensions, Patch-For-Review, MediaWiki-extensions-Other, Security

Jan 29 2018

Mainframe98 added a comment to T185883: updateBlacklist.php should be in maintenance/updateBlacklist.php.

@Mainframe98 I'll go with T185883#3927602 but it's "require_one" or "require_once"?

Jan 29 2018, 11:02 AM · User-MarcoAurelio, MediaWiki-extensions-StopForumSpam
Mainframe98 added a comment to T185883: updateBlacklist.php should be in maintenance/updateBlacklist.php.

It'd break current uses, but that could work. The die(); is superfluous though, since the scripts halts after the exception is thrown.

Jan 29 2018, 10:58 AM · User-MarcoAurelio, MediaWiki-extensions-StopForumSpam
Mainframe98 added a comment to T185883: updateBlacklist.php should be in maintenance/updateBlacklist.php.
<?php
print "This maintenance script has been moved to a new location. It is now located in the maintenance/ folder.\n"
Jan 29 2018, 10:46 AM · User-MarcoAurelio, MediaWiki-extensions-StopForumSpam

Jan 28 2018

Mainframe98 added a comment to T185762: Convert SkinPerNamespace to use extension registration.

Almost. It should go after "value": [] in "SkinPerNamespace".

Jan 28 2018, 5:49 PM · User-MarcoAurelio, MediaWiki-extensions-SkinPerNamespace
Mainframe98 added a comment to T185762: Convert SkinPerNamespace to use extension registration.
Jan 28 2018, 5:38 PM · User-MarcoAurelio, MediaWiki-extensions-SkinPerNamespace

Jan 27 2018

Mainframe98 updated subscribers of T185762: Convert SkinPerNamespace to use extension registration.

While code reviewing the patch I encountered some weird behaviour of the extension registry:
It appears that it resets the indexes of a configuration variable when that variable is an array where the keys are numerical.
This only occurs when the configuration variable is defined in extension.json. (Meaning that the registry will have to check if the variable has already been defined and merge if it has been defined)
For example, if extension.json defines a configuration variable as

"SkinPerNamespace": {
	"value": {
		"5": "monobook"
	}
},

the value of it will be reset back to 0.
If the configuration variable is defined in LocalSettings.php, the extension registry will renumber the indexes to follow the default definition.
A manual definition of

$wgSkinPerNamespace[3] = 'monobook';
$wgSkinPerNamespace[5] = 'monobook';

will result in the actual value of $wgSkinPerNamespace being

$wgSkinPerNamespace = [
	0 => 'monobook',
	1 => 'monobook',
	2 => 'monobook'
];

The only case when this doesn't appear to happen is when the registry has already loaded the extension when defining $wgSkinPerNamespace, I.E. using ExtensionRegistry::getInstance()->loadFromQueue();.

Jan 27 2018, 1:48 PM · User-MarcoAurelio, MediaWiki-extensions-SkinPerNamespace

Jan 26 2018

Mainframe98 added a comment to T185749: Convert ContributionsList to use extension registration.

Full deprecation notice stack trace that I encountered while testing:

[error] [7413fdf58907661e641f99a4] /w/index.php?title=Test&action=submit   ErrorException from line 309 of /vagrant/mediawiki/includes/debug/MWDebug.php: PHP Deprecated: Use of Revision::pageJoinCond was deprecated in MediaWiki 1.31. [Called from ContributionsList::getQueryInfo in /vagrant/mediawiki/extensions/ContributionsList/ContributionsList.class.php at line 200]
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /vagrant/mediawiki/includes/debug/MWDebug.php(309): trigger_error(string, integer)
#2 /vagrant/mediawiki/includes/debug/MWDebug.php(241): MWDebug::sendMessage(string, array, string, integer)
#3 /vagrant/mediawiki/includes/GlobalFunctions.php(1181): MWDebug::deprecated(string, string, string, integer)
#4 /vagrant/mediawiki/includes/Revision.php(315): wfDeprecated(string, string)
#5 /vagrant/mediawiki/extensions/ContributionsList/ContributionsList.class.php(200): Revision::pageJoinCond()
#6 /vagrant/mediawiki/extensions/ContributionsList/ContributionsList.class.php(153): ContributionsList->getQueryInfo()
#7 /vagrant/mediawiki/extensions/ContributionsList/ContributionsList.class.php(129): ContributionsList->buildQueryInfo()
#8 /vagrant/mediawiki/extensions/ContributionsList/ContributionsList.class.php(117): ContributionsList->doQuery()
#9 /vagrant/mediawiki/extensions/ContributionsList/ContributionsList.hooks.php(58): ContributionsList->__construct(string, string, string, string, string)
#10 /vagrant/mediawiki/includes/parser/Parser.php(3407): ContributionsListHooks::contributionslistParserFunction(Parser, PPFrame_DOM, array)
#11 /vagrant/mediawiki/includes/parser/Parser.php(3108): Parser->callParserFunction(PPFrame_DOM, string, array)
#12 /vagrant/mediawiki/includes/parser/Preprocessor_DOM.php(1259): Parser->braceSubstitution(array, PPFrame_DOM)
#13 /vagrant/mediawiki/includes/parser/Parser.php(2923): PPFrame_DOM->expand(DOMElement, integer)
#14 /vagrant/mediawiki/includes/parser/Parser.php(1282): Parser->replaceVariables(string)
#15 /vagrant/mediawiki/includes/parser/Parser.php(443): Parser->internalParse(string)
#16 /vagrant/mediawiki/includes/content/WikitextContent.php(329): Parser->parse(string, Title, ParserOptions, boolean, boolean, NULL)
#17 /vagrant/mediawiki/includes/content/AbstractContent.php(516): WikitextContent->fillParserOutput(Title, NULL, ParserOptions, boolean, ParserOutput)
#18 /vagrant/mediawiki/includes/EditPage.php(3998): AbstractContent->getParserOutput(Title, NULL, ParserOptions)
#19 /vagrant/mediawiki/includes/EditPage.php(3926): EditPage->doPreviewParse(WikitextContent)
#20 /vagrant/mediawiki/includes/EditPage.php(2673): EditPage->getPreviewText()
#21 /vagrant/mediawiki/includes/EditPage.php(705): EditPage->showEditForm()
#22 /vagrant/mediawiki/includes/actions/EditAction.php(60): EditPage->edit()
#23 /vagrant/mediawiki/includes/actions/SubmitAction.php(38): EditAction->show()
#24 /vagrant/mediawiki/includes/MediaWiki.php(500): SubmitAction->show()
#25 /vagrant/mediawiki/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#26 /vagrant/mediawiki/includes/MediaWiki.php(858): MediaWiki->performRequest()
#27 /vagrant/mediawiki/includes/MediaWiki.php(524): MediaWiki->main()
#28 /vagrant/mediawiki/index.php(42): MediaWiki->run()
#29 /var/www/w/index.php(5): require(string)
#30 {main}
Jan 26 2018, 1:38 PM · MediaWiki-extensions-Other, User-MarcoAurelio
Mainframe98 added a comment to T185384: Convert AutoProxyBlock to use extension registration.

That matches the previous configuration, so that should be okay.
It still leaves the point that pre-extension registration, the log would not exist to MediaWiki at all, while now the log always exists. Considering how many extensions do the same, I think it should be fine though. I'll +1 when T185652 is merged.

Jan 26 2018, 12:32 PM · User-MarcoAurelio, MediaWiki-extensions-Other

Jan 24 2018

Mainframe98 added a comment to T185652: AutoProxyBlock uses unserialization on externally obtained php code.

It shouldn’t be necessary to abandon the patch, although eyeing the changes in that patch it might be better to merge the security fix first before converting to extension registration.

Jan 24 2018, 8:33 PM · Vuln-Inject, Security-Extensions, Patch-For-Review, MediaWiki-extensions-Other, Security
Mainframe98 added a comment to T185652: AutoProxyBlock uses unserialization on externally obtained php code.

Jan 24 2018, 7:59 PM · Vuln-Inject, Security-Extensions, Patch-For-Review, MediaWiki-extensions-Other, Security
Mainframe98 added a comment to T185652: AutoProxyBlock uses unserialization on externally obtained php code.

I've asked @MarcoAurelio to change the default url to use https, so that should be addressed in T185384. I was also thinking of using JSON. I'll see if I can whip up a diff.

Jan 24 2018, 7:43 PM · Vuln-Inject, Security-Extensions, Patch-For-Review, MediaWiki-extensions-Other, Security
Mainframe98 added a comment to T185652: AutoProxyBlock uses unserialization on externally obtained php code.

More details regarding PHP serialization in MediaWiki can be found on T161647: RFC: Deprecate using php serialization inside MediaWiki.

Jan 24 2018, 6:40 PM · Vuln-Inject, Security-Extensions, Patch-For-Review, MediaWiki-extensions-Other, Security
Mainframe98 added a project to T185652: AutoProxyBlock uses unserialization on externally obtained php code: MediaWiki-extensions-Other.
Jan 24 2018, 6:39 PM · Vuln-Inject, Security-Extensions, Patch-For-Review, MediaWiki-extensions-Other, Security
Mainframe98 created T185652: AutoProxyBlock uses unserialization on externally obtained php code.
Jan 24 2018, 6:38 PM · Vuln-Inject, Security-Extensions, Patch-For-Review, MediaWiki-extensions-Other, Security

Jan 23 2018

Mainframe98 added a comment to T185564: Convert BiblioPlus to use extension registration.

It'd be best to create a separate Hooks class with those two functions in it. Something like BiblioPlus.hooks.php.

Jan 23 2018, 5:29 PM · User-MarcoAurelio, BiblioPlus

Jan 15 2018

Mainframe98 claimed T184902: Implement Special:UnusedVideos, a special page to display videos not currently used on any page.

I'm willing to give this a shot.

Jan 15 2018, 7:36 PM · Video (non-WMF), Social-Tools