Page MenuHomePhabricator

Mainframe98 (Klaas Skelte van der Werf)
Administrator on MediaWiki.org and volunteer developer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 18 2016, 8:19 PM (236 w, 6 d)
Availability
Available
IRC Nick
Mainframe98
LDAP User
Mainframe98
MediaWiki User
Mainframe98 [ Global Accounts ]

I use MediaWiki in Dutch. If I ever claim to see something you don't, check if it occurs when setting the user language to Dutch, and remind me to switch too, so we don't get a repetition of T207288. And if I have the bright idea to test something on my local vagrant machine, and it doesn't work, I probably have a messed up vagrant instance and should be reminded to reset it, so we don't get a repetition of T207288.

Recent Activity

Mon, Nov 30

Mainframe98 placed T268952: Defining a handler for MediaWikiServices causes HookContainer::salvage to thrown an exception if the service locator is called before the service bootstrap is complete up for grabs.
Mon, Nov 30, 4:24 PM · MediaWiki-libs-ServiceContainer, MediaWiki-Core-Hooks
Mainframe98 removed a project from T268952: Defining a handler for MediaWikiServices causes HookContainer::salvage to thrown an exception if the service locator is called before the service bootstrap is complete: Patch-For-Review.
Mon, Nov 30, 4:23 PM · MediaWiki-libs-ServiceContainer, MediaWiki-Core-Hooks

Sun, Nov 29

Mainframe98 created T268952: Defining a handler for MediaWikiServices causes HookContainer::salvage to thrown an exception if the service locator is called before the service bootstrap is complete.
Sun, Nov 29, 7:55 PM · MediaWiki-libs-ServiceContainer, MediaWiki-Core-Hooks

Sat, Nov 28

Mainframe98 awarded T268900: Clean up section edit link brackets a Like token.
Sat, Nov 28, 7:41 AM · Design, Accessibility, MediaWiki-Parser

Sat, Nov 14

Mainframe98 committed rEOTPdf4b061886da: Use ConfigFactory and ConfigRegistry for configuration (authored by Mainframe98).
Use ConfigFactory and ConfigRegistry for configuration
Sat, Nov 14, 2:04 PM
Mainframe98 closed T237873: Deprecate and remove extension database updating globals, a subtask of T159283: Deprecate non-configuration globals, as Resolved.
Sat, Nov 14, 9:51 AM · Epic, MediaWiki-General, Technical-Debt
Mainframe98 closed T237873: Deprecate and remove extension database updating globals as Resolved.
Sat, Nov 14, 9:51 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MediaWiki-General, Technical-Debt

Oct 28 2020

Mainframe98 added a comment to T237873: Deprecate and remove extension database updating globals.

While that does work, it doesn't tell us which extension is still using the globals; which makes finding the offending extension difficult.

Right, but we can add the table/columns/etc names to the message, which would be a clear hint.

Oct 28 2020, 6:01 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MediaWiki-General, Technical-Debt

Oct 21 2020

Mainframe98 awarded T262946: Bump Firefox version in basic support to 3.6 or newer a Like token.
Oct 21 2020, 8:27 PM · TechCom-RFC (TechCom-RFC-Closed), Browser-Support-Firefox, Front-end-Standards-Group, MediaWiki-General

Oct 20 2020

Mainframe98 merged T266063: The interwiki section of the sidebar is missing in the modern skin into T265747: No "Languages" section visible in the sidebar of the "Modern" skin.
Oct 20 2020, 7:15 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Modern
Mainframe98 merged task T266063: The interwiki section of the sidebar is missing in the modern skin into T265747: No "Languages" section visible in the sidebar of the "Modern" skin.
Oct 20 2020, 7:15 PM · Modern, Regression
Mainframe98 edited projects for T266063: The interwiki section of the sidebar is missing in the modern skin, added: Modern; removed MediaWiki-Interwiki.
Oct 20 2020, 7:15 PM · Modern, Regression

Oct 17 2020

Mainframe98 added a comment to T265507: 20kb project logo image requested on every page (betawiki.png).

It is provided by ResourceLoaderSkinModule::getPreloadLinks. A solution could be extending that class and overriding getPreloadLinks to return an empty array.

Oct 17 2020, 4:59 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, MediaWiki-skins-WikimediaApiPortal, MediaWiki-extensions-WikimediaApiPortalOAuth

Oct 11 2020

Mainframe98 awarded T259771: RFC: Drop support for database upgrade older than two LTS releases a Like token.
Oct 11 2020, 7:45 AM · MediaWiki-Stakeholders-Group, Platform Engineering, TechCom-RFC

Oct 7 2020

Mainframe98 awarded T264930: Add phan annotations to ObjectFactory a Like token.
Oct 7 2020, 8:03 PM · phan, ObjectFactory

Oct 1 2020

Mainframe98 committed rEOTP002aee6acb0a: Update OrphanedTalkPages for hook handler changes in 1.35 (authored by Mainframe98).
Update OrphanedTalkPages for hook handler changes in 1.35
Oct 1 2020, 7:23 PM
Mainframe98 committed rEOTP7ca8f68981f8: Add phan (authored by Mainframe98).
Add phan
Oct 1 2020, 4:59 PM

Sep 30 2020

Mainframe98 awarded T264163: Add link to codesearch in header a Like token.
Sep 30 2020, 9:51 AM · Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)), Release-Engineering-Team (Development services), Gerrit

Sep 26 2020

Mainframe98 awarded T263883: Verify MediaWiki patch files apply in successive upgrades a Like token.
Sep 26 2020, 7:07 AM · MediaWiki-Releasing

Sep 25 2020

Mainframe98 added a project to T263825: Please create project `MediaWiki-extensions-DrawioEditor`: Project-Admins.
Sep 25 2020, 6:51 AM · Project-Admins
Mainframe98 added a project to T263824: Disable annoying auto popup of menu window: Vector.
Sep 25 2020, 5:22 AM · Vector

Sep 22 2020

Mainframe98 awarded T263513: Create a Special:Namespaces page a Like token.
Sep 22 2020, 10:46 AM · Patch-For-Review, User-DannyS712, MediaWiki-Special-pages

Sep 19 2020

Mainframe98 added a project to T263331: RuntimeError: cannot join current thread after updating to new version/python3: Pywikibot.
Sep 19 2020, 5:55 PM · Pywikibot

Sep 16 2020

Mainframe98 closed T263020: Use of Skin::aboutLink was deprecated in MediaWiki 1.36. [Called from NostalgiaTemplate::afterContent] as Resolved.

This was fixed by @Ammarpad in rSNOS79f029d69ccc: Remove site footer links indirection, and backported to wmf.9 by @Jdlrobson. Given that nostalgiawiki is already at wmf.9, this has effectively already been resolved. (See T258001#6464208).

Sep 16 2020, 3:00 PM · Nostalgia, Wikimedia-production-error

Sep 14 2020

Mainframe98 created T262806: Beta cluster certificates have expired.
Sep 14 2020, 9:55 AM · Operations, Traffic, HTTPS, Beta-Cluster-Infrastructure

Sep 10 2020

Mainframe98 added a comment to T262374: The "In other languages" portal appears unstyled when editing a page.

But for the links appearing on action=edit may I am not sure, though that'd be a bug for MediaWiki-extensions-WikibaseClient then? Also note this is not specific to mediawiki.org

Sep 10 2020, 9:13 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vector (Vector (Tracking))
Mainframe98 updated the task description for T262374: The "In other languages" portal appears unstyled when editing a page.
Sep 10 2020, 9:12 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vector (Vector (Tracking))

Sep 9 2020

Mainframe98 added a project to T262415: Throttle rule for 2020-09-14 - Senior Citizens Write Wikipedia course: Wikimedia-Site-requests.
Sep 9 2020, 1:59 PM · User-Urbanecm, Wikimedia-Site-requests
Mainframe98 added a comment to T262374: The "In other languages" portal appears unstyled when editing a page.

I don't get it; it still happens with safemode=1, but I can't reproduce it on my bot account.

Sep 9 2020, 8:39 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vector (Vector (Tracking))
Mainframe98 created T262374: The "In other languages" portal appears unstyled when editing a page.
Sep 9 2020, 7:11 AM · MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), Vector (Vector (Tracking))

Sep 4 2020

Mainframe98 added a comment to T262067: Skin templateDirectory option should be relative to the skin.

Is coupling a skin with an extension (like Minerva and MobileFrontend used to be) an anti-pattern (or discouraged)? If so, the change would basically be

        protected function getTemplateParser() {
                if ( $this->templateParser === null ) {
-                       $this->templateParser = new TemplateParser( $this->options['templateDirectory'] );
+                       $wgStyleDirectory = $this->getConfig()->get( 'StyleDirectory' );
+
+                       $this->templateParser = new TemplateParser(
+                               $wgStyleDirectory . '/' . $this->options['templateDirectory']
+                       );
                }
                return $this->templateParser;
        }
Sep 4 2020, 4:39 PM · MediaWiki-Configuration, MediaWiki-Core-Skin-Architecture
Mainframe98 added a comment to T262067: Skin templateDirectory option should be relative to the skin.

Is using a non-relative path an option? Specifying /var/www/html/something/templates does not seem usable at all. Wouldn't prefixing the directory with the path to the skin unconditionally make more sense? Like how ResourceFileModulePaths does?

Sep 4 2020, 4:27 PM · MediaWiki-Configuration, MediaWiki-Core-Skin-Architecture
Mainframe98 updated the task description for T262048: Archive the Tomas skin.
Sep 4 2020, 3:40 PM · translatewiki.net, Other-skins, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup
Mainframe98 committed rGTWN0e72dd4ed7f8: Remove reference to Tomas skin (authored by Mainframe98).
Remove reference to Tomas skin
Sep 4 2020, 2:44 PM
Mainframe98 updated the task description for T262048: Archive the Tomas skin.
Sep 4 2020, 2:43 PM · translatewiki.net, Other-skins, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup
Mainframe98 updated the task description for T262048: Archive the Tomas skin.
Sep 4 2020, 2:39 PM · translatewiki.net, Other-skins, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup
Mainframe98 removed a project from T262048: Archive the Tomas skin: MediaWiki-extensions-Other.
Sep 4 2020, 2:24 PM · translatewiki.net, Other-skins, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup
Mainframe98 created T262048: Archive the Tomas skin.
Sep 4 2020, 2:24 PM · translatewiki.net, Other-skins, Wikimedia-GitHub, Diffusion-Repository-Administrators, Projects-Cleanup

Sep 3 2020

Mainframe98 merged T261958: Downloading Excel XLSX files creates file with 0 bytes into T261909: In the Quary tool the download as excel creates empty files.
Sep 3 2020, 2:57 PM · Quarry
Mainframe98 merged task T261958: Downloading Excel XLSX files creates file with 0 bytes into T261909: In the Quary tool the download as excel creates empty files.
Sep 3 2020, 2:57 PM · Quarry

Aug 31 2020

Mainframe98 added projects to T261610: Add a full stop to string "Wikimedia-webauthn-module-description": MediaWiki-extensions-OATHAuth, good first task.
Aug 31 2020, 8:58 AM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), User-MarcoAurelio, good first task, WikimediaMessages, I18n

Aug 24 2020

Mainframe98 added a comment to T261080: ResourceLoaderSkinModule should put feature style files before skin provided style files.

I just ran into this again, this time with styling legend, specifically for the old recent changes. normalize sets its padding to 0, but I want its padding to be 0.5em. The legend element doesn't have a class I can use, and over qualifying is not desirable, because I want to style all legends anyway, not just those on Special:RecentChanges.

Aug 24 2020, 1:25 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, Performance-Team, MediaWiki-ResourceLoader
Mainframe98 added a comment to T257102: Mediawiki 1.34.2 tarball incompatible with 7zip on windows due to Pax format.

I followed the link in https://lists.wikimedia.org/pipermail/wikitech-l/2020-August/093737.html, but that file still has the paxfile issue. Trying to run the web installer prompts me with Uncaught Error: Interface 'MediaWiki\Diff\Hook\DifferenceEngineShowDiffPageMaybeShowMissingRevisionHook'. Looking for the file, it appears to have its filename truncated.

Aug 24 2020, 8:41 AM · Upstream, MediaWiki-Releasing

Aug 23 2020

Mainframe98 created T261080: ResourceLoaderSkinModule should put feature style files before skin provided style files.
Aug 23 2020, 6:34 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Readers-Web-Backlog (Kanbanana-FY-2020-21), MediaWiki-Interface, Performance-Team, MediaWiki-ResourceLoader

Aug 21 2020

Mainframe98 merged T260963: Format error in Gerrit API response - First line starts with: )]}' into T259333: gerrit.wm.o/r/changes/ has leading garbage in the output.
Aug 21 2020, 7:28 AM · User-Kormat, Gerrit, Operations
Mainframe98 merged task T260963: Format error in Gerrit API response - First line starts with: )]}' into T259333: gerrit.wm.o/r/changes/ has leading garbage in the output.
Aug 21 2020, 7:28 AM · Gerrit

Aug 16 2020

Mainframe98 awarded T260503: Split visualeditor Vagrant role a Like token.
Aug 16 2020, 8:20 PM · User-Ryasmeen, VisualEditor, MediaWiki-Vagrant

Aug 15 2020

Mainframe98 closed T260475: Freshly created vagrant box does not create .Xauthority in ~/, causing a warning to be shown as Invalid.

The file is indeed filled with something, that I didn't put there. I'll close this as invalid, assuming the issue doesn't pop up all the time like before.

Aug 15 2020, 2:20 PM · MediaWiki-Vagrant
Mainframe98 added a comment to T244716: Update php-xdebug to 2.9.2 in apt.wm.o component/php72.

Hi folks, could we get this added to our repo?

Aug 15 2020, 1:37 PM · serviceops, Operations
Mainframe98 created T260475: Freshly created vagrant box does not create .Xauthority in ~/, causing a warning to be shown.
Aug 15 2020, 11:32 AM · MediaWiki-Vagrant

Aug 13 2020

Mainframe98 added a project to T260327: formatting of head line broken: Metrolook.
Aug 13 2020, 7:54 AM · Metrolook

Aug 11 2020

Mainframe98 merged T260103: Anonnotice cannot be dismissed into T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing.
Aug 11 2020, 7:18 AM · Patch-For-Review, MediaWiki-HTML-Templating, Vector (Vector (Tracking)), Regression, DismissableSiteNotice
Mainframe98 merged task T260103: Anonnotice cannot be dismissed into T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing.
Aug 11 2020, 7:18 AM

Aug 10 2020

Mainframe98 merged T260033: Cannot close Sitenotice on Danish Wikipedia into T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing.
Aug 10 2020, 10:00 AM · Patch-For-Review, MediaWiki-HTML-Templating, Vector (Vector (Tracking)), Regression, DismissableSiteNotice
Mainframe98 merged task T260033: Cannot close Sitenotice on Danish Wikipedia into T259858: Sitenotice: Button for dismissing content isn't in the right place and does nothing.
Aug 10 2020, 10:00 AM

Aug 9 2020

Mainframe98 merged T260004: Notifications-Message-Indicator disappeared into T259872: Echo new message alert has no orange background in vector.
Aug 9 2020, 8:59 PM · MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), Vector, Growth-Team, Regression, Notifications
Mainframe98 merged task T260004: Notifications-Message-Indicator disappeared into T259872: Echo new message alert has no orange background in vector.
Aug 9 2020, 8:58 PM · Growth-Team, Notifications

Aug 6 2020

Mainframe98 added a comment to T258290: Allow Skins to register themselves as "responsive".

Per @Jdlrobson's comment on the patchset:

we don't often use '--' and use '-' if a skin is called responsive it will get the class 'skin-responsive' so this ensures it won't be targetted

Aug 6 2020, 5:53 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Patch-For-Review, patch-welcome, Vector (Vector (Tracking)), MinervaNeue (Tracking), Timeless, MediaWiki-Core-Skin-Architecture

Aug 5 2020

TheDJ awarded T258290: Allow Skins to register themselves as "responsive" a Stroopwafel token.
Aug 5 2020, 8:35 AM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Patch-For-Review, patch-welcome, Vector (Vector (Tracking)), MinervaNeue (Tracking), Timeless, MediaWiki-Core-Skin-Architecture
Mainframe98 claimed T259664: Provide a standard way to send messages to SkinMustache templates.
Aug 5 2020, 8:16 AM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), MediaWiki-Core-Skin-Architecture

Aug 4 2020

Mainframe98 committed rSMNBbce6d15d35c9: Specify the responsive option rather than manually specifying viewport (authored by Mainframe98).
Specify the responsive option rather than manually specifying viewport
Aug 4 2020, 9:15 PM
Mainframe98 awarded T259664: Provide a standard way to send messages to SkinMustache templates a Love token.
Aug 4 2020, 8:58 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), MediaWiki-Core-Skin-Architecture
Mainframe98 added a comment to T257102: Mediawiki 1.34.2 tarball incompatible with 7zip on windows due to Pax format.
FileResult
gnu_mediawiki-1.34.2.tar.gzExtracts properly
gnu_mediawiki-core-1.34.2.tar.gzExtracts properly
pax_mediawiki-1.34.2.tar.gzExtracts, but with @PaxHeader prompt - the extracted files sometimes have their filename truncated
pax_mediawiki-core-1.34.2.tar.gzExtracts, but with @PaxHeader prompt - the extracted files sometimes have their filename truncated
Aug 4 2020, 10:24 AM · Upstream, MediaWiki-Releasing

Aug 3 2020

Mainframe98 claimed T258290: Allow Skins to register themselves as "responsive".

@Mainframe98 @Isarra given Minerva is more stress tested (more users) I'd personally suggest using its value for the viewport attribute, unless you can suggest reasons why we would not want to use it.

initial-scale=1.0, user-scalable=yes, minimum-scale=0.25, maximum-scale=5.0, width=device-width

I can't recall the reasons for using minimum and maximum scale but am open to dropping those if we feel strongly about it.

Aug 3 2020, 6:30 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Patch-For-Review, patch-welcome, Vector (Vector (Tracking)), MinervaNeue (Tracking), Timeless, MediaWiki-Core-Skin-Architecture

Aug 1 2020

Mainframe98 updated the task description for T259108: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.36 release.
Aug 1 2020, 1:42 PM · MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), Patch-For-Review, MediaWiki-General, Technical-Debt (Deprecation process), MW-1.36-release
Mainframe98 added a comment to T257102: Mediawiki 1.34.2 tarball incompatible with 7zip on windows due to Pax format.

Is everyone using the latest 7-zip version? There's also a note that some older Windows versions won't work (see this comment) - what Windows versions are being used here?

Aug 1 2020, 10:34 AM · Upstream, MediaWiki-Releasing

Jul 31 2020

Mainframe98 added a comment to T258290: Allow Skins to register themselves as "responsive".

I know @Mainframe98 has been working on a skin (possibly using SkinMustache?) but I don't know if there's anything shareable there (yet)

Jul 31 2020, 7:36 AM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Patch-For-Review, patch-welcome, Vector (Vector (Tracking)), MinervaNeue (Tracking), Timeless, MediaWiki-Core-Skin-Architecture
Mainframe98 updated the task description for T259108: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.36 release.
Jul 31 2020, 7:34 AM · MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), Patch-For-Review, MediaWiki-General, Technical-Debt (Deprecation process), MW-1.36-release
Mainframe98 added a comment to T258002: Deprecate Skin::makeUrl and remove Skin::makeI18nUrl.

Skin::makeI18nUrl was deprecated (in 1.35) for T140664: Prepare MediaWiki for API-driven frontend. (rMW9c17d3a93d44: skins: Deprecate getDynamicStylesheetQuery, makeI18nUrl and makeNSUrl).

Jul 31 2020, 7:29 AM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), MediaWiki-Core-Skin-Architecture
Mainframe98 merged T258292: Update Example skin to use SkinMustache into T235008: ExampleSkin should use SkinMustache.
Jul 31 2020, 7:25 AM · Patch-For-Review, MediaWiki-Core-Skin-Architecture, User-Jdlrobson, Example (skin)
Mainframe98 merged task T258292: Update Example skin to use SkinMustache into T235008: ExampleSkin should use SkinMustache.
Jul 31 2020, 7:25 AM · Example (skin), MediaWiki-Core-Skin-Architecture

Jul 28 2020

Mainframe98 awarded T258986: Requesting +2 rights for Mediawiki Group for Ammarpad a Like token.
Jul 28 2020, 6:15 AM · MediaWiki-Gerrit-Group-Requests

Jul 27 2020

Mainframe98 added a comment to T258946: PHP Notice: Trying to access array offset on value of type null in /var/www/wiki/vendor/wikimedia/less.php/lib/Less/Parser.php on line 1927.

Given that MediaWiki 1.34.0 uses version 1.8.0, and 1.35.0 uses 3.0.0, this may already have been resolved.

Jul 27 2020, 1:58 PM · MediaWiki-General

Jul 25 2020

Mainframe98 added a comment to T252580: Document logo creation guidelines in MediaWiki.

See also T255913: Document tagline and icon options of $wgLogos by putting them in the installer, it would be nice if this information was available before the MW-1.35-release.

Jul 25 2020, 10:55 AM · Documentation, Readers-Web-Backlog, Desktop Improvements, Logos

Jul 23 2020

Mainframe98 updated subscribers of T258696: Class 'MediaWiki\Installer\Services\InstallerDBSupport' not found.

@Mainframe98 does that mean it's unlikely to happen again?

Jul 23 2020, 12:14 PM · Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error
Mainframe98 added a comment to T258696: Class 'MediaWiki\Installer\Services\InstallerDBSupport' not found.

Caused by rMW0b43c4946537: Revert "Add a new type of database to the installer from extension" (T258664: 25% latency regression July 2nd due to InstallerExtensionSelector service running in production).

Jul 23 2020, 11:53 AM · Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error

Jul 17 2020

Mainframe98 awarded T258290: Allow Skins to register themselves as "responsive" a Love token.
Jul 17 2020, 6:21 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Patch-For-Review, patch-welcome, Vector (Vector (Tracking)), MinervaNeue (Tracking), Timeless, MediaWiki-Core-Skin-Architecture
Mainframe98 added a comment to T258227: Sniff or phan rule against use `?:` and `if` on returns that may be a string.

mediawiki/tools/phan is the right place IMHO. We could create a dedicated folder for our plugins, especially if these plugins are short. I think this was already attempted in the past.

Jul 17 2020, 2:30 PM · Patch-For-Review, phan, MediaWiki-Codesniffer
Mainframe98 added a comment to T258227: Sniff or phan rule against use `?:` and `if` on returns that may be a string.

Basically, this would be a variant of the NonBoolBranchPlugin, but warning when encountering a string, rather than any non-boolean value, while also handling the ternary operator.

Jul 17 2020, 12:41 PM · Patch-For-Review, phan, MediaWiki-Codesniffer

Jul 16 2020

Mainframe98 added a project to T258159: Web Updater (mw-config/index.php) doesn't load Service Wiring files of extensions (their services are not accessible in LoadExtensionSchemaUpdates hook): MediaWiki-Installer.
Jul 16 2020, 12:39 PM · MediaWiki-Installer

Jul 11 2020

Mainframe98 added a project to T257720: Display of claims on Wikidata : Timeless.
Jul 11 2020, 7:25 AM · Timeless

Jul 10 2020

Mainframe98 merged T257660: Sidebar overlaps into footer when page content is shorter than the sidebar with skinversion 2 into T257518: [Bug] Max-Width Layout: Sidebar overlaps footer when its height is longer than the content height.
Jul 10 2020, 11:22 AM · MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Desktop Improvements
Mainframe98 merged task T257660: Sidebar overlaps into footer when page content is shorter than the sidebar with skinversion 2 into T257518: [Bug] Max-Width Layout: Sidebar overlaps footer when its height is longer than the content height.
Jul 10 2020, 11:22 AM · Desktop Improvements, Vector
Mainframe98 added a comment to T257660: Sidebar overlaps into footer when page content is shorter than the sidebar with skinversion 2.

Yep, I searched under Desktop Improvements but didn't spot it. Thanks!

Jul 10 2020, 11:22 AM · Desktop Improvements, Vector
Mainframe98 created T257660: Sidebar overlaps into footer when page content is shorter than the sidebar with skinversion 2.
Jul 10 2020, 9:55 AM · Desktop Improvements, Vector
Mainframe98 awarded T257630: SkinMustache::getTemplateData keys should be hyphenated and existing in a dictionary a Like token.
Jul 10 2020, 6:40 AM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), MW-1.35-release, MediaWiki-Interface, MediaWiki-Core-Skin-Architecture

Jul 5 2020

Mainframe98 added a comment to T257102: Mediawiki 1.34.2 tarball incompatible with 7zip on windows due to Pax format.

[...] Was 1.34.1 ok? Is 1.33.4 ok? I don't think any new files were actually added to 1.34.2 that weren't in previous releases...

Jul 5 2020, 11:57 AM · Upstream, MediaWiki-Releasing

Jul 4 2020

Mainframe98 added a comment to T257102: Mediawiki 1.34.2 tarball incompatible with 7zip on windows due to Pax format.

Can confirm. When unpacking the tar, I get prompted if I want to overwrite the @PaxHeader file, apparently for every file in the tarball.

Jul 4 2020, 11:18 AM · Upstream, MediaWiki-Releasing

Jul 3 2020

Mainframe98 added a project to T257020: Don't show "out of X total" message when Categories containing pages are less than 200 and hence shows complete results anyway, without paging: MediaWiki-Categories.
Jul 3 2020, 8:30 AM · MediaWiki-Categories

Jul 2 2020

Mainframe98 added a comment to T256963: gerrit plugin error: self.onAction is not a function.

A hard refresh is supposed to fix it, but didn't for me

Browsing to https://gerrit.wikimedia.org/r/plugins/delete-project/static/delete-project.js and hard refreshing it in my browser did; you'll clearly see the code change when you do

Jul 2 2020, 12:25 PM · Gerrit

Jun 30 2020

Mainframe98 added a project to T256782: Add "SandboxLink" to Turkish Wikipedia: Wikimedia-Site-requests.
Jun 30 2020, 5:28 PM · User-Majavah, Wikimedia-Site-requests, Turkish-Sites

Jun 29 2020

Mainframe98 merged T256631: Plugin install error: TypeError: self.onAction is not a function from https://gerrit.wikimedia.org/r/plugins/delete-project/static/delete-project.js into T256560: Plugin install error shown when loading a page (`Plugin install error: TypeError: self.onAction ... delete-project.js`).
Jun 29 2020, 1:16 PM · Gerrit
Mainframe98 merged task T256631: Plugin install error: TypeError: self.onAction is not a function from https://gerrit.wikimedia.org/r/plugins/delete-project/static/delete-project.js into T256560: Plugin install error shown when loading a page (`Plugin install error: TypeError: self.onAction ... delete-project.js`).
Jun 29 2020, 1:16 PM · Gerrit
Mainframe98 added a project to T256587: Change project name for Hindi Wikibooks: Wikimedia-Site-requests.
Jun 29 2020, 5:59 AM · Hindi-Sites, User-MarcoAurelio, Wikimedia-Site-requests

Jun 28 2020

Mainframe98 added a comment to T253842: Fix the printable versions of modern Vector.
Jun 28 2020, 3:42 PM · MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Vector, Desktop Improvements
Mainframe98 added a comment to T256568: Skins should not use $wgUseTwoButtonsSearchForm.

I'm not sure if I understand Nostalgia (this one will be simply removed completely). correctly; does that mean Nostalgia will no longer show two buttons? To preserve the look, I think Nostalgia should just display two buttons independent of MediaWiki.

Jun 28 2020, 1:44 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), DuskToDawn, Gamepress
Mainframe98 closed T256560: Plugin install error shown when loading a page (`Plugin install error: TypeError: self.onAction ... delete-project.js`) as Invalid.

Try clearing your browser cache, and see if it still occurs.

Jun 28 2020, 8:34 AM · Gerrit
Mainframe98 created T256560: Plugin install error shown when loading a page (`Plugin install error: TypeError: self.onAction ... delete-project.js`).
Jun 28 2020, 8:21 AM · Gerrit

Jun 27 2020

Mainframe98 merged T256544: User Creation Log bug into T256503: Regression: Redlinks not styled as such on mobile web.
Jun 27 2020, 6:09 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Regression, MinervaNeue, Mobile
Mainframe98 merged task T256544: User Creation Log bug into T256503: Regression: Redlinks not styled as such on mobile web.
Jun 27 2020, 6:09 PM