Page MenuHomePhabricator

Mainframe98 (Klaas Skelte van der Werf)
Administrator on MediaWiki.org and volunteer developer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 18 2016, 8:19 PM (279 w, 6 d)
Availability
Available
IRC Nick
Mainframe98
LDAP User
Mainframe98
MediaWiki User
Mainframe98 [ Global Accounts ]

I use MediaWiki in Dutch. If I ever claim to see something you don't, check if it occurs when setting the user language to Dutch, and remind me to switch too, so we don't get a repetition of T207288. And if I have the bright idea to test something on my local vagrant machine, and it doesn't work, I probably have a messed up vagrant instance and should be reminded to reset it, so we don't get a repetition of T207288.

Recent Activity

Yesterday

Mainframe98 added a comment to T291656: only show "Enable responsive mode" setting on relevant skins.

Maybe "Adapt layout to screen size"

Tue, Sep 28, 10:09 AM · Desktop Improvements, Readers-Web-Backlog

Sat, Sep 25

Mainframe98 added a project to T291740: Creation of namespace aliases at Ks Wikipedia: Wikimedia-Site-requests.
Sat, Sep 25, 1:57 PM · Wikimedia-Site-requests
Mainframe98 added a comment to T291731: Core tests failing - "PHP Deprecated" output instead of PHPUnit deprecation.

One of the difference that stands out:

- PHPUnit 8.5.20 by Sebastian Bergmann and contributors.
+ PHPUnit 8.5.21 by Sebastian Bergmann and contributors.

Changelog from https://github.com/sebastianbergmann/phpunit/blob/master/ChangeLog-8.5.md#8521---2021-09-25

Changed

  • PHPUnit no longer converts PHP deprecations to exceptions by default (configure convertDeprecationsToExceptions="true" to enable this)
  • The PHPUnit XML configuration file generator now configures convertDeprecationsToExceptions="true"

Fixed

#4772: TestDox HTML report not displayed correctly when browser has custom colour settings

That comes from https://github.com/sebastianbergmann/phpunit/commit/fac02620f6b38ae54d47fe840e0095e68226a56c

Sat, Sep 25, 11:40 AM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), MW-1.37-notes, MW-1.35-notes, MW-1.36-notes, Patch-For-Review, MediaWiki-Core-Tests, ci-test-error (WMF-deployed Build Failure), User-DannyS712

Fri, Sep 24

Mainframe98 merged T291705: Unstyled edit summaries on Special:DeletedContributions into T291441: Edit summaries at DeletedContributions are not italicised.
Fri, Sep 24, 5:00 PM · MediaWiki-Page-deletion
Mainframe98 merged task T291705: Unstyled edit summaries on Special:DeletedContributions into T291441: Edit summaries at DeletedContributions are not italicised.
Fri, Sep 24, 5:00 PM · Regression, MediaWiki-Special-pages

Wed, Sep 22

Mainframe98 added a comment to T253582: Let ResourceLoader only register skin modules for the current skin.

Note that this will break skins like Nimbus, which require styles from other skins (MonoBook in this particular case). Although in that particular case I don't see any difference.

Wed, Sep 22, 4:27 PM · Patch-For-Review, MediaWiki-ResourceLoader, Performance-Team

Mon, Sep 20

Mainframe98 added projects to T291351: rebuildFileCache.php and rebuildtextindex.php and deprecated warnings for Mediawiki 1.36.1: MediaWiki-Maintenance-system, MediaWiki-libs-ServiceContainer.
Mon, Sep 20, 5:55 AM · MediaWiki-libs-ServiceContainer, MediaWiki-Maintenance-system

Thu, Sep 16

Mainframe98 awarded T291193: Allow skins to mark themselves as internal a Like token.
Thu, Sep 16, 3:42 PM · Readers-Web-Backlog (Needs Prioritization (Tech)), Patch-For-Review, MediaWiki-Core-Skin-Architecture
Mainframe98 removed a project from T291147: The page are with the original text in English is in monospace font now. : Regression.

This is not a regression but a deliberate decision: T213658: Allow translators to distinguish between two single apostrophes '' (markup) vs. " quotation marks in strings to be translated.

Thu, Sep 16, 3:40 PM · MediaWiki-extensions-Translate
Mainframe98 awarded T213658: Allow translators to distinguish between two single apostrophes '' (markup) vs. " quotation marks in strings to be translated a Love token.
Thu, Sep 16, 3:40 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MediaWiki-extensions-Translate

Wed, Sep 15

Mainframe98 awarded T290932: Figure out remoteExtPath/remoteBasePath automatically for the common case a Love token.
Wed, Sep 15, 5:17 AM · Developer Productivity, MediaWiki-ResourceLoader, Performance-Team

Fri, Sep 10

Mainframe98 committed rSMIRaa00789791ba: Use templateDirectory skin option (authored by Mainframe98).
Use templateDirectory skin option
Fri, Sep 10, 6:44 PM
Mainframe98 committed rSMIR12d2e59e0a8b: Remove @noflip workarounds for displaying the right rail (authored by Mainframe98).
Remove @noflip workarounds for displaying the right rail
Fri, Sep 10, 6:38 PM
Mainframe98 added a comment to T290706: Parser code for special page transclusion replaces main context.

We've already seen this happen: T288113: Legacy Vector preferences not respected on pages that include special pages (eg. Special:PrefixIndex) (and T290539).

Fri, Sep 10, 6:04 AM · MediaWiki-General, Dependency injection

Fri, Sep 3

Mainframe98 closed T36541: File link-feature should not allow external links as Declined.

It's been almost a decade and the consensus seems to be WONTFIX (better known as Declined on Phabricator).

Fri, Sep 3, 4:50 PM · MediaWiki-Parser

Aug 23 2021

Mainframe98 awarded T289521: Support SQLite's upcoming strict mode a Love token.
Aug 23 2021, 6:34 PM · Performance-Team (Radar), Wikimedia-Rdbms, SQLite

Aug 20 2021

Mainframe98 awarded T289329: +2 in mediawiki/ for Majavah a Like token.
Aug 20 2021, 5:53 AM · MediaWiki-Gerrit-Group-Requests

Aug 19 2021

Mainframe98 committed rSMIR38a35ea75189: Update wikimedia-ui-base.less to v0.19.0 (authored by Mainframe98).
Update wikimedia-ui-base.less to v0.19.0
Aug 19 2021, 7:23 PM
Mainframe98 added a comment to T257704: Deprecate Skin::bottomScripts and SkinMustache::tailElement in favor of OutputPage::tailElement.

@Ammarpad, you've claimed this task for two weeks now. Do you have a patch ready?

Aug 19 2021, 7:02 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.37-release, MediaWiki-Interface, MediaWiki-Core-Skin-Architecture
Mainframe98 renamed T289229: spam from bestnewsfast to spam.
Aug 19 2021, 6:56 AM · Trash

Aug 18 2021

Mainframe98 added a comment to T277789: MediaWikiIntegrationTestCase::setMwGlobals doesn't affect the service locator for certain globals.

These services are set to hashes by MediaWikiIntegrationTestCase (via TestSetup).

Aug 18 2021, 5:58 PM · Performance-Team, MediaWiki-Core-Tests

Aug 15 2021

Mainframe98 added a comment to T280766: Phase out legacy error, warning and success classes for usage outside the parser.

I still can't manage to reproduce - do you have a link to an existing example? I used Vector (legacy) and changed my language to German without any effect.

Aug 15 2021, 3:12 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Regression, Patch-For-Review, MediaWiki-extensions-CentralAuth, User-notice, Technical-Debt
Mainframe98 added a comment to T280766: Phase out legacy error, warning and success classes for usage outside the parser.

Steps to reproduce

Extension

  • Create the following wikitext:
<ref name="DoesNotExist" />
<references />
  • Preview source editing (Vector).
  • Expected: Error message with text in red colour and enlarged size.
  • What you get: Regular black colour in inherited size vanishing among the entire document.
    • Error message is marked by class="error".
    • No decoration included when delivered by server.
Aug 15 2021, 2:37 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Regression, Patch-For-Review, MediaWiki-extensions-CentralAuth, User-notice, Technical-Debt
Mainframe98 moved T288907: Edit summary previews are no longer italic from Backlog to Edit summary on the MediaWiki-Page-editing board.
Aug 15 2021, 2:19 PM · MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Regression, MediaWiki-Core-Skin-Architecture, MediaWiki-Page-editing
Mainframe98 claimed T288907: Edit summary previews are no longer italic.

This regression is caused by rMWddbf011257fbe307d5ea3a583ccf5128fee3c2b0 (T278576), where the CSS style rule for span.comment was moved to interface.helpers.styles. These styles should also be loaded upon edit previewing. We failed to identify that usage, because the documentation for that style rule says Comment portions of RC entries.

Aug 15 2021, 2:01 PM · MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Regression, MediaWiki-Core-Skin-Architecture, MediaWiki-Page-editing

Aug 12 2021

Mainframe98 awarded T288707: Detect and monitor against multiple Parser invocation during edit requests a Love token.
Aug 12 2021, 2:22 AM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Performance-Team (Radar), Platform Engineering Code Jam, MediaWiki-Page-derived-data

Aug 6 2021

Mainframe98 created T288349: difference-missing-revision message inherits content language directionality and language despite being in the user's language.
Aug 6 2021, 1:33 PM · MediaWiki-Interface, MediaWiki-Page-diffs

Jul 31 2021

Mainframe98 awarded T287819: Add automatic temporary feature disabling to encourage migration away from long deprecated feature a Love token.
Jul 31 2021, 4:53 PM · Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-API, MediaWiki-General
Mainframe98 added a comment to T263213: Data shared between SkinMustache and SkinTemplate should be common.
In 709094, @Mainframe98 wrote:

My only concern about keeping SkinTemplate as in-between is that it causes a weird inheritance model.
There's two (three soon) ways to render a skin: SkinTemplate using QuickTemplate, SkinMustache using Mustache and soon SkinVue using Vue. By having the parent of SkinMustache also providing the QuickTemplate related templating logic, any child of it will also lug that legacy with it.
Having that said, it would be way to much work (and backwards-incompatible changes) to go through with that. If the end goal is to move most of that to QuickTemplate, then this is a fine intermediate step.

Jul 31 2021, 8:11 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-Core-Skin-Architecture

Jul 30 2021

Mainframe98 awarded T283396: Revisit core thumbnail styles for a more pleasant and predictable default a Like token.
Jul 30 2021, 3:38 PM · Design, MediaWiki-Core-Skin-Architecture
Mainframe98 awarded T283836: Give skin developers decent default table of contents styles a Like token.
Jul 30 2021, 3:17 PM · MediaWiki-Core-Skin-Architecture

Jul 26 2021

Mainframe98 awarded T281935: It should be safe to create exceptions without using the global state a Like token.
Jul 26 2021, 6:54 PM · User-DannyS712, Platform Team Workboards (MW Expedition)

Jul 8 2021

Mainframe98 added a project to T286345: WikiShare sets "follow us" link in sidebar even if disabled: MediaWiki-extensions-WikiShare.
Jul 8 2021, 2:56 PM · MediaWiki-extensions-WikiShare

Jul 5 2021

Mainframe98 merged T286177: Allow MediaWiki wikis to be installed as progressive web apps (PWAs) into T282500: [GOAL] Make desktop and mobile site installable on web browsers as progressive web app (PWA) (add to home screen, web app install prompt).
Jul 5 2021, 7:18 AM · MediaWiki-General, Performance-Team (Radar), Desktop Improvements, Readers-Web-Backlog, Product-Infrastructure-Team-Backlog, Goal
Mainframe98 merged task T286177: Allow MediaWiki wikis to be installed as progressive web apps (PWAs) into T282500: [GOAL] Make desktop and mobile site installable on web browsers as progressive web app (PWA) (add to home screen, web app install prompt).
Jul 5 2021, 7:18 AM

Jul 2 2021

Mainframe98 awarded T286079: Research to create service for Collation class a Like token.
Jul 2 2021, 8:22 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MediaWiki-General, Dependency injection
Mainframe98 committed rSMIRf79f14f3f341: Fix misplaced icons for personal tools (authored by Mainframe98).
Fix misplaced icons for personal tools
Jul 2 2021, 9:22 AM
Mainframe98 committed rSMIR0749f6bfaf30: Future proofing: Use only UserIdentity (authored by Mainframe98).
Future proofing: Use only UserIdentity
Jul 2 2021, 9:07 AM

Jul 1 2021

Mainframe98 awarded T285949: Redirect https://lists.wikimedia.org/pipermail/foobar/ to https://lists.wikimedia.org/hyperkitty/list/foobar@lists.wikimedia.org/ a Like token.
Jul 1 2021, 1:52 PM · SRE, Wikimedia-Mailing-lists

Jun 30 2021

Mainframe98 awarded T272079: PermissionManager:: 'edit' right check should also check for 'create' if the page does not exist a Like token.
Jun 30 2021, 3:52 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Patch-For-Review, Platform Team Workboards (MW Expedition)

Jun 26 2021

Mainframe98 awarded T285592: Add generally applicable `z-index` stack to MediaWiki skin variables and WikimediaUI Base a Love token.
Jun 26 2021, 10:20 AM · WikimediaUI-Base, UI-Standardization, MediaWiki-Core-Skin-Architecture

Jun 24 2021

Mainframe98 added a project to T285491: Use of BaseTemplate::getFooterIcons was deprecated ... in /var/www/html/w/skins/Vector: Vector.
Jun 24 2021, 5:51 PM · Vector
Mainframe98 committed rSMIRe816f43f9f8e: Set responsive to true in skin.json (authored by Mainframe98).
Set responsive to true in skin.json
Jun 24 2021, 5:26 PM
Mainframe98 committed rSMIRf6c259515db3: Set config for ResourceLoaderModule tests (authored by Mainframe98).
Set config for ResourceLoaderModule tests
Jun 24 2021, 5:25 PM
Mainframe98 committed rSMIRc80dc6dc1901: Set responsive to true in skin.json (authored by Mainframe98).
Set responsive to true in skin.json
Jun 24 2021, 4:15 PM
Mainframe98 added a comment to T285402: "Enable responsive MonoBook design" should be a (renamed) core skin preference.

I'm assuming if a skin is responsive, then by definition it works fine in a desktop browser? If so, a user opted into this preference the expectation would be similar to clicking "request desktop site" on a mobile browser. I envision this setting to remove the viewport to allow for zooming on a phone, nothing else. It looks to me like Mirage works fine in this mode, unless I'm missing something?

Jun 24 2021, 3:48 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Patch-For-Review, patch-welcome, MonoBook, MediaWiki-Core-Skin-Architecture
Mainframe98 awarded T285448: Remove ApiTestCase interaction with $wgUser a Like token.
Jun 24 2021, 7:55 AM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), MediaWiki-Core-Tests, Technical-Debt (Deprecation process), User-DannyS712, MediaWiki-General
Mainframe98 added a comment to T285402: "Enable responsive MonoBook design" should be a (renamed) core skin preference.

Skins can of course opt-out by changing the behaviour e.g. not calling parent::isResponsive but I think that would be discouraged as the user preference would save skin developers having to think about this (at minimum it would just drop the viewport tag meaning the skin functions perfectly well)

Jun 24 2021, 7:36 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Patch-For-Review, patch-welcome, MonoBook, MediaWiki-Core-Skin-Architecture

Jun 23 2021

Mainframe98 added a comment to T285402: "Enable responsive MonoBook design" should be a (renamed) core skin preference.

So keep existing behaviour, but make this a MediaWiki core feature? Is there a way for skins to opt out?

Jun 23 2021, 5:06 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Patch-For-Review, patch-welcome, MonoBook, MediaWiki-Core-Skin-Architecture

Jun 21 2021

Mainframe98 closed T44499: Enhanced recent changes doesn't hide subitems until the page finishes loading as Resolved.

This doesn't seem to be the case anymore. Sub-items are shown collapsed. The arrow takes a moment to load, but that's all.

Jun 21 2021, 5:56 PM · MediaWiki-Recent-changes
Mainframe98 added a project to T285221: Add patroller user group to Central Kurdish Wikipedia: Wikimedia-Site-requests.
Jun 21 2021, 12:46 PM · User-Zabe, Wikimedia-Site-requests
Mainframe98 added a project to T285204: Can't remove lines with syntax highlight on Android: Wikipedia-Android-App-Backlog.
Jun 21 2021, 9:10 AM · Community-Tech, WMDE-TechWish-Sprint-2021-06-23, WMDE-TechWish, MediaWiki-extensions-CodeMirror, Browser-Support-Android-Google-Chrome, SyntaxHighlight

Jun 18 2021

Mainframe98 added a comment to T220719: Standardize return type hint spacing.
  1. To do this we still need to ask if people want a decision. Mixing tabs and spaces for example creates actual problems. But this here? What happens when we let people decide if they want the space in their code or not?
Jun 18 2021, 1:46 PM · Patch-For-Review, MediaWiki-Documentation, MediaWiki-Codesniffer

Jun 16 2021

Mainframe98 updated the task description for T256509: Remove BaseTemplateToolbox hook.
Jun 16 2021, 10:02 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Readers-Web-Backlog (Kanbanana-FY-2020-21), MW-1.37-release, MediaWiki-Core-Skin-Architecture

Jun 14 2021

Mainframe98 added a comment to T275268: Address "image" table capacity problems by storing pdf/djvu text outside file metadata.

It appears this (rMWb4849e03b700813aca63cdc4d7b92a40cfa26f3f) breaks viewing files from foreign repos (See https://meta.wikimedia.beta.wmflabs.org/wiki/File:Wiki-wordmark.png, which is from Commons).

Jun 14 2021, 5:43 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), User-Ladsgroup, Performance-Team-publish, Performance-Team (Radar), MediaWiki-File-management, Patch-For-Review, DBA, Commons
Mainframe98 added a comment to T284936: Highlighted menu item is garish.

Chrome 91 (Windows) shows

image.png (218×214 px, 10 KB)

seemingly suggesting this is a FF issue.

Jun 14 2021, 3:47 PM · Browser-Support-Firefox, Phabricator

Jun 13 2021

Mainframe98 added a project to T284868: Rename Portal and Portal talk namespaces on viwiki: Wikimedia-Site-requests.
Jun 13 2021, 6:11 AM · User-Zabe, Wikimedia-Site-requests

Jun 12 2021

Mainframe98 added a project to T284864: Install wikilove in hewikisource: Wikimedia-Extension-setup.
Jun 12 2021, 6:35 PM · User-Zabe, Wikimedia-Extension-setup, Wikimedia-Site-requests

Jun 11 2021

Mainframe98 added a project to T284813: Enable dpl on https://wikitech.wikimedia.org/: Wikimedia-Extension-setup.
Jun 11 2021, 11:23 AM · Wikimedia-Site-requests, Wikimedia-Extension-setup, wikitech.wikimedia.org

Jun 8 2021

Mainframe98 edited projects for T284589: Remove "reviewer" user group from ruwiki (Flagged Revs), added: Wikimedia-Site-requests; removed MediaWiki-Shell.
Jun 8 2021, 6:27 PM · User-Ladsgroup, Wikimedia-Site-requests, MediaWiki-extensions-FlaggedRevs
Mainframe98 closed T12206: Print version displays URL-encoded link as Declined.

Viewing the printable version (which is deprecated: T167956), the "Retrieved from" message doesn't appear to be URL-encoded anymore.

Jun 8 2021, 5:08 PM · MediaWiki-Interface

Jun 7 2021

Mainframe98 awarded T284487: Document automatic MW branching time in Deployment Calendar a Like token.
Jun 7 2021, 5:53 PM · Release-Engineering-Team (Doing)

Jun 6 2021

Mainframe98 edited projects for T284408: Deploy Extension:PlantUML on Meta, added: Wikimedia-Extension-setup; removed Deployments.
Jun 6 2021, 8:35 PM · Wikimedia-Extension-setup

Jun 4 2021

Mainframe98 added a project to T284333: Apple Pay best practices for human interfacing: Wikimedia-Fundraising.
Jun 4 2021, 6:35 PM · FR-Adyen, Fundraising-Backlog, Wikimedia-Fundraising

Jun 2 2021

Mainframe98 added a project to T284124: Old mailing list info page URLs are 404s when listname is written with capital letter: Wikimedia-Mailing-lists.
Jun 2 2021, 6:57 AM · User-Ladsgroup, SRE, Wikimedia-Mailing-lists

Jun 1 2021

Mainframe98 awarded T268225: Switch Gerrit from Java 8 to Java 11 a Party Time token.
Jun 1 2021, 1:31 PM · Release-Engineering-Team (Doing), Gerrit (Gerrit 3.3)

May 30 2021

Mainframe98 awarded T283980: Phacility (Maintainer of Phabricator) is winding down. Upstream support ending. a Heartbreak token.
May 30 2021, 7:05 AM · Release-Engineering-Team (Seen), User-Matthewrbowker, Phabricator

May 27 2021

Mainframe98 awarded T283766: Refactor SpecialPage execution checks to use Authority a Love token.
May 27 2021, 6:44 AM · Patch-For-Review, MediaWiki-Special-pages, Platform Team Workboards (MW Expedition)
Mainframe98 merged T283794: New upstream release for composer/semver into T283560: New upstream release for composer/semver.
May 27 2021, 6:43 AM · Parsoid, MediaWiki-Vendor, MediaWiki-General, MediaWiki-Codesniffer
Mainframe98 merged task T283794: New upstream release for composer/semver into T283560: New upstream release for composer/semver.
May 27 2021, 6:43 AM · Parsoid, MediaWiki-Vendor, MediaWiki-General, MediaWiki-Codesniffer

May 25 2021

Mainframe98 added a comment to T282728: There is no icon for the action move in the edit button drop down.

From T231291#7021522: The existing move icon is used for now. A follow-up task for a new icon has not yet been created.

May 25 2021, 6:54 AM · MediaWiki-skins-Mirage

May 22 2021

Mainframe98 added projects to T283427: VisualEditor / Wikitext Editor contents get misaligned: VisualEditor, MediaWiki-extensions-FlaggedRevs.
May 22 2021, 6:11 PM · Vector, Readers-Web-Backlog, Regression, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
Mainframe98 added a comment to T90875: Convert tests/phpunit/phpunit.php entrypoint to plain PHPUnit with bootstrap file.

That is because of MWMultiVersion. Vagrant's CommonSettings sets $wgDBname to what was determined by MWMultiVersion, which for PHPUnit tests sets this to either --wiki, or the first argument given to the script ($argv). It should be updated to use the environment variable.

May 22 2021, 5:12 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Performance-Team (Radar), Patch-For-Review, User-kostajh, Code-Health-Metrics, Technical-Debt, MediaWiki-Core-Tests
Mainframe98 added a comment to T90875: Convert tests/phpunit/phpunit.php entrypoint to plain PHPUnit with bootstrap file.

@Mainframe98 which test(s) are you trying to run? vendor/bin/phpunit tests/phpunit/{path-to-test-file-or-directory} should work, and it uses the phpunit.xml.dist in the root of the repository by default, not the suite.xml file that was used with the tests/phpunit/phpunit.php wrapper script.

May 22 2021, 10:05 AM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Performance-Team (Radar), Patch-For-Review, User-kostajh, Code-Health-Metrics, Technical-Debt, MediaWiki-Core-Tests

May 21 2021

Mainframe98 added a comment to T90875: Convert tests/phpunit/phpunit.php entrypoint to plain PHPUnit with bootstrap file.

The point of this task is to remove tests/phpunit/phpunit.php entirely. Can you try with vendor/bin/phpunit?

May 21 2021, 7:08 AM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Performance-Team (Radar), Patch-For-Review, User-kostajh, Code-Health-Metrics, Technical-Debt, MediaWiki-Core-Tests

May 20 2021

Mainframe98 added a comment to T90875: Convert tests/phpunit/phpunit.php entrypoint to plain PHPUnit with bootstrap file.

That doesn't actually work. The issue here is that vagrant requires --wiki for MWMultiVersion. It will not work without it. If you pass it at the moment, the tests do not run and instead show unrecognized option --wiki.

Having phpunit.php remove --wiki or --wiki= from $argv is a workaround, or MWMultiVersion can be changed to accept an environment variable instead perhaps.

AIUI, this is issue happens because tests are being run as a mwscript.

May 20 2021, 12:08 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Performance-Team (Radar), Patch-For-Review, User-kostajh, Code-Health-Metrics, Technical-Debt, MediaWiki-Core-Tests
Mainframe98 added a comment to T90875: Convert tests/phpunit/phpunit.php entrypoint to plain PHPUnit with bootstrap file.

As requested in the email on wikitech-l:

  • CirrusSearch integration tests rely on --wiki=wiki in vagrant.

Right, this thing in vagrant was pointed out earlier. This can be remediated by using an environment variable instead, PHPUNIT_WIKI=wiki.

May 20 2021, 8:58 AM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Performance-Team (Radar), Patch-For-Review, User-kostajh, Code-Health-Metrics, Technical-Debt, MediaWiki-Core-Tests

May 18 2021

Mainframe98 awarded T283097: Run phan CI job unconditionally for all extensions a Love token.
May 18 2021, 6:00 PM · phan, Continuous-Integration-Config
Mainframe98 committed rSMIRc63938e6e9d1: Add a warning to File:Mirage-wordmark.png when used as wordmark (authored by Mainframe98).
Add a warning to File:Mirage-wordmark.png when used as wordmark
May 18 2021, 11:19 AM

May 17 2021

Mainframe98 updated subscribers of T283011: Indicator tag adds white space..
May 17 2021, 1:34 PM · MediaWiki-General

May 16 2021

Mainframe98 committed rSMIRad415f72c79a: Add missing newWindow icon to skin.mirage.icons (authored by Mainframe98).
Add missing newWindow icon to skin.mirage.icons
May 16 2021, 6:23 PM
Mainframe98 committed rSMIR921df10004e2: Use the Wikimedia Commons logo for InstantCommons (authored by Mainframe98).
Use the Wikimedia Commons logo for InstantCommons
May 16 2021, 6:11 PM
Mainframe98 committed rSMIR03cf174c9357: Actually rename unTrash to restore in skin.mirage.icons (authored by Mainframe98).
Actually rename unTrash to restore in skin.mirage.icons
May 16 2021, 10:11 AM
Mainframe98 committed rSMIR7249cb57cb62: Actually rename unTrash to restore in skin.mirage.icons (authored by Mainframe98).
Actually rename unTrash to restore in skin.mirage.icons
May 16 2021, 10:06 AM

May 15 2021

Mainframe98 closed T282901: MassMessage unit tests failure after new JobQueueGroupFactory service as Resolved.
May 15 2021, 9:14 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), ci-test-error (WMF-deployed Build Failure), MassMessage
Mainframe98 claimed T282901: MassMessage unit tests failure after new JobQueueGroupFactory service.
May 15 2021, 10:29 AM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), ci-test-error (WMF-deployed Build Failure), MassMessage
Mainframe98 added a comment to T282901: MassMessage unit tests failure after new JobQueueGroupFactory service.

This is because MassMessageJobTest::testPageMessageSendingFailToEdit sets $wgReadOnly with setMwGlobals, which now affects the JobQueueGroup because it uses the ReadOnlyMode service, which is reset with the setMwGlobals call.

May 15 2021, 9:37 AM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), ci-test-error (WMF-deployed Build Failure), MassMessage

May 14 2021

Mainframe98 renamed T282902: Remove use of deprecated hook EditPageBeforeEditToolbar from Remove/Replace use of deprecated hook EditPageBeforeEditToolbar to Remove use of deprecated hook EditPageBeforeEditToolbar.
May 14 2021, 9:44 PM · Technical-Debt, MediaWiki-extensions-LiquidThreads, MediaWiki-extensions-JsonData, ci-test-error
Mainframe98 added a comment to T282902: Remove use of deprecated hook EditPageBeforeEditToolbar.

In T278563: Deprecate the EditPageBeforeEditToolbar hook, I identified that these usages were solely to disable the old edit toolbar. (Except liquidthreads, which just invokes the hook). The handlers can be safely removed.

May 14 2021, 9:44 PM · Technical-Debt, MediaWiki-extensions-LiquidThreads, MediaWiki-extensions-JsonData, ci-test-error
Mainframe98 committed rSMIR9c5f5caf7ac4: Don't use mw-body-content for site notice and bodyContent (authored by Mainframe98).
Don't use mw-body-content for site notice and bodyContent
May 14 2021, 9:31 AM

May 13 2021

Mainframe98 committed rEDOD4d83da4d4f91: Use the JobQueueGroup service (authored by Mainframe98).
Use the JobQueueGroup service
May 13 2021, 10:15 AM

May 12 2021

Mainframe98 created T282728: There is no icon for the action move in the edit button drop down.
May 12 2021, 6:52 PM · MediaWiki-skins-Mirage
Mainframe98 committed rSMIRd584bfdfe8f5: unTrash was deprecated and renamed to restore (authored by Mainframe98).
unTrash was deprecated and renamed to restore
May 12 2021, 4:17 PM
Mainframe98 committed rSMIR331d3e336118: unTrash was deprecated and renamed to restore (authored by Mainframe98).
unTrash was deprecated and renamed to restore
May 12 2021, 4:05 PM
Mainframe98 committed rEGRV94fd84cf74d6: build: Updating npm dependencies (authored by LibUp-bot).
build: Updating npm dependencies
May 12 2021, 12:31 PM
Mainframe98 committed rEGRV9355d3d99fbd: Don't use namespaced CSSMin (authored by Mainframe98).
Don't use namespaced CSSMin
May 12 2021, 12:15 PM

May 11 2021

Mainframe98 added a project to T282541: commonswiki_p database does not exist (due to using wrong host): GLAM-Tech.
May 11 2021, 12:23 PM · GLAM-Tech
Mainframe98 closed T277648: JobQueueGroup::singleton() is difficult to use with dependency injection as Resolved.
May 11 2021, 8:54 AM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Patch-For-Review, Platform Team Workboards (External Code Reviews), Dependency injection, MediaWiki-General
Mainframe98 committed rEDOD5fb0d0276018: Use authority for permission checking (authored by Mainframe98).
Use authority for permission checking
May 11 2021, 8:44 AM
Mainframe98 committed rEDODf25d3f6564a2: Use authority for permission checking (authored by Mainframe98).
Use authority for permission checking
May 11 2021, 8:18 AM