Page MenuHomePhabricator

Mainframe98 (Klaas Skelte van der Werf)
Administrator on MediaWiki.org and volunteer developer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 18 2016, 8:19 PM (185 w, 1 d)
Availability
Available
IRC Nick
Mainframe98
LDAP User
Mainframe98
MediaWiki User
Mainframe98 [ Global Accounts ]

I use MediaWiki in Dutch. If I ever claim to see something you don't, check if it occurs when setting the user language to Dutch, and remind me to switch too, so we don't get a repetition of T207288. And if I have the bright idea to test something on my local vagrant machine, and it doesn't work, I probably have a messed up vagrant instance and should be reminded to reset it, so we don't get a repetition of T207288.

Recent Activity

Wed, Dec 4

Mainframe98 added a comment to T239807: Clean up old images on wikitech-static.

After a brief discussion on irc, there are a couple of suggestions for updating the content of Special:UnusedFiles (which could then be used via the api, we hope)

Wed, Dec 4, 8:35 PM · wikitech.wikimedia.org
Mainframe98 claimed T237873: Deprecate and remove extension database updating globals.
Wed, Dec 4, 7:53 PM · Patch-For-Review, MediaWiki-General, Technical-Debt
Mainframe98 created T239855: Inject services used by LinkBatch.
Wed, Dec 4, 7:35 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Cache
Mainframe98 added a comment to T238956: switch prod Phabricator from phab1003 to phab1001.

I suspect that this move inadvertently caused T239786: Viewing MediaWiki repository in diffusion results in an Unhandled Exception ("CommandException") as I only started seeing it today.

Wed, Dec 4, 4:21 PM · serviceops, Release-Engineering-Team
Mainframe98 created T239786: Viewing MediaWiki repository in diffusion results in an Unhandled Exception ("CommandException").
Wed, Dec 4, 8:47 AM · Diffusion, Phabricator

Thu, Nov 21

Mainframe98 created T238815: Jenkins/Zuul does not respond on I93d931ab60305ad49a6e419f8269c77791a3938d or I6c00cb8f32be7fb7f02deeac374378352b51a4ed.
Thu, Nov 21, 9:03 AM · Continuous-Integration-Config

Sun, Nov 17

Mainframe98 added a project to T238501: Can't undo latest edit and summary that include captions: Wikimedia-production-error.
Sun, Nov 17, 5:57 PM · Wikimedia-production-error, Commons

Fri, Nov 15

Mainframe98 added a comment to T222472: Investigate gerrit session expiration.

Today again; I had remained logged in since my last comment (10 days ago - T222472#5634681).

Fri, Nov 15, 8:53 AM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Gerrit

Mon, Nov 11

Mainframe98 added a project to T238026: Attempt to see a diff between deleted revisions of a file triggers InvalidArgumentException: Wikimedia-production-error.
Mon, Nov 11, 9:10 PM · Wikimedia-production-error
Mainframe98 added a project to T237929: Compatibility with $wgReadOnly: MediaWiki-extensions-Pluggable-Auth.
Mon, Nov 11, 10:13 AM · MediaWiki-extensions-Pluggable-Auth
Mainframe98 updated the task description for T237873: Deprecate and remove extension database updating globals.
Mon, Nov 11, 9:35 AM · Patch-For-Review, MediaWiki-General, Technical-Debt

Sun, Nov 10

Mainframe98 created T237873: Deprecate and remove extension database updating globals.
Sun, Nov 10, 6:16 PM · Patch-For-Review, MediaWiki-General, Technical-Debt
Mainframe98 merged T237842: Decide and document code style for return types for functions into T220719: Standardize return type hint spacing.
Sun, Nov 10, 7:23 AM · MediaWiki-Documentation, MediaWiki-Codesniffer
Mainframe98 merged task T237842: Decide and document code style for return types for functions into T220719: Standardize return type hint spacing.
Sun, Nov 10, 7:23 AM · Documentation, MediaWiki-General

Sat, Nov 9

Mainframe98 merged T237793: Scroll position lost when exiting Media Viewer into T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70.
Sat, Nov 9, 2:07 PM · Patch-For-Review, Structured-Data-Backlog, Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer
Mainframe98 merged task T237793: Scroll position lost when exiting Media Viewer into T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70.
Sat, Nov 9, 2:07 PM · MediaViewer
Mainframe98 added a project to T237792: Editing "$wgNamespacesToBeSearchedDefault" at EO wiktionary: Community-consensus-needed.
Sat, Nov 9, 9:26 AM · User-MarcoAurelio, Wikimedia-Site-requests

Fri, Nov 8

Mainframe98 closed T237694: Alphasort use statements as Resolved.
Fri, Nov 8, 1:26 PM · MediaWiki-Codesniffer
Mainframe98 claimed T237694: Alphasort use statements.
Fri, Nov 8, 12:21 PM · MediaWiki-Codesniffer

Nov 6 2019

Mainframe98 added a comment to T237500: Regression: [1.35.0-wmf.5] Classic RC lacks space between "(User creation log)"/"(Move log)"/"(Page translation log)" string and date.

I believe this is caused by rMW30c98e2351b4: Semicolon separator for article title and timestamp is a pseudo element, which in turn is for T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.

Nov 6 2019, 12:39 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Regression, MediaWiki-Recent-changes

Nov 5 2019

Mainframe98 added a comment to T222472: Investigate gerrit session expiration.

In the hope it's useful, I'll mention I'm still logged in to Gerrit, since my previous log in on October 24.

Nov 5 2019, 9:07 AM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Gerrit

Nov 4 2019

Mainframe98 added a project to T237325: IP limit exception for 2019-11-06: Wikimedia-Site-requests.
Nov 4 2019, 9:25 PM · Wikimedia-Site-requests

Oct 26 2019

Mainframe98 merged T236597: Ignoring users is not working into T236460: Regression: Changes to email blacklist or muted users do not activate Save button in Preferences.
Oct 26 2019, 4:29 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, Notifications, MediaWiki-User-preferences, Growth-Team
Mainframe98 merged task T236597: Ignoring users is not working into T236460: Regression: Changes to email blacklist or muted users do not activate Save button in Preferences.
Oct 26 2019, 4:29 PM · MediaWiki-User-preferences, MediaWiki-User-management

Oct 24 2019

Mainframe98 added a comment to T222472: Investigate gerrit session expiration.

Did you all click the remember me box?

Of course, what type of question is this?

Oct 24 2019, 10:22 AM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Gerrit
Mainframe98 added a comment to T222472: Investigate gerrit session expiration.

And today again.

Oct 24 2019, 7:51 AM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Gerrit

Oct 23 2019

Mainframe98 added a comment to T222472: Investigate gerrit session expiration.

I've been keeping a log for when I need to log in to Gerrit:

  • oct 16: logged in
  • oct 17: still logged in
  • oct 18: still logged in
  • oct 21: still logged in
  • oct 22: had to log in
  • oct 23: had to log in

HTH.

Oct 23 2019, 4:53 PM · Patch-For-Review, Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Gerrit

Oct 15 2019

Mainframe98 committed rEOTP1c6c81614f88: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Mainframe98).
build: Upgrade mediawiki-codesniffer to v28.0.0
Oct 15 2019, 3:12 PM

Oct 9 2019

Mainframe98 added a comment to T235115: Split special page alias resolution from SpecialPageFactory into a separate service.

Unfortunately, any alias resolver needs to know the list of special pages to know which special page belongs to which alias, which brings us back to the original issue, where extensions will (accidentally) need to specify special pages, but cannot do that without access to services that use the alias resolver.

Oct 9 2019, 5:31 PM · MediaWiki-Special-pages, Technical-Debt
Mainframe98 created T235115: Split special page alias resolution from SpecialPageFactory into a separate service.
Oct 9 2019, 5:08 PM · MediaWiki-Special-pages, Technical-Debt
Mainframe98 awarded Blog Post: Integrating code coverage metrics with your development workflow a Love token.
Oct 9 2019, 10:34 AM · Code-Health, MediaWiki-Core-Testing, Test-Coverage

Oct 6 2019

Mainframe98 added a comment to T196206: Bump symfony libraries when we no longer need hhvm support.

https://github.com/symfony/symfony/blob/4.0/composer.json and https://github.com/symfony/symfony/blob/4.4/composer.json have ^7.1.3
https://github.com/symfony/symfony/blob/master/composer.json (to be 5.0 I guess) has ^7.2.9
https://github.com/symfony/symfony/commit/d94d9d792c445240cbaf80c7b413795b71aff718 - I wonder if there's any specific reason to select 7.2.9 as the min supported PHP 7.2, that dates to 16 Aug 2018, well before that commit in May
Something for us to bare in mind when we come to bumping to PHP 7.2
On https://github.com/symfony/symfony/blob/3.4/composer.json#L19 we're good with ^5.5.9|>=7.0.8
But of course, we only require PHP 7.0.0. I suspect most people will have a newer point release... But it does mean our require-dev symfony/yaml will conflict
Filing a separate task
Re-stalling as we have nothing to do until we bump to 7.2 (do we have a task for that to bump this against)

Oct 6 2019, 8:15 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, MediaWiki-General
Mainframe98 updated subscribers of T192167: Upgrade PHPUnit from 4/6 to 8.

I've done some early investigation about PHPUnit 8. Needless to say, transitioning won't be easy. I've found two main problems:

  • PHPUnit 7/8 added gazillions of typehints. Many of them are in lower-level methods which we only override in base core classes, so replacing them is pretty easy. The main problem is that typehints were also added to setUp and tearDown, which are overriden in many, many test classes. I think that the easier solution is to automatically add the : void return type hint in *all* test classes in extensions and core *now*. This is accepted in PHP7.0+, even if the parent is not typehinted.
Oct 6 2019, 2:39 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing

Oct 5 2019

Mainframe98 added a comment to T234723: PHP fatal error: syntax error, unexpected T_CONST, expecting T_VARIABLE.

It's definitely culprit, but... WTF? That error can only happen on HHVM, and we're not running on HHVM anymore, right???

Oct 5 2019, 4:53 PM · Beta-Cluster-Infrastructure
Mainframe98 renamed T231742: $wgDebugToolbar not showing SQL queries from $wgDebugConsole not showing SQL queries to $wgDebugToolbar not showing SQL queries.
Oct 5 2019, 7:45 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MW-1.34-notes, MW-1.34-release, Wikimedia-Rdbms, Performance-Team, MediaWiki-Debug-Logger

Oct 3 2019

Mainframe98 added a comment to T232506: Inject services into special pages.

Right now, this is blocked on a circular dependency issue caused by a combination of MediaWiki-extensions-GlobalPreferences and MobileFrontend. I'm not able to reproduce it locally however.

Oct 3 2019, 10:35 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Special-pages, Technical-Debt

Sep 30 2019

Mainframe98 created T234240: It should be possible to install php-ast using apt-get on MediaWiki-Vagrant.
Sep 30 2019, 4:24 PM · Operations, MediaWiki-Vagrant, phan
Mainframe98 moved T234224: Gerrit workflow: "Merge review" AND "Open push" for BlueSpice? from Bugs & stuff to Discussions & doc stuff on the Gerrit board.
Sep 30 2019, 3:58 PM · Gerrit
Mainframe98 added a project to T234224: Gerrit workflow: "Merge review" AND "Open push" for BlueSpice?: Gerrit.
Sep 30 2019, 3:58 PM · Gerrit
Mainframe98 added a parent task for T192166: Drop HHVM support from MediaWiki: T234236: Drop HHVM support from MediaWiki-Vagrant.
Sep 30 2019, 3:55 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes, TechCom, Core Platform Team Legacy (Watching / External), Patch-For-Review, HHVM
Mainframe98 added a subtask for T234236: Drop HHVM support from MediaWiki-Vagrant: T192166: Drop HHVM support from MediaWiki.
Sep 30 2019, 3:55 PM · MediaWiki-Vagrant, HHVM
Mainframe98 created T234236: Drop HHVM support from MediaWiki-Vagrant.
Sep 30 2019, 3:54 PM · MediaWiki-Vagrant, HHVM

Sep 22 2019

Mainframe98 added a comment to T233512: Tag functions that always return a specific value (regardless of class, execution, etc) with @codeCoverageIgnore.

Note that ApiStructureTest does test the mentioned methods (and more: T184216#3878417).

Sep 22 2019, 5:03 PM · MediaWiki-Core-Testing, User-DannyS712, Test-Coverage, Proposal

Sep 19 2019

Mainframe98 added a comment to T233308: Special:MovePage WMFTimeoutException from line 39 of /srv/mediawiki/wmf-config/set-time-limit.php: the execution time limit of 60 seconds was exceeded.

Looks like a recursive call to MovePage:

Sep 19 2019, 3:07 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Wikimedia-production-error, MediaWiki-extensions-Translate
Mainframe98 renamed T233278: wikimedia/php-session-serializer 1.0.4 is not tagged, despite being required by MediaWiki 1.30 from wikimedia/php-session/serializer to wikimedia/php-session/serializer 1.0.4 is not tagged, despite being required by MediaWiki 1.30.
Sep 19 2019, 7:31 AM · MediaWiki-General, php-session-serializer

Sep 18 2019

Mainframe98 added a comment to F30388506: ERROR_chrome_2019-09-18T09-12-05.721Z.png.

For https://gerrit.wikimedia.org/r/c/mediawiki/core/+/535657, from https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/5876/console

Sep 18 2019, 9:16 AM

Sep 17 2019

Mainframe98 edited projects for T233137: Update $wgGroupPermissions for bnwiki, added: Wikimedia-Site-requests; removed MediaWiki-User-management.
Sep 17 2019, 6:49 PM · Bengali-Sites, User-Zoranzoki21, Wikimedia-Site-requests

Sep 16 2019

Mainframe98 committed rERLSbe5984abadf2: Inject ObjectFactory into ApiModuleManager (authored by Mainframe98).
Inject ObjectFactory into ApiModuleManager
Sep 16 2019, 9:39 PM

Sep 15 2019

Mainframe98 merged T190417: CheckboxMultiSelectInputWidget doesn't disable when infusing a disabled HTMLMultiSelectField into T230066: TagMultiselectWidget: the input field is editable even if the widget is disabled.
Sep 15 2019, 12:00 PM · OOUI, AbuseFilter, User-DannyS712
Mainframe98 merged task T190417: CheckboxMultiSelectInputWidget doesn't disable when infusing a disabled HTMLMultiSelectField into T230066: TagMultiselectWidget: the input field is editable even if the widget is disabled.
Sep 15 2019, 12:00 PM · OOUI

Sep 10 2019

Mainframe98 added a comment to T232506: Inject services into special pages.

For the listed patch, this code search shows which extensions will break due to the patch above.

Sep 10 2019, 5:54 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Special-pages, Technical-Debt
Mainframe98 updated the task description for T232506: Inject services into special pages.
Sep 10 2019, 5:27 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Special-pages, Technical-Debt
Mainframe98 created T232506: Inject services into special pages.
Sep 10 2019, 5:11 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Special-pages, Technical-Debt
Mainframe98 committed rEOTP918685b0b428: Remove unnecessary PHPCS exclusions (authored by Mainframe98).
Remove unnecessary PHPCS exclusions
Sep 10 2019, 10:35 AM

Sep 6 2019

Mainframe98 updated the task description for T222388: Create a mechanism for SpecialPages and API modules to have dependencies injected into them.
Sep 6 2019, 6:42 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ServiceContainer, MediaWiki-API, MediaWiki-Special-pages, TechCom, Technical-Debt
Mainframe98 added a parent task for T232169: Deprecate `wgSysopEmailBans`: T20807: Phase out right-related globals.
Sep 6 2019, 6:39 AM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Clinic Duty Team), Technical-Debt (Deprecation process), MediaWiki-User-management, User-DannyS712
Mainframe98 added a subtask for T20807: Phase out right-related globals: T232169: Deprecate `wgSysopEmailBans`.
Sep 6 2019, 6:39 AM · User-DannyS712, MediaWiki-Configuration

Sep 4 2019

Mainframe98 added a project to T231982: NOINDEX userpages within the Chinese Wikipedia: Wikimedia-Site-requests.
Sep 4 2019, 12:05 PM · User-Zoranzoki21, Wikimedia-Site-requests, Chinese-Sites

Sep 2 2019

Mainframe98 closed T231656: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors as Resolved.
Sep 2 2019, 11:13 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), MediaWiki-Core-Testing

Sep 1 2019

Mainframe98 added a comment to T231656: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors.

To give an example:

Using PHP 7.2.13-1+0~20181207100540.13+stretch~1.gbpf57305
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.
Sep 1 2019, 9:10 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), MediaWiki-Core-Testing
Mainframe98 added a comment to T231656: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors.

I tried mocking the Language class, and all the tests that used creatNoOpMock() to mock Language failed until I added the exception for the destructor.

Sep 1 2019, 8:55 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), MediaWiki-Core-Testing

Aug 30 2019

Mainframe98 created T231656: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors.
Aug 30 2019, 3:24 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), MediaWiki-Core-Testing

Aug 29 2019

Mainframe98 added a subtask for T220746: 1.34.0-wmf.21 deployment blockers: T231540: Unable to view contributions: Call to undefined method ContribsPager::getContribs().
Aug 29 2019, 11:19 AM · Release-Engineering-Team-TODO (201909), Patch-For-Review, Release-Engineering-Team (Deployment services), Release, Train Deployments
Mainframe98 added a parent task for T231540: Unable to view contributions: Call to undefined method ContribsPager::getContribs(): T220746: 1.34.0-wmf.21 deployment blockers.
Aug 29 2019, 11:19 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Special-pages, User-DannyS712

Aug 22 2019

Mainframe98 edited projects for T231029: DefaultPreferencesFactory.php: Global default '' is invalid for field incubatortestwiki-code, added: MediaWiki-extensions-GlobalPreferences, MediaWiki-User-preferences; removed MediaWiki-General.
Aug 22 2019, 4:44 PM · MediaWiki-extensions-WikimediaIncubator, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MediaWiki-User-preferences, Wikimedia-production-error

Aug 20 2019

Mainframe98 added a comment to T228518: Delete unused custom /src/other/CustomLoginHandler.php in Phab extensions.

Is there anything left to do for D1151? I couldn't find any instructions on what to do once the revision has been accepted. I also don't see a way to rerun the tests; previously they failed because harbormaster couldn't connect to Jenkins (B3231).

Aug 20 2019, 9:38 AM · Phabricator

Aug 18 2019

Mainframe98 added a project to T230672: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading?: SocialProfile.
Aug 18 2019, 7:26 AM · Social-Tools, SocialProfile

Aug 16 2019

Mainframe98 added a project to T230628: WinCacheBagOStuff.php: wincache_ucache_add(): function called with a key which already exists: MediaWiki-Cache.
Aug 16 2019, 8:18 PM · MediaWiki-Cache

Aug 15 2019

Mainframe98 edited projects for T230573: Special:RecordImpression renders as a blank page, added: MediaWiki-extensions-CentralNotice; removed MediaWiki-General.

codesearch shows that this special page is part of MediaWiki-extensions-CentralNotice.

Aug 15 2019, 8:27 PM · MediaWiki-extensions-CentralNotice, User-DannyS712

Aug 11 2019

Mainframe98 added projects to T230292: SpecialPage tests failing for Loops extension: MediaWiki-extensions-Loops, ci-test-error.
Aug 11 2019, 10:17 AM · ci-test-error, MediaWiki-extensions-Loops

Aug 4 2019

Mainframe98 added projects to T229750: PhabricatorPackagesPackageEditEngine.php : typo ? => Package Package : Phabricator (Upstream), I18n.

I can't see the message you're referring to: I see "This message group is empty". when I click on the links. Do you have a direct link to the message?

Aug 4 2019, 9:39 AM · I18n, Phabricator (Upstream), Upstream

Jul 31 2019

Mainframe98 added a comment to T228280: Disable grouped results on RecentChanges page on mobile.

This change also affects non-mobile views: I can no longer group recent changes on mediawiki.org (or the beta cluster), regardless of the value of the preference. I use Vector (on desktop - no mobile whatsoever).

Jul 31 2019, 6:20 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Advanced Mobile Contributions

Jul 29 2019

Mainframe98 updated subscribers of T229185: ArmchairGM links to the most recent commit don't work in Diffusion.

Then it's probably a duplicate of T196855: Diffusion commits stuck in 'Importing...... @mmodell should know how to fix it.

Jul 29 2019, 10:38 AM · Diffusion, VPS-project-codesearch

Jul 28 2019

Mainframe98 added a project to T229176: API allusers: Is it intended that all users are returned when an invalid value for augroup is specified?: MediaWiki-API.
Jul 28 2019, 11:27 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API

Jul 27 2019

Mainframe98 closed T205951: update.php doesn't create table securepoll_elections on SQLite database as Resolved.
Jul 27 2019, 8:08 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, MediaWiki-extensions-SecurePoll

Jul 25 2019

Mainframe98 committed rEOTP9fd5ce902ab9: Use IDatabase::selectSQLText for the sub query (authored by Mainframe98).
Use IDatabase::selectSQLText for the sub query
Jul 25 2019, 2:03 PM

Jul 19 2019

Mainframe98 added a comment to T228518: Delete unused custom /src/other/CustomLoginHandler.php in Phab extensions.

I've also updated https://www.mediawiki.org/wiki/Phabricator/Differential with instructions on how to create changes without using arcanist.

Jul 19 2019, 5:20 PM · Phabricator
Mainframe98 requested review of D1151: Remove unused file CustomLoginHandler.
Jul 19 2019, 5:16 PM · Wikimedia-Phabricator-Extensions
Mainframe98 claimed T228518: Delete unused custom /src/other/CustomLoginHandler.php in Phab extensions.

There's also https://phabricator.wikimedia.org/differential/diff/create/, in which you can paste a diff, which is how I created D1151.

Jul 19 2019, 5:02 PM · Phabricator
Mainframe98 added a revision to T223926: Phabricator login page does not show Welcome text / "Click button below" text anymore: D1151: Remove unused file CustomLoginHandler.
Jul 19 2019, 5:00 PM · Developer-Advocacy (Jul-Sep 2019), Regression, Phabricator
Mainframe98 added a revision to T228518: Delete unused custom /src/other/CustomLoginHandler.php in Phab extensions: D1151: Remove unused file CustomLoginHandler.
Jul 19 2019, 5:00 PM · Phabricator

Jul 18 2019

Mainframe98 updated the task description for T228367: Archive the ViewFiles extension.
Jul 18 2019, 8:54 AM · translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup

Jul 17 2019

Mainframe98 created T228264: Viewing php extensions on libup's package overview results in an 500 Internal Server Error.
Jul 17 2019, 9:46 AM · LibUp

Jul 16 2019

Mainframe98 added a comment to T228148: Convert Convert2Wiki to use extension registration.

I've created T228198: Archive the Convert2Wiki extension.

Jul 16 2019, 6:19 PM · Patch-For-Review, MediaWiki-extensions-Other
Mainframe98 created T228198: Archive the Convert2Wiki extension.
Jul 16 2019, 6:18 PM · User-MarcoAurelio, Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 added a comment to T228148: Convert Convert2Wiki to use extension registration.

I did an install and found the following issues, that make me advise archival:

  • I18n, while present, is not loaded, resulting in ⧼convert2wiki⧽ shown.
  • The special page itself is not translatable, the text is hardcoded in Convert2WikiSpecial.php.
  • Rather than adding all necessary classes to the MediaWiki autoloader, this extension manually registers a new autoloader to load its classes, in a weird way that isn't obvious to me why you'd do that. There is no comment indicating why.
  • Usage of deprecated global $wgAjaxExportList.
  • No maintenance or updates have been done after the initial import.
  • Only reported usage is a 1.26 wiki.
  • Dropdowns on Special:Convert2Wiki do not work.
  • Console reports TypeError: Cannot read property 'wikiScript' of undefined at convert2wiki.js:48
  • The special page does not work at all, no submit button or anything. It seems to rely on the JavaScript component to do anything, making it unfriendly to users without JavaScript.
  • Unit tests aren't auto-discovered, nor manually registered. It does have tests, but those aren't run by the CI. The tests themselves fail, there is a broken method call in Convert2Wiki\Formats\Text.
Jul 16 2019, 6:09 PM · Patch-For-Review, MediaWiki-extensions-Other

Jul 12 2019

Mainframe98 added a comment to T227843: Deprecate AbuseFilter's support for Zero.

Mediawiki.org had one filter, which I've marked as deleted: https://www.mediawiki.org/wiki/Special:AbuseFilter/50.

Jul 12 2019, 7:07 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), User-notice, WikimediaMessages, Technical-Debt, AbuseFilter

Jul 11 2019

Mainframe98 updated the task description for T227731: Archive ZeroPortal and ZeroBanner.
Jul 11 2019, 7:47 AM · translatewiki.net, ZeroPortal, ZeroBanner, MediaWiki-extensions-General, Repository-Admins, Technical-Debt
Mainframe98 added a project to T227731: Archive ZeroPortal and ZeroBanner: translatewiki.net.
Jul 11 2019, 7:47 AM · translatewiki.net, ZeroPortal, ZeroBanner, MediaWiki-extensions-General, Repository-Admins, Technical-Debt

Jul 2 2019

Mainframe98 awarded T191035: MediaWiki core @Database tests failure with sqlite a Party Time token.
Jul 2 2019, 11:00 AM · SQLite, MediaWiki-Core-Testing

Jun 27 2019

Mainframe98 added a project to T226690: Monobook – the three symbols User-page / your alerts / your notices: MonoBook.
Jun 27 2019, 7:02 AM · Growth-Team, Notifications, MonoBook

Jun 24 2019

Mainframe98 added a project to T226433: Install Extension:Newsletter on Meta: Wikimedia-Extension-setup.
Jun 24 2019, 5:39 PM · Community-consensus-needed, Wikimedia-Site-requests, Wikimedia-Extension-setup, Wiktionary

Jun 21 2019

Mainframe98 updated the task description for T226149: Archive the FirstSteps extension.
Jun 21 2019, 10:12 PM · Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Restricted Application added a project to T226249: Cannot close "Custom Policy" dialog window when viewing policy of an OAuth application; no "Close" button displayed: Upstream.
Jun 21 2019, 11:06 AM · Phabricator (2019-08-22), Upstream

Jun 20 2019

Mainframe98 moved T226149: Archive the FirstSteps extension from Backlog to delete on the GitHub-Mirrors board.
Jun 20 2019, 9:16 AM · Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 moved T226149: Archive the FirstSteps extension from Backlog to Cleanup / Archival on the Repository-Admins board.
Jun 20 2019, 9:16 AM · Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 moved T226149: Archive the FirstSteps extension from Untriaged to Archive extensions on the Cleanup board.
Jun 20 2019, 9:15 AM · Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 updated the task description for T226149: Archive the FirstSteps extension.
Jun 20 2019, 8:22 AM · Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 added a project to T226149: Archive the FirstSteps extension: translatewiki.net.
Jun 20 2019, 7:57 AM · Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup
Mainframe98 claimed T226149: Archive the FirstSteps extension.

I couldn't find any uses on WikiApiary: https://wikiapiary.com/wiki/Extension:FirstSteps. Googling the extension description didn't turn up anything either.

Jun 20 2019, 7:52 AM · Patch-For-Review, translatewiki.net, MediaWiki-extensions-Other, GitHub-Mirrors, Repository-Admins, Cleanup