Page MenuHomePhabricator

Mainframe98 (Klaas Skelte van der Werf)
Administrator on MediaWiki.org and volunteer developer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 18 2016, 8:19 PM (195 w, 5 d)
Availability
Available
IRC Nick
Mainframe98
LDAP User
Mainframe98
MediaWiki User
Mainframe98 [ Global Accounts ]

I use MediaWiki in Dutch. If I ever claim to see something you don't, check if it occurs when setting the user language to Dutch, and remind me to switch too, so we don't get a repetition of T207288. And if I have the bright idea to test something on my local vagrant machine, and it doesn't work, I probably have a messed up vagrant instance and should be reminded to reset it, so we don't get a repetition of T207288.

Recent Activity

Yesterday

Mainframe98 added projects to T245387: PostgreSQL installer ignores port specification: PostgreSQL, MediaWiki-Installer.
Mon, Feb 17, 8:24 AM · MediaWiki-Installer, PostgreSQL

Sat, Feb 15

Mainframe98 awarded T243997: <languages> tag has wasteful heading on narrow screens a Love token.
Sat, Feb 15, 7:56 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Readers-Web-Backlog, Mobile-Web-Settings, MediaWiki-extensions-Translate

Fri, Feb 14

Mainframe98 claimed T243176: Remove wfGetMessageCacheStorage.
Fri, Feb 14, 7:12 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MediaWiki-Cache, Technical-Debt (Deprecation process)

Thu, Feb 13

Mainframe98 added a project to T245129: Parser::getTitle() is not allowed to return null, eventhough it can happen: MediaWiki-Parser.
Thu, Feb 13, 11:23 AM · MediaWiki-Parser

Mon, Feb 10

Mainframe98 added a project to T244720: ImageMap extension error message Error: Image is invalid or non-existent should give more details.: ImageMap.
Mon, Feb 10, 11:26 AM · ImageMap
Mainframe98 added a comment to T220406: Add mediawiki-vagrant php7.2 xdebug support.

I've run into the same issue, but didn't get the same information in the xdebug logs; @abi_, did you do anything special to get these logs?

Mon, Feb 10, 10:49 AM · MediaWiki-Vagrant, Fundraising-Backlog
Mainframe98 created T244716: Update php-xdebug to 2.9.2 in apt.wm.o component/php72.
Mon, Feb 10, 10:48 AM · serviceops, Operations

Thu, Feb 6

Mainframe98 moved T244466: Allow the creation of skins with services injected from Backlog to Skinning system on the MediaWiki-Interface board.
Thu, Feb 6, 10:13 AM · Patch-For-Review, MediaWiki-Interface
Mainframe98 created T244466: Allow the creation of skins with services injected.
Thu, Feb 6, 10:13 AM · Patch-For-Review, MediaWiki-Interface

Mon, Feb 3

Mainframe98 added a project to T244114: "Publish" button remains greyed out: "TypeError: this.translationView.categoryUI is null": ContentTranslation.
Mon, Feb 3, 11:30 AM · Language-Team (Language-2020-January-March), ContentTranslation
Mainframe98 created T244119: Minerva on Desktop double escapes entries in the hamburger menu.
Mon, Feb 3, 10:26 AM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Readers-Web-Backlog (Kanbanana-2019-20-Q3), MinervaNeue
Mainframe98 added a comment to Blog Post: Why does building a skin require PHP knowledge?.

Am I alone in thinking it should be possible to build skins without PHP? Do you have different opinions on what the skin system should be?

You're not alone. First and foremost I feel the skin system should be modernized. Requiring passing raw HTML to a (mustache) template because the QuickTemplate abstraction generates raw HTML or require elements to be built with methods like makeListItem should be the exception, not the norm.
It would certainly help if there was a document describing what elements a skin is expected to provide, with which classes/ids, and what hierarchical order is required (for say VisualEditor).

Mon, Feb 3, 8:53 AM · MediaWiki-Interface

Fri, Jan 31

Mainframe98 added a project to T244033: Check on IP range in MediaWiki\Block\DatabaseBlock::newLoad triggers error in psql, breaks mediawiki.: PostgreSQL.
Fri, Jan 31, 9:14 PM · MediaWiki-General, PostgreSQL

Thu, Jan 30

Mainframe98 added a project to T243947: light Integration tests without DB: MediaWiki-Core-Testing.
Thu, Jan 30, 10:47 AM · MediaWiki-Core-Testing
Mainframe98 added a project to T243945: Could we use the same modern design for all Wikimedia projects portals?: Wikimedia-Portals.
Thu, Jan 30, 10:27 AM · Wikimedia-Portals, Design

Fri, Jan 24

Mainframe98 closed T203209: Allow parent scope variables to be used in Mustache / TemplateParser as Resolved.

The provided patch was merged and has successfully been in production for over a year without any noticeable performance regressions.

Fri, Jan 24, 3:55 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), MediaWiki-HTML-Templating
Mainframe98 added a project to T243599: special pages has not been updated since November 2019 in jawiki and several other projects: Wikimedia-maintenance-script-run.
Fri, Jan 24, 1:35 PM · serviceops-radar, Operations, Wikimedia-maintenance-script-run

Mon, Jan 20

Mainframe98 created T243233: MediaWiki should provide a LocalClusterObjectCache service.
Mon, Jan 20, 6:58 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Cache
Mainframe98 added a comment to T237873: Deprecate and remove extension database updating globals.

While that does work, it doesn't tell us which extension is still using the globals; which makes finding the offending extension difficult.

Mon, Jan 20, 12:39 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MediaWiki-General, Technical-Debt
Mainframe98 updated the task description for T243176: Remove wfGetMessageCacheStorage.
Mon, Jan 20, 10:37 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MediaWiki-Cache, Technical-Debt (Deprecation process)
Mainframe98 created T243176: Remove wfGetMessageCacheStorage.
Mon, Jan 20, 10:36 AM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MediaWiki-Cache, Technical-Debt (Deprecation process)
Mainframe98 created T243175: Deprecate and remove $messageMemc.
Mon, Jan 20, 10:33 AM · Technical-Debt (Deprecation process), MediaWiki-General

Jan 10 2020

Mainframe98 added a comment to T242050: Support optional extension dependencies in ObjectFactory specifications.

I'm not sure if I correctly understand the issue, but can't you just conditionally define the service in the ObjectFactory spec depending on whether or not the extension is installed?

Jan 10 2020, 12:33 PM · MediaWiki-ServiceContainer, ObjectFactory

Jan 6 2020

Mainframe98 closed T239855: Inject services used by LinkBatch as Resolved.
Jan 6 2020, 6:13 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Cache

Dec 27 2019

Mainframe98 added a comment to T90875: Convert tests/phpunit/phpunit.php entrypoint to plain PHPUnit with bootstrap file.

I've uploaded a change that achieves what this task asks for. I originally intended to use it to debug tests using PhpStorm, until I found out that I could use it without PhpStorm too.
If T173899: autoload.ide.php needs to be updated or removed is a concern, I'll gladly volunteer as owner; I am the one using it after all.

Dec 27 2019, 10:59 AM · Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Code-Health-Metrics, Technical-Debt, MediaWiki-Core-Testing

Dec 24 2019

Mainframe98 added a comment to T238984: importdump warning: call_user_func() expects parameter 1 to be a valid callback, cannot access private method BackupReader::reportPage() in WikiImporter.php.

@Physikerwelt, I only just noticed that there's a month difference between this task and yours; my apologies. Feel free to unduplicate.

Dec 24 2019, 8:51 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MediaWiki-Maintenance-scripts, Regression, MediaWiki-Export-or-Import
Mainframe98 merged T241426: Investigate why importDump.php < xmlfile.xml complains that BackupReader::handleRevision is private into T238984: importdump warning: call_user_func() expects parameter 1 to be a valid callback, cannot access private method BackupReader::reportPage() in WikiImporter.php.
Dec 24 2019, 6:58 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MediaWiki-Maintenance-scripts, Regression, MediaWiki-Export-or-Import
Mainframe98 merged task T241426: Investigate why importDump.php < xmlfile.xml complains that BackupReader::handleRevision is private into T238984: importdump warning: call_user_func() expects parameter 1 to be a valid callback, cannot access private method BackupReader::reportPage() in WikiImporter.php.
Dec 24 2019, 6:58 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MediaWiki-Export-or-Import, User-Physikerwelt

Dec 17 2019

Mainframe98 archived P9852 Memory usage test for T196090.
Dec 17 2019, 11:48 AM

Dec 11 2019

Mainframe98 added a comment to T196090: Extensions should be able to add to the test autoloader.

In light of T187154 and pending T220994 or similar, we should not significantly increase the size of extension.json wholesale. This adds notable latency to all web request for all entry points.
For cases where the classes are already in extension.json, I suppose moving them will not increase it by much. Although it does mean adding a new object wrapper to a lot of extension.json files and by extend to the array structure we have to load in memory and allocate for every extension on every request.

Dec 11 2019, 6:14 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Patch-For-Review, Performance-Team, MediaWiki-Core-Testing, MediaWiki-Configuration
Mainframe98 added a comment to P9852 Memory usage test for T196090.

Test results for rEABF's extension.json:
Original: (rEABF6be070e5a2b2e1d39f1130ddf5b1157413819fc4)

$ php bench.php
Starting memory: 406776
Memory at iteration 0: 469808
Memory at iteration 1: 532320
Memory at iteration 2: 594832
Memory at iteration 3: 657344
Memory at iteration 4: 719856
Memory at iteration 5: 782368
Memory at iteration 6: 844880
Memory at iteration 7: 907392
Memory at iteration 8: 970224
Memory at iteration 9: 1032736

Adjusted: (rEABFcff9889549a12b8778cbd78c811f28d334e7c1af)

$ php bench.php
Starting memory: 406776
Memory at iteration 0: 470232
Memory at iteration 1: 533168
Memory at iteration 2: 596104
Memory at iteration 3: 659040
Memory at iteration 4: 721976
Memory at iteration 5: 784912
Memory at iteration 6: 847848
Memory at iteration 7: 910784
Memory at iteration 8: 974040
Memory at iteration 9: 1036976
Dec 11 2019, 3:48 PM
Mainframe98 created P9852 Memory usage test for T196090.
Dec 11 2019, 3:45 PM

Dec 9 2019

Mainframe98 added a comment to T240261: Allow extension registry/extension.json to autoload test helper classes only in test mode.

Is this about the same topic as T196090: Extensions should be able to add to the test autoloader?

Dec 9 2019, 9:05 PM · MediaWiki-Core-Testing, MediaWiki-Configuration
Mainframe98 updated the task description for T237873: Deprecate and remove extension database updating globals.
Dec 9 2019, 11:20 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MediaWiki-General, Technical-Debt

Dec 8 2019

Mainframe98 added a comment to T237873: Deprecate and remove extension database updating globals.

I've tried using DeprecatedGlobal, but that class is not suitable for globals using non-objects; for arrays, it'll result in a PHP warning: Cannot use object of type DeprecatedGlobal as array. I'm not sure what else could serve a clear deprecation warning. You could add a check to DatabaseUpdater::getOldGlobalUpdates that checks if any of the globals is something else than [], but that doesn't tell you what extension caused that warning.

Dec 8 2019, 11:48 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MediaWiki-General, Technical-Debt

Dec 7 2019

Mainframe98 added a comment to T237873: Deprecate and remove extension database updating globals.

Well, my reasoning was that with T223939: Type-hint all onLoadExtensionSchemaUpdate hook handler $updater parameter with DatabaseUpdater type (which would result in prohibiting passing null; therefore making the backwards compatibility fallback an un-executable branch of code), any of the known extensions use it as backwards compatibility only, its effective obsolescence in 1.17 and the fact that some globals lack documentation, we're effectively dealing with dead code here. I think we'd be hardpressed to find anything relying on these globals that is still compatible with MediaWiki 1.35.

Dec 7 2019, 12:17 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MediaWiki-General, Technical-Debt

Dec 4 2019

Mainframe98 added a comment to T239807: Clean up old images on wikitech-static.

After a brief discussion on irc, there are a couple of suggestions for updating the content of Special:UnusedFiles (which could then be used via the api, we hope)

Dec 4 2019, 8:35 PM · wikitech.wikimedia.org
Mainframe98 claimed T237873: Deprecate and remove extension database updating globals.
Dec 4 2019, 7:53 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MediaWiki-General, Technical-Debt
Mainframe98 created T239855: Inject services used by LinkBatch.
Dec 4 2019, 7:35 PM · MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Cache
Mainframe98 added a comment to T238956: switch prod Phabricator from phab1003 to phab1001.

I suspect that this move inadvertently caused T239786: Viewing MediaWiki repository in diffusion results in an Unhandled Exception ("CommandException") as I only started seeing it today.

Dec 4 2019, 4:21 PM · serviceops, Release-Engineering-Team
Mainframe98 created T239786: Viewing MediaWiki repository in diffusion results in an Unhandled Exception ("CommandException").
Dec 4 2019, 8:47 AM · Diffusion, Phabricator

Nov 21 2019

Mainframe98 created T238815: Jenkins/Zuul does not respond on I93d931ab60305ad49a6e419f8269c77791a3938d or I6c00cb8f32be7fb7f02deeac374378352b51a4ed.
Nov 21 2019, 9:03 AM · Continuous-Integration-Config

Nov 17 2019

Mainframe98 added a project to T238501: Can't undo latest edit and summary that include captions: Wikimedia-production-error.
Nov 17 2019, 5:57 PM · Wikimedia-production-error, Commons

Nov 15 2019

Mainframe98 added a comment to T222472: Investigate gerrit session expiration.

Today again; I had remained logged in since my last comment (10 days ago - T222472#5634681).

Nov 15 2019, 8:53 AM · Release-Engineering-Team-TODO, Patch-For-Review, Release-Engineering-Team (Development services), Gerrit

Nov 11 2019

Mainframe98 added a project to T238026: Attempt to see a diff between deleted revisions of a file triggers InvalidArgumentException: Wikimedia-production-error.
Nov 11 2019, 9:10 PM · Wikimedia-production-error
Mainframe98 added a project to T237929: Compatibility with $wgReadOnly: MediaWiki-extensions-Pluggable-Auth.
Nov 11 2019, 10:13 AM · MediaWiki-extensions-Pluggable-Auth
Mainframe98 updated the task description for T237873: Deprecate and remove extension database updating globals.
Nov 11 2019, 9:35 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MediaWiki-General, Technical-Debt

Nov 10 2019

Mainframe98 created T237873: Deprecate and remove extension database updating globals.
Nov 10 2019, 6:16 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MediaWiki-General, Technical-Debt
Mainframe98 merged T237842: Decide and document code style for return types for functions into T220719: Standardize return type hint spacing.
Nov 10 2019, 7:23 AM · MediaWiki-Documentation, MediaWiki-Codesniffer
Mainframe98 merged task T237842: Decide and document code style for return types for functions into T220719: Standardize return type hint spacing.
Nov 10 2019, 7:23 AM · Documentation, MediaWiki-General

Nov 9 2019

Mainframe98 merged T237793: Scroll position lost when exiting Media Viewer into T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70.
Nov 9 2019, 2:07 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer
Mainframe98 merged task T237793: Scroll position lost when exiting Media Viewer into T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70.
Nov 9 2019, 2:07 PM · MediaViewer
Mainframe98 added a project to T237792: Editing "$wgNamespacesToBeSearchedDefault" at EO wiktionary: Community-consensus-needed.
Nov 9 2019, 9:26 AM · User-MarcoAurelio, Wikimedia-Site-requests

Nov 8 2019

Mainframe98 closed T237694: Alphasort use statements as Resolved.
Nov 8 2019, 1:26 PM · MediaWiki-Codesniffer
Mainframe98 claimed T237694: Alphasort use statements.
Nov 8 2019, 12:21 PM · MediaWiki-Codesniffer

Nov 6 2019

Mainframe98 added a comment to T237500: Regression: [1.35.0-wmf.5] Classic RC lacks space between "(User creation log)"/"(Move log)"/"(Page translation log)" string and date.

I believe this is caused by rMW30c98e2351b4: Semicolon separator for article title and timestamp is a pseudo element, which in turn is for T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.

Nov 6 2019, 12:39 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Regression, MediaWiki-Recent-changes

Nov 5 2019

Mainframe98 added a comment to T222472: Investigate gerrit session expiration.

In the hope it's useful, I'll mention I'm still logged in to Gerrit, since my previous log in on October 24.

Nov 5 2019, 9:07 AM · Release-Engineering-Team-TODO, Patch-For-Review, Release-Engineering-Team (Development services), Gerrit

Nov 4 2019

Mainframe98 added a project to T237325: IP limit exception for 2019-11-06: Wikimedia-Site-requests.
Nov 4 2019, 9:25 PM · Wikimedia-Site-requests

Oct 26 2019

Mainframe98 merged T236597: Ignoring users is not working into T236460: Regression: Changes to email blacklist or muted users do not activate Save button in Preferences.
Oct 26 2019, 4:29 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Regression, Notifications, Growth-Team, MediaWiki-User-preferences
Mainframe98 merged task T236597: Ignoring users is not working into T236460: Regression: Changes to email blacklist or muted users do not activate Save button in Preferences.
Oct 26 2019, 4:29 PM · MediaWiki-User-preferences, MediaWiki-User-management

Oct 24 2019

Mainframe98 added a comment to T222472: Investigate gerrit session expiration.

Did you all click the remember me box?

Of course, what type of question is this?

Oct 24 2019, 10:22 AM · Release-Engineering-Team-TODO, Patch-For-Review, Release-Engineering-Team (Development services), Gerrit
Mainframe98 added a comment to T222472: Investigate gerrit session expiration.

And today again.

Oct 24 2019, 7:51 AM · Release-Engineering-Team-TODO, Patch-For-Review, Release-Engineering-Team (Development services), Gerrit

Oct 23 2019

Mainframe98 added a comment to T222472: Investigate gerrit session expiration.

I've been keeping a log for when I need to log in to Gerrit:

  • oct 16: logged in
  • oct 17: still logged in
  • oct 18: still logged in
  • oct 21: still logged in
  • oct 22: had to log in
  • oct 23: had to log in

HTH.

Oct 23 2019, 4:53 PM · Release-Engineering-Team-TODO, Patch-For-Review, Release-Engineering-Team (Development services), Gerrit

Oct 15 2019

Mainframe98 committed rEOTP1c6c81614f88: build: Upgrade mediawiki-codesniffer to v28.0.0 (authored by Mainframe98).
build: Upgrade mediawiki-codesniffer to v28.0.0
Oct 15 2019, 3:12 PM

Oct 9 2019

Mainframe98 added a comment to T235115: Split special page alias resolution from SpecialPageFactory into a separate service.

Unfortunately, any alias resolver needs to know the list of special pages to know which special page belongs to which alias, which brings us back to the original issue, where extensions will (accidentally) need to specify special pages, but cannot do that without access to services that use the alias resolver.

Oct 9 2019, 5:31 PM · MediaWiki-Special-pages, Technical-Debt
Mainframe98 created T235115: Split special page alias resolution from SpecialPageFactory into a separate service.
Oct 9 2019, 5:08 PM · MediaWiki-Special-pages, Technical-Debt
Mainframe98 awarded Blog Post: Integrating code coverage metrics with your development workflow a Love token.
Oct 9 2019, 10:34 AM · Code-Health, MediaWiki-Core-Testing, Test-Coverage

Oct 6 2019

Mainframe98 added a comment to T196206: Bump symfony libraries when we no longer need hhvm support.

https://github.com/symfony/symfony/blob/4.0/composer.json and https://github.com/symfony/symfony/blob/4.4/composer.json have ^7.1.3
https://github.com/symfony/symfony/blob/master/composer.json (to be 5.0 I guess) has ^7.2.9
https://github.com/symfony/symfony/commit/d94d9d792c445240cbaf80c7b413795b71aff718 - I wonder if there's any specific reason to select 7.2.9 as the min supported PHP 7.2, that dates to 16 Aug 2018, well before that commit in May
Something for us to bare in mind when we come to bumping to PHP 7.2
On https://github.com/symfony/symfony/blob/3.4/composer.json#L19 we're good with ^5.5.9|>=7.0.8
But of course, we only require PHP 7.0.0. I suspect most people will have a newer point release... But it does mean our require-dev symfony/yaml will conflict
Filing a separate task
Re-stalling as we have nothing to do until we bump to 7.2 (do we have a task for that to bump this against)

Oct 6 2019, 8:15 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, MediaWiki-General
Mainframe98 updated subscribers of T192167: Upgrade PHPUnit from 4/6 to 8.

I've done some early investigation about PHPUnit 8. Needless to say, transitioning won't be easy. I've found two main problems:

  • PHPUnit 7/8 added gazillions of typehints. Many of them are in lower-level methods which we only override in base core classes, so replacing them is pretty easy. The main problem is that typehints were also added to setUp and tearDown, which are overriden in many, many test classes. I think that the easier solution is to automatically add the : void return type hint in *all* test classes in extensions and core *now*. This is accepted in PHP7.0+, even if the parent is not typehinted.
Oct 6 2019, 2:39 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing

Oct 5 2019

Mainframe98 added a comment to T234723: PHP fatal error: syntax error, unexpected T_CONST, expecting T_VARIABLE.

It's definitely culprit, but... WTF? That error can only happen on HHVM, and we're not running on HHVM anymore, right???

Oct 5 2019, 4:53 PM · Beta-Cluster-Infrastructure
Mainframe98 renamed T231742: $wgDebugToolbar not showing SQL queries from $wgDebugConsole not showing SQL queries to $wgDebugToolbar not showing SQL queries.
Oct 5 2019, 7:45 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MW-1.34-notes, MW-1.34-release, Wikimedia-Rdbms, Performance-Team, MediaWiki-Debug-Logger

Oct 3 2019

Mainframe98 added a comment to T232506: Inject services into special pages.

Right now, this is blocked on a circular dependency issue caused by a combination of MediaWiki-extensions-GlobalPreferences and MobileFrontend. I'm not able to reproduce it locally however.

Oct 3 2019, 10:35 AM · CPT Initiatives (Decoupling (CDP2)), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Special-pages, Technical-Debt

Sep 30 2019

Mainframe98 created T234240: It should be possible to install php-ast using apt-get on MediaWiki-Vagrant.
Sep 30 2019, 4:24 PM · Operations, MediaWiki-Vagrant, phan
Mainframe98 moved T234224: Gerrit workflow: "Merge review" AND "Open push" for BlueSpice? from Bugs & stuff to Discussions & doc stuff on the Gerrit board.
Sep 30 2019, 3:58 PM · Gerrit
Mainframe98 added a project to T234224: Gerrit workflow: "Merge review" AND "Open push" for BlueSpice?: Gerrit.
Sep 30 2019, 3:58 PM · Gerrit
Mainframe98 added a parent task for T192166: Drop HHVM support from MediaWiki: T234236: Drop HHVM support from MediaWiki-Vagrant.
Sep 30 2019, 3:55 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes, TechCom, Core Platform Team Legacy (Watching / External), Patch-For-Review, HHVM
Mainframe98 added a subtask for T234236: Drop HHVM support from MediaWiki-Vagrant: T192166: Drop HHVM support from MediaWiki.
Sep 30 2019, 3:55 PM · MediaWiki-Vagrant, HHVM
Mainframe98 created T234236: Drop HHVM support from MediaWiki-Vagrant.
Sep 30 2019, 3:54 PM · MediaWiki-Vagrant, HHVM

Sep 22 2019

Mainframe98 added a comment to T233512: Tag functions that always return a specific value (regardless of class, execution, etc) with @codeCoverageIgnore.

Note that ApiStructureTest does test the mentioned methods (and more: T184216#3878417).

Sep 22 2019, 5:03 PM · MediaWiki-Core-Testing, User-DannyS712, Test-Coverage, Proposal

Sep 19 2019

Mainframe98 added a comment to T233308: Special:MovePage WMFTimeoutException from line 39 of /srv/mediawiki/wmf-config/set-time-limit.php: the execution time limit of 60 seconds was exceeded.

Looks like a recursive call to MovePage:

Sep 19 2019, 3:07 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Wikimedia-production-error, MediaWiki-extensions-Translate
Mainframe98 renamed T233278: wikimedia/php-session-serializer 1.0.4 is not tagged, despite being required by MediaWiki 1.30 from wikimedia/php-session/serializer to wikimedia/php-session/serializer 1.0.4 is not tagged, despite being required by MediaWiki 1.30.
Sep 19 2019, 7:31 AM · MediaWiki-General, php-session-serializer

Sep 18 2019

Mainframe98 added a comment to F30388506: ERROR_chrome_2019-09-18T09-12-05.721Z.png.

For https://gerrit.wikimedia.org/r/c/mediawiki/core/+/535657, from https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/5876/console

Sep 18 2019, 9:16 AM

Sep 17 2019

Mainframe98 edited projects for T233137: Update $wgGroupPermissions for bnwiki, added: Wikimedia-Site-requests; removed MediaWiki-User-management.
Sep 17 2019, 6:49 PM · Bengali-Sites, User-Zoranzoki21, Wikimedia-Site-requests

Sep 16 2019

Mainframe98 committed rERLSbe5984abadf2: Inject ObjectFactory into ApiModuleManager (authored by Mainframe98).
Inject ObjectFactory into ApiModuleManager
Sep 16 2019, 9:39 PM

Sep 15 2019

Mainframe98 merged T190417: CheckboxMultiSelectInputWidget doesn't disable when infusing a disabled HTMLMultiSelectField into T230066: TagMultiselectWidget: the input field is editable even if the widget is disabled.
Sep 15 2019, 12:00 PM · OOUI, User-DannyS712, AbuseFilter
Mainframe98 merged task T190417: CheckboxMultiSelectInputWidget doesn't disable when infusing a disabled HTMLMultiSelectField into T230066: TagMultiselectWidget: the input field is editable even if the widget is disabled.
Sep 15 2019, 12:00 PM · OOUI

Sep 10 2019

Mainframe98 added a comment to T232506: Inject services into special pages.

For the listed patch, this code search shows which extensions will break due to the patch above.

Sep 10 2019, 5:54 PM · CPT Initiatives (Decoupling (CDP2)), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Special-pages, Technical-Debt
Mainframe98 updated the task description for T232506: Inject services into special pages.
Sep 10 2019, 5:27 PM · CPT Initiatives (Decoupling (CDP2)), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Special-pages, Technical-Debt
Mainframe98 created T232506: Inject services into special pages.
Sep 10 2019, 5:11 PM · CPT Initiatives (Decoupling (CDP2)), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Special-pages, Technical-Debt
Mainframe98 committed rEOTP918685b0b428: Remove unnecessary PHPCS exclusions (authored by Mainframe98).
Remove unnecessary PHPCS exclusions
Sep 10 2019, 10:35 AM

Sep 6 2019

Mainframe98 updated the task description for T222388: Create a mechanism for SpecialPages and API modules to have dependencies injected into them.
Sep 6 2019, 6:42 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ServiceContainer, MediaWiki-API, MediaWiki-Special-pages, TechCom, Technical-Debt
Mainframe98 added a parent task for T232169: Deprecate `wgSysopEmailBans`: T20807: Phase out right-related globals.
Sep 6 2019, 6:39 AM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Clinic Duty Team), Technical-Debt (Deprecation process), MediaWiki-User-management, User-DannyS712
Mainframe98 added a subtask for T20807: Phase out right-related globals: T232169: Deprecate `wgSysopEmailBans`.
Sep 6 2019, 6:39 AM · User-DannyS712, MediaWiki-Configuration

Sep 4 2019

Mainframe98 added a project to T231982: NOINDEX userpages within the Chinese Wikipedia: Wikimedia-Site-requests.
Sep 4 2019, 12:05 PM · User-Zoranzoki21, Wikimedia-Site-requests, Chinese-Sites

Sep 2 2019

Mainframe98 closed T231656: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors as Resolved.
Sep 2 2019, 11:13 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), MediaWiki-Core-Testing

Sep 1 2019

Mainframe98 added a comment to T231656: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors.

To give an example:

Using PHP 7.2.13-1+0~20181207100540.13+stretch~1.gbpf57305
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.
Sep 1 2019, 9:10 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), MediaWiki-Core-Testing
Mainframe98 added a comment to T231656: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors.

I tried mocking the Language class, and all the tests that used creatNoOpMock() to mock Language failed until I added the exception for the destructor.

Sep 1 2019, 8:55 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), MediaWiki-Core-Testing

Aug 30 2019

Mainframe98 created T231656: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors.
Aug 30 2019, 3:24 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), MediaWiki-Core-Testing

Aug 29 2019

Mainframe98 added a subtask for T220746: 1.34.0-wmf.21 deployment blockers: T231540: Unable to view contributions: Call to undefined method ContribsPager::getContribs().
Aug 29 2019, 11:19 AM · Release-Engineering-Team-TODO (201909), Patch-For-Review, Release-Engineering-Team (Deployment services), Release, Train Deployments
Mainframe98 added a parent task for T231540: Unable to view contributions: Call to undefined method ContribsPager::getContribs(): T220746: 1.34.0-wmf.21 deployment blockers.
Aug 29 2019, 11:19 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Special-pages, User-DannyS712