Page MenuHomePhabricator

MarkAHershberger (Mark A. Hershberger)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 25 2014, 3:45 PM (264 w, 1 d)
Availability
Available
LDAP User
MarkAHershberger
MediaWiki User
MarkAHershberger [ Global Accounts ]

Recent Activity

Yesterday

MarkAHershberger added a comment to T235392: I09a178e5c6938954edb2949f13660227d6a01fbc breaks extension Semantic MediaWiki.

I disagree. This is what releases are for.

Thu, Oct 17, 4:03 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Parsing-Team, MW-1.34-release, Patch-For-Review, MediaWiki-Parser

Tue, Sep 24

MarkAHershberger added a project to T233727: PluggableAuth should complain if $wgPluggableAuth_Class does not resolve to a loadable class: MediaWiki-extensions-Pluggable-Auth.
Tue, Sep 24, 2:46 PM · MediaWiki-extensions-Pluggable-Auth
MarkAHershberger created T233727: PluggableAuth should complain if $wgPluggableAuth_Class does not resolve to a loadable class.
Tue, Sep 24, 2:45 PM · MediaWiki-extensions-Pluggable-Auth

Sun, Sep 22

MarkAHershberger added a comment to T2453: Make page titles case-insensitive (but preserve case-sensitivity for display).

Try the SuggestedTitles extension.

Sun, Sep 22, 8:38 PM · WorkType-NewFunctionality, MediaWiki-General

Sep 12 2019

MarkAHershberger added a comment to T224949: Failed to access name from slot_roles using id = 1.

Now...

[51fbb8ea5f47e21ee0143081] [no req]   MediaWiki\Revision\RevisionAccessException from line 1635 of /opt/htdocs/mediawiki/includes/Revision/RevisionStore.php: Main slot of revision 934 not found in database!
Backtrace:
#0 /opt/htdocs/mediawiki/includes/Revision/RevisionStore.php(1671): MediaWiki\Revision\RevisionStore->loadSlotRecords(string, integer)
#1 [internal function]: MediaWiki\Revision\RevisionStore->MediaWiki\Revision\{closure}()
#2 /opt/htdocs/mediawiki/includes/Revision/RevisionSlots.php(165): call_user_func(Closure)
#3 /opt/htdocs/mediawiki/includes/Revision/RevisionRenderer.php(169): MediaWiki\Revision\RevisionSlots->getSlots()
#4 /opt/htdocs/mediawiki/includes/Revision/RevisionRenderer.php(128): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#5 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#6 /opt/htdocs/mediawiki/includes/Revision/RenderedRevision.php(175): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#7 /opt/htdocs/mediawiki/includes/Storage/DerivedPageDataUpdater.php(1266): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#8 /opt/htdocs/mediawiki/includes/Storage/DerivedPageDataUpdater.php(1288): MediaWiki\Storage\DerivedPageDataUpdater->getCanonicalParserOutput()
#9 /opt/htdocs/mediawiki/includes/Storage/DerivedPageDataUpdater.php(1560): MediaWiki\Storage\DerivedPageDataUpdater->getSecondaryDataUpdates(boolean)
#10 /opt/htdocs/mediawiki/includes/page/WikiPage.php(2106): MediaWiki\Storage\DerivedPageDataUpdater->doSecondaryDataUpdates(array)
#11 /opt/htdocs/mediawiki/maintenance/refreshLinks.php(275): WikiPage->doSecondaryDataUpdates(array)
#12 /opt/htdocs/mediawiki/maintenance/refreshLinks.php(198): RefreshLinks::fixLinksFromArticle(integer, boolean)
#13 /opt/htdocs/mediawiki/maintenance/refreshLinks.php(83): RefreshLinks->doRefreshLinks(integer, boolean, string, boolean, boolean)
#14 /opt/htdocs/mediawiki/maintenance/rebuildall.php(60): RefreshLinks->execute()
#15 /opt/htdocs/mediawiki/maintenance/doMaintenance.php(94): RebuildAll->execute()
#16 /opt/htdocs/mediawiki/maintenance/rebuildall.php(67): require_once(string)
#17 {main}
Sep 12 2019, 10:59 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-release, Multi-Content-Revisions (Reactive), MW-1.33-release, Patch-For-Review, MW-1.32-release, MediaWiki-General
MarkAHershberger added a comment to T224949: Failed to access name from slot_roles using id = 1.

fixed by adding a row with role_id=2 and role_name='aux'

Sep 12 2019, 10:39 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-release, Multi-Content-Revisions (Reactive), MW-1.33-release, Patch-For-Review, MW-1.32-release, MediaWiki-General
MarkAHershberger added a comment to T224949: Failed to access name from slot_roles using id = 1.

No, I'm not sure. I just found this bug and hoped it was the same.

> select * from slot_roles;
stdClass Object
(
    [role_id] => 1
    [role_name] => main
)
Sep 12 2019, 10:18 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-release, Multi-Content-Revisions (Reactive), MW-1.33-release, Patch-For-Review, MW-1.32-release, MediaWiki-General
MarkAHershberger added a comment to T224949: Failed to access name from slot_roles using id = 1.

Just ran into this on https://asyncwiki-moon.wmflabs.org/demo/index.php/Main_Page ... looking at the patch.

Sep 12 2019, 10:11 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (MCR), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-release, Multi-Content-Revisions (Reactive), MW-1.33-release, Patch-For-Review, MW-1.32-release, MediaWiki-General

Sep 5 2019

MarkAHershberger created T232112: PageForms: Without {{{for template}}} form submission silently fails.
Sep 5 2019, 3:21 PM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Sep 4 2019

MarkAHershberger added a comment to T231957: PageForms: Should allow user to submit a form if there are restricted mandantory fields without defaults that the user cannot fill.

Is it your view that people will never create a field tag on purpose
that has "mandatory" and "restricted", but no "default"?

Sep 4 2019, 4:03 PM · MediaWiki-extensions-Page_Forms
MarkAHershberger added a comment to T231958: PageForms: Hidden mandatory fields without defaults can keep the user from submitting the form without any error message.

I think this problem can be resolved by not doing error checking on
hidden fields. If they are hidden, the user hasn't had a chance to see
them.

Sep 4 2019, 3:32 PM · MediaWiki-extensions-Page_Forms
MarkAHershberger created T231958: PageForms: Hidden mandatory fields without defaults can keep the user from submitting the form without any error message.
Sep 4 2019, 1:36 AM · MediaWiki-extensions-Page_Forms
MarkAHershberger renamed T231957: PageForms: Should allow user to submit a form if there are restricted mandantory fields without defaults that the user cannot fill from PageForms: Allows mandantory fields without defaults that the user cannot fill in to PageForms: Should allow user to submit a form if there are restricted mandantory fields without defaults that the user cannot fill.
Sep 4 2019, 1:24 AM · MediaWiki-extensions-Page_Forms
MarkAHershberger created T231957: PageForms: Should allow user to submit a form if there are restricted mandantory fields without defaults that the user cannot fill.
Sep 4 2019, 1:22 AM · MediaWiki-extensions-Page_Forms

Sep 3 2019

MarkAHershberger added a comment to T137701: Fix default value for field tag, for existing and new pages..

The patch was submitted prematurely. I would like to refactor PF so that it is easier to find and fix bugs.

Sep 3 2019, 8:15 PM · MediaWiki-extensions-Page_Forms

Sep 2 2019

MarkAHershberger added a project to T231843: Document how to enable authentication against an OAuth source: MediaWiki-Authentication-and-authorization.
Sep 2 2019, 7:33 PM · MediaWiki-Authentication-and-authorization
MarkAHershberger created T231843: Document how to enable authentication against an OAuth source.
Sep 2 2019, 7:31 PM · MediaWiki-Authentication-and-authorization

Aug 30 2019

MarkAHershberger created T231665: PageForms: Drop support for PHP 5.3.
Aug 30 2019, 4:29 PM · MediaWiki-extensions-Page_Forms
MarkAHershberger added a comment to T231626: The table 'text' is full (db-local).

I am just checking my emails and got a few "table is full" emails from
the mysql before I saw these reports.

Aug 30 2019, 3:45 PM · WikiApiary

Aug 29 2019

MarkAHershberger added a comment to T137701: Fix default value for field tag, for existing and new pages..

I understand the concern regarding new defaults on old pages, but it is currently possible to create restricted fields that are required and have a default.

Aug 29 2019, 4:25 PM · MediaWiki-extensions-Page_Forms

Aug 13 2019

MarkAHershberger added a comment to T226857: Provide a Installer::addDBType() so DB types can be added via an extension.

So how that can be done?

Aug 13 2019, 9:31 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Installer

Aug 10 2019

MarkAHershberger created T230278: CLI interface needed for bot passwords.
Aug 10 2019, 7:52 PM · MediaWiki-General

Aug 7 2019

MarkAHershberger created T230029: getRawIP() results in "Unable to determine IP." when $_SERVER['REMOTE_ADDR'] contains a bracketed IPv6 address.
Aug 7 2019, 2:44 PM · MediaWiki-General

Aug 2 2019

MarkAHershberger closed T217960: Tarball upload automation, a subtask of T223392: Automate MediaWiki tarball release process, as Resolved.
Aug 2 2019, 5:10 PM · MediaWiki-Release-Tools, MediaWiki-Releasing (Workflow Improvements), Epic
MarkAHershberger closed T217960: Tarball upload automation as Resolved.

@mmodell has +1'd the change and we're looking for a way to merge it.

Aug 2 2019, 5:10 PM · CPT Initiatives (Release Automation (TEC1)), Patch-For-Review, Core Platform Team Workboards (Contractor Workboard), MediaWiki-Releasing (Workflow Improvements), MediaWiki-Release-Tools
MarkAHershberger closed T217840: Test tarball extraction and verify diffs apply cleanly, a subtask of T223392: Automate MediaWiki tarball release process, as Resolved.
Aug 2 2019, 5:09 PM · MediaWiki-Release-Tools, MediaWiki-Releasing (Workflow Improvements), Epic
MarkAHershberger closed T217840: Test tarball extraction and verify diffs apply cleanly as Resolved.

Since we're just using git to produce the diffs and diff production is automated based on the last release (even when the release is a .0 release), I think this is done.

Aug 2 2019, 5:09 PM · CPT Initiatives (Release Automation (TEC1)), Core Platform Team Workboards (Contractor Workboard), MediaWiki-Releasing (Workflow Improvements), MediaWiki-Release-Tools
MarkAHershberger closed T217961: Produce and document interface for kicking off a branch and tarball production, a subtask of T223392: Automate MediaWiki tarball release process, as Resolved.
Aug 2 2019, 5:08 PM · MediaWiki-Release-Tools, MediaWiki-Releasing (Workflow Improvements), Epic
MarkAHershberger closed T217961: Produce and document interface for kicking off a branch and tarball production as Resolved.
Aug 2 2019, 5:08 PM · CPT Initiatives (Release Automation (TEC1)), Core Platform Team Workboards (Contractor Workboard), MediaWiki-Releasing (Workflow Improvements), MediaWiki-Release-Tools
MarkAHershberger added a comment to T217961: Produce and document interface for kicking off a branch and tarball production.

Wrote the initial docs in a README, @mmodell said he would add to them and move the docs to the appropriate wiki place.

Aug 2 2019, 5:08 PM · CPT Initiatives (Release Automation (TEC1)), Core Platform Team Workboards (Contractor Workboard), MediaWiki-Releasing (Workflow Improvements), MediaWiki-Release-Tools
MarkAHershberger closed T217963: Ensure all repositories in Gerrit have been branched at the right time., a subtask of T217960: Tarball upload automation, as Resolved.
Aug 2 2019, 5:03 PM · CPT Initiatives (Release Automation (TEC1)), Patch-For-Review, Core Platform Team Workboards (Contractor Workboard), MediaWiki-Releasing (Workflow Improvements), MediaWiki-Release-Tools
MarkAHershberger closed T217963: Ensure all repositories in Gerrit have been branched at the right time. as Resolved.

I think using gerrit to branch server-side (as is done in the code), means that this is essentially resolved.

Aug 2 2019, 5:03 PM · CPT Initiatives (Release Automation (TEC1)), Core Platform Team Workboards (Contractor Workboard), MediaWiki-Releasing (Workflow Improvements), MediaWiki-Release-Tools

Jul 31 2019

MarkAHershberger removed a project from T532: Research Docker as a new format of distribution : MediaWiki-Stakeholders-Group.
Jul 31 2019, 12:39 AM · Wiki-Release-Team
MarkAHershberger moved T140068: Provide a mechanism for site admins to hide the "This is my own work" checkbox for third party wikis which don't care from Inbox to Needs Volunteer on the MediaWiki-Stakeholders-Group board.
Jul 31 2019, 12:38 AM · MediaWiki-Stakeholders-Group, MediaWiki-Uploading, Multimedia
MarkAHershberger added a comment to T140068: Provide a mechanism for site admins to hide the "This is my own work" checkbox for third party wikis which don't care.

This seems easy... Why hasn't anyone done this in the past three years?

Jul 31 2019, 12:38 AM · MediaWiki-Stakeholders-Group, MediaWiki-Uploading, Multimedia
MarkAHershberger closed T532: Research Docker as a new format of distribution as Resolved.
Jul 31 2019, 12:35 AM · Wiki-Release-Team
MarkAHershberger added a comment to T532: Research Docker as a new format of distribution .

This is done now since we have an official docker image https://hub.docker.com/_/mediawiki

Jul 31 2019, 12:35 AM · Wiki-Release-Team
MarkAHershberger renamed T117202: Prepare Technical Roadmap for MediaWiki Stakeholders' Group from Prepare Technical Roadmap for MediaWiki Stakeholders' Group to Prepare Technical Roadmap for MediaWiki Stakeholders.
Jul 31 2019, 12:26 AM · MediaWiki-Stakeholders-Group
MarkAHershberger added a comment to T117202: Prepare Technical Roadmap for MediaWiki Stakeholders' Group.

I would love to have someone else handle this

Jul 31 2019, 12:19 AM · MediaWiki-Stakeholders-Group
MarkAHershberger renamed T117202: Prepare Technical Roadmap for MediaWiki Stakeholders' Group from Prepare Technical Roadmap to Prepare Technical Roadmap for MediaWiki Stakehold.
Jul 31 2019, 12:19 AM · MediaWiki-Stakeholders-Group
MarkAHershberger closed T119345: Backup plan for extensions hosted in code.google.com as Resolved.

This ship has sailed and everything is done that can be done.

Jul 31 2019, 12:14 AM · MediaWiki-Stakeholders-Group
MarkAHershberger closed T122840: Send a MediaWiki rep to php[tek] conference as Invalid.

No time machine!

Jul 31 2019, 12:13 AM · MediaWiki-Stakeholders-Group
MarkAHershberger closed T122835: Send a MediaWiki rep to php[world] 2016 conference as Invalid.

We do not have a time machine.

Jul 31 2019, 12:12 AM · MediaWiki-Stakeholders-Group
MarkAHershberger added a comment to T155029: MediaWiki.org: Generate infoboxes from extension.json in git.

@Bawolff we'd like to keep this moving forward and know you've done a lot here. Could you point us to how the lua is generated on wiki?

Jul 31 2019, 12:08 AM · User-DannyS712, Tool-extjsonuploader, User-Tgr, MediaWiki-Stakeholders-Group, Developer-Wishlist (2017), MediaWiki-Documentation, Documentation

Jul 30 2019

MarkAHershberger added a comment to T194901: MediaWiki and GDPR.

Wikia said something on RIOT about having an extension for this that was published but probably not usable by others.

Jul 30 2019, 11:49 PM · MediaWiki-Stakeholders-Group, Wikimedia-Hackathon-2018
MarkAHershberger added a comment to T165270: Future of "Extension:LDAP Authentication".

Can we re-title this?

Jul 30 2019, 11:45 PM · MediaWiki-extensions-LdapAuthentication, MediaWiki-Stakeholders-Group, Wikimedia-Hackathon-2017
MarkAHershberger added a comment to T200375: Implement Pingback v2.

I would love to get WikiApiary support built in and make whatever changes we need to support.

Jul 30 2019, 11:33 PM · MediaWiki-Stakeholders-Group, MediaWiki-General
MarkAHershberger created T229370: Disable hhvm/php5.x (composer-hhvm-docker) tests for release-tools.
Jul 30 2019, 8:35 PM · Patch-For-Review, Continuous-Integration-Config, MediaWiki-Release-Tools
MarkAHershberger added a comment to T229349: InviteSignup does not give provide UserGroupMembership::getGroupMemberName() with a $user parameter.

Found via Suppport Desk.

Jul 30 2019, 4:06 PM · Patch-For-Review, MediaWiki-extensions-Other
MarkAHershberger updated subscribers of T229349: InviteSignup does not give provide UserGroupMembership::getGroupMemberName() with a $user parameter.
Jul 30 2019, 4:04 PM · Patch-For-Review, MediaWiki-extensions-Other
MarkAHershberger created T229349: InviteSignup does not give provide UserGroupMembership::getGroupMemberName() with a $user parameter.
Jul 30 2019, 4:00 PM · Patch-For-Review, MediaWiki-extensions-Other

Jul 28 2019

MarkAHershberger triaged T229043: Session information lost when accessing the wiki from external Url but works when directly access the internal wiki url as Low priority.
Jul 28 2019, 10:27 PM · MediaWiki-Configuration
MarkAHershberger added a comment to T229043: Session information lost when accessing the wiki from external Url but works when directly access the internal wiki url.

If you are using only one LocalSettings.php, then you'll need to check the HTTP headers when someone visits to see which site they're going to and set $wgServer according to that.

Jul 28 2019, 9:41 PM · MediaWiki-Configuration
MarkAHershberger edited projects for T229043: Session information lost when accessing the wiki from external Url but works when directly access the internal wiki url, added: MediaWiki-Configuration; removed MediaWiki-extensions-SimpleSAMLphp, MediaWiki-Authentication-and-authorization.
Jul 28 2019, 9:20 PM · MediaWiki-Configuration
MarkAHershberger added a comment to T229043: Session information lost when accessing the wiki from external Url but works when directly access the internal wiki url.

Are you trying to use one LocalSettings.php to serve the same wiki from two different domains?

Jul 28 2019, 7:47 PM · MediaWiki-Configuration
MarkAHershberger added a comment to T229043: Session information lost when accessing the wiki from external Url but works when directly access the internal wiki url.

Defined the wiki.internal.domain.com as relative url in $wgServer in LocalSettings.php file. also IdP reply url configured as wiki.internal.domain.com

Jul 28 2019, 5:53 PM · MediaWiki-Configuration

Jul 27 2019

MarkAHershberger committed rESRD869656884d44: Creating new REL1_24 branch (authored by MarkAHershberger).
Creating new REL1_24 branch
Jul 27 2019, 11:19 PM
MarkAHershberger added a comment to T229043: Session information lost when accessing the wiki from external Url but works when directly access the internal wiki url.
  • I went and looked at the old SAMLAuth page and saw that it does not provide anywhere to provide a redirect url.
  • I see that in your working config and notworking config files for SimpleSAMLphp, the redirect.trustedsites configuration is NULL or an empty list.
Jul 27 2019, 10:35 PM · MediaWiki-Configuration
MarkAHershberger added a comment to T229043: Session information lost when accessing the wiki from external Url but works when directly access the internal wiki url.

...we have hosted the website in Azure (Azure App Service) (wiki.domain.com) and the same website is configured with Custom domain url (internal domain in my reference - wiki.internal.domain.com). So when user access the Azure Domain Url (wiki.domain.com) and after authentication they will landed/redirected to wiki.internal.domain.com.

Jul 27 2019, 9:12 PM · MediaWiki-Configuration

Jul 21 2019

MarkAHershberger added a comment to T216805: [PageForms] Loading form input JS libraries (like datepicker) fix doesn't work.

This needs a better fix.

Jul 21 2019, 2:42 AM · Patch-For-Review, MediaWiki-extensions-Page_Forms

Jul 20 2019

MarkAHershberger added a comment to T226199: Move DataAfterContent into its own block in the main column.

If anyone here has wants to contribute code to the SMW project, but hesitates because of SMW is not governed by the WMF's CoC, I will work with them to privately contribute their code with or without attribution, whichever is preferred. I voluntarily place my collaboration in this mode under the WMF's CoC and any arbitration there.

Jul 20 2019, 1:02 AM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MonoBook, Vector

Jul 17 2019

MarkAHershberger added a comment to T226199: Move DataAfterContent into its own block in the main column.

[1] A codesearch across Wikimedia didn't show any results for dataAfterContent so it was not clear that https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/518095/1/includes/templates/index.mustache would impact SemanticMediaWiki.

Jul 17 2019, 8:11 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MonoBook, Vector
MarkAHershberger added a comment to T226199: Move DataAfterContent into its own block in the main column.

What is the downside of fixing SemanticWiki usage retroactively using one of the more skin-agnostic ways like @Legoktm proposes? Is help needed here?

Jul 17 2019, 7:49 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MonoBook, Vector
MarkAHershberger added a comment to T227599: Review 1.33.1 tarball.

From meeting:

  • Write documentation
  • Mukunda reviews code
  • See what the issue is with composer
    • Mark ran composer because he read reports on Support Desk about missing composer libs. Were they actually missing?
    • If it is an issue, how should problems like this be resolved?
Jul 17 2019, 7:22 PM · MediaWiki-Releasing
MarkAHershberger added a comment to T226199: Move DataAfterContent into its own block in the main column.

Copying this comment of mine from code review because I think this is a clear summary of my argument:

Jul 17 2019, 3:22 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MonoBook, Vector
MarkAHershberger added a comment to T226199: Move DataAfterContent into its own block in the main column.

The intention of this change was to standardize how all skins display content using the SkinAfterContent hook (that is, moving it explicitly after the content area, as the name implies). I think we all agree that long-term the skin standardization that @Isarra, @Jdlrobson, and others are working on is a good thing, yes?

Jul 17 2019, 2:50 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MonoBook, Vector

Jul 16 2019

MarkAHershberger added a comment to T226199: Move DataAfterContent into its own block in the main column.

If so, I think we should be looking for ways to move forward rather than an attitude of "don't change stuff ever, because it might break things".

Jul 16 2019, 4:54 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MonoBook, Vector
MarkAHershberger added a comment to T226199: Move DataAfterContent into its own block in the main column.

this extension should be using a parser hook, as Cite does.

Jul 16 2019, 3:48 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MonoBook, Vector

Jul 14 2019

MarkAHershberger added a comment to T226199: Move DataAfterContent into its own block in the main column.

This changed causes layout problems with SMW: "Move DataAfterContent outside of main content block" breaks Factbox display.

Jul 14 2019, 8:09 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MonoBook, Vector

Jul 12 2019

MarkAHershberger added a comment to T227662: Update.php failure when upgrading from 1.32.1 to 1.33.

Maybe migrateComments.php could check the table schema and change it if needed?

Jul 12 2019, 7:10 PM · MW-1.33-notes, MW-1.32-notes, MW-1.31-release-notes, MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Installer
MarkAHershberger added a comment to T227662: Update.php failure when upgrading from 1.32.1 to 1.33.

Since this has happened to two separate people, it seems likely that there are a number of other people experiencing the same problem that we don't know about.

Jul 12 2019, 7:08 PM · MW-1.33-notes, MW-1.32-notes, MW-1.31-release-notes, MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Installer
MarkAHershberger added a comment to T227159: Enable sandbox branches in gerrit.
mah@silk:~/work/code/mediawiki$ git clone ssh://gerrit.wikimedia.org:29418/test/gerrit-ping test-gerrit-repo
Cloning into 'test-gerrit-repo'...
remote: Counting objects: 2, done
remote: Finding sources: 100% (1/1)
Receiving objects: 100% (5/5), done.
remote: Total 5 (delta 0), reused 5 (delta 0)
mah@silk:~/work/code/mediawiki$ cd test-gerrit-repo/
mah@silk:~/work/code/mediawiki/test-gerrit-repo$ git checkout -b sandbox/hashar/testcreation
Switched to a new branch 'sandbox/hashar/testcreation'
mah@silk:~/work/code/mediawiki/test-gerrit-repo$ git push origin sandbox/hashar/testcreation
Total 0 (delta 0), reused 0 (delta 0)
remote: Processing changes: refs: 1, done    
To ssh://gerrit.wikimedia.org:29418/test/gerrit-ping
 ! [remote rejected] sandbox/hashar/testcreation -> sandbox/hashar/testcreation (prohibited by Gerrit: create not permitted for refs/heads/sandbox/hashar/testcreation)
error: failed to push some refs to 'ssh://gerrit.wikimedia.org:29418/test/gerrit-ping'
mah@silk:~/work/code/mediawiki/test-gerrit-repo$ git checkout -b sandbox/mah/testcreation
Switched to a new branch 'sandbox/mah/testcreation'
mah@silk:~/work/code/mediawiki/test-gerrit-repo$ git push origin sandbox/mah/testcreation
Total 0 (delta 0), reused 0 (delta 0)
remote: Processing changes: done    
To ssh://gerrit.wikimedia.org:29418/test/gerrit-ping
 * [new branch]      sandbox/mah/testcreation -> sandbox/mah/testcreation
mah@silk:~/work/code/mediawiki/test-gerrit-repo$ git push --delete origin sandbox/mah/testcreation
remote: Processing changes: done    
To ssh://gerrit.wikimedia.org:29418/test/gerrit-ping
 - [deleted]         sandbox/mah/testcreation
Jul 12 2019, 3:17 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (201907), Gerrit
MarkAHershberger added a comment to T191231: RFC: Abstract schemas and schema changes.

In any case, splitting DBMS out of core is an absolute non-starter until the installer can make use of them somehow without LocalSettings.php existing. Once that happens and is well-supported rather than an afterthought, I’d be happy to re-evaluate moving less-supported DBMS into extensions or whatever system is devised for that.

Jul 12 2019, 1:53 AM · CPT Initiatives (Abstract Schema), TechCom-RFC (TechCom-Approved), MediaWiki-Installer, Patch-For-Review, User-Addshore, SQLite, Oracle Database, MSSQL, PostgreSQL, Epic

Jul 11 2019

MarkAHershberger reopened T200468: Percona XtraDB Cluster gives error when using GET_LOCK() when pxc_strict_mode=ENFORCING is set (e.g. By ApiStashEdit.php) as "Open".

As the task stood, you did not misunderstand. However, since creating it, I've been working on doing the DB support as a pure extension which I hope to move to Gerrit soon. That is where this task should be targeted.

Jul 11 2019, 11:32 PM · MediaWiki-extensions-General
MarkAHershberger created T227832: Improvements to HTTPFileStreamer::preprocessHeaders().
Jul 11 2019, 11:09 PM · MediaWiki-General
MarkAHershberger created T227729: Can't log into gerrit.git.wmflabs.org with account from ldapauth-gitldap.wmflabs.org.
Jul 11 2019, 1:40 AM · VPS-Projects

Jul 10 2019

MarkAHershberger added a comment to T227159: Enable sandbox branches in gerrit.

rejected...

$ git clone ssh://gerrit.wikimedia.org:29418/test/gerrit-ping test-gerrit-repo
Cloning into 'test-gerrit-repo'...
remote: Counting objects: 2, done        
remote: Finding sources: 100% (1/1)        
Receiving objects: 100% (5/5), done.
remote: Total 5 (delta 0), reused 5 (delta 0)        
$ cd test-gerrit-repo/
$ git checkout -b sandbox/hashar/testcreation
Switched to a new branch 'sandbox/hashar/testcreation'
$ git push origin sandbox/hashar/testcreation
Total 0 (delta 0), reused 0 (delta 0)
remote: Processing changes: refs: 1, done            
To ssh://gerrit.wikimedia.org:29418/test/gerrit-ping
 ! [remote rejected] sandbox/hashar/testcreation -> sandbox/hashar/testcreation (prohibited by Gerrit: create not permitted for refs/heads/sandbox/hashar/testcreation)
error: failed to push some refs to 'ssh://gerrit.wikimedia.org:29418/test/gerrit-ping'
Jul 10 2019, 7:26 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (201907), Gerrit
MarkAHershberger added a comment to T213893: Allow extensions to define additional command line parameters to "update.php".

I note that this introduced php 7 syntax into the update.php script.
This means that if you use php56 and try to run update.php and accidentally you use php56 as a command line default etc. the version check for php won't help you in giving useful feedback as you will receive a syntax error.

Jul 10 2019, 4:04 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Patch-For-Review, Core Platform Team Workboards (Done with CPT), Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), User-Nikerabbit, MediaWiki-Installer

Jul 9 2019

MarkAHershberger created T227599: Review 1.33.1 tarball.
Jul 9 2019, 5:53 PM · MediaWiki-Releasing
MarkAHershberger added a comment to T227159: Enable sandbox branches in gerrit.

@MarkAHershberger i had to create the account manually using createAndPromote.php, i've sent the details through email for logging in.

Jul 9 2019, 3:54 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (201907), Gerrit
MarkAHershberger added a comment to T227159: Enable sandbox branches in gerrit.

Ah indeed. So All-Projects.git has:

[access "refs/heads/sandbox/${username}/*"]
    create = group Registered Users
    push = group Registered Users
    pushMerge = group Registered Users

Which apparently mean that any registered user can create a branch anywhere under refs/heads/sandbox/. So tentatively @Hexmode might be able to create a branch under my sandbox (ex: refs/heads/sandbox/hashar/hexmode).

Jul 9 2019, 3:52 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (201907), Gerrit

Jul 8 2019

MarkAHershberger added a comment to T217960: Tarball upload automation.

Need to get all this off github, but here is the publish target and here are the 1.33.1 artifacts this produces.

Jul 8 2019, 4:27 AM · CPT Initiatives (Release Automation (TEC1)), Patch-For-Review, Core Platform Team Workboards (Contractor Workboard), MediaWiki-Releasing (Workflow Improvements), MediaWiki-Release-Tools

Jul 6 2019

MarkAHershberger updated the task description for T227370: Remove MW Core REL1_34 branch.
Jul 6 2019, 2:11 AM · Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Gerrit
MarkAHershberger added projects to T227370: Remove MW Core REL1_34 branch: Gerrit, Release-Engineering-Team.
Jul 6 2019, 2:08 AM · Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Gerrit
MarkAHershberger created T227370: Remove MW Core REL1_34 branch.
Jul 6 2019, 2:07 AM · Release-Engineering-Team-TODO (201907), Release-Engineering-Team (Development services), Gerrit

Jul 3 2019

MarkAHershberger added a comment to T227159: Enable sandbox branches in gerrit.

Now, an xdebug dump:

Notice: Trying to get property 'status' of non-object in /vagrant/mediawiki/includes/auth/AuthManager.php on line 1347

and several complaints about headers already being sent (natch).

Jul 3 2019, 6:19 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (201907), Gerrit
MarkAHershberger added a comment to T227159: Enable sandbox branches in gerrit.

I got ⧼authmanager-authplugin-create-fail⧽ when I tried to create an account.

Jul 3 2019, 6:07 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (201907), Gerrit
MarkAHershberger updated the task description for T227159: Enable sandbox branches in gerrit.
Jul 3 2019, 4:32 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (201907), Gerrit
MarkAHershberger reopened T227159: Enable sandbox branches in gerrit as "Open".

I understand the limited usefulness for development.

Jul 3 2019, 4:31 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (201907), Gerrit
MarkAHershberger updated the task description for T227157: Use copy if symlink fails.
Jul 3 2019, 2:31 AM · Patch-For-Review, MediaWiki-General
MarkAHershberger created T227159: Enable sandbox branches in gerrit.
Jul 3 2019, 2:28 AM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (201907), Gerrit
MarkAHershberger created T227157: Use copy if symlink fails.
Jul 3 2019, 1:14 AM · Patch-For-Review, MediaWiki-General

Jul 2 2019

MarkAHershberger awarded T227147: Can't upgrade MW installs to MW1.33 if using a non-standard DB prefix a Like token.
Jul 2 2019, 9:21 PM · MW-1.33-notes, MW-1.33-release, Wikimedia-Rdbms

Jul 1 2019

MarkAHershberger added a comment to T226946: Remove MW Core REL1_44 branch.

I was about to create a bug asking that this be removed.

Jul 1 2019, 1:11 AM · Release-Engineering-Team, Gerrit

Jun 29 2019

MarkAHershberger added a comment to T191231: RFC: Abstract schemas and schema changes.

This is one of things this RFC can look into and move away MSSQL and other propriety databases to extensions and leave it to people who wants to maintain it.

Jun 29 2019, 8:56 PM · CPT Initiatives (Abstract Schema), TechCom-RFC (TechCom-Approved), MediaWiki-Installer, Patch-For-Review, User-Addshore, SQLite, Oracle Database, MSSQL, PostgreSQL, Epic

Jun 28 2019

MarkAHershberger created T226857: Provide a Installer::addDBType() so DB types can be added via an extension.
Jun 28 2019, 6:58 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Installer

Jun 27 2019

MarkAHershberger added a comment to T226766: Avoid explicit commit references in composer.json in code meant for public consumption.

This was first noticed when a TravisCI job failed with

+php maintenance/install.php --dbtype mysql --dbuser root --dbname its_a_mw --dbpath /home/travis/build/SemanticMediaWiki/mw --pass nyan TravisWiki admin --scriptpath /TravisWiki
PHP Warning:  require(/home/travis/build/SemanticMediaWiki/mw/vendor/composer/../jetbrains/phpstorm-stubs/PhpStormStubsMap.php): failed to open stream: No such file or directory in /home/travis/build/SemanticMediaWiki/mw/vendor/composer/autoload_real.php on line 66
Warning: require(/home/travis/build/SemanticMediaWiki/mw/vendor/composer/../jetbrains/phpstorm-stubs/PhpStormStubsMap.php): failed to open stream: No such file or directory in /home/travis/build/SemanticMediaWiki/mw/vendor/composer/autoload_real.php on line 66
PHP Fatal error:  require(): Failed opening required '/home/travis/build/SemanticMediaWiki/mw/vendor/composer/../jetbrains/phpstorm-stubs/PhpStormStubsMap.php' (include_path='.:/home/travis/.phpenv/versions/7.1.11/share/pear') in /home/travis/build/SemanticMediaWiki/mw/vendor/composer/autoload_real.php on line 66
Fatal error: require(): Failed opening required '/home/travis/build/SemanticMediaWiki/mw/vendor/composer/../jetbrains/phpstorm-stubs/PhpStormStubsMap.php' (include_path='.:/home/travis/.phpenv/versions/7.1.11/share/pear') in /home/travis/build/SemanticMediaWiki/mw/vendor/composer/autoload_real.php on line 66
Jun 27 2019, 7:47 PM · MW-1.32-notes, MW-1.31-release-notes, MW-1.32-release, MW-1.31-release, Composer, MediaWiki-General
MarkAHershberger added a comment to T107875: Use InnoDB engine for searchindex table in MySQL.

For those interested in query differences between MyISAM and InnoDB fulltext queries, see this post on Percona's site.

Jun 27 2019, 2:10 AM · MediaWiki-Installer, Patch-For-Review, MediaWiki-Search
MarkAHershberger added a comment to T107875: Use InnoDB engine for searchindex table in MySQL.

I'm proposing changing this to innodb and bumping MediaWiki's minimum version supported of MySQL to 5.6.10 as a result.

Jun 27 2019, 2:07 AM · MediaWiki-Installer, Patch-For-Review, MediaWiki-Search

Jun 17 2019

MarkAHershberger added a comment to T224954: Update the Semantic Mediawiki version on WikiApiary.

Thanks for the hints. I am trying to make sure I do this the right way on another largish wiki and will have time to work on WikiApiary in a few.

Jun 17 2019, 10:49 PM · WikiApiary