Page MenuHomePhabricator

MarkAHershberger (Mark A. Hershberger)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 25 2014, 3:45 PM (365 w, 2 d)
Availability
Available
LDAP User
MarkAHershberger
MediaWiki User
MarkAHershberger [ Global Accounts ]

Recent Activity

Aug 16 2021

MarkAHershberger added a comment to T288920: Add nonwmf-extensions repository.

I'm not sure what this is taking about. Which uploader tool?

Aug 16 2021, 3:39 PM · MediaWiki-Stakeholders-Group, Tool-extjsonuploader

Aug 12 2021

MarkAHershberger added a comment to T258860: LogicException: Process cache for 'en' should be set by now.

Trying to upgrade a wiki to 1.35 and seeing it consistently in AbuseFilter:

...afl_patrolled_by in table abuse_filter_log already modified by patch …/extensions/AbuseFilter/db_patches/patch-afl_change_deleted_patrolled.sql.
LogicException from line 406 of .../includes/cache/MessageCache.php: Process cache for 'en' should be set by now.
#0 .../includes/cache/MessageCache.php(1108): MessageCache->load('en')
#1 .../includes/cache/MessageCache.php(1034): MessageCache->getMsgFromNamespace('Abusefilter-blo...', 'en')
#2 .../includes/cache/MessageCache.php(1005): MessageCache->getMessageForLang(Object(LanguageEn), 'abusefilter-blo...', true, Array)
#3 .../includes/cache/MessageCache.php(947): MessageCache->getMessageFromFallbackChain(Object(LanguageEn), 'abusefilter-blo...', true)
#4 .../includes/language/Message.php(1304): MessageCache->get('abusefilter-blo...', true, Object(LanguageEn))
#5 .../includes/language/Message.php(862): Message->fetchMessage()
#6 .../includes/language/Message.php(954): Message->toString('text')
#7 …/extensions/AbuseFilter/includes/AbuseFilterHooks.php(658): Message->text()
#8 .../includes/installer/DatabaseUpdater.php(554): AbuseFilterHooks::createAbuseFilterUser(Object(MysqlUpdater))
#9 .../includes/installer/DatabaseUpdater.php(522): DatabaseUpdater->runUpdates(Array, true)
#10 .../maintenance/update.php(181): DatabaseUpdater->doUpdates(Array)
#11 .../maintenance/doMaintenance.php(107): UpdateMediaWiki->execute()
#12 .../maintenance/update.php(253): require_once('....')
#13 {main}
Aug 12 2021, 9:57 PM · Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error, MW-1.35-release, Discovery-Search, MediaWiki-Cache, affects-translatewiki.net

Aug 10 2021

MarkAHershberger closed T288412: ApprovedRevs in-memory cache needs accessors to clear it during long runs as Resolved.
Aug 10 2021, 8:07 PM · Patch-For-Review, MediaWiki-extensions-Approved-Revs

Aug 8 2021

MarkAHershberger updated subscribers of T288412: ApprovedRevs in-memory cache needs accessors to clear it during long runs.
Aug 8 2021, 5:34 PM · Patch-For-Review, MediaWiki-extensions-Approved-Revs
MarkAHershberger created T288412: ApprovedRevs in-memory cache needs accessors to clear it during long runs.
Aug 8 2021, 5:33 PM · Patch-For-Review, MediaWiki-extensions-Approved-Revs

Jul 24 2021

MarkAHershberger added a comment to T284176: Page Forms: Initially-hidden tokens input doesn't show placeholder text.

https://github.com/select2/select2/pull/6071

Jul 24 2021, 1:43 AM · MediaWiki-extensions-Page_Forms

Jul 5 2021

MarkAHershberger added a comment to T280875: rules.attributes does not work for multi-valued attribute results.

@MarkAHershberger What do you think. Does it match your expectation this way?

Jul 5 2021, 2:50 PM · Patch-For-Review, LDAP-Extensions, MediaWiki-extensions-LDAPAuthorization
MarkAHershberger added a comment to T280875: rules.attributes does not work for multi-valued attribute results.

I think this change deviates from the LDAP standard.

Jul 5 2021, 2:23 PM · Patch-For-Review, LDAP-Extensions, MediaWiki-extensions-LDAPAuthorization

Jun 30 2021

MarkAHershberger committed rECOS9258bbf1198f: Fix next and previous links on Special:AllComments (authored by cicalese).
Fix next and previous links on Special:AllComments
Jun 30 2021, 12:30 PM

Jun 24 2021

MarkAHershberger updated subscribers of T201169: Migrating to MediaWiki from another high-profile content management system should be a pleasant experience.

I believe @Osnard did some work on Confluence that would be helpful here.

Jun 24 2021, 3:51 PM · Documentation, MediaWiki-Stakeholders-Group, MediaWiki-General

Jun 21 2021

MarkAHershberger added a comment to T283604: Make Lingo compatible with MediaWiki 1.35: TitleMoveComplete hook; Undefined index parserhook; Invalid argument supplied for foreach().

See also: https://github.com/SemanticMediaWiki/SemanticGlossary/pull/59

Jun 21 2021, 6:24 PM · Patch-For-Review, Technical-Debt, MediaWiki-extensions-Lingo
MarkAHershberger added a comment to T283604: Make Lingo compatible with MediaWiki 1.35: TitleMoveComplete hook; Undefined index parserhook; Invalid argument supplied for foreach().

btw, I'm thinking the E_NOTICE on the Special:Version page has something to do with SMW Glossary and Lingo's interaction. But I haven't tested this yet.

Jun 21 2021, 4:16 PM · Patch-For-Review, Technical-Debt, MediaWiki-extensions-Lingo
MarkAHershberger added a comment to T283604: Make Lingo compatible with MediaWiki 1.35: TitleMoveComplete hook; Undefined index parserhook; Invalid argument supplied for foreach().

Added a patch for the notice

Jun 21 2021, 4:13 PM · Patch-For-Review, Technical-Debt, MediaWiki-extensions-Lingo

Jun 16 2021

MarkAHershberger added a comment to T197234: Expected mass rollback of all peer transactions (DBO_TRX set).
Jun 16 2021, 1:53 PM · Growth-Team-Filtering, Wikimedia-database-error, Growth-Team, StructuredDiscussions
MarkAHershberger added a comment to T197234: Expected mass rollback of all peer transactions (DBO_TRX set).

Just saw this in some new transaction handling I added for the SMW extension. The logic I added looks similar to @Tgr's example from Flow.

Jun 16 2021, 1:44 PM · Growth-Team-Filtering, Wikimedia-database-error, Growth-Team, StructuredDiscussions

Jun 10 2021

MarkAHershberger updated the task description for T284754: ContextMenu endpoint missing in Jenkins.
Jun 10 2021, 3:14 PM · Continuous-Integration-Infrastructure, Jenkins
MarkAHershberger created T284754: ContextMenu endpoint missing in Jenkins.
Jun 10 2021, 3:12 PM · Continuous-Integration-Infrastructure, Jenkins
MarkAHershberger added a comment to T273261: Premature access to service container.

Switch your test from MediaWikiUnitTestCase to MediaWikiIntegrationTestCase

... and move it out of the unit subdirectory.

Jun 10 2021, 2:20 PM · GoogleLogin, ci-test-error, User-ArielGlenn, Platform Team Workboards (Clinic Duty Team), MediaWiki-General
MarkAHershberger added a comment to T273261: Premature access to service container.
Jun 10 2021, 1:57 PM · GoogleLogin, ci-test-error, User-ArielGlenn, Platform Team Workboards (Clinic Duty Team), MediaWiki-General
MarkAHershberger added a comment to T273261: Premature access to service container.

Just got this here. I know I'm not supposed to use $wgTitle, but I'm not sure what to do here. Pointers would be helpful.

Jun 10 2021, 2:54 AM · GoogleLogin, ci-test-error, User-ArielGlenn, Platform Team Workboards (Clinic Duty Team), MediaWiki-General

Jun 7 2021

MarkAHershberger created T284453: LDAPProvider/LDAPAuthentation2: Multiple uids in a user record cause error.
Jun 7 2021, 2:01 PM · LDAP-Extensions

Jun 2 2021

MarkAHershberger renamed T284176: Page Forms: Initially-hidden tokens input doesn't show placeholder text from PageForms: to PageForms: Token input doesn't show hidden placeholder text.
Jun 2 2021, 7:39 PM · MediaWiki-extensions-Page_Forms
MarkAHershberger created T284176: Page Forms: Initially-hidden tokens input doesn't show placeholder text.
Jun 2 2021, 6:40 PM · MediaWiki-extensions-Page_Forms

Jun 1 2021

MarkAHershberger added a comment to T40432: Uploading MS Word files doesn't work ("File extension does not match the detected MIME type of the file").

Un-assigning myself. @freephile, since you are the most recent to comment an the issue, can you tell us what issues, if any, still remain in REL1_36?

Jun 1 2021, 2:06 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Multimedia, MediaWiki-Uploading
MarkAHershberger placed T40432: Uploading MS Word files doesn't work ("File extension does not match the detected MIME type of the file") up for grabs.
Jun 1 2021, 2:03 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Multimedia, MediaWiki-Uploading

May 21 2021

MarkAHershberger updated the task description for T283387: transformFilePath complains when $wgLogo points to a dynamic url.
May 21 2021, 8:29 PM · MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), Performance-Team, MediaWiki-ResourceLoader
MarkAHershberger closed T283387: transformFilePath complains when $wgLogo points to a dynamic url as Resolved.
May 21 2021, 7:44 PM · MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), Performance-Team, MediaWiki-ResourceLoader
MarkAHershberger created T283387: transformFilePath complains when $wgLogo points to a dynamic url.
May 21 2021, 5:59 PM · MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), Performance-Team, MediaWiki-ResourceLoader

May 18 2021

MarkAHershberger committed rEWTLf64d62d6bf43: Put the log entries for wikitoldap on the wikitoldap page (authored by MarkAHershberger).
Put the log entries for wikitoldap on the wikitoldap page
May 18 2021, 5:41 PM

May 9 2021

MarkAHershberger created T282345: PluggableAuthPrimaryAuthenticationProvider::testUserExists() always returns false.
May 9 2021, 2:31 AM · MediaWiki-extensions-Pluggable-Auth

Apr 11 2021

MarkAHershberger closed T279865: failure for PluggableAuth plugin does not necessarily mean failed login as Resolved.

I had a :void return type on my plugin's authenticate() method before. Changing it to :bool and setting $error every time it returned false seems to have worked.

Apr 11 2021, 6:12 PM · MediaWiki-extensions-Pluggable-Auth
MarkAHershberger added a comment to T279865: failure for PluggableAuth plugin does not necessarily mean failed login.

To answer my own question about a magical isLoggedIn() call, I've verified that the $user is not logged in when the requests is made. In fact looking at the requests made, I can see that the user is getting re-verified by the SSO provider. So the problem looks like it is (just?) that my provider does not return true.

Apr 11 2021, 5:58 PM · MediaWiki-extensions-Pluggable-Auth
MarkAHershberger added a comment to T279865: failure for PluggableAuth plugin does not necessarily mean failed login.

I am able to duplicate this problem by simply deleting the session cookie. The username and userid cookies are left intact.

Apr 11 2021, 5:25 PM · MediaWiki-extensions-Pluggable-Auth
MarkAHershberger updated subscribers of T279865: failure for PluggableAuth plugin does not necessarily mean failed login.

Note that the code to userlogin-logged only displays it when the user object isLoggedIn().

Apr 11 2021, 5:18 PM · MediaWiki-extensions-Pluggable-Auth
MarkAHershberger created T279865: failure for PluggableAuth plugin does not necessarily mean failed login.
Apr 11 2021, 5:04 PM · MediaWiki-extensions-Pluggable-Auth

Apr 9 2021

MarkAHershberger committed rELDQacf7b41f09ba: Throw more catch-able ConfigException instead of MWException (authored by MarkAHershberger).
Throw more catch-able ConfigException instead of MWException
Apr 9 2021, 8:08 PM

Apr 5 2021

MarkAHershberger committed rEWTL41ed3ee20382: ucFirst for username creation always (authored by MarkAHershberger).
ucFirst for username creation always
Apr 5 2021, 9:10 PM

Apr 2 2021

MarkAHershberger created T279202: Confusing errors are emitted by Phan when when AdminLinks is not installed in parallel.
Apr 2 2021, 8:33 PM · MediaWiki-extensions-ReplaceText
MarkAHershberger added a comment to T279027: LDAPAuthorization (LDAP Stack) denies access immediately but allows access only periodically.

You can address this by telling the user to clear their cookies. or by setting $LDAPProviderCacheTime to a lower value.

Apr 2 2021, 3:22 PM · MediaWiki-extensions-LDAPAuthorization
MarkAHershberger created T279148: ReplaceText produces PHP warnings because it does not check $matches.
Apr 2 2021, 2:38 PM · MediaWiki-extensions-ReplaceText

Mar 25 2021

MarkAHershberger committed rELDR51b24daa0a1a: Clean up dotfiles (authored by MarkAHershberger).
Clean up dotfiles
Mar 25 2021, 12:17 AM

Mar 24 2021

MarkAHershberger committed rELDR0097b00fef27: Clean up dotfiles (authored by MarkAHershberger).
Clean up dotfiles
Mar 24 2021, 11:14 PM

Mar 17 2021

MarkAHershberger created T277684: 2017 Wikitext editor is confused by long lines.
Mar 17 2021, 6:01 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
MarkAHershberger created T277683: VE preview of changes is confused after switching from section editing using NWE.
Mar 17 2021, 5:53 PM · Editing-team, VisualEditor

Mar 1 2021

MarkAHershberger added a comment to T270228: "Error: Unsupported operand types" from ParserOptionsTest::testMatches on php74.

Thanks for calling out the problem with Ubuntu 20.04, @tstarling. We just had someone come into the MediaWiki-Stakeholders-Group channel talking about this issue for 1.35 this morning, so this is a nice bit of serendipity.

Mar 1 2021, 4:03 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), MW-1.35-notes, MW-1.36-release, Platform Team Workboards (Clinic Duty Team), ci-test-error, MediaWiki-Parser

Feb 23 2021

MarkAHershberger added a comment to T251174: ApprovedRevs: special page's orderBy clause orders by fields not in the select.

Just ran into this again. This is not a percona problem, but an incompatibility with mysql 5.7.

Feb 23 2021, 2:57 AM · Patch-For-Review, MediaWiki-extensions-Approved-Revs

Feb 22 2021

MarkAHershberger created T275419: Method visibililty does not match parent class for special page.
Feb 22 2021, 6:25 PM · Patch-For-Review, MediaWiki-extensions-Approved-Revs

Feb 8 2021

Kghbln awarded T158026: Make responsive image maps possible in ImageMap extension a Like token.
Feb 8 2021, 5:02 PM · ImageMap

Jan 30 2021

Rudloff awarded T250406: RFC: Hybrid extension management a Like token.
Jan 30 2021, 11:18 AM · MediaWiki-Configuration, MediaWiki-Stakeholders-Group, TechCom-RFC

Jan 22 2021

MarkAHershberger added a project to T272659: TemporaryPasswordPrimaryAuthenticationProvider does not use the language that the request was created in: MediaWiki-Authentication-and-authorization.
Jan 22 2021, 1:57 AM · MediaWiki-Authentication-and-authorization

Jan 18 2021

MarkAHershberger committed rELDBde03809c9ef6: Allow maybeLocalLogin() to change the username. (authored by MarkAHershberger).
Allow maybeLocalLogin() to change the username.
Jan 18 2021, 10:55 PM

Jan 8 2021

MarkAHershberger updated the task description for T250406: RFC: Hybrid extension management.
Jan 8 2021, 6:19 PM · MediaWiki-Configuration, MediaWiki-Stakeholders-Group, TechCom-RFC
MarkAHershberger added a comment to T250406: RFC: Hybrid extension management.

I've updated the description to remove the requirements that would increase the workload for the WMF. Hopefully this will mean it can be fully implemented.

Jan 8 2021, 6:15 PM · MediaWiki-Configuration, MediaWiki-Stakeholders-Group, TechCom-RFC
MarkAHershberger updated the task description for T250406: RFC: Hybrid extension management.
Jan 8 2021, 6:14 PM · MediaWiki-Configuration, MediaWiki-Stakeholders-Group, TechCom-RFC

Jan 7 2021

MarkAHershberger committed rELDB62229d1aa4f8: Refactor individual local/ldap checking bits into protected methods (authored by MarkAHershberger).
Refactor individual local/ldap checking bits into protected methods
Jan 7 2021, 3:21 PM
MarkAHershberger committed rELDBfce09f433333: Reduce code duplication by creating a protected getAuthManager() (authored by MarkAHershberger).
Reduce code duplication by creating a protected getAuthManager()
Jan 7 2021, 3:21 PM
MarkAHershberger committed rELDB3139b8cb8951: Ensure that $id is populated for all existing users (authored by MarkAHershberger).
Ensure that $id is populated for all existing users
Jan 7 2021, 2:51 PM

Jan 6 2021

MarkAHershberger committed rELDQ59a76d8b0c40: Add phan and fix the problems it found (authored by MarkAHershberger).
Add phan and fix the problems it found
Jan 6 2021, 7:35 PM
MarkAHershberger committed rELDQ9e3723dad13f: Remove $port parameter since it is efffectively ignored (authored by MarkAHershberger).
Remove $port parameter since it is efffectively ignored
Jan 6 2021, 3:49 AM

Jan 5 2021

MarkAHershberger updated the task description for T271238: ...\LDAPProvider\PlatformFunctionWrapper::getConnection should not pass $port parameter.
Jan 5 2021, 7:06 PM · MediaWiki-extensions-LDAPProvider
MarkAHershberger claimed T271238: ...\LDAPProvider\PlatformFunctionWrapper::getConnection should not pass $port parameter.
Jan 5 2021, 7:01 PM · MediaWiki-extensions-LDAPProvider
MarkAHershberger updated the task description for T271238: ...\LDAPProvider\PlatformFunctionWrapper::getConnection should not pass $port parameter.
Jan 5 2021, 6:53 PM · MediaWiki-extensions-LDAPProvider
MarkAHershberger created T271238: ...\LDAPProvider\PlatformFunctionWrapper::getConnection should not pass $port parameter.
Jan 5 2021, 6:51 PM · MediaWiki-extensions-LDAPProvider

Dec 30 2020

MarkAHershberger added a comment to T270918: PluggableAuth: Add hook when users are created.

Never mind, I found that PluggableAuthPopulateGroups is called from the LocalUserCreated hook.

Dec 30 2020, 10:57 PM · MediaWiki-extensions-Pluggable-Auth
MarkAHershberger updated the task description for T270918: PluggableAuth: Add hook when users are created.
Dec 30 2020, 6:38 PM · MediaWiki-extensions-Pluggable-Auth

Dec 29 2020

MarkAHershberger added a comment to T270918: PluggableAuth: Add hook when users are created.

I guess what I'm saying is; Should I just use the UserAuthorization hook? It looks like I should, so feel free to WONTFIX.

Dec 29 2020, 7:22 PM · MediaWiki-extensions-Pluggable-Auth
MarkAHershberger created T270918: PluggableAuth: Add hook when users are created.
Dec 29 2020, 6:56 PM · MediaWiki-extensions-Pluggable-Auth

Dec 28 2020

MarkAHershberger created T270885: LDAPAuthentication2::authenticate() should allow subclasses more places to override authentication.
Dec 28 2020, 6:13 PM · Patch-For-Review, MediaWiki-extensions-LDAPAuthentication2

Dec 15 2020

MarkAHershberger added a comment to T269906: Groups should still have rights if they are only given permissions in $wgAddGroups or $wgRemoveGroups.

I've been trying to find a way to "fix" this without littering Special:ListGroupRights with random "read" rights. I realized that changing the $wgGroupPermissions right to

$wgGroupPermissions["GROUP"]["*"] = false;

seems to do the job.

Dec 15 2020, 9:11 PM · MediaWiki-User-management

Dec 14 2020

MarkAHershberger closed T270056: LDAPAuthentication2::authenticate() should populate $id if the user already exists as Resolved.
Dec 14 2020, 5:10 PM · Patch-For-Review, MediaWiki-extensions-Pluggable-Auth, LDAP-Extensions
MarkAHershberger committed rELDB3a2f221adf23: Populate $id if we can (authored by MarkAHershberger).
Populate $id if we can
Dec 14 2020, 11:21 AM

Dec 13 2020

MarkAHershberger created T270056: LDAPAuthentication2::authenticate() should populate $id if the user already exists.
Dec 13 2020, 8:26 PM · Patch-For-Review, MediaWiki-extensions-Pluggable-Auth, LDAP-Extensions
Dinoguy1000 awarded T177291: ReplaceText should have an option to not send out emails a Dislike token.
Dec 13 2020, 5:43 AM · MediaWiki-extensions-ReplaceText

Dec 11 2020

MarkAHershberger created T269906: Groups should still have rights if they are only given permissions in $wgAddGroups or $wgRemoveGroups.
Dec 11 2020, 12:26 AM · MediaWiki-User-management

Dec 7 2020

MarkAHershberger added a comment to T245134: Arrays extension cannot parse certain numbers.

As more wikis are updating to MW 1.34+, this is impacting more people. See for example https://www.mediawiki.org/wiki/Topic:Vuij4e8ea5ydavbn. Would be nice to see this fixed in a new point release of the extension.

Dec 7 2020, 11:50 PM · MediaWiki-extensions-Arrays
MarkAHershberger added a comment to T245134: Arrays extension cannot parse certain numbers.
Dec 7 2020, 11:23 PM · MediaWiki-extensions-Arrays
MarkAHershberger added a comment to T245134: Arrays extension cannot parse certain numbers.

Can you try again with the master version of the Arrays extension? This is probably broken because the global default value has been broken for some time in v2.2: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Arrays/+/6a47eac735e7cd9c16b445453f960e6b057845ae

Dec 7 2020, 11:17 PM · MediaWiki-extensions-Arrays

Dec 2 2020

MarkAHershberger added a comment to T268328: Automatically index extensions in Codesearch.

Among the additional stuff is a secondary index of https://raw.githubusercontent.com/MWStake/nonwmf-extensions/master/.gitmodules (ref) which is what you propose, but behind one extra anti-abuse step where MWStake has decided to list the repo. Whether to use this or some other mechanism, I think it's worth having something like that in place before feeding straight into Codesearch cloning, tracking and indexing the repo for the next 24 hours.

Dec 2 2020, 3:17 PM · VPS-project-Codesearch, TechCom

Dec 1 2020

MarkAHershberger added a comment to T269060: ApprovedRevs should allow you to disable parts of #approvable_by.

No, I don't think that is a good enough solution. That's why I was thorough in cleaning out the permissions.

Dec 1 2020, 11:47 PM · Patch-For-Review, MediaWiki-extensions-Approved-Revs
MarkAHershberger added a comment to T269060: ApprovedRevs should allow you to disable parts of #approvable_by.

The code could be simpler, but then it wouldn't address the page properties that already exist. Without that, the possibility of ghost user restrictions remains.

Dec 1 2020, 11:29 PM · Patch-For-Review, MediaWiki-extensions-Approved-Revs
MarkAHershberger added a comment to T269060: ApprovedRevs should allow you to disable parts of #approvable_by.

Just getting rid of the parameters on the wiki does not make them unavailable to users. We want users to use the group parameter, but we do not want to let them use the user parameter since that will change the behavior in an undesired way.

Dec 1 2020, 10:17 PM · Patch-For-Review, MediaWiki-extensions-Approved-Revs
MarkAHershberger added a comment to T269060: ApprovedRevs should allow you to disable parts of #approvable_by.

Okay, now I get it. It would be easier to just disable the "users" parameter when handling #approvable_by... I suppose the downside there is that you can't do anything about #approvable_by calls that already exist and already include a "users" param, but that doesn't seem like a big deal. Or is it?

Dec 1 2020, 9:59 PM · Patch-For-Review, MediaWiki-extensions-Approved-Revs
MarkAHershberger added a comment to T269060: ApprovedRevs should allow you to disable parts of #approvable_by.

We want users to be able to say

{{#approvable_by: group = approvers}}

or

{{#approvable_by: group = editors}}

but not

{{#approvable_by: user = sam}}
Dec 1 2020, 5:56 PM · Patch-For-Review, MediaWiki-extensions-Approved-Revs
MarkAHershberger created T269060: ApprovedRevs should allow you to disable parts of #approvable_by.
Dec 1 2020, 2:18 AM · Patch-For-Review, MediaWiki-extensions-Approved-Revs

Nov 20 2020

MarkAHershberger closed T268251: "Approve this revision" link does not show up on revisions of pages that are set to be approvable by groups as Invalid.
Nov 20 2020, 12:35 AM · MediaWiki-extensions-Approved-Revs

Nov 19 2020

MarkAHershberger added a comment to T268251: "Approve this revision" link does not show up on revisions of pages that are set to be approvable by groups.

I may have to eat my words. Setting up a test wiki with only

wfLoadExtension( 'ApprovedRevs' );
$wgGroupPermissions['sysop']['approverevisions'] = false;
$egApprovedRevsBlankIfUnapproved = true;
$egApprovedRevsShowNotApprovedMessage = true;

shows behavior more like what I expected. Reviewing all this now.

Nov 19 2020, 7:35 PM · MediaWiki-extensions-Approved-Revs
MarkAHershberger added a comment to T268251: "Approve this revision" link does not show up on revisions of pages that are set to be approvable by groups.

Note that changing my membership in the group does immediately add or remove the approve links from the history page.

Nov 19 2020, 7:31 PM · MediaWiki-extensions-Approved-Revs
MarkAHershberger updated the task description for T268251: "Approve this revision" link does not show up on revisions of pages that are set to be approvable by groups.
Nov 19 2020, 6:17 PM · MediaWiki-extensions-Approved-Revs
MarkAHershberger created T268251: "Approve this revision" link does not show up on revisions of pages that are set to be approvable by groups.
Nov 19 2020, 4:41 PM · MediaWiki-extensions-Approved-Revs

Nov 16 2020

MarkAHershberger updated the task description for T267936: Lingo should use the SimpleMathJaxAttributes to add `class="noglossary"` to the span around the math.
Nov 16 2020, 6:43 PM · MediaWiki-extensions-Lingo
MarkAHershberger created T267936: Lingo should use the SimpleMathJaxAttributes to add `class="noglossary"` to the span around the math.
Nov 16 2020, 4:05 PM · MediaWiki-extensions-Lingo
MarkAHershberger closed T123968: Doesn't work with Visual Editor as Resolved.

It looks like this is no longer an issue.

Nov 16 2020, 3:44 PM · MediaWiki-extensions-Lingo

Nov 5 2020

MarkAHershberger added a comment to T250406: RFC: Hybrid extension management.

It is my understanding that this RFC effectively asks the WMF to release all extensions she maintains on a composer repository (packagist or self-hosted) on a regular bases (along with core releases, presumably). Did I get that right?

Nov 5 2020, 2:32 PM · MediaWiki-Configuration, MediaWiki-Stakeholders-Group, TechCom-RFC
MarkAHershberger created T267281: Provide Lockdown with a movepage-from-lockdown permission.
Nov 5 2020, 12:49 AM · MediaWiki-extensions-Lockdown

Oct 30 2020

MarkAHershberger added a comment to T250406: RFC: Hybrid extension management.

Those of us working on this have updated Composer/For_extension_developers and Composer/For_extensions in anticipation of the resolution of this.

Oct 30 2020, 12:01 AM · MediaWiki-Configuration, MediaWiki-Stakeholders-Group, TechCom-RFC

Oct 29 2020

MarkAHershberger added a comment to T264680: Lockdown extension and VE: "Error loading from server: apierror-visualeditor-docserver-http: HTTP 500.".

Do you have the following in your LocalSettings.php?

$wgVirtualRestConfig['modules']['parsoid']['forwardCookies'] = true;
Oct 29 2020, 7:25 PM · Parsoid (Third-party), VisualEditor, MediaWiki-extensions-Lockdown

Oct 27 2020

MarkAHershberger added a comment to T198902: NS & Title not being processed when articles removed from category.

Currently working on CW, so this may see some attention.

Oct 27 2020, 4:59 PM · MediaWiki-extensions-CategoryWatch
MarkAHershberger closed T197807: Source map error in FF for ext.biblioPlus.qtip.min.js as Resolved.
Oct 27 2020, 4:58 PM · BiblioPlus
MarkAHershberger added a comment to T158026: Make responsive image maps possible in ImageMap extension.

The patch needs to be updated and I need to talk to the people who originally requested this to see if they still want it.

Oct 27 2020, 4:57 PM · ImageMap
MarkAHershberger closed T191705: Create a way to automatically update the non-wmf-hosted repository of extensions as Declined.

Doesn't need to be done. I'm happy just pointing to the repositories and occasionally moving what the parent repo points to.

Oct 27 2020, 4:55 PM · MediaWiki-Stakeholders-Group