Page MenuHomePhabricator

Martaannaj (Marta Anna Jansone)
User

Today

  • No visible events.

Tomorrow

  • No visible events.

Monday

  • No visible events.

User Details

User Since
May 3 2021, 6:53 AM (248 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Martaannaj [ Global Accounts ]

Recent Activity

Jul 31 2021

Martaannaj updated the task description for T285098: Production A/B test deployment - Improved Property Suggester/Recommender.
Jul 31 2021, 8:20 AM · Patch-Needs-Improvement, [Archived]Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech
Martaannaj added a comment to T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester.

@Michaelcochez Should be fixed now, in the case where there are no properties already attributed to the entity the PropertySuggester would simply return a pre-set list, so the request duration would be 0 ms. This in turn would cause the line $this->requestDuration ?: -1 to replace the 0 by -1, causing the error.

Jul 31 2021, 8:19 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Wikidata, MediaWiki-extensions-PropertySuggester
Martaannaj added a comment to T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester.

@Michaelcochez can you give me an example of an entity where this happens? Because looking at https://wikidata.beta.wmflabs.org/wiki/Q86 (served by the PropertySuggester) the request duration gets logged nicely.
In the implementation, in the case where the call to the SchemaTreeRecommender times out the request gets handled by the PropertySuggester. In these cases the request duration gets logged as -1 to indicate that it was supposed to be handled by the SchemaTreeRecommender but something went wrong with the request so it ended up being executed by the PropertySuggester. Maybe this is what you see in the logs?
I think that what should be seen is one event log where the recommender used is the 'SchemaTreeRecommender' with the request duration of -1 and then another server side log for the same entity but with the recommender used 'PropertySuggester'

Jul 31 2021, 7:18 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Wikidata, MediaWiki-extensions-PropertySuggester
Martaannaj added a comment to T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester.
Jul 31 2021, 7:11 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Wikidata, MediaWiki-extensions-PropertySuggester

Jul 28 2021

Martaannaj added a comment to T285098: Production A/B test deployment - Improved Property Suggester/Recommender.

@Addshore

It would still be required to test the event logging on beta right? And for that I believe that the schemas still need to be merged. If that gets done then I can make another patch for deploying the event logging streams to mediawiki-config. After that there should be nothing missing in order to proceed with test.wikidata.

This is now merged, let us know how testing goes or if you get stuck with anything!

Jul 28 2021, 2:19 PM · Patch-Needs-Improvement, [Archived]Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech

Jul 26 2021

Martaannaj added a comment to T285098: Production A/B test deployment - Improved Property Suggester/Recommender.

It would still be required to test the event logging on beta right? And for that I believe that the schemas still need to be merged. If that gets done then I can make another patch for deploying the event logging streams to mediawiki-config. After that there should be nothing missing in order to proceed with test.wikidata.

Jul 26 2021, 1:14 PM · Patch-Needs-Improvement, [Archived]Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech

Jul 22 2021

Martaannaj updated the task description for T285098: Production A/B test deployment - Improved Property Suggester/Recommender.
Jul 22 2021, 11:21 AM · Patch-Needs-Improvement, [Archived]Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech
Martaannaj updated the task description for T285098: Production A/B test deployment - Improved Property Suggester/Recommender.
Jul 22 2021, 9:04 AM · Patch-Needs-Improvement, [Archived]Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech

Jul 20 2021

Martaannaj updated the task description for T285098: Production A/B test deployment - Improved Property Suggester/Recommender.
Jul 20 2021, 11:33 AM · Patch-Needs-Improvement, [Archived]Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech

Jul 19 2021

Martaannaj updated the task description for T285098: Production A/B test deployment - Improved Property Suggester/Recommender.
Jul 19 2021, 12:09 PM · Patch-Needs-Improvement, [Archived]Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech

Jul 14 2021

Martaannaj added a comment to T285098: Production A/B test deployment - Improved Property Suggester/Recommender.

I noticed something strange while testing the wmcloud suggester:

$ curl -s --data-raw '{"Properties":[],"Types":[]}' 'https://recommender.wmcloud.org/recommender' | jq '.recommendations | .[] | select(.property | contains("entity"))' | head -25
{
  "property": "t#http://www.wikidata.org/entity/Q13442814",
  "probability": 0.3913980623938509
}
{
  "property": "t#http://www.wikidata.org/entity/Q5",
  "probability": 0.095606796510795
}
{
  "property": "t#http://www.wikidata.org/entity/Q4167836",
  "probability": 0.05041456380639843
}
{
  "property": "t#http://www.wikidata.org/entity/Q523",
  "probability": 0.03463687290548014
}
{
  "property": "t#http://www.wikidata.org/entity/Q16521",
  "probability": 0.030493683112935314
}
{
  "property": "t#http://www.wikidata.org/entity/Q318",
  "probability": 0.022078375242171346
}
{

Some of the suggestions are entity URIs instead of property URIs… and they start with a random t#?

Jul 14 2021, 4:10 PM · Patch-Needs-Improvement, [Archived]Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech

May 4 2021

Martaannaj updated the task description for T281840: Request creation of SchemaTreeRecommender VPS project.
May 4 2021, 1:03 PM · [DEPRECATED] wdwb-tech, Cloud-VPS (Project-requests)
Martaannaj created T281840: Request creation of SchemaTreeRecommender VPS project.
May 4 2021, 1:03 PM · [DEPRECATED] wdwb-tech, Cloud-VPS (Project-requests)