Page MenuHomePhabricator

Martaannaj (Marta Anna Jansone)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 3 2021, 6:53 AM (167 w, 1 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Martaannaj [ Global Accounts ]

Recent Activity

Mar 2 2022

Martaannaj committed rDPRS43acacd6a514: return from function when nil.
return from function when nil
Mar 2 2022, 7:12 PM
Martaannaj committed rDPRScd3663c5f95d: Merge branch 'main' into evaluation.
Merge branch 'main' into evaluation
Mar 2 2022, 7:12 PM
Martaannaj committed rDPRS4155c4197507: Revert "fix loading of the tree".
Revert "fix loading of the tree"
Mar 2 2022, 7:12 PM
Martaannaj added a reverting change for rDPRSada7059010d8: fix loading of the tree: rDPRS4155c4197507: Revert "fix loading of the tree".
Mar 2 2022, 7:12 PM
Martaannaj committed rDPRSe8a84e72b34d: Merge branch 'main' into evaluation.
Merge branch 'main' into evaluation
Mar 2 2022, 7:12 PM
Martaannaj committed rDPRSd5420b9ecf3d: Merge branch 'main' into evaluation.
Merge branch 'main' into evaluation
Mar 2 2022, 7:12 PM
Martaannaj committed rDPRSbdec63f7d437: script fix.
script fix
Mar 2 2022, 7:12 PM
Martaannaj committed rDPRSb8acc5072284: evaluate recummender script.
evaluate recummender script
Mar 2 2022, 7:12 PM
Martaannaj committed rDPRS52f696f7915a: exit for loop if there are no more nodes.
exit for loop if there are no more nodes
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS4586ac2e0d73: remove error with skipping the entities that don't have types.
remove error with skipping the entities that don't have types
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRSc5128671d74d: remove rankIfHitAvg.
remove rankIfHitAvg
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS8e0c213a08a5: Merge branch 'evaluation' of https://github.com/martaannaj/RecommenderServer….
Merge branch 'evaluation' of https://github.com/martaannaj/RecommenderServer…
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS90b6012045a4: remove currently unused files.
remove currently unused files
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS445b82c2f674: results files.
results files
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS92a3bf5f11d8: log only info required for duration tests.
log only info required for duration tests
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS9c87697585a9: graphing the tree.
graphing the tree
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRSfc38510b574a: evaluation for just the duration of the request for the entire wikidata.
evaluation for just the duration of the request for the entire wikidata
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRSf1f977abe28b: files required for evaluation.
files required for evaluation
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS0d71f3c15868: Merge branch 'main' into evaluation.
Merge branch 'main' into evaluation
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS5ab6488a6e9a: catch the file closing error.
catch the file closing error
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRSd33d28806e9a: add the package tests.
add the package tests
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS25befe10fd1d: remove unnecessary assessment functions & handle errors.
remove unnecessary assessment functions & handle errors
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS94e8998f25e2: run lint.
run lint
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS82f71d75cdcd: lint errors.
lint errors
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRSe94135186ded: add a part of golangci-lint fixes.
add a part of golangci-lint fixes
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRSd5a9a478b0a3: Merge branch 'main' of https://github.com/martaannaj/RecommenderServer into main.
Merge branch 'main' of https://github.com/martaannaj/RecommenderServer into main
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS54c69339d77a: ability to strip the recommendations of the URIs.
ability to strip the recommendations of the URIs
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRSdc3aa39c65e6: clean-up and add back workflow configuration.
clean-up and add back workflow configuration
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS378f6bb37b81: error handling.
error handling
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS68f5cf33fba3: unroll loop fix.
unroll loop fix
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS827359dfb81b: loop unroll.
loop unroll
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS4a6fa9cc024b: use the constant everywhere.
use the constant everywhere
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRSe1351bcdee77: rebase.
rebase
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS76140069117f: update loading the tree.
update loading the tree
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRSfa666535ed6a: blubber file and bash scripts.
blubber file and bash scripts
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRSada7059010d8: fix loading of the tree.
fix loading of the tree
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS2c98acde4c47: for loop breaks.
for loop breaks
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRSb49d3ab0809c: fix the pointers to child nodes.
fix the pointers to child nodes
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRSf0fba121413c: print statement.
print statement
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS6ae4d0a31e6f: Only the code necessary to serve the recommender.
Only the code necessary to serve the recommender
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRSf192bd2e4c51: missing readme files.
missing readme files
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS0c1538b0f626: unneccessary files.
unneccessary files
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS13a99acdc3b9: removing unused functions.
removing unused functions
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS8ebbe9b8ec41: updating the array structure.
updating the array structure
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRSe1cf799c4cf2: remove executable.
remove executable
Mar 2 2022, 7:11 PM
Martaannaj committed rDPRS1b214a85e574: Initial commit.
Initial commit
Mar 2 2022, 7:11 PM

Aug 2 2021

Martaannaj committed rEPS3f4406cf53d5: Fix setting the request duration correctly for the PropertySuggester.
Fix setting the request duration correctly for the PropertySuggester
Aug 2 2021, 11:02 AM

Jul 31 2021

Martaannaj updated the task description for T285098: Production A/B test deployment - Improved Property Suggester/Recommender.
Jul 31 2021, 8:20 AM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech
Martaannaj added a comment to T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester.

@Michaelcochez Should be fixed now, in the case where there are no properties already attributed to the entity the PropertySuggester would simply return a pre-set list, so the request duration would be 0 ms. This in turn would cause the line $this->requestDuration ?: -1 to replace the 0 by -1, causing the error.

Jul 31 2021, 8:19 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Wikidata, MediaWiki-extensions-PropertySuggester
Martaannaj added a comment to T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester.

@Michaelcochez can you give me an example of an entity where this happens? Because looking at https://wikidata.beta.wmflabs.org/wiki/Q86 (served by the PropertySuggester) the request duration gets logged nicely.
In the implementation, in the case where the call to the SchemaTreeRecommender times out the request gets handled by the PropertySuggester. In these cases the request duration gets logged as -1 to indicate that it was supposed to be handled by the SchemaTreeRecommender but something went wrong with the request so it ended up being executed by the PropertySuggester. Maybe this is what you see in the logs?
I think that what should be seen is one event log where the recommender used is the 'SchemaTreeRecommender' with the request duration of -1 and then another server side log for the same entity but with the recommender used 'PropertySuggester'

Jul 31 2021, 7:18 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Wikidata, MediaWiki-extensions-PropertySuggester
Martaannaj added a comment to T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester.
Jul 31 2021, 7:11 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Wikidata, MediaWiki-extensions-PropertySuggester

Jul 30 2021

Martaannaj committed rEPS8ee714fe0db3: Fix an incorrect EventLogging stream name client-side.
Fix an incorrect EventLogging stream name client-side
Jul 30 2021, 2:53 PM

Jul 28 2021

Martaannaj added a comment to T285098: Production A/B test deployment - Improved Property Suggester/Recommender.

@Addshore

It would still be required to test the event logging on beta right? And for that I believe that the schemas still need to be merged. If that gets done then I can make another patch for deploying the event logging streams to mediawiki-config. After that there should be nothing missing in order to proceed with test.wikidata.

This is now merged, let us know how testing goes or if you get stuck with anything!

Jul 28 2021, 2:19 PM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech

Jul 26 2021

Martaannaj added a comment to T285098: Production A/B test deployment - Improved Property Suggester/Recommender.

It would still be required to test the event logging on beta right? And for that I believe that the schemas still need to be merged. If that gets done then I can make another patch for deploying the event logging streams to mediawiki-config. After that there should be nothing missing in order to proceed with test.wikidata.

Jul 26 2021, 1:14 PM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech

Jul 22 2021

Martaannaj updated the task description for T285098: Production A/B test deployment - Improved Property Suggester/Recommender.
Jul 22 2021, 11:21 AM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech
Martaannaj committed rEPSb55db8674d9a: Set deprecated and classifying IDs for the SchemaTreeSuggester.
Set deprecated and classifying IDs for the SchemaTreeSuggester
Jul 22 2021, 10:12 AM
Martaannaj updated the task description for T285098: Production A/B test deployment - Improved Property Suggester/Recommender.
Jul 22 2021, 9:04 AM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech

Jul 21 2021

Martaannaj committed rEPSfbae15c3149f: Adjust the SchemaTreeSuggester to not require URL prefixes.
Adjust the SchemaTreeSuggester to not require URL prefixes
Jul 21 2021, 12:16 PM

Jul 20 2021

Martaannaj updated the task description for T285098: Production A/B test deployment - Improved Property Suggester/Recommender.
Jul 20 2021, 11:33 AM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech

Jul 19 2021

Martaannaj updated the task description for T285098: Production A/B test deployment - Improved Property Suggester/Recommender.
Jul 19 2021, 12:09 PM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech

Jul 14 2021

Martaannaj added a comment to T285098: Production A/B test deployment - Improved Property Suggester/Recommender.

I noticed something strange while testing the wmcloud suggester:

$ curl -s --data-raw '{"Properties":[],"Types":[]}' 'https://recommender.wmcloud.org/recommender' | jq '.recommendations | .[] | select(.property | contains("entity"))' | head -25
{
  "property": "t#http://www.wikidata.org/entity/Q13442814",
  "probability": 0.3913980623938509
}
{
  "property": "t#http://www.wikidata.org/entity/Q5",
  "probability": 0.095606796510795
}
{
  "property": "t#http://www.wikidata.org/entity/Q4167836",
  "probability": 0.05041456380639843
}
{
  "property": "t#http://www.wikidata.org/entity/Q523",
  "probability": 0.03463687290548014
}
{
  "property": "t#http://www.wikidata.org/entity/Q16521",
  "probability": 0.030493683112935314
}
{
  "property": "t#http://www.wikidata.org/entity/Q318",
  "probability": 0.022078375242171346
}
{

Some of the suggestions are entity URIs instead of property URIs… and they start with a random t#?

Jul 14 2021, 4:10 PM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, [DEPRECATED] wdwb-tech

May 7 2021

Addshore awarded T281840: Request creation of SchemaTreeRecommender VPS project a Like token.
May 7 2021, 2:05 PM · [DEPRECATED] wdwb-tech, Cloud-VPS (Project-requests)

May 4 2021

WMDE-leszek awarded T281840: Request creation of SchemaTreeRecommender VPS project a Like token.
May 4 2021, 1:04 PM · [DEPRECATED] wdwb-tech, Cloud-VPS (Project-requests)
Martaannaj updated the task description for T281840: Request creation of SchemaTreeRecommender VPS project.
May 4 2021, 1:03 PM · [DEPRECATED] wdwb-tech, Cloud-VPS (Project-requests)
Martaannaj created T281840: Request creation of SchemaTreeRecommender VPS project.
May 4 2021, 1:03 PM · [DEPRECATED] wdwb-tech, Cloud-VPS (Project-requests)