Page MenuHomePhabricator

MattFitzpatrick (Matt Fitzpatrick)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 4:46 AM (249 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Matt Fitzpatrick [ Global Accounts ]

Recent Activity

Oct 24 2018

MattFitzpatrick updated subscribers of T200704: TemplateStyles don't work when the template is inside a link.

Thanks to @Jonesey95's report at en:Template talk:Noitalic: The same thing is happening inside navboxes at en. Apparently, whether the noitalic is inside a link or not.

Oct 24 2018, 10:10 AM · MediaWiki-Parser, TemplateStyles

Aug 16 2018

MattFitzpatrick added a comment to T195053: Reduce page jumps in table of contents.

Can anyone check the new "show" or "hide" label on IE11 + screen reader? (I don't have an IE11 capable machine.)

Aug 16 2018, 10:52 PM · User-Ryasmeen, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Performance-Team (Radar), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board-Old, CSS, JavaScript, MediaWiki-Interface

Jun 10 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rESCCfb05e51a31f5: Update patch set 1 (authored by MattFitzpatrick).
Update patch set 1
Jun 10 2018, 7:31 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESCC242d75ae31d8: Update patch set 1 (authored by MattFitzpatrick).
Update patch set 1
Jun 10 2018, 7:27 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSLf12847a36f4a: Update patch set 5 (authored by MattFitzpatrick).
Update patch set 5
Jun 10 2018, 3:31 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSL83eb36771505: Update patch set 3 (authored by MattFitzpatrick).
Update patch set 3
Jun 10 2018, 3:31 AM

Jan 18 2018

MattFitzpatrick added a comment to T104770: HTML5 Semantic element <aside></aside> not seemingly parsed..

See the WAI-ARIA 1.1 role definitions to get started.

Jan 18 2018, 6:52 PM · MediaWiki-Parser

Dec 14 2017

MattFitzpatrick added a comment to T6521: Colon (:) & semicolon (;) shouldn't output as HTML definition list when used for indentation, boldfacing.

The parser shouldn't be overly strict. A one-item ul or ol is okay in the HTML spec. And there are reasons a wiki might legitimately want to do that. For example, a single placeholder item, with JavaScript to add or remove items to the list.

Dec 14 2017, 5:09 PM · Parsoid, Accessibility, MediaWiki-Parser

Dec 6 2017

MattFitzpatrick added a comment to T138622: Help community migrate away from legacy Main page special casing.

I think en: is, on the whole, amenable to breaking content out of layout tables. Even on en:Main Page, if the changes are invisible or too small to be noticed visually.

Dec 6 2017, 7:11 PM · Readers-Web-Backlog (Tracking), Readers-Community-Engagement, Reading-Web-Local-Wiki-Issues

Dec 5 2017

MattFitzpatrick added a comment to T182041: Display math generates div inside of paragraph (HTML5 violation).

Ha, you beat me to this.

Dec 5 2017, 4:51 PM · good first task, Math

Nov 9 2017

MattFitzpatrick added a comment to T35787: screenreaders should have a way to skip InfoBoxes content..

I agree with TheDJ - an infobox/sidebar skip link is easy to do with just template or module code, and a bit of JS or CSS if you want to hide the skip link.

Nov 9 2017, 7:43 PM · WorkType-NewFunctionality, Accessibility, MediaWiki-General

Nov 3 2017

MattFitzpatrick moved T147199: Removing support for DES-CBC3-SHA TLS cipher (drops IE8-on-XP support) from Unsorted to IE8 on the Browser-Support-Internet-Explorer board.
Nov 3 2017, 3:28 PM · Browser-Support-Internet-Explorer, User-notice, Patch-For-Review, Operations, Traffic
MattFitzpatrick added a project to T147199: Removing support for DES-CBC3-SHA TLS cipher (drops IE8-on-XP support): Browser-Support-Internet-Explorer.
Nov 3 2017, 3:28 PM · Browser-Support-Internet-Explorer, User-notice, Patch-For-Review, Operations, Traffic

Oct 17 2017

MattFitzpatrick moved T178398: Use semantic HTML5 <main> tag for primary page content from Unsorted to Semantic HTML on the Accessibility board.
Oct 17 2017, 4:48 PM · Parsoid, MediaWiki-Parser, Accessibility
MattFitzpatrick added a comment to T178398: Use semantic HTML5 <main> tag for primary page content.

I agree with use of <main>.

Oct 17 2017, 4:47 PM · Parsoid, MediaWiki-Parser, Accessibility

Sep 18 2017

MattFitzpatrick added a comment to T104770: HTML5 Semantic element <aside></aside> not seemingly parsed..

It's not a full solution, but MediaWiki since 1.27 allows <div role="complementary"> and <div role="note"> for part of the functionality of an <aside>.

Sep 18 2017, 11:51 PM · MediaWiki-Parser
MattFitzpatrick added a parent task for T74833: MWTidy: Old versions of Tidy break flow content out of <caption> and <table>: T21719: HTML5 features (tracking).
Sep 18 2017, 11:36 PM · Verified, User-Ryasmeen, Tidy, MediaWiki-Parser
MattFitzpatrick added a subtask for T21719: HTML5 features (tracking): T74833: MWTidy: Old versions of Tidy break flow content out of <caption> and <table>.
Sep 18 2017, 11:36 PM · Tracking-Neverending, MediaWiki-Parser
MattFitzpatrick added a comment to T74833: MWTidy: Old versions of Tidy break flow content out of <caption> and <table>.

As mentioned in T76100, this was fixed in 2015, in tidy-html5.

Sep 18 2017, 11:32 PM · Verified, User-Ryasmeen, Tidy, MediaWiki-Parser
MattFitzpatrick merged task T76100: Thumbnails in table caption get hoisted outside the table into T74833: MWTidy: Old versions of Tidy break flow content out of <caption> and <table>.
Sep 18 2017, 11:27 PM · Tidy, MediaWiki-Parser
MattFitzpatrick merged T76100: Thumbnails in table caption get hoisted outside the table into T74833: MWTidy: Old versions of Tidy break flow content out of <caption> and <table>.
Sep 18 2017, 11:27 PM · Verified, User-Ryasmeen, Tidy, MediaWiki-Parser
MattFitzpatrick renamed T74833: MWTidy: Old versions of Tidy break flow content out of <caption> and <table> from MediaWiki: Lists inside captions end up outside of the table with Tidy enabled to MWTidy: Old versions of Tidy break flow content out of <caption> and <table>.
Sep 18 2017, 11:26 PM · Verified, User-Ryasmeen, Tidy, MediaWiki-Parser

Aug 24 2017

MattFitzpatrick added a comment to T173900: Hide InputBox when printed.

Thanks for the feedback.

Aug 24 2017, 10:57 PM · CSS, MediaWiki-extensions-InputBox

Aug 23 2017

MattFitzpatrick created T173900: Hide InputBox when printed.
Aug 23 2017, 6:42 AM · CSS, MediaWiki-extensions-InputBox

Aug 3 2017

MattFitzpatrick added a comment to T6521: Colon (:) & semicolon (;) shouldn't output as HTML definition list when used for indentation, boldfacing.

Quick and dirty test page. Definition lists conforming or not conforming to HTML5 spec, with or without presentation role.

Aug 3 2017, 12:25 AM · Parsoid, Accessibility, MediaWiki-Parser

Jun 3 2017

MattFitzpatrick moved T166941: Allow additional attributes in file / image links from Unsorted to ARIA on the Accessibility board.
Jun 3 2017, 7:16 AM · Accessibility, MediaWiki-Parser
MattFitzpatrick created T166941: Allow additional attributes in file / image links.
Jun 3 2017, 7:13 AM · Accessibility, MediaWiki-Parser

May 23 2017

MattFitzpatrick updated the task description for T25932: Enable, whitelist, and incorporate semantic HTML5 elements.
May 23 2017, 9:17 AM · Epic, Accessibility, MediaWiki-Parser

Mar 6 2017

MattFitzpatrick added a comment to T157062: Template:Stack breaks display on mobile.

As Jdlrobson mentioned, TemplateStyles will solve this beautifully. In the meantime, as a temporary fix, the mobile-float-reset class is now added to Template:Stack's output element. It isn't ideal, as Template:Stack now takes 100% width in Minerva skin regardless of viewport size, but at least surrounding text can no longer be squished.

Mar 6 2017, 9:30 PM · Mobile, Reading-Web-Local-Wiki-Issues

Aug 31 2016

MattFitzpatrick updated the task description for T25932: Enable, whitelist, and incorporate semantic HTML5 elements.
Aug 31 2016, 11:40 AM · Epic, Accessibility, MediaWiki-Parser
MattFitzpatrick added a comment to T52644: Support <style scoped> as HTML element in wiki source.

Mozilla devs leaning toward removing <style scoped> support, see Bugzilla 1291515.

Aug 31 2016, 11:34 AM · MediaWiki-Parser

Jul 2 2016

MattFitzpatrick created T139221: Make generated table of contents a navigation region.
Jul 2 2016, 12:40 AM · Patch-For-Review, Accessibility, MediaWiki-Parser
MattFitzpatrick moved T129792: Tab order in link insertion dialog is all messed up from Unsorted to Tabindex on the Accessibility board.
Jul 2 2016, 12:15 AM · MW-1.28-release (WMF-deploy-2016-07-26_(1.28.0-wmf.12)), MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)), MW-1.28-release-notes, VisualEditor-MediaWiki-Links, Accessibility, VisualEditor, VisualEditor-MediaWiki

Feb 13 2016

MattFitzpatrick moved T52793: Make ULS accessible from keyboard from Unsorted to Tabindex on the Accessibility board.
Feb 13 2016, 6:30 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Language-2018-Jan-Mar, Accessibility, UniversalLanguageSelector
MattFitzpatrick added a subtask for T52793: Make ULS accessible from keyboard: T52921: Add more ARIA attributes to ULS cog.
Feb 13 2016, 6:27 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Language-2018-Jan-Mar, Accessibility, UniversalLanguageSelector
MattFitzpatrick added a parent task for T52921: Add more ARIA attributes to ULS cog: T52793: Make ULS accessible from keyboard.
Feb 13 2016, 6:27 AM · Accessibility, UniversalLanguageSelector

Feb 12 2016

MattFitzpatrick added a comment to T52921: Add more ARIA attributes to ULS cog.

Getting close to a patch.

Feb 12 2016, 5:17 AM · Accessibility, UniversalLanguageSelector
MattFitzpatrick added a comment to T44394: After introduction of WAI ARIA roles, VoiceOver is extremely slow.

Oh good, looks like there's already work being done on this!

Feb 12 2016, 5:04 AM · Upstream, Accessibility, MediaWiki-Interface
MattFitzpatrick added a parent task for T114072: <section> tags for MediaWiki sections: T12467: Use semantic HTML (tracking).
Feb 12 2016, 5:01 AM · Reading Epics (Platform JS CSS and HTML consolidation), Services (blocked), Proposal, Parsing-Team, Accessibility, TechCom-RFC, RESTBase, Patch-For-Review, Parsoid, MediaWiki-Interface
MattFitzpatrick added a subtask for T12467: Use semantic HTML (tracking): T114072: <section> tags for MediaWiki sections.
Feb 12 2016, 5:01 AM · Accessibility, Tracking-Neverending, MediaWiki-Interface
MattFitzpatrick moved T114072: <section> tags for MediaWiki sections from Unsorted to Semantic HTML on the Accessibility board.
Feb 12 2016, 5:00 AM · Reading Epics (Platform JS CSS and HTML consolidation), Services (blocked), Proposal, Parsing-Team, Accessibility, TechCom-RFC, RESTBase, Patch-For-Review, Parsoid, MediaWiki-Interface
MattFitzpatrick added a project to T114072: <section> tags for MediaWiki sections: Accessibility.
Feb 12 2016, 4:59 AM · Reading Epics (Platform JS CSS and HTML consolidation), Services (blocked), Proposal, Parsing-Team, Accessibility, TechCom-RFC, RESTBase, Patch-For-Review, Parsoid, MediaWiki-Interface

Feb 10 2016

MattFitzpatrick added a comment to T6521: Colon (:) & semicolon (;) shouldn't output as HTML definition list when used for indentation, boldfacing.

There may be an alternative solution using WAI-ARIA roles.

Feb 10 2016, 7:07 PM · Parsoid, Accessibility, MediaWiki-Parser
MattFitzpatrick claimed T52921: Add more ARIA attributes to ULS cog.
Feb 10 2016, 10:15 AM · Accessibility, UniversalLanguageSelector

Feb 4 2016

MattFitzpatrick added a comment to T44394: After introduction of WAI ARIA roles, VoiceOver is extremely slow.

If this is an issue of screen readers struggling with a single too-big landmark/region, could wrapping output in <section>-like <div>s do the trick?

Feb 4 2016, 10:15 PM · Upstream, Accessibility, MediaWiki-Interface
MattFitzpatrick updated the task description for T44394: After introduction of WAI ARIA roles, VoiceOver is extremely slow.
Feb 4 2016, 9:41 PM · Upstream, Accessibility, MediaWiki-Interface

Jan 19 2016

MattFitzpatrick created T123998: Flip Sanitizer.php attribute whitelist arrays before caching.
Jan 19 2016, 3:05 AM · MediaWiki-General, Performance Issue
MattFitzpatrick added a comment to T26659: Whitelist additional values for the WAI-ARIA role attribute on certain elements in wikitext.

tstarling suggested at Gerrit that validation on the role attribute is unnecessary, so this patch has been scaled way back. It now simply whitelists the aria-* and role attributes (and escapes id's passed as aria-* values, to avoid unexpected id mismatches).

Jan 19 2016, 1:18 AM · MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)), MW-1.27-release-notes, Accessibility, MediaWiki-Parser

Dec 16 2015

MattFitzpatrick added a comment to T26583: wiki-text should support presentational tables.

I think it's safe to close this? includes/Sanitizer.php has whitelisted role="presentation" for all elements since 1.21.

Dec 16 2015, 10:20 PM · Parser, Accessibility, MediaWiki-Parser

Oct 21 2015

MattFitzpatrick added a comment to T25932: Enable, whitelist, and incorporate semantic HTML5 elements.

It's a little surprising that the corner case of IE8 with JavaScript disabled is still taking priority over accessibility, nearly 5 years after IE8's last update.

Oct 21 2015, 7:13 PM · Epic, Accessibility, MediaWiki-Parser

Oct 4 2015

MattFitzpatrick added a comment to T26659: Whitelist additional values for the WAI-ARIA role attribute on certain elements in wikitext.

I saw daniel also mentioned ARIA attributes, so the patch I submitted also whitelists a subset of aria-* attributes defining non-interactive properties, such as labels. Since they're non-interactive they're potentially useful even where user interaction like forms and scripts are not present. And since they all happen to be global properties, they're allowed on all elements by definition, so they can be dropped right into the $common array of attributes whitelisted for all elements.

Oct 4 2015, 12:41 AM · MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)), MW-1.27-release-notes, Accessibility, MediaWiki-Parser

Oct 3 2015

MattFitzpatrick claimed T26659: Whitelist additional values for the WAI-ARIA role attribute on certain elements in wikitext.
Oct 3 2015, 8:06 AM · MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)), MW-1.27-release-notes, Accessibility, MediaWiki-Parser

Oct 2 2015

MattFitzpatrick renamed T26659: Whitelist additional values for the WAI-ARIA role attribute on certain elements in wikitext from allow WAI ARIA attributes in wikitext to Whitelist additional values for the WAI-ARIA role attribute on certain elements in wikitext.
Oct 2 2015, 4:47 AM · MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)), MW-1.27-release-notes, Accessibility, MediaWiki-Parser
MattFitzpatrick added a comment to T26659: Whitelist additional values for the WAI-ARIA role attribute on certain elements in wikitext.

WAI-ARIA roles allow HTML elements, such as <div>, to be given semantic associations for accessible browsing.(1) Several HTML5 semantic tags remain blacklisted (see T25932), so the role attribute is, in many cases, the only method to attach roles to wikitext elements.

Oct 2 2015, 4:45 AM · MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)), MW-1.27-release-notes, Accessibility, MediaWiki-Parser

Jun 1 2015

MattFitzpatrick added a comment to T25932: Enable, whitelist, and incorporate semantic HTML5 elements.

<time> and <mark> were whitelisted in 1.21.

Jun 1 2015, 7:59 AM · Epic, Accessibility, MediaWiki-Parser

Apr 18 2015

MattFitzpatrick added a project to T25932: Enable, whitelist, and incorporate semantic HTML5 elements: Accessibility.
Apr 18 2015, 4:54 AM · Epic, Accessibility, MediaWiki-Parser
MattFitzpatrick merged task T65446: Whitelist HTML5 <aside> element, to wrap MediaWiki aside-type content into T25932: Enable, whitelist, and incorporate semantic HTML5 elements.
Apr 18 2015, 4:49 AM · good first task, Accessibility, MediaWiki-Interface
MattFitzpatrick updated subscribers of T25932: Enable, whitelist, and incorporate semantic HTML5 elements.
Apr 18 2015, 4:49 AM · Epic, Accessibility, MediaWiki-Parser