Page MenuHomePhabricator

MaxSem (Max Semenik)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:37 PM (316 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
MaxSem [ Global Accounts ]

Recent Activity

Today

kolbert awarded T132614: No way to work around account creation blocks for global accounts a Baby Tequila token.
Fri, Oct 30, 6:58 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), User-Majavah, User-Urbanecm, MediaWiki-Blocks, MediaWiki-extensions-CentralAuth

Sep 21 2020

MaxSem added a comment to T263501: Move DeviceDetection.php from MobileFrontend to core.

What, again? :P It was in the core at some point, was moved back because only MF used it anyway.

Sep 21 2020, 10:09 PM · MobileFrontend (Tracking), Readers-Web-Backlog (Tracking), MediaWiki-Interface

Aug 18 2020

MaxSem updated the task description for T260735: Stop using is_resource().
Aug 18 2020, 8:46 PM · Wikidata, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-Html2Wiki, MediaWiki-extensions-QuickGV, TimedMediaHandler, MediaWiki-General, PHP 8.0 support
MaxSem updated the task description for T260735: Stop using is_resource().
Aug 18 2020, 8:45 PM · Wikidata, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-Html2Wiki, MediaWiki-extensions-QuickGV, TimedMediaHandler, MediaWiki-General, PHP 8.0 support
MaxSem created T260735: Stop using is_resource().
Aug 18 2020, 8:44 PM · Wikidata, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-Html2Wiki, MediaWiki-extensions-QuickGV, TimedMediaHandler, MediaWiki-General, PHP 8.0 support

Aug 9 2020

Akuckartz awarded T248925: Make MediaWiki compatible with PHP 8 a Like token.
Aug 9 2020, 9:39 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), PHP 8.0 support, MediaWiki-General, MediaWiki-Stakeholders-Group

Aug 6 2020

MaxSem closed T187716: Sunset Wikipedia Zero, a subtask of T106123: Extensions needing to be removed from Wikimedia wikis, as Resolved.
Aug 6 2020, 1:32 PM · Wikimedia-Extension-setup, Tracking-Neverending
MaxSem closed T187716: Sunset Wikipedia Zero as Resolved.

\m/

Aug 6 2020, 1:32 PM · Release-Engineering-Team-TODO, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Epic, Product-Infrastructure-Team-Backlog, Wikimedia-Site-requests
MaxSem updated the task description for T187716: Sunset Wikipedia Zero.
Aug 6 2020, 1:30 PM · Release-Engineering-Team-TODO, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Epic, Product-Infrastructure-Team-Backlog, Wikimedia-Site-requests
MaxSem removed a member for RESTBase-architecture: MaxSem.
Aug 6 2020, 1:14 PM
MaxSem removed a member for Wikidata Query UI: MaxSem.
Aug 6 2020, 1:14 PM
MaxSem removed a member for Maps-Sprint: MaxSem.
Aug 6 2020, 1:13 PM

Jul 3 2020

MaxSem updated subscribers of T256527: Deploy the Commons deletion notification bot on nl.wiktionary [[SMALL]].

Nope, I don't work for WMF anymore. Ping @ifried and @aezell for prioritization.

Jul 3 2020, 6:23 PM · Community-Tech (Kanban-2020-21-Q1), Commons

Jun 25 2020

MaxSem added a comment to T233012: Make MediaWiki core compatible with PHP 7.4.

Examples of what needs to be fixed?

Jun 25 2020, 5:42 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support

May 26 2020

MaxSem merged T174369: Scap sync and sync-file are too similar looking yet do very different things into T250302: Rename `scap sync` to `scap sync-world`.
May 26 2020, 3:19 PM · Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Sustainability (Incident Followup), Patch-For-Review, EngProd-Virtual-Hackathon, Scap
MaxSem merged task T174369: Scap sync and sync-file are too similar looking yet do very different things into T250302: Rename `scap sync` to `scap sync-world`.
May 26 2020, 3:19 PM · Scap

May 25 2020

MaxSem added a comment to T253461: Liberate the @ for AtEase.

However, I fear that if we remove the PHPCS rule, people may start using the operator even when unnecessary, e.g. when accessing array offsets

May 25 2020, 10:43 AM · TechCom, MediaWiki-Codesniffer, Proposal, at-ease, MediaWiki-General

May 20 2020

MaxSem placed T219769: [BUG] Edits and Bytes Changed metrics: Page Improved includes deleted revisions; Event Summary and All Edits do not up for grabs.
May 20 2020, 7:45 PM · Event Metrics
MaxSem placed T153817: Notify users when their user group membership is about to expire, or has expired up for grabs.
May 20 2020, 7:45 PM · Growth-Team, Stewards-and-global-tools (Temporary-UserRights), Collaboration-Team-Triage, Notifications
MaxSem placed T220423: Show "timed out" error to the user when an event update has been running for over an hour up for grabs.
May 20 2020, 7:44 PM · Event Metrics
MaxSem placed T220463: Make jobs not time out in 30 seconds up for grabs.
May 20 2020, 7:44 PM · Event Metrics
MaxSem closed T172752: Tool "osmlint" loads form-me-on-github ribbon from github, a subtask of T172065: Hunt for Toolforge tools that load resources from third party sites, as Resolved.
May 20 2020, 7:43 PM · Privacy Engineering, Toolforge-standards-committee, Tools, Privacy
MaxSem closed T172752: Tool "osmlint" loads form-me-on-github ribbon from github as Resolved.

The tool was long-dead, I've disabled it completely.

May 20 2020, 7:43 PM · Tools

May 7 2020

MaxSem moved T248925: Make MediaWiki compatible with PHP 8 from Backlog to MediaWiki core on the PHP 8.0 support board.
May 7 2020, 2:26 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), PHP 8.0 support, MediaWiki-General, MediaWiki-Stakeholders-Group

May 6 2020

MaxSem committed rEFLI77221523492a: SpecialImportFileIntegrationTest: Fix optional parameter before required (authored by MaxSem).
SpecialImportFileIntegrationTest: Fix optional parameter before required
May 6 2020, 4:07 PM
MaxSem added a comment to T243056: Set up static-codereview.wikimedia.org to host static HTML dump of CodeReview .
May 6 2020, 3:22 PM · Operations, MediaWiki-extensions-CodeReview

Apr 28 2020

MaxSem added a comment to T243056: Set up static-codereview.wikimedia.org to host static HTML dump of CodeReview .

Mhm, maybe put it in a subdomain of mediawiki.org?

Apr 28 2020, 9:32 PM · Operations, MediaWiki-extensions-CodeReview

Apr 22 2020

MaxSem renamed T247990: Tests leak memory under PHP 7.4 and 8 from Tests leak memory under PHP 8 to Tests leak memory under PHP 7.4 and 8.
Apr 22 2020, 8:35 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (External Code Reviews), Patch-For-Review, Upstream, PHP 7.4 support, PHP 8.0 support, MediaWiki-Core-Testing
MaxSem added a comment to T247990: Tests leak memory under PHP 7.4 and 8.

My bisecting indicates that the cause is https://github.com/php/php-src/commit/5161cebe28cca36fa7f7989b5a799290a3f1eb6a

Apr 22 2020, 8:34 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (External Code Reviews), Patch-For-Review, Upstream, PHP 7.4 support, PHP 8.0 support, MediaWiki-Core-Testing

Mar 30 2020

MaxSem created T248925: Make MediaWiki compatible with PHP 8.
Mar 30 2020, 9:31 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), PHP 8.0 support, MediaWiki-General, MediaWiki-Stakeholders-Group
MaxSem updated the task description for T248887: Make testing-access-wrapper compatible with PHP8.
Mar 30 2020, 5:46 PM · PHP 8.0 support, MediaWiki-Core-Testing
MaxSem created T248887: Make testing-access-wrapper compatible with PHP8.
Mar 30 2020, 5:35 PM · PHP 8.0 support, MediaWiki-Core-Testing

Mar 28 2020

MaxSem added a comment to T247934: Required parameter $rules follows optional parameter $value in Directive.php.

PHP 8.0 is not gonna be released anytime soon (late 2021, probably)

Mar 28 2020, 8:56 PM · Technical-Debt, PHP 8.0 support, Performance-Team, MediaWiki-ResourceLoader

Mar 19 2020

MaxSem moved T248110: Create a sniff for: "PHP Deprecated: The behavior of unparenthesized expressions … will change in PHP 8" from Backlog to Other on the PHP 8.0 support board.
Mar 19 2020, 9:42 PM · PHP 8.0 support, PHP 7.4 support, MediaWiki-Codesniffer
MaxSem added a comment to T247934: Required parameter $rules follows optional parameter $value in Directive.php.

I think we should at least try to use Travis' php-nightly to be ready for new PHP's coming.

Mar 19 2020, 8:16 PM · Technical-Debt, PHP 8.0 support, Performance-Team, MediaWiki-ResourceLoader
MaxSem added a project to T248110: Create a sniff for: "PHP Deprecated: The behavior of unparenthesized expressions … will change in PHP 8": PHP 8.0 support.
Mar 19 2020, 5:17 PM · PHP 8.0 support, PHP 7.4 support, MediaWiki-Codesniffer
MaxSem created T248088: Make PHPUnit tests fail on warnings.
Mar 19 2020, 12:46 PM · MobileFrontend (Tracking), Wikidata, MediaWiki-extensions-WikibaseClient, Technical-Debt, MediaWiki-Core-Testing
MaxSem created P10728 wmf-quibble-core-vendor-mysql-php72-docker warnings.
Mar 19 2020, 12:38 PM
MaxSem created T248078: Fix all functions that have required parameters following optional ones.
Mar 19 2020, 11:40 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), MW-1.35-release, MediaWiki-Codesniffer, Technical-Debt, MediaWiki-General, PHP 8.0 support
MaxSem moved T248075: Make MediaWiki ready for PCRE2 from Backlog to MediaWiki core on the PHP 8.0 support board.
Mar 19 2020, 11:10 AM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), MediaWiki-General, PHP 8.0 support
MaxSem created T248075: Make MediaWiki ready for PCRE2.
Mar 19 2020, 10:41 AM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), MediaWiki-General, PHP 8.0 support

Mar 18 2020

MaxSem placed T35704: GeoData should pull coordinates from Wikidata on sites with the Wikibase Client up for grabs.
Mar 18 2020, 5:44 PM · Discovery-Search, MediaWiki-extensions-WikibaseClient, Wikidata, GeoData
MaxSem placed T90645: A better Nearby for Wikivoyage up for grabs.
Mar 18 2020, 5:43 PM · Discovery-Search, Wikimania-Hackathon-2015, GeoData
MaxSem moved T247990: Tests leak memory under PHP 7.4 and 8 from Backlog to MediaWiki core on the PHP 8.0 support board.
Mar 18 2020, 3:20 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (External Code Reviews), Patch-For-Review, Upstream, PHP 7.4 support, PHP 8.0 support, MediaWiki-Core-Testing
MaxSem created T247990: Tests leak memory under PHP 7.4 and 8.
Mar 18 2020, 3:20 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Platform Team Workboards (External Code Reviews), Patch-For-Review, Upstream, PHP 7.4 support, PHP 8.0 support, MediaWiki-Core-Testing
MaxSem moved T247934: Required parameter $rules follows optional parameter $value in Directive.php from Backlog to MediaWiki core on the PHP 8.0 support board.
Mar 18 2020, 9:51 AM · Technical-Debt, PHP 8.0 support, Performance-Team, MediaWiki-ResourceLoader
MaxSem created T247934: Required parameter $rules follows optional parameter $value in Directive.php.
Mar 18 2020, 9:50 AM · Technical-Debt, PHP 8.0 support, Performance-Team, MediaWiki-ResourceLoader

Mar 17 2020

MaxSem added a watcher for PHP 8.0 support: MaxSem.
Mar 17 2020, 7:00 PM
MaxSem created T247895: Please create a tag for PHP 8.0 support.
Mar 17 2020, 6:50 PM · Phabricator

Feb 27 2020

MaxSem added a comment to T237696: Wikimedia deployers audit.

Your stats are wrong if they think it was more than 2 years since I've deployed:) And I'm not in the deployers group anymore either. Anyway, I was under the impressionthat my account was reenabled to keep me in the WMF-NDA LDAP group, as requested in T238960.

Feb 27 2020, 1:00 PM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release-Engineering-Team (Deployment services), user-sbassett, Security, Security-Team

Jan 23 2020

MaxSem added a comment to T192167: Upgrade PHPUnit from 4/6 to 8.

Yeah, time to pull the trigger.

Jan 23 2020, 5:59 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing

Jan 21 2020

MaxSem added a comment to T192167: Upgrade PHPUnit from 4/6 to 8.

Current status:

Jan 21 2020, 4:55 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing
MaxSem added a subtask for T192167: Upgrade PHPUnit from 4/6 to 8: T243296: Release a new version of WikibaseCodeSniffer.
Jan 21 2020, 4:47 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing
MaxSem added a parent task for T243296: Release a new version of WikibaseCodeSniffer: T192167: Upgrade PHPUnit from 4/6 to 8.
Jan 21 2020, 4:47 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, MediaWiki-Codesniffer, Wikidata
MaxSem created T243296: Release a new version of WikibaseCodeSniffer.
Jan 21 2020, 4:47 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, MediaWiki-Codesniffer, Wikidata

Jan 20 2020

MaxSem committed rEWCS3fc9b94a43e5: Fix PHPUnit 8 warnings (authored by MaxSem).
Fix PHPUnit 8 warnings
Jan 20 2020, 9:46 PM
MaxSem committed rEFLI3612fe9e1c76: Fix PHPUnit 8 warnings (authored by MaxSem).
Fix PHPUnit 8 warnings
Jan 20 2020, 4:03 PM

Jan 17 2020

MaxSem committed rEPS986292a08ad5: Make tests pass on PHPUnit 8 (authored by MaxSem).
Make tests pass on PHPUnit 8
Jan 17 2020, 4:37 PM

Jan 16 2020

MaxSem committed rELUA0d6a4da3d578: Make tests pass on PHPUnit 8 (authored by MaxSem).
Make tests pass on PHPUnit 8
Jan 16 2020, 5:36 PM

Jan 15 2020

MaxSem closed T242914: Receiving emails from projects I'm no longer a member of as Invalid.

Never mind, mixed up tools and VPS projects.

Jan 15 2020, 8:34 PM · Toolforge
MaxSem created T242914: Receiving emails from projects I'm no longer a member of.
Jan 15 2020, 8:27 PM · Toolforge

Dec 20 2019

MaxSem added a comment to T75181: Remove HHVM and PHP7 revision tags.

Did you also delete the php7 tag?

Dec 20 2019, 2:01 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-WikimediaMaintenance, HHVM, Wikimedia-General-or-Unknown

Dec 16 2019

MaxSem added a comment to T240307: Hook container with strong types and DI.

One thing to discuss here is the guidelines of how to evolve code using this approach: previously, you could add a new parameter to a hook and it will just work™️ with existing hook handlers. Even some parameter type changes were possible. Not the case in this RFC: existing hook handlers can't be changed easily.

Dec 16 2019, 10:48 AM · Platform Team Workboards (Epics), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), MW-1.33-notes, MW-1.31-release-notes, MW-1.34-notes, Platform Team Initiatives (New Hook System), MediaWiki-Core-Hooks, Dependency injection, TechCom-RFC (TechCom-RFC-Closed), User-Daniel, Platform Engineering

Dec 11 2019

MaxSem closed T71014: PhpTags does not pass all tests under hhvm/hiphop as Invalid.

This issue is moot now that HHVM is incompatible with PHP and MediaWiki doesn't support it.

Dec 11 2019, 5:17 PM · Patch-For-Review, MediaWiki-extensions-PhpTags
MaxSem closed T102256: HHVM and PhpTags 5.1: In nested foreach loop, the inner loop corrupts the array of the outer loop, a subtask of T71014: PhpTags does not pass all tests under hhvm/hiphop, as Invalid.
Dec 11 2019, 5:16 PM · Patch-For-Review, MediaWiki-extensions-PhpTags
MaxSem closed T102256: HHVM and PhpTags 5.1: In nested foreach loop, the inner loop corrupts the array of the outer loop as Invalid.

This issue is moot now that HHVM is incompatible with PHP and MediaWiki doesn't support it.

Dec 11 2019, 5:16 PM · MediaWiki-extensions-PhpTags
MaxSem closed T104632: HHVM array data corruption when using the MW extension PhpTags, a subtask of T102256: HHVM and PhpTags 5.1: In nested foreach loop, the inner loop corrupts the array of the outer loop, as Invalid.
Dec 11 2019, 5:16 PM · MediaWiki-extensions-PhpTags
MaxSem closed T104632: HHVM array data corruption when using the MW extension PhpTags as Invalid.

This issue is moot now that HHVM is incompatible with PHP and MediaWiki doesn't support it.

Dec 11 2019, 5:16 PM · Upstream, MediaWiki-extensions-PhpTags, HHVM

Dec 10 2019

MaxSem added a comment to T192167: Upgrade PHPUnit from 4/6 to 8.

@MaxSem Another thing I've come across: assertArraySubset will be removed in PHPUnit 9 with no alternative method (https://github.com/sebastianbergmann/phpunit/issues/3494). I see several usages around. I was thinking whether we should:

  1. Just stop using it, although it's not always clear what the replacement should be (usually, a long list of assertArrayHasKey and assertEquals)
  2. Re-implement it in a trait in MW core
  3. Use https://github.com/rdohms/phpunit-arraysubset-asserts as suggested by Sebastian on the issue linked above.

I'd say either 1 or 3. If 3, we should update PHPCS because the new version will forbid usage of assertArraySubset.

Dec 10 2019, 1:35 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing

Dec 9 2019

MaxSem removed a watcher for acl*security: MaxSem.
Dec 9 2019, 4:36 PM

Dec 8 2019

MaxSem added a comment to T192167: Upgrade PHPUnit from 4/6 to 8.

@RazeSoldier, what PHP version? What's the error Composer emits?

Dec 8 2019, 11:22 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing

Dec 6 2019

MaxSem removed a watcher for MediaWiki-extensions-CodeMirror: MaxSem.
Dec 6 2019, 5:03 PM
MaxSem removed a member for Community-Tech: MaxSem.
Dec 6 2019, 5:02 PM
MaxSem added a comment to T239047: Check home leftovers of maxsem.

Everything can be safely deleted.

Dec 6 2019, 3:52 PM · Analytics

Dec 4 2019

MaxSem added a watcher for PHP 7.2 support: MaxSem.
Dec 4 2019, 7:05 PM
MaxSem added a watcher for PHP 7.3 support: MaxSem.
Dec 4 2019, 7:04 PM
MaxSem added a watcher for PHP 7.4 support: MaxSem.
Dec 4 2019, 7:04 PM

Dec 3 2019

MaxSem added a comment to T233012: Make MediaWiki core compatible with PHP 7.4.

https://gerrit.wikimedia.org/r/554202 fixes it.

Dec 3 2019, 3:57 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support
MaxSem added a comment to T233012: Make MediaWiki core compatible with PHP 7.4.

And of course, it's not documented in https://www.php.net/manual/en/ini.list.php.

Dec 3 2019, 2:22 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support
MaxSem added a comment to T233012: Make MediaWiki core compatible with PHP 7.4.

Weird. I skimmed through PHP 7.4 UPGRADING, and couldn't find anything interesting. I've also tested the faulty code on 3v4l (I still have to install PHP 7.4 locally), but the trace seems to have an object there.

Dec 3 2019, 1:59 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support

Nov 26 2019

MaxSem added a comment to T238960: Conversion to volunteer NDA for MaxSem.

Sent.

Nov 26 2019, 11:34 AM · LDAP-Access-Requests, Operations, SRE-Access-Requests

Nov 25 2019

Niharika awarded T238960: Conversion to volunteer NDA for MaxSem a Love token.
Nov 25 2019, 8:52 PM · LDAP-Access-Requests, Operations, SRE-Access-Requests

Nov 22 2019

MaxSem placed T233969: Update Temporary Password Email with Preference Info [x-small] up for grabs.
Nov 22 2019, 11:27 PM · Community-Tech (Kanban-Q3-2019-20), MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Password-Reset-Update
MaxSem placed T238385: Links in table of contents don't work for certain characters up for grabs.
Nov 22 2019, 11:07 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Patch-For-Review, TechCom, Readers-Web-Backlog (Tracking), MediaWiki-Parser
MaxSem created T238960: Conversion to volunteer NDA for MaxSem.
Nov 22 2019, 10:40 PM · LDAP-Access-Requests, Operations, SRE-Access-Requests

Nov 21 2019

MaxSem closed T216734: Drop devDependency on phpunit-mock-objects, which is abandoned and warns against use as Resolved.

Gone after we upgraded to PHPUnit 7 in https://gerrit.wikimedia.org/r/552166.

Nov 21 2019, 8:43 PM · Technical-Debt, MediaWiki-Core-Testing
MaxSem committed rEPSccdc4868762f: Fix PHPUnit 7 compatibility (authored by MaxSem).
Fix PHPUnit 7 compatibility
Nov 21 2019, 7:53 PM
MaxSem added a comment to T238076: Alert group Cookie(s) without Secure flag set.

Probably has something to do with us not being HTTPS only back then.

Nov 21 2019, 6:53 PM · MobileFrontend, Security, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Tracking)
MaxSem added a comment to T192167: Upgrade PHPUnit from 4/6 to 8.
Nov 21 2019, 3:26 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing

Nov 20 2019

MaxSem added a comment to T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets [high priority].

That sounds like API responses are getting cached?

Nov 20 2019, 9:57 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Community-Tech (Kanban-Q2-2019-20), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Growth-Team, PageCuration

Nov 19 2019

MaxSem committed rECIR695162522fc8: Fixes for PHPUnit 8 compatibility (authored by MaxSem).
Fixes for PHPUnit 8 compatibility
Nov 19 2019, 8:11 PM
MaxSem committed rEFLIa33900f3f711: Suppress PHPUnit 8 warnings (authored by MaxSem).
Suppress PHPUnit 8 warnings
Nov 19 2019, 7:33 PM
MaxSem committed rEWSO4fa5339a762e: Declare types everywhere and force strict_types = 1 (authored by MaxSem).
Declare types everywhere and force strict_types = 1
Nov 19 2019, 3:23 PM
MaxSem moved T207485: Enable page curation tools to be loaded on any page (optionally) from Needs Review/Feedback to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.
Nov 19 2019, 4:51 AM · Community-Tech (Kanban-Q2-2019-20), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), PageCuration, Growth-Team

Nov 18 2019

MaxSem committed rESHGb591e2cdab4b: Remove 2 unused functions deprecated 5 years ago (authored by MaxSem).
Remove 2 unused functions deprecated 5 years ago
Nov 18 2019, 10:42 AM

Nov 17 2019

MaxSem committed rEWPLfbc57e887bba: Stop passing objects by reference (authored by MaxSem).
Stop passing objects by reference
Nov 17 2019, 1:54 PM

Nov 16 2019

MaxSem committed rETBL6948b3c5cf14: Stop passing objects by reference (authored by MaxSem).
Stop passing objects by reference
Nov 16 2019, 2:34 PM
MaxSem committed rEWETb31b8e7c7f8b: Stop passing objects by reference (authored by MaxSem).
Stop passing objects by reference
Nov 16 2019, 2:23 PM
MaxSem moved T238466: Deprecate GlobalPreferencesFactory::setUser() [medium] from Unsorted to Needs refactor on the Technical-Debt board.
Nov 16 2019, 6:07 AM · Community-Tech (Kanban-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Technical-Debt, MediaWiki-extensions-GlobalPreferences
MaxSem created T238466: Deprecate GlobalPreferencesFactory::setUser() [medium].
Nov 16 2019, 6:07 AM · Community-Tech (Kanban-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Technical-Debt, MediaWiki-extensions-GlobalPreferences