MaxSem (Max Semenik)
User

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:37 PM (185 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
MaxSem

Recent Activity

Today

MaxSem added a comment to T190425: GlobalPreferences deploy caused a significant increase in reads on s3.


Nah, still noticeable load.

Thu, Apr 26, 1:18 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences

Tue, Apr 24

MaxSem added a comment to T190425: GlobalPreferences deploy caused a significant increase in reads on s3.

With caching in place, we will try another time at 15:00 SF this Wednesday.

Tue, Apr 24, 2:19 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences

Mon, Apr 23

MaxSem added a comment to T192638: LoginNotify should inform users of failed login attempts in the language of their home wiki.

This should be resolved when we roll out GlobalPreferences - you will be able to set a global interface language.

Mon, Apr 23, 8:20 PM · MediaWiki-extensions-LoginNotify

Sat, Apr 21

MaxSem added a comment to T192695: Move GeoJSON for <mapframe> tags to its own table instead of page_props.

I think @MaxSem was working on this a while back, and might have even had some code. ]

Sat, Apr 21, 1:23 AM · Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps (Kartographer)

Fri, Apr 20

MaxSem closed T192638: LoginNotify should inform users of failed login attempts in the language of their home wiki as Declined.

The rule is that all interface is presented in the language the user chose in their preferences or wiki's default language if no choice have been made. We don't violate this rule with other cross-wiki notifications and I don't see why we should do this with LoginNotify.

Fri, Apr 20, 6:30 PM · MediaWiki-extensions-LoginNotify
MaxSem added a comment to T190348: Improve usability of TemplateWizard.

There's no way that a curated list is going to be useful because it's literally a selection of 5 out of 400K. Especially since people tend to stick to their own areas that have their own set of popular templates.

Fri, Apr 20, 6:25 PM · Community-Tech, MediaWiki-extensions-TemplateWizard
MaxSem added a comment to T112948: All map location names should be in the user's language.

The way Mapnik works, it's much easier to create a repository of fonts and use it - which is what we're doing. Note that it's impossible to just point it at a directory with fonts - they have to be listed in the style's XML file. As of particular fonts, we standardised on Google's Noto fonts that provide consistent styling across different alphabets.

Fri, Apr 20, 7:16 AM · Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps (Map-Styles), I18n

Wed, Apr 18

MaxSem created T192503: Don't blindly delete and reinsert all settings on save.
Wed, Apr 18, 9:25 PM · Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences
MaxSem added a comment to T73379: Upgrade patches for tarball releases don't apply cleanly to tarball installation.

Are patches even useful these days when download speed is much less of a problem than 20 years ago?

Wed, Apr 18, 1:06 AM · MediaWiki-Releasing, MW-1.31-release, Release-Engineering-Team
MaxSem closed T182741: Determine whether firejail shell restrictions can be enabled by default as Resolved.

The above patch has been merged, so all executions using the new API are now restricted by default.

Wed, Apr 18, 1:03 AM · Patch-For-Review, MW-1.31-release, MediaWiki-Shell

Mon, Apr 16

MaxSem added a comment to T112948: All map location names should be in the user's language.

Basically, you need to update the fonts repository, possibly by updating https://github.com/kartotherian/osm-bright.fonts/blob/master/scripts/copy-fonts.py
and then run https://github.com/kartotherian/osm-bright.tm2/blob/master/scripts/update-mss.py to update the style.

Mon, Apr 16, 9:03 PM · Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps (Map-Styles), I18n

Fri, Apr 13

MaxSem added a comment to T192166: Drop HHVM support from MediaWiki.

Yeah, but do we want to waste our time and hardware resources on running HHVM tests on master then? :)

Fri, Apr 13, 7:52 PM · Patch-For-Review, MediaWiki-Platform-Team, PHP 7.0 support, HHVM
MaxSem added a comment to T192166: Drop HHVM support from MediaWiki.

Practically, the second WMF finishes its switch back to Zend HHVM support will crash and burn, so my own feeling is that we should aim towards removing HHVM specific hacks and adding a warning in installer that whomever using it is doing so at their own peril.

Fri, Apr 13, 6:35 PM · Patch-For-Review, MediaWiki-Platform-Team, PHP 7.0 support, HHVM
MaxSem added a comment to T192159: Requesting access to deployment for pmiazga.
Fri, Apr 13, 6:32 PM · Release-Engineering-Team, Gerrit, Operations, Ops-Access-Requests

Thu, Apr 12

MaxSem added a comment to T188151: Create the Commons deletion bot which will post messages on article talk pages.

*scratches head*

Thu, Apr 12, 10:42 PM · Community-Tech-Sprint, Commons
MaxSem added a comment to T188151: Create the Commons deletion bot which will post messages on article talk pages.

First of all, this information is not available to the bot at all - watchlists are considered private information. Had it been, I would have likely figured something tolerably performing.

Thu, Apr 12, 10:07 PM · Community-Tech-Sprint, Commons
Liuxinyu970226 awarded T172165: Require either PHP 7.0+ or HHVM in MW 1.31 a Like token.
Thu, Apr 12, 10:54 AM · MW-1.31-release-notes, MW-1.31-release, Patch-For-Review, TechCom-RFC (TechCom-Approved), MediaWiki-General-or-Unknown
MaxSem added a comment to T190425: GlobalPreferences deploy caused a significant increase in reads on s3.

This measure is definitely good, however the overload happens on the local database, not centralauth.

Thu, Apr 12, 4:35 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences
MaxSem added a comment to T190425: GlobalPreferences deploy caused a significant increase in reads on s3.

We tried running it for ~1 hour, got the same increase in DB load. The new logging is available in the preferences channel. @Samwilson says he has some ideas.

Thu, Apr 12, 1:19 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences

Wed, Apr 11

MaxSem moved T190353: Argument 1 passed to CentralIdLookup::namesFromCentralIds() must be an instance of array, string given from Needs Review/Feedback to Done on the Community-Tech-Sprint board.
Wed, Apr 11, 11:54 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Community-Tech-Sprint, Notifications, Collaboration-Team-Triage, MediaWiki-extensions-GlobalPreferences
MaxSem closed T190353: Argument 1 passed to CentralIdLookup::namesFromCentralIds() must be an instance of array, string given, a subtask of T189806: Deploy GlobalPrefs on production, as Resolved.
Wed, Apr 11, 11:54 PM · Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-GlobalPreferences
MaxSem closed T190353: Argument 1 passed to CentralIdLookup::namesFromCentralIds() must be an instance of array, string given as Resolved.
Wed, Apr 11, 11:54 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Community-Tech-Sprint, Notifications, Collaboration-Team-Triage, MediaWiki-extensions-GlobalPreferences
RandomDSdevel awarded T190374: Rollback gets both "mw-rollback" and "mw-undo" tags a Grey Medal token.
Wed, Apr 11, 10:11 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), Community-Tech-Sprint, MediaWiki-Page-editing, Regression
MaxSem added a comment to T191746: Bundle LoginNotify extension with MW 1.31.

Does the installer support extension dependencies now?

Wed, Apr 11, 6:57 PM · MediaWiki-extensions-LoginNotify, MW-1.31-release, MediaWiki-Releasing
MaxSem added a parent task for T192013: Remove DMOZ support completely: T128326: De-deploy the RelatedSites extension (used on Wikivoyage).
Wed, Apr 11, 6:27 PM · Wikimedia-Site-requests, MediaWiki-extensions-RelatedSites
MaxSem added a subtask for T128326: De-deploy the RelatedSites extension (used on Wikivoyage): T192013: Remove DMOZ support completely.
Wed, Apr 11, 6:26 PM · Readers-Web-Backlog (Tracking), Community-Liaisons, User-notice, MediaWiki-extensions-RelatedSites, Technical-Debt, Wikimedia-Site-requests
MaxSem created T192013: Remove DMOZ support completely.
Wed, Apr 11, 6:26 PM · Wikimedia-Site-requests, MediaWiki-extensions-RelatedSites
MaxSem added a comment to T188150: Create list of talk pages that need to be updated based on Commons image deletion workflows.

That's an interesting question. Since there's nobody in the team who can review this, I guess we can just decide that code review is "it's good if it works".

Wed, Apr 11, 2:39 AM · Community-Tech-Sprint, Commons

Tue, Apr 10

MaxSem added a comment to T190425: GlobalPreferences deploy caused a significant increase in reads on s3.

@Marostegui and @jcrespo, we've fixed the other problems and introduced logging to pinpoint this bug. I'd like to try deploying to group0 wikis again to see how it works now and collect some logs - is that fine by you?

Tue, Apr 10, 8:07 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences
MaxSem added a comment to T174388: LoginNotify should inform users of the IP address of failed login attempts to their account.

Hmm, can we just pass cu_changes.cuc_id and load from Checkuser data, thus keeping all the private information in one place?

Tue, Apr 10, 7:22 PM · Patch-For-Review, Notifications, Collaboration-Team-Triage, User-Huji, Community-Tech, Privacy, WMF-Legal, MediaWiki-extensions-LoginNotify

Mon, Apr 9

MaxSem added a comment to T189045: Automatic edit summaries should not trigger edit summary pings.

Confirm that autosummary triggers a ping. Is it really a behavior we don't want?

Mon, Apr 9, 10:32 PM · Community-Tech, Notifications, Collaboration-Team-Triage
MaxSem added a comment to T190425: GlobalPreferences deploy caused a significant increase in reads on s3.

We decided to add more logging as a starting point.

Mon, Apr 9, 8:45 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences
MaxSem updated subscribers of T188434: Perform code steward process for #geodata extension.

I believe GD id now search team's responsibility, adding @EBjune.

Mon, Apr 9, 6:28 PM · Discovery-Search, GeoData, Code-Stewardship-Reviews

Fri, Apr 6

MaxSem added a comment to T191655: Deploy maps internationalization to production.
  1. Should also include updating the style which will be dependent on vectors.
Fri, Apr 6, 9:21 PM · User-notice-collaboration, Patch-For-Review, I18n, Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps
MaxSem added a comment to T178349: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites.

I've poked around a few third-party wikis with LU installed - none of them had a week old core message update. From that I can conclude that either nobody pays attention to configure it or I don't know how this extension works😊

Fri, Apr 6, 8:58 PM · Patch-For-Review, MW-1.31-release, MediaWiki-Releasing, MediaWiki-Installer
RandomDSdevel awarded T141670: Templates are parsed in AbuseLog a Barnstar token.
Fri, Apr 6, 7:48 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), AbuseFilter, Security

Thu, Apr 5

MaxSem added a comment to T178349: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites.

Is "$wgMFAutodetectMobileView = true;" required?

Depends on how you want to run the wiki, but 99% of users probably want this. I'm tempted to say that we should just change the default.

Thu, Apr 5, 10:36 PM · Patch-For-Review, MW-1.31-release, MediaWiki-Releasing, MediaWiki-Installer
MaxSem added a comment to T190425: GlobalPreferences deploy caused a significant increase in reads on s3.

I'll discuss the action plan with Sam.

Thu, Apr 5, 10:14 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences
MaxSem added a comment to T178349: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites.

LocalisationUpdate also requires a cronjob to function. Besides, I reeeally don't think that many third-party wikis would be interested in it unless they're running bleeding edge like we do.

Thu, Apr 5, 9:47 PM · Patch-For-Review, MW-1.31-release, MediaWiki-Releasing, MediaWiki-Installer

Wed, Apr 4

MaxSem removed projects from T35704: GeoData should pull coordinates from Wikidata on sites with the Wikibase Client: § Wikidata-Sprint-2015-03-11, § Wikidata-Sprint-2015-02-25, § Wikidata-Sprint-2015-02-03, § Wikidata-Sprint-2015-01-21, Patch-For-Review, Wikipedia-Android-App-Backlog.
Wed, Apr 4, 5:23 PM · MediaWiki-extensions-WikibaseClient, Wikidata, GeoData

Tue, Apr 3

MaxSem added a comment to T190354: Wikimedia\Rdbms\Database::query: lost connection to {dbserver}; reconnected.

Might be fixed by Aaron's https://gerrit.wikimedia.org/r/#/c/423783/

Tue, Apr 3, 8:59 PM · Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences

Mon, Apr 2

MaxSem moved T188151: Create the Commons deletion bot which will post messages on article talk pages from Ready to In Development on the Community-Tech-Sprint board.
Mon, Apr 2, 10:19 PM · Community-Tech-Sprint, Commons
MaxSem moved T188150: Create list of talk pages that need to be updated based on Commons image deletion workflows from In Development to Needs Review/Feedback on the Community-Tech-Sprint board.

Done in https://github.com/MaxSem/CommonsNotifier. Technically, it doesn't generate the list of pages - only files to notify about - but I decided that page selection should be better done in the posting part.

Mon, Apr 2, 10:19 PM · Community-Tech-Sprint, Commons
MaxSem closed T161036: Warning: ZeroAPI: Unable to parse json of page Zero: as Resolved.

Don't see anything in logs anymore.

Mon, Apr 2, 8:09 PM · Patch-For-Review, Wikimedia-log-errors, Zero
MaxSem added a comment to T190381: Figure out XAnalytics stuff.

No I don't.

Mon, Apr 2, 5:48 PM · Readers-Web-Backlog (Tracking), Performance-Team (Radar), Technical-Debt, Analytics, MobileFrontend

Fri, Mar 30

MaxSem triaged T191130: [Regression] Retina tiles don't work (anymore?) as High priority.
Fri, Mar 30, 11:30 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression, Maps (Kartotherian)

Wed, Mar 28

MaxSem moved T188798: Change the limit of the edit summary to 500 characters on all Wikimedia wikis from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.
Wed, Mar 28, 11:24 PM · Patch-For-Review, Community-Tech-Sprint, MediaWiki-Page-editing
MaxSem moved T188150: Create list of talk pages that need to be updated based on Commons image deletion workflows from Ready to In Development on the Community-Tech-Sprint board.
Wed, Mar 28, 11:24 PM · Community-Tech-Sprint, Commons
MaxSem moved T190425: GlobalPreferences deploy caused a significant increase in reads on s3 from Ready to In Development on the Community-Tech-Sprint board.
Wed, Mar 28, 11:24 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences
MaxSem closed T190374: Rollback gets both "mw-rollback" and "mw-undo" tags as Resolved.
Wed, Mar 28, 6:42 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), Community-Tech-Sprint, MediaWiki-Page-editing, Regression
MaxSem closed T190374: Rollback gets both "mw-rollback" and "mw-undo" tags, a subtask of T32750: [Epic] Ping/notify user when username used in an edit summary, as Resolved.
Wed, Mar 28, 6:42 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Epic, Community-Wishlist-Survey-2017, Community-Tech, Collaboration-Team-Triage, Notifications, MediaWiki-Page-editing
MaxSem moved T190374: Rollback gets both "mw-rollback" and "mw-undo" tags from Ready to Done on the Community-Tech-Sprint board.
Wed, Mar 28, 6:42 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), Community-Tech-Sprint, MediaWiki-Page-editing, Regression

Mar 26 2018

MaxSem claimed T190374: Rollback gets both "mw-rollback" and "mw-undo" tags.
Mar 26 2018, 10:24 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), Community-Tech-Sprint, MediaWiki-Page-editing, Regression

Mar 24 2018

MaxSem added a comment to T190425: GlobalPreferences deploy caused a significant increase in reads on s3.

We are logging SQL queries for testwiki (testwiki.log). I've done some slicing throught these, however the enabling on GP roughly coincides with train deployment of a new MW version, making precise analysis hard. Specifically, there's a huge increase in external store queries (due to some MCR work? due to somehow increased traffic?):

maxsem@mwlog1001:~$ for file in *qc.log; do total=`wc -l $file`; count=`grep 'SELECT  blob_text' $file | wc -l`; echo "$file $count $total" ; done
21qc.log 81270 305302 21qc.log
22qc.log 3714588 4874350 22qc.log
23qc.log 1926239 2836952 23qc.log

And a corresponding increase in readonly checks:

maxsem@mwlog1001:~$ for file in *qc.log; do total=`wc -l $file`; count=`grep "SHOW GLOBAL VARIABLES LIKE 'read_only'" $file | wc -l`; echo "$file $count $total" ; done
21qc.log 14419 305302 21qc.log
22qc.log 658799 4874350 22qc.log
23qc.log 326875 2836952 23qc.log

Neither of these dropped after GP was disabled, so clearly a wrong lead. @Marostegui, is there a record of which queries were causing the slowdown somewhere in Tendril?

Mar 24 2018, 2:45 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences

Mar 23 2018

MaxSem added a comment to T190451: Find out who maintains http://hikebikemap.org/.

@cmarqu, you got permission from the old Toolserver admins. That project had scope that allowed projects related to either Wikimedia or OpenStreetMap. This here is Wikimedia Cloud that is run by a different organization and has different rules. We only allow stuff that that benefits Wikimedia projects and Toolserver rules aren't grandfathered.

Mar 23 2018, 6:31 PM · cloud-services-team, Cloud-VPS, Tools
MaxSem closed T183680: firejail < 0.9.50 doesn't support --seccomp=@default as Resolved.
Mar 23 2018, 5:52 AM · MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Patch-For-Review, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), MediaWiki-Shell

Mar 22 2018

MaxSem added a comment to T190451: Find out who maintains http://hikebikemap.org/.

Heaviest hikebike tile users:

root@maps-tiles3:/var/log/apache2# grep /hikebike/ other_vhosts_access.log | awk '{ print $9; }' | grep http | grep -oP '(?<=://)[^/"]*' | sort | uniq -c | sort -rn | head -n 100
1165417 www.gpsies.com
 238723 www.apemap.com
  94155 hikebikemap.org
  55847 m.gpsies.com
  20521 www.hikebikemap.org
   9791 www.mazovia.zamanagroup.pl
   9705 routen.vfdnet.de
   7980 leaflet-extras.github.io
   7149 www.gaiagps.com
   6668 osmapa.pl
   5545 www.mazoviamtb.pl
   5202 rowery.rbgp.pl
Mar 22 2018, 11:40 PM · cloud-services-team, Cloud-VPS, Tools
MaxSem claimed T190425: GlobalPreferences deploy caused a significant increase in reads on s3.

Grabbing this because I unlike Sam have prod access for investigation.

Mar 22 2018, 8:58 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences
MaxSem updated the task description for T189806: Deploy GlobalPrefs on production.
Mar 22 2018, 8:46 PM · Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-GlobalPreferences
MaxSem added a comment to T164869: Rate limiter (pingLimiter) in combination with XCache never expires (users get locked out).

I would argue that this bug makes XCache incompatible with MW. Do we have a maintainer for it?

Mar 22 2018, 8:18 PM · MediaWiki-User-management, MediaWiki-Cache

Mar 21 2018

MaxSem added a comment to T189806: Deploy GlobalPrefs on production.

Noticeable increase of traffic on a s7 DB server corresponding to the time GP was enabled:

15:18 <+logmsgbot> !log maxsem@tin Synchronized wmf-config/InitialiseSettings.php: https://gerrit.wikimedia.org/r/#/c/421185/ (duration: 01m 15s)
15:32 <+logmsgbot> !log maxsem@tin Synchronized wmf-config/InitialiseSettings.php: Revert global prefs (duration: 01m 15s)
Mar 21 2018, 10:55 PM · Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-GlobalPreferences
MaxSem added a comment to T189806: Deploy GlobalPrefs on production.

Update: after 14 minutes on non-WP wikis, I had to revert because of shenanigans in the logs that were submitted as 2 above bugs. Leaving the extension enabled on test wikis for now as it hadn't caused any problems there so far.

Mar 21 2018, 10:47 PM · Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-GlobalPreferences
MaxSem added a subtask for T189806: Deploy GlobalPrefs on production: T190354: Wikimedia\Rdbms\Database::query: lost connection to {dbserver}; reconnected.
Mar 21 2018, 10:41 PM · Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-GlobalPreferences
MaxSem added a parent task for T190354: Wikimedia\Rdbms\Database::query: lost connection to {dbserver}; reconnected: T189806: Deploy GlobalPrefs on production.
Mar 21 2018, 10:41 PM · Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences
MaxSem created T190354: Wikimedia\Rdbms\Database::query: lost connection to {dbserver}; reconnected.
Mar 21 2018, 10:41 PM · Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences
MaxSem added a parent task for T190353: Argument 1 passed to CentralIdLookup::namesFromCentralIds() must be an instance of array, string given: T189806: Deploy GlobalPrefs on production.
Mar 21 2018, 10:36 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Community-Tech-Sprint, Notifications, Collaboration-Team-Triage, MediaWiki-extensions-GlobalPreferences
MaxSem added a subtask for T189806: Deploy GlobalPrefs on production: T190353: Argument 1 passed to CentralIdLookup::namesFromCentralIds() must be an instance of array, string given.
Mar 21 2018, 10:36 PM · Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-GlobalPreferences
MaxSem created T190353: Argument 1 passed to CentralIdLookup::namesFromCentralIds() must be an instance of array, string given.
Mar 21 2018, 10:36 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Community-Tech-Sprint, Notifications, Collaboration-Team-Triage, MediaWiki-extensions-GlobalPreferences
MaxSem added a comment to T189636: Undefined indexes in CollectionPageTemplate.php.

I think CollectionSession::getCollection() is returning a bogus empty collection.

Mar 21 2018, 6:26 PM · Wikimedia-log-errors, Collection

Mar 20 2018

MaxSem added a comment to T184121: Deploy checklist for GlobalPreferences on production.

The above changes were reverted because we're still not ready, but quick testing indicated that the extension worked fine in production.

Mar 20 2018, 11:06 PM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Patch-For-Review, Wikimedia-Site-requests, Community-Tech, MediaWiki-extensions-GlobalPreferences

Mar 18 2018

MaxSem added a comment to T186939: Create and apply PHPCS and eslint rules for if else blocks with missing `else`s?.

Looks like an atavism from C where these worked as scope limiters, but they're pointless in PHP.

Mar 18 2018, 6:36 PM · Continuous-Integration-Config, MediaWiki-Codesniffer
MaxSem added a comment to T141750: <maplink> and/or <mapframe>: clickable marker area too big.

What's the plan with library updates? Just remember to repply the fix manually?

Mar 18 2018, 6:17 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Maps (Kartographer)
MaxSem moved T183756: Detect global functions definied inside static functions from Accepted rule changes to In progress on the MediaWiki-Codesniffer board.
Mar 18 2018, 7:52 AM · Patch-For-Review, MediaWiki-Codesniffer

Mar 17 2018

Liuxinyu970226 awarded T189819: Revert to last revision by user should not mention a Like token.
Mar 17 2018, 12:44 PM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Community-Tech-Sprint, Collaboration-Team-Triage, Notifications
MaxSem moved T182057: Look for @parma typo (should be @param) from Accepted rule changes to In progress on the MediaWiki-Codesniffer board.
Mar 17 2018, 5:52 AM · Patch-For-Review, MediaWiki-Codesniffer
MaxSem claimed T182057: Look for @parma typo (should be @param).
Mar 17 2018, 2:11 AM · Patch-For-Review, MediaWiki-Codesniffer
MaxSem updated the task description for T122754: Pre MW 1.21 deprecation cleanup.
Mar 17 2018, 12:22 AM · MW-1.28-release-notes, Technical-Debt, MW-1.27-release-notes, Tracking, MediaWiki-General-or-Unknown

Mar 16 2018

MaxSem moved T189819: Revert to last revision by user should not mention from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.
Mar 16 2018, 9:36 PM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Community-Tech-Sprint, Collaboration-Team-Triage, Notifications
MaxSem added a comment to T189879: Set up a Nominatim instance to avoid geocode lookups with Google and/or OSM from tools.

Note that Nominatim doesn't work against a vanilla OSM database - you'll need another copy, this time with its own osm2pgsql style. Luckily, this copy is much smaller.

Mar 16 2018, 6:25 PM · Tools, Maps (Maps-data)
MaxSem renamed T189879: Set up a Nominatim instance to avoid geocode lookups with Google and/or OSM from tools from Set up a Nominatum instance to avoid geocode lookups with Google and/or OSM from tools to Set up a Nominatim instance to avoid geocode lookups with Google and/or OSM from tools.
Mar 16 2018, 6:16 PM · Tools, Maps (Maps-data)
Daimona awarded T189819: Revert to last revision by user should not mention a Like token.
Mar 16 2018, 10:05 AM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Community-Tech-Sprint, Collaboration-Team-Triage, Notifications
MaxSem added a comment to T114846: Enable PhanUndeclaredVariable rule in MediaWiki core.

In the light of Phan being available, it this still relevant?

Mar 16 2018, 7:25 AM · MediaWiki-Core-Tests
matej_suchanek awarded T189819: Revert to last revision by user should not mention a Like token.
Mar 16 2018, 7:14 AM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Community-Tech-Sprint, Collaboration-Team-Triage, Notifications
MaxSem merged task T189853: Wikibase qunit test failures into T189329: jquery.wikibase.edittoolbar and other qunit tests are flaky.
Mar 16 2018, 1:50 AM · Wikidata
MaxSem merged T189853: Wikibase qunit test failures into T189329: jquery.wikibase.edittoolbar and other qunit tests are flaky.
Mar 16 2018, 1:50 AM · Wikimedia-log-errors (Jenkins Failure), MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Patch-For-Review, MediaWiki-extensions-WikibaseRepository, Wikidata
Cyberpower678 awarded T189819: Revert to last revision by user should not mention a Like token.
Mar 16 2018, 12:22 AM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Community-Tech-Sprint, Collaboration-Team-Triage, Notifications

Mar 15 2018

MaxSem claimed T189819: Revert to last revision by user should not mention.
Mar 15 2018, 10:38 PM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Community-Tech-Sprint, Collaboration-Team-Triage, Notifications

Mar 14 2018

MaxSem added a comment to T187598: Pass MW user language to Kartotherian from Kartographer.

Yup, that's how it's going to be for now at least.

Mar 14 2018, 10:42 PM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Patch-For-Review, Maps (Kartographer), Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), I18n
MaxSem added a comment to T187598: Pass MW user language to Kartotherian from Kartographer.

Yes, it has. But you will also have to vary parser cache by it, at which point performance ppl will open a hunt for ya:)

Mar 14 2018, 10:37 PM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Patch-For-Review, Maps (Kartographer), Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), I18n

Mar 12 2018

MaxSem claimed T186570: ACTRIAL: Disable on March 14th.
Mar 12 2018, 10:14 PM · Patch-For-Review, Community-Tech-Sprint
MaxSem moved T189034: Document how to ping from edit summary in Help:Notifications/Notifications_types#Mentions from Needs Review/Feedback to Done on the Community-Tech-Sprint board.
Mar 12 2018, 6:48 PM · Documentation, Notifications, Collaboration-Team-Triage, Community-Tech-Sprint
MaxSem closed T189034: Document how to ping from edit summary in Help:Notifications/Notifications_types#Mentions as Resolved.
Mar 12 2018, 6:48 PM · Documentation, Notifications, Collaboration-Team-Triage, Community-Tech-Sprint
MaxSem closed T189034: Document how to ping from edit summary in Help:Notifications/Notifications_types#Mentions, a subtask of T188469: Release ping users from edit summary in production, as Resolved.
Mar 12 2018, 6:48 PM · Patch-For-Review, Community-Tech-Sprint

Mar 11 2018

MaxSem edited projects for T189409: Strong reduction of computing time at Wikivoyage needed, added: Performance; removed Operations, hardware-requests.

Just FYI, all wikis are hosted on the same cluster.

Mar 11 2018, 6:40 PM · Regression, MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), MediaWiki-extensions-Scribunto, Performance, MediaWiki-extensions-WikibaseClient, Wikidata

Mar 10 2018

MaxSem added a comment to T32750: [Epic] Ping/notify user when username used in an edit summary.

No, subpages will not trigger this.

Mar 10 2018, 12:52 AM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Epic, Community-Wishlist-Survey-2017, Community-Tech, Collaboration-Team-Triage, Notifications, MediaWiki-Page-editing

Mar 9 2018

MaxSem closed T189067: Allow disabling user pings in edit summary by prefixing with a colon, a subtask of T32750: [Epic] Ping/notify user when username used in an edit summary, as Resolved.
Mar 9 2018, 11:45 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Epic, Community-Wishlist-Survey-2017, Community-Tech, Collaboration-Team-Triage, Notifications, MediaWiki-Page-editing
MaxSem closed T189067: Allow disabling user pings in edit summary by prefixing with a colon as Resolved.
Mar 9 2018, 11:45 PM · MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), Community-Tech-Sprint, Patch-For-Review, Notifications, Collaboration-Team-Triage
MaxSem added a comment to T189263: Some slaves are impossible to check for replication lag in MediaWiki.

No, the issue is opposite - lag checks can't see it so more writes get piled than it can handle.

Mar 9 2018, 7:10 AM · Wikimedia-Site-requests, DBA
MaxSem added a comment to T184666: DBA review for GlobalPreferences schema.

@jcrespo: if we shaved off 80M+ rows totaling 6G+ in size from a different place, would it alleviate your disk space concerns?

Mar 9 2018, 12:36 AM · Patch-For-Review, Community-Tech, MediaWiki-extensions-GlobalPreferences, Schema-change, DBA

Mar 8 2018

MaxSem added a comment to T189034: Document how to ping from edit summary in Help:Notifications/Notifications_types#Mentions.

They do if they generate page revisions. In this particular case, the user won't get pinged because they did it themselves.

Mar 8 2018, 11:29 PM · Documentation, Notifications, Collaboration-Team-Triage, Community-Tech-Sprint