Page MenuHomePhabricator

MaxSem (Max Semenik)
User

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:37 PM (276 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
MaxSem [ Global Accounts ]

Recent Activity

Yesterday

MaxSem added a comment to T192167: Upgrade PHPUnit from 4/6 to 8.

Yeah, time to pull the trigger.

Thu, Jan 23, 5:59 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing

Tue, Jan 21

MaxSem added a comment to T192167: Upgrade PHPUnit from 4/6 to 8.

Current status:

Tue, Jan 21, 4:55 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing
MaxSem added a subtask for T192167: Upgrade PHPUnit from 4/6 to 8: T243296: Release a new version of WikibaseCodeSniffer.
Tue, Jan 21, 4:47 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing
MaxSem added a parent task for T243296: Release a new version of WikibaseCodeSniffer: T192167: Upgrade PHPUnit from 4/6 to 8.
Tue, Jan 21, 4:47 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, MediaWiki-Codesniffer, Wikidata
MaxSem created T243296: Release a new version of WikibaseCodeSniffer.
Tue, Jan 21, 4:47 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, MediaWiki-Codesniffer, Wikidata

Mon, Jan 20

MaxSem committed rEWCS3fc9b94a43e5: Fix PHPUnit 8 warnings (authored by MaxSem).
Fix PHPUnit 8 warnings
Mon, Jan 20, 9:46 PM
MaxSem committed rEFLI3612fe9e1c76: Fix PHPUnit 8 warnings (authored by MaxSem).
Fix PHPUnit 8 warnings
Mon, Jan 20, 4:03 PM

Fri, Jan 17

MaxSem committed rEPS986292a08ad5: Make tests pass on PHPUnit 8 (authored by MaxSem).
Make tests pass on PHPUnit 8
Fri, Jan 17, 4:37 PM

Thu, Jan 16

MaxSem committed rELUA0d6a4da3d578: Make tests pass on PHPUnit 8 (authored by MaxSem).
Make tests pass on PHPUnit 8
Thu, Jan 16, 5:36 PM

Wed, Jan 15

MaxSem closed T242914: Receiving emails from projects I'm no longer a member of as Invalid.

Never mind, mixed up tools and VPS projects.

Wed, Jan 15, 8:34 PM · Toolforge
MaxSem created T242914: Receiving emails from projects I'm no longer a member of.
Wed, Jan 15, 8:27 PM · Toolforge

Dec 20 2019

MaxSem added a comment to T75181: Remove HHVM and PHP7 revision tags.

Did you also delete the php7 tag?

Dec 20 2019, 2:01 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-WikimediaMaintenance, HHVM, Wikimedia-General-or-Unknown

Dec 16 2019

MaxSem added a comment to T240307: Hook container with strong types and DI.

One thing to discuss here is the guidelines of how to evolve code using this approach: previously, you could add a new parameter to a hook and it will just work™️ with existing hook handlers. Even some parameter type changes were possible. Not the case in this RFC: existing hook handlers can't be changed easily.

Dec 16 2019, 10:48 AM · TechCom-RFC (TechCom-Approved), User-Daniel, Core Platform Team

Dec 11 2019

MaxSem closed T71014: PhpTags does not pass all tests under hhvm/hiphop as Invalid.

This issue is moot now that HHVM is incompatible with PHP and MediaWiki doesn't support it.

Dec 11 2019, 5:17 PM · Patch-For-Review, MediaWiki-extensions-PhpTags
MaxSem closed T102256: HHVM and PhpTags 5.1: In nested foreach loop, the inner loop corrupts the array of the outer loop, a subtask of T71014: PhpTags does not pass all tests under hhvm/hiphop, as Invalid.
Dec 11 2019, 5:16 PM · Patch-For-Review, MediaWiki-extensions-PhpTags
MaxSem closed T102256: HHVM and PhpTags 5.1: In nested foreach loop, the inner loop corrupts the array of the outer loop as Invalid.

This issue is moot now that HHVM is incompatible with PHP and MediaWiki doesn't support it.

Dec 11 2019, 5:16 PM · MediaWiki-extensions-PhpTags
MaxSem closed T104632: HHVM array data corruption when using the MW extension PhpTags, a subtask of T102256: HHVM and PhpTags 5.1: In nested foreach loop, the inner loop corrupts the array of the outer loop, as Invalid.
Dec 11 2019, 5:16 PM · MediaWiki-extensions-PhpTags
MaxSem closed T104632: HHVM array data corruption when using the MW extension PhpTags as Invalid.

This issue is moot now that HHVM is incompatible with PHP and MediaWiki doesn't support it.

Dec 11 2019, 5:16 PM · Upstream, MediaWiki-extensions-PhpTags, HHVM

Dec 10 2019

MaxSem added a comment to T192167: Upgrade PHPUnit from 4/6 to 8.

@MaxSem Another thing I've come across: assertArraySubset will be removed in PHPUnit 9 with no alternative method (https://github.com/sebastianbergmann/phpunit/issues/3494). I see several usages around. I was thinking whether we should:

  1. Just stop using it, although it's not always clear what the replacement should be (usually, a long list of assertArrayHasKey and assertEquals)
  2. Re-implement it in a trait in MW core
  3. Use https://github.com/rdohms/phpunit-arraysubset-asserts as suggested by Sebastian on the issue linked above.

I'd say either 1 or 3. If 3, we should update PHPCS because the new version will forbid usage of assertArraySubset.

Dec 10 2019, 1:35 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing

Dec 9 2019

MaxSem removed a watcher for Security: MaxSem.
Dec 9 2019, 4:36 PM

Dec 8 2019

MaxSem added a comment to T192167: Upgrade PHPUnit from 4/6 to 8.

@RazeSoldier, what PHP version? What's the error Composer emits?

Dec 8 2019, 11:22 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing

Dec 6 2019

MaxSem removed a watcher for MediaWiki-extensions-CodeMirror: MaxSem.
Dec 6 2019, 5:03 PM
MaxSem removed a member for Community-Tech: MaxSem.
Dec 6 2019, 5:02 PM
MaxSem added a comment to T239047: Check home leftovers of maxsem.

Everything can be safely deleted.

Dec 6 2019, 3:52 PM · Analytics

Dec 4 2019

MaxSem added a watcher for PHP 7.2 support: MaxSem.
Dec 4 2019, 7:05 PM
MaxSem added a watcher for PHP 7.3 support: MaxSem.
Dec 4 2019, 7:04 PM
MaxSem added a watcher for PHP 7.4 support: MaxSem.
Dec 4 2019, 7:04 PM

Dec 3 2019

MaxSem added a comment to T233012: Make MediaWiki core compatible with PHP 7.4.

https://gerrit.wikimedia.org/r/554202 fixes it.

Dec 3 2019, 3:57 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support
MaxSem added a comment to T233012: Make MediaWiki core compatible with PHP 7.4.

And of course, it's not documented in https://www.php.net/manual/en/ini.list.php.

Dec 3 2019, 2:22 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support
MaxSem added a comment to T233012: Make MediaWiki core compatible with PHP 7.4.

Weird. I skimmed through PHP 7.4 UPGRADING, and couldn't find anything interesting. I've also tested the faulty code on 3v4l (I still have to install PHP 7.4 locally), but the trace seems to have an object there.

Dec 3 2019, 1:59 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-General, Patch-For-Review, PHP 7.4 support

Nov 26 2019

MaxSem added a comment to T238960: Conversion to volunteer NDA for MaxSem.

Sent.

Nov 26 2019, 11:34 AM · LDAP-Access-Requests, SRE-Access-Requests, Operations

Nov 25 2019

Niharika awarded T238960: Conversion to volunteer NDA for MaxSem a Love token.
Nov 25 2019, 8:52 PM · LDAP-Access-Requests, SRE-Access-Requests, Operations

Nov 22 2019

MaxSem placed T233969: Update Temporary Password Email with Preference Info [x-small] up for grabs.
Nov 22 2019, 11:27 PM · Community-Tech (Kanban-Q3-2019-20), MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Password-Reset-Update
MaxSem placed T238385: Links in table of contents don't work for certain characters up for grabs.
Nov 22 2019, 11:07 PM · TechCom, Readers-Web-Backlog (Tracking), MediaWiki-Parser, Parsoid, Parsing-Team
MaxSem created T238960: Conversion to volunteer NDA for MaxSem.
Nov 22 2019, 10:40 PM · LDAP-Access-Requests, SRE-Access-Requests, Operations

Nov 21 2019

MaxSem closed T216734: Drop devDependency on phpunit-mock-objects, which is abandoned and warns against use as Resolved.

Gone after we upgraded to PHPUnit 7 in https://gerrit.wikimedia.org/r/552166.

Nov 21 2019, 8:43 PM · Technical-Debt, MediaWiki-Core-Testing
MaxSem committed rEPSccdc4868762f: Fix PHPUnit 7 compatibility (authored by MaxSem).
Fix PHPUnit 7 compatibility
Nov 21 2019, 7:53 PM
MaxSem added a comment to T238076: Alert group Cookie(s) without Secure flag set.

Probably has something to do with us not being HTTPS only back then.

Nov 21 2019, 6:53 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Tracking), MobileFrontend, Security
MaxSem added a comment to T192167: Upgrade PHPUnit from 4/6 to 8.
Nov 21 2019, 3:26 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing

Nov 20 2019

MaxSem added a comment to T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets [high priority].

That sounds like API responses are getting cached?

Nov 20 2019, 9:57 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Community-Tech (Kanban-Q2-2019-20), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Growth-Team, PageCuration

Nov 19 2019

MaxSem committed rECIR695162522fc8: Fixes for PHPUnit 8 compatibility (authored by MaxSem).
Fixes for PHPUnit 8 compatibility
Nov 19 2019, 8:11 PM
MaxSem committed rEFLIa33900f3f711: Suppress PHPUnit 8 warnings (authored by MaxSem).
Suppress PHPUnit 8 warnings
Nov 19 2019, 7:33 PM
MaxSem committed rEWSO4fa5339a762e: Declare types everywhere and force strict_types = 1 (authored by MaxSem).
Declare types everywhere and force strict_types = 1
Nov 19 2019, 3:23 PM
MaxSem moved T207485: Enable page curation tools to be loaded on any page (optionally) from Needs Review/Feedback to Product sign-off on the Community-Tech (Kanban-Q2-2019-20) board.
Nov 19 2019, 4:51 AM · Community-Tech (Kanban-Q2-2019-20), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), PageCuration, Growth-Team

Nov 18 2019

MaxSem committed rESHGb591e2cdab4b: Remove 2 unused functions deprecated 5 years ago (authored by MaxSem).
Remove 2 unused functions deprecated 5 years ago
Nov 18 2019, 10:42 AM

Nov 17 2019

MaxSem committed rEWPLfbc57e887bba: Stop passing objects by reference (authored by MaxSem).
Stop passing objects by reference
Nov 17 2019, 1:54 PM

Nov 16 2019

MaxSem committed rETBL6948b3c5cf14: Stop passing objects by reference (authored by MaxSem).
Stop passing objects by reference
Nov 16 2019, 2:34 PM
MaxSem committed rEWETb31b8e7c7f8b: Stop passing objects by reference (authored by MaxSem).
Stop passing objects by reference
Nov 16 2019, 2:23 PM
MaxSem moved T238466: Deprecate GlobalPreferencesFactory::setUser() from Unsorted to Needs refactor on the Technical-Debt board.
Nov 16 2019, 6:07 AM · Community-Tech, Technical-Debt, MediaWiki-extensions-GlobalPreferences
MaxSem created T238466: Deprecate GlobalPreferencesFactory::setUser().
Nov 16 2019, 6:07 AM · Community-Tech, Technical-Debt, MediaWiki-extensions-GlobalPreferences
MaxSem closed T26918: Do not allow #, %, [, ], nbsp in fragment identifiers, a subtask of T2209: [DO NOT USE] HTML validity (tracking), as Declined.
Nov 16 2019, 4:05 AM · Tracking-Neverending
MaxSem closed T26918: Do not allow #, %, [, ], nbsp in fragment identifiers as Declined.

This bug is moot after section encoding was rewritten.

Nov 16 2019, 4:05 AM · WorkType-NewFunctionality, MediaWiki-General

Nov 15 2019

MaxSem committed rESMX10735775fb48: Stop passing objects by reference (authored by MaxSem).
Stop passing objects by reference
Nov 15 2019, 8:03 PM
MaxSem committed rESHG310de5114fe6: Stop passing objects by reference (authored by MaxSem).
Stop passing objects by reference
Nov 15 2019, 7:35 PM
MaxSem committed rEHIE71d0d977d3f7: Stop passing objects by reference (authored by MaxSem).
Stop passing objects by reference
Nov 15 2019, 7:25 PM

Nov 13 2019

MaxSem closed T238011: Undefined variable: wgGERestbaseUrl in CommonSettings-labs.php as Resolved.

Confirm it's fixed.

Nov 13 2019, 11:59 PM · User-Urbanecm, Growth-Team (Current Sprint), GrowthExperiments, Beta-Cluster-Infrastructure

Nov 12 2019

MaxSem committed rECPA23ea634acea8: Sanitizer::escapeId() is deperecated (authored by MaxSem).
Sanitizer::escapeId() is deperecated
Nov 12 2019, 4:58 PM
MaxSem closed T238072: Alert group HTML form without CSRF protection as Invalid.
Nov 12 2019, 3:50 PM · Security
MaxSem closed T238073: Alert group HTTPS connection with weak key length as Invalid.
Nov 12 2019, 3:44 PM · Security
MaxSem closed T238079: Alert group Possible sensitive files as Invalid.
Nov 12 2019, 3:42 PM · Security
MaxSem closed T238060: Alert group: JSONP enabled by default in MappingJackson2JsonView as Invalid.
Nov 12 2019, 3:36 PM · Security

Nov 11 2019

MaxSem added a comment to T75181: Remove HHVM and PHP7 revision tags.

With the fix merged, I've successfully ran the removal in beta. Unless there will be problems discovered with the removals, I'll test the process on testwiki this week and run it on the rest of production next week.

Nov 11 2019, 6:36 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-WikimediaMaintenance, HHVM, Wikimedia-General-or-Unknown
MaxSem created T238011: Undefined variable: wgGERestbaseUrl in CommonSettings-labs.php.
Nov 11 2019, 6:25 PM · User-Urbanecm, Growth-Team (Current Sprint), GrowthExperiments, Beta-Cluster-Infrastructure
MaxSem updated subscribers of T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8.
Nov 11 2019, 8:57 AM · Wikidata-Campsite, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), MediaWiki-extensions-WikibaseRepository, Wikidata
MaxSem created T237923: mwcore-phpunit-coverage-patch runs against old MW code.
Nov 11 2019, 8:55 AM · Release-Engineering-Team-TODO, Test-Coverage, phpunit-patch-coverage, Quibble
MaxSem added a comment to T75181: Remove HHVM and PHP7 revision tags.

Update: there's a bug in the script discovered running it on betalabs, DON'T RUN IT IN PRODUCTION YET! Fix here: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/550070/

Nov 11 2019, 6:55 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-WikimediaMaintenance, HHVM, Wikimedia-General-or-Unknown
MaxSem added a comment to T236019: Remove HHVM support from Quibble.

With the above patch merged, anything else left?

Nov 11 2019, 5:47 AM · Release-Engineering-Team-TODO (201911), Release-Engineering-Team (CI & Testing services), Quibble, HHVM

Nov 9 2019

MaxSem committed rETMCb981f0fddefa: $wgEnableAPI is deprecated (authored by MaxSem).
$wgEnableAPI is deprecated
Nov 9 2019, 11:21 PM
MaxSem committed rEOILfe63204b4697: wgEnableAPI is deprecated (authored by MaxSem).
wgEnableAPI is deprecated
Nov 9 2019, 10:53 PM

Nov 7 2019

MaxSem closed T237346: Make the Commons bot email the team in case of errors as Resolved.
Nov 7 2019, 1:13 AM · Commons, Community-Tech

Nov 5 2019

MaxSem created T237346: Make the Commons bot email the team in case of errors.
Nov 5 2019, 1:59 AM · Commons, Community-Tech
MaxSem closed T237168: Commons notification bot is broken as Resolved.
Nov 5 2019, 12:40 AM · Community-Tech (Kanban-Q2-2019-20), Commons
MaxSem moved T237168: Commons notification bot is broken from In Development to Done on the Community-Tech (Kanban-Q2-2019-20) board.

Fixed with this commit, will create tickets about monitoring.

Nov 5 2019, 12:33 AM · Community-Tech (Kanban-Q2-2019-20), Commons

Nov 3 2019

MaxSem moved T237168: Commons notification bot is broken from Ready to In Development on the Community-Tech (Kanban-Q2-2019-20) board.
Nov 3 2019, 8:42 PM · Community-Tech (Kanban-Q2-2019-20), Commons

Nov 2 2019

MaxSem created T237168: Commons notification bot is broken.
Nov 2 2019, 9:49 PM · Community-Tech (Kanban-Q2-2019-20), Commons
MaxSem added a subtask for T192167: Upgrade PHPUnit from 4/6 to 8: T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8.
Nov 2 2019, 9:15 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing
MaxSem added a parent task for T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8: T192167: Upgrade PHPUnit from 4/6 to 8.
Nov 2 2019, 9:15 PM · Wikidata-Campsite, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), MediaWiki-extensions-WikibaseRepository, Wikidata
MaxSem created T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8.
Nov 2 2019, 9:14 PM · Wikidata-Campsite, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), MediaWiki-extensions-WikibaseRepository, Wikidata
MaxSem committed rECIRd3293c36847c: PHPUnit 8 compatibility fixes (authored by MaxSem).
PHPUnit 8 compatibility fixes
Nov 2 2019, 7:04 PM

Nov 1 2019

MaxSem added a comment to T231357: Page Curation should create a new AfD discussion page if one already exists.

@dom_walden, looking at the above nomination:

Templates look to be working to me.

Nov 1 2019, 4:57 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Community-Tech (Kanban-Q2-2019-20), Growth-Team, PageCuration

Oct 30 2019

MaxSem added a comment to T235005: Spike #2: Watchlist Expiry [12 hours].

By clicking on the watchlist star: Can the user edit the time period by unwatching the page and then re-watching it with a newly selected time period? Would this be the easiest to implement (in terms of editing)?

Oct 30 2019, 10:41 PM · Community-Tech (Kanban-Q3-2019-20), Expiring-Watchlist-Items, TCB-Team
MaxSem added a comment to T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets [high priority].

Not particularly likely, but there could be other issues, like log page failing to load due to bad connection, etc.

Oct 30 2019, 8:35 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Community-Tech (Kanban-Q2-2019-20), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Growth-Team, PageCuration

Oct 29 2019

MaxSem changed the edit policy for T236557: "google-api-proxy" Cloud VPS project jessie deprecation (medium).
Oct 29 2019, 11:23 PM · Community-Tech (Kanban-Q2-2019-20), Cloud-VPS (Debian Jessie Deprecation)
MaxSem closed T103671: Empty PHP Notice in wfShellExec (GlobalFunctions.php) as Resolved.

See also https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Scribunto/+/546393/ for T191247: Use MediaWiki\SuppressWarnings around trigger_error('') instead @trigger_error('').

Oct 29 2019, 7:13 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MediaWiki-General, Technical-Debt

Oct 28 2019

MaxSem added a comment to T226861: Hash all pageTokens or temporary identifiers from the EL Sanitization white-list for Community Tech.

@aezell We would need to go through a list of our team's projects and review whether each of them is using EL or not.

Oct 28 2019, 10:58 PM · Product-Analytics (Kanban), Community-Tech, Analytics
MaxSem moved T233969: Update Temporary Password Email with Preference Info [x-small] from Needs Review/Feedback to QA on the Community-Tech (Kanban-Q2-2019-20) board.
Oct 28 2019, 5:06 PM · Community-Tech (Kanban-Q3-2019-20), MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Password-Reset-Update
MaxSem committed rEPLL9be385396523: build: Bump mediawiki-codesniffer to 28.0.0 (authored by MaxSem).
build: Bump mediawiki-codesniffer to 28.0.0
Oct 28 2019, 11:03 AM
MaxSem moved T231389: [Needs investigation] What's the way forward with setMainPage() in MobileFormatter.php? from Unsorted to Needs research on the Technical-Debt board.
Oct 28 2019, 5:49 AM · Readers-Web-Backlog, Technical-Debt, MobileFrontend
MaxSem moved T236001: Is DonationInterface still needed on the main cluster? from Unsorted to Needs research on the Technical-Debt board.
Oct 28 2019, 5:10 AM · Technical-Debt, MediaWiki-extensions-DonationInterface

Oct 27 2019

MaxSem added a comment to T236513: Jenkins jobs failing with Composer TransportException: 404 Not Found (October 2019).

With the above patches, core tests pass - however other repositories are still broken. Ugh.

Oct 27 2019, 12:19 AM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Patch-For-Review, Release-Engineering-Team, Continuous-Integration-Infrastructure, Wikimedia-production-error (Shared Build Failure)

Oct 25 2019

MaxSem committed rEQSLf30c38f09603: tests: Fix setUp()/tearDown() signatures (authored by MaxSem).
tests: Fix setUp()/tearDown() signatures
Oct 25 2019, 8:33 AM
MaxSem added a comment to T231474: Move DonationInterface messages used in banners to WikimediaMessages.

Is there a way to determine which messages are used?

Oct 25 2019, 3:39 AM · Fundraising-Backlog, MediaWiki-extensions-DonationInterface
MaxSem committed rEWCS9dc9e33e32a4: tests: Fix setUp() that crept into a trait (authored by MaxSem).
tests: Fix setUp() that crept into a trait
Oct 25 2019, 2:40 AM

Oct 23 2019

MaxSem added a comment to T233418: Fatal exception of type "Wikimedia\Assert\PostconditionException" (page with an invalid title on Pashto Wikipedia).
maxsem@deploy1001:~$ mwscript namespaceDupes.php --wiki=pswiki --source-pseudo-namespace='تانبه'
Checking prefix "تانبه" vs namespace 0
id=21451 ns=0 dbk=تانبه::لرغونپوهنه -> تانبه-:لرغونپوهنه (no conflict) DRY RUN ONLY
Oct 23 2019, 4:40 AM · Navigation-Popups, Wikimedia-production-error, MediaWiki-General, Readers-Web-Backlog (Tracking)
MaxSem renamed T233418: Fatal exception of type "Wikimedia\Assert\PostconditionException" (page with an invalid title on Pashto Wikipedia) from Fatal exception of type "Wikimedia\Assert\PostconditionException" / "invalidtitle" error for extracts API error for title in Pashto Wikipedia to Fatal exception of type "Wikimedia\Assert\PostconditionException" (page with an invalid title on Pashto Wikipedia).
Oct 23 2019, 4:14 AM · Navigation-Popups, Wikimedia-production-error, MediaWiki-General, Readers-Web-Backlog (Tracking)
MaxSem edited projects for T233418: Fatal exception of type "Wikimedia\Assert\PostconditionException" (page with an invalid title on Pashto Wikipedia), added: MediaWiki-General, Wikimedia-production-error, Navigation-Popups; removed Wikimedia-General-or-Unknown, TextExtracts.
Postcondition failed: makeTitleSafe() should always return a Title for the text returned by getRootText().
Oct 23 2019, 4:13 AM · Navigation-Popups, Wikimedia-production-error, MediaWiki-General, Readers-Web-Backlog (Tracking)
MaxSem committed rEWSO58eb72896ec5: tests: createMock() is deprecated (authored by MaxSem).
tests: createMock() is deprecated
Oct 23 2019, 1:59 AM

Oct 22 2019

MaxSem added a comment to T233969: Update Temporary Password Email with Preference Info [x-small].

Err, I both forgot to update the commit message and it's kinda moot, considering that it depends on two changes that have been waiting to be merged for a month.

Oct 22 2019, 9:27 PM · Community-Tech (Kanban-Q3-2019-20), MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Password-Reset-Update
MaxSem committed rEFLIbb029b12c561: tests: getMock() is deprecated (authored by MaxSem).
tests: getMock() is deprecated
Oct 22 2019, 7:07 AM

Oct 21 2019

MaxSem added a comment to T207485: Enable page curation tools to be loaded on any page (optionally).

This thingie still needs review: https://gerrit.wikimedia.org/r/538123

Oct 21 2019, 5:11 PM · Community-Tech (Kanban-Q2-2019-20), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), PageCuration, Growth-Team