Notes from etherpad:

Notes from etherpad:

Notes from session:

Etherpad for this session: https://etherpad.wikimedia.org/p/Toolforge_Build_Service_beta_preview

Smoke test needed on TestFlight build 7.2.2 (2182)

Smoke test needed on TestFlight build 7.2.2 (2182)

Moved to needs QA to test if we're sending data correctly.

https://github.com/wikimedia/wikipedia-ios/pull/4514

Task created to address issues: https://phabricator.wikimedia.org/T335165

More notes from eng sync on Android's implementation:

• Tokens: hitting backspace on a mention "token" should clear the token and take you back to the search username workflow
• Deleting one character of the token should delete the entire token for a better experience
• Hitting space twice in a row should exit the search flow. Using one space is allowed, and usernames can only have one consecutive space character
• Apple's example of a search token, can be a design alternative https://developer.apple.com/documentation/uikit/uisearchtoken (this element itself only works on search bars and not on text fields, but it can be a useful native reference)

Update on the search issues investigation:

Thanks @ARamadan-WMF! Not at this moment, that was helpful!

@ARamadan-WMF, thank you!
Could you ask them to try two things?

• First, go to the app store and update to the 7.2.1 version. It was released last Friday.
• If that doesn't solve the issue, could they try updating their iPhone, if possible, to the latest iOS version - 16.4.1; more info is here if they need it https://support.apple.com/en-us/HT204204.

This could help us narrow down where the issue is if it's related to a version of our app or an iOS version.

In T334765#8785375, @ARamadan-WMF wrote:

+1 user through the iOS support email:
the app has now completely stopped working. The search function is missing (you can click the icon and then you get a list of recent searches, but no search field) and the ”W” button in the top center is not clickable anymore. It also looks like the bottom navigation bar is improperly shown, but the buttons at least work there.
As a result, the app is completely useless at the moment. Hope you get the chance to get it back on track again, as it’s been a brilliant and well-designed app for many years.

Moved to blocked or waiting as I finish the MEP work. Both tasks delete many files, so I'm prioritizing the MEP work to be merged first.

Currently waiting on this PR to be finalized https://github.com/wikimedia/wikipedia-ios/pull/4473

In T313772#8757317, @Tsevener wrote:

@OTichonova

Heads up, I don't think it's possible for us to both enable the editor (because the user has permissions) but also show a page protection error. If the user has high enough permissions for the page protection level, the API does not return any error text for us to display. I checked on Android and they do not seem to show this state either.

This means the "Editor decides to edit a semi-protected page" flow will just show an enabled editor with no modal (assuming their level is high enough). Please let us know if we're missing something here though, thanks!

I kicked a build for this one: Wikipedia Experimental 7.3.0 (19), in case you want to review it @OTichonova

Hi @cmadeo! Thanks for reviewing it. Let me know if this is how the button backgrounds should look like (here using 'base background')

Hi @cmadeo! I got a new build with the updates from design feedback -Wikipedia Experimental 7.3.0 (15). Let me know if there's something else I can update! (CC @OTichonova in case she wants to check as well)

PRs:

• On iOS, is done with other MEP work https://github.com/wikimedia/wikipedia-ios/pull/4473
• On Android https://github.com/wikimedia/apps-android-wikipedia/pull/3892

Hi @OTichonova and @cmadeo 👋 We have an Experimental build with this color update - Wikipedia Experimental 7.2.0 (2) from last Friday, March 03. A lot of stuff changed, so feel free to bring up anything that looks off. Let me know if you can't find this version, and I'll create a new build.

PR for the Experimental build post-build script update:
https://github.com/wikimedia/wikipedia-ios/pull/4484
This PR addresses the requirement of not generating a beta tag for experimental builds.

In T299793#8654577, @cmadeo wrote:

Sorry to jump in! @Mazevedo we could call these colors: color-orange and color-purple (sorry I should have put these in the table instead to match Codex). Alternatively we could use color-orange-600 / color-purple-600 or orange600/purple600

App PR - https://github.com/wikimedia/wikipedia-ios/pull/4482
Components PR - https://github.com/wikimedia/wikipedia-ios-components/pull/4

@OTichonova could we have another name for the new colors named orange and purple? As there are iOS system colors with the same names, it can get a little confusing.

PR https://github.com/wikimedia/wikipedia-ios/pull/4476

Part 1 PR - https://github.com/wikimedia/wikipedia-ios/pull/4468