Page MenuHomePhabricator

Mh-3110 (Mh-3110)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 13 2018, 4:26 PM (70 w, 1 d)
Availability
Available
LDAP User
Mh-3110
MediaWiki User
Unknown

Recent Activity

Thu, Aug 15

Mh-3110 added a comment to T223608: Create Wikimedia Hackathon documentation pages.

Hi all,
quick update: i18n engine implemented + languages can be changed now.
2 languages are for the moment implemented: En and FR
Tools is now hosted on on forge: https://tools.wmflabs.org/mortar/?lang=en

Thu, Aug 15, 2:09 PM · Wikimania-Hackathon-2019, OpenRefine
Mh-3110 edited projects for T223608: Create Wikimedia Hackathon documentation pages, added: Wikimania-Hackathon-2019; removed Wikimedia-Hackathon-2019.
Thu, Aug 15, 9:35 AM · Wikimania-Hackathon-2019, OpenRefine

Wed, Aug 14

Mh-3110 edited projects for T214849: Optimize LinguaLibre UI on mobile devices, added: Wikimania-Hackathon-2019; removed Wikimedia-Hackathon-2019.
Wed, Aug 14, 9:25 AM · Wikimania-Hackathon-2019, Lingua Libre
Mh-3110 added a comment to T230464: Lightweight tool to visualise Wikipedia article contest/editathon flow/results.

Hi @tramm,
Can give a help here. just wondering if there is not any tool already that do the job.

Wed, Aug 14, 9:23 AM · Wikimania-Hackathon-2019

Thu, Aug 8

Mh-3110 added a comment to T228114: Have libup rename .eslintrc to .eslintrc.json.

@Legoktm ,
It is clear what needs to be done here. Will submit the patch this week-end the latest.

Thu, Aug 8, 8:20 AM · good first bug, LibUp

Jul 17 2019

Mh-3110 added a comment to T227756: Account length help text bug.

@Samwalton9 , the second option works and I can login

Jul 17 2019, 8:33 PM · good first bug, Library-Card-Platform
Mh-3110 placed T221344: Change subst option in template.py up for grabs.
Jul 17 2019, 5:36 AM · good first bug, Pywikibot-Scripts, Pywikibot
Mh-3110 added a comment to T221344: Change subst option in template.py.

Hi,
I will unassigned myself from this task for now. Will come back to it if i have any correct solution for this issue.
Thanks

Jul 17 2019, 5:36 AM · good first bug, Pywikibot-Scripts, Pywikibot
Mh-3110 claimed T228114: Have libup rename .eslintrc to .eslintrc.json.
Jul 17 2019, 5:33 AM · good first bug, LibUp
Mh-3110 added a comment to T228114: Have libup rename .eslintrc to .eslintrc.json.

Thank you @Legoktm .
I will work on this.

Jul 17 2019, 5:33 AM · good first bug, LibUp

Jul 16 2019

Mh-3110 added a comment to T227756: Account length help text bug.

@Samwalton9 ,
I am able to launch the platform in my local server but don't succeed to log in as a superuser to access the admin interface so that to test the fix.
Will ping you on IRC for more details.

Jul 16 2019, 10:32 PM · good first bug, Library-Card-Platform
Mh-3110 added a comment to T228114: Have libup rename .eslintrc to .eslintrc.json.

Hi @Legoktm ,
it's .eslintrc files under libraryupgrader, right?

Jul 16 2019, 10:45 AM · good first bug, LibUp

Jul 11 2019

Mh-3110 claimed T227756: Account length help text bug.
Jul 11 2019, 10:16 AM · good first bug, Library-Card-Platform
Mh-3110 added a comment to T227756: Account length help text bug.

Thanks @Samwalton9 ,
it could be an escaping issue.
Let me check this.
Thanks

Jul 11 2019, 10:16 AM · good first bug, Library-Card-Platform
Mh-3110 added a comment to T227756: Account length help text bug.

Hi @Samwalton9 , any screenshoot?
Thanks

Jul 11 2019, 9:50 AM · good first bug, Library-Card-Platform

Jul 8 2019

Mh-3110 added a member for good first bug: Mh-3110.
Jul 8 2019, 5:28 AM
Mh-3110 added a watcher for good first bug: Mh-3110.
Jul 8 2019, 5:27 AM
Mh-3110 claimed T224806: Change the autonym of Minangkabau from "Baso Minangkabau" to "Minangkabau".
Jul 8 2019, 4:34 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), good first bug, MediaWiki-Internationalization
Mh-3110 added a comment to T224806: Change the autonym of Minangkabau from "Baso Minangkabau" to "Minangkabau".

Hi,
I will start working on this!
Thanks

Jul 8 2019, 4:33 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), good first bug, MediaWiki-Internationalization

Jul 3 2019

Mh-3110 added a comment to T221344: Change subst option in template.py.

@Dvorapa , yeah it's weird. None of those options works good.

Jul 3 2019, 4:25 AM · good first bug, Pywikibot-Scripts, Pywikibot

Jun 29 2019

Mh-3110 added a comment to T221344: Change subst option in template.py.

Hi @Hercule ,
I can reproduce the issue. However, I've tried to replace "subst" with "safesubst" with the "<includeonly>" tags applied but the result seems not correct.
See attached:


Jun 29 2019, 8:15 AM · good first bug, Pywikibot-Scripts, Pywikibot

Jun 24 2019

Mh-3110 renamed T221344: Change subst option in template.py from Change subst method on template.py to Change subst option in template.py.
Jun 24 2019, 9:58 PM · good first bug, Pywikibot-Scripts, Pywikibot

Jun 22 2019

Mh-3110 claimed T221344: Change subst option in template.py.
Jun 22 2019, 6:10 AM · good first bug, Pywikibot-Scripts, Pywikibot
Mh-3110 added a comment to T221344: Change subst option in template.py.

Hi,
Will start working on this.
Thanks

Jun 22 2019, 6:10 AM · good first bug, Pywikibot-Scripts, Pywikibot

Jun 15 2019

Mh-3110 claimed T220305: Implement -overwrite option in create_categories.py.
Jun 15 2019, 11:28 PM · good first bug, Pywikibot-Scripts, Pywikibot
Mh-3110 added a comment to T220305: Implement -overwrite option in create_categories.py.

Hi,
Will start working on this.
Thanks

Jun 15 2019, 11:28 PM · good first bug, Pywikibot-Scripts, Pywikibot
Mh-3110 added a comment to T222716: L10N of WelcomeBot is outdated.

Hi,
After checking, it turns out that ar and it wikipedia don't have the WLE template.

Jun 15 2019, 10:59 PM · Patch-For-Review, good first bug, Pywikibot-Scripts, Pywikibot

Jun 13 2019

Mh-3110 updated the task description for T222716: L10N of WelcomeBot is outdated.
Jun 13 2019, 4:37 AM · Patch-For-Review, good first bug, Pywikibot-Scripts, Pywikibot

Jun 11 2019

Mh-3110 added a comment to T223816: Transferbot.py script could stop for many reasons, is it possible to just skip and continue ?.

Thank you both @Dvorapa and @Xqt for your help!

Jun 11 2019, 7:36 PM · good first bug, Pywikibot-Scripts, Pywikibot

Jun 4 2019

Mh-3110 claimed T222716: L10N of WelcomeBot is outdated.
Jun 4 2019, 11:16 PM · Patch-For-Review, good first bug, Pywikibot-Scripts, Pywikibot
Mh-3110 added a comment to T222716: L10N of WelcomeBot is outdated.

Hi @Xqt, I would like to start working on this task.
Thanks

Jun 4 2019, 11:15 PM · Patch-For-Review, good first bug, Pywikibot-Scripts, Pywikibot

Jun 1 2019

Mh-3110 added a comment to T223816: Transferbot.py script could stop for many reasons, is it possible to just skip and continue ?.

Hi @Dvorapa , yeah my bad! I have just realized later after pushing.
Thanks

Jun 1 2019, 4:33 AM · good first bug, Pywikibot-Scripts, Pywikibot

May 31 2019

Mh-3110 added a comment to T223816: Transferbot.py script could stop for many reasons, is it possible to just skip and continue ?.

Ok thank you @Dvorapa

May 31 2019, 4:54 PM · good first bug, Pywikibot-Scripts, Pywikibot
Mh-3110 added a comment to T223816: Transferbot.py script could stop for many reasons, is it possible to just skip and continue ?.

@Dvorapa , what do you think about creating subtask for each case:
-A subtask for the case of {{bots}}, {{nobots}} templates presence
-A subtask for the case of page doesn't not exist( presence of illegal characters, page deleted after script launch)
-A subtask for the case of SpamBlackList

May 31 2019, 4:13 PM · good first bug, Pywikibot-Scripts, Pywikibot
Mh-3110 updated the task description for T223816: Transferbot.py script could stop for many reasons, is it possible to just skip and continue ?.
May 31 2019, 4:03 PM · good first bug, Pywikibot-Scripts, Pywikibot
Mh-3110 updated subscribers of T214849: Optimize LinguaLibre UI on mobile devices.
May 31 2019, 8:14 AM · Wikimania-Hackathon-2019, Lingua Libre
Mh-3110 updated subscribers of T214849: Optimize LinguaLibre UI on mobile devices.
May 31 2019, 8:14 AM · Wikimania-Hackathon-2019, Lingua Libre
Mh-3110 added a comment to T214849: Optimize LinguaLibre UI on mobile devices.

Hi, here were my first attempts but I got some feedbacks from UX specialists at the hackathon in Prague to improve it.

May 31 2019, 8:11 AM · Wikimania-Hackathon-2019, Lingua Libre

May 30 2019

Mh-3110 added a comment to T219198: Wikimedia Hackathon 2019 volunteer group: Blog .

My WMF Hackathon 19 experience: 3 Days, 2 Projects and many cool things!

May 30 2019, 5:13 PM · International-Developer-Events, User-Jdlrobson, Developer-Advocacy (Apr-Jun 2019), Wikimedia-Hackathon-2019-Organization, Wikimedia-Hackathon-2019

May 29 2019

Mh-3110 added a comment to T223740: Commons Game to identify figure skaters.

Hi @Harmonia_Amanda ,
could you please tell me where/how I can get the participant list?
Thanks

May 29 2019, 11:25 PM · Wikistorm-2019, Commons, Wikimedia-Hackathon-2019

May 26 2019

Mh-3110 added a comment to T223816: Transferbot.py script could stop for many reasons, is it possible to just skip and continue ?.

Thanks @Dvorapa . For SpamBlackList I don't know how to detect neither.
For nobots: below is the fix:

May 26 2019, 1:15 PM · good first bug, Pywikibot-Scripts, Pywikibot
Mh-3110 added a comment to T223816: Transferbot.py script could stop for many reasons, is it possible to just skip and continue ?.

@Nicolas_NALLET , thanks. What I want to point out here is that, as no page is supposed to contains such forbidden characters, we will process the same way as if page does not exist. Same thing in case page has been deleted after script was launched.
Fix will look like this:

May 26 2019, 12:53 PM · good first bug, Pywikibot-Scripts, Pywikibot

May 23 2019

Mh-3110 added a comment to T223862: Delete tools user account:Yoda Mah.

Thanks

May 23 2019, 11:24 PM · cloud-services-team (Kanban), Toolforge, wikitech.wikimedia.org
Mh-3110 added a comment to T223862: Delete tools user account:Yoda Mah.

@bd808 , can confirm that I'm now able to associate my Mah3110 wikimedia account to Mh-3110.

May 23 2019, 11:16 PM · cloud-services-team (Kanban), Toolforge, wikitech.wikimedia.org
Mh-3110 updated the task description for T216260: Wikimedia Hackathon 2019 Showcase / Closing .
May 23 2019, 10:49 PM · International-Developer-Events, Wikimedia-Hackathon-2019-Organization, Wikimedia-Hackathon-2019

May 22 2019

Mh-3110 added a comment to T223816: Transferbot.py script could stop for many reasons, is it possible to just skip and continue ?.

Hi @Nicolas_NALLET , what do you define as "Illegal characters". Could you please provide some examples?
Thanks

May 22 2019, 6:13 PM · good first bug, Pywikibot-Scripts, Pywikibot

May 21 2019

Mh-3110 updated the task description for T223862: Delete tools user account:Yoda Mah.
May 21 2019, 10:31 AM · cloud-services-team (Kanban), Toolforge, wikitech.wikimedia.org

May 20 2019

Mh-3110 created T223862: Delete tools user account:Yoda Mah.
May 20 2019, 4:57 AM · cloud-services-team (Kanban), Toolforge, wikitech.wikimedia.org

May 19 2019

Mh-3110 claimed T223816: Transferbot.py script could stop for many reasons, is it possible to just skip and continue ?.
May 19 2019, 5:14 PM · good first bug, Pywikibot-Scripts, Pywikibot
Mh-3110 added a comment to T223816: Transferbot.py script could stop for many reasons, is it possible to just skip and continue ?.

Hi, will be working on this task.
Thanks

May 19 2019, 5:14 PM · good first bug, Pywikibot-Scripts, Pywikibot

May 17 2019

Mh-3110 added a comment to T214849: Optimize LinguaLibre UI on mobile devices.

@0x010C , here are the next steps:

May 17 2019, 9:25 AM · Wikimania-Hackathon-2019, Lingua Libre
Mh-3110 added a member for Pywikibot: Mh-3110.
May 17 2019, 5:17 AM

Apr 4 2019

Mh-3110 added a comment to T51541: Add "thanks" links to Special:Watchlist and Special:Contributions.

My bad!

Apr 4 2019, 10:22 AM · Growth-Team, MediaWiki-Watchlist, Collaboration-Team-Triage, MediaWiki-Special-pages, Patch-For-Review, Thanks
Mh-3110 added a comment to T218255: Enabling api-request eventgate to group1 caused minor service disruptions .

Hi @Ottomata,
assigning this to you as you're working on it.
Thanks

Apr 4 2019, 4:37 AM · Core Platform Team Workboards (Done with CPT), Services (done), Analytics, EventBus, Core Platform Team (Needs Cleaning - Security, stability, performance and scalability (TEC1)), serviceops, Wikimedia-Incident, Operations
Mh-3110 assigned T218255: Enabling api-request eventgate to group1 caused minor service disruptions to Ottomata.
Apr 4 2019, 4:36 AM · Core Platform Team Workboards (Done with CPT), Services (done), Analytics, EventBus, Core Platform Team (Needs Cleaning - Security, stability, performance and scalability (TEC1)), serviceops, Wikimedia-Incident, Operations
Mh-3110 added a comment to T51541: Add "thanks" links to Special:Watchlist and Special:Contributions.

Hi @darthbhyrava,
assigning this to you as you're working on it.
Thanks

Apr 4 2019, 4:03 AM · Growth-Team, MediaWiki-Watchlist, Collaboration-Team-Triage, MediaWiki-Special-pages, Patch-For-Review, Thanks
Mh-3110 assigned T51541: Add "thanks" links to Special:Watchlist and Special:Contributions to darthbhyrava.
Apr 4 2019, 4:02 AM · Growth-Team, MediaWiki-Watchlist, Collaboration-Team-Triage, MediaWiki-Special-pages, Patch-For-Review, Thanks
Mh-3110 added a comment to T210747: "Thank" link is super tiny in desktop view on small screen widths in WebKit based browsers.

Hi @CKoerner_WMF ,
looking at this but cannot reproduce it. Can you still reproduce it on your side? Which version of chrome do you use?
Thanks

Apr 4 2019, 3:57 AM · Growth-Team, Browser-Support-Google-Chrome, Thanks

Mar 25 2019

Mh-3110 added a project to T214849: Optimize LinguaLibre UI on mobile devices: Wikimedia-Hackathon-2019.
Mar 25 2019, 11:10 AM · Wikimania-Hackathon-2019, Lingua Libre
Mh-3110 assigned T120753: Opt out of Thanks feature to happy5214.
Mar 25 2019, 8:02 AM · Growth-Team, Patch-For-Review, Pywikibot-Thanks, Thanks, Collaboration-Team-Triage, Community-Wishlist-Survey-2015
Mh-3110 updated subscribers of T120753: Opt out of Thanks feature.

Hi @happy5214 I'm assigning this task to you as you're working on it. The task is still assigned to none.

Mar 25 2019, 8:01 AM · Growth-Team, Patch-For-Review, Pywikibot-Thanks, Thanks, Collaboration-Team-Triage, Community-Wishlist-Survey-2015

Mar 23 2019

Mh-3110 added a comment to T219058: Temporary lift of IP cap for Francophone Month contribution 2019 in Bénin.

Oh, got it! Sorry, Will take it into account for next time.
We will use our personal phone connexion for this time.
Thanks

Mar 23 2019, 10:34 AM · User-Zoranzoki21, Wikimedia-Site-requests
Mh-3110 updated the task description for T219058: Temporary lift of IP cap for Francophone Month contribution 2019 in Bénin.
Mar 23 2019, 10:30 AM · User-Zoranzoki21, Wikimedia-Site-requests
Mh-3110 added a comment to T219058: Temporary lift of IP cap for Francophone Month contribution 2019 in Bénin.

Hi @Zoranzoki21 ,
yes it is today 23rd. We are currently running the session.
Thanks

Mar 23 2019, 10:30 AM · User-Zoranzoki21, Wikimedia-Site-requests
Mh-3110 created T219058: Temporary lift of IP cap for Francophone Month contribution 2019 in Bénin.
Mar 23 2019, 10:21 AM · User-Zoranzoki21, Wikimedia-Site-requests

Jan 30 2019

Mh-3110 renamed T214849: Optimize LinguaLibre UI on mobile devices from Optimze LinguaLibre UI on mobile devices to Optimize LinguaLibre UI on mobile devices.
Jan 30 2019, 5:34 PM · Wikimania-Hackathon-2019, Lingua Libre

Jan 28 2019

Mh-3110 renamed T214849: Optimize LinguaLibre UI on mobile devices from Optimze LinguaLibre UI on mobile device to Optimze LinguaLibre UI on mobile devices.
Jan 28 2019, 3:18 PM · Wikimania-Hackathon-2019, Lingua Libre
Mh-3110 moved T214849: Optimize LinguaLibre UI on mobile devices from Backlog to UI on the Lingua Libre board.
Jan 28 2019, 3:18 PM · Wikimania-Hackathon-2019, Lingua Libre
Mh-3110 created T214849: Optimize LinguaLibre UI on mobile devices.
Jan 28 2019, 3:17 PM · Wikimania-Hackathon-2019, Lingua Libre

Dec 13 2018

Mh-3110 added a comment to T201135: Allow custom categories.

Hi @0x010C,
I was not aware of the Lingua Libre hackathon, but sur I will join with pleasure.
Please, ping me when the development environment is ready.
Thanks

Dec 13 2018, 1:22 PM · Lingua Libre

Dec 4 2018

Mh-3110 claimed T201135: Allow custom categories.
Dec 4 2018, 4:23 PM · Lingua Libre
Mh-3110 assigned T201135: Allow custom categories to Mah3110.
Dec 4 2018, 1:02 PM · Lingua Libre
Mh-3110 added a comment to T201135: Allow custom categories.

Hi @0x010C,
I would like to start working on this.
Thanks

Dec 4 2018, 12:59 PM · Lingua Libre
Mh-3110 added a member for Lingua Libre: Mh-3110.
Dec 4 2018, 12:53 PM

Nov 29 2018

RazeSoldier awarded T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set" a Like token.
Nov 29 2018, 1:21 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks
Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

@SBisson ,
Thank you so much for your support on this!

Nov 29 2018, 1:07 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Nov 11 2018

Liuxinyu970226 awarded T195175: Fon Wikipedia project - Build a keyboard for editing articles in Fon a 100 token.
Nov 11 2018, 7:01 AM · UniversalLanguageSelector, Wikimedia-Hackathon-2018

Oct 28 2018

Mh-3110 closed T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set" as Resolved.
Oct 28 2018, 2:17 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks
Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

@Framawiki , this task is resolved. Thanks.
@RazeSoldier, can you comment more details why you say it is not resolved?
Note that this fix is not yet deployed in production.
Thanks

Oct 28 2018, 2:16 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Oct 27 2018

Restricted Application added a project to T117309: On Safari the thanks confirmation is not hidden correctly: Growth-Team.

@Umherirrender, have tested on Mac + Safari but cannot reproduce the issue as well.
Do you still reproduce it on your side?

Oct 27 2018, 3:47 PM · Growth-Team, Browser-Support-Apple-Safari, JavaScript, Collaboration-Team-Triage, Thanks

Oct 25 2018

Mh-3110 added a comment to T204178: "PHP Notice: Undefined index: revid" in SpecialThanks.php.
Oct 25 2018, 11:39 AM · Growth-Team, Thanks, Wikimedia-production-error

Oct 17 2018

Mh-3110 added a comment to T206427: Thanks: Remove unexpected '<' character from selector.

@SBisson ,
Thanks for the documentation. I don't think this is useful here but as it use is mentioned in the module documentation then it should be kept. I will close this ticket as invalid. My bad.
Thanks

Oct 17 2018, 8:30 PM · Patch-For-Review, Growth-Team, Thanks

Oct 16 2018

Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

Thanks @SBisson ,
I think I will open a new ticket to track the e.preventDefault() issue.
When focusing on the main issue we're tracking here in this ticket, I can notice that the below function is trying to get the flow post id from with a wrong param $data[revid]. There is no input in the submit form with the attribute name = revid. Then correcting it to $data[id] to get the correct flow post id fixes the issue.

/**
	 * Call the API internally.
	 * @param string[] $data The form data.
	 * @return Status
	 */
	public function onSubmit( array $data ) {
		if ( !isset( $data['id'] ) ) {
			return Status::newFatal( 'thanks-error-invalidrevision' );
		}
Oct 16 2018, 1:46 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Oct 10 2018

Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

@SBisson, I do really appreciate your motivating comment.
From my first look, here are notices:
1-On click on the 'Thank' link, it follows the Url even though there is a preventDefault() called on it.
2-When the 'Thank' link doesn't follow the URL (preventDefault() is working), then 'Send thank' succeeds. No error message. But it follows the link and open a new tab then 'Send thank' fails with the error message : "The postid parameter must be set"
3-It is a little bit weird as this is working fine in my local environment (Vagrant) but not in production.
I'm still investigating and I will surely let you if I have any question.
Thanks so much

Oct 10 2018, 2:44 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Oct 7 2018

Mh-3110 created T206427: Thanks: Remove unexpected '<' character from selector.
Oct 7 2018, 8:40 PM · Patch-For-Review, Growth-Team, Thanks

Oct 6 2018

Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

@SBisson ,
Following my comment on gerrit, please find attached the screenshot.

This is where that message is coming from: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/9fb7a9519d6911091d6d4738e8e7f8bde7b4d8c8/src/mobile.startup/mobile.startup.js#L11

Oct 6 2018, 8:26 AM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Sep 18 2018

Mh-3110 updated subscribers of T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

@SBisson ,
Following my comment on gerrit, please find attached the screenshot.

Sep 18 2018, 9:13 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Sep 17 2018

Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

[off-topic] @Mh-3110: Please do not put a ">>" at the beginning of lines when these lines are not quoted text that was originally written by somebody else. It is super confusing. See https://phabricator.wikimedia.org/T191442#4589122 in your browser. Thanks.

Sep 17 2018, 8:14 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks
Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

will start working on this.

@Mh-3110: How is it going? Do you need any help with something?

Sep 17 2018, 2:40 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Sep 16 2018

Mh-3110 added a comment to T188326: Thank dialog success page has no "return back" link.

I've tested but 2 notices;

  1. The thanks doesn't seem to be sent to the target user.
  2. When the link "Return to history" is clicked, I get a "File not found" page.

See images below;


Sep 16 2018, 6:59 AM · Patch-For-Review, Growth-Team, good first bug, Thanks, Collaboration-Team-Triage

Sep 1 2018

Mh-3110 added a comment to T188326: Thank dialog success page has no "return back" link.

Is that screenshot from dev or prod? As in prod this feature (go back to diff) doesn't exist.
Thanks

I'm testing on my local/development environment

This is now fixed with the new patch set I submitted. See attached screeshot. Thanks

Sep 1 2018, 8:41 AM · Patch-For-Review, Growth-Team, good first bug, Thanks, Collaboration-Team-Triage

Aug 26 2018

Mh-3110 added a comment to T188326: Thank dialog success page has no "return back" link.

Hi @D3r1ck01 , Don't get this point right.
Is that screenshot from dev or prod? As in prod this feature (go back to diff) doesn't exist.
Thanks

Aug 26 2018, 7:17 AM · Patch-For-Review, Growth-Team, good first bug, Thanks, Collaboration-Team-Triage

Aug 21 2018

Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

Hi,
will start working on this.
Thanks

Aug 21 2018, 9:43 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks
Mh-3110 added a comment to T188326: Thank dialog success page has no "return back" link.

yes @D3r1ck01 , this only happens on 'no-JS' mode. Clicking twice on the browser back button surely gets user back to the history page.

Aug 21 2018, 9:39 PM · Patch-For-Review, Growth-Team, good first bug, Thanks, Collaboration-Team-Triage
Mh-3110 added a comment to T188326: Thank dialog success page has no "return back" link.

Hi @D3r1ck01 ,
sure but from what I what I understood the link should lead back to the history page not the article itself. (see attached scrreenshot)

Aug 21 2018, 9:15 PM · Patch-For-Review, Growth-Team, good first bug, Thanks, Collaboration-Team-Triage
Mh-3110 added a comment to T201565: Phan error inside ThanksLogFormatter.

Hi,
This issue is also causing main test faillure. Case of the patch I've submitted for the Thanks extension. error log

Aug 21 2018, 3:17 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Growth-Team, phan-taint-check-plugin, Thanks

Aug 13 2018

Mh-3110 claimed T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".
Aug 13 2018, 12:09 AM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Aug 10 2018

Mh-3110 added a watcher for Thanks: Mh-3110.
Aug 10 2018, 10:12 AM
Mh-3110 added a member for Thanks: Mh-3110.
Aug 10 2018, 10:11 AM

Aug 6 2018

Mh-3110 moved T188326: Thank dialog success page has no "return back" link from New Contributor's Tasks (Incoming) to Tasks in progress (Doing) on the Africa-Wikimedia-Developers board.
Aug 6 2018, 7:23 PM · Patch-For-Review, Growth-Team, good first bug, Thanks, Collaboration-Team-Triage