Mh-3110 (Mh-3110)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 13 2018, 4:26 PM (35 w, 1 d)
Availability
Available
LDAP User
Mh-3110
MediaWiki User
Unknown

Recent Activity

Thu, Dec 13

Mh-3110 added a comment to T201135: Allow custom categories.

Hi @0x010C,
I was not aware of the Lingua Libre hackathon, but sur I will join with pleasure.
Please, ping me when the development environment is ready.
Thanks

Thu, Dec 13, 1:22 PM · Lingua Libre

Tue, Dec 4

Mh-3110 claimed T201135: Allow custom categories.
Tue, Dec 4, 4:23 PM · Lingua Libre
Mh-3110 assigned T201135: Allow custom categories to Mah3110.
Tue, Dec 4, 1:02 PM · Lingua Libre
Mh-3110 added a comment to T201135: Allow custom categories.

Hi @0x010C ?
I would like to start working on this.
Thanks

Tue, Dec 4, 12:59 PM · Lingua Libre
Mh-3110 added a member for Lingua Libre: Mh-3110.
Tue, Dec 4, 12:53 PM

Thu, Nov 29

RazeSoldier awarded T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set" a Like token.
Thu, Nov 29, 1:21 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks
Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

@SBisson ,
Thank you so much for your support on this!

Thu, Nov 29, 1:07 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Nov 11 2018

Liuxinyu970226 awarded T195175: Fon Wikipedia project - Build a keyboard for editing articles in Fon a 100 token.
Nov 11 2018, 7:01 AM · UniversalLanguageSelector, Wikimedia-Hackathon-2018

Oct 28 2018

Mh-3110 closed T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set" as Resolved.
Oct 28 2018, 2:17 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks
Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

@Framawiki , this task is resolved. Thanks.
@RazeSoldier, can you comment more details why you say it is not resolved?
Note that this fix is not yet deployed in production.
Thanks

Oct 28 2018, 2:16 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Oct 27 2018

Restricted Application added a project to T117309: On Safari the thanks confirmation is not hidden correctly: Growth-Team.

@Umherirrender, have tested on Mac + Safari but cannot reproduce the issue as well.
Do you still reproduce it on your side?

Oct 27 2018, 3:47 PM · Growth-Team, Browser-Support-Apple-Safari, JavaScript, Collaboration-Team-Triage, Thanks

Oct 25 2018

Mh-3110 added a comment to T204178: "PHP Notice: Undefined index: revid" in SpecialThanks.php.
Oct 25 2018, 11:39 AM · Growth-Team, Thanks, Wikimedia-production-error

Oct 17 2018

Mh-3110 added a comment to T206427: Thanks: Remove unexpected '<' character from selector.

@SBisson ,
Thanks for the documentation. I don't think this is useful here but as it use is mentioned in the module documentation then it should be kept. I will close this ticket as invalid. My bad.
Thanks

Oct 17 2018, 8:30 PM · Patch-For-Review, Growth-Team, Thanks

Oct 16 2018

Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

Thanks @SBisson ,
I think I will open a new ticket to track the e.preventDefault() issue.
When focusing on the main issue we're tracking here in this ticket, I can notice that the below function is trying to get the flow post id from with a wrong param $data[revid]. There is no input in the submit form with the attribute name = revid. Then correcting it to $data[id] to get the correct flow post id fixes the issue.

/**
	 * Call the API internally.
	 * @param string[] $data The form data.
	 * @return Status
	 */
	public function onSubmit( array $data ) {
		if ( !isset( $data['id'] ) ) {
			return Status::newFatal( 'thanks-error-invalidrevision' );
		}
Oct 16 2018, 1:46 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Oct 10 2018

Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

@SBisson, I do really appreciate your motivating comment.
From my first look, here are notices:
1-On click on the 'Thank' link, it follows the Url even though there is a preventDefault() called on it.
2-When the 'Thank' link doesn't follow the URL (preventDefault() is working), then 'Send thank' succeeds. No error message. But it follows the link and open a new tab then 'Send thank' fails with the error message : "The postid parameter must be set"
3-It is a little bit weird as this is working fine in my local environment (Vagrant) but not in production.
I'm still investigating and I will surely let you if I have any question.
Thanks so much

Oct 10 2018, 2:44 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Oct 7 2018

Mh-3110 created T206427: Thanks: Remove unexpected '<' character from selector.
Oct 7 2018, 8:40 PM · Patch-For-Review, Growth-Team, Thanks

Oct 6 2018

Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

@SBisson ,
Following my comment on gerrit, please find attached the screenshot.

This is where that message is coming from: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/9fb7a9519d6911091d6d4738e8e7f8bde7b4d8c8/src/mobile.startup/mobile.startup.js#L11

Oct 6 2018, 8:26 AM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Sep 18 2018

Mh-3110 updated subscribers of T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

@SBisson ,
Following my comment on gerrit, please find attached the screenshot.

Sep 18 2018, 9:13 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Sep 17 2018

Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

[off-topic] @Mh-3110: Please do not put a ">>" at the beginning of lines when these lines are not quoted text that was originally written by somebody else. It is super confusing. See https://phabricator.wikimedia.org/T191442#4589122 in your browser. Thanks.

Sep 17 2018, 8:14 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks
This is a test notification, sent at Mon, Sep 17, 5:39 PM.
Sep 17 2018, 3:39 PM
Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

will start working on this.

@Mh-3110: How is it going? Do you need any help with something?

Sep 17 2018, 2:40 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Sep 16 2018

Mh-3110 added a comment to T188326: Thank dialog success page has no "return back" link.

I've tested but 2 notices;

  1. The thanks doesn't seem to be sent to the target user.
  2. When the link "Return to history" is clicked, I get a "File not found" page.

    See images below;



Sep 16 2018, 6:59 AM · Patch-For-Review, Growth-Team, goodfirstbug, Collaboration-Team-Triage, Thanks

Sep 1 2018

Mh-3110 added a comment to T188326: Thank dialog success page has no "return back" link.

Is that screenshot from dev or prod? As in prod this feature (go back to diff) doesn't exist.
Thanks

I'm testing on my local/development environment

This is now fixed with the new patch set I submitted. See attached screeshot. Thanks

Sep 1 2018, 8:41 AM · Patch-For-Review, Growth-Team, goodfirstbug, Collaboration-Team-Triage, Thanks

Aug 26 2018

Mh-3110 added a comment to T188326: Thank dialog success page has no "return back" link.

Hi @D3r1ck01 , Don't get this point right.
Is that screenshot from dev or prod? As in prod this feature (go back to diff) doesn't exist.
Thanks

Aug 26 2018, 7:17 AM · Patch-For-Review, Growth-Team, goodfirstbug, Collaboration-Team-Triage, Thanks

Aug 21 2018

Mh-3110 added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

Hi,
will start working on this.
Thanks

Aug 21 2018, 9:43 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks
Mh-3110 added a comment to T188326: Thank dialog success page has no "return back" link.

yes @D3r1ck01 , this only happens on 'no-JS' mode. Clicking twice on the browser back button surely gets user back to the history page.

Aug 21 2018, 9:39 PM · Patch-For-Review, Growth-Team, goodfirstbug, Collaboration-Team-Triage, Thanks
Mh-3110 added a comment to T188326: Thank dialog success page has no "return back" link.

Hi @D3r1ck01 ,
sure but from what I what I understood the link should lead back to the history page not the article itself. (see attached scrreenshot)

Aug 21 2018, 9:15 PM · Patch-For-Review, Growth-Team, goodfirstbug, Collaboration-Team-Triage, Thanks
Mh-3110 added a comment to T201565: Phan error inside ThanksLogFormatter.

Hi,
This issue is also causing main test faillure. Case of the patch I've submitted for the Thanks extension. error log

Aug 21 2018, 3:17 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, Growth-Team, phan-taint-check-plugin, Thanks

Aug 13 2018

Mh-3110 claimed T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".
Aug 13 2018, 12:09 AM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Aug 10 2018

Mh-3110 added a watcher for Thanks: Mh-3110.
Aug 10 2018, 10:12 AM
Mh-3110 added a member for Thanks: Mh-3110.
Aug 10 2018, 10:11 AM

Aug 6 2018

Mh-3110 moved T188326: Thank dialog success page has no "return back" link from New Contributor's Tasks (Incoming) to Tasks in progress (Doing) on the Africa-Wikimedia-Developers board.
Aug 6 2018, 7:23 PM · Patch-For-Review, Growth-Team, goodfirstbug, Collaboration-Team-Triage, Thanks
Mh-3110 claimed T188326: Thank dialog success page has no "return back" link.
Aug 6 2018, 7:22 PM · Patch-For-Review, Growth-Team, goodfirstbug, Collaboration-Team-Triage, Thanks

Aug 5 2018

Restricted Application added a project to T188326: Thank dialog success page has no "return back" link: Growth-Team.

Hi @Dvorapa ,
I will start working on this task. But just to sure: this would be useful only in case user disable JS in the browser or open the link in a new tab. Right?
In that case I'm not sure there are so many users who disable Javascript in their browser or open the link in a new tab. I just need to be sure the feature will be really useful.
Thanks

Aug 5 2018, 8:45 AM · Patch-For-Review, Growth-Team, goodfirstbug, Collaboration-Team-Triage, Thanks
Mh-3110 added a watcher for JavaScript: Mh-3110.
Aug 5 2018, 8:08 AM
Mh-3110 added a member for JavaScript: Mh-3110.
Aug 5 2018, 8:08 AM

Aug 4 2018

Mh-3110 added a watcher for Africa-Wikimedia-Developers: Mh-3110.
Aug 4 2018, 12:04 PM
Mh-3110 added a member for Africa-Wikimedia-Developers: Mh-3110.
Aug 4 2018, 12:03 PM

May 27 2018

Mh-3110 added a comment to T194847: Wikimedia Hackathon Volunteer Group: Blogging.

My Achievements & learnings from the 2018 Hackathon

May 27 2018, 5:30 PM · Wikimedia-Hackathon-2018-Organization

May 20 2018

Mh-3110 renamed T195175: Fon Wikipedia project - Build a keyboard for editing articles in Fon from Fon Wikipedia project - Build a keyboard for writing Fon to Fon Wikipedia project - Build a keyboard for editing articles in Fon.
May 20 2018, 5:15 AM · UniversalLanguageSelector, Wikimedia-Hackathon-2018
Mh-3110 updated subscribers of T195175: Fon Wikipedia project - Build a keyboard for editing articles in Fon.

@Amire80

May 20 2018, 5:14 AM · UniversalLanguageSelector, Wikimedia-Hackathon-2018
Mh-3110 created T195175: Fon Wikipedia project - Build a keyboard for editing articles in Fon.
May 20 2018, 5:12 AM · UniversalLanguageSelector, Wikimedia-Hackathon-2018