Mon, Feb 10
Sat, Feb 8
Gah! I just remembered one more thing which may need to be checked/tweaked once migrateMobileviewToMobileHTMLIfNecessary is wired up to the normal article loading logic...
Fri, Feb 7
Thu, Feb 6
Reminder - will need to test with Chinese lang variant articles.
Jan 16 2020
carolyn found an android mailing list post asking about on-this-day for other langs.
Jan 13 2020
This has more detail on the colon char in this context, and explains why the tool above uses \3a - which was confusing me because of the space:
Though its suggestion for our selector a[rel=mw:MediaLink] (\3a ) is confusing... hmm...
This is pretty useful too! Lets you see how to escape css live as you type:
This seems relevant:
Someone else used same fix here:
parseProperty.js?921c:18 Uncaught (in promise) DOMException: Failed to execute 'querySelector' on 'Element': 'a[rel=mw:MediaLink]' is not a valid selector. at Object.parsePronunciation (webpack-internal:///148:20:47) at new MobileHTML (webpack-internal:///130:275:50) at convertParsoidDocumentToMobileHTML (webpack-internal:///129:7:20) at convertMobileViewJSONToMobileHTML (webpack-internal:///129:33:10) at testMobileView$ (webpack-internal:///129:187:24) at tryCatch (webpack-internal:///323:45:40) at Generator.invoke [as _invoke] (webpack-internal:///323:271:22) at Generator.prototype.<computed> [as next] (webpack-internal:///323:97:21) at tryCatch (webpack-internal:///323:45:40) at invoke (webpack-internal:///323:135:20) at eval (webpack-internal:///323:145:13)
Jan 11 2020
Jan 10 2020
Jan 7 2020
Dec 10 2019
Can add a script to build this (if we don't already have one) periodically from API source of truth.
Reminder: don't search all hidden tables - too slow - just un-collapse all tables when user searches may be best.
Cool thanks so much!
Dec 9 2019
Also, I am using a 2FA account.
Dec 7 2019
Dec 6 2019
In iOS a triple-home-button-click can be configured to show a VoiceOver toggle:
https://github.com/wikimedia/wikipedia-ios/pull/3381 adds grouping for 2 places on diff screens.
Method for creating a compound accessibilityLabel string:
Good article on the issue:
Fixes for the issues @ABorbaWMF found: https://github.com/wikimedia/wikipedia-ios/pull/3381
Dec 3 2019
Good catch! The accessibility inspector sees the individual elements when I tap its "next" button, but when tapping the items you indicated the container seems to be stealing focus! Looking at fix now...
Dec 2 2019
Nov 28 2019
Looks like some small bits remain:
Nov 27 2019
Reproducible with these data/time settings:
Nov 26 2019
closing since i created separate tasks for diff accessibility issues found and really no need for a parent ticket
Could potentially greatly improve parsing in some languages which use these aliases more heavily than EN...