Tue, Apr 16
Mon, Apr 15
Fri, Apr 12
Thu, Apr 11
Per @bearND see buildTocEntries.
Reminder: only needs to work against mobile-html:
Assuming the body is present (would have to be to get offsets) the method I was thinking about would be similar to...
...and would return data structured the way @Dbrant specified.
Still ok if I take a stab at this?
@bearND oh cool! will check it out!
Confirmed it's no longer reproducible.
Tue, Apr 9
Thu, Apr 4
@Mholloway oh sorry i missed this - was out last week :) will take a peek tomorrow.
Wed, Apr 3
Noticed while updating screenshotting.
@Dbrant answered my question above ^ it's cause Android's TOC needs to know all section offsets at once.
These change with screen dimensions (on rotation etc) and when tables are (un)collapsed. Shouldn't the offset simply be determined on click?
Mar 23 2019
@cmadeo The PR above adds the alert :)
See PR for animations:
Mar 20 2019
Haha oh that's cause I didn't see you'd added the alert mock ;)
Mar 19 2019
Closing this for new per chat with @NHarateh_WMF
Mar 18 2019
Updated here https://phabricator.wikimedia.org/T218622 by pulling in page lib fix.
Mar 14 2019
One thing to double-check - are we using the built-in CodeMirror mechanism: editor.setOption("theme", choice); See example at: https://codemirror.net/demo/theme.html
Mar 12 2019
Per the mocks it looks like for the 1st pass (until "Animating elements of the illustrations" follow-up) you'll only need a single image for each of the foreground animation views - currently WMFWelcomeIntroductionAnimationView (shows just the globe) is a good template for these. (so the "layer" overlap issue shouldn't come into play - though you'll still want to get all 4 pdf's from @cmadeo at exactly the same size and with built-in padding - see footnote)
Mar 9 2019
Mar 8 2019
Mar 7 2019
@cmadeo PR is up with animation and some edge-case screenshots :)
Feb 28 2019
@cmadeo there's a similar issue anytime selection encompasses more than text - especially if one end of the selection range is in the middle something... may be easier to play with edge cases once the basic functionality is wired up :)
Feb 27 2019
Feb 26 2019
@Jdlrobson thx for the help!! :)
@Jdlrobson ya it looks like it's the page library :/