Page MenuHomePhabricator

Michael (Michael Große (WMDE))
🦔

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 5 2018, 11:51 AM (121 w, 5 d)
Availability
Available
IRC Nick
Michael_WMDE
LDAP User
Michael Große
MediaWiki User
Michael Große (WMDE) [ Global Accounts ]

Berlin-based software developer for WMDE. Previously I worked on DokuWiki and WikiMatrix. Exited about PHP7.2 coming to our platforms.

Board: User-Michael
Meta: User:Michael_Große_(WMDE)
Tech: My Contributions
GitHub: micgro42
LinkedIn: https://www.linkedin.com/in/celenduin

🦔

Recent Activity

Wed, Mar 3

Michael moved T273001: (MS 3) Create Quantity input component from Doing to Peer Review on the Wikidata Query Builder board.

This leaves the validation and parsing to the application, for now at least. But that can be moved to the component with little effort, if we still want it.

Wed, Mar 3, 6:08 PM · User-Michael, Wikidata Query Builder, Wikidata
Michael added a comment to T274261: (optional) the popover should be responsive to prevent making the screen scroll.

Ways to approach it:

Wed, Mar 3, 1:48 PM · Wikidata Design System, Wikidata, Wikidata Query Builder
Michael renamed T273162: (MS 5) shorten URL for visual query sharing from (MS 5) 🛑 shorten URL for visual query sharing to (MS 5) shorten URL for visual query sharing.
Wed, Mar 3, 9:47 AM · Wikidata, Wikidata Query Builder

Tue, Mar 2

Michael updated the task description for T274157: Remove WikibaseRepo idGeneratorRateLimiting option.
Tue, Mar 2, 11:32 AM · wdwb-tech-focus (backlog), Wikidata-Campsite, Wikidata
Michael closed T276028: Safari Problem: PostCSS doesn't transform inset-inline-start, etc. as Invalid.

Turns out it did actually create the correct output, but the stories in the DS storybook do not have the dir attribute set by default

Tue, Mar 2, 9:56 AM · Wikidata, Wikidata Design System
Michael moved T273041: (MS 6) Create popover component from Ready to pick up to Peer Review on the Wikidata Query Builder board.
Tue, Mar 2, 9:02 AM · Wikidata, Wikidata Query Builder

Mon, Mar 1

Michael added a comment to T274149: Wikidata Bridge error.

T276146: Wikidata Bridge error was just created and now also contains the time at which that request happened down to the millisecond (though with some internal delay of a couple of milliseconds). Maybe that can be used to find the request in hadoop?

Mon, Mar 1, 6:59 PM · wdwb-tech-focus (backlog), MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikidata-Bridge
Michael closed T274259: position the popover based on a prop as Resolved.
Mon, Mar 1, 10:24 AM · Wikidata, Wikidata Query Builder
Michael closed T274259: position the popover based on a prop, a subtask of T273041: (MS 6) Create popover component, as Resolved.
Mon, Mar 1, 10:23 AM · Wikidata, Wikidata Query Builder
Michael created T276028: Safari Problem: PostCSS doesn't transform inset-inline-start, etc..
Mon, Mar 1, 8:57 AM · Wikidata, Wikidata Design System

Fri, Feb 26

Michael added a comment to T223968: Split Wikibase tests into unit and integration tests.

Not sure if this task is different from T96458: [Task] Separate unit tests from integration tests or not.

Fri, Feb 26, 5:30 PM · Patch-For-Review, Wikidata
Michael moved T275397: Change title of Query builder from Peer Review to Test (Verification) on the Wikidata Query Builder board.
Fri, Feb 26, 2:51 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder

Thu, Feb 25

Michael added a comment to T275397: Change title of Query builder.

@Michael added it as an AC to the ticket description

Thu, Feb 25, 11:22 AM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Michael added a comment to T275397: Change title of Query builder.

Should this still be a translated title, or should it always be in English?

Thu, Feb 25, 10:56 AM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Michael updated the task description for T274346: Add named slot for icon to Design System components with label.
Thu, Feb 25, 10:43 AM · Wikidata, Wikidata Query Builder
Michael merged T273046: Allow buttons to be full width into T274283: UX/UI improvements for the Query Builder.
Thu, Feb 25, 10:22 AM · User-Ladsgroup, Wikidata Query Builder, Wikidata
Michael merged task T273046: Allow buttons to be full width into T274283: UX/UI improvements for the Query Builder.
Thu, Feb 25, 10:22 AM · Wikidata, Wikidata Query Builder
Michael updated the task description for T274346: Add named slot for icon to Design System components with label.
Thu, Feb 25, 10:20 AM · Wikidata, Wikidata Query Builder
Michael updated the task description for T274346: Add named slot for icon to Design System components with label.
Thu, Feb 25, 8:59 AM · Wikidata, Wikidata Query Builder
Michael renamed T274346: Add named slot for icon to Design System components with label from Replace label icon prop with slot to Add named slot for icon to Design System components with label.
Thu, Feb 25, 8:55 AM · Wikidata, Wikidata Query Builder
Michael added a comment to T273046: Allow buttons to be full width.

Below 608px some Buttons become full-width now.

Thu, Feb 25, 7:37 AM · Wikidata, Wikidata Query Builder

Wed, Feb 24

Michael renamed T272692: (MS3) 🛑 Query for specific property with values in a specific range from (MS3) Query for specific property with values in a specific range to (MS3) 🛑 Query for specific property with values in a specific range.
Wed, Feb 24, 1:04 PM · Wikidata Query Builder, Wikidata
Michael renamed T268942: (MS 3) 🛑 query for quantity values from (MS 3) query for quantity values to (MS 3) 🛑 query for quantity values.
Wed, Feb 24, 1:04 PM · Wikidata, Wikidata Query Builder
Michael renamed T273162: (MS 5) shorten URL for visual query sharing from (MS 5) shorten URL for visual query sharing to (MS 5) 🛑 shorten URL for visual query sharing.
Wed, Feb 24, 1:03 PM · Wikidata, Wikidata Query Builder
Michael added a subtask for T275542: (MS 6) tooltips for some of the UI components: T274346: Add named slot for icon to Design System components with label.
Wed, Feb 24, 9:53 AM · Wikidata, Wikidata Query Builder
Michael edited parent tasks for T274346: Add named slot for icon to Design System components with label, added: T275542: (MS 6) tooltips for some of the UI components; removed: T273041: (MS 6) Create popover component.
Wed, Feb 24, 9:53 AM · Wikidata, Wikidata Query Builder
Michael removed a subtask for T273041: (MS 6) Create popover component: T274346: Add named slot for icon to Design System components with label.
Wed, Feb 24, 9:53 AM · Wikidata, Wikidata Query Builder
Michael added a comment to T273184: The editSPARQL query link does not generate results in query.wikidata.org.

This took hours and a headache to let me understand what's happening.

The fix is: https://github.com/wmde/query-builder/pull/209

So, it doesn't happen if you copy-paste the url but it does happen if you refresh the page with ctrl+r, at first I thought it might be something in the headers and referrer was a candidate. It was the only thing different in headers when you make a request by copy-pasting the URL but it doesn't happen if you right-click on it and open on the new tab and it does have the referrer too so that's not the issue. Comparing how we make the iframe with scholia (and reading about iframes in general). I learned that we sandbox our iframe which does some security measure. The problem is that sandbox is extremely restrictive (which is a good thing in general) and you need to turn on each feature one by one. The reason this happens is that when you click on it meaning you allow a popups, it carries the sandbox mode to the new tab and it breaks wdqs gui (I couldn't figure out exactly how, the number of caught exceptions in gui is really astonishing) but when turning on allow-popups-to-escape-sandbox would fix it. I assume when don't let bad js being ran in the iframe nor we link to problematic websites there. So this is fine.

Wed, Feb 24, 7:45 AM · User-Ladsgroup, Wikidata Query Builder, Wikidata

Mon, Feb 22

Michael awarded T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015) a Like token.
Mon, Feb 22, 11:56 AM · Performance-Team, JavaScript, MediaWiki-ResourceLoader
Michael added a comment to T274569: Uncaught TypeError: activeInstances[i].update is not a function.

The link to logstash doesn't work anymore. Can you share it using the share function?

Mon, Feb 22, 9:53 AM · wdwb-tech-focus (backlog), User-Ladsgroup, MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), JavaScript, Wikidata, Wikidata-Campsite, Wikibase, Wikimedia-production-error

Fri, Feb 19

Michael moved T273768: Use Cypress for Browser tests from Ready to pick up to Done on the Wikidata Query Builder board.
Fri, Feb 19, 5:12 PM · Wikidata, Wikidata Query Builder
Michael claimed T273001: (MS 3) Create Quantity input component.
Fri, Feb 19, 2:31 PM · User-Michael, Wikidata Query Builder, Wikidata
Michael updated the task description for T275189: Favicon for the Simple Query Builder.
Fri, Feb 19, 9:19 AM · Wikidata, Wikidata Query Builder
Michael created T275189: Favicon for the Simple Query Builder.
Fri, Feb 19, 9:15 AM · Wikidata, Wikidata Query Builder

Thu, Feb 18

Michael moved T275010: Create basic NumberInput component from Incoming to Backlog on the Wikidata Query Builder board.
Thu, Feb 18, 10:19 AM · Wikidata, Wikidata Query Builder
Michael moved T275113: Validation for ExtendedNumberInput from Incoming to Ready to pick up on the Wikidata Query Builder board.
Thu, Feb 18, 9:57 AM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Michael moved T275114: Create actual extended number input component from Incoming to Ready to pick up on the Wikidata Query Builder board.
Thu, Feb 18, 9:57 AM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Michael moved T272887: (MS 5) expose visual query sharing via URL in the UI from Ready to pick up to ❌ Blocked on the Wikidata Query Builder board.
Thu, Feb 18, 9:54 AM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Michael added a comment to T273001: (MS 3) Create Quantity input component.
NOTE: Get started with this component in parallel to T273796 by using a TextInput until T273796 is done
Thu, Feb 18, 9:54 AM · User-Michael, Wikidata Query Builder, Wikidata
Michael created T275114: Create actual extended number input component.
Thu, Feb 18, 9:50 AM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Michael created T275113: Validation for ExtendedNumberInput.
Thu, Feb 18, 9:41 AM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Michael moved T274260: Add pointer from Peer Review to Done on the Wikidata Query Builder board.
Thu, Feb 18, 9:01 AM · User-Michael, Wikidata, Wikidata Query Builder

Wed, Feb 17

Michael moved T274260: Add pointer from Doing to Peer Review on the Wikidata Query Builder board.

See the last commit at https://github.com/wmde/wikit/pull/373

Wed, Feb 17, 4:18 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael claimed T274260: Add pointer.
Wed, Feb 17, 1:03 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael moved T274346: Add named slot for icon to Design System components with label from Backlog to Ready for story time on the Wikidata Query Builder board.
Wed, Feb 17, 1:03 PM · Wikidata, Wikidata Query Builder
Michael moved T273796: Create extended number input component from Incoming to Ready for story time on the Wikidata Query Builder board.
Wed, Feb 17, 10:35 AM · Wikidata, Wikidata Query Builder
Michael updated the task description for T273001: (MS 3) Create Quantity input component.
Wed, Feb 17, 10:22 AM · User-Michael, Wikidata Query Builder, Wikidata

Tue, Feb 16

Michael added a comment to T272984: scrolling to new condition.

@Charlie_WMDE could you have a look whether that behavior matches what you want? 👉 https://602b923272a7a9709d1ecca6--clicky-sparqly.netlify.app/

Tue, Feb 16, 4:23 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Michael added a comment to T274283: UX/UI improvements for the Query Builder.

Improvement C:
i forgot to leave specs for the placement of the checkboxes inside of the decorator. i added them now in the mobile mock for space reasons, but the same specs apply for desktop and they're all using the same token. let me know if this should be an extra ticket or can be done in this one

Done: https://github.com/wmde/query-builder/pull/202

Improvement E:

  • The buttons switch to full width a bit later than layout 4 is triggered

Done: https://github.com/wmde/query-builder/pull/202

Tue, Feb 16, 4:20 PM · User-Ladsgroup, Wikidata Query Builder, Wikidata
Michael moved T274258: open on clicking the icon, close on click anywhere outside the popover from Doing to Peer Review on the Wikidata Query Builder board.

New commits to review: https://github.com/wmde/wikit/pull/373

Tue, Feb 16, 3:07 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael claimed T274258: open on clicking the icon, close on click anywhere outside the popover.
Tue, Feb 16, 1:51 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael added a comment to T273184: The editSPARQL query link does not generate results in query.wikidata.org.

This is an interesting bug. It DOES occur if you left-click that Edit SPARQL link. It does NOT occur, if you middle-click it, if you ctrl-click it, or if you right-click it and select "Open in a new tab". 🤔

Tue, Feb 16, 9:21 AM · User-Ladsgroup, Wikidata Query Builder, Wikidata
Michael added a comment to T268643: Add "footer".

This is done? @Michael

Tue, Feb 16, 8:59 AM · Wikidata, Wikidata Query Builder
Ladsgroup awarded T273500: Ensure all CSS classes follow proper BEM methodology a Love token.
Tue, Feb 16, 7:42 AM · Wikidata, wdwb-tech-focus (backlog), Wikidata Query Builder

Mon, Feb 15

Michael moved T272999: Make the OptionsMenu scroll active through keyboard on Chrome from Doing to Peer Review on the Wikidata Query Builder board.
Mon, Feb 15, 4:56 PM · User-Michael, Wikidata Query Builder, Wikidata
Michael closed T274257: open and close popover component on hover over the target, a subtask of T273041: (MS 6) Create popover component, as Resolved.
Mon, Feb 15, 4:29 PM · Wikidata, Wikidata Query Builder
Michael closed T274257: open and close popover component on hover over the target as Resolved.
Mon, Feb 15, 4:29 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael moved T274257: open and close popover component on hover over the target from Peer Review to Done on the Wikidata Query Builder board.
Mon, Feb 15, 4:28 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael added a comment to T274659: "Subtask-Checkbox" should be visible right from the beginning if a datatype wikibase-item is reconstructed.

@Michael So, the subclass checkbox should be visible as the page is loaded ? Am I correct?

Mon, Feb 15, 3:24 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael claimed T272999: Make the OptionsMenu scroll active through keyboard on Chrome.
Mon, Feb 15, 2:44 PM · User-Michael, Wikidata Query Builder, Wikidata
Michael moved T274659: "Subtask-Checkbox" should be visible right from the beginning if a datatype wikibase-item is reconstructed from Peer Review to Test (Verification) on the Wikidata Query Builder board.
Mon, Feb 15, 2:09 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael moved T274659: "Subtask-Checkbox" should be visible right from the beginning if a datatype wikibase-item is reconstructed from ❌ Blocked to Peer Review on the Wikidata Query Builder board.
Mon, Feb 15, 11:57 AM · User-Michael, Wikidata, Wikidata Query Builder
Michael moved T274659: "Subtask-Checkbox" should be visible right from the beginning if a datatype wikibase-item is reconstructed from Doing to ❌ Blocked on the Wikidata Query Builder board.
Mon, Feb 15, 11:50 AM · User-Michael, Wikidata, Wikidata Query Builder
Michael claimed T274659: "Subtask-Checkbox" should be visible right from the beginning if a datatype wikibase-item is reconstructed.
Mon, Feb 15, 11:20 AM · User-Michael, Wikidata, Wikidata Query Builder
Michael closed T273868: Debounce Entity lookup inputs as Resolved.
Mon, Feb 15, 10:27 AM · User-Michael, Wikidata, Wikidata Query Builder
Michael closed T274256: create first version of popover component, a subtask of T273041: (MS 6) Create popover component, as Resolved.
Mon, Feb 15, 10:26 AM · Wikidata, Wikidata Query Builder
Michael closed T274256: create first version of popover component as Resolved.
Mon, Feb 15, 10:26 AM · User-Michael, Wikidata, Wikidata Query Builder
Michael closed T273771: Integrate Cypress into our GitHub CI as Resolved.
Mon, Feb 15, 10:25 AM · Wikidata, Wikidata Query Builder
Michael closed T273771: Integrate Cypress into our GitHub CI, a subtask of T273768: Use Cypress for Browser tests, as Resolved.
Mon, Feb 15, 10:25 AM · Wikidata, Wikidata Query Builder
Michael closed T273775: Rewrite the existing SauceLabs/Nightwatch Browser Test to Cypress and drop SauceLabs, a subtask of T273768: Use Cypress for Browser tests, as Resolved.
Mon, Feb 15, 10:25 AM · Wikidata, Wikidata Query Builder
Michael closed T273775: Rewrite the existing SauceLabs/Nightwatch Browser Test to Cypress and drop SauceLabs as Resolved.
Mon, Feb 15, 10:25 AM · Wikidata, Wikidata Query Builder
Michael moved T273775: Rewrite the existing SauceLabs/Nightwatch Browser Test to Cypress and drop SauceLabs from Test (Verification) to Done on the Wikidata Query Builder board.
Mon, Feb 15, 10:24 AM · Wikidata, Wikidata Query Builder
Michael moved T273771: Integrate Cypress into our GitHub CI from Test (Verification) to Done on the Wikidata Query Builder board.
Mon, Feb 15, 10:24 AM · Wikidata, Wikidata Query Builder

Fri, Feb 12

Michael changed the subtype of T270111: Consider a different font for arabic script from "Task" to "Bug Report".

This should be doable with something like

Fri, Feb 12, 5:33 PM · Wikidata, Wikidata Query Builder
Michael changed the subtype of T272609: fix checkbox issues from "Task" to "Bug Report".
Fri, Feb 12, 5:28 PM · Wikidata Query Builder, Wikidata
Michael changed the subtype of T273306: Searches "Without some condition" and labels always time out from "Task" to "Bug Report".
Fri, Feb 12, 5:27 PM · Wikidata, Wikidata Query Builder
Michael moved T274346: Add named slot for icon to Design System components with label from Incoming to Backlog on the Wikidata Query Builder board.
Fri, Feb 12, 5:26 PM · Wikidata, Wikidata Query Builder
Michael moved T272999: Make the OptionsMenu scroll active through keyboard on Chrome from Incoming to Ready to pick up on the Wikidata Query Builder board.
Fri, Feb 12, 5:25 PM · User-Michael, Wikidata Query Builder, Wikidata
Michael changed the subtype of T272999: Make the OptionsMenu scroll active through keyboard on Chrome from "Task" to "Bug Report".
Fri, Feb 12, 5:25 PM · User-Michael, Wikidata Query Builder, Wikidata
Michael moved T274257: open and close popover component on hover over the target from Doing to Peer Review on the Wikidata Query Builder board.

Added another commit to #373 with the hover behavior

Fri, Feb 12, 5:06 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael claimed T274257: open and close popover component on hover over the target.
Fri, Feb 12, 3:45 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael moved T274659: "Subtask-Checkbox" should be visible right from the beginning if a datatype wikibase-item is reconstructed from Incoming to Ready to pick up on the Wikidata Query Builder board.
Fri, Feb 12, 3:40 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael created T274659: "Subtask-Checkbox" should be visible right from the beginning if a datatype wikibase-item is reconstructed.
Fri, Feb 12, 3:40 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael created T274632: Update Termbox dependencies.
Fri, Feb 12, 11:49 AM · Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wdwb-tech-focus (backlog), Wikidata, Wikidata-Termbox
Michael created T274626: wikidata-query-gui build tooling uses outdated packages (via grunt).
Fri, Feb 12, 10:44 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wdwb-tech-focus (backlog), Wikidata Query UI, Wikidata
Michael moved T274256: create first version of popover component from Peer Review to Done on the Wikidata Query Builder board.
Fri, Feb 12, 9:03 AM · User-Michael, Wikidata, Wikidata Query Builder

Thu, Feb 11

Michael moved T274256: create first version of popover component from Doing to Peer Review on the Wikidata Query Builder board.
Thu, Feb 11, 5:15 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael claimed T274256: create first version of popover component.
Thu, Feb 11, 2:47 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael moved T273796: Create extended number input component from Ready to pick up to Incoming on the Wikidata Query Builder board.
Thu, Feb 11, 11:17 AM · Wikidata, Wikidata Query Builder

Wed, Feb 10

Michael added a comment to T273868: Debounce Entity lookup inputs.

PR up for review: https://github.com/wmde/query-builder/pull/194

Wed, Feb 10, 7:13 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael claimed T273868: Debounce Entity lookup inputs.
Wed, Feb 10, 7:12 PM · User-Michael, Wikidata, Wikidata Query Builder
Michael moved T273795: Investigation: Number input component from Ongoing to Needs review on the Wikidata Design System board.
Wed, Feb 10, 4:38 PM · User-Michael, Wikidata Query Builder, Wikidata Design System, Wikidata
Michael moved T273795: Investigation: Number input component from Doing to Peer Review on the Wikidata Query Builder board.
Wed, Feb 10, 4:38 PM · User-Michael, Wikidata Query Builder, Wikidata Design System, Wikidata
Michael added a comment to T273795: Investigation: Number input component.
  1. <input type="number" />
Wed, Feb 10, 4:38 PM · User-Michael, Wikidata Query Builder, Wikidata Design System, Wikidata
Michael added a comment to T273768: Use Cypress for Browser tests.

As far as I can tell that is the only thing needed in the case of pointing browser tests to saucelabs for example? some sort of auth?

Wed, Feb 10, 4:16 PM · Wikidata, Wikidata Query Builder
Michael added a comment to T274258: open on clicking the icon, close on click anywhere outside the popover.

For clicking outside, https://vuetifyjs.com/en/api/v-click-outside/ could be an inspiration

Wed, Feb 10, 11:50 AM · User-Michael, Wikidata, Wikidata Query Builder
Michael renamed T274346: Add named slot for icon to Design System components with label from Replace label icon slot with prop to Replace label icon prop with slot.
Wed, Feb 10, 11:05 AM · Wikidata, Wikidata Query Builder
Michael claimed T273795: Investigation: Number input component.
Wed, Feb 10, 9:48 AM · User-Michael, Wikidata Query Builder, Wikidata Design System, Wikidata
Michael moved T273661: Reconstruct the QueryBuilder from a generated URL from Peer Review to Done on the Wikidata Query Builder board.
Wed, Feb 10, 9:18 AM · User-Michael, Wikidata, Wikidata Query Builder
Michael added a comment to T273052: Value type not detected in the visual query after using 'regardless of value' .

Can you refresh my memory from the story time? Have we decided to just clean everything once "regardless of value" is selected or we decided to keep it but hide it?

Wed, Feb 10, 9:00 AM · Wikidata Query Builder, Wikidata