In T228857#5885189, @Pablo-WMDE wrote:

https://gerrit.wikimedia.org/r/571482 is an attempt at reducing the size, but without changing the content. "Tree shaking" (e.g. https://github.com/indutny/webpack-common-shake/) is a much harder problem, and - if it were added - would have to come as an earlier step (i.e. before uglify).

List of things left Todo from the last pairing session:

• The button on the bailout screen should have a font-size of 14px, a total height of 32 px, with a margin-top of 4px and a margin-bottom of 5px
• The color of the button icons should be #222 -> T245150
• On the bailout screen the bullet points should be indented like the bullet points in the cascade protection list of pages
• The size of the x in the close button should be 20px by 20px and the total dimensions of the button should be 40px by 40px, thus the inner size of the header needs to be 40px, too -> https://gerrit.wikimedia.org/r/547198

In T239421#5877653, @Lucas_Werkmeister_WMDE wrote:

@Michael Is this ready for Verification already or is more work still missing?

@Charlie_WMDE My suggested views to look at for this task:

No, I cannot. caniuse now seems to indicate that it should work on IE11 fine without prefix? I could have sworn it was different in September when I created this ticket. I will close this for now and if that problem should show up again, then I'll reopen it.

In T240340#5865278, @Lucas_Werkmeister_WMDE wrote:

remove existing storybook installation on toolforge

see Toolforge (Tools to be deleted)

In T240212#5864400, @Charlie_WMDE wrote:

[...]

okay, but this would never occur in production, right? i think that was my actual question. sorry for not specifying.

In T240212#5863965, @Charlie_WMDE wrote:

question: is this "String Property: multiple statement" the property name? seems weird to me.

This has been resolved by adopting vuex-smart-modules in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/566818

This has been implemented for DataBridge in context of T240329: Set up a shared Vue component library for Wikibase.

In T235753#5852246, @Lucas_Werkmeister_WMDE wrote:

So either we apply the same fix (scale the margin appropriately to cancel out the font size), or we rethink this whole px-to-em business, because at least I don’t understand it at all.

In T241180#5843150, @simnalamburt wrote:

P.S. Please check https://github.com/developit/htm. HTM is useful when you want to use React without any build tools or JSX. HTM template is a string too so maybe you’ll be able to leverage ResourceLoader just like the Vue template.

This relates to T243192: font size adjustments

This seems to have been made worse by T243725: HtmlPageLinkRendererBeginHookHandler creates a LanguageFallbackChain when it may not be needed. The patches for that Wikibase/Babel issue are already merged into master and should be deployed with the next train scheduled for 2020-02-05(?).

In T241180#5822020, @AronManning wrote:

To neutrally asses the risks, we have to consider Facebook's attempt to change the license of React. Vue is not in a position where such an attempt could be made.

In T235753#5819595, @Lucas_Werkmeister_WMDE wrote:

The second bullet point already doesn’t work as a continuation of the “Instead you could” sentence beginning, so it might make sense to make the first bullet point separate too, I think.

This is related to the errors with the phatality id ab64e499d026f371bf3bdeb734a881ce0a881b28744605e775d113987d28702c

T243192: font size adjustments is related to this.

In T243192#5816612, @Michael wrote:

While thinking about it more, I feel a component in a library should probably use em instead of rem in order to respect the styles of the components that wrap it. So maybe we should change that.
But then, there is a font-size: 0.875em on body > .oo-ui-windowManager that is around the entire data bridge app. So an font-size: 1em; in this radio-button would currently result in a rendered size of 14px instead of the expected 16px.
How do we deal with that? We could add a font-size: calc(1em/0.875); on #data-bridge-app?

Both actual usage and browser tests were already done as part of T239802: Require editDecision to enable save button. This is ready to be verified as soon as 562867 is merged.

Dev + UX synced that the button should indeed only be hidden for the error state. It should be visible (though possibly disabled) for the initializing and saving state.

@Charlie_WMDE Wondering if maybe the property label should be in quotes? The reason is that there are properties like "located in the administrative territorial entity" where the title would otherwise read "Edit located in the administrative territorial entity". Which sounds somewhat misleading to me. But maybe this is a non-issue and obvious from context?

Yes, the intention of the ticket makes sense to me.

I'm wasn't able to find the associate Figma mock, but what happens if "References"-heading and the new link are too long to fit on the same line? This bound to happen in some languages, surely in German.

This was implemented in T240329: Set up a shared Vue component library for Wikibase and T240445: Publish storybook on doc.wikimedia.org.

This turned out to be a Safari Issue. I'm currently working on a patch using flex-shrink: 0; that seems to do the trick

Our storybook is now available at https://doc.wikimedia.org/Wikibase/master/js/data-bridge-storybook/

T216692: Security review for WikibaseSchema can be accessed again as well. Thank you! 👍

Meh. Even though https://phabricator.wikimedia.org/maniphest/query/iOXFoS3DwML3/#R seems to indicate that no task has the deprecated-security-team-reviews tag anymore, at least one related task can no longer be reached with the same error: T216692: Security review for WikibaseSchema 😕

\Wikibase\Rdf\DispatchingValueSnakRdfBuilder::addValue seems to get an UnDeserializableValue

Storybook has been updated: https://tools-static.wmflabs.org/wikibase-databridge-storybook/?path=/story/initializing--default

We likely want to do the update flow in two edits to have useful edit summaries.

@Charlie_WMDE @Sarai-WMDE: We adjusted the global styles of the Storybook so that it should be by default closer to the OOUI Demo page. Could you verify this component again?

Yes, that file was created in context of T213726: Register Schema: namespace. I don't think it is needed anymore.

In T237527#5693196, @Michael wrote:

In T237527#5693170, @Lucas_Werkmeister_WMDE wrote:

Actually, let’s put this in verification. Can someone update the storybook? (See T235763 for instructions.)

Can do.

In T237527#5693170, @Lucas_Werkmeister_WMDE wrote:

Actually, let’s put this in verification. Can someone update the storybook? (See T235763 for instructions.)

We discussed that the investigation (T237522) uncovered that we currently cannot get the intended blockee from the mediawiki API. We decided that for now, we drop that requirement, i.e. that bullet point in the error message, and create a ticket to follow up later. See T238828: Show intended blockee in blocked message in wikidata bridge

Left todo: create the dashboards in grafana