This leaves the validation and parsing to the application, for now at least. But that can be moved to the component with little effort, if we still want it.

Ways to approach it:

Turns out it did actually create the correct output, but the stories in the DS storybook do not have the dir attribute set by default

T276146: Wikidata Bridge error was just created and now also contains the time at which that request happened down to the millisecond (though with some internal delay of a couple of milliseconds). Maybe that can be used to find the request in hadoop?

In T223968#6864909, @Lucas_Werkmeister_WMDE wrote:

Not sure if this task is different from T96458: [Task] Separate unit tests from integration tests or not.

In T275397#6860443, @Charlie_WMDE wrote:

@Michael added it as an AC to the ticket description

Should this still be a translated title, or should it always be in English?

Below 608px some Buttons become full-width now.

In T273184#6853575, @Ladsgroup wrote:

This took hours and a headache to let me understand what's happening.

The fix is: https://github.com/wmde/query-builder/pull/209

So, it doesn't happen if you copy-paste the url but it does happen if you refresh the page with ctrl+r, at first I thought it might be something in the headers and referrer was a candidate. It was the only thing different in headers when you make a request by copy-pasting the URL but it doesn't happen if you right-click on it and open on the new tab and it does have the referrer too so that's not the issue. Comparing how we make the iframe with scholia (and reading about iframes in general). I learned that we sandbox our iframe which does some security measure. The problem is that sandbox is extremely restrictive (which is a good thing in general) and you need to turn on each feature one by one. The reason this happens is that when you click on it meaning you allow a popups, it carries the sandbox mode to the new tab and it breaks wdqs gui (I couldn't figure out exactly how, the number of caught exceptions in gui is really astonishing) but when turning on allow-popups-to-escape-sandbox would fix it. I assume when don't let bad js being ran in the iframe nor we link to problematic websites there. So this is fine.

In T274569#6847963, @Ladsgroup wrote:

The link to logstash doesn't work anymore. Can you share it using the share function?

See the last commit at https://github.com/wmde/wikit/pull/373

@Charlie_WMDE could you have a look whether that behavior matches what you want? 👉 https://602b923272a7a9709d1ecca6--clicky-sparqly.netlify.app/

In T274283#6833303, @Ladsgroup wrote:

In T274283#6833078, @Charlie_WMDE wrote:

Improvement C:
i forgot to leave specs for the placement of the checkboxes inside of the decorator. i added them now in the mobile mock for space reasons, but the same specs apply for desktop and they're all using the same token. let me know if this should be an extra ticket or can be done in this one

Done: https://github.com/wmde/query-builder/pull/202

Improvement E:

• The buttons switch to full width a bit later than layout 4 is triggered

Done: https://github.com/wmde/query-builder/pull/202

New commits to review: https://github.com/wmde/wikit/pull/373

This is an interesting bug. It DOES occur if you left-click that Edit SPARQL link. It does NOT occur, if you middle-click it, if you ctrl-click it, or if you right-click it and select "Open in a new tab". 🤔

In T268643#6832038, @Ladsgroup wrote:

This is done? @Michael

In T274659#6830794, @amy_rc wrote:

@Michael So, the subclass checkbox should be visible as the page is loaded ? Am I correct?

This should be doable with something like

Added another commit to #373 with the hover behavior

PR up for review: https://github.com/wmde/query-builder/pull/194

1. <input type="number" />

In T273768#6811439, @Addshore wrote:

As far as I can tell that is the only thing needed in the case of pointing browser tests to saucelabs for example? some sort of auth?

For clicking outside, https://vuetifyjs.com/en/api/v-click-outside/ could be an inspiration

In T273052#6816996, @Ladsgroup wrote:

Can you refresh my memory from the story time? Have we decided to just clean everything once "regardless of value" is selected or we decided to keep it but hide it?