Fri, Feb 14
List of things left Todo from the last pairing session:
- The button on the bailout screen should have a font-size of 14px, a total height of 32 px, with a margin-top of 4px and a margin-bottom of 5px
- The color of the button icons should be #222 -> T245150
- On the bailout screen the bullet points should be indented like the bullet points in the cascade protection list of pages
- The size of the x in the close button should be 20px by 20px and the total dimensions of the button should be 40px by 40px, thus the inner size of the header needs to be 40px, too -> https://gerrit.wikimedia.org/r/547198
Thu, Feb 13
Wed, Feb 12
@Charlie_WMDE My suggested views to look at for this task:
Tue, Feb 11
No, I cannot. caniuse now seems to indicate that it should work on IE11 fine without prefix? I could have sworn it was different in September when I created this ticket. I will close this for now and if that problem should show up again, then I'll reopen it.
Mon, Feb 10
Thu, Feb 6
This has been resolved by adopting vuex-smart-modules in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/566818
This has been implemented for DataBridge in context of T240329: Set up a shared Vue component library for Wikibase.
Wed, Feb 5
Fri, Jan 31
Tue, Jan 28
This relates to T243192: font size adjustments
Mon, Jan 27
This seems to have been made worse by T243725: HtmlPageLinkRendererBeginHookHandler creates a LanguageFallbackChain when it may not be needed. The patches for that Wikibase/Babel issue are already merged into master and should be deployed with the next train scheduled for 2020-02-05(?).
Fri, Jan 24
Wed, Jan 22
Tue, Jan 21
This is related to the errors with the phatality id ab64e499d026f371bf3bdeb734a881ce0a881b28744605e775d113987d28702c
T243192: font size adjustments is related to this.
Mon, Jan 20
Both actual usage and browser tests were already done as part of T239802: Require editDecision to enable save button. This is ready to be verified as soon as 562867 is merged.
Dev + UX synced that the button should indeed only be hidden for the error state. It should be visible (though possibly disabled) for the initializing and saving state.
@Charlie_WMDE Wondering if maybe the property label should be in quotes? The reason is that there are properties like "located in the administrative territorial entity" where the title would otherwise read "Edit located in the administrative territorial entity". Which sounds somewhat misleading to me. But maybe this is a non-issue and obvious from context?
Yes, the intention of the ticket makes sense to me.
Jan 16 2020
I'm wasn't able to find the associate Figma mock, but what happens if "References"-heading and the new link are too long to fit on the same line? This bound to happen in some languages, surely in German.
Jan 15 2020
This was implemented in T240329: Set up a shared Vue component library for Wikibase and T240445: Publish storybook on doc.wikimedia.org.
Jan 13 2020
This turned out to be a Safari Issue. I'm currently working on a patch using flex-shrink: 0; that seems to do the trick
Jan 10 2020
Our storybook is now available at https://doc.wikimedia.org/Wikibase/master/js/data-bridge-storybook/
T216692: Security review for WikibaseSchema can be accessed again as well. Thank you! 👍
Jan 8 2020
Meh. Even though https://phabricator.wikimedia.org/maniphest/query/iOXFoS3DwML3/#R seems to indicate that no task has the deprecated-security-team-reviews tag anymore, at least one related task can no longer be reached with the same error: T216692: Security review for WikibaseSchema 😕
Jan 7 2020
Jan 6 2020
Dec 13 2019
\Wikibase\Rdf\DispatchingValueSnakRdfBuilder::addValue seems to get an UnDeserializableValue
Dec 12 2019
Dec 11 2019
Dec 10 2019
Nov 29 2019
Storybook has been updated: https://tools-static.wmflabs.org/wikibase-databridge-storybook/?path=/story/initializing--default
Nov 28 2019
We likely want to do the update flow in two edits to have useful edit summaries.
Nov 27 2019
Yes, that file was created in context of T213726: Register Schema: namespace. I don't think it is needed anymore.
Nov 26 2019
Nov 21 2019
We discussed that the investigation (T237522) uncovered that we currently cannot get the intended blockee from the mediawiki API. We decided that for now, we drop that requirement, i.e. that bullet point in the error message, and create a ticket to follow up later. See T238828: Show intended blockee in blocked message in wikidata bridge
Nov 20 2019
Left todo: create the dashboards in grafana