Page MenuHomePhabricator

Michaelcochez (Michael Cochez)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 3 2021, 2:44 PM (74 w, 1 d)
Availability
Available
IRC Nick
michaelcochez
LDAP User
Michaelcochez
MediaWiki User
Michaelcochez [ Global Accounts ]

Recent Activity

May 27 2022

Michaelcochez added a comment to T301471: New Service Request SchemaTree.

Regarding the option of using a batch of queries to an external database; the issue is that what we are creating is a specialized index specifically for what we need. What we perform is a tree traversal were at each node a new decision is made. To do something like this with a database, one would have to fire a series of queries where each of the queries is dependent on all the results of the previous ones.

May 27 2022, 10:03 PM · User-ItamarWMDE, serviceops, wdwb-tech, Wikidata, MediaWiki-extensions-PropertySuggester, Service-deployment-requests, Services
Michaelcochez added a comment to T301471: New Service Request SchemaTree.

An update on the current status, mainly regarding the index file:

May 27 2022, 9:41 PM · User-ItamarWMDE, serviceops, wdwb-tech, Wikidata, MediaWiki-extensions-PropertySuggester, Service-deployment-requests, Services

Apr 8 2022

Michaelcochez added a comment to T301471: New Service Request SchemaTree.

I merged the pull request on github now.

Apr 8 2022, 9:47 AM · User-ItamarWMDE, serviceops, wdwb-tech, Wikidata, MediaWiki-extensions-PropertySuggester, Service-deployment-requests, Services

Mar 28 2022

Michaelcochez added a comment to T301471: New Service Request SchemaTree.

@Joe We now made the changes to use the bullseye distribution and the provided image with go installed See: https://github.com/martaannaj/RecommenderServer/pull/22/files
@QChris We just went ahead and added that file in our repository.

Mar 28 2022, 5:02 PM · User-ItamarWMDE, serviceops, wdwb-tech, Wikidata, MediaWiki-extensions-PropertySuggester, Service-deployment-requests, Services

Mar 23 2022

Michaelcochez added a comment to T301471: New Service Request SchemaTree.

@Joe : would it be fine if we include the index file into the image for the A/B testing phase? If that is successful, we can see whether it makes sense to move it to a different location.

Mar 23 2022, 4:30 PM · User-ItamarWMDE, serviceops, wdwb-tech, Wikidata, MediaWiki-extensions-PropertySuggester, Service-deployment-requests, Services
Michaelcochez updated subscribers of T301471: New Service Request SchemaTree.

@QChris I noticed the addition of the .gitreview file on gerrit. Is this file needed? If so, we would merge it into our github repository, so we can keep the active development there and synchronize with gerrit.

Mar 23 2022, 11:01 AM · User-ItamarWMDE, serviceops, wdwb-tech, Wikidata, MediaWiki-extensions-PropertySuggester, Service-deployment-requests, Services

Mar 2 2022

Michaelcochez committed rDPRS6a42ae38db4d: Fixed trivial issues raised by the linter. (authored by Michaelcochez).
Fixed trivial issues raised by the linter.
Mar 2 2022, 7:16 PM
Michaelcochez committed rDPRS9b89b86e9f35: Cleaning up paths of the tracing files and failing when closing fails (authored by Michaelcochez).
Cleaning up paths of the tracing files and failing when closing fails
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRS289cea534805: Making sure all files are closed when profiling (authored by Michaelcochez).
Making sure all files are closed when profiling
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRS6c3ab7b22bd2: Surpressing the warnign raised by semgrep, as suggested in the discussion on… (authored by Michaelcochez).
Surpressing the warnign raised by semgrep, as suggested in the discussion on…
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRSe4a934be78f1: moved from fmt to log, fixes #14 (authored by Michaelcochez).
moved from fmt to log, fixes #14
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRS24eda06830c7: Merge branch 'main' of github.com:martaannaj/RecommenderServer into main (authored by Michaelcochez).
Merge branch 'main' of github.com:martaannaj/RecommenderServer into main
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRSd0b0b9950f5c: Now making sure there are no new lines in the logged request (authored by Michaelcochez).
Now making sure there are no new lines in the logged request
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRS65799f993e35: Add TLS option (authored by Michaelcochez).
Add TLS option
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRS89c2b0c516d4: First attempt to add semgrep (authored by Michaelcochez).
First attempt to add semgrep
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRS4e3a06728aaa: Testing nancy (authored by Michaelcochez).
Testing nancy
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRS451343467e6a: Attempt to correct the location of the sarif file (authored by Michaelcochez).
Attempt to correct the location of the sarif file
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRS06d405bef898: Merge branch 'main' of github.com:martaannaj/RecommenderServer into main (authored by Michaelcochez).
Merge branch 'main' of github.com:martaannaj/RecommenderServer into main
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRS3d7964ee12ef: Trying gokart workflow (authored by Michaelcochez).
Trying gokart workflow
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRS51621fc04a3c: Moved the needed parts from assessment into the schematree (authored by Michaelcochez).
Moved the needed parts from assessment into the schematree
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRS432c7edcced6: Changed some details on the reporting of vulnerabilities. (authored by Michaelcochez).
Changed some details on the reporting of vulnerabilities.
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRS6edec52dd76d: Updated go.mod and go.sum to go 1.17 (authored by Michaelcochez).
Updated go.mod and go.sum to go 1.17
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRS6e29680a98b0: Adding test running to the CI (authored by Michaelcochez).
Adding test running to the CI
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRS58259beb8209: Added gosec as a task to the github workflow (authored by Michaelcochez).
Added gosec as a task to the github workflow
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRSa9ac5c7a906c: Added the linting and gosec as cron jobs, running once a week (authored by Michaelcochez).
Added the linting and gosec as cron jobs, running once a week
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRSf215d08ac0e0: Apparently, gosec did not notice that the variable got overwritten with a… (authored by Michaelcochez).
Apparently, gosec did not notice that the variable got overwritten with a…
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRSc064d90a7df4: Adressing a gosec issue. The filename is coming in as a command line argument. (authored by Michaelcochez).
Adressing a gosec issue. The filename is coming in as a command line argument.
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRSab9661b61ba2: Better choise of wording for code comment (authored by Michaelcochez).
Better choise of wording for code comment
Mar 2 2022, 7:11 PM
Michaelcochez committed rDPRS7b1005ae745a: Adding golang-lint to the workflow (authored by Michaelcochez).
Adding golang-lint to the workflow
Mar 2 2022, 7:11 PM

Mar 1 2022

Michaelcochez added a comment to T301471: New Service Request SchemaTree.

We'd be happy to receive a patch or pull request.

Mar 1 2022, 10:24 PM · User-ItamarWMDE, serviceops, wdwb-tech, Wikidata, MediaWiki-extensions-PropertySuggester, Service-deployment-requests, Services

Feb 21 2022

Michaelcochez added a comment to T301471: New Service Request SchemaTree.

@Joe for the base image, would you recommend our current approach of starting from an 'empty' image and downloading the latest go distribution ourselves, or should we take this one: https://docker-registry.wikimedia.org/golang1.17/tags/
I am not sure how stable these images are.

Feb 21 2022, 4:44 PM · User-ItamarWMDE, serviceops, wdwb-tech, Wikidata, MediaWiki-extensions-PropertySuggester, Service-deployment-requests, Services

Feb 16 2022

Michaelcochez added a comment to T301471: New Service Request SchemaTree.

@Joe we have created files for blubber before, I assume what is needed is very similar to that? I am not sure I know what the deployment-charts repository is . The code is under development on https://github.com/martaannaj/RecommenderServer/ also the blubber configuration files are there.

Feb 16 2022, 10:00 AM · User-ItamarWMDE, serviceops, wdwb-tech, Wikidata, MediaWiki-extensions-PropertySuggester, Service-deployment-requests, Services

Feb 10 2022

Michaelcochez created T301471: New Service Request SchemaTree.
Feb 10 2022, 2:23 PM · User-ItamarWMDE, serviceops, wdwb-tech, Wikidata, MediaWiki-extensions-PropertySuggester, Service-deployment-requests, Services

Jan 12 2022

Michaelcochez added a comment to T292110: Security Readiness Review For Improved Property Suggester/Recommender for Wikidata.

@sbassett @Reedy thank you very much for your effort!

Jan 12 2022, 12:19 AM · Wikidata, Security, Application Security Reviews, secscrum

Dec 16 2021

Michaelcochez closed T296599: Create project tag for Schematree_recommender as Declined.

Ok, I added myself and @Martaannaj to MediaWiki-extensions-PropertySuggester and change the status to declined (not sure that is the right status, should it be resolved?)

Dec 16 2021, 10:40 AM · Wikidata, Project-Admins
Michaelcochez added a member for MediaWiki-extensions-PropertySuggester: Martaannaj.
Dec 16 2021, 10:38 AM
Michaelcochez added a member for MediaWiki-extensions-PropertySuggester: Michaelcochez.
Dec 16 2021, 10:38 AM
Michaelcochez added a comment to T292110: Security Readiness Review For Improved Property Suggester/Recommender for Wikidata.

@sbassett Is that something which should be checked now, during the security readiness review, or only later upon deployment?

Dec 16 2021, 12:30 AM · Wikidata, Security, Application Security Reviews, secscrum

Dec 15 2021

Michaelcochez added a comment to T292110: Security Readiness Review For Improved Property Suggester/Recommender for Wikidata.

Thanks @sbassett . I didn't realize it was possible to run semgrep without posting the results to their service. They actually have a configuration available which can be used without that feature. I have now configured that.

Dec 15 2021, 9:47 PM · Wikidata, Security, Application Security Reviews, secscrum
Michaelcochez added a comment to T292110: Security Readiness Review For Improved Property Suggester/Recommender for Wikidata.

I have now added gokart. The github action was not working out of the box, because of some missing configuration parameters in the example. I opened a pull request for that.

Dec 15 2021, 12:41 AM · Wikidata, Security, Application Security Reviews, secscrum

Dec 1 2021

Michaelcochez added a comment to T296599: Create project tag for Schematree_recommender.
Dec 1 2021, 11:28 AM · Wikidata, Project-Admins

Nov 28 2021

Michaelcochez added a comment to T292110: Security Readiness Review For Improved Property Suggester/Recommender for Wikidata.

@Aklapper : thanks. Process initiated. https://phabricator.wikimedia.org/T296599

Nov 28 2021, 10:30 PM · Wikidata, Security, Application Security Reviews, secscrum
Michaelcochez updated the task description for T296599: Create project tag for Schematree_recommender.
Nov 28 2021, 10:28 PM · Wikidata, Project-Admins
Michaelcochez updated the task description for T296599: Create project tag for Schematree_recommender.
Nov 28 2021, 10:27 PM · Wikidata, Project-Admins
Michaelcochez created T296599: Create project tag for Schematree_recommender.
Nov 28 2021, 10:27 PM · Wikidata, Project-Admins

Nov 27 2021

Michaelcochez added a comment to T292110: Security Readiness Review For Improved Property Suggester/Recommender for Wikidata.

We went forward fixing multiple aspects:

Nov 27 2021, 12:51 AM · Wikidata, Security, Application Security Reviews, secscrum

Nov 10 2021

Michaelcochez added a comment to T292110: Security Readiness Review For Improved Property Suggester/Recommender for Wikidata.

For the security policy, I created a first draft. I would prefer to use phabricator for any security issues. Smaller issues can go as issues on github. https://github.com/martaannaj/RecommenderServer/blob/main/SECURITY.md

Nov 10 2021, 12:37 AM · Wikidata, Security, Application Security Reviews, secscrum

Aug 2 2021

Michaelcochez added a comment to T287760: stream-beta.wmflabs.org seems broken (can't see my mediawiki-create events) or anything else.

I can see the property suggester events.

Aug 2 2021, 1:35 PM · User-Addshore, Analytics-Kanban, Analytics, EventStreams

Aug 1 2021

Michaelcochez updated the task description for T285098: Production A/B test deployment - Improved Property Suggester/Recommender.
Aug 1 2021, 10:00 PM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, wdwb-tech

Jul 31 2021

Michaelcochez closed T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester as Resolved.

The example I was looking at fits the case you describe.

Jul 31 2021, 9:59 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Wikidata, MediaWiki-extensions-PropertySuggester
Michaelcochez closed T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester, a subtask of T285098: Production A/B test deployment - Improved Property Suggester/Recommender, as Resolved.
Jul 31 2021, 9:58 AM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, wdwb-tech

Jul 30 2021

Michaelcochez changed the subtype of T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester from "Task" to "Bug Report".
Jul 30 2021, 11:35 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Wikidata, MediaWiki-extensions-PropertySuggester
Michaelcochez added a subtask for T285098: Production A/B test deployment - Improved Property Suggester/Recommender: T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester.
Jul 30 2021, 11:34 PM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, wdwb-tech
Michaelcochez added a parent task for T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester: T285098: Production A/B test deployment - Improved Property Suggester/Recommender.
Jul 30 2021, 11:34 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Wikidata, MediaWiki-extensions-PropertySuggester
Michaelcochez created T287797: request_duration_ms is -1 in A/B testing when the request goes to the PropertySuggester.
Jul 30 2021, 11:34 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Wikidata, MediaWiki-extensions-PropertySuggester
Michaelcochez added a comment to T285098: Production A/B test deployment - Improved Property Suggester/Recommender.

With much appreciated help from @Ottomata , we got to see some events using kafkacat on deployment-kafka-jumbo-2 now. To check whether the events are correctly generated, this seems sufficient.
One thing which got done on the way is including the config of these streams from this patch https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/708592 into the main config.

Jul 30 2021, 9:06 PM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, wdwb-tech
Michaelcochez set IRC Nick to michaelcochez on Michaelcochez.
Jul 30 2021, 4:19 PM
Michaelcochez updated the task description for T287760: stream-beta.wmflabs.org seems broken (can't see my mediawiki-create events) or anything else.
Jul 30 2021, 4:14 PM · User-Addshore, Analytics-Kanban, Analytics, EventStreams

Jul 29 2021

Michaelcochez added a comment to T287641: Review wd_propertysuggester event logging stream config.

Updated a patch to resolve the issues.

Jul 29 2021, 8:12 AM · Wikidata, MediaWiki-extensions-PropertySuggester

Jul 28 2021

Michaelcochez updated subscribers of T287641: Review wd_propertysuggester event logging stream config.

@Ottomata Is this a patch you can review?

Jul 28 2021, 9:46 PM · Wikidata, MediaWiki-extensions-PropertySuggester
Michaelcochez added a subtask for T285098: Production A/B test deployment - Improved Property Suggester/Recommender: T287641: Review wd_propertysuggester event logging stream config.
Jul 28 2021, 9:44 PM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, wdwb-tech
Michaelcochez added a parent task for T287641: Review wd_propertysuggester event logging stream config: T285098: Production A/B test deployment - Improved Property Suggester/Recommender.
Jul 28 2021, 9:44 PM · Wikidata, MediaWiki-extensions-PropertySuggester
Michaelcochez created T287641: Review wd_propertysuggester event logging stream config.
Jul 28 2021, 9:43 PM · Wikidata, MediaWiki-extensions-PropertySuggester
Michaelcochez added a comment to T285098: Production A/B test deployment - Improved Property Suggester/Recommender.

Turned out the instructions which we had found before are outdated (now marked as deprecated). New ones are here: https://wikitech.wikimedia.org/wiki/Event_Platform/Instrumentation_How_To#Deployment
Accordingly, I created a patch to get our streams activated. https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/708592
At the moment, they are only in the -labs configuration. After making sure that works, we can move the configuration to main config and get it merged during a backport window.

Jul 28 2021, 9:17 PM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, wdwb-tech
Michaelcochez added a comment to T285098: Production A/B test deployment - Improved Property Suggester/Recommender.

We (@Michaelcochez and @Martaannaj ) should have access now. We still have to figure out where the events are logged. The /srv/log/eventlogging directory were logging should happen according to TestingOnBetaCluster seems empty.

Jul 28 2021, 7:53 PM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, wdwb-tech

Jul 20 2021

Michaelcochez added a parent task for T286655: Review wd_propertysuggester A/B testing schema: T285098: Production A/B test deployment - Improved Property Suggester/Recommender.
Jul 20 2021, 10:50 AM · Wikidata, User-Addshore, Metrics-Platform-Planning
Michaelcochez added a subtask for T285098: Production A/B test deployment - Improved Property Suggester/Recommender: T286655: Review wd_propertysuggester A/B testing schema.
Jul 20 2021, 10:50 AM · Wikidata Dev Team, Foundational Technology Requests, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Patch-For-Review, Wikidata, MediaWiki-extensions-PropertySuggester, wdwb-tech