Also, re #3, in some of the mockups they're on the left, and some on the right -- since we have more UI elements to include (pagination, on the right side for example) so I am actually not 100% sure where they should go right now. We could add them to the right side for the moment, but when we add pagination they will likely have to move - either to the left of the pagination controls (but still relatively to the right) or at the left of the interface.
We can get them to auto-close, but according to the design, both popups have more options in them (see T168513: Enable 'Group results by page' preference on the RC page itself) so they can't really be drop-down widgets when those are implemented (which is very soon).
Fri, Jul 21
The state is either on or off; if we only display it as "on" when something is selected, then a user will press that button over and over again with no result (the button will remain non-active because nothing is selected) until the user selects something, in which case the button will finally respond.
Thu, Jul 20
The filters are only excluded when they're selected, according to spec. We don't highlight excluded namespaces, because they're not there, so if the filter isn't selected and is just highlighted, it won't show the "not" message because it's highlighting the namespace itself. I wouldn't touch the active state of the button itself because that lets users choose the excluding namespaces even if none is YET selected.
I'll take a shower look at the rest of the questions, but regarding the free form input, if anyone fills in the URL (and when I implement listening to the preference of all act the same) with some number, that number is inserted in order to the most of current options. You can try that by changing days= parameter in the URL to slang custom. If you use fractions, like days=0.01 it will translate to hours and place them in order.
Wed, Jul 19
Tue, Jul 18
Mon, Jul 17
Fri, Jul 14
I assigned it tor @Catrope because he implemented most of the fixes that were needed; it came back due to the spacing of the items, which is actually a slight annoyance (because of the padding/margins and icon in there)
Wed, Jul 12
This is a bit of a radical suggestion, but we could try to do this part in the front end, and depend on sending the data on closing the menu.
Tue, Jul 11
Abandoned the RCFilter-specific fix since this got into the OOUI release today. Should be available on Beta later today.
Mon, Jul 10
I don't see this in Chrome or Firefox on ubuntu. What browser did you see this in?
The above fix is for the message. I'm still trying to verify where to set up the new default for expansion, that fix will come soon.
Fri, Jul 7
As @matmarex points out, there already is a ticket to split out legacy modules to non-legacy ones. It seems to not be high priority, but this behavior in RTL/LTR mixes in mobile makes at least that part a priority itself. see T89981: Split the mediawiki.legacy.shared module into non-legacy manageable parts for context.
@Volker_E I have added a proposal patch for this, making language a new module and setting it as a dependency of mediawiki.skinning.content.
Thu, Jul 6
@Catrope and I checked into this, and the definition is in the mediawiki.legacy.shared module. Two conclusions strike me as action items:
Tue, Jul 4
Fixing the icon size will be a bit of an issue, since that's the icon that is in OOUI, but I'll give it a try. The padding is also consistent through ooui menus, but we have a lot more leeway with it, providing the icons are not blocking a portion of it (ooui icons have whitespace around them, it's a known issue, but one that prevents us from using exact size measurements of the actual icon rather than the whole whitespace-plus-icon box, which is what the svg itself is using.
Fri, Jun 30
Oy, sorry, when we changed the way validation works, I removed the condition to treat spaces as empty.
Fixed in the commit above.
This shouldn't happen anymore, can you re-check? The "Apply" button should be disabled when the text is empty, and the saved query shouldn't be saved at all if there's nothing in the input, including when you press enter.
Thu, Jun 29
Fixed the tooltips.
Wed, Jun 28
Whoops. Sorry about that.
Tue, Jun 27
@Pginer-WMF question that will affect implementation: What happens if there are no results? Can we not show the legend in such a case.
Just to verify something -- those two lines may actually have something left in there from external extensions. For example, I'm a bit confused about where "Translations" went in your second set of screenshots... it should still remain, since we did not yet implement it in RCFilters.
Jun 23 2017
Jun 22 2017
Gadget is officially available on mw.org: https://www.mediawiki.org/wiki/MediaWiki:Gadget-NotifCountTitle.js
Jun 21 2017
@Nirmos I am not 100% sure where you're going with this, but in an effort to help, I created a quick and dirty gadget for you to use as a basis for whatever you need. I did end up loading mw.echo.api module, for convenience, and the required i18n message.
Opening them updates them already, so I assume you mean you want to update their counters?
What use case are you thinking about? The Special:Notifications page? The badges? They already both have a way of updating themselves, why would you need a function? Is there a specific gadget you're thinking about that needs to use it specifically?
Jun 20 2017
A couple of questions we should ask to prepare for this:
Jun 16 2017
The new size is only implemented on the RCFilters section, and not the results list. The results list will continue to have the same size as the nojs version (font size of the content container)
Implemented everything except for the message footer for namespaces and tagged edits -- after a chat with @jmatazzoni, my understanding that the extra explanation in the footer in the example above is only relevant to "Users" and "Categories" which are lookup elements, and not to Namespaces and Tagged Edits.
Jun 15 2017
Didn't implement the (?) button yet because I don't have a link to go to -- we can add that later.
Other than that, all functionality should be there.
Jun 14 2017
@Pginer-WMF quick question -- we already have a footer in the menu right now for sending feedback about the RCFilters beta. Where do I put this footer now? Under the footers above (the text one for the tag/namespace and the button selection one for the default view) ?
Jun 13 2017
Jun 12 2017
This was an issue with all options that are "outside" the RCFilters dropdown. Fixed in the commit above, and will be thoroughly fixed in an upcoming commit to rewrite (and unit test!) the way we do and compare URLs.