Page MenuHomePhabricator

Mooeypoo (Moriel Schottlender)
Tech Lead, CommTech and Anti Harassment Team

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 18 2014, 11:57 PM (263 w, 4 d)
Availability
Available
IRC Nick
mooeypoo
LDAP User
Mooeypoo
MediaWiki User
Mooeypoo [ Global Accounts ]

Recent Activity

Fri, Dec 6

Mooeypoo added a comment to T239680: CU 2.0: Persist the form state.

My concern is whether one check (pressing the "Submit" button, switching to "Compare" tab) for multiple users should create one or multiple cu_log entries.

Fri, Dec 6, 7:21 AM · Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)
Mooeypoo added a comment to T239680: CU 2.0: Persist the form state.

CU log entries and CU investigations have a 1-1 relation. Calling it a "log" is arbitrary, reflecting the original use-case. Maybe calling it "CU investigations" in the DB would be more appropriate while calling it "CU log" on the UI.
I see only one limiting factor with the current cu_log table: cul_user is an N-1 relation, that cannot accommodate for multiple users checked in one investigation. That will require a new table (schema change).

Fri, Dec 6, 4:47 AM · Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)

Thu, Dec 5

Mooeypoo updated subscribers of T235005: Spike #2: Watchlist Expiry [12 hours].

During TechConf, I've discussed the implication of a periodic purge of the Watchlist table with several people, and there seems to be consensus that the general approach is sound with regards to the new table and the periodic purge of the Watchlist based on indexed timestamps of the watchlist_expiry table (ticket upcoming for the creation of that table+consultation with DBAs)

Thu, Dec 5, 1:07 AM · Expiring-Watchlist-Items, TCB-Team, Community-Tech (Kanban-Q2-2019-20)

Wed, Dec 4

Mooeypoo moved T235130: WWT: Implement Opacity for Templates [medium] from Needs Review/Feedback to QA on the Community-Tech (Kanban-Q2-2019-20) board.
Wed, Dec 4, 8:36 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo added a comment to T239680: CU 2.0: Persist the form state.

Repeating what we discussed (briefly) in an RL meeting -- We need to come up with a way to make sure the pagination works with the same state, but I am not convinced that sessions are the best way to go.

Wed, Dec 4, 7:16 PM · Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)
Mooeypoo added a comment to T237593: [Epic] CheckUser 2.0: Compare.

@Rxy The AHT team has taken on rewriting and redesigning CheckUser as part of the general strategy around this area. This means that we are *heavily* editing the code, and the plan is to replace the current CheckUser special page with the new one that we're building.

Wed, Dec 4, 5:06 PM · Epic, Anti-Harassment, CheckUser

Tue, Dec 3

Mooeypoo added a comment to T238961: PRU: Improve Security & Standardize Experience for Password Reset [medium].

Note: We might already have a message about invalid characters in Usernames within the registration page? Worth checking if it's valid to reuse here.

Tue, Dec 3, 10:18 PM · Community-Tech (Kanban-Q2-2019-20), Password-Reset-Update

Mon, Dec 2

Mooeypoo claimed T235015: WWT: Support for Latest Version of a Page after VE Edits.

Ahha! I think there might be an issue of re-processing the contents if it's re-requested.

Mon, Dec 2, 6:28 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo added a comment to T235005: Spike #2: Watchlist Expiry [12 hours].

Basic Functionality: Investigate how users can watch a page temporarily (highest priority)

  • Via the "watch" star: Can we add a drop-down menu (when user clicks the "watch" star) that enables them to select a timerange (for example, one day, one month, three months, six months, or permanently)? See the mockup link for examples.
    • What are the possible risks or issues associated with implementing this?
Mon, Dec 2, 6:24 PM · Expiring-Watchlist-Items, TCB-Team, Community-Tech (Kanban-Q2-2019-20)
Mooeypoo moved T239369: Create a changelog for WWT releases [small] from Needs Review/Feedback to QA on the Community-Tech (Kanban-Q2-2019-20) board.
Mon, Dec 2, 6:14 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Sun, Dec 1

Mooeypoo claimed T239369: Create a changelog for WWT releases [small].

Pull request ready for review: https://github.com/wikimedia/WhoWroteThat/pull/102

Sun, Dec 1, 9:06 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Thu, Nov 28

Mooeypoo added a comment to T235015: WWT: Support for Latest Version of a Page after VE Edits.

Should have been fixed by https://github.com/wikimedia/WhoWroteThat/commit/0e9e72022751c7f9d003d3a672ed6ab1eeb5768e

Thu, Nov 28, 12:55 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo moved T239369: Create a changelog for WWT releases [small] from Untriaged to To be estimated/discussed on the Community-Tech board.
Thu, Nov 28, 12:01 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo created T239369: Create a changelog for WWT releases [small].
Thu, Nov 28, 12:00 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Wed, Nov 27

Mooeypoo updated subscribers of T239354: ORES SqlScoreStorageTest failing on Jenkins.

@Halfak Do you know who can fix this test? This is blocking two patches that we need to merge to PageTriage; it comes up as an unrelated test failure, and we can't figure out why or what to do about it.

Wed, Nov 27, 11:11 PM · ci-test-error, ORES, Scoring-platform-team
Mooeypoo added a comment to T238385: Links in table of contents don't work for certain characters.

@Jdlrobson hm, this seems to have been worked on in the 2016 wishlist and seemed to have worked since; is this a new / recent failure? I remember there was conversation about problems with UTF characters when we migrated to PHP7.2, could that be the problem as well?

Wed, Nov 27, 8:06 PM · TechCom, Readers-Web-Backlog (Tracking), MediaWiki-Parser, Parsoid, Parsing-Team

Mon, Nov 18

abi_ awarded T234649: Wikimedia Technical Conference 2019 Session: Front-end modernization and standardization a Like token.
Mon, Nov 18, 11:29 AM · International-Developer-Events, Wikimedia-Technical-Conference-2019

Thu, Nov 14

Mooeypoo added a comment to T234463: WWT: Only Show Loading Animation in Revision Details Pop-up If Data Not Yet Loaded.

Pull request awaiting review: https://github.com/wikimedia/WhoWroteThat/pull/92

Thu, Nov 14, 10:31 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo moved T234463: WWT: Only Show Loading Animation in Revision Details Pop-up If Data Not Yet Loaded from Ready to Needs Review/Feedback on the Community-Tech (Kanban-Q2-2019-20) board.
Thu, Nov 14, 10:30 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo claimed T234463: WWT: Only Show Loading Animation in Revision Details Pop-up If Data Not Yet Loaded.
Thu, Nov 14, 10:30 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo added a comment to T231508: WWT: Handle behavior with VisualEditor.

Should be fixed with https://github.com/wikimedia/WhoWroteThat/pull/91

Thu, Nov 14, 9:48 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Wed, Nov 13

Mooeypoo added a comment to T231508: WWT: Handle behavior with VisualEditor.

Oops, the link should be hidden when the system is disabled. I think it's a problem of how I instantiate the system with the wrong starting value.

Wed, Nov 13, 4:32 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Pablo-WMDE awarded T234649: Wikimedia Technical Conference 2019 Session: Front-end modernization and standardization a Like token.
Wed, Nov 13, 4:24 AM · International-Developer-Events, Wikimedia-Technical-Conference-2019

Nov 6 2019

Mooeypoo added a comment to T231508: WWT: Handle behavior with VisualEditor.

The second behavior should be fixed when https://github.com/wikimedia/WhoWroteThat/pull/80 is merged

Nov 6 2019, 11:54 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Nov 2 2019

Mooeypoo added a comment to T234483: WWT: Closing the information bar while it's pending results in a crash.

@Mooeypoo After this change (which I think is this) the revision summary animation does not appear for tokens you have already clicked. Instead, you see the revision summary blinking in and out.
I also feel like, even for tokens I am clicking the first time, the animation does not always appear (or not for long enough to notice). Although I appreciate that is a bit subjective.

Nov 2 2019, 12:09 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Oct 31 2019

Mooeypoo updated the task description for T234649: Wikimedia Technical Conference 2019 Session: Front-end modernization and standardization.
Oct 31 2019, 5:29 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019

Oct 28 2019

Mooeypoo moved T234483: WWT: Closing the information bar while it's pending results in a crash from In Development to QA on the Community-Tech (Kanban-Q2-2019-20) board.
Oct 28 2019, 5:10 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo added a comment to T231508: WWT: Handle behavior with VisualEditor.

@MusikAnimal If you go directly to the VisualEditor (e.g. https://tr.wikipedia.org/w/index.php?title=%C4%B0Pad_Mini_4&veaction=edit), the "Who Wrote That?" link appears briefly and the guided tour popup appears and remains (unless you have previously dismissed it).
In the brief period in which the "Who Wrote That?" link appears, if you are quick enough you can click it and have the infobar appear. Leaves it in a weird state where model.enabled == false but model.active == true. This does not appear to interfere with VisualEditor.
I don't see these problems when I go first to the article and then click "Edit".

Oct 28 2019, 5:08 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Oct 21 2019

Mooeypoo edited projects for T234483: WWT: Closing the information bar while it's pending results in a crash, added: Community-Tech (Kanban-Q2-2019-20); removed Community-Tech.
Oct 21 2019, 5:07 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo moved T234483: WWT: Closing the information bar while it's pending results in a crash from Needs Review/Feedback to In Development on the Community-Tech (Kanban-Q2-2019-20) board.
Oct 21 2019, 5:06 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Oct 16 2019

Mooeypoo moved T234483: WWT: Closing the information bar while it's pending results in a crash from In Development to Needs Review/Feedback on the Community-Tech (Kanban-Q2-2019-20) board.
Oct 16 2019, 4:44 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Oct 14 2019

Mooeypoo added a comment to T232802: Release beta extension on Firefox Add-ons.

We should still fix the security issues, (perceived or real, regardless)

Oct 14 2019, 4:41 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Oct 12 2019

Mooeypoo moved T234483: WWT: Closing the information bar while it's pending results in a crash from Needs Review/Feedback to In Development on the Community-Tech (Kanban-Q2-2019-20) board.
Oct 12 2019, 5:06 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo moved T234483: WWT: Closing the information bar while it's pending results in a crash from QA to Needs Review/Feedback on the Community-Tech (Kanban-Q2-2019-20) board.
Oct 12 2019, 2:47 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Oct 10 2019

Mooeypoo added a comment to T234649: Wikimedia Technical Conference 2019 Session: Front-end modernization and standardization.

I'll facilitate this. I'll talk to the group about whether there are specifics we want to make sure are delivered within the given topic.

Oct 10 2019, 10:55 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019
Mooeypoo updated the task description for T235015: WWT: Support for Latest Version of a Page after VE Edits.
Oct 10 2019, 10:28 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo moved T231508: WWT: Handle behavior with VisualEditor from Needs Review/Feedback to QA on the Community-Tech (Kanban-Q2-2019-20) board.
Oct 10 2019, 10:16 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo added a comment to T235196: WWT: Investigate/Fix "Less than 1% of Page" Confusion.

We've discussed offline but just for posterity here -- the biggest issue we have is that these percentages are calculated based on tokens and on wikitext. Essentially, the second author may have edited things like citations and thumbnails and templates that we do not "see" visually in the visual WWT tool, but make his edits correctly account for 2.1% of the page.

Oct 10 2019, 7:23 PM · Who-Wrote-That, Community-Tech
Mooeypoo moved T232059: WWT: Enable WWT for Older Versions of Page [medium] from Needs Review/Feedback to QA on the Community-Tech (Kanban-Q2-2019-20) board.
Oct 10 2019, 2:22 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo claimed T234483: WWT: Closing the information bar while it's pending results in a crash.

This was fixed (incidentally!) as part of the MVC refactor.

Oct 10 2019, 1:19 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Oct 9 2019

Mooeypoo moved T231508: WWT: Handle behavior with VisualEditor from In Development to Needs Review/Feedback on the Community-Tech (Kanban-Q2-2019-20) board.

Submitted a PR to handle load/unload of VisualEditor: https://github.com/wikimedia/WhoWroteThat/pull/64

Oct 9 2019, 6:11 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo created T235015: WWT: Support for Latest Version of a Page after VE Edits.
Oct 9 2019, 6:08 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo moved T234874: Enable WWT to be turned on and off remotely from Needs Review/Feedback to QA on the Community-Tech (Kanban-Q2-2019-20) board.
Oct 9 2019, 5:55 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo added a comment to T232802: Release beta extension on Firefox Add-ons.

This is more about good practice rather than strictly security.

Oct 9 2019, 5:16 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Oct 8 2019

Mooeypoo added a comment to T231508: WWT: Handle behavior with VisualEditor.

A pre-requisite is to be able to shut off the system (and disable it) from an event handler. Created T234874: Enable WWT to be turned on and off remotely for that task (PR attached) and will follow up with a VE-specific event handler after that one's merged.

Oct 8 2019, 1:22 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo moved T234874: Enable WWT to be turned on and off remotely from Ready to Needs Review/Feedback on the Community-Tech (Kanban-Q2-2019-20) board.

PR available: https://github.com/wikimedia/WhoWroteThat/pull/63

Oct 8 2019, 1:21 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo created T234874: Enable WWT to be turned on and off remotely.
Oct 8 2019, 1:20 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Oct 3 2019

Mooeypoo added a comment to T231508: WWT: Handle behavior with VisualEditor.

[edit] There's also mw.hook( 've.deactivationComplete' ) for deactivation of VE (thanks @Esanders ) that can be used to reactivate the activation link.

If we re-add the WWT link after someone has made changes using VE, will WWT be able to show the newly added content? Or would that require a refresh of some sort?

Oct 3 2019, 4:03 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo claimed T231508: WWT: Handle behavior with VisualEditor.
Oct 3 2019, 5:55 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo updated subscribers of T231508: WWT: Handle behavior with VisualEditor.
Oct 3 2019, 1:17 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Oct 2 2019

Mooeypoo moved T234483: WWT: Closing the information bar while it's pending results in a crash from Untriaged to To be estimated/discussed on the Community-Tech board.
Oct 2 2019, 11:13 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo added projects to T234483: WWT: Closing the information bar while it's pending results in a crash: Community-Tech, Who-Wrote-That.
Oct 2 2019, 10:51 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo created T234483: WWT: Closing the information bar while it's pending results in a crash.
Oct 2 2019, 9:38 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo added a comment to T231508: WWT: Handle behavior with VisualEditor.

So after an investigation, here are findings on how we can potentially do this.

Oct 2 2019, 9:32 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo renamed T233164: Correct the display of user attribution percentages in the popup from Correct display of popup user attribution percentage message to Correct the display of user attribution percentages in the popup.
Oct 2 2019, 8:26 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo moved T233164: Correct the display of user attribution percentages in the popup from In Development to Needs Review/Feedback on the Community-Tech (Kanban (Q1 2019-20)) board.
Oct 2 2019, 8:18 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo renamed T233164: Correct the display of user attribution percentages in the popup from Popup is missing a percentage value in WhoWroteThat to Correct display of popup user attribution percentage message.
Oct 2 2019, 8:13 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo claimed T233164: Correct the display of user attribution percentages in the popup.

You're right, we missed that part when discussing the ticket; it was fixing a code review comment by adding extra functionality.

Oct 2 2019, 8:12 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo updated the task description for T234463: WWT: Only Show Loading Animation in Revision Details Pop-up If Data Not Yet Loaded.
Oct 2 2019, 6:18 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo moved T231115: Implement Loading State Support for Revision Details Pop-up in WWT [small] from Needs Review/Feedback to QA on the Community-Tech (Kanban (Q1 2019-20)) board.
Oct 2 2019, 5:12 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo moved T232215: WWT: Support Hidden Contributor Names from Needs Review/Feedback to QA on the Community-Tech (Kanban (Q1 2019-20)) board.

This is merged to master. I will update the self-hosted gadget in the next few days before it moves to product (if all is well :) .

Oct 2 2019, 2:54 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Oct 1 2019

Mooeypoo updated the task description for T234401: Password Reset: Update Preference to Require both username & email address [medium].
Oct 1 2019, 11:42 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Community-Tech (Kanban-Q2-2019-20), Password-Reset-Update

Sep 24 2019

Mooeypoo moved T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets [high priority] from Needs Review/Feedback to QA on the Community-Tech (Kanban (Q1 2019-20)) board.

This was merged, and will be available on beta in a few minutes.

Sep 24 2019, 1:12 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Community-Tech (Kanban-Q2-2019-20), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Growth-Team, PageCuration

Sep 23 2019

Mooeypoo moved T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets [high priority] from QA to Needs Review/Feedback on the Community-Tech (Kanban (Q1 2019-20)) board.

Bringing back to review for this patch.

Sep 23 2019, 11:56 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Community-Tech (Kanban-Q2-2019-20), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Growth-Team, PageCuration
Mooeypoo updated subscribers of T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets [high priority].

Thanks to the amazing debug (and git blame) skills of @Catrope we found the problem.

Sep 23 2019, 11:08 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Community-Tech (Kanban-Q2-2019-20), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Growth-Team, PageCuration
Mooeypoo added a comment to T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets [high priority].

@MusikAnimal @Mooeypoo There is an odd behaviour I cannot understand. After opening the "Page info" flyout the articleinfo hook fires, which is fine. But afterwards, each time I mark the page reviewed/unreviewed (without refreshing), the articleinfo hook also fires. First time once, second time twice, third time 4 times, then 8, etc.

Sep 23 2019, 5:09 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Community-Tech (Kanban-Q2-2019-20), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Growth-Team, PageCuration

Sep 20 2019

Mooeypoo added a comment to T232460: [BUG] Unresponsive script when loading articles in non-default language [8 hours].

@dom_walden I just re-tested this in an effort to figure out what's going on, and I can no longer reproduce it...

Sep 20 2019, 7:33 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo added a comment to T232460: [BUG] Unresponsive script when loading articles in non-default language [8 hours].

@dom_walden Ah, thanks for the clarification!
@Mooeypoo This bug may only be reproducible with the extension rather than the gadget. Do you know why that may be?

Sep 20 2019, 1:30 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo added a comment to T231943: Uncheck "Automatically block the last IP address" by default on Special:Block on officewiki.

@Tchanders you're making a good point about this; however, this will only fix the underlying ask tangentially. It would mean that the checkbox being selected won't matter, but it won't actually unselect that checkbox.

Just to help us understand this correctly - are there cases where a logged-in user on office wiki should be blocked if the IP they are editing from is blocked? If not, then we could use the 'ipblock-exempt' option.

Sep 20 2019, 1:12 AM · Anti-Harassment, Patch-For-Review, User-DannyS712, MediaWiki-User-management, MediaWiki-Special-pages, Wikimedia-Site-requests, Office-IT

Sep 19 2019

Mooeypoo added a comment to T231943: Uncheck "Automatically block the last IP address" by default on Special:Block on officewiki.

Forms that pre-populate fields by default will just get it wrong in some cases... Could we get round the problem another way, as suggested above? E.g. setting $wgAutoblockExpiry to 0 or granting the permission 'ipblock-exempt' to all users?

Sep 19 2019, 10:48 PM · Anti-Harassment, Patch-For-Review, User-DannyS712, MediaWiki-User-management, MediaWiki-Special-pages, Wikimedia-Site-requests, Office-IT
Mooeypoo added a comment to T231943: Uncheck "Automatically block the last IP address" by default on Special:Block on officewiki.

I agree that it feels a bit problematic to make assumptions about autoblocks based on the $wgBlockDisablesLogin config. I'm not sure I agree the checking of $wgBlockDisablesLogin and isEveryoneAllowed('read') is much better - it's less impactful, but the principle is the same. (If a wiki with these settings wanted the checkbox checked by default, what would we do?)
Forms that pre-populate fields by default will just get it wrong in some cases... Could we get round the problem another way, as suggested above? E.g. setting $wgAutoblockExpiry to 0 or granting the permission 'ipblock-exempt' to all users?

Sep 19 2019, 5:54 PM · Anti-Harassment, Patch-For-Review, User-DannyS712, MediaWiki-User-management, MediaWiki-Special-pages, Wikimedia-Site-requests, Office-IT
Mooeypoo added a comment to T231943: Uncheck "Automatically block the last IP address" by default on Special:Block on officewiki.

This is why, originally, I had introduced a separate config variable to control this. However, @Krinkle objected on the patch (https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/534936/) to the addition of a new global setting, instead suggesting that $wgBlockDisablesLogin be used. I have no strong preference either way, but given that just checking BlockDisablesLogin wouldn't be enough, I again suggest that a new config value be added.

Sep 19 2019, 3:11 AM · Anti-Harassment, Patch-For-Review, User-DannyS712, MediaWiki-User-management, MediaWiki-Special-pages, Wikimedia-Site-requests, Office-IT
Mooeypoo added a comment to T231943: Uncheck "Automatically block the last IP address" by default on Special:Block on officewiki.

First off, thank you @DannyS712 for picking this up :)

Sep 19 2019, 1:45 AM · Anti-Harassment, Patch-For-Review, User-DannyS712, MediaWiki-User-management, MediaWiki-Special-pages, Wikimedia-Site-requests, Office-IT

Sep 18 2019

Mooeypoo updated subscribers of T233182: Upgrade OOUI to 0.34.1.

Hm I wonder if this has anything to do with the upgrade to jQuery 3.4.1, and that ULS perhaps needs to be adjusted for it.

Sep 18 2019, 4:14 AM · Community-Tech, SVG Translate Tool
Mooeypoo added a comment to T233115: Add 'Username in title' tag and filter for Page Curation [medium].

It would help if we had any kind of data about the number of triggers this would pull. Would it be comparable to the edit filters?

Sep 18 2019, 2:46 AM · PageCuration, Community-Tech

Sep 17 2019

Mooeypoo created T233164: Correct the display of user attribution percentages in the popup.
Sep 17 2019, 9:35 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Sep 8 2019

Mooeypoo added a comment to T232168: TemplateData.

I'm sorry to hear that. If you ever change your mind, we'll be happy to try and help guide you through the process.
In any case, this page might be able to help as well, if you need it: https://www.mediawiki.org/wiki/Help:TemplateData

Sep 8 2019, 7:53 AM · MediaWiki-extensions-TemplateWizard, Community-Tech, VisualEditor, TemplateData
Mooeypoo claimed T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets [high priority].
Sep 8 2019, 7:26 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Community-Tech (Kanban-Q2-2019-20), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Growth-Team, PageCuration

Sep 7 2019

Mooeypoo added a comment to T232168: TemplateData.

@Mooeypoo thanks. the manage template button is already active. Is there anyway to have it working as described in the TemplateWizard instructions?

Sep 7 2019, 11:47 PM · MediaWiki-extensions-TemplateWizard, Community-Tech, VisualEditor, TemplateData
Mooeypoo added a comment to T232168: TemplateData.

TemplateWizard allows you to insert templates into a page if they have TemplateData definition.
TemplateData extension can help you set definitions in your templates.

Sep 7 2019, 11:46 PM · MediaWiki-extensions-TemplateWizard, Community-Tech, VisualEditor, TemplateData
Mooeypoo added a comment to T232168: TemplateData.

If you have TemplateData installed, you can add $wgTemplateDataUseGUI = true; to your LocalSettings.php and you'll see a "Manage TemplateData" button when you edit a template.

Sep 7 2019, 9:02 PM · MediaWiki-extensions-TemplateWizard, Community-Tech, VisualEditor, TemplateData
Mooeypoo added a comment to T232168: TemplateData.

@AlgorithmGG TemplateWizard requires having TemplateData definition in each template.

Sep 7 2019, 6:54 PM · MediaWiki-extensions-TemplateWizard, Community-Tech, VisualEditor, TemplateData

Sep 6 2019

Mooeypoo added a member for MediaWiki-extensions-WebToolsManager: Mooeypoo.
Sep 6 2019, 5:42 AM
Mooeypoo committed rEWTMe8980ebc9e76: Initial commit, set up the repo (authored by Mooeypoo).
Initial commit, set up the repo
Sep 6 2019, 5:15 AM

Sep 4 2019

Mooeypoo moved T226772: Add "Guided Tour" Pop-Up (first time users) for Who Wrote That from Needs Review/Feedback to QA on the Community-Tech (Kanban (Q1 2019-20)) board.
Sep 4 2019, 5:18 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets [high priority].

One of the biggest issues here is that we call the hook just before we refresh the page, and that the use cases that this hook is for are working asynchronously, which means refreshing immediately after call is not going to help anything

Sep 4 2019, 5:25 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Community-Tech (Kanban-Q2-2019-20), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Growth-Team, PageCuration

Sep 3 2019

Mooeypoo updated the task description for T231508: WWT: Handle behavior with VisualEditor.
Sep 3 2019, 9:42 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo added a comment to T229041: Add WikiLookUp plugin to Wordpress.

Sweet! I'm so glad that this is working properly and thank you for the feedback.

Sep 3 2019, 10:15 AM · Space

Aug 30 2019

Mooeypoo added a comment to T231608: Security access for Tchanders.

Fair enough.

Aug 30 2019, 9:35 PM · Security-Team
Mooeypoo added a comment to T231608: Security access for Tchanders.

I will remind everyone that we're talking about a WMF employee here.

Aug 30 2019, 9:14 PM · Security-Team
Mooeypoo added a comment to T231608: Security access for Tchanders.

@sbassett in that case, I just want to make sure we add to the list the fact that Anti Harassment's Tool team's work touches on blocking tools, which inherently tend to be Security tickets if any bug happens there.
Our upcoming work will involve CheckUser, which, again, almost exclusively has bugs in the security realm. For us, this is not just a matter of this being useful, but a pretty crucial part of the work, in case bugs happen in the part of the code we actively work on.

Aug 30 2019, 8:51 PM · Security-Team

Aug 29 2019

Mooeypoo created T231508: WWT: Handle behavior with VisualEditor.
Aug 29 2019, 12:33 AM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Aug 28 2019

Mooeypoo moved T231492: Add a tool to proxy API requests to WhoColor API from Untriaged to To be estimated/discussed on the Community-Tech board.
Aug 28 2019, 8:11 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That
Mooeypoo created T231492: Add a tool to proxy API requests to WhoColor API.
Aug 28 2019, 8:11 PM · Community-Tech (Kanban-Q2-2019-20), Who-Wrote-That

Aug 27 2019

Mooeypoo moved T226772: Add "Guided Tour" Pop-Up (first time users) for Who Wrote That from In Development to Needs Review/Feedback on the Community-Tech (Kanban (Q1 2019-20)) board.
Aug 27 2019, 11:17 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Aug 23 2019

Mooeypoo moved T226760: Support Loading State & Error Behavior for Who Wrote That from Needs Review/Feedback to QA on the Community-Tech (Kanban (Q1 2019-20)) board.
Aug 23 2019, 11:42 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Aug 22 2019

Mooeypoo added a comment to T189144: RTL support for Interaction Timeline.

CSSJanus Webpack plugin: https://github.com/mooeypoo/cssjanus-webpack

Aug 22 2019, 6:42 PM · InteractionTimeline

Aug 17 2019

Mooeypoo claimed T226772: Add "Guided Tour" Pop-Up (first time users) for Who Wrote That.

While doing some experimentation, I unfortunately discovered it's not as easy to get GuidedTour to activate from the injected script; the naming conventions and the fact that it supposed to run on all pages seem to be a bit more difficult for the extension to load itself with the gains of the cookie and toggling.

Aug 17 2019, 2:46 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T207485: Enable page curation tools to be loaded on any page (optionally).
  1. "apihelp-pagetriageaction-param-pageid": "The article for which to perform action on."
    • Potentially change to: “Select this article”
  2. "apihelp-pagetriageaction-param-reviewed": "If set, specifies whether the article is reviewed."
    • Potentially change to: “Specify whether the article is reviewed”
  3. "apihelp-pagetriageaction-param-enqueue": "If set, the page will be added to PageTriage queue."
    • Potentially change to: “Page will be added to the PageTriage queue”
Aug 17 2019, 12:37 AM · Community-Tech (Kanban-Q2-2019-20), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), PageCuration, Growth-Team

Aug 16 2019

Mooeypoo moved T229551: Database-reports can't see packages in its virtualenv on the grid from Needs Review/Feedback to Done on the Community-Tech (Kanban (Q1 2019-20)) board.
Aug 16 2019, 10:40 PM · Community-Tech (Kanban (Q1 2019-20)), Patch-For-Review, Tools, Toolforge