Page MenuHomePhabricator

Mooeypoo (Moriel Schottlender)
Tech Lead, CommTech and Anti Harassment Team

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Nov 18 2014, 11:57 PM (305 w, 2 d)
Availability
Available
IRC Nick
mooeypoo
LDAP User
Mooeypoo
MediaWiki User
Mooeypoo [ Global Accounts ]

Recent Activity

Thu, Sep 10

Mooeypoo added a comment to T261029: Decide on UI framework(s) to start the project with.

I'm jumping in (by request! ;) to give my recommendation: I would 100% go with VueJS on this, even only for the reason that recently this was the framework adopted by the foundation for our frontend modernization.

Thu, Sep 10, 2:28 AM · Toolhub

Jul 21 2020

Mooeypoo added a comment to T258457: WWT makes API request on every page view before button is clicked..

Also, this shouldn't act as a gadget; we did not officially release it as such and it is not optimized to be that. We're supporting it as a browser extension, and we're (ab)using the ResourceLoader queue "feature" to insert ourselves as if we're a gadget,but still working from the browser.

Jul 21 2020, 12:50 AM · Community-Tech, Who-Wrote-That
Mooeypoo added a comment to T258457: WWT makes API request on every page view before button is clicked..

IIRC, we need to ask for the translated message for the button/link, and while we're at it we're asking for the rest of the messages. I don't think we can get away with not calling it at all and still have the link appear? (though admittedly I need to delve into the code again to see if it's a timing issue)

Jul 21 2020, 12:48 AM · Community-Tech, Who-Wrote-That

Jul 8 2020

Mooeypoo created T257502: Requesting access to analytics-privatedata-users for mooeypoo.
Jul 8 2020, 6:52 PM · Operations, SRE-Access-Requests

Jul 7 2020

Mooeypoo removed a watcher for Community-Tech: Mooeypoo.
Jul 7 2020, 2:39 AM

Jun 30 2020

Mooeypoo added a comment to T255504: Decouple Special:Investigate toollinks from Special:CheckUser toollinks.

@Mooeypoo brings up an important point of separating the concerns (separating the config from the translations). However, it seems like it might be a slight abuse of the translation system to use it for config, even though, as @Tchanders point out, it's already being used that way. I wasn't able to find any other messages being used in a JSON format (they all seem to use a custom format).

Jun 30 2020, 2:13 AM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Anti-Harassment (The Letter Song), Patch-For-Review, CheckUser
Mooeypoo updated subscribers of T252812: Investigate watchlist sizes (limiting or handling large ones properly).

@Marostegui (feel free to tag anyone else that may need to participate here?), we've discussed this extensively in the team after running into some challenges, and ran some analysis on the usage of the watchlist table. We want to see if we can reframe the problem and make sure we can find a viable way forward.

Jun 30 2020, 12:31 AM · Platform Team Workboards (Clinic Duty Team), Community-Tech (Kanban-2020-21-Q1), Expiring-Watchlist-Items

Jun 29 2020

Mooeypoo added a comment to T255504: Decouple Special:Investigate toollinks from Special:CheckUser toollinks.

Another idea, followup from conversations in the team:

Jun 29 2020, 8:21 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Anti-Harassment (The Letter Song), Patch-For-Review, CheckUser

May 29 2020

Mooeypoo added a comment to T194529: Allow a user to be blocked from moving/renaming pages.

There's an issue here we should account for, or at least be aware of, that may make this block action less impactful than we'd think. If we go with @DannyS712 idea, we could probably block the actual action of moving a page (when you hit the menu action item for "move") but there are other ways to move pages manually.

May 29 2020, 9:15 PM · Anti-Harassment, MediaWiki-Blocks, User-DannyS712, MediaWiki-Page-rename

May 22 2020

Mooeypoo added a comment to T249259: Watchlist Expiry: Update popup loading behavior when watching via star [medium].

The module to bundle this is with would be that same module (the watch JS module). See packageFiles.

May 22 2020, 5:55 PM · Community-Tech (Kanban-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Patch-For-Review, Expiring-Watchlist-Items, archived--TCB-Team

May 21 2020

Mooeypoo added a comment to T250212: Watchlist Expiry: Add UI behavior in Special:Watchlist [medium].

It looks like the output should be added to the table entry for the page rather than just the rows outputted for a single change, in "EnhancedRecentChanges". Good catch, @Scardenasmolinar

May 21 2020, 7:10 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Community-Tech (Kanban-2019-20-Q4), Expiring-Watchlist-Items, archived--TCB-Team

May 20 2020

Mooeypoo added a comment to T249259: Watchlist Expiry: Update popup loading behavior when watching via star [medium].

On StructuredDiscussion talk pages, I am seeing inconsistent popup behaviour when clicking the watch star.

Watching talk page

  1. Visit a talk page which is unwatched and has StructuredDiscussions enabled (go to Special:Preferences#mw-prefsection-betafeatures, check "Structured Discussions on user talk" and Save).
  2. Click the watch star. You will see the usual watch message:
  3. Click the watch star again. You will see the usual unwatch message:
  4. Click the watch star again. You will see the special StructuredDiscussion message:

With watchlist expiry disabled, you see the special StructuredDiscussion message when you first click watch (step 2).

Unwatching talk page

  1. Visit a talk page which is watched and has SD enabled.
  2. Click the watch star. You will see the SD message telling you you have subscribed to the page (even though you have not):

I can reproduce both of the above on beta, which has watchlist expiry enabled ($wgWatchlistExpiry = true).

I have not been able to reproduce either of the above with watchlist expiry disabled (on my local version).

@Scardenasmolinar I know @Mooeypoo worked on StructuredDiscussion, so she might know more about this.

May 20 2020, 12:33 AM · Community-Tech (Kanban-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Patch-For-Review, Expiring-Watchlist-Items, archived--TCB-Team

May 19 2020

Mooeypoo added a comment to T249259: Watchlist Expiry: Update popup loading behavior when watching via star [medium].
From Gerrit:

This should not be output in the <head> of every production page view.

The information is static and identical side-wide. Bundle it with the module that neeeds it instead. This avoids delaying article rendering.

May 19 2020, 11:15 PM · Community-Tech (Kanban-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Patch-For-Review, Expiring-Watchlist-Items, archived--TCB-Team

May 15 2020

Mooeypoo added a comment to T252860: WWT fails on `James Alexander Chiles`.

We definitely rely on user rights when we show (and not show) the information when a revision is suppressed or deleted, by feature (not bug) so it sounds reasonable that if the revision was deleted, you'd get a popup with hidden details.

May 15 2020, 9:33 PM · User-DannyS712, Community-Tech, Who-Wrote-That
Mooeypoo added a comment to T252860: WWT fails on `James Alexander Chiles`.

Can you check if this happened at a specific revision? I just tried it now, and I see the entire text highlighted, given credit to your username as have written 100% of the page.

May 15 2020, 9:32 AM · User-DannyS712, Community-Tech, Who-Wrote-That

May 14 2020

Mooeypoo created T252812: Investigate watchlist sizes (limiting or handling large ones properly).
May 14 2020, 7:18 PM · Platform Team Workboards (Clinic Duty Team), Community-Tech (Kanban-2020-21-Q1), Expiring-Watchlist-Items

May 8 2020

Mooeypoo added a comment to T217363: Consider minimizing the presence of Partial Blocks UI elements on Special:Block.

Today I learned ;) https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/htmlform/HTMLForm.php$95

May 8 2020, 12:30 AM · User-notice, MediaWiki-Blocks, Patch-For-Review, User-DannyS712, MediaWiki-Interface, WMF-Design, Design, Anti-Harassment

May 7 2020

Mooeypoo added a comment to T217363: Consider minimizing the presence of Partial Blocks UI elements on Special:Block.

Using HTML form's hide-if should take care of accessibility concerns

@Mooeypoo @Volker_E I don't know much about hide-if. Is it implemented in an accessible way?

May 7 2020, 11:58 PM · User-notice, MediaWiki-Blocks, Patch-For-Review, User-DannyS712, MediaWiki-Interface, WMF-Design, Design, Anti-Harassment

May 5 2020

Mooeypoo added a comment to T251894: Requesting WMF-NDA group membership for AHT engineers.

Tagging @aezell in case manager approval is needed.

@Mooeypoo do you need access too?

May 5 2020, 4:49 PM · WMF-NDA-Requests

May 1 2020

Mooeypoo updated subscribers of T251590: Inline FieldLayout isn't inline when it contains a TextInputWidget.

Hmmmm, we really don't want inline labels at most. They are bad, bad, bad. User research (I'd need to google it for you) has shown that inline labels and text inputs make it really hard to quickly navigate/skim forms for users. Haven't yet come across the combination of text input and inline.

Sure, but there are exceptions to this rule, and when those exist, we do need a way to do it.

May 1 2020, 10:55 PM · OOUI
Mooeypoo added a comment to T251611: Move the Graph extension's TableWidget upstream to core.

I think that the question of which "upstream" is a good one; ideally, this actually could be generic enough to be in OOUI tiself, but I agree that it probably just increases complexity and size for probably very low usage.

May 1 2020, 9:01 PM · MediaWiki-extensions-Graph, JsonConfig, covid-19, Commons-Datasets
Mooeypoo updated subscribers of T251590: Inline FieldLayout isn't inline when it contains a TextInputWidget.

That's weird; we do have inline forms with text fields, I'd have expected this to be found as a bug before.... :\
If FieldLayout allows for an inline config, then it should respect inline settings.

May 1 2020, 3:16 AM · OOUI

Apr 21 2020

Mooeypoo updated subscribers of T249259: Watchlist Expiry: Update popup loading behavior when watching via star [medium].

After a bit of back and forth with @Catrope and examining the challenges here with an OOUI popup, Roan made a good point about at least testing whether the alternative is viable.

Apr 21 2020, 4:04 AM · Community-Tech (Kanban-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Patch-For-Review, Expiring-Watchlist-Items, archived--TCB-Team

Apr 17 2020

Mooeypoo updated subscribers of T249059: Requesting access to analytics-privatedata-users for tchanders, dmaza, dbarratt, wikigit.

Thank you everyone for all the feedback and back and forth, and I apologize for any misunderstandings here.

Apr 17 2020, 12:49 AM · Anti-Harassment, Operations, SRE-Access-Requests

Apr 9 2020

Mooeypoo moved T249782: Watchlist Expiry: ClearUserWatchlistJob doesn't delete from watchlist_expiry from Ready to In Development on the Community-Tech (Kanban-2019-20-Q4) board.
Apr 9 2020, 5:26 PM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), Community-Tech (Kanban-2019-20-Q4), archived--TCB-Team, Expiring-Watchlist-Items
Mooeypoo edited projects for T249782: Watchlist Expiry: ClearUserWatchlistJob doesn't delete from watchlist_expiry, added: Community-Tech (Kanban-2019-20-Q4); removed Community-Tech.
Apr 9 2020, 5:26 PM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), Community-Tech (Kanban-2019-20-Q4), archived--TCB-Team, Expiring-Watchlist-Items

Apr 7 2020

Mooeypoo added a comment to T249059: Requesting access to analytics-privatedata-users for tchanders, dmaza, dbarratt, wikigit.

@Nuria I'm a little confused, and I'd like to clarify something.

Apr 7 2020, 5:33 PM · Anti-Harassment, Operations, SRE-Access-Requests

Mar 31 2020

Mooeypoo added a comment to T248496: Watchlist Expiry: Add a popup to watch pages temporarily - BEING WORKED ON IN SEPARATE SUBTASKS.

Split to two tickets:

Mar 31 2020, 11:33 PM · Expiring-Watchlist-Items, archived--TCB-Team, Community-Tech
Mooeypoo updated the task description for T248496: Watchlist Expiry: Add a popup to watch pages temporarily - BEING WORKED ON IN SEPARATE SUBTASKS.
Mar 31 2020, 9:53 PM · Expiring-Watchlist-Items, archived--TCB-Team, Community-Tech
Mooeypoo updated the task description for T248496: Watchlist Expiry: Add a popup to watch pages temporarily - BEING WORKED ON IN SEPARATE SUBTASKS.
Mar 31 2020, 9:53 PM · Expiring-Watchlist-Items, archived--TCB-Team, Community-Tech
Mooeypoo created T249059: Requesting access to analytics-privatedata-users for tchanders, dmaza, dbarratt, wikigit.
Mar 31 2020, 9:13 PM · Anti-Harassment, Operations, SRE-Access-Requests
Mooeypoo added a comment to T246797: Structured Data on Commons: RTL support for geographical co-ordinates.

(egh, my screenshot didn't work, but--) w00t, it works now!

Mar 31 2020, 7:12 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Structured-Data-Backlog (Current Work), RTL, Structured Data Engineering, I18n
Mooeypoo added a comment to T246797: Structured Data on Commons: RTL support for geographical co-ordinates.

Sweet, I think this should fix it. I +2'ed, so it should be available on beta soon to test.

Mar 31 2020, 5:22 AM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Structured-Data-Backlog (Current Work), RTL, Structured Data Engineering, I18n

Mar 27 2020

Mooeypoo added a comment to T246797: Structured Data on Commons: RTL support for geographical co-ordinates.

Following up since @Etonkovidova has asked me to look into why it's not working:

Mar 27 2020, 12:40 AM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Structured-Data-Backlog (Current Work), RTL, Structured Data Engineering, I18n

Mar 24 2020

Mooeypoo added a watcher for Vue.js: Mooeypoo.
Mar 24 2020, 8:05 PM

Mar 22 2020

Mooeypoo added a comment to T247639: CU 2.0: Create queries required for the Timeline tab [medium].

I would avoid doing things that have no (or huge) limit. Honestly, I think it's a product problem more than a performance one, but since we are checking more than one target (unlike the original) I'd be slightly more careful, and go with pagination.

Mar 22 2020, 4:17 AM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Anti-Harassment (The Letter Song), CheckUser

Mar 13 2020

Mooeypoo updated the task description for T247639: CU 2.0: Create queries required for the Timeline tab [medium].
Mar 13 2020, 9:41 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Anti-Harassment (The Letter Song), CheckUser
Mooeypoo created T247641: CU 2.0: Add variant display to the Timeline result list .
Mar 13 2020, 9:40 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser
Mooeypoo created T247640: CU 2.0: Add the timeline tab with a list of generic structured results [medium].
Mar 13 2020, 9:37 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Anti-Harassment (The Letter Song), CheckUser
Mooeypoo created T247639: CU 2.0: Create queries required for the Timeline tab [medium].
Mar 13 2020, 9:34 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Anti-Harassment (The Letter Song), CheckUser

Mar 12 2020

Mooeypoo added a comment to T237595: CU 2.0: Timeline tab.

This looks great. Let's just make sure we don't literally copy over what RecentChanges is doing, because the way it is constructing its lines is pretty horrific, and uses monospace-font single-spaces to align tags per each line, etc.

Mar 12 2020, 9:44 PM · Anti-Harassment, CheckUser

Mar 7 2020

Mooeypoo added a comment to T246958: HTMLUsersMultiselectField fails validation when exists is true, but required is false.

@Mooeypoo Thanks yes, that sounds the same as what's described in T246958#5949448. (Prioritize requires over exists; show errors accordingly.)

Oh, I'm sorry if I misrepresented. I got confused with the table showing different messaging exists=true and exists=false... which is different than the suggestion. Sorry, it's really confusing -- I'm just glad we are on the same page!

My main concern was about changing the behaviour of a long-standing and widely-used widget - if that's ok then let's go ahead with this.

Mar 7 2020, 1:51 AM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Anti-Harassment (The Letter Song), MediaWiki-General

Mar 6 2020

Mooeypoo added a comment to T246958: HTMLUsersMultiselectField fails validation when exists is true, but required is false.

Thank you for the thorough analysis, @Tchanders !

Mar 6 2020, 11:02 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Anti-Harassment (The Letter Song), MediaWiki-General

Feb 26 2020

Mooeypoo updated the task description for T245078: Watchlist expiry API: Add a expiry parameter when adding an item to the watchlist [medium].
Feb 26 2020, 9:34 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), Community-Tech (Kanban-2019-20-Q4), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Expiring-Watchlist-Items, archived--TCB-Team
Mooeypoo added a comment to T245866: Watchlist Expiry: Create 20,000 cap.

Clarification: The cap should be configurable per wiki (per the conversations with DBAs), with a default (for now) of 20,000 items.

Feb 26 2020, 9:23 PM · archived--TCB-Team, Expiring-Watchlist-Items, Community-Tech
Mooeypoo updated the task description for T245866: Watchlist Expiry: Create 20,000 cap.
Feb 26 2020, 9:09 PM · archived--TCB-Team, Expiring-Watchlist-Items, Community-Tech
Mooeypoo added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

Thank you for the excellent detailed reply, @EvanYou. This is a great summary of the points, and gives a good perspective to this RFC and the entire modernization endeavor in general.

Feb 26 2020, 7:03 PM · Front-end-Standards-Group, Vue.js, TechCom-RFC (TechCom-RFC-Closed), Security-Team
Mooeypoo added a comment to T245793: [Firefox 73] Infusing a RadioOptionWidget changes first-child alignment.

Looks good to me. Thank you for figuring it out, @matmarex !

Feb 26 2020, 5:10 AM · OOUI (OOUI-0.37.0), MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Community-Tech, MediaWiki-extensions-GlobalPreferences, Browser-Support-Firefox, Desktop Improvements
Mooeypoo added a comment to T246053: Give access to Anti Harassment Tools team to production deployment.

Thanks @Dzahn ; I signed the document, and my public ED25519 key is:

Feb 26 2020, 12:13 AM · Operations, SRE-Access-Requests

Feb 25 2020

Mooeypoo added a comment to T245181: Improve test coverage for Special:Investigate.

The general idea of this specific task is to provide the full coverage for the Services, not so much for the special page, which seemed to be more focused and doable. We've added the use cases to guide/inform the approach to the testing.

Feb 25 2020, 10:14 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Anti-Harassment (The Letter Song), CheckUser
Mooeypoo created T246053: Give access to Anti Harassment Tools team to production deployment.
Feb 25 2020, 12:48 AM · Operations, SRE-Access-Requests

Feb 21 2020

Mooeypoo added a comment to T245499: Improve performance of Compare query for Special:Investigate.

A couple of small clarifications from the meeting. The third option is the one that's laid out in the description of this ticket, including the product implications.

Feb 21 2020, 11:25 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Anti-Harassment (The Letter Song), Performance Issue, CheckUser
Mooeypoo added a comment to T245793: [Firefox 73] Infusing a RadioOptionWidget changes first-child alignment.

Confirmed; on Firefox v73, even on not too large of a screen.

Feb 21 2020, 12:00 AM · OOUI (OOUI-0.37.0), MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Community-Tech, MediaWiki-extensions-GlobalPreferences, Browser-Support-Firefox, Desktop Improvements

Feb 20 2020

Mooeypoo updated the task description for T245181: Improve test coverage for Special:Investigate.
Feb 20 2020, 7:25 PM · MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Anti-Harassment (The Letter Song), CheckUser
Mooeypoo added a comment to T244100: Spike: New/Improved OCR tool [8 hours].

We don't have that in production so far, so I'm not sure, especially due to security concerns. We might need to have a gadget where each user must whitelist the toolforge URL individually for security and privacy.

Feb 20 2020, 4:02 PM · Community-Tech (Kanban-2019-20-Q4), Internet-Archive
Mooeypoo moved T245660: PRU: enable pru on test wikidata from Needs Review/Feedback to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

PRU is now available on all test wikis:

Feb 20 2020, 12:25 AM · Community-Tech (Kanban-Q3-2019-20), Password-Reset-Update

Feb 19 2020

Mooeypoo closed T240094: Create required table for new Watchlist Expiry feature as Resolved.

The table has been created. Thank you for all the advice and guidance and help @Marostegui! And thanks, @Anomie, for the input and guidance on the best ways to approach the purging.

Feb 19 2020, 6:19 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), DBA, Community-Tech (Kanban-Q3-2019-20), Platform Team Workboards (Clinic Duty Team), Expiring-Watchlist-Items
Mooeypoo closed T235005: Spike #2: Watchlist Expiry [12 hours] as Resolved.

Investigation resolved. Next steps on followup tickets. Thank you for everyone's input!

Feb 19 2020, 6:17 PM · Community-Tech (Kanban-Q3-2019-20), Expiring-Watchlist-Items, archived--TCB-Team
Mooeypoo moved T243300: Spike: Investigate Named References in VE [8 hours] from Needs Review/Feedback to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.

Investigation is done; we will await next steps to create followup tickets.

Feb 19 2020, 6:14 PM · User-Ryasmeen, Community-Tech (Kanban-2019-20-Q4), Editing-team (Tracking), VisualEditor

Feb 18 2020

Mooeypoo moved T238961: PRU: Improve Security & Standardize Experience for Password Reset [medium] from Needs Review/Feedback to Product sign-off on the Community-Tech (Kanban-Q3-2019-20) board.
Feb 18 2020, 10:33 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Community-Tech (Kanban-Q3-2019-20), Password-Reset-Update

Feb 17 2020

Mooeypoo updated subscribers of T245358: Compress table watchlist_expiry.

Will do, @Marostegui ; FYI, I'm also tracking the creation of the table through this ticket: T244631: Create `watchlist_expiry` table in production after wmf.19 is available.

Feb 17 2020, 8:18 AM · DBA

Feb 15 2020

Mooeypoo added a comment to T245082: Add site-wide $wgDefaultWatchlistExpiry configuration variable.

How will the relative bits work with translation and localization if this is truly configurable per wiki?

Feb 15 2020, 7:44 AM · Expiring-Watchlist-Items, archived--TCB-Team, Community-Tech

Feb 14 2020

Mooeypoo added a comment to T238961: PRU: Improve Security & Standardize Experience for Password Reset [medium].

Just to clarify for engineering related thing, am I right to say that, basically, the message ("Both username and email address are required to receive a temporary password via email.") should never appear anywhere, @ifried ?

Feb 14 2020, 10:28 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Community-Tech (Kanban-Q3-2019-20), Password-Reset-Update
Mooeypoo updated subscribers of T244579: MediaWiki does not support consistent pagination on non-unique fields.

The product we're discussing (an expansion to CheckUser) deals with potentially large chunks of data from the database, which triggers a number of problems with regard to performance. Regardless of what method we use, we have to come up with a good way to deal with that. After discussing with the team and talking things with @Catrope for some advice around how CheckUser has historically extracted potentially large chunks of information to process, I think we have a slightly changed strategy, and have a plan.

Feb 14 2020, 4:07 AM · MediaWiki-General, TechCom
Mooeypoo created T245224: Cleanup Watchlist expiry: matching of watchlist_expiry item with removal of a watchlist item.
Feb 14 2020, 12:14 AM · Community-Tech (Kanban-2019-20-Q4), archived--TCB-Team, Expiring-Watchlist-Items

Feb 13 2020

Mooeypoo created T245082: Add site-wide $wgDefaultWatchlistExpiry configuration variable.
Feb 13 2020, 12:14 AM · Expiring-Watchlist-Items, archived--TCB-Team, Community-Tech
Mooeypoo created T245081: Special:EditWatchlist: Filter out expired items [medium].
Feb 13 2020, 12:12 AM · Community-Tech (Kanban-2019-20-Q4), Expiring-Watchlist-Items, archived--TCB-Team
Mooeypoo created T245080: Special:Watchlist: Filter out expired items [medium].
Feb 13 2020, 12:11 AM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), Community-Tech (Kanban-2019-20-Q4), Expiring-Watchlist-Items, archived--TCB-Team
Mooeypoo created T245079: Watchlist expiry API: Filter out expired items when outputting the watchlist [medium].
Feb 13 2020, 12:10 AM · Community-Tech (Kanban-2019-20-Q4), Patch-For-Review, archived--TCB-Team, Expiring-Watchlist-Items
Mooeypoo created T245078: Watchlist expiry API: Add a expiry parameter when adding an item to the watchlist [medium].
Feb 13 2020, 12:08 AM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), Community-Tech (Kanban-2019-20-Q4), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Expiring-Watchlist-Items, archived--TCB-Team

Feb 12 2020

Mooeypoo moved T243300: Spike: Investigate Named References in VE [8 hours] from In Development to Needs Review/Feedback on the Community-Tech (Kanban-Q3-2019-20) board.
Feb 12 2020, 12:09 AM · User-Ryasmeen, Community-Tech (Kanban-2019-20-Q4), Editing-team (Tracking), VisualEditor

Feb 11 2020

Mooeypoo updated the task description for T244804: Create a purge routine for `watchlist_expiry` [medium].
Feb 11 2020, 10:46 PM · Community-Tech (Kanban-2019-20-Q4), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Expiring-Watchlist-Items, archived--TCB-Team
Mooeypoo updated subscribers of T243300: Spike: Investigate Named References in VE [8 hours].

Thank you for the analysis, @HMonroy, this is super helpful!

Feb 11 2020, 7:25 PM · User-Ryasmeen, Community-Tech (Kanban-2019-20-Q4), Editing-team (Tracking), VisualEditor
Mooeypoo added a comment to T244507: [wip] Temporary Watchlist UI .

That's a good point also for the no-JS version.

Feb 11 2020, 12:06 AM · Community-Tech, Expiring-Watchlist-Items, archived--TCB-Team

Feb 10 2020

Mooeypoo added a comment to T244804: Create a purge routine for `watchlist_expiry` [medium].

The purging operation should be done every X edits, where X is a configuration variable that has a default but can be set separately per wiki.

I would suggest adding a maintenance script (as a thin wrapper around whatever code you write) that can be cronjob'd/similar too like we do in other situations

https://github.com/wikimedia/mediawiki/blob/master/maintenance/purgeExpiredUserrights.php and https://github.com/wikimedia/puppet/blob/b347052863d4d2e87b37d6c2d9f44f833cfd9dc2/modules/mediawiki/manifests/maintenance/purge_expired_userrights.pp

Feb 10 2020, 11:18 PM · Community-Tech (Kanban-2019-20-Q4), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Expiring-Watchlist-Items, archived--TCB-Team
Mooeypoo added a comment to T244804: Create a purge routine for `watchlist_expiry` [medium].

Note: This process is already implemented for the RecentChanges table, which is being purged every few edits. see: https://gerrit.wikimedia.org/g/mediawiki/core/+/799eeb583a6747ad96888ec0fef8f76e45079129/includes/Storage/DerivedPageDataUpdater.php#1493

Feb 10 2020, 11:17 PM · Community-Tech (Kanban-2019-20-Q4), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Expiring-Watchlist-Items, archived--TCB-Team
Mooeypoo created T244804: Create a purge routine for `watchlist_expiry` [medium].
Feb 10 2020, 10:58 PM · Community-Tech (Kanban-2019-20-Q4), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Expiring-Watchlist-Items, archived--TCB-Team

Feb 8 2020

Mooeypoo created T244631: Create `watchlist_expiry` table in production after wmf.19 is available.
Feb 8 2020, 2:33 AM · archived--TCB-Team, Expiring-Watchlist-Items, Community-Tech, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3))
Mooeypoo added a comment to T244507: [wip] Temporary Watchlist UI .

These look great, @Prtksxna !

Feb 8 2020, 12:50 AM · Community-Tech, Expiring-Watchlist-Items, archived--TCB-Team

Feb 5 2020

Mooeypoo added a comment to T240094: Create required table for new Watchlist Expiry feature.

Not sure I get this, if we move to a model where we'd be purging based on the number of edits, we should be good now?
Say we purge every 1000 edits, if that operation fails, we'd be purging once it reaches 2000?

I think one retry at least is always good, servers can be overloaded, they could be connection issues, contention issues etc...so at least a retry should be attempted I believe.

Feb 5 2020, 5:15 AM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), DBA, Community-Tech (Kanban-Q3-2019-20), Platform Team Workboards (Clinic Duty Team), Expiring-Watchlist-Items
Mooeypoo added a comment to T124752: RFC: Expiring watch list entries.

To clarify -- the wl_id was already added to the table. When we checked into this feature, we believed this RFC to be done because the details (wl_id in the watchlist table) were done, even though the original proposers then deprioritized the work on the feature. When we consulted, we were told no RFC is needed for the actual feature.

Feb 5 2020, 3:00 AM · Community-Tech, User-Addshore, Expiring-Watchlist-Items, German-Community-Wishlist, archived--TCB-Team, TechCom-RFC
Mooeypoo added a comment to T124752: RFC: Expiring watch list entries.

We're working on this as part of the wishlist items. We're going with the strategy of adding a new table that references the watchlist item and has an expiration.

Feb 5 2020, 2:35 AM · Community-Tech, User-Addshore, Expiring-Watchlist-Items, German-Community-Wishlist, archived--TCB-Team, TechCom-RFC

Feb 4 2020

Mooeypoo added a comment to T240094: Create required table for new Watchlist Expiry feature.

Thank you for the quick response, @Marostegui.

Our hope was that having this data in a separate table would allow us to tune the automated deletions that will happen as part of expiration. If we do this in the existing watchlist table, we risk causing table locks that could significantly affect app performance.

How are you going to determine the size of the DELETE batches. Deleting is an expensive operation in MySQL, so ideally we'd prefer often but smaller transaction rather than less but bigger ones.
I also assume normal "wait for replication protections" will be used on the scripts.

Feb 4 2020, 1:35 AM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), DBA, Community-Tech (Kanban-Q3-2019-20), Platform Team Workboards (Clinic Duty Team), Expiring-Watchlist-Items

Jan 26 2020

Mooeypoo added a comment to T243626: Provide instructions to install and configure WWT for any wiki.

Thank you for the kind words, I'm really glad you like this, and very happy to see the positive reactions overall.

Jan 26 2020, 3:54 AM · Documentation, Who-Wrote-That, Community-Tech

Jan 23 2020

Mooeypoo added a comment to T239680: CU 2.0: Persist the form state.

The patch as written by @dbarratt looks good to me, but I'd like to make sure this complies with your recommendations, @sbassett, especially in regards to the given packages and the versioning. Since this is going to be what we base the rest of the product on, can you be so kind to do a quick pass, @sbassett https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/554229

Jan 23 2020, 10:28 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)

Jan 22 2020

Mooeypoo added a comment to T240094: Create required table for new Watchlist Expiry feature.

Now that we have things organized and settled, I'm tagging DBA for assistance. Please let us know if there's anything we need to further expand on, explain, or help with. Your help is super appreciated, thank you!

Jan 22 2020, 10:32 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), DBA, Community-Tech (Kanban-Q3-2019-20), Platform Team Workboards (Clinic Duty Team), Expiring-Watchlist-Items
Mooeypoo added a project to T240094: Create required table for new Watchlist Expiry feature: DBA.
Jan 22 2020, 10:30 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), DBA, Community-Tech (Kanban-Q3-2019-20), Platform Team Workboards (Clinic Duty Team), Expiring-Watchlist-Items
Mooeypoo added a comment to T242918: Spike: Investigate WWT Expansion [4 hours].

After some thinking, I unfortunately think that the extension route might actually not be feasible because of the external API request (I don't think we allow for any of that in extensions in production) but either way, a question -- @MusikAnimal

Jan 22 2020, 10:16 PM · Community-Tech (Kanban-Q3-2019-20), Spike, Who-Wrote-That
Mooeypoo moved T242759: WWT: Standardise how we do attribution percentage in translations [small] from Needs Review/Feedback to QA on the Community-Tech (Kanban-Q3-2019-20) board.
Jan 22 2020, 8:40 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
Mooeypoo updated the task description for T240094: Create required table for new Watchlist Expiry feature.
Jan 22 2020, 6:20 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), DBA, Community-Tech (Kanban-Q3-2019-20), Platform Team Workboards (Clinic Duty Team), Expiring-Watchlist-Items
Mooeypoo renamed T242760: Move WSExport to VPS from Move WSexport to VPS to Move WSExport to VPS.
Jan 22 2020, 12:45 AM · Community-Tech (Kanban-Q3-2019-20), Wikisource Export

Jan 21 2020

Mooeypoo updated the task description for T243300: Spike: Investigate Named References in VE [8 hours].
Jan 21 2020, 10:57 PM · User-Ryasmeen, Community-Tech (Kanban-2019-20-Q4), Editing-team (Tracking), VisualEditor
Mooeypoo added a comment to T242091: Spike: WWT: WhoColor API does not work with some tokens.

This is a weird bug, but I don't think it's a problem of the character, I think there might be an issue in WhoColor with this specific article?

Jan 21 2020, 10:48 PM · Who-Wrote-That, Community-Tech
Mooeypoo added a comment to T242918: Spike: Investigate WWT Expansion [4 hours].

There is another option we should add to the investigation, @MusikAnimal -- let's also check into making WWT into a MediaWiki extension.

Jan 21 2020, 9:38 PM · Community-Tech (Kanban-Q3-2019-20), Spike, Who-Wrote-That
Mooeypoo added a comment to T233091: Revision Details Pop-up sometimes in wrong place .

Okay, thanks, Dom. I'll keep it in the 'to be estimated/discussed' column for now, and we'll check in again at a later time to see if the behavior resurfaces.

Also, @Mooeypoo, do you think this issue was fixed in the process of the refactor work in T241004? Thanks!

Jan 21 2020, 8:25 PM · Who-Wrote-That, Community-Tech
Mooeypoo moved T242954: WWT Popup: Padding changes [x-small] from Needs Review/Feedback to QA on the Community-Tech (Kanban-Q3-2019-20) board.
Jan 21 2020, 6:36 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
Mooeypoo moved T241004: WWT: Refactor the relationship between the RevisionPopupWidget, Model and Controller for clarity from Needs Review/Feedback to QA on the Community-Tech (Kanban-Q3-2019-20) board.
Jan 21 2020, 6:36 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
Mooeypoo claimed T242954: WWT Popup: Padding changes [x-small].

Added as part of https://github.com/wikimedia/WhoWroteThat/pull/138

Jan 21 2020, 4:35 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That
Mooeypoo added a comment to T241004: WWT: Refactor the relationship between the RevisionPopupWidget, Model and Controller for clarity.

OK I fixed the comments, and also fixed up the request from T242954: WWT Popup: Padding changes [x-small] so this is ready for re-review.

Jan 21 2020, 4:35 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That

Jan 16 2020

Mooeypoo added a comment to T242954: WWT Popup: Padding changes [x-small].

Perfect. This can be fixed / added to the ongoing PR https://github.com/wikimedia/WhoWroteThat/pull/138

Jan 16 2020, 4:52 PM · Community-Tech (Kanban-Q3-2019-20), Who-Wrote-That