Mooeypoo (Moriel Schottlender)
Software Engineer, Editing Team

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 18 2014, 11:57 PM (148 w, 5 d)
Availability
Available
IRC Nick
mooeypoo
LDAP User
Mooeypoo
MediaWiki User
Mooeypoo

Recent Activity

Thu, Sep 21

Mooeypoo claimed T176380: Stop community links from opening then closing on Recent changes.
Thu, Sep 21, 9:50 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Performance, Edit-Review-Improvements

Wed, Sep 20

Mooeypoo moved T176250: Slowdown due to new filters from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Wed, Sep 20, 11:39 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Performance, Edit-Review-Improvements

Tue, Sep 19

Mooeypoo created T176237: ContentTranslation on Hebrew Wiki crashes on Chrome for a page with multiple templates.
Tue, Sep 19, 5:29 PM · ContentTranslation

Mon, Sep 18

Mooeypoo removed a project from T168835: Make icons size more consistent for Recent Changes filters: User-Petar.petkovic.
Mon, Sep 18, 8:01 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T168835: Make icons size more consistent for Recent Changes filters from Ready for Pickup to Blocked on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.

Moving this to blocked, as per @Volker_E's comment. This is a standardization issue, and fixing/overriding it specifically in RCFilters may do more damage than good to overall support.

Mon, Sep 18, 8:00 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T175217: Tweak UI for main filtering entry point from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Mon, Sep 18, 7:17 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T172387: Cannot set my default to see all results (no filters) from QA Review to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.

Bringing back to 'needs review' with the new fix.

Mon, Sep 18, 6:09 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page

Fri, Sep 15

Mooeypoo added a comment to T172387: Cannot set my default to see all results (no filters).

The patch above works well but it creates a weird situation: when you save the empty state as your default filter, the "Restore default filters" button is visible even though you currently have your default filters.

Fri, Sep 15, 12:05 AM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page

Thu, Sep 14

Mooeypoo added a comment to T172387: Cannot set my default to see all results (no filters).

The patch above works well but it creates a weird situation: when you save the empty state as your default filter, the "Restore default filters" button is visible even though you currently have your default filters.

Thu, Sep 14, 9:42 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Mooeypoo moved T175965: Days default value does not retain a fraction from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Thu, Sep 14, 9:14 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo created T175965: Days default value does not retain a fraction.
Thu, Sep 14, 9:14 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo updated subscribers of T174819: Show last 250 changes and period selection dropdowns are not keyboard accessible.

Pinging @Volker_E and @matmarex on this; I took a look and I can shift focus into the popup when you open the popup, which then allows you to tab through the elements in there -- however, while OO.ui.ButtonSelectWidget miexes in OO.ui.mixin.TabIndexedElement, OO.ui.ButtonOptionWidget isn't -- so I can't set a tabindex for it.

Thu, Sep 14, 12:35 AM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Accessibility, Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T174732: Logged actions selected by namespace filters cannot be highlighted from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.

Whoops. Fixed in this commit.

Thu, Sep 14, 12:18 AM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Mooeypoo claimed T172387: Cannot set my default to see all results (no filters).
Thu, Sep 14, 12:14 AM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page

Wed, Sep 13

Mooeypoo claimed T167262: Server-launched guided tour can show on the wrong page if the user navigates away before full page load.
Wed, Sep 13, 11:41 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Patch-For-Review, Edit-Review-Improvements-RC-Page, MediaWiki-extensions-GuidedTour, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo moved T175697: Don't move the Filter search bar when user clicks on it from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Wed, Sep 13, 10:31 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T175697: Don't move the Filter search bar when user clicks on it.
Wed, Sep 13, 10:30 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T175867: [wmf.18 - regression] oo-ui-iconElement-icon oo-ui-icon-userAvatar and others are missing in Echo notifications.
Wed, Sep 13, 10:19 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Regression, Collab-Notifications-Page
Mooeypoo assigned T174454: [wmf.15] 'Save current filter settings' cancel button (X) is misaligned to Petar.petkovic.
Wed, Sep 13, 8:54 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, User-Petar.petkovic, Edit-Review-Improvements, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo claimed T174732: Logged actions selected by namespace filters cannot be highlighted .

Should be fixed alongside T174734: Changes to namespaces are not highlighted as requested if 'Group results by page' is enabled

Wed, Sep 13, 12:58 AM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Mooeypoo claimed T174734: Changes to namespaces are not highlighted as requested if 'Group results by page' is enabled.

Some of the results seem to not be properly tagged with the 'mw-changeslist-ns-1' class in the backend. Fixing.

Wed, Sep 13, 12:44 AM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)

Tue, Sep 12

Mooeypoo added a comment to T174111: [wmf.16-regression] Saved query names displayed shifted up.

This most likely happened after we changed the saved queries title from "we don't care how long this is" to "trim it at 1 line". The display options make it hard to align now, but need to be looked into.

Tue, Sep 12, 5:08 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, User-Petar.petkovic, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo added a comment to T169613: Introduce the New Filters to users upon beta graduation.

In T169613#3593044, @Mooeypoo wrote:

@jmatazzoni question/clarification; as @Mattflaschen-WMF pointed out in review, the current code will only work in Special:RecentChanges. I could make it work in all other pages (Watchlist and RelatedChanges) but the language of the tour is specific to "RecentChanges".

I am going to keep this as-is for now; if you want this tour to also be the same behavior for Watchlist or RecentChanges (this also applies to the "invite to the beta feature") then let's create a child task and make sure we have adequate wording for the tour displaying on the other pages.

@Mooeypoo, will what you've done work on Related Changes? That's the only other place we'll want this .No need for Watchlist. Thanks.

Tue, Sep 12, 5:02 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Fri, Sep 8

Mooeypoo added a comment to T169613: Introduce the New Filters to users upon beta graduation.

@jmatazzoni question/clarification; as @Mattflaschen-WMF pointed out in review, the current code will only work in Special:RecentChanges. I could make it work in all other pages (Watchlist and RelatedChanges) but the language of the tour is specific to "RecentChanges".

Fri, Sep 8, 9:41 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Fri, Sep 1

Mooeypoo added a comment to T173970: pt-notifications-alert > a has "Notices (0)" as text on first load, but changes to "0" on click.

(from an IRC conversation) -

Fri, Sep 1, 11:52 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Notifications, Collaboration-Team-Triage
Mooeypoo added a comment to T173970: pt-notifications-alert > a has "Notices (0)" as text on first load, but changes to "0" on click.

This sounds a little weird; the nojs CSS should override the number from the beginning, regardless of JS (without having to wait for load)

Fri, Sep 1, 10:11 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Notifications, Collaboration-Team-Triage
Mooeypoo added a comment to T169613: Introduce the New Filters to users upon beta graduation.

@Pginer-WMF, I rewrote this to make it into a spec for developers and moved it to RFP. Please look it over to make sure it's correct. Also, if you need to provide any icons, etc (like the gear, perhaps?), please add them to the Description above. Thanks.

The spec looks good.
One aspect missing is when this would be removed, since at some point the new filters would be the normal experience, but we can create a separate ticket for that if needed.

The cog icon is part of the standard set of icons, which I think can be adjusted to any color in code. In any case, if a specific blue version is needed, I added it below:

Fri, Sep 1, 5:14 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Trizek-WMF awarded T169613: Introduce the New Filters to users upon beta graduation a Like token.
Fri, Sep 1, 1:32 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T169613: Introduce the New Filters to users upon beta graduation.

@Pginer-WMF Do you have a copy of the gear icon in the proper size/color? I couldn't find it (I was sure we used it before, but I guess I was wrong?)

Fri, Sep 1, 1:14 AM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T169613: Introduce the New Filters to users upon beta graduation.
Fri, Sep 1, 12:10 AM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Thu, Aug 31

Mooeypoo added a comment to T172957: Live Update causes problems with "Navigation popups" gadget.

I am not 100% sure of the reprecussions of this to other products, so I don't want to edit the actual code, but it seems like it's reasonable to expect that any time wikipage.content hook is fired, the popups should reset.

Thu, Aug 31, 12:06 AM · User-Petar.petkovic, Navigation-Popups, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page, Edit-Review-Improvements-Integrated-Filters

Wed, Aug 30

Mooeypoo moved T173533: No longer block user from clicking results when page is loading. from Ready for Pickup to Blocked on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.

Moving to blocked, as this is waiting on two patches that are less urgent but need to be merged enough time before a cut to allow for rigorous testing.

Wed, Aug 30, 11:35 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Mooeypoo moved T174617: Make 'Other review tools' (MediaWiki:Recentchangestext box) span the entire page from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Wed, Aug 30, 11:28 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Recent-changes, Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T174617: Make 'Other review tools' (MediaWiki:Recentchangestext box) span the entire page from Ready for Pickup to In Development on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Wed, Aug 30, 10:40 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Recent-changes, Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T170875: Improve highlighting display so it's compatible with 'Group results by page" preference.

@Mooeypoo please note the above new requirement. I know there is some complication in the structure of this page. Will that be possible without heroic efforts?

Wed, Aug 30, 5:02 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)

Tue, Aug 29

Mooeypoo claimed T174506: [wmf.16-regression] Default filters with Excluded namespaces don't preserve exclude status when loaded via 'Restore default filters'.
Tue, Aug 29, 10:05 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements, Regression, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo added a comment to T172030: Integrate Watchlist-management links and page info into the new UX.

@jmatazzoni Took a look and said there's no problem with removing the icon if it's a hassle technically.

Tue, Aug 29, 7:12 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist
Mooeypoo added a comment to T172030: Integrate Watchlist-management links and page info into the new UX.

Just pointing out that we can't (and shouldn't, in general) have an icon inside the message text. This causes huge issues for translation and while we might be able to cheat the system to comply, it's going to affect a lot more than just this specific page; translators are going to have a big problem with the bit of text and handling it.

Tue, Aug 29, 6:05 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist
Mooeypoo added a comment to T170875: Improve highlighting display so it's compatible with 'Group results by page" preference.

The indendation was the intended behavior according to the spec I understood, and reworking it is a pretty big mess because of the wya that the "enhanced" display works with big tables and "placeholder" cells.
@jmatazzoni looked at it on my computer yesteday and seemed to be happy with it.

Tue, Aug 29, 4:12 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)

Mon, Aug 28

Mooeypoo moved T173264: Tweaks to the pushpin icon design and functionality from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Mon, Aug 28, 11:14 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Mooeypoo added a comment to T173264: Tweaks to the pushpin icon design and functionality.

Whoops, my CSS selectors were too broad. Fixed in this commit.

Mon, Aug 28, 10:32 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Mooeypoo claimed T174193: The names of new Saved Filters don't appear as expected in the Active Filter area .
Mon, Aug 28, 8:08 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)

Aug 26 2017

Mooeypoo moved T171235: Standardize system for indicating unseen/seen changes on Watchlist from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 26 2017, 1:04 AM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters, MediaWiki-Watchlist

Aug 24 2017

Mooeypoo claimed T171235: Standardize system for indicating unseen/seen changes on Watchlist.
Aug 24 2017, 11:56 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters, MediaWiki-Watchlist
Mooeypoo moved T174121: Get rid of the <legend> in RCFilters fieldset and minimize more vertical spaces from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 24 2017, 11:56 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo created T174121: Get rid of the <legend> in RCFilters fieldset and minimize more vertical spaces.
Aug 24 2017, 11:55 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a project to T172461: Special:RecentChanges no longer displays interwiki links on wikis that have added them to MediaWiki:Recentchangestext: Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017).

We're looking into this.

Aug 24 2017, 5:19 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release, Regression, MediaWiki-Recent-changes
Mooeypoo added a comment to T172461: Special:RecentChanges no longer displays interwiki links on wikis that have added them to MediaWiki:Recentchangestext.

I am looking at https://cs.wikipedia.org/wiki/Speci%C3%A1ln%C3%AD:Posledn%C3%AD_zm%C4%9Bny and I can see the MediaWiki:Recentchangestext message clearly.

Aug 24 2017, 5:21 AM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release, Regression, MediaWiki-Recent-changes

Aug 23 2017

Mooeypoo moved T173992: Hide saved filters from anonymous users from QA Review to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 23 2017, 11:35 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo created T173992: Hide saved filters from anonymous users.
Aug 23 2017, 11:32 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo claimed T173264: Tweaks to the pushpin icon design and functionality.

This particular pushpin instance was intended to be presented more like a marker than an action (T164128). Some adjustments that could help:

  • Make the size smaller. In the spec I was proposing to use 16x16px instead of the current 24x24px.

Done.

  • Use grey as the color. We can use Base20 (#54595D)

Can't directly change the color, so I've used opacity instead. opacity:0.5; seemed to be fairly good, but may require a little bit of adjustment later.

  • Use it as a shortcut for opening the menu, where the "default" status can be adjusted from. This provides a safe path for those trying to act on the mark to access related actions.

Done.

Aug 23 2017, 11:11 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Mooeypoo added a comment to T173265: Reduce vertical whitespace in the RC page with the New Filters.

Okay, I misunderstood - I thought you meant reducing both top/bottom margins to 4px. Fixing the patch now. We can go over it again after it's merged and you could see it in beta.

Aug 23 2017, 6:20 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Mooeypoo added a comment to T173264: Tweaks to the pushpin icon design and functionality.

This particular pushpin instance was intended to be presented more like a marker than an action (T164128). Some adjustments that could help:

  • Make the size smaller. In the spec I was proposing to use 16x16px instead of the current 24x24px.
  • Use grey as the color. We can use Base20 (#54595D)
  • Use it as a shortcut for opening the menu, where the "default" status can be adjusted from. This provides a safe path for those trying to act on the mark to access related actions.
Aug 23 2017, 4:56 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page

Aug 22 2017

Mooeypoo moved T166908: ChangesListSpecialPage backend: Respect saved query if no parameters from Needs Review to Code Review Started on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 22 2017, 11:46 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T173265: Reduce vertical whitespace in the RC page with the New Filters.
Aug 22 2017, 11:40 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Mooeypoo added a comment to T173265: Reduce vertical whitespace in the RC page with the New Filters.

I made the spaces smaller, removed the top margin (it was there to separate from the community list, but that list goes into the box anyways now) and I reduced the top margin/padding of the first heading of the results, so it's a little less spacey.

Aug 22 2017, 11:40 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Mooeypoo claimed T171901: [minor] RC page - a filter's name that spans several lines needs vertical adjustment.
Aug 22 2017, 11:14 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page

Aug 21 2017

Mooeypoo placed T172580: 'Group results by page' option is sticky up for grabs.
Aug 21 2017, 9:04 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo claimed T172580: 'Group results by page' option is sticky .
Aug 21 2017, 7:08 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo claimed T173059: [regression-wmf.13] Notification panel - misaligned blue dot.
Aug 21 2017, 6:22 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, Notifications, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Regression

Aug 18 2017

Mooeypoo updated subscribers of T172327: [wmf.12 - regression] RC page - Day selector displays decimals from "Days to show..." form.

Yes, this isn't really a bug - or rather, it's expected.

Aug 18 2017, 11:38 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Mooeypoo closed T172557: [betalabs-regression] 'Show last changes' does not display number 1 as Invalid.

After talking to @jmatazzoni, I'm closing this as invalid.

Aug 18 2017, 11:33 PM · Edit-Review-Improvements-RC-Page, Regression, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo updated subscribers of T172557: [betalabs-regression] 'Show last changes' does not display number 1 .

It shows the singular version of the message: "Show last change" (note, it's a single change)

Aug 18 2017, 11:31 PM · Edit-Review-Improvements-RC-Page, Regression, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo claimed T172820: [regression - wmf.12] RC page - the dotted (empty) circle for Highlights is misaligned.
Aug 18 2017, 11:29 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Regression
Mooeypoo moved T173608: Add missing accessibility features to RCFilters from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 18 2017, 11:08 PM · OOjs-UI (OOjs-UI-0.22.5), Accessibility, MW-1.30-release-notes, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo created T173608: Add missing accessibility features to RCFilters.
Aug 18 2017, 11:03 PM · OOjs-UI (OOjs-UI-0.22.5), Accessibility, MW-1.30-release-notes, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo moved T166908: ChangesListSpecialPage backend: Respect saved query if no parameters from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 18 2017, 10:25 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Aug 17 2017

Mooeypoo moved T173303: Can't change number of results selector after you click trashcan from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 17 2017, 11:23 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo claimed T173303: Can't change number of results selector after you click trashcan.
Aug 17 2017, 6:30 PM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo created T173523: If there is a default saved query, load it in the backend.
Aug 17 2017, 5:38 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Aug 15 2017

Mooeypoo moved T172635: [wmf.12] Namespace exclusion not saved from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 15 2017, 6:02 AM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Aug 3 2017

Mooeypoo claimed T172427: [betalabs-regression] The names of Saved filters are not displayed.
Aug 3 2017, 7:53 PM · MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Patch-For-Review, Regression, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)

Aug 2 2017

Mooeypoo added a comment to T172031: Small language tweak in 'Changes to show' menu.

Is this ready? Sounds like it depends on the pagination patch first?

Aug 2 2017, 11:50 PM · Easy, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MediaWiki-Watchlist
Mooeypoo moved T166919: Put community-defined 'related links' into a collapsible panel from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 2 2017, 11:26 PM · MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T172237: [betalabs-regression] 'Other review tools' arrow placed too low.
Aug 2 2017, 11:26 PM · Patch-For-Review, Regression, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Mooeypoo moved T172026: [wmf.11] "Number of edits to show in recent changes ..." form accepts invalid numbers from QA Review to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 2 2017, 11:12 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo added a comment to T172026: [wmf.11] "Number of edits to show in recent changes ..." form accepts invalid numbers.

Fixed the minimum cap to 0 rather than 1, since the backend seems to do that for us too, and we should be consistent even if it is stupid.
(We should fix this in the backend, but that will change current behavior. @Catrope?)

Aug 2 2017, 11:12 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo added a comment to T166919: Put community-defined 'related links' into a collapsible panel.

In this particular case, I wonder if it makes sense to move the focus to the expanded elements. That is, clicking to expand moves the focus to the first link there (and as a side effect removes it from the button). @Volker_E
may know better if this is a legitimate approach or goes against the accessibility guidelines.

Aug 2 2017, 5:14 PM · MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T172156: Make limit sticky adhere to preference limit value from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 2 2017, 5:09 PM · Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo moved T168513: Enable 'Group results by page' preference on the RC page itself from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 2 2017, 5:09 PM · MW-1.30-release-notes, Patch-For-Review, User-notice-collaboration, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T169063: Make saved filters title more prominent when applied from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 2 2017, 5:09 PM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T171387: Recent change date range popup usability issues.

#1 and #3 are already fixed. #2 might not be that relevant since we've added 'hours' vs 'days' to one popup, and 'group by results' to the second, so since both have more than one picker, I don't think that a dropdown widget will work.

Aug 2 2017, 9:07 AM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo updated subscribers of T172237: [betalabs-regression] 'Other review tools' arrow placed too low.

This is a simple frameless button. @Volker_E looks like a regression in ooui's frameless buttons with indicators?

Aug 2 2017, 8:59 AM · Patch-For-Review, Regression, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Mooeypoo added a comment to T172250: Reconsider the blue border for buttons themed like links on focus/click.

Frameless buttons, in general, are supposed to be frameless, and they're usually inside other elements that don't take into account the "box" that is around them. The frame that appears on focus looks weird and abrupt on these types of buttons, especially when they're in the middle of some other box, which these type of buttons usually are.

Aug 2 2017, 8:55 AM · OOjs-UI
Mooeypoo updated subscribers of T166919: Put community-defined 'related links' into a collapsible panel.

@Trizek-WMF the blue border appears in some other cases of UI elements (i.e. Legend expand link).

Well, it is still disturbing. :/

The arrow is misaligned this morning on Beta wiki:

Aug 2 2017, 8:46 AM · MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Aug 1 2017

Mooeypoo claimed T172138: Don't fetch results unnecessarily when actions don't warrant it.
Aug 1 2017, 11:17 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters, Edit-Review-Improvements-RC-Page
Mooeypoo added a comment to T171894: Tweak Advanced Filters navigation UI during the interim period of 2 Advanced Filters only.

@Mooeypoo, did you do just the Interim? Or is the rest of it ready to go as soon as the filters are ready (and should we make a separate task for the final state stuff?)

Aug 1 2017, 10:38 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T171894: Tweak Advanced Filters navigation UI during the interim period of 2 Advanced Filters only from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 1 2017, 10:11 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T168225: [minor] Trim leading/trailing white spaces when searching for RC filters, Namespaces, Tags and Main menus from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 1 2017, 9:55 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo added a comment to T168225: [minor] Trim leading/trailing white spaces when searching for RC filters, Namespaces, Tags and Main menus.

I couldn't reproduce #1 and #3 in that list of problems (whitepsace works for me, and tags work) but I did fix #2 (whitespace between the 'trigger' and the text)

Aug 1 2017, 9:55 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo moved T170651: Scroll back to top when users click buttons at bottom of the main filter panel to switch to an Advanced panel from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.

It should be doing that for most cases because switching views also focuses the input -- but I made sure it does it on all cases as well.

Aug 1 2017, 9:50 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T171202: 'Display options' from Recent changes User preferences are not displayed with 'Time Period Selector' and 'Number of Changes Selector' from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.

This should be fixed; see T172156: Make limit sticky adhere to preference limit value

Aug 1 2017, 9:21 PM · Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo claimed T172156: Make limit sticky adhere to preference limit value.
Aug 1 2017, 9:05 PM · Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo added a comment to T172156: Make limit sticky adhere to preference limit value.

As per @jmatazzoni - making the 'limit' parameter non sticky for now.

Aug 1 2017, 9:05 PM · Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo added a comment to T171047: [[MediaWiki:Rcfilters-limit-shownum]] needs PLURAL support.

I wouldn't say it's embarrassing, since the variable is sent in and there's no real use case to pluralize it in English -- but I did add that into the copy so TranslateWiki can verify that languages that require these are implementing it correctly.

Aug 1 2017, 7:44 PM · MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page, Edit-Review-Improvements-Integrated-Filters, I18n
Mooeypoo moved T168513: Enable 'Group results by page' preference on the RC page itself from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Aug 1 2017, 2:19 AM · MW-1.30-release-notes, Patch-For-Review, User-notice-collaboration, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Jul 31 2017

Mooeypoo claimed T172026: [wmf.11] "Number of edits to show in recent changes ..." form accepts invalid numbers.
Jul 31 2017, 11:37 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo added a comment to T172156: Make limit sticky adhere to preference limit value.

In my opinion, #1 is the least confusing (though I am still very much meh about the fact the preference pretends to only apply to RC while it actually applies to everything) and also the quickest to implement.
I added a proposed solution above.

Jul 31 2017, 11:11 PM · Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo added a comment to T171202: 'Display options' from Recent changes User preferences are not displayed with 'Time Period Selector' and 'Number of Changes Selector'.

This is an annoying "feature" of the fact that the original preference updates everything that has lists of pages in it even though it claims to only update RecentChanges.

Jul 31 2017, 11:09 PM · Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo created T172156: Make limit sticky adhere to preference limit value.
Jul 31 2017, 10:58 PM · Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)