Mooeypoo (Moriel Schottlender)
Software Engineer, Editing Team

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Nov 18 2014, 11:57 PM (183 w, 2 d)
Availability
Available
IRC Nick
mooeypoo
LDAP User
Mooeypoo
MediaWiki User
Mooeypoo

Recent Activity

Today

Mooeypoo added a comment to T190714: GSoC proposal: Add 'Category' search filter to Recent Changes Filters.

Note another relevant task (a child of T163433) that we will also implement as an entry point to Category search: T195481: Create entry points for the category filters
This is in addition to typing the trigger '/' in the filter menu.

Fri, May 25, 7:58 AM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, Google-Summer-of-Code (2018)

Yesterday

Mooeypoo added a comment to T178387: Standardise vertical option/button group popup widgets.

In a conversation, @Pginer-WMF and myself tried to find a balance when to use a callout triangle. Our proposal:
Whenever a popup replaces a dialog, it should have a callout triangle. All of the above showed examples are on the menu side, so shouldn't feature a triangle.

Thu, May 24, 2:44 PM · Design, Patch-For-Review, UI-Standardization-Kanban, UI-Standardization, OOUI
Mooeypoo added a comment to T193389: Tab-key should select first entry in autosuggest dropdown.

@Mooeypoo I've mentioned the corresponding task T183299 above, in my understanding WMDE team is taking on the work (which can be oriented on similar ones already linked there) and will reach out to us if they run into problems. Everybody fine with that?

Thu, May 24, 8:37 AM · Accessibility, TCB-Team, Advanced-Search

Wed, May 23

Mooeypoo added a comment to T193389: Tab-key should select first entry in autosuggest dropdown.

I believe there's work to migrate category select (mw.widget) to TagMultiselectWidget... @Volker_E ? Any ideas if that's going on?

Wed, May 23, 4:44 PM · Accessibility, TCB-Team, Advanced-Search
Mooeypoo added a comment to T172232: Add navigation UI to access Categories and/or User filters.

The MVP will definitely just use another button in the row (no dropdown menu) so we can take a look at that and see if we want to iterate. The initial implementation will not include a dropdown menu, even just for practical reasons.

Wed, May 23, 4:09 PM · User-notice, Accessibility, Collaboration-Team-Triage, Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T178387: Standardise vertical option/button group popup widgets.

See the above patch to Echo. $( '<a>' ).attr( 'href', '...' ) can be passed to $element in the config, giving you right/middle click functionality, and normal selects can be handled with location.href. This could be packaged into a LinkMenuOptionWidget, and handled upstream. The CX user menu does something similar.

Wed, May 23, 4:06 PM · Design, Patch-For-Review, UI-Standardization-Kanban, UI-Standardization, OOUI
Mooeypoo added a comment to T190714: GSoC proposal: Add 'Category' search filter to Recent Changes Filters.

It was before, it was changed to the Category filter task now.

Wed, May 23, 3:50 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, Google-Summer-of-Code (2018)
Mooeypoo added a comment to T192303: Advanced Search & Timeless: General.

This is great, thanks!

Wed, May 23, 9:09 AM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), OOUI, User-aniansson, Patch-For-Review, WMDE-FUN-Sprint-2018-05-02, Timeless, TCB-Team, Advanced-Search

Tue, May 22

Mooeypoo added a comment to T178387: Standardise vertical option/button group popup widgets.

That ties into having, in general, a non-disappearing "menu" behavior like a better implemented OO.ui.SelectWidget

I think OutlineSelectWidget / OutlineOptionWidget, although named as if it can only be used in a BookletLayout is actually very suitable for these static list scenarios.

We may want to create a parent classes that have a more generic names, and removes some of the methods only called by OutlineWidget (e.g. move/remove), but for now it should be perfectly usable.

Tue, May 22, 10:20 AM · Design, Patch-For-Review, UI-Standardization-Kanban, UI-Standardization, OOUI
Mooeypoo added a comment to T178387: Standardise vertical option/button group popup widgets.

I'm thinking this could be done with some small changes the DropdownWidget, such as making the handle frameless, and not changing the label when an item is selected.

Tue, May 22, 9:50 AM · Design, Patch-For-Review, UI-Standardization-Kanban, UI-Standardization, OOUI
Mooeypoo added a comment to T178387: Standardise vertical option/button group popup widgets.

To add to the list, we have this also in RCFilters:


(Though to be fair, we had to extend the functionality there a bit to have sub-menus and to have an "edit" capability, but the base is still a vertical group of buttons)

Tue, May 22, 9:47 AM · Design, Patch-For-Review, UI-Standardization-Kanban, UI-Standardization, OOUI

Sun, May 20

Mooeypoo committed rEASR1495cde210b6: [wip^inf] PHP'ify AdvancesSearch (authored by Mooeypoo).
[wip^inf] PHP'ify AdvancesSearch
Sun, May 20, 7:40 PM

Sat, May 19

Jayprakash12345 awarded T194788: An introduction to working with OOUI (Wikimedia Hackathon 2018) a Love token.
Sat, May 19, 5:18 PM · Wikimedia-Hackathon-2018

Tue, May 15

Mooeypoo updated the task description for T194788: An introduction to working with OOUI (Wikimedia Hackathon 2018).
Tue, May 15, 7:03 PM · Wikimedia-Hackathon-2018
Mooeypoo created T194788: An introduction to working with OOUI (Wikimedia Hackathon 2018).
Tue, May 15, 6:44 PM · Wikimedia-Hackathon-2018
Mooeypoo added a comment to T56203: Core-ify the CleanChanges extension's intent (to filter and declutter RecentChanges).

Yeah, please do not implement user filter. In the current GSoC project that is working on this, we pivoted to Categories after discussions with the Anti Harassment team and product managers.

Tue, May 15, 6:06 PM · Wikimedia-Hackathon-2018, MediaWiki-extensions-CleanChanges, User-Nikerabbit, Design, MediaWiki-Recent-changes
Mooeypoo added a comment to T193826: Organise module files in directories based on their module name.

@Krinkle all of this is great work, thanks for leading it. I wanted to help with rcfilters, but if I go by the standard you put up, it seems it's already organized into its own folder anyways. We already organized the files inside based on logical structure (dm/ui/styles etc) so I'm trying to see if I'm missing something. I mainly ask since it's in the TODO list in the description, so I want to verify in case you want to rearrange something or if they're "passing" by default...

Tue, May 15, 5:16 AM · Patch-For-Review, Front-end-Standards-Group, Performance-Team, MediaWiki-ResourceLoader
Mooeypoo added a comment to T153011: Special:Notifications is too slow to open.

Well, running with "debug=true" makes the thing that loads slightly slowly

  • the filter thing on top of "related changes" -- load incredibly slowly; without debug=true, it takes 4-5 seconds to load; with debug=true, it takes more like 25 seconds. I am seeing several of these in the Firefox debugger
Tue, May 15, 4:05 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice-collaboration, Notifications

Mon, May 14

Mooeypoo added a comment to T192251: Mapframes with a width of 100% fail to display on the mobile site unless "frameless" is used.

I can't reproduce it in master, I don't have display:flex applying to this class. @Catrope do you know where is this coming from?

Mon, May 14, 11:58 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps, Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps)

Sat, May 12

Mooeypoo added a comment to T194228: Mapframe: Leaflet.Draw action buttons are unreadable.

The position of the original leaflet icons isn't correct (they are too far right). Is there a task for it?

Sat, May 12, 1:54 AM · MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), Discovery, Maps, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter)

Fri, May 11

Mooeypoo moved T193428: [wmf.1] Horizontal scrolling on full-map view panel from QA Review to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Fri, May 11, 7:49 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review, Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps

Thu, May 10

Mooeypoo added a comment to T193428: [wmf.1] Horizontal scrolling on full-map view panel.

@Mooeypoo
However, when clicking on "View more", the horizontal scrolling appears. I vaguely remember that it's extremely difficult to disable horizontal scrolling if a vertical scrolling is in place, so maybe we should be fine as it is?

Thu, May 10, 2:14 AM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review, Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps

Wed, May 9

Mooeypoo added a comment to T112948: All map location names should be in the user's language.

@Ghuron use nolabels=1 parameter.

Wed, May 9, 7:20 PM · Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps (Map-Styles), I18n
Mooeypoo added a comment to T192701: Create an optimized language-fallback system for Maps internationalization based on investigations.

The important bit here, in my opinion, is that for these things we have to have some community agreement

Agree. It's also super hard to preemptively ask communites what they would prefer. Posting something to every Village Pump would give us far less feedback than we'd desire.

I'm not saying that's what you're asking here @MSchottlender-WMF, but just a truism as I think about this. :)

I tried to add clear documentation on how community members can request a change to the fallback chain. This would, presumably, also include requests to not fall back to English. I think this would suffice in most cases. If/When a community discovers a fallback they do not want, they can build consensus to change, and file a task for an update to the list. Does that sound agreeable?

https://www.mediawiki.org/wiki/Help:Extension:Kartographer#Map_language_fallbacks

Wed, May 9, 7:06 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Mooeypoo updated subscribers of T194228: Mapframe: Leaflet.Draw action buttons are unreadable.

This color scheme was approved (and guided by) @Volker_E

Wed, May 9, 12:19 AM · MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), Discovery, Maps, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo moved T194228: Mapframe: Leaflet.Draw action buttons are unreadable from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Wed, May 9, 12:18 AM · MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), Discovery, Maps, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo created T194228: Mapframe: Leaflet.Draw action buttons are unreadable.
Wed, May 9, 12:18 AM · MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), Discovery, Maps, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter)

Tue, May 8

Mooeypoo claimed T188024: mapframe: Labels/menu for polyline/polygon options need improvements.

Helpfully, these are messages the code creates automatically, but that don't have actual text.

Tue, May 8, 11:58 PM · MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), Patch-For-Review, Discovery, Maps, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps)
Mooeypoo claimed T193428: [wmf.1] Horizontal scrolling on full-map view panel.
Tue, May 8, 10:25 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review, Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps
Mooeypoo added a comment to T193428: [wmf.1] Horizontal scrolling on full-map view panel.

eek; it was a combination of an older condition with the padding/placements that the new widgets used.

Tue, May 8, 10:24 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review, Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps
Mooeypoo added a comment to T155290: Add a data-page-only wiki markup header to datasets.

I really need a way to add category to json pages.

Tue, May 8, 2:26 AM · Maps, Discovery, Commons-Datasets
Mooeypoo updated subscribers of T187959: Create error message to alert users that they have gone beyond 99.

This is actually not straight forward at all. It's not just counting how many markers there are, but specifically how many numbered counters there are. If we just count markers, then there are iconed markers who shouldn't be a problem at all. The issue is when the numbered ones are over 99 and start displaying numbers that don't fit the marker area.

Tue, May 8, 12:12 AM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Maps (Kartographer)

Mon, May 7

Mooeypoo awarded T194069: Latitude and longitude are reversed a Love token.
Mon, May 7, 8:39 PM · MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), Patch-For-Review, Maps, Discovery

Sun, May 6

Mooeypoo updated subscribers of T192701: Create an optimized language-fallback system for Maps internationalization based on investigations.
(1) https://github.com/kartotherian/babel/blob/master/lib/fallbacks.json file is limited in defining fallbacks for some common language, e.g. no fallbacks for Russian, Ukranian, Greek, Belorussian, Bahasa (Indonesian), Hebrew etc. English is not a fallback for any language.   It results in displaying local names most of the time.
Sun, May 6, 7:16 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Mooeypoo added a comment to T192701: Create an optimized language-fallback system for Maps internationalization based on investigations.

I think x-local and mul are less straight forward for users... is it crucial to try and change it?

I don't think it is worth changing it now. My advice would be to consider carefully in the future before introducing usages of values which do not follow the language code and language tag standards.

Sun, May 6, 7:08 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps

Fri, May 4

Mooeypoo added a comment to T193826: Organise module files in directories based on their module name.

The idea sounds great, I am just confused about what it actually means; what conventions are we going for?

Fri, May 4, 4:58 AM · Patch-For-Review, Front-end-Standards-Group, Performance-Team, MediaWiki-ResourceLoader
Mooeypoo added a comment to T192701: Create an optimized language-fallback system for Maps internationalization based on investigations.

Adding lang="local"will force the system to ignore any requested language

Did you consider using a value that conforms to the standard mechanism to create private use language codes, such as x-local or perhaps even mul?

Fri, May 4, 12:30 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps

Wed, May 2

Mooeypoo added a comment to T193020: Change RTL LiveUpdates icon.

Hi, @Mooeypoo. If so, I suggest a second options, so the best can win. The icon will remain the same, but it will located at the left of the button, to look natural. I do not know which one is better.

Wed, May 2, 2:44 AM · User-notice-collaboration, Easy, RTL, I18n, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage
Mooeypoo updated subscribers of T193020: Change RTL LiveUpdates icon.

The play icon is usually not reversed for RTL languages, as @Mooeypoo says.

But this does make me think:

  • Why is this the icon in the first place? It has the element of movement and stopping, but it's not media. Can it be some other icon?
Wed, May 2, 2:34 AM · User-notice-collaboration, Easy, RTL, I18n, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage
Mooeypoo claimed T193571: TagMultiselectWidget clearItems() doesn't work properly when the widget is disabled.

I'm replacing the concept of setDisabled() on an item with a setStatic() on an item; this will (a) prevent the bad behavior when the entire widget is disabled, and (b) properly separate the actual meaning of wanting to specifically "disable" a single item inside the widget -- which, really, means, it's not disabled, it's just "always included" and is static.
This also means that T181578: Backspace allows editing/deleting disabled items in TagMultiSelectWidget will be changed; )

Wed, May 2, 1:56 AM · Patch-For-Review, OOUI

Tue, May 1

Mooeypoo added a comment to T193571: TagMultiselectWidget clearItems() doesn't work properly when the widget is disabled.

Yowza, nice catch, thank you!

Tue, May 1, 10:25 PM · Patch-For-Review, OOUI
Mooeypoo added a comment to T193020: Change RTL LiveUpdates icon.

Following up, here's a screenshot from a Hebrew news site that uses video. See the "Play" buttons are all in LTR:

Tue, May 1, 7:06 PM · User-notice-collaboration, Easy, RTL, I18n, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage
Mooeypoo updated subscribers of T193020: Change RTL LiveUpdates icon.

Ah, this is a fun one. I'll poke @Amire80 for this too, since we've been having this similar discussion several times, but since this was reported by @IKhitron who's a Hebrew speaker, I want to see other opinions here.

Tue, May 1, 6:53 PM · User-notice-collaboration, Easy, RTL, I18n, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage

Mon, Apr 30

Mooeypoo moved T190714: GSoC proposal: Add 'Category' search filter to Recent Changes Filters from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Mon, Apr 30, 4:48 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, Google-Summer-of-Code (2018)
Mooeypoo edited projects for T190714: GSoC proposal: Add 'Category' search filter to Recent Changes Filters, added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Mon, Apr 30, 4:47 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, Google-Summer-of-Code (2018)

Sat, Apr 28

Mooeypoo added a comment to T192662: name:<local name code> is not always available in OSM.

Joe asked for my comments here, although I'm a bit lost, because I'm really not an OSM expert. The big thing that I fail to understand is how can it happen that some labels are not shown at all. In practice, this is indeed a regression, but isn't there supposed to be some kind of a fallback?

Sat, Apr 28, 6:32 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Maps
Mooeypoo added a comment to T156808: Back-end infrastructure for timed notifications in Echo.

It's not locked; The code is available, we need to review, fix it, and merge. Is anyone actively working on T189391: New block option: Notify me when this block is about to expire or has expired ?

Sat, Apr 28, 6:29 AM · Schema-change, Notifications, Collaboration-Team-Triage

Fri, Apr 27

Mooeypoo added a comment to T163135: MenuTagMultiselectWidget with outline input doesn't open menu after first selection.

@Mooeypoo I agree that option #2 doesn't sound convincing from an experience perspective.
But there are also some issues with #1:

  • How do people realize that it's a MultiselectWidget when there are no items chosen yet? They come across a thing that looks like an input field with an autocomplete menu (or similar). So they choose one and suddenly the dropdown remains open. How does one close it?

The second they choose an item and the menu doesn't close, the user understands the widget allows for more items.

Fri, Apr 27, 4:16 AM · OOUI

Wed, Apr 25

Mooeypoo added a comment to T192451: allowEditTags doesn't work MenuTagMultiselect.

@Daimona can you specify briefly the behavior you described in the gerrit discussion, so @Volker_E can pitch in about maybe assessing a good general UX for the widget in these cases?

Wed, Apr 25, 7:34 PM · Patch-For-Review, OOUI
Mooeypoo added a comment to T192451: allowEditTags doesn't work MenuTagMultiselect.

After a bit of discussion on the ticket, I've merged the code. It's a good fix for the current completely broken behavior.

Wed, Apr 25, 7:30 PM · Patch-For-Review, OOUI

Apr 25 2018

Mooeypoo added a comment to T163135: MenuTagMultiselectWidget with outline input doesn't open menu after first selection.

We should definitely fix it. The menu hides itself after choose, and only reopens on focus - but in these cases, the focus is ALREADY on the input, so it doesn't reopen. We need to fix it.

Apr 25 2018, 1:03 AM · OOUI

Apr 24 2018

Mooeypoo claimed T192968: Give maplink maps the same internationalization features as mapframe maps.
Apr 24 2018, 10:30 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), I18n, Patch-For-Review, Maps-Sprint, Discovery, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Mooeypoo updated the task description for T192701: Create an optimized language-fallback system for Maps internationalization based on investigations.
Apr 24 2018, 8:39 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Mooeypoo updated the task description for T192701: Create an optimized language-fallback system for Maps internationalization based on investigations.
Apr 24 2018, 8:13 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps

Apr 23 2018

Mooeypoo closed T192781: Distorted lake shapes on devel server as Invalid.
Apr 23 2018, 9:49 PM · Maps (Map-Styles), Discovery

Apr 20 2018

Mooeypoo added a comment to T112948: All map location names should be in the user's language.

Aramaic is probably my fault; there are several options for Aramaic, I went with Imperial Aramaic, it might not be correct?

Apr 20 2018, 5:24 PM · Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps (Map-Styles), I18n

Apr 18 2018

Mooeypoo added a comment to T187919: Open enlarged mapframe map with 'Map Details' panel closed instead of open (and rename it).

That means that the hover effect is built-in OOUI for buttons, which means -- none. @Pginer-WMF if we put hover effect on these buttons, that's overriding the styleguide. @Esanders Also made a good point about OOUI's hover color being grey, not blue. What do you want done here?

The general idea is to have a list of clickable elements, which I assumed we had a standard component for, but I don't see an example in the demos. The hover color to use on lists is still an open issue, so let's use the standard to make sure it keeps aligned if it changes in the future.

Apr 18 2018, 9:55 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps

Apr 17 2018

Mooeypoo added a comment to T112948: All map location names should be in the user's language.

@Amire80, thanks for checking these. It sounds like there is an issue with fonts we need to go into fully. Does this need to be a new subtask? If so, would you please write it up, since you have a good handle on the issues. Please tag it with "Collaboration-Feature-Rollouts (Collaboration-Maps)" and "Collaboration-Team-Triage (Collab-Team-This-Quarter)" Thanks!

Apr 17 2018, 10:01 PM · Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps (Map-Styles), I18n

Apr 15 2018

Mooeypoo added a comment to T187919: Open enlarged mapframe map with 'Map Details' panel closed instead of open (and rename it).

You could look into subclassing SelectWidget.

Apr 15 2018, 8:29 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps

Apr 14 2018

Mooeypoo added a comment to T112948: All map location names should be in the user's language.

Not sure if this was discussed before. Many labels in OSM are encoded with an extra param, e.g. Latn (75k), _rm (250k+), _kana, _pinyin, hira, and other. Search for "name:" for the full list. How should these be handled? I think babel used to have some support for it, but it might have been recently removed.

Apr 14 2018, 11:00 PM · Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps (Map-Styles), I18n
Mooeypoo added a comment to T112948: All map location names should be in the user's language.

Question: Is there a reason "round abouts" and "bus-stopps" not transliterated (e.g. in Israel)?
https://maps-beta.wmflabs.org/?lang=fr#19/31.52647/394.60170

Apr 14 2018, 10:44 PM · Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps (Map-Styles), I18n

Apr 13 2018

Mooeypoo added a comment to T187919: Open enlarged mapframe map with 'Map Details' panel closed instead of open (and rename it).

Based on comments on the patch, I reset the item list to be OOUI buttons so that they follow the accessibility requirements, and also that they work the same in Apex, which the previous <a> design didn't have.

Apr 13 2018, 11:21 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Mooeypoo moved T187919: Open enlarged mapframe map with 'Map Details' panel closed instead of open (and rename it) from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Apr 13 2018, 7:53 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Mooeypoo added a comment to T187919: Open enlarged mapframe map with 'Map Details' panel closed instead of open (and rename it).
  • Avoid the "View more" option when there are few options. If there are 7 or less options, all of them should be listed (without a "view more" button).
Apr 13 2018, 7:29 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Mooeypoo moved T187919: Open enlarged mapframe map with 'Map Details' panel closed instead of open (and rename it) from QA Review to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Pulling it back to 'in development' to work on the fixes with a followup commit.

Apr 13 2018, 6:45 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Mooeypoo closed T187288: maps.wikimedia.org copyright attribution should be translated, a subtask of T112948: All map location names should be in the user's language, as Declined.
Apr 13 2018, 5:50 PM · Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps (Map-Styles), I18n
Mooeypoo closed T187288: maps.wikimedia.org copyright attribution should be translated as Declined.
Apr 13 2018, 5:50 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps (Kartotherian)
Mooeypoo added a comment to T191582: Editing maps in VE - the marker area needs some adjustments.

Copying my notes from the patch, because there's still a small visual bug that cannot be fixed:

Apr 13 2018, 12:36 AM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), VisualEditor-ContentEditable, Maps, VisualEditor

Apr 12 2018

Mooeypoo claimed T191582: Editing maps in VE - the marker area needs some adjustments.
Apr 12 2018, 8:11 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), VisualEditor-ContentEditable, Maps, VisualEditor
Mooeypoo placed T187294: maps.wikimedia.org does not include Wikimedia maps terms of use link up for grabs.
Apr 12 2018, 7:37 PM · Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps (Kartotherian), WMF-Legal
Mooeypoo moved T187294: maps.wikimedia.org does not include Wikimedia maps terms of use link from Ready for Pickup to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Apr 12 2018, 7:21 PM · Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps (Kartotherian), WMF-Legal
Mooeypoo claimed T187294: maps.wikimedia.org does not include Wikimedia maps terms of use link.
Apr 12 2018, 7:21 PM · Patch-For-Review, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps (Kartotherian), WMF-Legal
Mooeypoo added a comment to T187919: Open enlarged mapframe map with 'Map Details' panel closed instead of open (and rename it).

I implemented the hover color in the current patch. I'll poke the team about reviewing it.

Apr 12 2018, 5:22 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Mooeypoo added a comment to T187919: Open enlarged mapframe map with 'Map Details' panel closed instead of open (and rename it).

@Mooeypoo, when and where will we be able to see this, please?

Apr 12 2018, 5:01 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps

Apr 11 2018

RandomDSdevel awarded T190718: Tag filters' titles and descriptions should be bidi isolated a Like token.
Apr 11 2018, 10:10 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), User-notice-collaboration, User-notice, I18n, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters

Apr 9 2018

Mooeypoo added a comment to T187919: Open enlarged mapframe map with 'Map Details' panel closed instead of open (and rename it).

@Pginer-WMF I've implemented the mockup to the best of my ability without the accurate distances. It looks fairly close to what you have.

Apr 9 2018, 7:31 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Mooeypoo moved T187919: Open enlarged mapframe map with 'Map Details' panel closed instead of open (and rename it) from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Apr 9 2018, 7:29 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps

Apr 6 2018

RandomDSdevel awarded T186277: Hide preference for 'Reload the watchlist automatically whenever a filter is changed' when New Filters are active a Cookie token.
Apr 6 2018, 7:47 PM · User-notice, User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-User-preferences, Edit-Review-Improvements-Integrated-Filters
RandomDSdevel awarded T183539: Notifications badge icon overlaps with other links a Haypence token.
Apr 6 2018, 7:44 PM · User-notice-collaboration, User-notice, MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications, CSS

Apr 5 2018

Mooeypoo added a comment to T190679: Make the layers panel useful for readers to explore the map content.

The main issue is that layers are configured per wiki, so the "base" state of the map is having no layers (like in mediawiki.org) and hence, no sidebar.
"Nearby articles" is also only working for English Wikivoyage for the moment. Making it work in other wikis is possible, but is not trivial.

Apr 5 2018, 10:27 PM · Collaboration-Team-Triage, Discovery, Maps

Apr 4 2018

Mooeypoo moved T183725: Update language used in MediaWiki:Flow-edit-header-submit and similar for "publish" wikis from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Apr 4 2018, 11:16 PM · User-notice-collaboration, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, MediaWiki-Internationalization
Mooeypoo added a comment to T183725: Update language used in MediaWiki:Flow-edit-header-submit and similar for "publish" wikis.

I updated the patch, it has conditional display between save and publish now.

Apr 4 2018, 11:15 PM · User-notice-collaboration, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, MediaWiki-Internationalization
Mooeypoo moved T141750: <maplink> and/or <mapframe>: clickable marker area too big from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Apr 4 2018, 9:29 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Maps (Kartographer)
Mooeypoo added a comment to T141750: <maplink> and/or <mapframe>: clickable marker area too big.

Several issues that need to be sorted here:

(1) The issue in the ticket was reported based on the dev tool Inspector displaying a large area around a marker - it's still in place (https://en.wikipedia.beta.wmflabs.org/wiki/Mavetuna - the map of Swiss):

Apr 4 2018, 8:06 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Maps (Kartographer)
Mooeypoo added a comment to T141750: <maplink> and/or <mapframe>: clickable marker area too big.

The clickable area is also too big here: https://en.wikivoyage.org/wiki/Kastellorizo#/map/0

Is it a difference between fullscreen and thumb?

Apr 4 2018, 4:28 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Maps (Kartographer)
Mooeypoo added a comment to T141750: <maplink> and/or <mapframe>: clickable marker area too big.

But in Elena's screenshots, it doesn't look like it's the fullscreen version, either.

Apr 4 2018, 4:23 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Maps (Kartographer)
Mooeypoo added a comment to T141750: <maplink> and/or <mapframe>: clickable marker area too big.

This is a really weird bug that seems to have different behaviors in different places.

Apr 4 2018, 1:55 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Maps (Kartographer)
Mooeypoo moved T187291: Maps: Remove Wikidata info from attribution overlay from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Apr 4 2018, 1:48 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps (Kartographer)
Mooeypoo added a comment to T187291: Maps: Remove Wikidata info from attribution overlay.

The above commit removes wikidata only, and leaves image attribution; if we want to remove the image attribution too, we could fix the commit or followup.

Apr 4 2018, 1:48 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps (Kartographer)
Mooeypoo added a comment to T187291: Maps: Remove Wikidata info from attribution overlay.

Looking at the code, we're also gathering attribution for "page" which are images from commons. I can't find an example live for this, so I'm going off what I see in code, and it's done exactly the same as the wikidata collection -- do we want to take those off too, or just the Wikidata links?

Apr 4 2018, 1:42 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps (Kartographer)
Mooeypoo moved T141750: <maplink> and/or <mapframe>: clickable marker area too big from QA Review to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Apr 4 2018, 12:56 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Maps (Kartographer)
Mooeypoo closed T188142: Create and run tests in Kartotherian repos as part of CI as Resolved.

Build passes; nothing to QA. Resolved.

Apr 4 2018, 12:54 PM · Discovery, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Mooeypoo moved T183725: Update language used in MediaWiki:Flow-edit-header-submit and similar for "publish" wikis from Needs Review to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Apr 4 2018, 12:47 PM · User-notice-collaboration, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, MediaWiki-Internationalization
Mooeypoo added a comment to T183725: Update language used in MediaWiki:Flow-edit-header-submit and similar for "publish" wikis.

The request in the ticket is to update language "for "publish" wikis", which would mean doubling up all your messages. I think this is the only solution that makes sense.

You may want to create the patch that adds the new messages and merge that first to give translators time to create the new messages.

Apr 4 2018, 12:41 PM · User-notice-collaboration, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, MediaWiki-Internationalization
Mooeypoo updated the task description for T190714: GSoC proposal: Add 'Category' search filter to Recent Changes Filters.
Apr 4 2018, 12:29 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, Google-Summer-of-Code (2018)

Apr 3 2018

Mooeypoo updated subscribers of T191366: [regression - wmf.28] The bookmark icon for Saved filters is missing.

@Volker_E .... could this have to do with the OOUI icon changes?

Apr 3 2018, 10:36 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, User-notice-collaboration, User-notice, UI-Standardization, Edit-Review-Improvements-Integrated-Filters, Regression, Collaboration-Team-Triage

Apr 2 2018

Mooeypoo added a comment to T187919: Open enlarged mapframe map with 'Map Details' panel closed instead of open (and rename it).

Is this ready to be worked on?

Apr 2 2018, 12:44 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Mooeypoo added a comment to T183725: Update language used in MediaWiki:Flow-edit-header-submit and similar for "publish" wikis.

Just to delve deeper on how to approach this; if we are going to have each of these messages (multiple messages with "save" that should say "publish") then the fix is getting a little more elaborate.

Apr 2 2018, 12:28 PM · User-notice-collaboration, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, MediaWiki-Internationalization
Mooeypoo added a comment to T183725: Update language used in MediaWiki:Flow-edit-header-submit and similar for "publish" wikis.

I just noticed the existence of this:
https://gerrit.wikimedia.org/r/#/c/306303/6/wmf-config/InitialiseSettings.php,unified

Apr 2 2018, 11:39 AM · User-notice-collaboration, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, MediaWiki-Internationalization
RandomDSdevel awarded T189428: Notifications: Preferences popup `z-index` issue a Haypence token.
Apr 2 2018, 1:04 AM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, CSS, Easy, Notifications