Page MenuHomePhabricator

Mooeypoo (Moriel Schottlender)
Tech Lead, CommTech and Anti Harassment Team

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 18 2014, 11:57 PM (247 w, 4 d)
Availability
Available
IRC Nick
mooeypoo
LDAP User
Mooeypoo
MediaWiki User
Mooeypoo [ Global Accounts ]

Recent Activity

Yesterday

Mooeypoo claimed T226772: Add "Guided Tour" Pop-Up (first time users) for Who Wrote That.

While doing some experimentation, I unfortunately discovered it's not as easy to get GuidedTour to activate from the injected script; the naming conventions and the fact that it supposed to run on all pages seem to be a bit more difficult for the extension to load itself with the gains of the cookie and toggling.

Sat, Aug 17, 2:46 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T207485: Enable page curation tools to be loaded on any page (optionally).
  1. "apihelp-pagetriageaction-param-pageid": "The article for which to perform action on."
    • Potentially change to: “Select this article”
  2. "apihelp-pagetriageaction-param-reviewed": "If set, specifies whether the article is reviewed."
    • Potentially change to: “Specify whether the article is reviewed”
  3. "apihelp-pagetriageaction-param-enqueue": "If set, the page will be added to PageTriage queue."
    • Potentially change to: “Page will be added to the PageTriage queue”
Sat, Aug 17, 12:37 AM · Patch-For-Review, Community-Tech (Kanban (Q1 2019-20)), PageCuration, Growth-Team

Fri, Aug 16

Mooeypoo moved T229551: Database-reports can't see packages in its virtualenv on the grid from Needs Review/Feedback to Done on the Community-Tech (Kanban (Q1 2019-20)) board.
Fri, Aug 16, 10:40 PM · Community-Tech (Kanban (Q1 2019-20)), Patch-For-Review, Tools, Toolforge
Mooeypoo moved T226771: Implement Information Bar for Who Wrote That from Needs Review/Feedback to QA on the Community-Tech (Kanban (Q1 2019-20)) board.

To QA, use the instructions on https://github.com/wikimedia/WhoWroteThat#testing-the-browser-extension

Fri, Aug 16, 10:40 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo moved T226761: Add Ability to Toggle on/off WhoWroteThat from Needs Review/Feedback to QA on the Community-Tech (Kanban (Q1 2019-20)) board.

To QA the browser extension, see the steps at https://github.com/wikimedia/WhoWroteThat#testing-the-browser-extension

Fri, Aug 16, 10:39 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Wed, Aug 14

Mooeypoo renamed T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets from Placeholder: Add Hook for PageTriage after specific actions taken, to allow access from gadgets to Add Hook for PageTriage after specific actions taken, to allow access from gadgets.
Wed, Aug 14, 10:01 PM · Community-Tech (Kanban (Q1 2019-20)), Growth-Team, PageCuration
Mooeypoo renamed T230455: Add Hook for PageTriage after specific actions taken, to allow access from gadgets from Placeholder: Add Hook for T207237 [more info added later] to Placeholder: Add Hook for PageTriage after specific actions taken, to allow access from gadgets.
Wed, Aug 14, 10:01 PM · Community-Tech (Kanban (Q1 2019-20)), Growth-Team, PageCuration

Fri, Aug 9

Mooeypoo added a comment to T189144: RTL support for Interaction Timeline.

Notes so far:

Fri, Aug 9, 4:47 AM · Anti-Harassment, InteractionTimeline

Thu, Aug 8

Mooeypoo claimed T227527: Implement build steps for WhoWroteThat as a gadget.

Done here: https://github.com/wikimedia/WhoWroteThat/pull/13

Thu, Aug 8, 9:39 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T189144: RTL support for Interaction Timeline.

Hmmm but I set up Hebrew as the interface language. Interesting. I'll give it another shot.

Thu, Aug 8, 6:06 PM · Anti-Harassment, InteractionTimeline
Mooeypoo added a comment to T189144: RTL support for Interaction Timeline.

First problem: I switched my Chrome language to Hebrew, and I see the site in English.

Thu, Aug 8, 6:45 AM · Anti-Harassment, InteractionTimeline
Mooeypoo claimed T189144: RTL support for Interaction Timeline.

Yup, although I might need that language picker ... ;)

Thu, Aug 8, 6:41 AM · Anti-Harassment, InteractionTimeline
Mooeypoo moved T226771: Implement Information Bar for Who Wrote That from In Development to Needs Review/Feedback on the Community-Tech (Kanban (Q1 2019-20)) board.
Thu, Aug 8, 6:00 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T226771: Implement Information Bar for Who Wrote That.
  • When WWT is activated, a blue information bar should appear at the top of the article.
  • The information bar should be displayed below the links ("Read," "Edit," "View History," "Article," or "Talk") and above the article title.
  • This is only working for Vector for the moment. We'll need to adjust it for monobook if we're interested in supporting it. @ifried
  • The information bar should not block any links on the page.
  • The whitespace dimensions at the top of the article should remain the same.
  • The information bar should be sticky.
  • The information bar should be implemented in such a way that it can adapt to different states. For example, if there is an API error, the bar may change (e.g. a different color). However, the actual handling of error behavior will be covered in a separate ticket.
  • The widget changes state with widget.setState( state ) where state can be pending, ready, and err.
Thu, Aug 8, 5:13 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo moved T207452: Flag talk page feedback in toolbar from Needs Review/Feedback to QA on the Community-Tech (Kanban (Q1 2019-20)) board.
Thu, Aug 8, 1:54 AM · Community-Tech (Kanban (Q1 2019-20)), PageCuration, Growth-Team

Wed, Aug 7

Mooeypoo claimed T226771: Implement Information Bar for Who Wrote That.
Wed, Aug 7, 9:08 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Tue, Aug 6

Mooeypoo moved T206096: Inconsistent handling of missing Required values in TemplateWizard from Needs Review/Feedback to QA on the Community-Tech (Kanban (Q1 2019-20)) board.
Tue, Aug 6, 8:45 PM · Community-Tech (Kanban (Q1 2019-20)), Outreachy (Round 17), MediaWiki-extensions-TemplateWizard

Mon, Aug 5

Mooeypoo added a comment to T226761: Add Ability to Toggle on/off WhoWroteThat.

This PR fixes the following:

Mon, Aug 5, 5:22 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo moved T226761: Add Ability to Toggle on/off WhoWroteThat from In Development to Needs Review/Feedback on the Community-Tech (Kanban (Q1 2019-20)) board.
Mon, Aug 5, 5:10 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Sun, Aug 4

Mooeypoo claimed T226761: Add Ability to Toggle on/off WhoWroteThat.

I have a PR for this here: https://github.com/wikimedia/WhoWroteThat/pull/16

Sun, Aug 4, 9:54 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Wed, Jul 31

Mooeypoo updated the task description for T226771: Implement Information Bar for Who Wrote That.
Wed, Jul 31, 8:48 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo updated the task description for T226771: Implement Information Bar for Who Wrote That.
Wed, Jul 31, 8:47 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo set the point value for T227174: Improve the consistency of block error notices to 8.
Wed, Jul 31, 5:48 PM · Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-User-management

Mon, Jul 29

Mooeypoo closed T226543: Create a minimal structure for WhoWroteThat browser extension as Resolved.
Mon, Jul 29, 5:09 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo moved T207452: Flag talk page feedback in toolbar from Needs Review/Feedback to In Development on the Community-Tech (Kanban (Q1 2019-20)) board.
Mon, Jul 29, 5:05 PM · Community-Tech (Kanban (Q1 2019-20)), PageCuration, Growth-Team
Mooeypoo updated the task description for T226543: Create a minimal structure for WhoWroteThat browser extension.
Mon, Jul 29, 5:04 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T226543: Create a minimal structure for WhoWroteThat browser extension.

\o/ Thank you @Samwilson !

Mon, Jul 29, 5:04 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Fri, Jul 26

Mooeypoo added a project to T200938: Special:CentralAuth should provide the same blocking information as Special:BlockList does: Core Platform Team.
Fri, Jul 26, 5:23 PM · Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-extensions-CentralAuth, Stewards-and-global-tools, MediaWiki-User-management
Mooeypoo created T229128: Bundle PageImages with MediaWiki.
Fri, Jul 26, 4:12 PM · MW-1.34-release, MediaWiki-Releasing, MediaWiki-Installer
Mooeypoo created T229127: Bundle TextExtracts with MediaWiki.
Fri, Jul 26, 4:09 PM · MW-1.34-release, MediaWiki-Releasing, MediaWiki-Installer

Wed, Jul 24

Mooeypoo updated the task description for T226543: Create a minimal structure for WhoWroteThat browser extension.
Wed, Jul 24, 6:38 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo updated the task description for T226543: Create a minimal structure for WhoWroteThat browser extension.
Wed, Jul 24, 5:31 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Krinkle awarded T228904: Clean up modules in PageTriage a Orange Medal token.
Wed, Jul 24, 5:28 PM · Performance-Team (Radar), Community-Tech (Kanban (Q1 2019-20))
Mooeypoo updated the task description for T228904: Clean up modules in PageTriage.
Wed, Jul 24, 5:23 PM · Performance-Team (Radar), Community-Tech (Kanban (Q1 2019-20))
Mooeypoo created T228904: Clean up modules in PageTriage.
Wed, Jul 24, 5:22 PM · Performance-Team (Radar), Community-Tech (Kanban (Q1 2019-20))
Mooeypoo claimed T226543: Create a minimal structure for WhoWroteThat browser extension.
Wed, Jul 24, 5:17 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Tue, Jul 23

Mooeypoo closed T227522: Implement build steps for using WhoWroteThat as injected script as Resolved.

Reviewed, tested. Resolving this ticket. Hopefully this makes this easier also for the sister-ticket T227527: Implement build steps for WhoWroteThat as a gadget

Tue, Jul 23, 3:00 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Mon, Jul 22

Mooeypoo moved T227522: Implement build steps for using WhoWroteThat as injected script from Ready to Needs Review/Feedback on the Community-Tech (Kanban (Q1 2019-20)) board.
Mon, Jul 22, 9:03 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo claimed T227522: Implement build steps for using WhoWroteThat as injected script.

I have a PR on the private repo (we need to move that repo under Wikimedia) but I want to make sure someone takes a look before it's merged: https://github.com/mooeypoo/WhoWroteThat/pull/1

Mon, Jul 22, 9:02 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo moved T207442: Send Message to creator without needing to 'unreview'/'re-review' the article from QA to Product sign-off on the Community-Tech (Kanban (Q1 2019-20)) board.
Mon, Jul 22, 5:03 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Community-Tech (Kanban (Q1 2019-20)), Community-Tech-Sprint, PageCuration, Growth-Team

Jul 19 2019

Mooeypoo added a comment to T226758: Design: Determine WhoColor API Error Behavior.

These look great!

Jul 19 2019, 12:16 AM · Community-Tech, Who-Wrote-That

Jul 17 2019

Mooeypoo updated the task description for T227160: Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites.
Jul 17 2019, 10:13 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Jul 15 2019

Mooeypoo added a comment to T184144: Investigation: Who Wrote That revision search tool.

@ifried Hey Ifried, nice to meet you and good to hear :)

What concerns would you have about using the WhoColor API to retrieve data from older versions of a page?

None, you can call any revision of an article and get back the tokens at the time that were in the revision and their history.
The only "weird" but intended behavior here is that the lists of in and outs will also "look into the future" for tokens in older revisions (see example here for token_id: 31614 , but you can simply ignore those with higher revids than the oldid you have retrieved.

Jul 15 2019, 9:38 PM · Who-Wrote-That, Community-Tech

Jul 11 2019

Mooeypoo added a comment to T224958: Instrument Special:Mute.

@Niharika , correct me if I'm wrong, but for option 2 we actually don't need to retain the User ID; The entire row is a picture of what random-user did in the form, so the user id or username itself doesn't matter. Is that right?

Jul 11 2019, 10:15 PM · Analytics, Patch-For-Review, Anti-Harassment (The Letter Song)

Jul 9 2019

Mooeypoo added a comment to T225169: [4 hours] Investigate whether it's efficient to order by tag value (DBA input requested).

Thanks, @Marostegui -- I edited my comment to reflect the new estimate.

Jul 9 2019, 4:56 PM · Community-Tech (Kanban (Q1 2019-20)), Spike, Growth-Team, PageCuration

Jul 8 2019

Mooeypoo moved T227527: Implement build steps for WhoWroteThat as a gadget from Untriaged to To be estimated/discussed on the Community-Tech board.
Jul 8 2019, 9:55 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a project to T227527: Implement build steps for WhoWroteThat as a gadget: Community-Tech.
Jul 8 2019, 9:55 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo created T227527: Implement build steps for WhoWroteThat as a gadget.
Jul 8 2019, 9:55 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo moved T227522: Implement build steps for using WhoWroteThat as injected script from Untriaged to To be estimated/discussed on the Community-Tech board.
Jul 8 2019, 8:30 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo closed T227160: Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites as Resolved.
Jul 8 2019, 8:29 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T227160: Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites.

Created an actionable ticket T227522: Implement build steps for using WhoWroteThat as injected script

Jul 8 2019, 8:29 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo created T227522: Implement build steps for using WhoWroteThat as injected script.
Jul 8 2019, 8:28 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T225169: [4 hours] Investigate whether it's efficient to order by tag value (DBA input requested).

We've discussed this (and the wider implication of the entire feature) in the Engineering meeting, and agreed it's time to revisit whether the product is worth the significant effort here. We tried to estimate, generally, how long things may take.

Jul 8 2019, 5:28 PM · Community-Tech (Kanban (Q1 2019-20)), Spike, Growth-Team, PageCuration

Jul 5 2019

Mooeypoo added a comment to T227160: Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites.

OK, it looks like there's agreement that the strategy is sound and acceptable. In that case, I am going to summarize it with an action plan for the team. Please see if this makes sense or if I missed anything:

Jul 5 2019, 9:33 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T227160: Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites.

Alright, now it's working:

Jul 5 2019, 9:25 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T227160: Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites.

I don't know much about how browser extensions work behind the scenes, but I believe the following are mutually exclusive:

  • JavaScript code is actually executed in the context of a browser tab.
  • JavaScript code has access to a library automatically loaded by the browser (in your case, a copy of jquery.js).
Jul 5 2019, 9:02 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T227160: Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites.

I might be missing something here, but this didn't work for me. The browser extension itself requires jQuery, so I can immediately use $( document ).ready() in the contentScript just for that. So, I tested this:

Jul 5 2019, 8:48 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T227160: Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites.

Yes, you're right, you can't use mw.loader.using(). You can use mw.loader.load() though.

Both are defined asynchronously and both may be absent initially. mw.loader.load is part of the startup module and while that is loaded from an async script tag, it is guaranteed to be executed at domComplete/window-onload because it is a sub resource (just like images, stylesheets and synchronous scripts). However, domInteractive/dom-ready does not guarantee it.
The mw.loader.using method is ensured to be available for any ResourceLoader module is executed, but actually ships as part of an implicit default dependency for all modules (called "mediawiki.base"). And downloads in parallel to regular modules. This is an implementation detail, but it means that if you're observing from the outside, "window-onload" will not guarantee presence of mw.loader.using.
But... none of this matters. This use case is exactly why RLQ exists. Use the following:

myStuff.load = function () {
 /* This can use mw.loader.using(), and jQuery etc. */
};
var q = window.RLQ || ( window.RLQ = [] );
q.push( [ 'jquery', 'mediawiki.base' ], myStuff.load );

Then everything will work as expected. No timeouts, dom-readies, custom jquery, or other things required.

Jul 5 2019, 8:34 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T227160: Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites.

I have an alternative idea building off of yours that will allow us to lazy-load our dependencies when we need them, rather than immediately.

Jul 5 2019, 8:30 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T227160: Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites.

Wait, so, if we go with mw.loader.load on a module we implemented *and* defined as having an OOUI dependency, then, technically, mw.loader.load() is sufficient. We won't need to wait for dependencies and THEN run the code -- the definition itself does it for us.

Jul 5 2019, 8:09 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T227160: Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites.

Ooh! This is interesting. My only question, though, is that wouldn't we be facing the same problem of running mw.loader.using( 'whowrotethat' ) too early? The main issue we're running into is that the pageScript that's injected is in itself running to early, so even if we use the available infrastructure to create a module, wouldn't we still have to wait for mw.loader.using to be available in order to instigate the actual loading of the script?

Jul 5 2019, 8:05 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Jul 4 2019

Mooeypoo moved T227160: Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites from Ready to Needs Review/Feedback on the Community-Tech (Kanban (Q1 2019-20)) board.
Jul 4 2019, 2:26 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo claimed T227160: Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites.
Jul 4 2019, 2:25 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo updated subscribers of T227160: Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites.

Some preliminary investigation on my end shows one direction we can go with. Chrome extensions are sandboxed; that is, the extension code itself cannot communicate with code inside the tab, and whatever is inside the DOM cannot communicate with the Chrome browser API. This is done for security reasons, and is understandable.

Jul 4 2019, 1:01 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Jul 3 2019

Mooeypoo added a comment to T226774: Design: Determine 'Guided Tour' Requirements.

Thanks @Mooeypoo! Quick question, is it possible to have markup inside OOUI popups like headings and stuff, as is the case with GuidedTours?

Jul 3 2019, 3:42 AM · Who-Wrote-That
Mooeypoo created T227160: Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites.
Jul 3 2019, 3:40 AM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That
Mooeypoo added a comment to T226774: Design: Determine 'Guided Tour' Requirements.

Honestly, I'm hoping we can do it so we can also use ooui pop-ups in general. From my experience, they're vastly superior to anything else out there when it comes to proper positioning within cross directional text with cross directional interface, which is pretty necessary for wikis.

Jul 3 2019, 3:28 AM · Who-Wrote-That
Mooeypoo added a comment to T226774: Design: Determine 'Guided Tour' Requirements.

Just to be clear before anyone jumps ahead of the train (of thought;) we need to check into whether this is feasible and follows our security and privacy standards.

Jul 3 2019, 3:23 AM · Who-Wrote-That
Mooeypoo added a comment to T226774: Design: Determine 'Guided Tour' Requirements.

Actually, I've been reading about how we might be able to reach into the available global variables in the DOM with a browser extension. Since we know it only runs on Wikipedia sites, if we can do that, we will have access to the mw variable, which means we can use resource loader to load (and use!) Guided Tour.

Jul 3 2019, 3:16 AM · Who-Wrote-That

Jul 2 2019

Mooeypoo added a comment to T226543: Create a minimal structure for WhoWroteThat browser extension.

Original repo: https://github.com/mooeypoo/WhoWroteThat

Jul 2 2019, 11:09 PM · Community-Tech (Kanban (Q1 2019-20)), Who-Wrote-That

Jun 27 2019

GitHub <noreply@github.com> committed rGSVT6e611e30993c: Merge pull request #123 from wikimedia/i18n-files (authored by Mooeypoo).
Merge pull request #123 from wikimedia/i18n-files
Jun 27 2019, 11:22 PM
Mooeypoo updated subscribers of T223174: [Timebox - 8 hours] Investigation: Watchlist Expiry.

From the engineering meeting, we hashed out next steps for this:

Jun 27 2019, 11:14 PM · Community-Tech (Kanban (Q1 2019-20))

Jun 25 2019

Mooeypoo added a comment to T210039: Demos rendering performance.

I have a radical suggestion here... since the demos were written in what the IT universe defines as "generations ago", I think that instead of thinking about how to fix performance for what's built, we should reassess whether the demos -- in general -- need to be rewritten.

Jun 25 2019, 6:07 PM · OOUI

Jun 21 2019

Mooeypoo committed rEFWZa12a9585b408: Change expected object from the API (authored by Mooeypoo).
Change expected object from the API
Jun 21 2019, 9:15 PM
Mooeypoo committed rEFWZ40ae766c5421: Change expected object from the API (authored by Mooeypoo).
Change expected object from the API
Jun 21 2019, 9:15 PM

Jun 20 2019

Mooeypoo moved T207439: Size improvements for Curation toolbar from Needs Review/Feedback to QA on the Community-Tech (Resolved 2018-19 Q4) board.
Jun 20 2019, 11:14 PM · Community-Tech (Kanban (Q1 2019-20)), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Community-Tech-Sprint, PageCuration
Mooeypoo added a comment to T184144: Investigation: Who Wrote That revision search tool.

@FaFlo , we took a closer look at the response we're getting from articles that break, and we found that the cause seems to be that the process is running out of memory. See:

Jun 20 2019, 11:02 PM · Who-Wrote-That, Community-Tech
Mooeypoo closed T225015: Communicate changes to Block class to the community as Resolved.
Jun 20 2019, 9:47 PM · Anti-Harassment (The Letter Song)
Mooeypoo updated the task description for T225015: Communicate changes to Block class to the community.
Jun 20 2019, 9:47 PM · Anti-Harassment (The Letter Song)
Mooeypoo claimed T225015: Communicate changes to Block class to the community.
Jun 20 2019, 6:28 PM · Anti-Harassment (The Letter Song)

Jun 19 2019

Mooeypoo added a comment to T207485: Enable page curation tools to be loaded on any page (optionally).

I am a little weary changing this behavior inside the toolbar itself.

Jun 19 2019, 2:07 AM · Patch-For-Review, Community-Tech (Kanban (Q1 2019-20)), PageCuration, Growth-Team

Jun 16 2019

Mooeypoo added a comment to T225571: Add MessageWidget for block user messages (error, warning, success or notice).

Will there also be a PHP variant of this widget?

Jun 16 2019, 1:42 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), OOUI (OOUI-0.33.0)

Jun 13 2019

Mooeypoo added a comment to T225675: Add OAuth to Citation bot.

Yup, that would work as well; I wasn't sure if it was okay to change that without some agreement from community if the bot is widespread, which is why I (wrongly) assumed that wasn't an option :)

Jun 13 2019, 12:55 AM · Anti-Harassment (The Letter Song)
Mooeypoo updated subscribers of T225675: Add OAuth to Citation bot.

I was thinking about this -- I don't think OAuth is enough to stop this behavior. We will need to add a check about whether the user is also blocked, potentially from the page they're asking the bot to edit.

Jun 13 2019, 12:02 AM · Anti-Harassment (The Letter Song)

Jun 11 2019

Mooeypoo created T225567: OOUI demos: Hide the content until JS is ready.
Jun 11 2019, 8:41 PM · Patch-For-Review, OOUI

Jun 5 2019

Restricted Application added a project to T225169: [4 hours] Investigate whether it's efficient to order by tag value (DBA input requested): Growth-Team.
Jun 5 2019, 11:09 PM · Community-Tech (Kanban (Q1 2019-20)), Spike, Growth-Team, PageCuration
Mooeypoo added a comment to T206163: Restrictions of overlapping blocks should be merged on enforcement.

What name do we prefer? So far the suggestion is CompositeBlock which sounds good to me.

Jun 5 2019, 9:22 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Anti-Harassment (Lāmed - ל), Patch-For-Review, MediaWiki-User-management

Jun 4 2019

Mooeypoo created T225015: Communicate changes to Block class to the community.
Jun 4 2019, 6:58 PM · Anti-Harassment (The Letter Song)
GitHub <noreply@github.com> committed rGSVTd1391cf69228: Merge pull request #117 from wikimedia/upload-urls-T224265 (authored by Mooeypoo).
Merge pull request #117 from wikimedia/upload-urls-T224265
Jun 4 2019, 7:40 AM

May 31 2019

Mooeypoo added a comment to T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption.

Yes, I don't think that's a problem, that's the intent.

May 31 2019, 9:32 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Community-Tech (Kanban (Q1 2019-20)), Patch-For-Review, Anti-Harassment, MediaWiki-extensions-GlobalPreferences

May 30 2019

Mooeypoo added a comment to T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption.

Yeah, I've corrected my text.

May 30 2019, 10:35 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Community-Tech (Kanban (Q1 2019-20)), Patch-For-Review, Anti-Harassment, MediaWiki-extensions-GlobalPreferences
Mooeypoo added a comment to T224245: Create a way to save preference options wherever they are set by GlobalPreferences without disruption.
  • When such a setting is getting modified, GlobalPreferences intercepts this and, if the option is global and not overridden locally, a local value is set instead. Modifying a locally overridden value transparently should already work as expected (but we need to verify this regardless).
May 30 2019, 10:33 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Community-Tech (Kanban (Q1 2019-20)), Patch-For-Review, Anti-Harassment, MediaWiki-extensions-GlobalPreferences

May 28 2019

Mooeypoo moved T222737: Refactor Block to AbstractBlock, DatabaseBlock and SystemBlock from Review to QA/Testing on the Anti-Harassment (Kaf - כ) board.

There's not a lot of specifics to test here, but we should just verify that things didn't break with this on beta.

May 28 2019, 10:19 PM · Anti-Harassment (Lāmed - ל), MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, MediaWiki-User-management
Mooeypoo closed T209205: Change the date picker widget as Declined.

This is an interesting discussion, but it's not quite for this product to make the decision. We read the spec off of TemplateData which allow template owners (and wikis) to set the templates the way they wish they behave for better behavior both on the wiki as well as while being edited by this tool or VisualEditor.

May 28 2019, 10:11 PM · I18n, Community-Tech, MediaWiki-extensions-TemplateWizard
Mooeypoo added a comment to T218265: Mute: Add links to disable email and mute specific user to emails sent via Special:EmailUser.

Actually, that's a great catch; this should probably also be the fallback for wikis where Echo isn't installed.

May 28 2019, 4:25 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Anti-Harassment (The Letter Song), Patch-For-Review, MediaWiki-Email
Mooeypoo added a comment to T224294: Target language inputs should be dir=rtl when the language is RTL.

Yeah, this fix is mostly only for the UX of the tool and should not impact the actual SVG file.

May 28 2019, 4:53 AM · Community-Tech (Resolved 2018-19 Q4), Community-Tech-Sprint, SVG Translate Tool

May 24 2019

Mooeypoo added a comment to T224294: Target language inputs should be dir=rtl when the language is RTL.

PR available: https://github.com/wikimedia/svgtranslate/pull/114

May 24 2019, 10:39 PM · Community-Tech (Resolved 2018-19 Q4), Community-Tech-Sprint, SVG Translate Tool
GitHub <noreply@github.com> committed rGSVT80a289476413: Merge f388961126ac975035078887a0be7c5a31de86eb into… (authored by Mooeypoo).
Merge f388961126ac975035078887a0be7c5a31de86eb into…
May 24 2019, 10:35 PM
Mooeypoo committed rGSVTf388961126ac: Set target language inputs directionality (authored by Mooeypoo).
Set target language inputs directionality
May 24 2019, 10:35 PM
Mooeypoo moved T224294: Target language inputs should be dir=rtl when the language is RTL from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.
May 24 2019, 10:35 PM · Community-Tech (Resolved 2018-19 Q4), Community-Tech-Sprint, SVG Translate Tool