Mon, Oct 14
We should still fix the security issues, (perceived or real, regardless)
Sat, Oct 12
Thu, Oct 10
I'll facilitate this. I'll talk to the group about whether there are specifics we want to make sure are delivered within the given topic.
We've discussed offline but just for posterity here -- the biggest issue we have is that these percentages are calculated based on tokens and on wikitext. Essentially, the second author may have edited things like citations and thumbnails and templates that we do not "see" visually in the visual WWT tool, but make his edits correctly account for 2.1% of the page.
This was fixed (incidentally!) as part of the MVC refactor.
Wed, Oct 9
Submitted a PR to handle load/unload of VisualEditor: https://github.com/wikimedia/WhoWroteThat/pull/64
This is more about good practice rather than strictly security.
Tue, Oct 8
A pre-requisite is to be able to shut off the system (and disable it) from an event handler. Created T234874: Enable WWT to be turned on and off remotely for that task (PR attached) and will follow up with a VE-specific event handler after that one's merged.
For testing, you can now use, in the console:
Thu, Oct 3
Wed, Oct 2
So after an investigation, here are findings on how we can potentially do this.
You're right, we missed that part when discussing the ticket; it was fixing a code review comment by adding extra functionality.
This is merged to master. I will update the self-hosted gadget in the next few days before it moves to product (if all is well :) .
Tue, Oct 1
Tue, Sep 24
This was merged, and will be available on beta in a few minutes.
Mon, Sep 23
Bringing back to review for this patch.
Thanks to the amazing debug (and git blame) skills of @Catrope we found the problem.
Fri, Sep 20
@dom_walden I just re-tested this in an effort to figure out what's going on, and I can no longer reproduce it...
Thu, Sep 19
First off, thank you @DannyS712 for picking this up :)
Wed, Sep 18
Hm I wonder if this has anything to do with the upgrade to jQuery 3.4.1, and that ULS perhaps needs to be adjusted for it.
Sep 17 2019
Sep 8 2019
I'm sorry to hear that. If you ever change your mind, we'll be happy to try and help guide you through the process.
In any case, this page might be able to help as well, if you need it: https://www.mediawiki.org/wiki/Help:TemplateData
Sep 7 2019
TemplateWizard allows you to insert templates into a page if they have TemplateData definition.
TemplateData extension can help you set definitions in your templates.
If you have TemplateData installed, you can add $wgTemplateDataUseGUI = true; to your LocalSettings.php and you'll see a "Manage TemplateData" button when you edit a template.
@AlgorithmGG TemplateWizard requires having TemplateData definition in each template.
Sep 6 2019
Sep 4 2019
One of the biggest issues here is that we call the hook just before we refresh the page, and that the use cases that this hook is for are working asynchronously, which means refreshing immediately after call is not going to help anything
Sep 3 2019
Sweet! I'm so glad that this is working properly and thank you for the feedback.
Aug 30 2019
I will remind everyone that we're talking about a WMF employee here.
@sbassett in that case, I just want to make sure we add to the list the fact that Anti Harassment's Tool team's work touches on blocking tools, which inherently tend to be Security tickets if any bug happens there.
Our upcoming work will involve CheckUser, which, again, almost exclusively has bugs in the security realm. For us, this is not just a matter of this being useful, but a pretty crucial part of the work, in case bugs happen in the part of the code we actively work on.
Aug 29 2019
Aug 28 2019
Aug 27 2019
Aug 23 2019
Aug 22 2019
CSSJanus Webpack plugin: https://github.com/mooeypoo/cssjanus-webpack
Aug 17 2019
While doing some experimentation, I unfortunately discovered it's not as easy to get GuidedTour to activate from the injected script; the naming conventions and the fact that it supposed to run on all pages seem to be a bit more difficult for the extension to load itself with the gains of the cookie and toggling.
Aug 16 2019
To QA, use the instructions on https://github.com/wikimedia/WhoWroteThat#testing-the-browser-extension
To QA the browser extension, see the steps at https://github.com/wikimedia/WhoWroteThat#testing-the-browser-extension
Aug 14 2019
Aug 9 2019
Notes so far:
Aug 8 2019
Hmmm but I set up Hebrew as the interface language. Interesting. I'll give it another shot.
First problem: I switched my Chrome language to Hebrew, and I see the site in English, after refreshing and hard-refreshing a few times.
Yup, although I might need that language picker ... ;)
- When WWT is activated, a blue information bar should appear at the top of the article.
- The information bar should be displayed below the links ("Read," "Edit," "View History," "Article," or "Talk") and above the article title.
- I've checked on this for Vector, Monobook and Timeless. There are minor annoyances with the icons in Monobook and Timeless, but it is working.
- The information bar should not block any links on the page.
- The whitespace dimensions at the top of the article should remain the same.
- The information bar should be sticky.
- The information bar should be implemented in such a way that it can adapt to different states. For example, if there is an API error, the bar may change (e.g. a different color). However, the actual handling of error behavior will be covered in a separate ticket.
- The widget changes state with widget.setState( state ) where state can be pending, ready, and err.
Aug 7 2019
Aug 6 2019
Aug 5 2019
This PR fixes the following:
- Add a link/button to toggle WhoWroteThat view on/off on the sidebar, under "Tools
- The text of the link should read as follows: "Who Wrote That?"
- The "Who Wrote That" link should be the last in the order of tools (i.e. do not change the current order)
- If a user toggles on WWT, the WWT mode should display on an article page
- If the user toggles off WWT, the WWT mode should no longer display on an article page
- This should only appear in "Tools" when the user is viewing an article page in Read view.
Aug 4 2019
I have a PR for this here: https://github.com/wikimedia/WhoWroteThat/pull/16
Jul 31 2019
Jul 29 2019
\o/ Thank you @Samwilson !