Mooeypoo (Moriel Schottlender)
Software Engineer, Editing Team

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 18 2014, 11:57 PM (170 w, 5 d)
Availability
Available
IRC Nick
mooeypoo
LDAP User
Mooeypoo
MediaWiki User
Mooeypoo

Recent Activity

Sat, Feb 24

Mooeypoo moved T184883: Notifications popup renders twice in unknown conditions from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Sat, Feb 24, 4:47 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Notifications
Mooeypoo claimed T184883: Notifications popup renders twice in unknown conditions.
Sat, Feb 24, 4:47 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Notifications

Fri, Feb 23

Mooeypoo moved T188142: Create and run unit tests in Kartotherian repos as part of CI from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Fri, Feb 23, 9:22 PM · Discovery, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Mooeypoo created T188142: Create and run unit tests in Kartotherian repos as part of CI.
Fri, Feb 23, 9:22 PM · Discovery, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Mooeypoo moved T188060: Add style linting to Kartotherian stack from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Fri, Feb 23, 1:02 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps (Kartotherian), Collaboration-Feature-Rollouts (Collaboration-Maps)
Mooeypoo created T188060: Add style linting to Kartotherian stack.
Fri, Feb 23, 1:02 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps (Kartotherian), Collaboration-Feature-Rollouts (Collaboration-Maps)

Thu, Feb 22

Mooeypoo added a comment to T187398: MenuTagMultiselectWidget: The first item should be automatically highlighted+selected when the menu opens.
  • Whatever happens in this fix, 'highlightOnFilter' on MenuSelectWidget is broken right now. I couldn't manage to directly fix it without completely changing the way the events work, and almost rewriting the widget. My approach to a fix would have been separating, at the very least, the event response to editing the input with the events related to keystroke, but that change is much more nuanced, since some of those are not really distinct as we want them to be. I didn't want to get too much into this without consulting first, though. So -- do we cancel the 'highlightOnFilter' config as non working, or should we rewrite the functionality to try and decouple events and make it work?
Thu, Feb 22, 2:23 AM · Patch-For-Review, OOUI
Mooeypoo updated subscribers of T187398: MenuTagMultiselectWidget: The first item should be automatically highlighted+selected when the menu opens.

@matmarex this was a little harder than I thought, and exposed another potential bug in MenuSelectWidget with the config variable "highlightOnFilter". Supposedly, "highlightOnFilter" should do exactly this behavior, but it doesn't work right now. I tried to fix it in MenuSelectWidget, but the cross-events that trigger 'updateItemVisibility' (on key strokes, on changing of input, etc) interfere with this behavior, and make the selection jump up and be unsynchronized with the arrow movement.

Thu, Feb 22, 1:24 AM · Patch-For-Review, OOUI

Wed, Feb 21

Mooeypoo added a comment to T186998: No indication to a user that only one Thank action is allowed.

Update: It works now when I thank another user.

Wed, Feb 21, 12:43 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Thanks
Mooeypoo added a comment to T186998: No indication to a user that only one Thank action is allowed.

This is getting more complicated, though, something is seriously weird here.

Wed, Feb 21, 12:33 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Thanks

Sat, Feb 17

Mooeypoo moved T186247: Hebrew Wikivoyage (via Tool "wikivoyage") loads assets by default from third-party sites from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Sat, Feb 17, 7:07 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Vuln-Infoleak, Community-Liaisons, Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Privacy, Toolforge-standards-committee, Maps, WMF-Legal, Tools
Mooeypoo added a project to T186247: Hebrew Wikivoyage (via Tool "wikivoyage") loads assets by default from third-party sites: Collaboration-Team-Triage (Collab-Team-This-Quarter).
Sat, Feb 17, 7:07 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Vuln-Infoleak, Community-Liaisons, Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Privacy, Toolforge-standards-committee, Maps, WMF-Legal, Tools
Mooeypoo added a comment to T186247: Hebrew Wikivoyage (via Tool "wikivoyage") loads assets by default from third-party sites.

I ported he.wikivoyage templates to use Kartographer.

Sat, Feb 17, 6:55 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Vuln-Infoleak, Community-Liaisons, Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Privacy, Toolforge-standards-committee, Maps, WMF-Legal, Tools
Mooeypoo updated subscribers of T186247: Hebrew Wikivoyage (via Tool "wikivoyage") loads assets by default from third-party sites.

What exists right now is bad for privacy policy, but it's been like that for years. We can give it a couple of days to do this in a way that doesn't suddenly remove all maps from the site, like replace the {{mapframe}} template properly.

Sorry, but privacy policy violations are different different. The fact it's been like this for so long is a huge problem that we need to address (CSP, etc.) but leaving it even longer is unacceptable in my view. This ticket was filed over 2 weeks ago, but nothing changed, so the leeway for a couple of days is well past.

Sat, Feb 17, 1:03 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Vuln-Infoleak, Community-Liaisons, Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Privacy, Toolforge-standards-committee, Maps, WMF-Legal, Tools
Krinkle awarded T187520: Fix the broken source map in OOUI demos a Orange Medal token.
Sat, Feb 17, 12:54 AM · OOUI (OOUI-0.25.2)

Fri, Feb 16

Mooeypoo added a comment to T186247: Hebrew Wikivoyage (via Tool "wikivoyage") loads assets by default from third-party sites.

We need to be careful not to completely and immediately destroy functionality on hewikivoyage. This should be fixed, but we should and can fix it right.

Fri, Feb 16, 11:56 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Vuln-Infoleak, Community-Liaisons, Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Privacy, Toolforge-standards-committee, Maps, WMF-Legal, Tools
Mooeypoo created T187520: Fix the broken source map in OOUI demos.
Fri, Feb 16, 1:50 AM · OOUI (OOUI-0.25.2)

Thu, Feb 15

Lea_WMDE awarded T187398: MenuTagMultiselectWidget: The first item should be automatically highlighted+selected when the menu opens a Party Time token.
Thu, Feb 15, 8:50 AM · Patch-For-Review, OOUI

Wed, Feb 14

Mooeypoo added a comment to T173741: When typing a namespace, the top option should be highlighted and be able to be added with enter.

Fair enough, I can look into putting it upstream. I created the task for it here T187398: MenuTagMultiselectWidget: The first item should be automatically highlighted+selected when the menu opens and will work on this.

Wed, Feb 14, 10:53 PM · OOUI, WMDE-QWERTY-Sprint-2017-12-13, Advanced-Search, TCB-Team
Mooeypoo created T187398: MenuTagMultiselectWidget: The first item should be automatically highlighted+selected when the menu opens.
Wed, Feb 14, 10:53 PM · Patch-For-Review, OOUI
debt awarded T186779: Enable zoom 19 in kartographer / mapframe / maplink a Like token.
Wed, Feb 14, 5:41 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps-Sprint, Maps (Kartographer), Discovery

Tue, Feb 13

Mooeypoo added a comment to T186247: Hebrew Wikivoyage (via Tool "wikivoyage") loads assets by default from third-party sites.

Matt, I am not sure a CL is really needed here? (I am super curious though about how this will end, and how to find all the communities equally affected.)

Tue, Feb 13, 6:59 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Vuln-Infoleak, Community-Liaisons, Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Privacy, Toolforge-standards-committee, Maps, WMF-Legal, Tools
RandomDSdevel awarded T178540: RC page - the page jumps when filter capsules are clicked while searching a Haypence token.
Tue, Feb 13, 2:28 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page

Fri, Feb 9

Mooeypoo updated the task description for T186779: Enable zoom 19 in kartographer / mapframe / maplink.
Fri, Feb 9, 10:58 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps-Sprint, Maps (Kartographer), Discovery
Mooeypoo updated the task description for T186779: Enable zoom 19 in kartographer / mapframe / maplink.
Fri, Feb 9, 10:58 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps-Sprint, Maps (Kartographer), Discovery
Mooeypoo updated the task description for T186779: Enable zoom 19 in kartographer / mapframe / maplink.
Fri, Feb 9, 10:49 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps-Sprint, Maps (Kartographer), Discovery
Mooeypoo added a comment to T186779: Enable zoom 19 in kartographer / mapframe / maplink.

snapshot service needs to accept zoom 19 too.

Fri, Feb 9, 10:14 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps-Sprint, Maps (Kartographer), Discovery
Mooeypoo added a comment to T186779: Enable zoom 19 in kartographer / mapframe / maplink.
  • mapframe zoom parameter
Fri, Feb 9, 10:14 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps-Sprint, Maps (Kartographer), Discovery
Mooeypoo updated subscribers of T186779: Enable zoom 19 in kartographer / mapframe / maplink.

As per @Mattflaschen-WMF, the full test for all zoom19 implementation should include

Fri, Feb 9, 6:44 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps-Sprint, Maps (Kartographer), Discovery
Mooeypoo moved T186779: Enable zoom 19 in kartographer / mapframe / maplink from Needs Review to Code Review Started on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

(This is step 1, I need to add support for Mapframe embedding and maplink zoom parameter next.)

Fri, Feb 9, 6:33 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps-Sprint, Maps (Kartographer), Discovery
Mooeypoo moved T186779: Enable zoom 19 in kartographer / mapframe / maplink from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Verified that the zoom level is capable of one more level, but beyond that, the network tab shows the request asking for zoom level 19 as max level:

:path:/osm-intl/19/83867/202626.png
Fri, Feb 9, 6:00 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps-Sprint, Maps (Kartographer), Discovery
Mooeypoo claimed T186779: Enable zoom 19 in kartographer / mapframe / maplink.
Fri, Feb 9, 5:51 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps-Sprint, Maps (Kartographer), Discovery
Mooeypoo moved T184574: [monobook] The guided tour for RC filters has small font from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Fri, Feb 9, 5:43 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo claimed T184574: [monobook] The guided tour for RC filters has small font.
Fri, Feb 9, 1:14 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter)

Thu, Feb 8

Mooeypoo removed a project from T184295: Notifications have small font in Modern skin: Collaboration-Team-Triage (Collab-Team-This-Quarter).

We've moved the notification layer to a global overlay. Vector and Monobook are working, Modern is not supported.

Thu, Feb 8, 10:40 PM · Collaboration-Team-Triage, Notifications, Modern

Wed, Feb 7

Mooeypoo added a comment to T183378: MenuTagMultiselectWidget does not clear the input field when selecting a tag from the menu.

Awesome, thank you! RCFilters already overrides the onMenuChoose behavior (we deal with filtering in the model layer) but this is important to note. Thanks for this!

Wed, Feb 7, 11:01 PM · OOUI (OOUI-0.25.2)
Mooeypoo added a comment to T181705: Keep namespace selection dropdown open after selection.

Note, by the way, that there is another separate (but perhaps related) configuration option that was added recently to MenuTagMultiselectWidget to prevent clearing the input itself on choose (see https://gerrit.wikimedia.org/r/#/c/401422/ )

Wed, Feb 7, 10:48 PM · WMDE-Fundraising-Sprint-17, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, WMDE-Fundraising-Sprint-16, OOUI, WMDE-QWERTY-Sprint-2017-12-13, TCB-Team, Advanced-Search

Sat, Feb 3

Mooeypoo added a comment to T32750: [Epic] Ping/notify user when username used in an edit summary.

I agree that there's the problem of missing context on history pages, but this isn't different from how it's done right now. There are many cases where usernames are used in edit summaries, the only difference would be a notification if the name has been linked.

Sat, Feb 3, 2:34 AM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Epic, Community-Wishlist-Survey-2017, Community-Tech, Notifications, Collaboration-Team-Triage, MediaWiki-Page-editing
Mooeypoo added a comment to T32750: [Epic] Ping/notify user when username used in an edit summary.

Another concern I have is lack of context; seeing "per Mooeypoo" in an edit in history lacks the context of whether I actually asked for this, or whether someone misunderstood me, or whether I asked, changed my mind, and the decision is now different.

Sat, Feb 3, 1:22 AM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Epic, Community-Wishlist-Survey-2017, Community-Tech, Notifications, Collaboration-Team-Triage, MediaWiki-Page-editing

Thu, Feb 1

Mooeypoo added a comment to T32750: [Epic] Ping/notify user when username used in an edit summary.

I have a few reservations about this, namely that you can't edit the edit summaries in history, so it sounds like there's some anti-harassment / moderation aspects to consider.

Thu, Feb 1, 10:56 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Epic, Community-Wishlist-Survey-2017, Community-Tech, Notifications, Collaboration-Team-Triage, MediaWiki-Page-editing
Mooeypoo added a comment to T97156: Flow inputs' placeholders should be bidi-isolated when viewed with interface directionality that is different than the wiki directionality.

Those don't work well in placeholders, unfortunately.

Thu, Feb 1, 9:03 PM · I18n, StructuredDiscussions, Collaboration-Team-Triage

Jan 23 2018

Mooeypoo updated the task description for T183319: Wikimedia Developer Summit 2018 Topic: Embracing Open Source Software.
Jan 23 2018, 5:59 PM · Wikimedia-Developer-Summit (2018)

Jan 19 2018

Mooeypoo moved T185046: Icon misaligned in Notification popup submenus from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Jan 19 2018, 6:59 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications

Jan 17 2018

Mooeypoo added a comment to T184883: Notifications popup renders twice in unknown conditions.

It's hard to trace this without more detail, and I can't manage to reproduce this.

Jan 17 2018, 10:30 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Notifications
Mooeypoo added a comment to T184143: Special:Notifications page does not truncate long page titles.

Here's the comparison of the new patch.

Jan 17 2018, 10:26 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collab-Notifications-Page

Jan 16 2018

Mooeypoo moved T185046: Icon misaligned in Notification popup submenus from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Jan 16 2018, 10:31 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
Mooeypoo created T185046: Icon misaligned in Notification popup submenus.
Jan 16 2018, 10:31 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
Mooeypoo added a comment to T178437: Make icon/indicator visibility handling several widget nesting levels proof.

Apparently not quite the same, but similar, just broke icons in buttons in Special:Notifications T184023: [wmf.12-minor] monobook Special:Notification - drop-down options for the cog icon should be aligned with the icons

Jan 16 2018, 10:20 PM · Regression, OOUI
Mooeypoo claimed T184023: [wmf.12-minor] monobook Special:Notification - drop-down options for the cog icon should be aligned with the icons.

@Volker_E this seems to be an issue in OOUI Apex.

Jan 16 2018, 10:13 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collab-Notifications-Page
Mooeypoo updated subscribers of T184143: Special:Notifications page does not truncate long page titles.

I decreased spacing a bit and realigned the rows, but I also tried to make sure the lines are aligned to the middle of the cells, so the spacing is different a bit, but I actually think it makes it better now in the new version, showing everything aligned in the same line neatly. I couldn't get rid of more top/bottom spacing when it's table view, but it seems to be the "fault" of the icon that is now aligned to the middle of the line, and the counter that dictates the heights of each line. I could decrease the line-height in the counter, but then it makes the counter "box" less square, it doesn't seem to look that good.

Jan 16 2018, 8:12 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collab-Notifications-Page

Jan 12 2018

Mooeypoo claimed T184143: Special:Notifications page does not truncate long page titles.
Jan 12 2018, 12:04 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collab-Notifications-Page

Jan 11 2018

Mooeypoo added a comment to T184174: Bookmarking Watchlist with new filters does not preserve user Watchlist preferences .

@Mooeypoo enhanced=1 controls "group by page", it doesn't control whether the WL shows only the most recent edit for each page, or all edits, and that's what he's talking about.

Jan 11 2018, 7:31 PM · User-notice-collaboration, User-notice, Edit-Review-Improvements-Integrated-Filters, Wikidata, Collaboration-Team-Triage
Mooeypoo added a comment to T184174: Bookmarking Watchlist with new filters does not preserve user Watchlist preferences .

The 'group results by page' option works by the preference but also by the URL parameter. In the new RC system, we make the URL parameter be synchronized with the preference -- so it seems like it's the same. The old system doesn't have that synchronization, though, which means that whatever preference the user has for "group by page" will be overridden by the enhanced=xx parameter.

Jan 11 2018, 6:12 PM · User-notice-collaboration, User-notice, Edit-Review-Improvements-Integrated-Filters, Wikidata, Collaboration-Team-Triage

Jan 10 2018

Mooeypoo added a comment to T184174: Bookmarking Watchlist with new filters does not preserve user Watchlist preferences .

When you disable the beta-feture again but don't change the url – i.e. you reload the already open page instead of clicking on "watchlist" in the menu – the enhanced watch list does not work anymore.
This is especially an issue when you if you never close your watchlist but keep it open in a tab or have set a bookmark (while the beta-feature was enabled).

Jan 10 2018, 6:19 PM · User-notice-collaboration, User-notice, Edit-Review-Improvements-Integrated-Filters, Wikidata, Collaboration-Team-Triage

Jan 9 2018

Mooeypoo updated subscribers of T184181: mw.widgets.TitleWidget.prototype.getTitle conflicts with OO.ui.mixin.TitledElement.prototype.getTitle.

@Etonkovidova to test this, refer to the mentioned task (that's closed, but is relevant) - T183484: Related Changes page-name entry box does not show the entirety of long pagenames

Jan 9 2018, 11:55 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), MediaWiki-General-or-Unknown, Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review
Mooeypoo moved T184181: mw.widgets.TitleWidget.prototype.getTitle conflicts with OO.ui.mixin.TitledElement.prototype.getTitle from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Jan 9 2018, 11:53 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), MediaWiki-General-or-Unknown, Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review

Jan 5 2018

Mooeypoo added a comment to T183729: Allow the 'Live updates' feature to be turned on by default.

What is the ramifications of this for performance, especially for big wikis like enwiki?

Jan 5 2018, 5:50 PM · User-Urbanecm, Collaboration-Team-Triage, Edit-Review-Improvements-RC-Page
Mooeypoo added a comment to T183720: Avoid or minimise impact of "unready" Grade A state .

I like this.

Jan 5 2018, 12:42 AM · Performance-Team (Radar), Front-end-Standards-Group

Jan 4 2018

Mooeypoo added a comment to T183910: "Exclude selected" in "Namespaces" doesn't work when using "Saved filters" in RecentChanges .

When any namespaces are selected, but "Exclude selected" is not selected, only the selected namespaces are shown, so other namespaces are effectually excluded. This is how it worked and still works with my filters (which I have kept) which were affected by the bug, and how it works with any filter.

Jan 4 2018, 7:16 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page, MediaWiki-Recent-changes
Mooeypoo added a comment to T184181: mw.widgets.TitleWidget.prototype.getTitle conflicts with OO.ui.mixin.TitledElement.prototype.getTitle.

TitleWidget should be the one that adjusts here, in my opinion, since 'title' in this case is for HTML properties, rather than having the mixin allow for things it wasn't designed for.

Jan 4 2018, 6:25 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), MediaWiki-General-or-Unknown, Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review
Mooeypoo added a comment to T183910: "Exclude selected" in "Namespaces" doesn't work when using "Saved filters" in RecentChanges .

I may misunderstand but this seems wrong to me: "When you loaded the saved filter all other namespaces were excluded instead."

Jan 4 2018, 6:09 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page, MediaWiki-Recent-changes
Mooeypoo added a comment to T183910: "Exclude selected" in "Namespaces" doesn't work when using "Saved filters" in RecentChanges .

I understand this to include renaming. To be nitpicky: Would "Set as default" affect this?

Jan 4 2018, 5:38 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page, MediaWiki-Recent-changes

Jan 3 2018

Mooeypoo added a comment to T183720: Avoid or minimise impact of "unready" Grade A state .

After reading both of these tasks, I had the idea that re-triggering the click events after page load could allow this to be implemented more easily. Along the lines of:

<a href="blahblah" onclick="$(function(){ $(this).trigger('click') }.bind(this))"></a>

But this won't work for two reasons:

  • We'd need to wait for the code handling these clicks to load before re-triggering the event
  • The HTML element may no longer exist if that code replaces it with something else (e.g. an OOUI button)
Jan 3 2018, 10:09 PM · Performance-Team (Radar), Front-end-Standards-Group
Mooeypoo added a comment to T184028: Allow for deferred clicks on personal tools while Javascript is loading.

This sounds like the same idea as T183720: Avoid or minimise impact of "unready" Grade A state , have you been working on this together with @Krinkle or just two great minds thinking alike?

Jan 3 2018, 5:55 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Notifications, MediaWiki-General-or-Unknown
Mooeypoo added a comment to T183910: "Exclude selected" in "Namespaces" doesn't work when using "Saved filters" in RecentChanges .

@Johan, something for Problems in the next Tech News?

Affected users: Those who have any "Saved filters" with excluded namespaces, and have saved or removed (or renamed?) any saved filters, from the week of 12 December until tonight. (Is that right, Mooeypoo?)

Jan 3 2018, 4:52 AM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page, MediaWiki-Recent-changes
Mooeypoo added a comment to T183910: "Exclude selected" in "Namespaces" doesn't work when using "Saved filters" in RecentChanges .

in my Swedish account, I haven't made any change to my saved filters in more than a month (other than selecting active filters). I'll get back to you after the SWAT.

@Mooeypoo, as expected all my English saved filters with exclusions will need to be re-saved, while all of my Swedish saved filters now works as they should again.

Jan 3 2018, 1:29 AM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page, MediaWiki-Recent-changes
Mooeypoo updated subscribers of T184028: Allow for deferred clicks on personal tools while Javascript is loading.

Note -- I think it was @Catrope that showed me a trick (and may have said it was @Krinkle who used it?) where we redefine the 'push' method of the array that was used to collect clicks before JS is loaded. If we do that, we can replace the 'getDeferredActions' with a subscription process, and have the 'push' be replaced with something like "triggerHandler" that trigger 'click' action; this would make the onClick relevant pre-JS load, and also after without having to remove the onClick from the node.

Jan 3 2018, 1:28 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Notifications, MediaWiki-General-or-Unknown
Mooeypoo created T184028: Allow for deferred clicks on personal tools while Javascript is loading.
Jan 3 2018, 1:15 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Notifications, MediaWiki-General-or-Unknown

Jan 2 2018

Mooeypoo added a comment to T183910: "Exclude selected" in "Namespaces" doesn't work when using "Saved filters" in RecentChanges .

@Pipetricker actually, I hve an idea of why your setup works with your Default but not on reload. I think you haven't saved any new saved filters in the past 2 weeks or so -- if that's the case, then the fix we are doing today in SWAT will seamlessly fix your setup, and you need to do nothing :)

Jan 2 2018, 10:32 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page, MediaWiki-Recent-changes
Mooeypoo added a comment to T183910: "Exclude selected" in "Namespaces" doesn't work when using "Saved filters" in RecentChanges .

Thanks @Mooeypoo.
After the SWAT, I will retry my older saved filters which have exclusions. As I said in the bug description, my default Swedish filter still works correctly on page load (but not when subsequently selected).

Jan 2 2018, 10:27 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page, MediaWiki-Recent-changes
Mooeypoo added a comment to T182241: [minor] wmf.11-regression: changesLimitButtonWidget does not display "Number of edits to show by default: 1" .

(Note: I was originally thinking of T170975: {{PLURAL}} behaves differently in PHP vs JS for decimal numbers but this is a different issue than the one in this ticket)

Jan 2 2018, 10:07 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression, Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T182241: [minor] wmf.11-regression: changesLimitButtonWidget does not display "Number of edits to show by default: 1" .

Yes, there's a funny (not) bug/feature in mw.msg regarding treating the number 0 as plural, so {{PLURAL:$1|change|$1 changes}} will be 'change' if it's only one, and '0 changes' if it's zero or bigger than 1. I'm not 100% sure, but I think we tried a variation {{PLURAL:$1|0=no changes|1=one change|$1 changes}} and that didn't work right, but I might be wrong, and this could be a solution.

Jan 2 2018, 10:03 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression, Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T183910: "Exclude selected" in "Namespaces" doesn't work when using "Saved filters" in RecentChanges .

When was this typo deployed? (and can I find that information myself?)

Jan 2 2018, 9:37 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page, MediaWiki-Recent-changes
Mooeypoo moved T183910: "Exclude selected" in "Namespaces" doesn't work when using "Saved filters" in RecentChanges from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Jan 2 2018, 6:34 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page, MediaWiki-Recent-changes
Mooeypoo added a comment to T183910: "Exclude selected" in "Namespaces" doesn't work when using "Saved filters" in RecentChanges .

Fixed a typo that caused this. It should work now, but I can't retroactively fix the incorrectly saved queries -- after the patch is merged and deployed, please re-save the saved filters that had 'excluded' in them again.

Jan 2 2018, 6:34 PM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page, MediaWiki-Recent-changes
Mooeypoo added a comment to T183378: MenuTagMultiselectWidget does not clear the input field when selecting a tag from the menu.

I see, I misunderstood. I am a bit weary of doing this so broadly (we're going tohave to override this in RCFilters, because we don't close the popup on every choice and would like to keep the filtering)

Jan 2 2018, 6:15 PM · OOUI (OOUI-0.25.2)

Dec 27 2017

Mooeypoo moved T183435: Secondary links broken in Echo in Monobook (possibly a MenuOptionWidget regression in Apex?) from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Dec 27 2017, 7:48 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
Mooeypoo added a comment to T183435: Secondary links broken in Echo in Monobook (possibly a MenuOptionWidget regression in Apex?).

@matmarex awesome, thank you -- is this relatively new? The previous stylesheet already tried to override "specific" rules, it seems at some point the rules became even more specific...? (Sorry, I misread the old/new code, but I'm still curious about when this broke, if you have an idea?)

Dec 27 2017, 7:44 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications

Dec 22 2017

Mooeypoo added a comment to T183377: MenuTagMultiselectWidget menu doesn't close properly when used with an overlay.

OK, as I suspected, this was $autoCloseIgnore. The widget adds the $overlay to the autoCloseIgnore, which is wrong -- it means that the menu won't close when you click the overlay, that's basically everywhere.

Dec 22 2017, 7:44 PM · OOUI (OOUI-0.25.0)
Mooeypoo moved T183442: [betalabs] Drop-down filter menu becomes detached when the first filter item is selected from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Dec 22 2017, 5:34 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-This-Quarter)

Dec 21 2017

Mooeypoo added a comment to T183442: [betalabs] Drop-down filter menu becomes detached when the first filter item is selected.

I can't reproduce this, but I have a feeling this has to do with the lazy loading. @Etonkovidova can you confirm, though -- between step 1 and step 2, the popup should open automatically. When you "clear" the filters, the input should be focused, and the popup should open. Is that happening? I just want to verify.

Dec 21 2017, 6:23 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo added a comment to T183378: MenuTagMultiselectWidget does not clear the input field when selecting a tag from the menu.

Hm, in RCFilters, we do it manually through extending onTagSelect we have this.input.setValue( '' );

Dec 21 2017, 12:11 AM · OOUI (OOUI-0.25.2)
Mooeypoo added a comment to T183377: MenuTagMultiselectWidget menu doesn't close properly when used with an overlay.

Hmm, I'll need to see the code for this, but my initial suspicion is that this has to do with $autoCloseIgnore and its definition.

Dec 21 2017, 12:07 AM · OOUI (OOUI-0.25.0)
Mooeypoo added a comment to T181705: Keep namespace selection dropdown open after selection.

The MenuSelectWidget has a 'hideOnChoose' option, conveniently :)
In RCFilters, we're setting it to 'false' in the menu configuration: https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js#L45

Dec 21 2017, 12:05 AM · WMDE-Fundraising-Sprint-17, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, WMDE-Fundraising-Sprint-16, OOUI, WMDE-QWERTY-Sprint-2017-12-13, TCB-Team, Advanced-Search
Mooeypoo added a comment to T173741: When typing a namespace, the top option should be highlighted and be able to be added with enter.

Ah! We actually did that in RCFilters, with a hack, see here: https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.MenuSelectWidget.js#L264

Dec 21 2017, 12:00 AM · OOUI, WMDE-QWERTY-Sprint-2017-12-13, Advanced-Search, TCB-Team

Dec 20 2017

Mooeypoo renamed T183435: Secondary links broken in Echo in Monobook (possibly a MenuOptionWidget regression in Apex?) from Secondary links broken in Echo (possibly a MenuOptionWidget regression in Apex?) to Secondary links broken in Echo in Monobook (possibly a MenuOptionWidget regression in Apex?).
Dec 20 2017, 11:52 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
Mooeypoo edited projects for T183435: Secondary links broken in Echo in Monobook (possibly a MenuOptionWidget regression in Apex?), added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Dec 20 2017, 11:51 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
Mooeypoo updated subscribers of T183435: Secondary links broken in Echo in Monobook (possibly a MenuOptionWidget regression in Apex?).

@Volker_E I played around with trying to fix it, but all the adjustments don't make much sense (making the icon display:inline-block; but then reducing margin and re-aligning the label... pit of despair, that approach)

Dec 20 2017, 11:50 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
Mooeypoo created T183435: Secondary links broken in Echo in Monobook (possibly a MenuOptionWidget regression in Apex?).
Dec 20 2017, 11:48 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
Mooeypoo claimed T156080: [minor] monobook- Notification drop-down panel needs additional padding for bundled notifications. .
Dec 20 2017, 11:45 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
Mooeypoo moved T181100: [wmf.8 - regression] Related changes: Saved filters set as default won't include the page as part of a query from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

This should be fixed now.

Dec 20 2017, 9:47 PM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Edit-Review-Improvements-RC-Page, Regression, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo moved T177455: flow-post-timestamp editedbefore RTL issue from Snack Box to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Dec 20 2017, 5:58 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Easy, I18n, RTL

Dec 13 2017

Mooeypoo edited projects for T182720: Clean up the synchronization and updating of menu items with the search input, added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Dec 13 2017, 10:49 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters

Dec 12 2017

Mooeypoo added a subtask for T178540: RC page - the page jumps when filter capsules are clicked while searching: T182720: Clean up the synchronization and updating of menu items with the search input.
Dec 12 2017, 10:04 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page
Mooeypoo added a parent task for T182720: Clean up the synchronization and updating of menu items with the search input: T178540: RC page - the page jumps when filter capsules are clicked while searching.
Dec 12 2017, 10:04 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
Mooeypoo created T182720: Clean up the synchronization and updating of menu items with the search input.
Dec 12 2017, 10:03 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters

Nov 30 2017

Mooeypoo added a comment to T181671: 1.31.0-alpha / Declaration of SpecialRecentChangesLinked::getPageTitle() should be compatible with SpecialPage::getPageTitle.

Oy, sorry about that, RecentChangesLinked didn't actually use the parameter, so I took it out without actually realizing that effect.
Fixing now.

Nov 30 2017, 7:08 PM · MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), Patch-For-Review, Collaboration-Team-Triage, Edit-Review-Improvements-RC-Page, MediaWiki-General-or-Unknown

Nov 27 2017

Mooeypoo added a comment to T177009: Only add highlight/toggle states conditionally to the saved queries.

Yes, the fix for that is here: https://gerrit.wikimedia.org/r/#/c/392182/

Nov 27 2017, 9:59 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)

Nov 18 2017

Mooeypoo claimed T180863: [wmf.7] "Excluded" label is displayed with filter selection .
Nov 18 2017, 12:58 AM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Patch-For-Review, Regression, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo added a comment to T180863: [wmf.7] "Excluded" label is displayed with filter selection .

This was a mishap due to the fix for T177009: Only add highlight/toggle states conditionally to the saved queries

Nov 18 2017, 12:58 AM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Patch-For-Review, Regression, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-This-Quarter)