Mooeypoo (Moriel Schottlender)
Software Engineer, Editing Team

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 18 2014, 11:57 PM (139 w, 5 d)
Availability
Available
IRC Nick
mooeypoo
LDAP User
Mooeypoo
MediaWiki User
Mooeypoo

Recent Activity

Yesterday

Mooeypoo added a comment to T171387: Recent change date range popup usability issues.

Also, re #3, in some of the mockups they're on the left, and some on the right -- since we have more UI elements to include (pagination, on the right side for example) so I am actually not 100% sure where they should go right now. We could add them to the right side for the moment, but when we add pagination they will likely have to move - either to the left of the pagination controls (but still relatively to the right) or at the left of the interface.

Sun, Jul 23, 5:18 AM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T171387: Recent change date range popup usability issues.

We can get them to auto-close, but according to the design, both popups have more options in them (see T168513: Enable 'Group results by page' preference on the RC page itself) so they can't really be drop-down widgets when those are implemented (which is very soon).

Sun, Jul 23, 5:12 AM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Fri, Jul 21

Mooeypoo added a comment to T166912: Implement Namespace filters and filter menu in the new UI.

The state is either on or off; if we only display it as "on" when something is selected, then a user will press that button over and over again with no result (the button will remain non-active because nothing is selected) until the user selects something, in which case the button will finally respond.

Fri, Jul 21, 10:08 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T171085: [betalabs-regression] the Legend does not collapse/expand on RC page with 'New filters for edit review' beta feature enabled.
Fri, Jul 21, 9:52 PM · Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo claimed T165286: Explore more subtle way to indicate filter loading status.
Fri, Jul 21, 12:53 AM · MW-1.30-release-notes, User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T171081: Trash can button (reset to defaults) resets days and limit in model but not UI.
Fri, Jul 21, 12:03 AM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Thu, Jul 20

Mooeypoo claimed T171129: [betalabs-regression] RC page - "No active filters. All contributions are shown" text is missing when default filters dismissed .
Thu, Jul 20, 11:08 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo added a comment to T166912: Implement Namespace filters and filter menu in the new UI.

The filters are only excluded when they're selected, according to spec. We don't highlight excluded namespaces, because they're not there, so if the filter isn't selected and is just highlighted, it won't show the "not" message because it's highlighting the namespace itself. I wouldn't touch the active state of the button itself because that lets users choose the excluding namespaces even if none is YET selected.

Thu, Jul 20, 10:51 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T162784: Integrate 'Time Period Selector' into the new filters for edit review.

I'll take a shower look at the rest of the questions, but regarding the free form input, if anyone fills in the URL (and when I implement listening to the preference of all act the same) with some number, that number is inserted in order to the most of current options. You can try that by changing days= parameter in the URL to slang custom. If you use fractions, like days=0.01 it will translate to hours and place them in order.

Thu, Jul 20, 7:32 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters

Wed, Jul 19

Mooeypoo claimed T168513: Enable 'Group results by page' preference on the RC page itself.
Wed, Jul 19, 2:21 AM · Patch-For-Review, User-notice-collaboration, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Tue, Jul 18

Mooeypoo claimed T169047: Allow to view only one "what's this" popup at a time on the filters panel.
Tue, Jul 18, 10:20 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T168651: Avoid page reloading when the filters have ended to be loaded.
Tue, Jul 18, 10:06 PM · User-notice-collaboration, MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T169063: Make saved filters title more prominent when applied.
Tue, Jul 18, 10:00 PM · MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T164861: Tweaks to Quick Links design & functions from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Tue, Jul 18, 9:25 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, User-notice-collaboration, Edit-Review-Improvements-RC-Page

Mon, Jul 17

Mooeypoo moved T166912: Implement Namespace filters and filter menu in the new UI from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Mon, Jul 17, 10:39 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Fri, Jul 14

Mooeypoo moved T164861: Tweaks to Quick Links design & functions from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Fri, Jul 14, 8:52 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, User-notice-collaboration, Edit-Review-Improvements-RC-Page
Mooeypoo added a comment to T164861: Tweaks to Quick Links design & functions.

I assigned it tor @Catrope because he implemented most of the fixes that were needed; it came back due to the spacing of the items, which is actually a slight annoyance (because of the padding/margins and icon in there)

Fri, Jul 14, 8:52 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, User-notice-collaboration, Edit-Review-Improvements-RC-Page
Mooeypoo added a comment to T162784: Integrate 'Time Period Selector' into the new filters for edit review.

So, @Catrope, technical question -- we should definitely respect the 'days' parameter on load, but do we actually need to use it in the system, or should we output 'from' with the proper timestamp for all time intervals (hours/days/month/etc) ?

days=5 and from=<5 days ago> are not the same. They are equivalent right now but one is relative while the other one is absolute. If I open a filter I've saved a week ago they don't mean the same thing anymore.

Of course you could save days in the filters and translate it to from every time you query but that seems unnecessary since the server supports days and could very easily support hours.

Fri, Jul 14, 3:58 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T162786: Integrate 'Number of Changes Selector' in the new filters for edit review from In Development to Code Review Started on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Fri, Jul 14, 1:42 AM · User-notice-collaboration, MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Design
Mooeypoo moved T162784: Integrate 'Time Period Selector' into the new filters for edit review from In Development to Code Review Started on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Fri, Jul 14, 1:42 AM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T170651: Scroll back to top when users click buttons at bottom of the main filter panel to switch to an Advanced panel .
Fri, Jul 14, 1:05 AM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Wed, Jul 12

Mooeypoo added a comment to T170214: Metrics: Get numbers for New Filters usage (and compare to baseline).

In T170214#3428591, @Mooeypoo wrote:

This is a bit of a radical suggestion, but we could try to do this part in the front end, and depend on sending the data on closing the menu.

Ingenious! Is there a way to also count Saved Filters with that, which, of course, don't require opening of the panel.

Wed, Jul 12, 12:12 AM · Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo added a comment to T170214: Metrics: Get numbers for New Filters usage (and compare to baseline).

This is a bit of a radical suggestion, but we could try to do this part in the front end, and depend on sending the data on closing the menu.

Wed, Jul 12, 12:07 AM · Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)

Tue, Jul 11

Mooeypoo moved T170329: [betalabs-regression] Monobook does not display Namespace filter icon from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.

Abandoned the RCFilter-specific fix since this got into the OOUI release today. Should be available on Beta later today.

Tue, Jul 11, 9:41 PM · Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo claimed T170329: [betalabs-regression] Monobook does not display Namespace filter icon.
Tue, Jul 11, 9:36 PM · Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)

Mon, Jul 10

Mooeypoo moved T170010: [betalabs-regression] Enhanced RC displays misaligned timestamps in a smaller font from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Mon, Jul 10, 9:59 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-RC-Page
Mooeypoo moved T170190: RC Legend - the highlight color is displayed over the Legend from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017) board.
Mon, Jul 10, 9:58 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo added a comment to T170190: RC Legend - the highlight color is displayed over the Legend .

I don't see this in Chrome or Firefox on ubuntu. What browser did you see this in?

Note that per the bug report, this only happens in non-enhanced mode. You don't need to change your prefs to disable/enable enhanced mode, you can just use ?enhanced=0.

Mon, Jul 10, 9:22 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo added a comment to T170190: RC Legend - the highlight color is displayed over the Legend .

Actually, also in Safari.

Second issue: do you see the misaligned Talk tag in this screenshot? Has that been reported?

Mon, Jul 10, 9:21 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo added a comment to T170190: RC Legend - the highlight color is displayed over the Legend .

I don't see this in Chrome or Firefox on ubuntu. What browser did you see this in?

Mon, Jul 10, 8:11 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017)
Mooeypoo added a comment to T168043: Adjust the legend on Recent Changes page.

The above fix is for the message. I'm still trying to verify where to set up the new default for expansion, that fix will come soon.

Mon, Jul 10, 3:59 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T168043: Adjust the legend on Recent Changes page from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Mon, Jul 10, 3:56 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T170161: RCFilters shows 'no filters' message even when filters are shown in the menu.
Mon, Jul 10, 3:25 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo created T170161: RCFilters shows 'no filters' message even when filters are shown in the menu.
Mon, Jul 10, 3:24 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T168043: Adjust the legend on Recent Changes page.

There's something about this that I've been uncomfortable with, and now that I see the implementation on beta the penny dropped as to what it is. Actually, there are a couple of things;

Making the legend collapsed by default: Did this, in fact, happen? If so, I don't understand the thinking behind it. It is impossible for new users to intuit the meaning of the various symbols in the legend. So if users get this page with the legend collapsed, we are making it that much harder for them to ever learn the meaning. Don't we want them to learn, and have a better understanding of the results? I suggest the box be open by default.

Using the word "Legend" by itself: In its collapsed state, the simple word "Legend" is not very explanatory as to what this is. Obviously, this problem is more severe if we make the box closed by default. But even without that, I think we can improve this. Typically, one has a 'legend" of a map or chart of some kind. Thus, to begin with, this term is not a common thing on search results. And then there's the fact that in its collapsed state it's quite small and insignificant looking. Given the width of the box here, we have some room to expatiate. So I suggest a more descriptive title. Here are some name suggestions. See if any of these work for you:

  • Legend of abbreviations
  • Abbreviations defined
  • Abbreviations used on this page
Mon, Jul 10, 3:09 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T168043: Adjust the legend on Recent Changes page.

@Mooeypoo, I see you claimed this task and that there is a Patch for Review. But it was still in Product Design, so changes were still being made to the spec.

It's now in RFP. Please review the rewritten description, above. In particular, note the change of title and the fact that the default state will be open, not closed.

Mon, Jul 10, 2:45 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters

Fri, Jul 7

Mooeypoo updated subscribers of T169910: Define language css rules in a common module shared by all skins (Mobile skin (Minerva) seems to lack definition for .mw-content-ltr).

As @matmarex points out, there already is a ticket to split out legacy modules to non-legacy ones. It seems to not be high priority, but this behavior in RTL/LTR mixes in mobile makes at least that part a priority itself. see T89981: Split the mediawiki.legacy.shared module into non-legacy manageable parts for context.

Fri, Jul 7, 7:58 PM · MinervaNeue, Front-end-Standards-Group, Patch-For-Review, Reading-Web-Backlog (Tracking)
Mooeypoo added a comment to T169910: Define language css rules in a common module shared by all skins (Mobile skin (Minerva) seems to lack definition for .mw-content-ltr).

@Volker_E I have added a proposal patch for this, making language a new module and setting it as a dependency of mediawiki.skinning.content.

Fri, Jul 7, 7:42 PM · MinervaNeue, Front-end-Standards-Group, Patch-For-Review, Reading-Web-Backlog (Tracking)

Thu, Jul 6

Mooeypoo updated subscribers of T169910: Define language css rules in a common module shared by all skins (Mobile skin (Minerva) seems to lack definition for .mw-content-ltr).

@Catrope and I checked into this, and the definition is in the mediawiki.legacy.shared module. Two conclusions strike me as action items:

Thu, Jul 6, 9:51 PM · MinervaNeue, Front-end-Standards-Group, Patch-For-Review, Reading-Web-Backlog (Tracking)
Mooeypoo created T169910: Define language css rules in a common module shared by all skins (Mobile skin (Minerva) seems to lack definition for .mw-content-ltr).
Thu, Jul 6, 5:30 PM · MinervaNeue, Front-end-Standards-Group, Patch-For-Review, Reading-Web-Backlog (Tracking)

Tue, Jul 4

Mooeypoo added a comment to T164861: Tweaks to Quick Links design & functions.

Fixing the icon size will be a bit of an issue, since that's the icon that is in OOUI, but I'll give it a try. The padding is also consistent through ooui menus, but we have a lot more leeway with it, providing the icons are not blocking a portion of it (ooui icons have whitespace around them, it's a known issue, but one that prevents us from using exact size measurements of the actual icon rather than the whole whitespace-plus-icon box, which is what the svg itself is using.

Tue, Jul 4, 7:01 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, User-notice-collaboration, Edit-Review-Improvements-RC-Page
Trizek-WMF awarded T167384: Implement navigation UI for the Advanced filters a Like token.
Tue, Jul 4, 12:57 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters
Trizek-WMF awarded T167384: Implement navigation UI for the Advanced filters a Like token.
Tue, Jul 4, 12:53 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters

Fri, Jun 30

Mooeypoo claimed T169273: [betalabs-regression] RC page - blank names for filter selection can be saved.

Oy, sorry, when we changed the way validation works, I removed the condition to treat spaces as empty.
Fixed in the commit above.

Fri, Jun 30, 4:50 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Regression
Mooeypoo assigned T169271: [wmf.7] RC filers - the loudspeaker icon is missing in RTL wikis to Catrope.
Fri, Jun 30, 12:31 AM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017)
Mooeypoo added a comment to T169273: [betalabs-regression] RC page - blank names for filter selection can be saved.

This shouldn't happen anymore, can you re-check? The "Apply" button should be disabled when the text is empty, and the saved query shouldn't be saved at all if there's nothing in the input, including when you press enter.

Fri, Jun 30, 12:29 AM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Regression

Thu, Jun 29

Mooeypoo moved T167384: Implement navigation UI for the Advanced filters from QA Review to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.

Fixed the tooltips.

Thu, Jun 29, 11:39 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T169163: [wmf.7] The new advanced filters 'Namespaces' and 'Tagged edits' displayed with old filter options from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Thu, Jun 29, 12:29 AM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017)
Mooeypoo claimed T169107: [regression] Can't remove a saved filter.
Thu, Jun 29, 12:07 AM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo edited projects for T169107: [regression] Can't remove a saved filter, added: Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017); removed Collaboration-Team-Triage.
Thu, Jun 29, 12:07 AM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters

Wed, Jun 28

Mooeypoo claimed T169163: [wmf.7] The new advanced filters 'Namespaces' and 'Tagged edits' displayed with old filter options.

Whoops. Sorry about that.

Wed, Jun 28, 11:47 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Patch-For-Review, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017)
Mooeypoo moved T169110: For some languages (here French), the label to save a set of filters is not aligned with the icons from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Wed, Jun 28, 5:49 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Edit-Review-Improvements-RC-Page
Mooeypoo claimed T169110: For some languages (here French), the label to save a set of filters is not aligned with the icons.
Wed, Jun 28, 5:49 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Edit-Review-Improvements-RC-Page
Mooeypoo moved T169042: The dialog to save filters on Recent Changes needs adjustments to better communicate the initial status from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Wed, Jun 28, 5:45 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T169042: The dialog to save filters on Recent Changes needs adjustments to better communicate the initial status.
Wed, Jun 28, 5:45 PM · MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)), Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters

Tue, Jun 27

Mooeypoo claimed T168043: Adjust the legend on Recent Changes page.
Tue, Jun 27, 7:01 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T168043: Adjust the legend on Recent Changes page.

@Pginer-WMF question that will affect implementation: What happens if there are no results? Can we not show the legend in such a case.

Tue, Jun 27, 12:41 AM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T168325: RC filters - extra space/padding for previous 'Namespace' and 'Tag filter' options is preserved .
Tue, Jun 27, 12:37 AM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-RC-Page
Mooeypoo added a comment to T168325: RC filters - extra space/padding for previous 'Namespace' and 'Tag filter' options is preserved .

Just to verify something -- those two lines may actually have something left in there from external extensions. For example, I'm a bit confused about where "Translations" went in your second set of screenshots... it should still remain, since we did not yet implement it in RCFilters.

Tue, Jun 27, 12:29 AM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-RC-Page
Mooeypoo moved T168855: Going back from "tagged edits" filter results in the filters panel losing the title from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Tue, Jun 27, 12:26 AM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T168851: Don't make the advanced filters to float at the bottom of the filters panel.
Tue, Jun 27, 12:18 AM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Jun 23 2017

RandomDSdevel awarded T166912: Implement Namespace filters and filter menu in the new UI a Doubloon token.
Jun 23 2017, 9:44 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters
RandomDSdevel awarded T166914: Implement 'Tagged edits' filters and filter menu in the new UI a Doubloon token.
Jun 23 2017, 9:44 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
RandomDSdevel awarded T167551: Number of Results and Number of Days selectors no longer function a Doubloon token.
Jun 23 2017, 9:43 PM · MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-RC-Page
RandomDSdevel awarded T165107: Highlight settings contained in RC Page URLs fail to load a Grey Medal token.
Jun 23 2017, 9:42 PM · MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-RC-Page
Liuxinyu970226 awarded T89878: mediawiki.feedback should use OOjs UI dialog a Party Time token.
Jun 23 2017, 8:51 AM · User-Ryasmeen, User-notice, WMF-deploy-2015-03-04_(1.25wmf20), VisualEditor-Performance, VisualEditor 2014/15 Q3 blockers, UI-Standardization, MediaWiki-General-or-Unknown, VisualEditor

Jun 22 2017

Mooeypoo added a comment to T75209: The document title should be dynamically updated to include a (n) notifications count in the browser title bar..

Gadget is officially available on mw.org: https://www.mediawiki.org/wiki/MediaWiki:Gadget-NotifCountTitle.js

Jun 22 2017, 12:37 AM · User-notice-collaboration, Collaboration-Team-Triage, Easy, Design, Notifications
Mooeypoo added a comment to T75209: The document title should be dynamically updated to include a (n) notifications count in the browser title bar..
Jun 22 2017, 12:19 AM · User-notice-collaboration, Collaboration-Team-Triage, Easy, Design, Notifications

Jun 21 2017

Mooeypoo added a comment to T168570: JavaScript function to update notifications.

@Nirmos I am not 100% sure where you're going with this, but in an effort to help, I created a quick and dirty gadget for you to use as a basis for whatever you need. I did end up loading mw.echo.api module, for convenience, and the required i18n message.

Jun 21 2017, 11:57 PM · Notifications, Collaboration-Team-Triage
Mooeypoo added a comment to T168387: Create the UI button to open the Adding Reminder menu.
  • Do we have a set range of options to choose from, or a free-text number with days?

Don't see a reason to limit to a fixed set of options, unless that's required for performance reasons. We may want to validate that it's an integer (not 1.5 days), depending on how often the cron job runs (though if it's general infrastructure, it will probably run often enough that we don't have to).

Jun 21 2017, 9:55 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Article-Reminder-Notifications, Notifications
Mooeypoo added a comment to T168570: JavaScript function to update notifications.

I know it is complicated right now and that's exactly what this task is about: creating and exposing an easy-to-use function so that gadget authors don't have to "inject those numbers into the html of the badges".

Jun 21 2017, 9:47 PM · Notifications, Collaboration-Team-Triage
Mooeypoo added a comment to T168570: JavaScript function to update notifications.

Opening them updates them already, so I assume you mean you want to update their counters?

Jun 21 2017, 8:51 PM · Notifications, Collaboration-Team-Triage
Mooeypoo claimed T168220: Namespace drop-down filter menu does not scrolls automatically when selected Namespace (Tag) filter capsule is clicked .
Jun 21 2017, 8:32 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017)
Mooeypoo added a comment to T168570: JavaScript function to update notifications.

What use case are you thinking about? The Special:Notifications page? The badges? They already both have a way of updating themselves, why would you need a function? Is there a specific gadget you're thinking about that needs to use it specifically?

Jun 21 2017, 8:00 PM · Notifications, Collaboration-Team-Triage

Jun 20 2017

Mooeypoo added a comment to T168387: Create the UI button to open the Adding Reminder menu.

A couple of questions we should ask to prepare for this:

Jun 20 2017, 7:24 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Article-Reminder-Notifications, Notifications

Jun 16 2017

Mooeypoo claimed T162784: Integrate 'Time Period Selector' into the new filters for edit review.
Jun 16 2017, 10:34 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T162786: Integrate 'Number of Changes Selector' in the new filters for edit review.
Jun 16 2017, 10:33 PM · User-notice-collaboration, MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)), Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Design
Mooeypoo claimed T166917: Change magnifying glass icon to hamburger in RC Filters search bar.
Jun 16 2017, 10:27 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T168090: Unbalanced margin/padding around RC filters from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Jun 16 2017, 10:26 PM · MW-1.30-release-notes, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T168090: Unbalanced margin/padding around RC filters.
Jun 16 2017, 10:25 PM · MW-1.30-release-notes, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T168091: Filter callouts anchored to close icons, instead of whole label from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Jun 16 2017, 10:09 PM · MW-1.30-release-notes, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T168091: Filter callouts anchored to close icons, instead of whole label.
Jun 16 2017, 10:09 PM · MW-1.30-release-notes, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T168089: Use 12.8 instead of 14px font size.

The new size is only implemented on the RCFilters section, and not the results list. The results list will continue to have the same size as the nojs version (font size of the content container)

Jun 16 2017, 9:48 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T168089: Use 12.8 instead of 14px font size from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Jun 16 2017, 9:42 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T168089: Use 12.8 instead of 14px font size.
Jun 16 2017, 9:42 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T167384: Implement navigation UI for the Advanced filters from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Jun 16 2017, 7:19 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T167384: Implement navigation UI for the Advanced filters .

Implemented everything except for the message footer for namespaces and tagged edits -- after a chat with @jmatazzoni, my understanding that the extra explanation in the footer in the example above is only relevant to "Users" and "Categories" which are lookup elements, and not to Namespaces and Tagged Edits.

Jun 16 2017, 7:19 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T166626: Update message copy of MediaWiki:Echo-pref-notifications-blacklist.

With the new GUI, the "Add one username per row." sentence is no longer needed.

Jun 16 2017, 5:40 PM · Collaboration-Team-Triage, Voice & Tone, Easy, Anti-Harassment, User-notice-collaboration, Support-and-Safety, Notifications

Jun 15 2017

Mooeypoo placed T167944: Provide default bookmarks for the most used sets of filters up for grabs.
Jun 15 2017, 9:15 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), User-notice-collaboration, Edit-Review-Improvements-RC-Page
Mooeypoo claimed T166914: Implement 'Tagged edits' filters and filter menu in the new UI.
Jun 15 2017, 7:11 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T166914: Implement 'Tagged edits' filters and filter menu in the new UI.

Didn't implement the (?) button yet because I don't have a link to go to -- we can add that later.
Other than that, all functionality should be there.

Jun 15 2017, 7:10 PM · Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T166912: Implement Namespace filters and filter menu in the new UI from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Jun 15 2017, 7:09 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q1-Jul-Sep-2017), Edit-Review-Improvements-Integrated-Filters

Jun 14 2017

Mooeypoo added a comment to T167384: Implement navigation UI for the Advanced filters .

@Pginer-WMF quick question -- we already have a footer in the menu right now for sending feedback about the RCFilters beta. Where do I put this footer now? Under the footers above (the text one for the tag/namespace and the button selection one for the default view) ?

Jun 14 2017, 11:30 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters
Mooeypoo updated the task description for T167919: The 'back' button should go out of RCFilters and to the previous page.
Jun 14 2017, 8:13 PM · MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017)
Mooeypoo moved T167919: The 'back' button should go out of RCFilters and to the previous page from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Jun 14 2017, 8:09 PM · MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017)
Mooeypoo created T167919: The 'back' button should go out of RCFilters and to the previous page.
Jun 14 2017, 8:09 PM · MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017)
Mooeypoo added a comment to T167384: Implement navigation UI for the Advanced filters .

@Mooeypoo, please note the most recent interchange between Pau and me, above, re. adapting his design for just the two Advanced menus we'll be launching at first. Basically, to cut to the chase, it's in this screenshot.

Jun 14 2017, 1:55 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters

Jun 13 2017

Mooeypoo moved T167384: Implement navigation UI for the Advanced filters from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Jun 13 2017, 7:17 PM · MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-Integrated-Filters

Jun 12 2017

Mooeypoo claimed T167551: Number of Results and Number of Days selectors no longer function.

This was an issue with all options that are "outside" the RCFilters dropdown. Fixed in the commit above, and will be thoroughly fixed in an upcoming commit to rewrite (and unit test!) the way we do and compare URLs.

Jun 12 2017, 1:02 PM · MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Edit-Review-Improvements-RC-Page
Mooeypoo moved T167650: All old options for Recent changes pages are not working when using the New filters Beta from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.
Jun 12 2017, 1:00 PM · Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017), Patch-For-Review, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page