Mooeypoo (Moriel Schottlender)
Software Engineer, Editing Team

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 18 2014, 11:57 PM (157 w, 16 h)
Availability
Available
IRC Nick
mooeypoo
LDAP User
Mooeypoo
MediaWiki User
Mooeypoo

Recent Activity

Sat, Nov 18

Mooeypoo claimed T180863: [wmf.7] "Excluded" label is displayed with filter selection .
Sat, Nov 18, 12:58 AM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Patch-For-Review, Regression, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo added a comment to T180863: [wmf.7] "Excluded" label is displayed with filter selection .

This was a mishap due to the fix for T177009: Only add highlight/toggle states conditionally to the saved queries

Sat, Nov 18, 12:58 AM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Patch-For-Review, Regression, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-This-Quarter)

Thu, Nov 16

Mooeypoo added a comment to T179714: All my edits on my talk page are marked as unseen in watchlist a couple of weeks.

It will be a lot easier on me if you give me the full link from the history of the page you know, rather than having me spend time looking it up and building that link ;)

Thu, Nov 16, 6:51 PM · Regression, MediaWiki-Watchlist
Mooeypoo added a comment to T179714: All my edits on my talk page are marked as unseen in watchlist a couple of weeks.

Well, @Mooeypoo, it just happened me on another page. It's still there, I did not open the page.
I can see in

https://he.wikipedia.org/w/api.php?action=query&list=watchlist&wlshow=unread&wlallrev=1&format=xmlfm&wllimit=100&wlprop=ids%7Ctitle%7Cflags%7Ccomment%7Ctimestamp

that

<item type="edit" ns="3" title="שיחת משתמש:קובץ על יד" pageid="1380285" revid="21948406" old_revid="21948371" timestamp="2017-11-16T00:34:34Z" comment="/* מנסה לייצר דף על מאגאדה */" />
Thu, Nov 16, 5:44 PM · Regression, MediaWiki-Watchlist
Mooeypoo added a comment to T179714: All my edits on my talk page are marked as unseen in watchlist a couple of weeks.

We just tried to reproduce it with various iterations - with wikitext, with the new wikitext editor, without, etc -- and none of us could reproduce it.

Thu, Nov 16, 12:18 AM · Regression, MediaWiki-Watchlist

Wed, Nov 15

Mooeypoo added a comment to T179714: All my edits on my talk page are marked as unseen in watchlist a couple of weeks.

@IKhitron I have a theory that this has to do with the difference between editing in wikitext versus editing in VisualEditor. Since talk pages are always wikitext, that might be the cause.

Both are not bold.

Wed, Nov 15, 10:21 PM · Regression, MediaWiki-Watchlist
Mooeypoo added a comment to T179714: All my edits on my talk page are marked as unseen in watchlist a couple of weeks.

@IKhitron I have a theory that this has to do with the difference between editing in wikitext versus editing in VisualEditor. Since talk pages are always wikitext, that might be the cause.

Wed, Nov 15, 5:34 PM · Regression, MediaWiki-Watchlist

Sat, Nov 4

Mooeypoo added a comment to T179714: All my edits on my talk page are marked as unseen in watchlist a couple of weeks.

Does it happen with any other page, or only your talk page?

Sat, Nov 4, 4:43 AM · Regression, MediaWiki-Watchlist

Fri, Nov 3

Mooeypoo edited projects for T174415: Make the Number of Edits and Number of Days settings sticky (and adjust the Preference pg. behavior appropriately), added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage (Collab-Team-Next-Quarter).
Fri, Nov 3, 12:17 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T174415: Make the Number of Edits and Number of Days settings sticky (and adjust the Preference pg. behavior appropriately).
Fri, Nov 3, 12:16 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T174415: Make the Number of Edits and Number of Days settings sticky (and adjust the Preference pg. behavior appropriately) from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-Next-Quarter) board.
Fri, Nov 3, 12:16 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters

Fri, Oct 27

Mooeypoo added a comment to T175826: Fix RTL on text input fields.

Hey @Amire80 and @Mooeypoo ,
quick ping to raise my chances of you seeing the notification.

It would be great for me to understand the issue with placeholders in RTL so I can make changes to the mock if necessary. I couldn't find any information on this topic anywhere so any input would be appreciated :)

Fri, Oct 27, 10:42 AM · WMDE-Fundraising-Funban-2, I18n, RTL, WMDE-Fundraising-Sprint-12, Advanced-Search, TCB-Team

Oct 19 2017

Mooeypoo claimed T178396: Other review tools has inconsistent border behavior.
Oct 19 2017, 7:09 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), Patch-For-Review, Edit-Review-Improvements, Collaboration-Team-Triage (Collab-Team-Next-Quarter)
Mooeypoo claimed T178610: [regression-wmf.4] Names of Saved filters do not get truncated.
Oct 19 2017, 7:09 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-Next-Quarter), Regression
Mooeypoo added a comment to T178396: Other review tools has inconsistent border behavior.

I see it now, sorry, I was confused.

Oct 19 2017, 6:35 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), Patch-For-Review, Edit-Review-Improvements, Collaboration-Team-Triage (Collab-Team-Next-Quarter)
Mooeypoo updated subscribers of T178396: Other review tools has inconsistent border behavior.

Unless I remember wrong, the design dictated having a border when the box is open -- but having no border on the toggle button itself, so that explains why the border disappears when minimizing.

Oct 19 2017, 5:21 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), Patch-For-Review, Edit-Review-Improvements, Collaboration-Team-Triage (Collab-Team-Next-Quarter)
Mooeypoo added a comment to T177917: Have Special:RecentChanges as URL without any options when user visits the default filters configuration.

I don't think this is a good idea at all, and honestly, I don't see why this would be an issue to the users. You can access the same page by going to the same two versions of the address -- why does it matter that new data is added in? It hurts and harms nothing.

Oct 19 2017, 3:07 AM · Collaboration-Team-Triage (Collab-Team-Next-Quarter), Edit-Review-Improvements-Integrated-Filters

Oct 16 2017

Mooeypoo added a comment to T175893: RCTopSection toplinks gets two times tabindex=0 applied, keyboard focus only needed once.

I merged the hack, but @Volker_E isn't this a bug in OOUI? We're replacing a php-ooui button with javascript ooui button, why is the tab index applied twice? Could that be the reason? Beyond fixing the individual problem, let's see if there's an issue with ooui itself here?

Oct 16 2017, 9:59 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Collaboration-Team-Triage (Collab-Team-Next-Quarter), UI-Standardization, UI-Standardization-Kanban, Accessibility, Edit-Review-Improvements

Oct 13 2017

Mooeypoo claimed T177117: Page elements still jumping around and blinking on RC page and Watchlist.
Oct 13 2017, 11:36 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo added a comment to T177117: Page elements still jumping around and blinking on RC page and Watchlist.

It seems the jumpiness on English Wikipedia's Watchlist is due to the dismissable links at the top, which caused 'jumpiness' regardless of RCFilters being enabled or not.
I can't reproduce jumpiness on Watchlist without those links.

Oct 13 2017, 11:36 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo added a comment to T177117: Page elements still jumping around and blinking on RC page and Watchlist.

The fix above corrects the jumpiness in RecentChanges; I couldn't reproduce the jumpiness in Watchlist...

Oct 13 2017, 11:32 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo added a comment to T174819: Show last 250 changes and period selection dropdowns are not keyboard accessible.

This seems all a bit mish-mashed.

From an accessibility/screenreader standpoint: The “Show last 50 changes” PopupButtonWidget carries an aria-haspopup="true" attribute, in contrast to the PopupButtonWidget demos the popup isn't added as sibling, but somewhen later in the DOM. If the popup isn't a descendant the button has to also feature a pointer via aria-owns to the popup. Don't know why the popups are separated here.

When the PopupButtonWidget-Popup were a descendant of the PopupButtonWidget and got tabindex=0 applied, I think it should be possible to tab through it flawlessly.

Oct 13 2017, 9:46 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Accessibility, Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T177926: Interface adjustments: Make the "View newest changes" link more prominent and combine pagination and time period selectors from Untriaged to Product/Design Work on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Oct 13 2017, 9:27 PM · Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo added a comment to T165550: [minor] Bookmarking no-effect filters results in 'No active filters. All contributions are shown".

States with all filters selected in send_unselected_if_any groups are not representable in the URL. We're now storing saved filters as URL parameters, so they're basically bookmarks. If we really wanted to, we could store the list of groups with redundant selections (because there's only one way in which a group can be in such a state), but that would be an annoying thing that IMO wouldn't solve that urgent of an issue.

Oct 13 2017, 5:17 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page
Mooeypoo updated subscribers of T165550: [minor] Bookmarking no-effect filters results in 'No active filters. All contributions are shown".

The way the architecture is build, this is almost impossible to change now. Filters that are redundant are represented exactly the same way as not-being-selected in the URL, so whether you're refreshing the system (re-reading the URL) or reloading a saved query (which is almost the same as reloading a URL) the query is "normalized" for you.

Oct 13 2017, 12:51 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page
Mooeypoo assigned T177009: Only add highlight/toggle states conditionally to the saved queries to SBisson.

This is dealt with here: https://gerrit.wikimedia.org/r/#/c/382531/

Oct 13 2017, 12:46 AM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo claimed T168849: Use standard round corners for advanced filters buttons on the filters panel.
Oct 13 2017, 12:37 AM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters

Oct 12 2017

Mooeypoo added a comment to T164131: Don't do unnecessary work when deleting a highlight-only tag.

So I actually started working on something like that, but ended up unsure if it actually will be faster...

Oct 12 2017, 4:52 PM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page
Mooeypoo added a subtask for T176652: Performance review of RCFilters feature: T178042: Code hygiene/performance: Batch filter update operations when we update multiple items.
Oct 12 2017, 5:16 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Performance-Team (Radar), Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a parent task for T178042: Code hygiene/performance: Batch filter update operations when we update multiple items: T176652: Performance review of RCFilters feature.
Oct 12 2017, 5:16 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T176652: Performance review of RCFilters feature.

Not sure if this is a tracking ticket but see related ticket for performance here: T178042: Code hygiene/performance: Batch filter update operations when we update multiple items

Oct 12 2017, 5:16 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Performance-Team (Radar), Edit-Review-Improvements-Integrated-Filters
Mooeypoo updated the task description for T178042: Code hygiene/performance: Batch filter update operations when we update multiple items.
Oct 12 2017, 4:53 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo updated the task description for T178042: Code hygiene/performance: Batch filter update operations when we update multiple items.
Oct 12 2017, 4:52 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo created T178042: Code hygiene/performance: Batch filter update operations when we update multiple items.
Oct 12 2017, 4:52 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T164131: Don't do unnecessary work when deleting a highlight-only tag.
Oct 12 2017, 12:11 AM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page
Mooeypoo added a comment to T164131: Don't do unnecessary work when deleting a highlight-only tag.

The commit prevents reloading if the removed tag is only highlights.
I couldn't reproduce the createTagItemWidget issue.

Oct 12 2017, 12:11 AM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page

Oct 9 2017

Mooeypoo added a comment to T177555: Can't enable ores role in vagrant.

I ran git-update and disabled and then re-enabled the role (vagrant provision in between of course)

Oct 9 2017, 10:50 PM · MediaWiki-Vagrant, Scoring-platform-team, MediaWiki-extensions-ORES

Oct 7 2017

Mooeypoo updated subscribers of T176661: Add a help link to the Tagged Edits menu.

After looking into the accessibility and icons that we have, the icon we should be using is the 'info' indicator -- which was created for this purpose. Indicators are too small for the ? button and they also don't have the i18n fixes that we use for icons (so the ? will not flip where it needs to for arabic, for example)

Oct 7 2017, 12:28 AM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, Documentation

Oct 6 2017

Mooeypoo updated subscribers of T176661: Add a help link to the Tagged Edits menu.

@Volker_E we need a question-mark indicator in OOUI to resolve this. It also seems to be a good idea in general seeing as we have an "alert" indicator "!" so there should also be room for a "?" indicator...?

Oct 6 2017, 8:40 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, Documentation
Mooeypoo added a comment to T175826: Fix RTL on text input fields.

If Google is not consistent across its own platforms or across browsers or OSes or whatever, then I retract the suggestion of using them as a de facto standard-setter. We can have a consistent way to do this, and I do believe that in the absence of a better plan, committing to the first strong character is a good way to do it. It will handle the most common cases in a good way while behaving in a predictable and understandable way in the outlier cases like my query above.

Oct 6 2017, 8:06 PM · WMDE-Fundraising-Funban-2, I18n, RTL, WMDE-Fundraising-Sprint-12, Advanced-Search, TCB-Team
Mooeypoo added a comment to T172757: Migrate and convert user preferences to the new UX.

Note: it's fixed in master by https://gerrit.wikimedia.org/r/#/c/382009 and will follow the train next week.

Oct 6 2017, 7:02 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Collaboration-Feature-Rollouts (Collaboration-RC-Graduated-Everywhere), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, MediaWiki-User-preferences
Mooeypoo added a comment to T172757: Migrate and convert user preferences to the new UX.

@SBisson, there appears to be a bug in the ORES migration features. The settings migrate to both Watchlist and RC page. You see the highlights and filters in the Active Filter area. But they don't show up in the filter menu—there, all the check boxes are empty and no highlights are showing.

Oct 6 2017, 6:53 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Collaboration-Feature-Rollouts (Collaboration-RC-Graduated-Everywhere), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, MediaWiki-User-preferences
Mooeypoo added a comment to T175826: Fix RTL on text input fields.

For better or worse, doing "what Google does" at least means that the people who encounter the issue frequently will be used to that particular behavior. If there's something obviously better, do better; otherwise, falling back to what Google does can approximate a standard when there really isn't one.

Oct 6 2017, 6:49 PM · WMDE-Fundraising-Funban-2, I18n, RTL, WMDE-Fundraising-Sprint-12, Advanced-Search, TCB-Team
Mooeypoo updated subscribers of T175826: Fix RTL on text input fields.

So, I support reasonable defaults for resolving interface/content mismatches that are quickly overridden by detection. I didn't look at Facebook, but Google desktop (google.com, Google Israel with Hebrew interface, and large text input boxes on Google Docs surveys) today is using the first strong character in the input (rather than the ratio of characters) to set the directionality. I think that not only should we do that, but that it is the backbone of solving the problem, and such a detector should be attached to any form input. (And doing so would put us ahead of Bing, Yahoo, and DuckDuckGo in terms of multi-directional UI.)

Oct 6 2017, 5:12 PM · WMDE-Fundraising-Funban-2, I18n, RTL, WMDE-Fundraising-Sprint-12, Advanced-Search, TCB-Team
Mooeypoo added a comment to T177555: Can't enable ores role in vagrant.

I manually updated composer afterwards in vagrant-ssh, and then ran foreachwiki update.php --quick and added the wg variables for ORES and it still didn't work -- but git-update is a good point that I completely forgot.

Oct 6 2017, 1:25 AM · MediaWiki-Vagrant, Scoring-platform-team, MediaWiki-extensions-ORES

Oct 5 2017

Mooeypoo created T177555: Can't enable ores role in vagrant.
Oct 5 2017, 11:03 PM · MediaWiki-Vagrant, Scoring-platform-team, MediaWiki-extensions-ORES
Mooeypoo added a comment to T175826: Fix RTL on text input fields.

Yeah funnily enough, I presented this issue in one of my recent lectures -- we seem to be treating the search input as interface, and I actually think that's completely wrong. If you search a wiki, you usually search it in the content language, so in my opinion it should be content direction. But it's located in the interface area, so it automatically gets treated as interface.

The first thing to understand is that people don't "search in the content language".

People search in whatever the **** they feel like searching. I suspect that most people don't think about the language in which they search at all. Most people are not us. Most people don't know about content language and interface language, and all that. They search in whatever is comfortable for them.

If they know only one language language, they'll probably search in that language.

If they know more than one language, they will search in one of them—not necessarily the one they know better and not necessarily the one in which they think they'll find better results.

If they know four languages, but only have a keyboard in which they can type in English... if you thought that I'm going to say that they'll search in English, then the answer, again, is "not necessarily". They may search in English, or they may just give up and not search at all, or they may try to search in transliterated English, or maybe they'll try to do some other crazy thing.

Very importantly, a lot of people don't realize that in a search box on a given wiki they have to search in the language of that wiki. I see people searching in the "wrong" language all the frikking time: searching in Hebrew, Spanish, or Russian while in the English Wikipedia, for example. Google is not perfect, but better than MediaWiki at finding the right thing despite garbage in its search box, and people quite understandably expect the same from other websites. That's why I put "wrong" in double quotes—our software makes it wrong, but in 2017 that's not what people want and need.

Oct 5 2017, 9:37 PM · WMDE-Fundraising-Funban-2, I18n, RTL, WMDE-Fundraising-Sprint-12, Advanced-Search, TCB-Team
Mooeypoo added a comment to T175826: Fix RTL on text input fields.

Classes (@Amire80 please add/adjust if I missed any)

Oct 5 2017, 6:51 PM · WMDE-Fundraising-Funban-2, I18n, RTL, WMDE-Fundraising-Sprint-12, Advanced-Search, TCB-Team
Mooeypoo updated subscribers of T175826: Fix RTL on text input fields.

Yeah funnily enough, I presented this issue in one of my recent lectures -- we seem to be treating the search input as interface, and I actually think that's completely wrong. If you search a wiki, you usually search it in the content language, so in my opinion it should be content direction. But it's located in the interface area, so it automatically gets treated as interface.

Oct 5 2017, 5:29 PM · WMDE-Fundraising-Funban-2, I18n, RTL, WMDE-Fundraising-Sprint-12, Advanced-Search, TCB-Team

Oct 4 2017

Mooeypoo added a comment to T176367: Watchlist css classes are messed up.

@IKhitron I tried to find exactly where the change came from and failed to find an exact match, but I think I know what happened. As part of the RCFilters fix, we've been updating the way highlighting works and the way that the enhanced list displays itself. 99% of the changes were done only for the beta activated, but while we were working we found a few underlying bugs that were also fixed. (The interesting thing about a bug, is that when it's a 7-8 year old bug, it's usually considered a "feature" even though it's clearly not... ;)

Oct 4 2017, 6:18 PM · Regression, CSS, MediaWiki-Watchlist
Mooeypoo added a comment to T175826: Fix RTL on text input fields.

Sorry, a tiny addition that hopefully will make things clearer too:

Oct 4 2017, 5:19 PM · WMDE-Fundraising-Funban-2, I18n, RTL, WMDE-Fundraising-Sprint-12, Advanced-Search, TCB-Team
Mooeypoo added a comment to T175826: Fix RTL on text input fields.

Generally, turning the entire content block 'rtl' direction would impact the inputs as well, and having interface elements will be impacted by the interface direction classes -- so both of those should work out of the box without doing anything.

Oct 4 2017, 5:09 PM · WMDE-Fundraising-Funban-2, I18n, RTL, WMDE-Fundraising-Sprint-12, Advanced-Search, TCB-Team

Sep 29 2017

Mooeypoo added a comment to T177009: Only add highlight/toggle states conditionally to the saved queries.

@jmatazzoni The issue is more about recognizing your saved query once you load it.

Sep 29 2017, 3:57 AM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)

Sep 28 2017

Mooeypoo added a comment to T177009: Only add highlight/toggle states conditionally to the saved queries.

The two rules above will be reproduced the same for the 'invert' button if it's on or off regarding whether there are namespaces chosen.

Did you mean "the rule above", rather than "the two rules above"? The rule above (the second rule) makes sense: the invert state should not be stored if no namespaces were selected. But the one above that (the first one) doesn't make sense to me: if the invert button is off, but namespaces are selected, those namespaces are still meaningful and should still be stored.

Sep 28 2017, 9:16 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo updated the task description for T177009: Only add highlight/toggle states conditionally to the saved queries.
Sep 28 2017, 7:11 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo created T177009: Only add highlight/toggle states conditionally to the saved queries.
Sep 28 2017, 7:09 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)

Sep 21 2017

Mooeypoo claimed T176380: Stop community links from opening then closing on Recent changes.
Sep 21 2017, 9:50 PM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Performance, Edit-Review-Improvements

Sep 20 2017

Mooeypoo moved T176250: Defer building new filters menu to speed up performance from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Sep 20 2017, 11:39 PM · User-notice-collaboration, MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Performance, Edit-Review-Improvements

Sep 19 2017

Mooeypoo created T176237: ContentTranslation on Hebrew Wiki crashes on Chrome for a page with multiple templates.
Sep 19 2017, 5:29 PM · Language-2017-Oct-Dec, ContentTranslation

Sep 18 2017

Mooeypoo removed a project from T168835: Make icons size more consistent for Recent Changes filters: User-Petar.petkovic.
Sep 18 2017, 8:01 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T168835: Make icons size more consistent for Recent Changes filters from Ready for Pickup to Blocked on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Moving this to blocked, as per @Volker_E's comment. This is a standardization issue, and fixing/overriding it specifically in RCFilters may do more damage than good to overall support.

Sep 18 2017, 8:00 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T175217: Tweak UI for main filtering entry point from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Sep 18 2017, 7:17 PM · Collaboration-Team-Triage, MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T172387: Cannot set my default to see all results (no filters) from QA Review to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Bringing back to 'needs review' with the new fix.

Sep 18 2017, 6:09 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page

Sep 15 2017

Mooeypoo added a comment to T172387: Cannot set my default to see all results (no filters).

The patch above works well but it creates a weird situation: when you save the empty state as your default filter, the "Restore default filters" button is visible even though you currently have your default filters.

Sep 15 2017, 12:05 AM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page

Sep 14 2017

Mooeypoo added a comment to T172387: Cannot set my default to see all results (no filters).

The patch above works well but it creates a weird situation: when you save the empty state as your default filter, the "Restore default filters" button is visible even though you currently have your default filters.

Sep 14 2017, 9:42 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page
Mooeypoo moved T175965: Days default value does not retain a fraction from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Sep 14 2017, 9:14 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo created T175965: Days default value does not retain a fraction.
Sep 14 2017, 9:14 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo updated subscribers of T174819: Show last 250 changes and period selection dropdowns are not keyboard accessible.

Pinging @Volker_E and @matmarex on this; I took a look and I can shift focus into the popup when you open the popup, which then allows you to tab through the elements in there -- however, while OO.ui.ButtonSelectWidget miexes in OO.ui.mixin.TabIndexedElement, OO.ui.ButtonOptionWidget isn't -- so I can't set a tabindex for it.

Sep 14 2017, 12:35 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Accessibility, Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T174732: Logged actions selected by namespace filters cannot be highlighted from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Whoops. Fixed in this commit.

Sep 14 2017, 12:18 AM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page
Mooeypoo claimed T172387: Cannot set my default to see all results (no filters).
Sep 14 2017, 12:14 AM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page

Sep 13 2017

Mooeypoo claimed T167262: Server-launched guided tour can show on the wrong page if the user navigates away before full page load.
Sep 13 2017, 11:41 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Patch-For-Review, Edit-Review-Improvements-RC-Page, MediaWiki-extensions-GuidedTour, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo moved T175697: Don't move the Filter search bar when user clicks on it from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Sep 13 2017, 10:31 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T175697: Don't move the Filter search bar when user clicks on it.
Sep 13 2017, 10:30 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T175867: [wmf.18 - regression] oo-ui-iconElement-icon oo-ui-icon-userAvatar and others are missing in Echo notifications.
Sep 13 2017, 10:19 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression, Collab-Notifications-Page
Mooeypoo assigned T174454: [wmf.15] 'Save current filter settings' cancel button (X) is misaligned to Petar.petkovic.
Sep 13 2017, 8:54 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, User-Petar.petkovic, Edit-Review-Improvements, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo claimed T174732: Logged actions selected by namespace filters cannot be highlighted .

Should be fixed alongside T174734: Changes to namespaces are not highlighted as requested if 'Group results by page' is enabled

Sep 13 2017, 12:58 AM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page
Mooeypoo claimed T174734: Changes to namespaces are not highlighted as requested if 'Group results by page' is enabled.

Some of the results seem to not be properly tagged with the 'mw-changeslist-ns-1' class in the backend. Fixing.

Sep 13 2017, 12:44 AM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter)

Sep 12 2017

Mooeypoo added a comment to T174111: [wmf.16-regression] Saved query names displayed shifted up.

This most likely happened after we changed the saved queries title from "we don't care how long this is" to "trim it at 1 line". The display options make it hard to align now, but need to be looked into.

Sep 12 2017, 5:08 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, User-Petar.petkovic, Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo added a comment to T169613: Introduce the New Filters to users upon beta graduation.

In T169613#3593044, @Mooeypoo wrote:

@jmatazzoni question/clarification; as @Mattflaschen-WMF pointed out in review, the current code will only work in Special:RecentChanges. I could make it work in all other pages (Watchlist and RelatedChanges) but the language of the tour is specific to "RecentChanges".

I am going to keep this as-is for now; if you want this tour to also be the same behavior for Watchlist or RecentChanges (this also applies to the "invite to the beta feature") then let's create a child task and make sure we have adequate wording for the tour displaying on the other pages.

@Mooeypoo, will what you've done work on Related Changes? That's the only other place we'll want this .No need for Watchlist. Thanks.

Sep 12 2017, 5:02 PM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters

Sep 8 2017

Mooeypoo added a comment to T169613: Introduce the New Filters to users upon beta graduation.

@jmatazzoni question/clarification; as @Mattflaschen-WMF pointed out in review, the current code will only work in Special:RecentChanges. I could make it work in all other pages (Watchlist and RelatedChanges) but the language of the tour is specific to "RecentChanges".

Sep 8 2017, 9:41 PM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters

Sep 1 2017

Mooeypoo added a comment to T173970: pt-notifications-alert > a has "Notices (0)" as text on first load, but changes to "0" on click.

(from an IRC conversation) -

Sep 1 2017, 11:52 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage, Notifications
Mooeypoo added a comment to T173970: pt-notifications-alert > a has "Notices (0)" as text on first load, but changes to "0" on click.

This sounds a little weird; the nojs CSS should override the number from the beginning, regardless of JS (without having to wait for load)

Sep 1 2017, 10:11 PM · MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, Collaboration-Team-Triage, Notifications
Mooeypoo added a comment to T169613: Introduce the New Filters to users upon beta graduation.

@Pginer-WMF, I rewrote this to make it into a spec for developers and moved it to RFP. Please look it over to make sure it's correct. Also, if you need to provide any icons, etc (like the gear, perhaps?), please add them to the Description above. Thanks.

The spec looks good.
One aspect missing is when this would be removed, since at some point the new filters would be the normal experience, but we can create a separate ticket for that if needed.

The cog icon is part of the standard set of icons, which I think can be adjusted to any color in code. In any case, if a specific blue version is needed, I added it below:

Sep 1 2017, 5:14 PM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
Trizek-WMF awarded T169613: Introduce the New Filters to users upon beta graduation a Like token.
Sep 1 2017, 1:32 PM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T169613: Introduce the New Filters to users upon beta graduation.

@Pginer-WMF Do you have a copy of the gear icon in the proper size/color? I couldn't find it (I was sure we used it before, but I guess I was wrong?)

Sep 1 2017, 1:14 AM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
Mooeypoo claimed T169613: Introduce the New Filters to users upon beta graduation.
Sep 1 2017, 12:10 AM · MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters

Aug 31 2017

Mooeypoo added a comment to T172957: Live Update causes problems with "Navigation popups" gadget.

I am not 100% sure of the reprecussions of this to other products, so I don't want to edit the actual code, but it seems like it's reasonable to expect that any time wikipage.content hook is fired, the popups should reset.

Aug 31 2017, 12:06 AM · User-Petar.petkovic, Navigation-Popups, Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page, Edit-Review-Improvements-Integrated-Filters

Aug 30 2017

Mooeypoo moved T173533: No longer block user from clicking results when page is loading. from Ready for Pickup to Blocked on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

Moving to blocked, as this is waiting on two patches that are less urgent but need to be merged enough time before a cut to allow for rigorous testing.

Aug 30 2017, 11:35 PM · MW-1.30-release-notes, MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page
Mooeypoo moved T174617: Make 'Other review tools' (MediaWiki:Recentchangestext box) span the entire page from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Aug 30 2017, 11:28 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-Recent-changes, Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T174617: Make 'Other review tools' (MediaWiki:Recentchangestext box) span the entire page from Ready for Pickup to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Aug 30 2017, 10:40 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-Recent-changes, Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T170875: Improve highlighting display so it's compatible with 'Group results by page" preference.

@Mooeypoo please note the above new requirement. I know there is some complication in the structure of this page. Will that be possible without heroic efforts?

Aug 30 2017, 5:02 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)

Aug 29 2017

Mooeypoo claimed T174506: [wmf.16-regression] Default filters with Excluded namespaces don't preserve exclude status when loaded via 'Restore default filters'.
Aug 29 2017, 10:05 PM · MW-1.30-release-notes, Patch-For-Review, Edit-Review-Improvements, Regression, Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo added a comment to T172030: Integrate Watchlist-management links and page info into the new UX.

@jmatazzoni Took a look and said there's no problem with removing the icon if it's a hassle technically.

Aug 29 2017, 7:12 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-Watchlist
Mooeypoo added a comment to T172030: Integrate Watchlist-management links and page info into the new UX.

Looking at the text here:

Aug 29 2017, 6:05 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-Watchlist
Mooeypoo added a comment to T170875: Improve highlighting display so it's compatible with 'Group results by page" preference.

The indendation was the intended behavior according to the spec I understood, and reworking it is a pretty big mess because of the wya that the "enhanced" display works with big tables and "placeholder" cells.
@jmatazzoni looked at it on my computer yesteday and seemed to be happy with it.

Aug 29 2017, 4:12 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)

Aug 28 2017

Mooeypoo moved T173264: Tweaks to the pushpin icon design and functionality from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Aug 28 2017, 11:14 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page
Mooeypoo added a comment to T173264: Tweaks to the pushpin icon design and functionality.

Whoops, my CSS selectors were too broad. Fixed in this commit.

Aug 28 2017, 10:32 PM · MW-1.30-release-notes, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page
Mooeypoo claimed T174193: The names of new Saved Filters don't appear as expected in the Active Filter area .
Aug 28 2017, 8:08 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)

Aug 26 2017

Mooeypoo moved T171235: Standardize system for indicating unseen/seen changes on Watchlist from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Aug 26 2017, 1:04 AM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, MediaWiki-Watchlist

Aug 24 2017

Mooeypoo claimed T171235: Standardize system for indicating unseen/seen changes on Watchlist.
Aug 24 2017, 11:56 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, MediaWiki-Watchlist