Mooeypoo (Moriel Schottlender)
Software Engineer, Editing Team

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 18 2014, 11:57 PM (190 w, 5 d)
Availability
Available
IRC Nick
mooeypoo
LDAP User
Mooeypoo
MediaWiki User
Mooeypoo [ Global Accounts ]

Recent Activity

Fri, Jul 13

Mooeypoo added a comment to T198931: Date input overlay should not be cut-off if the input is at the bottom of the dialog.

I found the culprit and fixed it; the WindowManager has z-index set for 101; I set the popup overlay to be 110. It works for me now.

Fri, Jul 13, 8:18 PM · Community-Tech-Sprint, Patch-For-Review, MediaWiki-extensions-TemplateWizard
Mooeypoo added a comment to T190231: Add all the overlays required for TemplateWizard.

I think by default, actions appear on top and bottom, so while that is considered OOUI dialog's "normal" behavior (to have buttons on footer/top, if the design is different here, then we shouldn't bother.
An ActionWidget would just be a [widget][button] set, like input/button or input/label, etc.

Fri, Jul 13, 5:06 AM · Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard

Thu, Jul 12

Mooeypoo added a comment to T198494: New Pages Feed: Disable page curation toolbar in draft namespace (1.6).

That's okay, testwiki is one commit behind at the mo'; it'll be updated in about 7 hours (I think?).

Thu, Jul 12, 4:40 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Community-Tech-Sprint
Mooeypoo added a comment to T198931: Date input overlay should not be cut-off if the input is at the bottom of the dialog.

@Mooeypoo your patch gives me this:

because the .mw-widget-dateInputWidget-calendar has a z-index of 1 I guess... I'm trying to track down why it's getting the bottom scroll bar (it shouldn't ever, should it?).

Thu, Jul 12, 3:37 AM · Community-Tech-Sprint, Patch-For-Review, MediaWiki-extensions-TemplateWizard
Mooeypoo added a comment to T198913: Throw an error from the local preferences set API if pref is overridden.

Okay, here's my general thoughts on this, but I think we should delve a little deeper and make some decisions about what we consider a good default behavior for these things.

Thu, Jul 12, 1:27 AM · MediaWiki-extensions-GlobalPreferences, Community-Tech-Sprint

Wed, Jul 11

Mooeypoo raised the priority of T198137: Selenium "User should be able to change preferences" test flaky from High to Unbreak Now!.

I'm changing this to unbreak now, since we can't merge anything into PageTriage. It consistently fails, due to #3. Please help on this.

Wed, Jul 11, 5:56 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, User-zeljkofilipin, Release-Engineering-Team (Kanban), MediaWiki-User-preferences, Wikimedia-log-errors (Shared Build Failure), MediaWiki-Core-Tests

Tue, Jul 10

Mooeypoo added a parent task for T198935: Clean up the mess with one-off transformations for some preferences: T197260: Create an API module to allow apps to set local exceptions.
Tue, Jul 10, 11:43 PM · Patch-For-Review, MediaWiki-API, Community-Tech-Sprint, MediaWiki-User-preferences
Mooeypoo added a subtask for T197260: Create an API module to allow apps to set local exceptions: T198935: Clean up the mess with one-off transformations for some preferences.
Tue, Jul 10, 11:43 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-GlobalPreferences
Mooeypoo added a comment to T195545: New Pages Feed: add drafts to the feed (1.1).

@MMiller_WMF this is on testwiki, ready for your review.

Tue, Jul 10, 11:38 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Community-Tech-Sprint, English-Wikipedia-New-Pages-Patrol
Mooeypoo added a comment to T195924: New Pages Feed: filter to draft states (1.2).

@MMiller_WMF This is in test wiki, testable.

Tue, Jul 10, 11:36 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Community-Tech-Sprint, English-Wikipedia-New-Pages-Patrol
Mooeypoo updated subscribers of T198364: PageTriage with AfC option: Options removed from NPP option are incorrectly saved when switching to AfC.

@MMiller_WMF this is ready to test; let me know if my reproduction explanation is lacking -- the title language is a little confusing.

Tue, Jul 10, 11:31 PM · Growth-Team, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Community-Tech-Sprint, Collaboration-Team-Triage, MediaWiki-extensions-PageCuration
Mooeypoo added a comment to T198137: Selenium "User should be able to change preferences" test flaky.

Another failure; same as #3, but happened today as well: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/6989/consoleFull

Tue, Jul 10, 5:14 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, User-zeljkofilipin, Release-Engineering-Team (Kanban), MediaWiki-User-preferences, Wikimedia-log-errors (Shared Build Failure), MediaWiki-Core-Tests

Fri, Jul 6

Mooeypoo added a comment to T198931: Date input overlay should not be cut-off if the input is at the bottom of the dialog.

Yep. If you look at the Echo popup and try to open a sub menu (dotdotdot) at the lower end, you'll see it opens downwards but isn't confined by the general popup.

Fri, Jul 6, 5:54 PM · Community-Tech-Sprint, Patch-For-Review, MediaWiki-extensions-TemplateWizard
Mooeypoo added a comment to T198926: The input fields should not be focused when the field is removed.

I would definitely not lose it completely; I'm thinking of keyboard accessibility, and losing focus is not really helpful.

Fri, Jul 6, 3:46 AM · Community-Tech, MediaWiki-extensions-TemplateWizard
Mooeypoo added a comment to T198926: The input fields should not be focused when the field is removed.

Yeah, those aren't buttons, though, those are OptionWidgets.... They're not quite the UX of a "click to do an action" but more of a "I select this content to see" so the behavior is different, but we might be able to get something similar with volker's assistance.

Fri, Jul 6, 3:15 AM · Community-Tech, MediaWiki-extensions-TemplateWizard
Mooeypoo added a comment to T198926: The input fields should not be focused when the field is removed.

That's ooui's focus feature for accessibility. I'd highly recommend against removing it... :/

Fri, Jul 6, 2:52 AM · Community-Tech, MediaWiki-extensions-TemplateWizard
Mooeypoo added a comment to T198926: The input fields should not be focused when the field is removed.

I'm confused; is the text input focused or the button? If it's the button, you just clicked it, it looks like the correct behavior? What should happen instead?

Fri, Jul 6, 12:47 AM · Community-Tech, MediaWiki-extensions-TemplateWizard
Mooeypoo added a comment to T198931: Date input overlay should not be cut-off if the input is at the bottom of the dialog.

That's actually pretty complicated. We have a couple of tasks about similar issue with pop-ups that we need to fix in ooui. It has to do with changing the logic of popup widget and clippable and its a bit of a mess.

Fri, Jul 6, 12:21 AM · Community-Tech-Sprint, Patch-For-Review, MediaWiki-extensions-TemplateWizard

Thu, Jul 5

Mooeypoo added a comment to T111735: Non-breaking spaces break page layout when confirming thanks in diff view.

This is probably coming from the animation. Without your patch, there is an "opening" animation going on when the "Are you sure..." is appearing. In order to make it work, it has to start with width:0 and end with its natural width. When the string is not wrapping, the span "just" grows into the full line -- but when we make the string wrap, the changing width actually changes how much the text wraps -- which changes the height too.

Thu, Jul 5, 3:31 PM · Growth-Team, Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, JavaScript, Thanks

Tue, Jul 3

Mooeypoo updated subscribers of T193262: TemplateWizard: RTL support .

Followup from discussion in teh gerrit commit, putting my full analysis here for posterity:

Tue, Jul 3, 5:02 PM · Patch-For-Review, I18n, RTL, MediaWiki-extensions-TemplateWizard, Community-Tech
Mooeypoo added a comment to T190348: Improve usability of TemplateWizard.

@Mooeypoo I agree with your decent estimation of work (“non-trivial”) needed. Would you clarify with @cmadeo what the default would result in and also please both, feel encouraged to file follow-up tasks on any identified UX shortcomings of OOUI dialogs.

Tue, Jul 3, 4:08 PM · Community-Tech, MediaWiki-extensions-TemplateWizard

Mon, Jul 2

Mooeypoo added a comment to T190348: Improve usability of TemplateWizard.

@Volker_E The way we currently have those messages with OO.ui.Alert() is that they pop a secondary window on top of the existing window. I agree this looks weird, and I'd love us to fix it, but we should do that in OOUI itself, not in this product.

Mon, Jul 2, 10:51 PM · Community-Tech, MediaWiki-extensions-TemplateWizard
Krinkle awarded T198231: OO.ui.mixin.GroupElement: Add and remove operations are not no-ops if there are no items given a Orange Medal token.
Mon, Jul 2, 9:08 PM · Patch-For-Review, OOUI
Mooeypoo added a comment to F23081670: 2018-06-30 01-48-36.mkv.

@Hagarshilo this is pretty interesting... one idea that you could explore is to have your fix only work for diff pages. Look for a class (probably on <body>) that is on diff pages specifically, and add that class as a super selector to your rule.
IT's not a perfect solution, since the original bug may happen in history pages too, but it seems to have less chances of existing there anyways (?)

Mon, Jul 2, 7:32 PM
Mooeypoo added a comment to T197065: New Filters for Edit Review: UI displays poorly when the window is narrow.

Some minor bootstrap like changes:

        /* equal cells which wrap, with 1em of space in between */
	.mw-rcfilters-ui-row {
		display:flex;
		flex-wrap: wrap;
		justify-content: space-between;
		margin: 0 -0.5em;
	}
	.mw-rcfilters-ui-cell {
		flex: 1 1;
		padding: 0 0.5em;
	}
Mon, Jul 2, 3:40 PM · Collaboration-Team-Triage, MonoBook, Timeless, Edit-Review-Improvements-Integrated-Filters

Sun, Jul 1

Mooeypoo added a comment to T192275: Fix "Tags" padding to have it less close to the edge.

@Mooeypoo Thanks for raising this. From a UI library perspective I don't see this as a general use case. The sense behind a ButtonSelectWidget is IMO to visualize that you can choose 1 out of n options and you get visual/aural feedback about it.
In the case of RCFilters it's not visible for the user that this is a ButtonSelect nor does it have to necessarily be exposed. Internally it might be preferable for simpler handling. Therefore I'd be against adding code on library side for ButtonSelectWidgets with frameless buttons. It speaks against the UX concept of a ButtonSelectWidget.

Sun, Jul 1, 12:49 AM · Growth-Team, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Easy, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters

Sat, Jun 30

Mooeypoo moved T198445: Markers not appearing from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Sat, Jun 30, 3:37 AM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, MediaWiki-Watchlist

Fri, Jun 29

Mooeypoo claimed T198513: Watchlist bullets missing colors.
Fri, Jun 29, 8:43 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-Watchlist
Mooeypoo added a project to T198513: Watchlist bullets missing colors: Collaboration-Team-Triage (Collab-Team-This-Quarter).

Hmm. This is odd, but it seems to be the same problem as T198445: Markers not appearing. I can't reproduce this exact effect to test if that patch fixes it, but just from generally knowing what caused the previous patch (mismatching selectors) I anticipated this one may be fixed as well.

Fri, Jun 29, 8:43 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), MediaWiki-Watchlist
Mooeypoo moved T198445: Markers not appearing from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Fri, Jun 29, 6:56 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, MediaWiki-Watchlist
Mooeypoo added a project to T198445: Markers not appearing: Collaboration-Team-Triage (Collab-Team-This-Quarter).
Fri, Jun 29, 6:56 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, MediaWiki-Watchlist
Mooeypoo added a comment to T198445: Markers not appearing.

@Mooeypoo assigning the task to you as you're working on the patch.

Fri, Jun 29, 4:03 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, MediaWiki-Watchlist

Thu, Jun 28

Mooeypoo added a comment to T198291: Fix display of description (when long).

We could add a "read more" link under (or at the end) of the template description that sends people to the template page, and with that, get rid of the need to show long descriptions anyways?

Thu, Jun 28, 11:15 PM · Patch-For-Review, Community-Tech-Sprint, MediaWiki-extensions-TemplateWizard
Mooeypoo moved T198364: PageTriage with AfC option: Options removed from NPP option are incorrectly saved when switching to AfC from Ready to Needs Review/Feedback on the Community-Tech-Sprint board.
Thu, Jun 28, 8:51 PM · Growth-Team, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Community-Tech-Sprint, Collaboration-Team-Triage, MediaWiki-extensions-PageCuration
Mooeypoo claimed T198364: PageTriage with AfC option: Options removed from NPP option are incorrectly saved when switching to AfC.

This probably isn't the best solution ever, sicne it will override previous values -- but it only happens if the user unclicked both checkboxes anyways, and it will only potentially override the specific unreviewed/reviewed checkbox state, so I think that's acceptable for a quickfix.

Thu, Jun 28, 8:50 PM · Growth-Team, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Community-Tech-Sprint, Collaboration-Team-Triage, MediaWiki-extensions-PageCuration
Mooeypoo added a subtask for T195545: New Pages Feed: add drafts to the feed (1.1): T198364: PageTriage with AfC option: Options removed from NPP option are incorrectly saved when switching to AfC.
Thu, Jun 28, 3:49 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Community-Tech-Sprint, English-Wikipedia-New-Pages-Patrol
Mooeypoo added a parent task for T198364: PageTriage with AfC option: Options removed from NPP option are incorrectly saved when switching to AfC: T195545: New Pages Feed: add drafts to the feed (1.1).
Thu, Jun 28, 3:49 PM · Growth-Team, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Community-Tech-Sprint, Collaboration-Team-Triage, MediaWiki-extensions-PageCuration

Wed, Jun 27

Mooeypoo created T198364: PageTriage with AfC option: Options removed from NPP option are incorrectly saved when switching to AfC.
Wed, Jun 27, 11:28 PM · Growth-Team, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Community-Tech-Sprint, Collaboration-Team-Triage, MediaWiki-extensions-PageCuration

Tue, Jun 26

Mooeypoo created T198231: OO.ui.mixin.GroupElement: Add and remove operations are not no-ops if there are no items given.
Tue, Jun 26, 4:30 PM · Patch-For-Review, OOUI

Mon, Jun 25

stjn awarded T198139: Move construction of highlight containers to server a Like token.
Mon, Jun 25, 9:03 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Performance, Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T190161: NamespaceFilters: backspace on "pills" edits namespace id, not name .

Hmm. This is a question we should discuss and solve in general, but there are multiple reasons why widgets (it's not just TagMultiselectWidget, it's also Combo*Widget, MenuSelectWidget, and the entire inner operations of 'findItemByData()' in OOUI) look for items by their data rather than label.

Mon, Jun 25, 3:46 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, OOUI, WMDE-FUN-Sprint-2018-06-25, Design, WMDE-Design, TCB-Team, Advanced-Search

Thu, Jun 21

Mooeypoo added a member for Community-Tech-Sprint: Mooeypoo.
Thu, Jun 21, 10:15 PM
Mooeypoo added a member for Community-Tech: Mooeypoo.
Thu, Jun 21, 10:14 PM
Mooeypoo added a watcher for Community-Tech: Mooeypoo.
Thu, Jun 21, 10:14 PM

Wed, Jun 20

Mooeypoo updated subscribers of T192275: Fix "Tags" padding to have it less close to the edge.

While we fix this specifically for RCFilters, I think this shows a discrepancy we have in OOUI as well.

Wed, Jun 20, 11:21 PM · Growth-Team, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Easy, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T197833: Results "jump" after load in RCFilters in Watchlist from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Wed, Jun 20, 9:46 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page
Mooeypoo created T197833: Results "jump" after load in RCFilters in Watchlist.
Wed, Jun 20, 9:45 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page

Tue, Jun 19

Mooeypoo added a comment to T181165: In chapter wikis can't see notifications from other wikis on Special:Notifications due to lack of CORS whitelisting.

ilwikimedia -> https://il.wikimedia.org

{$lang}wikimedia -> https://$lang.wikimedia.org

Tue, Jun 19, 10:11 PM · Growth-Team, Wikimedia-Site-requests, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
Mooeypoo added a comment to T181165: In chapter wikis can't see notifications from other wikis on Special:Notifications due to lack of CORS whitelisting.
Tue, Jun 19, 8:42 PM · Growth-Team, Wikimedia-Site-requests, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
Mooeypoo added a comment to T181165: In chapter wikis can't see notifications from other wikis on Special:Notifications due to lack of CORS whitelisting.

I should note, we don't explicitly whitelist *.wikimedia.org as some things aren't wikis (see phabricator), and some stuff aren't wikis but also are hosted offsite by a third party (see https://status.wikimedia.org/)

Tue, Jun 19, 8:40 PM · Growth-Team, Wikimedia-Site-requests, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
Mooeypoo added a comment to T181165: In chapter wikis can't see notifications from other wikis on Special:Notifications due to lack of CORS whitelisting.

I've whitelisted the chapters that are wikis or have a wiki inside (that I am aware of).
I've listed below the chapters that are not wikis and do not seem to contain a wiki.

wikimedia.org.ar
wikimedia.at
wikimedia.org.au
wikimedia.org.bd
wikimedia.ch
wikimedia.de
wikimedia.es
wikimedia.fr
wikimedia.org.il
wikimedia.it
wikimedia.nl
wikimedia.co.za // Site can't be reached

I don't think we should be whitelisting wikis that aren't hosted by Wikimedia...

Tue, Jun 19, 8:21 PM · Growth-Team, Wikimedia-Site-requests, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications

Mon, Jun 18

Mooeypoo moved T191534: Saved filters empty state needs adjustment from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Mon, Jun 18, 10:53 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice-collaboration, Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a subtask for T158400: Streamline & improve tag component TagMultiselectWidget (former CapsuleMultiselectWidget): T197636: MenuTagMultiselectWidget: Menu sometimes disappears when the cursor is still inside the input.
Mon, Jun 18, 10:51 PM · Design, OOUI, UI-Standardization
Mooeypoo added a parent task for T197636: MenuTagMultiselectWidget: Menu sometimes disappears when the cursor is still inside the input: T158400: Streamline & improve tag component TagMultiselectWidget (former CapsuleMultiselectWidget).
Mon, Jun 18, 10:51 PM · OOUI
Mooeypoo created T197636: MenuTagMultiselectWidget: Menu sometimes disappears when the cursor is still inside the input.
Mon, Jun 18, 10:50 PM · OOUI
Mooeypoo added a comment to T177206: Make Active Filter display area collapsible on Watchlist and Recent Changes.

@Etonkovidova writes:

However, the 'Hide/Show' option adds only one line vs. about three lines in the mockups. Also there is a lot of empty space.

These two facts, just to state what should be obvious, are related. Which is to say, when the filters go into "hide" mode, the a large space is opening up between the "list of abbreviations" box and the "250 changes, 30 days" button.

The spacing between those two elements should remain the same in hide and show mode. That is does not is why the results aren't moving up and the hide isn't saving more than just one line of results.

Mon, Jun 18, 6:22 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
Mooeypoo assigned T181165: In chapter wikis can't see notifications from other wikis on Special:Notifications due to lack of CORS whitelisting to Hagarshilo.
Mon, Jun 18, 4:50 PM · Growth-Team, Wikimedia-Site-requests, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications

Jun 13 2018

Mooeypoo updated subscribers of T195048: Add a Telegram frontend for Echo notifications.

I am going to raise a slightly philosophical point, so bear with me, and let's discuss a bit.

Jun 13 2018, 3:52 PM · Collaboration-Team-Triage, Easy, Patch-For-Review, Notifications
Mooeypoo moved T177206: Make Active Filter display area collapsible on Watchlist and Recent Changes from Needs Review to Code Review Started on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Jun 13 2018, 3:48 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T197011: Full-width maps cannot be properly edited in VisualEditor from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Jun 13 2018, 2:06 AM · Patch-For-Review, Maps, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo claimed T177206: Make Active Filter display area collapsible on Watchlist and Recent Changes.
Jun 13 2018, 2:05 AM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
Mooeypoo added a comment to T177206: Make Active Filter display area collapsible on Watchlist and Recent Changes.

@Pginer-WMF I went by your designs, but I had a problem creating the separator line between the "show/hide" button and the query name; I could only get it to be 100% height (from top to bottom) and I can't manage to get it to be a smaller one.

Jun 13 2018, 2:03 AM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters

Jun 12 2018

Mooeypoo claimed T197011: Full-width maps cannot be properly edited in VisualEditor.
Jun 12 2018, 5:29 PM · Patch-For-Review, Maps, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter)
Mooeypoo created T197011: Full-width maps cannot be properly edited in VisualEditor.
Jun 12 2018, 3:20 PM · Patch-For-Review, Maps, Collaboration-Feature-Rollouts (Collaboration-Maps), Collaboration-Team-Triage (Collab-Team-This-Quarter)

Jun 11 2018

Mooeypoo moved T192251: Mapframes with a width of 100% fail to display on the mobile site unless "frameless" is used from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Jun 11 2018, 11:00 PM · MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps, Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery
Mooeypoo assigned T192210: Loading animation is over text on Recent Changes to Hagarshilo.
Jun 11 2018, 4:29 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, User-notice-collaboration, Easy, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
Mooeypoo assigned T191530: Use the trash icon in the saved filters menu to Hagarshilo.
Jun 11 2018, 4:27 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice-collaboration, Edit-Review-Improvements-Integrated-Filters
Mooeypoo assigned T195902: Update rcfilters-filterlist-feedbacklink to reflect the current status of the filters to Hagarshilo.
Jun 11 2018, 4:23 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
Mooeypoo assigned T191534: Saved filters empty state needs adjustment to Hagarshilo.
Jun 11 2018, 4:09 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice-collaboration, Edit-Review-Improvements-Integrated-Filters
Mooeypoo moved T196546: [iPad - Vector] Filters menu overlaps the list of results from In Development to Blocked on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

This was merged into OOUI, so it should be available in the next release. I'm tagging it as "Blocked" but we should re-test when OOUI is released again.
@Volker_E, I don't remember, when is the next release due? I think in about 2 weeks?

Jun 11 2018, 12:33 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, OOUI

Jun 10 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rERSL2ebe32f51ca4: Final NoteDb migration updates (authored by Mooeypoo).
Final NoteDb migration updates
Jun 10 2018, 4:12 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSL6ab80a69d704: Create change (authored by Mooeypoo).
Create change
Jun 10 2018, 4:11 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSL437f98855903: Final NoteDb migration updates (authored by Mooeypoo).
Final NoteDb migration updates
Jun 10 2018, 4:07 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSL39e609174a63: Create patch set 5 (authored by Mooeypoo).
Create patch set 5
Jun 10 2018, 4:07 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSL29377aa890b5: Create patch set 6 (authored by Mooeypoo).
Create patch set 6
Jun 10 2018, 4:07 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSLe7d932fd46e2: Update patch set 4 (authored by Mooeypoo).
Update patch set 4
Jun 10 2018, 4:07 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSLafd26d10486d: Create patch set 4 (authored by Mooeypoo).
Create patch set 4
Jun 10 2018, 4:07 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSLb608938628dd: Update patch set 3 (authored by Mooeypoo).
Update patch set 3
Jun 10 2018, 4:07 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSL7dcd1b398941: Create patch set 3 (authored by Mooeypoo).
Create patch set 3
Jun 10 2018, 4:07 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSLeb449eaee217: Create change (authored by Mooeypoo).
Create change
Jun 10 2018, 4:07 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSL4f4dac575b04: Create patch set 2 (authored by Mooeypoo).
Create patch set 2
Jun 10 2018, 4:07 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSLaff870657635: Final NoteDb migration updates (authored by Mooeypoo).
Final NoteDb migration updates
Jun 10 2018, 4:07 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSLb3f87a7d5419: Update patch set 3 (authored by Mooeypoo).
Update patch set 3
Jun 10 2018, 4:07 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSL439c075d50e8: Create change (authored by Mooeypoo).
Create change
Jun 10 2018, 4:07 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rERSLfd30982e96c1: Create patch set 2 (authored by Mooeypoo).
Create patch set 2
Jun 10 2018, 4:07 AM

Jun 8 2018

Mooeypoo added a comment to T190156: first item in namespace drop-down isn't always preselected.

The above commit should fix this behavior inside OOUI itself. Thanks for spotting it!

Jun 8 2018, 10:10 PM · WMDE-FUN-Sprint-2018-07-09, Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), WMDE-FUN-Sprint-2018-06-25, OOUI, WMDE-Design, Design, TCB-Team, Advanced-Search
Gerrit Code Review <gerrit@wikimedia.org> committed rEASR25de24ced671: Final NoteDb migration updates (authored by Mooeypoo).
Final NoteDb migration updates
Jun 8 2018, 9:38 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEASR9c711ac0d151: Create change (authored by Mooeypoo).
Create change
Jun 8 2018, 9:38 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rEASR252025906888: Update patch set 1 (authored by Mooeypoo).
Update patch set 1
Jun 8 2018, 9:37 PM

Jun 6 2018

Mooeypoo moved T196546: [iPad - Vector] Filters menu overlaps the list of results from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Jun 6 2018, 6:35 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, OOUI
Mooeypoo claimed T196546: [iPad - Vector] Filters menu overlaps the list of results.
Jun 6 2018, 6:35 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, OOUI
Mooeypoo added a comment to T196546: [iPad - Vector] Filters menu overlaps the list of results.

Confirmed on iPad (running iOS 9.3.5).

Notes:

  • the issue is not present on RC page, only on Watchlist
Jun 6 2018, 2:44 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, OOUI
Mooeypoo added a comment to T192251: Mapframes with a width of 100% fail to display on the mobile site unless "frameless" is used.

@Mooeypoo I'm back in the office Monday. Maybe we can take an hour to go through this and work out a sustainable way forward? I need to re-familiarize myself with the original bug report as well as the problem here.

Jun 6 2018, 2:32 PM · MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps, Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery
Mooeypoo added a comment to T196546: [iPad - Vector] Filters menu overlaps the list of results.

Sorry, I completely botched the gerrit process by making a new commit rather than overriding the old one.

Jun 6 2018, 2:23 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, OOUI
Mooeypoo added a comment to T196546: [iPad - Vector] Filters menu overlaps the list of results.

(Also, I just noticed I didn't change the commit title -- I just did in the actual gerrit patch, but the posting for gerritbot is the wrong one)

Jun 6 2018, 2:20 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, OOUI
Mooeypoo updated subscribers of T196546: [iPad - Vector] Filters menu overlaps the list of results.

This is the same type of bug we had before with touchstart/mousedown/click on iOS safari.
There was very weird consensus on the previous (unresloved) patch that seemed to say that 'click' is best but iOS seems to have issues with occasionally not emitting it correctly.
We can't use 'touchstart', though, because that's also emitted on scroll. The patch comments were a little confusing, so I thought my amended commit is worth -- can we recheck if this is resolving the issue?

Jun 6 2018, 2:19 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, OOUI

Jun 5 2018

Mooeypoo added a comment to T196078: Fixed tag items are removable.

Whoops, thanks for finding this! Patch incoming.

Jun 5 2018, 10:21 PM · MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), OOUI (OOUI-0.27.2)
Mooeypoo claimed T194803: [testwiki-wmf.4] Maplink opened in a different tab shows double "mw-kartographer-buttonfoot" and "mw-kartographer-captionfoot" elements.
Jun 5 2018, 9:19 PM · MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Discovery, Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
Mooeypoo moved T192251: Mapframes with a width of 100% fail to display on the mobile site unless "frameless" is used from QA Review to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Jun 5 2018, 5:23 PM · MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps, Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery
Mooeypoo added a comment to T192251: Mapframes with a width of 100% fail to display on the mobile site unless "frameless" is used.

Found the culprit rule.

Jun 5 2018, 5:17 PM · MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Maps, Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery