Page MenuHomePhabricator

Mstyles (Maryum)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 18 2019, 7:30 PM (10 w, 22 h)
Availability
Available
LDAP User
Mstyles
MediaWiki User
MStyles (WMF) [ Global Accounts ]

Recent Activity

Tue, Jan 21

Mstyles claimed T209812: Review Elastic/maps Grafana dashboards.
Tue, Jan 21, 10:12 PM · Discovery-Search, Maps, Elasticsearch, Operations
Mstyles closed T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects as Resolved.
Tue, Jan 21, 10:11 PM · Discovery-Search (Current work), Patch-For-Review, Code-Health
Mstyles closed T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects, a subtask of T237926: [Epic] Maryum's onboarding to the Search Platform team, as Resolved.
Tue, Jan 21, 10:11 PM · Discovery-Search (Current work)
Mstyles moved T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects from Blocked to Done on the Discovery-Search (Current work) board.
Tue, Jan 21, 10:11 PM · Discovery-Search (Current work), Patch-For-Review, Code-Health
Mstyles moved T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects from Waiting to Blocked on the Discovery-Search (Current work) board.
Tue, Jan 21, 10:10 PM · Discovery-Search (Current work), Patch-For-Review, Code-Health
Mstyles moved T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects from In Progress to Waiting on the Discovery-Search (Current work) board.
Tue, Jan 21, 10:10 PM · Discovery-Search (Current work), Patch-For-Review, Code-Health
Mstyles added a comment to T241291: Simplify WDQS Packaging.

@Addshore that's correct, after removing the gui submodule, I won't be doing any further work

Tue, Jan 21, 4:55 PM · Discovery-Search (Current work), Wikidata-Query-Service, Patch-For-Review, Wikidata, Discovery

Fri, Jan 17

Mstyles added a comment to T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects.

very exciting to see it work here: https://gerrit.wikimedia.org/r/c/search/extra/+/563267. I know @Gehel mentioned trying to refactor where the same job runs for both pre-merge and post-merge but after chatting with @Jdforrester-WMF, it seems that convention is to have separate pre and post merge jobs.

Fri, Jan 17, 8:26 PM · Discovery-Search (Current work), Patch-For-Review, Code-Health
Mstyles added a comment to T217742: Rework the data flow between logstash and cirrus elasticsearch cluster for ApiFeatureUsage.

Tabling this for now as it's not urgent

Fri, Jan 17, 12:59 AM · Discovery-Search
Mstyles added a comment to T241291: Simplify WDQS Packaging.

After a bunch of discussion with the team, it's been decided that removing the gui submodule from the RDF repository will suffice for now. That will fix our broken build issues (see https://phabricator.wikimedia.org/T242640) @Ladsgroup I definitely think you should work on that patch and getting things going with service runner if you have the bandwidth.

Fri, Jan 17, 12:41 AM · Discovery-Search (Current work), Wikidata-Query-Service, Patch-For-Review, Wikidata, Discovery

Thu, Jan 16

Mstyles added a comment to T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects.

@kostajh do we still need to separate sonar args for master vs non master branches then? it seems that we should be able to send all of the same sonar args whether or not the branch is master. I'm not sure how to tell the bot if something is pre or post merge.

Thu, Jan 16, 1:34 AM · Discovery-Search (Current work), Patch-For-Review, Code-Health

Mon, Jan 13

Mstyles added a comment to T241291: Simplify WDQS Packaging.

Had a quick sync meeting with WMDE. The outcome of that was to use this node patch as a starting point for service runner. It's unclear whether or not blubber needs to be involved in this process. Also, ideally the public image for the WDQS UI would be eliminated in favor of the new image used for this new build process.

Mon, Jan 13, 7:21 PM · Discovery-Search (Current work), Wikidata-Query-Service, Patch-For-Review, Wikidata, Discovery
Addshore awarded T241291: Simplify WDQS Packaging a 100 token.
Mon, Jan 13, 7:18 PM · Discovery-Search (Current work), Wikidata-Query-Service, Patch-For-Review, Wikidata, Discovery

Fri, Jan 10

Mstyles added a comment to T232006: LDF service does not Vary responses by Accept, sending incorrect cached responses to clients.

@Gehel I think we can consider this closed unless someone is able to reproduce

Fri, Jan 10, 8:20 PM · Discovery-Search (Current work), Patch-For-Review, Operations, Traffic, Wikidata-Query-Service, Wikidata

Thu, Jan 9

Mstyles added a comment to T241291: Simplify WDQS Packaging.

@akosiaris Could we possibly use miscweb in front of a VM as an interim to serve up the static files before moving to service template?

Thu, Jan 9, 9:18 PM · Discovery-Search (Current work), Wikidata-Query-Service, Patch-For-Review, Wikidata, Discovery
Mstyles added a comment to T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects.

@kostajh everything has been merged, and the code health job runs with sonar analysis after a patch for java projects. However we're not seeing any results from bots in the test patch in search extra (https://gerrit.wikimedia.org/r/563250) with analysis here: https://sonarcloud.io/project/activity?id=org.wikimedia.search%3Aextra-parent. Does the bot know about java projects?

Thu, Jan 9, 7:30 PM · Discovery-Search (Current work), Patch-For-Review, Code-Health
Mstyles added a comment to T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects.

you're right, it's a typo. It should be /run-java.sh. Pushing up a patch now

Thu, Jan 9, 5:40 PM · Discovery-Search (Current work), Patch-For-Review, Code-Health
Mstyles added a comment to T237165: LDF server has 404 errors for JS and CSS resources.

for clarification the correct response will contain a list that looks like this

@prefix schema: <http://schema.org/> .
@prefix pq:    <http://www.wikidata.org/prop/qualifier/> .
@prefix pr:    <http://www.wikidata.org/prop/reference/> .
@prefix ps:    <http://www.wikidata.org/prop/statement/> .

and the incorrect response is HTML that looks similar to

<!DOCTYPE html><html lang="en" dir="ltr"><head><meta charset="utf-8"><meta http-equiv="X-UA-Compatible" content="IE=edge"><meta name="viewport" content="width=device-width,initial-scale=1,user-scalable=yes"><link rel="stylesheet" href="css/style.min.6c0e4865f687302c4d99.css"><link id="favicon" rel="shortcut icon"><script src="js/shim.min.6d0a3b4d4b50e4f73d3e.js"></script><style id="MJX-CHTML-styles">/* placeholder for MathJax */</style></head><body><div class="wikibase-queryservice container-fluid">
Thu, Jan 9, 4:55 PM · Discovery-Search (Current work), Operations, Traffic, Wikidata, Wikidata-Query-Service, Discovery

Wed, Jan 8

Mstyles added a comment to T237165: LDF server has 404 errors for JS and CSS resources.

from inside any of the WDQS machines ( 'wdqs1004.eqiad.wmnet','wdqs1005.eqiad.wmnet', 'wdqs1006.eqiad.wmnet','wdqs1007.eqiad.wmnet')
the following curls return the correct data
curl localhost:80/bigdata/ldf -> direct to nginx server on host
curl localhost:9999/bigdata/ldf -> direct to query service on host
but curl https://query.wikidata.org/bigdata/ldf is not working indicating some problem with routing traffic.
This could be the recent switch from varnish to apache.

Wed, Jan 8, 10:25 PM · Discovery-Search (Current work), Operations, Traffic, Wikidata, Wikidata-Query-Service, Discovery
Mstyles added a project to T237165: LDF server has 404 errors for JS and CSS resources: Traffic.
Wed, Jan 8, 8:50 PM · Discovery-Search (Current work), Operations, Traffic, Wikidata, Wikidata-Query-Service, Discovery

Dec 21 2019

Mstyles created T241291: Simplify WDQS Packaging.
Dec 21 2019, 12:52 AM · Discovery-Search (Current work), Wikidata-Query-Service, Patch-For-Review, Wikidata, Discovery

Dec 20 2019

Mstyles added a comment to T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects.

I am all for reducing duplication but in this case, perhaps we can see if we get it working first and then try to reduce the duplication?

Dec 20 2019, 1:27 AM · Discovery-Search (Current work), Patch-For-Review, Code-Health

Dec 18 2019

Mstyles added a comment to T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects.

What I was trying to say is that all of the projects are currently sending their analysis to SonarQube, so I didn't want to change any postmerge jobs. I put what I thought in the patch

Dec 18 2019, 11:31 PM · Discovery-Search (Current work), Patch-For-Review, Code-Health
Mstyles claimed T217742: Rework the data flow between logstash and cirrus elasticsearch cluster for ApiFeatureUsage.
Dec 18 2019, 9:29 PM · Discovery-Search
Mstyles added a comment to T217742: Rework the data flow between logstash and cirrus elasticsearch cluster for ApiFeatureUsage.

I think specifically the updates are around this ticket, https://phabricator.wikimedia.org/T235833

Dec 18 2019, 9:24 PM · Discovery-Search
Mstyles added a comment to T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects.

Thanks @Jdforrester-WMF
@kostajh I had some questions about the layout. I know you said to create an extension-codehealth-java similar to https://github.com/wikimedia/integration-config/blob/master/zuul/layout.yaml#L884. There doesn't seem to be a standardized pattern for the urls in the same way for non extension projects. Also, some of the java jobs have different post merge jobs that run from each other. I was thinking of adding codehealth separately to each project, in these blocks, https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/master/zuul/layout.yaml#8115. I'm not sure if that will affect future plans that you have with the codehealth stuff going forward

Dec 18 2019, 8:12 PM · Discovery-Search (Current work), Patch-For-Review, Code-Health
Mstyles renamed T219534: Test MLR models for zhwiki, jawiki and kowiki from Train MLR models for zhwiki, jawiki and kowiki to Test MLR models for zhwiki, jawiki and kowiki.
Dec 18 2019, 5:23 PM · Patch-For-Review, Chinese-Sites, Discovery-Search, CirrusSearch
Mstyles added a comment to T217742: Rework the data flow between logstash and cirrus elasticsearch cluster for ApiFeatureUsage.

@Gehel, @EBernhardson mentioned that our new Elasticsearch cluster version doesn't have the same issue with data replication when upgrading the cluster, which means that stopping writes might be less important in the next upgrade.

Dec 18 2019, 12:15 AM · Discovery-Search

Dec 13 2019

Mstyles claimed T219534: Test MLR models for zhwiki, jawiki and kowiki.
Dec 13 2019, 8:45 PM · Patch-For-Review, Chinese-Sites, Discovery-Search, CirrusSearch

Dec 12 2019

Mstyles edited projects for T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects, added: Discovery-Search (Current work); removed Discovery-Search.
Dec 12 2019, 8:00 PM · Discovery-Search (Current work), Patch-For-Review, Code-Health
Mstyles added a comment to T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects.

I put a WIP patch out. I haven't included the changes needed for the php renaming or anything that will have to happen in the jib directory. Those could also go in a separate patch if that makes things more readable. I would love to get feedback and I was wondering if there were any other ways to test outside of running the docker container locally which I've been doing. Also, I plan to put the project/job-template in the search.yaml file, that seems like a reasonable home.

Dec 12 2019, 2:20 AM · Discovery-Search (Current work), Patch-For-Review, Code-Health

Dec 6 2019

Mstyles added a comment to T237605: Create kerberos principals for users.

I too am requesting Kerberos credentials for the stat and notebook machines. My username is mstyles

Dec 6 2019, 7:43 PM · Patch-For-Review, Analytics-Kanban, Analytics

Dec 3 2019

Mstyles added a comment to T238004: Implement sonarcloud integration for Java projects in the same way as PHP projects.

Thanks so much for your very detailed write up. I hope that can make it into official documentation somewhere

Dec 3 2019, 9:59 PM · Discovery-Search (Current work), Patch-For-Review, Code-Health
Mstyles updated the task description for T239654: Requesting access to production shell for Maryum Styles.
Dec 3 2019, 7:52 PM · Discovery-Search (Current work), SRE-Access-Requests, Operations
Mstyles added a comment to T239654: Requesting access to production shell for Maryum Styles.

email address: mstyles@wikimedia.org
wikitech name: mstyles

Dec 3 2019, 7:26 PM · Discovery-Search (Current work), SRE-Access-Requests, Operations
Mstyles updated the task description for T239654: Requesting access to production shell for Maryum Styles.
Dec 3 2019, 7:23 PM · Discovery-Search (Current work), SRE-Access-Requests, Operations
Mstyles moved T238106: "Wikidata Query Service Updater" should have 'bot' in the user agent to indicate is a tool from Waiting to Done on the Discovery-Search (Current work) board.
Dec 3 2019, 7:07 PM · Analytics-Kanban, Patch-For-Review, Discovery-Search (Current work)

Dec 2 2019

Mstyles created T239654: Requesting access to production shell for Maryum Styles.
Dec 2 2019, 7:49 PM · Discovery-Search (Current work), SRE-Access-Requests, Operations

Nov 27 2019

Mstyles created T239300: Add Maryum to Puppet.
Nov 27 2019, 12:19 AM · Patch-For-Review, Operations, Discovery-Search (Current work)

Nov 26 2019

Mstyles claimed T238106: "Wikidata Query Service Updater" should have 'bot' in the user agent to indicate is a tool .

Yep, I'll take a look

Nov 26 2019, 6:31 PM · Analytics-Kanban, Patch-For-Review, Discovery-Search (Current work)

Nov 25 2019

Mstyles edited projects for T238013: Improve unit test branch coverage on 1 or 2 classes in WDQS, added: Discovery-Search; removed Discovery-Search (Current work).
Nov 25 2019, 6:31 PM · Wikidata, Wikidata-Query-Service, Discovery-Search
Mstyles updated Mstyles.
Nov 25 2019, 6:28 PM

Nov 21 2019

Mstyles claimed T238013: Improve unit test branch coverage on 1 or 2 classes in WDQS.
Nov 21 2019, 8:02 PM · Wikidata, Wikidata-Query-Service, Discovery-Search

Nov 20 2019

Mstyles created T238715: Add Mstyles to #wmf-nda.
Nov 20 2019, 1:23 AM · WMF-NDA-Requests

Nov 19 2019

Mstyles added a member for Discovery: Mstyles.
Nov 19 2019, 9:35 PM