Weekly Internship Report

fixed with this PR https://github.com/cis-india/Wikisource-Reader/pull/83

updated the app to save native language for downloaded book https://github.com/cis-india/Wikisource-Reader/pull/91

opened PR to resolve this https://codeberg.org/ph4ni/wsindex/pulls/23

@Saiphani02 I have pushed changes as requested. I have added the native language as first priority and the title as fallback

Weekly Internship Report

updated the PR to https://github.com/cis-india/Wikisource-Reader/pull/90

Opened PR to fix this https://github.com/cis-india/Wikisource-Reader/pull/89

opened PR to fix this https://github.com/cis-india/Wikisource-Reader/pull/88

Weekly Internship Report

opened PR for this https://codeberg.org/ph4ni/wsindex/pulls/20

opened PR to fix this https://codeberg.org/ph4ni/wsindex/pulls/19

Added some guides when user first accesses reader interface. opened PR for this https://github.com/cis-india/Wikisource-Reader/pull/87

opened a PR for this https://github.com/cis-india/Wikisource-Reader/pull/86

Weekly Internship Report

opened a PR to resolve this https://github.com/cis-india/Wikisource-Reader/pull/85

resolved this with the following PR https://codeberg.org/ph4ni/wsindex/pulls/17

Weekly Internship Report

I have implemented a toggle in settings that triggers to show the home guided tour.

I have implemented the guided tour in Home Screen, showing the language filter, book sort and search. also added the navigations.

Weekly Internship Report

I have updated it to https://wsindex.toolforge.org/books///**book_wiki_id**//

okay, got it.

@Saiphani02 I have added the links

Weekly Internship Report

I have opened a PR for this
https://github.com/cis-india/Wikisource-Reader/pull/78

I have resized the svg to fit the splash requirements
https://github.com/cis-india/Wikisource-Reader/pull/77

I have added this as requested and pushed the changes.

Weekly Internship Report

I have opened a PR to resolve this https://github.com/cis-india/Wikisource-Reader/pull/75

opened a PR for this https://github.com/cis-india/Wikisource-Reader/pull/74

I have opened a PR for this, https://codeberg.org/ph4ni/wsindex/pulls/13.

@Saiphani02 I have opened a PR for this https://github.com/cis-india/Wikisource-Reader/pull/73

I have opened another branch for this with the mentioned areas of concern, kindly check

Weekly Internship Report

Weekly Internship Report

I will proceed with how to contribute and best practices for a PR to be accepted.

I have added setup steps for running the api locally. I have opened a PR https://github.com/cis-india/wikisource-reader-app/pull/1

I have opened a PR for this, I have added a fallback to English incase the default locale is returning the isoString.

I have opened a PR for this https://github.com/cis-india/Wikisource-Reader/pull/68 .

In books details screen its fixed here T406245, using system language.

@Saiphani02
I have added the publisher and places of publications and to use system language or English if system language is not available. I have opened a PR please check. https://github.com/cis-india/Wikisource-Reader/pull/67

@Saiphani02 I have opened a PR for the api side
https://codeberg.org/ph4ni/wsindex/pulls/12. I will proceed with the client side once this is approved.

Weekly Internship Report

@Saiphani02 I have updates as requested.

Ok sure, I'm on it.

@Saiphani02 i have opened a PR for this, please check
https://github.com/cis-india/Wikisource-Reader/pull/65

I have renamed and it works fine but just a concern, Once you switch to random sort it will fetch random books and cache them. Is that fine?

@Saiphani02 This is for the client side https://github.com/cis-india/Wikisource-Reader/pull/62

Hi @Saiphani02 , I have opened a PR for this,
https://github.com/cis-india/Wikisource-Reader/pull/63

I have opened a PR for this,
https://github.com/cis-india/Wikisource-Reader/pull/64

@Saiphani02 I have updated the package as mentioned. would really appreciate some guidance how the schemas are used?

Hi @Bodhisattwa, This is well noted and I have updated the report.

Hi @Saiphani02, I have re looked this as mentioned please check, https://codeberg.org/ph4ni/wsindex/pulls/10 .

I have altered the api to sort randomly if no sort is added as the client side by default sends a sort query. This doesn't affect the fetching by popularity in the first fetch as it will have that query.

@Saiphani02, I have implemented this by adding the default sort to random unless you specify either to sort alphabetically or by priority. Here is the PR kindly check.

Hi @Saiphani02 and @Bodhisattwa, Please have a look at this pull request.

Weekly Internship Report

@Saiphani02 I have updated the PR, used com.starry.wikisourcesreader instead and reverted the transtlations back to Myne. I have also tested this and its not breaking local database for the users. Kindly check

This is well noted, I will revert as mentioned and research more on the database schemas.

I have oped a PR for this issue, https://github.com/cis-india/Wikisource-Reader/pull/61
please check.

I have added the classes and subpackages within org.cis_india.wsreader.reader.tts to proguard_rules.pro. This resolves this issue where the Text-to-Speech (TTS) icon is missing as Proguard was tampering during the release build.

I have created the task T412043.

Hi @Saiphani02, When i build with this changes in build.gradle, it works fine

buildTypes {
    release {
        minifyEnabled false
        shrinkResources false

In T408927#11411849, @Saiphani02 wrote:

@Muguro The TTS icon is missing in the playstore production release but it is working in local debugging. Can you check if this is related?

@Saiphani02 I have opened a PR that fixes this, Kindly check it out.
https://github.com/cis-india/Wikisource-Reader/pull/59

@Saiphani02 I have noticed the "?" in the title is whats causing the issue as it is an invalid character while using File class.

@Saiphani02 This is happening because we are encoding the URL for books with a question mark ("?")
I'll create a new task to fix this.

Hi @Saiphani02, I have opend a PR for this issue. Kindly check it out.