Page MenuHomePhabricator

Mvolz (Marielle Volz)
User

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 9:50 PM (402 w, 7 h)
Availability
Available
IRC Nick
Mvolz
LDAP User
Mvolz
MediaWiki User
Mvolz (WMF) [ Global Accounts ]

mvolz@wikimedia.org

Recent Activity

Tue, Jun 14

Mvolz claimed T307591: Citoid ignores query string parameters for non-www urls without protocol.
Tue, Jun 14, 12:00 PM · Patch-For-Review, Citoid

Sun, Jun 5

Mvolz created T309940: Template Editor should open up template data for the whole page even whilst section editing in 2017 wikitext editor.
Sun, Jun 5, 9:15 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, TemplateData

Thu, Jun 2

Mvolz added a comment to T305574: Consider using a hierarchy of configuration files.

Another point is that having separate templates for separate wikis would allow wikilinking to pages in the fields (i.e. the publisher, for instance). (Relevant mailing list discussion here: https://lists.wikimedia.org/hyperkitty/list/webtocit@lists.wikimedia.org/thread/HRYDDXA6MLTKBEV477H6FMZ4CBSNVGS4/)

Thu, Jun 2, 6:50 PM · Web2Cit
Mvolz closed T309645: Web2Cit template debug output seems okay (for some fields), but still not seeing template it being used in gadget. as Resolved.
Thu, Jun 2, 6:42 PM · Web2Cit

Tue, May 31

Mvolz created T309645: Web2Cit template debug output seems okay (for some fields), but still not seeing template it being used in gadget. .
Tue, May 31, 5:10 PM · Web2Cit

May 30 2022

Mvolz closed T308433: VisualEditor apparently creates malformed |volume= parameter values in cs1|2 templates (en.wiki) as Resolved.
May 30 2022, 11:21 AM · VisualEditor
Mvolz added a comment to T308433: VisualEditor apparently creates malformed |volume= parameter values in cs1|2 templates (en.wiki).

Ah, and only volume but not issue was in the suggested params - so they didn't probably notice you could add the issue separately. Fixed: https://en.wikipedia.org/w/index.php?title=Template:Cite_journal/doc&type=revision&diff=1090606937&oldid=1090605535&diffmode=source

May 30 2022, 11:06 AM · VisualEditor
Mvolz added a comment to T309251: PubMed source dates with no day.

We used to add 01 as the day. This made people mad due to "false precision". As has nearly every other way I've tried to resolve this. There is extensive discussion on the other thread if you want to weigh in there!

May 30 2022, 10:59 AM · Citoid, VisualEditor
Mvolz merged T309251: PubMed source dates with no day into T132308: Internationalise citoid dates.
May 30 2022, 10:59 AM · User-notice, User-Josve05a, VisualEditor, Citoid
Mvolz merged task T309251: PubMed source dates with no day into T132308: Internationalise citoid dates.
May 30 2022, 10:57 AM · Citoid, VisualEditor
Mvolz added a comment to T308433: VisualEditor apparently creates malformed |volume= parameter values in cs1|2 templates (en.wiki).

A potential fix could be change the template data type - currently issue and volume are both set to "line" and it could be set to "number". However if you have, for instance, a "summer" issue, then that would prevent people from using that. Other than validating it against the type, there's currently no way to validate it more specifically than that.

May 30 2022, 10:56 AM · VisualEditor
Mvolz removed a project from T308433: VisualEditor apparently creates malformed |volume= parameter values in cs1|2 templates (en.wiki): Citoid.
May 30 2022, 10:42 AM · VisualEditor
Mvolz added a comment to T308433: VisualEditor apparently creates malformed |volume= parameter values in cs1|2 templates (en.wiki).

Now having looked at the examples, these can't be from citoid because they're both pdf links which citoid doesn't do. Potentially user error?

May 30 2022, 10:41 AM · VisualEditor
Mvolz added a comment to T308433: VisualEditor apparently creates malformed |volume= parameter values in cs1|2 templates (en.wiki).
May 30 2022, 10:40 AM · VisualEditor
Mvolz triaged T308433: VisualEditor apparently creates malformed |volume= parameter values in cs1|2 templates (en.wiki) as Medium priority.
May 30 2022, 10:39 AM · VisualEditor

May 24 2022

Mvolz added a comment to T305574: Consider using a hierarchy of configuration files.

At Wikimedia Hackathon 2022's Web2Cit session (T308449), @Mvolz commented that having separate Web2Cit configurations per Wikipedia may be useful for the specific case described in T132308. That is, that incomplete dates returned by Citoid (e.g., 2010-12, meaning December 2010) throw an error in English Wikipedia citation templates, to avoid confusion with date ranges (i.e., 2010-2012). As described there, it was tried with -XX at the end (i.e., 2010-12-XX), but whereas accepted by English Wikipedia, it was rejected by other Wikipedias.

If this is the only case where we would benefit from having different Web2Cit/Citoid response format between Wikipedias, I think that it would be outweighed by the benefits of having one single set of common Web2Cit configurations across Wikipedias (i.e., the benefit of a larger community). I've added a comment to T132308 with an idea of how this could be sorted out at the Citoid extension's level.

@Mvolz, can you think of where we may benefit from having separate Web2Cit configurations per Wikipedia? Thanks!

May 24 2022, 11:54 AM · Web2Cit

Apr 28 2022

Mvolz added a comment to T225415: Tests hang when running full citoid suite with node 11 and higher.

Tried with 12 and it's fine now :).

Apr 28 2022, 10:43 AM · Citoid
Mvolz closed T225415: Tests hang when running full citoid suite with node 11 and higher as Invalid.
Apr 28 2022, 10:42 AM · Citoid

Apr 7 2022

Mvolz added a comment to T205870: Fully migrate producers off statsd.

This is now deployed for citoid.

This is great to see! Thanks for your help @Mvolz

I have updated grafana for the most part, however there are a few (minor) metrics this broke which relied on the service-runner native ones; quantiles by status and method are broken, but quantiles overall are still working. I'm not sure how to fix them but I'm not sure how essential those are since it's the same info but just broken down a bit.

Garbage collection metrics have been broken for a while, as have memory pod metrics, and that's not related to this change.

ack, please feel free to contact us (SRE o11y) for assistance with the missing/broken metrics if needed

Apr 7 2022, 4:31 PM · SRE Observability (FY2021/2022-Q4), MW-1.38-notes (1.38.0-wmf.4; 2021-10-12), Goal, Performance-Team (Radar), Patch-For-Review, SRE
Mvolz added a comment to T205870: Fully migrate producers off statsd.

This is now deployed for citoid.

Apr 7 2022, 11:25 AM · SRE Observability (FY2021/2022-Q4), MW-1.38-notes (1.38.0-wmf.4; 2021-10-12), Goal, Performance-Team (Radar), Patch-For-Review, SRE
Mvolz updated the task description for T205870: Fully migrate producers off statsd.
Apr 7 2022, 11:22 AM · SRE Observability (FY2021/2022-Q4), MW-1.38-notes (1.38.0-wmf.4; 2021-10-12), Goal, Performance-Team (Radar), Patch-For-Review, SRE

Apr 5 2022

Mvolz created T305456: Upgrade to use node 12.
Apr 5 2022, 12:24 PM · service-template-node

Mar 29 2022

Mvolz added a comment to T291707: zotero paging / serving 5xxes after CPU spikes.

In terms of a get endpoint, would swagger docs suffice? I started to do something like that but never got around to finishing it :/ https://github.com/zotero/translation-server/issues/76

That would work fine. Many thanks for working on that!

In review -> https://github.com/zotero/translation-server/pull/131

@Mvolz, care to ping upstream again on that one? It's 6 months already.

We had another slew of pages disrupting our weekend as SREs. Pages we could literally do nothing else than just restart things and hope the problem doesn't show up again. This is not sustainable and is demoralizing long term, I am afraid that if this continues SRE will have to pull support for zotero and stop receiving pages for incidents/outages/degradations the service faces.

Judging from the graphs, https://w.wiki/4zi8 we still had spare capacity (14 replicas and at most 9 were fully utilized) and could serve requests. So if we had this get endpoint to use as a readiness probe, kubernetes would have automatically depooled the non responsive instances until they were responsive again leading to no user-visible issues for end users.

Mar 29 2022, 8:58 AM · Patch-For-Review, serviceops, Citoid

Mar 2 2022

Mvolz added a comment to T302521: Citoid ISBN lookup not working.

It's probable we ran into our request limit with worldcat, but I can't find any obvious spike on the 24th like we've had in the past with bots eating up our requests. It's working for now - we should perhaps improve metrics/ tracking to alert us when we go over our request limit.

Mar 2 2022, 11:28 AM · Citoid
Mvolz added a comment to T301510: Optimize large number of Citoid requests for coverage estimation research project.

I've been looking into Citoid API request rate limits.

We access the Citoid API through Wikmedia's RESTBase proxy. I found two 429 HyperSwitch errors for exceeded request rates: https://www.mediawiki.org/wiki/HyperSwitch/errors/rate_exceeded and https://www.mediawiki.org/wiki/HyperSwitch/errors/request_rate_exceeded

Here it says that there is a global limit of up to 200 requests per second, but that individual endpoints may have specific limits. However, the Citoid API documentation doesn't seem to say anything about it.

On the other hand, I found this thread where @Mvolz mentions a "1000/10s (100/s long term, with 1000 burst)" limit.

She also refers to how long requests take and timeouts, but I'm not sure what she means. How does time to response affect request rate limit? Say we make 1000 requests at t=0s of which only 500 have returned a response at t=10s, can we make another 1000-request batch now? Or do pending requests count against our request rate limit?

Mar 2 2022, 11:04 AM · Web2Cit-Research, Citoid

Jan 27 2022

Mvolz created T300257: console.logging proxy metrics object fails because it doesn't recognise "util.inspect.custom" as a valid property.
Jan 27 2022, 2:48 PM · service-runner

Jan 25 2022

Mvolz added a comment to T299981: Improving cite extraction from URLs when the author has one or two surnames (Basque, Spanish...).

This is very cool! The short answer is - it would be very difficult to integrate this into the actual service we use. It uses a web scraper (Zotero) and each website is parsed by a different translator.

Jan 25 2022, 2:36 PM · Citoid

Jan 6 2022

Mvolz renamed T298427: Zotero translator needed to get correct author for Condé Nast requests from Zotero translator for Tatler/Teen Vogue request to Zotero translator needed to get correct author for Tatler/Teen Vogue requests.
Jan 6 2022, 1:31 PM · VisualEditor, Citoid
Mvolz renamed T298427: Zotero translator needed to get correct author for Condé Nast requests from Citoid incorrectly inserts "Condé Nast" as author in references to Zotero translator for Tatler/Teen Vogue request.
Jan 6 2022, 1:31 PM · VisualEditor, Citoid
Mvolz moved T298427: Zotero translator needed to get correct author for Condé Nast requests from Backlog to Zotero on the Citoid board.
Jan 6 2022, 1:30 PM · VisualEditor, Citoid
Mvolz added a comment to T298427: Zotero translator needed to get correct author for Condé Nast requests.

Unfortunately this is a case where you would have to write a custom translator for zotero (see https://www.mediawiki.org/wiki/Citoid#My_favourite_site_isn't_recognised_by_citoid_and_only_gets_basic_information) for these sites.

Jan 6 2022, 1:30 PM · VisualEditor, Citoid

Nov 5 2021

Mvolz added a comment to T294010: Automatic citation generation using ISBN on Wikipedia doesn't work.

It's ~70 rps at those peaks. They are most definitely violating https://www.mediawiki.org/wiki/API:Etiquette (even if we don't have hard numbers in that page) and we can take action against that. A quick look at turnilo shows a single AWS IP with a user agent of Apache-HttpClient/4.5.6 (Java/1.8.0_265) doing the vast majority of these calls in the last day (>85%).

I 've gone ahead and added them to our abuser lists (in the private repo). It will take some 30 minutes to propagate fully, but after that they should receive back a 403 asking them to contact noc@wikimedia.org.

To be fair, https://en.wikipedia.org/api/rest_v1/ says limit it to 200 r/s.

I had forgotten about that. Good point.

Unfortunately even 1r/s would eat up our quota. We could add more specific documentation to citoid on the page.

Yup, we should do that. Having a global recommendation that is incompatible with more specific services like Citoid isn't good decorum. Thanks for bringing it up!

Nov 5 2021, 9:16 AM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE

Nov 4 2021

Mvolz added a comment to T294010: Automatic citation generation using ISBN on Wikipedia doesn't work.

It's ~70 rps at those peaks. They are most definitely violating https://www.mediawiki.org/wiki/API:Etiquette (even if we don't have hard numbers in that page) and we can take action against that. A quick look at turnilo shows a single AWS IP with a user agent of Apache-HttpClient/4.5.6 (Java/1.8.0_265) doing the vast majority of these calls in the last day (>85%).

I 've gone ahead and added them to our abuser lists (in the private repo). It will take some 30 minutes to propagate fully, but after that they should receive back a 403 asking them to contact noc@wikimedia.org.

Nov 4 2021, 11:43 AM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE

Nov 2 2021

Mvolz added a comment to T294010: Automatic citation generation using ISBN on Wikipedia doesn't work.

Looking at https://grafana.wikimedia.org/d/NJkCVermz/citoid?viewPanel=43&orgId=1&from=now-30d&to=now I think the ban worked. I haven't seen anyone yet reaching out to noc@wikimedia.org but we no longer have that amount of excessive ISBN citation usage. I don't know if we are under quota again though and if everything is working as expected. I did a quick test and it seems to work. @Mvolz, care to have a look?

Nov 2 2021, 5:05 PM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE

Oct 29 2021

Mvolz placed T294010: Automatic citation generation using ISBN on Wikipedia doesn't work up for grabs.
Oct 29 2021, 9:25 AM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE
Mvolz added a comment to T294010: Automatic citation generation using ISBN on Wikipedia doesn't work.

This paints a nice picture. https://grafana.wikimedia.org/d/NJkCVermz/citoid?orgId=1&from=1635185829182&to=1635189452614 something is eating up our isbn requests for about a half hour, they keep going for a half our after that with all the requests getting 404ed, and then the requests stop.

Oct 29 2021, 9:12 AM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE
Mvolz updated subscribers of T294010: Automatic citation generation using ISBN on Wikipedia doesn't work.
Oct 29 2021, 9:02 AM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE
Mvolz added a comment to T294010: Automatic citation generation using ISBN on Wikipedia doesn't work.

Can we ask for an exemption for Wikipedia?

Oct 29 2021, 8:57 AM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE

Oct 28 2021

Mvolz added a comment to T294010: Automatic citation generation using ISBN on Wikipedia doesn't work.

According to WorldCat we're probably exceeding a usage cap of 50,000 requests a day.

Oct 28 2021, 4:53 PM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE

Oct 27 2021

Mvolz added a comment to T294010: Automatic citation generation using ISBN on Wikipedia doesn't work.

If the problem was solved and has come back, I would imagine we get banned from their systems for some reason?

Oct 27 2021, 10:24 PM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE

Oct 22 2021

JosefineHellrothLarssonWMSE awarded T294010: Automatic citation generation using ISBN on Wikipedia doesn't work a Party Time token.
Oct 22 2021, 8:21 AM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE

Oct 21 2021

Dzahn awarded T294010: Automatic citation generation using ISBN on Wikipedia doesn't work a Like token.
Oct 21 2021, 6:10 PM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE
Mvolz updated subscribers of T294010: Automatic citation generation using ISBN on Wikipedia doesn't work.
Oct 21 2021, 6:09 PM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE
Mvolz added a comment to T294010: Automatic citation generation using ISBN on Wikipedia doesn't work.

Thank you to @Dzahn in ops for rotating the keys! It looks all fixed now.

Oct 21 2021, 6:09 PM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE
Mvolz closed T294010: Automatic citation generation using ISBN on Wikipedia doesn't work as Resolved.
Oct 21 2021, 5:57 PM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE
Mvolz added a comment to T294010: Automatic citation generation using ISBN on Wikipedia doesn't work.

I have checked and can confirm locally that the key we use for worldcat in production is no longer working, whereas our other keys still work. However, according to Worldcat dashboard the key has not exceeded usage and is not blocked. I can try rotating the key and see if that works, otherwise will need to get in touch with support. It might have just been dropped from their db or something and reissuing might do the trick.

Oct 21 2021, 4:38 PM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE
Mvolz claimed T294010: Automatic citation generation using ISBN on Wikipedia doesn't work.
Oct 21 2021, 4:38 PM · WMSE-Bug-Reporting-and-Translation-2021, serviceops, Editing-team (FY2021-22 Kanban Board), Citoid, VisualEditor, User-JosefineHellrothLarssonWMSE

Oct 5 2021

Mvolz added a comment to T291707: zotero paging / serving 5xxes after CPU spikes.

In terms of a get endpoint, would swagger docs suffice? I started to do something like that but never got around to finishing it :/ https://github.com/zotero/translation-server/issues/76

That would work fine. Many thanks for working on that!

Oct 5 2021, 1:31 PM · Patch-For-Review, serviceops, Citoid

Sep 29 2021

Mvolz added a comment to T291707: zotero paging / serving 5xxes after CPU spikes.

The PDF connection might be a red herring because although that's what happened in the past, attempting to translate those was disabled here: https://github.com/zotero/translation-server/issues/68

https://github.com/zotero/translation-server/commit/5cf698e20acf8a2fe40219a464f5cbdf7154d24f

https://github.com/zotero/translation-server/commit/9f2c36664fe5f0c3e98ffeb369194f7c242120c3

Locally I've checked and this is still working as expected. So the rejections happen because they get requested a lot, not because it's necessarily related to the crash.

Per those commits, the limit seems to be 50MB. @dstillman is probably right in his comment that it is maybe too high. Can we lower this more/is it configurable now? Like 10MB ? Do we have any use case requiring that we are able to cite objects > 10MB ?

Sep 29 2021, 8:15 AM · Patch-For-Review, serviceops, Citoid

Sep 28 2021

Mvolz added a comment to T291707: zotero paging / serving 5xxes after CPU spikes.

The PDF connection might be a red herring because although that's what happened in the past, attempting to translate those was disabled here: https://github.com/zotero/translation-server/issues/68

Sep 28 2021, 12:33 PM · Patch-For-Review, serviceops, Citoid

Sep 17 2021

Mvolz added a comment to T290717: Wikibase references in citoid broken.

@Mvolz is this still the case?

Sep 17 2021, 9:06 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Regression, Citoid
Mvolz closed T290717: Wikibase references in citoid broken as Resolved.
Sep 17 2021, 9:06 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Regression, Citoid

Sep 14 2021

Mvolz reopened T290717: Wikibase references in citoid broken as "Open".
Sep 14 2021, 9:25 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Regression, Citoid

Sep 10 2021

Mvolz closed T290717: Wikibase references in citoid broken as Resolved.
Sep 10 2021, 1:38 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Regression, Citoid
Mvolz created T290717: Wikibase references in citoid broken.
Sep 10 2021, 9:20 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Regression, Citoid

Sep 8 2021

Mvolz added a comment to T290304: https://gitlab.com/wikimedia exists and is not owned by us.

Could Legal do it?

Sep 8 2021, 6:37 PM · GitLab

Sep 3 2021

Mvolz created T290304: https://gitlab.com/wikimedia exists and is not owned by us.
Sep 3 2021, 8:36 AM · GitLab
Mvolz claimed T290301: Requests for ISBN 6133434333 have level path fatal / service-runner / unhandled in logs.
Sep 3 2021, 8:09 AM · Citoid
Mvolz created T290301: Requests for ISBN 6133434333 have level path fatal / service-runner / unhandled in logs.
Sep 3 2021, 8:09 AM · Citoid

Sep 2 2021

Mvolz renamed T290157: Move service-template-node repository to gitlab from Move repository to gitlab to Move service-template-node repository to gitlab.
Sep 2 2021, 11:50 AM · GitLab (Project Migration), service-template-node
Mvolz added a project to T290157: Move service-template-node repository to gitlab: GitLab.
Sep 2 2021, 11:50 AM · GitLab (Project Migration), service-template-node
Mvolz added a comment to T282842: Early adoption signup for WMF GitLab.

A slightly edge-casey library is https://github.com/wikimedia/html-metadata which is not on gerrit and is also an npm package, so I'll need to point npm to the new location (Come to think of it I might be the only one with the rights to do that since mobrovac left? need to fix..). Happy to do that earlier rather than later but not be helpful as a template for other repos.

Sep 2 2021, 11:50 AM · Release-Engineering-Team (🌱 Spring Cleaning — April 2022), GitLab (Project Migration), User-brennen
Mvolz added a comment to T290157: Move service-template-node repository to gitlab.

I think at this stage it makes sense to just move to gitlab instead so change the task to that ^-^

Sep 2 2021, 11:49 AM · GitLab (Project Migration), service-template-node
Mvolz renamed T290157: Move service-template-node repository to gitlab from Pipeline bot causing merge conflicts - should we move repository to gerrit? to Move repository to gitlab.
Sep 2 2021, 11:49 AM · GitLab (Project Migration), service-template-node

Aug 14 2021

Mvolz added a comment to T288811: Secret key value exposed within gerrit change set 712921.

Can this be made public if the credentials have been cycled and a new key created?

Aug 14 2021, 10:23 AM · SecTeam-Processed, Gerrit, Release-Engineering-Team, Security, Security-Team

Aug 13 2021

Mvolz added a comment to T288811: Secret key value exposed within gerrit change set 712921.

Tagging Release-Engineering-Team as the ostensible owners of gerrit. It looks like the problem config file appears in PS2 and PS3 - not sure if we can remove those patch sets (or at least the config file/diff) from this change set's history?

@Mvolz - has the exposed key been deactivated or rotated? It likely shouldn't be used again, especially not within any kind of production envrionment.

It's not the production key fortunately but a currently unused one intended for beta but never configured. I can get it revoked upstream and ask for a new one.

I guess an easier solution would just be to revoke it actually!

Aug 13 2021, 4:35 PM · SecTeam-Processed, Gerrit, Release-Engineering-Team, Security, Security-Team
Mvolz closed T288811: Secret key value exposed within gerrit change set 712921 as Resolved.
Aug 13 2021, 4:34 PM · SecTeam-Processed, Gerrit, Release-Engineering-Team, Security, Security-Team
Mvolz added a comment to T288811: Secret key value exposed within gerrit change set 712921.

Tagging Release-Engineering-Team as the ostensible owners of gerrit. It looks like the problem config file appears in PS2 and PS3 - not sure if we can remove those patch sets (or at least the config file/diff) from this change set's history?

@Mvolz - has the exposed key been deactivated or rotated? It likely shouldn't be used again, especially not within any kind of production envrionment.

It's not the production key fortunately but a currently unused one intended for beta but never configured. I can get it revoked upstream and ask for a new one.

Aug 13 2021, 4:31 PM · SecTeam-Processed, Gerrit, Release-Engineering-Team, Security, Security-Team
Mvolz added a comment to T288811: Secret key value exposed within gerrit change set 712921.

Tagging Release-Engineering-Team as the ostensible owners of gerrit. It looks like the problem config file appears in PS2 and PS3 - not sure if we can remove those patch sets (or at least the config file/diff) from this change set's history?

@Mvolz - has the exposed key been deactivated or rotated? It likely shouldn't be used again, especially not within any kind of production envrionment.

Aug 13 2021, 4:29 PM · SecTeam-Processed, Gerrit, Release-Engineering-Team, Security, Security-Team

Aug 12 2021

Mvolz closed T279824: invalid date in particlar article as Resolved.
Aug 12 2021, 10:29 AM · Citoid

Aug 6 2021

Mvolz moved T278704: Please import citation templates and set up citoid for the Twi Wikipedia from Backlog to Site Config on the Citoid board.
Aug 6 2021, 3:34 PM · Citoid
Mvolz moved T281046: Citation tool fails to add citations for calls longer than 20 seconds from Backlog to Extension on the Citoid board.
Aug 6 2021, 3:34 PM · VisualEditor-MediaWiki-References, Citoid, VisualEditor
Mvolz moved T284371: Author name not split correctly on citation from Airitilibrary under visual editor. from Backlog to Zotero on the Citoid board.
Aug 6 2021, 3:34 PM · Upstream, Chinese-Sites, Citoid
Mvolz moved T284729: If Citoid fails to generate a citation from a URL, should pre-fill that URL in the Manual citation template from Backlog to Extension on the Citoid board.
Aug 6 2021, 3:34 PM · VisualEditor-MediaWiki-References, Citoid, VisualEditor

Aug 5 2021

Mvolz closed T265354: VisualEditor should add a space before every pipe character used in a cite template as Invalid.
Aug 5 2021, 12:18 PM · VisualEditor

Jul 9 2021

Mvolz added a comment to T286360: zotero failing with getaddrinfo ENOTFOUND en.wikipedia.org and url-downloader.codfw.wikimedia.org, causing Citoid errors.

I can temporarily silence this if you want, by commenting out the offending test and redeploying, at least for the time being? Doesn't seem to actually affect operation, at least. We used to actually probe www.example.com but that would cause errors like this too, and switched to our own stuff so uptime would be concurrent... is it a temporary DNS issue do you think?

Jul 9 2021, 10:17 AM · Citoid

Jun 30 2021

Mvolz created T285891: Invalid date in particular article.
Jun 30 2021, 5:56 PM · Citoid

Jun 28 2021

Mvolz removed a project from T285627: VisualEditor "forgets" some template parameters while editing a template: Citoid.
Jun 28 2021, 1:31 PM · TemplateData, VisualEditor

Jun 27 2021

Mvolz added a project to T285626: When using the VisualEditor+Citoid insert tool, the URL field should have focus: Regression.
Jun 27 2021, 12:21 PM · Verified, MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Editing-team (FY2021-22 Kanban Board), Performance-Team (Radar), Regression, Citoid, VisualEditor

Jun 23 2021

Ladsgroup awarded T233293: wikibase/javascript-api (wikibase-api) should use datatype instead of deprecated parameter parser a Yellow Medal token.
Jun 23 2021, 12:24 PM · wdwb-tech, Technical-Debt, Patch-For-Review, Wikibase-JavaScript-Api, DataValues, MediaWiki-extensions-WikibaseRepository, Wikidata

Jun 21 2021

Mvolz closed T246990: Remember user's last tab preference, a subtask of T199197: [2.11] Integrate Citoid in Wikidata, as Resolved.
Jun 21 2021, 9:27 AM · Knowledge-Integrity, Patch-For-Review, Citoid, WMF-Legal, Wikidata, Epic
Mvolz closed T246990: Remember user's last tab preference as Resolved.
Jun 21 2021, 9:27 AM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), Citoid, Wikidata

Jun 10 2021

Mvolz closed T119494: Don't "strip tags" from DOIs as Resolved.
Jun 10 2021, 10:31 AM · User-Josve05a, VisualEditor, Citoid
Mvolz added a comment to T284216: helm error trying to deploy citoid staging.

connectivity hiccup probably

Jun 10 2021, 10:22 AM · Citoid
Mvolz closed T284216: helm error trying to deploy citoid staging as Declined.
Jun 10 2021, 10:22 AM · Citoid

Jun 8 2021

Mvolz added a comment to T284345: Upgrade all CI jobs for WMF-deployed projects from Node 10 to Node 12.

While playing with this locally I realized that, npm v7 uses a new lockfile version and whenever I run npm to install the packages it also updates the v1 lockfile to v2 adding a lot of diff overhead. - So I wonder if it might be useful ( when ever we are sure to stick with this version ) to run Libraryupgrader and mass adjust the repos.

Jun 8 2021, 9:31 AM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), User-zeljkofilipin, Release-Engineering-Team (Doing), MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Patch-For-Review, Continuous-Integration-Config

Jun 3 2021

Mvolz added a comment to T284216: helm error trying to deploy citoid staging.

Not sure if this a temporary hiccup / just things timing out, and if I should just try to deploy again or something more serious so filing :)

Jun 3 2021, 11:01 AM · Citoid
Mvolz created T284216: helm error trying to deploy citoid staging.
Jun 3 2021, 11:00 AM · Citoid

May 28 2021

Mvolz triaged T279824: invalid date in particlar article as Low priority.
May 28 2021, 9:35 AM · Citoid
Mvolz closed T163986: Revamp spec.yaml in citoid as Resolved.
May 28 2021, 9:34 AM · Patch-For-Review, User-Ryasmeen, Services (watching), User-mobrovac, VisualEditor, Citoid
Mvolz placed T146539: Some input to Citoid extension, may already be URL encoded, and the Citoid extension encodes it again, resulting in double-encoded input to citoid. up for grabs.
May 28 2021, 9:34 AM · User-Ryasmeen, Citoid
Mvolz placed T264083: Switch to WorldCat Search v2 api which uses json up for grabs.
May 28 2021, 9:33 AM · Technical-Debt, VisualEditor, Citoid
Mvolz placed T217258: Language handling for adding citations with citoid in wikidata up for grabs.
May 28 2021, 9:31 AM · Wikidata, Citoid

May 20 2021

Mvolz added a comment to T232771: In cite journal, do not add URL expanded from existing identifier like DOI.

Not all citation templates have a DOI field, and only have a URL field. As long as we have this information, we should provide it, because some consumers will prefer to use the URL. If en wiki prefers to remove these with bots that's a preferred option imo. We can't delete fields that are being used on other wikis in the back-end just because of policy in en wiki.

May 20 2021, 12:42 PM · Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Citoid
Mvolz closed T232771: In cite journal, do not add URL expanded from existing identifier like DOI as Declined.
May 20 2021, 12:35 PM · Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Citoid

May 19 2021

Mvolz added a comment to Mentor.

@zeljkofilipin Thalia's handle is Tchanders but for some reason when I try to actually tag her it breaks Phabricator.

unhandledexception.png (883×1 px, 87 KB)

May 19 2021, 1:02 PM
Mvolz added a comment to T1092: "Warning: Too many errors." but none explained.

Came across this as well - triggered in reftoolbar (https://en.wikipedia.org/wiki/MediaWiki:RefToolbar.js) found this archived topic where it's suggested it's due to Ace being outdated and it's since been fixed* https://www.mediawiki.org/wiki/Topic:Tat8gxmbmjtpn5dl

May 19 2021, 12:35 PM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Upstream, CodeEditor
Mvolz claimed T119494: Don't "strip tags" from DOIs.
May 19 2021, 10:35 AM · User-Josve05a, VisualEditor, Citoid
Mvolz renamed T119494: Don't "strip tags" from DOIs from Citoid converts ignores <302::aid-ajmg13> to Don't "strip tags" from DOIs.
May 19 2021, 10:34 AM · User-Josve05a, VisualEditor, Citoid
Mvolz merged T283101: Parts of DOIs between < and > are lost in URL expansion into T119494: Don't "strip tags" from DOIs.
May 19 2021, 10:34 AM · User-Josve05a, VisualEditor, Citoid