Page MenuHomePhabricator

N3rsti (Krzysztof Witucki)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Dec 8 2019, 10:00 AM (10 w, 1 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
N3rsti [ Global Accounts ]

Recent Activity

Jan 6 2020

N3rsti added a comment to T231205: Add shadow to nav menu drawer.

It's working on wikipedia beta because it use #some_input_id:checked ~ #mw-mf-page-left (i don't remember id), but from what I've seen mediawiki is using anchor in this id so it can't be checked. Now I'm on mobile phone so I can't check dev tools, but I'm pretty sure there was anchor, not input on mediawiki

Jan 6 2020, 9:56 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend, Google-Code-in-2019, good first task
N3rsti added a comment to T231205: Add shadow to nav menu drawer.

Ok, but I don't think it will work without this change which was reverted. Should I add it again (if it won't be a problem now)?

Jan 6 2020, 8:53 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend, Google-Code-in-2019, good first task
N3rsti added a comment to T231205: Add shadow to nav menu drawer.

https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page runs the latest code and I see the box-shadow there but not the primary-navigation-enabled class. It's most likely this is a regression which will resolve itself in the next deploy.

Jan 6 2020, 8:41 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend, Google-Code-in-2019, good first task
N3rsti added a comment to T231205: Add shadow to nav menu drawer.
Jan 6 2020, 8:19 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend, Google-Code-in-2019, good first task
N3rsti added a comment to T231205: Add shadow to nav menu drawer.

I removed border-radius from .toggle-list__list. I haven't found any other border-radius styles that could override this so removing it from ToggleList.less should be fine, but I'm not sure why previous box-shadow change was reverted, like I said before.

@Jdlrobson Why was this change reverted? I know you said that "this CSS block is dead", but now it doesn't show shadow in websites like this . There were no other shadow styles for this drawer.

Jan 6 2020, 7:34 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend, Google-Code-in-2019, good first task
N3rsti added a comment to T231205: Add shadow to nav menu drawer.

@Jdlrobson Why was this change reverted? I know you said that "this CSS block is dead", but now it doesn't show shadow in websites like this . There were no other shadow styles for this drawer.

Jan 6 2020, 7:16 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend, Google-Code-in-2019, good first task

Jan 2 2020

N3rsti added a comment to T231205: Add shadow to nav menu drawer.

@alexhollender I haven't changed border-radius, because from the task I had to change color only. I did everything from this list:

Jan 2 2020, 6:22 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend, Google-Code-in-2019, good first task

Dec 28 2019

N3rsti claimed T213181: Show (pre) expediture totals in admin interface.
Dec 28 2019, 4:15 PM · Google-Code-in-2019, WMCZ-Tracker

Dec 25 2019

N3rsti closed T241442: Tracker crashing after clicking "watch settings" button as Resolved.
Dec 25 2019, 4:50 PM · User-Urbanecm, WMCZ-Tracker
N3rsti updated the task description for T241442: Tracker crashing after clicking "watch settings" button.
Dec 25 2019, 4:36 PM · User-Urbanecm, WMCZ-Tracker
N3rsti created T241442: Tracker crashing after clicking "watch settings" button.
Dec 25 2019, 4:33 PM · User-Urbanecm, WMCZ-Tracker
N3rsti claimed T240226: Display sum of ticket in Tracker admin.
Dec 25 2019, 3:57 PM · Google-Code-in-2019, WMCZ-Tracker

Dec 24 2019

N3rsti added a comment to T240668: Refresh subtopic list in admin interface when topic is changed.

@Urbanecm

Dec 24 2019, 8:59 PM · Google-Code-in-2019, WMCZ-Tracker
N3rsti added a comment to T231205: Add shadow to nav menu drawer.

It should be fixed now. I'm not sure if I created variable in the right place, but it's easy to fix in necessary.

Dec 24 2019, 11:27 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend, Google-Code-in-2019, good first task

Dec 23 2019

N3rsti added a comment to T231205: Add shadow to nav menu drawer.

It should be working now, it it's not, please let me know and I will try to fix it.

Dec 23 2019, 9:43 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend, Google-Code-in-2019, good first task
N3rsti added a comment to T231205: Add shadow to nav menu drawer.

I tried to reconstruct this bug on devtools and I see this shadow on the left side (which I will try to fix), but I don't see the shadow on the burger menu. On which website have you seen this bug?

Dec 23 2019, 9:04 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend, Google-Code-in-2019, good first task
N3rsti added a comment to T231205: Add shadow to nav menu drawer.

@Jdlrobson My GCI task was already approved, but I see that there is a problem with it. Can I fix it?

Dec 23 2019, 8:56 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend, Google-Code-in-2019, good first task
N3rsti claimed T240383: Statutory declaration field label isn't translated into other languages.

Notes
These are my notes, I will edit them when I find something.

Dec 23 2019, 4:35 PM · Google-Code-in-2019, WMCZ-Tracker
N3rsti closed T231205: Add shadow to nav menu drawer as Resolved.
Dec 23 2019, 12:35 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend, Google-Code-in-2019, good first task

Dec 21 2019

N3rsti claimed T231205: Add shadow to nav menu drawer.
Dec 21 2019, 5:01 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), MobileFrontend, Google-Code-in-2019, good first task
Pavithraes awarded T235584: Develop a web app showcasing a variety of tools hosted in Wikimedia Toolforge a Love token.
Dec 21 2019, 9:56 AM · Developer-Advocacy (Jan-Mar 2020), User-srishakatux, Google-Code-in-2019
N3rsti closed T235584: Develop a web app showcasing a variety of tools hosted in Wikimedia Toolforge as Resolved.

Created web app showing toolfoge apps using wikimedia API including new apps from task description. The tiles design is from previous toolforge gallery, but I did it from scratch without using bootstrap (so it's probably slightly faster) and changed color to blue (#36c) from wikimedia style guide. On navigation bar you can search for apps using app name / module.

Dec 21 2019, 9:19 AM · Developer-Advocacy (Jan-Mar 2020), User-srishakatux, Google-Code-in-2019
srishakatux awarded T235584: Develop a web app showcasing a variety of tools hosted in Wikimedia Toolforge a Love token.
Dec 21 2019, 9:16 AM · Developer-Advocacy (Jan-Mar 2020), User-srishakatux, Google-Code-in-2019

Dec 17 2019

N3rsti claimed T235584: Develop a web app showcasing a variety of tools hosted in Wikimedia Toolforge.
Dec 17 2019, 5:22 PM · Developer-Advocacy (Jan-Mar 2020), User-srishakatux, Google-Code-in-2019

Dec 14 2019

N3rsti claimed T240677: Links with "-" are split.
Dec 14 2019, 8:30 AM · Google-Code-in-2019, WMCZ-Tracker