Tue, May 21
Moving to Waiting until I'm finished with T222760
Mon, May 20
Fri, May 17
Thu, May 16
Sure! After you insert a new link, do you lose your cursor completely or are you scrolled out of view? Are you on the latest iOS version?
Tue, May 14
@bearND on iOS, we're using it to adjust scroll offset - https://github.com/wikimedia/wikipedia-ios/blob/8fe4da9a9a1d0fb78457dcaf1d12eac2baf4fb0d/www/js/sections.js#L170
@cmadeo would you want to remove the shadows from the input views too (& update the bg color)?
Thu, May 9
Tue, May 7
Thu, May 2
Wed, May 1
@cmadeo for text size, we'd have to decrease it by more than 1pt to get dynamic size - title is now 20 pt, description and extract are 15 pt so in order to decrease those sizes, we'd have to make the title 17pt and description & extract 13 pt (https://developer.apple.com/design/human-interface-guidelines/ios/visual-design/typography/)
Tue, Apr 30
@cmadeo yup, makes sense! Yes, I know, it's a lot, especially when you have to imagine the interactions 😂 Hopefully it'll be easier to adjust once we can use it!
I'm starting to think that we might want to show a menu off of the cursor to deal with this similar to Google Docs. This would mean that the user would be free to change the text within the link however they please, but also open the squib/wizard when needed via this menu or remove the Wikitext. Do you think this might work? or be easy to implement?
I highlight the word canine but I select the link for dog then the wikitext would be [canine | dog]
Sorry about the content flash confusion, my cache wasn't clean so it didn't flash when I tested it. I thought there was a task that captured the abstraction described by @JoeWalsh in the 2nd paragraph and that it was already implemented. That led me to believe that the completion on the client side was redundant.
Mon, Apr 29
Fri, Apr 26
Looks like the whole table view is messed up on 12.2, couldn't reproduce on 11.4
Thu, Apr 25
Wed, Apr 24
Fixed by T221768
@JMinor should the Continue reading card always stick to the top of the feed or should it be at the top of feed section for a given day?
selection doesn't show on 12.2
Tue, Apr 23
@bearND the callback for wmf.setTheme was necessary to avoid the theme change flash problem. We were hiding the web view until we heard back from js that the theme was applied. I checked with the latest changes and it looks like it works without a callback. Did you have a task that fixed the flash? If you give me the pre-change SHA, I can go back and 100% confirm whether the callback isn't necessary.
Apr 22 2019
FYI the server is returning a correct (+ localized) message ("Invalid username or password entered. Please try again.") but we're overriding it with our own "Wrong password" message. Do we want to return the server message or show our own?
Apr 12 2019
Apr 10 2019
Apr 9 2019
Additional design question -
Apr 8 2019
Apr 6 2019
Apr 5 2019
Apr 2 2019
Apr 1 2019
@cmadeo do we want to mark text only for single replace or for both?
@cmadeo now that we select the string, do you want to get rid of the highlight?
Mar 28 2019
Mar 27 2019
I figured it out
Mar 26 2019
@cmadeo no problem! I exported the pluses myself just to see what it would look like, the limitation was my animation skills 🤨, not the assets
There's probably something I'm missing here but I don't know how to make sure the pluses don't overlap the image when it scales. In our current onboarding animations, the central image is always a square and the smaller elements are positioned around it. Here, some of the pluses are "inside" the central image. I don't know how to allow the image to scale and position the pluses in a way that won't make them overlap the image at some point.