Thu, Sep 19
Wed, Sep 18
Fri, Sep 13
Thu, Sep 12
I couldn't find anything about a public API that lets us hook into the undo / redo actions as of iOS 13.1.
I couldn't reproduce this on a device running 12.4.1, here's a gif of what the flow looked like for me -
Thu, Sep 5
Wed, Sep 4
Tue, Sep 3
Per 09/03/2019 sync, it'd be ideal to be able to restore the feed position.
Fri, Aug 30
Thu, Aug 29
The file appears to be unsigned.
When the language changes in Settings, the app is relaunched and (mostly) restored to its previous state.
Wed, Aug 28
Tue, Aug 27
Mon, Aug 26
The solution to this is related to the modal presentation of Settings (T229489). If we stick with the full screen modal presentation (default < iOS 12), this will be fixed. If we use the new iOS 13 modal presentation (card that can be dismissed), this will require further investigation - the swipes seems to be interfering with each other (dismissal vs font size slider swipe).
The PR that excludes the app from dark mode was merged into the xcode_11 branch (https://github.com/wikimedia/wikipedia-ios/pull/3165).
Some system controls end up being too dark/light when there's a system/app theme mismatch.
The reorderControl caught by @Tsevener is not exposed via a public API so we can't adjust its tint color. Setting a custom editingAccessoryView results in not being able to drag & reorder items.
Fri, Aug 23
On iOS, we append 2 special items to TOC - “About this article” (https://github.com/wikimedia/wikipedia-ios/blob/ca4df05eaeab29aaa9c023aa8bb9ce59f5feb39e/Wikipedia/Code/WMFArticleContainerViewController%2BTOC.swift#L124) and "Read more" (https://github.com/wikimedia/wikipedia-ios/blob/ca4df05eaeab29aaa9c023aa8bb9ce59f5feb39e/Wikipedia/Code/WMFArticleContainerViewController%2BTOC.swift#L127).
If the user taps on “About this article“, we scroll them to pagelib_footer_container_menu. For “Read more”, it’s pagelib_footer_container_readmore (https://github.com/wikimedia/wikipedia-ios/blob/ca4df05eaeab29aaa9c023aa8bb9ce59f5feb39e/Wikipedia/Code/WMFArticleContainerViewController%2BTOC.swift#L60).
Thu, Aug 22
Aug 22 2019
This is not reproducible on a device (iPhone 7 Plus) running iOS 13 beta 8, only on a simulator. This is not reproducible on a device (iPhone 7 Plus) running iOS 13 beta 8 (or previous), only on a simulator.
Aug 20 2019
Aug 16 2019
Aug 14 2019
Thank you for all the information @Mholloway, that's super helpful!
Aug 9 2019
Aug 8 2019
User added that the problem is occasional and it occurs when editing the references and/or external links sections
Aug 7 2019
If "Open app on Search" is on and I leave the app with a stack of articles pushed from Search, should I have the stack restored or not (assuming it happens before the cutoff date)?
Aug 6 2019
- Sparkline: https://wikimedia.org/api/rest_v1/metrics/edits/per-page/www.en.wikipedia.org/Ching_Shih/all-editor-types/daily/20170404/20190806. Queryable timespan is limited to 1 year. We could assume that the start year is current year - 1 but if a page was created less than 1 year ago, we'll get a 400 response (https://wikimedia.org/api/rest_v1/metrics/edits/per-page/www.test.wikipedia.org/Young_page/all-editor-types/daily/20170806/20190806). We could get page's creation date using https://xtools.wmflabs.org/api/page/articleinfo/en.wikipedia.org/Ching_Shih (created_at).
- Getting total number of edits for page: https://xtools.wmflabs.org/api/page/articleinfo/en.wikipedia.org/Ching_Shih (revisions)
- Getting total number of editors for page: https://xtools.wmflabs.org/api/page/articleinfo/en.wikipedia.org/Ching_Shih (editors)
- Count of minor/ip/bot/reverted edits for page: XTools API doesn’t expose those in the API response for articleinfo, looks like it could be included:
- Building the response: https://github.com/x-tools/xtools/blob/6d8f265ec0aecf6f3a6909b742cc4cda0d28d94f/src/AppBundle/Controller/ArticleInfoController.php#L238
- Gettings counts https://github.com/x-tools/xtools/blob/19bcac6775a8302273a4314bbfe1b0e753458255/src/AppBundle/Model/ArticleInfo.php#L485
- Talk page question: https://www.mediawiki.org/wiki/Topic:V4x15ga6upb875w1
- It's possible to add an option to get the number of minor & IP edits. Getting the number of reverted edits would be too slow for an API endpoint (it's an approximate figure anyway).
- Total number of edits for user: https://xtools.wmflabs.org/api/user/simple_editcount/en.wikipedia/Badylek (live_edit_count). API docs state that To ensure performance and stability, most endpoints related to users will return an error if the user has made an exceptionally high number of edits. (https://xtools.readthedocs.io/en/stable/api/index.htm)
- Sending thanks:
- api.php?action=thank&rev=16543&token=%2B\, https://www.mediawiki.org/wiki/Extension:Thanks#API_Documentation
- Python example: https://gist.github.com/notconfusing/460d6ffb6682439ebe6b70b78e7759af#file-flask_thank_app-py-L60
Aug 2 2019
Aug 1 2019
Jul 19 2019
It looks like the endpoint we're using to get languages for articles in the main namespace doesn't return languages for user talk pages.
Jul 18 2019
Jul 17 2019
Jul 12 2019
This is the object we're using to register InteractionHandler and receive interaction messages: https://github.com/wikimedia/wikipedia-ios-lite/blob/55ba227f2db2a9a815319d032d6129ea75669481/lite/WKUserScripts/InteractionSetupUserScript.swift#L3
@bearND Unfortunately, no. iOS is doing all the decoding of JS messages and I'm just getting a dictionary with the result. There's no way for me to get raw JS and implement decoding on my own on the native side.
Jul 11 2019
Jul 10 2019
Jul 8 2019
Jul 5 2019
Server fix is live, moving to QA
Looks good on iOS
The API response for that day (tickets filed on 07/01/2019) didn't include a featured article - https://de.wikipedia.org/api/rest_v1/feed/featured/2019/07/01 ("tfa") even though German Wikipedia did feature an article on that day https://de.wikipedia.org/wiki/Wikipedia:Hauptseite/Artikel_des_Tages/Chronologie_2019 ("01.07.2019 Kerala").
Jul 2 2019
Jun 28 2019
This seems to be happening for languages with non-latin scripts. iOS is giving us a wrong url - instead of giving us a url with the correct language, it gives us a url with the 1st preferred language with latin script. I tested Russian, Chinese, Japanese and Arabic.
See https://phabricator.wikimedia.org/T226762. This should be retested after the server fix is deployed.
Jun 27 2019
Adding iOS for tracking