Page MenuHomePhabricator

Nbdd0121
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jan 7 2016, 6:11 PM (429 w, 13 h)
Availability
Available
LDAP User
Unknown
MediaWiki User
Nbdd0121 [ Global Accounts ]

Recent Activity

May 20 2019

Nbdd0121 added a comment to T223834: generateSitemap.php generating more links in each segment file than the url_limit 50000.

I don't think my original patch is ever merged.

May 20 2019, 12:56 AM · Moegirlpedia, MediaWiki-Maintenance-system

Jul 30 2016

Nbdd0121 added a comment to T129499: Move ZhConversion conversion tables from static class to array file.

@Liuxinyu970226 It is not that these codes cannot be converted to JSON. Instead, there's no reason to convert them to JSON. They are statically generated and no one is supposed to change it manually. By keeping them in PHP files, we can actually gain performance from OPcache. If we made them JSON, an extra step of JSON parsing will be required, or extra caching will be needed to compensate the performance degradation.

Jul 30 2016, 1:21 PM · Chinese-Sites, MediaWiki-Language-converter, MediaWiki-Internationalization

Jun 3 2016

Nbdd0121 created T137002: Incorrect dependency configuration of momentjs - should depend on mediawiki.language.
Jun 3 2016, 11:30 PM · MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)), MW-1.28-release-notes, MediaWiki-General, good first task

May 31 2016

Nbdd0121 added a comment to T134027: Improper default settings for grants.

This isn't really 1.27-specific, untagging.

May 31 2016, 4:10 PM · MW-1.27-release-notes, MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)), MW-1.27-release, MediaWiki-extensions-General

May 24 2016

Nbdd0121 added a comment to T135170: Require POST in ?action=purge.

I oppose this change, for users with purge right they should be able to purge without confirmation regardless POST or GET.

May 24 2016, 1:47 PM · MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)), MW-1.28-release-notes, MediaWiki-Action-API, Community-Relations-Support, Patch-For-Review, Performance Issue

May 22 2016

Nbdd0121 added a comment to T132538: isConfiguredProxy not recognizing $wgSquidServers with port.

What about repeating them (without port) in $wgSquidServersNoPurge?

May 22 2016, 11:06 PM · Patch-Needs-Improvement, MediaWiki-General
Nbdd0121 claimed T65098: Sitemap doesn't count language variant entries against the url_limit, causing it to be rejected.

This is a bug indeed. The 50,000 url limit is currently imposed on number of articles, instead of number of entries generated.

May 22 2016, 8:54 PM · Patch-Needs-Improvement, Chinese-Sites, MediaWiki-Maintenance-system

May 5 2016

Nbdd0121 added a comment to T134465: Internal links supports parameters spliced by vertical bar.

I am against adding this. As Bawolff said, this could make syntax more complex. We have more straightforward way to solve the problem, for example, like stated in zh.wp's discussion, use a special page that mimics Special:Diff (named Special:Action for example).

May 5 2016, 7:25 PM · MediaWiki-Parser
Nbdd0121 updated the task description for T134465: Internal links supports parameters spliced by vertical bar.
May 5 2016, 7:16 PM · MediaWiki-Parser

Apr 30 2016

Nbdd0121 added a comment to T134027: Improper default settings for grants.

@Aklapper "Grants" is the new feature introduced in MediaWiki 1.27 (which is migrated from OAuth plugin), and in DefaultSettings.php, two rights, torunblock and autoreview are listed. I am saying that these two rights are not expected to be there. This is an improper implementation, so reproducing is easy: do a fresh installation and navigate to Special:ListGrants, and you will see these two rights are there.

Apr 30 2016, 2:34 PM · MW-1.27-release-notes, MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)), MW-1.27-release, MediaWiki-extensions-General
Nbdd0121 created T134027: Improper default settings for grants.
Apr 30 2016, 1:22 AM · MW-1.27-release-notes, MW-1.28-release (WMF-deploy-2016-06-14_(1.28.0-wmf.6)), MW-1.27-release, MediaWiki-extensions-General

Apr 25 2016

Nbdd0121 added a comment to T37704: Drop support in wikitext for inline styles.

It can be a great overhead for adding style tags instead of inline styles, if the style is used extensively in a page (this is the case for many fan-wikis, some of them contain a lot of colored texts).

Apr 25 2016, 8:05 PM · Community-consensus-needed, Epic, MediaWiki-Page-editing, Accessibility, MediaWiki-User-Interface
Nbdd0121 added a comment to T37704: Drop support in wikitext for inline styles.

Will adding colors text require use of TemplateStyles then? Some inline style like adding color or change font will not really introduce problems to mobile friendliness and security, why not support both inline styles and TemplateStyles? These could share a codebase for parsing and sanitizing.

Apr 25 2016, 7:43 PM · Community-consensus-needed, Epic, MediaWiki-Page-editing, Accessibility, MediaWiki-User-Interface

Apr 13 2016

Nbdd0121 created T132538: isConfiguredProxy not recognizing $wgSquidServers with port.
Apr 13 2016, 1:15 AM · Patch-Needs-Improvement, MediaWiki-General

Apr 8 2016

Nbdd0121 closed T131780: Hide MassEditRegex's "Edit All" button to those who don't have permission as Resolved.
Apr 8 2016, 11:51 PM · MediaWiki-extensions-MassEditRegex

Apr 4 2016

Nbdd0121 created T131780: Hide MassEditRegex's "Edit All" button to those who don't have permission.
Apr 4 2016, 5:28 PM · MediaWiki-extensions-MassEditRegex

Mar 26 2016

Nbdd0121 added a comment to T129499: Move ZhConversion conversion tables from static class to array file.

[Citation needed]

Mar 26 2016, 9:58 PM · Chinese-Sites, MediaWiki-Language-converter, MediaWiki-Internationalization

Mar 24 2016

Nbdd0121 added a comment to T129499: Move ZhConversion conversion tables from static class to array file.

Does it really matter? Currently the php file is built by maintenance tool anyway.

Mar 24 2016, 10:35 PM · Chinese-Sites, MediaWiki-Language-converter, MediaWiki-Internationalization
Nbdd0121 merged task T122768: momentjs does not support zh zh-hans zh-hant? into T123080: Moment.js does not support all Chinese languages that MediaWiki supports.
Mar 24 2016, 10:20 PM · MediaWiki-Internationalization, I18n, MediaWiki-ResourceLoader, Language-Team
Nbdd0121 updated subscribers of T123080: Moment.js does not support all Chinese languages that MediaWiki supports.
Mar 24 2016, 10:20 PM · MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)), MW-1.27-release-notes, Patch-For-Review, I18n, MediaWiki-General

Jan 19 2016

Nbdd0121 added a comment to T40848: Security: CSS positioning can be used to break out of the content area.

Just to comment that position:fixed also affect extensions, such as Flow. I suggest sanitize it completely.

Jan 19 2016, 11:38 PM · SecTeam-Processed, Vuln-Misconfiguration, Security, User-Tgr, TemplateStyles, MediaWiki-User-Interface

Jan 7 2016

Nbdd0121 created T123080: Moment.js does not support all Chinese languages that MediaWiki supports.
Jan 7 2016, 6:20 PM · MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)), MW-1.27-release-notes, Patch-For-Review, I18n, MediaWiki-General