@bd808
I'm indeed not subscribed to cloud-announce, I will register for it then...

@Bakertheacre
No, the Cobra library is integrated in WPCleaner, there's no need to get it.
So, you mean that even "Expand templates" doesn't work? I have to add logs to understand at what point it goes wrong.

@bd808
The temporary setup would be for a few weeks (ideally in my mind a bit after the holidays), so that most users will use WPCleaner at least once. When they use it once, it will retrieve the new configuration and will be fixed.

@bd808
I've got no answer from getdown developers, so I went browsing their code: I highly doubt that getdown is handling any kind of HTTP redirect, so using a 301 instead of a 308 won't achieve anything. They don't seem to use any HTTP aware library, just basic java.net classes.

I've modified the code to do so. It will be available in the next release.

It should be fixed. Available in the next release.

@Bakertheacre
You have 3 different options in the menu: Preview, Expand templates and Expand templates and Preview. Can you try each of them and tell me the result?

@bd808
Ok, for the explanation. Is there a possibility to change at least temporarily the way the redirect is done (not a 308)?

@Jerodlycett
I can't test now, but you can to modify the configuration, like the [[ [[Utilisateur:NicoV/WikiCleanerConfiguration#ISBN]] | French configuration ]], parameter general_isbn_templates, by adding a line ISBN|1,2,3,4,5,6,7,8,9,10|true.

Problem with 308: Permanent Redirect.

But there's one thing that worries me a lot: existing installations don't seem to pickup the redirection properly and don't update themselves

Everything seems fixed now, but if you did modifications as suggested in my first comment, you need to update getdown.txt, where you should have

@Jerodlycett
Yes, my suggestion only worked during the time with the problematic URL. Now that they are fixed, I need to change them also in the installer, in getdown configuration... In the process of doing so

Until I manage to understand how to properly deal with the domain migration of Toolforge, you can bypass the problem by editing the getdown.txt file in the folder where WPCleaner is installed.

Hello. Is it the same problem for my tool WPCleaner, T257384 ?
The redirect removes the top directory in the path, breaking all the tools for each user as the tool can't update itself.

Hello. Is it the same problem for my tool WPCleaner, T257384 ?
The redirect removes the top directory in the path, breaking all the tools for each user as the tool can't update itself.

This is due to Toolforge migration T234617, which introduces problems with filenames starting with the same name as the tool T257417, T254640, which is the case for WPCleaner. I will try to understand how to fix it later, very busy day...

@abi_ Ok, I've disabled the generation of the .po files in my build process.

It looks like normal logs (accessing CheckWiki API or MediaWiki API). I will have to add logs for the Preview.

I've added the restriction for chem tags. It will be available in the next release

@Marcodpat Will it be ok if WPCleaner stops reporting #56 in <chem> tags?

Detailed results for first part of enwiki (2020/07/06):

Then I'll have to add logs to understand what's going on.

@Bakertheacre Do you see anything else in the logs ?
This line in the log only is only the retrieval of article 9/11 in Movies Theory.

Released

@Bakertheacre I've done the improvements I thought about. If you think of other things to do, tell me.

I've also improved #19 (Headlines start with one "=") : if there's only one error at the last title, it will be fixed automatically

I've also improved #7 (Headings all start with three "=") : if there's only one title, it will be fixed automatically.

@Bakertheacre
I've also improved #83 (Heading start with three "=" and later with level two) : if the second title is with level two, there's a suggestion to change the first title to the same level (this suggestion is also applied automatically). It will be in the next release.

In T256807#6279236, @Bakertheacre wrote:

I noticed the Tool --> Preview does not do anything. Is that supposed to open a new web browser with my changes in it so I can verify before sending?

@Bakertheacre I've modified WPCleaner for #25, is it better?
Do you see other situations where this option could be beneficial?
I'm worried of adding it to places where it will result in incorrect modifications by the user, so I prefer avoiding to do it. For example, I won't suggest for Title 2 (because Title 3 is at the same level than Title 2), but I will suggest it for Title 5 (because Title 6 is at a correct level compared to Title 4). I've tested it on frwiki, and I have the feeling that it accounts for about half the errors for #25.

I'm adding the right clicking for #25 (heading hierarchy) when there's only one subtitle that has the problem (to avoid people changing only one title when there are several to change)

@Bakertheacre When a heading is in error, you usually have a "Edit TOC" function when you right-click on it : it allows to change the level of the titles, several at a time (because often to fix an error with the level you have to change several titles)

Released

Released

Released

@Jerodlycett : The modification I just did, only add, as the first option, the suggestion to end the comment at the end of the line if there's another comment beginning further down. Is it enough ?

This should be fixed. It will be available in the next release.

The current suggestion is not to close the comment at end of the next line, but to close it just before the next one begins... In the example, it results in ending it on the next line, but that's because the next comment begins there.

It should be fixed in the next release.
Such cases should be detected with 2 suggestions :

Currently, it's detected at least by #504 (reference in a title), I will see for it to be detected also by #8

Example on enwiki :

Hi @Bakertheacre , yes it's the intended behavior for the replacement : it doesn't change the final result, just properly close the first comment.

Should be fixed, will be available in the next release, after I've performed some extra testing (modifying the parser can have strange side effects sometimes...).

Fixed.

Fixed.

Yes, it seems fixed.

@Pols12 I haven't seen it recently

The problem is coming from Check Wiki project configuration, I fixed it.