Page MenuHomePhabricator

Nicolasmichel (Nicolasmichel)
User

Today

  • No visible events.

Tomorrow

  • No visible events.

Thursday

  • No visible events.

User Details

User Since
Jul 21 2025, 5:48 PM (39 w, 23 h)
Availability
Available
LDAP User
Nicolasmichel
MediaWiki User
NicolasDAMichel [ Global Accounts ]

Recent Activity

Nov 19 2025

Nicolasmichel added a comment to T338465: Overwrite file option in VideoCutTool didn't actually overwrite, but upload as a new file instead.

Patch pushed. I addressed some of the comments you left.
Implemented some basic storage of wikitext to not regenerate on every toggle.
Cleaned up WT generation function a bit (mainly removed the ugly duplicate code).
Fixed the download path typo & removed / commented out leftover debugging console.log(s).

Nov 19 2025, 3:34 PM · Patch-Needs-Improvement, good first task, VideoCutTool

Nov 18 2025

Nicolasmichel added a comment to T338465: Overwrite file option in VideoCutTool didn't actually overwrite, but upload as a new file instead.

Heyo, I pushed a patch to the branch.
As a summary of the changes:
For fresh uploads:

  1. Users uploading a fresh file are no longer presented with an overwrite option
  2. Users can edit title, comment, and wikitext. Source and description fields in wikitext is set to the comment / whatever the user manually changes them to.
Nov 18 2025, 8:21 PM · Patch-Needs-Improvement, good first task, VideoCutTool

Nov 17 2025

Nicolasmichel claimed T338465: Overwrite file option in VideoCutTool didn't actually overwrite, but upload as a new file instead.
Nov 17 2025, 7:42 PM · Patch-Needs-Improvement, good first task, VideoCutTool
Nicolasmichel added a comment to T338465: Overwrite file option in VideoCutTool didn't actually overwrite, but upload as a new file instead.

So it seems like we dont have a default value for the source source field on the current live version.
The "Created/rotated/trimmed/cropped and Uploaded by VideoCutTool" you refer to above is the comment which is added as part of the description.
When looking at other files on commons, people either list an external url or "own work" in the source field.
It would not be difficult to add another text input box (similar to title) where we prompt the user for their source -- obviously only when uploading a fresh file, in cases 2 & 3 nothing from what is mentioned above would need to change.
As it stands the user could manually edit the wikitext to set their source but its not indicated that they need to at all.

Nov 17 2025, 7:42 PM · Patch-Needs-Improvement, good first task, VideoCutTool

Nov 14 2025

Nicolasmichel added a comment to T338465: Overwrite file option in VideoCutTool didn't actually overwrite, but upload as a new file instead.

Okay, I finally got around to getting some work done on this. (code isnt pushed yet, just looking for some clarification)
I've made some changes such that if the user uploads their own file, they are not presented with overwrite as an option, just upload as new file.
When a user edits an existing file on commons they have both options.

Nov 14 2025, 8:51 PM · Patch-Needs-Improvement, good first task, VideoCutTool

Nov 10 2025

Nicolasmichel added a comment to T338465: Overwrite file option in VideoCutTool didn't actually overwrite, but upload as a new file instead.

Also, is the intended behavior that when overwriting a file that has already been edited, the index is incremented?
That is:
original upload: video.webm
first edit: video_edited_0.webm
overwrite of first edit: video_edited_1.webm

Nov 10 2025, 9:43 PM · Patch-Needs-Improvement, good first task, VideoCutTool
Nicolasmichel added a comment to T338465: Overwrite file option in VideoCutTool didn't actually overwrite, but upload as a new file instead.

Hey,
Yes I tested both new file upload & overwrite. The implementation behaves the same as live.

Nov 10 2025, 9:38 PM · Patch-Needs-Improvement, good first task, VideoCutTool
Nicolasmichel added a comment to T338465: Overwrite file option in VideoCutTool didn't actually overwrite, but upload as a new file instead.

Hello, thanks for the review! The MR has a subsequent commit with the requested changes + some basic unit tests.

Nov 10 2025, 8:13 PM · Patch-Needs-Improvement, good first task, VideoCutTool

Nov 7 2025

Nicolasmichel added a comment to T338465: Overwrite file option in VideoCutTool didn't actually overwrite, but upload as a new file instead.

Hello I've implemented a fix to the overwrite / new file bug. The merge request can be found here. Please provide any feedback that you all may have. Thanks!

Nov 7 2025, 2:26 PM · Patch-Needs-Improvement, good first task, VideoCutTool

Nov 6 2025

Nicolasmichel added a comment to T409210: Requesting GitLab account activation for [Nicolasmichel].

Request is being made for VideoCutTool bug: https://phabricator.wikimedia.org/T338465

Nov 6 2025, 7:20 PM · Essential-Work, Release-Engineering-Team (Doing 😎), GitLab (Account Approval)

Nov 4 2025

Nicolasmichel added a comment to T338465: Overwrite file option in VideoCutTool didn't actually overwrite, but upload as a new file instead.

Oops I must have dismissed that window in a previous session. I've submitted a unlock request form since I'm not yet in either of the groups. Thank you!

Nov 4 2025, 8:44 PM · Patch-Needs-Improvement, good first task, VideoCutTool
Nicolasmichel created T409210: Requesting GitLab account activation for [Nicolasmichel].
Nov 4 2025, 7:43 PM · Essential-Work, Release-Engineering-Team (Doing 😎), GitLab (Account Approval)
Nicolasmichel added a comment to T338465: Overwrite file option in VideoCutTool didn't actually overwrite, but upload as a new file instead.

Hello, I've implemented and tested a fix, and have come to the point where I'd like to submit a patch for code review.
I found this documentation for submitting patches on GitLab. As I dont have a developer-level account I looked to fork the repo, but cant seem to find the fork option in the GUI. I've attempted to login to GitLab as well and am "pending approval from your GitLab administrator".

Nov 4 2025, 7:08 PM · Patch-Needs-Improvement, good first task, VideoCutTool

Sep 16 2025

Nicolasmichel added a comment to T401524: Convert global spam blacklist into Special:BlockedExternalDomains.

Hi, is the goal of this task to create a script that import the domains found in the global spam blacklist as BlockedDomainFilters?
Would replicating SpamBlacklist's behavior of retrieving the txt/regex from meta wiki regularly, checking for diff and then storing any new domains be sufficient?

Sep 16 2025, 10:36 PM · AbuseFilter, SpamBlacklist

Sep 12 2025

Nicolasmichel added a comment to T206307: Remove wgContentTranslationHighMTCategory configuration.

Hello, I wanted to run the vagrant test suite (as detailed here) before making any changes related to this task, but I ran into quite a few problems.
I am on Macos 14.6.1 Sonoma.
The versions of multiple packages used in the testing suite (byebug, bundler) are older and require versions of ruby and the C compiler to match them.
I managed, after quite some trial and error, to get bundler to both install all the packages and run the testing script with the following: Ruby 2.6.10 (installed with rbenv) and clang from llvm@12.
llvm@12 is disabled by homebrew by default (14 is the oldest active) but it can still be installed by tapping homebrew/core, removing the disable line, installing with brew from the local copy, and then untapping core.

Sep 12 2025, 8:26 PM · RoadToWiki, good first task, ContentTranslation

Sep 9 2025

Nicolasmichel added a comment to T395323: Refactor LastEditInfo to hold UserIdentity instead of separate userId and userName pair.

Hi all, are there any further changes that are required? Or is the most recent patch set good to merge?

Sep 9 2025, 5:30 PM · MW-1.45-notes (1.45.0-wmf.19; 2025-09-16), good first task, AbuseFilter
Nicolasmichel added a comment to T381061: Add Kavalan (ckv) to Wikidata (lexemes + monolingual text).

A gerrit patch for Universal Language Selector can be found here.
Please let me know if there are any additional changes to be made.

Sep 9 2025, 5:28 PM · LPL Projects (Language Onboarding & Development Essential 2025 July-Sep), MW-1.45-notes (1.45.0-wmf.19; 2025-09-16), good first task, LPL Onboarding and Development, Wikimedia Taiwan, wmde-wikidata-tech, Wikidata, MediaWiki-extensions-CLDR, MediaWiki-Internationalization, I18n, Language codes

Sep 8 2025

Nicolasmichel added a comment to T381061: Add Kavalan (ckv) to Wikidata (lexemes + monolingual text).

Hello,
I'm updating jquery, and there appears to be multiple other changes that are unrelated to this task (spelling changes on other languages).
Is there a way to exclude these other updates, or should I go ahead and make a PR regardless?

Sep 8 2025, 2:48 PM · LPL Projects (Language Onboarding & Development Essential 2025 July-Sep), MW-1.45-notes (1.45.0-wmf.19; 2025-09-16), good first task, LPL Onboarding and Development, Wikimedia Taiwan, wmde-wikidata-tech, Wikidata, MediaWiki-extensions-CLDR, MediaWiki-Internationalization, I18n, Language codes

Sep 3 2025

Nicolasmichel added a comment to T381061: Add Kavalan (ckv) to Wikidata (lexemes + monolingual text).

Hello all, a pull request to add Kavalan to Language-data can be found here.
I am new to contributing to mediawiki so please provide any feedback you may have.

Sep 3 2025, 9:12 PM · LPL Projects (Language Onboarding & Development Essential 2025 July-Sep), MW-1.45-notes (1.45.0-wmf.19; 2025-09-16), good first task, LPL Onboarding and Development, Wikimedia Taiwan, wmde-wikidata-tech, Wikidata, MediaWiki-extensions-CLDR, MediaWiki-Internationalization, I18n, Language codes
Nicolasmichel claimed T381061: Add Kavalan (ckv) to Wikidata (lexemes + monolingual text).
Sep 3 2025, 9:03 PM · LPL Projects (Language Onboarding & Development Essential 2025 July-Sep), MW-1.45-notes (1.45.0-wmf.19; 2025-09-16), good first task, LPL Onboarding and Development, Wikimedia Taiwan, wmde-wikidata-tech, Wikidata, MediaWiki-extensions-CLDR, MediaWiki-Internationalization, I18n, Language codes

Aug 31 2025

Nicolasmichel added a comment to T395323: Refactor LastEditInfo to hold UserIdentity instead of separate userId and userName pair.

I am a (very) new contributor.
Ive created a patch that can be found here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/1183259
Please review at your earliest convenience and let me know if I've done anything horribly wrong.

Aug 31 2025, 2:44 PM · MW-1.45-notes (1.45.0-wmf.19; 2025-09-16), good first task, AbuseFilter

Aug 29 2025

Nicolasmichel claimed T395323: Refactor LastEditInfo to hold UserIdentity instead of separate userId and userName pair.
Aug 29 2025, 7:51 PM · MW-1.45-notes (1.45.0-wmf.19; 2025-09-16), good first task, AbuseFilter