@Tbayer and I discussed and reviewed. Here are our conclusions:
@Tbayer and I are going to meet a week from tomorrow to walk through the page issues EventLogging implementation for new and old treatments. We're waiting a week since I'm out Monday and Tuesday and we also want to allow more time for patches to be merged. Other devs are welcome to step forward, of course. /cc @ovasileva
I'm not sure if the fix for T201924 is live yet but this is still an issue.
This seems to be occurring for me. For example: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/452413/.
Mon, Aug 13
@alexhollender, I'm still digging through the code to respond to your feedback. I've had to restructure some things to understand them better and hope to have answers tomorrow.
@nray, I don't think so. I'm just as frustrated as anyone with the state of some of our fundamental UI components on mobile like the gallery or the really confusing "power off" / logout button in the menu and would like to see an overhaul which isn't really fair to pin on this task.
After discussion today, no one could or would speak on behalf of test_. The current proposal is to move forward with .test.js naming in the future which is used by Popups and Core.
@Jdlrobson, thanks! I've rebased the patch.
Can someone now document the difference between mw.eventLog.pageviewToken() and mw.eventlog.newPageInteractionToken() (how is each calculated, and when, and how long does it persist)?
I want to clarify that these new functions are in code review and not yet merged.
Fri, Aug 10
Add a getter for the pageViewToken property defined in the ext.eventLogging.subscriber module.
Done in https://gerrit.wikimedia.org/r/451885 as mw.eventLog.pageviewToken() and mw.eventlog.newPageInteractionToken(). The former is now used by reading depth (see below remark) and can be used by Popups' pageToken and that latter can be used by Popups' linkInteractionToken and Minerva's page issues.
Thu, Aug 9
@Jdlrobson, should be fixed now. I didn't realize this earlier but I was able to edit the remaining requested templates and didn't need to touch the underlying ambox logic, although it would ideally use the name parameter to generate a unique class name. Not a sustainable approach but at least we're starting to get some the data structure into the templates themselves.
It sounds like you're happy with it so I will ping RelEng on https://gerrit.wikimedia.org/r/#/c/integration/config/+/450635/.
Wed, Aug 8
Tue, Aug 7
@alexhollender, this is just a bug fix. Not sure if you want to check this out.
Mon, Aug 6
Moved to blocked on others based on review needed from RelEng.
Fri, Aug 3
Not seeing scales icon on http://reading-web-staging.wmflabs.org/wiki/Fiorello_H._La_Guardia
I've left feedback.
@Volker_E, are you done with a11y.wmflabs.org or should we keep that up?
The two lead paragraphs are out of order on mobile
@ovasileva, this seems important. Can we pull it in soon?
Thu, Aug 2
Image widening example from PCS (uses pagelib) https://en.wikipedia.org/api/rest_v1/page/mobile-html/God
I can repro again today. I felt confident at my go yesterday so I'm not sure if reproduction is flaky or I'm flaky. Beware!
Wed, Aug 1
@nray, I can no longer reproduce this issue either.
Tue, Jul 31
Refrain (even though it is extremely tempting) from writing new unit tests
We can always add QUnit.skip to tests we don't want to measure later too.
@Jdlrobson found some bugs:
- Not seeing scales icon on http://reading-web-staging.wmflabs.org/wiki/Fiorello_H._La_Guardia
- Lots of issues with balanced templates+icon combo
Mon, Jul 30
@ABorbaWMF, I don't have a list for the beta cluster or devwiki but any page can be copied from enwiki to the beta cluster. Can you use readers-web-master? It's less stable (it resynchronizes every 15 minutes and may be unavailable during this time) but mirrors enwiki.
Fri, Jul 27
This looks amazing. In the Page Library (Android / iOS), a failed image appears dark like this:
Thu, Jul 26
@Jdlrobson, I'm not sure if it's intentional but no fade is performed on large screens (where max-height clips the content).
Wed, Jul 25
We think the best way forward would be to remove subsection issues.
@Jdlrobson does this relate to your change for identifying issues by section level via 'h1,h2,h3,h4,h5,h6'? Maybe we can still leave the subsection issues inline but identify top level issues in the dialog by passing it h1 issues only?
This is ready for signoff pending @Volker_E's approval!
Tue, Jul 24
I agree, an image may have article content or device constraints. I propose we use the solution in the wikimedia-page-library instead, a padded span within a span for placeholders to enforce a ratio that is kept regardless of rendered width. For example, the image: