Wed, Oct 21
Tue, Oct 20
In the interest of moving this project forward which is already overly ambitious, aligning to whatever conventions RelEng has for all CI projects makes sense to me for the short term. For everyone except CI automation experts, I agree that going against standard expectations for NPM scripts is confusing though so please consider documenting discrepancies you identify. Obviously, changing all the CI infrastructure as part of this task though is out of scope.
Thu, Oct 1
@Jdrewniak, as discussed, Anri has put in a lot of work into building out this component but now the patch is quite large because it encompasses both this typeahead-search component and also the search form (T256041). If it helps reviewers, I suggest splitting out the input + dropdown (this task) from the form (T256041) into a separate patch and focusing on getting that merged first.
My understanding of what remains for this task: throw an error from the context of a Vue.js component and see if it would be tracked or not.
Sep 30 2020
Web had some prior discussion with the Release-Engineering-Team regarding this task and T257582 on and off thread. I think @nnikkhoui has also been collaborating with y'all already so hopefully none of this is news but Nikki has the WVUI repo fully containerized and Blubberized at this point. That is, patches submitted to the WVUI repo are now built and tested. 🎉
@nnikkhoui, this task is lower priority than the other build tasks but still important work that might be in your wheelhouse.
This task is medium priority but seems smallish and mostly independent of the other work. It would be a good starter task.
Sep 28 2020
Sep 25 2020
@nnikkhoui's patch^ adds a docker-compose config to WVUI. It includes a Node.js container for installing dependencies and building, as well as a Storybook container for development.
^Followed up on the open patch with some feedback that can be addressed in the meantime
Sep 23 2020
The above patches audit fix and upgrade everything in WVUI and Vector.^^^
@Volker_E, we upgraded all dependencies as of this morning. Can you try again after an NPM install?
Sep 22 2020
Sep 21 2020
Thank you, @sbassett! As a starting point, I've applied compatible fixes to WVUI with npm audit fix. This appears to have fixed all vulnerabilities detected by snyk.
Sep 18 2020
As far as I know, these configurations are statically defined per wiki.
Sep 17 2020
Sep 15 2020
@nray, thank you 👍
Sep 14 2020
Everything looks good to me @nray, can you tell me if #mw-page-base is expected to be missing? Also, who is the best person to write the mw-workspace-container task mentioned in sign-off?
Sep 10 2020
Sep 9 2020
@sbassett, @Reedy, we believe the NPM dependencies to be very stable for the WVUI library (now hosted in Gerrit) and the feat/search of Vector and ready for review. Code directly in the library and skin themselves are under active development.
Sep 8 2020
Sep 3 2020
I'm assuming the only Vue component I should be seeing is the search input. Can you confirm?
Correct. That's all that is wired up right now.
Sorry, I'm having trouble making sense of the gif andI haven't been able to repro. I see the Storybook scrollbar and the viewport kind of fighting. Using the up arrow from the top or down arrow from the bottom and carefully scrolling without highlighting the item shows correct selection behavior. Here are the steps I took:
Sep 2 2020
Hi @Addshore! @nnikkhoui is digging into the vuejs-components Docker implementation and had a few questions. I, ah, can't seem to find the WMDE contact list page any more but I think(?) you'd be the best person to talk about it. Would it be possible for y'all to meet and discuss?
Sep 1 2020
Aug 31 2020
@Volker_E, do you think this component still makes sense in the current implementation? Do we need this task?
This is in progress. @Anribolon will have a patch up today.
@Esanders, would you please add some detail? Is this for WVUI or another Vue.js project? For the former, there's some related discussion and differing perspectives in https://github.com/wikimedia/wvui/pull/76.
Can we have get an update on the WVUI and the Vector changes?
- The instrumentation is not wired up yet but the plan is to use the existing SearchSuggestion in Core so changes to Vector or WVUI will likely be minimal.
- The components are not done yet but getting there. See T255902.
- IE11 support is not done yet. That's under T244287.