Page MenuHomePhabricator

Niedzielski (Stephen Niedzielski)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2015, 9:18 PM (234 w, 6 d)
Availability
Busy Busy until Nov 4.
IRC Nick
niedzielski
LDAP User
Unknown
MediaWiki User
Niedzielski [ Global Accounts ]

Recent Activity

Fri, Oct 11

Masumrezarock100 awarded T226125: Updates to notifications container on mobile to make it more consistent with desktop a Like token.
Fri, Oct 11, 5:22 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MobileFrontend

Sep 7 2019

Masumrezarock100 awarded T204834: [Needs input] Show the category button on pages without any categories a Like token.
Sep 7 2019, 6:11 AM · Advanced Mobile Contributions, Readers-Web-Backlog (Design), MobileFrontend

Aug 29 2019

Niedzielski added a comment to T226562: [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens.

Replace the class names for the page actions icons with the new class

I ended up taking a no-JS approach. Let's see what folks think.

Aug 29 2019, 7:10 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Niedzielski moved T230693: [AMC] Update icon for "Page information" menu item from Needs QA to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 29 2019, 3:26 PM · Product-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski reassigned T229295: Cleanup AMC feature flagging from pmiazga to Edtadros.
Aug 29 2019, 3:26 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue (Desktop), Advanced Mobile Contributions
Niedzielski moved T229295: Cleanup AMC feature flagging from Needs QA to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 29 2019, 3:26 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue (Desktop), Advanced Mobile Contributions
Niedzielski added a comment to T230693: [AMC] Update icon for "Page information" menu item.

@alexhollender, sounds good. Updated QA (note: patch not yet merged).

Aug 29 2019, 3:25 PM · Product-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski updated the task description for T230693: [AMC] Update icon for "Page information" menu item.
Aug 29 2019, 3:25 PM · Product-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski claimed T226562: [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens.
Aug 29 2019, 3:17 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Niedzielski moved T226562: [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 29 2019, 3:17 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Niedzielski assigned T230693: [AMC] Update icon for "Page information" menu item to alexhollender.
Aug 29 2019, 3:08 PM · Product-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski added a comment to T230693: [AMC] Update icon for "Page information" menu item.

This is currently using the "info" icon in wikimedia.ui. Change it to use "infoFilled" and check with Alex that the icon used matches the attachment. If it's not we'll need to update the icon in OOUI (out of scope for this task).
DO NOT put a new SVG icon into the Minerva repo.

Aug 29 2019, 3:08 PM · Product-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions

Aug 28 2019

Niedzielski added a comment to T230034: [AMC] Menu handle has no active state.

@alexhollender, hm, since the toolbar is already grey maybe we need to use a translucent background. Something like:

Aug 28 2019, 7:15 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
Niedzielski created T231486: [Bug] ArgumentCountError in MobileFrontend/includes/amc/Manager.php: Too few arguments to function MobileFrontend\AMC\Manager::__construct().
Aug 28 2019, 6:07 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
Niedzielski added a comment to T230695: Render talk page as a tab (rather than a modal).

@Jdlrobson via discussion:

Aug 28 2019, 4:59 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions

Aug 27 2019

Niedzielski moved T206265: Bug: Section edit links should be hidden for blocked users from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 27 2019, 9:01 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), good first bug
Niedzielski reassigned T206265: Bug: Section edit links should be hidden for blocked users from Niedzielski to pmiazga.

@pmiazga, given your experience, I think you're in an ideal spot to review this change. I refactored some of the "loose" page permission checks into the MinervaPagePermissions implementation as it seemed quite appropriate. What I'm most unsure of is if any special work is needed when adding new permission actions (a special config in skin.json). (I'm not sure why this is configurable.) The distinction from the plain old "EDIT" action was needed as some parts of the code only care whether the page content model is editable and others care whether the active user can edit.

Aug 27 2019, 9:01 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), good first bug
Niedzielski closed T230860: Avoid hyphenation in URLs that span multiple lines as Resolved.

LGTM. Tested on https://en.m.wikipedia.beta.wmflabs.org/wiki/User:ShreyasMinocha/URL_Hyphenation_Demo?useskin=minerva on an emulated device.

Aug 27 2019, 7:11 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue
Niedzielski reopened T206358: Request Sauce Labs access for niedzielski as "Open".

@zeljkofilipin, I'm getting "Your trial period has ended. Upgrade now..." messages again :[ Can you take a look?

Aug 27 2019, 7:07 PM · Release-Engineering-Team-TODO
Niedzielski added a comment to T231054: Disabling the recent changes highlighting feature on Minerva.

From @Jdrewniak: what happens if we just disable the RC filter ResourceLoader module?

Aug 27 2019, 4:31 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski updated the task description for T231206: Turn on AMC outreach modal.
Aug 27 2019, 4:29 PM · Wikimedia-Site-requests, Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
Niedzielski added a comment to T226562: [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens.

Maybe we can start by only showing the labels at maximum width. Another option mentioned was show the labels below the icons so there's more room for wrapping.

Aug 27 2019, 4:20 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Niedzielski added a comment to T230034: [AMC] Menu handle has no active state.
.toggle-list__checkbox:checked + .toggle-list__toggle {
	outline: 0;
	background: @colorGray14;
}
Aug 27 2019, 2:12 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions

Aug 26 2019

Niedzielski placed T231014: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode" up for grabs.

Visit http://localhost:8181/wiki/Special:History/Foo?action=history on a mobile device.

@pmiazga and I are no longer able to reproduce this issue locally with or without the patch.

Aug 26 2019, 6:48 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Wikimedia-production-error
Niedzielski updated the task description for T231014: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode".
Aug 26 2019, 6:44 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Wikimedia-production-error
Niedzielski added a comment to T230034: [AMC] Menu handle has no active state.

Ok, I think we want something like this then:

Aug 26 2019, 6:11 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
Niedzielski claimed T231014: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode".
Aug 26 2019, 5:18 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Wikimedia-production-error
Niedzielski reassigned T230033: [ICONS] Increase touch targets from 40x40 to 44x44 from Nirzar to alexhollender.

@Nirzar, please weigh in on Design's requirements when you can.

Back to @alexhollender.

Aug 26 2019, 5:08 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Accessibility, Advanced Mobile Contributions
Niedzielski updated the task description for T226125: Updates to notifications container on mobile to make it more consistent with desktop.
Aug 26 2019, 4:03 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MobileFrontend
Niedzielski updated the task description for T226125: Updates to notifications container on mobile to make it more consistent with desktop.
Aug 26 2019, 4:02 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MobileFrontend
Niedzielski claimed T206265: Bug: Section edit links should be hidden for blocked users.
Aug 26 2019, 3:53 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), good first bug
Niedzielski moved T206265: Bug: Section edit links should be hidden for blocked users from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 26 2019, 3:52 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), good first bug
Niedzielski added a comment to T231205: Add shadow to nav menu drawer.

@alexhollender, should we update the notification drawer shadow?

Aug 26 2019, 3:07 PM · Google-Code-in-2019, good first bug, Readers-Web-Backlog

Aug 23 2019

Niedzielski moved T225535: Notifications tray (mobile) - design refinements from Doing to Needs Analysis on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 23 2019, 6:43 PM · Readers-Web-Backlog, Growth-Team, Notifications
Niedzielski placed T225535: Notifications tray (mobile) - design refinements up for grabs.

I've been poking around in the Echo extension which I haven't developed in previously. These are my recommendations for how to proceed with this task but I'm unsure if the changes are wanted or if we're the best team for them given component responsibilities:

Aug 23 2019, 6:42 PM · Readers-Web-Backlog, Growth-Team, Notifications
Niedzielski added a comment to T219434: No popup is shown when quickly hovering the same link twice.

Thanks @Lea_WMDE, @WMDE-Fisch, and @thiemowmde!

Aug 23 2019, 4:35 PM · Reference Previews, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews
Niedzielski moved T219434: No popup is shown when quickly hovering the same link twice from Blocked on Others to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 23 2019, 2:29 PM · Reference Previews, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews
Niedzielski reassigned T219434: No popup is shown when quickly hovering the same link twice from thiemowmde to Edtadros.
Aug 23 2019, 2:29 PM · Reference Previews, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews
Niedzielski updated the task description for T219434: No popup is shown when quickly hovering the same link twice.
Aug 23 2019, 2:28 PM · Reference Previews, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews

Aug 22 2019

Niedzielski added a comment to T226562: [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens.

I think the download button might be the only special case as it's added by JS. IIRC, the ToggleList menu entries are otherwise stock Minerva UI Icons that already include a (currently) hidden label that could be unhidden on CSS breakpoint.

Aug 22 2019, 6:55 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Niedzielski added a comment to T225535: Notifications tray (mobile) - design refinements.

@alexhollender, there are three icon colors currently AFAIK: progressive (blue), constructive (teal), and black. The recommendation in the description is to change progressive for read notifications only (a fourth color). Should the others be changed?

Aug 22 2019, 6:50 PM · Readers-Web-Backlog, Growth-Team, Notifications
Niedzielski updated the task description for T225535: Notifications tray (mobile) - design refinements.
Aug 22 2019, 6:47 PM · Readers-Web-Backlog, Growth-Team, Notifications
Niedzielski moved T225535: Notifications tray (mobile) - design refinements from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 22 2019, 6:01 PM · Readers-Web-Backlog, Growth-Team, Notifications
Niedzielski claimed T225535: Notifications tray (mobile) - design refinements.
Aug 22 2019, 6:01 PM · Readers-Web-Backlog, Growth-Team, Notifications
Niedzielski added a comment to T206354: Main menu should slide over content.

I think I missed this. Do we want to make the notification drawer shadow match while we're at it? (Currently it's a hard outline.)

Aug 22 2019, 5:10 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), MobileFrontend
Niedzielski placed T229440: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency up for grabs.

SVGs are updated in https://gerrit.wikimedia.org/r/531713. It sounds like @Jdlrobson and @Jdrewniak are exploring the sizing.

Aug 22 2019, 5:00 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions

Aug 21 2019

Niedzielski edited projects for T219434: No popup is shown when quickly hovering the same link twice, added: Readers-Web-Backlog; removed Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1).

@thiemowmde, friendly ping on this task. We're moving this out of our sprint board but please note there is a patch (just a revision of your original submission) ready for your consideration when you have the time: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Popups/+/488098/. Thank you!

Aug 21 2019, 5:56 PM · Reference Previews, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews
Niedzielski edited projects for T163853: Updates to "Last edited" element on mobile, added: Readers-Web-Backlog; removed Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1).

Per discussion: not a priority. Moving to backlog. We'll know more once AMC has been out for a while.

Aug 21 2019, 5:53 PM · Readers-Web-Backlog, MinervaNeue
Niedzielski placed T229360: [Tracking/Epic] Problems with RecentChanges advanced mobile contribution experience up for grabs.
Aug 21 2019, 5:52 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Epic, MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Advanced Mobile Contributions
Niedzielski moved T229360: [Tracking/Epic] Problems with RecentChanges advanced mobile contribution experience from Needs Design Review to Needs Analysis on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 21 2019, 5:51 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Epic, MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Advanced Mobile Contributions
Niedzielski edited projects for T229360: [Tracking/Epic] Problems with RecentChanges advanced mobile contribution experience, added: Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1); removed Readers-Web-Backlog.

Per discussion: moving to kanbanana (needs analysis). To analyst: please decide whether to keep this as a single task or split it into four. Once the task has been analyzed, it will need an estimate as per usual. We think this is still in scope for AMC.

Aug 21 2019, 5:51 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Epic, MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Advanced Mobile Contributions
Niedzielski reassigned T230033: [ICONS] Increase touch targets from 40x40 to 44x44 from alexhollender to Nirzar.

@Nirzar, please weigh in on Design's requirements when you can.

Aug 21 2019, 5:27 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Accessibility, Advanced Mobile Contributions
Niedzielski set the point value for T230162: "User Rights" in overflow menu has no icon to 2.
Aug 21 2019, 5:15 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Advanced Mobile Contributions
Niedzielski added a comment to T230656: Minerva styles the wrong selector for rollback link.

@Jdrewniak, just following up from the meeting: do you have what you need to QA?

Aug 21 2019, 5:13 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), MinervaNeue, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Confirmation prompt for rollback action, UI-Standardization, Advanced Mobile Contributions
Niedzielski assigned T230162: "User Rights" in overflow menu has no icon to ovasileva.
Aug 21 2019, 5:12 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Advanced Mobile Contributions
Niedzielski reassigned T225959: [Bug] Overflow menu has blank entry on community portal when no Wikidata item exists from Edtadros to Jdlrobson.
Aug 21 2019, 5:11 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski reassigned T230445: JS Error occurs when cancelling writing a comment on mobile structured talk pages from Edtadros to nray.
Aug 21 2019, 5:10 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), good first bug, MobileFrontend
Niedzielski reassigned T150189: Make toasts tappable links when redirecting a user away from a page from Edtadros to ovasileva.
Aug 21 2019, 5:10 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Niedzielski claimed T229440: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency.
Aug 21 2019, 3:08 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Niedzielski updated subscribers of T230815: [Bug] Gray fills viewport on mediawiki.org mobile site.

@nray, @Jdlrobson, do we want to do more analysis here? What do you think about moving this to blocked on others? We can close it if it the issue isn't seen after a week.

Aug 21 2019, 2:57 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
Niedzielski added a comment to T230034: [AMC] Menu handle has no active state.

This functionality is currently disabled for the user and overflow menus as it was for other elements on mobile:

Aug 21 2019, 2:56 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions

Aug 20 2019

Niedzielski awarded T226562: [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens a Love token.
Aug 20 2019, 7:10 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Niedzielski added a comment to T230692: [AMC] Add touch state to menu items.

Is this device specific or am I misunderstanding? This seems to work ok on the Chromium emulator and Android:

Aug 20 2019, 7:09 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski assigned T150189: Make toasts tappable links when redirecting a user away from a page to Edtadros.
Aug 20 2019, 6:56 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Niedzielski placed T150189: Make toasts tappable links when redirecting a user away from a page up for grabs.
Aug 20 2019, 6:56 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Niedzielski awarded T197690: Check the status of v8.js PHP extension, and assess its applicability for the needs of service-side rendering of Wikibase UI a Love token.
Aug 20 2019, 6:48 PM · Wikidata, Wikidata-Frontend
Niedzielski updated subscribers of T197690: Check the status of v8.js PHP extension, and assess its applicability for the needs of service-side rendering of Wikibase UI.

I'd be very interested in the status of this ticket too! I followed @SBisson's V8Js approach for implementing an isomorphic skin proof of concept. I was amazed at how easy it was and how little code it took! I think the benefits of being able to execute the same code both server and client side are difficult to overstate so it would be awesome to provide this functionality for interested skins and extensions.

Aug 20 2019, 6:48 PM · Wikidata, Wikidata-Frontend
Niedzielski closed T229972: [Bug] can't re-enter Talk overlay after adding a discussion, a subtask of T214647: [EPIC] Re-define the contract for displaying drawers and overlays in MobileFrontend, as Resolved.
Aug 20 2019, 6:13 PM · Patch-For-Review, Readers-Web-Backlog (Tracking), Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski closed T229972: [Bug] can't re-enter Talk overlay after adding a discussion as Resolved.

Tested on https://en.m.wikipedia.beta.wmflabs.org/wiki/User:Teststephen.

Aug 20 2019, 6:13 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
Niedzielski added a comment to T163853: Updates to "Last edited" element on mobile.

Given that AMC may be deployed to all users in time, do we want to remove this link instead?

Aug 20 2019, 5:19 PM · Readers-Web-Backlog, MinervaNeue
Niedzielski claimed T150189: Make toasts tappable links when redirecting a user away from a page.
Aug 20 2019, 5:12 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Niedzielski claimed T229972: [Bug] can't re-enter Talk overlay after adding a discussion.
Aug 20 2019, 5:08 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)

Aug 12 2019

Niedzielski placed T230162: "User Rights" in overflow menu has no icon up for grabs.
Aug 12 2019, 3:47 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Advanced Mobile Contributions
Niedzielski updated the task description for T230162: "User Rights" in overflow menu has no icon.
Aug 12 2019, 3:46 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Advanced Mobile Contributions
Niedzielski updated subscribers of T230033: [ICONS] Increase touch targets from 40x40 to 44x44.

@alexhollender, this change seemed like a nice improvement to me so I merged it. If there are any issues on your end, please let me know.

Aug 12 2019, 3:44 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Accessibility, Advanced Mobile Contributions
Niedzielski awarded T230033: [ICONS] Increase touch targets from 40x40 to 44x44 a Love token.
Aug 12 2019, 3:04 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Accessibility, Advanced Mobile Contributions
Niedzielski closed T225877: Two link rel="canonical" if $wgEnableCanonicalServerLink and $mfNoIndexPages is true as Resolved.
  • When $wgEnableCanonicalServerLink = true, <link rel="canonical" href="http://localhost:8181/wiki/Foo"> is included once on mobile pages regardless of $wgMFNoindexPages or $wgMobileUrlTemplate state.
  • When $wgEnableCanonicalServerLink = false and $wgMobileUrlTemplate is unset, the canonical link is not included on mobile pages regardless of $wgMFNoindexPages state.
  • When $wgEnableCanonicalServerLink = false and $wgMFNoindexPages = 'foo':
    • When $wgMFNoindexPages = true, the canonical link is included once on mobile pages.
    • When $wgMFNoindexPages = false, the canonical link is not included on mobile pages.
Aug 12 2019, 2:59 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Niedzielski added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

I've modified them, hopefully correctly and they show that Special:MobileMenu had ~15k total pageviews last year. Of those, ~4.7k pageviews were Opera Mini visits.

@phuedx, identified some flaws in these queries: no pageview filter and no accounting for 1/128th sampling. Updated queries:

Aug 12 2019, 2:02 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue

Aug 8 2019

Niedzielski placed T206354: Main menu should slide over content up for grabs.
Aug 8 2019, 9:05 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), MobileFrontend
Niedzielski moved T206354: Main menu should slide over content from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 8 2019, 9:05 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), MobileFrontend
Niedzielski added a comment to T206354: Main menu should slide over content.

Should we give the menu a max-width?
+1 to max-width. Please take into account that the logout button is right aligned aside of users with possibly a very long user name.

I've changed the max-width from tablet (600px) to a min-width of 250px that feels a lot lighter to me. Let me know what you think.

Aug 8 2019, 5:25 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), MobileFrontend
Niedzielski added a comment to T225959: [Bug] Overflow menu has blank entry on community portal when no Wikidata item exists.

@ovasileva, ^fix

Aug 8 2019, 2:02 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski closed T229664: Thumbnails are too small due to background-size for an icon as Resolved.

I tested this on https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog. LGTM

Aug 8 2019, 1:33 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, RelatedArticles

Aug 7 2019

Niedzielski closed T229036: [Bug] Watchlist has skewed thumbnails as Resolved.
Aug 7 2019, 5:54 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Niedzielski added a comment to T229664: Thumbnails are too small due to background-size for an icon.

Merge is still pending and is not ready for QA.

Aug 7 2019, 5:54 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, RelatedArticles
Niedzielski claimed T229664: Thumbnails are too small due to background-size for an icon.
Aug 7 2019, 5:22 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, RelatedArticles
Niedzielski claimed T229036: [Bug] Watchlist has skewed thumbnails.
Aug 7 2019, 5:21 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Niedzielski closed T207618: Flex box: Serious rendering issues in header/image captions on mobile IE and old versions of iOS (e..g.iPhone 5S) as Declined.

From the ticket, it's my understanding this bug impacts IE11 and iOS < v12. From the compatibility table, it's my understanding that we provide grade C support iOS >= v7. I don't know what version of desktop IE we support, so I picked IE11. With the regex, (iPhone OS [789]_)|(MSIE 11), it's my understanding that this bug impacts up to .002% of the 1.9B pageviews recorded in the last year and that this number will only decrease. Given our other priorities, I think it's unlikely that this issue will be fixed before these devices disappear completely so I'm regretfully declining this task. /cc @ovasileva @alexhollender @phuedx, please reopen if this is a priority.

Aug 7 2019, 5:06 PM · Browser-Support-Apple-Safari, User-Jdlrobson, Readers-Web-Backlog, good first bug, MinervaNeue, Browser-Support-Internet-Explorer, Mobile, MediaWiki-General
Niedzielski added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

@phuedx posted some nice queries specific to the page in question. I've modified them, hopefully correctly and they show that Special:MobileMenu had ~15k total pageviews last year. Of those, ~4.7k pageviews were Opera Mini visits.

Aug 7 2019, 4:28 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue
Niedzielski updated subscribers of T225213: [SPIKE 8hr] Main Menu should work without javascript.

For what it' worth, this same technique is used in Vector. On Readers Web we're fond of saying YAGNI (You Ain't Gonna Need It) to get rid of piles of code and complexity. Given our resourcing, we don't need this.

Aug 7 2019, 2:57 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue

Aug 6 2019

Niedzielski added a comment to T223566: Topic: edits should appear in Talk tab in Mobile Watchlist.

Possible duplicate of T220889.

Aug 6 2019, 4:41 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend Special Pages), Growth-Team, MediaWiki-Watchlist, StructuredDiscussions
Niedzielski added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

Could we also consider moving the Wikimedia-specific instrumentation for the main menu into the WikimediaEvents extension?

I think this was done in T228681 but could be mistaken.

Aug 6 2019, 4:11 AM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue
Niedzielski added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

@Jdlrobson, after re-reading my comment, I realized I could have worded it much better. I apologize as I didn't intend my response to come off as flippant. I've added some more detail below and we can dig into this in our 1:1 tomorrow as needed.

Aug 6 2019, 3:27 AM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue

Aug 5 2019

Niedzielski added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

The JavaScript load is a separate issue that never got addressed and is orthogonal to this. It would be trivial to disable the click handler for JS users... This page is meant for users such as those using Opera Mini.

Yes, I see this page on slow connections when I tap the menu so that's part of this issue too.

Aug 5 2019, 10:14 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue
Niedzielski added a comment to T206354: Main menu should slide over content.

@alexhollender, visible changes are here: https://readers-web-stephen.wmflabs.org/wiki/Foobarbaz. I'm looking into a test failure but need your blessing on the visual changes.

Aug 5 2019, 9:21 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), MobileFrontend
Niedzielski added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

I think 1) the usability win and 2) reduced tech debt are more than justification enough:

Aug 5 2019, 9:02 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue

Aug 2 2019

Niedzielski created T229691: [Bug] Notification drawer spins forever on load failure.
Aug 2 2019, 7:39 PM · Readers-Web-Backlog (Design), Notifications, MobileFrontend, Growth-Team
Niedzielski updated subscribers of T228159: Improve loading progress appearance when loading MF, or switching from MF to VE.

Adding @alexhollender and @Volker_E in case they want to make adjustments to other parts of MobileFrontend

Aug 2 2019, 4:03 PM · Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), Design, VisualEditor-MediaWiki-Mobile
Niedzielski added a comment to T228681: Decommision MobileWebMainMenuClickTracking.

A quick cleanup will also be necessary in mediawiki-config.

Aug 2 2019, 1:36 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue
pmiazga awarded T221137: Skin should reset SkinOptions on UserLogout action. a Love token.
Aug 2 2019, 10:58 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Advanced Mobile Contributions, MinervaNeue, Technical-Debt