Niedzielski (Stephen Niedzielski)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2015, 9:18 PM (174 w, 4 h)
Availability
Available
IRC Nick
niedzielski
LDAP User
Unknown
MediaWiki User
Niedzielski [ Global Accounts ]

Recent Activity

Yesterday

Niedzielski added a comment to T201124: Provide standard/reproducible way to access a PageToken.

@Tbayer and I discussed and reviewed. Here are our conclusions:

Tue, Aug 14, 8:26 PM · Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings, Readers-Web-Backlog
Niedzielski added a comment to T191532: Mobile page issues - instrument page issues.

@Tbayer and I are going to meet a week from tomorrow to walk through the page issues EventLogging implementation for new and old treatments. We're waiting a week since I'm out Monday and Tuesday and we also want to allow more time for patches to be merged. Other devs are welcome to step forward, of course. /cc @ovasileva

Tue, Aug 14, 7:56 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings
Niedzielski added a comment to T201925: Server error when viewing web proxies.

I'm not sure if the fix for T201924 is live yet but this is still an issue.

Tue, Aug 14, 3:29 PM · Cloud-Services
Niedzielski created T201925: Server error when viewing web proxies.
Tue, Aug 14, 2:01 PM · Cloud-Services
Niedzielski added a comment to T195176: Gerrit plugin "zuul" failed to load.

This seems to be occurring for me. For example: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/452413/.

Tue, Aug 14, 1:09 PM · Release-Engineering-Team, Gerrit
Niedzielski moved T191528: Mobile page issues - allow page issues to display different severity levels from Needs More Work to Doing on the Readers-Web-Kanbanana-Board board.
Tue, Aug 14, 12:20 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design

Mon, Aug 13

Niedzielski added a comment to T191528: Mobile page issues - allow page issues to display different severity levels.

@alexhollender, I'm still digging through the code to respond to your feedback. I've had to restructure some things to understand them better and hope to have answers tomorrow.

Mon, Aug 13, 10:01 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design
Niedzielski added a comment to T197110: [Bug] Changing gallery images causes an abrupt and jarring white flash.

@nray, I don't think so. I'm just as frustrated as anyone with the state of some of our fundamental UI components on mobile like the gallery or the really confusing "power off" / logout button in the menu and would like to see an overhaul which isn't really fair to pin on this task.

Mon, Aug 13, 5:54 PM · Patch-For-Review, MinervaNeue, Readers-Web-Backlog
Niedzielski added a comment to T197884: Update Readers Web coding convention for test filenames (and update violators).

After discussion today, no one could or would speak on behalf of test_. The current proposal is to move forward with .test.js naming in the future which is used by Popups and Core.

Mon, Aug 13, 5:39 PM · Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski created T201852: [Bug] Page issues sometimes reopens dialog.
Mon, Aug 13, 3:56 PM · MinervaNeue, Page-Issue-Warnings, Readers-Web-Backlog
Niedzielski added a comment to T188261: [MobileFrontend] Replace JSDuck with JSDoc.

@Jdlrobson, thanks! I've rebased the patch.

Mon, Aug 13, 3:34 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board, Patch-For-Review, Documentation, Technical-Debt, MobileFrontend, Epic, Readers-Web-Backlog
Niedzielski created T201843: TimedMediaHandler has verbose output when ResourceLoader debugging is enabled.
Mon, Aug 13, 2:51 PM · TimedMediaHandler-Player, Technical-Debt
Niedzielski added a comment to T201124: Provide standard/reproducible way to access a PageToken.

@Tbayer, the following came up in @Krinkle's code review and I was hoping to solicit your guidance:

Mon, Aug 13, 2:34 PM · Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings, Readers-Web-Backlog
Niedzielski added a comment to T201124: Provide standard/reproducible way to access a PageToken.

Can someone now document the difference between mw.eventLog.pageviewToken() and mw.eventlog.newPageInteractionToken() (how is each calculated, and when, and how long does it persist)?

I want to clarify that these new functions are in code review and not yet merged.

Mon, Aug 13, 1:20 PM · Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings, Readers-Web-Backlog
Niedzielski moved T199452: Introduce webpack config/node-qunit and port ModuleLoader from To Do to Doing on the Readers-Web-Kanbanana-Board board.
Mon, Aug 13, 12:24 PM · Readers-Web-Kanbanana-Board, MobileFrontend (MobileFrontend.js), Readers-Web-Backlog
Niedzielski claimed T199452: Introduce webpack config/node-qunit and port ModuleLoader.
Mon, Aug 13, 12:24 PM · Readers-Web-Kanbanana-Board, MobileFrontend (MobileFrontend.js), Readers-Web-Backlog

Fri, Aug 10

Niedzielski moved T201124: Provide standard/reproducible way to access a PageToken from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Fri, Aug 10, 7:35 PM · Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings, Readers-Web-Backlog
Niedzielski updated subscribers of T201124: Provide standard/reproducible way to access a PageToken.

Add a getter for the pageViewToken property defined in the ext.eventLogging.subscriber module.

Done in https://gerrit.wikimedia.org/r/451885 as mw.eventLog.pageviewToken() and mw.eventlog.newPageInteractionToken(). The former is now used by reading depth (see below remark) and can be used by Popups' pageToken and that latter can be used by Popups' linkInteractionToken and Minerva's page issues.

Fri, Aug 10, 6:28 PM · Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings, Readers-Web-Backlog
Niedzielski updated subscribers of T187207: Spin out a tiny EventLogging RL module for lightweight logging.

I don't know that this is entirely related but @Jdrewniak worked on an "EventLogging lite" implementation for Portals. Maybe this can be pulled into an NPM package?

Fri, Aug 10, 3:48 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Performance-Team (Radar), Analytics, Analytics-EventLogging
Niedzielski claimed T201124: Provide standard/reproducible way to access a PageToken.
Fri, Aug 10, 2:42 PM · Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings, Readers-Web-Backlog
Niedzielski moved T201124: Provide standard/reproducible way to access a PageToken from To Do to Doing on the Readers-Web-Kanbanana-Board board.
Fri, Aug 10, 2:42 PM · Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings, Readers-Web-Backlog
Niedzielski created T201687: [Bug] Async loading code if failing occludes the page and disables interactivity.
Fri, Aug 10, 2:12 PM · Readers-Web-Backlog (Design)

Thu, Aug 9

Niedzielski placed T201124: Provide standard/reproducible way to access a PageToken up for grabs.
Thu, Aug 9, 7:26 PM · Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings, Readers-Web-Backlog
Niedzielski moved T201124: Provide standard/reproducible way to access a PageToken from Doing to To Do on the Readers-Web-Kanbanana-Board board.
Thu, Aug 9, 7:26 PM · Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings, Readers-Web-Backlog
Niedzielski added a comment to T191528: Mobile page issues - allow page issues to display different severity levels.

@Jdlrobson, should be fixed now. I didn't realize this earlier but I was able to edit the remaining requested templates and didn't need to touch the underlying ambox logic, although it would ideally use the name parameter to generate a unique class name. Not a sustainable approach but at least we're starting to get some the data structure into the templates themselves.

Thu, Aug 9, 7:08 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design
Niedzielski added a comment to T188261: [MobileFrontend] Replace JSDuck with JSDoc.

It sounds like you're happy with it so I will ping RelEng on https://gerrit.wikimedia.org/r/#/c/integration/config/+/450635/.

Thu, Aug 9, 5:15 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board, Patch-For-Review, Documentation, Technical-Debt, MobileFrontend, Epic, Readers-Web-Backlog
Niedzielski claimed T201124: Provide standard/reproducible way to access a PageToken.
Thu, Aug 9, 12:46 PM · Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings, Readers-Web-Backlog
Niedzielski moved T201124: Provide standard/reproducible way to access a PageToken from To Do to Doing on the Readers-Web-Kanbanana-Board board.
Thu, Aug 9, 12:46 PM · Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings, Readers-Web-Backlog

Wed, Aug 8

Niedzielski placed T198947: There should not be multiple h1 tags on mobile page HTML: Restructure mobile web header for SEO and accessibility up for grabs.
Wed, Aug 8, 7:41 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Accessibility, Readers-Web-Backlog, MinervaNeue, Mobile, SEO
Niedzielski moved T198947: There should not be multiple h1 tags on mobile page HTML: Restructure mobile web header for SEO and accessibility from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Wed, Aug 8, 7:40 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Accessibility, Readers-Web-Backlog, MinervaNeue, Mobile, SEO
Niedzielski moved T188261: [MobileFrontend] Replace JSDuck with JSDoc from Blocked on Others to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Wed, Aug 8, 5:06 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board, Patch-For-Review, Documentation, Technical-Debt, MobileFrontend, Epic, Readers-Web-Backlog

Tue, Aug 7

Niedzielski updated subscribers of T173527: Allow people to explicitly choose skins for stationary and mobile.

@Jdlrobson, @Jdrewniak noticed a regression where the advanced settings were always shown when this patch was merged. Sorry, but we had to do a quick revert for now.

Tue, Aug 7, 5:35 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Reading-Web-Third-Party-Support, Readers-Web-Backlog (Tracking), MediaWiki-User-preferences, MobileFrontend
Niedzielski added a comment to T201131: Bug: Order of some paragraphs is flipped on mobile.

@alexhollender, this is just a bug fix. Not sure if you want to check this out.

Tue, Aug 7, 5:09 PM · Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, MobileFrontend
Niedzielski reassigned T201131: Bug: Order of some paragraphs is flipped on mobile from pmiazga to alexhollender.
Tue, Aug 7, 5:08 PM · Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, MobileFrontend
Niedzielski moved T201131: Bug: Order of some paragraphs is flipped on mobile from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board board.
Tue, Aug 7, 5:08 PM · Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, MobileFrontend
Niedzielski added a project to T201124: Provide standard/reproducible way to access a PageToken: Technical-Debt.
Tue, Aug 7, 4:34 PM · Patch-For-Review, Analytics, Analytics-EventLogging, MediaWiki-extensions-WikimediaEvents, Page-Previews, Readers-Web-Kanbanana-Board, Technical-Debt, Performance-Team (Radar), Page-Issue-Warnings, Readers-Web-Backlog

Mon, Aug 6

Niedzielski added a comment to T188261: [MobileFrontend] Replace JSDuck with JSDoc.

Moved to blocked on others based on review needed from RelEng.

Mon, Aug 6, 5:10 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board, Patch-For-Review, Documentation, Technical-Debt, MobileFrontend, Epic, Readers-Web-Backlog
Niedzielski moved T188261: [MobileFrontend] Replace JSDuck with JSDoc from Needs Code Review to Blocked on Others on the Readers-Web-Kanbanana-Board board.
Mon, Aug 6, 5:09 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board, Patch-For-Review, Documentation, Technical-Debt, MobileFrontend, Epic, Readers-Web-Backlog
Niedzielski claimed T198947: There should not be multiple h1 tags on mobile page HTML: Restructure mobile web header for SEO and accessibility.
Mon, Aug 6, 4:42 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Accessibility, Readers-Web-Backlog, MinervaNeue, Mobile, SEO
Niedzielski moved T198947: There should not be multiple h1 tags on mobile page HTML: Restructure mobile web header for SEO and accessibility from To Do to Doing on the Readers-Web-Kanbanana-Board board.
Mon, Aug 6, 4:42 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Accessibility, Readers-Web-Backlog, MinervaNeue, Mobile, SEO

Fri, Aug 3

Niedzielski placed T191528: Mobile page issues - allow page issues to display different severity levels up for grabs.
Fri, Aug 3, 8:34 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design
Niedzielski moved T191528: Mobile page issues - allow page issues to display different severity levels from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Fri, Aug 3, 8:34 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design
Niedzielski added a comment to T191528: Mobile page issues - allow page issues to display different severity levels.

Not seeing scales icon on http://reading-web-staging.wmflabs.org/wiki/Fiorello_H._La_Guardia

Fixed.

Fri, Aug 3, 8:33 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design
Niedzielski claimed T191528: Mobile page issues - allow page issues to display different severity levels.
Fri, Aug 3, 7:36 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design
Niedzielski moved T191528: Mobile page issues - allow page issues to display different severity levels from Needs More Work to Doing on the Readers-Web-Kanbanana-Board board.
Fri, Aug 3, 7:36 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design
Niedzielski placed T188261: [MobileFrontend] Replace JSDuck with JSDoc up for grabs.
Fri, Aug 3, 7:35 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board, Patch-For-Review, Documentation, Technical-Debt, MobileFrontend, Epic, Readers-Web-Backlog
Niedzielski assigned T191532: Mobile page issues - instrument page issues to Jdlrobson.
Fri, Aug 3, 7:35 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings
Niedzielski moved T191532: Mobile page issues - instrument page issues from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board board.
Fri, Aug 3, 7:34 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings
Niedzielski added a comment to T191532: Mobile page issues - instrument page issues.

https://gerrit.wikimedia.org/r/443569

I've left feedback.

Fri, Aug 3, 7:32 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings
Niedzielski added a comment to T192627: Feature branch: Page Previews excerpts should be referenced by `aria-describedby` so we can begin user testing.

@Volker_E, are you done with a11y.wmflabs.org or should we keep that up?

Fri, Aug 3, 5:18 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Accessibility, Page-Previews
Niedzielski added a comment to T199452: Introduce webpack config/node-qunit and port ModuleLoader.

Fri, Aug 3, 4:31 PM · Readers-Web-Kanbanana-Board, MobileFrontend (MobileFrontend.js), Readers-Web-Backlog
Niedzielski moved T197133: Remove the WatchstarGateway cache from Needs More Work to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Fri, Aug 3, 4:22 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, MobileFrontend, Technical-Debt, Readers-Web-Backlog
Niedzielski moved T201131: Bug: Order of some paragraphs is flipped on mobile from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Fri, Aug 3, 4:21 PM · Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, MobileFrontend
Niedzielski updated subscribers of T201131: Bug: Order of some paragraphs is flipped on mobile.

The two lead paragraphs are out of order on mobile

@ovasileva, this seems important. Can we pull it in soon?

Fri, Aug 3, 4:05 PM · Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, MobileFrontend
Niedzielski renamed T201131: Bug: Order of some paragraphs is flipped on mobile from Order of some paragraphs is flipped on mobile to Bug: Order of some paragraphs is flipped on mobile.
Fri, Aug 3, 4:00 PM · Audiences-QA, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, MobileFrontend

Thu, Aug 2

Niedzielski reassigned T197639: [spike,8hrs] Identify different entry points for MobileFrontend code splitting from Niedzielski to Jdlrobson.
Thu, Aug 2, 9:19 PM · MobileFrontend (MobileFrontend.js), Readers-Web-Kanbanana-Board, Spike, User-Jdlrobson, Readers-Web-Backlog, MinervaNeue
Niedzielski added a comment to T197639: [spike,8hrs] Identify different entry points for MobileFrontend code splitting.

@Jdlrobson, would you mind signing this off? I've updated T199452 to indicate that we should in fact start by attacking the mobile.startup module.

Thu, Aug 2, 9:18 PM · MobileFrontend (MobileFrontend.js), Readers-Web-Kanbanana-Board, Spike, User-Jdlrobson, Readers-Web-Backlog, MinervaNeue
Niedzielski moved T197639: [spike,8hrs] Identify different entry points for MobileFrontend code splitting from Blocked on Others to Ready for Signoff on the Readers-Web-Kanbanana-Board board.
Thu, Aug 2, 9:16 PM · MobileFrontend (MobileFrontend.js), Readers-Web-Kanbanana-Board, Spike, User-Jdlrobson, Readers-Web-Backlog, MinervaNeue
Niedzielski updated the task description for T197639: [spike,8hrs] Identify different entry points for MobileFrontend code splitting.
Thu, Aug 2, 9:15 PM · MobileFrontend (MobileFrontend.js), Readers-Web-Kanbanana-Board, Spike, User-Jdlrobson, Readers-Web-Backlog, MinervaNeue
Niedzielski updated the task description for T199452: Introduce webpack config/node-qunit and port ModuleLoader.
Thu, Aug 2, 9:15 PM · Readers-Web-Kanbanana-Board, MobileFrontend (MobileFrontend.js), Readers-Web-Backlog
Niedzielski added a comment to T197188: MobileFormatter should take into account mobile image dimension adjustments.

Image widening example from PCS (uses pagelib) https://en.wikipedia.org/api/rest_v1/page/mobile-html/God

Thu, Aug 2, 4:42 PM · Performance, Readers-Web-Backlog, MobileFrontend
Niedzielski added a comment to T200518: [Bug] Lazy loaded image placeholders larger than viewport cause horizontal scrollbar on small screens.

I can repro again today. I felt confident at my go yesterday so I'm not sure if reproduction is flaky or I'm flaky. Beware!

Thu, Aug 2, 12:17 PM · Audiences-QA, Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), MobileFrontend, Readers-Web-Backlog

Wed, Aug 1

Niedzielski moved T197133: Remove the WatchstarGateway cache from Blocked on Others to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Wed, Aug 1, 5:14 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, MobileFrontend, Technical-Debt, Readers-Web-Backlog
Niedzielski claimed T188261: [MobileFrontend] Replace JSDuck with JSDoc.
Wed, Aug 1, 5:06 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board, Patch-For-Review, Documentation, Technical-Debt, MobileFrontend, Epic, Readers-Web-Backlog
Niedzielski moved T188261: [MobileFrontend] Replace JSDuck with JSDoc from Needs More Work to Doing on the Readers-Web-Kanbanana-Board board.
Wed, Aug 1, 5:06 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board, Patch-For-Review, Documentation, Technical-Debt, MobileFrontend, Epic, Readers-Web-Backlog
Niedzielski placed T191532: Mobile page issues - instrument page issues up for grabs.
Wed, Aug 1, 5:06 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings
Niedzielski moved T191532: Mobile page issues - instrument page issues from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Wed, Aug 1, 5:06 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings
Niedzielski placed T188261: [MobileFrontend] Replace JSDuck with JSDoc up for grabs.
Wed, Aug 1, 5:05 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board, Patch-For-Review, Documentation, Technical-Debt, MobileFrontend, Epic, Readers-Web-Backlog
Niedzielski changed the edit policy for T200877: Forbid use of $.each, $.map, $.isArray in core JavaScript code.
Wed, Aug 1, 4:31 PM · MediaWiki-Core-Tests, Performance-Team (Radar), Google-Code-in-2018, Patch-For-Review, Readers-Web-Backlog, User-Jdlrobson
Niedzielski added a comment to T200518: [Bug] Lazy loaded image placeholders larger than viewport cause horizontal scrollbar on small screens.

@nray, I can no longer reproduce this issue either.

Wed, Aug 1, 1:46 PM · Audiences-QA, Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), MobileFrontend, Readers-Web-Backlog
Niedzielski updated the task description for T200518: [Bug] Lazy loaded image placeholders larger than viewport cause horizontal scrollbar on small screens.
Wed, Aug 1, 1:41 PM · Audiences-QA, Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), MobileFrontend, Readers-Web-Backlog
Niedzielski awarded T197188: MobileFormatter should take into account mobile image dimension adjustments a Like token.
Wed, Aug 1, 1:39 PM · Performance, Readers-Web-Backlog, MobileFrontend

Tue, Jul 31

Niedzielski moved T191532: Mobile page issues - instrument page issues from Needs Code Review to Doing on the Readers-Web-Kanbanana-Board board.
Tue, Jul 31, 5:08 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings
Niedzielski moved T197110: [Bug] Changing gallery images causes an abrupt and jarring white flash from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board board.
Tue, Jul 31, 4:53 PM · Patch-For-Review, MinervaNeue, Readers-Web-Backlog
Niedzielski added a comment to T197637: Document/estimate existing JavaScript code coverage in MobileFrontend.

Refrain (even though it is extremely tempting) from writing new unit tests

We can always add QUnit.skip to tests we don't want to measure later too.

Tue, Jul 31, 3:47 PM · Readers-Web-Kanbanana-Board, User-Jdlrobson, Readers-Web-Backlog, MobileFrontend, MinervaNeue
Niedzielski moved T191528: Mobile page issues - allow page issues to display different severity levels from Needs QA to Needs More Work on the Readers-Web-Kanbanana-Board board.
Tue, Jul 31, 12:54 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design
Niedzielski placed T191528: Mobile page issues - allow page issues to display different severity levels up for grabs.

@Jdlrobson found some bugs:

Tue, Jul 31, 12:54 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design

Mon, Jul 30

Niedzielski added a comment to T191528: Mobile page issues - allow page issues to display different severity levels.

@ABorbaWMF, I don't have a list for the beta cluster or devwiki but any page can be copied from enwiki to the beta cluster. Can you use readers-web-master? It's less stable (it resynchronizes every 15 minutes and may be unavailable during this time) but mirrors enwiki.

Mon, Jul 30, 8:23 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings, Design
Niedzielski claimed T191532: Mobile page issues - instrument page issues.
Mon, Jul 30, 6:33 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Issue-Warnings
Niedzielski reassigned T188261: [MobileFrontend] Replace JSDuck with JSDoc from Niedzielski to Jdlrobson.
Mon, Jul 30, 6:23 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board, Patch-For-Review, Documentation, Technical-Debt, MobileFrontend, Epic, Readers-Web-Backlog
Niedzielski moved T188261: [MobileFrontend] Replace JSDuck with JSDoc from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Mon, Jul 30, 6:23 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board, Patch-For-Review, Documentation, Technical-Debt, MobileFrontend, Epic, Readers-Web-Backlog

Fri, Jul 27

Niedzielski added a comment to T136693: Make lazy loading images resilient.

This looks amazing. In the Page Library (Android / iOS), a failed image appears dark like this:

Fri, Jul 27, 2:12 PM · Readers-Web-Backlog (Design), MobileFrontend
Niedzielski added a comment to T200518: [Bug] Lazy loaded image placeholders larger than viewport cause horizontal scrollbar on small screens.

Possible dup of T191893, T197188, T199351.

Fri, Jul 27, 2:02 PM · Audiences-QA, Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), MobileFrontend, Readers-Web-Backlog
Niedzielski created T200518: [Bug] Lazy loaded image placeholders larger than viewport cause horizontal scrollbar on small screens.
Fri, Jul 27, 2:00 PM · Audiences-QA, Readers-Web-Kanbanana-Board, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), MobileFrontend, Readers-Web-Backlog

Thu, Jul 26

Niedzielski updated the task description for T197718: Build sticky header navigation in beta.
Thu, Jul 26, 6:17 PM · Readers-Web-Backlog, MinervaNeue, Design
Niedzielski claimed T188261: [MobileFrontend] Replace JSDuck with JSDoc.
Thu, Jul 26, 6:14 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board, Patch-For-Review, Documentation, Technical-Debt, MobileFrontend, Epic, Readers-Web-Backlog
Niedzielski moved T188261: [MobileFrontend] Replace JSDuck with JSDoc from Needs More Work to Doing on the Readers-Web-Kanbanana-Board board.
Thu, Jul 26, 6:14 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board, Patch-For-Review, Documentation, Technical-Debt, MobileFrontend, Epic, Readers-Web-Backlog
Niedzielski moved T197639: [spike,8hrs] Identify different entry points for MobileFrontend code splitting from Doing to Blocked on Others on the Readers-Web-Kanbanana-Board board.
Thu, Jul 26, 6:13 PM · MobileFrontend (MobileFrontend.js), Readers-Web-Kanbanana-Board, Spike, User-Jdlrobson, Readers-Web-Backlog, MinervaNeue
Niedzielski moved T199157: [Spike ??hrs] Sticky header instrumentation from Blocked on Others to To Do on the Readers-Web-Kanbanana-Board board.
Thu, Jul 26, 6:13 PM · Analytics, Readers-Web-Backlog, MinervaNeue, Design
Niedzielski moved T199157: [Spike ??hrs] Sticky header instrumentation from To Do to Blocked on Others on the Readers-Web-Kanbanana-Board board.
Thu, Jul 26, 6:13 PM · Analytics, Readers-Web-Backlog, MinervaNeue, Design
Niedzielski added a comment to T197931: Truncate page issues.

@Jdlrobson, I'm not sure if it's intentional but no fade is performed on large screens (where max-height clips the content).

Thu, Jul 26, 1:10 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog

Wed, Jul 25

Niedzielski added a comment to T197932: Display section issues modal.

We think the best way forward would be to remove subsection issues.

@Jdlrobson does this relate to your change for identifying issues by section level via 'h1,h2,h3,h4,h5,h6'? Maybe we can still leave the subsection issues inline but identify top level issues in the dialog by passing it h1 issues only?

Wed, Jul 25, 5:34 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Issue-Warnings, Readers-Web-Backlog
Niedzielski moved T197133: Remove the WatchstarGateway cache from Needs More Work to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Wed, Jul 25, 5:18 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, MobileFrontend, Technical-Debt, Readers-Web-Backlog
Niedzielski added a comment to T192627: Feature branch: Page Previews excerpts should be referenced by `aria-describedby` so we can begin user testing.

This is ready for signoff pending @Volker_E's approval!

Wed, Jul 25, 5:08 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Accessibility, Page-Previews
Niedzielski moved T192627: Feature branch: Page Previews excerpts should be referenced by `aria-describedby` so we can begin user testing from Ready for Signoff to Blocked on Others on the Readers-Web-Kanbanana-Board board.
Wed, Jul 25, 5:07 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Accessibility, Page-Previews
Niedzielski added a comment to T192627: Feature branch: Page Previews excerpts should be referenced by `aria-describedby` so we can begin user testing.

@Volker_E , please review this when you can! We're eager to close this task! https://a11y.wmflabs.org/wiki/Main_Page

Wed, Jul 25, 5:07 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Accessibility, Page-Previews

Tue, Jul 24

Niedzielski added a comment to T197188: MobileFormatter should take into account mobile image dimension adjustments.

I agree, an image may have article content or device constraints. I propose we use the solution in the wikimedia-page-library instead, a padded span within a span for placeholders to enforce a ratio that is kept regardless of rendered width. For example, the image:

Tue, Jul 24, 5:38 PM · Performance, Readers-Web-Backlog, MobileFrontend
Niedzielski reassigned T186760: Provide a feature flagged way for logged in users to disable mobile optimisations from Ryasmeen to ovasileva.
Tue, Jul 24, 5:05 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Readers-Web-Kanbanana-Board, Patch-For-Review, Readers-Web-Backlog, MobileFrontend
Niedzielski added a parent task for T197133: Remove the WatchstarGateway cache: T195473: [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture.
Tue, Jul 24, 2:10 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Audiences-QA, Patch-For-Review, Readers-Web-Kanbanana-Board, MobileFrontend, Technical-Debt, Readers-Web-Backlog
Niedzielski added a subtask for T195473: [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture: T197133: Remove the WatchstarGateway cache.
Tue, Jul 24, 2:09 PM · Readers-Web-Backlog, MobileFrontend, MinervaNeue, Goal