Page MenuHomePhabricator

Niedzielski (Stephen Niedzielski)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2015, 9:18 PM (226 w, 4 d)
Availability
Available
IRC Nick
niedzielski
LDAP User
Unknown
MediaWiki User
Niedzielski [ Global Accounts ]

Recent Activity

Mon, Aug 12

Niedzielski placed T230162: "User Rights" in overflow menu has no icon up for grabs.
Mon, Aug 12, 3:47 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Advanced Mobile Contributions
Niedzielski updated the task description for T230162: "User Rights" in overflow menu has no icon.
Mon, Aug 12, 3:46 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Advanced Mobile Contributions
Niedzielski updated subscribers of T230033: Touch targets not large enough.

@alexhollender, this change seemed like a nice improvement to me so I merged it. If there are any issues on your end, please let me know.

Mon, Aug 12, 3:44 PM · Patch-For-Review, Readers-Web-Backlog (Design), MobileFrontend, Accessibility, Advanced Mobile Contributions
Niedzielski awarded T230033: Touch targets not large enough a Love token.
Mon, Aug 12, 3:04 PM · Patch-For-Review, Readers-Web-Backlog (Design), MobileFrontend, Accessibility, Advanced Mobile Contributions
Niedzielski closed T225877: Two link rel="canonical" if $wgEnableCanonicalServerLink and $mfNoIndexPages is true as Resolved.
  • When $wgEnableCanonicalServerLink = true, <link rel="canonical" href="http://localhost:8181/wiki/Foo"> is included once on mobile pages regardless of $wgMFNoindexPages or $wgMobileUrlTemplate state.
  • When $wgEnableCanonicalServerLink = false and $wgMobileUrlTemplate is unset, the canonical link is not included on mobile pages regardless of $wgMFNoindexPages state.
  • When $wgEnableCanonicalServerLink = false and $wgMFNoindexPages = 'foo':
    • When $wgMFNoindexPages = true, the canonical link is included once on mobile pages.
    • When $wgMFNoindexPages = false, the canonical link is not included on mobile pages.
Mon, Aug 12, 2:59 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Niedzielski added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

I've modified them, hopefully correctly and they show that Special:MobileMenu had ~15k total pageviews last year. Of those, ~4.7k pageviews were Opera Mini visits.

@phuedx, identified some flaws in these queries: no pageview filter and no accounting for 1/128th sampling. Updated queries:

Mon, Aug 12, 2:02 PM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue

Thu, Aug 8

Niedzielski placed T206354: Main menu should slide over content up for grabs.
Thu, Aug 8, 9:05 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), MobileFrontend
Niedzielski moved T206354: Main menu should slide over content from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Thu, Aug 8, 9:05 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), MobileFrontend
Niedzielski added a comment to T206354: Main menu should slide over content.

Should we give the menu a max-width?
+1 to max-width. Please take into account that the logout button is right aligned aside of users with possibly a very long user name.

I've changed the max-width from tablet (600px) to a min-width of 250px that feels a lot lighter to me. Let me know what you think.

Thu, Aug 8, 5:25 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), MobileFrontend
Niedzielski added a comment to T225959: [Bug] Overflow menu has blank entry on community portal when no Wikidata item exists.

@ovasileva, ^fix

Thu, Aug 8, 2:02 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski closed T229664: Thumbnails are too small due to background-size for an icon as Resolved.

I tested this on https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog. LGTM

Thu, Aug 8, 1:33 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, RelatedArticles

Wed, Aug 7

Niedzielski closed T229036: [Bug] Watchlist has skewed thumbnails as Resolved.
Wed, Aug 7, 5:54 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Niedzielski added a comment to T229664: Thumbnails are too small due to background-size for an icon.

Merge is still pending and is not ready for QA.

Wed, Aug 7, 5:54 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, RelatedArticles
Niedzielski claimed T229664: Thumbnails are too small due to background-size for an icon.
Wed, Aug 7, 5:22 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, RelatedArticles
Niedzielski claimed T229036: [Bug] Watchlist has skewed thumbnails.
Wed, Aug 7, 5:21 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Niedzielski closed T207618: Flex box: Serious rendering issues in header/image captions on mobile IE and old versions of iOS (e..g.iPhone 5S) as Declined.

From the ticket, it's my understanding this bug impacts IE11 and iOS < v12. From the compatibility table, it's my understanding that we provide grade C support iOS >= v7. I don't know what version of desktop IE we support, so I picked IE11. With the regex, (iPhone OS [789]_)|(MSIE 11), it's my understanding that this bug impacts up to .002% of the 1.9B pageviews recorded in the last year and that this number will only decrease. Given our other priorities, I think it's unlikely that this issue will be fixed before these devices disappear completely so I'm regretfully declining this task. /cc @ovasileva @alexhollender @phuedx, please reopen if this is a priority.

Wed, Aug 7, 5:06 PM · Browser-Support-Apple-Safari, User-Jdlrobson, Readers-Web-Backlog, good first bug, MinervaNeue, Browser-Support-Internet-Explorer, Mobile, MediaWiki-General
Niedzielski added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

@phuedx posted some nice queries specific to the page in question. I've modified them, hopefully correctly and they show that Special:MobileMenu had ~15k total pageviews last year. Of those, ~4.7k pageviews were Opera Mini visits.

Wed, Aug 7, 4:28 PM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue
Niedzielski updated subscribers of T225213: [SPIKE 8hr] Main Menu should work without javascript.

For what it' worth, this same technique is used in Vector. On Readers Web we're fond of saying YAGNI (You Ain't Gonna Need It) to get rid of piles of code and complexity. Given our resourcing, we don't need this.

Wed, Aug 7, 2:57 PM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue

Tue, Aug 6

Niedzielski added a comment to T223566: Topic: edits should appear in Talk tab in Mobile Watchlist.

Possible duplicate of T220889.

Tue, Aug 6, 4:41 PM · Readers-Web-Backlog, Growth-Team, MobileFrontend, MediaWiki-Watchlist, StructuredDiscussions
Niedzielski added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

Could we also consider moving the Wikimedia-specific instrumentation for the main menu into the WikimediaEvents extension?

I think this was done in T228681 but could be mistaken.

Tue, Aug 6, 4:11 AM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue
Niedzielski added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

@Jdlrobson, after re-reading my comment, I realized I could have worded it much better. I apologize as I didn't intend my response to come off as flippant. I've added some more detail below and we can dig into this in our 1:1 tomorrow as needed.

Tue, Aug 6, 3:27 AM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue

Mon, Aug 5

Niedzielski added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

The JavaScript load is a separate issue that never got addressed and is orthogonal to this. It would be trivial to disable the click handler for JS users... This page is meant for users such as those using Opera Mini.

Yes, I see this page on slow connections when I tap the menu so that's part of this issue too.

Mon, Aug 5, 10:14 PM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue
Niedzielski added a comment to T206354: Main menu should slide over content.

@alexhollender, visible changes are here: https://readers-web-stephen.wmflabs.org/wiki/Foobarbaz. I'm looking into a test failure but need your blessing on the visual changes.

Mon, Aug 5, 9:21 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), MobileFrontend
Niedzielski added a comment to T225213: [SPIKE 8hr] Main Menu should work without javascript.

I think 1) the usability win and 2) reduced tech debt are more than justification enough:

Mon, Aug 5, 9:02 PM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, MinervaNeue

Fri, Aug 2

Niedzielski created T229691: [Bug] Notification drawer spins forever on load failure.
Fri, Aug 2, 7:39 PM · Readers-Web-Backlog (Design), Notifications, MobileFrontend, Growth-Team
Niedzielski updated subscribers of T228159: Improve loading progress appearance when loading MF, or switching from MF to VE.

Adding @alexhollender and @Volker_E in case they want to make adjustments to other parts of MobileFrontend

Fri, Aug 2, 4:03 PM · Patch-For-Review, VisualEditor (Current work), Design, VisualEditor-MediaWiki-Mobile
Niedzielski added a comment to T228681: Decommision MobileWebMainMenuClickTracking.

A quick cleanup will also be necessary in mediawiki-config.

Fri, Aug 2, 1:36 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue
pmiazga awarded T221137: Skin should reset SkinOptions on UserLogout action. a Love token.
Fri, Aug 2, 10:58 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Advanced Mobile Contributions, MinervaNeue, Technical-Debt
Niedzielski closed T221137: Skin should reset SkinOptions on UserLogout action. as Resolved.
Fri, Aug 2, 1:13 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Advanced Mobile Contributions, MinervaNeue, Technical-Debt

Thu, Aug 1

Niedzielski claimed T206354: Main menu should slide over content.
Thu, Aug 1, 6:59 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), MobileFrontend
Niedzielski moved T206354: Main menu should slide over content from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Thu, Aug 1, 6:59 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Performance-Team (Radar), MobileFrontend
Niedzielski awarded T218159: ContentProviderFactory content proxy is incompatible with Popups when MFContentProviderScriptPath enabled a Heartbreak token.
Thu, Aug 1, 3:15 AM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski moved T219434: No popup is shown when quickly hovering the same link twice from Ready for Development to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Thu, Aug 1, 3:13 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, Patch-For-Review, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews
Niedzielski reassigned T219434: No popup is shown when quickly hovering the same link twice from Niedzielski to thiemowmde.

@thiemowmde, I've revised your patch (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Popups/+/488098/). Please review the latest changes when you can.

Thu, Aug 1, 3:13 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, Patch-For-Review, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews
Niedzielski updated the task description for T218159: ContentProviderFactory content proxy is incompatible with Popups when MFContentProviderScriptPath enabled.
Thu, Aug 1, 2:27 AM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog

Wed, Jul 31

Niedzielski updated subscribers of T218206: AMC Navigation - make main menu scrollable.

Scrolling indicator — it would be great to communicate to the user that there are more menu items offscreen/blow. When the menu is first opened the scrollbar should appear then quickly fade out, indicating the additional contents below (it seems like sometimes browsers do this by default - need to investigate further)

I've submitted a simple patch that adds a scrollbar as needed but more work is needed for fancy fade in / out scrollbars. This remaining work is available if someone wants it. @Jdrewniak, are these practical to do in CSS or is JS necessary?

Wed, Jul 31, 5:44 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski moved T225959: [Bug] Overflow menu has blank entry on community portal when no Wikidata item exists from Ready for Development to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Wed, Jul 31, 5:41 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski updated subscribers of T225959: [Bug] Overflow menu has blank entry on community portal when no Wikidata item exists.

@alexhollender says it's ok to remove menu resizing logic so we can remove the JS and the min-height.

Wed, Jul 31, 5:21 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski added a comment to T229440: Fix icon sizing by updating all 24x24 icons to 20x20 icons.

Wed, Jul 31, 4:38 PM · Readers-Web-Backlog, MinervaNeue, Mobile, MobileFrontend (MobileFrontend and MinervaNeue architecture), Advanced Mobile Contributions
Niedzielski added a comment to T225959: [Bug] Overflow menu has blank entry on community portal when no Wikidata item exists.

Do we think the dynamic resizing on small screens is important? I'd love to drop that resizing JavaScript and this min-height CSS if document scrolling can be used instead.

Wed, Jul 31, 4:16 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions

Tue, Jul 30

Niedzielski added a comment to T226068: AMC Outreach - Modal.

Thanks for the through notes, @nray.

Tue, Jul 30, 8:32 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski added a comment to T218206: AMC Navigation - make main menu scrollable.

I think this could be as simple as adding the following rules:

I like this task and hope we do it and that it's simple. If it's not simple, it may not be worthwhile since the main menu doesn't have many items in it.

Tue, Jul 30, 8:11 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski added a comment to T226125: Notifications should appear in a modal dialog or drawer.

@alexhollender, this looks nice to me! I think just morphing this task to your latest designs probably makes the most sense. We can then consider splitting it up after discussing implementation concerns.

Tue, Jul 30, 5:50 PM · Readers-Web-Backlog (Design), MobileFrontend
Niedzielski placed T224216: Add recent changes link into main menu for AMC up for grabs.
Tue, Jul 30, 5:32 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski moved T224216: Add recent changes link into main menu for AMC from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Tue, Jul 30, 5:32 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski moved T224216: Add recent changes link into main menu for AMC from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Tue, Jul 30, 5:20 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski claimed T224216: Add recent changes link into main menu for AMC.
Tue, Jul 30, 5:20 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski closed T229000: [Bug] All mobile options reverted when desktop preferences saved as Resolved.

LGTM

Tue, Jul 30, 1:30 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend

Mon, Jul 29

Niedzielski added a comment to T214540: [EPIC] AMC Navigation - user menu.

@Jdlrobson, @pmiazga, what is the intended behavior of the page actions overflow menu in Minerva desktop mode

I think we resolved this?

I'm still unclear what the expected behavior is. Should we show the page actions overflow menu or not in Minerva desktop? Here's the current behavior:

Mon, Jul 29, 11:47 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski added a comment to T214540: [EPIC] AMC Navigation - user menu.

AC1 H, J

This is a legit bug. I can repro. I'll investigate Monday.

Fixed and available on BC.

Mon, Jul 29, 8:13 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski added a project to T228235: Edits lost when clicking back from talk overlay: MobileFrontend.
Mon, Jul 29, 5:08 PM · Advanced Mobile Contributions, MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)

Sat, Jul 27

Niedzielski moved T214540: [EPIC] AMC Navigation - user menu from Needs More Work to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Sat, Jul 27, 7:31 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski added a comment to T214540: [EPIC] AMC Navigation - user menu.

I went through the test for every mode.

Thank you @Edtadros. Outstanding work as usual.

Sat, Jul 27, 7:31 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions

Fri, Jul 26

Niedzielski added a comment to T229023: [Bug] User Menu/Main Menu still in AMC mode on logout page.

I would love to have one-click log outs. Fixing this bug as a side-effect would be great but I think we'd need to show the log in button then in the main menu which might make this messier.

Fri, Jul 26, 1:44 PM · MobileFrontend, Readers-Web-Backlog

Thu, Jul 25

Niedzielski renamed T229024: GrowthExperiments shouldn't be setting the AMC mode from GrowthExtension shouldn't be setting the AMC mode to GrowthExperiments shouldn't be setting the AMC mode.
Thu, Jul 25, 6:53 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Growth-Team (Current Sprint), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), GrowthExperiments- HomepageDiscovery, Advanced Mobile Contributions, MinervaNeue
Niedzielski added a comment to T214540: [EPIC] AMC Navigation - user menu.

AC4

I was wrong about this. I guess the Sandbox is the only new link since contributions was already in the AMC main menu. This link is actually in top of Vector, not the sidebar like I said originally. Sorry for the confusion.

Thu, Jul 25, 6:45 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski created T229036: [Bug] Watchlist has skewed thumbnails.
Thu, Jul 25, 5:55 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Niedzielski closed T193077: Remove Page's View functionality, a subtask of T195482: [EPIC] Review and refactor Minerva components, as Resolved.
Thu, Jul 25, 5:51 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Epic, MobileFrontend, MinervaNeue
Niedzielski closed T193077: Remove Page's View functionality as Resolved.
Thu, Jul 25, 5:51 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski updated the task description for T193077: Remove Page's View functionality.
Thu, Jul 25, 5:51 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski claimed T193077: Remove Page's View functionality.
Thu, Jul 25, 5:08 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski closed T224070: Update notifications & search icons (AMC & non-AMC), a subtask of T214540: [EPIC] AMC Navigation - user menu, as Resolved.
Thu, Jul 25, 5:05 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski closed T224070: Update notifications & search icons (AMC & non-AMC) as Resolved.

Looks good on BC

Thu, Jul 25, 5:05 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski closed T212944: Update page issues folder structure as Resolved.
Thu, Jul 25, 5:03 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Page-Issue-Warnings, Technical-Debt
Niedzielski closed T212800: AMC feature flag can be superseded by a development query parameter, a subtask of T198313: [GOAL] Advanced mobile contributions, as Declined.
Thu, Jul 25, 4:32 PM · Advanced Mobile Contributions, Goal, Readers-Web-Backlog
Niedzielski closed T212800: AMC feature flag can be superseded by a development query parameter as Declined.

Being bold. @Edward's been testing and we've been developing without this.

Thu, Jul 25, 4:32 PM · Readers-Web-Backlog, Advanced Mobile Contributions
Niedzielski added a comment to T214540: [EPIC] AMC Navigation - user menu.

@Edtadros, I've updated the description to include testing vectors. I'm guessing this is our #1 priority or somewhere near the top. I've tried to keep it brief but comprehensive. If I've failed to elaborate sufficiently or you have questions, please ping me! GrowthExperiments instructions forthcoming.

Thu, Jul 25, 2:22 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski reassigned T214540: [EPIC] AMC Navigation - user menu from alexhollender to Edtadros.
Thu, Jul 25, 2:20 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski updated the task description for T214540: [EPIC] AMC Navigation - user menu.
Thu, Jul 25, 2:20 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski updated the task description for T229000: [Bug] All mobile options reverted when desktop preferences saved.
Thu, Jul 25, 2:05 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Niedzielski added a project to T229000: [Bug] All mobile options reverted when desktop preferences saved: MobileFrontend.
Thu, Jul 25, 2:03 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Niedzielski created T229000: [Bug] All mobile options reverted when desktop preferences saved.
Thu, Jul 25, 2:02 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend
Niedzielski added a comment to T214540: [EPIC] AMC Navigation - user menu.

I'll write QA steps tomorrow. Thanks @alexhollender, @Jdlrobson, @pmiazga <3

Thu, Jul 25, 3:24 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions

Wed, Jul 24

Niedzielski placed T214540: [EPIC] AMC Navigation - user menu up for grabs.
Wed, Jul 24, 5:09 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski moved T214540: [EPIC] AMC Navigation - user menu from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Wed, Jul 24, 5:09 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski removed a project from T225453: Identify prevalent component antipatterns in MobileFrontend: Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1).
Wed, Jul 24, 5:06 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski updated subscribers of T214540: [EPIC] AMC Navigation - user menu.

This was due to a bad rebase. I'll follow up.

This still looks funny to me. @alexhollender please make sure everything looks ok to you in AMC and default modes.

Wed, Jul 24, 12:41 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions

Tue, Jul 23

Niedzielski added a comment to T214540: [EPIC] AMC Navigation - user menu.

@alexhollender, the user avatar outline seems a little thick to me.

This was due to a bad rebase. I'll follow up.

Tue, Jul 23, 4:21 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski added a comment to T214540: [EPIC] AMC Navigation - user menu.

I've rebased all the patches and have been addressing feedback. The following patches are awaiting review:

Tue, Jul 23, 2:48 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions

Mon, Jul 22

Niedzielski moved T219434: No popup is shown when quickly hovering the same link twice from Doing to Ready for Development on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Mon, Jul 22, 6:56 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, Patch-For-Review, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews
Niedzielski claimed T214540: [EPIC] AMC Navigation - user menu.
Mon, Jul 22, 6:56 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski closed T228298: JS Cannot read property 'find' of undefined on Beta cluster as Resolved.
Mon, Jul 22, 5:14 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Beta-Cluster-reproducible, MobileFrontend

Fri, Jul 19

Niedzielski claimed T219434: No popup is shown when quickly hovering the same link twice.
Fri, Jul 19, 2:21 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, Patch-For-Review, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews
Niedzielski moved T219434: No popup is shown when quickly hovering the same link twice from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Fri, Jul 19, 2:21 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, Patch-For-Review, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews

Jul 12 2019

Niedzielski added a comment to T214540: [EPIC] AMC Navigation - user menu.

Current task status:

Jul 12 2019, 3:26 AM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions

Jul 11 2019

Niedzielski moved T214540: [EPIC] AMC Navigation - user menu from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Jul 11 2019, 5:06 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski moved T212944: Update page issues folder structure from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Jul 11 2019, 5:05 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Page-Issue-Warnings, Technical-Debt
Niedzielski added a parent task for T227726: Security review of preact 8.4.2: T225577: Audit component library for MobileFrontend's security.
Jul 11 2019, 12:54 AM · Readers-Web-Backlog (Tracking), Security-Team-Reviews
Niedzielski added a subtask for T225577: Audit component library for MobileFrontend's security: T227726: Security review of preact 8.4.2.
Jul 11 2019, 12:54 AM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt

Jul 10 2019

Niedzielski updated subscribers of T225453: Identify prevalent component antipatterns in MobileFrontend.

We discussed this ticket in the Frontend Standards meeting today (/cc @Mooeypoo). This task only lists problems encountered in MobileFrontend components but the sentiment from Volker, Eric, Ed, and Jon was that this problem is actually much broader to frontend development and any solution to these issues would probably be wanted elsewhere, so we should be mindful of that.

Jul 10 2019, 9:11 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski moved T212944: Update page issues folder structure from Ready for Signoff to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Jul 10 2019, 8:12 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Page-Issue-Warnings, Technical-Debt
Niedzielski placed T212944: Update page issues folder structure up for grabs.
Jul 10 2019, 8:12 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Page-Issue-Warnings, Technical-Debt
Niedzielski claimed T212944: Update page issues folder structure.
Jul 10 2019, 5:06 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue, Page-Issue-Warnings, Technical-Debt
santhosh awarded T225453: Identify prevalent component antipatterns in MobileFrontend a 100 token.
Jul 10 2019, 3:59 AM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt

Jul 9 2019

Niedzielski added a comment to T214540: [EPIC] AMC Navigation - user menu.

@alexhollender: latest is on staging https://readers-web-stephen.wmflabs.org/wiki/Foobarbaz.

Jul 9 2019, 6:32 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski placed T214540: [EPIC] AMC Navigation - user menu up for grabs.
Jul 9 2019, 6:14 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski moved T214540: [EPIC] AMC Navigation - user menu from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Jul 9 2019, 6:14 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Patch-For-Review, Epic, Advanced Mobile Contributions
Niedzielski closed T218105: reference#fetchPreviewForTitle() should use model constructor as Resolved.
Jul 9 2019, 1:41 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Page-Previews, Reference Previews, Technical-Debt, Readers-Web-Backlog
Niedzielski renamed T225959: [Bug] Overflow menu has blank entry on community portal when no Wikidata item exists from [Bug] Overflow menu has blank entry on community portal to [Bug] Overflow menu has blank entry on community portal when no Wikidata item exists.
Jul 9 2019, 1:32 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski added a comment to T206826: [Bug] TypeError thrown when loading page with uBlock Origin enabled: wb.datamodel.Fingerprint is not a constructor.

@Mormegil, thanks!

Jul 9 2019, 1:30 PM · Regression, Wikidata