Niedzielski (sniedzielski)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2015, 9:18 PM (138 w, 5 d)
Availability
Available
IRC Nick
niedzielski
LDAP User
Unknown
MediaWiki User
Niedzielski

Recent Activity

Fri, Dec 8

Niedzielski committed rMARVf2c2ad0d0a5d: Chore: add query parameter typing (authored by Niedzielski).
Chore: add query parameter typing
Fri, Dec 8, 8:41 PM
Niedzielski committed rMARV98300e359852: Chore: add query parameter typing (authored by Niedzielski).
Chore: add query parameter typing
Fri, Dec 8, 8:14 PM
Niedzielski committed rMARVfe52310f4647: Update: allow query parameters in URL (authored by Niedzielski).
Update: allow query parameters in URL
Fri, Dec 8, 8:14 PM
Niedzielski claimed T178615: Add query parameter typing.
Fri, Dec 8, 8:03 PM · Patch-For-Review, Marvin
Niedzielski claimed T178617: Add query parameter parser.
Fri, Dec 8, 5:03 PM · Patch-For-Review, Marvin
Niedzielski committed rMARV2050cac92edb: Update: browser window / tab title per page (authored by Niedzielski).
Update: browser window / tab title per page
Fri, Dec 8, 4:14 PM
Niedzielski claimed T180465: Changing pages should update page title.
Fri, Dec 8, 4:11 PM · Patch-For-Review, Marvin
Niedzielski committed rMARVac05e3532ccc: Update: reset scroll position when visiting a new page (authored by Niedzielski).
Update: reset scroll position when visiting a new page
Fri, Dec 8, 2:09 PM
Niedzielski moved T182420: Scroll state should be reset when visiting a new page and restored when revisiting a prior page from Needs Triage to Backlog (Priority Descending) on the Marvin board.
Fri, Dec 8, 2:05 PM · Patch-For-Review, Marvin
Niedzielski claimed T182420: Scroll state should be reset when visiting a new page and restored when revisiting a prior page.
Fri, Dec 8, 2:05 PM · Patch-For-Review, Marvin
Niedzielski created T182420: Scroll state should be reset when visiting a new page and restored when revisiting a prior page.
Fri, Dec 8, 2:01 PM · Patch-For-Review, Marvin

Thu, Dec 7

Niedzielski committed rMARV39fac8034db2: Fix: image links don't load destination in place (authored by Niedzielski).
Fix: image links don't load destination in place
Thu, Dec 7, 7:22 PM
Niedzielski claimed T181901: Lead image links don't load in place.
Thu, Dec 7, 6:46 PM · Patch-For-Review, Marvin
Niedzielski added a comment to T179600: Add canonical title to mobile-sections lead.

@bearND, after discussing with Corey it sounds like this work will appear in PCS only. Please feel free to close this task.

Thu, Dec 7, 6:45 PM · Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), Marvin, Page Content Service
Niedzielski removed a project from T177367: Initial version of Marvin user interface chrome: Patch-For-Review.
Thu, Dec 7, 6:43 PM · Epic, Marvin
Niedzielski closed T177870: The router should handle all page titles as Resolved.

I believe this is resolved. Remaining work around page revision disambiguation will be covered in T178616.

Thu, Dec 7, 6:42 PM · Patch-For-Review, Marvin
Niedzielski updated the task description for T177681: Page URL should update on redirect.
Thu, Dec 7, 6:41 PM · Patch-For-Review, Marvin
Niedzielski closed T181900: Visiting a missing page causes a server error as Resolved.
Thu, Dec 7, 6:37 PM · Patch-For-Review, Marvin
Niedzielski committed rMARVdb924a310523: Fix: show original server errors (authored by Niedzielski).
Fix: show original server errors
Thu, Dec 7, 6:02 PM
joakin <joaquin@chimeces.com> committed rMARV2f20688f5c96: Fix: force File page images to wrap (authored by Niedzielski).
Fix: force File page images to wrap
Thu, Dec 7, 5:55 PM
joakin <joaquin@chimeces.com> committed rMARVaff8134d63ce: Fix: force File page images to wrap (authored by Niedzielski).
Fix: force File page images to wrap
Thu, Dec 7, 5:37 PM
Niedzielski committed rMARV620268ada8b0: Chore: add router tests for fetch errors (authored by Niedzielski).
Chore: add router tests for fetch errors
Thu, Dec 7, 4:09 PM
Niedzielski committed rMARVd3893f1a5501: Fix: visiting a missing wiki page causes a server error (authored by Niedzielski).
Fix: visiting a missing wiki page causes a server error
Thu, Dec 7, 3:07 PM
Niedzielski committed rMARV6a8b828133af: Fix: visiting a missing wiki page causes a server error (authored by Niedzielski).
Fix: visiting a missing wiki page causes a server error
Thu, Dec 7, 3:04 PM
Niedzielski added a comment to T182103: 404 responses do not specify CORS headers.

Thank you!

Thu, Dec 7, 3:04 PM · RESTBase-API, Services (done), Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, RESTBase, Marvin
Niedzielski changed the status of T181900: Visiting a missing page causes a server error from Stalled to Open.
Thu, Dec 7, 3:03 PM · Patch-For-Review, Marvin
Niedzielski committed rMARVed256645ba20: Fix: show original server errors (authored by Niedzielski).
Fix: show original server errors
Thu, Dec 7, 2:10 PM
Niedzielski committed rMARV5ca6d41f059a: Fix: show original server errors (authored by Niedzielski).
Fix: show original server errors
Thu, Dec 7, 1:55 PM
Niedzielski committed rMARVa87dfd443144: Fix: gracefully handle redirects to external sites (authored by Niedzielski).
Fix: gracefully handle redirects to external sites
Thu, Dec 7, 1:54 PM
Niedzielski committed rMARV501957a52d38: Fix: force File page images to wrap (authored by Niedzielski).
Fix: force File page images to wrap
Thu, Dec 7, 1:54 PM
Niedzielski committed rMARVf55616965590: Fix: return not found wiki pages as 404s (authored by Niedzielski).
Fix: return not found wiki pages as 404s
Thu, Dec 7, 1:32 PM
Niedzielski committed rMARV2ca241b47aa6: Chore: replace fetch header type assertion (authored by Niedzielski).
Chore: replace fetch header type assertion
Thu, Dec 7, 1:28 PM
Niedzielski committed rMARVa7cbd40df459: Chore: remove AnyRoute (authored by Niedzielski).
Chore: remove AnyRoute
Thu, Dec 7, 1:28 PM
joakin <joaquin@chimeces.com> committed rMARV3380caaba65e: Fix: return not found wiki pages as 404s (authored by Niedzielski).
Fix: return not found wiki pages as 404s
Thu, Dec 7, 1:05 PM
joakin <joaquin@chimeces.com> committed rMARV9a86611ffba9: Chore: remove AnyRoute (authored by Niedzielski).
Chore: remove AnyRoute
Thu, Dec 7, 1:05 PM
joakin <joaquin@chimeces.com> committed rMARV9ef1fc11e963: Fix: gracefully handle redirects to external sites (authored by Niedzielski).
Fix: gracefully handle redirects to external sites
Thu, Dec 7, 1:05 PM
joakin <joaquin@chimeces.com> committed rMARVc6aac45e6f34: Chore: replace fetch header type assertion (authored by Niedzielski).
Chore: replace fetch header type assertion
Thu, Dec 7, 1:05 PM

Wed, Dec 6

Niedzielski updated subscribers of T177865: Blog about the Wikimedia Page Library.

Oh and here's the blog. Thanks for all the improvements and reviews @MelodyKramer, @Jdlrobson, @phuedx, @Fjalapeno, and @EdErhart-WMF!

Wed, Dec 6, 8:52 PM · wikimedia-page-library, Wikimedia-Blog-Content
Niedzielski closed T177865: Blog about the Wikimedia Page Library as Resolved.

Published!

Wed, Dec 6, 8:47 PM · wikimedia-page-library, Wikimedia-Blog-Content
Niedzielski updated the task description for T177865: Blog about the Wikimedia Page Library.
Wed, Dec 6, 8:46 PM · wikimedia-page-library, Wikimedia-Blog-Content
Niedzielski committed rMARVae78245b47ab: Fix: show original server errors (authored by Niedzielski).
Fix: show original server errors
Wed, Dec 6, 8:28 PM
Niedzielski committed rMARV87e8e3429803: Fix: force File page images to wrap (authored by Niedzielski).
Fix: force File page images to wrap
Wed, Dec 6, 8:24 PM
Niedzielski committed rMARV6f2da10b5e22: Fix: return not found wiki pages as 404s (authored by Niedzielski).
Fix: return not found wiki pages as 404s
Wed, Dec 6, 8:24 PM
Niedzielski committed rMARVbdcb037faa00: Chore: replace fetch header type assertion (authored by Niedzielski).
Chore: replace fetch header type assertion
Wed, Dec 6, 8:24 PM
Niedzielski committed rMARVe6f3ae572007: Chore: remove AnyRoute (authored by Niedzielski).
Chore: remove AnyRoute
Wed, Dec 6, 8:24 PM
Niedzielski committed rMARV805ff7bc344a: Fix: gracefully handle redirects to external sites (authored by Niedzielski).
Fix: gracefully handle redirects to external sites
Wed, Dec 6, 7:55 PM
Niedzielski committed rMARVbe1f6f3000c1: Chore: update router test style to return Promises (authored by Niedzielski).
Chore: update router test style to return Promises
Wed, Dec 6, 7:31 PM
Niedzielski committed rMARVb0687f010b49: Chore: add type checking to error and 404 page props (authored by Niedzielski).
Chore: add type checking to error and 404 page props
Wed, Dec 6, 7:31 PM
Niedzielski committed rMARV648202d0b657: Chore: rename PageResolver (authored by Niedzielski).
Chore: rename PageResolver
Wed, Dec 6, 7:31 PM
Niedzielski committed rMARV9f948324548b: Chore: add fetch wrapper tests (authored by Niedzielski).
Chore: add fetch wrapper tests
Wed, Dec 6, 7:31 PM
Niedzielski committed rMARV2128c6d665de: Chore: add type checking to error and 404 page props (authored by Niedzielski).
Chore: add type checking to error and 404 page props
Wed, Dec 6, 7:24 PM
Niedzielski committed rMARV8e5841964b58: Chore: update router test style to return Promises (authored by Niedzielski).
Chore: update router test style to return Promises
Wed, Dec 6, 7:24 PM
Niedzielski committed rMARV19a639d1516c: Chore: rename PageResolver (authored by Niedzielski).
Chore: rename PageResolver
Wed, Dec 6, 7:24 PM
Niedzielski committed rMARVdd82285a05e0: Chore: remove isomorphic unfetch extras (authored by Niedzielski).
Chore: remove isomorphic unfetch extras
Wed, Dec 6, 7:24 PM
Niedzielski committed rMARV441cad1115f4: Chore: add fetch wrapper tests (authored by Niedzielski).
Chore: add fetch wrapper tests
Wed, Dec 6, 7:24 PM
Niedzielski committed rMARV83ea2fbb013f: Chore: rename PageResolver (authored by Niedzielski).
Chore: rename PageResolver
Wed, Dec 6, 7:10 PM
Niedzielski committed rMARVb847779302b3: Chore: add fetch wrapper tests (authored by Niedzielski).
Chore: add fetch wrapper tests
Wed, Dec 6, 6:48 PM
Niedzielski updated the task description for T169807: Replace settings checkboxes to ToggleSwitches.
Wed, Dec 6, 5:29 PM · Readers-Web-Kanban-Board, Patch-For-Review, Readers-Web-Backlog
Niedzielski updated the task description for T182202: MinervaNeue browser tests are failing on talk topics and watchstar.
Wed, Dec 6, 4:14 PM · User-zeljkofilipin, Patch-For-Review, User-Jdlrobson, Browser-Tests, Readers-Web-Backlog
Niedzielski created T182202: MinervaNeue browser tests are failing on talk topics and watchstar.
Wed, Dec 6, 4:14 PM · User-zeljkofilipin, Patch-For-Review, User-Jdlrobson, Browser-Tests, Readers-Web-Backlog
Niedzielski moved T182200: Anonymous 3G speed indices fluctuating by 2000 on the en.wiki Barack Obama article starting on November 30th, 17:00 from To Triage to Tracking on the Readers-Web-Backlog board.
Wed, Dec 6, 3:59 PM · Readers-Web-Backlog (Tracking), Performance-Team, Regression, Performance
Niedzielski created T182200: Anonymous 3G speed indices fluctuating by 2000 on the en.wiki Barack Obama article starting on November 30th, 17:00.
Wed, Dec 6, 3:59 PM · Readers-Web-Backlog (Tracking), Performance-Team, Regression, Performance
Niedzielski added a project to T169162: [Epic] Improve special page template: Epic.
Wed, Dec 6, 3:48 PM · Mobile-Web-Settings, Epic, Design (RW-Design-Debt), Readers-Web-Backlog
Niedzielski added a comment to T169257: Promote expand all sections feature from beta.

Does this deploy to all wikis? Do we need any extra logging? Will this trigger existing expand / collapse logging for all sections on a page?

Wed, Dec 6, 3:46 PM · Patch-For-Review, Mobile-Web-Settings, Readers-Web-Backlog
Niedzielski added a project to T182197: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to?: Spike.
Wed, Dec 6, 3:31 PM · Proton, Spike, Readers-Web-Backlog
Niedzielski removed a project from T182059: Tapping on Download icon has no response in older versions of the Chrome browser including Samsung "Internet" browser.: Mobile.
Wed, Dec 6, 3:29 PM · User-Jdlrobson, Proton, Readers-Web-Backlog
Niedzielski removed a project from T182197: [Spike 4hrs] Is there a way to detect the which browsers the download button is being delivered to?: Mobile.

I've removed the Mobile tag form this task per https://www.mediawiki.org/wiki/Reading/Web/Chore_list#Review_#mobile.

Wed, Dec 6, 3:29 PM · Proton, Spike, Readers-Web-Backlog
Niedzielski moved T180838: Link preview does not show full text extract when lead sentence contains abbreviations (text extract cuts off at the first abbrevation) from To Triage to Tracking on the Readers-Web-Backlog board.
Wed, Dec 6, 3:25 PM · Readers-Web-Backlog (Tracking), TextExtracts, Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, Wikipedia-Android-App-Backlog
Niedzielski added a project to T180838: Link preview does not show full text extract when lead sentence contains abbreviations (text extract cuts off at the first abbrevation): Readers-Web-Backlog.
Wed, Dec 6, 3:25 PM · Readers-Web-Backlog (Tracking), TextExtracts, Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, Wikipedia-Android-App-Backlog
Niedzielski edited projects for T180838: Link preview does not show full text extract when lead sentence contains abbreviations (text extract cuts off at the first abbrevation), added: Mobile-Content-Service, TextExtracts; removed Page-Previews.

I've updated the tags on this task. AFAIK Android is using the page summary endpoint which I think calls TextExtracts.

Wed, Dec 6, 3:23 PM · Readers-Web-Backlog (Tracking), TextExtracts, Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, Wikipedia-Android-App-Backlog

Tue, Dec 5

Niedzielski committed rMARV3382dad22042: Chore: add type checking to error and 404 page props (authored by Niedzielski).
Chore: add type checking to error and 404 page props
Tue, Dec 5, 10:39 PM
Niedzielski committed rMARV99965ac436a6: Chore: update router test style to return Promises (authored by Niedzielski).
Chore: update router test style to return Promises
Tue, Dec 5, 10:39 PM
Niedzielski committed rMARVdbea21daceb5: Chore: add type checking to error and 404 page props (authored by Niedzielski).
Chore: add type checking to error and 404 page props
Tue, Dec 5, 10:39 PM
Niedzielski committed rMARV4c329cc5d205: Chore: update router test style to return Promises (authored by Niedzielski).
Chore: update router test style to return Promises
Tue, Dec 5, 10:39 PM
Niedzielski committed rMARV098ddbf57cf6: Fix: return not found wiki pages as 404s (authored by Niedzielski).
Fix: return not found wiki pages as 404s
Tue, Dec 5, 10:36 PM
Niedzielski committed rMARV23052ad030b6: Chore: replace fetch header type assertion (authored by Niedzielski).
Chore: replace fetch header type assertion
Tue, Dec 5, 10:36 PM
Niedzielski committed rMARV46b9a5c2f014: Chore: remove AnyRoute (authored by Niedzielski).
Chore: remove AnyRoute
Tue, Dec 5, 10:36 PM
Niedzielski committed rMARVd83c8068aa46: Fix: force File page images to wrap (authored by Niedzielski).
Fix: force File page images to wrap
Tue, Dec 5, 10:36 PM
Niedzielski committed rMARVc1b21aa6b891: Fix: gracefully handle redirects to external sites (authored by Niedzielski).
Fix: gracefully handle redirects to external sites
Tue, Dec 5, 10:36 PM
Niedzielski committed rMARV3da812f23237: Chore: add fetch wrapper tests (authored by Niedzielski).
Chore: add fetch wrapper tests
Tue, Dec 5, 10:36 PM
Niedzielski committed rMARVc25ccbc00a9a: Chore: add fetch wrapper tests (authored by Niedzielski).
Chore: add fetch wrapper tests
Tue, Dec 5, 10:36 PM
Niedzielski committed rMARVe6bfaa91db5b: Chore: remove isomorphic unfetch extras (authored by Niedzielski).
Chore: remove isomorphic unfetch extras
Tue, Dec 5, 10:36 PM
Niedzielski committed rMARV31a844810f6c: Update: handle redirects manually on the client too (authored by Niedzielski).
Update: handle redirects manually on the client too
Tue, Dec 5, 5:04 PM
Niedzielski committed rMARV7e63a065faeb: Chore: replace fetch header type assertion (authored by Niedzielski).
Chore: replace fetch header type assertion
Tue, Dec 5, 5:04 PM
Niedzielski moved T182120: Redirected pages should alert the user from Needs Triage to Backlog (Priority Descending) on the Marvin board.
Tue, Dec 5, 4:34 PM · Marvin
Niedzielski placed T182120: Redirected pages should alert the user up for grabs.
Tue, Dec 5, 4:34 PM · Marvin
Niedzielski closed T181702: Logo is blurry as Resolved.

@Nirzar, sorry, I'm not sure but I'm glad it's fixed.

Tue, Dec 5, 4:34 PM · Patch-For-Review, Marvin
Niedzielski removed a project from T181900: Visiting a missing page causes a server error: Patch-For-Review.
Tue, Dec 5, 4:32 PM · Patch-For-Review, Marvin
Niedzielski moved T182103: 404 responses do not specify CORS headers from Needs Triage to Backlog (Priority Descending) on the Marvin board.
Tue, Dec 5, 4:32 PM · RESTBase-API, Services (done), Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, RESTBase, Marvin
Niedzielski added a comment to T177681: Page URL should update on redirect.

This should also include a "redirected from" notice, cf. https://en.m.wikipedia.org/wiki/Einstein and T53736#3382857 .

@Tbayer, thanks! Now tracked in T182120.

Tue, Dec 5, 4:22 PM · Patch-For-Review, Marvin
Niedzielski updated the task description for T182120: Redirected pages should alert the user.
Tue, Dec 5, 4:16 PM · Marvin
Niedzielski created T182120: Redirected pages should alert the user.
Tue, Dec 5, 4:14 PM · Marvin
Niedzielski committed rMARVa69295725195: Fix: show original server errors (authored by Niedzielski).
Fix: show original server errors
Tue, Dec 5, 3:19 PM
Niedzielski changed the status of T181900: Visiting a missing page causes a server error from Open to Stalled.

The server case is working but client re-render must be disabled to see it: https://gerrit.wikimedia.org/r/#/c/395039/.

Tue, Dec 5, 3:19 PM · Patch-For-Review, Marvin
Niedzielski created T182103: 404 responses do not specify CORS headers.
Tue, Dec 5, 3:14 PM · RESTBase-API, Services (done), Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, RESTBase, Marvin
Niedzielski committed rMARV36fd89fe6cc9: Chore: remove AnyRoute (authored by Niedzielski).
Chore: remove AnyRoute
Tue, Dec 5, 1:50 AM

Mon, Dec 4

Niedzielski committed rMARV163c398fb5d8: Chore: use function keyword in client and server (authored by Niedzielski).
Chore: use function keyword in client and server
Mon, Dec 4, 5:06 PM
Niedzielski committed rMARVdd2cda9b8bb1: Fix: show original server errors (authored by Niedzielski).
Fix: show original server errors
Mon, Dec 4, 5:06 PM
Niedzielski claimed T181900: Visiting a missing page causes a server error.
Mon, Dec 4, 3:41 PM · Patch-For-Review, Marvin
Niedzielski committed rMARV68f6375a45eb: Fix: force File page images to wrap (authored by Niedzielski).
Fix: force File page images to wrap
Mon, Dec 4, 1:57 PM