Page MenuHomePhabricator

Niedzielski (Stephen Niedzielski)
Programmer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2015, 9:18 PM (253 w, 5 d)
Availability
Available
IRC Nick
niedzielski
LDAP User
Unknown
MediaWiki User
Niedzielski [ Global Accounts ]

Recent Activity

Fri, Feb 21

Niedzielski updated subscribers of T242381: Add a Vector skin version preference.

Ok, we have a workaround for T245793 (thanks @Mooeypoo!). New issue: there's a race scenario with Popups to insert the new skin preferences section directly underneath skin choice section. I can't think of a way to handle this scenario in the current architecture except:

Fri, Feb 21, 12:45 AM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Thu, Feb 20

Niedzielski created T245793: [Firefox 73] Infusing a RadioOptionWidget changes first-child alignment.
Thu, Feb 20, 11:52 PM · Browser-Support-Firefox, OOUI, Desktop Improvements
Niedzielski added a comment to T242381: Add a Vector skin version preference.

As I was staging this change for review, I uncovered a radio alignment regression affecting wide-screen Firefox JavaScript users only. The issue is reproducible on the stock Special:Preferences page by simply infusing the skin section. E.g., OO.ui.infuse( $( '#mw-input-wpskin' ) ):

Thu, Feb 20, 10:37 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski claimed T242381: Add a Vector skin version preference.
Thu, Feb 20, 10:27 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski moved T242381: Add a Vector skin version preference from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Thu, Feb 20, 10:27 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Wed, Feb 19

Niedzielski updated the task description for T239262: Type check JavaScript documentation.
Wed, Feb 19, 6:33 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Vector, Technical-Debt
Niedzielski updated the task description for T239262: Type check JavaScript documentation.
Wed, Feb 19, 6:26 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Vector, Technical-Debt
Niedzielski set the point value for T244481: Provide basic FeatureManagement in Vector codebase to 8.

Estimated asynchronously at an extra-large.

Wed, Feb 19, 4:02 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Vector, Desktop Improvements
Niedzielski placed T242779: Add Vector and Popups PHP documentation to doc.wikimedia.org up for grabs.

Removing Olga as assignee. I think the carryover was just a clerical error.

Wed, Feb 19, 3:07 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Documentation, Page-Previews, Desktop Improvements, Technical-Debt

Tue, Feb 18

Niedzielski placed T242381: Add a Vector skin version preference up for grabs.
Tue, Feb 18, 11:44 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski moved T242381: Add a Vector skin version preference from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Tue, Feb 18, 11:44 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski claimed T242381: Add a Vector skin version preference.
Tue, Feb 18, 5:47 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski moved T242381: Add a Vector skin version preference from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Tue, Feb 18, 5:47 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski awarded T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases a 100 token.
Tue, Feb 18, 3:33 PM · Patch-For-Review, Epic, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MobileFrontend, Documentation
Niedzielski closed T239258: Migrate JavaScript API documentation from jsduck to JSDoc, a subtask of T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases, as Resolved.
Tue, Feb 18, 3:32 PM · Patch-For-Review, Epic, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MobileFrontend, Documentation
Niedzielski closed T239258: Migrate JavaScript API documentation from jsduck to JSDoc, a subtask of T239262: Type check JavaScript documentation, as Resolved.
Tue, Feb 18, 3:32 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Vector, Technical-Debt
Niedzielski closed T239258: Migrate JavaScript API documentation from jsduck to JSDoc as Resolved.
Tue, Feb 18, 3:32 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Vector, Technical-Debt
Niedzielski updated the task description for T239258: Migrate JavaScript API documentation from jsduck to JSDoc.
Tue, Feb 18, 3:32 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Vector, Technical-Debt
Niedzielski updated subscribers of T239262: Type check JavaScript documentation.

o/ @ovasileva, this task is ready for estimation and timely given @nray's T239258 work.

Tue, Feb 18, 2:19 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Vector, Technical-Debt

Sat, Feb 15

Niedzielski placed T234258: Delete readers-web-stephen.reading-webstaging.eqiad.wmflabs and marvin-staging.reading-webstaging.eqiad.wmflabs? up for grabs.
Sat, Feb 15, 4:18 AM · Readers-Web-Backlog (Tracking)
Niedzielski closed T183333: Black theme doesn't render Chess template properly as Resolved.

PR is merged so I hope this task is done.

Sat, Feb 15, 4:17 AM · wikimedia-page-library, Wikipedia-Android-App-Backlog
Niedzielski closed T188096: Infobox subsections are rendered as separate infoboxes on https://fr.m.wikipedia.org/wiki/Burkina_Faso as Resolved.

PR is merged so I hope this task is done.

Sat, Feb 15, 4:16 AM · wikimedia-page-library, Wikipedia-Android-App-Backlog
Niedzielski updated Niedzielski.
Sat, Feb 15, 4:13 AM

Fri, Feb 14

Niedzielski reassigned T242381: Add a Vector skin version preference from Niedzielski to phuedx.
Fri, Feb 14, 11:19 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski moved T242381: Add a Vector skin version preference from Doing to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Fri, Feb 14, 11:19 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski added a comment to T242381: Add a Vector skin version preference.

@phuedx, I've left a comment for you in code review regarding preference conversion. This still "needs work" but is pending your feedback so I'm moving over to code review and assigning to you temporarily

Fri, Feb 14, 11:19 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski added a comment to T242381: Add a Vector skin version preference.

Thank you, @phuedx!

Fri, Feb 14, 6:10 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski updated the task description for T244481: Provide basic FeatureManagement in Vector codebase.
Fri, Feb 14, 6:08 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Vector, Desktop Improvements
Niedzielski updated the task description for T244481: Provide basic FeatureManagement in Vector codebase.
Fri, Feb 14, 6:07 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Vector, Desktop Improvements

Thu, Feb 13

Niedzielski added a comment to T242381: Add a Vector skin version preference.

Config patch is up. I've submitted a revision of the hooks patch that adds tests for the different branches.

Thu, Feb 13, 11:26 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski updated subscribers of T245162: Job unable to create file page "Fatal: Call function inNamespace() on null" (via MinervaHooks).

@matmarex, sorry if this doesn't make sense but do you think there's a chance https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/541597/ could be contributing to this issue?

Thu, Feb 13, 4:13 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Structured Data Engineering, Structured-Data-Backlog, MinervaNeue, Wikimedia-production-error
Niedzielski created T245160: [Bug] Many MobileFormatter lead paragraph transform alerts starting on Feb 11, 2020.
Thu, Feb 13, 3:30 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), MobileFrontend

Wed, Feb 12

Niedzielski added a comment to T243281: Build opt-out button for logged-in users with new vector on.

This needs discussion on approach with @Jdlrobson and the other devs.

Wed, Feb 12, 5:16 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski closed T239269: [SPIKE 16hrs] Add coding convention for new commits to Vector as Resolved.
Wed, Feb 12, 3:48 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Spike, Vector, Technical-Debt

Tue, Feb 11

Niedzielski added a comment to T243281: Build opt-out button for logged-in users with new vector on.

@phuedx, we add the link to the sidebar via MediaWiki:Sidebar on each test wiki, correct? Is it ok that that this is modern Vector-only link? The mocks say that clicking the button just takes to the appropriate Special:Preferences section so I don't think we need anything extra like JavaScript, right?

Clarified in the meeting that JavaScript isn't necessary so option 3 is MediaWiki:Sidebar + hooks only.

Tue, Feb 11, 6:34 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski claimed T239269: [SPIKE 16hrs] Add coding convention for new commits to Vector.
Tue, Feb 11, 6:04 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Spike, Vector, Technical-Debt
Niedzielski added a comment to T243281: Build opt-out button for logged-in users with new vector on.

3
Adding a link to Special:Preferences#mw-prefsection-rendering in PHP. Use JS to trap the user clicking the link and use the MediaWiki API to opt them in/out.

@phuedx, we add the link to the sidebar via MediaWiki:Sidebar on each test wiki, correct? Is it ok that that this is modern Vector-only link? The mocks say that clicking the button just takes to the appropriate Special:Preferences section so I don't think we need anything extra like JavaScript, right?

Tue, Feb 11, 3:00 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski added a comment to T243924: Requesting access to deployment for niedzielski.

Thank you @jijiki, @MarkTraceur, @thcipriani!

Tue, Feb 11, 3:50 AM · Operations, SRE-Access-Requests

Sun, Feb 9

Niedzielski updated the task description for T244408: Consolidate source code licenses to single line per file.
Sun, Feb 9, 5:17 PM · User-RhinosF1, Software-Licensing, WMF-Legal, Technical-Debt, Desktop Improvements
Niedzielski renamed T244408: Consolidate source code licenses to single line per file from Consolidate source code license in repository root to Consolidate source code licenses to single line per file.
Sun, Feb 9, 3:33 AM · User-RhinosF1, Software-Licensing, WMF-Legal, Technical-Debt, Desktop Improvements

Fri, Feb 7

Niedzielski awarded T243925: Grant +2 gerrit rights for @polishdeveloper a Love token.
Fri, Feb 7, 11:35 PM · MediaWiki-Gerrit-Group-Requests, Gerrit-Privilege-Requests
Niedzielski added a comment to T244481: Provide basic FeatureManagement in Vector codebase.

@polishdeveloper, looks good! Just reframing the above into concepts to make sure I got it:

Fri, Feb 7, 6:46 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Vector, Desktop Improvements

Thu, Feb 6

Niedzielski added a comment to T242381: Add a Vector skin version preference.

I've added some skin preferences section display logic to Core as hide-if only works for field elements not sections.

Thu, Feb 6, 10:28 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski added a comment to T244408: Consolidate source code licenses to single line per file.

@Anomie, that seems to be the approach taken by all (?) of Wikibase.

Thu, Feb 6, 3:28 PM · User-RhinosF1, Software-Licensing, WMF-Legal, Technical-Debt, Desktop Improvements
Niedzielski added a comment to T244439: Re-evaluate (and disable) whitespace and newline removal in MobileFrontend/MinervaNeue.

Can we generate SVGs as a build product like we do in Popups? This allows for developers to have a development friendly version that is built by automation into the shipped user version.

Thu, Feb 6, 2:30 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Wed, Feb 5

Demian awarded T244408: Consolidate source code licenses to single line per file a Like token.
Wed, Feb 5, 9:32 PM · User-RhinosF1, Software-Licensing, WMF-Legal, Technical-Debt, Desktop Improvements
Niedzielski created T244408: Consolidate source code licenses to single line per file.
Wed, Feb 5, 9:03 PM · User-RhinosF1, Software-Licensing, WMF-Legal, Technical-Debt, Desktop Improvements
Demian awarded T244392: [Epic] Deploy the new search experience a Love token.
Wed, Feb 5, 6:59 PM · Epic, Desktop Improvements
Niedzielski added a parent task for T244287: Build the search component network client: T244392: [Epic] Deploy the new search experience.
Wed, Feb 5, 6:56 PM · Desktop Improvements, Readers-Web-Backlog
Niedzielski added a subtask for T244392: [Epic] Deploy the new search experience: T244287: Build the search component network client.
Wed, Feb 5, 6:56 PM · Epic, Desktop Improvements
Niedzielski created T244392: [Epic] Deploy the new search experience.
Wed, Feb 5, 6:56 PM · Epic, Desktop Improvements
Niedzielski moved T232140: Separate out logo handling into square image logos and long text/wordmark banner logos from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Wed, Feb 5, 6:14 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), ContentTranslation, Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements, Patch-For-Review, Logos, MediaWiki-Interface
Niedzielski renamed T244262: [Epic] Enable page previews and reference previews as a beta feature on all projects from [Deploy] Enable page previews and reference previews as a beta feature on all projects to [Epic] Enable page previews and reference previews as a beta feature on all projects.
Wed, Feb 5, 2:54 PM · Epic, Page-Previews, Readers-Web-Backlog

Tue, Feb 4

Niedzielski created T244287: Build the search component network client.
Tue, Feb 4, 8:58 PM · Desktop Improvements, Readers-Web-Backlog
Niedzielski created T244276: Add gzipped minified bundle size test to Vector.
Tue, Feb 4, 7:12 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Vector, Desktop Improvements, Technical-Debt
Niedzielski assigned T244262: [Epic] Enable page previews and reference previews as a beta feature on all projects to ovasileva.
Tue, Feb 4, 6:54 PM · Epic, Page-Previews, Readers-Web-Backlog
Niedzielski moved T244261: Report unhandled jQuery $.Deferred errors in client side error logging from Incoming to Tracking on the Readers-Web-Backlog board.
Tue, Feb 4, 6:53 PM · Readers-Web-Backlog (Tracking)
Niedzielski closed T240062: Extract components from VectorTemplate to Mustache files, a subtask of T239248: [EPIC] Divide VectorTemplate into components, as Resolved.
Tue, Feb 4, 6:52 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Epic, Technical-Debt, Desktop Improvements, Vector
Niedzielski closed T240062: Extract components from VectorTemplate to Mustache files as Resolved.
Tue, Feb 4, 6:52 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, Desktop Improvements, Vector
Niedzielski claimed T240062: Extract components from VectorTemplate to Mustache files.
Tue, Feb 4, 6:08 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, Desktop Improvements, Vector
Niedzielski created T244262: [Epic] Enable page previews and reference previews as a beta feature on all projects.
Tue, Feb 4, 5:49 PM · Epic, Page-Previews, Readers-Web-Backlog
Niedzielski awarded T111329: [GOAL] Page previews on mobileweb a Love token.
Tue, Feb 4, 5:39 PM · Readers-Web-Backlog (Needs Product Owner Decisions), Reading Epics (Page Previews), Goal, Page-Previews
Niedzielski added a comment to T244261: Report unhandled jQuery $.Deferred errors in client side error logging.

@Tgr, let me know if this doesn't make sense and feel free to edit!

Tue, Feb 4, 5:32 PM · Readers-Web-Backlog (Tracking)
Niedzielski created T244261: Report unhandled jQuery $.Deferred errors in client side error logging.
Tue, Feb 4, 5:32 PM · Readers-Web-Backlog (Tracking)
Niedzielski closed T239248: [EPIC] Divide VectorTemplate into components, a subtask of T217172: Vector should replace rendering from PHP with Mustache, as Resolved.
Tue, Feb 4, 3:29 PM · Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Performance-Team (Radar), Patch-For-Review, Vector
Niedzielski closed T239248: [EPIC] Divide VectorTemplate into components, a subtask of T240856: [EPIC] New header for desktop improvements project, as Resolved.
Tue, Feb 4, 3:29 PM · Performance-Team (Radar), Desktop Improvements, Epic
Niedzielski closed T239248: [EPIC] Divide VectorTemplate into components as Resolved.

@Jdlrobson, this work was tougher than I anticipated but @Jdrewniak has done well. I think the outcome is very good and practical.

Tue, Feb 4, 3:29 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Epic, Technical-Debt, Desktop Improvements, Vector
Niedzielski updated the task description for T239248: [EPIC] Divide VectorTemplate into components.
Tue, Feb 4, 3:26 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Epic, Technical-Debt, Desktop Improvements, Vector

Mon, Feb 3

Niedzielski added a comment to Blog Post: Why does building a skin require PHP knowledge?.

In my opinion this was the skin's right.

I think it could be valuable to separate the ideas of application entry points and UI appearance-only changes. (I'm not sure if it makes sense in MediaWiki for the latter to include content styling too.)

Mon, Feb 3, 3:24 PM · MediaWiki-Interface
Niedzielski updated the task description for T243924: Requesting access to deployment for niedzielski.
Mon, Feb 3, 2:05 PM · Operations, SRE-Access-Requests

Wed, Jan 29

Niedzielski created T243924: Requesting access to deployment for niedzielski.
Wed, Jan 29, 9:40 PM · Operations, SRE-Access-Requests

Tue, Jan 28

Niedzielski added a comment to T242381: Add a Vector skin version preference.

^Neat! It doesn't look like this preference even displays unless the skin preference has been saved!

Tue, Jan 28, 5:16 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Jan 24 2020

Niedzielski added a comment to T236176: [EPIC] Build opt-in/opt-out mechanism for desktop improvements project.

@AronManning, I think a good place to start would be FeaturesManager.php in MobileFrontend and the contents of the features subdirectory. An example mode implementation would be the AMC UserMode (this class represents advanced mode on mobile--the name is a relic from when it was called Advanced Mobile Contributions) and an example feature would be the standard and advanced menus. More details in T242835.

Jan 24 2020, 9:21 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski added a project to T243263: Popups should not use github.com for documentation generation: Readers-Web-Backlog.

I think we can use something like https://phabricator.wikimedia.org/source/mediawiki/browse/master/resources/src/mediawiki.less/mediawiki.mixins.less?view=raw (unless you know a better URL). Related discussion in Vector.

Jan 24 2020, 3:21 PM · Release-Engineering-Team, Readers-Web-Backlog, Page-Previews
Niedzielski moved T191156: Convert FlaggedRevisions to OOUI from Needs triage to MinervaNeue on the Mobile board.
Jan 24 2020, 3:18 PM · MinervaNeue (Tracking), Mobile, Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, UI-Standardization
Niedzielski added a comment to T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown.

@AnneT, eek, I'm not seeing that load either! I do see MenuOptionWidget.

Jan 24 2020, 2:56 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured-Data-Backlog (Current Work), Wikidata, SDC-Statements, SDC General
Demian awarded T218410: Ship unminified sources when ResourceLoader's debug mode is enabled a Love token.
Jan 24 2020, 5:44 AM · Patch-For-Review, Page-Previews, Technical-Debt, Readers-Web-Backlog
Niedzielski added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

Hey @Jhernandez! Point taken but of course the integration won't be perfect or frictionless initially. As I understand it, FAWG and Web will be iterating on the initial solution well beyond this RFC so there will be opportunity to uncover integration complexities (such as the ones you noted) that would arise from any choice and I'll be bold enough to say that I'm probably more optimistic than you that we'll figure them out :]

Jan 24 2020, 12:25 AM · Security-Team, TechCom-RFC

Jan 23 2020

Niedzielski added a comment to T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown.

I can repro the issue in the Chromium device emulator on Vector per the description:

Jan 23 2020, 8:46 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Structured-Data-Backlog (Current Work), Wikidata, SDC-Statements, SDC General
Niedzielski reassigned T240062: Extract components from VectorTemplate to Mustache files from pmiazga to Jdlrobson.
Jan 23 2020, 6:08 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, Desktop Improvements, Vector
Niedzielski moved T240062: Extract components from VectorTemplate to Mustache files from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jan 23 2020, 6:08 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Technical-Debt, Desktop Improvements, Vector
Niedzielski added a comment to T242381: Add a Vector skin version preference.

Hello @AronManning! (Sorry for the slightly redundant reply.)

Jan 23 2020, 4:47 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski added a comment to T236176: [EPIC] Build opt-in/opt-out mechanism for desktop improvements project.

Hi @AronManning! Per the outcome of T234907, development is already underway in Vector itself. My understanding is that this approach will allow us to minimize development costs. The existing experience (now called "legacy") will be carefully preserved via a user preference (the subject of this task) and feature manager.

Jan 23 2020, 4:15 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Jan 22 2020

Niedzielski closed T242469: Upgrade Vector skin.json schema to v2, a subtask of T242503: Upgrade skins skin.json schema to manifest_version 2, as Resolved.
Jan 22 2020, 11:36 PM · Other-skins
Niedzielski closed T242469: Upgrade Vector skin.json schema to v2 as Resolved.

I was thinking that the same changes could be made to at least Minerva which it looks like you did. Thank you!

Jan 22 2020, 11:36 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Technical-Debt, Desktop Improvements, Readers-Web-Backlog

Jan 16 2020

Niedzielski moved T242931: Improve mobile experience on Wikitech from Needs triage to MobileFrontend specific on the Mobile board.
Jan 16 2020, 3:19 PM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Mobile, wikitech.wikimedia.org, cloud-services-team
Niedzielski added a project to T242931: Improve mobile experience on Wikitech: MobileFrontend.
Jan 16 2020, 3:19 PM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Mobile, wikitech.wikimedia.org, cloud-services-team
Niedzielski created T242979: [Bug] Uncaught Error: Class 'LCRun3'.
Jan 16 2020, 3:15 PM · MinervaNeue (Tracking), Readers-Web-Backlog (Tracking)

Jan 15 2020

Niedzielski added a comment to T236097: Dev: Popups modules should set targets to mobile and desktop.

T158181 sounds like a nice objective. For this task specifically, I like @Jdlrobson's generic hover proposal much better than what appears in the description.

Jan 15 2020, 6:44 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), User-Jdlrobson, Page-Previews, Performance-Team (Radar)
Niedzielski claimed T242381: Add a Vector skin version preference.
Jan 15 2020, 6:10 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski moved T242381: Add a Vector skin version preference from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q3) board.
Jan 15 2020, 6:10 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski added a project to T242784: Regression: Watchstar CTA fails to display properly 2nd and 3rd time: MobileFrontend.
Jan 15 2020, 3:47 PM · MobileFrontend, MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Readers-Web-Backlog (Kanbanana-2019-20-Q3)

Jan 14 2020

Niedzielski created T242781: Transition Vector Gruntfile.js tasks to NPM scripts.
Jan 14 2020, 7:05 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Vector, Technical-Debt
Niedzielski created T242779: Add Vector and Popups PHP documentation to doc.wikimedia.org.
Jan 14 2020, 6:52 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q3), Documentation, Page-Previews, Desktop Improvements, Technical-Debt
Niedzielski placed T214049: Technical: Every Drawer has a shield for catching clicks up for grabs.
Jan 14 2020, 6:07 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), MobileFrontend
Niedzielski created T242772: Remove unused configuration $wgVectorResponsive.
Jan 14 2020, 5:26 PM · Vector (Responsive-Vector), Desktop Improvements, Technical-Debt, Readers-Web-Backlog
Niedzielski committed rEQSb2659426f6be: Further reduce unnecessary conditional loading (authored by phuedx).
Further reduce unnecessary conditional loading
Jan 14 2020, 5:19 PM

Jan 13 2020

Niedzielski updated subscribers of T242381: Add a Vector skin version preference.

I discussed this task with @pmiazga, mostly about how it relates to T237635, and the configuration changes and the approach proposed. We think this work will be pretty loosely coupled from the feature manager but it would be nice to deliver legacy and v2 "modes" in the initial (Vector) feature manager patches whenever they come (Piotr is hoping for next week). No other concerns regarding approach but Piotr has some ideas about using the BetaFeatures extension, when available, in conjunction with the $wgVectorDefaultSkinVersion config to start more users on v2 that he'll be discussing with @ovasileva but that can be decided independently of this task.

Jan 13 2020, 9:30 PM · Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
Niedzielski added a comment to T214049: Technical: Every Drawer has a shield for catching clicks.

The shield should cover the whole article surface and be translucent (opacity: 0.6)

The opacity of the reference drawer shield appears to be .5. Is this correct @Jdlrobson, @Jdrewniak? Otherwise LGTM.

Jan 13 2020, 7:34 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), MobileFrontend
Niedzielski claimed T214049: Technical: Every Drawer has a shield for catching clicks.
Jan 13 2020, 6:05 PM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Patch-For-Review, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), MobileFrontend