Does T239418 depend on this task?

This appears to be a duplicate of T237552#5661368 which has been fixed by @matmarex but not yet deployed.

I think this issue is limited to anonymous users. I'm looking into it.

Assigned to @Jdrewniak to refine his CSS checkbox patch.

@ovasileva, I think this task and its parent are very important for any JavaScript work we do in Vector. I would rather not have to lookup jsduck syntax :] Would it be possible to get this into the kanbanana soon?

@Volker_E, for better and worse it's been my experience that the Web team is often pioneering new technologies, and coding patterns and techniques that occasionally percolate out to the broader Foundation's repositories. Having a universal coding convention (beyond linting) sounds appealing, but in practice, I think repositories are often focused on very different problems and conventions that seem like no-brainers in one place may be entirely impractical and be a negative force on development in another. Additionally, assigning a team all the responsibilities of maintaining and significantly extending a project but demanding that all coding conventions pass through the gatekeepers of the conventions for all repositories under the Foundation's purview is not empowering and leads to lazy contributions in my perspective. I would rather see the team fully embrace a convention that makes sense to them for a given project.

@Addshore, sorry I'm not very smart about this part of the codebase. I've executed docker exec -it boxwiki_mediawiki_1 php extensions/Wikibase/lib/maintenance/populateSitesTable.php and it reports done.. http://localhost:8181/wiki/Special:SiteMatrix is empty.

@ovasileva, I've merged @Ammarpad's nice patch. It looked low risk, was a solid improvement, and the patch was ready and waiting. As the patch is now merged, I'm moving this into the kanban board for testing by @Edtadros.

@TheDJ has recommend mediawiki.org as a test wiki candidate with the idea that it would 1) encourage developers to use the new Vector 2) regressions would have low impact to users but high visibility to devs.

Depending on the approach taken, this task may be a good candidate for initial FAWG integration (it's a form composed of components with minimal ties to MW and may appear as a modal).

@zeljkofilipin, thank you! This seems to be working for me now.

@bd808, deleted!

@alexhollender, is it important to represent this new setting as a suboption? E.g.:

Wow!! Good work everybody! Special shout out to @Edtadros for the great find and @Jdlrobson for the great investigation!

I've been away for awhile so please excuse this comment if it doesn't make sense, but did you consider a "--deleteLocalSettings" (or similar) flag? If the flag is set, the LocalSettings.php can be deleted and database reinitialized. If not, the informational message can be shown: A LocalSettings.php file has been detected. To upgrade this installation, please run update.php instead.

Adding to @ovasileva and @alexhollender's radar in case they're interested in this change.

marvin-staging.reading-web-staging.eqiad.wmflabs

This can be reclaimed AFAIK.

I like that we're tidying up the backlog but for this task in particular it seems a shame that it can't be reprioritized any time soon. Page previews have been very impactful on desktop and this task had over 80 subtasks, which all appear to be resolved now. Additionally, Popups now support references as an additional out of box functionality. I respect the priorities set by product but I wanted to mention that from my perspective as a developer and user, I think this feature could be worth doing sooner rather than later.

Thanks! I use readers-web-stephen to share and develop changes with the team so please keep it! AFAIK, marvin-staging and chromium-pdf can be dropped.

Replace the class names for the page actions icons with the new class

I ended up taking a no-JS approach. Let's see what folks think.

@alexhollender, sounds good. Updated QA (note: patch not yet merged).

This is currently using the "info" icon in wikimedia.ui. Change it to use "infoFilled" and check with Alex that the icon used matches the attachment. If it's not we'll need to update the icon in OOUI (out of scope for this task).
DO NOT put a new SVG icon into the Minerva repo.

@alexhollender, hm, since the toolbar is already grey maybe we need to use a translucent background. Something like:

@Jdlrobson via discussion:

@pmiazga, given your experience, I think you're in an ideal spot to review this change. I refactored some of the "loose" page permission checks into the MinervaPagePermissions implementation as it seemed quite appropriate. What I'm most unsure of is if any special work is needed when adding new permission actions (a special config in skin.json). (I'm not sure why this is configurable.) The distinction from the plain old "EDIT" action was needed as some parts of the code only care whether the page content model is editable and others care whether the active user can edit.

LGTM. Tested on https://en.m.wikipedia.beta.wmflabs.org/wiki/User:ShreyasMinocha/URL_Hyphenation_Demo?useskin=minerva on an emulated device.

@zeljkofilipin, I'm getting "Your trial period has ended. Upgrade now..." messages again :[ Can you take a look?

From @Jdrewniak: what happens if we just disable the RC filter ResourceLoader module?

Maybe we can start by only showing the labels at maximum width. Another option mentioned was show the labels below the icons so there's more room for wrapping.

Visit http://localhost:8181/wiki/Special:History/Foo?action=history on a mobile device.

@pmiazga and I are no longer able to reproduce this issue locally with or without the patch.

Ok, I think we want something like this then:

@Nirzar, please weigh in on Design's requirements when you can.

Back to @alexhollender.

@alexhollender, should we update the notification drawer shadow?

I've been poking around in the Echo extension which I haven't developed in previously. These are my recommendations for how to proceed with this task but I'm unsure if the changes are wanted or if we're the best team for them given component responsibilities:

Thanks @Lea_WMDE, @WMDE-Fisch, and @thiemowmde!