Niedzielski (sniedzielski)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2015, 9:18 PM (157 w, 2 d)
Availability
Available
IRC Nick
niedzielski
LDAP User
Unknown
MediaWiki User
Niedzielski

Recent Activity

Yesterday

Niedzielski added a comment to T191267: Blank or white background images look abruptly cut off in Page Previews.

@Jdrewniak what you have seems like the correct behavior to me. Of course, I'm not a designer. It might look even better if you always keep the width the same (and remove the x offset) regardless of the thumbnail dimensions so that the image can be centered. I tried using preserveAspectRatio on svg > image but couldn't quickly get it to behave like object-fit: cover for newer browsers.

Thu, Apr 19, 5:57 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Previews
Niedzielski closed T192454: Popups Cucumber tests fails quietly with "undefined step" as Resolved.

The issue is fixed although the infrastructure could still be improved to detect this problem in the future.

Thu, Apr 19, 3:46 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, Technical-Debt, Page-Previews, Readers-Web-Backlog

Wed, Apr 18

Niedzielski updated the task description for T191646: Refactor: Consolidate preview template outer container.
Wed, Apr 18, 6:56 PM · Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski added a comment to T191596: Regression: Module mobile.site.styles is not being loaded with mobile.site module.

@Jdlrobson, it looks like there's an open question in code review as to how to proceed. Should we split this task so that the original tracks the revert and the split tracks the proper fix?

Wed, Apr 18, 6:12 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Performance-Team (Radar), Readers-Web-Backlog, MediaWiki-ResourceLoader, Regression, MobileFrontend
Niedzielski added a comment to T191888: Change page previews configuration for opt-in accounts.

None of the developers who pointed this task have done this before but it looks like there's some examples available in the MediaWiki Code Search and GitHub search. We are concerned there may be hidden complexities so whoever implements this should review the examples and add Gergo to the patch for review to make sure we use the hook properly.

Wed, Apr 18, 6:10 PM · Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Previews
Niedzielski added a project to T191646: Refactor: Consolidate preview template outer container: Readers-Web-Kanbanana-Board.

@Niedzielski to add AC and QA points. Primary objective is to create a common popup container.

Wed, Apr 18, 5:46 PM · Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski added a comment to T191532: Mobile page issues - instrument page issues.

@Tbayer will revise the description. @Niedzielski will schedule a meeting to discuss technical approaches.

Wed, Apr 18, 5:27 PM · Readers-Web-Backlog, Page-Issue-Warnings
Niedzielski moved T190831: [Bug] Page preview portrait images should be flipped in right-to-left languages from Needs More Work to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Wed, Apr 18, 5:08 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, RTL, I18n, Page-Previews, Readers-Web-Backlog
Niedzielski updated the task description for T192454: Popups Cucumber tests fails quietly with "undefined step".
Wed, Apr 18, 1:52 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski created T192454: Popups Cucumber tests fails quietly with "undefined step".
Wed, Apr 18, 1:51 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski added a comment to T188913: "Obama" page on Beta Cluster often responds with 503.

Here's the latest report:

Wed, Apr 18, 1:15 PM · Operations, Beta-Cluster-Infrastructure

Tue, Apr 17

Niedzielski added a comment to T192091: 500ms increase in fully loaded desktop and mobile on 30th March 2018.

@Gilles and @Peter, thank you for the analysis and support!

Tue, Apr 17, 3:06 PM · Performance-Team (Radar), Readers-Web-Backlog (Tracking)
Niedzielski added a comment to T192313: [Bug] Page's watched watchstar focus is rotated.

@ovasileva this is only a visual issue. The functionality works fine; pages can be added or removed from the watchlist.

Tue, Apr 17, 1:11 PM · MobileFrontend, Readers-Web-Backlog

Mon, Apr 16

Niedzielski added a comment to T192287: [Bug] Beta cluster page summary endpoint sometimes reponds with 5xx.

I tried about 50 links and it seems to work. Thanks (and thanks for keeping a debugging record) @Mholloway!!

Mon, Apr 16, 10:19 PM · Services (done), Reading-Infrastructure-Team-Backlog (Kanban), Readers-Web-Backlog (Tracking), Operations, Beta-Cluster-Infrastructure, Mobile-Content-Service, Page-Previews
Niedzielski updated the task description for T192313: [Bug] Page's watched watchstar focus is rotated.
Mon, Apr 16, 8:12 PM · MobileFrontend, Readers-Web-Backlog
Niedzielski moved T192315: [Bug] Page's change language button focus padding is truncated from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Mon, Apr 16, 8:12 PM · MobileFrontend, Readers-Web-Backlog
Niedzielski updated the task description for T192315: [Bug] Page's change language button focus padding is truncated.
Mon, Apr 16, 8:12 PM · MobileFrontend, Readers-Web-Backlog
Niedzielski created T192315: [Bug] Page's change language button focus padding is truncated.
Mon, Apr 16, 8:10 PM · MobileFrontend, Readers-Web-Backlog
Niedzielski moved T192313: [Bug] Page's watched watchstar focus is rotated from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Mon, Apr 16, 8:05 PM · MobileFrontend, Readers-Web-Backlog
Niedzielski created T192313: [Bug] Page's watched watchstar focus is rotated.
Mon, Apr 16, 8:05 PM · MobileFrontend, Readers-Web-Backlog
Niedzielski moved T192287: [Bug] Beta cluster page summary endpoint sometimes reponds with 5xx from To Triage to Tracking on the Readers-Web-Backlog board.
Mon, Apr 16, 7:59 PM · Services (done), Reading-Infrastructure-Team-Backlog (Kanban), Readers-Web-Backlog (Tracking), Operations, Beta-Cluster-Infrastructure, Mobile-Content-Service, Page-Previews
Niedzielski added a comment to T188913: "Obama" page on Beta Cluster often responds with 503.

Thanks @Mholloway. This task is specific to the Barack Obama page. The page summary issue is in T192287 and occurs on certain summary responses (all happened to be found on page previews linked from the Dog page).

Mon, Apr 16, 2:33 PM · Operations, Beta-Cluster-Infrastructure
Niedzielski updated subscribers of T188913: "Obama" page on Beta Cluster often responds with 503.

Could the summary endpoint issue be a network or caching problem related to this task? I was wondering because it seems like the Node.js service is issuing a request to 10.68.19.128 which fails with EHOSTUNREACH. I've opened T192287 to track this issue separately but please merge it back into this if I'm mistaken. /cc @bearND @Mholloway

Mon, Apr 16, 2:16 PM · Operations, Beta-Cluster-Infrastructure
Niedzielski created T192287: [Bug] Beta cluster page summary endpoint sometimes reponds with 5xx.
Mon, Apr 16, 2:12 PM · Services (done), Reading-Infrastructure-Team-Backlog (Kanban), Readers-Web-Backlog (Tracking), Operations, Beta-Cluster-Infrastructure, Mobile-Content-Service, Page-Previews
Niedzielski added a comment to T188913: "Obama" page on Beta Cluster often responds with 503.

I think this task is still being worked on but in case it helps, here's another report from the Obama page this morning:

Mon, Apr 16, 1:46 PM · Operations, Beta-Cluster-Infrastructure

Fri, Apr 13

Niedzielski added a comment to T187821: Choose a server for the chromium-render service.

Thanks so much @mobrovac!! Feel free to do whatever you want to the patches and let us know if help is needed. Thanks again!

Fri, Apr 13, 3:49 PM · Services (done), Readers-Web-Backlog, Proton, Operations
Niedzielski added a comment to T192091: 500ms increase in fully loaded desktop and mobile on 30th March 2018.

I think this graph of beta cluster and stable mobile fully loaded times is also alarming (and may be what @Jdlrobson intended to link to):

Fri, Apr 13, 1:19 PM · Performance-Team (Radar), Readers-Web-Backlog (Tracking)

Thu, Apr 12

Niedzielski claimed T191454: Watchlist missing logic is broken and hits the API multiple times unnecessarily on load.
Thu, Apr 12, 6:07 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog
Niedzielski moved T191454: Watchlist missing logic is broken and hits the API multiple times unnecessarily on load from To Do to Doing on the Readers-Web-Kanbanana-Board board.
Thu, Apr 12, 6:07 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog
Niedzielski awarded T188913: "Obama" page on Beta Cluster often responds with 503 a The World Burns token.
Thu, Apr 12, 5:11 PM · Operations, Beta-Cluster-Infrastructure
Niedzielski added a comment to T188913: "Obama" page on Beta Cluster often responds with 503.

This is still an issue:

Thu, Apr 12, 5:11 PM · Operations, Beta-Cluster-Infrastructure
Niedzielski added a project to T192094: [Bug] Languages shown in language picker on the main page not showing "title": MobileFrontend.
Thu, Apr 12, 4:45 PM · MobileFrontend, Readers-Web-Backlog
Niedzielski moved T192094: [Bug] Languages shown in language picker on the main page not showing "title" from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Thu, Apr 12, 4:44 PM · MobileFrontend, Readers-Web-Backlog
Niedzielski created T192094: [Bug] Languages shown in language picker on the main page not showing "title".
Thu, Apr 12, 4:44 PM · MobileFrontend, Readers-Web-Backlog
Niedzielski closed T189515: Evaluate Preact framework for use in Page previews as Declined.

Perhaps it's best to decline for now and we can open this later as needed.

Thu, Apr 12, 12:46 PM · Technical-Debt, Spike, Page-Previews, Readers-Web-Backlog
Niedzielski added a parent task for T191646: Refactor: Consolidate preview template outer container: T186129: Set up Extension:Popups to support multiple preview types.
Thu, Apr 12, 12:43 PM · Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski added a subtask for T186129: Set up Extension:Popups to support multiple preview types: T191646: Refactor: Consolidate preview template outer container.
Thu, Apr 12, 12:43 PM · Readers-Web-Backlog, Page-Previews
Niedzielski added a project to T173952: Remove A/B testing and instrumentation code: Technical-Debt.
Thu, Apr 12, 2:58 AM · Technical-Debt, Readers-Web-Backlog, Page-Previews
Niedzielski added a comment to T191888: Change page previews configuration for opt-in accounts.

Since we've already deployed to dewiki and will soon deploy to enwiki, have we missed the window for this task? It seems worse to initially enable it for everyone and then turn it off for many people.

Thu, Apr 12, 2:56 AM · Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Page-Previews
Niedzielski moved T191945: wikimediafoundation.org doesn't have a responsive design from Needs triage to Triaged on the Mobile board.
Thu, Apr 12, 2:09 AM · Reading-Web-Local-Wiki-Issues, Wikimedia-General-or-Unknown, Mobile
Niedzielski moved T191674: Template:Css_image_crop images are not showing in mobile view from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Thu, Apr 12, 2:06 AM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, MobileFrontend
Niedzielski added a project to T191674: Template:Css_image_crop images are not showing in mobile view: Readers-Web-Backlog.
Thu, Apr 12, 2:06 AM · Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, MobileFrontend
Niedzielski updated subscribers of T191795: Support MCR in mobile.
Thu, Apr 12, 2:06 AM · Readers-Web-Backlog (Tracking), User-mobrovac, Services (designing), MobileFrontend, RESTBase, Mobile-Content-Service, Parsoid, Reading-Infrastructure-Team-Backlog, Multi-Content-Revisions
Niedzielski updated subscribers of T191795: Support MCR in mobile.
Thu, Apr 12, 2:05 AM · Readers-Web-Backlog (Tracking), User-mobrovac, Services (designing), MobileFrontend, RESTBase, Mobile-Content-Service, Parsoid, Reading-Infrastructure-Team-Backlog, Multi-Content-Revisions
Niedzielski moved T191795: Support MCR in mobile from To Triage to Tracking on the Readers-Web-Backlog board.
Thu, Apr 12, 2:04 AM · Readers-Web-Backlog (Tracking), User-mobrovac, Services (designing), MobileFrontend, RESTBase, Mobile-Content-Service, Parsoid, Reading-Infrastructure-Team-Backlog, Multi-Content-Revisions
Niedzielski moved T192018: Make it possible to edit the lead (section 0) when Javascript is disabled (mobile view) from To Triage to Needs Analysis on the Readers-Web-Backlog board.
Thu, Apr 12, 2:04 AM · Readers-Web-Backlog (Design), MobileFrontend
Niedzielski added a project to T191795: Support MCR in mobile: Readers-Web-Backlog.
Thu, Apr 12, 2:04 AM · Readers-Web-Backlog (Tracking), User-mobrovac, Services (designing), MobileFrontend, RESTBase, Mobile-Content-Service, Parsoid, Reading-Infrastructure-Team-Backlog, Multi-Content-Revisions
Niedzielski added a project to T192018: Make it possible to edit the lead (section 0) when Javascript is disabled (mobile view): Readers-Web-Backlog.
Thu, Apr 12, 2:03 AM · Readers-Web-Backlog (Design), MobileFrontend
Niedzielski placed T190831: [Bug] Page preview portrait images should be flipped in right-to-left languages up for grabs.
Thu, Apr 12, 1:54 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, RTL, I18n, Page-Previews, Readers-Web-Backlog
Niedzielski moved T190831: [Bug] Page preview portrait images should be flipped in right-to-left languages from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Thu, Apr 12, 1:54 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, RTL, I18n, Page-Previews, Readers-Web-Backlog

Wed, Apr 11

Niedzielski added a comment to T190831: [Bug] Page preview portrait images should be flipped in right-to-left languages.

@Jdlrobson, there's more to it than that but if you're really curious, I'm happy to chat in depth.

Wed, Apr 11, 11:32 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, RTL, I18n, Page-Previews, Readers-Web-Backlog
Niedzielski closed T165036: Refactor rendering code in src/renderer.js for readability and testability as Resolved.

Good find @ABorbaWMF. I've opened T192004 to track. Closing this unrelated ticket per discussion.

Wed, Apr 11, 5:21 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski closed T165036: Refactor rendering code in src/renderer.js for readability and testability, a subtask of T162936: Improve developer happiness, as Resolved.
Wed, Apr 11, 5:21 PM · Epic, Readers-Web-Backlog
Niedzielski closed T165036: Refactor rendering code in src/renderer.js for readability and testability, a subtask of T186129: Set up Extension:Popups to support multiple preview types, as Resolved.
Wed, Apr 11, 5:21 PM · Readers-Web-Backlog, Page-Previews
Niedzielski created T192004: [Bug] [IE 11] Popups settings dialog is offcenter.
Wed, Apr 11, 5:21 PM · Browser-Support-Internet-Explorer, Page-Previews, Readers-Web-Backlog
Niedzielski updated subscribers of T42812: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state).

@Niedzielski to add his review but more reviews from the team are requested. /cc @pmiazga, @Jhernandez, @Jdrewniak

Wed, Apr 11, 5:10 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Vector, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface
Niedzielski assigned T189533: [Bug] Search overlay isn't always full screen to ABorbaWMF.

Over to you, @ABorbaWMF. Please test this on the beta cluster: https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page.

Wed, Apr 11, 5:07 PM · Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Readers-Web-Backlog
Niedzielski added a comment to T189533: [Bug] Search overlay isn't always full screen.

I think so too!

Wed, Apr 11, 3:59 PM · Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Readers-Web-Backlog

Tue, Apr 10

Niedzielski added a comment to T191454: Watchlist missing logic is broken and hits the API multiple times unnecessarily on load.

In short: don't make a watchlist request for pages that are known to be missing.

Tue, Apr 10, 4:24 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Readers-Web-Kanbanana-Board, Readers-Web-Backlog
Niedzielski added a comment to T165036: Refactor rendering code in src/renderer.js for readability and testability.

Looks good except for IE 11. This is probably a separate issue. I only see this on IE11. It is not present on Chrome, Edge, Opera, or Firefox.

Just to confirm, the issue here is that the settings dialog is centered on the upper left corner?

Tue, Apr 10, 3:06 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski updated the task description for T191893: [Bug] Horizontal scrollbar shown when browser window is between 1000px and 1107px.
Tue, Apr 10, 1:29 PM · Readers-Web-Backlog (Design), MinervaNeue
Niedzielski created T191893: [Bug] Horizontal scrollbar shown when browser window is between 1000px and 1107px.
Tue, Apr 10, 1:26 PM · Readers-Web-Backlog (Design), MinervaNeue

Fri, Apr 6

Niedzielski added a comment to T165036: Refactor rendering code in src/renderer.js for readability and testability.

Thanks @ABorbaWMF. That gif was meant to be informational and may or may not be useful since I think all the testing can be done as a user. Testing for this is pretty much just a run through of all the popups UI. Something like:

Fri, Apr 6, 8:15 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Mholloway awarded Blog Post: mustache.js replaced with JavaScript template literals in Extension:Popups a Like token.
Fri, Apr 6, 6:16 PM
Niedzielski created T191646: Refactor: Consolidate preview template outer container.
Fri, Apr 6, 4:53 PM · Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski added a comment to T190831: [Bug] Page preview portrait images should be flipped in right-to-left languages.

Thanks @Jdlrobson. Since the user may have their preference set to show the UI in English / LTR, I've updated the URL and removed this step.

Fri, Apr 6, 4:36 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, RTL, I18n, Page-Previews, Readers-Web-Backlog
Niedzielski updated the task description for T190831: [Bug] Page preview portrait images should be flipped in right-to-left languages.
Fri, Apr 6, 4:33 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, RTL, I18n, Page-Previews, Readers-Web-Backlog

Thu, Apr 5

Niedzielski updated the task description for T190831: [Bug] Page preview portrait images should be flipped in right-to-left languages.
Thu, Apr 5, 6:40 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, RTL, I18n, Page-Previews, Readers-Web-Backlog
Niedzielski added a comment to T187821: Choose a server for the chromium-render service.

Thanks @mobrovac! ^/cc @ovasileva

Thu, Apr 5, 5:00 PM · Services (done), Readers-Web-Backlog, Proton, Operations
Niedzielski updated the task description for T190831: [Bug] Page preview portrait images should be flipped in right-to-left languages.
Thu, Apr 5, 2:40 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, RTL, I18n, Page-Previews, Readers-Web-Backlog
Niedzielski claimed T190831: [Bug] Page preview portrait images should be flipped in right-to-left languages.
Thu, Apr 5, 2:32 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, RTL, I18n, Page-Previews, Readers-Web-Backlog
Niedzielski moved T190831: [Bug] Page preview portrait images should be flipped in right-to-left languages from To Do to Doing on the Readers-Web-Kanbanana-Board board.
Thu, Apr 5, 2:32 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, RTL, I18n, Page-Previews, Readers-Web-Backlog
Niedzielski added a comment to T190834: Edit icon should show as locked when user is blocked from editing..

This is related to T190613.

Thu, Apr 5, 2:29 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Readers-Web-Kanbanana-Board, MinervaNeue, Readers-Web-Backlog
Niedzielski placed T190834: Edit icon should show as locked when user is blocked from editing. up for grabs.
Thu, Apr 5, 2:27 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Readers-Web-Kanbanana-Board, MinervaNeue, Readers-Web-Backlog
Niedzielski moved T190834: Edit icon should show as locked when user is blocked from editing. from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Thu, Apr 5, 2:27 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Readers-Web-Kanbanana-Board, MinervaNeue, Readers-Web-Backlog

Wed, Apr 4

Niedzielski added a comment to T190188: VirtualPageView schema should not use EventLogging api to send virtual page view events.

I confirm VirtualPageView events are received on deployment-eventlog05 from the beta cluster regardless of DNT settings for Chrome v65.0.3325.181 on Ubuntu v17.10 64b and Firefox v59.0.2.

Wed, Apr 4, 5:59 PM · Readers-Web-Backlog (Tracking), MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Page-Previews
Niedzielski assigned T191230: [Bug] Auto expanding text area causes editor to lose editing position to Jdrewniak.

@Jdrewniak to review.

Wed, Apr 4, 5:25 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, MobileFrontend, Readers-Web-Kanbanana-Board, Readers-Web-Backlog
Niedzielski assigned T165036: Refactor rendering code in src/renderer.js for readability and testability to ABorbaWMF.

@ABorbaWMF, the result of this task in itself should not be especially user visible. Please just generally verify that page previews appear to be working. Thank you!

Wed, Apr 4, 5:19 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski added a comment to T190188: VirtualPageView schema should not use EventLogging api to send virtual page view events.

@Niedzielski @Jdlrobson to do a little more QAing.

Wed, Apr 4, 5:18 PM · Readers-Web-Backlog (Tracking), MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Page-Previews
Niedzielski placed T165036: Refactor rendering code in src/renderer.js for readability and testability up for grabs.
Wed, Apr 4, 5:17 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski moved T165036: Refactor rendering code in src/renderer.js for readability and testability from Needs More Work to Needs QA on the Readers-Web-Kanbanana-Board board.
Wed, Apr 4, 5:17 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski added a comment to Blog Post: mustache.js replaced with JavaScript template literals in Extension:Popups.

@Jhernandez thank you!

Wed, Apr 4, 3:19 PM

Tue, Apr 3

Niedzielski updated the task description for T191368: [Bug] Talk and category buttons missing for anons.
Tue, Apr 3, 10:43 PM · MobileFrontend, Readers-Web-Backlog
Niedzielski created T191368: [Bug] Talk and category buttons missing for anons.
Tue, Apr 3, 10:38 PM · MobileFrontend, Readers-Web-Backlog
Niedzielski created T191367: Clicking edit icon at top of page confuses when lead section is blank.
Tue, Apr 3, 10:32 PM · Readers-Web-Backlog (Design), MobileFrontend
Niedzielski created Blog Post: mustache.js replaced with JavaScript template literals in Extension:Popups.
Tue, Apr 3, 5:22 PM
Niedzielski added a project to T42812: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state): Vector.
Tue, Apr 3, 4:34 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Vector, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface
Niedzielski added a project to T191230: [Bug] Auto expanding text area causes editor to lose editing position: MobileFrontend.
Tue, Apr 3, 4:33 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, MobileFrontend, Readers-Web-Kanbanana-Board, Readers-Web-Backlog
Niedzielski updated subscribers of T187821: Choose a server for the chromium-render service.

Hey @mobrovac. We're making final plans for the current quarter. Any idea when we should expect a place for the Proton production server to be available? I'm happy to continue the patches we worked on with @Pchelolo or clarify any ambiguities. Let me know how I can help you help us! Thank you! /cc @ovasileva @thcipriani

Tue, Apr 3, 2:55 PM · Services (done), Readers-Web-Backlog, Proton, Operations

Mon, Apr 2

Niedzielski reassigned T190469: Top alignment for Page Issues Modal from Jdlrobson to alexhollender.
Mon, Apr 2, 5:18 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog
Niedzielski moved T190469: Top alignment for Page Issues Modal from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board board.
Mon, Apr 2, 5:17 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog
Niedzielski added a comment to T190469: Top alignment for Page Issues Modal.

@Niedzielski to review.

Mon, Apr 2, 5:04 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog

Thu, Mar 29

Niedzielski added a comment to T190188: VirtualPageView schema should not use EventLogging api to send virtual page view events.

@Jdlrobson will deploy Monday.

Thu, Mar 29, 5:11 PM · Readers-Web-Backlog (Tracking), MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Page-Previews

Wed, Mar 28

Niedzielski claimed T190834: Edit icon should show as locked when user is blocked from editing..
Wed, Mar 28, 6:53 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Readers-Web-Kanbanana-Board, MinervaNeue, Readers-Web-Backlog
Niedzielski moved T190834: Edit icon should show as locked when user is blocked from editing. from Needs More Work to Doing on the Readers-Web-Kanbanana-Board board.
Wed, Mar 28, 6:53 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Readers-Web-Kanbanana-Board, MinervaNeue, Readers-Web-Backlog
Niedzielski moved T165036: Refactor rendering code in src/renderer.js for readability and testability from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Wed, Mar 28, 6:52 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski moved T165036: Refactor rendering code in src/renderer.js for readability and testability from Needs More Work to Doing on the Readers-Web-Kanbanana-Board board.
Wed, Mar 28, 6:50 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski placed T189699: Table of contents not show on desktop Minerva (remove wgMinervaTocEnabled config flag) up for grabs.
Wed, Mar 28, 6:50 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, Readers-Web-Backlog, MinervaNeue (Desktop)
Niedzielski moved T189699: Table of contents not show on desktop Minerva (remove wgMinervaTocEnabled config flag) from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Wed, Mar 28, 6:49 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, Readers-Web-Backlog, MinervaNeue (Desktop)
Niedzielski added a comment to T189699: Table of contents not show on desktop Minerva (remove wgMinervaTocEnabled config flag).

@TheDJ, this is a Minerva-specific issue. Please see https://en.wikipedia.org/wiki/Henry_VIII_of_England?useskin=minerva.

Wed, Mar 28, 3:40 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, Readers-Web-Backlog, MinervaNeue (Desktop)