@alexhollender the new 10px lot look stellar. I've deployed these changes to https://readers-web-stephen.wmflabs.org/ for your review. You can verify the version is still deployed by checking that MinervaNeue is at revision 2ce4242 on https://readers-web-stephen.wmflabs.org/wiki/Special:Version.
Wed, Jun 20
@alexhollender, here's with a 20x20px SVG and a background-size of 10px on a standard density display:
We could use a CSS media query to limit the SVG asset to hidpi or high resolution displays and fallback to a hand tuned 10x10px PNG otherwise.
@alexhollender, here's what I see on standard and hidpi monitors (and zoomed in at 4x, no interpolation):
Tue, Jun 19
Over to @Jdlrobson for patch feedback.
@Jdlrobson, yeah, let's just report the errors and we can check them in our chores and on Tuesdays. The sooner the better!
Over to me to review.
Mon, Jun 18
To whomever reviews the above patch: if you're happy with it, consider resolving T193519. I just used the ASCII report since it seemed reasonable and would be easy to eye in CI.
I've reviewed and tested Jon's changes and they look good but would feel more comfortable if they got a second pair of eyes. Can you take a look?
Fri, Jun 15
@Jdlrobson over to you for sing off.
Thu, Jun 14
Over to @Jdlrobson for code review since 1) we've already established a context for this patch 2) I may have botched the ResourceLoader changes.
Jon showed me what's up. I don't think I'll need anything extra.
@alexhollender, the existing links are 10px square. The new assets are 20px but I wasn't sure if you really wanted that. Can you provide some PNG cuts for fallback too? When I try to render the new assets at 10px they don't come out very good. Thanks!
This patch needs a product decision before I can merge it.
Wed, Jun 13
Is that all you care about? Patches?
@Jdlrobson, this needs more work and discussion but I removed some of the cruft