Thanks @Gilles. Patches are up.

@Jdlrobson, @pmiazga, @Jdrewniak, @nray I can pair with one of you to help QA as needed.

Thank you so much @cscott, @pmiazga, @phuedx, @ovasileva, @Jdrewniak, @Jdlrobson, @Addshore, @WMDE-leszek, @Smalyshev, @Tarrow for helping to get this merged!!! \o/

If I understand correctly, this issue is also easily reproducible by running maintenance/install.php with a preexisting LocalSettings.php:

Diff the NPM 2.0.0 (unminified) release with libs/hogan.js/hogan.js to verify the version is correct.

diff node_modules/hogan.js/web/builds/2.0.0/hogan-2.0.0.js libs/hogan.js/hogan.js.js checks out.

@ABorbaWMF, BC seems to be working at the moment for me https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:History/User:Teststephen

@Addshore, I wanted to thank you for your help formally on this task and general Wikidataness. I've greatly benefited from your gentle guidance :]

No subtasks remain! Time to check off the AC and close?

It seems that all subtasks of this epic are closed \o/ Is there any work remaining?

Is T156186 the last task in this epic? If so, let's get it done and close this sucker!

instanceof $
$html = $( tmpDOM );

I wasn't sure what to do with this one since we don't have a util method for these. Since it was unusual and not part of this task's tests, I left it.

Just to confirm, that means 50% of articles across all projects?

Just to keep this ticket somewhat in sync with the patch, the latest patchset produces schemas like:

I can no longer reproduce.

Doesn't occur when I shrink the screen:

This seems to still be an issue until I type: https://readers-web-master.wmflabs.org/w/index.php?title=Barack_Obama2#/editor/0

The above occurs on mobile which does not have Popups.

Task manager observations for my own consideration later.

Thank you so much @zeljkofilipin!!

Patch revised. @ovasileva, moving to blocked pending feedback from Wikibase folks. @Jdlrobson, @pmiazga, reviews appreciated in the meantime!

@cscott, thank you very much for these references.

What problems do we hope mustache-loader will solve? Is it just a performance and dependency thing? If it's the former, I'd like to understand if we plan to keep Mustache templates in MobileFrontend for the foreseeable future. We've migrated away from them in Popups. I didn't seem to have much problem with the latter in 104322ed3. I understand there are other Hogan.js consumers but it seems like a lower priority to me if we're not planning to use templates in MobileFrontend. I'm not opposed to Mustache necessarily but I do hope to avoid polishing what we won't actually use and I thought we were previously considering migrating away from templates.

@Jdrewniak, thanks for looking into this. FWIW, @Tbayer also alluded to these mapping concerns in his comment. What do you think we should do for the many entities that do not have an equivalent class? For example, kitten is not an instance of anything but is a subclass of house cat and that has no equivalent class. Should I fallback to instance of and then to subclass of?

The WIP now records description and @type fields. The former is not required but seems to be recommended for the microdata format we were exploring previously. The latter is flagged as an error by Google's structured data testing tool when omitted.

Per discussion, I've continued with the minimal JSON-LD approach. I've uploaded a WIP with a Q number hardcoded while we figure out the linking issue subtasked. I've staged the change. It literally injects:

I can reproduce this behavior in the Docker Compose image but I don't have an issue in Vagrant with creating links to production Wikipedia.

If possible, please rename CSS class names from A/B-test specific to main/non-main namespace specific since both treatments must be kept.

@Jdlrobson, @ovasileva, once https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/463545/ is merged, this is ready for the board!

I didn't realize we had a separate one for beta. I wish our Gerrit / tooling errors went there instead of prod!

I wonder why this isn't showing up in the logstash.