Page MenuHomePhabricator

Niedzielski (Stephen Niedzielski)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2015, 9:18 PM (242 w, 4 d)
Availability
Available
IRC Nick
niedzielski
LDAP User
Unknown
MediaWiki User
Niedzielski [ Global Accounts ]

Recent Activity

Yesterday

Niedzielski created T240062: Extract components from VectorTemplate to Mustache files.
Sat, Dec 7, 12:33 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Technical-Debt, Desktop Improvements, Vector

Fri, Dec 6

Niedzielski added a project to T239248: Divide VectorTemplate into components: Epic.
Fri, Dec 6, 11:48 PM · Epic, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Technical-Debt, Desktop Improvements, Vector
Niedzielski updated the task description for T239269: Add coding convention for new commits to Vector.
Fri, Dec 6, 3:23 PM · Desktop Improvements, Spike, Vector, Technical-Debt

Wed, Dec 4

Niedzielski updated the task description for T239269: Add coding convention for new commits to Vector.
Wed, Dec 4, 6:35 PM · Desktop Improvements, Spike, Vector, Technical-Debt
Niedzielski added a comment to T239295: Placeholder: Run display locking origin trial.

Does T239418 depend on this task?

Wed, Dec 4, 5:39 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski moved T239377: Use <img lazyload> for footer icons from Incoming to Tracking on the Readers-Web-Backlog board.
Wed, Dec 4, 4:01 PM · Readers-Web-Backlog (Tracking), Performance-Team, Vector
Niedzielski added a project to T239377: Use <img lazyload> for footer icons: Readers-Web-Backlog.
Wed, Dec 4, 3:59 PM · Readers-Web-Backlog (Tracking), Performance-Team, Vector

Tue, Dec 3

Niedzielski updated subscribers of T239740: MobileFrontend "transparent-shield" makes pages unreadable (Wikitech).

This appears to be a duplicate of T237552#5661368 which has been fixed by @matmarex but not yet deployed.

Tue, Dec 3, 7:28 PM · Readers-Web-Backlog, wikitech.wikimedia.org, MobileFrontend
Niedzielski merged T239740: MobileFrontend "transparent-shield" makes pages unreadable (Wikitech) into T237552: Regression: Gray Screen shows for wikis that require login to edit due to problem in editor setup.
Tue, Dec 3, 7:27 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), VisualEditor (Current work), MinervaNeue
Niedzielski merged task T239740: MobileFrontend "transparent-shield" makes pages unreadable (Wikitech) into T237552: Regression: Gray Screen shows for wikis that require login to edit due to problem in editor setup.
Tue, Dec 3, 7:27 PM · Readers-Web-Backlog, wikitech.wikimedia.org, MobileFrontend
Niedzielski added a comment to T239740: MobileFrontend "transparent-shield" makes pages unreadable (Wikitech).

I think this issue is limited to anonymous users. I'm looking into it.

Tue, Dec 3, 7:03 PM · Readers-Web-Backlog, wikitech.wikimedia.org, MobileFrontend
Niedzielski added a comment to T225213: Main Menu should work without JavaScript to be more accessible and a better user experience.

Assigned to @Jdrewniak to refine his CSS checkbox patch.

Tue, Dec 3, 6:11 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Jdlrobson, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Niedzielski reassigned T225213: Main Menu should work without JavaScript to be more accessible and a better user experience from Jdlrobson to Jdrewniak.
Tue, Dec 3, 6:10 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Jdlrobson, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Niedzielski claimed T237561: [SPIKE 10hrs] Investigate how skin suboptions can be presented in Special:Preferences.
Tue, Dec 3, 2:45 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Niedzielski moved T237561: [SPIKE 10hrs] Investigate how skin suboptions can be presented in Special:Preferences from Ready for Development to Doing on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Tue, Dec 3, 2:45 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements

Mon, Dec 2

Niedzielski added a comment to T239258: Migrate JavaScript API documentation from jsduck to JSDoc.

@ovasileva, I think this task and its parent are very important for any JavaScript work we do in Vector. I would rather not have to lookup jsduck syntax :] Would it be possible to get this into the kanbanana soon?

Mon, Dec 2, 9:36 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, Vector, Technical-Debt
Niedzielski awarded T237636: [SPIKE 10hrs] Build new header within the Vector skin a Love token.
Mon, Dec 2, 9:30 PM · Performance-Team (Radar), Accessibility, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Niedzielski added a comment to T239269: Add coding convention for new commits to Vector.

@Volker_E, for better and worse it's been my experience that the Web team is often pioneering new technologies, and coding patterns and techniques that occasionally percolate out to the broader Foundation's repositories. Having a universal coding convention (beyond linting) sounds appealing, but in practice, I think repositories are often focused on very different problems and conventions that seem like no-brainers in one place may be entirely impractical and be a negative force on development in another. Additionally, assigning a team all the responsibilities of maintaining and significantly extending a project but demanding that all coding conventions pass through the gatekeepers of the conventions for all repositories under the Foundation's purview is not empowering and leads to lazy contributions in my perspective. I would rather see the team fully embrace a convention that makes sense to them for a given project.

Mon, Dec 2, 9:28 PM · Desktop Improvements, Spike, Vector, Technical-Debt
Niedzielski updated the task description for T239269: Add coding convention for new commits to Vector.
Mon, Dec 2, 8:22 PM · Desktop Improvements, Spike, Vector, Technical-Debt
Niedzielski added a comment to T206567: [Bug] Linking an item to a page does not recognize the active wiki's site identifier.

@Addshore, sorry I'm not very smart about this part of the codebase. I've executed docker exec -it boxwiki_mediawiki_1 php extensions/Wikibase/lib/maintenance/populateSitesTable.php and it reports done.. http://localhost:8181/wiki/Special:SiteMatrix is empty.

Mon, Dec 2, 7:21 PM · Wikidata-Campsite, Documentation, Wikibase-Containers, Wikidata
Niedzielski updated the task description for T239269: Add coding convention for new commits to Vector.
Mon, Dec 2, 6:58 PM · Desktop Improvements, Spike, Vector, Technical-Debt
Niedzielski added a project to T239357: Identify Page-Previews product people: Readers-Web-Backlog.
Mon, Dec 2, 3:54 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Page-Previews
Niedzielski moved T224430: Improve appearance of Special:MobileDiff when looking for invalid revision (Maybe because it's deleted) from Needs Analysis to Needs QA on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Mon, Dec 2, 3:19 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MobileFrontend (MobileFrontend Special Pages)
Niedzielski reassigned T224430: Improve appearance of Special:MobileDiff when looking for invalid revision (Maybe because it's deleted) from Ammarpad to Edtadros.

@ovasileva, I've merged @Ammarpad's nice patch. It looked low risk, was a solid improvement, and the patch was ready and waiting. As the patch is now merged, I'm moving this into the kanban board for testing by @Edtadros.

Mon, Dec 2, 3:19 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MobileFrontend (MobileFrontend Special Pages)
Niedzielski updated the task description for T224430: Improve appearance of Special:MobileDiff when looking for invalid revision (Maybe because it's deleted).
Mon, Dec 2, 3:18 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, MobileFrontend (MobileFrontend Special Pages)

Tue, Nov 26

Niedzielski moved T225213: Main Menu should work without JavaScript to be more accessible and a better user experience from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Kanbanana-2019-20-Q2) board.
Tue, Nov 26, 9:21 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Jdlrobson, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Niedzielski created T239271: Upgrade Sinon.JS.
Tue, Nov 26, 7:25 PM · Technical-Debt, Readers-Web-Backlog
Niedzielski created T239269: Add coding convention for new commits to Vector.
Tue, Nov 26, 7:09 PM · Desktop Improvements, Spike, Vector, Technical-Debt
Niedzielski created T239268: Add Node.js unit test infrastructure.
Tue, Nov 26, 7:00 PM · Desktop Improvements, Vector, Technical-Debt
Niedzielski updated subscribers of T233925: [EPIC] Establish feedback cycles with community and identify test wikis.

@TheDJ has recommend mediawiki.org as a test wiki candidate with the idea that it would 1) encourage developers to use the new Vector 2) regressions would have low impact to users but high visibility to devs.

Tue, Nov 26, 6:48 PM · Desktop Improvements
Niedzielski created T239263: Add Storybook documentation for components.
Tue, Nov 26, 6:46 PM · Desktop Improvements, Vector, Technical-Debt
Niedzielski added a parent task for T239258: Migrate JavaScript API documentation from jsduck to JSDoc: T239262: Type check JavaScript documentation.
Tue, Nov 26, 6:41 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, Vector, Technical-Debt
Niedzielski added a subtask for T239262: Type check JavaScript documentation: T239258: Migrate JavaScript API documentation from jsduck to JSDoc.
Tue, Nov 26, 6:41 PM · Desktop Improvements, Vector, Technical-Debt
Niedzielski created T239262: Type check JavaScript documentation.
Tue, Nov 26, 6:41 PM · Desktop Improvements, Vector, Technical-Debt
Niedzielski added a subtask for T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases: T239258: Migrate JavaScript API documentation from jsduck to JSDoc.
Tue, Nov 26, 5:58 PM · Patch-For-Review, Epic, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, MobileFrontend, Documentation
Niedzielski added a parent task for T239258: Migrate JavaScript API documentation from jsduck to JSDoc: T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases.
Tue, Nov 26, 5:58 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, Vector, Technical-Debt
Niedzielski created T239258: Migrate JavaScript API documentation from jsduck to JSDoc.
Tue, Nov 26, 5:56 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, Vector, Technical-Debt
Niedzielski updated the task description for T239248: Divide VectorTemplate into components.
Tue, Nov 26, 5:34 PM · Epic, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Technical-Debt, Desktop Improvements, Vector
Niedzielski updated the task description for T239248: Divide VectorTemplate into components.
Tue, Nov 26, 5:20 PM · Epic, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Technical-Debt, Desktop Improvements, Vector
Niedzielski created T239248: Divide VectorTemplate into components.
Tue, Nov 26, 5:02 PM · Epic, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Readers-Web-Backlog (Kanbanana-2019-20-Q2), Technical-Debt, Desktop Improvements, Vector
Niedzielski added a comment to T233741: Settings should be in an overlay.

Depending on the approach taken, this task may be a good candidate for initial FAWG integration (it's a form composed of components with minimal ties to MW and may appear as a modal).

Tue, Nov 26, 3:41 PM · User-Jdlrobson, Desktop Improvements, Readers-Web-Backlog
zeljkofilipin awarded T206358: Request Sauce Labs access for niedzielski a Like token.
Tue, Nov 26, 2:43 PM · Release-Engineering-Team-TODO

Mon, Nov 18

Masumrezarock100 awarded T212263: Migrate page issue styles from Minerva to TemplateStyles a Like token.
Mon, Nov 18, 8:38 AM · User-Jdlrobson, Technical-Debt, Reading-Web-Local-Wiki-Issues, Page-Issue-Warnings, MinervaNeue, Readers-Web-Backlog

Fri, Nov 15

Niedzielski updated the task description for T238264: Unconference: JS Framework Experience Sharing.
Fri, Nov 15, 7:31 PM · Wikimedia-Technical-Conference-2019
Niedzielski updated the task description for T238264: Unconference: JS Framework Experience Sharing.
Fri, Nov 15, 7:28 PM · Wikimedia-Technical-Conference-2019

Thu, Nov 14

Niedzielski updated the task description for T238264: Unconference: JS Framework Experience Sharing.
Thu, Nov 14, 11:03 PM · Wikimedia-Technical-Conference-2019
Niedzielski closed T206358: Request Sauce Labs access for niedzielski as Resolved.

@zeljkofilipin, thank you! This seems to be working for me now.

Thu, Nov 14, 2:26 PM · Release-Engineering-Team-TODO

Fri, Nov 8

Niedzielski added a comment to T236528: "reading-web-staging" Cloud VPS project jessie deprecation.

@bd808, deleted!

Fri, Nov 8, 5:45 PM · Cloud-VPS (Debian Jessie Deprecation)
Niedzielski updated the task description for T236528: "reading-web-staging" Cloud VPS project jessie deprecation.
Fri, Nov 8, 5:45 PM · Cloud-VPS (Debian Jessie Deprecation)

Nov 7 2019

Niedzielski added a member for Desktop Improvements: Niedzielski.
Nov 7 2019, 6:02 PM

Nov 6 2019

Niedzielski added a comment to T237561: [SPIKE 10hrs] Investigate how skin suboptions can be presented in Special:Preferences.

@alexhollender, is it important to represent this new setting as a suboption? E.g.:

Nov 6 2019, 10:36 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements
Niedzielski updated subscribers of T233037: [Regression] Not possible for logged in users to disable page previews.

Wow!! Good work everybody! Special shout out to @Edtadros for the great find and @Jdlrobson for the great investigation!

Nov 6 2019, 8:01 PM · Wikimedia-Fundraising-Banners, Readers-Web-Backlog (Tracking), Reference Previews, Regression, Page-Previews
Niedzielski added a comment to T218647: Quibble should backup and delete LocalSettings.php.

I've been away for awhile so please excuse this comment if it doesn't make sense, but did you consider a "--deleteLocalSettings" (or similar) flag? If the flag is set, the LocalSettings.php can be deleted and database reinitialized. If not, the informational message can be shown: A LocalSettings.php file has been detected. To upgrade this installation, please run update.php instead.

Nov 6 2019, 4:20 PM · Quibble

Nov 5 2019

Niedzielski awarded Blog Post: Integrating code coverage metrics with your development workflow a Like token.
Nov 5 2019, 8:15 PM · Code-Health, MediaWiki-Core-Testing, Test-Coverage
Niedzielski updated subscribers of T235737: Discuss and decide on underspecified behavior for anonymous users.

Adding to @ovasileva and @alexhollender's radar in case they're interested in this change.

Nov 5 2019, 8:13 PM · WMDE-Design, Page-Previews, WMDE-QWERTY-Team, Design, Reference Previews
Niedzielski added a comment to T236528: "reading-web-staging" Cloud VPS project jessie deprecation.

marvin-staging.reading-web-staging.eqiad.wmflabs

This can be reclaimed AFAIK.

Nov 5 2019, 4:58 PM · Cloud-VPS (Debian Jessie Deprecation)
Niedzielski added a comment to T111329: [GOAL] Page previews on mobileweb.

I like that we're tidying up the backlog but for this task in particular it seems a shame that it can't be reprioritized any time soon. Page previews have been very impactful on desktop and this task had over 80 subtasks, which all appear to be resolved now. Additionally, Popups now support references as an additional out of box functionality. I respect the priorities set by product but I wanted to mention that from my perspective as a developer and user, I think this feature could be worth doing sooner rather than later.

Nov 5 2019, 4:32 PM · Readers-Web-Backlog (Needs Product Owner Decisions), Reading Epics (Page Previews), Goal, Page-Previews
Niedzielski removed a watcher for wikimedia-page-library: Niedzielski.
Nov 5 2019, 4:12 PM
Niedzielski awarded T236589: Page Previews Storybook not available on doc.wikimedia.org and documentation a bit broken a Love token.
Nov 5 2019, 4:04 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Patch-For-Review, Documentation, Page-Previews
Niedzielski updated the task description for T236091: Wikidata not compatible with the advanced mobile contributions mode of Minerva.
Nov 5 2019, 3:38 PM · Wikidata, MinervaNeue (Tracking), Wikidata-Termbox

Nov 4 2019

Niedzielski added a comment to T234258: Delete readers-web-stephen.reading-webstaging.eqiad.wmflabs and marvin-staging.reading-webstaging.eqiad.wmflabs?.

Thanks! I use readers-web-stephen to share and develop changes with the team so please keep it! AFAIK, marvin-staging and chromium-pdf can be dropped.

Nov 4 2019, 10:17 PM · Readers-Web-Backlog (Tracking)
Niedzielski awarded T234582: Remove IE 6 & 7 hacks and workarounds from core & extensions a Like token.
Nov 4 2019, 7:03 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Technical-Debt, Front-end-Standards-Group, Browser-Support-Internet-Explorer, CSS, MediaWiki-General

Oct 11 2019

Masumrezarock100 awarded T226125: Updates to notifications container on mobile to make it more consistent with desktop a Like token.
Oct 11 2019, 5:22 PM · User-Jdlrobson, Growth-Team, Notifications, Readers-Web-Backlog (Design), Patch-For-Review

Sep 7 2019

Masumrezarock100 awarded T204834: [Needs input] Show the category button on pages without any categories a Like token.
Sep 7 2019, 6:11 AM · Advanced Mobile Contributions, Readers-Web-Backlog (Design), MobileFrontend

Aug 29 2019

Niedzielski added a comment to T226562: AMC - display labels for toolbar actions on larger screens.

Replace the class names for the page actions icons with the new class

I ended up taking a no-JS approach. Let's see what folks think.

Aug 29 2019, 7:10 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Niedzielski moved T230693: [AMC] Update icon for "Page information" menu item from Needs QA to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 29 2019, 3:26 PM · Product-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski reassigned T229295: Cleanup AMC feature flagging from pmiazga to Edtadros.
Aug 29 2019, 3:26 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue (Desktop), Advanced Mobile Contributions
Niedzielski moved T229295: Cleanup AMC feature flagging from Needs QA to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 29 2019, 3:26 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue (Desktop), Advanced Mobile Contributions
Niedzielski added a comment to T230693: [AMC] Update icon for "Page information" menu item.

@alexhollender, sounds good. Updated QA (note: patch not yet merged).

Aug 29 2019, 3:25 PM · Product-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski updated the task description for T230693: [AMC] Update icon for "Page information" menu item.
Aug 29 2019, 3:25 PM · Product-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski claimed T226562: AMC - display labels for toolbar actions on larger screens.
Aug 29 2019, 3:17 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Niedzielski moved T226562: AMC - display labels for toolbar actions on larger screens from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 29 2019, 3:17 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Niedzielski assigned T230693: [AMC] Update icon for "Page information" menu item to alexhollender.
Aug 29 2019, 3:08 PM · Product-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski added a comment to T230693: [AMC] Update icon for "Page information" menu item.

This is currently using the "info" icon in wikimedia.ui. Change it to use "infoFilled" and check with Alex that the icon used matches the attachment. If it's not we'll need to update the icon in OOUI (out of scope for this task).
DO NOT put a new SVG icon into the Minerva repo.

Aug 29 2019, 3:08 PM · Product-QA (RW-Test-Cases), MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions

Aug 28 2019

Niedzielski added a comment to T230034: [AMC] Menu handle has no active state.

@alexhollender, hm, since the toolbar is already grey maybe we need to use a translucent background. Something like:

Aug 28 2019, 7:15 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
Niedzielski created T231486: [Bug] ArgumentCountError in MobileFrontend/includes/amc/Manager.php: Too few arguments to function MobileFrontend\AMC\Manager::__construct().
Aug 28 2019, 6:07 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions
Niedzielski added a comment to T230695: Render talk page as a tab (rather than a modal).

@Jdlrobson via discussion:

Aug 28 2019, 4:59 PM · User-notice, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Advanced Mobile Contributions

Aug 27 2019

Niedzielski moved T206265: Bug: Section edit links should be hidden for blocked users from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 27 2019, 9:01 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), good first task
Niedzielski reassigned T206265: Bug: Section edit links should be hidden for blocked users from Niedzielski to pmiazga.

@pmiazga, given your experience, I think you're in an ideal spot to review this change. I refactored some of the "loose" page permission checks into the MinervaPagePermissions implementation as it seemed quite appropriate. What I'm most unsure of is if any special work is needed when adding new permission actions (a special config in skin.json). (I'm not sure why this is configurable.) The distinction from the plain old "EDIT" action was needed as some parts of the code only care whether the page content model is editable and others care whether the active user can edit.

Aug 27 2019, 9:01 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), good first task
Niedzielski closed T230860: Avoid hyphenation in URLs that span multiple lines as Resolved.

LGTM. Tested on https://en.m.wikipedia.beta.wmflabs.org/wiki/User:ShreyasMinocha/URL_Hyphenation_Demo?useskin=minerva on an emulated device.

Aug 27 2019, 7:11 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MinervaNeue
Niedzielski reopened T206358: Request Sauce Labs access for niedzielski as "Open".

@zeljkofilipin, I'm getting "Your trial period has ended. Upgrade now..." messages again :[ Can you take a look?

Aug 27 2019, 7:07 PM · Release-Engineering-Team-TODO
Niedzielski added a comment to T231054: Disabling the recent changes highlighting feature on Minerva.

From @Jdrewniak: what happens if we just disable the RC filter ResourceLoader module?

Aug 27 2019, 4:31 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Advanced Mobile Contributions
Niedzielski updated the task description for T231206: Turn on AMC outreach modal.
Aug 27 2019, 4:29 PM · Wikimedia-Site-requests, Advanced Mobile Contributions, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1)
Niedzielski added a comment to T226562: AMC - display labels for toolbar actions on larger screens.

Maybe we can start by only showing the labels at maximum width. Another option mentioned was show the labels below the icons so there's more room for wrapping.

Aug 27 2019, 4:20 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Patch-For-Review, Advanced Mobile Contributions
Niedzielski added a comment to T230034: [AMC] Menu handle has no active state.
.toggle-list__checkbox:checked + .toggle-list__toggle {
	outline: 0;
	background: @colorGray14;
}
Aug 27 2019, 2:12 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions

Aug 26 2019

Niedzielski placed T231014: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode" up for grabs.

Visit http://localhost:8181/wiki/Special:History/Foo?action=history on a mobile device.

@pmiazga and I are no longer able to reproduce this issue locally with or without the patch.

Aug 26 2019, 6:48 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Wikimedia-production-error
Niedzielski updated the task description for T231014: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode".
Aug 26 2019, 6:44 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Wikimedia-production-error
Niedzielski added a comment to T230034: [AMC] Menu handle has no active state.

Ok, I think we want something like this then:

Aug 26 2019, 6:11 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), Accessibility, Advanced Mobile Contributions
Niedzielski claimed T231014: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > AMC.UserMode".
Aug 26 2019, 5:18 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend, Wikimedia-production-error
Niedzielski reassigned T230033: [ICONS] Increase touch targets from 40x40 to 44x44 from Nirzar to alexhollender.

@Nirzar, please weigh in on Design's requirements when you can.

Back to @alexhollender.

Aug 26 2019, 5:08 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Readers-Web-Backlog (Kanbanana-2019-20-Q2), MobileFrontend, Accessibility, Advanced Mobile Contributions
Niedzielski updated the task description for T226125: Updates to notifications container on mobile to make it more consistent with desktop.
Aug 26 2019, 4:03 PM · User-Jdlrobson, Growth-Team, Notifications, Readers-Web-Backlog (Design), Patch-For-Review
Niedzielski updated the task description for T226125: Updates to notifications container on mobile to make it more consistent with desktop.
Aug 26 2019, 4:02 PM · User-Jdlrobson, Growth-Team, Notifications, Readers-Web-Backlog (Design), Patch-For-Review
Niedzielski claimed T206265: Bug: Section edit links should be hidden for blocked users.
Aug 26 2019, 3:53 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), good first task
Niedzielski moved T206265: Bug: Section edit links should be hidden for blocked users from Ready for Development to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 26 2019, 3:52 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), MobileFrontend, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), good first task
Niedzielski added a comment to T231205: Add shadow to nav menu drawer.

@alexhollender, should we update the notification drawer shadow?

Aug 26 2019, 3:07 PM · MobileFrontend, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Google-Code-in-2019, good first task

Aug 23 2019

Niedzielski moved T225535: Notifications tray (mobile) - design refinements from Doing to Needs Analysis on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 23 2019, 6:43 PM · Readers-Web-Backlog, Growth-Team, Notifications
Niedzielski placed T225535: Notifications tray (mobile) - design refinements up for grabs.

I've been poking around in the Echo extension which I haven't developed in previously. These are my recommendations for how to proceed with this task but I'm unsure if the changes are wanted or if we're the best team for them given component responsibilities:

Aug 23 2019, 6:42 PM · Readers-Web-Backlog, Growth-Team, Notifications
Niedzielski added a comment to T219434: No popup is shown when quickly hovering the same link twice.

Thanks @Lea_WMDE, @WMDE-Fisch, and @thiemowmde!

Aug 23 2019, 4:35 PM · Reference Previews, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews
Niedzielski moved T219434: No popup is shown when quickly hovering the same link twice from Blocked on Others to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Aug 23 2019, 2:29 PM · Reference Previews, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews
Niedzielski reassigned T219434: No popup is shown when quickly hovering the same link twice from thiemowmde to Edtadros.
Aug 23 2019, 2:29 PM · Reference Previews, Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews