@Jdrewniak what you have seems like the correct behavior to me. Of course, I'm not a designer. It might look even better if you always keep the width the same (and remove the x offset) regardless of the thumbnail dimensions so that the image can be centered. I tried using preserveAspectRatio on svg > image but couldn't quickly get it to behave like object-fit: cover for newer browsers.
The issue is fixed although the infrastructure could still be improved to detect this problem in the future.
Wed, Apr 18
@Jdlrobson, it looks like there's an open question in code review as to how to proceed. Should we split this task so that the original tracks the revert and the split tracks the proper fix?
None of the developers who pointed this task have done this before but it looks like there's some examples available in the MediaWiki Code Search and GitHub search. We are concerned there may be hidden complexities so whoever implements this should review the examples and add Gergo to the patch for review to make sure we use the hook properly.
@Niedzielski to add AC and QA points. Primary objective is to create a common popup container.
Here's the latest report:
Tue, Apr 17
@ovasileva this is only a visual issue. The functionality works fine; pages can be added or removed from the watchlist.
Mon, Apr 16
I tried about 50 links and it seems to work. Thanks (and thanks for keeping a debugging record) @Mholloway!!
Thanks @Mholloway. This task is specific to the Barack Obama page. The page summary issue is in T192287 and occurs on certain summary responses (all happened to be found on page previews linked from the Dog page).
Could the summary endpoint issue be a network or caching problem related to this task? I was wondering because it seems like the Node.js service is issuing a request to 10.68.19.128 which fails with EHOSTUNREACH. I've opened T192287 to track this issue separately but please merge it back into this if I'm mistaken. /cc @bearND @Mholloway
I think this task is still being worked on but in case it helps, here's another report from the Obama page this morning:
Fri, Apr 13
Thanks so much @mobrovac!! Feel free to do whatever you want to the patches and let us know if help is needed. Thanks again!
Thu, Apr 12
This is still an issue:
Perhaps it's best to decline for now and we can open this later as needed.
Since we've already deployed to dewiki and will soon deploy to enwiki, have we missed the window for this task? It seems worse to initially enable it for everyone and then turn it off for many people.
Wed, Apr 11
@Jdlrobson, there's more to it than that but if you're really curious, I'm happy to chat in depth.
Over to you, @ABorbaWMF. Please test this on the beta cluster: https://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page.
I think so too!
Tue, Apr 10
In short: don't make a watchlist request for pages that are known to be missing.
Looks good except for IE 11. This is probably a separate issue. I only see this on IE11. It is not present on Chrome, Edge, Opera, or Firefox.
Just to confirm, the issue here is that the settings dialog is centered on the upper left corner?
Fri, Apr 6
Thanks @ABorbaWMF. That gif was meant to be informational and may or may not be useful since I think all the testing can be done as a user. Testing for this is pretty much just a run through of all the popups UI. Something like:
Thanks @Jdlrobson. Since the user may have their preference set to show the UI in English / LTR, I've updated the URL and removed this step.
Thu, Apr 5
This is related to T190613.
Wed, Apr 4
I confirm VirtualPageView events are received on deployment-eventlog05 from the beta cluster regardless of DNT settings for Chrome v65.0.3325.181 on Ubuntu v17.10 64b and Firefox v59.0.2.
@Jdrewniak to review.
@ABorbaWMF, the result of this task in itself should not be especially user visible. Please just generally verify that page previews appear to be working. Thank you!
@Jhernandez thank you!
Tue, Apr 3
Hey @mobrovac. We're making final plans for the current quarter. Any idea when we should expect a place for the Proton production server to be available? I'm happy to continue the patches we worked on with @Pchelolo or clarify any ambiguities. Let me know how I can help you help us! Thank you! /cc @ovasileva @thcipriani
Mon, Apr 2
@Niedzielski to review.
Thu, Mar 29
@Jdlrobson will deploy Monday.
Wed, Mar 28
@TheDJ, this is a Minerva-specific issue. Please see https://en.wikipedia.org/wiki/Henry_VIII_of_England?useskin=minerva.