Niedzielski (sniedzielski)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2015, 9:18 PM (149 w, 4 d)
Availability
Available
IRC Nick
niedzielski
LDAP User
Unknown
MediaWiki User
Niedzielski

Recent Activity

Fri, Feb 23

Mholloway awarded T188065: JavaScript development in the Wikimedia Page Library a Like token.
Fri, Feb 23, 2:34 PM · Wikimedia-Hackathon-2018
Niedzielski updated the task description for T188065: JavaScript development in the Wikimedia Page Library.
Fri, Feb 23, 2:28 PM · Wikimedia-Hackathon-2018
Niedzielski added a comment to T176759: Infobox rendering could be better.

@Mholloway, thanks!

Fri, Feb 23, 1:44 PM · wikimedia-page-library, Android-app-feature-UX-Debt, Wikipedia-Android-App-Backlog
Niedzielski created T188065: JavaScript development in the Wikimedia Page Library.
Fri, Feb 23, 2:30 AM · Wikimedia-Hackathon-2018
Niedzielski updated subscribers of T164616: Verify WebView image loading doesn't occur prior to a lazy load transform (lazy load images).

@Mhurd, I think you resolved this task a few months back. Can we close this?

Fri, Feb 23, 2:13 AM · Wikipedia-Android-App-Backlog, wikimedia-page-library, Spike
Niedzielski placed T174259: Dark theme makes some blank spaces over formulas, making them unreadable up for grabs.
Fri, Feb 23, 2:09 AM · wikimedia-page-library, Wikipedia-Android-App-Backlog
Niedzielski closed T174259: Dark theme makes some blank spaces over formulas, making them unreadable as Resolved.

Thanks all for triaging and debugging this issue! Per @RHo's comment, I'm marking this task as resolved. Please reopen if I'm mistaken.

Fri, Feb 23, 2:09 AM · wikimedia-page-library, Wikipedia-Android-App-Backlog
Niedzielski closed T164322: Remove div overflow from Android as Resolved.

This appears to be complete per the above patches and absence of https://gerrit.wikimedia.org/r/plugins/gitiles/apps/android/wikipedia/+/master/www/js/transforms/setDivWidth.js.

Fri, Feb 23, 2:03 AM · Patch-For-Review, wikimedia-page-library-tshirt
Niedzielski closed T164322: Remove div overflow from Android, a subtask of T163839: Phase one: consolidate the JavaScript transforms and associated CSS, as Resolved.
Fri, Feb 23, 2:03 AM · wikimedia-page-library, Epic
Niedzielski changed the status of T176759: Infobox rendering could be better from Open to Stalled.

Unless there are some specific changes wanted, I think this needs input from design. I'm marking this stalled in the meanwhile.

Fri, Feb 23, 1:56 AM · wikimedia-page-library, Android-app-feature-UX-Debt, Wikipedia-Android-App-Backlog
Niedzielski added a comment to T185249: [BUG] Collapsed table headers shouldn't include coordinates or reference links.

@Mhurd, the associated PR was merged. Is this fixed?

Fri, Feb 23, 1:51 AM · iOS-app-v5.8.0-Manatee-On-A-Skateboard, wikimedia-page-library, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
Niedzielski closed T164789: Create an NPM account and publish a release as Resolved.

According to NPM, @Mhurd is successfully publishing releases.

Fri, Feb 23, 1:45 AM · wikimedia-page-library
Niedzielski added a comment to T179437: Split page library output by transform.

The Page Library now uses Webpack and splitting by output is now more straightforward. The transform outputs wanted can be generated by adding to the Webpack entry points:

Fri, Feb 23, 12:48 AM · wikimedia-page-library, Marvin

Thu, Feb 22

Niedzielski added a comment to T187821: Choose a server for the chromium-render service.

@ovasileva, this was discussed in today's Services sync. There are a couple options @mobrovac and @Pchelolo are thinking about but they need to get in touch with Ops (next week):

Thu, Feb 22, 9:43 PM · Readers-Web-Backlog, Services (watching), Proton, Operations
Niedzielski added a comment to T177219: [Spike 3hr] Determine how to store PDFs in order to get file size.

We talked with @Pchelolo and @mobrovac today. As I understand it, we have the following options:

Thu, Feb 22, 9:35 PM · Readers-Web-Kanbanana-Board, Spike, Readers-Web-Backlog, Proton, New-Readers
Niedzielski added a comment to T188043: Missing active state on touch for hyperlinks in article namespace on iOS devices.

This issue does not occur on a Google Pixel XL or Nexus 5X.

Thu, Feb 22, 9:28 PM · Readers-Web-Kanbanana-Board, MinervaNeue, Readers-Web-Backlog
Niedzielski reassigned T186227: Clean-up proton repository from Jdrewniak to Jhernandez.
Thu, Feb 22, 6:17 PM · Readers-Web-Kanbanana-Board, Proton, Readers-Web-Backlog
Niedzielski updated the task description for T173539: Abandon use of globals in MobileFrontend classes.
Thu, Feb 22, 4:56 PM · Patch-For-Review, MinervaNeue, Readers-Web-Kanbanana-Board, MobileFrontend (MobileFrontend.js), MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Readers-Web-Backlog
Niedzielski added a comment to T187955: Page preview shows icon instead of thumbnail.

The client should remove the assumption of having px- in the thumbnail URL.

This is fixed in https://gerrit.wikimedia.org/r/413282.

Thu, Feb 22, 12:31 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Readers-Web-Kanbanana-Board, Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), Page-Previews, Readers-Web-Backlog

Wed, Feb 21

Niedzielski added a comment to T187955: Page preview shows icon instead of thumbnail.

These images are coming back with a 404. When I visit an image (https://upload.wikimedia.org/wikipedia/commons/b/b2/228px-ristopherSinclair.jpg):

Wed, Feb 21, 10:49 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Readers-Web-Kanbanana-Board, Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), Page-Previews, Readers-Web-Backlog
Niedzielski added a project to T173539: Abandon use of globals in MobileFrontend classes: MinervaNeue.
Wed, Feb 21, 7:36 PM · Patch-For-Review, MinervaNeue, Readers-Web-Kanbanana-Board, MobileFrontend (MobileFrontend.js), MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Readers-Web-Backlog
Niedzielski added a comment to T177219: [Spike 3hr] Determine how to store PDFs in order to get file size.

Thanks @Jhernandez!

Wed, Feb 21, 7:08 PM · Readers-Web-Kanbanana-Board, Spike, Readers-Web-Backlog, Proton, New-Readers
Niedzielski added projects to T187916: Improve Page Issue modal: MobileFrontend, MinervaNeue.

For responsive web only, not desktop.

Wed, Feb 21, 6:40 PM · MinervaNeue, MobileFrontend, Design (RW-Design-Debt), Readers-Web-Backlog
Niedzielski added a comment to T165036: Refactor rendering code in src/renderer.js for readability and testability.

This is blocked on the outcome of our technical discussion tomorrow!

Wed, Feb 21, 6:17 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski removed a project from T187821: Choose a server for the chromium-render service: Readers-Web-Kanbanana-Board.
Wed, Feb 21, 6:16 PM · Readers-Web-Backlog, Services (watching), Proton, Operations
Niedzielski moved T165036: Refactor rendering code in src/renderer.js for readability and testability from Blocked on Others to To Do on the Readers-Web-Kanbanana-Board board.
Wed, Feb 21, 6:15 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski closed T187891: Beta cluster api.php never responds as Resolved.

Fixed! Thank you @thcipriani!

Wed, Feb 21, 5:17 PM · Release-Engineering-Team (Kanban), Readers-Web-Backlog (Tracking), Beta-Cluster-Infrastructure, Operations
Niedzielski claimed T173539: Abandon use of globals in MobileFrontend classes.
Wed, Feb 21, 4:56 PM · Patch-For-Review, MinervaNeue, Readers-Web-Kanbanana-Board, MobileFrontend (MobileFrontend.js), MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Readers-Web-Backlog
Niedzielski moved T173539: Abandon use of globals in MobileFrontend classes from Sprint+1 to Doing on the Readers-Web-Kanbanana-Board board.
Wed, Feb 21, 4:56 PM · Patch-For-Review, MinervaNeue, Readers-Web-Kanbanana-Board, MobileFrontend (MobileFrontend.js), MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Readers-Web-Backlog
Niedzielski added a comment to T182321: Show HTML summaries on cswiki.

Summarizing: @EddieGP's config change patch can be merged pending verification (see QA notes above) of the summary v1.3 rollout.

Wed, Feb 21, 4:38 PM · Readers-Web-Kanbanana-Board, Patch-For-Review, Reading-Infrastructure-Team-Backlog (Kanban), Wikimedia-Site-requests, Page-Previews, Readers-Web-Backlog
Niedzielski reassigned T181680: Allow rendering PDFs for mobile from ABorbaWMF to pmiazga.

Assigning to @pmiazga for fix.

Wed, Feb 21, 4:29 PM · Patch-For-Review, Services (watching), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Proton
Niedzielski reassigned T187173: Mobile diff warnings do not wrap properly from Jdrewniak to Jhernandez.
Wed, Feb 21, 4:26 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, Readers-Web-Backlog
Niedzielski added a comment to T187173: Mobile diff warnings do not wrap properly.

Assigning to @Jhernandez for insights into this approach and code review^^^

Wed, Feb 21, 4:26 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, Readers-Web-Backlog
Niedzielski moved T187173: Mobile diff warnings do not wrap properly from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Wed, Feb 21, 4:25 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Readers-Web-Kanbanana-Board, Easy, Readers-Web-Backlog
Niedzielski placed T186176: [Bug] URI decoding fails for unescaped percent up for grabs.
Wed, Feb 21, 4:25 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Proton, Readers-Web-Backlog
Niedzielski placed T187479: [bug] related articles /sometimes/ appear in wrong place on articles up for grabs.
Wed, Feb 21, 4:24 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, RelatedArticles, Readers-Web-Kanbanana-Board, Easy, Design (RW-Design-Debt), Readers-Web-Backlog
Niedzielski moved T187479: [bug] related articles /sometimes/ appear in wrong place on articles from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Wed, Feb 21, 4:24 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, RelatedArticles, Readers-Web-Kanbanana-Board, Easy, Design (RW-Design-Debt), Readers-Web-Backlog
Niedzielski moved T187821: Choose a server for the chromium-render service from To Triage to Tracking on the Readers-Web-Backlog board.
Wed, Feb 21, 3:14 PM · Readers-Web-Backlog, Services (watching), Proton, Operations
Niedzielski moved T187891: Beta cluster api.php never responds from To Triage to Tracking on the Readers-Web-Backlog board.
Wed, Feb 21, 3:14 PM · Release-Engineering-Team (Kanban), Readers-Web-Backlog (Tracking), Beta-Cluster-Infrastructure, Operations
Niedzielski updated the task description for T187891: Beta cluster api.php never responds.
Wed, Feb 21, 3:11 PM · Release-Engineering-Team (Kanban), Readers-Web-Backlog (Tracking), Beta-Cluster-Infrastructure, Operations
Niedzielski updated the task description for T187891: Beta cluster api.php never responds.
Wed, Feb 21, 3:10 PM · Release-Engineering-Team (Kanban), Readers-Web-Backlog (Tracking), Beta-Cluster-Infrastructure, Operations
Niedzielski created T187891: Beta cluster api.php never responds.
Wed, Feb 21, 3:09 PM · Release-Engineering-Team (Kanban), Readers-Web-Backlog (Tracking), Beta-Cluster-Infrastructure, Operations
Niedzielski added a project to T187804: Back to top button not appearing on some browsers: MinervaNeue.
Wed, Feb 21, 1:49 PM · MinervaNeue, Readers-Web-Backlog, Readers-Web-Kanbanana-Board, Patch-For-Review
Niedzielski closed T186338: The production server configuration is outdated as Resolved.

The tests still pass and there's no additional QA needed on this.

Wed, Feb 21, 1:47 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Proton, Readers-Web-Backlog
Niedzielski closed T186338: The production server configuration is outdated, a subtask of T178071: [EPIC] Complete the First Deployment tutorial/checklist for the trial render service, as Resolved.
Wed, Feb 21, 1:47 PM · Readers-Web-Kanbanana-Board, Epic, Readers-Web-Backlog, Proton, Electron-PDFs

Tue, Feb 20

Niedzielski added a project to T187479: [bug] related articles /sometimes/ appear in wrong place on articles: RelatedArticles.
Tue, Feb 20, 8:42 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, RelatedArticles, Readers-Web-Kanbanana-Board, Easy, Design (RW-Design-Debt), Readers-Web-Backlog
Niedzielski added a comment to T187479: [bug] related articles /sometimes/ appear in wrong place on articles.

@ovasileva pulling this into the sprint from sprint+1 because all other tasks are claimed

Tue, Feb 20, 7:57 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, RelatedArticles, Readers-Web-Kanbanana-Board, Easy, Design (RW-Design-Debt), Readers-Web-Backlog
Niedzielski claimed T187479: [bug] related articles /sometimes/ appear in wrong place on articles.
Tue, Feb 20, 7:56 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, RelatedArticles, Readers-Web-Kanbanana-Board, Easy, Design (RW-Design-Debt), Readers-Web-Backlog
Niedzielski moved T187479: [bug] related articles /sometimes/ appear in wrong place on articles from Sprint+1 to Doing on the Readers-Web-Kanbanana-Board board.
Tue, Feb 20, 7:56 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, RelatedArticles, Readers-Web-Kanbanana-Board, Easy, Design (RW-Design-Debt), Readers-Web-Backlog
Niedzielski updated subscribers of T187821: Choose a server for the chromium-render service.

@ovasileva, @phuedx this is in the sprint for tracking because T186748 is blocked on it

Tue, Feb 20, 7:53 PM · Readers-Web-Backlog, Services (watching), Proton, Operations
Niedzielski committed rMSCRe3d70089f102: Fix: return HTTP status 400 for bad URLs (authored by Niedzielski).
Fix: return HTTP status 400 for bad URLs
Tue, Feb 20, 7:52 PM
Niedzielski moved T186176: [Bug] URI decoding fails for unescaped percent from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Tue, Feb 20, 7:51 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Proton, Readers-Web-Backlog
Niedzielski closed T170807: Return promises from action thunks as Resolved.

We discussed this task in standup and believe to be resolved.

Tue, Feb 20, 7:02 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Easy, Technical-Debt, Page-Previews
Niedzielski added a subtask for T186748: New service request: chromium-render/deploy: T187821: Choose a server for the chromium-render service.
Tue, Feb 20, 6:59 PM · Patch-For-Review, Services (watching), Service-deployment-requests, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Proton, Operations, Electron-PDFs
Niedzielski added a parent task for T187821: Choose a server for the chromium-render service: T186748: New service request: chromium-render/deploy.
Tue, Feb 20, 6:59 PM · Readers-Web-Backlog, Services (watching), Proton, Operations
Niedzielski created T187821: Choose a server for the chromium-render service.
Tue, Feb 20, 6:58 PM · Readers-Web-Backlog, Services (watching), Proton, Operations
Niedzielski updated subscribers of T177219: [Spike 3hr] Determine how to store PDFs in order to get file size.

We discussed this task some today in grooming and a couple questions came up:

Tue, Feb 20, 6:36 PM · Readers-Web-Kanbanana-Board, Spike, Readers-Web-Backlog, Proton, New-Readers
Niedzielski added a comment to T151797: Explore creating an interface to check for emptiness of an object.

This utility's preferred home is in Core. From @pmiazga, example:

Tue, Feb 20, 5:51 PM · Need-volunteer, Easy, Technical-Debt (RW-Tech-Debt), Readers-Web-Backlog, MobileFrontend
Niedzielski moved T186176: [Bug] URI decoding fails for unescaped percent from To Do to Doing on the Readers-Web-Kanbanana-Board board.
Tue, Feb 20, 5:08 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Proton, Readers-Web-Backlog
Niedzielski committed rESCDdda92f62408c: Update: add Scap config (authored by Niedzielski).
Update: add Scap config
Tue, Feb 20, 4:22 PM
Niedzielski claimed T186176: [Bug] URI decoding fails for unescaped percent.

T181680: Allow rendering PDFs for mobile will change the erroneous line and so fixing this task is blocked on that

I believe this task is unblocked by https://gerrit.wikimedia.org/r/#/c/408573/ (merged) but this issue still seems to be occurring. I'm claiming to at least investigate, if not fix.

Tue, Feb 20, 4:12 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Proton, Readers-Web-Backlog
Niedzielski committed rMSCRe58c3adc11e5: Hygiene: remove unused endpoint configs (authored by Niedzielski).
Hygiene: remove unused endpoint configs
Tue, Feb 20, 4:08 PM
Niedzielski added a comment to T186338: The production server configuration is outdated.

@pmiazga, I asked Petr about combining the Scap3 and prod config but it seems to be necessary to keep them distinct for Puppet Hiera. (Sorry, I don't have any additional details.)

Tue, Feb 20, 2:08 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Proton, Readers-Web-Backlog

Sat, Feb 17

Liuxinyu970226 awarded T165036: Refactor rendering code in src/renderer.js for readability and testability a Love token.
Sat, Feb 17, 1:32 AM · Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Liuxinyu970226 awarded T165036: Refactor rendering code in src/renderer.js for readability and testability a Love token.
Sat, Feb 17, 1:32 AM · Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog

Fri, Feb 16

Niedzielski moved T165036: Refactor rendering code in src/renderer.js for readability and testability from Doing to Blocked on Others on the Readers-Web-Kanbanana-Board board.
Fri, Feb 16, 8:12 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski closed T179552: Set up Jenkins for chromium-render repository as Resolved.

Thanks @Jdrewniak!

Fri, Feb 16, 5:05 PM · Release-Engineering-Team (Kanban), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Continuous-Integration-Config, Proton
Niedzielski closed T179552: Set up Jenkins for chromium-render repository, a subtask of T181118: [EPIC] Build a Chromium-based PDF renderer service, as Resolved.
Fri, Feb 16, 5:04 PM · Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Proton, Epic
Niedzielski committed rMSCRee9b97c9da5e: Update: deploy configurations (authored by Niedzielski).
Update: deploy configurations
Fri, Feb 16, 5:03 PM
Niedzielski committed rMSCR4c91983c016a: Remove dependencies, use chromium instead (authored by hashar).
Remove dependencies, use chromium instead
Fri, Feb 16, 5:00 PM
Niedzielski committed rESCD7d6560550b31: Update: add Scap config (authored by Niedzielski).
Update: add Scap config
Fri, Feb 16, 4:37 PM
Niedzielski committed rESCDbc5245dc9d28: Update: add Scap config (authored by Niedzielski).
Update: add Scap config
Fri, Feb 16, 4:34 PM
Niedzielski reassigned T179552: Set up Jenkins for chromium-render repository from pmiazga to Jdrewniak.

@Jdrewniak, would you mind QAing this guy and signing it off? Basically, you submit a patch to the chromium-render repo and see that it passes or fails as expected. Additionally, you should see in the Jenkins logs explicit mention that Chromium download has been skipped! If you have _any_ trouble, please ping me! Thank you!

Fri, Feb 16, 4:28 PM · Release-Engineering-Team (Kanban), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Continuous-Integration-Config, Proton
Niedzielski moved T179552: Set up Jenkins for chromium-render repository from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board board.
Fri, Feb 16, 4:26 PM · Release-Engineering-Team (Kanban), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Continuous-Integration-Config, Proton

Thu, Feb 15

Niedzielski moved T179552: Set up Jenkins for chromium-render repository from Needs More Work to Needs Code Review on the Readers-Web-Kanbanana-Board board.
Thu, Feb 15, 9:06 PM · Release-Engineering-Team (Kanban), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Continuous-Integration-Config, Proton
Niedzielski reassigned T179552: Set up Jenkins for chromium-render repository from Niedzielski to pmiazga.
Thu, Feb 15, 9:06 PM · Release-Engineering-Team (Kanban), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Continuous-Integration-Config, Proton
Niedzielski added a comment to T179552: Set up Jenkins for chromium-render repository.

Thanks @hashar for getting those last couple patches across the finish line! @pmiazga, the final patch is here https://gerrit.wikimedia.org/r/#/c/410621/ and has been verified to run the tests successfully without downloading Chromium.

Thu, Feb 15, 9:00 PM · Release-Engineering-Team (Kanban), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Continuous-Integration-Config, Proton
Niedzielski moved T179552: Set up Jenkins for chromium-render repository from Blocked on Others to Needs More Work on the Readers-Web-Kanbanana-Board board.
Thu, Feb 15, 8:37 PM · Release-Engineering-Team (Kanban), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Continuous-Integration-Config, Proton
Niedzielski committed rMSCRa8c4e13a7620: Update: deploy configurations (authored by Niedzielski).
Update: deploy configurations
Thu, Feb 15, 7:10 PM
Niedzielski committed rMSCR594e80725e31: Update: add CHROME_BIN Puppeteer seam for CI tests (authored by Niedzielski).
Update: add CHROME_BIN Puppeteer seam for CI tests
Thu, Feb 15, 7:07 PM
Niedzielski assigned T186748: New service request: chromium-render/deploy to phuedx.
Thu, Feb 15, 6:11 PM · Patch-For-Review, Services (watching), Service-deployment-requests, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Proton, Operations, Electron-PDFs
Niedzielski moved T179552: Set up Jenkins for chromium-render repository from Doing to Blocked on Others on the Readers-Web-Kanbanana-Board board.
Thu, Feb 15, 12:16 AM · Release-Engineering-Team (Kanban), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Continuous-Integration-Config, Proton
Niedzielski moved T165036: Refactor rendering code in src/renderer.js for readability and testability from To Do to Doing on the Readers-Web-Kanbanana-Board board.
Thu, Feb 15, 12:16 AM · Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski committed rMSCRf8aae8e0be68: Fix: lint errors (authored by Niedzielski).
Fix: lint errors
Thu, Feb 15, 12:05 AM
Niedzielski committed rMSCRf8963d0fe0be: Hygiene: rename service name in configs (authored by Niedzielski).
Hygiene: rename service name in configs
Thu, Feb 15, 12:02 AM
Niedzielski committed rMSCRa6344e2ef4d8: Update: add CHROME_BIN Puppeteer seam for CI tests (authored by Niedzielski).
Update: add CHROME_BIN Puppeteer seam for CI tests
Thu, Feb 15, 12:00 AM

Wed, Feb 14

Niedzielski moved T165036: Refactor rendering code in src/renderer.js for readability and testability from Doing to To Do on the Readers-Web-Kanbanana-Board board.
Wed, Feb 14, 10:50 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Technical-Debt, Page-Previews, Readers-Web-Backlog
Niedzielski moved T179552: Set up Jenkins for chromium-render repository from Blocked on Others to Doing on the Readers-Web-Kanbanana-Board board.
Wed, Feb 14, 10:50 PM · Release-Engineering-Team (Kanban), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Continuous-Integration-Config, Proton
Niedzielski moved T178172: Create Puppet role and profile from Needs Code Review to Blocked on Others on the Readers-Web-Kanbanana-Board board.
Wed, Feb 14, 10:26 PM · Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Proton, Electron-PDFs
Niedzielski committed rESCD8045630282d0: Update: add Scap config (authored by Niedzielski).
Update: add Scap config
Wed, Feb 14, 10:10 PM
Niedzielski committed rESCDf7d6357e4b9b: Update: add Scap config (authored by Niedzielski).
Update: add Scap config
Wed, Feb 14, 9:43 PM
Niedzielski added a comment to T179552: Set up Jenkins for chromium-render repository.

I'm shuffling this over to blocked on our board since it needs releng review. Please check the patch out when you get a chance!

Wed, Feb 14, 9:40 PM · Release-Engineering-Team (Kanban), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Continuous-Integration-Config, Proton
Niedzielski moved T179552: Set up Jenkins for chromium-render repository from Needs Code Review to Blocked on Others on the Readers-Web-Kanbanana-Board board.
Wed, Feb 14, 9:38 PM · Release-Engineering-Team (Kanban), Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Patch-For-Review, Continuous-Integration-Config, Proton
Niedzielski closed T186127: [Bug] Requesting a nonexistent page generates a PDF instead of returning an HTTP response as Resolved.
Wed, Feb 14, 9:00 PM · Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Proton
Niedzielski moved T186127: [Bug] Requesting a nonexistent page generates a PDF instead of returning an HTTP response from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board board.
Wed, Feb 14, 8:59 PM · Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Proton
Niedzielski added a comment to T186127: [Bug] Requesting a nonexistent page generates a PDF instead of returning an HTTP response.

This appears correct: {"name":"HTTPError","message":"404","status":404,"details":"Article 'Book13242' not found"}. As discussed in code review, it is known that the message should probably replace the redundant details and bad parameters incorrectly produce a 404 response as well. e.g., http://localhost:3030/en.wikipedia.org/v1/pdf/Book/letterq1341e. Moving to sign off and resolving directly.

Wed, Feb 14, 8:59 PM · Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Proton
Niedzielski added a comment to T184793: Instrument page interactions.

If a preview can't be generated for a page, i.e. the "generic" preview is shown (defined as in the Popups schema), then no page interaction is recorded.

This seems like a valuable metric to record as a "missed pageview" of sorts.

Wed, Feb 14, 8:04 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Readers-Web-Kanbanana-Board, Page-Previews, Readers-Web-Backlog
Niedzielski claimed T186127: [Bug] Requesting a nonexistent page generates a PDF instead of returning an HTTP response.

@Niedzielski to QA.

Wed, Feb 14, 6:06 PM · Readers-Web-Kanbanana-Board, Readers-Web-Backlog, Proton
Niedzielski moved T186929: [wmf.20-regression] MinervaNeue - "Uncaught TypeError: Cannot convert undefined or null to object" when search for Special page from Needs triage to Triaged on the Mobile board.
Wed, Feb 14, 4:38 PM · Readers-Web-Backlog, Mobile, MinervaNeue, Regression
Niedzielski added a comment to T186929: [wmf.20-regression] MinervaNeue - "Uncaught TypeError: Cannot convert undefined or null to object" when search for Special page.

Possible duplicate of T186147.

Wed, Feb 14, 4:37 PM · Readers-Web-Backlog, Mobile, MinervaNeue, Regression