Page MenuHomePhabricator

Niedzielski (Stephen Niedzielski)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2015, 9:18 PM (209 w, 5 d)
Availability
Available
IRC Nick
niedzielski
LDAP User
Unknown
MediaWiki User
Niedzielski [ Global Accounts ]

Recent Activity

Sat, Apr 20

Niedzielski updated the task description for T206356: [Bug] Popups should avoid presentation in the natural reading direction.
Sat, Apr 20, 2:10 AM · Readers-Web-Backlog (Design), Page-Previews
Niedzielski updated the task description for T206356: [Bug] Popups should avoid presentation in the natural reading direction.
Sat, Apr 20, 2:09 AM · Readers-Web-Backlog (Design), Page-Previews
awight awarded Blog Post: mustache.js replaced with JavaScript template literals in Extension:Popups a Doubloon token.
Sat, Apr 20, 12:58 AM

Thu, Apr 18

Niedzielski added a comment to T214918: [[MediaWiki:Timeless-sitetitle]] should transclude {{int:}} instead of {{Mediawiki:}}.

I'm guessing but I think we want just plain {{SITENAME}}. It's listed on the magic words page. {{int:Sitetitle}} refers to MediaWiki:Sitetitle and that page is deleted.

Thu, Apr 18, 6:45 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Timeless, Patch-For-Review, I18n
Niedzielski created T221396: [Bug] BetaOptinPanel shown twice for nonexistent user pages.
Thu, Apr 18, 5:56 PM · MobileFrontend, Readers-Web-Backlog

Wed, Apr 17

Niedzielski created T221242: [Bug] [Beta] Lazily loaded references sometimes cannot be viewed.
Wed, Apr 17, 3:16 PM · MobileFrontend, Readers-Web-Backlog
Niedzielski awarded T221194: Search input of overlay is not tab-able, inaccessible by alternative input users a Love token.
Wed, Apr 17, 1:19 PM · Readers-Web-Backlog, Accessibility, MinervaNeue
Niedzielski added a project to T221194: Search input of overlay is not tab-able, inaccessible by alternative input users: Readers-Web-Backlog.
Wed, Apr 17, 1:19 PM · Readers-Web-Backlog, Accessibility, MinervaNeue

Tue, Apr 16

Niedzielski added a comment to T193077: Remove Page's View functionality.

Before writing any patches have a slack conversation outlining your plans to avoid the problems we've been hitting in our refactor work and ensure you have buy in. Make sure to share your work early and check in that everyone understands it.

Here's my initial plan of attack:

Tue, Apr 16, 8:36 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski added a project to T221137: Skin should reset SkinOptions on UserLogout action.: Advanced Mobile Contributions.

Tagging AMC since it's impacted too.

Tue, Apr 16, 7:54 PM · Advanced Mobile Contributions, Readers-Web-Backlog, MinervaNeue, Technical-Debt
Niedzielski updated subscribers of T214918: [[MediaWiki:Timeless-sitetitle]] should transclude {{int:}} instead of {{Mediawiki:}}.

Sorry for the dumb question on a broader topic. Do you know if we should favor {{int:Sitetitle}} or {{SITENAME}}? I see a bunch of references in MobileFrontend and elsewhere to the former but only Timeless appears to use the latter. We have a cool patch from @DannyS712 in MobileFrontend but I'm not sure which we should prefer.

Tue, Apr 16, 7:43 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Timeless, Patch-For-Review, I18n
Niedzielski moved T193077: Remove Page's View functionality from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Apr 16, 6:02 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski claimed T193077: Remove Page's View functionality.
Tue, Apr 16, 6:01 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski updated subscribers of T209377: Remove A/B test and launch to 100%.

NOTE: tentative deployment date April 30, 2019

@Tbayer, @cscott, @Addshore, @Gilles, @WMDE-leszek, @Smalyshev, @Tarrow, @CKoerner_WMF, @mpopov we're planning to complete the roll out of the "sameAs" page schema changes soon. Please comment if you have any concerns.

Tue, Apr 16, 5:58 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), SEO
Niedzielski created T221124: Entire search result element should be clickable.
Tue, Apr 16, 5:44 PM · MobileFrontend, Readers-Web-Backlog
Niedzielski added a comment to T220979: [Bug] Notification counts broken on mobile.

I think so, at least for now. T220511 shows a number but it's incorrect. The issue in this bug is that no alert is shown.

Tue, Apr 16, 2:04 PM · Notifications, Growth-Team, MobileFrontend, Readers-Web-Backlog

Mon, Apr 15

Niedzielski updated the task description for T220847: Refactor BetaOptInPanel to a class that extends View.
Mon, Apr 15, 8:04 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski renamed T220847: Refactor BetaOptInPanel to a class that extends View from Replace some usages of mfExtend to Refactor BetaOptInPanel to a class that extends View.
Mon, Apr 15, 8:03 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski closed T218653: Delete unneeded page-actions menu CSS/JS as Resolved.
Mon, Apr 15, 7:23 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Technical-Debt, MinervaNeue, MobileFrontend
Niedzielski updated the task description for T221024: Make actions menu sticky.
Mon, Apr 15, 6:26 PM · Advanced Mobile Contributions
Niedzielski added a parent task for T216073: Move lazily loaded references initialization from Skin to mobile.init.js: T220968: Redefine the responsibilities of Skin.js.
Mon, Apr 15, 5:52 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Tracking), Technical-Debt
Niedzielski added a subtask for T220968: Redefine the responsibilities of Skin.js: T216073: Move lazily loaded references initialization from Skin to mobile.init.js.
Mon, Apr 15, 5:52 PM · Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski added subtasks for T221022: Divide MobileFrontend component concerns: T220847: Refactor BetaOptInPanel to a class that extends View, T220849: Separate View code from SearchOverlay, T220850: Separate Toggler storage responsibilities, T220768: Split out isVisualEditorEnabled logic from editor overlay view code, T220770: Separate out events in EditorOverlay/EditorOverlayBase/VisualEditorOverlay, T207770: Split PageGateway, T220558: Remove cache from ImageGateway, T220862: Remove hideOnExitClick from ImageCarousel prototype, T220863: Remove `hideOnExitClick` from Overlay.js, T220865: Remove `Overlay.EVENT_EXIT` from Overlay.js, T220869: Remove `hasLoadError` instance variable/logic from Overlay/OverlayManager, T221004: Simplify MainMenu building in Minerva skin, T221007: Extract Echo handling from SkinMinerva class, T221012: Extract $skinOptions from SkinMinerva class, T220965: Decouple Watchstar from Toast and CtaDrawer, T220968: Redefine the responsibilities of Skin.js, T220969: Move getAndroidVersion() and getChromeVersion() into Browser.js.
Mon, Apr 15, 5:46 PM · Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski added a parent task for T207770: Split PageGateway: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:46 PM · Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog
Niedzielski added a parent task for T220558: Remove cache from ImageGateway: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:46 PM · Patch-For-Review, MobileFrontend, Technical-Debt, Readers-Web-Backlog
Niedzielski added a parent task for T220768: Split out isVisualEditorEnabled logic from editor overlay view code: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:46 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski added a parent task for T220770: Separate out events in EditorOverlay/EditorOverlayBase/VisualEditorOverlay: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:46 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski added a parent task for T220847: Refactor BetaOptInPanel to a class that extends View: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:46 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski added a parent task for T220849: Separate View code from SearchOverlay: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:46 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski added a parent task for T220850: Separate Toggler storage responsibilities: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:46 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski added a parent task for T220862: Remove hideOnExitClick from ImageCarousel prototype: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:46 PM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski added a parent task for T220863: Remove `hideOnExitClick` from Overlay.js: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:46 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski added a parent task for T220865: Remove `Overlay.EVENT_EXIT` from Overlay.js: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:46 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski added a parent task for T220869: Remove `hasLoadError` instance variable/logic from Overlay/OverlayManager: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:45 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski added a parent task for T220965: Decouple Watchstar from Toast and CtaDrawer: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:45 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski added a parent task for T220968: Redefine the responsibilities of Skin.js: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:45 PM · Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski added a parent task for T220969: Move getAndroidVersion() and getChromeVersion() into Browser.js: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:45 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski added a parent task for T221004: Simplify MainMenu building in Minerva skin: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:45 PM · Readers-Web-Backlog, MinervaNeue, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski added a parent task for T221007: Extract Echo handling from SkinMinerva class: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:45 PM · Growth-Team, Notifications, Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Niedzielski added a parent task for T221012: Extract $skinOptions from SkinMinerva class: T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:45 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Niedzielski created T221022: Divide MobileFrontend component concerns.
Mon, Apr 15, 5:42 PM · Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski placed T216418: AMC Navigation - overflow menu up for grabs.
Mon, Apr 15, 5:19 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Epic, Advanced Mobile Contributions
Niedzielski moved T216418: AMC Navigation - overflow menu from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Mon, Apr 15, 5:19 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Epic, Advanced Mobile Contributions
Niedzielski claimed T218653: Delete unneeded page-actions menu CSS/JS.
Mon, Apr 15, 5:09 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Technical-Debt, MinervaNeue, MobileFrontend
Niedzielski added a project to T220968: Redefine the responsibilities of Skin.js: Readers-Web-Backlog.
Mon, Apr 15, 4:31 PM · Readers-Web-Backlog, MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski added a comment to T220511: [Bug] Wrong number of notifications shown on initial edit.

Possibly affected by T220979.

Mon, Apr 15, 2:05 PM · MinervaNeue, Growth-Team, Notifications, Readers-Web-Backlog
Niedzielski created T220979: [Bug] Notification counts broken on mobile.
Mon, Apr 15, 2:00 PM · Notifications, Growth-Team, MobileFrontend, Readers-Web-Backlog

Sat, Apr 13

Niedzielski created T220889: User watchlist talk tab should show pages from all talk namespaces.
Sat, Apr 13, 7:22 PM · MobileFrontend, Readers-Web-Backlog

Fri, Apr 12

Niedzielski created T220850: Separate Toggler storage responsibilities.
Fri, Apr 12, 7:09 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski created T220849: Separate View code from SearchOverlay.
Fri, Apr 12, 6:57 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski created T220848: Remove context.js.
Fri, Apr 12, 6:45 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski created T220847: Refactor BetaOptInPanel to a class that extends View.
Fri, Apr 12, 6:39 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski created T220845: Consolidate singleton state.
Fri, Apr 12, 6:23 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski awarded T179361: Move MobileFrontend/Minerva's svg_check.sh script into a reusable, separate library a Love token.
Fri, Apr 12, 5:29 PM · Front-end-Standards-Group, Readers-Web-Backlog (Tracking), User-Jdlrobson, Release-Engineering-Team (Watching / External), MinervaNeue, Librarization

Thu, Apr 11

Niedzielski added a comment to T216418: AMC Navigation - overflow menu.

All feedback is addressed. Latest changes are up https://readers-web-stephen.wmflabs.org/wiki/User:Hello.

Thu, Apr 11, 8:27 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Epic, Advanced Mobile Contributions
Niedzielski added a comment to T220668: Regression: Download icon doesn't download images.

I can repro on emulated Android with sections collapsed on enwiki prod.

Thu, Apr 11, 5:12 PM · MinervaNeue, Regression, Readers-Web-Backlog
Niedzielski added a comment to T220668: Regression: Download icon doesn't download images.

Not sure what the heck I'm doing wrong but https://en.m.wikipedia.beta.wmflabs.org/wiki/Qatar shows the Wikipedia:New user landing page when I'm logged in and the Qatar page when I'm logged out:

Thu, Apr 11, 4:58 PM · MinervaNeue, Regression, Readers-Web-Backlog
Niedzielski added a comment to T220668: Regression: Download icon doesn't download images.

I tried a number of other pages including local development articles using the content proxy but they seem to be working too. I'm thinking that the most likely issue is either that you're hitting the parsimonious timeout of 3 seconds or an image is failing to download (errors are silently eaten). You may be able to verify the latter by examining the network requests issues after pressing the download PDF button.

Thu, Apr 11, 2:10 AM · MinervaNeue, Regression, Readers-Web-Backlog
Niedzielski added a comment to T220668: Regression: Download icon doesn't download images.

I tried to repro this on https://en.m.wikipedia.org/wiki/Barack_Obama but it seems to be working.

Thu, Apr 11, 1:54 AM · MinervaNeue, Regression, Readers-Web-Backlog

Wed, Apr 10

Niedzielski added a comment to T216418: AMC Navigation - overflow menu.

All feedback is addressed. Latest changes are up https://readers-web-stephen.wmflabs.org/wiki/User:Hello. Open questions on download icon behavior and toolbar layout to be discussed tomorrow.

Wed, Apr 10, 9:48 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Epic, Advanced Mobile Contributions
Niedzielski created T220644: Log in should be a top level action.
Wed, Apr 10, 7:10 PM · Readers-Web-Backlog (Design), MinervaNeue
Niedzielski created T220637: [Bug] Unexpected result set returned by Elasticsearch.
Wed, Apr 10, 5:29 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Discovery-Search, Elasticsearch, GeoData, Readers-Web-Backlog
Niedzielski added a comment to T220619: Inline remaining templates.

Nevermind-- I see you've added it to a related task!

Wed, Apr 10, 3:42 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend
Niedzielski added a comment to T220619: Inline remaining templates.
  • A deprecated flag is added to mediawiki.template.hogan to ensure existing users move to mediawiki.template.mustache

This seemed like a good idea to me. Was it intentional to remove it from the AC?

Wed, Apr 10, 3:41 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend

Tue, Apr 9

Niedzielski added a comment to T216418: AMC Navigation - overflow menu.

I've revised the images and scrolling behavior. The changes are most visible on user pages. E.g., https://readers-web-stephen.wmflabs.org/wiki/User:Hello.

Tue, Apr 9, 9:02 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Epic, Advanced Mobile Contributions
Niedzielski added a comment to T217298: Repurpose BetaOptinPanel as a Panel.

I've moved this to QA per my understanding of super-happy-dev-time discussion. @Jdlrobson, please punt back if you disagree.

Tue, Apr 9, 7:45 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Niedzielski moved T217298: Repurpose BetaOptinPanel as a Panel from Blocked on Others to Needs QA on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Tue, Apr 9, 7:43 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue
Niedzielski added a watcher for MobileFrontend (MobileFrontend and MinervaNeue architecture): Niedzielski.
Tue, Apr 9, 6:20 PM
Niedzielski added a comment to T220016: Extend and rename MobileWebMainMenuClickTracking schema.

Would track any UI you can click on a page in the main namespace. Nothing in search or watchlist. So maybe just top and secondary level UI?

Tue, Apr 9, 4:52 PM · Advanced Mobile Contributions, Readers-Web-Backlog
Niedzielski added a project to T218653: Delete unneeded page-actions menu CSS/JS: Technical-Debt.
Tue, Apr 9, 4:40 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Technical-Debt, MinervaNeue, MobileFrontend
Niedzielski renamed T220511: [Bug] Wrong number of notifications shown on initial edit from [Bug] Wrong number of notifications shown initially to [Bug] Wrong number of notifications shown on initial edit.
Tue, Apr 9, 2:30 PM · MinervaNeue, Growth-Team, Notifications, Readers-Web-Backlog
Niedzielski created T220511: [Bug] Wrong number of notifications shown on initial edit.
Tue, Apr 9, 2:30 PM · MinervaNeue, Growth-Team, Notifications, Readers-Web-Backlog

Mon, Apr 8

Niedzielski updated subscribers of T216418: AMC Navigation - overflow menu.

Per our discussion:

Mon, Apr 8, 11:04 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Epic, Advanced Mobile Contributions
Niedzielski changed the status of T207770: Split PageGateway from Stalled to Open.
Mon, Apr 8, 3:41 PM · Technical-Debt, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog
Niedzielski changed the status of T207770: Split PageGateway, a subtask of T195482: [EPIC] Review and refactor Minerva components, from Stalled to Open.
Mon, Apr 8, 3:41 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Epic, MobileFrontend, MinervaNeue

Thu, Apr 4

Niedzielski added a comment to T216418: AMC Navigation - overflow menu.

@alexhollender, still working through this but the following would help:

Thu, Apr 4, 10:06 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Epic, Advanced Mobile Contributions

Wed, Apr 3

Niedzielski added a comment to T192408: Page preview pokey not positioned correctly when moving cursor quickly across a link.

This may be improved or fixed by WMDE's work for T215194.

Wed, Apr 3, 9:08 PM · Readers-Web-Backlog (Design), Page-Previews
Niedzielski added a comment to T220025: Rename secondaryButton.mustache to notificationButton.mustache.

when Echo is not installed it can be used for other things (it falls back to a talk link).

Maybe out of scope for this task but do we need to support a non-Echo configuration?

Wed, Apr 3, 6:46 PM · MinervaNeue, Technical-Debt, Readers-Web-Backlog
Niedzielski updated the task description for T220025: Rename secondaryButton.mustache to notificationButton.mustache.
Wed, Apr 3, 6:35 PM · MinervaNeue, Technical-Debt, Readers-Web-Backlog
Niedzielski created T220025: Rename secondaryButton.mustache to notificationButton.mustache.
Wed, Apr 3, 6:34 PM · MinervaNeue, Technical-Debt, Readers-Web-Backlog
Niedzielski closed T208155: Main menu should be swipeable, a subtask of T158314: [EPIC] Mobile site should support swipe user interactions, as Invalid.
Wed, Apr 3, 6:02 PM · Readers-Web-Backlog (Design), MobileFrontend
Niedzielski closed T208155: Main menu should be swipeable as Invalid.

Sure, works for me.

Wed, Apr 3, 6:02 PM · Readers-Web-Backlog (Design), MinervaNeue
Niedzielski added a comment to T208155: Main menu should be swipeable.

Regarding iOS: on web browsers (Chrome, Safari, Firefox) swiping rightwards from the left-edge of the screen takes you to the previous page (i.e. it's a back button). This is also the behavior in many other apps.

Wed, Apr 3, 5:42 PM · Readers-Web-Backlog (Design), MinervaNeue
Niedzielski moved T217298: Repurpose BetaOptinPanel as a Panel from Needs Code Review to Blocked on Others on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
Wed, Apr 3, 5:06 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Tue, Apr 2

Volker_E awarded T206354: Menu and notifications drawers should slide over content a Love token.
Tue, Apr 2, 11:39 PM · Readers-Web-Backlog, MobileFrontend
Niedzielski added a comment to T206354: Menu and notifications drawers should slide over content.

This is part of the AMC effort and it's parent epic is marked high priority so it may be equally high.

Tue, Apr 2, 9:56 PM · Readers-Web-Backlog, MobileFrontend
Niedzielski merged T202934: [Bug] Page previews don't always appear when previous preview is quickly dismissed into T219434: No popup is shown when quickly hovering the same link twice.
Tue, Apr 2, 6:46 PM · WMDE-QWERTY-Sprint-2019-04-17, WMDE-QWERTY-Sprint-2019-04-03, Readers-Web-Backlog, Patch-For-Review, WMDE-QWERTY-Season-Sprint-2019-03-20, TCB-Team, Page-Previews
Niedzielski merged task T202934: [Bug] Page previews don't always appear when previous preview is quickly dismissed into T219434: No popup is shown when quickly hovering the same link twice.
Tue, Apr 2, 6:46 PM · Page-Previews, Readers-Web-Backlog
Niedzielski created T219917: [Bug] Control / middle-clicking search auto-completion results dismisses the results.
Tue, Apr 2, 6:44 PM · Readers-Web-Backlog, Wikimedia-Portals
Niedzielski added a comment to T211778: Hovering over a redlink should prompt the user to create the page.

Maybe a similar prompt could appear for citation needed as well? This might work well with Reference Previews.

Tue, Apr 2, 6:32 PM · Readers-Web-Backlog (Design), Page-Previews
Niedzielski updated the task description for T211778: Hovering over a redlink should prompt the user to create the page.
Tue, Apr 2, 6:31 PM · Readers-Web-Backlog (Design), Page-Previews
Niedzielski updated subscribers of T206248: Report all client-side JavaScript errors.

+Sam who I believe has a personal interest in client-side error reporting.

Tue, Apr 2, 6:29 PM · Readers-Web-Backlog
Niedzielski moved T187744: SocialProfile: Refactor UserRelationship class to be more object-oriented from Needs refactor to Test coverage on the Technical-Debt board.
Tue, Apr 2, 5:06 PM · Patch-For-Review, Technical-Debt, Social-Tools, SocialProfile
Niedzielski merged T206335: Separate Page into components and increase its code coverage into T193077: Remove Page's View functionality.
Tue, Apr 2, 3:54 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski merged task T206335: Separate Page into components and increase its code coverage into T193077: Remove Page's View functionality.
Tue, Apr 2, 3:54 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, Readers-Web-Backlog
Niedzielski updated the task description for T193077: Remove Page's View functionality.
Tue, Apr 2, 3:54 PM · Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski updated subscribers of T189167: How should we deal with events in MobileFrontend's JS?.

There's related confusion on which event buses we should use for which purpose too. For example:

Tue, Apr 2, 3:37 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski updated subscribers of T209295: [EPIC] Enable WebClientError on production.

Adding @phuedx who I think has a personal interest in client side error reporting. Please feel free to ignore otherwise.

Tue, Apr 2, 3:32 PM · Epic, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog
Niedzielski closed T202739: Add QUnit linting rules to Popups, Minerva, and MobileFrontend as Resolved.

This seems to have been completed entirely by @Esanders. I'm marking it resolved. Thanks @Esanders!!

Tue, Apr 2, 3:29 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt, MinervaNeue, Page-Previews, Readers-Web-Backlog
Niedzielski closed T217805: [Bug] Expanded sections not persisted as Invalid.

The section persistence will only work if you are on a mobile resolution and will get confused if you resizethe window.

I didn't know.

Tue, Apr 2, 2:44 PM · Readers-Web-Backlog (Design), MobileFrontend