Niedzielski (Stephen Niedzielski)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2015, 9:18 PM (200 w, 6 d)
Availability
Available
IRC Nick
niedzielski
LDAP User
Unknown
MediaWiki User
Niedzielski [ Global Accounts ]

Recent Activity

Wed, Feb 13

Niedzielski added a comment to T214658: Separate Lazy loading code from Skin.js.

> The acceptance criteria says We will add test coverage for the Skin class but Skin.js has no coverage.
Many tests were added for lazy image loading but Skin itself is still not especially testable. I'll look into this.

@Jdlrobson, per your AC I've taken a closer look at Skin and I don't think it will be the best use of time to write tests for it. Part of the reason is that Skin does not provide many seams and it modifies the page's HTML. I'm thinking at the end of it we would have similar feelings as we did for CtaDrawer.test.js. It's only about 140 lines but look at what we're actually validating:

Wed, Feb 13, 9:30 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Niedzielski created T216073: Move lazily loaded references to mobile.init.js.
Wed, Feb 13, 8:58 PM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Tracking), Technical-Debt
Niedzielski added a comment to T214658: Separate Lazy loading code from Skin.js.

Last acceptance criteria says that we will remove usage of the jQuery lib, but the jQuery is still required for Deferreds and declaring types for function params, and attaching eventListeners.

jQuery is the underlying implementation for util.Deferred() which lazyImageLoader uses. lazyImageLoader has no direct jQuery dependency. Swapping out the underlying util implementation for Promises or a polyfill is out of scope.

Wed, Feb 13, 8:27 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Niedzielski created T216063: [Bug] Many ReadingDepth validation errors logged.
Wed, Feb 13, 7:37 PM · Analytics, Readers-Web-Backlog

Tue, Feb 12

Niedzielski added a comment to T213696: Sample by title in QuickSurvey.

This is an example configuration currently supported: https://www.mediawiki.org/wiki/Extension:QuickSurveys#Configuration.

Tue, Feb 12, 5:56 PM · Readers-Web-Backlog, QuickSurveys, Research
Niedzielski added a comment to T215477: Tag Thanks actions with AMC tag.

onExtensionThanksLogEntryTagCreate

Sorry, coming into this discussion a little late. Can this be generalized to any tag and be a change in Core instead? Something like onExtensionLogEntryTagCreate()?

Tue, Feb 12, 5:14 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions, Thanks, Growth-Team
Niedzielski added a comment to T215088: Update page performance tests to use null banner parameter.

@AndyRussG, do you think it would be possible to check the headers in CentralNotice.hooks.php? When a banner header with a value of null is set, maybe we don't call $out->addModules( 'ext.centralNotice.startUp' );. This would disable the CentralNotice banner JavaScript from executing.

Tue, Feb 12, 3:37 PM · Performance-Team, Readers-Web-Backlog
Niedzielski added a subtask for T215909: Use shorthand properties: T202746: Enable babel transpiling in MobileFrontend.
Tue, Feb 12, 3:00 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski added a parent task for T202746: Enable babel transpiling in MobileFrontend: T215909: Use shorthand properties.
Tue, Feb 12, 3:00 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Niedzielski created T215909: Use shorthand properties.
Tue, Feb 12, 2:59 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt

Mon, Feb 11

Niedzielski added a comment to T204627: Popups: Double pokey on some page preview pop-ups due to SVG mask being larger than thumbnail.

I don't know if this is the same issue or not (it goes back at least as far as StoryPops 30c9de1) but I see pretty bad double pokeys in the StoryPops "RTL thumbnails" section:

Mon, Feb 11, 11:06 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Audiences-QA, Design, Page-Previews
Niedzielski moved T214658: Separate Lazy loading code from Skin.js from Needs More Work to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mon, Feb 11, 9:56 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Niedzielski placed T208915: MobileFrontend modules: Cleanup some deprecation calls up for grabs.
Mon, Feb 11, 9:48 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski moved T208915: MobileFrontend modules: Cleanup some deprecation calls from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mon, Feb 11, 9:48 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski added a comment to T205127: Memory consumption on Wikipedia pages running in background tabs grows as other pages are opened.

@Jdlrobson, I can reproduce my earlier findings on Ubuntu Chromium v71.0.3578.98:

Mon, Feb 11, 8:14 PM · Readers-Web-Backlog (Tracking), Performance-Team (Radar), Page-Previews, Growth-Team
Niedzielski closed T202746: Enable babel transpiling in MobileFrontend as Resolved.
Mon, Feb 11, 7:39 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Niedzielski closed T202746: Enable babel transpiling in MobileFrontend, a subtask of T94086: [EPIC] Migrate MobileFrontend templates from hogan to mustache / Use template transpiler, as Resolved.
Mon, Feb 11, 7:39 PM · Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog, Epic
Niedzielski closed T202746: Enable babel transpiling in MobileFrontend, a subtask of T195475: [EPIC] Automate asset bundling in MobileFrontend, as Resolved.
Mon, Feb 11, 7:39 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Readers-Web-Kanbanana-Board-Old, User-Jdlrobson, Epic, MobileFrontend, MinervaNeue
Niedzielski updated the task description for T202746: Enable babel transpiling in MobileFrontend.
Mon, Feb 11, 7:39 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Niedzielski placed T211724: [Spike, 8hrs] Discuss OO.EventEmitter usage for Views up for grabs.

We discussed this in super happy dev time. Removing myself as assignee.

Mon, Feb 11, 6:57 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Spike, Technical-Debt (RW-Tech-Debt), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski updated the task description for T215808: Replace vars with const and let.
Mon, Feb 11, 6:34 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski claimed T202746: Enable babel transpiling in MobileFrontend.
Mon, Feb 11, 6:03 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Niedzielski updated the task description for T202756: Enable tree-shaking.
Mon, Feb 11, 5:04 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Niedzielski updated the task description for T215814: Replace anonymous functions with arrow functions.
Mon, Feb 11, 4:27 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski added a parent task for T202746: Enable babel transpiling in MobileFrontend: T215814: Replace anonymous functions with arrow functions.
Mon, Feb 11, 4:09 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Niedzielski added a subtask for T215814: Replace anonymous functions with arrow functions: T202746: Enable babel transpiling in MobileFrontend.
Mon, Feb 11, 4:09 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski created T215814: Replace anonymous functions with arrow functions.
Mon, Feb 11, 4:09 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski updated the task description for T215808: Replace vars with const and let.
Mon, Feb 11, 4:07 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski updated the task description for T215808: Replace vars with const and let.
Mon, Feb 11, 4:02 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski added a subtask for T215811: Replace string concatenation with ES6 template literals: T202746: Enable babel transpiling in MobileFrontend.
Mon, Feb 11, 3:58 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski added a parent task for T202746: Enable babel transpiling in MobileFrontend: T215811: Replace string concatenation with ES6 template literals.
Mon, Feb 11, 3:58 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Niedzielski edited projects for T215808: Replace vars with const and let, added: MobileFrontend (MobileFrontend and MinervaNeue architecture); removed MobileFrontend.
Mon, Feb 11, 3:57 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski created T215811: Replace string concatenation with ES6 template literals.
Mon, Feb 11, 3:56 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski edited projects for T215806: Replace Common.js requires and module.exports with ECMAScript imports and exports, added: MobileFrontend (MobileFrontend and MinervaNeue architecture); removed MobileFrontend.
Mon, Feb 11, 3:51 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski edited projects for T215806: Replace Common.js requires and module.exports with ECMAScript imports and exports, added: MobileFrontend; removed MobileFrontend (MobileFrontend and MinervaNeue architecture).
Mon, Feb 11, 3:51 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski edited projects for T215808: Replace vars with const and let, added: MobileFrontend; removed MobileFrontend (MobileFrontend and MinervaNeue architecture).
Mon, Feb 11, 3:51 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski updated the task description for T215808: Replace vars with const and let.
Mon, Feb 11, 3:46 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski added a subtask for T215808: Replace vars with const and let: T202746: Enable babel transpiling in MobileFrontend.
Mon, Feb 11, 3:45 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski added a parent task for T202746: Enable babel transpiling in MobileFrontend: T215808: Replace vars with const and let.
Mon, Feb 11, 3:45 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Niedzielski created T215808: Replace vars with const and let.
Mon, Feb 11, 3:45 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Technical-Debt
Niedzielski added a parent task for T202746: Enable babel transpiling in MobileFrontend: T215806: Replace Common.js requires and module.exports with ECMAScript imports and exports.
Mon, Feb 11, 3:33 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Niedzielski added a subtask for T215806: Replace Common.js requires and module.exports with ECMAScript imports and exports: T202746: Enable babel transpiling in MobileFrontend.
Mon, Feb 11, 3:33 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski created T215806: Replace Common.js requires and module.exports with ECMAScript imports and exports.
Mon, Feb 11, 3:32 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski added a subtask for T202756: Enable tree-shaking: T202746: Enable babel transpiling in MobileFrontend.
Mon, Feb 11, 3:12 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Niedzielski added a parent task for T202746: Enable babel transpiling in MobileFrontend: T202756: Enable tree-shaking.
Mon, Feb 11, 3:12 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue

Fri, Feb 8

Niedzielski added a comment to T211603: [Bug] Bad tracking on edit abort.

This still seems to be an issue:

Fri, Feb 8, 4:27 PM · Growth-Team (Current Sprint), Readers-Web-Backlog (Tracking), MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, MobileFrontend
Niedzielski added a comment to T215088: Update page performance tests to use null banner parameter.

Thanks, @AndyRussG!! I'll assign this to @Peter on Thursday when the train arrives on enwiki.

Fri, Feb 8, 2:57 PM · Performance-Team, Readers-Web-Backlog

Thu, Feb 7

Niedzielski added a comment to T215536: Regression: Nested references do not work.

@Jdlrobson, sorry for the hassle but I'm glad it's fixed

Thu, Feb 7, 10:54 PM · MinervaNeue, Regression, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Niedzielski placed T202746: Enable babel transpiling in MobileFrontend up for grabs.
Thu, Feb 7, 8:05 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Niedzielski claimed T202746: Enable babel transpiling in MobileFrontend.
Thu, Feb 7, 6:21 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture), User-Jdlrobson, MinervaNeue
Niedzielski added a comment to T215088: Update page performance tests to use null banner parameter.

Thanks, @Peter! I'll assign this to you when the dependent patch, T215086, is merged!

Thu, Feb 7, 2:37 PM · Performance-Team, Readers-Web-Backlog

Wed, Feb 6

Niedzielski created T215469: [Bug] Closing editor overlay shows loading spinner indefinitely.
Wed, Feb 6, 9:41 PM · Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), Editing-team, Patch-For-Review, Regression, MobileFrontend
Niedzielski triaged T214658: Separate Lazy loading code from Skin.js as Normal priority.
Wed, Feb 6, 7:11 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Niedzielski awarded T215449: Re-parent the OOjs repos so that regular `wmf` LDAP users can merge code a Like token.
Wed, Feb 6, 7:08 PM · Patch-For-Review, OOUI, OOjs-Router, OOjs, Gerrit
Niedzielski claimed T214658: Separate Lazy loading code from Skin.js.
Wed, Feb 6, 6:16 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Niedzielski added a comment to T215420: Quickly moving and hovering links hinders popup creation.

I think this is a duplicate of T202934.

Wed, Feb 6, 5:51 PM · Readers-Web-Backlog (Design), Patch-For-Review, Page-Previews, Reference Previews, TCB-Team
Niedzielski awarded T211784: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects a Love token.
Wed, Feb 6, 4:50 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, JavaScript, Continuous-Integration-Config
Niedzielski added a comment to T215088: Update page performance tests to use null banner parameter.

@Peter, we monitor the Facebook and Barack Obama pages on both desktop and mobile.

Wed, Feb 6, 3:02 PM · Performance-Team, Readers-Web-Backlog
Niedzielski added a comment to T214861: Reference popups not working with unexpected URL parameters.

@Niedzielski do you know if there's a reason for that getTitle() does not return a valid title when there are other parameters in the link URL than title=?

I do not know. There's a test case for multiple query parameters but no explanation. Perhaps, it's to avoid showing previews for any usage of the action API. E.g., https://en.wikipedia.org/w/index.php?title=Barack_Obama&action=history.

Wed, Feb 6, 2:56 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Reference Previews, TCB-Team

Tue, Feb 5

Niedzielski closed T214955: [REGRESSION] settings missing from mobile menu as Resolved.

This appears to be fixed on the beta cluster:

Tue, Feb 5, 6:52 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Regression, Patch-For-Review
Niedzielski moved T211724: [Spike, 8hrs] Discuss OO.EventEmitter usage for Views from Needs Code Review to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Feb 5, 6:14 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Spike, Technical-Debt (RW-Tech-Debt), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski claimed T214955: [REGRESSION] settings missing from mobile menu.
Tue, Feb 5, 6:08 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Regression, Patch-For-Review
alexhollender awarded T213336: Regression: Mobile gallery loading spinner appears on left instead of centered a Love token.
Tue, Feb 5, 5:40 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Regression, MobileFrontend
Niedzielski added a comment to T214049: Every Drawer has a shield for catching clicks.

Note: drawer contents can scroll.

Tue, Feb 5, 5:40 PM · MobileFrontend, Readers-Web-Backlog
Niedzielski added a comment to T214724: Remove AMC Article/Talk tabs from Main page.

There's some discussion about whether it would be better to hide the tabs in CSS or never send the HTML in the first place. The benefit of the former is the change is made only to presentation. The benefit of the latter is no possible confusion for screen readers and improved bandwidth.

Tue, Feb 5, 5:12 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Niedzielski added a comment to T214724: Remove AMC Article/Talk tabs from Main page.

rootpage_MainPage could be used to distinguish the main page in CSS. There is also a main page stylesheet.

Tue, Feb 5, 5:05 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
Niedzielski moved T208915: MobileFrontend modules: Cleanup some deprecation calls from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Feb 5, 4:01 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski claimed T208915: MobileFrontend modules: Cleanup some deprecation calls.
Tue, Feb 5, 4:01 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Mon, Feb 4

Niedzielski created T215197: [Bug] References previews not shown for some URLs.
Mon, Feb 4, 8:01 PM · Reference Previews, Readers-Web-Backlog
Niedzielski renamed T215195: [Bug] Hovering over references in reference previews dismisses dialog from [Bug] Hovering over references in reference previews dismiss dialog to [Bug] Hovering over references in reference previews dismisses dialog.
Mon, Feb 4, 7:52 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Readers-Web-Backlog (Tracking), Reference Previews
Niedzielski created T215195: [Bug] Hovering over references in reference previews dismisses dialog.
Mon, Feb 4, 7:51 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Readers-Web-Backlog (Tracking), Reference Previews
Niedzielski created T215194: [Bug] Pointer is incorrectly aligned for some references.
Mon, Feb 4, 7:46 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, Page-Previews, WMDE-QWERTY-Sprint-2019-02-06, Readers-Web-Backlog (Tracking), Reference Previews
Niedzielski renamed T212371: Separate page issue parsing from pageIssues.js from [Analysis] Separate page issue parsing from pageIssues.js to Separate page issue parsing from pageIssues.js.
Mon, Feb 4, 6:43 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog, Technical-Debt, MinervaNeue, Page-Issue-Warnings
Niedzielski placed T212371: Separate page issue parsing from pageIssues.js up for grabs.

I submitted a few hygiene patches while analyzing this. In combination with T212376, I think these changes are adequate. The page issues code could still use some big improvements, but the low hanging fruit has been plucked. If there are no objections, I advise that the outstanding patches be considered to resolve both T212371 and T212376.

Mon, Feb 4, 6:42 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog, Technical-Debt, MinervaNeue, Page-Issue-Warnings
Niedzielski claimed T211724: [Spike, 8hrs] Discuss OO.EventEmitter usage for Views.

Added discuss bullet to next super happy dev time.

Mon, Feb 4, 6:21 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Spike, Technical-Debt (RW-Tech-Debt), MobileFrontend (MobileFrontend and MinervaNeue architecture)
Niedzielski added a comment to T214658: Separate Lazy loading code from Skin.js.

This is ready for sign off by anyone.

Mon, Feb 4, 6:17 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Niedzielski placed T214658: Separate Lazy loading code from Skin.js up for grabs.
Mon, Feb 4, 6:16 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Niedzielski claimed T214658: Separate Lazy loading code from Skin.js.
Mon, Feb 4, 6:10 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3)
Niedzielski assigned T214180: Add informational links to AMC opt-in toggle to Edtadros.
Mon, Feb 4, 6:06 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Sat, Feb 2

Niedzielski updated the task description for T215088: Update page performance tests to use null banner parameter.
Sat, Feb 2, 4:08 AM · Performance-Team, Readers-Web-Backlog
Niedzielski updated subscribers of T215088: Update page performance tests to use null banner parameter.
Sat, Feb 2, 2:50 AM · Performance-Team, Readers-Web-Backlog
Niedzielski updated the task description for T215088: Update page performance tests to use null banner parameter.
Sat, Feb 2, 2:49 AM · Performance-Team, Readers-Web-Backlog
Niedzielski added a subtask for T215088: Update page performance tests to use null banner parameter: T215086: Add null banner preview to CentralNotice for performance testing baseline.
Sat, Feb 2, 2:48 AM · Performance-Team, Readers-Web-Backlog
Niedzielski added a parent task for T215086: Add null banner preview to CentralNotice for performance testing baseline: T215088: Update page performance tests to use null banner parameter.
Sat, Feb 2, 2:48 AM · Fundraising Sprint Casino Royale With Cheese, Fundraising Sprint Bert and Ernie's Excellent Adventure, Patch-For-Review, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Niedzielski created T215088: Update page performance tests to use null banner parameter.
Sat, Feb 2, 2:46 AM · Performance-Team, Readers-Web-Backlog

Thu, Jan 31

Niedzielski updated subscribers of T214998: Remove .m. subdomain, serve mobile and desktop variants through the same URL.
Thu, Jan 31, 9:09 PM · Readers-Web-Backlog (Tracking), Traffic, Operations, MobileFrontend

Fri, Jan 25

Niedzielski closed T214200: Editor code is packaged in 2 modules as Resolved.
Fri, Jan 25, 8:12 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review
Niedzielski added a comment to T211724: [Spike, 8hrs] Discuss OO.EventEmitter usage for Views.

So it's my understanding that https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/485957/ and https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/485956/ are the outcomes of this spike and we're just waiting a write up/discussion of that experience. Is that correct?

Yes, the offsite would be a good venue for this.

Fri, Jan 25, 8:12 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Spike, Technical-Debt (RW-Tech-Debt), MobileFrontend (MobileFrontend and MinervaNeue architecture)

Thu, Jan 24

Niedzielski updated subscribers of T214200: Editor code is packaged in 2 modules.
Thu, Jan 24, 9:32 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review
Niedzielski added a comment to T214200: Editor code is packaged in 2 modules.

@Jdlrobson, should I create a dependency, move the module consolidation requirements to T213340, make a new task, or remove the requirements?

Thu, Jan 24, 9:32 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review
Niedzielski moved T212371: Separate page issue parsing from pageIssues.js from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Thu, Jan 24, 9:24 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog, Technical-Debt, MinervaNeue, Page-Issue-Warnings
Niedzielski moved T214200: Editor code is packaged in 2 modules from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Thu, Jan 24, 9:19 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review
Niedzielski placed T214200: Editor code is packaged in 2 modules up for grabs.

I think this needs more work. mobile.editor is still present in extension.json and tests/qunit/mobile.editor.api/EditorGateway.test.js references mobile.editor.api.

Thu, Jan 24, 9:19 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review
Niedzielski added a comment to T213908: Links in footnote preview open in a new tab.

Links that are part of the footnote, when clicked, open in a new tab

I'm not objecting to this requirement but rather asking about it. Is this a change in behavior from the way references work today? For me personally, I usually control or middle-click when a new tab is wanted. If this is a change, do want to introduce it as part of the initial reference previews deployment? If it was separate, it could be A/B tested. I don't have any strong opinions but wanted to ask to understand the thinking behind the requirement.

Thu, Jan 24, 3:52 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, WMDE-QWERTY-Sprint-2019-01-23, Reference Previews

Wed, Jan 23

Niedzielski added a comment to T214200: Editor code is packaged in 2 modules.

Wed, Jan 23, 10:34 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review
Niedzielski renamed T212376: Extract pageIssues.js view code from [Analysis] Extract pageIssues.js view code to Extract pageIssues.js view code.
Wed, Jan 23, 8:25 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MinervaNeue, Page-Issue-Warnings
Niedzielski reassigned T212376: Extract pageIssues.js view code from Niedzielski to ovasileva.

I've tagged an example patch that I hope is more illustrative. In my view, this is ready to work when priorities permit.

Wed, Jan 23, 8:25 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MinervaNeue, Page-Issue-Warnings
Niedzielski added a project to T214200: Editor code is packaged in 2 modules: MobileFrontend (MobileFrontend and MinervaNeue architecture).
Wed, Jan 23, 2:54 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review

Tue, Jan 22

Niedzielski moved T212376: Extract pageIssues.js view code from To Do to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Jan 22, 9:46 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MinervaNeue, Page-Issue-Warnings
Niedzielski reassigned T211724: [Spike, 8hrs] Discuss OO.EventEmitter usage for Views from Niedzielski to Jdlrobson.

Over to @Jdlrobson for code review.

Tue, Jan 22, 9:33 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Spike, Technical-Debt (RW-Tech-Debt), MobileFrontend (MobileFrontend and MinervaNeue architecture)