Legal says they are happy with the wording on the survey but need to setup a privacy statement for it. This is not a blocker for the beta deploy.

In T307023#7926398, @Prtksxna wrote:

The spd-test tool has this and is linking to the interaction timeline between the user that was queried and the the user in the row. While I think its useful, I'm not sure if we want to officially link to an external tool (that I think this team built) from a MediaWiki extension. @Niharika what do you think?

@Tchanders thanks for the explanation! we would not be inviting actual users to try the tool on beta or testwiki environments. Those environments are for our own QA purposes only. So with regards to testing on beta and testwiki I am flexible with whichever option seems sensible to you.

My opinion is that if the log line is showing up and the IP address is visible, we should show the IP popup as usual to be consistent. @Prtksxna what do you think?

@Tchanders can we call this task done and close it?

Thanks for the patch, @Reedy!

In T295017#7516522, @Tks4Fish wrote:

@phuedx and @Niharika: shouldn't this be limited to Staff, CU, Stewards and OmbCom members? The reasoning being the possibility of audit by the last two, that already have access to the CU log on all wikis.

Thanks for investigating! I agree with your conclusion. It does seem like a very unlikely to happen edge-case.

Got it. Yes, I think we are okay with the caveats.

Special:MyLanguage will look up the language on meta. This could still be English even if language was not.

@Tchanders can you explain this sentence please? Are we saying that if the translation for the wiki content language where feedback is being provided does not exist, it will fallback to English?

In T304521#7881871, @Tchanders wrote:

@Prtksxna @Niharika I changed a few things from the mockup - hope that's OK:

• Changed "Find similar users" to "Find similar editors" (since the special page name is now Similar Editors, not Similar Users)
• Changed the placeholder description at the top of the page to "Find the most similar editors to a given editor based on edit history." - adapted from the first sentence of the README for similar-users: https://github.com/wikimedia/mediawiki-services-similar-users#readme

In T302398#7871091, @dom_walden wrote:

In T302398#7868738, @Niharika wrote:

Have we seen this bug happen on testwiki yet?

I am not sure we would know even if it did happen to a user.

I have tried to reproduce the bug in the description about 10 times on testwiki and was not able to.

However, I was able to reproduce a bug that is possibly related on testwiki:

1. Go to Special:Preferences beta tab
2. Enable autoenroll and submit
3. Go to the User profile tab, check both IPInfo options and submit
4. The second option is not checked, like it was not saved correctly

I have reproduced this about half the time I have tried.

Have we seen this bug happen on testwiki yet?

In T304695#7856321, @Tchanders wrote:

I'm in favour of adding the logging, until we deploy to more production sites. I've made a deployment-blocking task for removing the logging: T306212

@Niharika Are we OK to log the IP, as discussed on gerrit? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/IPInfo/+/779018

In T304631#7848091, @Tchanders wrote:

In T304631#7846005, @Mstyles wrote:

@Tchanders @Niharika following up about the review. Is this for the extension or for the underlying service, or both?

@Mstyles This task was just for the extension since that's the part we're working on now... But I'm not sure what work was done on the service while I was away. @Niharika do you know if the service needs a security review (and if so, would we be requesting that since we don't own the service)?

Boldly closing this.

Thanks for catching this, Thalia. I don't think this task is valid as written anymore. I think we wrote this task when we said we will only give out IP Info to admins etc on testwiki and other wikis. We should be okay with the status quo for now. Maybe eventually when we have IP Info deployed everywhere, we can remove it from the beta cluster. How does that sound to you?