Thu, Apr 27
The patch shouldn't be merged until the page has been created. Ticket for it at T164038: Create help page for LoginNotify
So https://mediawiki.org/wiki/Help:Login_notifications sounds good?
Wed, Apr 26
I believe the reason behind the bot slow-ness is that we included the feature for adding up redirect pageviews after last month. So even if the total number of project pages in a wikiproject is 10k, it's easily fetching pageviews for 30k articles or more. I think it's sane to spawn a second bot-job starting further down the list for future. Will need a little bit of code tweaks including a separate logging file for the second bot.
I just realized that this task is blocked on creating the page we're linking to. @DannyH if you could tell me where the page would live I could link to it.
Patch above needs a review and merge.
Message posted on the Technical Village pump- https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#LoginNotify_coming_soon_to_a_wiki_near_you 🤞
I'm pretty sure it should be colored when CodeMirror is enabled and greyed out when disabled.
Tue, Apr 25
Marking as resolved. @Etonkovidova please reopen if this happens again. Thanks! :)
@Pastakhov Let's hold off on the extension integration for a bit? The thing that's bothering me is that if two or more extensions end up defining same/similar color schemes for their tags, it can look ugly. It's not deliberate but people use wikitext in lots of weird crazy ways. We should give this a little more thought before implementing it.
Mon, Apr 24
"Unique" is somewhat ambiguous here. I know the implication is unique from passwords on other websites but not everybody will get the implication. The other thing is that we need to keep the message string as short as possible to avoid showing them a very long notification without it being truncated.
Fri, Apr 21
I'm gonna draft the message and add screenshots when the latest patch for changing the wording is approved.
So this already seems to be true. There are multiple records when the same IP tries to edit repetitively. I don't believe that is a problem. The data looks solid. Here's the query I ran to find distinct cookie-blocked users so far.
mysql:email@example.com [log]> select date_format(timestamp, '%Y-%m-%d') date, event_ip from CookieBlock_16241436 where event_is_cookie_block =1 group by event_ip;
This should work.
Well, the sorting should be for all blocks or autoblocks, not for the current page you're looking at.
What's the issue with sorting just the visible records? I agree sorting everything might be more useful, but as the number of auto blocks go up in future, it could get slower.
Why do we need routing again? Can't we have a copy of the repo in each of the tools?
Use wikitext tables, for one. :) They allow you to sort without having to implement something complicated by yourself.
Thu, Apr 20
Hi! I was recently at this Facebook dev summit and I've come across this (possibly) useful library that (I believe) Facebook uses to do image recognition. https://github.com/facebookresearch/multipathnet.
https://caffe2.ai is another one that was widely mentioned.
My current theory is that something messed up with the API during the DC switch.
The weird thing is, this has never happened before. I think something is up with the API. I did previously chat with someone and they said our API is robust enough to not throw this error unless you make like a thousand requests a second or something.
This solution won't scale if there are fifty extensions creating tags and most of them are unmaintained, which is the case usually. Not many people will bother to add styling for their own tags in their extension. And even if they do, most people won't give any thought to how that will appear when their tags show up with tags from other extensions. It might end up looking like a total mess. It might be completely unsupported for people who are color-blind.
I'd say we switch all tags to green and see how it works. The thing is, we as developers know that HTML, extension and wiki markup tags are all different but for an editor, it is all the same. They look same, they work in a similar fashion.
If it doesn't look good, we can consider switching back to different colors.
Tue, Apr 18
@Pastakhov, I amended your first patch to add ref tag support too. Can you review it? We can abandon the other one.
@Etonkovidova Yes, it is correct now because we did some hacky stuff in our code to accommodate for this. It'd still be nice to either count unexpandable bundles as 1 or let them specify the count they should show up as.
Well, I've been testing on our Beta cluster, and according to Reedy, Labs has a shorter bad-word list so it might not happen as often on enwiki. Guess we'd have to find out.
Mon, Apr 17
Hi @Pastakhov, could you shed some light on why WikiEditor is a dependency for CodeMirror? What does WikiEditor do specifically, that CodeMirror needs to run after it?
"wgLoginNotifyAttemptsNewIP" has now been set to 1 in Labs and it solves all of the issues surrounding number mismatch between icon and attempts and bundling works very nicely with it.
Fri, Apr 14
Yes, this was deployed yesterday during SWAT. There was time so we decided to include this.
Thu, Apr 13
http://tools.wmflabs.org/popularpages/ Anything else I should add?
How does https://wikitech.wikimedia.org/wiki/Tool:Popular_Pages look?
Currently blocked on getting the latest patch on Test wiki. https://gerrit.wikimedia.org/r/#/c/347120/
Wed, Apr 12
Are the settings mentioned in the task description accurate? I recall we decided to make "LoginNotifyAttemptsNewIP" 2 in our meeting.
@kaldari It's very much possible for a page to have some fixed links and some not fixed links. Since log entries are by page, it's hard to segregate what counts as fixed and what doesn't.
@kaldari Could you make it a bit clearer what you mean by 'Fixed' and 'Processed'?
Tue, Apr 11
Here's the notification now:
Mon, Apr 10
Working on showing the actual attempt count in the message and generic messages in the individual messages.
Sat, Apr 8
Tested locally, works fine.
Fri, Apr 7
Here's what I got:
Hi @Shizhao. How is this task related to T141154: [Epic] Fix and improve Mr.Z's popular pages report?
How the notification would appear when you login (and until the point you mark it as read):
Wed, Apr 5
Also https://github.com/wikimedia/mediawiki-extensions-LoginNotify/blob/master/extension.json#L18 should probably be set to true.
Couple more things:
It's not possible to have "global" notifications in Echo, i.e. your notification has to be tied to a wiki. Here's the current implementation:
Where's the code for this? I don't see it at https://github.com/MusikAnimal/xtools-rebirth