Page MenuHomePhabricator

Nikerabbit (Niklas Laxström)
Senior Software Engineer, Language team · i18n and translation expert

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 5:29 AM (257 w, 6 d)
Availability
Available
IRC Nick
nikerabbit
LDAP User
Nikerabbit
MediaWiki User
Nikerabbit [ Global Accounts ]

I am Wikimedian since 2004. I am the founder and maintainer of translatewiki.net. I mainly work on language support (internationalization, localisation and translation tools).

Leave feedback

Examples of projects I where I have significant contributions:

My personal board is User-Nikerabbit.

Recent Activity

Today

Nikerabbit added a comment to T231991: Convert T41480 ("Issues affecting translatewiki.net") to a project tag.

Most of our issues are what I call logspam. Another option would be #translatewiki.net-mediawiki-error if the word production is troublesome. Strictly speaking, there are other projects tracked here in Phabricator that we use, like keyholder, which we might encounter issues.
We could just copy the task name #affects-translatewiki.net - if that isn't too uncovential name for a task?

Mon, Sep 16, 8:24 AM · Project-Admins, translatewiki.net
Nikerabbit added a comment to T230690: array_keys() expects parameter 1 to be array, null given in cache/MessageCache.php on line 493.

Can we put a special key on the cache value itself when it is populated by full cache load? If it is not present when we check the cache, then we know we only have partial value and need to (re)load?

Mon, Sep 16, 7:27 AM · Performance-Team, MediaWiki-Cache, MediaWiki-extensions-Translate
Nikerabbit added a comment to T232967: Detect renames / moves that have ordering dependency.

We need to ensure that this works well with the new rename functionality

Mon, Sep 16, 6:58 AM · Language-Team (Language-2019-July-September), User-abi_, MediaWiki-extensions-Translate

Sat, Sep 14

Nikerabbit renamed T199323: Checkuser does not truncate data (cuc_comment, cuc_agent, cuc_actiontext) and that causes exceptions with strict mode from Checkuser does not truncate data (cuc_comment, cuc_agent) and that causes exceptions with strict mode to Checkuser does not truncate data (cuc_comment, cuc_agent, cuc_actiontext) and that causes exceptions with strict mode.
Sat, Sep 14, 1:03 PM · CheckUser
Nikerabbit added a comment to T199323: Checkuser does not truncate data (cuc_comment, cuc_agent, cuc_actiontext) and that causes exceptions with strict mode.

Now I am also seeing:

Function: CheckUserHooks::updateCheckUserData
Error: 1406 Data too long for column 'cuc_actiontext' at row 1
Sat, Sep 14, 1:03 PM · CheckUser
Nikerabbit removed a project from T230690: array_keys() expects parameter 1 to be array, null given in cache/MessageCache.php on line 493: translatewiki.net.
Sat, Sep 14, 11:26 AM · Performance-Team, MediaWiki-Cache, MediaWiki-extensions-Translate
Nikerabbit merged task T232900: FuzzyBot "imported" wrong old versions of VisualEditor messages into Translatewiki into T232892: PHP Notice: Key 8:visualeditor-linkcontext-label-label already belongs to ext-bluespicevisualeditorconnector, conflict with mwgerrit-visualeditor-ve .
Sat, Sep 14, 7:27 AM · MediaWiki-extensions-Translate, translatewiki.net
Nikerabbit merged T232900: FuzzyBot "imported" wrong old versions of VisualEditor messages into Translatewiki into T232892: PHP Notice: Key 8:visualeditor-linkcontext-label-label already belongs to ext-bluespicevisualeditorconnector, conflict with mwgerrit-visualeditor-ve .
Sat, Sep 14, 7:27 AM · User-Ryasmeen, VisualEditor, User-Zoranzoki21, translatewiki.net, BlueSpice
Nikerabbit added a comment to T232897: Thousand separator for large numbers.

I'm not sure it's possible to automatically figure out the correct action with regards to line breaking here.

Sat, Sep 14, 7:25 AM · MediaWiki-Internationalization, ParserFunctions
Nikerabbit closed T232894: Decimal point is lost in formatnum for large numbers as Invalid.

Using this input on Special:ExpandTemplates with Pi as page name:

{{#property:P1181}}
{{#statements:P1181}}
{{formatnum:{{#property:P1181}}}}
Sat, Sep 14, 7:24 AM · MediaWiki-Internationalization, ParserFunctions, MediaWiki-extensions-WikibaseClient, Wikidata
Nikerabbit changed the status of T232898: Thousand separator misplaced for large real numbers from Open to Stalled.

Your bug report is missing a test case.

Sat, Sep 14, 7:17 AM · MediaWiki-Internationalization, ParserFunctions

Fri, Sep 13

Nikerabbit added a comment to T231326: Explore ResourceLoader package files feature as way to reduce number of modules.

Thanks! A bunch of those involve CX1 which we would prefer not to touch at all until it is removed completely.

Fri, Sep 13, 7:15 AM · Performance-Team (Radar), ContentTranslation

Thu, Sep 12

Nikerabbit claimed T232686: Update Translate for changes in AbuseFilter and SpamBlacklist API error responses.
Thu, Sep 12, 2:04 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Language-Team (Language-2019-July-September), MediaWiki-extensions-Translate
Nikerabbit claimed T206264: SpamBlacklist doesn't respect $wgSpamBlacklistFiles?.

I'm updating README and the wiki page.

Thu, Sep 12, 1:54 PM · Patch-For-Review, SpamBlacklist
Nikerabbit moved T232686: Update Translate for changes in AbuseFilter and SpamBlacklist API error responses from Priority backlog to In Review on the Language-Team (Language-2019-July-September) board.

No updates are necessary to handle the new format. I have marked the code for removal once backwards compatibility is no longer required.

Thu, Sep 12, 12:25 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Language-Team (Language-2019-July-September), MediaWiki-extensions-Translate
Nikerabbit added a comment to T232702: Phabricator Maniphest showing "Cancelar suscripción" in English user interface.

FYI https://translatewiki.net/w/i.php?title=Special:SearchTranslations&match=all&query=Cancelar+suscripci%C3%B3n&group=phabricator&grouppath=phabricator

Thu, Sep 12, 10:17 AM · Phabricator
Nikerabbit added a comment to T230690: array_keys() expects parameter 1 to be array, null given in cache/MessageCache.php on line 493.

@Krinkle Umm, can it just be as simple as en falling out of $this->cache due to LRU mechanism, and $this->loadedLanguages['en'] still being true, unaware of this fact. This is likely to happen if there are a lot of cache misses, because MapCacheLRU::has does not ping. If it called load unconditionally, it would continuously ping and keep en in the cache.

Thu, Sep 12, 10:08 AM · Performance-Team, MediaWiki-Cache, MediaWiki-extensions-Translate
Nikerabbit added a comment to T230690: array_keys() expects parameter 1 to be array, null given in cache/MessageCache.php on line 493.

I added some additional debugging:

diff --git a/includes/cache/MessageCache.php b/includes/cache/MessageCache.php
index 6272723..7d0f51a 100644
--- a/includes/cache/MessageCache.php
+++ b/includes/cache/MessageCache.php
@@ -454,9 +454,17 @@ class MessageCache {
Thu, Sep 12, 10:03 AM · Performance-Team, MediaWiki-Cache, MediaWiki-extensions-Translate
Nikerabbit committed rGTWN60f251484e9c: Enable GettextPlural validator for Dissemin (authored by Nikerabbit).
Enable GettextPlural validator for Dissemin
Thu, Sep 12, 9:07 AM
Nikerabbit added a comment to T230100: MediaWiki Core: exceeded the timeout of 300 seconds for export.php.

I think we need additional debugging information to drill down where the time is spent.

Thu, Sep 12, 8:19 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), translatewiki.net
Nikerabbit closed T206056: Wikimedia Technical Conference 2018 Session - Improving the translation process as Resolved.
Thu, Sep 12, 7:55 AM · Wikimedia-Technical-Conference-2018
Nikerabbit added a comment to T230690: array_keys() expects parameter 1 to be array, null given in cache/MessageCache.php on line 493.

There were a couple of instances of [2019-09-12 06:38:34] MessageCacheError.INFO: MessageCache::load: Failed to load hr {"private":false} [] but it doesn't seem to explain these errors. Also no callers on enable/disable.

Thu, Sep 12, 7:53 AM · Performance-Team, MediaWiki-Cache, MediaWiki-extensions-Translate
Nikerabbit added a comment to T232683: Update ContentTranslation for changes in AbuseFilter and SpamBlacklist API error responses.

We are on it :)

Thu, Sep 12, 7:39 AM · ContentTranslation
Nikerabbit merged task T232683: Update ContentTranslation for changes in AbuseFilter and SpamBlacklist API error responses into T232583: Adjust Content Translation to changes in AbuseFilter and SpamBlacklist systems.
Thu, Sep 12, 7:39 AM · ContentTranslation
Nikerabbit merged T232683: Update ContentTranslation for changes in AbuseFilter and SpamBlacklist API error responses into T232583: Adjust Content Translation to changes in AbuseFilter and SpamBlacklist systems.
Thu, Sep 12, 7:39 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Language-Team (Language-2019-July-September), ContentTranslation

Wed, Sep 11

Nikerabbit added a comment to T230690: array_keys() expects parameter 1 to be array, null given in cache/MessageCache.php on line 493.

I enabled MessageCacheError logging on Mon Sep 9 11:02:37 2019 +0200. There is nothing in the logs. This error last appeared [2019-09-11 15:13:17]. I double checked that I didn't misconfigure anything. Maybe I should add logging if MessageCache::disable is getting called.

Wed, Sep 11, 7:59 PM · Performance-Team, MediaWiki-Cache, MediaWiki-extensions-Translate
Nikerabbit added a comment to T231326: Explore ResourceLoader package files feature as way to reduce number of modules.

Some concerns have been raised that reducing the number of modules goes against making reusable code.

Wed, Sep 11, 3:22 PM · Performance-Team (Radar), ContentTranslation
Nikerabbit added a comment to T231326: Explore ResourceLoader package files feature as way to reduce number of modules.

Documentation for this is a bit hard to find (T232566: $wgResourceModules documentation is incomplete), but there are examples to copy too.

Wed, Sep 11, 7:00 AM · Performance-Team (Radar), ContentTranslation
Nikerabbit created T232566: $wgResourceModules documentation is incomplete.
Wed, Sep 11, 7:00 AM · MediaWiki-Documentation, Performance-Team, MediaWiki-ResourceLoader

Tue, Sep 10

Nikerabbit moved T231443: Uncaught Wikimedia\Rdbms\DBUnexpectedError: Wikimedia\Rdbms\Database::close: mass commit/rollback of peer transaction required (DBO_TRX set) from Recheck after deployment to Done on the Language-Team (Language-2019-July-September) board.

Yep, no longer appearing in logs.

Tue, Sep 10, 6:25 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), MediaWiki-General
Nikerabbit added a comment to T231284: ApiQueryContentTranslation.php: PHP Notice: Trying to get property 'translation' of non-object.

Yes.

Tue, Sep 10, 5:54 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), ContentTranslation, Wikimedia-production-error

Mon, Sep 9

Nikerabbit added a comment to T231181: Add PLURAL validators for projects using the new Validator framework.

Do you have an example of a project that uses plurals in Python?

Mon, Sep 9, 3:48 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Language-Team (Language-2019-July-September), MediaWiki-extensions-Translate, translatewiki.net
Nikerabbit added a comment to T54687: Use IEC units (KiB, MiB, etc.) and not SI units (KB, MB).

@Urhixidur This task is about MediaWiki. Issues with X'tools should be handled separately in an appropriate place. The message you linked is not in use anywhere. We keep old messages around because it is more hassle to remove them.

Mon, Sep 9, 3:36 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, WorkType-NewFunctionality, MW-1.27-release-notes, Multimedia, MediaWiki-General
Nikerabbit committed rGTWN29030d23458f: Use single quotes to avoid Yaml parsing error (authored by Nikerabbit).
Use single quotes to avoid Yaml parsing error
Mon, Sep 9, 11:45 AM
Nikerabbit added a comment to T54687: Use IEC units (KiB, MiB, etc.) and not SI units (KB, MB).

That's already the case: https://translatewiki.net/wiki/Special:Translations?message=Size-kilobytes&namespace=8

Mon, Sep 9, 9:07 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, WorkType-NewFunctionality, MW-1.27-release-notes, Multimedia, MediaWiki-General
Nikerabbit added a comment to T230690: array_keys() expects parameter 1 to be array, null given in cache/MessageCache.php on line 493.

With regards to mDisable being true:

  • $wgUseDatabaseMessages is certainly true, so mDisable should not be set true in the constructor line 155. I could only find one place where MessageCache is constructed, in service wiring.
  • If loading fails for some reason, it might be disabled on line 356. If this is the case, it should be apparent from MessageCacheError log channel. I can't find anything in Logstash, so this does not seem to be the case in production?? In translatewiki.net, we don't have logging for that channel. I'll enable it.
  • Something could also call MessageCache::disable, but as non-static method it is hard to search in code search.
Mon, Sep 9, 9:01 AM · Performance-Team, MediaWiki-Cache, MediaWiki-extensions-Translate
Nikerabbit added a comment to T231991: Convert T41480 ("Issues affecting translatewiki.net") to a project tag.

I was thinking what similar tags already exist. Wikimedia-production-error is very similar. If we use that pattern, it would be #translatewiki.net-production-error.

Mon, Sep 9, 8:36 AM · Project-Admins, translatewiki.net
Nikerabbit added a comment to T54687: Use IEC units (KiB, MiB, etc.) and not SI units (KB, MB).

Why would you introduce new messages? Then you would need to update call callers separately. They are already documented to use base 2 so they are just using the wrong units.

Mon, Sep 9, 8:29 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, WorkType-NewFunctionality, MW-1.27-release-notes, Multimedia, MediaWiki-General
Nikerabbit added a comment to T54687: Use IEC units (KiB, MiB, etc.) and not SI units (KB, MB).

Why has this been languishing for over three years?

Mon, Sep 9, 7:37 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, WorkType-NewFunctionality, MW-1.27-release-notes, Multimedia, MediaWiki-General
Nikerabbit added a comment to T228230: Add "✔️" into link modal.

In my experience, in Finnish the use of checkmark to mean wrong is limited to school exams. There is hardly any chance for confusion as people are used to seeing the checkmark used as affirmative symbol all over the places.

Mon, Sep 9, 7:24 AM · I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-Edit Cards , Editing Design
Nikerabbit added a comment to T206986: LocalisationCache::readPHPFile may read outdated files on PHP 7 in stock MediaWiki (apc.cache_by_default no longer supported).

fwiw Language-Team says that MediaWiki-Internationalization is "Passive maintenance or unsupported". That means only UBN! tickets will be looked at if even noticed.

Mon, Sep 9, 7:14 AM · Language-Team, PHP 7.1 support, MediaWiki-Internationalization, PHP 7.3 support, PHP 7.2 support, PHP 7.0 support, MW-1.34-release, Technical-Debt

Thu, Sep 5

Jdforrester-WMF awarded T231288: Clarify confusing error "ConfigException: GlobalVarConfig::get: undefined option: ServiceWiringFiles" when using Title etc. in a unit test a Like token.
Thu, Sep 5, 7:32 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Code-Health, MediaWiki-Core-Testing
Nikerabbit added a comment to T232084: Add validator to validate that a certain key / keys can only contain a set of values.

Did we have another task for generic support of limiting the validator only to certain keys? I can't find such one.

Thu, Sep 5, 12:50 PM · MediaWiki-extensions-Translate
Nikerabbit added a comment to T231991: Convert T41480 ("Issues affecting translatewiki.net") to a project tag.

Yeah two tags. And naming is hard.

Thu, Sep 5, 12:48 PM · Project-Admins, translatewiki.net

Wed, Sep 4

Nikerabbit added a comment to T231991: Convert T41480 ("Issues affecting translatewiki.net") to a project tag.

I would like to keep the work we translatewiki.net folks do separate from the issues we notice in "upstream" code while operating a MediaWiki instance.

Wed, Sep 4, 2:44 PM · Project-Admins, translatewiki.net
Nikerabbit closed T204431: Error from line 733 of /srv/mediawiki/tags/2018-09-16_09:30:30/extensions/PageForms/includes/PF_AutoeditAPI.php: Call to a member function getNativeData() on null, a subtask of T41480: Issues affecting translatewiki.net, as Resolved.
Wed, Sep 4, 1:55 PM · Tracking-Neverending, MediaWiki-General
Nikerabbit closed T204431: Error from line 733 of /srv/mediawiki/tags/2018-09-16_09:30:30/extensions/PageForms/includes/PF_AutoeditAPI.php: Call to a member function getNativeData() on null as Resolved.

This seems to be resolved.

Wed, Sep 4, 1:55 PM · MediaWiki-extensions-Page_Forms
Nikerabbit removed a parent task for T168461: Notice: Undefined index: 206 in PF_FormLinker.php on line 164: T41480: Issues affecting translatewiki.net.
Wed, Sep 4, 1:53 PM · MediaWiki-extensions-Page_Forms
Nikerabbit removed a subtask for T41480: Issues affecting translatewiki.net: T168461: Notice: Undefined index: 206 in PF_FormLinker.php on line 164.
Wed, Sep 4, 1:53 PM · Tracking-Neverending, MediaWiki-General
Nikerabbit added a comment to T168461: Notice: Undefined index: 206 in PF_FormLinker.php on line 164.

This notice is not currently appearing in translatewiki.net logs.

Wed, Sep 4, 1:53 PM · MediaWiki-extensions-Page_Forms
Nikerabbit added a comment to T231991: Convert T41480 ("Issues affecting translatewiki.net") to a project tag.

To be clear, I'm looking for advice what's the best way to track these issues and help to implement that.

Wed, Sep 4, 1:50 PM · Project-Admins, translatewiki.net
Nikerabbit moved T231991: Convert T41480 ("Issues affecting translatewiki.net") to a project tag from Backlog to Processes on the translatewiki.net board.
Wed, Sep 4, 1:50 PM · Project-Admins, translatewiki.net
Nikerabbit added a project to T231991: Convert T41480 ("Issues affecting translatewiki.net") to a project tag: translatewiki.net.
Wed, Sep 4, 1:49 PM · Project-Admins, translatewiki.net
Nikerabbit created T231991: Convert T41480 ("Issues affecting translatewiki.net") to a project tag.
Wed, Sep 4, 1:47 PM · Project-Admins, translatewiki.net
Nikerabbit removed a subtask for T41480: Issues affecting translatewiki.net: T190146: PHP Warning when viewing a page whose name contains $1.
Wed, Sep 4, 1:43 PM · Tracking-Neverending, MediaWiki-General
Nikerabbit removed a parent task for T190146: PHP Warning when viewing a page whose name contains $1: T41480: Issues affecting translatewiki.net.
Wed, Sep 4, 1:43 PM · MediaWiki-General
Nikerabbit closed T219904: Link to this message dialog is broken, a subtask of T41480: Issues affecting translatewiki.net, as Resolved.
Wed, Sep 4, 1:41 PM · Tracking-Neverending, MediaWiki-General
Nikerabbit closed T219904: Link to this message dialog is broken as Resolved.

Looks like this has been fixed in the meanwhile.

Wed, Sep 4, 1:41 PM · MediaWiki-extensions-LiquidThreads
Nikerabbit removed a subtask for T41480: Issues affecting translatewiki.net: T41510: Editing large watchlists via Special:EditWatchlist fails due to a server timeout.
Wed, Sep 4, 1:40 PM · Tracking-Neverending, MediaWiki-General
Nikerabbit removed a parent task for T41510: Editing large watchlists via Special:EditWatchlist fails due to a server timeout: T41480: Issues affecting translatewiki.net.
Wed, Sep 4, 1:40 PM · Growth-Team (Current Sprint), Core Platform Team Workboards (Clinic Duty Team), User-notice, Wikimedia-production-error, Patch-For-Review, MediaWiki-Watchlist
Nikerabbit removed a subtask for T41480: Issues affecting translatewiki.net: T227773: [LiquidThreads] Use of EditPage::getContextTitle called with no title set was deprecated in MediaWiki 1.32.
Wed, Sep 4, 1:38 PM · Tracking-Neverending, MediaWiki-General
Nikerabbit removed a parent task for T227773: [LiquidThreads] Use of EditPage::getContextTitle called with no title set was deprecated in MediaWiki 1.32: T41480: Issues affecting translatewiki.net.
Wed, Sep 4, 1:38 PM · MediaWiki-extensions-LiquidThreads
Nikerabbit added a comment to T227773: [LiquidThreads] Use of EditPage::getContextTitle called with no title set was deprecated in MediaWiki 1.32.

This notice is not currently present in translatewiki.net logs that go back about one month.

Wed, Sep 4, 1:38 PM · MediaWiki-extensions-LiquidThreads
Nikerabbit added a comment to T231443: Uncaught Wikimedia\Rdbms\DBUnexpectedError: Wikimedia\Rdbms\Database::close: mass commit/rollback of peer transaction required (DBO_TRX set).

I'm not sure if the merged patch was supposed to fix this, but I am still seeing the error with slightly changed line numbers:

[04-Sep-2019 12:54:55 UTC] PHP Fatal error:  Uncaught Wikimedia\Rdbms\DBUnexpectedError: Wikimedia\Rdbms\Database::close: mass commit/rollback of peer transaction required (DBO_TRX set) in /srv/mediawiki/tags/2019-09-04_12:36:29/includes/libs/rdbms/database/Database.php:888
Stack trace:
#0 /srv/mediawiki/tags/2019-09-04_12:36:29/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1517): Wikimedia\Rdbms\Database->close()
#1 /srv/mediawiki/tags/2019-09-04_12:36:29/includes/libs/rdbms/loadbalancer/LoadBalancer.php(2085): Wikimedia\Rdbms\LoadBalancer->Wikimedia\Rdbms\{closure}(Object(Wikimedia\Rdbms\DatabaseMysqli))
#2 /srv/mediawiki/tags/2019-09-04_12:36:29/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1518): Wikimedia\Rdbms\LoadBalancer->forEachOpenConnection(Object(Closure))
#3 /srv/mediawiki/tags/2019-09-04_12:36:29/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1502): Wikimedia\Rdbms\LoadBalancer->closeAll()
#4 /srv/mediawiki/tags/2019-09-04_12:36:29/includes/libs/rdbms/lbfactory/LBFactory.php(235): Wikimedia\Rdbms\LoadBalancer->disable()
#5 /srv/ in /srv/mediawiki/tags/2019-09-04_12:36:29/includes/libs/rdbms/database/Database.php on line 888
Wed, Sep 4, 1:02 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), MediaWiki-General
Nikerabbit removed a project from T227102: Switch to new Encyclopedia of Life github repo: Patch-For-Review.
Wed, Sep 4, 11:59 AM · Language-Team (Language-2019-July-September), translatewiki.net
Nikerabbit added a comment to T231942: Error message with HTML entity insertables as params should display the entity as text.

Good catch. The parameter needs additional escaping. Should be simple to fix once you find the place (is it on PHP side or JavaScript side).

Wed, Sep 4, 6:15 AM · MediaWiki-extensions-Translate

Tue, Sep 3

Nikerabbit added a comment to T231703: CentralNotice: Timeout when creating translation variables Translate Extension .

You are still calling MessageIndexRebuildJob->run during user request, that is super slow. It would be better to defer it to the jobqueue.

Tue, Sep 3, 7:43 PM · Fundraising Sprint Rocky Horror Presentation Layer, MediaWiki-extensions-Translate, Fr-CentralNotice-Translation-Bugs, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Nikerabbit renamed T231922: PHPCS: Allow long lines for phan annotations from PHPCS: Alllow long lines for phan annotations to PHPCS: Allow long lines for phan annotations.
Tue, Sep 3, 5:35 PM · phan, MediaWiki-Codesniffer
Nikerabbit moved T228054: (Schedule) hard deprecation (emit notices) for old style registration in Translate from Pending input for QA to Done on the Language-Team (Language-2019-July-September) board.
Tue, Sep 3, 12:02 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), MediaWiki Language Extension Bundle, MediaWiki-extensions-Translate
Nikerabbit moved T231443: Uncaught Wikimedia\Rdbms\DBUnexpectedError: Wikimedia\Rdbms\Database::close: mass commit/rollback of peer transaction required (DBO_TRX set) from Priority backlog to Recheck after deployment on the Language-Team (Language-2019-July-September) board.

Will report back after deployment tomorrow Wednesday.

Tue, Sep 3, 8:36 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), MediaWiki-General
Nikerabbit added a comment to T228054: (Schedule) hard deprecation (emit notices) for old style registration in Translate.

You need access to LocalSettings.php`. Using require_once "$IP/extensions/Translate/Translate.php"; should cause a deprecation notice to appear in the error log. Using wfLoadExtension( 'Translate' ) should not.

Tue, Sep 3, 5:37 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), MediaWiki Language Extension Bundle, MediaWiki-extensions-Translate

Mon, Sep 2

Nikerabbit moved T228054: (Schedule) hard deprecation (emit notices) for old style registration in Translate from Backlog to Needs QA on the Language-Team (Language-2019-July-September) board.
Mon, Sep 2, 7:56 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), MediaWiki Language Extension Bundle, MediaWiki-extensions-Translate
Nikerabbit assigned T228054: (Schedule) hard deprecation (emit notices) for old style registration in Translate to Jdforrester-WMF.
Mon, Sep 2, 7:56 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), MediaWiki Language Extension Bundle, MediaWiki-extensions-Translate

Sat, Aug 31

Nikerabbit added a comment to T231695: Innu language displays "Undefined" as tooltip in ULS.

The suggested languages section sometimes gives languages that it shouldn't. That's T216342: "ʔucināguci" in "Suggested languages" section cannot be selected and has tooltip "undefined"

Sat, Aug 31, 7:10 AM · UniversalLanguageSelector

Fri, Aug 30

Nikerabbit merged task T231567: Translator.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, boolean given into T231544: ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, bool given.
Fri, Aug 30, 8:03 AM · ContentTranslation, Wikimedia-production-error
Nikerabbit merged T231567: Translator.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, boolean given into T231544: ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, bool given.
Fri, Aug 30, 8:03 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), ContentTranslation, Wikimedia-production-error
Nikerabbit added a comment to T231567: Translator.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, boolean given.

The trace is the same. The small difference in the message is likely hhvm vs. php difference.

Fri, Aug 30, 8:03 AM · ContentTranslation, Wikimedia-production-error
Nikerabbit renamed T215202: Error moving translated category (or any translatable page in a namespace without subpages enabled) from Error moving translated category on Meta-Wiki to Error moving translated category (or any translatable page in a namespace without subpages enabled).
Fri, Aug 30, 6:46 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), WMF-Documentation-Working-Group, MediaWiki-extensions-Translate
Nikerabbit added a comment to T215202: Error moving translated category (or any translatable page in a namespace without subpages enabled).

Assuming you mean wmf deployment branches... this bug has existed at least for 6 months. I see no reason to hurry with backports.

Fri, Aug 30, 6:45 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), WMF-Documentation-Working-Group, MediaWiki-extensions-Translate

Thu, Aug 29

Nikerabbit merged T231584: SpecialPageTranslationMovePage.php: Argument must implement interface Traversable into T215202: Error moving translated category (or any translatable page in a namespace without subpages enabled).
Thu, Aug 29, 4:38 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), WMF-Documentation-Working-Group, MediaWiki-extensions-Translate
Nikerabbit merged task T231584: SpecialPageTranslationMovePage.php: Argument must implement interface Traversable into T215202: Error moving translated category (or any translatable page in a namespace without subpages enabled).
Thu, Aug 29, 4:38 PM · MediaWiki-extensions-Translate, Wikimedia-production-error
Nikerabbit added a comment to T231584: SpecialPageTranslationMovePage.php: Argument must implement interface Traversable.

Yes, dupe, I was just demonstrating it :D

Thu, Aug 29, 4:38 PM · MediaWiki-extensions-Translate, Wikimedia-production-error
Nikerabbit added a comment to T231439: AssertionError [ERR_ASSERTION] in "App can edit a single string mainsnak value".

Probably... it also doesn't allow to change priority.

Thu, Aug 29, 4:32 PM · Wikidata-Bridge, Wikidata, Wikimedia-production-error (Shared Build Failure)
Nikerabbit added a comment to T231567: Translator.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, boolean given.

Looks a dupe to me.

Thu, Aug 29, 3:28 PM · ContentTranslation, Wikimedia-production-error
Nikerabbit added a project to T231505: DBQueryError when discouraging translation: Language-Team (Language-2019-July-September).
Thu, Aug 29, 2:29 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Language-Team (Language-2019-July-September), User-DannyS712, Wikimedia-production-error, MediaWiki-extensions-Translate
Nikerabbit updated subscribers of T231505: DBQueryError when discouraging translation.

@abi_ This seems quite similar to the issue with the message index, just a different table.

Thu, Aug 29, 2:29 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Language-Team (Language-2019-July-September), User-DannyS712, Wikimedia-production-error, MediaWiki-extensions-Translate
Nikerabbit moved T231505: DBQueryError when discouraging translation from Backlog to performance and stability on the MediaWiki-extensions-Translate board.
Thu, Aug 29, 2:28 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Language-Team (Language-2019-July-September), User-DannyS712, Wikimedia-production-error, MediaWiki-extensions-Translate
Nikerabbit triaged T231505: DBQueryError when discouraging translation as Normal priority.
Thu, Aug 29, 2:27 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Language-Team (Language-2019-July-September), User-DannyS712, Wikimedia-production-error, MediaWiki-extensions-Translate
Nikerabbit added a comment to T231505: DBQueryError when discouraging translation.

The code is roughly:

Thu, Aug 29, 2:26 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Language-Team (Language-2019-July-September), User-DannyS712, Wikimedia-production-error, MediaWiki-extensions-Translate
Nikerabbit committed rGTWN853cc6ec66c2: Remove wlshowlast from mostused (authored by Nikerabbit).
Remove wlshowlast from mostused
Thu, Aug 29, 2:16 PM
Nikerabbit removed a parent task for T231544: ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, bool given: T220745: 1.34.0-wmf.20 deployment blockers.
Thu, Aug 29, 2:09 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), ContentTranslation, Wikimedia-production-error
Nikerabbit removed a subtask for T220745: 1.34.0-wmf.20 deployment blockers: T231544: ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, bool given.
Thu, Aug 29, 2:09 PM · User-zeljkofilipin, Release-Engineering-Team-TODO (201908), Release-Engineering-Team (Deployment services), Release, Train Deployments
Nikerabbit added a comment to T231544: ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, bool given.

I don't seem to be able to change the priority of this task?

Thu, Aug 29, 2:09 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), ContentTranslation, Wikimedia-production-error
Nikerabbit moved T231544: ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, bool given from Backlog to In Review on the Language-Team (Language-2019-July-September) board.
Thu, Aug 29, 2:08 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), ContentTranslation, Wikimedia-production-error
Nikerabbit added a project to T231544: ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, bool given: Language-Team (Language-2019-July-September).

This just looks like the same injection thing hitting a new API module. We'll fix it, but suggesting that this doesn't need to block the train.

Thu, Aug 29, 1:48 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), ContentTranslation, Wikimedia-production-error
Nikerabbit added a comment to T231439: AssertionError [ERR_ASSERTION] in "App can edit a single string mainsnak value".

Doesn't seem to be happening currently, on quick look. But I think the test was changed on T231074: Selenium tests will fail on gate&submit recently.

Thu, Aug 29, 1:41 PM · Wikidata-Bridge, Wikidata, Wikimedia-production-error (Shared Build Failure)
Nikerabbit added a comment to T230646: Setup L10n for labs/tools/Isa.git.

I see bunch of files in i18n and translations. Which files should be set up for translation? Also, I don't see mention of which license the repository is using. It would be helpful to have the basic information needed for setup in the summary of this ticket.

Thu, Aug 29, 8:32 AM · I18n, ISA, Patch-For-Review, translatewiki.net, Continuous-Integration-Config, User-MarcoAurelio, Gerrit
Nikerabbit added a comment to T231505: DBQueryError when discouraging translation.

It's the IP of the database server.

Thu, Aug 29, 7:56 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Language-Team (Language-2019-July-September), User-DannyS712, Wikimedia-production-error, MediaWiki-extensions-Translate
Nikerabbit added a comment to T231505: DBQueryError when discouraging translation.
Query: REPLACE INTO `translate_groupreviews` (tgr_group,tgr_lang,tgr_state) VALUES ('page-Abuse filter editors','*priority','discouraged')
Function: MessageGroups::setPriority
Error: 1205 Lock wait timeout exceeded; try restarting transaction (10.64.48.15)
Thu, Aug 29, 7:41 AM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Language-Team (Language-2019-July-September), User-DannyS712, Wikimedia-production-error, MediaWiki-extensions-Translate
Nikerabbit added a comment to T218207: Use disk-based LCStore by default in MediaWiki 1.34.

Command line scripts do not have any memory limit unless specified separately.

Thu, Aug 29, 6:44 AM · Performance-Team (Radar), MW-1.35-release, Core Platform Team, Language-Team, MediaWiki-Internationalization