Nirmos
Clown

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 18 2015, 1:31 AM (187 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Nirmos [ Global Accounts ]

Recent Activity

Yesterday

Nirmos reopened T204616: Remove unexpected line-break from Special:Gadgets between "required rights" list and "on by default" as "Open".

Now there is no line break between "(View source | Export)" and "Uses:"

Thu, Sep 20, 5:20 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Performance-Team, Gadgets

Sun, Sep 16

Nirmos added a comment to T204457: Incoherent styling of number on a list in bold when part of one item in the list is not bold.

If I'm reading https://developer.mozilla.org/en-US/docs/Web/HTML/Element/b correctly, then the b tag only accepts phrasing content as content, and according to https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Content_categories#Phrasing_content neither ol nor li belongs to that category, so as I understand it, the input is invalid.

Sun, Sep 16, 9:54 PM · MediaWiki-Parser
Nirmos added a comment to T204457: Incoherent styling of number on a list in bold when part of one item in the list is not bold.

Produced HTML:

<p>
	<b>
	</b>
</p>
<b></b>
<ol>
	<b>
		<li>a b c</li>
		<li>d e f</li>
	</b>
	<li>
		<b>g </b>
		h
		<b> i</b>
	</li>
	<b>
		<li>j k l</li>
		<li>m n o</li>
	</b>
</ol>
<b></b>
<p>
	<b></b>
</p>
Sun, Sep 16, 7:51 PM · MediaWiki-Parser

Tue, Sep 11

Nirmos added a comment to T197617: TemplateStyles should be able to add skin-specific CSS.

You have misspelled "minerva" as "minera" in https://zh.wikipedia.beta.wmflabs.org/wiki/Wikipedia:%E9%A6%96%E9%A1%B5/styles.css

Tue, Sep 11, 8:44 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, TemplateStyles

Tue, Aug 28

Liuxinyu970226 awarded T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015) a Like token.
Tue, Aug 28, 1:32 PM · Performance-Team, JavaScript, MediaWiki-ResourceLoader

Aug 21 2018

Nirmos added a comment to T202073: Flaky unit test AbuseFilterConsequencesTest.

Shouldn't the comment in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/454285/2/tests/phpunit/AbuseFilterTest.php be updated too?

Aug 21 2018, 3:14 PM · MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Technical-Debt, AbuseFilter, Wikimedia-production-error (Shared Build Failure)

Aug 14 2018

Nirmos added a comment to T135963: Add support for Content-Security-Policy (CSP) headers in MediaWiki.

The description mentions some onerror attribute that I've never heard of:

CSP disables all the inline ways of executing javascript (e.g. <img onerror="alert(1)"> )

Will this also affect onclick attributes?

Aug 14 2018, 3:33 AM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Core-Platform-Team, Epic, Security-Team

Aug 7 2018

Nirmos added a comment to T201393: Add Galician Wikipedia to wikistream.

As far as I can see, https://stream.wikimedia.org/v2/stream/recentchange works perfectly for glwiki. I'm testing this personally on https://sv.wikipedia.org/wiki/Wikipedia:Senaste_%C3%A4ndringar/EventStreams with the gadget that I have made: https://sv.wikipedia.org/wiki/MediaWiki:Gadget-EventStreams.js

Aug 7 2018, 10:20 AM · Wikimedia-Stream

Jul 27 2018

Nirmos created T200506: Previewing a non-style-only gadget that you already have enabled causes a syntax error.
Jul 27 2018, 10:06 AM · MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Performance-Team, MediaWiki-ResourceLoader

Jul 23 2018

Nirmos added a comment to T199416: Cache update time for Gadgets and Common.js/css regressed from 5 min to 1 hour.

It has nothing to do with lang=ru. It's the same problem on svwiki.

Jul 23 2018, 5:53 PM · MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review, Core-Platform-Team, Multi-Content-Revisions, Regression, MediaWiki-ResourceLoader, Performance-Team

Jul 21 2018

Nirmos added a comment to T191452: Deploy TemplateStyles on French Wikipedia on 2018-07-19.

While starting to clean Commons.css, one of the administrators wondered if TemplateStyles might extend the loading time (parsing, possible duplication, ...). Do we know if this has a negative impact on performance?

See T185853. Even in the worst case scenario (i.e. in the migration period when styles in the MediaWiki namespace and styles from TemplateStyles are loaded at the same time) there was no measurable change in performance. In theory, TemplateStyles would be good for sparsely used templates, and bad for ubiquitous templates, but since we did not observe any such thing, my guess is that the amount of CSS that is local to a wiki is so small in proportion to the total amount of CSS. Unfortunately, I don't have any numbers to support that – it's just a gut feeling.

Jul 21 2018, 11:26 AM · Patch-For-Review, User-Zoranzoki21, Wikimedia-Site-requests, TemplateStyles

Jul 19 2018

Nirmos added a comment to T110353: Audit use of cookies.

There is also svwiki-mw-tour, set to expire 1969-12-31T23:59:59.000Z (and yes, I actually can see this under Network → Cookies → Request Cookies in Chrome, not just under Application → Cookies).

Jul 19 2018, 1:24 PM · Epic, Sysadmin-notice, Performance-Team, Wikimedia-General-or-Unknown

Jul 18 2018

Nirmos added a comment to T12331: Introduce page creation log.

Good idea, but could you, please, add filtering by namespace? Thank you.

Jul 18 2018, 6:50 PM · MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), Patch-For-Review, MediaWiki-Logging, User-notice, MediaWiki-Page-editing, TechCom-RFC, Collaboration-Team-Triage, MediaWiki-Special-pages

Jul 14 2018

Nirmos added a watcher for Gadgets: Nirmos.
Jul 14 2018, 12:11 AM

Jul 6 2018

Nirmos added a comment to T190015: Create separate user group for editing sitewide CSS/JavaScript that does not include administrators by default.

If this is the case, then there wouldn't be interface editors at some wikis.

The idea of an interface editor or engineer group that is meant to be more accessible than sysop is indeed backwards with regard to security.

Jul 6 2018, 2:48 PM · MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core

Jul 3 2018

Nirmos updated the task description for T198725: Deploy TemplateStyles on huwiktionary.
Jul 3 2018, 5:12 PM · Patch-For-Review, User-Urbanecm, Wikimedia-Site-requests, TemplateStyles

Jun 26 2018

gabriel-wmde awarded T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015) a Like token.
Jun 26 2018, 4:41 PM · Performance-Team, JavaScript, MediaWiki-ResourceLoader
Nirmos added a comment to T110353: Audit use of cookies.

How are you viewing this data exactly?

I used the Storage tab in Firefox. If I instead use the Network tab, cpPosIndex, UseCDNCache and UseDC are not present.

Jun 26 2018, 1:53 AM · Epic, Sysadmin-notice, Performance-Team, Wikimedia-General-or-Unknown

Jun 25 2018

Nirmos added a comment to T110353: Audit use of cookies.

cpPosIndex, UseCDNCache and UseDC definitely do not go away with two minutes of browsing. Also, I started my computer this evening (the 25th) and as you can see these cookies have an "Expires" date for the 24th, i.e. a date that has already occured.

Jun 25 2018, 9:31 PM · Epic, Sysadmin-notice, Performance-Team, Wikimedia-General-or-Unknown

Jun 21 2018

Nirmos added a comment to T110353: Audit use of cookies.

Here are the cookies I have, if that helps:

centralauth_Session
centralauth_Token
centralauth_User
cpPosIndex
forceHTTPS
GeoIP
loginnotify_prevlogins
svwikircfilters-toplinks-collapsed-state
svwikiSession
svwikiUserID
svwikiUserName
UseCDNCache
UseDC
VEE
wikiEditor-0-booklet-characters-page
wikiEditor-0-booklet-help-page
WMF-Last-Access-Global
WMF-Last-Access
Jun 21 2018, 9:30 AM · Epic, Sysadmin-notice, Performance-Team, Wikimedia-General-or-Unknown
Nirmos renamed T197846: JavaScript parse error from "JavaScript parse error" when using URLParams.delete in custom JS to JavaScript parse error.
Jun 21 2018, 8:53 AM · Performance-Team, MediaWiki-ResourceLoader
Nirmos created T197846: JavaScript parse error.
Jun 21 2018, 8:28 AM · Performance-Team, MediaWiki-ResourceLoader

Jun 16 2018

Nirmos added projects to T197451: Incorrect formatting of "Lua - minnesanvändning" ("Lua memory usage") in Parser Profiling Data in Swedish Wikipedia: I18n, MediaWiki-extensions-Scribunto.

The relevant messages here are scribunto-limitreport-memusage-value-html and size-megabytes.

Jun 16 2018, 1:12 PM · MediaWiki-extensions-Scribunto, I18n, MediaWiki-Debug-Logger, MediaWiki-Parser

Jun 14 2018

Nirmos added a comment to T197061: ps.wikivoyage not appearing in www.wikivoyage.org.

I made an edit request at https://meta.wikimedia.org/wiki/Talk:Www.wikivoyage.org_template#Pashto

Jun 14 2018, 3:31 PM · Discovery, Wikimedia-Portals
Nirmos added a comment to T190015: Create separate user group for editing sitewide CSS/JavaScript that does not include administrators by default.

there’s no reason a wiki cannot locally decide to add their sysops to the new group too

The problem here is that there are many wikis that do not have any bureaucrats. These projects would effectively lose the ability to edit their own site-wide CSS and JS.

Jun 14 2018, 2:14 PM · MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core

Jun 12 2018

Nirmos added a comment to T196802: Remove deprecated mediawiki.api.* dependencies from extensions.

Just noting here that there are two modules mentioned in ecc812f0 that are not present in PerfektesChaos's comment. These are:
mediawiki.api.login
mediawiki.api.rollback

Jun 12 2018, 11:56 AM · Readers-Web-Backlog (Tracking), MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, MediaWiki-extensions-General

Jun 10 2018

Nirmos created T196847: titles parameter is broken on Special:ApiSandbox.
Jun 10 2018, 2:53 PM · MediaWiki-API, MediaWiki-Special-pages
Nirmos added a project to T188383: Spaces and tabs used interchangeably at Special:ApiSandbox: MediaWiki-API.

(Most tasks regarding ApiSandbox seem to be tagged as MediaWiki-API, not MediaWiki-Special-pages, hence the retag)

Jun 10 2018, 2:29 PM · MediaWiki-API, MediaWiki-Special-pages

Jun 5 2018

Nirmos added a comment to T196440: Provide a clearer way to distinguish between "absent" and empty/blank parameters when handling them in templates and parser functions.

https://test.wikipedia.org/

Jun 5 2018, 7:35 PM · MediaWiki-Parser, MediaWiki-Templates, MediaWiki-extensions-ParserFunctions
Nirmos created T196471: PHP fatal error: Call to undefined method __PHP_Incomplete_Class::getEntityType().
Jun 5 2018, 2:51 PM · Wikidata-Campsite, Wikibase-DataModel-Serialization, MediaWiki-extensions-WikibaseClient, Wikidata, Wikimedia-production-error

Jun 2 2018

Nirmos added a comment to T167246: Refactor "user" & "user_text" fields into "actor" reference table.

Will this task (and/or the parent task T161671) allow us to do cross-searches between page and user? For example: "Give me the edits on Wikipedia:Village_pump_(technical) by Nirmos".

Jun 2 2018, 12:35 AM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Epic, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), MediaWiki-Database

May 30 2018

Nirmos added a comment to T195946: Allow editors to style main page's differently from other pages for performance and to allow creativity (e.g. MediaWiki:Mainpage.css).

This task seems like a special case of the more generic T63007. I think it would be better to solve that task instead. If that task is solved, you have solved it for any page, not just the main page, and not just for CSS, but JavaScript too.

May 30 2018, 9:42 PM · Performance-Team, MediaWiki-ResourceLoader, MediaWiki-Interface, MediaWiki-Platform-Team, Readers-Web-Backlog, Performance

May 24 2018

Nirmos added a comment to T157418: RFC: Make some aspects of Tidy's whitespace stripping behavior part of wikitext parsing "spec".

Does this task have anything to do with the fact that

== Innehåll ==

is changed to

==Innehåll==

in https://sv.wikipedia.org/w/index.php?diff=42944724?

May 24 2018, 12:28 AM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Tidy, Community-Relations-Support, Parsoid, MediaWiki-Parser
Nirmos added a comment to T184485: Stop logging autopatrol actions.
May 24 2018, 12:27 AM · User-Ladsgroup, MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Wikidata-Ministry-Of-Magic-Tech-Debt, Wikidata-Ministry-Of-Magic, User-notice, TechCom-RFC (TechCom-Approved), User-ArielGlenn, MediaWiki-Patrolling, Patch-For-Review, MediaWiki-Logging

May 20 2018

Nirmos added a comment to T195222: Create a <codenowiki>/<nowikicode> tag.

Wouldn't it be easier to create a template with the content

<code>{{#tag:nowiki|{{{1}}}}}</code>

?

May 20 2018, 7:21 PM · MediaWiki-Parser

May 19 2018

Nirmos added a comment to T60082: MwEmbedSupport injects too many JavaScript configuration variables.

And, for completeness

{
	const regex = /EmbedPLayer\./i;
	Object.keys( mw.config.get() ).filter( v => regex.test( v ) ).length;
}

gives 46, which means EmbedPLayer.IFramePlayer.DomainWhiteList is the only key with any capitalization error in that part of the name (that is, before the first dot).

May 19 2018, 1:14 PM · MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, Performance-Team (Radar), TimedMediaHandler-Player, MediaWiki-extensions-MwEmbedSupport, TimedMediaHandler
Nirmos added a comment to T60082: MwEmbedSupport injects too many JavaScript configuration variables.

Wooooaaahhh. I wrote

Object.keys( mw.config.get() ).filter( v => v.startsWith( 'EmbedPLayer.' ) );

in the console to see how many keys there are, and was surprised when I only got one value in the array. Turns out that one of the keys is misspelled. See the capital L in PLayer?

May 19 2018, 11:49 AM · MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, Performance-Team (Radar), TimedMediaHandler-Player, MediaWiki-extensions-MwEmbedSupport, TimedMediaHandler

May 17 2018

Nirmos added a comment to T28508: Content Security Policy (CSP).

Will I as a gadget author have access to the violation reports for svwiki?

May 17 2018, 10:18 PM · Front-end-Standards-Group, Security, Security-Team, WorkType-NewFunctionality, MediaWiki-General-or-Unknown

May 9 2018

Nirmos added a comment to T190015: Create separate user group for editing sitewide CSS/JavaScript that does not include administrators by default.

I would also like to challenge

You can't mass vandalize wikipedia using CSS.

May 9 2018, 2:10 PM · MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core
Nirmos added a comment to T190015: Create separate user group for editing sitewide CSS/JavaScript that does not include administrators by default.

I could live with "tech(nical)? (admin|sysop)" or "technician".

May 9 2018, 12:39 PM · MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core

May 7 2018

Nirmos added a comment to T190015: Create separate user group for editing sitewide CSS/JavaScript that does not include administrators by default.

What's wrong with just "developer"? Is it because Wikimedia folk usually say "the developers" when they mean WMF staff, and you want to avoid confusion?

May 7 2018, 8:11 PM · MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core

Apr 28 2018

Nirmos added a project to T193263: PHP BadMethodCallException exception on load.php: MediaWiki-ResourceLoader.

I'm pretty sure the BadMethodCallException is PHP, not JavaScript. The code below that is JavaScript, though.

Apr 28 2018, 5:25 AM · MediaWiki-ResourceLoader, Performance-Team, JavaScript, MediaWiki-General-or-Unknown
Nirmos added a comment to T193254: Global renames get stuck at metawiki.

Is this because of https://gerrit.wikimedia.org/r/419520 for T167246?

Apr 28 2018, 5:11 AM · Services (done), Analytics, EventBus, MediaWiki-JobQueue, Operations, Wikimedia-production-error, GlobalRename, Wikimedia-Site-requests, MediaWiki-extensions-CentralAuth

Apr 27 2018

Nirmos added a comment to T193199: Styles, scripts missing in Russian Wikipedia.

Now that this has happened, I suppose what needs to be determined is: Was this a one-time hickup, or will the same thing happen next week? If the former, there's not much use beating a dead horse, and this task can probably be closed. If the latter, I'd like to see some effort from the WMF going in to investigating this.

Apr 27 2018, 2:52 PM · Performance-Team, MediaWiki-ResourceLoader, Regression

Apr 26 2018

Nirmos added a comment to T193199: Styles, scripts missing in Russian Wikipedia.

T193091 was filed about this.

Apr 26 2018, 9:05 PM · Performance-Team, MediaWiki-ResourceLoader, Regression
Nirmos added a comment to T193091: common.css is not loaded in hewiki.

Could someone remind me, is hewiki one of the two Wikipedias that get new software updates one day early? Is it hewiki and cawiki?

Apr 26 2018, 6:57 AM · Performance-Team, MediaWiki-ResourceLoader, Wikimedia-General-or-Unknown

Apr 23 2018

Nirmos added a comment to T189375: MediaWiki:Common.css does not allow starting and trailing space inside url().

I'm a little bit confused here. This bug is about quoted URLs, and that's also what the commit message in https://gerrit.wikimedia.org/r/428371 says. However, RELEASE-NOTES-1.31 says unquoted URLs. Have you actually fixed two different issues here, or is the wording in the release notes a mistake?

Apr 23 2018, 5:28 PM · MW-1.31-release-notes, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader

Apr 18 2018

Nirmos created T192431: Previewing user JavaScript runs without script validation checks.
Apr 18 2018, 7:12 AM · MediaWiki-ResourceLoader, Performance-Team

Apr 16 2018

Nirmos added a comment to T192236: Add tag filter to Special:ListFiles.

If I understand your problem correctly, then resolving this task will not solve your problem because:

  1. As far as I know, there is not (yet) any infrastructure for filtering out edits with a certain tag. The inverse (only showing edits with a certain tag) does exist, but that's not what we want to do here.
  2. As far as I know, tags aren't applied retroactively.

In lieu of support from MediaWiki to do this, we can use JavaScript and CSS. You can add

$( function() {
	'use strict';
	if ( mw.config.get( 'wgCanonicalSpecialPageName' ) === 'Listfiles' ) {
		$( '#mw-content-text' ).prepend( '<button type="button" id="gadget-toggleflickr2commons" title="Toggle visibility of images uploaded using Flickr2Commons.">Toggle Flickr2Commons</button>' );
		$( '#gadget-toggleflickr2commons' ).click( function() {
			$( '.TablePager_col_img_description' ).each( function( i, e ) {
				if ( $( e ).text() === 'Transferred from Flickr via Flickr2Commons' ) {
					$( e ).closest( 'tr' ).toggleClass( 'gadget-toggleflickr2commons' );
				}
			} );
		} );
	}
} );

to Special:MyPage/common.js. This adds a button at the top of Special:ListFiles. When you click it, it will add the HTML class "gadget-toggleflickr2commons" to all rows where the description is "Transferred from Flickr via Flickr2Commons".

Apr 16 2018, 3:23 PM · MediaWiki-Change-tagging, MediaWiki-Special-pages, Commons, Multimedia
Nirmos added a project to T192241: Abuse filters cannot be edited without javascript: Accessibility.
Apr 16 2018, 6:58 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), CodeEditor, Regression, AbuseFilter

Apr 13 2018

Nirmos closed T192130: wikipage.content fired twice on RecentChanges with live updates as Invalid.

Ah, I see! So I have to change my code to

mw.hook( 'wikipage.content' ).add( function( elements ) {
	'use strict';
	if ( elements.hasClass( 'mw-changeslist' ) ) {
		console.log( 'wikipage.content fired' );
	}
} );

Thank you!

Apr 13 2018, 2:56 PM · Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage
Nirmos created T192130: wikipage.content fired twice on RecentChanges with live updates.
Apr 13 2018, 4:40 AM · Edit-Review-Improvements-RC-Page, Collaboration-Team-Triage

Apr 9 2018

Nirmos added a comment to T191652: ResourceLoader addModuleStyles() ignores dependencies..

We also fixed several other context bugs that caused ResourceLoader to rapidly evict the cache due to it not handling cache keys correctly.(Thus causing slow downs due to having to recache constantly.)

Is this referring to T188076?

Apr 9 2018, 5:47 PM · Performance-Team, MediaWiki-ResourceLoader

Apr 8 2018

Nirmos added a comment to T134469: doBlockLevels() inserts <p> and </p> randomly with no regard for HTML validity.

Is this the same as T11207?

Apr 8 2018, 11:47 AM · MediaWiki-Parser
Nirmos merged T191717: Use of async makes loader fail into T75714: ResourceLoader JavaScript parser should allow ES6 syntax features .
Apr 8 2018, 11:40 AM · Performance-Team, MediaWiki-ResourceLoader
Nirmos merged task T191717: Use of async makes loader fail into T75714: ResourceLoader JavaScript parser should allow ES6 syntax features .
Apr 8 2018, 11:40 AM · MediaWiki-ResourceLoader, Performance-Team
Nirmos added a project to T191596: Regression: Module mobile.site.styles is not being loaded with mobile.site module: Regression.
Apr 8 2018, 10:53 AM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Performance-Team (Radar), Readers-Web-Backlog, MediaWiki-ResourceLoader, Regression, MobileFrontend
Nirmos added a comment to T125222: Support a given subpage as the "official" documentation subpage for templates, to avoid duplicate TemplateData.

So, I came here from https://sv.wikipedia.org/w/index.php?oldid=42703510. Now, I don't understand the VE or TemplateData stuff, but I do know what doc pages are. Is the purpose of this task to determine what doc pages usually are called on different projects? In that case, you must have gotten it wrong, at least for svwiki. https://sv.wikipedia.org/w/index.php?search=intitle%3A%2F%5C%2Fdok%2F&ns10=1 shows that there are 2 097 pages in the Template namespace where the title matches the regular expression /\/dok/. The same search with a capital D (https://sv.wikipedia.org/w/index.php?search=intitle%3A%2F%5C%2FDok%2F&ns10=1) shows 4 pages.

Apr 8 2018, 6:41 AM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), VisualEditor (Current work), TemplateData

Apr 6 2018

Nirmos added a comment to T133410: Deploy TemplateStyles to WMF production.

Not sure I understand your question. Are you asking how to fix the lint errors so that wikis can switch from Tidy to Remex? In that case, there is plenty of information on https://www.mediawiki.org/wiki/Help:Extension:Linter and its subpages.

Apr 6 2018, 11:24 AM · Epic, Performance-Team (Radar), User-notice, Readers-Web-Backlog (Tracking), Traffic, Operations, Wikimedia-Extension-setup, TemplateStyles
Nirmos added a comment to T191452: Deploy TemplateStyles on French Wikipedia on 2018-07-19.

This task is about French Wikipedia, but Deskana's link goes to French Wiktionary. Here's the relevant link: https://fr.wikipedia.org/wiki/Sp%C3%A9cial:LintErrors

Apr 6 2018, 11:10 AM · Patch-For-Review, User-Zoranzoki21, Wikimedia-Site-requests, TemplateStyles

Apr 5 2018

Nirmos added a comment to T186965: Output HTML should not contain `<p><style>...</style></p>`.

I just want to make sure I understand this correctly. When I first complained about this, it was because this edit failed. This still fails, so what you have done instead is allowing the templatestyles tag to be placed on its own line. However, there are still cases when the line break is significant and unwanted, as can be seen in https://sv.wikipedia.org/wiki/Mall:Audio, so always adding it on its own line does not seem to be an option either.

Apr 5 2018, 1:54 AM · Parsoid-Read-Views, MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), MediaWiki-Parser, RemexHtml, Patch-For-Review, TemplateStyles

Apr 4 2018

Nirmos added a comment to T42812: jquery.makeCollapsible: Refactor to use CSS instead of JavaScript to do the expansion/collapse (including initial state).

Note on slow connections, collapsed content will not be accessible until the JavaScript has fully loaded, however this is arguably less of a problem then the existing reflows.

This sounds exactly like what I was afraid of in T42812#3351094 and what matmarex and Krinkle assured me would not happen.

Apr 4 2018, 11:40 PM · MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), MediaWiki-ResourceLoader, Performance-Team (Radar), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Vector, Readers-Web-Backlog, CSS, JavaScript, MediaWiki-Interface
Nirmos added a comment to T191468: Undefined variable: mode in extensions/AbuseFilter/includes/AbuseFilter.php on line 491.

I think it's because of @Daimona's attempt at making AbuseFilter work with https://www.mediawiki.org/wiki/Optimistic_save to solve T176291 et al.

Apr 4 2018, 8:35 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), AbuseFilter, Wikimedia-production-error
Nirmos updated subscribers of T191468: Undefined variable: mode in extensions/AbuseFilter/includes/AbuseFilter.php on line 491.
Apr 4 2018, 8:32 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), AbuseFilter, Wikimedia-production-error
Nirmos updated the task description for T188849: Flow comments start and end with a lot of whitespace.
Apr 4 2018, 12:33 AM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions

Apr 2 2018

Nirmos added a comment to T191134: TemplateStyles removes space between solid and #aaa.

Thank you!

Apr 2 2018, 6:42 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Browser-Support-Internet-Explorer, css-sanitizer, TemplateStyles
Nirmos added a comment to T175438: Hits from private AbuseFilters aren't in the stream.

Filter hits aren't in RecentChanges, regardless of whether the filter is private or not.

Apr 2 2018, 5:21 PM · Wikimedia-Stream, Analytics, EventBus

Mar 31 2018

Nirmos added a comment to T191134: TemplateStyles removes space between solid and #aaa.

Mar 31 2018, 7:34 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Browser-Support-Internet-Explorer, css-sanitizer, TemplateStyles
Nirmos added a comment to T191134: TemplateStyles removes space between solid and #aaa.

I have confirmed that IE11 has this bug.

Mar 31 2018, 6:03 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Browser-Support-Internet-Explorer, css-sanitizer, TemplateStyles
Nirmos added a project to T191134: TemplateStyles removes space between solid and #aaa: Browser-Support-Internet-Explorer.
Mar 31 2018, 6:30 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Browser-Support-Internet-Explorer, css-sanitizer, TemplateStyles
Nirmos created T191134: TemplateStyles removes space between solid and #aaa.
Mar 31 2018, 6:19 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Patch-For-Review, Browser-Support-Internet-Explorer, css-sanitizer, TemplateStyles

Mar 29 2018

Nirmos closed T189818: Special:Nearby regression in #/page/{title} route as Resolved.

I can no longer reproduce this problem, so I'm marking this as resolved.

Mar 29 2018, 11:48 AM · Readers-Web-Backlog, Regression, MediaWiki-Special-pages

Mar 26 2018

Nirmos updated subscribers of T190636: On the Swedish Wikipedia main page with the Timeless skin, background icons are repeated in "På andra projekt" in the sidebar.

Ok, I've investigated this further now. The hyperspecific CSS rules I complained about above are from https://sv.wikipedia.org/wiki/MediaWiki:Gadget-InterProjectLinks.css (I didn't realize this at the time I wrote that). However, they are there because Vector has these ridiculously specific rules:

#mw-panel .portal .body li {
	line-height: 1.125em;
	margin: 0;
	padding: 0.25em 0;
	font-size: 0.75em;
	word-wrap: break-word;
}

This is the core problem as I see it (unless the rabbit hole goes even deeper). @matmarex, @Volker_E: Is there any chance Vector's specificity here could be lowered? Otherwise we're just playing this ridiculous game about who can shout the loudest.

Mar 26 2018, 4:04 PM · Wikimedia-General-or-Unknown
Nirmos added a comment to T190636: On the Swedish Wikipedia main page with the Timeless skin, background icons are repeated in "På andra projekt" in the sidebar.

The issue at svwiki is solved, but I'd still consider the fault to be on either:

  1. The Timeless skin that for reasons I can't explain does not reuse the same ids, classes or HTML structure (why can't #mw-site-navigation be called #mw-panel?) and/or
  2. The overly specific CSS selectors (why can't #mw-panel div.portal div.body ul li.wb-otherproject-link be changed to simply .wb-otherproject-link?)
Mar 26 2018, 3:39 PM · Wikimedia-General-or-Unknown
Nirmos added a comment to T190636: On the Swedish Wikipedia main page with the Timeless skin, background icons are repeated in "På andra projekt" in the sidebar.

Added

#p-wikibase-otherprojects .mw-portlet-body ul .wb-otherproject-link {
	background-repeat: no-repeat;
	background-position: left center;
	padding-left: 18px;
}

to https://sv.wikipedia.org/wiki/MediaWiki:Gadget-InterProjectLinks.css in https://sv.wikipedia.org/w/index.php?diff=42642259

Mar 26 2018, 3:22 PM · Wikimedia-General-or-Unknown
Nirmos added a comment to T190636: On the Swedish Wikipedia main page with the Timeless skin, background icons are repeated in "På andra projekt" in the sidebar.

As far as I can see, there is a CSS rule that looks like this:

li.interProject,
.portlet .wb-otherproject-link,
#mw-panel div.portal div.body ul li.interProject,
#mw-panel div.portal div.body ul li.wb-otherproject-link {
	background-repeat: no-repeat;
	background-position: left center;
	padding-left: 18px;
	margin-left: 0;
}

This is not applied in Timeless.

Mar 26 2018, 3:09 PM · Wikimedia-General-or-Unknown

Mar 15 2018

Nirmos added a comment to T189818: Special:Nearby regression in #/page/{title} route.

Thanks!

Mar 15 2018, 10:33 PM · Readers-Web-Backlog, Regression, MediaWiki-Special-pages
Nirmos added a comment to T189818: Special:Nearby regression in #/page/{title} route.

No, I can't reproduce the issue on https://reading-web-staging.wmflabs.org/wiki/Special:Nearby#/page/Spain. Thanks! I suppose this can be closed as resolved. Do you know when this will be deployed to WMF wikis?

Mar 15 2018, 9:57 PM · Readers-Web-Backlog, Regression, MediaWiki-Special-pages
Nirmos added a comment to T189818: Special:Nearby regression in #/page/{title} route.

Could you elaborate on what you mean by a race condition?

When I load https://sv.wikipedia.org/wiki/Special:N%C3%A4ra#/page/Oslo I sometimes get articles near Oslo, and sometimes articles near myself.

Are you able to replicate the same issue on https://reading-web-staging.wmflabs.org/wiki/Special:Nearby ?

Hard to say. I'm having trouble connecting to that site (it's really slow for me). Also, there is, as far as I can see, only one article there with coordinates (Spain).

Mar 15 2018, 9:39 PM · Readers-Web-Backlog, Regression, MediaWiki-Special-pages
Nirmos added a comment to T125820: Special:Nearby lacks to show purpose of the feature to the user.

I created T189818 about the race condition you have introduced.

Mar 15 2018, 9:21 PM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Patch-For-Review, Readers-Web-Kanbanana-Board-Old, Readers-Web-Backlog, Design, MW-1.28-release (WMF-deploy-2016-06-07_(1.28.0-wmf.5)), MobileFrontend
Nirmos created T189818: Special:Nearby regression in #/page/{title} route.
Mar 15 2018, 9:07 PM · Readers-Web-Backlog, Regression, MediaWiki-Special-pages
Nirmos added a comment to T188760: Allow TemplateStyles (via css-sanitizer) to use protocol-relative URLs.

The nomination failed, so this is now out of my hands.

Mar 15 2018, 4:38 PM · Patch-For-Review, TemplateStyles
Nirmos updated subscribers of T63007: Allow specifying when a gadget should load (conditional, page title, action or namespace).

So, this task is kind of two-pronged in that there's partly an extension of MediaWiki:Gadgets-definition (see T145997 for an example) that's being discussed, and partly per-page loading with for example
<load module="ext.gadget.MyAmazingGadget"/> that would be added to a page's wikitext. While an extension to MediaWiki:Gadgets-definition would be a lot more powerful and be of use for more gadgets, I assume that this would also be more difficult.

Mar 15 2018, 11:17 AM · Wikimedia-Israel-Hackers, Gadgets
Restricted Application added a project to T145997: [RFC] Filter gadgets server-side?: Performance-Team.
Mar 15 2018, 11:17 AM · Performance-Team, Proposal, Performance, MediaWiki-ResourceLoader

Mar 10 2018

Nirmos updated the task description for T189374: WikimediaBadges should use c:File:Rekommenderad_grön.svg for recommended articles.
Mar 10 2018, 3:07 PM · MediaWiki-extensions-WikimediaBadges
Nirmos added a comment to T189373: Create Phabricator tag for Extension:WikimediaBadges.

Thank you!

Mar 10 2018, 3:01 PM · User-MarcoAurelio, MediaWiki-extensions-WikimediaBadges, Project-Admins
Nirmos created T189375: MediaWiki:Common.css does not allow starting and trailing space inside url().
Mar 10 2018, 2:58 PM · MW-1.31-release-notes, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader
Nirmos triaged T189374: WikimediaBadges should use c:File:Rekommenderad_grön.svg for recommended articles as Lowest priority.
Mar 10 2018, 2:13 PM · MediaWiki-extensions-WikimediaBadges
Nirmos created T189374: WikimediaBadges should use c:File:Rekommenderad_grön.svg for recommended articles.
Mar 10 2018, 2:13 PM · MediaWiki-extensions-WikimediaBadges
Nirmos created T189373: Create Phabricator tag for Extension:WikimediaBadges.
Mar 10 2018, 1:40 PM · User-MarcoAurelio, MediaWiki-extensions-WikimediaBadges, Project-Admins
Nirmos added a comment to T189349: Enabled filters should have at least one action to take.

I'm not sure this change would be very well received by the community. Sometimes, for various reasions, people only want to log actions. Recently, this was done on enwiki in https://en.wikipedia.org/wiki/Special:AbuseFilter/905 for T32750/T188960.

Mar 10 2018, 5:01 AM · AbuseFilter

Mar 7 2018

Nirmos added a comment to T189095: Template inclusion with minus followed by an opening curly brace stops parser and prevents inclusion.

There is also https://www.mediawiki.org/wiki/Writing_systems/LanguageConverter

Mar 7 2018, 10:29 AM · MediaWiki-Templates, MediaWiki-Parser
Nirmos added a comment to T189095: Template inclusion with minus followed by an opening curly brace stops parser and prevents inclusion.

Or https://www.mediawiki.org/wiki/Writing_systems/Syntax perhaps?

Mar 7 2018, 10:25 AM · MediaWiki-Templates, MediaWiki-Parser
Nirmos added a comment to T189095: Template inclusion with minus followed by an opening curly brace stops parser and prevents inclusion.

Does https://www.mediawiki.org/wiki/Writing_systems help you?

Mar 7 2018, 10:24 AM · MediaWiki-Templates, MediaWiki-Parser

Mar 6 2018

Nirmos added a comment to T185853: Monitor changes in performance due to TemplateStyles in tandem with on-wiki migration?.

I thought we had established in T185853#3966830 that the amount of styles is so small that it does not affect performance. I've been meaning to ask if this task should be closed, but other things have gotten in the way.

Mar 6 2018, 12:50 PM · Performance-Team
Nirmos added a comment to T71492: Edits which hit the condition limit should be tagged.

Wow! If you have done what I think you have done, this deserves all the story points and user notices it can get! I'm very much looking forward to seeing this in action!

Mar 6 2018, 2:36 AM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), AbuseFilter

Mar 4 2018

Nirmos triaged T188849: Flow comments start and end with a lot of whitespace as Lowest priority.
Mar 4 2018, 4:12 AM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions
Nirmos created T188849: Flow comments start and end with a lot of whitespace.
Mar 4 2018, 4:12 AM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions
Nirmos added a comment to T188737: In the list of "templates used on this page" when editing, highlight redirect templates by italicising them (like we do elsewhere)..

First of all, thank you so much for making a patch for this, and so quickly too!

Mar 4 2018, 12:12 AM · MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Patch-For-Review, Easy, MediaWiki-Interface

Mar 3 2018

Nirmos added a comment to T188760: Allow TemplateStyles (via css-sanitizer) to use protocol-relative URLs.

Done. This is now https://meta.wikimedia.org/wiki/Steward_requests/Global_permissions#global-interface-editor_for_Nirmos

Mar 3 2018, 2:55 AM · Patch-For-Review, TemplateStyles