Fri, Sep 22
Thu, Sep 21
Wed, Sep 20
this is what im seeing on 100% and 110% on beta mode / safari / ios / ru.m
@Yanpas looks like you have enabled beta mode. would you mind going to settings and checking the font size settings?
@ovasileva the copy looks good, just changing "save" to "download" to reduce confusion with save/publish etc.
not a blocker
Tue, Sep 19
our message system doesn't have things like accessory icons and title etc... i honestly don't have a clear answer since this requires either us creating new messages or use old messages which won't convey what we are trying to convey :( debt biting us again. we can also do one off message right now. and then remove the code later.
That was if you want to create a book, you can still do so and only access it online. So I'd say, let's keep the banners on top of the page and add the remainder as is.
Due to severe issues with our current rendering system, PDF book printing will be unavailable in the short term. We are currently working on a replacement system we hope to deliver by November 2017. In the meantime, you can download the individual articles of a book using the "download as PDF" functionality from the sidebar. For feedback, please visit the project page here:
Mon, Sep 18
and this is how the grid will come in handy to lay the content :)
Let's create a lite version of this spec that I eventually want in marvin
Do we need to mention sans-serifs for all the platforms we have? won't the generic "sans-serif" take care of it automatically?
Thu, Sep 14
created article for MF https://phabricator.wikimedia.org/T175877
Updated the RHS a bit as well
Wed, Sep 13
Looks nice! It needs a "create chapter" button though. And it would be nice if the mockup showed how chapters are displayed (the old layout uses an indented list; that probably doesn't look nice with the drag panels).
Here's a future font stack that Mobilefrontend will use till we can actually use custom fonts
I think we should re-use an existing solution
yeah can we change the font stack in default print styles and if the renderer (a server or a person's computer) has a Charis as a font, it will use it?
Here's a mock
coming up the magic number would be difficult, let's go with 120 for now.
Tue, Sep 12
@bmansurov can we add the custom serif font on the backend as a requirement to this card?
I removed the tap area requirement.
this card is just about replacing the SVGs now.
Mon, Sep 11
is the solution to clear both sides of paragraphs? or we can jump on a call if this is a lot of back and forth
Sat, Sep 9
Fri, Sep 8
@ovasileva i thought we are stalling this as this is scope creep to print work
Thu, Sep 7
What is the goal at doing this?
@ovasileva and I talked about this today.
This is also browser specific behaviour isn't it ?
I'd guess not since we are generating the pdf in the background and don't know it's final size until it's done.
Wed, Sep 6
Yes. but that would be much later down the line.
Let's move to backlog Needs analysis as we don't know if this is us or firefox?
are you sure this is happening on production as well. if so, we should keep it in the backlog but move it out of current print work.
implication is it creates gaps in TD TH cells and borders :( i think you were the one who found that fix to the gap issue :)
@TheDJ This is done, resolving it. I will keep you updated on the upcoming improvements by WMDE on this.
@Andrew_Davidson Thank you!
This is because of page-break-before: avoid;
It's supposed to be #f8f9fa
wikilove to @pmiazga
Limiting floated left/right elements to a certain amount of space e.g. 50% of the screen / 33% of the screen
maybe I'm not following the steps correct but I can't reproduce this on production. that indicates not a mozilla bug?
Let's decline or stall and add to backlog. This is the behavior on production with existing styles.
two column design?
Tue, Sep 5
What do you mean here?
this is about the modal window to disable the page previews.
Mon, Sep 4
I just reviewed all the examples here.
Fri, Sep 1
@TheDJ do you mean buttons instead of links?
Thu, Aug 31
Wed, Aug 30
Spike not needed. this will be rolled back if we receive substantial feedback. stalling it for now.
@Niedzielski subtasks are not blockers afaik
Tue, Aug 29
Mon, Aug 28
Looks like the code achieves what the description is asking for.
resolving this. unlikely that this did not solve a problem.
@ovasileva see if this design ^ works, I can update the description after your okay.
Like on mobile, we could have a step between clicking "download as pdf" and trigger the file download.
will resolve after merge
just think of people who get disoriented looking at article wizard :)
Sorry, this is completely my fault for not following up on the styleguide grey > rgba conversion conversation and as a result the grey is not the correct one.