Page MenuHomePhabricator

Nomsterio (Noam Rosenthal)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 3 2020, 10:17 AM (72 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Nomsterio [ Global Accounts ]

Recent Activity

Mar 16 2021

Nomsterio added a comment to T276668: Regression: Settings button misplaced in article preview.

@Nomsterio - thank you for getting this started! do you have availability to continue working on a fix here?

Mar 16 2021, 6:23 AM · Performance-Team (Radar), MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews

Mar 9 2021

Nomsterio added a comment to T276668: Regression: Settings button misplaced in article preview.

@Nomsterio let me know if you have time to look into this one as well, thanks!

Mar 9 2021, 8:22 AM · Performance-Team (Radar), MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews

Mar 3 2021

Nomsterio added a comment to T276112: Regression: Page Previews and Reference Previews tip triangle is in the wrong location in RTL wikis.

Yes. Confirmed that via git bisect.

7b0937c5a865f282f7e5100613b1113a5990ef2e is the first bad commit
commit 7b0937c5a865f282f7e5100613b1113a5990ef2e
Author: Noam Rosenthal <noam.j.rosenthal@gmail.com>
Date:   Tue Dec 8 17:13:13 2020 +0200

    Use CSS clip-path instead of SVG when supported.
    
    This reduces a lot of churn in creating the SVG
    element and related helpers.
    
    When IE11 is dropped, the SVG code-path can also be dropped.
    
    Bug: T269336
    Change-Id: I7f91192dedc2a78f1c7c84179cff1687593177c0

 resources/dist/index.js               | Bin 43126 -> 43329 bytes
 resources/dist/index.js.map.json      | Bin 207213 -> 207998 bytes
 src/ui/renderer.js                    |  14 +++--
 src/ui/templates/popup/popup.less     | 106 ++++++++++++++++++++++++++++++++--
 src/ui/thumbnail.js                   |  34 +++++++----
 tests/node-qunit/ui/thumbnail.test.js |  15 ++++-
 webpack.config.js                     |   4 +-
 7 files changed, 147 insertions(+), 26 deletions(-)

Do we revert or try to revise? I'm guessing the CSS in /src/ui/templates/popup/popup.less needs revising for RTL. cc @Nomsterio @Gilles

Mar 3 2021, 9:26 AM · Performance-Team (Radar), MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews, RTL, I18n

Jan 26 2021

Nomsterio added a comment to T272169: Regression: Page-Previews seem to be blurred for thumbnails with natural height less than 200px..

Change 658493 had a related patch set uploaded (by Noam Rosenthal; owner: Noam Rosenthal):
[mediawiki/extensions/Popups@master] Fix bluriness on low-DPR screens

https://gerrit.wikimedia.org/r/658493

Jan 26 2021, 6:14 AM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Page-Previews

Jan 24 2021

Nomsterio added a comment to T272169: Regression: Page-Previews seem to be blurred for thumbnails with natural height less than 200px..

I can replicate this on browser stack in Windows and now understand the issue some more.

$('<img src="https://upload.wikimedia.org/wikipedia/commons/thumb/7/74/Computer_modern_sample.svg/640px-Computer_modern_sample.svg.png">').css({ 'object-fit': 'cover', width: '320px', 'min-height': '200px'}).appendTo('#content')

The image is 640px by 270px so it's not possible for it to be 320px x 200px without some blur. Ideally it would render at 320px by 135px.

@Nomsterio I see several other options here

  1. We request a bigger thumbnail. Perhaps the blur will go away? Note we're not rendering an SVG here, we're rendering a PNG version of an svg (don't ask ;-))

That's what the original code did, and in the attached change request I mimic that original behavior: loading a bigger PNG and clipping it.

Jan 24 2021, 7:18 AM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Performance-Team (Radar), Readers-Web-Backlog (Kanbanana-FY-2020-21), Patch-For-Review, Page-Previews

Jan 19 2021

Nomsterio added a comment to T269297: Performance optimization for popup rendering: Remove title attributes at init.

Yes, the solution of modifying on init was obviously not the right solution :)

Jan 19 2021, 7:26 AM · Page-Previews (Tracking), Performance-Team (Radar)

Jan 17 2021

Nomsterio added a comment to T269336: Preview popups: Replace SVG with clip-path.

T272169 got raised today which coinciding with the deployment here. I haven't been able to replicate it yet, but likely caused by this.

Does Windows have any documented rendering issues with clip path @Nomsterio ?

Jan 17 2021, 8:10 AM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Readers-Web-Backlog (Kanbanana-FY-2020-21), Browser-Support-Internet-Explorer, Page-Previews

Jan 13 2021

Nomsterio added a comment to T269297: Performance optimization for popup rendering: Remove title attributes at init.

@Gilles @Krinkle what is the performance recommendation here, given @matmarex and the revert that happened here?
Am moving this off our sprint board (and thus radar) for now until we can get clearer guidance on whether we still want to do this, and what we want to do differently.

Jan 13 2021, 6:54 PM · Page-Previews (Tracking), Performance-Team (Radar)

Dec 14 2020

Nomsterio added a comment to T269297: Performance optimization for popup rendering: Remove title attributes at init.

Yes, it's possible.

Dec 14 2020, 6:48 AM · Page-Previews (Tracking), Performance-Team (Radar)

Dec 3 2020

Nomsterio added a comment to T269336: Preview popups: Replace SVG with clip-path.

Could the existing SVG mechanic be kept as a fallback that only runs for IE11, with clip-path used for other browsers?

Dec 3 2020, 9:23 AM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Readers-Web-Backlog (Kanbanana-FY-2020-21), Browser-Support-Internet-Explorer, Page-Previews
Nomsterio created T269338: Popup extension: use templates instead of HTML parse.
Dec 3 2020, 9:05 AM · MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), Readers-Web-Backlog (Kanbanana-FY-2020-21), Page-Previews
Nomsterio created T269336: Preview popups: Replace SVG with clip-path.
Dec 3 2020, 9:03 AM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Readers-Web-Backlog (Kanbanana-FY-2020-21), Browser-Support-Internet-Explorer, Page-Previews

Nov 24 2020

Nomsterio added a comment to T267185: Story idea for Blog: Web platform performance case study: preview popups.

Looks great! Let's tweet it
Thanks @srodlund

Nov 24 2020, 3:41 PM · Performance-Team, Technical-blog-posts

Nov 20 2020

Nomsterio added a comment to T267185: Story idea for Blog: Web platform performance case study: preview popups.

Thanks!

Nov 20 2020, 7:07 PM · Performance-Team, Technical-blog-posts
Nomsterio added a comment to T267185: Story idea for Blog: Web platform performance case study: preview popups.

One idea, for the featured image we could use the big version of the Sloth/Anteater photo: https://commons.wikimedia.org/wiki/File:Myresluger2.jpg

Good idea!

Nov 20 2020, 6:07 PM · Performance-Team, Technical-blog-posts
Nomsterio added a comment to T267185: Story idea for Blog: Web platform performance case study: preview popups.

@Nomsterio I saw that you accepted changes on the doc -- If you feel this is ready, I can move it over to the blog to post early next week. Let me know.

Nov 20 2020, 6:06 PM · Performance-Team, Technical-blog-posts

Nov 17 2020

Nomsterio added a comment to T267185: Story idea for Blog: Web platform performance case study: preview popups.

@Nomsterio I took a first pass at this. Please don't be discouraged by the number of edits/suggestions. :-) The post is good and super-informative! It just needed a little more organizational structure. I made some additions and some obvious edits and would like you to go through and accept or decline my suggestions. After it will need some wordsmithing and editing, but I'd like to see what it looks like with the adjusted organizational structure.

Nov 17 2020, 6:10 AM · Performance-Team, Technical-blog-posts

Nov 4 2020

Nomsterio renamed T267185: Story idea for Blog: Web platform performance case study: preview popups from Story idea for Blog: ADD YOUR SUMMARY HERE to Story idea for Blog: Web platform performance case study: preview popups.
Nov 4 2020, 8:46 AM · Performance-Team, Technical-blog-posts
Nomsterio created T267185: Story idea for Blog: Web platform performance case study: preview popups.
Nov 4 2020, 8:45 AM · Performance-Team, Technical-blog-posts

Jun 21 2020

Nomsterio added a comment to T254335: Story idea for Blog: contributing paint-timing API to WebKit.

Nomsterio -- I finished making edits (including making some bigger changes to one paragraph I commented on). Let me know if it looks good, and I will move it over to the blog to prepare for publication.

Looks great. I did a little extra pass on it myself.

  • Who do you want listed as the authors of the doc

Myself and @Gilles, or clearly say that I'm the author and Gilles wrote the background as part of Wikipedia?

Jun 21 2020, 11:56 AM · Performance-Team (Radar), Technical-blog-posts

Jun 15 2020

Nomsterio added a comment to T254335: Story idea for Blog: contributing paint-timing API to WebKit.

@Nomsterio can you give me permission to edit the document directly? Right now I just have the ability to suggest. Thanks!

Done

Jun 15 2020, 4:38 PM · Performance-Team (Radar), Technical-blog-posts

Jun 14 2020

Nomsterio added a comment to T254335: Story idea for Blog: contributing paint-timing API to WebKit.

@Nomsterio I went through and left some suggested edits and comments on the doc. Once you've had a chance to address these, I'll go through again and do another edit. It's a lot, so let me know if you have questions.

Jun 14 2020, 6:45 AM · Performance-Team (Radar), Technical-blog-posts

Jun 5 2020

Nomsterio added a comment to T254335: Story idea for Blog: contributing paint-timing API to WebKit.

@Gilles should I add that context to the post? Or do you want to add something like a preface from wikimedia perf team?

Jun 5 2020, 12:57 PM · Performance-Team (Radar), Technical-blog-posts

Jun 3 2020

Nomsterio added a comment to T254335: Story idea for Blog: contributing paint-timing API to WebKit.

Ah, thanks a lot for the clarification. And sorry - I had no idea, obviously! :)
That was an interesting read - thanks! I took the liberty to leave a few smaller comments from an outsider perspective on the first page of that draft.

Jun 3 2020, 12:27 PM · Performance-Team (Radar), Technical-blog-posts
Nomsterio added a comment to T254335: Story idea for Blog: contributing paint-timing API to WebKit.

Hi @Nomsterio, thanks for taking the time to report this and welcome to Wikimedia Phabricator! Could you elaborate a bit how this will be related to specific Wikimedia aspects? (I'm basically asking as you registered a Wikimedia account an hour ago, so I wonder what brought you to Wikimedia for this.) Thanks! :)

Jun 3 2020, 11:13 AM · Performance-Team (Radar), Technical-blog-posts
Nomsterio added a comment to T254335: Story idea for Blog: contributing paint-timing API to WebKit.

https://docs.google.com/document/d/1y6HOqqc7u1x6yxpPsaj3Dl0OMqll7eWhb7aQ7LA8PA0/

Jun 3 2020, 11:07 AM · Performance-Team (Radar), Technical-blog-posts
Nomsterio created T254335: Story idea for Blog: contributing paint-timing API to WebKit.
Jun 3 2020, 10:22 AM · Performance-Team (Radar), Technical-blog-posts