it's been 48 hours and still not deployed. re-opening to reduce chances of this slipping through the cracks

In T321509#12199517, @Escargot_rouge wrote:

The current system does one edit by inactive mentor every 3 days. This makes the history of the  MediaWiki:GrowthMentors.json  page a bit unreadable (see frwiki history).
Would it be possible to group these edits into a single edit every 3 days, or to change the system so that it isn't needed to mark a user as inactive if they were already marked inactive 3 days ago?

Adding MediaWiki-ResourceLoader since adding things to the mw.config variables has performance implications, for example increasing the amount of data transmitted on every page load.

Sounds good. Please make another comment in this ticket when the nlwiki discussion is concluded and has a consensus for local SecurePoll usage.

I'm able to reproduce in Firefox 152. I've edited the ticket to add the step "Zoom the browser in", which may be an extra step and the reason why you weren't able to reproduce.

In T383654#12178220, @Nikerabbit wrote:

@Novem_Linguae Opened language selector makes the page wider. You can see the left side is partially out of the viewport (scrollbar is not visible on the screenshot).

Looks like the "language menu overflows off the left when it shouldn't" issue is fixed. I am unable to reproduce. That is what this ticket and T366474: Language selector modal is partially off the screen at high zooms in Vector 2010 are about. I'll go ahead and mark this ticket as resolved.

Ah. Good point. Yeah, we probably need to keep the override list then. OK, back to thinking of a better name for it :)

Thanks for the quick response. One workaround would be to add these folks to the eligibility list instead. Thoughts on that? Or is the idea that the eligibility list gets updated multiple times and you don't want to accidentally overwrite the override list people?

@jrbs and @Cyberpower678 , would we break any of your election workflows if we removed the "Override List" on the voter eligibility page? If not, I like SD0001's idea of removing it.

My plan is, if the NPP backlog gets above 30,000 articles unreviewed ( https://en.wikipedia.org/wiki/Wikipedia_talk:New_pages_patrol/Reviewers#NPP_backlog ), I will propose that we let articles unreviewed longer than 6 months fall off the back of the NPP queue (i.e. get marked as patrolled by the software). These tend to be borderline articles that aren't obvious accepts or declines, so take the most reviewer brainpower.

Looks like the number of incoming drafts is holding steady. Also, AFC regularly achieves low or zero drafts needing review during its backlog drives. All of this is great and points towards a healthy, sustainable system.

This ticket probably isn't ready for work yet. I was hoping to get some input from other experienced SecurePoll people. @SD0001, any thoughts on the names I proposed above?

Patch looks good.

Did the root cause get fixed? Or will these errors just reappear again until we write a patch that...

On the bright side, this appears consistently reproducible in production today if an engineer wants to dig into it.

I received both. I assume you did not get a copy of number 1?

Sure, go ahead.

In T383047#12157165, @Pine wrote:

I see several changes were merged recently. Does this imply that the errors should soon stop happening?

I'm able to reproduce. From my limit testing (about 5 times today), it seems that the sending of the main email succeeds (despite reloading the form and displaying the error message), and the sending of the "send me a copy of this email" fails.

In T432987#12155891, @Bugreporter2 wrote:

Searching for nothing takes you to [[Special:Search]].

Thanks! I think owner is the gerrit account and author is the git commit email.

Alright, after talking with people at my hackathon table, looks like the problem is that the author and owner had different email addresses in the example I provided above. Will go ahead and close this. SomeRandomDeveloper can reopen if his issue isn't solved by this explanation.

@SomeRandomDeveloper , can you please also post your example? Thanks!

FYI, a production error needs to display an error code rather than just being a bug. Is there an error code? If not, let's change this ticket back to being a bug report.

Thanks. Looks like there's 2 remaining:

That russian text, converted with OCR, is: Подтвердить эту версию ($1 непроверенных изменений)

Using the query from T432191: Wikimedia\Rdbms\DBQueryTimeoutError: A database query timeout has occurred. Page: Special:Log...

Looks like the problem has fixed itself in the 3 years since I filed the ticket :)

My patch had a couple of quality of life things such as installing PHP Composer, installing Symfony CLI, installing XDebug and configuring it to allow VS Code step debugging, and allowing directory listings. I haven't checked if today's patch has those or not, but those might be good additions to add in a follow up.

Re-opening since I think there's a couple more in my screenshot we could add comments to.

Thanks for the patch!

I wrote the patch. Someone else test and backport please :)

Thanks for being flexible to feedback. I love how you're taking people's feedback into account and trying to release compromise versions of icons. I think this is great for community relations. Looking forward to further refinements.

In T427868#12052392, @Ponor wrote:

In T427868#12052342, @DTorsani-WMF wrote:

The demo with the latest amendments should be working now. cc @Chaotic_Enby

@DTorsani-WMF does this mean that the "bra" icon ( cdxIconAppearance) is staying? :[
There's a better icon for these settings even at your demo site (top right)

Page loads in 0.9 seconds for me now. That's without backporting today's patch. Suggests it was fixed by something else.

QA - After the patch merges, will need to wait for train, then will need testing in production to see if the page load time improved below 4 seconds for the page https://en.wikipedia.org/w/index.php?title=Special:SecurePoll/list/821&sort=vote_id&limit=500&asc=&desc=1

In T427868#12048525, @TurboSuperAAA wrote:

In T427868#12038782, @Chaotic_Enby wrote:

Newspaper and Die coming in:

The step to reproduce that we were missing was title = "2026年召集人任命选举". All that replica database, primary database, and cluster stuff was a red herring. Thank you PSI team for solving this!

In T427868#12042152, @Ponor wrote:

<svg aria-hidden="true" class="svg-icon iconInbox" width="20" height="18" viewBox="0 0 20 18"><path d="M4.63 1h10.56a2 2 0 0 1 1.94 1.35L20 10.79V15a2 2 0 0 1-2 2H2a2 2 0 0 1-2-2v-4.21l2.78-8.44c.25-.8 1-1.36 1.85-1.35m8.28 12 2-2h2.95l-2.44-7.32a1 1 0 0 0-.95-.68H5.35a1 1 0 0 0-.95.68L1.96 11h2.95l2 2z"></path></svg>

Can we please consider improving the tray icon? I can no longer tell that it is a tray. And it's a highly visible icon that is shown on every page to logged in users.

Cross link for those looking for it: I think work on refining these icons moved to the ticket T427868: Icon refinement follow ups.

Changed ended up being intentional. Closing.

I don't have enough access to do that, but seems like a good idea. Maybe Product Safety and Integrity can add this ticket to one of their sprints? This is a local election held a month ago that still doesn't have its results, so seems kind of urgent to me. cc @Niharika

@ZhaoFJx, question above for you when you get a minute. STran suggests that you try tallying again (making a brand new tally). Have you tried that yet? What happens?

Also, the Community Tech team no longer exists, so that may not be the correct tag for this.

This was intended to be a task where we plan out those details. None of the acceptance criteria have been met yet (picking a date, marketing it). I would suggest reopening.

@ZhaoFJx, question above for you when you get a minute.

Did you use the encryption setting for your election? Any other settings that might be relevant to your election that I might not be reproducing correctly in beta cluster?

If you're thinking about adding strict_types to anything else, I would recommend against it. This ticket caused 6 production errors in SecurePoll. Not sure that's worth whatever benefit strict_types provides.

A bit odd that there have been no edits using the tag. Could be a bug. Maybe ask your favorite interface administrator to make a test edit?

T428584 is fixed now.

https://en.wikipedia.beta.wmcloud.org/wiki/Special:SecurePoll/tallies/67/result/1 works now. Thanks!

Stack trace on beta cluster has now changed to the following. Might need an additional patch.

Just now I went to go reproduce this bug on betawiki, but I am encountering a different error that probably needs to be fixed first: T428584: TypeError when tallying STV elections.

It's a tricky patch to review since it sounds like the bug is not reproducible in localhost. Someone will probably need to confirm the bug in beta cluster, merge the patch, wait for beta cluster to pick it up, then confirm the fix in beta cluster. If the patch doesn't fix the bug, then would probably want to revert it.

In T423755#11991583, @AROHI_SINGH wrote:

i am claimimg this task

I don't see the latest patch on https://www.wikinews.org/. Probably needs to be deployed.

In T427721#11970263, @Soda wrote:

In T427721#11970258, @Aklapper wrote:

Not a Community Wishlist wish, thus removing project tag

@Aklapper, how do you propose we track changes to the wishlist process?