Hi @Dillon! This looks great I had a couple comments/questions

Hi @Kgraessle, thanks for sharing!
In Figma the content added/removed colors are lighter in dark mode.
What I see them become below:

Hi! Sorry, I updated the byte red and green colors, I just noticed that there are these for added/removed content - name: 'content added' #006400 & name 'content removed' #8B0000

Looks great @Kgraessle, thank you!

Thank you @Kgraessle! It looks great, one small thing. One tiny change, can the space between user links, edit count and buttons be 12 pxs?

1. The cards in codex don't have the option to remove the side borders by default so this would be introducing some custom styling- are we ok with that?

Thanks for sharing this. I think for the MVP we don't need to introduce custom styling.

In T410036#11379895, @Samwalton9-WMF wrote:

We noticed this was missing the non-AMC design for mobile users. Flagged with @OTichonova.

Hi! Is it possible to make the last small updates? 


1. The copy for the inline message for the survey ->
“This is an early version of this page. Share your feedback to inform future improvements via this survey.”



Design updates: 


1. moved bytes in front of the edit summary text. 

2. got rid of side borders for the cards. 

3. I added a hover state on Friday for the cards in the acceptance criteria.

Hi @Kgraessle
Sorry a couple more things



1. The user card and info icon are not center-aligned with the text 

2. The padding on the left side of the username doesn’t align with the rest of the text

3. My bad, but can the spacing between the buttons be 12px? 

4. The username popover pops up behind and above the card.

Hi @Kgraessle!
Thank you for sharing this! I have a couple of comments.

1. For the mobile popover, they are working on it in codex but it is not ready yet, as I understand
T386144 (I think it used to be a modal, as it says in the description). I am going to double-check. 

2. The padding on each side of the card is wider than that of the page. Can it match with 16px?

3)The space above the username & below the button is pretty large, can it be decreased to 12px? 


4. Could the card have a white background (‘base’ FFFFFF)?

5. Can the arrow be on the right side of the card rather than the left to match the designs & edit check?

In T405745#11219958, @Samwalton9-WMF wrote:

@OTichonova do you have thoughts about the icon we should use? (Should we create a new one?)

In T389465#11327313, @Samwalton9-WMF wrote:

We probably shouldn't write "anonymous or temporary" - soon all non logged in users will be temporary accounts. I think rewriting the button label could be self-explanatory, without requiring help text? Open to thoughts.

Only send talk pages to registered users

Hi @Kgraessle!
In the new iteration T402297#11306961, I actually don't have the person icon. Would it be possible to show the the icon next to the username when checkuser is turned on and none, when it is turned off?

In T402297#11303636, @Scardenasmolinar wrote:

This ticket is stalled until we get new/updated designs

Hi @Scardenasmolinar. Are the user groups a vital part of the card? If not, I wouldn't keep them, as the elements in the card are taking up a lot of the screen.

Here are the designs:
They are a little bit different to the ones we discussed in RTL . Since having the buttons side by side might be tricky for languages that have really long names for the actions (ml wiki example below).

Hi @Kgraessle, looks good!
And it would be possible to add illustrations/icons to it?

In T402747#11119889, @Kgraessle wrote:

@OTichonova

I created a patch demo so you can see the proposed design changes to the layout for RecentChanges that fixes this bug.
Let me know what you think about this new design and if so I can +2 this patch.

Hi @Kgraessle! Thank you for fixing the issue with some of the highlight colors (when more than 3+ colors) showing up #00000. I checked the contrast and it is about the same as the current colors. I don't see any additional issues.
I do think that these colors is something that worth revisiting and rethinking.

Hi @Kgraessle, thank you for the color updates. I cannot seem to recreate the hollow bullet points, but not what I see if that if more than one color is selected the highlight color appears to be 000000 (not really visible).

Multiple colors

@Scardenasmolinar and here are the color picker vs highlight colors as found on these pages now.

Looks good @Scardenasmolinar, thank you!

In T395646#10973093, @Trizek-WMF wrote:

Can anyone draft what changed, so that we can announce it in Tech News, please?

Hi @Kgraessle, looks good to me, thanks!

Hi @Kgraessle, thanks!
2 small things:

1. When decreasing the size of the screen, the group by page toggle and the time filter stay grouped together and align left. Can they stack on top of each other and align right?

Current	Design

14 pxl - 0.875 em; 26 pxl - 1.625 em

2. The space between toggle and the filter is a tiny bit smaller than it should be (1pxl). Can it be increased to 12 pxl/0.75 em?

In T395646#10911789, @PatchDemoBot wrote:

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmcloud.org/wikis/58ec1f9ca2/w/

In T395646#10911657, @Quiddity wrote:

Question: Why would Monobook not have the`Edit Watchlist` button? I don't see any way to navigate to Special:EditWatchlist without that button.

Ah, sorry, I think that's just my incomplete set of screenshots/annotations/notes being confusing.
I mean (if feasible):

• In Vector-legacy & Monobook & etc, Do both of:
  • Leave the new "Preferences" link+icon where it is at the side.
  • And also remove the existing [old] "Edit watchlist" link, because that it now accessible via the Special:Preferences page itself, and isn't (AFAIK) a daily-use feature for anyone. That will save space. It's essentially a link-swap.
• In Vector-2022: Either:
  1. Do the same thing.
  2. Or if it's easy to do unique things in that skin, then consider my earlier two suggestions. [I.e. Either (a) move the "Preferences" link to the top-bar (which would leave nothing behind, as the duplicate "Edit watchlist" could be removed), or (b) if space is needed, then do the same but also remove the old "clear the watchlist" button.]

E.g. mockups (edited-screenshots, where I've either deleted or cut&pasted things around...) -- 1, 2a, 2b:

[Edit:] I.e. All of the Watchlist pages will have the "Preferences" link, and the top of that preferences page has all 3 feature-links:

@Scardenasmolinar Okay, thank you!

In T395646#10895537, @Kgraessle wrote:

This looks good to me, moving to design review so @OTichonova can give it a final review, thanks for all your work!

Wil do!

Hi @Scardenasmolinar, adding small spacing/padding improvements for the mobile web here as well.

The second option seems better than the first one, since not wrapping at all is hard to achieve and is unlikely to be responsive. But to your broader point, that button row already doesn’t entirely relate to filters: ‘Mark all changes as seen’ button relates to the watchlist itself AFAIK, and marks all changes in the entire watchlist, not just changes shown in the current filter screen.

@stjn Yes I hear you. The page is pretty dense with information already. The other buttons are actions or dropdowns related to the page itself, while the other two options at the top take you to an entirely different page. I think it would be good to rethink the filters + actions and how they are displayed on the page, but that unfortunately is out of scope for now.

The second issue is caused by T180906 - I noticed this on German Wikipedia as well, the text of „edit watchlist“ is too long. @Kgraessle @OTichonova how about moving „edit watchlist“ and „preferences“ to the same row where „mark all changes“ and „saved filters“ appear? Looking at F60073643 there’s lots of space in this row.

Hi @MusikAnimal, thank you for the comments!

Gotcha, okay. It looks great! Thanks @Kgraessle

Hi @Kgraessle, looks great!
One small thing, could you decrease the space between the two links to be 12pts?

Hi @Kgraessle, yes, would that be possible?

I do really like the idea of connecting this to T180906: Enable navigation from watchlist to watchlist preferences. Maybe we can add some language in the design around the preferences link that explains that the latest revision is the default filter and if they want to change that or any other settings, they can navigate to preferences?

Hi @Kgraessle!
In Codex it is recommended to use links when the user navigates to 'another page, view or section, when the user presses it’, while buttons are used for actions.
Hence, both of the buttons ‘Edit your list of watched pages’ and ‘Preferences’ could be links.

My question for you is since this is the way the filters should behave, what design steps could we take to alleviate the user confusion? The main concern is around missing edits when the default is set to only show the latest revision- what would be a good way to communicate this to the user so that it's less confusing? Maybe a good solution is to not have the filter "Latest Revision" on by default?

Hi @jsn.sherman, the privacy statement has now been added to the survey.

@Ladsgroup

I applied @OTichonova's final design changes (tiny stuff in mobile) and now it's fully done \o/

Thank you so much!