Page MenuHomePhabricator

Od1n
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 8 2016, 3:49 PM (408 w, 1 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Od1n [ Global Accounts ]

Recent Activity

Sun, Mar 3

Od1n added a comment to T349298: "wikipage.content" JS hook: $content should be consistent on live previews.

This issue dates back to T35399.

Sun, Mar 3, 5:41 AM · MediaWiki-Platform-Team (Radar), MediaWiki-User-Interface, JavaScript
Od1n added a comment to T35399: LivePreview: Re-run wikipage content handlers (jquery.makeCollapsible, jquery.tablesorter, ..) after preview content is loaded.

You may want to have a look at T349298.

Sun, Mar 3, 5:39 AM · JavaScript, MediaWiki-jQuery-Tablesorter--archived, MW-1.22.0-release
Od1n added a comment to T349298: "wikipage.content" JS hook: $content should be consistent on live previews.

I have just encountered an issue in a gadget because of this discrepancy: https://fr.wikipedia.org/w/index.php?title=MediaWiki:Gadget-Accessibility.js&diff=prev&oldid=212995332

Sun, Mar 3, 5:20 AM · MediaWiki-Platform-Team (Radar), MediaWiki-User-Interface, JavaScript

Tue, Feb 27

Od1n updated the task description for T358545: Blurred logo on classic Vector, when Windows is configured on 125% font scaling.
Tue, Feb 27, 4:30 AM · MediaWiki-User-Interface (actions), Logos, Vector (legacy skin)
Od1n added a comment to T279645: Wikipedia logo is blurry in Timeless, icon config lacking 2x or svg variant.

Related, with classic Vector skin: T358545

Tue, Feb 27, 4:30 AM · Patch-For-Review, Logos, Timeless
Od1n created T358545: Blurred logo on classic Vector, when Windows is configured on 125% font scaling.
Tue, Feb 27, 4:26 AM · MediaWiki-User-Interface (actions), Logos, Vector (legacy skin)

Sat, Feb 24

Od1n added a comment to T358419: Why is invoking/running this specific module slow?.

As the functionality was new, in 99.999% of existing uses there was no replacement to do actually. Thus, I wanted to optimize these cases the most possible, and the plaintext string.find() is a prefilter to rule them out as fast as possible.

Sat, Feb 24, 9:24 PM · Scribunto
Od1n created T358419: Why is invoking/running this specific module slow?.
Sat, Feb 24, 9:31 AM · Scribunto
Od1n added a comment to T357199: Could we optimize Lua environment setup to improve {{#invoke:}} performance?.

While doing some random test, I noticed the 4 assignments local getmetatable = getmetatable, etc. actually make the code slower.
What makes the code slower is not the assignment, but the access to the local variable instead of the global function. It's as if the Lua engine had some internal optimization for these global accesses.

Sat, Feb 24, 4:35 AM · Scribunto
Od1n awarded T328610: Default gadgets to run on mobile a Dislike token.
Sat, Feb 24, 3:12 AM · User-notice-archive, MW-1.41-notes (1.41.0-wmf.16; 2023-07-04), Patch-For-Review, MediaWiki-extensions-Gadgets
Od1n awarded T340802: Remove the ResourceLoader targets system from MediaWiki core in 1.42 a Dislike token.
Sat, Feb 24, 3:12 AM · MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), MediaWiki-Platform-Team (Radar), MW-1.42-release, MediaWiki-ResourceLoader
Od1n awarded T248416: [EPIC] Drop MediaWiki:Mobile.css and MediaWiki:Mobile.js in favor of TemplateStyles a Dislike token.
Sat, Feb 24, 2:25 AM · MobileFrontend, Epic, User-Jdlrobson
Od1n created T358413: Byte size not plurialized in search results with interface in French.
Sat, Feb 24, 2:19 AM · Discovery-Search, MediaWiki-Internationalization, CirrusSearch

Fri, Feb 23

Od1n added a comment to T357693: Show patrol link regardless of whether preview is shown (Was: Edits can't be patrolled on Commons by users who have the user preference "Do not show page content below diffs" enabled).

Agree too for always showing the links.

Fri, Feb 23, 6:47 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Regression, MediaWiki-Patrolling, Commons

Thu, Feb 22

Od1n added a comment to T357693: Show patrol link regardless of whether preview is shown (Was: Edits can't be patrolled on Commons by users who have the user preference "Do not show page content below diffs" enabled).

The code is very misleading:

// Patrol link is hidden when no preview shows, unless the user has specifically
// opted out of previews via user preference (T357693).
$showPatrolLink = $userRequestedDiffOnly ? false : $diffOnly;

(then, $showPatrolLink gets passed as argument to the markPatrolledLink() method, as the $isDiffOnly parameter)

Thu, Feb 22, 10:58 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Regression, MediaWiki-Patrolling, Commons

Fri, Feb 16

Od1n added a comment to T13555: .mw-editsection links should not be part of the <h#> element.

One caveat I thought of with enclosing styled bare <h2>'s with the mw-heading <div>, is that it would prevent margin collapsing with the preceding (or following) element.

Fri, Feb 16, 12:11 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser

Thu, Feb 15

Od1n added a comment to T13555: .mw-editsection links should not be part of the <h#> element.

Removal of the "old" and "hybrid" markups will definitely improve the situation. I would have preferred to no longer see the "plain" markup too, but if converting an input such as <h2 style="color:orange; margin-top:2em;"> to "new markup", as the color isn't inherited, it would have to be directly applied to the inner <h2>, and the the margin-top would preferably have to be applied to the outer <div class="mw-heading">… of course, it is not feasible to implement handling for each and every property…

Thu, Feb 15, 9:38 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser

Wed, Feb 14

Od1n added a comment to T301212: Vector-2022.js should no longer load legacy Vector site and user scripts/styles.

The last 2 linked searches above are mistaken: user pages shouldn't be named Vector.js/css, but vector.js/css (contrarily to the site scripts, which are Titlecased). Just change "Vector" to "vector" in the last 2 links.

Wed, Feb 14, 11:12 PM · Web-Team-Backlog (Needs Prioritization (Tech)), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Desktop Improvements (Vector 2022), Vector (legacy skin), Technical-Debt
Od1n added a comment to T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js.

It's not about Common vs Vector vs Vector-2022 etc scripts. It's about ensuring user scripts (whether common, vector, etc.) are loaded after site scripts (whether common, vector, etc.)

Wed, Feb 14, 10:59 PM · Vector (legacy skin), Patch-For-Review, JavaScript

Tue, Feb 13

Od1n added a comment to T357197: Allow ES8 (ES2017) code in gadgets.

(off-topic: I'm really sorry to hear that fr.wikipedia is still amongst the most error-throwing wikis. I had a look for requesting Logstash access, but that sounds just a bit too cumbersome to me. Though, would it be possible to provide me some information to spot the most problematic codes, without breaking the NDA?)

Tue, Feb 13, 9:47 AM · MediaWiki-Platform-Team (Radar), MediaWiki-extensions-Gadgets

Mon, Feb 12

Od1n added a comment to T357199: Could we optimize Lua environment setup to improve {{#invoke:}} performance?.
  • The global lookups to getmetatable, etc. functions are cached so the (numerous) recursiveClone() calls avoid them. Considering the gigantic number of recursiveClone() calls, that's certainly the biggest optimization of your new variant.
  • And by using the do...end block, mw.clone() calls (and they add up, at least one per {{#invoke}}) benefit from this lookup cache as well (instead of creating a new set of caching variables every time).
  • Nice one too with the scope of tableRefs (refs The Implementation of Lua 5.0 [PDF] - Sections 5: Function and Closures)
Mon, Feb 12, 10:23 PM · Scribunto
Od1n added a comment to T357199: Could we optimize Lua environment setup to improve {{#invoke:}} performance?.

So there is some room for improvement, thank you for investigating this.

Mon, Feb 12, 7:00 AM · Scribunto

Sat, Feb 10

Od1n created T357199: Could we optimize Lua environment setup to improve {{#invoke:}} performance?.
Sat, Feb 10, 6:34 AM · Scribunto
Od1n added a comment to T357197: Allow ES8 (ES2017) code in gadgets.

I feel that the only thing that blocks the switch to ES8 is that async is not yet fully supported in the minifier (per T277675).

Sat, Feb 10, 5:13 AM · MediaWiki-Platform-Team (Radar), MediaWiki-extensions-Gadgets

Thu, Feb 8

Od1n added a comment to T277675: Add native support for ES2016-ES2020 or higher versions.

Please, please keep the requiresES6 flag at least until ES8 can be used in scripts. On frwiki, we have scripts that use async/await, and this language feature makes the codes incredibly simpler. We even had codes with the ?. operator, but I rewrote them to avoid using this operator (for now). But the async/await is a must have.

Thu, Feb 8, 7:14 AM · MediaWiki-Platform-Team, Wikimedia-Minify, Performance-Team, JavaScript, MediaWiki-ResourceLoader

Wed, Feb 7

Framawiki awarded T351243: Suggestion: Add JavaScript config values "wgPrefixedTitle", etc. a Love token.
Wed, Feb 7, 10:16 AM · MediaWiki-User-Interface, JavaScript

Tue, Feb 6

Od1n updated the task description for T355017: Missing space in Special:RecentChangesLinked.
Tue, Feb 6, 1:41 AM · MW-1.39-notes, MW-1.41-notes, MW-1.40-notes, MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Growth-Team, MediaWiki-Recent-changes

Feb 3 2024

Od1n added a comment to T13555: .mw-editsection links should not be part of the <h#> element.

I confirm that having these many markups, that overlap, makes it a headache to create selectors that pick the desired elements, and only these.

Feb 3 2024, 10:18 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser

Jan 28 2024

Od1n added a comment to T13555: .mw-editsection links should not be part of the <h#> element.

Another thing, here's the new markup I currently see on the pages:

Jan 28 2024, 3:33 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser

Jan 27 2024

Od1n added a comment to T13555: .mw-editsection links should not be part of the <h#> element.

Hi, on frwiki homepage (permalink), I noticed there is an element in the wikicode that doesn't get converted to the new markup: <h2 style="margin-top:1.5rem">. When removing the style="margin-top:1.5rem", the element gets converted, as the other <h2>'s of the page.

Jan 27 2024, 9:08 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser

Jan 18 2024

Od1n updated the task description for T180911: Add a property "talkNsText" to mw.title objects.
Jan 18 2024, 10:05 PM · MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), MediaWiki CodeJam Dec 2023, Scribunto

Jan 14 2024

Od1n created T355017: Missing space in Special:RecentChangesLinked.
Jan 14 2024, 9:40 AM · MW-1.39-notes, MW-1.41-notes, MW-1.40-notes, MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Growth-Team, MediaWiki-Recent-changes

Nov 26 2023

Od1n added a comment to T263509: The module 'wikibase.api.RepoApi' required by 'ext.cx.wikibase.link' must exist.

Related: T259211

Nov 26 2023, 7:56 PM · MediaWiki-extensions-WikibaseRepository, MW-1.31-release, Wikidata, ContentTranslation

Nov 22 2023

Bugreporter2 awarded T308504: Redirects should be italicised on Special:MostTranscludedPages (and maybe other pages as well) a Dislike token.
Nov 22 2023, 3:50 AM · Patch-For-Review, CSS, MediaWiki-User-Interface

Nov 14 2023

Od1n created T351243: Suggestion: Add JavaScript config values "wgPrefixedTitle", etc..
Nov 14 2023, 5:31 PM · MediaWiki-User-Interface, JavaScript
Od1n added a comment to T25307: Send $wgTitle to the fiery pit from whence it came.

Just to confirm: the wgTitle JavaScript config value is completely unrelated, and there is no plan to deprecate it ever, right?

Nov 14 2023, 4:12 PM · Patch-For-Review, Technical-Debt, MediaWiki-General
Od1n added a comment to T348717: Filter IDs and log entry IDs should not be num-formatted.

Arguably, filter IDs could be considered as their "name". For instance, on frwiki we often refer to the filters just by their numbers.

Nov 14 2023, 6:28 AM · Patch-For-Review, AbuseFilter

Nov 7 2023

Pppery awarded T350635: Previewing should be enabled when editing Scribunto pages a Dislike token.
Nov 7 2023, 12:44 AM · Scribunto

Nov 6 2023

Od1n created T350635: Previewing should be enabled when editing Scribunto pages.
Nov 6 2023, 10:51 PM · Scribunto

Oct 22 2023

Od1n triaged T207448: Resetting a custom global preference via API does not work as High priority.
Oct 22 2023, 1:48 PM · Community-Tech, User-TheDJ, MediaWiki-Action-API, MediaWiki-extensions-GlobalPreferences
Od1n added a comment to T207448: Resetting a custom global preference via API does not work.

I have just encountered this issue. A gadget migrated its options schema, and there are a bunch of old items to clean up. Currently, the best I can do is to set these to empty values, so that at least it takes little space.

Oct 22 2023, 1:46 PM · Community-Tech, User-TheDJ, MediaWiki-Action-API, MediaWiki-extensions-GlobalPreferences

Oct 19 2023

Od1n created T349298: "wikipage.content" JS hook: $content should be consistent on live previews.
Oct 19 2023, 1:50 PM · MediaWiki-Platform-Team (Radar), MediaWiki-User-Interface, JavaScript

Oct 16 2023

Od1n added a comment to T348717: Filter IDs and log entry IDs should not be num-formatted.

@matej_suchanek I took the liberty of subscribing you here, as I mainly comment on Phabricator :)

Oct 16 2023, 2:35 PM · Patch-For-Review, AbuseFilter
Od1n updated subscribers of T348717: Filter IDs and log entry IDs should not be num-formatted.
Oct 16 2023, 2:35 PM · Patch-For-Review, AbuseFilter
Od1n added a comment to T348717: Filter IDs and log entry IDs should not be num-formatted.

Alternatively, we may play it safe for now: keep filter IDs num-formatted, and just cherry-pick the 2 changes for log entry IDs (see in SpecialAbuseLog.php).

Oct 16 2023, 2:20 AM · Patch-For-Review, AbuseFilter
Od1n added a comment to T348717: Filter IDs and log entry IDs should not be num-formatted.

Uploaded patchset 3, which takes care of occurrences of formatNum() that were remaining.

Oct 16 2023, 1:55 AM · Patch-For-Review, AbuseFilter

Oct 12 2023

Od1n created T348717: Filter IDs and log entry IDs should not be num-formatted.
Oct 12 2023, 8:02 AM · Patch-For-Review, AbuseFilter

Oct 8 2023

Od1n added a comment to T348398: Missing old/new_content_model variables on Flow pages.

By the way, Flow has a dedicated AbuseFilter group. See the wgFlowAbuseFilterGroup variable at Extension:StructuredDiscussions#Configuration.

Oct 8 2023, 12:21 PM · Patch-For-Review, Growth-Team, StructuredDiscussions, Wikimedia-abusefilter-global-maintainers, AbuseFilter
Od1n created T348398: Missing old/new_content_model variables on Flow pages.
Oct 8 2023, 11:42 AM · Patch-For-Review, Growth-Team, StructuredDiscussions, Wikimedia-abusefilter-global-maintainers, AbuseFilter

Oct 6 2023

Od1n added a comment to T343994: OutputPage::setPageTitle() should call Message::escaped() when given a Message.

It's perfect just like this, thank you!

Oct 6 2023, 4:12 AM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Patch-For-Review, MediaWiki-General, MediaWiki-Internationalization

Sep 29 2023

Od1n added a comment to T343994: OutputPage::setPageTitle() should call Message::escaped() when given a Message.

If it is feasible, I guess it would be nice to support the same markup as {{DISPLAYTITLE}} does? i.e. '', ''', <abbr>, <sup>

Sep 29 2023, 10:56 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Patch-For-Review, MediaWiki-General, MediaWiki-Internationalization
Od1n added a comment to T343994: OutputPage::setPageTitle() should call Message::escaped() when given a Message.

Change 960131 introduced a regression on frwiki, see our localized message MediaWiki:Abusefilter-history, which makes use of template {{n°}}.

Sep 29 2023, 4:53 AM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Patch-For-Review, MediaWiki-General, MediaWiki-Internationalization

Sep 12 2023

Od1n added a comment to T257075: Simplify the checkboxHack API.

As I was working on these changes, more and more race conditions were emerging… You can see in the changes history how it went horribly.
(and actually, there is at least one other issue remaining, that I had fixed locally, but lacked the motivation to commit.)

Sep 12 2023, 8:20 AM · Web-Team-Backlog (Needs Prioritization (Tech)), Accessibility, MediaWiki-User-Interface (active libraries), User-Demian
Od1n added a comment to T328870: Optimize and tidy up in mediawiki.page.ready/ready.js.

Sure, you may cherry-pick this change if you want to merge it yourself :)

Sep 12 2023, 8:10 AM · MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), Wikimedia-Performance-recommendation, MediaWiki-User-Interface, JavaScript

Sep 1 2023

Od1n added a comment to T334617: page_id should be 0 when testing filter against a page creation in RC.

Any news on this? I would really love to migrate the filters on frwiki from page_age to page_id, which would save a few milliseconds on every page edit :-)

Sep 1 2023, 7:55 PM · MW-1.41-notes (1.41.0-wmf.26; 2023-09-12), AbuseFilter

Aug 27 2023

Od1n added a comment to T343281: Small improvement in documentation of mw.util.addPortletLink().

@Frostly I have submitted a patch for this, but feel free to work on this too if you want to learn the tools :)

Aug 27 2023, 4:48 AM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), MediaWiki-Platform-Team (Radar), good first task, MediaWiki-ResourceLoader, Documentation, JavaScript
Od1n lowered the priority of T343281: Small improvement in documentation of mw.util.addPortletLink() from High to Low.
Aug 27 2023, 4:45 AM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), MediaWiki-Platform-Team (Radar), good first task, MediaWiki-ResourceLoader, Documentation, JavaScript

Aug 17 2023

Od1n added a comment to T343660: Fix inconsistencies in CSS media query breakpoints.

By the way, a search for max-width: @width-breakpoint in the codebase (search results) reveals a lot of other mistakes.

Aug 17 2023, 11:08 PM · Design-System-Team, Patch-For-Review, UI-Standardization, CSS
Od1n added a comment to T343660: Fix inconsistencies in CSS media query breakpoints.

Yes I am aware of these @max/min-width-breakpoint- variables. These are of course a better option, as they remove any risk of mistake.

Aug 17 2023, 10:49 PM · Design-System-Team, Patch-For-Review, UI-Standardization, CSS

Aug 6 2023

Od1n updated the task description for T343660: Fix inconsistencies in CSS media query breakpoints.
Aug 6 2023, 12:25 PM · Design-System-Team, Patch-For-Review, UI-Standardization, CSS
Od1n added a project to T343660: Fix inconsistencies in CSS media query breakpoints: Design-System-Team.
Aug 6 2023, 12:21 PM · Design-System-Team, Patch-For-Review, UI-Standardization, CSS
Od1n created T343660: Fix inconsistencies in CSS media query breakpoints.
Aug 6 2023, 12:15 PM · Design-System-Team, Patch-For-Review, UI-Standardization, CSS

Aug 1 2023

Od1n created T343281: Small improvement in documentation of mw.util.addPortletLink().
Aug 1 2023, 9:04 PM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), MediaWiki-Platform-Team (Radar), good first task, MediaWiki-ResourceLoader, Documentation, JavaScript

Jul 31 2023

Od1n added a comment to T331168: Inconsistent treatment for pinnable elements at the desktop breakpoint.

There are still a lot of inconsistencies in the codebase, as the layout changes are defined sometimes before the breakpoint, sometimes after. Therefore, when the window width hits exactly the breakpoint we encounter a "mixed" state.

Jul 31 2023, 7:28 AM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Web Team Visual Regression Framework, Web-Team-Backlog, Desktop Improvements (Vector 2022)

Jul 10 2023

Od1n added a comment to T340900: Summary preview is missing when using live diff.

Also, when editing a page of the Module: namespace, there is no "Show preview" button. Thus, to be able to preview the edit summary, one had to copy/paste it to another edit page…

Jul 10 2023, 6:26 AM · MW-1.41-notes (1.41.0-wmf.17; 2023-07-11), Regression, Realtime Preview, JavaScript, MediaWiki-Page-editing

Jul 5 2023

Od1n added a comment to T337280: Improve loading process of the templates-in-use list.

A code such as:

Jul 5 2023, 7:27 AM · MW-1.41-notes (1.41.0-wmf.16; 2023-07-04), Community-Tech (CommTech-Kanban), Realtime Preview

Jul 4 2023

Od1n added a comment to T337280: Improve loading process of the templates-in-use list.

By the way, for the batchSize we could leverage the high API limit. Something like:

Jul 4 2023, 8:53 AM · MW-1.41-notes (1.41.0-wmf.16; 2023-07-04), Community-Tech (CommTech-Kanban), Realtime Preview
Od1n added a project to T340900: Summary preview is missing when using live diff: Regression.
Jul 4 2023, 1:15 AM · MW-1.41-notes (1.41.0-wmf.17; 2023-07-11), Regression, Realtime Preview, JavaScript, MediaWiki-Page-editing
Od1n added a comment to T340900: Summary preview is missing when using live diff.

The comments by Nardog are relevant as well. This regression appears to be more and more frustrating for me… so I am forced to disable live preview for now.

Jul 4 2023, 1:15 AM · MW-1.41-notes (1.41.0-wmf.17; 2023-07-11), Regression, Realtime Preview, JavaScript, MediaWiki-Page-editing

Jul 2 2023

Od1n added a comment to T340900: Summary preview is missing when using live diff.

I really don't see the point of purposedly hiding the preview of the edit summary, where technically nothing prevents us from showing it.

Jul 2 2023, 4:33 AM · MW-1.41-notes (1.41.0-wmf.17; 2023-07-11), Regression, Realtime Preview, JavaScript, MediaWiki-Page-editing

Jul 1 2023

Od1n added a comment to T340900: Summary preview is missing when using live diff.

It seems to be a regression from T293930 (see the code changes).

Jul 1 2023, 2:57 PM · MW-1.41-notes (1.41.0-wmf.17; 2023-07-11), Regression, Realtime Preview, JavaScript, MediaWiki-Page-editing
Od1n added a comment to T340900: Summary preview is missing when using live diff.

My mistake: the preview of the edit summary is missing when doing a "Show changes" action. When doing a "Show preview" action, it is present as expected. I have corrected the first message.

Jul 1 2023, 2:17 PM · MW-1.41-notes (1.41.0-wmf.17; 2023-07-11), Regression, Realtime Preview, JavaScript, MediaWiki-Page-editing
Od1n updated the task description for T340900: Summary preview is missing when using live diff.
Jul 1 2023, 2:15 PM · MW-1.41-notes (1.41.0-wmf.17; 2023-07-11), Regression, Realtime Preview, JavaScript, MediaWiki-Page-editing
Od1n added a subtask for T41272: Bugs in "Live preview" feature (tracking): T340900: Summary preview is missing when using live diff.
Jul 1 2023, 3:12 AM · JavaScript, MediaWiki-Page-editing, Tracking-Neverending
Od1n added a parent task for T340900: Summary preview is missing when using live diff: T41272: Bugs in "Live preview" feature (tracking).
Jul 1 2023, 3:12 AM · MW-1.41-notes (1.41.0-wmf.17; 2023-07-11), Regression, Realtime Preview, JavaScript, MediaWiki-Page-editing
Od1n created T340900: Summary preview is missing when using live diff.
Jul 1 2023, 3:12 AM · MW-1.41-notes (1.41.0-wmf.17; 2023-07-11), Regression, Realtime Preview, JavaScript, MediaWiki-Page-editing

Jun 22 2023

Od1n added a comment to T303378: MobileFrontend removal of elements takes <templatestyles> tags with it.

Of course strong support for fixing this.

Jun 22 2023, 10:48 AM · Web-Team-Backlog (Needs Prioritization (Tech)), TemplateStyles, MobileFrontend

Jun 9 2023

Od1n added a comment to T316533: Trigger category from Lua code or as parser function.

You could make use of #iferror for your case. It catches any element (namely strong, span, p, div) that has a class "error". This includes errors generated by Scribunto.

Jun 9 2023, 7:24 AM · Scribunto, ParserFunctions
Od1n added a comment to T338561: Optimize mw.text.trim() with default charset.

In commit message of patchset 5, added a note about the addition of \v to the characters trimmed by default.

Jun 9 2023, 4:17 AM · MW-1.41-notes (1.41.0-wmf.18; 2023-07-18), Scribunto
Od1n added a comment to T338561: Optimize mw.text.trim() with default charset.

Added author and source in commit message of patchset 4. I can't say for the license. There is just none.

Jun 9 2023, 3:51 AM · MW-1.41-notes (1.41.0-wmf.18; 2023-07-18), Scribunto
Od1n added a comment to T338561: Optimize mw.text.trim() with default charset.

In patchset 3, I'm replacing s:match( ... ) with string.match( s, ... ).

Jun 9 2023, 1:16 AM · MW-1.41-notes (1.41.0-wmf.18; 2023-07-18), Scribunto
Od1n added a comment to T338561: Optimize mw.text.trim() with default charset.

In patchset 2, I'm replacing the default charset '\t\r\n\f ' with %s. This allows for a much simpler code.

Jun 9 2023, 1:03 AM · MW-1.41-notes (1.41.0-wmf.18; 2023-07-18), Scribunto
Od1n created T338561: Optimize mw.text.trim() with default charset.
Jun 9 2023, 12:54 AM · MW-1.41-notes (1.41.0-wmf.18; 2023-07-18), Scribunto

May 31 2023

Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

By using margin-inline-start, I managed to considerably reduce the amount of CSS needed, see on French Wikipédia.

May 31 2023, 3:23 PM · Patch-For-Review, MediaWiki-General, CSS, JavaScript

May 30 2023

Od1n added a comment to T309909: Error: Permission denied to access property "nodeType" when pressing Ctrl+F while editing (Firefox).

Interestingly, the error happens only when "Highlight All" is toggled on, in the browser search bar.

May 30 2023, 10:20 PM · Browser-Support-Firefox, MediaWiki-General, JavaScript, Wikimedia-production-error
Od1n added a comment to T309909: Error: Permission denied to access property "nodeType" when pressing Ctrl+F while editing (Firefox).

I can reproduce too:

May 30 2023, 10:16 PM · Browser-Support-Firefox, MediaWiki-General, JavaScript, Wikimedia-production-error

May 7 2023

Od1n updated the task description for T336127: No warning is shown when previewing a "sanitized-css" page containing unsupported CSS.
May 7 2023, 5:00 AM · Regression, MediaWiki-Page-editing, TemplateStyles, css-sanitizer
Od1n created T336127: No warning is shown when previewing a "sanitized-css" page containing unsupported CSS.
May 7 2023, 4:54 AM · Regression, MediaWiki-Page-editing, TemplateStyles, css-sanitizer

May 5 2023

Od1n added a comment to T237336: non-commutativity of short-circuiting operations due to truthy/falsy values.

Indeed, the results are a bit inconsistent currently…

May 5 2023, 1:33 AM · AbuseFilter

May 4 2023

Od1n updated the task description for T334369: Improving the function cache.
May 4 2023, 5:59 AM · AbuseFilter

May 3 2023

Od1n added a comment to T313163: AbuseFilter API "aflprop=details" should allow querying finer grained variables.

+1 for this. Working with the API to inspect past hits, I often encounter the following warning, even with very low limits (less than 50):

May 3 2023, 9:50 AM · Patch-For-Review, AbuseFilter
Od1n added a comment to T334617: page_id should be 0 when testing filter against a page creation in RC.

The patch should be ready to merge :)

May 3 2023, 9:42 AM · MW-1.41-notes (1.41.0-wmf.26; 2023-09-12), AbuseFilter

May 1 2023

Od1n added a comment to T265203: Allow start/end values to be modified after the toolbar has been bootstrapped.

On a related note, in our toolbox we have a « &nbsp; » link, to insert the "&nbsp;" string.

May 1 2023, 4:15 AM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), CharInsert

Apr 29 2023

Od1n added a comment to T265203: Allow start/end values to be modified after the toolbar has been bootstrapped.

Thanks for merging this old patch.

Apr 29 2023, 10:44 PM · MW-1.41-notes (1.41.0-wmf.9; 2023-05-15), CharInsert

Apr 20 2023

Od1n updated the task description for T335133: Add keywords and functions for case-insensitive plaintext search.
Apr 20 2023, 1:02 PM · AbuseFilter
Od1n created T335133: Add keywords and functions for case-insensitive plaintext search.
Apr 20 2023, 1:00 PM · AbuseFilter

Apr 13 2023

Od1n created T334640: Clean up unused DEMPTY data type.
Apr 13 2023, 5:26 AM · MW-1.41-notes (1.41.0-wmf.5; 2023-04-17), AbuseFilter

Apr 12 2023

Od1n added a comment to T302316: "This regular expression matches the empty string" false positive with variables.

I really don't understand what causes the editor warning…

Apr 12 2023, 7:32 PM · AbuseFilter
Od1n added a comment to T302316: "This regular expression matches the empty string" false positive with variables.

Also note we are encountering this editor warning as soon as a variable is used in the pattern, even if the pattern has other parts:

Apr 12 2023, 6:58 PM · AbuseFilter
Od1n added a comment to T302316: "This regular expression matches the empty string" false positive with variables.

See also T283966.

Apr 12 2023, 6:50 PM · AbuseFilter