Page MenuHomePhabricator

Od1n
User

Today

  • No visible events.

Tomorrow

  • No visible events.

Friday

  • No visible events.

User Details

User Since
May 8 2016, 3:49 PM (519 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Od1n [ Global Accounts ]

System Saved Queries:

Personal Saved Queries:

Recent Activity

Sun, Apr 19

Od1n added a comment to T14974: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing.

Apologies—immediately after posting, I realized that the <noinclude> technique wouldn't actually work here.

Sun, Apr 19, 10:11 PM · Epic, MediaWiki-Parser
Od1n added a comment to T14974: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing.

This bug is literally 18 years old and remains one of the main caveats for template work. Some action has to be taken; otherwise, how long will it remain stalled—indefinitely?

Sun, Apr 19, 9:59 PM · Epic, MediaWiki-Parser

Sat, Apr 18

Od1n added a comment to T197137: Editing sitewide JS/CSS pages should require elevated security.

This issue could be similar to what I previously reported regarding 2FA reliability:

Sat, Apr 18, 1:29 PM · 2026-user-javascript-incident, Security, MediaWiki-User-management, MediaWiki-User-Interface

Fri, Apr 17

Od1n added a comment to T197137: Editing sitewide JS/CSS pages should require elevated security.

To address the concern that a script on the main domain can still forge POST requests or sniff tokens (as mentioned in point 2 above), one potential path worth mentioning is moving sensitive edits to a dedicated, "naked" domain (e.g., secure-edit.wikimedia.org).

Fri, Apr 17, 12:57 PM · 2026-user-javascript-incident, Security, MediaWiki-User-management, MediaWiki-User-Interface

Thu, Apr 16

Od1n added a comment to T197137: Editing sitewide JS/CSS pages should require elevated security.

Furthermore, automated edits take—what—well under a second, right?

Thu, Apr 16, 5:46 PM · 2026-user-javascript-incident, Security, MediaWiki-User-management, MediaWiki-User-Interface
Od1n added a comment to T197137: Editing sitewide JS/CSS pages should require elevated security.

TOTP is by far the least convenient 2FA setup we support :) The only good thing about it is that it's low-tech, since you can generate TOTP codes on any device you already have.

For convenience, a security key like Yubikey is much nicer (you only need to touch the dongle plugged into your computer), or a passkey, which can also be remembered by the browser.

Thu, Apr 16, 11:50 AM · 2026-user-javascript-incident, Security, MediaWiki-User-management, MediaWiki-User-Interface
Od1n added a comment to T197137: Editing sitewide JS/CSS pages should require elevated security.

How about only asking for the password? That should be sufficient, right? Not even filling in the username and password — no, just the password.
In other words, switching from “re‑authenticate to confirm” to “type your password to confirm” (compatible with browser autofill, of course).

Thu, Apr 16, 12:03 AM · 2026-user-javascript-incident, Security, MediaWiki-User-management, MediaWiki-User-Interface

Wed, Apr 15

Od1n added a comment to T420298: Special:BotPasswords should be included in Special:AccountSecurity.

And another thing I just noticed: there should be a confirmation dialog before deleting a password…

Wed, Apr 15, 1:31 PM · MediaWiki-Platform-Team, MediaWiki-Core-AuthManager
Od1n added a comment to T420298: Special:BotPasswords should be included in Special:AccountSecurity.

Another related point: the Special:BotPasswords/<password name> page should include a subtitle breadcrumb linking back to Special:BotPasswords; its absence feels like a missing piece of the standard navigation.

Wed, Apr 15, 1:28 PM · MediaWiki-Platform-Team, MediaWiki-Core-AuthManager
Od1n added a comment to T420298: Special:BotPasswords should be included in Special:AccountSecurity.

Agree that Special:BotPasswords is difficult to find. I expected to find it somewhere in Special:Preferences, but that’s not the case right now.

Wed, Apr 15, 1:06 PM · MediaWiki-Platform-Team, MediaWiki-Core-AuthManager
Od1n added a comment to T197137: Editing sitewide JS/CSS pages should require elevated security.

Indeed, there are the edits using the JS API, and most of what is discussed here doesn't guard against them, although it's the most straightforward way of worm propagation. Adding safeguard steps to web edits (i.e., the regular form) adds little to no security if we don't guard against the primary attack vector.

Wed, Apr 15, 12:27 PM · 2026-user-javascript-incident, Security, MediaWiki-User-management, MediaWiki-User-Interface
Od1n added a comment to T197137: Editing sitewide JS/CSS pages should require elevated security.

I still prefer the "disable execution of JS from wiki pages" approach (though would it be sufficient?), but if "re-auth" is kept, we could reduce its friction:

Wed, Apr 15, 7:46 AM · 2026-user-javascript-incident, Security, MediaWiki-User-management, MediaWiki-User-Interface

Tue, Apr 14

Od1n added a comment to T197137: Editing sitewide JS/CSS pages should require elevated security.

The least-worst solution I see is to disable JS execution when editing certain pages within the MediaWiki: namespace, as mentioned in PerfektesChaos's message above. After all, we already do this on Special:Preferences without much complaint; at most, it causes a small surprise. There isn't really any JS so crucial to the editing process.

Tue, Apr 14, 8:24 PM · 2026-user-javascript-incident, Security, MediaWiki-User-management, MediaWiki-User-Interface
Od1n added a comment to T197137: Editing sitewide JS/CSS pages should require elevated security.

Argh, we are already struggling with so much friction from the current re-authentication timeouts. Adding a multi-person approval layer on top of that would just add more weight to an already difficult workflow.

Tue, Apr 14, 3:11 PM · 2026-user-javascript-incident, Security, MediaWiki-User-management, MediaWiki-User-Interface

Sat, Apr 11

Od1n added a comment to T197137: Editing sitewide JS/CSS pages should require elevated security.

I constantly have to "re-verify" and really, it's annoying AF. Especially as I have to go retrieve a TOTP code every time.

Sat, Apr 11, 7:13 PM · 2026-user-javascript-incident, Security, MediaWiki-User-management, MediaWiki-User-Interface
Od1n added a comment to T358934: Implement the existing special:block form in Codex.

requestAnimationFrame() happens to solve the issue:

Sat, Apr 11, 10:46 AM · Essential-Work, Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox), Epic

Fri, Apr 10

Od1n added a comment to T358934: Implement the existing special:block form in Codex.

On frwiki, we have a script that acts on the "wpAutoBlock" checkbox (please don't mind the WIP state of the script at the time of writing).

Fri, Apr 10, 1:56 AM · Essential-Work, Multiblocks (Implement Codex Special:Block), Community-Tech (Jackal (not a fox) Fox), Epic

Mon, Apr 6

Od1n added a comment to T422130: Database servers in cluster(number) are overloaded.

I was still encountering the issue, and I’ve just resolved it by making an edit to MediaWiki:Group-sysop.js, which I noticed was included in the bundle, in order to trigger a server‑side cache refresh.

Mon, Apr 6, 8:36 AM · Wikimedia-Incident, SRE, DBA

Sun, Apr 5

Od1n added a comment to T422130: Database servers in cluster(number) are overloaded.

I've cleared my browser cache and restarted Chrome.

Sun, Apr 5, 6:46 AM · Wikimedia-Incident, SRE, DBA

Sat, Apr 4

Od1n added a comment to T422130: Database servers in cluster(number) are overloaded.

I'm still seeing the issue. The UUID is always the same, so I'm posting it here in case it helps:

Sat, Apr 4, 9:35 PM · Wikimedia-Incident, SRE, DBA

Fri, Apr 3

Od1n added a comment to T349298: "wikipage.content" JS hook: $content should be consistent on live previews.

As a reminder, as I suggested previously, there would also be the better solution of adding a hook for parser content:

Fri, Apr 3, 10:33 PM · Patch-For-Review, MediaWiki-Platform-Team (Radar), MediaWiki-User-Interface, JavaScript
Od1n added a comment to T349298: "wikipage.content" JS hook: $content should be consistent on live previews.

It feels like we are over-complicating the core issue.

Fri, Apr 3, 10:19 PM · Patch-For-Review, MediaWiki-Platform-Team (Radar), MediaWiki-User-Interface, JavaScript
Od1n added a comment to T422130: Database servers in cluster(number) are overloaded.

Right now, I’m still seeing the JS error in the console.

Fri, Apr 3, 10:05 AM · Wikimedia-Incident, SRE, DBA
Od1n added a comment to T308504: Redirects should be italicised on Special:MostTranscludedPages (and maybe other pages as well).

Same here — I only tested the styling itself, so the missing mediawiki.special load is an oversight on my part.

Fri, Apr 3, 6:43 AM · MW-1.46-notes (1.46.0-wmf.23; 2026-04-07), Patch-For-Review, MediaWiki-Special-pages, CSS, MediaWiki-User-Interface
Od1n raised the priority of T308504: Redirects should be italicised on Special:MostTranscludedPages (and maybe other pages as well) from Low to Medium.

I'm raising the priority to medium, as the feature in its currently merged state is not functioning as intended, and a patch addressing the issue is ready for review.

Fri, Apr 3, 6:01 AM · MW-1.46-notes (1.46.0-wmf.23; 2026-04-07), Patch-For-Review, MediaWiki-Special-pages, CSS, MediaWiki-User-Interface
Od1n reopened T308504: Redirects should be italicised on Special:MostTranscludedPages (and maybe other pages as well) as "Open".
Fri, Apr 3, 5:30 AM · MW-1.46-notes (1.46.0-wmf.23; 2026-04-07), Patch-For-Review, MediaWiki-Special-pages, CSS, MediaWiki-User-Interface
Od1n added a comment to T308504: Redirects should be italicised on Special:MostTranscludedPages (and maybe other pages as well).

I'm afraid that for this change to be effective, an $output->addModuleStyles( 'mediawiki.special' ); call also needs to be added to the SpecialMostLinked class (or one of its parent classes).

Fri, Apr 3, 5:26 AM · MW-1.46-notes (1.46.0-wmf.23; 2026-04-07), Patch-For-Review, MediaWiki-Special-pages, CSS, MediaWiki-User-Interface

Thu, Apr 2

Od1n added a comment to T308504: Redirects should be italicised on Special:MostTranscludedPages (and maybe other pages as well).

This patch has been merged, even though Bugreporter2 raised some concerns that are certainly arguable.

Thu, Apr 2, 9:55 PM · MW-1.46-notes (1.46.0-wmf.23; 2026-04-07), Patch-For-Review, MediaWiki-Special-pages, CSS, MediaWiki-User-Interface
Od1n added a comment to T422130: Database servers in cluster(number) are overloaded.

FWIW, I'm still currently encountering this error on frwiki, and it prevents my local custom JS/CSS files from loading.

Thu, Apr 2, 9:26 PM · Wikimedia-Incident, SRE, DBA

Feb 10 2026

Od1n added a comment to T417072: Wrong string check for "-local-exception" suffix.

From my understanding, the effect of this mistake is that -local-exception items end up being categorized as unused (by the following "else" branch), and would therefore be incorrectly removed when doing a reset with resetkinds=unused.

Feb 10 2026, 11:08 PM · Patch-For-Review, Community-Tech, MediaWiki-extensions-GlobalPreferences
Od1n added a comment to T417072: Wrong string check for "-local-exception" suffix.

Thanks for checking in. I had to use the API because the preference in question isn't exposed in Special:Preferences.

Feb 10 2026, 10:48 PM · Patch-For-Review, Community-Tech, MediaWiki-extensions-GlobalPreferences
Od1n updated the task description for T417072: Wrong string check for "-local-exception" suffix.
Feb 10 2026, 8:56 PM · Patch-For-Review, Community-Tech, MediaWiki-extensions-GlobalPreferences
Od1n created T417072: Wrong string check for "-local-exception" suffix.
Feb 10 2026, 8:31 PM · Patch-For-Review, Community-Tech, MediaWiki-extensions-GlobalPreferences

Jan 22 2026

Od1n lowered the priority of T67259: Monotonic increasing of strip markers allows information to be shared between parts of a page from High to Medium.
Jan 22 2026, 9:41 PM · MediaWiki-Parser

Jan 21 2026

Od1n added a comment to T67259: Monotonic increasing of strip markers allows information to be shared between parts of a page.
  • Base64 encodes data in groups of 3 bytes using 4 characters. Therefore, for maximum encoding efficiency, we should pick a number of bytes that is a multiple of 3. A sweet spot would be 12 bytes (96 bits), encoded using 16 characters (and as a bonus, 16 is a nice number). 96 bits is still sufficient for practical collision resistance, but I don't want to go below that since the "random ID" method relies on collision avoidance for correct operation.
  • I've thought of an improved approach: we could store the generated random IDs in a set (O(1) lookup), and if an ID is generated twice, simply generate a new one (or, with a deterministic RNG, advance to the next value). This would even allow using a 32‑bit space while keeping the current [0-9a-f]{8} format; collisions would occur, of course, but they would be detected and avoided.
  • I would be very interested to know whether intermediate markers affect page caching, because that would determine whether the correct method is to use true randomness or a deterministic RNG.
Jan 21 2026, 7:44 AM · MediaWiki-Parser

Jan 20 2026

Od1n added a comment to T67259: Monotonic increasing of strip markers allows information to be shared between parts of a page.

That being said:

Jan 20 2026, 5:50 PM · MediaWiki-Parser
Od1n updated subscribers of T67259: Monotonic increasing of strip markers allows information to be shared between parts of a page.
Jan 20 2026, 6:47 AM · MediaWiki-Parser
Od1n added a comment to T67259: Monotonic increasing of strip markers allows information to be shared between parts of a page.

The solution could be to use a deterministic RNG with a fixed seed.

Jan 20 2026, 6:34 AM · MediaWiki-Parser
Od1n added a comment to T67259: Monotonic increasing of strip markers allows information to be shared between parts of a page.

To clarify, the random part I suggested here is not the same as the random part in the old marker format, from before Gerrit 214404.

Jan 20 2026, 4:47 AM · MediaWiki-Parser
Od1n added a comment to T67259: Monotonic increasing of strip markers allows information to be shared between parts of a page.

An (almost) backward‑compatible solution would be to replace in these markers the incrementing “8 hex digits” part with 8 random hex digits. However, that would have only a 32‑bit space, which has far too much collision risk.

Jan 20 2026, 4:28 AM · MediaWiki-Parser
Od1n added a comment to T368143: Can we cache the result of executeModule to improve #invoke startup time?.

@SomeRandomDeveloper As you are not subscribed to that other ticket, in T357199#10290324 I suggested another approach that would have a better chance of being accepted (as it preserves context isolation): lazy‑loading the mw.* libraries on first call rather than cloning everything from the beginning… However, I don’t know for sure whether it would be technically doable.

Jan 20 2026, 3:41 AM · MW-1.46-notes (1.46.0-wmf.23; 2026-04-07), Performance Issue, Scribunto

Jan 7 2026

Od1n added a comment to T342347: Allow users to always enable safemode.

Yay, another preference adding to the bloat. The usefulness‑to‑noise ratio here feels extremely low.

Jan 7 2026, 5:22 AM · User-notice-archive, MW-1.41-notes (1.41.0-wmf.27; 2023-09-19), affects-Miraheze, MediaWiki-Core-Preferences

Dec 1 2025

Od1n added a comment to T265566: useformat=mobile does not make proper CSS/JS changes.

From an editor perspective, useformat=mobile should do what is written on the tin: render as on mobile. That means enabling MobileFrontend and using the default/only mobile skin, Minerva (unless a parameter useskin is also supplied).

Dec 1 2025, 9:27 PM · MobileFrontend (ResourceLoader)

Nov 30 2025

Od1n added a comment to T238385: Links in table of contents don't work for certain characters.

This hardening should be applied to JavaScript mediawiki.util as well,
specifically into escapeIdForLink method (which is notably used by getUrl method).

Nov 30 2025, 12:10 AM · Vector 2022, MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Patch-For-Review, TechCom, Web-Team-Backlog-Archived (Tracking), MediaWiki-Parser

Nov 28 2025

Od1n updated Od1n.
Nov 28 2025, 7:15 AM
Od1n updated Od1n.
Nov 28 2025, 7:06 AM

Nov 13 2025

Od1n renamed T396626: Hardware retirement Graphite Infrastructure (ETA June 2026) from Hardware retirement Graphite Infrastruture (ETA June 2026) to Hardware retirement Graphite Infrastructure (ETA June 2026).
Nov 13 2025, 11:57 AM · SRE Observability (FY2025/2026-Q1), MW-1.45-notes (1.45.0-wmf.1; 2025-05-13), Technical-Debt, Observability-Metrics

Nov 10 2025

Od1n closed T409679: Remove library "dasprid/enum" which is no longer needed as Declined.
Nov 10 2025, 10:00 PM · Upstream, Technical-Debt, MediaWiki-Vendor
Od1n added a comment to T409679: Remove library "dasprid/enum" which is no longer needed.

Thanks for taking a look! I hadn't considered that the dependency was coming from another library — good catch.

Nov 10 2025, 9:58 PM · Upstream, Technical-Debt, MediaWiki-Vendor
Od1n created T409679: Remove library "dasprid/enum" which is no longer needed.
Nov 10 2025, 2:25 AM · Upstream, Technical-Debt, MediaWiki-Vendor

Nov 9 2025

Od1n added a comment to T387778: [breaking change] Font modes: Introduce font modes to Codex.

It's been six months since I reported the font size issues in Vector classic caused by missing CSS variables like --font-size-medium.

Nov 9 2025, 3:04 AM · Patch-For-Review, Design-System-Team (DST-Sprint-45 (2025-04-14 to 2025-04-25)), Codex 2.0, Codex

Oct 27 2025

Od1n updated the task description for T408402: Links in skin selector should not be part of radio input labels.
Oct 27 2025, 3:20 PM · MediaWiki-Core-Preferences, OOUI, MediaWiki-User-Interface (actions)
Od1n created T408402: Links in skin selector should not be part of radio input labels.
Oct 27 2025, 3:11 PM · MediaWiki-Core-Preferences, OOUI, MediaWiki-User-Interface (actions)

Oct 22 2025

Od1n added a comment to T406724: Clean up watchlist and user properties of users if they don't log in for certain time.

Generally speaking, I abhor when websites, forums, or shops delete user accounts after some period of inactivity.

Oct 22 2025, 9:51 AM · Patch-For-Review, MW-1.46-notes (1.46.0-wmf.1; 2025-11-05), MW-1.45-notes (1.45.0-wmf.23; 2025-10-14), User-notice, Moderator-Tools-Team, MediaWiki-Core-Preferences, MediaWiki-Watchlist, DBA

Oct 12 2025

Od1n updated the task description for T398827: Fold LessVarModule into FileModule to enable teams to reduce startup manifest size.
Oct 12 2025, 7:48 AM · MW-1.46-notes (1.46.0-wmf.22; 2026-03-31), MediaWiki-Platform-Team (Q3 Kanban Board), Developer Productivity, MediaWiki-ResourceLoader

Oct 10 2025

Od1n added a comment to T392522: IP reveal: IP reveal fails if the temporary account is expired.

Currently, for registered users, the only option is still to use textContent, with a lookup for <bdi> to prevent breakage:

Oct 10 2025, 1:02 PM · Temporary accounts (Create/update essential tools/anti-abuse management), MW-1.44-notes (1.44.0-wmf.27; 2025-04-29), Trust and Safety Product Team, CheckUser, Trust and Safety Product Sprint (Sprint Cozonac (April 14 - May 2))

Aug 7 2025

Od1n added a comment to T319081: Add "contribs" link for IP edits in revision history.

If we go the "username" route (note that it's exactly the same structure as my previous drafts):

Aug 7 2025, 11:46 AM · MediaWiki-Page-history

Jul 29 2025

Od1n added a comment to T388124: CheckUser IP reveal: Support IP reveal on Special:AbuseLog.

The latest significant commits to the AbuseFilter extension seem to solely be about protected variables, afl_ip, afl_ip_hex, etc. That's why, as an educated guess, I assumed the regression might have been introduced during the work related to the items from this ticket.

Jul 29 2025, 5:32 AM · MW-1.45-notes (1.45.0-wmf.16; 2025-08-26), Trust and Safety Product Sprint (Sprint Princess Tarta (August 18 - September 5)), OKR-Work, Temporary accounts (Global wiki rollout), AbuseFilter, CheckUser, Trust and Safety Product Team

Jul 28 2025

Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

I just noticed that a mw-collapsible-toggle-placeholder class has been introduced in the meantime. Refs gerrit 897905 and gerrit 1020287.

Jul 28 2025, 2:31 AM · MediaWiki-General, CSS, JavaScript

Jul 9 2025

Od1n updated subscribers of T305315: Empty elements should be removed when producing the extract.

Hi @Pppery, I noticed the aside note I’d added was removed—no worries at all, I'm sure you had a good reason. It's been a while and I honestly don't remember the details well, so just curious what prompted the change. Thanks!

Jul 9 2025, 8:26 PM · Navigation-Popups-Gadget, TextExtracts

Jul 8 2025

Od1n created T398929: Follow-up cleanup of legacy edit toolbar integration points.
Jul 8 2025, 10:26 AM · Technical-Debt, JavaScript, MediaWiki-Page-editing
Od1n added a comment to T30856: Remove classic edit toolbar from core.

If you are interested in cleaning up additional remnants:

Jul 8 2025, 12:32 AM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), User-notice-archive, MW-1.32-notes, MW-1.29-release-notes, Technical-Debt, JavaScript, MediaWiki-Page-editing

Jun 25 2025

Od1n added a comment to T397496: Remove obsolete #toolbar fixed height CSS from some skins.

The removal of height: 22px causes the toolbar to occupy slightly more vertical space (exactly 22.292px in my current test). Previously, it was precisely 22px but slightly overlapped the textarea.

Jun 25 2025, 5:08 AM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), CSS, Timeless, Splash, MediaWiki-skins-Pivot, MediaWiki-skins-Foreground, Technical-Debt

Jun 23 2025

Od1n added a comment to T397496: Remove obsolete #toolbar fixed height CSS from some skins.

Refs related: Gerrit 1161826 — removal of the mw-toolbar-editbutton class (which appears to have been done a bit too hastily).

Jun 23 2025, 3:36 AM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), CSS, Timeless, Splash, MediaWiki-skins-Pivot, MediaWiki-skins-Foreground, Technical-Debt

Jun 20 2025

Od1n removed a project from T30856: Remove classic edit toolbar from core: Patch-For-Review.
Jun 20 2025, 5:35 PM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), User-notice-archive, MW-1.32-notes, MW-1.29-release-notes, Technical-Debt, JavaScript, MediaWiki-Page-editing
Od1n added a comment to T30856: Remove classic edit toolbar from core.

I have since identified other similar changes that need to be made, and I have opened a new task, T397496, to track them.

Jun 20 2025, 4:41 AM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), User-notice-archive, MW-1.32-notes, MW-1.29-release-notes, Technical-Debt, JavaScript, MediaWiki-Page-editing
Od1n added a comment to T397496: Remove obsolete #toolbar fixed height CSS from some skins.

I have submitted patches for the first four skins. Regarding the fifth one, Skin:Chameleon, it is only hosted on GitHub…

Jun 20 2025, 4:30 AM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), CSS, Timeless, Splash, MediaWiki-skins-Pivot, MediaWiki-skins-Foreground, Technical-Debt
Od1n created T397496: Remove obsolete #toolbar fixed height CSS from some skins.
Jun 20 2025, 3:52 AM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), CSS, Timeless, Splash, MediaWiki-skins-Pivot, MediaWiki-skins-Foreground, Technical-Debt

Jun 19 2025

Od1n added a comment to T30856: Remove classic edit toolbar from core.

Now that https://gerrit.wikimedia.org/r/c/mediawiki/core/+/317079 was merged in 2018 (and in particular, see the changes at the bottom of this page), we should undo https://gerrit.wikimedia.org/r/c/mediawiki/core/+/373403 (which was merged in 2017): its CSS is now useless, as we are no longer inserting empty #toolbar elements.

Jun 19 2025, 4:59 PM · MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), User-notice-archive, MW-1.32-notes, MW-1.29-release-notes, Technical-Debt, JavaScript, MediaWiki-Page-editing

Jun 13 2025

Od1n added a comment to T373711: Add support for Scribunto, JavaScript, CSS, JSON and Vue to CodeMirror 6.

Since it hasn't been brought up yet on this ticket, I wanted to mention that the AbuseFilter's rules editor also currently uses Ace Editor. What's particularly noteworthy here is that AbuseFilter rules are their own distinct language, not one of the standard content models being discussed for CodeMirror 6 support.

Jun 13 2025, 4:03 PM · User-notice-archive, MW-1.46-notes (1.46.0-wmf.21; 2026-03-24), MW-1.45-notes (1.45.0-wmf.20; 2025-09-23), MW-1.44-notes (1.44.0-wmf.28; 2025-05-06), MediaWiki-extensions-CodeMirror

Jun 10 2025

Od1n triaged T335133: Add keywords and functions for case-insensitive plaintext search as Low priority.
Jun 10 2025, 5:16 PM · AbuseFilter
Od1n added a comment to T200942: file_sha1 must be given in lowercase.

I think that no assumption should be made about the case of file_sha1, as it is subject to change without notice. Also, in the context of a hexadecimal string, "a" and "A" have exactly the same significance.

Jun 10 2025, 5:16 PM · AbuseFilter
Od1n added a comment to T391811: Rename 'all_links' to 'new_links'.

I explored alternative approaches using AI but couldn't find a better solution.

Jun 10 2025, 4:50 PM · User-notice-archive, MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), AbuseFilter
Od1n added a comment to T391811: Rename 'all_links' to 'new_links'.

However, new_links introduces an ambiguity: it could suggest that the variable contains "new links" only, meaning "added links," whereas it actually refers to "all links of the new revision". The new_html, new_text, and new_size variables are less affected by this potential misunderstanding.

Jun 10 2025, 4:32 PM · User-notice-archive, MW-1.45-notes (1.45.0-wmf.7; 2025-06-24), AbuseFilter

Jun 7 2025

Od1n added a comment to T381537: Raise Grade A JavaScript requirement from ES2016 (ES7) to ES2017 (ES8).

Thank you for the explanation. The USERJSPARSE_CACHE_VERSION is simply located in /includes/ResourceLoader/Module.php.

Jun 7 2025, 5:07 AM · User-notice-archive, MW-1.45-notes (1.45.0-wmf.6; 2025-06-17), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-ResourceLoader, JavaScript

Jun 6 2025

Od1n added a comment to T381537: Raise Grade A JavaScript requirement from ES2016 (ES7) to ES2017 (ES8).

Interestingly, a user resolved the issue by modifying the relevant script to force a server-side refresh (he also first attempted a null edit, but that apparently did not solve the issue).

Jun 6 2025, 10:09 AM · User-notice-archive, MW-1.45-notes (1.45.0-wmf.6; 2025-06-17), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-ResourceLoader, JavaScript
Od1n added a comment to T381537: Raise Grade A JavaScript requirement from ES2016 (ES7) to ES2017 (ES8).

We have an issue on frwiki. Although we have been updated to 1.45.0-wmf.4 as expected, we are encountering this error:

Jun 6 2025, 8:39 AM · User-notice-archive, MW-1.45-notes (1.45.0-wmf.6; 2025-06-17), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-ResourceLoader, JavaScript

Jun 5 2025

Od1n added a comment to T228380: Tech debt: sunsetting of Graphite.

I was using these graphs to monitor AbuseFilter performance—specifically, average execution time over time and conditions used (there is a hard limit of 2,000—previously 1,000—that is subject to being hit). Is there a replacement for this dashboard?

Jun 5 2025, 3:19 AM · MW-1.46-notes (1.46.0-wmf.4; 2025-11-25), SRE Observability (FY2025/2026-Q1), MW-1.45-notes (1.45.0-wmf.1; 2025-05-13), Patch-For-Review, Technical-Debt, Observability-Metrics

Jun 2 2025

Od1n added a comment to T381537: Raise Grade A JavaScript requirement from ES2016 (ES7) to ES2017 (ES8).

Refs the Tech News page: Tech/News/2025/23. (I'm not sure why this link hasn't been added to the task description, so I didn't include it myself.)

Jun 2 2025, 8:57 AM · User-notice-archive, MW-1.45-notes (1.45.0-wmf.6; 2025-06-17), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-ResourceLoader, JavaScript

May 27 2025

Od1n added a comment to T381537: Raise Grade A JavaScript requirement from ES2016 (ES7) to ES2017 (ES8).

I used AI to tweak the announcement—you might find some of its changes worth picking up:

May 27 2025, 8:05 PM · User-notice-archive, MW-1.45-notes (1.45.0-wmf.6; 2025-06-17), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-ResourceLoader, JavaScript

May 25 2025

Od1n closed T336127: No warning is shown when previewing a "sanitized-css" page containing unsupported CSS as Resolved.

Looks like this is fixed now—turns out the change in SyntaxHighlight’s hook did the trick. Thanks to everyone who helped look into this! Closing the ticket.

May 25 2025, 12:01 AM · Regression, MediaWiki-Page-editing, TemplateStyles, css-sanitizer

May 20 2025

Od1n added a comment to T369784: nsText property of Title objects should contain spaces instead of underscores.

Refs T58217, which had already identified discrepancies in prefixedText and nsText, fixed the former but not the latter.

May 20 2025, 11:16 PM · Patch-For-Review, Scribunto
Od1n added a comment to T380317: Add missing tests for nsText property of title objects, and set it to nil for interwiki links.

⚠️🤔 There is something I don't understand:

  • The current value of this property is '' (empty string): as obtained with mw.title.new( 'interwikiprefix:Module:TestFramework' ).interwiki
  • However, the relevant unit test expects the value 'interwikiprefix': TitleLibraryTests.lua#L296.
May 20 2025, 11:10 PM · Patch-For-Review, Scribunto

May 19 2025

Od1n added a comment to T20157: Implement a {{#trim}}, {{#ltrim}}, {{#rtrim}} in StringFunctions.
  • I find the syntax with start/end parameters ({{trim:...|0|1}}) to be both awkward and uncommon.
    • Nevertheless, as I mentioned earlier, partial trims cannot be implemented since branches are automatically trimmed.
  • The term "trim" encompasses two distinct use cases:
    • A) Trimming for template coding purposes: Here, we should only remove spaces, newlines, and occasional tab characters.
      • Indeed, I am fairly certain that some values contain leading or trailing non-breaking spaces that we do not want to trim.
      • Additionally, since this function will be used frequently, it must be highly efficient—Unicode handling would undermine that.
    • B) Trimming for editorial purposes (?): In this case, we could consider trimming all possible spaces.
  • To start, I believe we should implement only the first mode (A).
    • If necessary later on, we could introduce a "mode" parameter: {{trim:...|BASIC}} (default) and {{trim:...|EXHAUSTIVE}}.
    • However, I am not convinced that mode B is widely needed. For rare cases, it could potentially be handled in a custom userland Lua module.
May 19 2025, 6:24 PM · ParserFunctions

May 18 2025

Od1n added a comment to T387143: Minerva footer hides new items by default.

As a side effect of removing the troublesome hack, the bug in T387797 surfaced.

May 18 2025, 9:52 PM · MW-1.44-notes (1.44.0-wmf.19; 2025-03-04), patch-welcome, MinervaNeue
Od1n added a comment to T387797: Stray dot in footer when page previews enabled.

Just for fun:

May 18 2025, 9:47 PM · Reader Experience Team, MinervaNeue, Reader Growth Team, patch-welcome, Page-Previews
Od1n added a comment to T382937: Improve repositioning of "Terms of Use" in footer links.

Refs T387143, which solved the issue at hand.

May 18 2025, 9:34 PM · MW-1.44-notes (1.44.0-wmf.19; 2025-03-04), MediaWiki-Core-Skin-Architecture, MediaWiki-User-Interface, MobileFrontend
Od1n added a comment to T387797: Stray dot in footer when page previews enabled.

I've just reviewed the patch code, and it looks pretty much ready. Maybe we could reactivate the patch, as it seems almost ready to be merged?

May 18 2025, 8:39 PM · Reader Experience Team, MinervaNeue, Reader Growth Team, patch-welcome, Page-Previews
Od1n added a comment to T20157: Implement a {{#trim}}, {{#ltrim}}, {{#rtrim}} in StringFunctions.

About ltrim and rtrim proposals: parser function branches are automatically trimmed, thus it may be difficult—and inconsistent—to implement these functions, as it would involve introducing some way to not trim spaces. Therefore, I'm not sure this would be a good idea.

May 18 2025, 12:35 PM · ParserFunctions
Od1n added a comment to T20157: Implement a {{#trim}}, {{#ltrim}}, {{#rtrim}} in StringFunctions.

ltrim and rtrim may be interesting proposals as well; however, these names are centered around left-to-right languages. A more inclusive approach would be to name them trimstart and trimend.

May 18 2025, 12:01 PM · ParserFunctions
Od1n added a comment to T20157: Implement a {{#trim}}, {{#ltrim}}, {{#rtrim}} in StringFunctions.

2025 here. 👋 I have just created T394604, and afterwards I noticed this ticket in a workboard.

May 18 2025, 11:56 AM · ParserFunctions
Od1n added projects to T394604: Implementing a {{trim:}} parser function: MediaWiki-Parser-Templates, MediaWiki-Parser, Parsoid.
May 18 2025, 11:53 AM · Parsoid, MediaWiki-Parser, MediaWiki-Parser-Templates, ParserFunctions
Od1n created T394604: Implementing a {{trim:}} parser function.
May 18 2025, 11:50 AM · Parsoid, MediaWiki-Parser, MediaWiki-Parser-Templates, ParserFunctions

May 16 2025

Od1n added a comment to T387778: [breaking change] Font modes: Introduce font modes to Codex.

Again on Vector classic, I just noticed another similar issue: on history pages, the font size of the "Compare selected revisions" button is too large.

May 16 2025, 12:31 PM · Patch-For-Review, Design-System-Team (DST-Sprint-45 (2025-04-14 to 2025-04-25)), Codex 2.0, Codex

May 15 2025

Od1n added a comment to T387778: [breaking change] Font modes: Introduce font modes to Codex.

On Vector classic, it seems that this changeset unexpectedly increased the font size of warning messages.

May 15 2025, 4:47 PM · Patch-For-Review, Design-System-Team (DST-Sprint-45 (2025-04-14 to 2025-04-25)), Codex 2.0, Codex

May 13 2025

Od1n added a comment to T324991: Make Wikibase not rely on the ResourceLoader target system.

For quite some time now, a JavaScript error has been occurring on Commons. See T321532 for details.

May 13 2025, 3:35 AM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), User-ItamarWMDE, [Archived]Wikidata Dev Team, wmde-wikidata-tech, Wikidata, Wikidata-Campsite, User-Jdlrobson, Technical-Debt (RW-Tech-Debt)
Od1n added a comment to T321532: Console error - 'Error: View mediainfoview does not exist' on Commons File pages.

I can easily reproduce this error as well. Come on, it's been occurring since 2022!

May 13 2025, 3:24 AM · Wikidata-UX, JavaScript, [DEPRECATED] wdwb-tech, Wikidata, SDC General, Wikimedia-production-error, WikibaseMediaInfo, Structured-Data-Backlog

Apr 26 2025

Od1n added a comment to T347299: Create a button to expand all collapsible elements on a page.

The wishlist request is not only about the "Find in page" browser functionality, it also seeks an easy way to uncollapse everything:

Apr 26 2025, 4:24 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Moderator-Tools-Team (Kanban), Wikimedia Wishathon

Apr 25 2025

Od1n added a comment to T178146: Add support for a newer Lua version than Lua 5.1 to luasandbox.

I have reviewed the lists of new features (Lua 5.2, Lua 5.3, Lua 5.4), and apart from the hexadecimal and Unicode escapes I mentioned earlier, I don't see anything particularly compelling. That said, I believe these escapes alone would justify implementing a newer Lua version.

Apr 25 2025, 8:28 PM · LuaSandbox, Scribunto

Apr 16 2025

Od1n added a comment to T178146: Add support for a newer Lua version than Lua 5.1 to luasandbox.

Some interesting new features, related to multibyte strings:

  • Lua 5.2 would let us use hexadecimal byte codes in strings, whereas we currently have to rely on decimal byte codes, which are very uncommon. Example: we could replace the very unusual \194\160 with \xC2\xA0.
  • Lua 5.3 would even let us use Unicode code points in strings. Example: \u{A0}.
    • These code points are converted into their corresponding sequences of UTF-8 bytes (as outlined here). Keep in mind, they remain multibyte strings and come with all the associated caveats when using native string.* functions.
Apr 16 2025, 2:07 AM · LuaSandbox, Scribunto