Page MenuHomePhabricator

Od1n
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 8 2016, 3:49 PM (358 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Od1n [ Global Accounts ]

Recent Activity

Thu, Mar 16

Od1n awarded T331787: Repeated icons on Special:AbuseFilter/examine/log and Special:AbuseFilter/test a Like token.
Thu, Mar 16, 12:31 AM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), AbuseFilter

Mon, Mar 6

Od1n renamed T299117: Implement message Mainpage-title and Mainpage-title-loggedin in skins Modern and CologneBlue from Implement message Mainpage-title and Mainpage-title-loggedin in skins Modern and Cologneblue to Implement message Mainpage-title and Mainpage-title-loggedin in skins Modern and CologneBlue.
Mon, Mar 6, 10:12 AM · Modern, CologneBlue
Od1n updated the task description for T299117: Implement message Mainpage-title and Mainpage-title-loggedin in skins Modern and CologneBlue.
Mon, Mar 6, 10:10 AM · Modern, CologneBlue
Od1n removed projects from T299117: Implement message Mainpage-title and Mainpage-title-loggedin in skins Modern and CologneBlue: patch-welcome, CologneBlue.
Mon, Mar 6, 10:08 AM · Modern, CologneBlue
Od1n added a comment to T299117: Implement message Mainpage-title and Mainpage-title-loggedin in skins Modern and CologneBlue.

For the record, the message has been implemented in Cologneblue too: https://gerrit.wikimedia.org/r/776234.

Mon, Mar 6, 10:07 AM · Modern, CologneBlue

Fri, Feb 24

Od1n added a comment to T328340: Improve the saving of persistent settings.

However, for this localStorage to be effective, its value should be read on startup, when the script is executed on subsequent page views.

Fri, Feb 24, 12:34 AM · Readers-Web-Backlog (Needs Prioritization (Tech)), Patch-For-Review, Desktop Improvements (Vector 2022)

Thu, Feb 23

Od1n added a comment to T328340: Improve the saving of persistent settings.

Note it wouldn't fully solve your use case, because my solution wouldn't trigger the API save either. But it would solve the issue on same browser.

Thu, Feb 23, 1:23 AM · Readers-Web-Backlog (Needs Prioritization (Tech)), Patch-For-Review, Desktop Improvements (Vector 2022)
Od1n added a comment to T328340: Improve the saving of persistent settings.

That's due to the debounce of the API save. Such a debounce is mandatory, otherwise the user could trigger a lot of API calls. Not to mention that because the HTTP requests don't necessarily finish in the same order they were started, another request than the latest one could end up doing the lastest save.

Thu, Feb 23, 1:03 AM · Readers-Web-Backlog (Needs Prioritization (Tech)), Patch-For-Review, Desktop Improvements (Vector 2022)

Feb 21 2023

Od1n added a comment to T209310: Consider implementing Module:No globals / Log globals in Scribunto itself.

There was no patch for the REL1_36 branch, is it an overlook?

Feb 21 2023, 12:04 AM · User-notice-archive, MW-1.40-notes (1.40.0-wmf.6; 2022-10-17), MediaWiki-extensions-Scribunto

Feb 15 2023

Od1n updated the task description for T328340: Improve the saving of persistent settings.
Feb 15 2023, 12:03 AM · Readers-Web-Backlog (Needs Prioritization (Tech)), Patch-For-Review, Desktop Improvements (Vector 2022)

Feb 13 2023

Od1n added projects to T294856: Improvements to the editing interface: Wikimedia-abusefilter-global-maintainers, JavaScript.
Feb 13 2023, 2:12 AM · MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Community-Wishlist-Survey-2023, JavaScript, Wikimedia-abusefilter-global-maintainers, AbuseFilter

Feb 7 2023

Od1n added a comment to T328452: Add topic/read as wiki page buttons conflict with categories list on mobile.

Thanks for the patch :)

Feb 7 2023, 7:34 PM · Verified, MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), Editing-team (Kanban Board), DiscussionTools

Feb 5 2023

Od1n added a comment to T328340: Improve the saving of persistent settings.

I noticed the (currently abandonned) T257075 that proposed to refactor the checkbox hack, replacing the multiple exported method with a single super object.

Feb 5 2023, 10:29 PM · Readers-Web-Backlog (Needs Prioritization (Tech)), Patch-For-Review, Desktop Improvements (Vector 2022)
Od1n added a comment to T328870: Optimize and tidy up in mediawiki.page.ready/ready.js.

Pushed a commit to also optimize some selectors that use the [data-mw="interface"] attribute (refs https://github.com/wikimedia/mediawiki/commit/b1e3f9e38d7c74e080e99e58dac55629b9f0b097).

Feb 5 2023, 4:35 PM · Performance-Team (Radar), MediaWiki-Interface, Patch-For-Review, JavaScript
Od1n added a comment to T53583: Add more mw.hook events for wikipage: diff, categories etc..

Although this certainly has been discussed somewhere already, I'd suggest adding classes .mw-diff and .mw-catlinks, that would be used instead of table.diff and .catlinks respectively (of course, keeping these for BC).

Feb 5 2023, 4:24 PM · Performance-Team, MW-1.27-release-notes, MediaWiki-Interface, JavaScript
Od1n added a comment to T328452: Add topic/read as wiki page buttons conflict with categories list on mobile.

The selectors may be optimized:

Feb 5 2023, 4:02 PM · Verified, MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), Editing-team (Kanban Board), DiscussionTools
Od1n created T328870: Optimize and tidy up in mediawiki.page.ready/ready.js.
Feb 5 2023, 3:19 PM · Performance-Team (Radar), MediaWiki-Interface, Patch-For-Review, JavaScript

Feb 2 2023

Od1n added a comment to T328340: Improve the saving of persistent settings.

The best would be to call checkboxHack's setCheckedState() method, and only when it would actually change the sidedar state (e.g. if the sidebar is already collapsed, avoid calling setCheckedState(false)), in order to avoid triggering extraneous "input" events (as it may have unexpected side-effects). And of course, there is still the need to avoid the API save, which may be solved by setting a temporary flag.

Feb 2 2023, 7:05 AM · Readers-Web-Backlog (Needs Prioritization (Tech)), Patch-For-Review, Desktop Improvements (Vector 2022)

Feb 1 2023

Od1n added a comment to T328340: Improve the saving of persistent settings.

Another issue is that the automatic collapse/expand are done by setting the checkbox.checked property, which doesn't trigger the input change event. See in checkboxHack.js for thorough explanations. So we are missing everything that is added/modified using JS event handlers, such as ARIA, and possibly things bound elsewhere. And because of this, the state of these "JS managed" things may become stale, mismatching the actual collapsed/expanded state.

Feb 1 2023, 10:21 AM · Readers-Web-Backlog (Needs Prioritization (Tech)), Patch-For-Review, Desktop Improvements (Vector 2022)

Jan 31 2023

Od1n added a comment to T328340: Improve the saving of persistent settings.

Don't miss the comments by Vlakoff on the Gerrit page, some of them contain important information. Also, don't hesitate to compare between patchsets, as it may help understanding the individual changes.

Jan 31 2023, 9:54 PM · Readers-Web-Backlog (Needs Prioritization (Tech)), Patch-For-Review, Desktop Improvements (Vector 2022)
Od1n added a comment to T328121: Vector 2022 full width toggle doesn't cause VE's surface to fire resize events.

The code currently used ($( window ).trigger( 'resize' );) works with jQuery event listeners but not with native listeners,
i.e. it would execute a listener attached using $( window ).on( 'resize', … ), but not a listener attached using window.addEventListener( 'resize', … ).

Jan 31 2023, 2:48 PM · Editing QA, Editing-team (Kanban Board), MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Desktop Improvements (Vector 2022), VisualEditor

Jan 30 2023

Od1n added a comment to T316191: Collapse sidebar automatically at narrow widths.

Please have a look at the comments I posted at https://phabricator.wikimedia.org/T300826#8568297.

Jan 30 2023, 7:53 AM · Patch-For-Review, MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), Readers-Web-Backlog (Kanbanana-2022-23-Q1), Desktop Improvements (Vector 2022)
Od1n added a comment to T300826: VE toolbar does not resize when new Vector sidebar opened or closed.

The code to trigger the window resize event is inside the saveSidebarState() function, which has a 1000 ms debounce when it is called from bindSidebarClickEvent(). Thus, there is an undesirable delay of 1 second before repositioning the elements when the sidebar is toggled. This trigger of a "fake" window resize event should be decoupled from the API save, and executed immediately. This will result in a much snappier interface. And of course, triggering the fake window resize event and saving the state to API are two completely different things, which shouldn't be blended together.

Jan 30 2023, 7:15 AM · Patch-For-Review, Verified, MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), Editing-team (Kanban Board), VisualEditor, Desktop Improvements (Vector 2022)

Jan 29 2023

Restricted Application added a project to T213885: Multilingual Captions: Content isn't clear:both'ed on Files with no captions yet, because it's still wrapped in a mw:mediainfoView tags: Structured-Data-Backlog.

Not sure this ticket is the best place to report, but after searching about "mediainfoview", this talk page archive led me here.

Jan 29 2023, 5:19 AM · Structured-Data-Backlog, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Structured Data Engineering, Multimedia

Jan 23 2023

Od1n awarded T167577: "From date" on Special:Contributions doesn't filter Flow edits a Insectivore token.
Jan 23 2023, 4:29 AM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), Patch-For-Review, MediaWiki-Special-pages, Growth-Team-Filtering, Growth-Team, StructuredDiscussions

Jan 19 2023

Od1n added a comment to T327032: AbuseFilter: "like" keyword should support « : » character.

Reminder to self, the strtr() documentation states that « The longest keys will be tried first ».

Jan 19 2023, 6:18 AM · AbuseFilter
Od1n added a comment to T327032: AbuseFilter: "like" keyword should support « : » character.

(deleted the previous post, a stupid confusion between like and rlike)

Jan 19 2023, 6:14 AM · AbuseFilter
Od1n added a comment to T327032: AbuseFilter: "like" keyword should support « : » character.
Jan 19 2023, 6:12 AM · AbuseFilter

Jan 18 2023

Od1n added a comment to T172078: Minerva on desktop doesn't show navboxes (does it?).

On the French Wikipedia, we also have .navbox elements, however, they are not <div> but <table> elements.

Jan 18 2023, 6:42 AM · MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue (Desktop)

Jan 17 2023

Od1n added a comment to T327032: AbuseFilter: "like" keyword should support « : » character.

I just noticed a small defect, present if both the current code and I my suggestion of fixed code:

Jan 17 2023, 5:28 PM · AbuseFilter

Jan 16 2023

Od1n added a comment to T327032: AbuseFilter: "like" keyword should support « : » character.

Just a bunch of tests (and I've done many more, for example with \*, \?…):

"f+oo-bér" like "f+oo-b?r" &
Jan 16 2023, 3:32 AM · AbuseFilter
Od1n added a comment to T327032: AbuseFilter: "like" keyword should support « : » character.

I'm doing some tests, and it seems the fix is as simple as removing the '\\' => '\\\\' from WILDCARD_MAP. (and in turn, the '\+' => '\+', '\-' => '\-', and '\.' => '\.' would become useless and could be removed)

Jan 16 2023, 2:54 AM · AbuseFilter
Od1n added a comment to T327032: AbuseFilter: "like" keyword should support « : » character.

Also, I think the WILDCARD_MAP property should be moved from the AFPData class to the FilterEvaluator class (which is the one who uses it), as a protected property. Case in point, this array is not "general" and is really meant to be used by the keywordLike() method, and is applied on the result of a preg_quote(). Note this property is not used anywhere else (search in the codebase).

Jan 16 2023, 2:16 AM · AbuseFilter

Jan 15 2023

Od1n created T327032: AbuseFilter: "like" keyword should support « : » character.
Jan 15 2023, 6:55 PM · AbuseFilter

Jan 10 2023

Od1n added a comment to T326502: Consistently trim spaces when building the sort keys.

Uploaded patchset 4, which takes advantage of the fact that the root getElementSortKey() is executed only on cell elements (i.e. not on <img> tags etc.). It consolidates the code, which was needlessly split, and saves redundant executions of .nodeName.toLowerCase() (from 1 to 0 execution on the root node, and from 2 to 1 execution on (almost) every child node).

Jan 10 2023, 4:45 PM · MW-1.40-notes (1.40.0-wmf.19; 2023-01-16), JavaScript, MediaWiki-Interface (Tables)
Od1n added a comment to T326502: Consistently trim spaces when building the sort keys.

Uploaded patchset 3, that uses an inner function. I think it's definitely a better approach.

Jan 10 2023, 2:27 PM · MW-1.40-notes (1.40.0-wmf.19; 2023-01-16), JavaScript, MediaWiki-Interface (Tables)
Od1n added a comment to T326502: Consistently trim spaces when building the sort keys.

I'm thinking of a better approach, maybe it would be better to use a dedicated inner function for nested processing, rather than reusing the root getElementSortKey().

Jan 10 2023, 2:04 PM · MW-1.40-notes (1.40.0-wmf.19; 2023-01-16), JavaScript, MediaWiki-Interface (Tables)
Od1n updated subscribers of T326502: Consistently trim spaces when building the sort keys.

Just uploaded this subsequent patch, following up to this comment by @Krinkle.

Jan 10 2023, 1:49 PM · MW-1.40-notes (1.40.0-wmf.19; 2023-01-16), JavaScript, MediaWiki-Interface (Tables)
Od1n added a comment to T326502: Consistently trim spaces when building the sort keys.

As a reminder, this comment (Gerrit doesn't send me email notifications).

Jan 10 2023, 12:32 PM · MW-1.40-notes (1.40.0-wmf.19; 2023-01-16), JavaScript, MediaWiki-Interface (Tables)

Jan 9 2023

Od1n added a comment to T181024: AbuseFilter should not cast arrays into strings.

I would also support adding new keywords and functions. Mainly because of the BC concerns discussed here, and also because it's really a different processing when working with an array: instead of strpos() on bulk data, we are doing in_array() on a list.

Jan 9 2023, 9:44 PM · Patch-Needs-Improvement, AbuseFilter

Jan 8 2023

Od1n created T326502: Consistently trim spaces when building the sort keys.
Jan 8 2023, 3:21 PM · MW-1.40-notes (1.40.0-wmf.19; 2023-01-16), JavaScript, MediaWiki-Interface (Tables)

Jan 7 2023

Od1n updated the task description for T326081: Tablesorter should handle <br> as spaces in sort values.
Jan 7 2023, 5:05 PM · MW-1.40-notes (1.40.0-wmf.18; 2023-01-09), JavaScript, MediaWiki-Interface (Tables)
Od1n created T326474: Normalize consecutive spaces when building the sort values.
Jan 7 2023, 4:54 PM · MW-1.40-notes (1.40.0-wmf.18; 2023-01-09), JavaScript, MediaWiki-Interface (Tables)

Jan 3 2023

Od1n added a comment to T326081: Tablesorter should handle <br> as spaces in sort values.

If I use data-sort-value="foo bar" in wikicode, the HTML output is data-sort-value="foo bar".

Jan 3 2023, 12:57 PM · MW-1.40-notes (1.40.0-wmf.18; 2023-01-09), JavaScript, MediaWiki-Interface (Tables)
Od1n added a comment to T326081: Tablesorter should handle <br> as spaces in sort values.

Also, we may want to normalize and remove the consecutive spaces, by adding something like result.replace( /\s+/g, ' ' ).

Jan 3 2023, 12:49 PM · MW-1.40-notes (1.40.0-wmf.18; 2023-01-09), JavaScript, MediaWiki-Interface (Tables)

Jan 2 2023

Od1n created T326081: Tablesorter should handle <br> as spaces in sort values.
Jan 2 2023, 11:43 AM · MW-1.40-notes (1.40.0-wmf.18; 2023-01-09), JavaScript, MediaWiki-Interface (Tables)
Od1n added a comment to T47070: Wikitable sortable - capital letters sort both before and after small ones.

In this line :

Jan 2 2023, 10:03 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), good first task, MediaWiki-jQuery-Tablesorter--archived, JavaScript, MediaWiki-Interface

Dec 18 2022

Od1n added a comment to T180911: Add a property "talkNsText" to mw.title objects.

This seems to be a limitation of the underlying MediaWiki Title class, which apparently doesn't support interwikis by design.

Dec 18 2022, 10:47 PM · Patch-Needs-Improvement, MediaWiki-extensions-Scribunto

Dec 9 2022

Od1n added a comment to T180911: Add a property "talkNsText" to mw.title objects.

As pointed out in these comments, when there is an interwiki, the Scribunto Title objects give some erroneous results, which in turn affects the results of the "talkNsText" feature I was implementing here.

Dec 9 2022, 1:59 AM · Patch-Needs-Improvement, MediaWiki-extensions-Scribunto

Dec 6 2022

Od1n added a comment to T324523: Optimize some jQuery selectors .

I confirm Chrome and Firefox seem to have implemented some optimization for the $( '#ca-addsection a' ) case, because it's significantly faster than $( 'a' ), otherwise it would have been the contrary.

Dec 6 2022, 2:20 AM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), JavaScript, VisualEditor, DiscussionTools

Dec 5 2022

Od1n created T324523: Optimize some jQuery selectors .
Dec 5 2022, 11:54 PM · MW-1.40-notes (1.40.0-wmf.13; 2022-12-05), JavaScript, VisualEditor, DiscussionTools

Oct 31 2022

Od1n added a comment to T188731: Keep search query when switching between search backends.

As I pointed out in this comment (and the following one), there are still some issues on this matter.

Oct 31 2022, 9:20 PM · VPS-project-Codesearch
Od1n added a comment to T307361: Input text should be kept when switching to another project.

Also, I found quite surprising that clicking on another project automatically launch the search.
I think it should rather blank the results (of course keeping the input), and launch the search only when the user clicks on "Search".
Yes, that would mean an additional click, but I think it would be less confusing.

Oct 31 2022, 9:16 PM · VPS-project-Codesearch
Od1n added a comment to T307361: Input text should be kept when switching to another project.

I found a quite major defect in the beta:

Oct 31 2022, 9:13 PM · VPS-project-Codesearch
Od1n added a comment to T307361: Input text should be kept when switching to another project.

The beta version keeps the input in "use case 2", but not in "use case 1".

Oct 31 2022, 8:52 PM · VPS-project-Codesearch

Oct 30 2022

Od1n added a comment to T306883: [L] Searchers see thumbnails next to search results on the special:search page.

I think too the thumbnails should link to the article, not to the file page.

Oct 30 2022, 2:10 PM · User-notice-archive, MW-1.40-notes (1.40.0-wmf.4; 2022-10-03), MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Patch-For-Review, SDAW-Search-Improvements (Milestone 1: CSS changes to all wikis), Structured-Data-Backlog (Current Work)

Oct 14 2022

Od1n added a comment to T320741: Use delegation to reduce number of event listeners on history pages.

Some notes about the implementation:

Oct 14 2022, 2:43 AM · MW-1.40-notes (1.40.0-wmf.6; 2022-10-17), MediaWiki-Page-history, JavaScript

Oct 13 2022

Od1n added a comment to T320741: Use delegation to reduce number of event listeners on history pages.

I'm taking the opportunity to change the event type from "click" to the more modern "change", supported by IE 9+ (refs caniuse, MDN). See patchset 2.

Oct 13 2022, 4:42 PM · MW-1.40-notes (1.40.0-wmf.6; 2022-10-17), MediaWiki-Page-history, JavaScript
Od1n added a comment to T320741: Use delegation to reduce number of event listeners on history pages.

Refs some related commits:

Oct 13 2022, 4:17 PM · MW-1.40-notes (1.40.0-wmf.6; 2022-10-17), MediaWiki-Page-history, JavaScript
Od1n created T320741: Use delegation to reduce number of event listeners on history pages.
Oct 13 2022, 4:02 PM · MW-1.40-notes (1.40.0-wmf.6; 2022-10-17), MediaWiki-Page-history, JavaScript

Oct 2 2022

Od1n added a comment to T297019: Editors should be able to blank the main page title without MediaWiki:Vector.css changes for Vector.

I have updated the list of IDs and classes in the documentation: edits 5499359, 5499361, and 5499362.

Oct 2 2022, 4:28 AM · Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), MediaWiki-Core-Skin-Architecture

Sep 19 2022

Od1n added a comment to T290480: Move Interlanguage link on Main page to the top at euwiki.

You can try it on our home page using the following code:

Sep 19 2022, 4:31 PM · Desktop Improvements (Vector 2022)
Od1n added a comment to T290480: Move Interlanguage link on Main page to the top at euwiki.

I agree too that this move of the language switcher to the bottom of the page, because there is no other place for now, as a "let's hide this under the carpet for the time being" workaround, is really ugly!
Of course, everyone is already aware of this and agree that this definitely has to be improved. Especially as we are dealing with the home pages here.

Sep 19 2022, 12:41 PM · Desktop Improvements (Vector 2022)

Sep 11 2022

Od1n updated the task description for T306942: Skins should no longer output HTML and head tag.
Sep 11 2022, 4:05 PM · MW-1.40-release, Patch-For-Review, MediaWiki-Core-Skin-Architecture, good first task, patch-welcome
Od1n updated the task description for T306942: Skins should no longer output HTML and head tag.
Sep 11 2022, 4:03 PM · MW-1.40-release, Patch-For-Review, MediaWiki-Core-Skin-Architecture, good first task, patch-welcome
Od1n removed a project from T56312: colon in URL encoded in property parser function: patch-welcome.
Sep 11 2022, 3:59 PM · Wikidata, Verified, MediaWiki-extensions-WikibaseClient

Aug 31 2022

Od1n awarded T315418: Legacy Vector "More options" dropdown does not show on hover a Like token.
Aug 31 2022, 7:04 AM · MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Readers-Web-Backlog (Kanbanana-2022-23-Q1), Regression, Vector (legacy skin)

Aug 23 2022

Od1n added a comment to T42062: Provide CSS class (hlist) to define horizontal lists in MediaWiki core.

hlists inside warningboxes should not have a left margin, nor should they be crammed together.

Aug 23 2022, 12:39 AM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Readers-Web-Backlog (Tracking), CSS, good first task, Design, MediaWiki-Interface
Od1n added a comment to T278002: messagebox styles breaks indentation in some lists.

Patch submitted. The lack of "direct child" restriction definitely seems to be an overlook.

Aug 23 2022, 12:04 AM · MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MediaWiki-Core-Skin-Architecture, MediaWiki-Interface, CSS

Aug 22 2022

Od1n added a comment to T42062: Provide CSS class (hlist) to define horizontal lists in MediaWiki core.

What is the purpose of the following code in mediawiki.hlist/default.less?

Aug 22 2022, 11:32 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Readers-Web-Backlog (Tracking), CSS, good first task, Design, MediaWiki-Interface
Od1n added a comment to T278002: messagebox styles breaks indentation in some lists.

Ah, of course, because if using the wiki with English language, the displayed message is not MediaWiki:Previewnote, but MediaWiki:Previewnote/en... Please try with the default French language.

Aug 22 2022, 7:46 AM · MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MediaWiki-Core-Skin-Architecture, MediaWiki-Interface, CSS

Aug 21 2022

Od1n added a comment to T278002: messagebox styles breaks indentation in some lists.

Use case: System message MediaWiki:Previewnote on French wiki.

Aug 21 2022, 12:35 PM · MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MediaWiki-Core-Skin-Architecture, MediaWiki-Interface, CSS
Od1n added a comment to T278002: messagebox styles breaks indentation in some lists.

I just noticed the bug too, and was about to open a task suggesting to use more specific, direct child, selectors (i.e. .mw-message-box > :only-child).
Preliminary diggings led me to https://phabricator.wikimedia.org/rMW1fd66a67edcd, then to this already existing task.

Aug 21 2022, 8:02 AM · MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MediaWiki-Core-Skin-Architecture, MediaWiki-Interface, CSS

Jun 18 2022

Od1n updated the task description for T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js.
Jun 18 2022, 5:11 AM · Performance-Team (Radar), Vector (legacy skin), Patch-For-Review, JavaScript

Jun 15 2022

Od1n added a comment to T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js.

@Krinkle May I kindly ask if you have news about this?

Jun 15 2022, 11:05 PM · Performance-Team (Radar), Vector (legacy skin), Patch-For-Review, JavaScript

May 26 2022

Od1n added a comment to T306281: Boxes in French Wikipedia Skew Section Headers.

You can test the mobile version on a desktop computer simply by using the fr.m.wikipedia.org domain. Although not on a smartphone, it's sufficient when writing local CSS etc.

May 26 2022, 11:19 PM · Product-Infrastructure-Team-Backlog-Deprecated (Kanban), Wikipedia-Android-App-Backlog

May 17 2022

Od1n added a comment to T308504: Redirects should be italicised on Special:MostTranscludedPages (and maybe other pages as well).

Uploaded a new patch:

May 17 2022, 12:42 AM · Patch-For-Review, CSS, MediaWiki-Interface
Od1n added a comment to T308504: Redirects should be italicised on Special:MostTranscludedPages (and maybe other pages as well).

Here is the CSS I'm adding in the patch:

.mw-special-Mostlinkedtemplates .mw-redirect {
    font-style: italic;
}

A few notes:

May 17 2022, 12:26 AM · Patch-For-Review, CSS, MediaWiki-Interface
Od1n created T308504: Redirects should be italicised on Special:MostTranscludedPages (and maybe other pages as well).
May 17 2022, 12:14 AM · Patch-For-Review, CSS, MediaWiki-Interface

May 2 2022

Od1n created T307361: Input text should be kept when switching to another project.
May 2 2022, 2:08 PM · VPS-project-Codesearch

May 1 2022

Od1n added a comment to T188737: In the list of "templates used on this page" when editing, highlight redirect templates by italicising them (like we do elsewhere)..

Redirects should be italicised on this special page as well: Special:MostTranscludedPages.

May 1 2022, 2:13 PM · MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Patch-For-Review, good first task, MediaWiki-Interface

Apr 7 2022

Od1n added a comment to T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js.

It is registered as a different module

Understood. It loads vector.js (from the legacy skin) in addition to the rest.

Apr 7 2022, 3:57 PM · Performance-Team (Radar), Vector (legacy skin), Patch-For-Review, JavaScript
Od1n added a comment to T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js.

Thanks @Func for looking into this.

Apr 7 2022, 6:42 AM · Performance-Team (Radar), Vector (legacy skin), Patch-For-Review, JavaScript

Apr 6 2022

Od1n created T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js.
Apr 6 2022, 10:03 PM · Performance-Team (Radar), Vector (legacy skin), Patch-For-Review, JavaScript
Od1n added a comment to T302627: Skin continously switch to Vector 2022 despite (global) preferences.

Indeed, I was also encountering this issue on mediawiki.org. I don't remember on what pages exactly, but I'm pretty sure it was occurring on ResourceLoader/Core modules.

Apr 6 2022, 12:29 AM · MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), MW-1.38-release, Community-Tech, MediaWiki-extensions-GlobalPreferences, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector (legacy skin)

Apr 5 2022

Od1n added a comment to T302627: Skin continously switch to Vector 2022 despite (global) preferences.

Also, I usually fix this issue by doing a force refresh (shift + F5). A regular refresh (F5) isn't sufficient.

Apr 5 2022, 5:30 PM · MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), MW-1.38-release, Community-Tech, MediaWiki-extensions-GlobalPreferences, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector (legacy skin)
Od1n added a comment to T302627: Skin continously switch to Vector 2022 despite (global) preferences.

I am also encountering this issue. Nowadays it seems less frequent, but it may still happen sometimes. (edit: a fix has just been deployed, it simply hasn't reached frwiki yet)

Apr 5 2022, 5:23 PM · MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), MW-1.38-release, Community-Tech, MediaWiki-extensions-GlobalPreferences, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector (legacy skin)

Apr 3 2022

Od1n updated the task description for T305315: Empty elements should be removed when producing the extract.
Apr 3 2022, 3:29 AM · Reading Epics (Page Previews), Page-Previews, Navigation-Popups-Gadget, TextExtracts
Od1n created T305315: Empty elements should be removed when producing the extract.
Apr 3 2022, 2:02 AM · Reading Epics (Page Previews), Page-Previews, Navigation-Popups-Gadget, TextExtracts

Apr 1 2022

Od1n added a comment to T297019: Editors should be able to blank the main page title without MediaWiki:Vector.css changes for Vector.

I just noticed the .mw-first-heading is missing here:
https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/475508647466ea1c67d3e0d378ca3b4a76668e84/stories/skin.stories.data.js#91

Apr 1 2022, 3:37 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), MediaWiki-Core-Skin-Architecture
Od1n added a comment to T265892: MediaWiki:Pagetitle-view-mainpage does not behave the same in MinervaNeue skin as it does in other skin.

Following up to gerrit 737112 from late 2021 which has these FIXME:

Apr 1 2022, 3:20 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), Readers-Web-Backlog (Kanbanana-FY-2021-22), Patch-For-Review, MinervaNeue
Od1n added a comment to T297019: Editors should be able to blank the main page title without MediaWiki:Vector.css changes for Vector.

Currently all skins have #firstHeading, .firstHeading and .mw-first-heading, the only exception being cologneblue which only has #firstHeading.

Apr 1 2022, 4:15 AM · Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), MediaWiki-Core-Skin-Architecture
Od1n added a comment to T297019: Editors should be able to blank the main page title without MediaWiki:Vector.css changes for Vector.
  1. Back in 2009, class .firstHeading had been replaced with an ID #firstHeading, see T17427 and https://phabricator.wikimedia.org/rMWc68f345d54c3
  2. Very soon after, the class .firstHeading has been restored, alongside the ID, for backward compatibility, see https://phabricator.wikimedia.org/rMWba0f7c4c1378
  3. In 2014, the ID has been considered obsolete, see https://phabricator.wikimedia.org/rMW7d244175a3bd359bd and also this documentation update.
  4. The present ticket introduced a new class .mw-first-heading for name standardization.
Apr 1 2022, 4:09 AM · Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), MediaWiki-Core-Skin-Architecture

Mar 30 2022

Od1n updated subscribers of T250393: Use monospace font (or editfont preference) for diffs.

Currently the font has a pixel-based size (gerrit 593629).

Mar 30 2022, 3:49 PM · User-notice-archive, Editing-team, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), MediaWiki-Page-diffs

Mar 22 2022

Od1n added a comment to T304406: Loading styles from module "mediawiki.pager.styles" shouldn't have side-effect on display of Watchlist page.

Here is an extract of the markup in History and User contributions pages:

Mar 22 2022, 12:54 PM · MW-1.39-notes (1.39.0-wmf.4; 2022-03-23), MediaWiki-Interface, MediaWiki-Watchlist, CSS, Growth-Team
Od1n edited projects for T304406: Loading styles from module "mediawiki.pager.styles" shouldn't have side-effect on display of Watchlist page, added: MediaWiki-Interface; removed MediaWiki-Interface (Tables).
Mar 22 2022, 9:40 AM · MW-1.39-notes (1.39.0-wmf.4; 2022-03-23), MediaWiki-Interface, MediaWiki-Watchlist, CSS, Growth-Team
Od1n created T304406: Loading styles from module "mediawiki.pager.styles" shouldn't have side-effect on display of Watchlist page.
Mar 22 2022, 9:39 AM · MW-1.39-notes (1.39.0-wmf.4; 2022-03-23), MediaWiki-Interface, MediaWiki-Watchlist, CSS, Growth-Team

Mar 7 2022

Od1n added a comment to T302084: [Regression] Watchlist link appears twice in UI.

Has been fixed on Gerrit (relevant occurrences of class replaced with link-class).

Mar 7 2022, 1:26 AM · MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), Regression, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector (legacy skin)

Mar 4 2022

Od1n added a comment to T302084: [Regression] Watchlist link appears twice in UI.

Tests currently fail because user-links-collapsible-item is added to the <li>, and mw-ui-icon mw-ui-icon-before are added to the inner <a>,
but the tests look at the same place for both sets of classes: $content['user-menu']['userpage']['class'].

Mar 4 2022, 1:01 AM · MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), Regression, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector (legacy skin)

Feb 26 2022

Od1n added a comment to T302084: [Regression] Watchlist link appears twice in UI.

Some people may prefer to keep this additional item in the dropdown menu:

  • Has a text description.
  • The "Contributions" link is next to it.
Feb 26 2022, 7:21 AM · MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), Regression, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector (legacy skin)