Od1n
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 8 2016, 3:49 PM (88 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Od1n

Recent Activity

Sat, Jan 13

Od1n added a comment to T75556: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571.

So, you don't think there is the same issue with the 2nd do/while of the for loop? I haven't checked it thoroughly, but it just looks very similar, with these n+2 steps. That's why I added the "overflow fix" after the for loop in my demonstration patch, to cover the two do/while's.

Sat, Jan 13, 8:42 AM · Performance-Team, Wikimedia-log-errors, MediaWiki-ResourceLoader

Wed, Jan 10

Od1n added a comment to T75556: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571.

Thank you for your work on this.

Wed, Jan 10, 3:05 AM · Performance-Team, Wikimedia-log-errors, MediaWiki-ResourceLoader

Sat, Dec 30

Od1n awarded T183823: Add 'fromsection' and 'tosection' to action=compare a Party Time token.
Sat, Dec 30, 6:47 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, MediaWiki-API
Od1n added a comment to T160480: Selflinks should still be <a> tags with CSS styling via a class, not <strong> tags.

I was about to completely agree with Jdlrobson, but actually such links are HTML5's "placeholder links" and seem to be the recommended way…

Sat, Dec 30, 10:06 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), User-Ryasmeen, Technical-Debt, MediaWiki-Parser, MediaWiki-General-or-Unknown, Contributors-Team, VisualEditor

Fri, Dec 29

Od1n updated the task description for T183783: Missing some "noflip" directives for thumbs in Timeless skin.
Fri, Dec 29, 3:36 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Timeless, CSS
Od1n created T183783: Missing some "noflip" directives for thumbs in Timeless skin.
Fri, Dec 29, 3:32 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Timeless, CSS
Od1n added a comment to T183611: With "live preview" enabled, "Show changes" should provide visual feedback when there are no changes.

Code references:

Fri, Dec 29, 7:11 AM · MediaWiki-History-or-Diffs, JavaScript
Od1n added a comment to T183611: With "live preview" enabled, "Show changes" should provide visual feedback when there are no changes.

There are two different points:

  • Texts "Latest revision" and "Your text" are always missing. They should be added, for consistency with the "non-live preview" mode.
  • When there is no difference (i.e. empty ajax diff content) the text "(No difference)" should be added.
Fri, Dec 29, 7:05 AM · MediaWiki-History-or-Diffs, JavaScript
Od1n added a comment to T164106: Deprecate parsing and diff options in ApiQueryRevisionsBase.

Also, documentation needs to be updated: https://www.mediawiki.org/wiki/API:Revisions

Fri, Dec 29, 6:54 AM · MW-1.30-release-notes, Technical-Debt, Patch-For-Review, MediaWiki-API
Od1n added a comment to T164106: Deprecate parsing and diff options in ApiQueryRevisionsBase.

The JavaScript of "live preview"[1] gets deprecation warnings and has to be updated.

Fri, Dec 29, 6:53 AM · MW-1.30-release-notes, Technical-Debt, Patch-For-Review, MediaWiki-API

Thu, Dec 28

Od1n added a comment to T183718: Image border missing in Timeless skin.

Thanks :) @grey-bright variable is #eee. It's a bit too light in my opinion. The next one, @grey, is #ccc, which in turn is a bit too dark. Something between the two would have been optimal.

Thu, Dec 28, 8:24 AM · Google-Code-in-2017, CSS, MediaWiki-Interface, Timeless

Wed, Dec 27

Od1n added a comment to T183718: Image border missing in Timeless skin.

I just noticed this border's color is varying across the skins…

Wed, Dec 27, 7:21 PM · Google-Code-in-2017, CSS, MediaWiki-Interface, Timeless
Od1n updated the task description for T183718: Image border missing in Timeless skin.
Wed, Dec 27, 3:13 PM · Google-Code-in-2017, CSS, MediaWiki-Interface, Timeless
Od1n created T183718: Image border missing in Timeless skin.
Wed, Dec 27, 12:28 PM · Google-Code-in-2017, CSS, MediaWiki-Interface, Timeless
Od1n added a comment to T14974: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing.

I would suggest "normal" priority. This issue gives template editors many headaches, and often results in template codes much more complex than necessary. Thus, let's not forget this issue even further than now.

Wed, Dec 27, 3:26 AM · Epic, MediaWiki-Parser

Tue, Dec 26

Od1n added a comment to T14974: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing.

Yes, please do something about this issue, even (for the time being) just adding a magic word to configure behaviour of the template, would be helpful.

Tue, Dec 26, 3:19 AM · Epic, MediaWiki-Parser

Sat, Dec 23

Od1n removed a project from T183611: With "live preview" enabled, "Show changes" should provide visual feedback when there are no changes: Wikidata.
Sat, Dec 23, 10:57 AM · MediaWiki-History-or-Diffs, JavaScript
Od1n created T183611: With "live preview" enabled, "Show changes" should provide visual feedback when there are no changes.
Sat, Dec 23, 3:41 AM · MediaWiki-History-or-Diffs, JavaScript
Od1n added a comment to T75556: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571.

Indeed, the error happens only on invalid input. Still, there is a clear possibility of overflow here, fixing it is good to do. You should consider as luck it resulted in just a php notice :)

Sat, Dec 23, 2:37 AM · Performance-Team, Wikimedia-log-errors, MediaWiki-ResourceLoader

Dec 21 2017

Od1n added a comment to T182074: Ignore whitespaces between wiki table syntax and table content.

Yes, for ensuring consistency (there can be different parsers, across Special:ExpandTemplates, preview mode, etc.)

Dec 21 2017, 11:45 PM · Patch-For-Review, MediaWiki-Parser

Dec 15 2017

Od1n added a comment to T75556: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571.

Possible fix, inserting near line 484:

Dec 15 2017, 6:09 AM · Performance-Team, Wikimedia-log-errors, MediaWiki-ResourceLoader
Restricted Application added a project to T75556: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571: Performance-Team.

Test case: JavaScriptMinifier::minify('*/');

Dec 15 2017, 5:45 AM · Performance-Team, Wikimedia-log-errors, MediaWiki-ResourceLoader

Dec 12 2017

Od1n added a comment to T46678: allow to change the order of statements.

Thanks, I had a look at the javascript code, and I'm not really a fan of this solution.

Dec 12 2017, 2:26 PM · Wikidata, Verified, MediaWiki-extensions-WikibaseRepository
Od1n added a comment to T181877: CSS loading sometimes delayed in Firefox; FOUC reproducibly displayed.

Just to mention the mobile version has this issue on all browsers actually, not only Firefox 57. Tried Chrome and Pale Moon. So maybe the mobile version has a related, but different, issue that would need to be investigated.

Dec 12 2017, 2:59 AM · Upstream, Performance-Team, Browser-Support-Firefox
Restricted Application added a project to T46678: allow to change the order of statements: Wikidata.

Looks like this feature is currently missing. (if I recall correctly, maybe it has been removed at some time)

Dec 12 2017, 2:53 AM · Wikidata, Verified, MediaWiki-extensions-WikibaseRepository

Dec 10 2017

Od1n added a comment to T181877: CSS loading sometimes delayed in Firefox; FOUC reproducibly displayed.

TBH, the fault is in Firefox 57, and the same issue happens on a shitload of websites. So I don't think there is any fix or workaround to consider for MediaWiki, the issue has to be fixed in Firefox.

Dec 10 2017, 1:08 AM · Upstream, Performance-Team, Browser-Support-Firefox

Dec 8 2017

Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

Here it is: T160480 (gerrit). Also, along this patch the mobile styles were probably forgotten, their omission wasn't on purpose.

Dec 8 2017, 3:15 AM · Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, MobileApp, Mobile, Wikipedia-Android-App-Backlog
Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

Just noticed this: apparently, in the past, the generated elements were <strong class="selflink">, then at some point it has been changed to <a class="selflink">.

Dec 8 2017, 2:10 AM · Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, MobileApp, Mobile, Wikipedia-Android-App-Backlog
Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

What I'm suggesting:

  • First, just add my CSS,
  • Then possibly, in a new ticket, transform <a class="selflink"> to <strong class="selflink">, for both desktop and mobile. At the source, not in a post-process layer.
Dec 8 2017, 2:02 AM · Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, MobileApp, Mobile, Wikipedia-Android-App-Backlog
Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

I think returning a modified, different markup on mobile version is quite surprising, and a wide open door for bugs.
As visible on your Gerrit patch, the markup is litteraly hacked (your patch code is clean though, I'm talking about the principle, of this one, and of the other ones that are already stacked...).

Dec 8 2017, 1:57 AM · Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, MobileApp, Mobile, Wikipedia-Android-App-Backlog

Dec 6 2017

Od1n added a comment to T181877: CSS loading sometimes delayed in Firefox; FOUC reproducibly displayed.

It also happens on the mobile version: https://fr.m.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal

Dec 6 2017, 2:02 PM · Upstream, Performance-Team, Browser-Support-Firefox
Od1n added a comment to T181877: CSS loading sometimes delayed in Firefox; FOUC reproducibly displayed.

I can also reproduce it with Firefox 57, even without throttling network speed (VDSL2).

Dec 6 2017, 9:58 AM · Upstream, Performance-Team, Browser-Support-Firefox
Od1n added a comment to T178998: Table collapsing button is too close to the capture - add some CSS spacing.

Yes, it would require manually adding margin-left: 0; and margin-right: 0; to the custom toggles, in addition to the already needed float: none;.
That's why I'd still bend to favor my patch 9, which has a "whitelist" approach.

Dec 6 2017, 9:42 AM · UI-Standardization, Patch-For-Review, Google-Code-in-2017, Wikimedia-Israel-Hackers, MediaWiki-General-or-Unknown, CSS, Easy
Od1n added a comment to T182172: Email Preferences should inform of default values.

(by the way, having the username in URL of preferences pages isn't very smart)

Dec 6 2017, 8:27 AM · Upstream, Phabricator (Upstream)
Od1n created T182172: Email Preferences should inform of default values.
Dec 6 2017, 8:23 AM · Upstream, Phabricator (Upstream)

Dec 5 2017

Od1n added a comment to T178998: Table collapsing button is too close to the capture - add some CSS spacing.

Please have a look at T155347 (and Gerrit patches 9 and 10), also please try your code on https://test.wikipedia.org/wiki/Test_suite_for_mw-collapsible, and especially on https://test.wikipedia.org/wiki/CollapsingTestpageMw (custom toggle).

Dec 5 2017, 3:30 PM · UI-Standardization, Patch-For-Review, Google-Code-in-2017, Wikimedia-Israel-Hackers, MediaWiki-General-or-Unknown, CSS, Easy
Od1n added a comment to T178998: Table collapsing button is too close to the capture - add some CSS spacing.

0.3em is a pretty frequent value on mediawiki, and it fits great here.

Dec 5 2017, 1:42 PM · UI-Standardization, Patch-For-Review, Google-Code-in-2017, Wikimedia-Israel-Hackers, MediaWiki-General-or-Unknown, CSS, Easy
Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

Yes, it's a duplicate. Though it got lucky and got more attention. Its CSS patch is less evolved, but note it has a workaround for the parser issue I mentioned earlier.

Dec 5 2017, 1:40 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript
Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

@Jdlrobson requested more discussion (* I wouldn't have guessed that such an obvious, simple and straightforward issue would require discussion…),

Dec 5 2017, 4:23 AM · Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, MobileApp, Mobile, Wikipedia-Android-App-Backlog

Dec 2 2017

Od1n added a comment to T119827: protectionLevels says that the current title is protected if it does not exist.

I have just tried to reproduce this bug, and I got the expected, correct value: "[]".

Dec 2 2017, 8:45 AM · Wikimedia-maintenance-script-run, Wikimedia-Site-requests, MediaWiki-Page-protection

Nov 30 2017

Od1n added a comment to T181592: Some rules have erroneous priority on diffs with Monobook skin.

Oh, they were local rules… Thank you very much matmarex for noticing this. I have removed these blameworthy rules.

Nov 30 2017, 12:40 AM · Wikimedia-General-or-Unknown

Nov 29 2017

Od1n added a comment to T120733: Improve date range searches on Special:Contributions.

Any feedback about my comment above?

Nov 29 2017, 5:54 AM · MW-1.30-release-notes, Community-Tech, User-notice, MW-1.29-release-notes, MW-1.28-release-notes, Wikimania-Hackathon-2016, Wikimedia-Hackathon-2016, Patch-For-Review, MediaWiki-Special-pages, Community-Wishlist-Survey-2015
Od1n created T181592: Some rules have erroneous priority on diffs with Monobook skin.
Nov 29 2017, 5:23 AM · Wikimedia-General-or-Unknown

Nov 28 2017

Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

Here is a test case: https://en.m.wikipedia.org/w/index.php?title=Draft:Sandbox&oldid=812613209

Nov 28 2017, 9:24 PM · Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, MobileApp, Mobile, Wikipedia-Android-App-Backlog
Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

Note these links already have a caret on hover, as it should be.

Nov 28 2017, 8:24 AM · Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, MobileApp, Mobile, Wikipedia-Android-App-Backlog
Od1n created T181472: "a.mw-selflink" links miss styling.
Nov 28 2017, 8:22 AM · Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, MobileApp, Mobile, Wikipedia-Android-App-Backlog

Nov 20 2017

Od1n added a comment to T168763: Lua's mw.text.nowiki() should escape exclamation point "!" on new line.

As suggested on Gerrit, I added a patch that implements a similar change in core wfEscapeWikiText().

Nov 20 2017, 8:31 PM · Patch-For-Review, MediaWiki-extensions-Scribunto
Od1n added a comment to T168763: Lua's mw.text.nowiki() should escape exclamation point "!" on new line.

New patch, that searches for \n[ \t]*!

Nov 20 2017, 2:00 PM · Patch-For-Review, MediaWiki-extensions-Scribunto
Od1n added a comment to T168763: Lua's mw.text.nowiki() should escape exclamation point "!" on new line.

Mmmm, wait. Table code would also accept such leading spaces/tabs:

Nov 20 2017, 1:27 PM · Patch-For-Review, MediaWiki-extensions-Scribunto

Nov 19 2017

Od1n updated subscribers of T180911: Add a property "talkNsText" to mw.title objects.

@Reedy Indeed. My first patch was:

data.canTalk = ns.talk ~= nil
Nov 19 2017, 4:25 PM · Patch-For-Review, MediaWiki-extensions-Scribunto
Od1n created T180911: Add a property "talkNsText" to mw.title objects.
Nov 19 2017, 3:03 PM · Patch-For-Review, MediaWiki-extensions-Scribunto

Nov 14 2017

Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

The changes should be quite robust as of now. I'd favor patch #9, it works on a specific "whitelist" set so it should be pretty safe, and more importantly, the space added by javascript in patch #10 really tickles me (see my comments above).

Nov 14 2017, 6:35 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript

Nov 12 2017

Od1n added a comment to T169034: Correct mouse pointer over the text input, in DateInputWidget.

Thank you!

Nov 12 2017, 8:43 AM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), CSS, UI-Standardization-Kanban, OOUI, UI-Standardization, JavaScript

Nov 4 2017

Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

Still, for inline toggles in table captions, I would favor a margin over a space:

  • It's an UI widget, so that "natural spacing [of exactly one space]" doesn't really make sense. A bit more spacing wouldn't hurt, actually.
  • It doesn't create a space which would get selected with the rest of the text. (I hate so much these extraneous spaces in text selections!)
Nov 4 2017, 11:56 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript
Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

@Krinkle Please see my the additional notes in my comment above.

Nov 4 2017, 1:12 AM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript

Nov 3 2017

Od1n triaged T155347: There should be a space between span.mw-collapsible-toggle and its preceding content as Normal priority.
Nov 3 2017, 9:14 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript
Od1n added a comment to T179612: mw-collapsible elements should be configurable (e.g. to disable the fading effects).

The issue is mainly about configurability: the code implements objects to manage options, yet the end-user cannot reach these options.

Nov 3 2017, 8:54 PM · MediaWiki-Interface, JavaScript
Od1n renamed T179612: mw-collapsible elements should be configurable (e.g. to disable the fading effects) from mw-collapsible elements should be configurable to mw-collapsible elements should be configurable (e.g. to disable the fading effects).
Nov 3 2017, 8:47 PM · MediaWiki-Interface, JavaScript

Nov 2 2017

Od1n updated the task description for T179612: mw-collapsible elements should be configurable (e.g. to disable the fading effects).
Nov 2 2017, 8:17 PM · MediaWiki-Interface, JavaScript
Od1n created T179612: mw-collapsible elements should be configurable (e.g. to disable the fading effects).
Nov 2 2017, 8:15 PM · MediaWiki-Interface, JavaScript
Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

Patch #7 was changing only the two "Collapsible table with caption" examples, which is fine and the expected behaviour.
Updated (#8) the patch, adding th .mw-collapsible-toggle to fix the "Collapsible table" example as well.

Nov 2 2017, 5:26 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript

Nov 1 2017

Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

Nope, narrowing the addition of the float was wrong.

Nov 1 2017, 7:07 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript
Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

Uploaded a new patch to https://gerrit.wikimedia.org/r/#/c/338045/

Nov 1 2017, 6:51 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript
Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

Changing the selector from .mw-collapsible-toggle to the narrower caption .mw-collapsible-toggle would fix the case pointed out by @Krinkle on Gerrit, and I guess would be robust enough to avoid the false positives.

Nov 1 2017, 6:31 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript

Oct 27 2017

Od1n added a comment to T72157: Provide sensible per-language defaults for tableSorterCollation used by jquery.tablesorter.

Wikis shouldn't have to provide such configuration, and as more these local settings are very incomplete. What we are looking for is not per-language settings, but universal removal of diacritics ("asciification").

Oct 27 2017, 4:16 AM · MediaWiki-jQuery-Tablesorter, JavaScript, MediaWiki-Interface, I18n

Aug 19 2017

Od1n added a comment to T162849: Support WMF communities in run-up to switching EditPage over to OOUI.

The dropdown options are insanely too spaced.
i.e. the vertical padding for .oo-ui-dropdownInputWidget option

Aug 19 2017, 12:19 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, User-Ryasmeen, Editing-team, Community-Liaisons (Jul-Sep 2017), Wikimedia-Site-requests, User-notice, VisualEditor

Jul 26 2017

Od1n added a comment to T162849: Support WMF communities in run-up to switching EditPage over to OOUI.

An override rule such as #wpSummaryLabel .oo-ui-fieldLayout-header { max-width: none; } should be added.

Jul 26 2017, 6:57 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, User-Ryasmeen, Editing-team, Community-Liaisons (Jul-Sep 2017), Wikimedia-Site-requests, User-notice, VisualEditor

Jul 22 2017

Od1n added a comment to T162849: Support WMF communities in run-up to switching EditPage over to OOUI.

What a coincidence, I was just about to report the exact same issue for French Wikipedia.

Jul 22 2017, 4:54 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, User-Ryasmeen, Editing-team, Community-Liaisons (Jul-Sep 2017), Wikimedia-Site-requests, User-notice, VisualEditor

Jul 13 2017

Od1n placed T155347: There should be a space between span.mw-collapsible-toggle and its preceding content up for grabs.
Jul 13 2017, 3:31 AM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript

Jul 5 2017

Od1n added a comment to T162849: Support WMF communities in run-up to switching EditPage over to OOUI.

Just to point out the new summary input sometimes feels really laggy on my gipsy computer.

Jul 5 2017, 10:28 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, User-Ryasmeen, Editing-team, Community-Liaisons (Jul-Sep 2017), Wikimedia-Site-requests, User-notice, VisualEditor

Jun 28 2017

Od1n added a comment to T120733: Improve date range searches on Special:Contributions.

Here it is: T169034

Jun 28 2017, 7:43 AM · MW-1.30-release-notes, Community-Tech, User-notice, MW-1.29-release-notes, MW-1.28-release-notes, Wikimania-Hackathon-2016, Wikimedia-Hackathon-2016, Patch-For-Review, MediaWiki-Special-pages, Community-Wishlist-Survey-2015
Od1n created T169034: Correct mouse pointer over the text input, in DateInputWidget.
Jun 28 2017, 7:41 AM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), CSS, UI-Standardization-Kanban, OOUI, UI-Standardization, JavaScript

Jun 27 2017

Od1n added a comment to T120733: Improve date range searches on Special:Contributions.

Also, the mouse pointer could be improved:

Jun 27 2017, 5:35 AM · MW-1.30-release-notes, Community-Tech, User-notice, MW-1.29-release-notes, MW-1.28-release-notes, Wikimania-Hackathon-2016, Wikimedia-Hackathon-2016, Patch-For-Review, MediaWiki-Special-pages, Community-Wishlist-Survey-2015

Jun 25 2017

Od1n added a comment to T122471: Mobile edit icon does not always point to correct section id.

Just to report I'm encountering the following error on https://fr.wikipedia.org/w/index.php?title=Nils_Nilsson&oldid=138436684&useskin=minerva

Jun 25 2017, 11:53 AM · MW-1.27-release (WMF-deploy-2016-03-08_(1.27.0-wmf.16)), Patch-For-Review, Readers-Web-Backlog, MobileFrontend

Jun 9 2017

Od1n added a comment to T120733: Improve date range searches on Special:Contributions.

I think the <br> between the start and end inputs should be removed. So that the "settings box" would be more compact (not a luxury), more appealing (one less line, feels less cluttered) *and* more ergonomic (one line equals one functionality, whereas breaking this rule as currently is quite disturbing).

Jun 9 2017, 5:01 AM · MW-1.30-release-notes, Community-Tech, User-notice, MW-1.29-release-notes, MW-1.28-release-notes, Wikimania-Hackathon-2016, Wikimedia-Hackathon-2016, Patch-For-Review, MediaWiki-Special-pages, Community-Wishlist-Survey-2015

Jun 5 2017

Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

I'm not sure about how to handle this, see the comments by Krinkle on patch set 4 on the gerrit ticket:

Jun 5 2017, 6:28 AM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript

Feb 16 2017

Od1n added a comment to T152025: Align MediaWiki core UI elements with WikimediaUI color palette.
Feb 16 2017, 11:41 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), MW-1.30-release-notes, User-notice, MW-1.29-release-notes, UI-Standardization
Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

I don't see the issue when I test the provided demo code -

Feb 16 2017, 3:51 AM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript

Feb 8 2017

Od1n added a comment to T157035: "new mw.Uri()" ignores options when using an empty first argument.

Many thanks!

Feb 8 2017, 8:13 PM · Patch-For-Review, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), MediaWiki-General-or-Unknown, JavaScript
Od1n added a comment to T157035: "new mw.Uri()" ignores options when using an empty first argument.

I dropped my Gerrit account after my last irksome experience with it, and don't plan to create a new account.

Feb 8 2017, 2:10 PM · Patch-For-Review, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), MediaWiki-General-or-Unknown, JavaScript

Feb 7 2017

Od1n updated subscribers of T157035: "new mw.Uri()" ignores options when using an empty first argument.

@matmarex, many thanks for your review on Gerrit :)

Feb 7 2017, 6:29 PM · Patch-For-Review, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), MediaWiki-General-or-Unknown, JavaScript
Od1n added a comment to T157035: "new mw.Uri()" ignores options when using an empty first argument.

If the changes are approved, a test should be added in mediawiki.Uri.test.js. But I'm not enough at ease there…

Feb 7 2017, 6:01 PM · Patch-For-Review, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), MediaWiki-General-or-Unknown, JavaScript
Od1n added a comment to T157035: "new mw.Uri()" ignores options when using an empty first argument.

Thanks for pointing me to the Gerrit Patch Uploader. Last time I used Gerrit, it was a real PITA and I don't want to touch it again, ever.

Feb 7 2017, 5:44 PM · Patch-For-Review, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), MediaWiki-General-or-Unknown, JavaScript
Od1n added a comment to T157035: "new mw.Uri()" ignores options when using an empty first argument.

I think the patch should be fine as it is.

Feb 7 2017, 2:19 PM · Patch-For-Review, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), MediaWiki-General-or-Unknown, JavaScript

Feb 4 2017

Od1n added a comment to T157035: "new mw.Uri()" ignores options when using an empty first argument.

Here is the simplest patch I could figure out:

Feb 4 2017, 9:12 PM · Patch-For-Review, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), MediaWiki-General-or-Unknown, JavaScript
Od1n added a comment to T157184: JS function getElementsByClassName() should not be deprecated and overriden.

I'm pretty sure previously I got similarly mistaken.

Feb 4 2017, 7:45 AM · JavaScript
Od1n closed T157184: JS function getElementsByClassName() should not be deprecated and overriden as Invalid.
Feb 4 2017, 7:39 AM · JavaScript
Od1n added a comment to T157184: JS function getElementsByClassName() should not be deprecated and overriden.

Mmmm, that's a very good point. I didn't notice it.

Feb 4 2017, 7:38 AM · JavaScript
Od1n updated the task description for T157184: JS function getElementsByClassName() should not be deprecated and overriden.
Feb 4 2017, 7:28 AM · JavaScript
Od1n triaged T157184: JS function getElementsByClassName() should not be deprecated and overriden as Unbreak Now! priority.
Feb 4 2017, 7:27 AM · JavaScript
Od1n created T157184: JS function getElementsByClassName() should not be deprecated and overriden.
Feb 4 2017, 7:27 AM · JavaScript

Feb 2 2017

Od1n triaged T157035: "new mw.Uri()" ignores options when using an empty first argument as High priority.
Feb 2 2017, 2:55 PM · Patch-For-Review, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), MediaWiki-General-or-Unknown, JavaScript
Od1n created T157035: "new mw.Uri()" ignores options when using an empty first argument.
Feb 2 2017, 2:54 PM · Patch-For-Review, MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-02-14_(1.29.0-wmf.12)), MediaWiki-General-or-Unknown, JavaScript
Fito awarded T155347: There should be a space between span.mw-collapsible-toggle and its preceding content a Like token.
Feb 2 2017, 6:46 AM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript

Jan 16 2017

Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.
  1. About my demo code with table caption: I'm surprised you have a space. I don't have space, using Firefox and Chrome.
  2. About the "narrow tables" on the manual page: you are correct, and that's precisely why I then proposed the "better fix", adding a margin-left CSS.
Jan 16 2017, 9:03 AM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript

Jan 15 2017

Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

Probably a better fix, as it would work on more cases: add a CSS margin-left:0.3em

Jan 15 2017, 2:55 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript
Od1n created T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.
Jan 15 2017, 2:45 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript

Oct 16 2016

Od1n updated the task description for T148313: Put wrapped data in mw.loadData cache.
Oct 16 2016, 3:42 AM · Performance, MediaWiki-extensions-Scribunto
Od1n created T148313: Put wrapped data in mw.loadData cache.
Oct 16 2016, 3:32 AM · Performance, MediaWiki-extensions-Scribunto

Sep 28 2016

Od1n added a comment to T146835: "Good article" star icon in interlanguage links should be less prominent.

Apparently they are defined in ext.wikimediaBadges, see wikimedia-badges.css.

Sep 28 2016, 6:17 PM · Need-volunteer, WMDE-Design, Wikidata, Design