Od1n
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 8 2016, 3:49 PM (102 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Od1n

Recent Activity

Fri, Apr 13

Od1n updated subscribers of T192033: Self links stopped bolding.

At least, the self links shouldn't be blue, using some a:not([href]) CSS as it has been done for Minerva.

Fri, Apr 13, 4:25 AM · Timeless

Thu, Apr 12

Od1n added a comment to T192033: Self links stopped bolding.

By the way, I checked on Timeless, and the self links are blue, as regular links. That is wrong for sure.

Thu, Apr 12, 3:12 AM · Timeless
Od1n added a comment to T192033: Self links stopped bolding.

I mean that the bold removal and the underline on hover are by design ;) But I may be mistaken.

Thu, Apr 12, 3:08 AM · Timeless
Od1n added a comment to T192033: Self links stopped bolding.

I think it is by design.

Thu, Apr 12, 2:51 AM · Timeless
Od1n added a comment to T153393: Deploy PageAssessments to French wikipedia.

@MusikAnimal I figured it out exactly at the same time ;)

Thu, Apr 12, 1:39 AM · Patch-For-Review, Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-PageAssessments
Od1n added a comment to T153393: Deploy PageAssessments to French wikipedia.

@MusikAnimal I've noticed your revert. Actually, there might be something missing in the extension implementation in MediaWiki. Compare the two following sets of Lua debug outputs:

Thu, Apr 12, 1:26 AM · Patch-For-Review, Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-PageAssessments

Wed, Apr 11

Od1n added a comment to T153393: Deploy PageAssessments to French wikipedia.
Wed, Apr 11, 5:17 PM · Patch-For-Review, Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-PageAssessments
Od1n added a comment to T153393: Deploy PageAssessments to French wikipedia.

Yes, please uncomment it, so you can at the very same moment check if it is running fine.

Wed, Apr 11, 5:15 PM · Patch-For-Review, Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-PageAssessments
Od1n added a comment to T153393: Deploy PageAssessments to French wikipedia.

@MusikAnimal I have implemented this extension in the module.

Wed, Apr 11, 9:59 AM · Patch-For-Review, Community-Tech, Wikimedia-Site-requests, MediaWiki-extensions-PageAssessments

Tue, Apr 10

whym awarded T181472: "a.mw-selflink" links miss styling a Love token.
Tue, Apr 10, 2:10 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, Extension-MobileApp, Wikipedia-Android-App-Backlog, Mobile

Mon, Apr 2

Od1n added a comment to T183718: Image border missing in Timeless skin.

I made the patch, but the Gerrit Patch Uploader currently fails to submit it (and there is no error message).

Mon, Apr 2, 9:52 AM · Google-Code-in-2017, CSS, MediaWiki-Interface, Timeless

Fri, Mar 30

Od1n closed T190538: Request to manually add "bot flag" to past edits by bot account as Resolved.

One week already, I got no more messages about this. If there is no one willing to nonetheless fix it, I think this ticket can just be closed.

Fri, Mar 30, 3:25 AM · Wikimedia-Site-requests

Mar 23 2018

Od1n created T190538: Request to manually add "bot flag" to past edits by bot account.
Mar 23 2018, 4:55 PM · Wikimedia-Site-requests

Mar 8 2018

Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

Just to clarify, the patch that has just been merged is not for the issue of this ticket, but for a related issue.

Mar 8 2018, 3:28 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, Extension-MobileApp, Wikipedia-Android-App-Backlog, Mobile

Mar 5 2018

Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

This needs more than the single rule above. I had to add the following to fr.wiki: https://fr.wikipedia.org/w/index.php?title=MediaWiki:Mobile.css&diff=prev&oldid=143649876

Mar 5 2018, 8:24 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, Extension-MobileApp, Wikipedia-Android-App-Backlog, Mobile

Mar 2 2018

Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

Thank you for this addition. But as I stated a bit above, these missing styles are simply an overlook from T160480. There is just no reason not to add them.

Mar 2 2018, 1:16 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, Extension-MobileApp, Wikipedia-Android-App-Backlog, Mobile

Feb 27 2018

Od1n added a comment to T14974: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing.

If template returns #ccc and is used as style="color:{{template}}", {{#balance:inline}} would break the template, as it wraps the output with <span>...</span>.

Feb 27 2018, 9:47 PM · Epic, MediaWiki-Parser

Feb 12 2018

Od1n added a comment to T38742: Elements with blacklisted class get removed only if it's their only class.

For convenience, refs https://phabricator.wikimedia.org/T31157 (relocation of bugzilla 29157).

Feb 12 2018, 3:17 AM · MobileFrontend-stable

Feb 7 2018

Od1n added a comment to T186710: When creating a new task, tags should be middle-clickable to go to their description page.

Phabricator's Contributing Code:

Feb 7 2018, 5:06 PM · Phabricator (Upstream), Upstream
Od1n added a comment to T186710: When creating a new task, tags should be middle-clickable to go to their description page.

Even in this "Browse Projects" modal, there is no link to go to the tag page!

Feb 7 2018, 2:47 PM · Phabricator (Upstream), Upstream
Od1n edited projects for T186702: Request to manually rename a gadget in fr.wiki database, added: Wikimedia-Site-requests; removed Wikimedia-General-or-Unknown.
Feb 7 2018, 2:17 PM · Wikimedia-Site-requests
Od1n created T186710: When creating a new task, tags should be middle-clickable to go to their description page.
Feb 7 2018, 2:11 PM · Phabricator (Upstream), Upstream
Od1n created T186702: Request to manually rename a gadget in fr.wiki database.
Feb 7 2018, 12:14 PM · Wikimedia-Site-requests

Feb 1 2018

Od1n closed T117646: Fix recentchangesbox Gadget on French Wikipedia as Resolved.
Feb 1 2018, 1:25 PM · Community-Tech, Community-Tech-fixes, Easy
Od1n closed T117646: Fix recentchangesbox Gadget on French Wikipedia, a subtask of T110185: Gadgets not working on the French Wikipedia, as Resolved.
Feb 1 2018, 1:25 PM · Gadgets, JavaScript, Wikimedia-General-or-Unknown
Od1n closed T117755: Fix GlobalWatchlist gadget on French Wikipedia as Resolved.
Feb 1 2018, 1:25 PM · Community-Tech, Community-Tech-fixes, Google-Code-In-2015, Easy
Od1n closed T117755: Fix GlobalWatchlist gadget on French Wikipedia, a subtask of T110185: Gadgets not working on the French Wikipedia, as Resolved.
Feb 1 2018, 1:25 PM · Gadgets, JavaScript, Wikimedia-General-or-Unknown
Od1n closed T117756: Fix AdvancedResearch gadget on French Wikipedia as Resolved.
Feb 1 2018, 1:25 PM · Community-Tech, Community-Tech-fixes, Google-Code-In-2015, Easy
Od1n closed T117756: Fix AdvancedResearch gadget on French Wikipedia, a subtask of T110185: Gadgets not working on the French Wikipedia, as Resolved.
Feb 1 2018, 1:25 PM · Gadgets, JavaScript, Wikimedia-General-or-Unknown
Od1n added a comment to T117756: Fix AdvancedResearch gadget on French Wikipedia.

Fixed by this edit, yet I have removed this code just after as it's no longer needed.

Feb 1 2018, 1:04 PM · Community-Tech, Community-Tech-fixes, Google-Code-In-2015, Easy
Od1n added a comment to T117646: Fix recentchangesbox Gadget on French Wikipedia.

Has been fixed in this edit (search setTimeout).

Feb 1 2018, 9:16 AM · Community-Tech, Community-Tech-fixes, Easy
Od1n added a comment to T117755: Fix GlobalWatchlist gadget on French Wikipedia.

Should be working again, see notably this edit.

Feb 1 2018, 9:08 AM · Community-Tech, Community-Tech-fixes, Google-Code-In-2015, Easy

Jan 31 2018

Od1n added a comment to T183718: Image border missing in Timeless skin.

Any news on this?

Jan 31 2018, 11:47 AM · Google-Code-in-2017, CSS, MediaWiki-Interface, Timeless
Od1n added a comment to T183827: Timeless: images (eg smileys) are not middle aligned with text.

For the demo above, note the CSS has been fixed locally.

Jan 31 2018, 11:46 AM · Patch-For-Review, Timeless

Jan 28 2018

Od1n created T185859: On [[Special:ExpandTemplates]], the "Input wikitext:" textarea should be resizable.
Jan 28 2018, 11:05 PM · OOUI (OOUI-0.26.2), Patch-For-Review, CSS, UI-Standardization, MediaWiki-Interface

Jan 21 2018

Od1n added a comment to T168763: Lua's mw.text.nowiki() should escape exclamation point "!" on new line.

How about just escaping all ! characters? It would escape more than necessary, but the code would be much simpler (in particular the PHP one).

Jan 21 2018, 10:05 PM · Patch-For-Review, MediaWiki-extensions-Scribunto

Jan 13 2018

Od1n added a comment to T75556: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571.

So, you don't think there is the same issue with the 2nd do/while of the for loop? I haven't checked it thoroughly, but it just looks very similar, with these n+2 steps. That's why I added the "overflow fix" after the for loop in my demonstration patch, to cover the two do/while's.

Jan 13 2018, 8:42 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team, Wikimedia-log-errors, MediaWiki-ResourceLoader

Jan 10 2018

Od1n added a comment to T75556: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571.

Thank you for your work on this.

Jan 10 2018, 3:05 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team, Wikimedia-log-errors, MediaWiki-ResourceLoader

Dec 30 2017

Od1n awarded T183823: Add 'fromsection' and 'tosection' to action=compare a Party Time token.
Dec 30 2017, 6:47 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Patch-For-Review, MediaWiki-API
Od1n added a comment to T160480: Selflinks should still be <a> tags with CSS styling via a class, not <strong> tags.

I was about to completely agree with Jdlrobson, but actually such links are HTML5's "placeholder links" and seem to be the recommended way…

Dec 30 2017, 10:06 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), User-Ryasmeen, Technical-Debt, MediaWiki-Parser, MediaWiki-General-or-Unknown, Contributors-Team, VisualEditor

Dec 29 2017

Od1n updated the task description for T183783: Missing some "noflip" directives for thumbs in Timeless skin.
Dec 29 2017, 3:36 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Timeless, CSS
Od1n created T183783: Missing some "noflip" directives for thumbs in Timeless skin.
Dec 29 2017, 3:32 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Timeless, CSS
Od1n added a comment to T183611: With "live preview" enabled, "Show changes" should provide visual feedback when there are no changes.

Code references:

Dec 29 2017, 7:11 AM · MediaWiki-History-or-Diffs, JavaScript
Od1n added a comment to T183611: With "live preview" enabled, "Show changes" should provide visual feedback when there are no changes.

There are two different points:

  • Texts "Latest revision" and "Your text" are always missing. They should be added, for consistency with the "non-live preview" mode.
  • When there is no difference (i.e. empty ajax diff content) the text "(No difference)" should be added.
Dec 29 2017, 7:05 AM · MediaWiki-History-or-Diffs, JavaScript
Od1n added a comment to T164106: Deprecate parsing and diff options in ApiQueryRevisionsBase.

Also, documentation needs to be updated: https://www.mediawiki.org/wiki/API:Revisions

Dec 29 2017, 6:54 AM · MW-1.30-release-notes, Technical-Debt, Patch-For-Review, MediaWiki-API
Od1n added a comment to T164106: Deprecate parsing and diff options in ApiQueryRevisionsBase.

The JavaScript of "live preview"[1] gets deprecation warnings and has to be updated.

Dec 29 2017, 6:53 AM · MW-1.30-release-notes, Technical-Debt, Patch-For-Review, MediaWiki-API

Dec 28 2017

Od1n added a comment to T183718: Image border missing in Timeless skin.

Thanks :) @grey-bright variable is #eee. It's a bit too light in my opinion. The next one, @grey, is #ccc, which in turn is a bit too dark. Something between the two would have been optimal.

Dec 28 2017, 8:24 AM · Google-Code-in-2017, CSS, MediaWiki-Interface, Timeless

Dec 27 2017

Od1n added a comment to T183718: Image border missing in Timeless skin.

I just noticed this border's color is varying across the skins…

Dec 27 2017, 7:21 PM · Google-Code-in-2017, CSS, MediaWiki-Interface, Timeless
Od1n updated the task description for T183718: Image border missing in Timeless skin.
Dec 27 2017, 3:13 PM · Google-Code-in-2017, CSS, MediaWiki-Interface, Timeless
Od1n created T183718: Image border missing in Timeless skin.
Dec 27 2017, 12:28 PM · Google-Code-in-2017, CSS, MediaWiki-Interface, Timeless
Od1n added a comment to T14974: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing.

I would suggest "normal" priority. This issue gives template editors many headaches, and often results in template codes much more complex than necessary. Thus, let's not forget this issue even further than now.

Dec 27 2017, 3:26 AM · Epic, MediaWiki-Parser

Dec 26 2017

Od1n added a comment to T14974: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing.

Yes, please do something about this issue, even (for the time being) just adding a magic word to configure behaviour of the template, would be helpful.

Dec 26 2017, 3:19 AM · Epic, MediaWiki-Parser

Dec 23 2017

Od1n removed a project from T183611: With "live preview" enabled, "Show changes" should provide visual feedback when there are no changes: Wikidata.
Dec 23 2017, 10:57 AM · MediaWiki-History-or-Diffs, JavaScript
Od1n created T183611: With "live preview" enabled, "Show changes" should provide visual feedback when there are no changes.
Dec 23 2017, 3:41 AM · MediaWiki-History-or-Diffs, JavaScript
Od1n added a comment to T75556: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571.

Indeed, the error happens only on invalid input. Still, there is a clear possibility of overflow here, fixing it is good to do. You should consider as luck it resulted in just a php notice :)

Dec 23 2017, 2:37 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team, Wikimedia-log-errors, MediaWiki-ResourceLoader

Dec 21 2017

Od1n added a comment to T182074: Ignore whitespaces between wiki table syntax and table content.

Yes, for ensuring consistency (there can be different parsers, across Special:ExpandTemplates, preview mode, etc.)

Dec 21 2017, 11:45 PM · Patch-For-Review, MediaWiki-Parser

Dec 15 2017

Od1n added a comment to T75556: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571.

Possible fix, inserting near line 484:

Dec 15 2017, 6:09 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team, Wikimedia-log-errors, MediaWiki-ResourceLoader
Restricted Application added a project to T75556: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571: Performance-Team.

Test case: JavaScriptMinifier::minify('*/');

Dec 15 2017, 5:45 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team, Wikimedia-log-errors, MediaWiki-ResourceLoader

Dec 12 2017

Od1n added a comment to T46678: allow to change the order of statements.

Thanks, I had a look at the javascript code, and I'm not really a fan of this solution.

Dec 12 2017, 2:26 PM · Wikidata, Verified, MediaWiki-extensions-WikibaseRepository
Od1n added a comment to T181877: Reproducible FOUC on Search and ISBN Lookup (CSS delayed in Firefox) .

Just to mention the mobile version has this issue on all browsers actually, not only Firefox 57. Tried Chrome and Pale Moon. So maybe the mobile version has a related, but different, issue that would need to be investigated.

Dec 12 2017, 2:59 AM · Performance-Team (Radar), Upstream, Browser-Support-Firefox
Restricted Application added a project to T46678: allow to change the order of statements: Wikidata.

Looks like this feature is currently missing. (if I recall correctly, maybe it has been removed at some time)

Dec 12 2017, 2:53 AM · Wikidata, Verified, MediaWiki-extensions-WikibaseRepository

Dec 10 2017

Od1n added a comment to T181877: Reproducible FOUC on Search and ISBN Lookup (CSS delayed in Firefox) .

TBH, the fault is in Firefox 57, and the same issue happens on a shitload of websites. So I don't think there is any fix or workaround to consider for MediaWiki, the issue has to be fixed in Firefox.

Dec 10 2017, 1:08 AM · Performance-Team (Radar), Upstream, Browser-Support-Firefox

Dec 8 2017

Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

Here it is: T160480 (gerrit). Also, along this patch the mobile styles were probably forgotten, their omission wasn't on purpose.

Dec 8 2017, 3:15 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, Extension-MobileApp, Wikipedia-Android-App-Backlog, Mobile
Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

Just noticed this: apparently, in the past, the generated elements were <strong class="selflink">, then at some point it has been changed to <a class="selflink">.

Dec 8 2017, 2:10 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, Extension-MobileApp, Wikipedia-Android-App-Backlog, Mobile
Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

What I'm suggesting:

  • First, just add my CSS,
  • Then possibly, in a new ticket, transform <a class="selflink"> to <strong class="selflink">, for both desktop and mobile. At the source, not in a post-process layer.
Dec 8 2017, 2:02 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, Extension-MobileApp, Wikipedia-Android-App-Backlog, Mobile
Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

I think returning a modified, different markup on mobile version is quite surprising, and a wide open door for bugs.
As visible on your Gerrit patch, the markup is litteraly hacked (your patch code is clean though, I'm talking about the principle, of this one, and of the other ones that are already stacked...).

Dec 8 2017, 1:57 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, Extension-MobileApp, Wikipedia-Android-App-Backlog, Mobile

Dec 6 2017

Od1n added a comment to T181877: Reproducible FOUC on Search and ISBN Lookup (CSS delayed in Firefox) .

It also happens on the mobile version: https://fr.m.wikipedia.org/wiki/Wikip%C3%A9dia:Accueil_principal

Dec 6 2017, 2:02 PM · Performance-Team (Radar), Upstream, Browser-Support-Firefox
Od1n added a comment to T181877: Reproducible FOUC on Search and ISBN Lookup (CSS delayed in Firefox) .

I can also reproduce it with Firefox 57, even without throttling network speed (VDSL2).

Dec 6 2017, 9:58 AM · Performance-Team (Radar), Upstream, Browser-Support-Firefox
Od1n added a comment to T178998: Table collapsing button is too close to the caption - add some CSS spacing.

Yes, it would require manually adding margin-left: 0; and margin-right: 0; to the custom toggles, in addition to the already needed float: none;.
That's why I'd still bend to favor my patch 9, which has a "whitelist" approach.

Dec 6 2017, 9:42 AM · UI-Standardization, Patch-For-Review, Google-Code-in-2017, Wikimedia-Israel-Hackers, MediaWiki-General-or-Unknown, CSS, Easy
Od1n added a comment to T182172: Email Preferences should inform of default values.

(by the way, having the username in URL of preferences pages isn't very smart)

Dec 6 2017, 8:27 AM · Upstream, Phabricator (Upstream)
Od1n created T182172: Email Preferences should inform of default values.
Dec 6 2017, 8:23 AM · Upstream, Phabricator (Upstream)

Dec 5 2017

Od1n added a comment to T178998: Table collapsing button is too close to the caption - add some CSS spacing.

Please have a look at T155347 (and Gerrit patches 9 and 10), also please try your code on https://test.wikipedia.org/wiki/Test_suite_for_mw-collapsible, and especially on https://test.wikipedia.org/wiki/CollapsingTestpageMw (custom toggle).

Dec 5 2017, 3:30 PM · UI-Standardization, Patch-For-Review, Google-Code-in-2017, Wikimedia-Israel-Hackers, MediaWiki-General-or-Unknown, CSS, Easy
Od1n added a comment to T178998: Table collapsing button is too close to the caption - add some CSS spacing.

0.3em is a pretty frequent value on mediawiki, and it fits great here.

Dec 5 2017, 1:42 PM · UI-Standardization, Patch-For-Review, Google-Code-in-2017, Wikimedia-Israel-Hackers, MediaWiki-General-or-Unknown, CSS, Easy
Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

Yes, it's a duplicate. Though it got lucky and got more attention. Its CSS patch is less evolved, but note it has a workaround for the parser issue I mentioned earlier.

Dec 5 2017, 1:40 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript
Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

@Jdlrobson requested more discussion (* I wouldn't have guessed that such an obvious, simple and straightforward issue would require discussion…),

Dec 5 2017, 4:23 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, Extension-MobileApp, Wikipedia-Android-App-Backlog, Mobile

Dec 2 2017

Od1n added a comment to T119827: protectionLevels says that the current title is protected if it does not exist.

I have just tried to reproduce this bug, and I got the expected, correct value: "[]".

Dec 2 2017, 8:45 AM · Wikimedia-maintenance-script-run, Wikimedia-Site-requests, MediaWiki-Page-protection

Nov 30 2017

Od1n added a comment to T181592: Some rules have erroneous priority on diffs with Monobook skin.

Oh, they were local rules… Thank you very much matmarex for noticing this. I have removed these blameworthy rules.

Nov 30 2017, 12:40 AM · Wikimedia-General-or-Unknown

Nov 29 2017

Od1n added a comment to T120733: Improve date range searches on Special:Contributions.

Any feedback about my comment above?

Nov 29 2017, 5:54 AM · MW-1.30-release-notes, Community-Tech, User-notice, MW-1.29-release-notes, MW-1.28-release-notes, Wikimania-Hackathon-2016, Wikimedia-Hackathon-2016, Patch-For-Review, MediaWiki-Special-pages, Community-Wishlist-Survey-2015
Od1n created T181592: Some rules have erroneous priority on diffs with Monobook skin.
Nov 29 2017, 5:23 AM · Wikimedia-General-or-Unknown

Nov 28 2017

Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

Here is a test case: https://en.m.wikipedia.org/w/index.php?title=Draft:Sandbox&oldid=812613209

Nov 28 2017, 9:24 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, Extension-MobileApp, Wikipedia-Android-App-Backlog, Mobile
Od1n added a comment to T181472: "a.mw-selflink" links miss styling.

Note these links already have a caret on hover, as it should be.

Nov 28 2017, 8:24 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, Extension-MobileApp, Wikipedia-Android-App-Backlog, Mobile
Od1n created T181472: "a.mw-selflink" links miss styling.
Nov 28 2017, 8:22 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), User-Jdlrobson, Patch-For-Review, Readers-Web-Backlog (Tracking), MinervaNeue, CSS, Extension-MobileApp, Wikipedia-Android-App-Backlog, Mobile

Nov 20 2017

Od1n added a comment to T168763: Lua's mw.text.nowiki() should escape exclamation point "!" on new line.

As suggested on Gerrit, I added a patch that implements a similar change in core wfEscapeWikiText().

Nov 20 2017, 8:31 PM · Patch-For-Review, MediaWiki-extensions-Scribunto
Od1n added a comment to T168763: Lua's mw.text.nowiki() should escape exclamation point "!" on new line.

New patch, that searches for \n[ \t]*!

Nov 20 2017, 2:00 PM · Patch-For-Review, MediaWiki-extensions-Scribunto
Od1n added a comment to T168763: Lua's mw.text.nowiki() should escape exclamation point "!" on new line.

Mmmm, wait. Table code would also accept such leading spaces/tabs:

Nov 20 2017, 1:27 PM · Patch-For-Review, MediaWiki-extensions-Scribunto

Nov 19 2017

Od1n updated subscribers of T180911: Add a property "talkNsText" to mw.title objects.

@Reedy Indeed. My first patch was:

data.canTalk = ns.talk ~= nil
Nov 19 2017, 4:25 PM · Patch-For-Review, MediaWiki-extensions-Scribunto
Od1n created T180911: Add a property "talkNsText" to mw.title objects.
Nov 19 2017, 3:03 PM · Patch-For-Review, MediaWiki-extensions-Scribunto

Nov 14 2017

Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

The changes should be quite robust as of now. I'd favor patch #9, it works on a specific "whitelist" set so it should be pretty safe, and more importantly, the space added by javascript in patch #10 really tickles me (see my comments above).

Nov 14 2017, 6:35 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript

Nov 12 2017

Od1n added a comment to T169034: Correct mouse pointer over the text input, in DateInputWidget.

Thank you!

Nov 12 2017, 8:43 AM · MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), CSS, UI-Standardization-Kanban, OOUI, UI-Standardization, JavaScript

Nov 4 2017

Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

Still, for inline toggles in table captions, I would favor a margin over a space:

  • It's an UI widget, so that "natural spacing [of exactly one space]" doesn't really make sense. A bit more spacing wouldn't hurt, actually.
  • It doesn't create a space which would get selected with the rest of the text. (I hate so much these extraneous spaces in text selections!)
Nov 4 2017, 11:56 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript
Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

@Krinkle Please see my the additional notes in my comment above.

Nov 4 2017, 1:12 AM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript

Nov 3 2017

Od1n triaged T155347: There should be a space between span.mw-collapsible-toggle and its preceding content as Normal priority.
Nov 3 2017, 9:14 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript
Od1n added a comment to T179612: mw-collapsible elements should be configurable (e.g. to disable the fading effects).

The issue is mainly about configurability: the code implements objects to manage options, yet the end-user cannot reach these options.

Nov 3 2017, 8:54 PM · MediaWiki-Interface, JavaScript
Od1n renamed T179612: mw-collapsible elements should be configurable (e.g. to disable the fading effects) from mw-collapsible elements should be configurable to mw-collapsible elements should be configurable (e.g. to disable the fading effects).
Nov 3 2017, 8:47 PM · MediaWiki-Interface, JavaScript

Nov 2 2017

Od1n updated the task description for T179612: mw-collapsible elements should be configurable (e.g. to disable the fading effects).
Nov 2 2017, 8:17 PM · MediaWiki-Interface, JavaScript
Od1n created T179612: mw-collapsible elements should be configurable (e.g. to disable the fading effects).
Nov 2 2017, 8:15 PM · MediaWiki-Interface, JavaScript
Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

Patch #7 was changing only the two "Collapsible table with caption" examples, which is fine and the expected behaviour.
Updated (#8) the patch, adding th .mw-collapsible-toggle to fix the "Collapsible table" example as well.

Nov 2 2017, 5:26 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript

Nov 1 2017

Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

Nope, narrowing the addition of the float was wrong.

Nov 1 2017, 7:07 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript
Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

Uploaded a new patch to https://gerrit.wikimedia.org/r/#/c/338045/

Nov 1 2017, 6:51 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript
Od1n added a comment to T155347: There should be a space between span.mw-collapsible-toggle and its preceding content.

Changing the selector from .mw-collapsible-toggle to the narrower caption .mw-collapsible-toggle would fix the case pointed out by @Krinkle on Gerrit, and I guess would be robust enough to avoid the false positives.

Nov 1 2017, 6:31 PM · Patch-For-Review, MediaWiki-General-or-Unknown, CSS, JavaScript