Page MenuHomePhabricator

Od1n
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
May 8 2016, 3:49 PM (319 w, 5 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Od1n [ Global Accounts ]

Recent Activity

Sat, Jun 18

Od1n updated the task description for T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js.
Sat, Jun 18, 5:11 AM · Performance-Team, MediaWiki-ResourceLoader, Vector, Patch-For-Review, JavaScript

Wed, Jun 15

Od1n added a comment to T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js.

@Krinkle May I kindly ask if you have news about this?

Wed, Jun 15, 11:05 PM · Performance-Team, MediaWiki-ResourceLoader, Vector, Patch-For-Review, JavaScript

Thu, May 26

Od1n added a comment to T306281: Boxes in French Wikipedia Skew Section Headers.

You can test the mobile version on a desktop computer simply by using the fr.m.wikipedia.org domain. Although not on a smartphone, it's sufficient when writing local CSS etc.

Thu, May 26, 11:19 PM · Product-Infrastructure-Team-Backlog (Kanban), Wikipedia-Android-App-Backlog

May 17 2022

Od1n added a comment to T308504: Redirects should be italicised on Special:MostTranscludedPages (and maybe other pages as well).

Uploaded a new patch:

May 17 2022, 12:42 AM · Patch-For-Review, CSS, MediaWiki-Interface
Od1n added a comment to T308504: Redirects should be italicised on Special:MostTranscludedPages (and maybe other pages as well).

Here is the CSS I'm adding in the patch:

.mw-special-Mostlinkedtemplates .mw-redirect {
    font-style: italic;
}

A few notes:

May 17 2022, 12:26 AM · Patch-For-Review, CSS, MediaWiki-Interface
Od1n created T308504: Redirects should be italicised on Special:MostTranscludedPages (and maybe other pages as well).
May 17 2022, 12:14 AM · Patch-For-Review, CSS, MediaWiki-Interface

May 2 2022

Od1n created T307361: Input text should be kept when switching to another project.
May 2 2022, 2:08 PM · VPS-project-Codesearch

May 1 2022

Od1n added a comment to T188737: In the list of "templates used on this page" when editing, highlight redirect templates by italicising them (like we do elsewhere)..

Redirects should be italicised on this special page as well: Special:MostTranscludedPages.

May 1 2022, 2:13 PM · MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), Patch-For-Review, good first task, MediaWiki-Interface

Apr 7 2022

Od1n added a comment to T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js.

It is registered as a different module

Understood. It loads vector.js (from the legacy skin) in addition to the rest.

Apr 7 2022, 3:57 PM · Performance-Team, MediaWiki-ResourceLoader, Vector, Patch-For-Review, JavaScript
Od1n added a comment to T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js.

Thanks @Func for looking into this.

Apr 7 2022, 6:42 AM · Performance-Team, MediaWiki-ResourceLoader, Vector, Patch-For-Review, JavaScript

Apr 6 2022

Od1n created T305594: Vector 2022 skin should not load user's vector.js before site's MediaWiki:Common.js.
Apr 6 2022, 10:03 PM · Performance-Team, MediaWiki-ResourceLoader, Vector, Patch-For-Review, JavaScript
Od1n added a comment to T302627: Skin continously switch to Vector 2022 despite (global) preferences.

Indeed, I was also encountering this issue on mediawiki.org. I don't remember on what pages exactly, but I'm pretty sure it was occurring on ResourceLoader/Core modules.

Apr 6 2022, 12:29 AM · MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), MW-1.38-release, Community-Tech, MediaWiki-extensions-GlobalPreferences, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector

Apr 5 2022

Od1n added a comment to T302627: Skin continously switch to Vector 2022 despite (global) preferences.

Also, I usually fix this issue by doing a force refresh (shift + F5). A regular refresh (F5) isn't sufficient.

Apr 5 2022, 5:30 PM · MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), MW-1.38-release, Community-Tech, MediaWiki-extensions-GlobalPreferences, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector
Od1n added a comment to T302627: Skin continously switch to Vector 2022 despite (global) preferences.

I am also encountering this issue. Nowadays it seems less frequent, but it may still happen sometimes. (edit: a fix has just been deployed, it simply hasn't reached frwiki yet)

Apr 5 2022, 5:23 PM · MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), MW-1.38-release, Community-Tech, MediaWiki-extensions-GlobalPreferences, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector

Apr 3 2022

Od1n updated the task description for T305315: Empty elements should be removed when producing the extract.
Apr 3 2022, 3:29 AM · Product-Infrastructure-Team-Backlog, Reading Epics (Page Previews), Page Content Service, Page-Previews, Navigation-Popups-Gadget, TextExtracts
Od1n created T305315: Empty elements should be removed when producing the extract.
Apr 3 2022, 2:02 AM · Product-Infrastructure-Team-Backlog, Reading Epics (Page Previews), Page Content Service, Page-Previews, Navigation-Popups-Gadget, TextExtracts

Apr 1 2022

Od1n added a comment to T297019: Editors should be able to blank the main page title without MediaWiki:Vector.css changes for Vector.

I just noticed the .mw-first-heading is missing here:
https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/475508647466ea1c67d3e0d378ca3b4a76668e84/stories/skin.stories.data.js#91

Apr 1 2022, 3:37 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), MediaWiki-Core-Skin-Architecture
Od1n added a comment to T265892: MediaWiki:Pagetitle-view-mainpage does not behave the same in MinervaNeue skin as it does in other skin.

Following up to gerrit 737112 from late 2021 which has these FIXME:

Apr 1 2022, 3:20 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), Readers-Web-Backlog (Kanbanana-FY-2021-22), Patch-For-Review, MinervaNeue
Od1n added a comment to T297019: Editors should be able to blank the main page title without MediaWiki:Vector.css changes for Vector.

Currently all skins have #firstHeading, .firstHeading and .mw-first-heading, the only exception being cologneblue which only has #firstHeading.

Apr 1 2022, 4:15 AM · Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), MediaWiki-Core-Skin-Architecture
Od1n added a comment to T297019: Editors should be able to blank the main page title without MediaWiki:Vector.css changes for Vector.
  1. Back in 2009, class .firstHeading had been replaced with an ID #firstHeading, see T17427 and https://phabricator.wikimedia.org/rMWc68f345d54c3
  2. Very soon after, the class .firstHeading has been restored, alongside the ID, for backward compatibility, see https://phabricator.wikimedia.org/rMWba0f7c4c1378
  3. In 2014, the ID has been considered obsolete, see https://phabricator.wikimedia.org/rMW7d244175a3bd359bd and also this documentation update.
  4. The present ticket introduced a new class .mw-first-heading for name standardization.
Apr 1 2022, 4:09 AM · Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), MediaWiki-Core-Skin-Architecture

Mar 30 2022

Od1n updated subscribers of T250393: Use monospace font (or editfont preference) for diffs.

Currently the font has a pixel-based size (gerrit 593629).

Mar 30 2022, 3:49 PM · Editing-team, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), User-notice, MediaWiki-Page-diffs

Mar 22 2022

Od1n added a comment to T304406: Loading styles from module "mediawiki.pager.styles" shouldn't have side-effect on display of Watchlist page.

Here is an extract of the markup in History and User contributions pages:

Mar 22 2022, 12:54 PM · MW-1.39-notes (1.39.0-wmf.4; 2022-03-23), MediaWiki-Interface, MediaWiki-Watchlist, Growth-Team, CSS
Od1n edited projects for T304406: Loading styles from module "mediawiki.pager.styles" shouldn't have side-effect on display of Watchlist page, added: MediaWiki-Interface; removed MediaWiki-Interface (Tables).
Mar 22 2022, 9:40 AM · MW-1.39-notes (1.39.0-wmf.4; 2022-03-23), MediaWiki-Interface, MediaWiki-Watchlist, Growth-Team, CSS
Od1n created T304406: Loading styles from module "mediawiki.pager.styles" shouldn't have side-effect on display of Watchlist page.
Mar 22 2022, 9:39 AM · MW-1.39-notes (1.39.0-wmf.4; 2022-03-23), MediaWiki-Interface, MediaWiki-Watchlist, Growth-Team, CSS

Mar 7 2022

Od1n added a comment to T302084: [Regression] Watchlist link appears twice in UI.

Has been fixed on Gerrit (relevant occurrences of class replaced with link-class).

Mar 7 2022, 1:26 AM · MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), Regression, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector

Mar 4 2022

Od1n added a comment to T302084: [Regression] Watchlist link appears twice in UI.

Tests currently fail because user-links-collapsible-item is added to the <li>, and mw-ui-icon mw-ui-icon-before are added to the inner <a>,
but the tests look at the same place for both sets of classes: $content['user-menu']['userpage']['class'].

Mar 4 2022, 1:01 AM · MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), Regression, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector

Feb 26 2022

Od1n added a comment to T302084: [Regression] Watchlist link appears twice in UI.

Some people may prefer to keep this additional item in the dropdown menu:

  • Has a text description.
  • The "Contributions" link is next to it.
Feb 26 2022, 7:21 AM · MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), Regression, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector
Od1n added a comment to T289619: Move Watchlist button outside user menu dropdown.

I hadn't understand AC4 is only about the HTML markup, not at all about the displayed element.

Feb 26 2022, 7:04 AM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), User-notice, MinervaNeue, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), RW-Feature-DI-User-Menu, Desktop Improvements

Feb 18 2022

Od1n added a comment to T289619: Move Watchlist button outside user menu dropdown.

About the (conflicting) AC2 and AC4, currently the entry is always present in the dropdown menu, including on large windows when there is also the direct icon.

Feb 18 2022, 1:37 PM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), User-notice, MinervaNeue, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), RW-Feature-DI-User-Menu, Desktop Improvements
Od1n added a comment to T289619: Move Watchlist button outside user menu dropdown.

I saw this in production on fawiki, so I deleted the Gadget I had created which would bring the Watchlist icon back out of the user dropdown menu. Unsure if other wikis had copied my Gadget too; if yes, they should delete as well.

Feb 18 2022, 1:33 PM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), User-notice, MinervaNeue, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), RW-Feature-DI-User-Menu, Desktop Improvements
Od1n added a comment to T291426: Gadget-injected menu items should not be cloned to sticky header user menu.

@Jdlrobson The below code (found here) seems to be incorrect:

Feb 18 2022, 12:52 PM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Readers-Web-Backlog (Kanbanana-FY-2021-22)

Feb 16 2022

Od1n added a comment to T42284: The CSS of each gadget is included two times.
Feb 16 2022, 5:22 PM · MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), MW-1.29-release (WMF-deploy-2017-02-21_(1.29.0-wmf.13)), Patch-For-Review, User-notice, MediaWiki-extensions-Gadgets
Od1n added a comment to T286612: Badges are not compatible with new Vector due to assumption around margin.

Is the above workaround still needed?

Feb 16 2022, 5:20 PM · Wikidata-Campsite (Team A Hearth 🏰🔥), Wikidata, MediaWiki-extensions-WikimediaBadges

Feb 7 2022

Od1n added a comment to T42284: The CSS of each gadget is included two times.

Now that by default, and automatically, all gadgets get type "general", except CSS-only (and without dependencies) gadgets which get type "styles",

Feb 7 2022, 8:58 AM · MW-1.30-release-notes (WMF-deploy-2017-06-06_(1.30.0-wmf.4)), MW-1.29-release (WMF-deploy-2017-02-21_(1.29.0-wmf.13)), Patch-For-Review, User-notice, MediaWiki-extensions-Gadgets

Jan 21 2022

Od1n added a comment to T299653: Text in new language switcher position notice is justified on frwiki (due to local MediaWiki:Common.css).

Refs the local fix: 190070230, which I followed with 190082211.

Jan 21 2022, 3:35 AM · Desktop Improvements

Jan 17 2022

Od1n added a comment to T299117: Implement message Mainpage-title and Mainpage-title-loggedin in skins Modern and Cologneblue.

The message has been implemented in Modern: https://github.com/wikimedia/mediawiki-skins-Modern/commit/35c9337d207714c75716bfb5f1b6ca11c4d2f5fb.

Jan 17 2022, 4:48 PM · patch-welcome, CologneBlue

Jan 13 2022

Od1n created T299117: Implement message Mainpage-title and Mainpage-title-loggedin in skins Modern and Cologneblue.
Jan 13 2022, 6:00 AM · patch-welcome, CologneBlue

Jan 11 2022

Od1n added a comment to T298715: Interface editors: Can change the heading on the main page.

Just to be clear, I tested and gave as examples the Monobook and Modern skins, but it was out of habit:

Jan 11 2022, 2:40 AM · MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), User-notice

Jan 10 2022

Od1n added a comment to T298715: Interface editors: Can change the heading on the main page.

For the heading to be effectively hidden (or replaced with a customized text), the message has to be implemented in the skin. It is currently the case for example with Vector, but still not with Monobook or Modern.

Jan 10 2022, 5:52 AM · MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), User-notice

Nov 11 2021

Od1n added a comment to T289226: Convert EasyTimeline extension to use Shellbox.

Refs T216318, where I had submitted a patch (see changeset 6) to implement width and height attributes, with a sidecar file for faster subsequent retrievals of their values.

Nov 11 2021, 10:07 PM · Patch-For-Review, EasyTimeline, Shellbox, MW-on-K8s
Od1n added a comment to T216318: EasyTimeline outputs an image with no width and height dimensions which is incompatible with MobileFrontend lazy loading.

Merge conflict with this large change. I'm not planning to rebase my patch…

Nov 11 2021, 9:57 PM · Patch-For-Review, Mobile, EasyTimeline
Od1n added a comment to T282220: EasyTimeline does not delete its temporary files.

Wow, that's quite tricky this need to keep references to manipulate when the autocollect is triggered.

Nov 11 2021, 9:54 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), EasyTimeline

Oct 18 2021

Od1n created T293590: Add a parameter "blprop" to API:Backlinks.
Oct 18 2021, 2:35 AM · MediaWiki-Action-API

Sep 20 2021

Od1n added a comment to T216318: EasyTimeline outputs an image with no width and height dimensions which is incompatible with MobileFrontend lazy loading.

Uploaded a new patch (see changeset 6), which avoids errors if ever PHP failed to determine the dimensions of the PNG, or if the desired data couldn't be read in the JSON retrieved from backend.

Sep 20 2021, 5:51 AM · Patch-For-Review, Mobile, EasyTimeline

Sep 18 2021

Od1n added a comment to T216318: EasyTimeline outputs an image with no width and height dimensions which is incompatible with MobileFrontend lazy loading.

I have seen your comment on Gerrit. Indeed, it was a shame to fetch the PNG every time from backend to get its dimensions. As I stated above, I previously made an attempt at implementing a sidecar metadata file, but it got too much complicated, mainly because of the diversity of code flows. Though, I just did another attempt with fresh mind (and meanwhile discovered the "create" backend operation instead of "store", which helped to keep the code simple)…

Sep 18 2021, 3:47 AM · Patch-For-Review, Mobile, EasyTimeline

Aug 24 2021

Od1n added a comment to T200206: Omit `<link rel="mw-deduplicated-inline-style">` from page view HTML.

I suppose you mean conditionally loading the templatestyles from Lua, using frame:extensionTag as described here: How can Lua modules interact with styles?

Aug 24 2021, 8:31 AM · Parsoid, Performance-Team (Radar), MediaWiki-Parser, TemplateStyles

Jul 25 2021

Od1n added a comment to T150742: Modern and Cologneblue is missing styling for mw-empty-elt.

Similarly, I just noticed these mw-empty-elt elements aren't hidden in the "printable version" too (example).

Jul 25 2021, 2:34 PM · MW-1.36-release, MediaWiki-Core-Skin-Architecture, CologneBlue (Tracking), Modern (Tracking)

Jun 5 2021

Od1n updated the task description for T37247: content-holding <div> should only contain the page text.
Jun 5 2021, 2:19 AM · User-notice, User-Ryasmeen, MW-1.30-release-notes, Patch-For-Review, Parsoid, TemplateStyles, VisualEditor, StructuredDiscussions, Collaboration-Team-Triage, MediaWiki-Interface
Od1n updated the task description for T37247: content-holding <div> should only contain the page text.
Jun 5 2021, 2:18 AM · User-notice, User-Ryasmeen, MW-1.30-release-notes, Patch-For-Review, Parsoid, TemplateStyles, VisualEditor, StructuredDiscussions, Collaboration-Team-Triage, MediaWiki-Interface

May 14 2021

Od1n added a comment to T216318: EasyTimeline outputs an image with no width and height dimensions which is incompatible with MobileFrontend lazy loading.

I understand this code better now (didn't notice there are 2 ways of generating the PNG: default using ploticus only, and "svg2png").

May 14 2021, 9:44 AM · Patch-For-Review, Mobile, EasyTimeline

May 13 2021

Od1n added a comment to T216318: EasyTimeline outputs an image with no width and height dimensions which is incompatible with MobileFrontend lazy loading.

Rather than reading the entire PNG to get its dimensions, maybe we could store them in a sidecar file? (something like {$pathPrefix}.dimensions)

May 13 2021, 11:59 PM · Patch-For-Review, Mobile, EasyTimeline
Od1n added a comment to T216318: EasyTimeline outputs an image with no width and height dimensions which is incompatible with MobileFrontend lazy loading.

After numerous tries, it was a permission issue indeed.
Uploaded to a separate changeset, so you can at least see my patch: 690771.

May 13 2021, 11:33 PM · Patch-For-Review, Mobile, EasyTimeline
Od1n added a comment to T216318: EasyTimeline outputs an image with no width and height dimensions which is incompatible with MobileFrontend lazy loading.

Using the Gerrit Patch Uploader, even after proper rebasing of my patch, I'm encountering this error:

May 13 2021, 10:39 PM · Patch-For-Review, Mobile, EasyTimeline

May 12 2021

Od1n added a comment to T216318: EasyTimeline outputs an image with no width and height dimensions which is incompatible with MobileFrontend lazy loading.

Rather than the getimagesize( $url ) in above patch, a better code could be:

May 12 2021, 12:59 PM · Patch-For-Review, Mobile, EasyTimeline

Feb 18 2021

Od1n added a comment to T271572: Uncaught Error: Syntax error, unrecognized expression: #/search in at onHashChange.
  • Without anchor, location.hash is an empty string; with "#" anchor, location.hash is still an empty string; then with "#x" anchor, location.hash becomes #x. Therefore, location.hash is never #.
  • jQuery constructor can work without argument, or null, undefined, empty string, empty array… all these return an empty collection. (reference)
Feb 18 2021, 3:15 AM · JavaScript, MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Editing-team, Wikimedia-production-error, SyntaxHighlight

Feb 15 2021

Od1n added a comment to T213426: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle.

So, with https://gerrit.wikimedia.org/r/664228 the simple EventSingletonManager utility gets a dependency on the heavy and unrelated OOUI…

Feb 15 2021, 1:22 PM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), Fundraising-Backlog, wdwb-tech, Growth-Team-Filtering, Patch-For-Review, Growth-Team, Metrolook, WikiEditor, Wikidata, MediaViewer, MassMessage, StructuredDiscussions, MediaWiki-extensions-CentralNotice, Technical-Debt (Deprecation process), JavaScript, MediaWiki-General

Feb 12 2021

Od1n added a comment to T126137: FOUC for styles applied via MediaWiki:Mobile.css due to bottom-loading.

Agree with Krinkle.

Feb 12 2021, 5:41 AM · Readers-Web-Backlog, MobileFrontend

Feb 11 2021

Od1n added a comment to T255007: Unwanted non-breaking space added before a ':' in TemplateStyles rules.

No problem at all!
And the fix seems to be significantly more complex than I thought, so thank you for your work on it!

Feb 11 2021, 5:16 AM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Patch-For-Review, MediaWiki-Parser, TemplateStyles, Parsoid

Feb 9 2021

Od1n added a comment to T271572: Uncaught Error: Syntax error, unrecognized expression: #/search in at onHashChange.

Firefox shows this warning:

Feb 9 2021, 4:33 AM · JavaScript, MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Editing-team, Wikimedia-production-error, SyntaxHighlight

Jan 23 2021

Od1n added a comment to T271956: De-emphasise line numbers when showing code.

Thanks, though I think it's still a bit too emphasized. How about the Base50 #a2a9b1, or at very least Base40 #8a9097?

Jan 23 2021, 7:43 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), SyntaxHighlight, CodeEditor

Jan 20 2021

Od1n updated the task description for T265665: MovePage::moveToInternal() should use Title::getArticleId() not Title::exists().
Jan 20 2021, 12:35 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MediaWiki-Page-rename, MediaWiki-Core-Hooks

Jan 13 2021

Od1n awarded T271956: De-emphasise line numbers when showing code a Like token.
Jan 13 2021, 5:48 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), SyntaxHighlight, CodeEditor

Jan 12 2021

Od1n added a comment to T32773: Enable line numbers for pages handled by SyntaxHighlight.

Useful addition, though, may I suggest making these numbers lighter? They add a lot of visual distraction, yet they are needed only in a few situations.

Jan 12 2021, 6:29 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), SyntaxHighlight

Dec 17 2020

Od1n added a comment to T255007: Unwanted non-breaking space added before a ':' in TemplateStyles rules.

Despite the above patch, the problem is still present on frwiki…

Dec 17 2020, 4:06 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Patch-For-Review, MediaWiki-Parser, TemplateStyles, Parsoid

Nov 12 2020

Od1n added a comment to T267623: "lang" parameter should be recognized in image tags for all formats, even for non-multilingual formats.

Refs discussion on French Wikipedia

Nov 12 2020, 5:42 AM · MediaWiki-Parser

Nov 10 2020

Od1n updated the task description for T267623: "lang" parameter should be recognized in image tags for all formats, even for non-multilingual formats.
Nov 10 2020, 3:27 AM · MediaWiki-Parser
Od1n updated the task description for T267623: "lang" parameter should be recognized in image tags for all formats, even for non-multilingual formats.
Nov 10 2020, 2:54 AM · MediaWiki-Parser
Od1n created T267623: "lang" parameter should be recognized in image tags for all formats, even for non-multilingual formats.
Nov 10 2020, 2:53 AM · MediaWiki-Parser

Oct 22 2020

Od1n added a comment to T254227: Switch test wikis to new version of vector by default.

Hi, using the "Download as PDF" feature on French Wikipedia, I noticed that the sidebar is included in the generated PDF, contrarily to a PDF generated on e.g. English Wikipedia.

Oct 22 2020, 1:00 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements

Oct 20 2020

Od1n added a comment to T120733: Improve date range searches on Special:Contributions.

Following up to my above comment, there is no longer a linebreak between the "From date" and "To date" inputs since the form has been converted to OOUI, refs T117736 :)

Oct 20 2020, 2:42 AM · MW-1.30-release-notes, Community-Tech, User-notice, MW-1.29-release-notes, MW-1.28-release-notes, Wikimania-Hackathon-2016, Wikimedia-Hackathon-2016, Patch-For-Review, MediaWiki-Special-pages, Community-Wishlist-Survey-2015
Od1n added a comment to T249259: Watchlist Expiry: Update popup loading behavior when watching via star [medium].

Though personally I don't understand the need for this feature, it seems a lot of users requested it and find it useful. So that's fine :)

Oct 20 2020, 2:19 AM · Community-Tech (Kanban-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Expiring-Watchlist-Items, TCB-Team (now WMDE-TechWish)

Oct 15 2020

Od1n added a comment to T249259: Watchlist Expiry: Update popup loading behavior when watching via star [medium].

Could you please provide a user setting for disabling this feature?

Oct 15 2020, 3:01 AM · Community-Tech (Kanban-2020-21-Q1), MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Expiring-Watchlist-Items, TCB-Team (now WMDE-TechWish)

Oct 11 2020

Od1n updated the task description for T265203: Allow start/end values to be modified after the toolbar has been bootstrapped.
Oct 11 2020, 3:10 AM · Patch-For-Review, CharInsert
Od1n created T265203: Allow start/end values to be modified after the toolbar has been bootstrapped.
Oct 11 2020, 2:59 AM · Patch-For-Review, CharInsert

Sep 8 2020

Od1n updated the task description for T262092: [October] Update to user styles and scripts required: .menu, .vectorTabs and .vectorMenu, .menu and .vectorMenuCheckbox no longer supported.
Sep 8 2020, 6:18 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Tech-Ambassadors, Patch-For-Review, Vector (Vector (Tracking)), User-notice
Od1n updated the task description for T262092: [October] Update to user styles and scripts required: .menu, .vectorTabs and .vectorMenu, .menu and .vectorMenuCheckbox no longer supported.
Sep 8 2020, 6:16 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Tech-Ambassadors, Patch-For-Review, Vector (Vector (Tracking)), User-notice

Jul 27 2020

Od1n added a comment to T247032: [EPIC] Build collapsible sidebar and deploy to all test wikis.

For your information, here is a script of mine, that I had developed to give full horizontal space to the content:

Jul 27 2020, 3:38 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements

May 29 2020

Od1n added a comment to T250393: Use monospace font (or editfont preference) for diffs.

I would like to clarify, are you (the devs) going to keep or revert the switch to monospace?

May 29 2020, 12:21 AM · Editing-team, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), User-notice, MediaWiki-Page-diffs

May 7 2020

Od1n added a comment to T250393: Use monospace font (or editfont preference) for diffs.

Look just above, the font <del>has been</del> <ins>is going to be</ins> restored to sans-serif.

May 7 2020, 10:32 AM · Editing-team, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), User-notice, MediaWiki-Page-diffs
Od1n added a comment to T250393: Use monospace font (or editfont preference) for diffs.

Just as a reminder, the changeset has been reverted

May 7 2020, 9:33 AM · Editing-team, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), User-notice, MediaWiki-Page-diffs
Od1n added a comment to T250393: Use monospace font (or editfont preference) for diffs.

Personally, after some initial reluctance, I tend to prefer the monospace, but I had to tweak the font in my user CSS.
The font really has to be fine-tuned, and it certainly varies a lot depending on the OS/browser/etc.

May 7 2020, 7:36 AM · Editing-team, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), User-notice, MediaWiki-Page-diffs
Od1n updated the task description for T176636: Unify CSS font stack of monospace-styled elements across products.
May 7 2020, 7:07 AM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Patch-For-Review, MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), MinervaNeue, Vector, CSS, UI-Standardization-Kanban, UI-Standardization
Od1n added a comment to T192373: Width of "Input wikitext" textfield on Special:ExpandTemplates is different from normal.

Just found T176636 already.

May 7 2020, 7:05 AM · VisualEditor (Current work), MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MediaWiki-Special-pages, MediaWiki-Interface
Od1n added a comment to T192373: Width of "Input wikitext" textfield on Special:ExpandTemplates is different from normal.

Some "Git blame" led me here ;)

May 7 2020, 7:02 AM · VisualEditor (Current work), MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MediaWiki-Special-pages, MediaWiki-Interface

Apr 26 2020

Od1n updated the task description for T250915: The [edit] section button does not appear on a sub page of a protected page..
Apr 26 2020, 2:50 AM · MediaWiki-Page-protection, MediaWiki-Templates
Od1n closed T251019: Links with query string replaced by "veaction=editsource" even for "action=history" and "action=purge" as Invalid.

Closing, as it was a mistake on the wiki actually. Refs the discussion, and the fix I have applied (removal of the inappropriately used mw-editsection class).

Apr 26 2020, 2:35 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Apr 14 2020

Od1n added a project to T250232: "Jump links" aren't hidden on print version with Monobook skin: CSS.
Apr 14 2020, 10:32 PM · CSS, Accessibility, Browser-support-print-media, MonoBook
Od1n created T250232: "Jump links" aren't hidden on print version with Monobook skin.
Apr 14 2020, 10:16 PM · CSS, Accessibility, Browser-support-print-media, MonoBook

Apr 4 2020

Od1n awarded T88797: #iferror should suppress scribunto error tracking category too a Like token.
Apr 4 2020, 12:42 AM · MediaWiki-TrackingCategories, ParserFunctions, MediaWiki-extensions-Scribunto

Apr 3 2020

Od1n added a comment to T137584: Allow Scribunto code to add a category without changing output.

Could anyone think of any issues, to have categories but without their code in the final wikitext?

Apr 3 2020, 2:25 PM · Platform Engineering, Patch-For-Review, MediaWiki-extensions-Scribunto

Mar 15 2020

Od1n added a comment to T213426: Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle.

I have added a code comment on the Gerrit patch.

Mar 15 2020, 7:25 AM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), Fundraising-Backlog, wdwb-tech, Growth-Team-Filtering, Patch-For-Review, Growth-Team, Metrolook, WikiEditor, Wikidata, MediaViewer, MassMessage, StructuredDiscussions, MediaWiki-extensions-CentralNotice, Technical-Debt (Deprecation process), JavaScript, MediaWiki-General

Mar 10 2020

Od1n awarded rMW8dbab8945c6e: mediawiki.log: Remove call to console.trace() for each warning a Like token.
Mar 10 2020, 11:06 PM

Feb 4 2020

Od1n added a comment to T178998: Table collapsing button is too close to the caption - add some CSS spacing.

T155347 is ready and awaiting for more than two years 😭

Feb 4 2020, 3:46 PM · UI-Standardization, Google-Code-in-2017, Wikimedia-Israel-Hackers, MediaWiki-General, CSS, good first task

Jan 10 2020

Od1n updated the task description for T242405: Minor formatting fix in JavaScript API edit module.
Jan 10 2020, 7:22 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), MediaWiki-General, Patch-For-Review, JavaScript
Od1n added a comment to T242405: Minor formatting fix in JavaScript API edit module.
Jan 10 2020, 3:25 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), MediaWiki-General, Patch-For-Review, JavaScript
Od1n removed projects from T242405: Minor formatting fix in JavaScript API edit module: Wikidata, Wikibase-JavaScript-Api.
Jan 10 2020, 3:16 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), MediaWiki-General, Patch-For-Review, JavaScript
Od1n created T242405: Minor formatting fix in JavaScript API edit module.
Jan 10 2020, 3:15 AM · MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), MediaWiki-General, Patch-For-Review, JavaScript

Dec 27 2019

Od1n added a comment to T215370: TalkOverlay should not extend Overlay.

Following-up to this commit,

Dec 27 2019, 3:52 PM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Dec 6 2019

Od1n added a comment to T200206: Omit `<link rel="mw-deduplicated-inline-style">` from page view HTML.

We had a related issue on frwiki (see talk, involving template Liste éléments):

Dec 6 2019, 6:46 PM · Parsoid, Performance-Team (Radar), MediaWiki-Parser, TemplateStyles

Nov 10 2019

Od1n awarded T137584: Allow Scribunto code to add a category without changing output a Like token.
Nov 10 2019, 4:36 PM · Platform Engineering, Patch-For-Review, MediaWiki-extensions-Scribunto