Mini task breakdown to cleanup:

• in ResponseFactory, change newErrorResponse arguments to code, message and optional context
• replace the remaining calls to newErrorResponse in middlewares
• modify newErrorResponseFromException to get rid of the new ErrorResponse( ... ) and pass in the three arguments directly
• move all public const error codes from ErrorResponse to UseCaseException
• remove the UseCaseErrorResponse class
• remove the ItemRedirectErrorResponse class

Here are some of my thoughts on using gitup over the past year or so.

Task breakdown:

Outstanding questions (for @WMDE-leszek) :

• Should we return an empty map ({}) if no statements exists with the provided property id?

Creating an ExceptionJsonPresenter would mean having to inject it into the ResponseFactory for all routes which seemed a bit excessive for an experiment. Instead, I made the new ResponseFactory::newErrorResponseFromException() method just convert the exception to an ErrorResponse for now. This also means no changes to ErrorResponseToHttpStatus are needed either.

Note: we will need to update the OpenAPI definition to make property/data-type nullable

Thanks @Michael

📜 Task breakdown notes:

So I don't forget, I'm adding some of my ideas/suggestions for improving errors here. Let me know if there is a better place for this.

We can't view the different 2xx and 3xx responses in grafana as that information isn't recorded with statsd, but we can view the different 4xx and 5xx responses. See Silvan's playpit dashboard for some examples.

A Wikibase REST API on Wikidata dashboard has been created.

@Manuel This seems more like a subtask of T314133: Allow recording Wikibase REST API usage for Wikidata monitoring and metrics than the parent task. This task will shortly be completed and I'm assuming discussion on the monitoring and metrics topic will continue in T314133? What do you think?

Successfully SSHed in and reset Kerberos password. Thanks!

The Wikibase REST API is covered by the AbuseFilter extension by using the same MediawikiEditEntity::attemptSave() low-level service. This service calls the EditFilterMergedContent hook which is registered by the extension (see extension.json). The error response returned by the Wikibase REST API is a generic 500 unexpected-error.