In T197083#4502992, @thcipriani wrote:

Quick update. I pushed up a new patchset for review for the plugin we're working on to resolve the problem in the notedb database: https://gerrit-review.googlesource.com/c/plugins/wmf-fixshadowuser/+/190030

There is no documentation for how to delete an account using notedb since it's new and upstream doesn't want users to be deleted (https://groups.google.com/d/msg/repo-discuss/JlV0i9w5lCY/F25h2t_HQzQJ). I'll ask how to do this and what the ramifications are if you're fine with losing all history.

Stalled until notedb is supported in the plugin.

I am not sure what the key is on windows / linux maybe ctrl + A but on the mac it's FN + A that opens the dialog where you write replies but also the one that adds reviewers.

Change has been merged but this does not auto close this revision.

Duplicate of T189182 ?

“Ready for review"” can be set by project members now

Oh sorry that I didn’t respond. Sorry that I was wrong or caused spam. Must be something else then?

Im guessing this problem is the new anti vandalism stuff.

Yup sure :)

Yup i think so.

I have this set https://github.com/miraheze/mw-config/blob/master/LocalWiki.php#L59 and this is my mathoid config https://github.com/miraheze/puppet/blob/master/modules/mathoid/files/config.yaml

In T196812#4482907, @greg wrote:

Thanks for the reasoning.

I'm not terribly inclined to use our user base as test subjects, especially when there are known issues that are not yet resolved on our install. But, if it's easy for them to go back to the old UI then maybe that's OK.

To be clear, in which upstream release will the old UI be removed?

In T196812#4482701, @greg wrote:

In T196812#4482013, @greg wrote:

So why not wait until we upgrade to 2.16?

In T196812#4482232, @Paladox wrote:

We can wait if you want?

I would prefer solid reasoning for doing it now or solid reasoning for doing it later. Given we have a choice that needs to be made we need reasons to do it or to wait. Can you help with those?

2.16 does include that feature :)

We can wait if you want?

@greg PolyGerrit has been made the default UI as of 2.16. David O (upstream) has a change to remove gwtui (https://gerrit-review.googlesource.com/c/gerrit/+/116790), but wants to keeps gwtui for at least one more release so 3.0 could possibly be the release marked for GWTUI removal.

1. This is set through a cookie so it's per browser.

we will want to hook into this https://github.com/GerritCodeReview/gerrit/blob/master/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html#L555

Also this https://gerrit-review.googlesource.com/c/gerrit/+/191610 has just been uploaded, that will help new users.

After forcing a cache refresh it seems to have worked.

@CCicalese_WMF 1.26.0 should fix your issue (it was fixed in that release)

@CCicalese_WMF hi, did you update to git-review 1.26.0?

Well for starters having just screenshots of the old ui and none for the new ui. Will confuse a new user more.

the old ui screen shots can be removed when ever upstream removes it (and we update to that version) :).

I've updated some of the screenshots to have both the old ui and new ui.

I've updated some of those screenshots to include polygerrit. Including the extra expand diff view (you don't have to go inside the diff to view it).

I got approval (after speaking with releng).

I think i found the problem. It is because of wgSVGMetadataCutoff.

@saper did you test that against stretch?

I get this error:

We should also make the group own its self.

Like this:

You can use this api https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#apply-fix i think (I'm not sure where the rest api is to suggest changes though)

This has been resolved now :).

We could add the user to this https://gerrit.wikimedia.org/r/admin/groups/119,members group which will grant them "create repos" and "create groups" rights in addition to other rights.

Closing as resolved as 2.15.3 should have resolved most of these issues with only the admin being able to unmark wips :)

PolyGerrit's change view is getting a minor redesign on top of the one already done in 2.16.

jenkins-bot does not need to be in cc to be able to run the tests.

I found where are problem was, caused by a configuration error.

Nope, can decline it for now.

i also see

pnmtojpeg: command not found

When I built that, I didn’t think about the rest api could be different heh.

if you were to clone the repo from GitHub and then changed the .git config file to point to the gerrit repo and push then yes it would overwrite the data (i think)

Was that repo imported from another repo (hosted else where?) if yes, then importing will overwrite i think.

Did someone force push? I see this https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CreatedPagesList/+/6339e603fbc15c49b0c6b298aa241dc6fe7f0684 which was force push as it dosen't have a change id.

We are importing from a import a user gave us to import. Just found that import> prefix to be weird.