I live in the United Kingdom GMT/BST(UTC+0, UTC+1)
I have autism.
๐ช๐บ ๐ฌ๐ง
I live in the United Kingdom GMT/BST(UTC+0, UTC+1)
I have autism.
๐ช๐บ ๐ฌ๐ง
I sent them a follow up email and they replied with:
Found it... I was looking at the wrong database.
some how manually running it worked.
Yeh, I checked the db and the schema it shows is:
"Web host or proxy. Contact cvt{{@}}miraheze.org if affected.: (Likely web host with a company name like Triple T Internet Company Limited, a Pakkret, Nonthaburi, Thailand-based concern.) Used by nefarious crosswiki spambot accounts for crosswiki spamming (200+ in past two months)" the full thing it tried to insert.
In T270923#6714071, @Reedy wrote:Pretty sure you've not deployed a schema change - T231170: Alter globalblocking tables to allow longer comments brought it up to 767 chars
Seems to affect Flow only, works with VE.
though I guess its disabled for a reason, so I think restarting gerrit is the only way.
@Dzahn Actually you could see if reloading the plugin works (which doesn't require downtime).
Gerrit needs a restart I think for that to take effect.
Fix is available at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/649910/12
Here's a test showing the recursion: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/649696
Patch below
Our config:
To reproduce with eval.php do the following:
Issue seems to only occur if using "8" and not "8" and "9".
Could the infinite loop be checkCondition calls getBlock() and getBlock eventually ends back up at checkCondition and since and repeat?
2020-12-15 01:08:23 test2 test2wiki: [33f96910118a256c243e33e8] /w/api.php?action=query&format=json&titles=Main_Page&prop=categories&clprop=sortkey ErrorException from line 535 of /srv/mediawiki/w/includes/user/UserGroupManager.php: PHP Warning: error_log() expects parameter 1 to be string, array given #0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array) #1 /srv/mediawiki/w/includes/user/UserGroupManager.php(535): error_log(array, integer) #2 /srv/mediawiki/w/includes/user/UserGroupManager.php(484): MediaWiki\User\UserGroupManager->checkCondition(array, User) #3 /srv/mediawiki/w/includes/user/UserGroupManager.php(470): MediaWiki\User\UserGroupManager->recCheckCondition(array, User) #4 /srv/mediawiki/w/includes/user/UserGroupManager.php(370): MediaWiki\User\UserGroupManager->recCheckCondition(array, User) #5 /srv/mediawiki/w/includes/user/UserGroupManager.php(257): MediaWiki\User\UserGroupManager->getUserAutopromoteGroups(User) #6 /srv/mediawiki/w/includes/user/UserGroupManager.php(295): MediaWiki\User\UserGroupManager->getUserImplicitGroups(User, integer, boolean) #7 /srv/mediawiki/w/includes/user/User.php(2967): MediaWiki\User\UserGroupManager->getUserEffectiveGroups(User, integer, boolean) #8 /srv/mediawiki/w/includes/Permissions/PermissionManager.php(1295): User->getEffectiveGroups() #9 /srv/mediawiki/w/includes/Permissions/PermissionManager.php(1244): MediaWiki\Permissions\PermissionManager->getUserPermissions(User) #10 /srv/mediawiki/w/includes/block/BlockManager.php(132): MediaWiki\Permissions\PermissionManager->userHasRight(User, string) #11 /srv/mediawiki/w/includes/user/User.php(1603): MediaWiki\Block\BlockManager->getUserBlock(User, WebRequest, boolean) #12 /srv/mediawiki/w/includes/user/User.php(1986): User->getBlockedStatus(boolean) #13 /srv/mediawiki/w/includes/block/BlockManager.php(472): User->getBlock() #14 /srv/mediawiki/w/includes/MediaWiki.php(767): MediaWiki\Block\BlockManager->trackBlockWithCookie(User, WebResponse) #15 /srv/mediawiki/w/includes/api/ApiMain.php(555): MediaWiki::preOutputCommit(DerivativeContext) #16 /srv/mediawiki/w/includes/api/ApiMain.php(500): ApiMain->executeActionWithErrorHandling() #17 /srv/mediawiki/w/api.php(90): ApiMain->execute() #18 /srv/mediawiki/w/api.php(45): wfApiMain()
@Reedy suggested that there might be a infinite loop.
Filed upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=13705
I've changed the log level to warning, thanks! (figured that out after writing this).
+1'd
https://github.com/miraheze/mediawiki/blob/REL1_35/includes/WebRequest.php#L240 returns true (hence why the overall return is false).
@Jdlrobson updated description.
@Jdlrobson Is what it looks like now with (https://gerrit.wikimedia.org/r/631814) , which seems fine for now.
@Jdlrobson disabling worked!
@Jdlrobson done T264686.
Oh, I think your US based. Which we've switched it off for. I'll switch it on so you can see. Please try again. @Jdlrobson
@Jdlrobson that looks nice! How was that managed (as in it spread out like that, and the "dismissible" button hidden?
@Jdlrobson something like ^?
@Jdlrobson I mean I am not sure if this looks nice
. Does this seem ok?@Jdlrobson thanks for the response! I found a replacement hook for the desktop version onSkinAfterContent, since it'll still shows the banner as if you did the code just under <body> though under MobileFrontend this shows in the footer thus this hook can only be used for the desktop. I've tried SiteNoticeAfterHook & SiteNoticeBeforeHook for mobile, the only issue is it displays where the site notice is, not at the top. Thus it's styles get lost (it's white the background, but because the background is already white it looks weird).
@Jdlrobson Hi, I'm wondering if you know what hook this extension should migrate? I haven't been able to find a hook that allows you to insert into the header element.
Upstream have this bug report: https://bugs.chromium.org/p/gerrit/issues/detail?id=11491&
Does HTTPS cloning work?
@matmarex do you have a slow connection?
We should back port it to 1.34 too.
Done: