I live in the United Kingdom GMT/BST(UTC+0, UTC+1)
I have autism.
🇪🇺 🇬🇧
I live in the United Kingdom GMT/BST(UTC+0, UTC+1)
I have autism.
🇪🇺 🇬🇧
In T311703#8039923, @hashar wrote:The REST API is https://gerrit.wikimedia.org/r/Documentation/rest-api-changes.html#cherry-pick which takes as in put a CherryPickInput entity. It only supports a single branch.
That can surely be amended by committing some resource and time to get Gerrit to support that new feature. Then it is unlikely anyone at upstream would be interested in spending time on it (maybe @Paladox might?).
To explain a bit more why it might not be of much interest to them. The way upstream manage their stable branch is they do the fix on the earliest branch (REL1_35) then once reviewed and merged they merge the hotfixed stable branch to the other stable branches all the way up to their primary branch which results in something like:
* (master) merge REL1_38 into master * (REL1_38) merge REL1_37 into REL1_38 | \ | * (REL1_37) merge REL1_35 into REL1_37 | \ | * (REL1_35) Hotfix for issue 1234 ... * (master)If the fix has first been proposed to the primary branch, it has to be moved to the earliest stable branch (ex: REL1_35) merged there and then it get merged back up. Or in short I don't think they cherry-pick.
That being said, a script can probably be written which would take a list of changes as parameter then issue the rest api querry to cherry-pick a change against each of the branches.
This is happening on 1.39 as well. I'm not sure which changes need to be backported as https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/829254 doesn't cleanly apply to the REL1_39 branch.
To put it clearly it was @Universal_Omega who found it.
So we found the cause of the OOM accidentally. It was caused by a misconfigured ImageMagick config. (this fixed the OOM's for us and uses lower memory). We had used the misconfigured config in the previous php version but seems that a new ImageMagick versions had issues with it. Also fixes cleaning up temp files.
In T321980#8355302, @Reedy wrote:Is it happening repeatedly? Or just seen once?
In T248925#8244134, @Huwmanbeing wrote:Strcasecmp-related error in CookieSessionProvider, MediaWiki 1.38.2.
This is a feature of Gerrit. From what I remember yellow/blue is when you rebase a change sometimes the file was changed in another change. So that’s what these colours show.
I *think* this may be fixed from gerrit 3.6. In gerrit 3.6 we redesigned how we did syntax highlighting. Still using highlight.js but syntax highlighting should be more reliable.
https://gerrit-review.googlesource.com/c/gerrit/+/313982/7 Was merged on 3.4 and I’ve backported https://gerrit-review.googlesource.com/c/gerrit/+/336094 to 3.4
we don't have git:// enabled for gerrit, we have had ECDSA and Ed25519 for years now and we can disable the ssh algorithms we don't want using the gerrit config.
You can have super submodules configured see https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/+/3487cb2fe882b42d4e181c3c6ed013691fe80e4f/project.config#13
In T296898#7542718, @Reedy wrote:BadMethodCallException: Sessions are disabled for this entry point
Which entry point would that be?
I’m not sure, that’s what I saw in the log (didn’t specify which end point though)
In T40010#7353052, @AntiCompositeNumber wrote:In T40010#7352995, @Paladox wrote:librsvg repo haas been disabled and doesn't support node v12+ (https://github.com/2gis/node-rsvg/tree/0.7.0). I see we could switch to puppeteer. E.g. https://github.com/etienne-martin/svg-to-img as a replacement?
(Debian bullseye uses nodejs 12.22.5).
Even the repo it says to use hasn't received an update since 2019...
We don't use that. Thumbor is written in Python (2, we know), but we shell out to rsvg-convert anyway. Librsvg is written mostly in Rust now, but the version currently in production is still C. Upstream is https://gitlab.gnome.org/GNOME/librsvg, packaged as https://packages.debian.org/stretch/librsvg2-bin.
librsvg repo haas been disabled and doesn't support node v12+ (https://github.com/2gis/node-rsvg/tree/0.7.0). I see we could switch to puppeteer. E.g. https://github.com/etienne-martin/svg-to-img as a replacement?