The WIP documentation for polygerrit needs documenting as this would have resolved T197238 (IE the "Start Review" button is the unwip button)

Path to be rsync is /srv/repos

Is the repos being resynced to phab1002?

The migration to cloud was done i think now.

Closing as resolved as refs/changes///meta is ignored and we are using T196855 to report any additional problems.

Ah doing php maintenance/cleanupUsersWithNoId.php --wiki=<wiki> --prefix=prefix fixed it.

Will that work for large wiki's? That would mean you would have to install mathoid on each server to be able to use it. But even then will it work if varnish magically decides which backend to use per request?

In T197520#4295404, @Izno wrote:

This is intended behavior. There is an intermediate size between "icons" and "2 column view".

@Isarra on the top bar you see "Navigation" and all along there other text too, those are icons if you spread the browser or make it small.

Tested the new fix and it fixes my issue now!

Using iOS 11.4 and iPhone X (now).

Hi, nope it dosent fix it for me.

Affects prod so UBN. Also it loads very very very slow that url.

PolyGerrit is now the default ui upstream https://gerrit-review.googlesource.com/c/gerrit/+/184550 (patch by me)

I would think it’s an attack as they are spamming on gerrit too https://gerrit.wikimedia.org/r/#/c/operations/puppet/+/440510/

https://gerrit-review.googlesource.com/c/gerrit/+/183851 is the fix which expands it to project owners too so not limited to just admins.

In T197238#4282981, @Tgr wrote:

I was slightly confused: the unWIP option seems to be missing completely from the new UI; on the old UI changeset owners can indeed see it. So this is not that bad a problem. Should block T196812: Make PolyGerrit the default ui though, IMO.

In T138672#2408607, @Krenair wrote:

Yes, we know what's causing this issue, it's the multiple accounts returned for this username:

krenair@tools-bastion-03:~$ ldapsearch -x cn=smccandlish | grep dn
 dn: uid=smccandlish,ou=people,dc=wikimedia,dc=org
 dn: uid=mech,ou=people,dc=wikimedia,dc=org

There is a start review button in polygerrit only the owner of the change can do it.

Upstream has wrote a reply https://bugs.chromium.org/p/gerrit/issues/detail?id=9256#c10

Ah I see, if it’s not too much trouble yeh we could fix it :).

@hashar that is old dat :), it’s stored in All-Users now which you have to clone a repo.

There use to be a unknown tag, also this should not stay untagged otherwise no one would be able to find it except you who knows how to :)

We already set that :)

Yes that seems related as 2.15 uses the index again I think

They reverted it for performance reasons

filled upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=9256

@Framawiki oh sorry forgot to tell you that we have postponed it until after the sre offsite (and then a date agreed with releng).

Fixed description now. was a misspelling it's https://www.mediawiki.org/wiki/Extension:MsLinks

@mmodell see https://phabricator.wikimedia.org/T197083#4280194 (we migrated to notedb so it's now in All-Users instead of the db)

@kaldari account has two external ids if i look at http://gerrit.wikimedia.org/r/accounts/?q=name:Kaldari+email:rkaldari@wikimedia.org&n=2

[17:51:42] <paladox> you git clone All-Users as your ssh user (which has admin and you need to grant the access db to the admins) then you edit .git/config and replace refs/heads with refs/ then git pull
[17:52:00] <paladox> and then git checkout origin/meta/external-ids

When searching for that user it couldn’t find them at least in the search bar.

This works under polygerrit, but seems to be a problem under gwtui.

It does not show those warnings when doing it under mediawiki 1.30 and php 7.0.

Done and ok :)

Hmm, though i revised the email by sending out the updated date :).

We will have to do it on friday as no ops are around to do it from next monday due to offsite.

project admins are who ever are owners of for example mediawiki/*, mediawiki/extension/<extension_name> and so on :).

Upstream have recently fixed the WIP problem by opening it to project admin in additions to admins. so we will need to update to gerrit 2.15.3 when it's released.

@Framawiki wondering can we get the user notice out so we can do this next monday please? :)

Yeh, upstream have implemented a really nice inline editing ui for 2.16 / 3.0 :).

phabricator is going to parse the existing refs/changes/*/*/meta commits (no new ones will be added to the queue so this will eventually go down). According to @mmodell it queued over 8 million refs.

Apparently in gwtui it loads the js file to early to be able to find the dom like polygerrit, anyways we are switching polygerrit to be the default ui for new users (and existing users that have not switched to the new ui and back to the old one thus having a ui cookie) see T196812 (next monday).