This is a feature of Gerrit. From what I remember yellow/blue is when you rebase a change sometimes the file was changed in another change. So that’s what these colours show.

May 15 2022, 5:38 PM · Gerrit

Apr 28 2022

Paladox added a comment to T288304: Syntaxhighlighting in Gerrit is broken on php here doc syntax.

I *think* this may be fixed from gerrit 3.6. In gerrit 3.6 we redesigned how we did syntax highlighting. Still using highlight.js but syntax highlighting should be more reliable.

Apr 28 2022, 12:17 PM · Gerrit

Paladox added a comment to T307072: Gerrit 3.4 shows empty avatar next to usernames.

https://gerrit-review.googlesource.com/c/gerrit/+/313982/7 Was merged on 3.4 and I’ve backported https://gerrit-review.googlesource.com/c/gerrit/+/336094 to 3.4

Apr 28 2022, 11:11 AM · Upstream, Gerrit (Gerrit 3.4)

Paladox added a comment to T307072: Gerrit 3.4 shows empty avatar next to usernames.

Fixed with https://gerrit-review.googlesource.com/c/gerrit/+/313983 and https://gerrit-review.googlesource.com/c/gerrit/+/313982/7.

Apr 28 2022, 11:04 AM · Upstream, Gerrit (Gerrit 3.4)

Mar 21 2022

Paladox added a comment to T304231: Take some pointers from GitHub security updates.

we don't have git:// enabled for gerrit, we have had ECDSA and Ed25519 for years now and we can disable the ssh algorithms we don't want using the gerrit config.

Mar 21 2022, 4:11 PM · GitLab (Administration, Settings & Policy), SRE, wikitech.wikimedia.org, Horizon, Security

Jan 10 2022

Paladox closed T298564: Add support for using ipv6 address for memcached as Resolved.

Jan 10 2022, 8:37 PM · IPv6, MW-1.37-notes, MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MW-1.35-notes, MW-1.36-notes, MW-1.37-release, MW-1.36-release, MW-1.35-release, MediaWiki-libs-ObjectCache, User-RhinosF1, MediaWiki-General, Performance-Team

Jan 4 2022

Paladox updated the task description for T298564: Add support for using ipv6 address for memcached.

Jan 4 2022, 8:25 PM · IPv6, MW-1.37-notes, MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MW-1.35-notes, MW-1.36-notes, MW-1.37-release, MW-1.36-release, MW-1.35-release, MediaWiki-libs-ObjectCache, User-RhinosF1, MediaWiki-General, Performance-Team

Paladox created T298564: Add support for using ipv6 address for memcached.

Jan 4 2022, 8:16 PM · IPv6, MW-1.37-notes, MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MW-1.35-notes, MW-1.36-notes, MW-1.37-release, MW-1.36-release, MW-1.35-release, MediaWiki-libs-ObjectCache, User-RhinosF1, MediaWiki-General, Performance-Team

Lens0021 awarded T199472: Update WikiApiary to MediaWiki 1.35 a Like token.

Jan 4 2022, 4:37 AM · WikiApiary

Jan 2 2022

Paladox added a comment to T298444: VisualEditor branches use outdated versions of lib/ve.

You can have super submodules configured see https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/+/3487cb2fe882b42d4e181c3c6ed013691fe80e4f/project.config#13

Jan 2 2022, 6:46 PM · LibUp, Security, VisualEditor

Dec 4 2021

Paladox created T297046: PHP 7.4 causes OOMs with Cargo extension.

Dec 4 2021, 2:53 PM · affects-Miraheze, MediaWiki-extensions-Cargo, MW-1.37-release, Performance Issue, MediaWiki-General, PHP 7.4 support

Dec 2 2021

Paladox added a comment to T296898: BadMethodCallException: Sessions are disabled for this entry point in /srv/mediawiki/w/includes/session/SessionManager.php:849.

In T296898#7542718, @Reedy wrote:

BadMethodCallException: Sessions are disabled for this entry point

Which entry point would that be?

I’m not sure, that’s what I saw in the log (didn’t specify which end point though)

Dec 2 2021, 3:09 AM · MW-1.37-notes, MW-1.36-notes, MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), MW-1.36-release, PHP 7.4 support, MediaWiki-General

Paladox created T296898: BadMethodCallException: Sessions are disabled for this entry point in /srv/mediawiki/w/includes/session/SessionManager.php:849.

Dec 2 2021, 12:20 AM · MW-1.37-notes, MW-1.36-notes, MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), MW-1.36-release, PHP 7.4 support, MediaWiki-General

Paladox created T296896: PHP Notice: Trying to access array offset on value of type null in CategoryViewer.php on line 516.

Dec 2 2021, 12:13 AM · Patch-For-Review, PHP 7.4 support, MediaWiki-General

Sep 14 2021

Paladox added a comment to T40010: RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis.

In T40010#7353052, @AntiCompositeNumber wrote:

In T40010#7352995, @Paladox wrote:

librsvg repo haas been disabled and doesn't support node v12+ (https://github.com/2gis/node-rsvg/tree/0.7.0). I see we could switch to puppeteer. E.g. https://github.com/etienne-martin/svg-to-img as a replacement?

(Debian bullseye uses nodejs 12.22.5).

Even the repo it says to use hasn't received an update since 2019...

We don't use that. Thumbor is written in Python (2, we know), but we shell out to rsvg-convert anyway. Librsvg is written mostly in Rust now, but the version currently in production is still C. Upstream is https://gitlab.gnome.org/GNOME/librsvg, packaged as https://packages.debian.org/stretch/librsvg2-bin.

Sep 14 2021, 7:33 PM · Proposal, Thumbor, MediaWiki-File-management, Commons, Wikimedia-SVG-rendering

Paladox added a comment to T40010: RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis.

librsvg repo haas been disabled and doesn't support node v12+ (https://github.com/2gis/node-rsvg/tree/0.7.0). I see we could switch to puppeteer. E.g. https://github.com/etienne-martin/svg-to-img as a replacement?

Sep 14 2021, 7:17 PM · Proposal, Thumbor, MediaWiki-File-management, Commons, Wikimedia-SVG-rendering

Sep 9 2021

Paladox created T290629: Since switch to using parser options in construct getting "Caused "Call to a member function getMaxPPNodeCount".

Sep 9 2021, 2:34 AM · MediaWiki-extensions-Other, MediaWiki-General

Sep 8 2021

Paladox added a comment to T288792: Improve performance of CentralAuth.

97.91% 13510.184      1 - wfIndexMain
97.91% 13510.050      1 - MediaWiki::run
97.58% 13463.819      1 - MediaWiki::main
93.93% 12961.417      1 - MediaWiki::performRequest
93.63% 12919.524      1 - MediaWiki\SpecialPage\SpecialPageFactory::executePath
93.63% 12919.118      1 - SpecialPage::run
93.56% 12910.165      1 - SpecialCentralAuth::execute
64.36% 8880.423      1 - CentralAuthUser::queryAttached
62.24% 8587.526    573 - CentralAuthUser::localUserData
36.17% 4990.544   1152 - Wikimedia\Rdbms\LoadBalancer::getConnectionRef
36.14% 4986.084   1172 - Wikimedia\Rdbms\LoadBalancer::getConnection
35.56% 4906.078   1172 - Wikimedia\Rdbms\LoadBalancer::getServerConnection
29.84% 4117.510   2885 - Wikimedia\Rdbms\Database::executeQuery
29.10% 4015.047   1149 - Wikimedia\Rdbms\LoadBalancer::getForeignConnection
29.10% 4014.878   2885 - Wikimedia\Rdbms\Database::executeQueryAttempt
27.97% 3859.694   3989 - array_map
27.73% 3825.916      1 - SpecialCentralAuth::showWikiLists
27.69% 3820.468      1 - SpecialCentralAuth::listAccounts
27.68% 3818.692    573 - SpecialCentralAuth::listWikiItem
24.96% 3444.532   2317 - Wikimedia\Rdbms\Database::query
24.10% 3326.006   2885 - Wikimedia\Rdbms\DatabaseMysqli::doQuery
23.48% 3240.000   2885 - mysqli::query
22.88% 3157.551      6 - Wikimedia\Rdbms\LoadBalancer::reallyOpenConnection
22.84% 3150.868      6 - Wikimedia\Rdbms\Database::initConnection
22.83% 3150.843      6 - Wikimedia\Rdbms\Database::doInitConnection
22.83% 3150.825      6 - Wikimedia\Rdbms\DatabaseMysqlBase::open
22.79% 3145.182      6 - Wikimedia\Rdbms\DatabaseMysqli::mysqlConnect
22.79% 3144.691      6 - mysqli::real_connect
22.50% 3104.466   1750 - Wikimedia\Rdbms\DBConnRef::__call
22.15% 3056.303   1729 - Wikimedia\Rdbms\Database::select
17.05% 2353.276   4227 - Message::format
16.46% 2271.586   4158 - Message::text
15.22% 2100.284   1151 - Wikimedia\Rdbms\DBConnRef::select
13.29% 1834.294    573 - SpecialCentralAuth::formatEditcount
10.49% 1447.528   4932 - Message::fetchMessage
 9.95% 1372.513   4875 - MessageCache::get
 9.48% 1307.394    574 - MediaWiki\User\UserGroupManager::getUserGroupMemberships
 8.20% 1131.602   4205 - Message::transformText
 7.77% 1072.799   4218 - MessageCache::transform
 7.59% 1046.845   2867 - WikiMap::getWiki
 7.53% 1039.686   2867 - WikiMap::getWikiReferenceFromWgConf
 7.48% 1032.239    583 - Parser::transformMsg
 7.47% 1030.075    583 - Parser::preprocess
 7.24% 999.163    575 - Wikimedia\Rdbms\DBConnRef::selectRow
 7.20% 993.341    575 - Wikimedia\Rdbms\Database::selectRow
 7.09% 978.543   6510 - MediaWiki\HookContainer\HookContainer::run
 6.79% 936.543   1230 - BagOStuff::getWithSetCallback
 6.36% 878.152   8601 - SiteConfiguration::get
 6.24% 860.782    589 - Parser::replaceVariables
 6.12% 844.115   1172 - Wikimedia\Rdbms\LoadBalancer::isMasterConnectionReadOnly
 5.78% 797.323    573 - section.query-m: SELECT ipb_id,ipb_expiry,ipb_block_email,ipb_anon_only,ipb_create_account,ipb_enable_autoblock,ipb_allow_usertalk,ipb_sitewide,comment_ipb_reason.comment_text AS `ipb_reason_text`,comment_ipb_reason.comment_data AS `ipb_reason_data`,comment_ipb_reason.com
 5.69% 785.503    573 - section.query-m: SELECT ug_user,ug_group,ug_expiry FROM `user_groups` WHERE ug_user = N 
 5.65% 779.592   6624 - SiteConfiguration::processSetting
 5.41% 746.282    568 - Wikimedia\Rdbms\Database::selectDomain
 5.39% 743.393    568 - Wikimedia\Rdbms\DatabaseMysqlBase::doSelectDomain
 5.33% 734.860    716 - Wikimedia\Rdbms\LoadBalancer::Wikimedia\Rdbms\{closure}
 5.30% 730.969    578 - Wikimedia\Rdbms\DatabaseMysqlBase::serverIsReadOnly
 5.26% 726.021    573 - section.query-m: SELECT user_id,user_email,user_name,user_email_authenticated,user_password,user_editcount,user_registration FROM `user` WHERE user_name = 'X' LIMIT N 
 5.20% 717.200   4875 - MessageCache::getMessageFromFallbackChain
 5.11% 705.037   4939 - MessageCache::getMessageForLang
 4.98% 686.718    589 - PPFrame_Hash::expand
 4.40% 607.256    584 - Parser::braceSubstitution
 4.37% 603.294   4879 - MessageCache::getMsgFromNamespace
 4.34% 598.332    573 - SpecialCentralAuth::formatBlockStatus
 4.24% 585.299    578 - section.query-m: SELECT @@GLOBAL.read_only AS Value
 3.89% 536.204   4875 - MediaWiki\HookContainer\HookRunner::onMessageCache__get
 3.82% 526.899   1719 - SpecialCentralAuth::foreignLink
 3.65% 504.298  11516 - MediaWiki\HookContainer\HookContainer::callLegacyHook
 3.60% 496.659      1 - MediaWiki::{closure}

Sep 8 2021, 6:28 PM · MediaWiki-extensions-CentralAuth

Paladox added a comment to T288792: Improve performance of CentralAuth.

In T288792#7340317, @Majavah wrote:

In T288792#7340314, @Paladox wrote:

I think it just checks each wikis edit table (which isn't future realistic). What if you had 20,000 wikis or a million? Very expensive to run.

Core already caches edit counts in the user table. CentralAuth reads it from there, but it takes a while as it needs to read it from every individual wiki.

Sep 8 2021, 6:22 PM · MediaWiki-extensions-CentralAuth

Paladox added a comment to T288792: Improve performance of CentralAuth.

In T288792#7340274, @Majavah wrote:

In T288792#7340009, @Paladox wrote:

Could also improve the performance for Special:CentralAuth. Some ideas are creating a job to do the edit stat updates rather then doing it all on page load.

Which stat counters? I'd rather not duplicate practically all displayed per-wiki user data to the CA database.

I presume the reason why logins are slow is the same reason that page is slow?

Probably different reasons.

Sep 8 2021, 6:19 PM · MediaWiki-extensions-CentralAuth

Paladox added a comment to T288792: Improve performance of CentralAuth.

Could also improve the performance for Special:CentralAuth. Some ideas are creating a job to do the edit stat updates rather then doing it all on page load.

Sep 8 2021, 4:41 PM · MediaWiki-extensions-CentralAuth