Page MenuHomePhabricator

Paladox (Paladox)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 9:51 AM (349 w, 6 d)
Availability
Available
LDAP User
Paladox
MediaWiki User
Unknown

I live in the United Kingdom GMT/BST(UTC+0, UTC+1)

I have autism.

๐Ÿ‡ช๐Ÿ‡บ ๐Ÿ‡ฌ๐Ÿ‡ง

Recent Activity

Sat, Jun 12

Paladox closed T270687: IPs can comment when globally blocked as Resolved.
Sat, Jun 12, 6:10 PM ยท User-RhinosF1, Comments, Social-Tools
Paladox closed T226342: Comments should use Title::userCan to determine a user's blocked status as Resolved.
Sat, Jun 12, 6:09 PM ยท Social-Tools, Comments

Wed, Jun 9

Paladox created P16363 (An Untitled Masterwork).
Wed, Jun 9, 6:06 PM

Mon, May 24

Paladox updated the task description for T283539: Error: Call to undefined function MediaWiki\Extension\Interwiki\Hooks().
Mon, May 24, 8:50 PM ยท MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), MediaWiki-extensions-Interwiki
Paladox created T283539: Error: Call to undefined function MediaWiki\Extension\Interwiki\Hooks().
Mon, May 24, 8:44 PM ยท MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), MediaWiki-extensions-Interwiki
Paladox created P16180 (An Untitled Masterwork).
Mon, May 24, 8:39 PM

May 10 2021

Paladox closed T262659: Cannot connect to MySQL in phab.wmflabs.org as Resolved.

It works and has for a while. Closing as resolved.

May 10 2021, 5:15 PM ยท VPS-project-Phabricator
Paladox merged T275270: Can't register on phab.wmflabs.org into T265505: Verification email does not reach my inbox.
May 10 2021, 5:13 PM ยท VPS-project-Phabricator
Paladox merged task T275270: Can't register on phab.wmflabs.org into T265505: Verification email does not reach my inbox.
May 10 2021, 5:13 PM ยท VPS-project-Phabricator

May 8 2021

Paladox committed rGERRITDEPLOY9b0c0bc6d03f: Remove unused _handleDropdownTap (authored by Paladox).
Remove unused _handleDropdownTap
May 8 2021, 2:00 PM

Apr 13 2021

Paladox added a comment to T279989: Shouldn't be possible to push direct to master.

https://gerrit.wikimedia.org/r/admin/repos/mediawiki/extensions/MsUpload,access Shows it has push rules. Should be as simple as removing that rule to revoke direct pushing.

Apr 13 2021, 8:37 AM ยท Gerrit

Apr 12 2021

Paladox added a comment to T268225: Switch Gerrit from Java 8 to Java 11.

I think that we use java 11 now?

Apr 12 2021, 8:34 PM ยท Release-Engineering-Team (Doing), Gerrit (Gerrit 3.3)

Mar 21 2021

Paladox added a comment to T222413: PageContentSave does not allow modification of parameters.

Oh! That's because of wgLinkTitlesFirstOnly.

Mar 21 2021, 12:36 AM ยท Multi-Content-Revisions, MediaWiki-Documentation, MediaWiki-Revision-backend, MediaWiki-Page-editing
Paladox added a comment to T222413: PageContentSave does not allow modification of parameters.

Slots can still be accessed via RenderedRevision object:

public static function onMultiContentSave( $renderedRevision, $user, $summary, $flags, $hookStatus ) {
    $slots = $renderedRevision->getRevision()->getSlots();
Mar 21 2021, 12:29 AM ยท Multi-Content-Revisions, MediaWiki-Documentation, MediaWiki-Revision-backend, MediaWiki-Page-editing

Mar 20 2021

Paladox added a comment to T222413: PageContentSave does not allow modification of parameters.

See also T205982. If/when MultiContentSave hook is merged (https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/467308/), it will be possible to use the following:

public static function onMultiContentSave( $title, $user, $slots, $summary, $flags, $status ) {
    $slots->setContent( 'main', ContentHandler::makeContent( "Another text", $title ) );
Mar 20 2021, 5:39 PM ยท Multi-Content-Revisions, MediaWiki-Documentation, MediaWiki-Revision-backend, MediaWiki-Page-editing

Mar 19 2021

Paladox added a comment to T277479: Miraheze section on wiki stats is blank.

@Dzahn I've fixed the api with https://github.com/miraheze/WikiDiscover/commit/d69574d21636a9fe29fa69ea693460940f5f992a

Mar 19 2021, 1:58 AM ยท User-RhinosF1, VPS-project-Wikistats

Mar 12 2021

Paladox created P14822 (An Untitled Masterwork).
Mar 12 2021, 9:17 PM
Paladox created P14821 (An Untitled Masterwork).
Mar 12 2021, 9:12 PM

Feb 24 2021

Paladox committed rEWSEb72a071b998f: MetaTag: Fix it so false is supported for Config (authored by Paladox).
MetaTag: Fix it so false is supported for Config
Feb 24 2021, 1:47 PM

Feb 18 2021

Paladox updated the task description for T274736: Grafana may allow access to API unauthenticated [CVE-2021-27358].
Feb 18 2021, 7:14 PM ยท Upstream, Security-Team, User-RhinosF1, Vuln-DoS, observability, Security

Feb 16 2021

Paladox closed T274898: PHP Notice: Undefined property: stdClass::$1 as Resolved.
Feb 16 2021, 5:33 PM ยท User-RhinosF1, MediaWiki-extensions-Cargo
Paladox created T274898: PHP Notice: Undefined property: stdClass::$1.
Feb 16 2021, 3:44 PM ยท User-RhinosF1, MediaWiki-extensions-Cargo

Feb 15 2021

Paladox added a comment to T274736: Grafana may allow access to API unauthenticated [CVE-2021-27358].

I sent them a follow up email and they replied with:

Feb 15 2021, 2:58 PM ยท Upstream, Security-Team, User-RhinosF1, Vuln-DoS, observability, Security

Feb 8 2021

Paladox created T274155: "Encountered a name invalid in XML.".
Feb 8 2021, 4:25 PM ยท Parsoid (Third-party), MW-1.35-release, MediaWiki-General

Feb 1 2021

Paladox committed rECW4f3981580db3: Move the warning outside sitenotice, tidy up code (authored by Ostrzyciel).
Move the warning outside sitenotice, tidy up code
Feb 1 2021, 6:15 PM

Jan 27 2021

Paladox closed T271551: ipblock-exempt permissions (inherited through CentralAuth) seems to be ignored on enwiki as Resolved.
Jan 27 2021, 10:13 PM ยท MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), User-Urbanecm, Anti-Harassment, Stewards-and-global-tools, Patch-For-Review, MediaWiki-extensions-CentralAuth, MediaWiki-User-management, Security, Security-Team

Dec 29 2020

Paladox added a comment to T270923: Error 1406: Data too long for column 'gb_reason'.

Found it... I was looking at the wrong database.

Dec 29 2020, 8:56 PM ยท User-RhinosF1, Schema-change, GlobalBlocking
Paladox added a comment to T270923: Error 1406: Data too long for column 'gb_reason'.

some how manually running it worked.

Dec 29 2020, 8:51 PM ยท User-RhinosF1, Schema-change, GlobalBlocking
Paladox added a comment to T270923: Error 1406: Data too long for column 'gb_reason'.

Yeh, I checked the db and the schema it shows is:

Dec 29 2020, 8:50 PM ยท User-RhinosF1, Schema-change, GlobalBlocking
Paladox added a comment to T270923: Error 1406: Data too long for column 'gb_reason'.

"Web host or proxy. Contact cvt{{@}}miraheze.org if affected.: (Likely web host with a company name like Triple T Internet Company Limited, a Pakkret, Nonthaburi, Thailand-based concern.) Used by nefarious crosswiki spambot accounts for crosswiki spamming (200+ in past two months)" the full thing it tried to insert.

Dec 29 2020, 8:46 PM ยท User-RhinosF1, Schema-change, GlobalBlocking
Paladox added a comment to T270923: Error 1406: Data too long for column 'gb_reason'.

Pretty sure you've not deployed a schema change - T231170: Alter globalblocking tables to allow longer comments brought it up to 767 chars

Dec 29 2020, 8:42 PM ยท User-RhinosF1, Schema-change, GlobalBlocking
Paladox added a comment to T270916: writeapi permission required for * group even if logged in for rest.php.

URL: "https://test2.miraheze.org/w/rest.php/test2.miraheze.org/v3/transform/wikitext/to/html/Topic%3AVz5uwxnb5dt80i8u"

Dec 29 2020, 6:45 PM ยท Growth-Team-Filtering, Parsoid (Tracking), StructuredDiscussions, Growth-Team, MediaWiki-REST-API
Paladox added a comment to T270916: writeapi permission required for * group even if logged in for rest.php.

Seems to affect Flow only, works with VE.

Dec 29 2020, 6:42 PM ยท Growth-Team-Filtering, Parsoid (Tracking), StructuredDiscussions, Growth-Team, MediaWiki-REST-API
Paladox updated the task description for T270916: writeapi permission required for * group even if logged in for rest.php.
Dec 29 2020, 6:07 PM ยท Growth-Team-Filtering, Parsoid (Tracking), StructuredDiscussions, Growth-Team, MediaWiki-REST-API
Paladox created T270916: writeapi permission required for * group even if logged in for rest.php.
Dec 29 2020, 6:07 PM ยท Growth-Team-Filtering, Parsoid (Tracking), StructuredDiscussions, Growth-Team, MediaWiki-REST-API

Dec 22 2020

Paladox removed a project from T270687: IPs can comment when globally blocked: GlobalBlocking.
Dec 22 2020, 8:14 PM ยท User-RhinosF1, Comments, Social-Tools
Paladox added a comment to T269300: Modify readme.md for gerrit markdown.

though I guess its disabled for a reason, so I think restarting gerrit is the only way.

Dec 22 2020, 7:16 PM ยท Upstream, Release-Engineering-Team-TODO, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js, WVUI
Paladox added a comment to T269300: Modify readme.md for gerrit markdown.

Need to enable https://github.com/GerritCodeReview/gerrit/blob/774100cf7e3b28af0087f77baf83b0da9c715977/java/com/google/gerrit/server/plugins/PluginLoader.java#L119 apparently

Dec 22 2020, 7:15 PM ยท Upstream, Release-Engineering-Team-TODO, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js, WVUI
Paladox added a comment to T269300: Modify readme.md for gerrit markdown.

@Dzahn Actually you could see if reloading the plugin works (which doesn't require downtime).

Dec 22 2020, 5:16 PM ยท Upstream, Release-Engineering-Team-TODO, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js, WVUI
Paladox added a comment to T269300: Modify readme.md for gerrit markdown.

Gerrit needs a restart I think for that to take effect.

Dec 22 2020, 5:15 PM ยท Upstream, Release-Engineering-Team-TODO, Readers-Web-Backlog (Kanbanana-FY-2020-21), Vue.js, WVUI

Dec 16 2020

Paladox added a comment to T270145: Using auto promote APCOND_BLOCKED can cause php to OOM.

Fix is available at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/649910/12

Dec 16 2020, 9:22 PM ยท MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-release, MW-1.35-notes, Anti-Harassment, MediaWiki-User-management, User-RhinosF1, MediaWiki-Blocks, Security
Paladox added a project to T270145: Using auto promote APCOND_BLOCKED can cause php to OOM: Anti-Harassment.
Dec 16 2020, 8:10 PM ยท MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-release, MW-1.35-notes, Anti-Harassment, MediaWiki-User-management, User-RhinosF1, MediaWiki-Blocks, Security
Paladox added a comment to T270145: Using auto promote APCOND_BLOCKED can cause php to OOM.

Here's a test showing the recursion: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/649696

Dec 16 2020, 7:42 PM ยท MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-release, MW-1.35-notes, Anti-Harassment, MediaWiki-User-management, User-RhinosF1, MediaWiki-Blocks, Security

Dec 15 2020

Paladox added a comment to T270145: Using auto promote APCOND_BLOCKED can cause php to OOM.

Patch below

Dec 15 2020, 9:12 PM ยท MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-release, MW-1.35-notes, Anti-Harassment, MediaWiki-User-management, User-RhinosF1, MediaWiki-Blocks, Security
Paladox triaged T270145: Using auto promote APCOND_BLOCKED can cause php to OOM as High priority.
Dec 15 2020, 4:33 PM ยท MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-release, MW-1.35-notes, Anti-Harassment, MediaWiki-User-management, User-RhinosF1, MediaWiki-Blocks, Security
Paladox added a comment to T270145: Using auto promote APCOND_BLOCKED can cause php to OOM.

Our config:

Dec 15 2020, 4:01 PM ยท MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-release, MW-1.35-notes, Anti-Harassment, MediaWiki-User-management, User-RhinosF1, MediaWiki-Blocks, Security
Paladox added a comment to T270145: Using auto promote APCOND_BLOCKED can cause php to OOM.

To reproduce with eval.php do the following:

Dec 15 2020, 3:57 PM ยท MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-release, MW-1.35-notes, Anti-Harassment, MediaWiki-User-management, User-RhinosF1, MediaWiki-Blocks, Security
Paladox updated subscribers of T270145: Using auto promote APCOND_BLOCKED can cause php to OOM.
Dec 15 2020, 8:01 AM ยท MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-release, MW-1.35-notes, Anti-Harassment, MediaWiki-User-management, User-RhinosF1, MediaWiki-Blocks, Security
Paladox added a comment to T270145: Using auto promote APCOND_BLOCKED can cause php to OOM.

Issue seems to only occur if using "8" and not "8" and "9".

Dec 15 2020, 1:15 AM ยท MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-release, MW-1.35-notes, Anti-Harassment, MediaWiki-User-management, User-RhinosF1, MediaWiki-Blocks, Security
Paladox added a comment to T270145: Using auto promote APCOND_BLOCKED can cause php to OOM.

Could the infinite loop be checkCondition calls getBlock() and getBlock eventually ends back up at checkCondition and since and repeat?

Dec 15 2020, 1:11 AM ยท MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-release, MW-1.35-notes, Anti-Harassment, MediaWiki-User-management, User-RhinosF1, MediaWiki-Blocks, Security
Paladox added a comment to T270145: Using auto promote APCOND_BLOCKED can cause php to OOM.
2020-12-15 01:08:23 test2 test2wiki: [33f96910118a256c243e33e8] /w/api.php?action=query&format=json&titles=Main_Page&prop=categories&clprop=sortkey   ErrorException from line 535 of /srv/mediawiki/w/includes/user/UserGroupManager.php: PHP Warning: error_log() expects parameter 1 to be string, array given
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/w/includes/user/UserGroupManager.php(535): error_log(array, integer)
#2 /srv/mediawiki/w/includes/user/UserGroupManager.php(484): MediaWiki\User\UserGroupManager->checkCondition(array, User)
#3 /srv/mediawiki/w/includes/user/UserGroupManager.php(470): MediaWiki\User\UserGroupManager->recCheckCondition(array, User)
#4 /srv/mediawiki/w/includes/user/UserGroupManager.php(370): MediaWiki\User\UserGroupManager->recCheckCondition(array, User)
#5 /srv/mediawiki/w/includes/user/UserGroupManager.php(257): MediaWiki\User\UserGroupManager->getUserAutopromoteGroups(User)
#6 /srv/mediawiki/w/includes/user/UserGroupManager.php(295): MediaWiki\User\UserGroupManager->getUserImplicitGroups(User, integer, boolean)
#7 /srv/mediawiki/w/includes/user/User.php(2967): MediaWiki\User\UserGroupManager->getUserEffectiveGroups(User, integer, boolean)
#8 /srv/mediawiki/w/includes/Permissions/PermissionManager.php(1295): User->getEffectiveGroups()
#9 /srv/mediawiki/w/includes/Permissions/PermissionManager.php(1244): MediaWiki\Permissions\PermissionManager->getUserPermissions(User)
#10 /srv/mediawiki/w/includes/block/BlockManager.php(132): MediaWiki\Permissions\PermissionManager->userHasRight(User, string)
#11 /srv/mediawiki/w/includes/user/User.php(1603): MediaWiki\Block\BlockManager->getUserBlock(User, WebRequest, boolean)
#12 /srv/mediawiki/w/includes/user/User.php(1986): User->getBlockedStatus(boolean)
#13 /srv/mediawiki/w/includes/block/BlockManager.php(472): User->getBlock()
#14 /srv/mediawiki/w/includes/MediaWiki.php(767): MediaWiki\Block\BlockManager->trackBlockWithCookie(User, WebResponse)
#15 /srv/mediawiki/w/includes/api/ApiMain.php(555): MediaWiki::preOutputCommit(DerivativeContext)
#16 /srv/mediawiki/w/includes/api/ApiMain.php(500): ApiMain->executeActionWithErrorHandling()
#17 /srv/mediawiki/w/api.php(90): ApiMain->execute()
#18 /srv/mediawiki/w/api.php(45): wfApiMain()
Dec 15 2020, 1:09 AM ยท MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-release, MW-1.35-notes, Anti-Harassment, MediaWiki-User-management, User-RhinosF1, MediaWiki-Blocks, Security
Paladox added a comment to T270145: Using auto promote APCOND_BLOCKED can cause php to OOM.

@Reedy suggested that there might be a infinite loop.

Dec 15 2020, 12:55 AM ยท MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-release, MW-1.35-notes, Anti-Harassment, MediaWiki-User-management, User-RhinosF1, MediaWiki-Blocks, Security
Paladox added projects to T270145: Using auto promote APCOND_BLOCKED can cause php to OOM: MediaWiki-Blocks, MediaWiki-General.
Dec 15 2020, 12:39 AM ยท MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-release, MW-1.35-notes, Anti-Harassment, MediaWiki-User-management, User-RhinosF1, MediaWiki-Blocks, Security
Paladox updated the task description for T270145: Using auto promote APCOND_BLOCKED can cause php to OOM.
Dec 15 2020, 12:36 AM ยท MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-release, MW-1.35-notes, Anti-Harassment, MediaWiki-User-management, User-RhinosF1, MediaWiki-Blocks, Security
Paladox created T270145: Using auto promote APCOND_BLOCKED can cause php to OOM.
Dec 15 2020, 12:35 AM ยท MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, MW-1.35-release, MW-1.35-notes, Anti-Harassment, MediaWiki-User-management, User-RhinosF1, MediaWiki-Blocks, Security

Dec 14 2020

Paladox created P13546 (An Untitled Masterwork).
Dec 14 2020, 3:51 PM

Dec 4 2020

Paladox created T269425: Logs are not sent if wiki throws "Uncaught ExtensionDependencyError".
Dec 4 2020, 11:40 AM ยท MediaWiki-Configuration, MediaWiki-Debug-Logger, User-RhinosF1

Nov 29 2020

Paladox edited P13460 (An Untitled Masterwork).
Nov 29 2020, 4:41 PM
Paladox created P13460 (An Untitled Masterwork).
Nov 29 2020, 4:40 PM

Nov 23 2020

Paladox placed T64570: WikiReportsLocalizations.pm still fetches language names from SVN up for grabs.
Nov 23 2020, 1:03 PM ยท Analytics, I18n, Analytics-Wikistats
Paladox placed T138919: Create intro/summary for Special:GlobalRenameUser up for grabs.
Nov 23 2020, 1:03 PM ยท Patch-Needs-Improvement, good first task, GlobalRename, MediaWiki-extensions-CentralAuth

Nov 22 2020

Paladox committed rESPR0d678abb4089: Forwards-compatibility fix to make CI happy (authored by ashley).
Forwards-compatibility fix to make CI happy
Nov 22 2020, 2:59 AM

Nov 19 2020

Paladox added a comment to T268260: URLs in format https://gerrit.wikimedia.org/r/123456 end up on port 80, leading to error SSL_ERROR_RX_RECORD_TOO_LONG.

Filed upstream at https://bugs.chromium.org/p/gerrit/issues/detail?id=13705

Nov 19 2020, 6:26 PM ยท Release-Engineering-Team (Development services), Upstream, Regression, Gerrit
Paladox created P13337 (An Untitled Masterwork).
Nov 19 2020, 4:40 PM
Paladox committed rGERRITDEPLOY601a73599f6e: Hide patch file download when the commit has multiple parents (authored by Frank Borden <frankborden@google.com>).
Hide patch file download when the commit has multiple parents
Nov 19 2020, 9:21 AM

Nov 16 2020

Paladox created T267964: ErrorException from line 796 of /srv/mediawiki/w/includes/session/SessionBackend.php: PHP Warning: session_id(): Cannot change session id when headers already sent.
Nov 16 2020, 7:08 PM ยท MediaWiki-Authentication-and-authorization, MediaWiki-General

Nov 12 2020

Paladox committed rEPRO389e6be1786f: Add support for MediaWiki 1.35 (authored by Paladox).
Add support for MediaWiki 1.35
Nov 12 2020, 2:13 PM

Nov 7 2020

Paladox created T267476: Fix showing error to user.
Nov 7 2020, 1:31 PM ยท MediaWiki-extensions-Cargo

Nov 4 2020

Paladox committed rGERRITDEPLOY4a597706963b: Add new preference "theme" (authored by Paladox).
Add new preference "theme"
Nov 4 2020, 9:35 PM
Paladox committed rGERRITDEPLOY87aa6beda06b: blame: Add base url to _getBlameForBaseLine (authored by Paladox).
blame: Add base url to _getBlameForBaseLine
Nov 4 2020, 9:35 PM
Paladox committed rGERRITDEPLOY6b055dcd60a3: Replace all 'this.fire' with 'this.dispatchEvent' for customEvents (authored by Paladox).
Replace all 'this.fire' with 'this.dispatchEvent' for customEvents
Nov 4 2020, 9:34 PM
Paladox committed rGERRITDEPLOY47c740cfc326: Fix setting PassiveTouchGestures (authored by Paladox).
Fix setting PassiveTouchGestures
Nov 4 2020, 9:34 PM
Paladox committed rGERRITDEPLOY6b774b5fed72: Fix toggle on iOS (authored by Paladox).
Fix toggle on iOS
Nov 4 2020, 9:34 PM
Paladox committed rGERRITDEPLOY72feff83a3cb: Fix searching in "included in" (authored by Paladox).
Fix searching in "included in"
Nov 4 2020, 9:32 PM
Paladox committed rGERRITDEPLOY1070e9383324: Require `semi` eslint option to error if ; is not at the end (authored by Paladox).
Require `semi` eslint option to error if ; is not at the end
Nov 4 2020, 9:31 PM
Paladox committed rGERRITDEPLOY933b64dbd38f: Remove contenteditable from #dragDropArea (authored by Paladox).
Remove contenteditable from #dragDropArea
Nov 4 2020, 9:31 PM

Oct 31 2020

Paladox added a comment to T266927: redis.log spammed with "worthRefreshPopular(1604102439.6853, 60, 900, 1604104011.4142): p = 0.0012121212121212; refresh = N".

I've changed the log level to warning, thanks! (figured that out after writing this).

Oct 31 2020, 2:58 PM ยท MediaWiki-Cache, MediaWiki-General
Paladox created T266927: redis.log spammed with "worthRefreshPopular(1604102439.6853, 60, 900, 1604104011.4142): p = 0.0012121212121212; refresh = N".
Oct 31 2020, 2:36 PM ยท MediaWiki-Cache, MediaWiki-General

Oct 28 2020

Paladox added a comment to T165885: Create a cron to clean clientbucket every day or hour.

+1'd

Oct 28 2020, 5:12 PM ยท cloud-services-team (Kanban), Cloud-Services, SRE, Puppet

Oct 27 2020

Paladox triaged T266619: $relPath is false inside thumb_handler.php as High priority.
Oct 27 2020, 10:51 PM ยท MW-1.35-notes, Platform Team Workboards (External Code Reviews), MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), MW-1.35-release, MediaWiki-General, User-RhinosF1
Paladox added a comment to T266619: $relPath is false inside thumb_handler.php.

https://github.com/miraheze/mediawiki/blob/REL1_35/includes/WebRequest.php#L240 returns true (hence why the overall return is false).

Oct 27 2020, 10:43 PM ยท MW-1.35-notes, Platform Team Workboards (External Code Reviews), MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), MW-1.35-release, MediaWiki-General, User-RhinosF1
Paladox added a parent task for T266619: $relPath is false inside thumb_handler.php: T235357: PHP Warning: preg_match(): Compilation failed: two named subpatterns have the same name at offset 62.
Oct 27 2020, 10:33 PM ยท MW-1.35-notes, Platform Team Workboards (External Code Reviews), MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), MW-1.35-release, MediaWiki-General, User-RhinosF1
Paladox added a subtask for T235357: PHP Warning: preg_match(): Compilation failed: two named subpatterns have the same name at offset 62: T266619: $relPath is false inside thumb_handler.php.
Oct 27 2020, 10:33 PM ยท MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-brennen, Platform Team Workboards (Clinic Duty Team), MediaWiki-General, Wikimedia-production-error
Paladox created T266619: $relPath is false inside thumb_handler.php.
Oct 27 2020, 10:33 PM ยท MW-1.35-notes, Platform Team Workboards (External Code Reviews), MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), MW-1.35-release, MediaWiki-General, User-RhinosF1

Oct 12 2020

Urfiner awarded T239734: Deprecated: Function Redis::lSize() is deprecated in /srv/mediawiki/w/includes/libs/redis/RedisConnRef.php on line 131 a Cup of Joe token.
Oct 12 2020, 11:39 AM ยท MW-1.34-notes, MW-1.32-notes, MW-1.31-release-notes, MW-1.33-notes, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MediaWiki-General

Oct 10 2020

Paladox renamed T264686: DismissionSiteNotice causes site notice to get wrapped from Using SitenoticeAfter hook, causes this extension to wrap the notice to DismissionSiteNotice causes site notice to get wrapped.
Oct 10 2020, 11:17 PM ยท Patch-For-Review, DismissableSiteNotice
Paladox added a comment to T264686: DismissionSiteNotice causes site notice to get wrapped.

@Jdlrobson updated description.

Oct 10 2020, 11:17 PM ยท Patch-For-Review, DismissableSiteNotice

Oct 5 2020

Paladox added a comment to T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook.

@Jdlrobson Is what it looks like now with (https://gerrit.wikimedia.org/r/631814) , which seems fine for now.

Oct 5 2020, 11:47 PM ยท MediaWiki-extensions-CookieWarning
Paladox added a comment to T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook.

@Jdlrobson disabling worked!

Oct 5 2020, 11:15 PM ยท MediaWiki-extensions-CookieWarning
Paladox added a comment to T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook.

@Jdlrobson done T264686.

Oct 5 2020, 11:08 PM ยท MediaWiki-extensions-CookieWarning
Paladox created T264686: DismissionSiteNotice causes site notice to get wrapped.
Oct 5 2020, 11:08 PM ยท Patch-For-Review, DismissableSiteNotice
Paladox added a comment to T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook.

Oh, I think your US based. Which we've switched it off for. I'll switch it on so you can see. Please try again. @Jdlrobson

Oct 5 2020, 10:54 PM ยท MediaWiki-extensions-CookieWarning
Paladox added a comment to T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook.

code is at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CookieWarning/+/631814/

Oct 5 2020, 10:31 PM ยท MediaWiki-extensions-CookieWarning
Paladox added a comment to T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook.

@Jdlrobson ah! Test url is https://test2.miraheze.org/w/index.php?title=Main_Page&mobileaction=toggle_view_mobile

Oct 5 2020, 10:30 PM ยท MediaWiki-extensions-CookieWarning
Paladox added a comment to T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook.

@Jdlrobson that looks nice! How was that managed (as in it spread out like that, and the "dismissible" button hidden?

Oct 5 2020, 9:36 PM ยท MediaWiki-extensions-CookieWarning
Paladox added a comment to T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook.

@Jdlrobson something like ^?

Oct 5 2020, 9:23 PM ยท MediaWiki-extensions-CookieWarning
Paladox added a comment to T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook.

@Jdlrobson I mean I am not sure if this looks nice

. Does this seem ok?

Oct 5 2020, 4:12 PM ยท MediaWiki-extensions-CookieWarning
Paladox added a comment to T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook.

@Jdlrobson thanks for the response! I found a replacement hook for the desktop version onSkinAfterContent, since it'll still shows the banner as if you did the code just under <body> though under MobileFrontend this shows in the footer thus this hook can only be used for the desktop. I've tried SiteNoticeAfterHook & SiteNoticeBeforeHook for mobile, the only issue is it displays where the site notice is, not at the top. Thus it's styles get lost (it's white the background, but because the background is already white it looks weird).

Oct 5 2020, 2:00 AM ยท MediaWiki-extensions-CookieWarning

Oct 4 2020

Paladox added a comment to T254302: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook.

@Jdlrobson Hi, I'm wondering if you know what hook this extension should migrate? I haven't been able to find a hook that allows you to insert into the header element.

Oct 4 2020, 2:27 AM ยท MediaWiki-extensions-CookieWarning

Oct 1 2020

Paladox updated the task description for T264368: Error while creating blog entries.
Oct 1 2020, 9:55 PM ยท User-RhinosF1, BlogPage, Social-Tools