Page MenuHomePhabricator

Paladox (Paladox)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 9:51 AM (490 w, 2 d)
Availability
Available
LDAP User
Paladox
MediaWiki User
Unknown

I live in the United Kingdom GMT/BST(UTC+0, UTC+1)

I have autism.

🇪🇺 🇬🇧

Recent Activity

Today

Paladox added a comment to T358762: Gerrit commit message formatting does not handle angle-bracketed URLs well, adds extra semicolon.

I believe gerrit 3.8 may fix the problem. It got rid of a library that had problems. Although I can't guarantee as I've only tested on master.

Thu, Feb 29, 1:59 PM · Gerrit
Paladox added a comment to T358762: Gerrit commit message formatting does not handle angle-bracketed URLs well, adds extra semicolon.

This is a upstream issue but testing on master it appears it's fixed.

Thu, Feb 29, 1:56 PM · Gerrit

Sat, Feb 17

Paladox committed rSANI0b73ef48d61e: Fix call to Language#convert, thus unbreaking CI (authored by ashley).
Fix call to Language#convert, thus unbreaking CI
Sat, Feb 17, 2:11 PM

Mon, Feb 12

Paladox added a comment to T357235: PHP Fatal Error from line 624 of /srv/mediawiki/1.41/vendor/wikimedia/parsoid/src/Config/Env.php: Allowed memory size of 1468006400 bytes exhausted.

I don't have any reproduction steps :/

Mon, Feb 12, 9:46 PM · Parsoid (Third-party)

Sun, Feb 11

Paladox committed rELOG1b0d11bee2af: Fix support for MW 1.41 (authored by Paladox).
Fix support for MW 1.41
Sun, Feb 11, 8:55 PM
Paladox committed rELOGfbbf55d35912: Fix support for MW 1.41 (authored by Paladox).
Fix support for MW 1.41
Sun, Feb 11, 5:02 PM
Paladox created T357235: PHP Fatal Error from line 624 of /srv/mediawiki/1.41/vendor/wikimedia/parsoid/src/Config/Env.php: Allowed memory size of 1468006400 bytes exhausted.
Sun, Feb 11, 4:42 PM · Parsoid (Third-party)

Sat, Feb 10

Paladox committed rELOG9659a555cdc9: Fix tests (authored by Paladox).
Fix tests
Sat, Feb 10, 10:48 PM
Paladox committed rELOGec0b69aa8df3: Fix tests (authored by Paladox).
Fix tests
Sat, Feb 10, 5:37 PM

Tue, Feb 6

Paladox added a comment to T355747: Gerrit: is:starred query fails with error since update to 3.7.6.

Also happening for me which is breaking my workflow - I can no longer even visually see starred changes in my code review queue.

Hrm, you only have 229 watched changes, so it should be below the 1024 limit. Are you seeing the too many items in queue thing?

I am also noticing a visual regression in my is:starred search where I don't see those starred changes as starred (and I only a few stars for testing).

Tue, Feb 6, 12:58 AM · Gerrit (Gerrit 3.7)

Sat, Feb 3

Paladox added a comment to T355619: Request MediaWiki +2 for Paladox.

I'd like to start off with a thank you for the nomination! To get into things I'd like to bring up my +2 rights on Gerrit-review that @Tgr mentions above. Whilst yes they aren't bleeding edge in the backend they are more so for the frontend. Users are more easily impacted if there was malicious code inside the frontend code. Not to mention people building or running it locally. A maintainer breaching trust would be huge and also have reputational damage especially as big companies use it such as Wikimedia and Volvo and more. I wouldn't go around merging anything I don't understand. (I show this on Gerrit-review).

Sat, Feb 3, 12:41 PM · MediaWiki-Gerrit-Group-Requests

Wed, Jan 31

Paladox added a comment to T355504: Gerrit commit not found.

Backported the fix to https://gerrit-review.googlesource.com/c/gerrit/+/405697

Wed, Jan 31, 9:04 PM · Release-Engineering-Team, Gerrit

Jan 25 2024

Paladox added a comment to T355816: Gerrit editor replaces tabs with spaces.

Seems the REST API is "indent_with_tabs" so it's true / false. So we would have to either create a new option to allow the three options above or if indent_with_tabs is true then always indent with tabs or if it's false check content for tabs otherwise use spaces.

Jan 25 2024, 9:15 PM · Upstream, Gerrit
Paladox added a comment to T355816: Gerrit editor replaces tabs with spaces.

I think a potential fix is detecting if there's tabs in the file and using that but also adding "auto" to the preference. So the preference will indicated what to do whether to check the file or force use of spaces/tabs.

Jan 25 2024, 9:08 PM · Upstream, Gerrit

Jan 22 2024

Paladox added a comment to T355561: Gerrit team dashboards no longer load.

I guess we just need to remove -is:ignored from the queries here: https://gerrit.wikimedia.org/r/plugins/gitiles/wikimedia/+/refs/meta/dashboards/teams/platform (and in a few other places)

I can do that.

@Paladox Do you know what these queries did previously, before the feature was removed?

Jan 22 2024, 4:10 PM · Gerrit (Gerrit 3.7)
Paladox added a comment to T355561: Gerrit team dashboards no longer load.

"ignored" needs to be removed. This was removed in gerrit 3.7.

Jan 22 2024, 4:00 PM · Gerrit (Gerrit 3.7)

Jan 11 2024

Paladox closed T288304: Syntaxhighlighting in Gerrit is broken on php here doc syntax as Resolved.

This is fixed.

Jan 11 2024, 11:29 AM · Gerrit
Paladox closed T292929: Gerrit project search result do not paginate correctly as Resolved.

Seems this is fixed as the next button is shown for me.

Jan 11 2024, 11:22 AM · Upstream, Gerrit
Paladox closed T308382: Error 500 (Server Error): Internal server error: Endpoint: /changes/*~*/comments as Resolved.

Seems this is fixed. I can’t reproduce at the url described in the description nor the other one described above.

Jan 11 2024, 11:17 AM · Gerrit (Gerrit 3.6)

Dec 19 2023

Paladox committed rELSR191eea8e0251: Fix "Passing null to parameter #1 ($string) of type string is deprecated" (authored by Paladox).
Fix "Passing null to parameter #1 ($string) of type string is deprecated"
Dec 19 2023, 5:38 AM
Paladox committed rELSR19c27dbd2cfe: Fix "Passing null to parameter #1 ($string) of type string is deprecated" (authored by Paladox).
Fix "Passing null to parameter #1 ($string) of type string is deprecated"
Dec 19 2023, 5:38 AM

Dec 18 2023

Paladox added a comment to T353644: PHP Deprecated: Creation of dynamic property Wikimedia\Parsoid\Html2Wt\SerializerState::$logType is deprecated.

There's also:

Dec 18 2023, 2:31 PM · MW-1.40-notes, PHP 8.2 support, Parsoid
Paladox added a project to T353644: PHP Deprecated: Creation of dynamic property Wikimedia\Parsoid\Html2Wt\SerializerState::$logType is deprecated: PHP 8.2 support.
Dec 18 2023, 2:07 PM · MW-1.40-notes, PHP 8.2 support, Parsoid
Paladox created T353644: PHP Deprecated: Creation of dynamic property Wikimedia\Parsoid\Html2Wt\SerializerState::$logType is deprecated.
Dec 18 2023, 2:07 PM · MW-1.40-notes, PHP 8.2 support, Parsoid
Paladox added a comment to T335847: 500 error when retrieving HTML from REST API.

I looked at the mediawiki-title library and it considers "/" as valid.

The log says that RESTBase is trying to reach {"internalURI"=>"http://localhost:6502/w/rest.php/cs.wiktionary.org/v3/page/pagebundle/%2F/1258994", "internalMethod"=>"get"} and getting HTTPError: 500: http_error
https://logstash.wikimedia.org/app/discover#/doc/0fade920-6712-11eb-8327-370b46f9e7a5/ecs-test-1-1.11.0-6-2023.20?id=tK2bL4gB_1-qnHEYGQy_

On scandium, executing NO_PROXY="" no_proxy="" curl -I --proxy scandium.eqiad.wmnet:80 http://cs.wiktionary.org/w/rest.php/cs.wiktionary.org/v3/page/pagebundle/%2F/1258994 returns HTTP/1.1 500 Internal Server Error

Without the -I it's an empty response. Locally, though, I'm able to get a response from that page.

The log for the 500 error says PHP Fatal Error: Allowed memory size of 1468006400 bytes exhausted (tried to allocate 53248 bytes)
https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-default-1-7.0.0-1-2023.05.18?id=BquqL4gBs53OSt3dH-Ic

So, it must be something about the content of that page that makes Parsoid quickly consume memory. Let's see.

Dec 18 2023, 12:44 PM · Parsoid, Content-Transform-Team-WIP, RESTBase-API, API Platform, Wikimedia Enterprise

Dec 15 2023

Paladox committed rELSR8a83e0f5ade3: Fix "Passing null to parameter #1 ($string) of type string is deprecated" (authored by Paladox).
Fix "Passing null to parameter #1 ($string) of type string is deprecated"
Dec 15 2023, 9:55 PM

Dec 13 2023

Paladox created T353398: PHP Deprecated: Creation of dynamic property MediaWiki\\Title\\Title::$isApprovable is deprecated.
Dec 13 2023, 11:20 PM · PHP 8.2 support, MediaWiki-extensions-Approved-Revs
Paladox closed T350615: Support ipv6 address or to bind to all (::) as Resolved.
Dec 13 2023, 4:26 PM · MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), MW-1.40-notes, MW-1.41-notes, MediaWiki-Platform-Team, PoolCounter

Dec 11 2023

Paladox triaged T353194: Fix support for firejail versions 0.9.72+ as High priority.
Dec 11 2023, 8:21 PM · MediaWiki-Shell
Paladox created T353194: Fix support for firejail versions 0.9.72+.
Dec 11 2023, 8:21 PM · MediaWiki-Shell

Nov 23 2023

Paladox closed T351900: ThumbnailRenderJob: sending a head request to a thumb in swift hangs until it hits the 1s timeout as Declined.

It was our http proxy.

Nov 23 2023, 7:34 PM · affects-Miraheze, MediaWiki-General
Paladox added a comment to T351900: ThumbnailRenderJob: sending a head request to a thumb in swift hangs until it hits the 1s timeout.

Commenting out this https://github.com/miraheze/mediawiki/blob/REL1_40/includes/http/GuzzleHttpRequest.php#L121 gets it working.

Nov 23 2023, 7:23 PM · affects-Miraheze, MediaWiki-General
Paladox added a comment to T351900: ThumbnailRenderJob: sending a head request to a thumb in swift hangs until it hits the 1s timeout.
> $test = new GuzzleHttpRequest( 'http://swift-lb.miraheze.org/sonicpediawiki/thumb/8/85/SX57_Knuckles_and_Cosmo.jpeg/800px-SX57_Knuckles_and_Cosmo.jpeg', [ 'method' => 'HEAD', 'timeout' => 1 ] );

> var_dump($test->getStatus());
int(200)

I forgot ->execute()

Nov 23 2023, 6:50 PM · affects-Miraheze, MediaWiki-General
Paladox added a comment to T351900: ThumbnailRenderJob: sending a head request to a thumb in swift hangs until it hits the 1s timeout.
> $test = new GuzzleHttpRequest( 'http://swift-lb.miraheze.org/sonicpediawiki/thumb/8/85/SX57_Knuckles_and_Cosmo.jpeg/800px-SX57_Knuckles_and_Cosmo.jpeg', [ 'method' => 'HEAD', 'timeout' => 1 ] );
Nov 23 2023, 6:34 PM · affects-Miraheze, MediaWiki-General
Paladox added a comment to T351900: ThumbnailRenderJob: sending a head request to a thumb in swift hangs until it hits the 1s timeout.

var_dump($response);

object(GuzzleHttp\Psr7\Response)#559 (6) {

["reasonPhrase":"GuzzleHttp\Psr7\Response":private]=>
string(2) "OK"
["statusCode":"GuzzleHttp\Psr7\Response":private]=>
int(200)
["headers":"GuzzleHttp\Psr7\Response":private]=>
array(12) {
  ["Content-Type"]=>
  array(1) {
    [0]=>
    string(10) "image/jpeg"
  }
  ["Content-Length"]=>
  array(1) {
    [0]=>
    string(5) "75995"
  }
  ["X-Object-Meta-Sha1Base36"]=>
  array(1) {
    [0]=>
    string(31) "09twibbekbm6a71x006eehab1hejxsj"
  }
  ["Content-Disposition"]=>
  array(1) {
    [0]=>
    string(57) "inline;filename*=UTF-8''SX57_Knuckles_and_Cosmo.jpeg.jpeg"
  }
  ["Etag"]=>
  array(1) {
    [0]=>
    string(32) "11a744edf44e10792d5bf56bd16c4b75"
  }
  ["Last-Modified"]=>
  array(1) {
    [0]=>
    string(29) "Sun, 05 Nov 2023 13:26:26 GMT"
  }
  ["X-Timestamp"]=>
  array(1) {
    [0]=>
    string(16) "1699190785.38844"
  }
  ["Accept-Ranges"]=>
  array(1) {
    [0]=>
    string(5) "bytes"
  }
  ["Access-Control-Allow-Origin"]=>
  array(1) {
    [0]=>
    string(1) "*"
  }
  ["X-Trans-Id"]=>
  array(1) {
    [0]=>
    string(34) "tx2b281b55765c4e90b2050-00655f92ce"
  }
  ["X-Openstack-Request-Id"]=>
  array(1) {
    [0]=>
    string(34) "tx2b281b55765c4e90b2050-00655f92ce"
  }
  ["Date"]=>
  array(1) {
    [0]=>
    string(29) "Thu, 23 Nov 2023 17:58:38 GMT"
  }
}
["headerNames":"GuzzleHttp\Psr7\Response":private]=>
array(12) {
  ["content-type"]=>
  string(12) "Content-Type"
  ["content-length"]=>
  string(14) "Content-Length"
  ["x-object-meta-sha1base36"]=>
  string(24) "X-Object-Meta-Sha1Base36"
  ["content-disposition"]=>
  string(19) "Content-Disposition"
  ["etag"]=>
  string(4) "Etag"
  ["last-modified"]=>
  string(13) "Last-Modified"
  ["x-timestamp"]=>
  string(11) "X-Timestamp"
  ["accept-ranges"]=>
  string(13) "Accept-Ranges"
  ["access-control-allow-origin"]=>
  string(27) "Access-Control-Allow-Origin"
  ["x-trans-id"]=>
  string(10) "X-Trans-Id"
  ["x-openstack-request-id"]=>
  string(22) "X-Openstack-Request-Id"
  ["date"]=>
  string(4) "Date"
}
["protocol":"GuzzleHttp\Psr7\Response":private]=>
string(3) "1.1"
["stream":"GuzzleHttp\Psr7\Response":private]=>
object(GuzzleHttp\Psr7\Stream)#556 (7) {
  ["stream":"GuzzleHttp\Psr7\Stream":private]=>
  resource(1229) of type (stream)
  ["size":"GuzzleHttp\Psr7\Stream":private]=>
  NULL
  ["seekable":"GuzzleHttp\Psr7\Stream":private]=>
  bool(true)
  ["readable":"GuzzleHttp\Psr7\Stream":private]=>
  bool(true)
  ["writable":"GuzzleHttp\Psr7\Stream":private]=>
  bool(true)
  ["uri":"GuzzleHttp\Psr7\Stream":private]=>
  string(10) "php://temp"
  ["customMetadata":"GuzzleHttp\Psr7\Stream":private]=>
  array(0) {
  }
}

}

Nov 23 2023, 5:59 PM · affects-Miraheze, MediaWiki-General
Paladox created T351900: ThumbnailRenderJob: sending a head request to a thumb in swift hangs until it hits the 1s timeout.
Nov 23 2023, 5:13 PM · affects-Miraheze, MediaWiki-General

Nov 22 2023

Paladox closed T350615: Support ipv6 address or to bind to all (::) as Resolved.
Nov 22 2023, 6:11 AM · MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), MW-1.40-notes, MW-1.41-notes, MediaWiki-Platform-Team, PoolCounter
Paladox committed rMSPC1b75315b3230: Add support for ipv6 (authored by Paladox).
Add support for ipv6
Nov 22 2023, 4:51 AM

Nov 7 2023

Paladox updated subscribers of T350696: Root jobs are stored in redis indefinite.
Nov 7 2023, 10:08 PM · API Platform, Patch-For-Review, MediaWiki-Core-JobQueue
Paladox created T350696: Root jobs are stored in redis indefinite.
Nov 7 2023, 3:26 PM · API Platform, Patch-For-Review, MediaWiki-Core-JobQueue

Nov 6 2023

Paladox created T350615: Support ipv6 address or to bind to all (::).
Nov 6 2023, 6:38 PM · MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), MW-1.40-notes, MW-1.41-notes, MediaWiki-Platform-Team, PoolCounter
Paladox updated subscribers of T350594: TypeError: DOMElement::setAttribute() expects parameter 2 to be string, null given .
Nov 6 2023, 5:14 PM · MW-1.39-notes, Parsoid
Paladox added a comment to T350600: Lots of parsoidCachePrewarm jobs are created, creating a huge backlog making it unsustainable.

for instance

Nov 6 2023, 4:51 PM · Parsoid (Third-party), User-RhinosF1, affects-Miraheze, MediaWiki-Core-JobQueue, Performance Issue
Paladox created T350600: Lots of parsoidCachePrewarm jobs are created, creating a huge backlog making it unsustainable.
Nov 6 2023, 4:48 PM · Parsoid (Third-party), User-RhinosF1, affects-Miraheze, MediaWiki-Core-JobQueue, Performance Issue
Paladox created T350594: TypeError: DOMElement::setAttribute() expects parameter 2 to be string, null given .
Nov 6 2023, 3:47 PM · MW-1.39-notes, Parsoid

Nov 4 2023

Paladox added a comment to T344189: array_merge_recursive inefficient on PHP 8.2 in HtmlForm.

I found a fix: https://github.com/miraheze/ManageWiki/commit/4fb5fd1a365b55889b632d11ed07239f2582c1bf. Not sure what changed in php 8.2 to require that. I saw on production:

Nov 4 2023, 3:27 PM · Performance Issue, MediaWiki-HTMLForm, PHP 8.2 support

Nov 1 2023

Paladox added a comment to T327007: 'file' HTMLForm inputs don't process required=>true correctly.

Looks like this is caused by https://github.com/wikimedia/mediawiki/commit/2b0b187bae8a42b4dca68a446ba5050bb7de6c50. Default value if not set is a null per getDefault(). Using 'default' => 'File' seemed to fix it but feel like it's a hack.

Nov 1 2023, 2:28 PM · MW-1.40-notes, MW-1.41-notes, MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), good first task, MediaWiki-HTMLForm
Paladox merged T350261: Bug with file type in HtmlForm - Prevents file being uploaded due to default value being null into T327007: 'file' HTMLForm inputs don't process required=>true correctly.
Nov 1 2023, 1:46 PM · MW-1.40-notes, MW-1.41-notes, MW-1.42-notes (1.42.0-wmf.10; 2023-12-19), good first task, MediaWiki-HTMLForm
Paladox merged task T350261: Bug with file type in HtmlForm - Prevents file being uploaded due to default value being null into T327007: 'file' HTMLForm inputs don't process required=>true correctly.
Nov 1 2023, 1:46 PM · MediaWiki-HTMLForm
Paladox created T350261: Bug with file type in HtmlForm - Prevents file being uploaded due to default value being null.
Nov 1 2023, 1:42 PM · MediaWiki-HTMLForm

Oct 26 2023

Paladox added a comment to T344189: array_merge_recursive inefficient on PHP 8.2 in HtmlForm.

We could revert https://github.com/wikimedia/mediawiki/commit/4727ed1a9ccb6c321e536f0249dafc1f4d160d88 until a fix is found?

Oct 26 2023, 4:31 PM · Performance Issue, MediaWiki-HTMLForm, PHP 8.2 support
Paladox added a comment to T344189: array_merge_recursive inefficient on PHP 8.2 in HtmlForm.

Found it. It's the type in loadInputFromParameters.

Switch from:

	public static function loadInputFromParameters( $fieldname, $descriptor,
		HTMLForm $parent = null
	)

to

	public static function loadInputFromParameters( $fieldname, $descriptor, $parent = null)

seems to fix it.

Oct 26 2023, 12:04 PM · Performance Issue, MediaWiki-HTMLForm, PHP 8.2 support
Paladox added a comment to T344189: array_merge_recursive inefficient on PHP 8.2 in HtmlForm.

Found it. It's the type in loadInputFromParameters.

Oct 26 2023, 11:52 AM · Performance Issue, MediaWiki-HTMLForm, PHP 8.2 support
Paladox added a comment to T344189: array_merge_recursive inefficient on PHP 8.2 in HtmlForm.

I can reproduce it on Special:Preferences.

Oct 26 2023, 1:09 AM · Performance Issue, MediaWiki-HTMLForm, PHP 8.2 support
Paladox added a comment to T344189: array_merge_recursive inefficient on PHP 8.2 in HtmlForm.

... And further I get to $descriptor['parent'] = $parent; (which the param passed is $this.

Oct 26 2023, 12:52 AM · Performance Issue, MediaWiki-HTMLForm, PHP 8.2 support

Oct 25 2023

Paladox added a comment to T344189: array_merge_recursive inefficient on PHP 8.2 in HtmlForm.

Even further, I got to $setSection[$fieldname] = $field;.

Oct 25 2023, 12:44 PM · Performance Issue, MediaWiki-HTMLForm, PHP 8.2 support
Paladox added a comment to T344189: array_merge_recursive inefficient on PHP 8.2 in HtmlForm.
Oct 25 2023, 12:14 PM · Performance Issue, MediaWiki-HTMLForm, PHP 8.2 support
Paladox added a comment to T344189: array_merge_recursive inefficient on PHP 8.2 in HtmlForm.

HTMLForm has been widely used in the core and many extensions, if the bug is only reproducible with interfaces created by the ManageWiki extension, there must be some unusual pattern in that extension.

Oct 25 2023, 11:59 AM · Performance Issue, MediaWiki-HTMLForm, PHP 8.2 support
Paladox added a comment to T344189: array_merge_recursive inefficient on PHP 8.2 in HtmlForm.

Digging, I can reproduce the OOM if I just do: error_log(print_r($loadedDescriptor, true));.

Oct 25 2023, 11:48 AM · Performance Issue, MediaWiki-HTMLForm, PHP 8.2 support
Paladox added a comment to T344189: array_merge_recursive inefficient on PHP 8.2 in HtmlForm.

What page(s) does this happen on reliably?

Oct 25 2023, 11:29 AM · Performance Issue, MediaWiki-HTMLForm, PHP 8.2 support
Paladox added a comment to T344189: array_merge_recursive inefficient on PHP 8.2 in HtmlForm.

Possibly. I think it's worth disabling the JIT (ie making sure that opcache.jit_buffer_size is unset or 0, which is the default) though just to rule it out as a cause—it's been known to cause oddball issues when it is enabled that simply do not occur when it is off, and its maintenance status in general is dubious.

Oct 25 2023, 1:33 AM · Performance Issue, MediaWiki-HTMLForm, PHP 8.2 support

Oct 22 2023

Paladox created T349444: Adding "betafeatures-auto-enroll" to wgHiddenPrefs causes an exception on Special:Preferences for some users.
Oct 22 2023, 1:40 PM · Patch-For-Review, BetaFeatures

Oct 18 2023

Paladox committed rEWSE2deaf813acab: Fix "Call to a member function transform() on bool" (authored by Paladox).
Fix "Call to a member function transform() on bool"
Oct 18 2023, 7:36 PM
Paladox committed rEWSE7bebb978967a: Fix "Call to a member function transform() on bool" (authored by Paladox).
Fix "Call to a member function transform() on bool"
Oct 18 2023, 7:32 PM
Paladox committed rEWSEd31148ebfe76: Fix "Call to a member function transform() on bool" (authored by Paladox).
Fix "Call to a member function transform() on bool"
Oct 18 2023, 7:32 PM
Paladox committed rEWSEacf14dfa7112: Fix "Call to a member function transform() on bool" (authored by Paladox).
Fix "Call to a member function transform() on bool"
Oct 18 2023, 7:16 PM

Aug 19 2023

Paladox committed rESPR327843012e75: UserRelationship: Fix "Call to undefined method User::getBoolOption()" (authored by Paladox).
UserRelationship: Fix "Call to undefined method User::getBoolOption()"
Aug 19 2023, 10:26 PM

Jul 2 2023

Paladox committed rESPRf1ab4e7f822a: Fix accessing wgDBname under 1.40 (authored by Paladox).
Fix accessing wgDBname under 1.40
Jul 2 2023, 7:00 PM
Paladox committed rESPR302ab5a7a3f6: Fix phan for WikiPage::factory (authored by Paladox).
Fix phan for WikiPage::factory
Jul 2 2023, 7:00 PM

Jun 28 2023

Paladox closed T340372: Custom Gerrit footer not displayed as Resolved.
Jun 28 2023, 2:02 PM · Regression, Gerrit

Jun 27 2023

Paladox committed rEWSEef17a6d7d26c: Fix using ExtensionDependencyError (authored by Paladox).
Fix using ExtensionDependencyError
Jun 27 2023, 12:59 PM
Paladox committed rEWSE621c73b41833: Fix using ExtensionDependencyError (authored by Paladox).
Fix using ExtensionDependencyError
Jun 27 2023, 12:58 PM
Paladox committed rEWSEa2ef5b71b2be: Fix using ExtensionDependencyError (authored by Paladox).
Fix using ExtensionDependencyError
Jun 27 2023, 12:25 PM

Jun 25 2023

Paladox added a comment to T340372: Custom Gerrit footer not displayed.

We do the customisation in https://github.com/wikimedia/operations-software-gerrit/blob/deploy/wmf/stable-3.5/plugins/wm-custom-links.js

Jun 25 2023, 1:05 PM · Regression, Gerrit

May 25 2023

Paladox committed rEBOP9b9bc6be5988: promote BoilerPlate files to top level (authored by Spage).
promote BoilerPlate files to top level
May 25 2023, 6:59 PM
Paladox committed rENBU7c89000d710d: Add npm entry point (authored by Paladox).
Add npm entry point
May 25 2023, 6:54 PM
Paladox committed rEPRZe3119b2c49d5: Add npm entry point (authored by Paladox).
Add npm entry point
May 25 2023, 6:53 PM
Paladox committed rEEUSc8de3a31eaf7: Autoload missing class EditUserPreferencesForm (authored by Paladox).
Autoload missing class EditUserPreferencesForm
May 25 2023, 5:58 PM
Paladox committed rEEUSc5ef7e39f500: Support npm and composer tests in EditUser (authored by Paladox).
Support npm and composer tests in EditUser
May 25 2023, 5:58 PM
Paladox committed rEEUSe3b0dcb4763e: Convert i18n to json format (authored by Paladox).
Convert i18n to json format
May 25 2023, 5:58 PM
Paladox committed rEEUS520354676971: Use __DIR__ instead (authored by Paladox).
Use __DIR__ instead
May 25 2023, 5:58 PM
Paladox committed rEEUSec906f667783: Bump version to 1.8.0 (authored by Paladox).
Bump version to 1.8.0
May 25 2023, 5:58 PM
Paladox committed rEEUSaf4f0029724a: Remove \r from i18n files (authored by Paladox).
Remove \r from i18n files
May 25 2023, 5:58 PM
Paladox committed rEEUS98a5a6aa575b: Add translatible name (authored by Paladox).
Add translatible name
May 25 2023, 5:58 PM
Paladox committed rEEUSe89d4ad4eae9: DO NOT MERGE: Test commit (authored by Translation updater bot <l10n-bot@translatewiki.net>).
DO NOT MERGE: Test commit
May 25 2023, 5:58 PM
Paladox committed rEEUS6dd6053b7c03: Revert "DO NOT MERGE: Test commit" (authored by Paladox).
Revert "DO NOT MERGE: Test commit"
May 25 2023, 5:58 PM
Paladox committed rEEUS6c2a9dd47f35: Update grunt-jscs to 2.1.0 (authored by Paladox).
Update grunt-jscs to 2.1.0
May 25 2023, 5:57 PM
Paladox committed rEEUS4c5b5e13ebc9: Add php code sniffer (authored by Paladox).
Add php code sniffer
May 25 2023, 5:57 PM
Paladox committed rEEUS1987918961f8: Remove deprecated $wgSpecialPageGroups (authored by Paladox).
Remove deprecated $wgSpecialPageGroups
May 25 2023, 5:57 PM
Paladox committed rEEUS8de739c75692: Remove \r in i18n files (authored by Paladox).
Remove \r in i18n files
May 25 2023, 5:57 PM
Paladox committed rEEUS6662a26688f7: Update packages (authored by Paladox).
Update packages
May 25 2023, 5:57 PM
Paladox committed rEEUSe54dfc24fa83: Update to match changes done in SpecialPreferences (authored by Paladox).
Update to match changes done in SpecialPreferences
May 25 2023, 5:57 PM
Paladox committed rEEUSa78aa59f56d2: Add extension.json, Remove php entry point (authored by Paladox).
Add extension.json, Remove php entry point
May 25 2023, 5:57 PM
Paladox committed rEEUS601a33ef27d0: Bump version to 1.9.0 (authored by Paladox).
Bump version to 1.9.0
May 25 2023, 5:57 PM

Mar 11 2023

Paladox committed rEWSEc2642380507f: Fix "Call to a member function transform() on bool" (authored by Paladox).
Fix "Call to a member function transform() on bool"
Mar 11 2023, 3:15 PM

Feb 5 2023

Paladox added a comment to T311703: Cherry pick to multiple branches.

The REST API is https://gerrit.wikimedia.org/r/Documentation/rest-api-changes.html#cherry-pick which takes as in put a CherryPickInput entity. It only supports a single branch.

That can surely be amended by committing some resource and time to get Gerrit to support that new feature. Then it is unlikely anyone at upstream would be interested in spending time on it (maybe @Paladox might?).

To explain a bit more why it might not be of much interest to them. The way upstream manage their stable branch is they do the fix on the earliest branch (REL1_35) then once reviewed and merged they merge the hotfixed stable branch to the other stable branches all the way up to their primary branch which results in something like:

* (master) merge REL1_38 into master
* (REL1_38) merge REL1_37 into REL1_38
| \
|  * (REL1_37) merge REL1_35 into REL1_37
|   \
|    * (REL1_35) Hotfix for issue 1234
...
* (master)

If the fix has first been proposed to the primary branch, it has to be moved to the earliest stable branch (ex: REL1_35) merged there and then it get merged back up. Or in short I don't think they cherry-pick.

That being said, a script can probably be written which would take a list of changes as parameter then issue the rest api querry to cherry-pick a change against each of the branches.

Feb 5 2023, 1:03 AM · Upstream, Gerrit

Jan 31 2023

Paladox closed T328100: CollapsibleVector extension not working properly with MediaWiki v1.39 as Resolved.
Jan 31 2023, 10:28 PM · MediaWiki-extensions-CollapsibleVector
Paladox added a comment to T315689: MWException: Error contacting the Parsoid/RESTBase server (HTTP 403): (no message) from DiscussionTools (on private wikis) – permalinks unavailable.

This is happening on 1.39 as well. I'm not sure which changes need to be backported as https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/829254 doesn't cleanly apply to the REL1_39 branch.

Jan 31 2023, 2:57 PM · Skipped QA, MW-1.40-notes (1.40.0-wmf.5; 2022-10-10), Editing-team (Kanban Board), DiscussionTools, Wikimedia-production-error

Jan 29 2023

Paladox added a comment to T297046: PHP 7.4 causes OOMs with Cargo extension.

Screenshot 2023-01-29 at 02.36.08.png (1×3 px, 455 KB)

Jan 29 2023, 2:36 AM · affects-Miraheze, MediaWiki-extensions-Cargo, Performance Issue, MediaWiki-General, PHP 7.4 support
Paladox added a comment to T297046: PHP 7.4 causes OOMs with Cargo extension.

To put it clearly it was @Universal_Omega who found it.

Jan 29 2023, 2:35 AM · affects-Miraheze, MediaWiki-extensions-Cargo, Performance Issue, MediaWiki-General, PHP 7.4 support