Page MenuHomePhabricator

Pastakhov (Pavel Astakhov)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2014, 4:46 AM (314 w, 1 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Pastakhov [ Global Accounts ]

Recent Activity

Sat, Oct 17

Vedmaka awarded T265753: Automatically add heading above <references/> tag if references exist a Like token.
Sat, Oct 17, 6:40 PM · Parsing-Team--ARCHIVED, Cite

Fri, Oct 16

Pastakhov updated the task description for T265753: Automatically add heading above <references/> tag if references exist.
Fri, Oct 16, 6:48 PM · Parsing-Team--ARCHIVED, Cite
Pastakhov created T265753: Automatically add heading above <references/> tag if references exist.
Fri, Oct 16, 6:42 PM · Parsing-Team--ARCHIVED, Cite

Sep 29 2020

Pastakhov added a comment to T106994: generateSitemap.php - Error: 1300 Invalid utf8 character string: 'F0A8AE'.

ALTER TABLE user CONVERT TO CHARACTER SET binary; helped me

Sep 29 2020, 5:45 PM · MediaWiki-Maintenance-system

Jul 9 2020

Pastakhov closed T249275: PhpTags tests fail on PHP74 as Resolved.

Fixed by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PhpTags/+/610343

Jul 9 2020, 9:09 AM · PHP 7.4 support, MediaWiki-extensions-PhpTags

Jul 5 2020

Pastakhov committed rEPFM8bfb422d1047: Ignore unregistered users with "current user" default value (authored by Pastakhov).
Ignore unregistered users with "current user" default value
Jul 5 2020, 3:06 PM

Jul 2 2020

Pastakhov committed rEPFMdab380b07d20: Fix textHighlight function (authored by Pastakhov).
Fix textHighlight function
Jul 2 2020, 6:52 PM

Apr 28 2020

Pastakhov added a comment to T249870: Create Action class for "action=mpdf".

done

Apr 28 2020, 10:42 AM · MediaWiki-extensions-Other

Apr 15 2020

Pastakhov added a comment to T249870: Create Action class for "action=mpdf".

I think it is a good idea, 1.0 :)
thanks for the contributions!

Apr 15 2020, 4:22 PM · MediaWiki-extensions-Other

Apr 10 2020

Pastakhov committed rEMPDafd77bcb5804: Put handling of "action=mpdf" into its own Action class (authored by Yaron_Koren).
Put handling of "action=mpdf" into its own Action class
Apr 10 2020, 1:42 PM
Pastakhov added a comment to T249870: Create Action class for "action=mpdf".

Hi Yaron, I saw it, just mark "Set Ready For Review" when they ready and I'll +2 them.
I get notifications about all new patches, but ping me if I don't answer for a long time. Unfortunately, sometimes I may not notice something, sorry

Apr 10 2020, 11:43 AM · MediaWiki-extensions-Other

Apr 8 2020

Pastakhov closed T249734: Add $wgMpdfSimpleOutput to Mpdf extension as Resolved.

I missed the patch, thanks for the ping

Apr 8 2020, 7:13 PM · MediaWiki-extensions-Other

Apr 6 2020

Pastakhov added a comment to T227479: Mpdf extension / Mpdf library outdated and causing errors and warnings.

yes, I'm one, I'll fix it when I get some time

Apr 6 2020, 9:49 AM · MediaWiki-extensions-Other

Apr 3 2020

Pastakhov claimed T249275: PhpTags tests fail on PHP74.
Apr 3 2020, 8:41 PM · PHP 7.4 support, MediaWiki-extensions-PhpTags

Mar 31 2020

Pastakhov added a comment to T94991: add support switch statement.

Hi, I still plan to work on this task

Mar 31 2020, 5:52 PM · MediaWiki-extensions-PhpTags
Pastakhov added a comment to T94879: Merge PhpTags Wiki, PhpTags Functions and PhpTags Widgets to PhpTags.

Hi, I still plan to work on this task

Mar 31 2020, 5:52 PM · MediaWiki-extensions-PhpTags

Feb 26 2020

Pastakhov committed rEPFM1dd8d720e870: Decode html entity in forminput parameters (authored by Pastakhov).
Decode html entity in forminput parameters
Feb 26 2020, 8:37 PM

Dec 20 2019

Pastakhov committed rEPFMcd476f9e56bb: Fix PFValuesUtils::getAllPagesForNamespace() for titles with single quote (authored by Pastakhov).
Fix PFValuesUtils::getAllPagesForNamespace() for titles with single quote
Dec 20 2019, 3:11 PM

Oct 24 2019

Pastakhov added a comment to T200653: Error undeleting page: IncompleteRevisionException: sha1 field must not be !.

The file was uploaded with empty Summary field, I tried to rename (move) another file that was loaded with empty Summary field and I got the error.
how it looks in the database:

mysql> SELECT t.* FROM page t WHERE page_id = 99;
+---------+----------------+-------------------+-------------------+------------------+-------------+----------------+----------------+-------------+----------+--------------------+--------------------+-----------+
| page_id | page_namespace | page_title        | page_restrictions | page_is_redirect | page_is_new | page_random    | page_touched   | page_latest | page_len | page_content_model | page_links_updated | page_lang |
+---------+----------------+-------------------+-------------------+------------------+-------------+----------------+----------------+-------------+----------+--------------------+--------------------+-----------+
|      99 |              6 | KarlMarxJeune.jpg |                   |                0 |           1 | 0.621428611495 | 20190113233540 |         281 |        0 | wikitext           | 20180410093726     | NULL      |
+---------+----------------+-------------------+-------------------+------------------+-------------+----------------+----------------+-------------+----------+--------------------+--------------------+-----------+
1 row in set (0.00 sec)
Oct 24 2019, 5:49 PM · MW-1.33-notes, MW-1.32-notes, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MW-1.31-release, MediaWiki-Revision-deletion, Multi-Content-Revisions

Oct 23 2019

Pastakhov added a comment to T200653: Error undeleting page: IncompleteRevisionException: sha1 field must not be !.

I just successfully moved the file page after I adding text on the page, I think you don't face the issue because, as usual, all files contain text on wikipedia's file pages

Oct 23 2019, 10:11 PM · MW-1.33-notes, MW-1.32-notes, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MW-1.31-release, MediaWiki-Revision-deletion, Multi-Content-Revisions
Pastakhov added a comment to T200653: Error undeleting page: IncompleteRevisionException: sha1 field must not be !.

debug info P9459

Oct 23 2019, 8:59 PM · MW-1.33-notes, MW-1.32-notes, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MW-1.31-release, MediaWiki-Revision-deletion, Multi-Content-Revisions
Pastakhov created P9459 T200653.
Oct 23 2019, 8:59 PM
Pastakhov added a comment to T200653: Error undeleting page: IncompleteRevisionException: sha1 field must not be !.

It seems this bug is not resolved yet.
I faced a similar problem on 1.33.0, when I'm trying to move page I got the error:

[0bff6a9515dc740c4d9e9790] /wr/index.php?title=Sp%C3%A9cial:Renommer_une_page&action=submit MediaWiki\Revision\IncompleteRevisionException from line 425 of /opt/mediawiki-1.33.1/includes/Revision/RevisionStore.php: sha1 field must not be ''!
Oct 23 2019, 8:41 PM · MW-1.33-notes, MW-1.32-notes, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MW-1.31-release, MediaWiki-Revision-deletion, Multi-Content-Revisions

Oct 12 2019

Pastakhov committed rEMMA2a663b9de3a3: Merge with branch master (authored by Pastakhov).
Merge with branch master
Oct 12 2019, 8:40 PM
Pastakhov committed rEMMA125a839a753c: Merge with branch master (authored by Pastakhov).
Merge with branch master
Oct 12 2019, 8:40 PM
Pastakhov committed rEMMAe7952715e36b: Merge with branch master (authored by Pastakhov).
Merge with branch master
Oct 12 2019, 8:40 PM

May 28 2019

stjn awarded T174811: Support JavaScript hook events for CodeMirror a Like token.
May 28 2019, 4:40 PM · Patch-For-Review, MediaWiki-extensions-CodeMirror

Mar 4 2019

Pastakhov committed rEPRL0978c98d91af: Fix mistakes in i18n files (authored by Pastakhov).
Fix mistakes in i18n files
Mar 4 2019, 8:32 AM

Jan 23 2019

Pastakhov committed rEPRLf5be4002641e: Initial commit (authored by tosfos).
Initial commit
Jan 23 2019, 10:10 PM
Pastakhov committed rEPRLc69416b87b08: Initial commit (authored by tosfos).
Initial commit
Jan 23 2019, 9:51 PM
Pastakhov committed rEPRL6df5c9169a51: Initial commit (authored by tosfos).
Initial commit
Jan 23 2019, 9:37 PM
Pastakhov committed rEPRL5ecf03767435: Initial commit (authored by tosfos).
Initial commit
Jan 23 2019, 9:29 PM
Pastakhov committed rEPRLb0b0293ac4a4: Initial commit (authored by tosfos).
Initial commit
Jan 23 2019, 9:17 PM
Pastakhov committed rEPRL813d5b815a53: Initial commit (authored by tosfos).
Initial commit
Jan 23 2019, 9:03 PM
Pastakhov committed rEPRL867b200897de: Initial commit (authored by tosfos).
Initial commit
Jan 23 2019, 8:53 PM
Pastakhov committed rEPRLa08dacb65548: Initial commit (authored by tosfos).
Initial commit
Jan 23 2019, 8:42 PM
Pastakhov committed rEPRL4feff47afac6: Initial commit (authored by tosfos).
Initial commit
Jan 23 2019, 1:12 PM
Pastakhov committed rEPRL77c39fe4560d: Initial commit (authored by tosfos).
Initial commit
Jan 23 2019, 1:09 PM
Pastakhov committed rEPRL7f0d755832a9: Initial commit (authored by tosfos).
Initial commit
Jan 23 2019, 12:04 PM
Pastakhov committed rEPRLf30e0212c980: Initial commit (authored by tosfos).
Initial commit
Jan 23 2019, 12:04 PM

Jul 6 2018

Pastakhov added a comment to T69074: indigo-depict sometimes fails for mysterious reasons outputting an empty SVG.

after increasing memory to 204800 and restarting apache, it no more failed thumbnails for that reason -- still needs investigation

Jul 6 2018, 6:30 PM · MediaWiki-extensions-MolHandler

Jun 25 2018

Pastakhov added a comment to T188585: PhpTags tests fail on PHP 7.0.

There is a few more errors because PHP 7.1 is more strictly related to the type of data, it is good but I need to process these incidents inside phptags too,
for example
php5.5 php7.0:
["4"] & "fff"; is ok
php 7.1
["4"] & "fff";

PHP Warning:  A non-numeric value encountered in Command line code on line 1
Jun 25 2018, 5:59 PM · Platform Team Workboards (Done with CPT), Patch-For-Review, Platform Engineering (PHP7 (TEC4)), PHP 7.0 support, MediaWiki-extensions-PhpTags
Pastakhov added a comment to T188585: PhpTags tests fail on PHP 7.0.

@hashar, thanks for looking at the failures. I debugged the problem, it happens because PHP 7 assigns the values in the list operator in reverted order (link).
I'll fix it soon

Jun 25 2018, 2:08 AM · Platform Team Workboards (Done with CPT), Patch-For-Review, Platform Engineering (PHP7 (TEC4)), PHP 7.0 support, MediaWiki-extensions-PhpTags

May 29 2018

Pastakhov added a comment to T188523: Mpdf extension fails PHP 7.0 lint.

please, check it https://gerrit.wikimedia.org/r/#/c/435971/

May 29 2018, 7:56 AM · Patch-For-Review, PHP 7.0 support, MediaWiki-extensions-Other

May 28 2018

Pastakhov added a comment to T188523: Mpdf extension fails PHP 7.0 lint.

Oh, sorry for delay, I try to update it right now

May 28 2018, 5:33 PM · Patch-For-Review, PHP 7.0 support, MediaWiki-extensions-Other

Jan 31 2018

Pastakhov added a comment to T108447: Files with links in caption not highlighted correctly.

Oh, sorry. I got hard busy... I hope to continue in 2-3 weeks :-/

Jan 31 2018, 4:00 AM · MediaWiki-extensions-CodeMirror

Jan 10 2018

MichaelSchoenitzer awarded T95104: Fix the default browser spellcheck functionality, or integrate a spell checker to CodeMirror a Love token.
Jan 10 2018, 1:32 AM · Community-Tech, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), User-notice, Patch-For-Review, MediaWiki-extensions-CodeMirror

Oct 4 2017

Pastakhov added a comment to T174145: Use more individual icon than pencil.

! In T174145#3652265, @kaldari wrote:
Note that we have to use an OOjs-UI icon for syntax highlighting within the 2017 Wikitext editor. That interface is constructed using OOjs-UI, so the only choices we have are the icons in https://github.com/wikimedia/oojs-ui/tree/master/src/themes/wikimediaui/images/icons.

Oct 4 2017, 3:44 PM · UI-Standardization, Design, MediaWiki-extensions-CodeMirror

Oct 2 2017

Pastakhov added a comment to T174145: Use more individual icon than pencil.

looks like a virus :)

Oct 2 2017, 11:10 AM · UI-Standardization, Design, MediaWiki-extensions-CodeMirror

Sep 27 2017

RandomDSdevel awarded T95104: Fix the default browser spellcheck functionality, or integrate a spell checker to CodeMirror a Piece of Eight token.
Sep 27 2017, 8:14 PM · Community-Tech, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), User-notice, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov closed T174830: Home and End keys behave differently in CodeMirror as Resolved.
Sep 27 2017, 4:01 AM · Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov closed T174514: 'End' key doesn't respect soft wrap as Resolved.
Sep 27 2017, 4:01 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror

Sep 26 2017

Pastakhov claimed T176685: Update CodeMirror extension to CodeMirror library 5.30.
Sep 26 2017, 3:08 AM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Community-Tech, MediaWiki-extensions-CodeMirror

Sep 11 2017

Pastakhov claimed T175378: Word jumping (option+arrow key) doesn't work in CodeMirror for regular wikitext editor.

Seems should be fixed. Should be used different keyMaps for Mac and PC.

Sep 11 2017, 4:14 PM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T174514: 'End' key doesn't respect soft wrap.

the path was rebased to the latest version of CodeMirror where the mentioned bug is fixed.

Sep 11 2017, 3:10 PM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror

Sep 10 2017

Pastakhov placed T175378: Word jumping (option+arrow key) doesn't work in CodeMirror for regular wikitext editor up for grabs.
Sep 10 2017, 9:05 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov reopened T175378: Word jumping (option+arrow key) doesn't work in CodeMirror for regular wikitext editor as "Open".

The status was changed by mistake... I did not want to do it by myself

Sep 10 2017, 9:05 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov closed T175378: Word jumping (option+arrow key) doesn't work in CodeMirror for regular wikitext editor as Resolved.

ctrl + arrow key still working. Change 373624 makes behavior of alt + arrow key the same as when textarea used, see bug T174055.

Sep 10 2017, 9:02 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror

Sep 8 2017

Pastakhov added a comment to T174830: Home and End keys behave differently in CodeMirror.

Home / End keys cumbersome behavior

Sep 8 2017, 7:41 AM · Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov claimed T170906: CodeMirror textarea is non-expandable.

I think there should not be a big problem to make it resizable, and there should not be a problem with performance. I'll try to fix it.

Sep 8 2017, 4:14 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror

Sep 5 2017

Pastakhov added a comment to T175007: Not possible to disable Syntax highlighter beta from the Beta panel in the preferences.

can't reproduce on en.wikipedia.org

Sep 5 2017, 1:32 PM · Community-Tech, MediaWiki-extensions-CodeMirror, BetaFeatures
Pastakhov added a comment to T174480: Browser Ctrl-F search can't search text outside of current view.

@Niharika yes, I understand about cost. I would prefer to find a balance between speed and ease of use.

Sep 5 2017, 3:54 AM · Community-Tech, Patch-For-Review, WikiEditor, MediaWiki-extensions-CodeMirror

Sep 4 2017

Pastakhov claimed T174731: Bump CodeMirror to latest version.
Sep 4 2017, 4:26 PM · Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov claimed T174811: Support JavaScript hook events for CodeMirror.
Sep 4 2017, 10:19 AM · Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov claimed T174547: Wrong cursor position after extension loads.
Sep 4 2017, 10:19 AM · Community-Tech, MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov claimed T174514: 'End' key doesn't respect soft wrap.
Sep 4 2017, 10:18 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov claimed T170238: Highlight void tags and other tags correctly.
Sep 4 2017, 10:16 AM · Community-Tech, MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T174323: LintErrors conflicts with SyntaxHighlighter.

Seems should be fixed with T174547

Sep 4 2017, 10:15 AM · Community-Tech, MediaWiki-extensions-CodeMirror, MediaWiki-Special-pages, MediaWiki-extensions-Linter
Pastakhov closed T174055: CodeMirror should not redefine Alt+Left and Alt+Right as Resolved.
Sep 4 2017, 9:07 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T174830: Home and End keys behave differently in CodeMirror.

Should be merged with T174514

Sep 4 2017, 8:17 AM · Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T174514: 'End' key doesn't respect soft wrap.

There is a bug: Home after End goes to the start of the next wrapped line. Hopefully it was fixed in latest CodeMirror library.

Sep 4 2017, 8:15 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T174514: 'End' key doesn't respect soft wrap.

Solution is Better Home/End navigation with wrapped lines? #1576

Sep 4 2017, 8:09 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T174635: Middle-click to paste text doesn't work in CodeMirror on Linux.

The bug in the CodeMirror library Paste by using middle click in firefox not working #931

Sep 4 2017, 7:32 AM · Upstream, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T174480: Browser Ctrl-F search can't search text outside of current view.

Maybe try to set viewportMargin to Infinity when ctrl+F pressed?

Sep 4 2017, 6:40 AM · Community-Tech, Patch-For-Review, WikiEditor, MediaWiki-extensions-CodeMirror

Sep 3 2017

Pastakhov added a comment to T174811: Support JavaScript hook events for CodeMirror.

As a variant the patch above calls the CodeMirror.enabled and CodeMirror.disabled hooks.
Catching ones gets you full access to the CodeMirror features.
For example, alert message when the text is changed:

mediaWiki.hook( 'CodeMirror.enabled' ).add( 
    function ( cm ) { 
        cm.on( 'change', function() { 
            alert ( 'text changed' ); 
        } );
    } 
);

It used event change of CodeMirror.

Sep 3 2017, 1:11 PM · Patch-For-Review, MediaWiki-extensions-CodeMirror

Aug 29 2017

Dvorapa awarded T163533: Add different color themes of syntax highlighting a Love token.
Aug 29 2017, 7:13 PM · MediaWiki-extensions-CodeMirror

Aug 26 2017

Marsupium awarded T95104: Fix the default browser spellcheck functionality, or integrate a spell checker to CodeMirror a Like token.
Aug 26 2017, 3:26 AM · Community-Tech, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), User-notice, Patch-For-Review, MediaWiki-extensions-CodeMirror

Aug 23 2017

Pastakhov added a comment to T172470: Remove $wgCodeMirrorEnableFrontend.

Not sure for what the one was added by change 199941.

Aug 23 2017, 5:33 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Community-Tech, MediaWiki-extensions-CodeMirror

Aug 20 2017

Pastakhov added a comment to T108447: Files with links in caption not highlighted correctly.

@Niharika I'm on a trip until September

Aug 20 2017, 1:51 PM · MediaWiki-extensions-CodeMirror

Aug 8 2017

Pastakhov added a comment to T172632: CodeMirror breaks NWE on labs: "TypeError: mwConfig is null".

Can't reproduce on en.wikipedia.beta.wmflabs.org

Aug 8 2017, 3:13 AM · Community-Tech, VisualEditor-MediaWiki-2017WikitextEditor, Beta-Cluster-reproducible, MediaWiki-extensions-CodeMirror, VisualEditor

Aug 4 2017

Pastakhov updated the task description for T172500: Allow to add buttons with undefined icons..
Aug 4 2017, 9:43 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), WikiEditor, MediaWiki-extensions-CodeMirror
Pastakhov updated the task description for T172500: Allow to add buttons with undefined icons..
Aug 4 2017, 9:38 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), WikiEditor, MediaWiki-extensions-CodeMirror
Pastakhov created T172500: Allow to add buttons with undefined icons..
Aug 4 2017, 9:35 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), WikiEditor, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T172458: CodeMirror must not embed 5KB of config on every page view.

The bug described above happens on FF. Since WikiEditor does not designed to work with changeable icons, the one requires the icon defined when initializing. Because we use other approach to define the icons, WikiEditor inserts style to the button style="background-image: url(&quot;undefined&quot;);".
Despite the fact that it is removed later, FF trying load undefined background any case .

Aug 4 2017, 9:20 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), Patch-For-Review, Regression, Performance-Team, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T172458: CodeMirror must not embed 5KB of config on every page view.

Possibly there is one other problem, I see the requests to /w/undefined when CodeMirror is enabled. Maybe problem is only on my test wiki, please check it on before the wide-scale deployment.

Aug 4 2017, 7:48 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), Patch-For-Review, Regression, Performance-Team, MediaWiki-extensions-CodeMirror

Aug 3 2017

Pastakhov created T172369: Error when run maintenance/FlowSearchConfig.php.
Aug 3 2017, 9:54 AM · Growth-Team, StructuredDiscussions, Collaboration-Team-Triage

Jul 25 2017

Pastakhov added a comment to T170001: Support CodeMirror syntax highlighting on RTL wikis.

@Niharika It is easier to install the extension without composer usage and maybe when I created the extension composer was not widely used for mediawiki extensions (not sure).

Jul 25 2017, 5:18 AM · Upstream, I18n, RTL, MediaWiki-extensions-CodeMirror

Jul 21 2017

Pastakhov added a comment to T170001: Support CodeMirror syntax highlighting on RTL wikis.

@Niharika Maybe it is possible by process event:

"cursorActivity" (instance: CodeMirror)
    Will be fired when the cursor or selection moves, or any change is made to the editor content.
Jul 21 2017, 11:05 AM · Upstream, I18n, RTL, MediaWiki-extensions-CodeMirror

Jul 20 2017

Pastakhov added a comment to T171074: HTML comment next to a heading disables heading highlighting.

There are two problems:

  1. font size can be changed only for whole line and big comments looks ugly for me.
  2. processing comments required some optimizations of tokenizer, it should be able to change type of previous tokens without processing all next tokens again.
Jul 20 2017, 4:53 AM · MediaWiki-extensions-CodeMirror

Jul 18 2017

Pastakhov added a comment to T92826: Ready-to-use Docker package for MediaWiki.

Take a look at my solution, maybe you'll find there something useful.
https://github.com/pastakhov/compose-mediawiki-ubuntu

Jul 18 2017, 9:25 AM · Wikimania-Hackathon-2017, Services (doing), User-mobrovac, MediaWiki-Containers, MediaWiki-Releasing, Wikimedia-Hackathon-2015

Jul 11 2017

Pastakhov added a comment to T170056: Exception in module-execute in module ext.CodeMirror.

Seems there is a hook that are called when Toolbar initialized, I am not sure...

Jul 11 2017, 3:37 PM · Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov closed T170130: CodeMirror should use only the content language, not the user language as Resolved.
Jul 11 2017, 8:38 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T108450: Highlighting broken in complicated templates.

Thanks for nice links ;-)

Jul 11 2017, 8:35 AM · Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T170240: Highlight keywords in file syntax.

Yes, actually it is one task - make parser for [[File:...]]. One is parsed as a link still.

Jul 11 2017, 8:31 AM · MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T170187: Move Code Mirror's Mediawiki Mode into a separate library.

Wikitext syntax highlighting depend on mediawiki settings such as site language, extension installed and etc.
Thus it is not possible to make a general mediawiki mode аnd in the future this dependence will only increase.

Jul 11 2017, 3:25 AM · Librarization, MediaWiki-extensions-CodeMirror

Jul 10 2017

Pastakhov updated the task description for T170130: CodeMirror should use only the content language, not the user language.
Jul 10 2017, 11:01 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), MediaWiki-extensions-CodeMirror
Pastakhov created T170130: CodeMirror should use only the content language, not the user language.
Jul 10 2017, 10:34 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), MediaWiki-extensions-CodeMirror
Pastakhov added a project to T170004: Syntax Highlighting: Translated magic words aren't recognized in Hebrew: MediaWiki-extensions-CodeMirror.
Jul 10 2017, 10:29 AM · I18n, RTL, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T170004: Syntax Highlighting: Translated magic words aren't recognized in Hebrew.

@IKhitron, It does not work since there are only part of language aliases (localized magic words).
And as I wrote, I have no idea why there are only part of them.
In any case this behavior is a bug, CodeMirror should use only language from $wgLanguageCode and it will be fixed soon.
For check localized magic words you should set $wgLanguageCode to corresponded value or use the CodeMirror extension on wiki with $wgLanguageCode have corresponded value (it's no joke).

Jul 10 2017, 10:20 AM · I18n, RTL, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T170004: Syntax Highlighting: Translated magic words aren't recognized in Hebrew.

I found other way - add uselang parameter to url, but it is more a bag that a feature (and should be fixed)
For example https://test.wikipedia.org/w/index.php?title=Pride_and_Prejudice&action=edit&oldid=323245&uselang=de
Or change it by language toolbar at the top of page. But in this case I see only part of language aliases.
Have no idea why.

Jul 10 2017, 8:25 AM · I18n, RTL, MediaWiki-extensions-CodeMirror