Pastakhov (Pavel Astakhov)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2014, 4:46 AM (169 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Pastakhov

Recent Activity

Wed, Jan 10

MichaelSchoenitzer awarded T95104: Fix the default browser spellcheck functionality, or integrate a spell checker to CodeMirror a Love token.
Wed, Jan 10, 1:32 AM · Community-Tech, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), User-notice, Patch-For-Review, MediaWiki-extensions-CodeMirror

Oct 4 2017

Pastakhov added a comment to T174145: Use more individual icon than pencil.

! In T174145#3652265, @kaldari wrote:
Note that we have to use an OOjs-UI icon for syntax highlighting within the 2017 Wikitext editor. That interface is constructed using OOjs-UI, so the only choices we have are the icons in https://github.com/wikimedia/oojs-ui/tree/master/src/themes/wikimediaui/images/icons.

Oct 4 2017, 3:44 PM · Community-Tech, MediaWiki-extensions-CodeMirror

Oct 2 2017

Pastakhov added a comment to T174145: Use more individual icon than pencil.

looks like a virus :)

Oct 2 2017, 11:10 AM · Community-Tech, MediaWiki-extensions-CodeMirror

Sep 27 2017

RandomDSdevel awarded T95104: Fix the default browser spellcheck functionality, or integrate a spell checker to CodeMirror a Piece of Eight token.
Sep 27 2017, 8:14 PM · Community-Tech, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), User-notice, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov closed T174830: Home and End keys behave differently in CodeMirror as Resolved.
Sep 27 2017, 4:01 AM · Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov closed T174514: 'End' key doesn't respect soft wrap as Resolved.
Sep 27 2017, 4:01 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror

Sep 26 2017

Pastakhov claimed T176685: Update CodeMirror extension to CodeMirror library 5.30.
Sep 26 2017, 3:08 AM · MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, Community-Tech, MediaWiki-extensions-CodeMirror

Sep 11 2017

Pastakhov claimed T175378: Word jumping (option+arrow key) doesn't work in CodeMirror for regular wikitext editor.

Seems should be fixed. Should be used different keyMaps for Mac and PC.

Sep 11 2017, 4:14 PM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T174514: 'End' key doesn't respect soft wrap.

the path was rebased to the latest version of CodeMirror where the mentioned bug is fixed.

Sep 11 2017, 3:10 PM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror

Sep 10 2017

Pastakhov placed T175378: Word jumping (option+arrow key) doesn't work in CodeMirror for regular wikitext editor up for grabs.
Sep 10 2017, 9:05 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov reopened T175378: Word jumping (option+arrow key) doesn't work in CodeMirror for regular wikitext editor as "Open".

The status was changed by mistake... I did not want to do it by myself

Sep 10 2017, 9:05 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov closed T175378: Word jumping (option+arrow key) doesn't work in CodeMirror for regular wikitext editor as Resolved.

ctrl + arrow key still working. Change 373624 makes behavior of alt + arrow key the same as when textarea used, see bug T174055.

Sep 10 2017, 9:02 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror

Sep 8 2017

Pastakhov added a comment to T174830: Home and End keys behave differently in CodeMirror.

Home / End keys cumbersome behavior

Sep 8 2017, 7:41 AM · Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov claimed T170906: CodeMirror textarea is non-expandable.

I think there should not be a big problem to make it resizable, and there should not be a problem with performance. I'll try to fix it.

Sep 8 2017, 4:14 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror

Sep 5 2017

Pastakhov added a comment to T175007: Not possible to disable Syntax highlighter beta from the Beta panel in the preferences.

can't reproduce on en.wikipedia.org

Sep 5 2017, 1:32 PM · Community-Tech, MediaWiki-extensions-CodeMirror, BetaFeatures
Pastakhov added a comment to T174480: Browser Ctrl-F search can't search text outside of current view.

@Niharika yes, I understand about cost. I would prefer to find a balance between speed and ease of use.

Sep 5 2017, 3:54 AM · Community-Tech, Patch-For-Review, WikiEditor, MediaWiki-extensions-CodeMirror

Sep 4 2017

Pastakhov claimed T174731: Bump CodeMirror to latest version.
Sep 4 2017, 4:26 PM · Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov claimed T174811: Support JavaScript hook events for CodeMirror.
Sep 4 2017, 10:19 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov claimed T174547: Wrong cursor position after extension loads.
Sep 4 2017, 10:19 AM · Community-Tech, MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov claimed T174514: 'End' key doesn't respect soft wrap.
Sep 4 2017, 10:18 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov claimed T170238: Highlight void tags and other tags correctly.
Sep 4 2017, 10:16 AM · Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T174323: LintErrors conflicts with SyntaxHighlighter.

Seems should be fixed with T174547

Sep 4 2017, 10:15 AM · Community-Tech, MediaWiki-extensions-CodeMirror, MediaWiki-Special-pages, MediaWiki-extensions-Linter
Pastakhov closed T174055: CodeMirror should not redefine Alt+Left and Alt+Right as Resolved.
Sep 4 2017, 9:07 AM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T174830: Home and End keys behave differently in CodeMirror.

Should be merged with T174514

Sep 4 2017, 8:17 AM · Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T174514: 'End' key doesn't respect soft wrap.

There is a bug: Home after End goes to the start of the next wrapped line. Hopefully it was fixed in latest CodeMirror library.

Sep 4 2017, 8:15 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T174514: 'End' key doesn't respect soft wrap.

Solution is Better Home/End navigation with wrapped lines? #1576

Sep 4 2017, 8:09 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T174635: Middle-click to paste text doesn't work in CodeMirror on Linux.

The bug in the CodeMirror library Paste by using middle click in firefox not working #931

Sep 4 2017, 7:32 AM · MediaWiki-extensions-CodeMirror, Community-Tech
Pastakhov added a comment to T174480: Browser Ctrl-F search can't search text outside of current view.

Maybe try to set viewportMargin to Infinity when ctrl+F pressed?

Sep 4 2017, 6:40 AM · Community-Tech, Patch-For-Review, WikiEditor, MediaWiki-extensions-CodeMirror

Sep 3 2017

Pastakhov added a comment to T174811: Support JavaScript hook events for CodeMirror.

As a variant the patch above calls the CodeMirror.enabled and CodeMirror.disabled hooks.
Catching ones gets you full access to the CodeMirror features.
For example, alert message when the text is changed:

mediaWiki.hook( 'CodeMirror.enabled' ).add( 
    function ( cm ) { 
        cm.on( 'change', function() { 
            alert ( 'text changed' ); 
        } );
    } 
);

It used event change of CodeMirror.

Sep 3 2017, 1:11 PM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror

Aug 29 2017

Dvorapa awarded T163533: Add different color themes of syntax highlighting a Love token.
Aug 29 2017, 7:13 PM · Community-Tech, MediaWiki-extensions-CodeMirror

Aug 26 2017

Marsupium awarded T95104: Fix the default browser spellcheck functionality, or integrate a spell checker to CodeMirror a Like token.
Aug 26 2017, 3:26 AM · Community-Tech, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), User-notice, Patch-For-Review, MediaWiki-extensions-CodeMirror

Aug 23 2017

Pastakhov added a comment to T172470: Remove $wgCodeMirrorEnableFrontend.

Not sure for what the one was added by change 199941.

Aug 23 2017, 5:33 PM · MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, Community-Tech, MediaWiki-extensions-CodeMirror

Aug 20 2017

Pastakhov added a comment to T108447: Files with links in caption not highlighted correctly.

@Niharika I'm on a trip until September

Aug 20 2017, 1:51 PM · Community-Tech, MediaWiki-extensions-CodeMirror

Aug 8 2017

Pastakhov added a comment to T172632: CodeMirror breaks NWE on labs: "TypeError: mwConfig is null".

Can't reproduce on en.wikipedia.beta.wmflabs.org

Aug 8 2017, 3:13 AM · VisualEditor-MediaWiki-2017WikitextEditor, Beta-Cluster-reproducible, VisualEditor, MediaWiki-extensions-CodeMirror

Aug 4 2017

Pastakhov updated the task description for T172500: Allow to add buttons with undefined icons..
Aug 4 2017, 9:43 AM · MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), WikiEditor, MediaWiki-extensions-CodeMirror
Pastakhov updated the task description for T172500: Allow to add buttons with undefined icons..
Aug 4 2017, 9:38 AM · MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), WikiEditor, MediaWiki-extensions-CodeMirror
Pastakhov created T172500: Allow to add buttons with undefined icons..
Aug 4 2017, 9:35 AM · MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), WikiEditor, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T172458: CodeMirror must not embed 5KB of config on every page view.

The bug described above happens on FF. Since WikiEditor does not designed to work with changeable icons, the one requires the icon defined when initializing. Because we use other approach to define the icons, WikiEditor inserts style to the button style="background-image: url("undefined");".
Despite the fact that it is removed later, FF trying load undefined background any case .

Aug 4 2017, 9:20 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), Patch-For-Review, Regression, Performance-Team, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T172458: CodeMirror must not embed 5KB of config on every page view.

Possibly there is one other problem, I see the requests to /w/undefined when CodeMirror is enabled. Maybe problem is only on my test wiki, please check it on before the wide-scale deployment.

Aug 4 2017, 7:48 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), Patch-For-Review, Regression, Performance-Team, MediaWiki-extensions-CodeMirror

Aug 3 2017

Pastakhov created T172369: Error when run maintenance/FlowSearchConfig.php.
Aug 3 2017, 9:54 AM · Collaboration-Team-Triage, StructuredDiscussions

Jul 25 2017

Pastakhov added a comment to T170001: Syntax highlighting - RTL problems.

@Niharika It is easier to install the extension without composer usage and maybe when I created the extension composer was not widely used for mediawiki extensions (not sure).

Jul 25 2017, 5:18 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, I18n, RTL, MediaWiki-extensions-CodeMirror

Jul 21 2017

Pastakhov added a comment to T170001: Syntax highlighting - RTL problems.

@Niharika Maybe it is possible by process event:

"cursorActivity" (instance: CodeMirror)
    Will be fired when the cursor or selection moves, or any change is made to the editor content.
Jul 21 2017, 11:05 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), Patch-For-Review, I18n, RTL, MediaWiki-extensions-CodeMirror

Jul 20 2017

Pastakhov added a comment to T171074: HTML comment next to a heading disables heading highlighting.

There are two problems:

  1. font size can be changed only for whole line and big comments looks ugly for me.
  2. processing comments required some optimizations of tokenizer, it should be able to change type of previous tokens without processing all next tokens again.
Jul 20 2017, 4:53 AM · Community-Tech, MediaWiki-extensions-CodeMirror

Jul 18 2017

Pastakhov added a comment to T92826: Ready-to-use Docker package for MediaWiki.

Take a look at my solution, maybe you'll find there something useful.
https://github.com/pastakhov/compose-mediawiki-ubuntu

Jul 18 2017, 9:25 AM · Wikimania-Hackathon-2017, Services (doing), User-mobrovac, MediaWiki-Containers, MediaWiki-Releasing, Wikimedia-Hackathon-2015

Jul 11 2017

Pastakhov added a comment to T170056: Exception in module-execute in module ext.CodeMirror.

Seems there is a hook that are called when Toolbar initialized, I am not sure...

Jul 11 2017, 3:37 PM · MediaWiki-extensions-CodeMirror
Pastakhov closed T170130: CodeMirror should use only the content language, not the user language as Resolved.
Jul 11 2017, 8:38 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T108450: Highlighting broken in complicated templates.

Thanks for nice links ;-)

Jul 11 2017, 8:35 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T170240: Highlight keywords in file syntax.

Yes, actually it is one task - make parser for [[File:...]]. One is parsed as a link still.

Jul 11 2017, 8:31 AM · Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T170187: Move Code Mirror's Mediawiki Mode into a separate library.

Wikitext syntax highlighting depend on mediawiki settings such as site language, extension installed and etc.
Thus it is not possible to make a general mediawiki mode аnd in the future this dependence will only increase.

Jul 11 2017, 3:25 AM · Community-Tech, MediaWiki-extensions-CodeMirror

Jul 10 2017

Pastakhov updated the task description for T170130: CodeMirror should use only the content language, not the user language.
Jul 10 2017, 11:01 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), MediaWiki-extensions-CodeMirror
Pastakhov created T170130: CodeMirror should use only the content language, not the user language.
Jul 10 2017, 10:34 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), MediaWiki-extensions-CodeMirror
Pastakhov added a project to T170004: Syntax Highlighting: Translated magic words aren't recognized in Hebrew: MediaWiki-extensions-CodeMirror.
Jul 10 2017, 10:29 AM · MediaWiki-extensions-CodeMirror, Community-Tech
Pastakhov added a comment to T170004: Syntax Highlighting: Translated magic words aren't recognized in Hebrew.

@IKhitron, It does not work since there are only part of language aliases (localized magic words).
And as I wrote, I have no idea why there are only part of them.
In any case this behavior is a bug, CodeMirror should use only language from $wgLanguageCode and it will be fixed soon.
For check localized magic words you should set $wgLanguageCode to corresponded value or use the CodeMirror extension on wiki with $wgLanguageCode have corresponded value (it's no joke).

Jul 10 2017, 10:20 AM · MediaWiki-extensions-CodeMirror, Community-Tech
Pastakhov added a comment to T170004: Syntax Highlighting: Translated magic words aren't recognized in Hebrew.

I found other way - add uselang parameter to url, but it is more a bag that a feature (and should be fixed)
For example https://test.wikipedia.org/w/index.php?title=Pride_and_Prejudice&action=edit&oldid=323245&uselang=de
Or change it by language toolbar at the top of page. But in this case I see only part of language aliases.
Have no idea why.

Jul 10 2017, 8:25 AM · MediaWiki-extensions-CodeMirror, Community-Tech
Pastakhov added a comment to T170004: Syntax Highlighting: Translated magic words aren't recognized in Hebrew.

I meant that it depends on the value of the $wgLanguageCode variable.
On test.wikipedia.org it is en thus there are no Localized magic words.
For check localized magic words you should set $wgLanguageCode to corresponded value.

Jul 10 2017, 7:28 AM · MediaWiki-extensions-CodeMirror, Community-Tech
Pastakhov claimed T170041: Highlight magic words.
Jul 10 2017, 6:12 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T170056: Exception in module-execute in module ext.CodeMirror.

Such hard-to-reproduce bug report is like a diamond, thank you for testing and well describing.
Seems problem is in $( addCodeMirrorToWikiEditor );
The addCodeMirrorToWikiEditor function should be called after wikiEditor loaded. (should make sure that wikiEditor loaded).
This is really hard-to-reproduce.

Jul 10 2017, 5:03 AM · MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T170004: Syntax Highlighting: Translated magic words aren't recognized in Hebrew.

Feel free to reopen the ticket if it will not work on local wiki

Jul 10 2017, 4:25 AM · MediaWiki-extensions-CodeMirror, Community-Tech
Pastakhov closed T170004: Syntax Highlighting: Translated magic words aren't recognized in Hebrew as Invalid.

This is the expected behavior.
Localized magic words should be highlighted only on local wiki.
As you see, MW parser interprets them as Template:SORTIERUNG:AA and Template:מיון רגיל:AAA

Jul 10 2017, 2:52 AM · MediaWiki-extensions-CodeMirror, Community-Tech

Jul 9 2017

Pastakhov added a comment to T108447: Files with links in caption not highlighted correctly.

@IKhitron the problem is not the same like a template inside a template and solution will be different.
Files have their own syntax and I just skipped this part of code (I had no time)

Jul 9 2017, 6:11 PM · Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T108447: Files with links in caption not highlighted correctly.

@Niharika no, it is not a complicated problem. Just Files contain several different parameters (not only the caption) and it takes a time to write code to cover all them. I will fix it.

Jul 9 2017, 4:05 PM · Community-Tech, MediaWiki-extensions-CodeMirror
Quiddity awarded T95104: Fix the default browser spellcheck functionality, or integrate a spell checker to CodeMirror a Mountain of Wealth token.
Jul 9 2017, 3:30 AM · Community-Tech, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), User-notice, Patch-For-Review, MediaWiki-extensions-CodeMirror

Jun 19 2017

Pastakhov added a comment to T164809: Fill scrolling gaps in syntax highlighting, take out larger font size and spacing for headers.

Can't reproduce.
Tested on CPU Intel Core i5-2430M CPU @ 2.40GHz
FireFox 52 and Chrome 51 on Linux 64-bit.

Jun 19 2017, 5:26 PM · Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T164809: Fill scrolling gaps in syntax highlighting, take out larger font size and spacing for headers.

I cant replay the problem
I took the large article and copied one several times for increase size of article even more.
Then I moved from beginning to end of article using mouse and ctrl + end buttons and could not see any "gaps".
http://test.foxway.org/w/index.php?title=Sandbox:T164809&action=edit

Jun 19 2017, 5:15 AM · Community-Tech, MediaWiki-extensions-CodeMirror

Jun 16 2017

Pastakhov added a comment to T164809: Fill scrolling gaps in syntax highlighting, take out larger font size and spacing for headers.

I will be able in a couple of days and take a look on it.

Jun 16 2017, 5:18 AM · Community-Tech, MediaWiki-extensions-CodeMirror

Jun 14 2017

Pastakhov added a comment to T167874: Archive/delete mediawiki/skins/Empty.

I have the old path for testing https://gerrit.wikimedia.org/r/#/c/323361/1 it may be merged

Jun 14 2017, 3:03 PM · RelEng-Archive-FY201718-Q1, Gerrit, Continuous-Integration-Config, MediaWiki-extensions-PhpTags
Pastakhov added a comment to T167874: Archive/delete mediawiki/skins/Empty.

Skin is still in development, and it will be released.

Jun 14 2017, 2:43 PM · RelEng-Archive-FY201718-Q1, Gerrit, Continuous-Integration-Config, MediaWiki-extensions-PhpTags

May 14 2017

Pastakhov added a comment to T164441: Replace CodeMirror icons with new icons.

Patch Set 3: use the color `#36С for the enabled button
Animated (3s)


May 14 2017, 6:02 PM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), Patch-For-Review, MediaWiki-extensions-CodeMirror

May 13 2017

Pastakhov added a comment to T165178: Design fixes for text styles for codemirror.

Also background colors in tags and templates reserved for tag matcher.
For example when the cursor on or inside a pair of tags the CodeMirror highlights them. Demo

May 13 2017, 11:46 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Patch-For-Review, MediaWiki-extensions-CodeMirror, Design

May 12 2017

Pastakhov added a comment to T164441: Replace CodeMirror icons with new icons.
  • I use mirrored background of toolbar, should I use one color #36C?
    • This is not possible by standard way since buttons are padded. As I wrote, I can try to hack it but seems it not good idea.
May 12 2017, 5:22 PM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T164441: Replace CodeMirror icons with new icons.

Buttonns in classic toolbar:

May 12 2017, 5:29 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), Patch-For-Review, MediaWiki-extensions-CodeMirror

May 11 2017

Pastakhov added a comment to T163919: Design review for CodeMirror extension.

@Volker_E From my point of view, we need several themes T163533 in any case, and the question is which one to use by default. The one that will be more convenient for most editors or one that will be readable by all.
And why aren't we getting input from real Wikipedia editors? I reason more as a software developer, and maybe for Wikipedia editors it's actually more important to read the comments than to easily separate they from the regular text.

May 11 2017, 5:35 PM · Community-Tech, MediaWiki-extensions-CodeMirror, Design
Pastakhov added a comment to T163919: Design review for CodeMirror extension.

@Volker_E IMO comments are inherently very close to part of an inactive user interface component (in Incidental) that is excepted from requirement to have a contrast ratio of at least 4.5:1.

May 11 2017, 4:13 PM · Community-Tech, MediaWiki-extensions-CodeMirror, Design
Pastakhov claimed T164441: Replace CodeMirror icons with new icons.
May 11 2017, 8:13 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-08-01_(1.30.0-wmf.12)), Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov created T165012: The options of dropdown menus are displayed under the layer of CodeMirror.
May 11 2017, 7:24 AM · MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), MediaWiki-extensions-CodeMirror
Pastakhov claimed T165001: Take out gray background behind list bullets in syntax highlighting.
May 11 2017, 6:05 AM · Patch-For-Review, MediaWiki-extensions-CodeMirror, Community-Tech
Pastakhov added a comment to T163919: Design review for CodeMirror extension.

I agree with everything except the color for comments.
#72777d looks very good but it is a problem. It looks too organic, and it does not allow you to easily visually separate the plain text and comment text. Of course this depends on the used fonts, display, light, settings and tastes, but IMO #72777d is too close to having a too low contrast.
Perhaps, as a compromise we could use # 969696.

May 11 2017, 6:04 AM · Community-Tech, MediaWiki-extensions-CodeMirror, Design

May 10 2017

Pastakhov updated the task description for T164905: function mw.toolbar.insertTags does not work with CodeMirror in Chrome and IE.
May 10 2017, 5:56 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov created T164905: function mw.toolbar.insertTags does not work with CodeMirror in Chrome and IE.
May 10 2017, 5:45 AM · Community-Tech, MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, MediaWiki-extensions-CodeMirror

Apr 28 2017

Pastakhov added a comment to T161694: Syntax highlighting: make <ref> tags and <nowiki> tags green.

I'm sure we should do the code inside SyntaxHighlight

Apr 28 2017, 5:12 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T161694: Syntax highlighting: make <ref> tags and <nowiki> tags green.

@Niharika The CodeMirror and SyntaxHighlight solve different tasks in different ways and one can't replace the other. We can make the text in the editor look the same as on the page (I mean the text or code inside <source> tags)

Apr 28 2017, 4:20 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror

Apr 26 2017

Pastakhov added a comment to T163916: CodeMirror enable/disable tooltips need to be switched.

Not sure about icons. Originally the colored icon was displayed when the CodeMirror was disabled and the colorless icon when CodeMirror was enabled. It meant that clicking on colored icon makes wikitext color, and clicking colorless icon makes wikitext colorless...
Maybe the question for T163919

Apr 26 2017, 5:00 PM · Patch-For-Review, Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov claimed T163916: CodeMirror enable/disable tooltips need to be switched.

Patch already exists

Apr 26 2017, 4:48 PM · Patch-For-Review, Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T163238: Integration of CodeMirror with other tag extensions.

@Niharika, it already exists by using CodeMirrorGetAdditionalResources hook , the problem is in performance only. I sure it should be rewritten for use in production. And yes, it can look ugly bu only if someone does it ugly, and, as I know, code review before merge prevent to merge ugly code to repository.

Apr 26 2017, 6:07 AM · Patch-For-Review, MediaWiki-extensions-CodeMirror

Apr 21 2017

Pastakhov updated the task description for T163238: Integration of CodeMirror with other tag extensions.
Apr 21 2017, 7:08 AM · Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T163238: Integration of CodeMirror with other tag extensions.

Integration is needed only for highlighting text (or maybe errors in the syntax) inside extension tags.

Apr 21 2017, 6:57 AM · Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov created T163533: Add different color themes of syntax highlighting.
Apr 21 2017, 6:36 AM · Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T161694: Syntax highlighting: make <ref> tags and <nowiki> tags green.

I wonder if we could just output the list of valid tags to the client

@kaldari, CodeMirror already gets the list of valid non-HTML tags from Parser.

Apr 21 2017, 4:22 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror

Apr 20 2017

Pastakhov added a comment to T161694: Syntax highlighting: make <ref> tags and <nowiki> tags green.

It never occurred to me that for someone it might be better that all the tags be the same color :)
I think we should make several color themes (T163533) in the future and editors will be able to choose the best for themselves.

Apr 20 2017, 6:10 PM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T161694: Syntax highlighting: make <ref> tags and <nowiki> tags green.

@DannyH, should all tags be green? There are HTML tags (like <big>) and extension tags ( like <ref> ) and specific wiki markup tags (like <nowiki>)
Originally HTML tags (and specific wiki markup tags except <pre> and <nowiki>) was green and extension tags was violet. I did this to visually separate HTML tags and extension tags since it look similar but behavior is different.

Apr 20 2017, 4:36 PM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror

Apr 18 2017

Pastakhov added a parent task for T163238: Integration of CodeMirror with other tag extensions: T161694: Syntax highlighting: make <ref> tags and <nowiki> tags green.
Apr 18 2017, 6:56 PM · Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a subtask for T161694: Syntax highlighting: make <ref> tags and <nowiki> tags green: T163238: Integration of CodeMirror with other tag extensions.
Apr 18 2017, 6:56 PM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov created T163238: Integration of CodeMirror with other tag extensions.
Apr 18 2017, 6:55 PM · Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T161694: Syntax highlighting: make <ref> tags and <nowiki> tags green.

@Niharika, I saw the patch (Patch Set 2), it is incorrect (please take a look at my answer in comments )
Patch https://gerrit.wikimedia.org/r/#/c/346499 makes <pre> and <nowiki> tags green, and also allows extensions to define colors for own tags.
(I was sure by mistake that this task for <pre> tags. I have to be more careful)

Apr 18 2017, 5:22 PM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov added a comment to T161694: Syntax highlighting: make <ref> tags and <nowiki> tags green.

Sorry, I mixed up <ref> and <pre> tags.
The patch https://gerrit.wikimedia.org/r/#/c/346499 is only for <pre> and <nowiki> tags.

Apr 18 2017, 9:05 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov claimed T161475: CodeMirror forces loading of ext.wikiEditor module even when it isn't needed.

Hi @Niharika, I have not looked at it yet. Seems it is a bug. I'll try to resolve it...

Apr 18 2017, 5:40 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror

Apr 5 2017

Pastakhov created T162234: Move CSS styles to LESS.
Apr 5 2017, 6:38 AM · Community-Tech, MediaWiki-extensions-CodeMirror
Pastakhov closed T153528: Sometimes Enable/Disable button is broken: "Node was not found in codemirror.js:5965" as Resolved.
Apr 5 2017, 6:26 AM · MediaWiki-extensions-CodeMirror
Pastakhov claimed T161694: Syntax highlighting: make <ref> tags and <nowiki> tags green.

What about <nowiki> tags?

Apr 5 2017, 5:28 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror
Pastakhov claimed T161559: Syntax highlighting: Better line spacing for H1s and H2s .
Apr 5 2017, 5:15 AM · Community-Tech, Patch-For-Review, MediaWiki-extensions-CodeMirror