Page MenuHomePhabricator

Pchelolo
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 24 2015, 10:23 AM (225 w, 1 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Pchelolo [ Global Accounts ]

Recent Activity

Yesterday

Pchelolo added a comment to T231586: Deploy Updated wikidiff2 C++ Engine.

Thank you @jijiki. I was a bit confused in the beginning as it didn't work, but sudo systemctl restart php7.2-fpm.service make it work :)

Thu, Oct 17, 4:48 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP), wikidiff2
Pchelolo added a comment to T235437: RESTBase/RESTRouter/service-runner rate limiting plans.

What happens if the rate-limiting service is unavailable or is lagging?

Thu, Oct 17, 2:51 PM · service-runner, User-mobrovac, Core Platform Team Workboards (Clinic Duty Team), Services (doing), CPT Initiatives (RESTBase Split (CDP2)), serviceops, Kubernetes, Service-deployment-requests, Operations
Pchelolo updated subscribers of T235666: Implement GET /revision/{from}/intermediatecount/{to}.

Back in 2014 the following patch has added a limit to the Title::countRevisionsBetween method that we intend to use in the implementation here with a rationale that a query was causing DB timeouts. The query we're going to use is the same, thus I think it has the potential to keep timing out.

Thu, Oct 17, 1:20 AM · Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Wed, Oct 16

Pchelolo moved T235666: Implement GET /revision/{from}/intermediatecount/{to} from Doing to Waiting for Review on the Core Platform Team Workboards (Green) board.
Wed, Oct 16, 10:14 PM · Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Pchelolo moved T235666: Implement GET /revision/{from}/intermediatecount/{to} from Ready to Doing on the Core Platform Team Workboards (Green) board.
Wed, Oct 16, 7:59 PM · Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Pchelolo claimed T235666: Implement GET /revision/{from}/intermediatecount/{to}.
Wed, Oct 16, 7:59 PM · Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T234940: Curator gets number of intermediate revisions between two revisions.

What should happen if revision from is newer then revision to?

Wed, Oct 16, 6:38 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T234940: Curator gets number of intermediate revisions between two revisions.

If you didn't know the first and last revision ID, you'd have to scroll through the whole history to get the first and last ID, at which point you could probably count all the intermediate ones yourself.

Wed, Oct 16, 6:26 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T235560: Ensure that null is not returned in place of empty string.

Addressed by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/542450 as well.

Wed, Oct 16, 5:49 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo added a comment to T235663: For Compare Revision Endpoint check for page read permission.

The check is implemented in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/542450

Wed, Oct 16, 5:46 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Pchelolo moved T231588: Implement GET Page Revision from Waiting for Review to Done on the Core Platform Team Workboards (Green) board.
Wed, Oct 16, 5:45 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T235665: Compose query for intermediate revision count.

If we don't go with my proposals in T234940#5580724, we don't need any special queries. There's already Title::countRevisionsBetween method in MW core which provides exactly what's needed.

Wed, Oct 16, 5:44 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T234940: Curator gets number of intermediate revisions between two revisions.
  • Do we envision expanding this endpoint to cover filters like T231590 in the future?
  • The /page/history/{title}/counts/edits is a special case of this endpoint as you can get the same information as /revision/<first_page_rev>/intermediatecount/<last_page_revision>. Given that the information provided by the endpoints is so similar that they even intersect, why are the endpoints named so differently and even belong to a different 'namespace'? one is 'page', other is 'revision'.
Wed, Oct 16, 4:50 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T231586: Deploy Updated wikidiff2 C++ Engine.

@jijiki Thank you! However, I will ask you for one more thing in beta - could you also install it on deployment-mediawiki-parsoid10.deployment-prep.eqiad.wmflabs before proceeding to prod? That's where all the requests to rest.php are routed now, so we need it there to test from outside the beta cluster.

Wed, Oct 16, 3:18 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP), wikidiff2
Pchelolo added a comment to T235437: RESTBase/RESTRouter/service-runner rate limiting plans.

The kad library that the DHT rate limiter is based on was forked. Since it worked OK, the fork was never actually updated, and in the time that's passed, the upstream library has moved names 2 times and now looks quite abandoned. So, moving away from using it was inevitable, thus I'm all for the pool counter solution.

Wed, Oct 16, 3:09 PM · service-runner, User-mobrovac, Core Platform Team Workboards (Clinic Duty Team), Services (doing), CPT Initiatives (RESTBase Split (CDP2)), serviceops, Kubernetes, Service-deployment-requests, Operations

Tue, Oct 15

Pchelolo removed a project from T235395: Document how to get the current contents of a page via the MediaWiki API: Core Platform Team.
Tue, Oct 15, 8:22 PM · MediaWiki-API, Documentation, Outreachy, good first bug
Pchelolo edited projects for T235355: REST Handler::getValidatedParams() return contract, added: CPT Initiatives (Core REST API in PHP); removed Core Platform Team.
Tue, Oct 15, 8:14 PM · CPT Initiatives (Core REST API in PHP), MediaWiki-REST-API
Pchelolo removed a project from T235298: Follow RFC7807 for REST error format: Core Platform Team.
Tue, Oct 15, 8:07 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T230843: Contributor updates a page.

csrf token: I don't believe this is necessary if we only support OAuth authentication

Tue, Oct 15, 5:01 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T229663: Contributor gets page source.

The path could be a subresource /page/{title}/wikitext, following the principle that subresources should be used for "larger, more expensive, less-frequently-used properties, or properties with different access rights" (ref), which would seem to describe the wikitext of the page. For HTML delivery we could use /page/{title}/html, but that doesn't seem to be necessary for the CRUD sprint.

Tue, Oct 15, 4:46 PM · Core Platform Team Workboards (User Stories), MediaWiki-REST-API, Story, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T234940: Curator gets number of intermediate revisions between two revisions.

I believe that we need to copy the errors from compare endpoint in case of revisions do not belong to the same page -> return 400

Tue, Oct 15, 4:20 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
Elitre awarded T232392: EventBus extension must not send batches that are too large a Love token.
Tue, Oct 15, 3:36 PM · Core Platform Team Workboards (Clinic Duty Team), Analytics, good first bug, Event-Platform, CPT Initiatives (Modern Event Platform (TEC2)), WMF-JobQueue
Pchelolo added a comment to T231586: Deploy Updated wikidiff2 C++ Engine.

@jijiki it appears to be present now :)

Tue, Oct 15, 3:21 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP), wikidiff2
Pchelolo added a project to T235358: Could not enqueue jobs: "Unable to deliver all events: 500: Internal Server Error": Core Platform Team Workboards (Clinic Duty Team).
Tue, Oct 15, 2:14 PM · Core Platform Team Workboards (Clinic Duty Team), WMF-JobQueue, Wikimedia-production-error

Fri, Oct 11

Pchelolo added a comment to T231590: Implement GET Edit Count.

We'll keep the endpoints as they are.

Fri, Oct 11, 8:19 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo created T235298: Follow RFC7807 for REST error format.
Fri, Oct 11, 7:14 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T230842: Contributor creates a page.

I agree with @tstarling

Fri, Oct 11, 6:17 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
Pchelolo moved T231590: Implement GET Edit Count from Doing to Done on the Core Platform Team Workboards (Green) board.
Fri, Oct 11, 5:49 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo added a comment to T235146: Improve GET History Filter.

The above patch should include nulls instead of omitting the properties.

Fri, Oct 11, 2:12 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)

Thu, Oct 10

Pchelolo added a comment to T235146: Improve GET History Filter.

Of the three, I prefer a null value. For clients, it's kind of irritating to have properties blink in and out of existence. The empty string is not really a good way to indicate "does not exist".

Thu, Oct 10, 10:25 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo added a parent task for T231933: Make services tests not depend on production enwiki pages: T229018: RESTBase should be able to store Parsoid/PHP contents in Cassandra alongwith Parsoid/JS contents.
Thu, Oct 10, 9:42 PM · Product-Infrastructure-Team-Backlog, CPT Initiatives (Parsoid PHP (CDP2)), Parsoid-PHP, RESTBase
Pchelolo added a subtask for T229018: RESTBase should be able to store Parsoid/PHP contents in Cassandra alongwith Parsoid/JS contents: T231933: Make services tests not depend on production enwiki pages.
Thu, Oct 10, 9:42 PM · Core Platform Team Workboards (Purple), CPT Initiatives (Parsoid PHP (CDP2)), RESTBase, Parsoid-PHP
Pchelolo added a comment to T231590: Implement GET Edit Count.

There's an inconsistency between the count and listing endpoints. that I feel like we could followup on really quick:

Thu, Oct 10, 9:17 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo added a comment to T235146: Improve GET History Filter.

@BPirkle one last thing (sorry): the original requirements had "delta" and "size" in "characters". What I meant was, "do it exactly like the Web UI does it". Reviewing, the size and delta are in bytes in the Web UI, and I think we should do the same here. (I tried adding multi-byte chars to pages and it looks like it's definitely a difference in bytes).
I don't know if you did it that way in the first place, but I wanted to call it out here.

Thu, Oct 10, 8:49 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo added a comment to T235146: Improve GET History Filter.

Bill, if you're making changes, can you return a 200 status code when there are 0 results? I updated the user story to be more specific that the array is 0-20 elements.

Thu, Oct 10, 3:18 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)

Wed, Oct 9

Pchelolo committed rGRBDf238bf395945: Add restbase-dev1006 to dev cluster scap targets (authored by Pchelolo).
Add restbase-dev1006 to dev cluster scap targets
Wed, Oct 9, 10:26 PM
Pchelolo added a comment to T233179: Use ExternalStoreAccess::fetchFromURLs in blobStore::getBlobBatch.

Is this task blocking MCR schema migration?

Wed, Oct 9, 2:47 PM · CPT Initiatives (MCR), MediaWiki-Revision-backend, Performance Issue, Core Platform Team Workboards (Purple), Multi-Content-Revisions (Tech Debt)

Tue, Oct 8

Pchelolo moved T233178: Use RevisionStore::newRevisionFromBatch in WikiExporter from Done to Doing on the Core Platform Team Workboards (Clinic Duty Team) board.

@CCicalese_WMF yeah. Some unexpected complications have been found.

Tue, Oct 8, 10:43 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
Pchelolo added a comment to T231590: Implement GET Edit Count.

I have to wonder why the IOS team needs all 5 numbers on every page. Then again, I also have to wonder why they need some of these numbers at all.

Tue, Oct 8, 9:12 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo added a comment to T234995: Testing for Core REST API.

The api-testing has abstractions and some tests set up for Action API, so we would probably need to invest a bit into setting it up for REST API routes as well before we can write actual tests.

Tue, Oct 8, 8:35 PM · CPT Initiatives (API Integration Tests)
Pchelolo added a comment to T231588: Implement GET Page Revision.

And, should we take the user preferences into account if there's a logged in user, or is it the HTML that anonymous user would see?

Tue, Oct 8, 8:16 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Pchelolo updated the task description for T234995: Testing for Core REST API.
Tue, Oct 8, 7:44 PM · CPT Initiatives (API Integration Tests)
Pchelolo created T234995: Testing for Core REST API.
Tue, Oct 8, 7:39 PM · CPT Initiatives (API Integration Tests)
Pchelolo closed T232379: MassMessage problems - multiple deliveries and missing deliveries as Resolved.

So it sounds like the root cause was MassMessageSubmit succeeding but reporting failure (and thus being retried), and that still hasn't been explained or fixed, even though we now have a hack in place to catch those erroneous duplicates, right?

Tue, Oct 8, 6:16 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Core Platform Team Workboards (Clinic Duty Team), WMF-JobQueue, MassMessage

Mon, Oct 7

Pchelolo closed T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()., a subtask of T198341: Remove all references to the rev_text_id and ar_text_id fields, as Resolved.
Mon, Oct 7, 7:16 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
Pchelolo closed T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo(). as Resolved.

With the completion of the Translate extension, all references has been either removed or gated. Resolving.

Mon, Oct 7, 7:15 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
Pchelolo closed T198343: Replace all calls to Revision::getRevisionText(), a subtask of T198341: Remove all references to the rev_text_id and ar_text_id fields, as Resolved.
Mon, Oct 7, 7:09 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
Pchelolo closed T198343: Replace all calls to Revision::getRevisionText() as Resolved.

Translate extension is done, all usages has been either removed or gated. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/539607 hard deprecates the method.

Mon, Oct 7, 7:08 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-release, Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Patch-For-Review, Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Wikidata
Pchelolo closed T228675: Remove direct access to the text table from the Translate extension., a subtask of T198341: Remove all references to the rev_text_id and ar_text_id fields, as Resolved.
Mon, Oct 7, 7:08 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
Pchelolo closed T228675: Remove direct access to the text table from the Translate extension., a subtask of T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()., as Resolved.
Mon, Oct 7, 7:07 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
Pchelolo closed T228675: Remove direct access to the text table from the Translate extension., a subtask of T198343: Replace all calls to Revision::getRevisionText(), as Resolved.
Mon, Oct 7, 7:07 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-release, Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Patch-For-Review, Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Wikidata
Pchelolo closed T228675: Remove direct access to the text table from the Translate extension. as Resolved.

All access has been either removed or gated. Resolving.

Mon, Oct 7, 7:07 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Language-Team (Language-2019-July-September), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
Pchelolo added a comment to T231590: Implement GET Edit Count.

Hi, Natalia. @Anomie pointed out that getting these counts is pretty hard on our infrastructure, so if we get them as separate HTTP calls, each call has lower impact on our servers, and we can spread them out across multiple servers. I realize it means you need to make 5 different calls; is that going to work for you?

Mon, Oct 7, 4:42 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo added a comment to T231588: Implement GET Page Revision.

html must contain the HTML for the page without any skin or UI, like action=render

Mon, Oct 7, 3:47 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Wed, Oct 2

Pchelolo added a comment to T231599: Compose New History Queries.

reverted

Where a revert is defined as a revision labelled with either Undo or Rollback

Wed, Oct 2, 10:38 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T234470: Decide on pagination and links spec for Core REST API.

I'm open to having this conversation but not to having it block shipping the history endpoint.

Wed, Oct 2, 9:38 PM · CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo created T234470: Decide on pagination and links spec for Core REST API.
Wed, Oct 2, 6:52 PM · CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo added a comment to T231588: Implement GET Page Revision.

In general, the response format doesn't seem to care about the fact we have slots now. I think any new API we're designing should take the existence of revision slots into consideration. Otherwise we're creating more tech debt.

Wed, Oct 2, 6:37 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Pchelolo closed T233777: Summary out of sync with content as Declined.

Not reproduced anymore, I guess some purge has been lost. Not much we can do to debug any further now.

Wed, Oct 2, 4:53 PM · Page Content Service, Core Platform Team, Services, Product-Infrastructure-Team-Backlog
Pchelolo closed T231866: Circular dependency when creating service! ContentLanguage as Resolved.
Wed, Oct 2, 4:47 PM · Core Platform Team, Performance-Team (Radar), Language-Team, MW-1.34-release, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ResourceLoader, MediaWiki-extensions-Gadgets, MediaWiki-ServiceContainer
Pchelolo added a comment to T231558: Implement GET page history.
  1. I think the question came down to the insanely confusing nature of reverse-chronological segmented lists. "next" means "older" and "prev" means "newer". I decided that the advantage of having standard next/prev link relations was offset by having the reverse-chron confusion.
Wed, Oct 2, 2:38 PM · Patch-For-Review, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo added a comment to T231558: Implement GET page history.

Sorry, I might be late to the party, but I do have some terminology concerns:

Wed, Oct 2, 3:12 AM · Patch-For-Review, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)

Tue, Oct 1

Pchelolo closed T158015: Services requirements for container-based infrastructures, a subtask of T170453: FY2017/18 Program 6: Streamlined Service delivery, as Invalid.
Tue, Oct 1, 6:47 PM · Release-Engineering-Team, Release-Engineering-Team-TODO, Core Platform Team Legacy (Watching / External), Phlogiston-Category, Epic, Services (watching), Operations
Pchelolo closed T158015: Services requirements for container-based infrastructures as Invalid.

This has been relevant during the planning stage of k8s for services, but I guess now we don't need this ticket open anymore.

Tue, Oct 1, 6:47 PM · Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), User-mobrovac, Services (next), Prod-Kubernetes
Pchelolo added a comment to T200374: Update indirect dependency on github.com/gwicke/kad.git.

I'm raising the priority of this yet again cause the fork has completely diverged from the upstream and it's getting to the point when it's dependencies are not supported either, so we really need to switch away from the fork.

Tue, Oct 1, 6:45 PM · Core Platform Team Workboards (Clinic Duty Team), Services (later), service-runner

Mon, Sep 30

Pchelolo closed T234226: MassMessage not delivering messages as Resolved.

Yay! Sorry about the regression.

Mon, Sep 30, 4:43 PM · Patch-For-Review, WMF-JobQueue, Core Platform Team Workboards (Clinic Duty Team), MassMessage
Pchelolo added a comment to T234226: MassMessage not delivering messages.

This should be resolved now. Please test.

Mon, Sep 30, 4:35 PM · Patch-For-Review, WMF-JobQueue, Core Platform Team Workboards (Clinic Duty Team), MassMessage
Pchelolo added a comment to T234226: MassMessage not delivering messages.

https://github.com/wikimedia/change-propagation/pull/331 should fix it.

Mon, Sep 30, 3:55 PM · Patch-For-Review, WMF-JobQueue, Core Platform Team Workboards (Clinic Duty Team), MassMessage
Pchelolo added a comment to T234226: MassMessage not delivering messages.

Ok. I know what's happening, I'm sorry about that. This is a regression of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MassMessage/+/538742

Mon, Sep 30, 3:45 PM · Patch-For-Review, WMF-JobQueue, Core Platform Team Workboards (Clinic Duty Team), MassMessage
Pchelolo triaged T234226: MassMessage not delivering messages as High priority.
Mon, Sep 30, 3:19 PM · Patch-For-Review, WMF-JobQueue, Core Platform Team Workboards (Clinic Duty Team), MassMessage

Fri, Sep 27

Pchelolo closed T233353: EntitySchema: remove dependency on pre-MCR database schema, a subtask of T198341: Remove all references to the rev_text_id and ar_text_id fields, as Resolved.
Fri, Sep 27, 5:31 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
Pchelolo closed T233353: EntitySchema: remove dependency on pre-MCR database schema as Resolved.
Fri, Sep 27, 5:31 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Wikidata, Shape Expressions, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
Pchelolo closed T234017: Protect log entries offer link to change protection only to unprivileged users as Resolved.
Fri, Sep 27, 4:43 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), MediaWiki-Logging, Regression

Thu, Sep 26

Pchelolo added a comment to T232485: RFC: Core REST API namespace and version.

Not ideal, but I think it's a relatively minor maintenance burden...?

Thu, Sep 26, 7:56 PM · TechCom-RFC, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Pchelolo committed rMSCD2db4bff5a6b9: Update change-propagation to d19aff2 (authored by Pchelolo).
Update change-propagation to d19aff2
Thu, Sep 26, 5:27 PM

Wed, Sep 25

Pchelolo added a comment to T233132: Expand QPS for partners when "stash=true" .

Could you find out why do they need data-parsoid? It's internal information useful for Parsoid. Exposing it via API is deprecated. Data-parsoid was never considered a part of the API, and AFAIK is not stable.

Wed, Sep 25, 8:31 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase-API, RESTBase
Pchelolo added a comment to T228675: Remove direct access to the text table from the Translate extension..

Does this depend on any recent core changes? I was testing with about week old core code.

Wed, Sep 25, 4:07 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Language-Team (Language-2019-July-September), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)

Tue, Sep 24

Pchelolo moved T179685: Respawn service-runner workers serially from Needs Cleaning - Security, stability, performance, and scalability (TEC1) to Icebox on the Core Platform Team board.
Tue, Sep 24, 6:52 PM · Core Platform Team, service-runner
Pchelolo closed T204183: EventBus error "Unable to deliver all events: (curl error: 28) Timeout was reached" as Invalid.

We're not using eventlogging-eventbus service anymore, it was replaced by eventgate, please create a new task if timeouts keep happening.

Tue, Sep 24, 6:39 PM · Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Event-Platform, WMF-JobQueue, Wikimedia-production-error, Analytics

Mon, Sep 23

Pchelolo closed T233358: SpamBlacklist: remove dependency on pre-MCR database schema, a subtask of T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()., as Resolved.
Mon, Sep 23, 6:47 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
Pchelolo closed T233358: SpamBlacklist: remove dependency on pre-MCR database schema as Resolved.
Mon, Sep 23, 6:47 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, SpamBlacklist, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
Pchelolo added a comment to T228675: Remove direct access to the text table from the Translate extension..

All of the above are addressed by the existing patches.

Mon, Sep 23, 4:44 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Language-Team (Language-2019-July-September), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)

Fri, Sep 20

Pchelolo added a comment to T214093: Modern Event Platform: Schema Guidelines and Conventions.

Multiple annotations directly in definition looks better.

Fri, Sep 20, 3:30 PM · Analytics-Kanban, CPT Initiatives (Modern Event Platform (TEC2)), Analytics, Better Use Of Data, Patch-For-Review, Product-Analytics, Goal, Services (watching), Analytics-EventLogging, Event-Platform
Pchelolo closed T206889: Develop a library for JSON schema backwards incompatibility detection, a subtask of T206814: CI Support for Schema Registry, as Resolved.
Fri, Sep 20, 3:24 PM · Analytics-Kanban, Patch-For-Review, CPT Initiatives (Modern Event Platform (TEC2)), Services (watching), Analytics-EventLogging, Event-Platform, Analytics
Pchelolo closed T206889: Develop a library for JSON schema backwards incompatibility detection as Resolved.
Fri, Sep 20, 3:24 PM · CPT Initiatives (Modern Event Platform (TEC2)), Core Platform Team Workboards (Clinic Duty Team), Analytics-EventLogging, Event-Platform, Analytics
Pchelolo moved T233173: Make RevisionStore::newRevisionsFromBatch use BlobStore::getBlobBatch from Waiting for Review to Done on the Core Platform Team Workboards (Purple) board.
Fri, Sep 20, 3:21 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
Pchelolo closed T233173: Make RevisionStore::newRevisionsFromBatch use BlobStore::getBlobBatch, a subtask of T228988: Create batch access interface for page content, as Resolved.
Fri, Sep 20, 3:20 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Core Platform Team Workboards (Purple), Patch-For-Review, CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
Pchelolo closed T233173: Make RevisionStore::newRevisionsFromBatch use BlobStore::getBlobBatch as Resolved.
Fri, Sep 20, 3:20 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)

Thu, Sep 19

Pchelolo closed T233356: Flow: remove dependency on pre-MCR database schema, a subtask of T198341: Remove all references to the rev_text_id and ar_text_id fields, as Resolved.
Thu, Sep 19, 10:29 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
Pchelolo closed T233356: Flow: remove dependency on pre-MCR database schema, a subtask of T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()., as Resolved.
Thu, Sep 19, 10:29 PM · Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
Pchelolo closed T233356: Flow: remove dependency on pre-MCR database schema as Resolved.
Thu, Sep 19, 10:29 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), StructuredDiscussions, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Growth-Team, Multi-Content-Revisions (Tech Debt)
Pchelolo claimed T233356: Flow: remove dependency on pre-MCR database schema.

The patch above deals with the only occurrence of *_text_id in the flow extension. Neither getRevisionText nor getQueryInfo with a text flag is present.

Thu, Sep 19, 10:21 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), StructuredDiscussions, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Growth-Team, Multi-Content-Revisions (Tech Debt)
Pchelolo claimed T233355: WikimediaMaintenance: remove dependency on pre-MCR database schema.
Thu, Sep 19, 9:20 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), MediaWiki-extensions-WikimediaMaintenance, Core Platform Team Workboards (Purple), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
Pchelolo added a comment to T232379: MassMessage problems - multiple deliveries and missing deliveries.

Hey @Pchelolo, do we know wether the patch might be merged soon? Thanks for the work there.

Thu, Sep 19, 5:23 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Core Platform Team Workboards (Clinic Duty Team), WMF-JobQueue, MassMessage

Wed, Sep 18

Pchelolo added a comment to T198343: Replace all calls to Revision::getRevisionText().

The last usage of the method within core (apart from maintenance scripts) is in ApiQueryDeletedrevs which was deprecated since 1.25.

Wed, Sep 18, 9:05 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-release, Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Patch-For-Review, Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Wikidata
Pchelolo closed T228988: Create batch access interface for page content, a subtask of T231689: Can get bulk access from code that has been using the 'text' for getQueryInfo() , as Resolved.
Wed, Sep 18, 5:14 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (MCR Schema Migration)
Pchelolo closed T228988: Create batch access interface for page content as Resolved.

I've created subtasks for pieces of followup work, but the interface is created, so this is done.

Wed, Sep 18, 5:14 PM · MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Core Platform Team Workboards (Purple), Patch-For-Review, CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)
Pchelolo added a comment to T228675: Remove direct access to the text table from the Translate extension..

There's 3 usages left in maintenance scripts and import action.

Could you name the files?

Wed, Sep 18, 2:56 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Language-Team (Language-2019-July-September), CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)

Sep 18 2019

Pchelolo created T233179: Use ExternalStoreAccess::fetchFromURLs in blobStore::getBlobBatch.
Sep 18 2019, 1:00 AM · CPT Initiatives (MCR), MediaWiki-Revision-backend, Performance Issue, Core Platform Team Workboards (Purple), Multi-Content-Revisions (Tech Debt)
Pchelolo moved T233178: Use RevisionStore::newRevisionFromBatch in WikiExporter from Backlog to Waiting for Review on the Core Platform Team Workboards (Purple) board.
Sep 18 2019, 12:50 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, CPT Initiatives (MCR Schema Migration), Multi-Content-Revisions (Tech Debt)