Page MenuHomePhabricator

Pchelolo
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 24 2015, 10:23 AM (257 w, 2 d)
Availability
Available
LDAP User
Ppchelko
MediaWiki User
PPchelko (WMF) [ Global Accounts ]

Recent Activity

Today

Pchelolo added a comment to T253949: User::getNewMessageLinks can return Revision objects.

So just hard deprecate the entire method?

Fri, May 29, 5:32 AM · Patch-For-Review, Core Platform Team, Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
Pchelolo moved T253080: Add new ContentModelChangeFactory interface, implement with PageCommandFactory from Inbox to Tracking/Watching on the Core Platform Team board.
Fri, May 29, 4:48 AM · Core Platform Team, Dependency injection, User-DannyS712, MediaWiki-ContentHandler
Pchelolo added a comment to T253080: Add new ContentModelChangeFactory interface, implement with PageCommandFactory.

Sounds good. Is it possible to use UserIdentity instead of the User?

Fri, May 29, 4:47 AM · Core Platform Team, Dependency injection, User-DannyS712, MediaWiki-ContentHandler
Pchelolo added a comment to T253949: User::getNewMessageLinks can return Revision objects.

See https://gerrit.wikimedia.org/r/c/mediawiki/core/+/596502 - we opted for just removing the use of this method entirely. Should probably do the same in other occurrences if they exist

Fri, May 29, 4:44 AM · Patch-For-Review, Core Platform Team, Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712

Yesterday

Pchelolo added a comment to T253717: Add a factory service for `ManualLogEntry` objects.

Actually, after a bit of more thinking, I wonder if LogEntry should instead be converted into a value object - only holding the fields with getters/setters and containing no logic, and database operations, and all the stuff that uses the dependency should be done via a separate service, or even a group of services.

Thu, May 28, 10:58 PM · Core Platform Team, Dependency injection, User-DannyS712, MediaWiki-Logging
Pchelolo added a comment to T253717: Add a factory service for `ManualLogEntry` objects.

Will do; is this then approved from a product point of view?

Thu, May 28, 10:26 PM · Core Platform Team, Dependency injection, User-DannyS712, MediaWiki-Logging
Pchelolo claimed T252455: Update mediawiki_user_blocks_change to log partial block parameters.
Thu, May 28, 8:55 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), Product-Analytics, Analytics
Pchelolo closed T221763: LinksUpdate fails during page move due to "Title does not belong to page" RevisionStore error from PageImages hook as Resolved.

All patches here were deployed. I've done some logstash searching, and all errors have completely stopped around May 04-05 which corresponds with deployment. Resolving. Please reopen if reappears.

Thu, May 28, 5:32 PM · Wikimedia-production-error, MediaWiki-Page-rename, MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), User-brennen, Patch-For-Review, User-ArielGlenn, CPT Initiatives (MCR), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), MediaWiki-Revision-backend, Core Platform Team Workboards (Clinic Duty Team), Readers-Web-Backlog (Tracking), PageImages, Multi-Content-Revisions (Reactive), Regression
Pchelolo closed T239717: Incorrect rev_sha1 and rev_len on some revisions as Resolved.

Verified that the error has gone away. Resolving.

Thu, May 28, 5:24 PM · User-brennen, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Core Platform Team Workboards (Clinic Duty Team), User-Daniel, CPT Initiatives (MCR), Multi-Content-Revisions
Pchelolo moved T253149: Regression: UserSaveOptions hook no longer exposes old preference values from Waiting for Review to Waiting for deployment on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, May 28, 5:17 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Core Platform Team Workboards (Clinic Duty Team)
Pchelolo updated subscribers of T253799: RESTBase linting API is very slow (not cached).

@ssastry please correct me if I'm wrong, but Linter extension stores Parsoid lints in MySQL. If I understand it well, the flow is the following: page edit -> parsoid rerender -> parsoid calling MW API to record lint errors -> API is scheduling a job -> errors are stored in the database. So, VE doesn't need to call RESTBase to re-render the lint errors, it can just execute an action API query if working from the client side, or depend on Linter extension and get the errors from linter table directly.

Thu, May 28, 3:52 PM · Patch-For-Review, DiscussionTools, VisualEditor
Pchelolo moved T222402: Page or file undelete/restore requests can deadlock (Fatal DBQueryError) from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Thu, May 28, 2:25 PM · Core Platform Team, Wikimedia-production-error, MediaWiki-Page-deletion, MediaWiki-API
Pchelolo edited projects for T251851: Move remaining user rights methods to PermissionManager, added: Core Platform Team Workboards (External Code Reviews); removed Core Platform Team.
Thu, May 28, 2:25 PM · Core Platform Team Workboards (External Code Reviews), Patch-For-Review, User-DannyS712, MediaWiki-User-management, Dependency injection
Pchelolo moved T253716: `tag` log entries should reference tag id rather than name from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Thu, May 28, 2:24 PM · Core Platform Team, MediaWiki-Logging, MediaWiki-Change-tagging, User-DannyS712
Pchelolo moved T253717: Add a factory service for `ManualLogEntry` objects from Inbox to Tracking/Watching on the Core Platform Team board.

ManualLogEntry implements a LogEntry interface, and has a sibling: DatabaseLogEntry with RCDatabaseLogEntry as a specialized dependent. DatabaseLogEntry is only created via static factory methods, not via direct construction.

Thu, May 28, 2:23 PM · Core Platform Team, Dependency injection, User-DannyS712, MediaWiki-Logging

Wed, May 27

Pchelolo moved T249672: Watchlist Expiry: Enforce maximum expiry length when watching pages [medium] from External Code Review In Progress to External Code Review Completed on the Core Platform Team Workboards (External Code Reviews) board.
Wed, May 27, 10:15 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Core Platform Team Workboards (External Code Reviews), Community-Tech (Kanban-2019-20-Q4), TCB-Team, Expiring-Watchlist-Items
Pchelolo added a comment to T251935: All EventGate instances should use EventStreamConfig.

We'd still need to figure out how to make eventgate-wikimedia generate static stream config from EventStreamConfig API at runtime. We'd have to have some script that runs during deployment and gets all stream configs that match stream_config_allowed_settings and renders out a static stream-config.yaml file that is used as the stream_config_uri.

Wed, May 27, 6:54 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Analytics-Kanban, Analytics, Analytics-EventLogging, Event-Platform

Tue, May 26

Pchelolo moved T253149: Regression: UserSaveOptions hook no longer exposes old preference values from Ready to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.

The two patches above introduce the new hook parameter and demonstrate it's usage in an extension. I will make patches to the rest of the extensions once the review of the core patch is completed and we're in agreement on the API.

Tue, May 26, 7:55 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Core Platform Team Workboards (Clinic Duty Team)
Pchelolo added a comment to T175224: Unclear expectations around path/module in $wgVirtualRestConfig.

The ServiceWiring code was introduced in August 2016. Apparently nothing used it until January 2020, when it was used in an experimental REST handler, but that handler will presumably fail in production due to this bug.

Tue, May 26, 1:45 PM · Core Platform Team Legacy (Later), Services (later), Documentation, RESTBase
Pchelolo awarded T253080: Add new ContentModelChangeFactory interface, implement with PageCommandFactory a Like token.
Tue, May 26, 1:40 PM · Core Platform Team, Dependency injection, User-DannyS712, MediaWiki-ContentHandler

Fri, May 15

Pchelolo added a comment to T251015: Move spam regex checks out of EditPage.

Some tests for the new service would be nice.

Fri, May 15, 4:04 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), MediaWiki-extensions-Newsletter, Core Platform Team Workboards (External Code Reviews), Dependency injection, User-DannyS712, MediaWiki-Page-editing
Pchelolo reassigned T252865: Add awawiki to restbase from Zoranzoki21 to hnowlan.

The patches were merged, but have not been deployed yet. I'm on vacation next week, so to unblock you I'm asking Hugh to deploy restbase with your changes next week

Fri, May 15, 1:51 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase

Thu, May 14

Pchelolo added a comment to T252811: Requesting +2 rights for Mediawiki Group for DannyS712.

I very much support this proposal.

Thu, May 14, 7:48 PM · User-DannyS712, MediaWiki-Gerrit-Group-Requests

Wed, May 13

Pchelolo added a comment to T252076: Cover RevisionList/RevisionItem classes with tests.

I was asking @Pchelolo as the person who filed the task, but sure. :-)

Wed, May 13, 8:03 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Test-Coverage, Core Platform Team, User-DannyS712, MediaWiki-General

Tue, May 12

Pchelolo moved T252127: Improve resource-purge request_id and dt propagation from Inbox to Doing on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, May 12, 8:57 PM · ChangeProp, Core Platform Team Workboards (Clinic Duty Team), serviceops
Pchelolo edited projects for T252146: Validate strategy for waiting for Page Content Service content to be updated, added: Product-Infrastructure-Team-Backlog; removed Core Platform Team.

I'm not sure what else to do here.

Tue, May 12, 8:24 PM · Product-Infrastructure-Team-Backlog, RESTBase
Pchelolo added a comment to T252127: Improve resource-purge request_id and dt propagation.

It seems to me like the only thing useful for the purge handler is the timestamp of when the purge event was created by the producer. Anything about what Last-Modified will be or when some cascading chain started seems like things it either can't or shouldn't use, right? Having said that - what will this actually be used for?

Tue, May 12, 6:01 PM · ChangeProp, Core Platform Team Workboards (Clinic Duty Team), serviceops
Pchelolo updated subscribers of T239640: Introduce TalkPageNotificationManager service.

Given that the end goal is not just decoupling, but also moving us closer to fixing the problems with the table described by @Krinkle in T146585#4233276 we need to change the API to perhaps eventually disallow NULL user_last_timestamp so that we're able to switch to upsert and remove duplicated rows, so I have deprecated passing null revision into setNewtalk. However, maybe this requires course correction.

Tue, May 12, 5:40 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (Decoupling (CDP2))
Pchelolo added a subtask for T133821: Make CDN purges reliable: T252127: Improve resource-purge request_id and dt propagation.
Tue, May 12, 4:42 PM · serviceops, Patch-For-Review, Sustainability (MediaWiki-MultiDC), Performance-Team (Radar), Traffic, Operations
Pchelolo added a parent task for T252127: Improve resource-purge request_id and dt propagation: T133821: Make CDN purges reliable.
Tue, May 12, 4:42 PM · ChangeProp, Core Platform Team Workboards (Clinic Duty Team), serviceops
Pchelolo closed T159393: null value in column "user_id" violates not-null constraint on PostgreSQL ("user_newtalk" table) as Resolved.

Both user_id and user_ip in Postgres now have default values, so this should be fixed. See https://gerrit.wikimedia.org/r/c/mediawiki/core/+/589345

Tue, May 12, 4:20 PM · MediaWiki-Export-or-Import, PostgreSQL
Pchelolo added a comment to T251278: Cleanup deprecated calls in production.

We got a few more:

Tue, May 12, 3:13 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), AbuseFilter, Patch-For-Review, Core Platform Team Workboards (Contractor Workboard), MediaWiki-General
Pchelolo moved T252253: Inject services to SpecialBlock rather than summon them through MediaWikiServices class from External Code Review Needed to External Code Review Completed on the Core Platform Team Workboards (External Code Reviews) board.
Tue, May 12, 2:14 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Anti-Harassment, Core Platform Team Workboards (External Code Reviews), User-Urbanecm, Technical-Debt, MediaWiki-Special-pages, MediaWiki-Blocks
Pchelolo moved T252390: Implement check endpoint using the MW:Rest-API from External Code Review Needed to External Code Review In Progress on the Core Platform Team Workboards (External Code Reviews) board.
Tue, May 12, 2:14 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Core Platform Team Workboards (External Code Reviews), Wikimedia-Hackathon-2020, CPT Initiatives (Core REST API in PHP), Math
Pchelolo edited projects for T251599: (Postgres) Error: 42803 ERROR: column "temp_rev_user.revactor_actor" must appear in the GROUP BY clause or be used in an aggregate function, added: Core Platform Team Workboards (External Code Reviews); removed Core Platform Team Workboards (Clinic Duty Team).
Tue, May 12, 2:10 PM · Core Platform Team Workboards (External Code Reviews), MediaWiki-General, Patch-For-Review, PostgreSQL
Pchelolo moved T240307: Hook container with strong types and DI from Waiting for Review to Doing on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, May 12, 2:10 PM · MW-1.33-notes, MW-1.31-release-notes, MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), CPT Initiatives (New Hook System), MediaWiki-Core-Hooks, Dependency injection, Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, TechCom-RFC (TechCom-RFC-Closed), User-Daniel, Core Platform Team
Pchelolo added a comment to T246855: Hook interface doc comment review.

Is his done? Can this be closed?

Tue, May 12, 2:09 PM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General
Pchelolo moved T239856: Fold services recommendations into Standards for services RfC from Waiting for Review to Inbox on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, May 12, 2:08 PM · Core Platform Team Workboards (Clinic Duty Team)
Pchelolo moved T248527: Create UserOptionsManager from Waiting for Review to Ready on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, May 12, 2:08 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, CPT Initiatives (Decoupling (CDP2))
Pchelolo moved T239640: Introduce TalkPageNotificationManager service from Waiting for Review to Ready on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, May 12, 2:08 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (Decoupling (CDP2))

Mon, May 11

Pchelolo reassigned T239640: Introduce TalkPageNotificationManager service from Pchelolo to Clarakosi.
Mon, May 11, 4:31 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (Decoupling (CDP2))
Pchelolo edited projects for T252390: Implement check endpoint using the MW:Rest-API, added: Core Platform Team Workboards (External Code Reviews); removed Core Platform Team.
Mon, May 11, 3:54 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Core Platform Team Workboards (External Code Reviews), Wikimedia-Hackathon-2020, CPT Initiatives (Core REST API in PHP), Math
Pchelolo moved T250209: [Bug] mobile-html cache not invalidated when associated wikidata item is edited from Waiting for deployment to Done on the Core Platform Team Workboards (Clinic Duty Team) board.

We've actually broken purging again, bu fixed now. We are going to finish working on purges soon, so we would stop breaking this.

Mon, May 11, 3:15 PM · Core Platform Team Workboards (Clinic Duty Team), Product-Infrastructure-Team-Backlog, Page Content Service

Fri, May 8

Pchelolo added a comment to T252146: Validate strategy for waiting for Page Content Service content to be updated.

@Pchelolo Thanks for the response, that sounds good. For the case that the user edits the Wikidata description for the article and we don't have a new article revision will it work to request the existing article revision or is the polling method required?

Fri, May 8, 6:00 PM · Product-Infrastructure-Team-Backlog, RESTBase
Pchelolo added a comment to T252146: Validate strategy for waiting for Page Content Service content to be updated.

You're talking about mobile-html endpoint right? It supports providing a revision ID to require a new revision. On normal views it's better to use URI without a revision ID, so that you have better cache hit ratio, but after en edit supplying revision ID in the request will have a lot of benefits:

Fri, May 8, 5:33 PM · Product-Infrastructure-Team-Backlog, RESTBase
Pchelolo moved T252145: Introduce REST entities extensively/upfront to fully represent defined schema in code. from Inbox to Tech Planning Review on the Core Platform Team board.
Fri, May 8, 5:28 PM · Core Platform Team, CPT Initiatives (Core REST API in PHP)
Pchelolo added a project to T252145: Introduce REST entities extensively/upfront to fully represent defined schema in code.: Core Platform Team.
Fri, May 8, 5:27 PM · Core Platform Team, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T239640: Introduce TalkPageNotificationManager service.

Now that the TalkPageNotificationManager was introduced, we can start using it. However, here it will not be a one-to-one replacement for calling methods.

Fri, May 8, 5:06 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (Decoupling (CDP2))
Pchelolo moved T249672: Watchlist Expiry: Enforce maximum expiry length when watching pages [medium] from External Code Review Needed to External Code Review In Progress on the Core Platform Team Workboards (External Code Reviews) board.
Fri, May 8, 5:05 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Core Platform Team Workboards (External Code Reviews), Community-Tech (Kanban-2019-20-Q4), TCB-Team, Expiring-Watchlist-Items
Pchelolo added a comment to T238966: Apply updates for MCR, actor migration, and content migration, to production wikis..

So this means that beta will be up to date as soon as the updater patch merges. We hit a small snag there, but I think this will happen later today. @Reedy you can speed things up be reviewing https://gerrit.wikimedia.org/r/c/mediawiki/core/+/595139 :)

Fri, May 8, 3:44 PM · Cloud-Services, DBA, Schema-change, Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (MCR Schema Migration)
Pchelolo closed T252142: [Bug] mobile-html and summary (possibly other) endpoints not getting updated after edits as Resolved.
Fri, May 8, 2:01 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, ChangeProp, Page Content Service, Product-Infrastructure-Team-Backlog
Pchelolo added a comment to T252142: [Bug] mobile-html and summary (possibly other) endpoints not getting updated after edits.

Tested again. The content is ok after edits.

Fri, May 8, 2:01 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, ChangeProp, Page Content Service, Product-Infrastructure-Team-Backlog

Thu, May 7

Pchelolo added a comment to T252156: Increase in "Main slot of revision [number] not found in database!" after deploy of 1.35.0-wmf.31 to all wikis.

That makes more sense. This one's to blame: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Scribunto/+/589699

Thu, May 7, 8:39 PM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, User-DannyS712, User-brennen, Wikimedia-production-error
Pchelolo added a comment to T249964: 1.35.0-wmf.32 deployment blockers.

Hey @thcipriani yeah... somehow the issue stacked up on this train.

Thu, May 7, 8:16 PM · Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), Release, Train Deployments
Pchelolo added a comment to T252142: [Bug] mobile-html and summary (possibly other) endpoints not getting updated after edits.

Please give it about 10-20 minutes before verifying, it needs to catch up on the backlog

Thu, May 7, 6:38 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, ChangeProp, Page Content Service, Product-Infrastructure-Team-Backlog
Pchelolo moved T252142: [Bug] mobile-html and summary (possibly other) endpoints not getting updated after edits from Inbox to Done on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, May 7, 6:34 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, ChangeProp, Page Content Service, Product-Infrastructure-Team-Backlog
Pchelolo edited projects for T252142: [Bug] mobile-html and summary (possibly other) endpoints not getting updated after edits, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Thu, May 7, 6:34 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, ChangeProp, Page Content Service, Product-Infrastructure-Team-Backlog
Pchelolo added a comment to T252145: Introduce REST entities extensively/upfront to fully represent defined schema in code..

I've had a similar idea before in T237692 but I like this proposal better.

Thu, May 7, 6:33 PM · Core Platform Team, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T237692: Proposal: introduce RESTEntityFormatter.

I'm closing this as a duplicate of T252145 - that approach would be better since not all the representations exist as core MW concepts.

Thu, May 7, 6:32 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo merged T237692: Proposal: introduce RESTEntityFormatter into T252145: Introduce REST entities extensively/upfront to fully represent defined schema in code..
Thu, May 7, 6:31 PM · Core Platform Team, CPT Initiatives (Core REST API in PHP)
Pchelolo merged task T237692: Proposal: introduce RESTEntityFormatter into T252145: Introduce REST entities extensively/upfront to fully represent defined schema in code..
Thu, May 7, 6:31 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T252142: [Bug] mobile-html and summary (possibly other) endpoints not getting updated after edits.

@JoeWalsh should be fixed now. Our sincere apologies, we are going to be done messing with this soon.

Thu, May 7, 6:29 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, ChangeProp, Page Content Service, Product-Infrastructure-Team-Backlog
Pchelolo committed rMSCD383fba598a73: Rename rule following resource-purge (authored by Pchelolo).
Rename rule following resource-purge
Thu, May 7, 6:23 PM
Pchelolo claimed T252142: [Bug] mobile-html and summary (possibly other) endpoints not getting updated after edits.
Thu, May 7, 6:10 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, ChangeProp, Page Content Service, Product-Infrastructure-Team-Backlog
Pchelolo updated subscribers of T252142: [Bug] mobile-html and summary (possibly other) endpoints not getting updated after edits.

I know what's going on. That's me and @hnowlan breaking things. Will fix right away.

Thu, May 7, 6:10 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, ChangeProp, Page Content Service, Product-Infrastructure-Team-Backlog
Pchelolo updated the task description for T252127: Improve resource-purge request_id and dt propagation.
Thu, May 7, 4:03 PM · ChangeProp, Core Platform Team Workboards (Clinic Duty Team), serviceops
Pchelolo created T252127: Improve resource-purge request_id and dt propagation.
Thu, May 7, 3:57 PM · ChangeProp, Core Platform Team Workboards (Clinic Duty Team), serviceops

Wed, May 6

Pchelolo moved T252076: Cover RevisionList/RevisionItem classes with tests from Inbox to Tracking/Watching on the Core Platform Team board.
Wed, May 6, 9:31 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Test-Coverage, Core Platform Team, User-DannyS712, MediaWiki-General
Pchelolo created T252076: Cover RevisionList/RevisionItem classes with tests.
Wed, May 6, 9:30 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Test-Coverage, Core Platform Team, User-DannyS712, MediaWiki-General
Pchelolo added a comment to T252072: Special:RevisionReview: PHP Unknown error: Object of class MediaWiki\Revision\RevisionStoreRecord could not be converted to string.

My bad, missed it in the review :(

Wed, May 6, 9:04 PM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), User-DannyS712, Core Platform Team, Wikimedia-production-error
Pchelolo added a comment to T249284: Incorrect language variant returned for PCS endpoints.

@Pchelolo thanks for updating this documentation - are there specifics about which characters are allowed and which characters need to be encoded?

Wed, May 6, 5:31 PM · Operations, Traffic, Core Platform Team Workboards (Clinic Duty Team), Chinese-Sites, Android-app-Bugs, Product-Infrastructure-Team-Backlog, Page Content Service, Wikipedia-Android-App-Backlog

Tue, May 5

Pchelolo added a comment to T250209: [Bug] mobile-html cache not invalidated when associated wikidata item is edited.

Apologies for the delays. It has happened this morning.

Thanks for the update! It looks like I'm still seeing the same issue. I added a title description to this article with this edit and the page is still outdated. It's properly updated on labs. It looks like the summary hasn't been updated either.

Tue, May 5, 4:19 PM · Core Platform Team Workboards (Clinic Duty Team), Product-Infrastructure-Team-Backlog, Page Content Service
Pchelolo added a comment to T250209: [Bug] mobile-html cache not invalidated when associated wikidata item is edited.

Apologies for the delays. It has happened this morning.

Tue, May 5, 4:01 PM · Core Platform Team Workboards (Clinic Duty Team), Product-Infrastructure-Team-Backlog, Page Content Service
Pchelolo added a comment to T245673: Reader gets page thumbnail with search results.

The FileRepresentation spec calls for 'size' property. However, sine we're doing the thumbnailg lazily it is impossible to know at the time of returning the response. Switching to non-lazy generation of thumbnails just to know the size is not acceptable from the performance perspective. We will be dropping the 'size' key from the response.

Tue, May 5, 2:36 PM · Core Platform Team Workboards (Contractor Workboard), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo updated subscribers of T247798: Core REST API logs calls.

cc @Ottomata ^^ it seems like all these are simple enough to get into our api-request schema.

Tue, May 5, 1:51 PM · Story, Core Platform Team Workboards (User Stories), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Mon, May 4

Pchelolo triaged T251758: LiquidThreads Extension, Threads: Use WikiPage argument instead of Article argument as Low priority.
Mon, May 4, 11:53 PM · MediaWiki-extensions-LiquidThreads, Core Platform Team Workboards (Contractor Workboard)
Pchelolo added a project to T248756: RevisionStore::getRevisionByTitle can fail for foreign wikis when called with TitleValue: Core Platform Team Workboards (External Code Reviews).
Mon, May 4, 11:50 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Core Platform Team Workboards (External Code Reviews), MediaWiki-Revision-backend
Pchelolo added a comment to T250209: [Bug] mobile-html cache not invalidated when associated wikidata item is edited.

But I guess you'll need to do a new chart release and deploy that in order for the new config to take effect — is that correct?

Mon, May 4, 4:55 PM · Core Platform Team Workboards (Clinic Duty Team), Product-Infrastructure-Team-Backlog, Page Content Service
Pchelolo committed rGRBD74db57eb6f10: Beta: add restbase03 to deployment targets (authored by Pchelolo).
Beta: add restbase03 to deployment targets
Mon, May 4, 3:58 PM
Pchelolo committed rGRBDd42ca7b4d673: Update restbase to b222ac19 (authored by Pchelolo).
Update restbase to b222ac19
Mon, May 4, 3:58 PM
Pchelolo moved T245911: Create a wiki for Wikimedia Community User Group Greece from External Code Review Needed to External Code Review Completed on the Core Platform Team Workboards (External Code Reviews) board.

RESTBase configuration deployed.

Mon, May 4, 3:22 PM · Core Platform Team Workboards (External Code Reviews), MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), User-MarcoAurelio, Wiki-Setup (Create), User-Urbanecm
Pchelolo removed a project from T246511: Create beta viwiki: Patch-For-Review.

RESTBase was enabled on the new domain: https://vi.wikipedia.beta.wmflabs.org/api/rest_v1/

Mon, May 4, 2:55 PM · Core Platform Team Workboards (External Code Reviews), User-Urbanecm, Wiki-Setup (Create), Beta-Cluster-Infrastructure, Growth-Team

Sat, May 2

Pchelolo added a comment to T248033: Make Flow use Article::newFromTitle.

I don't think this is much of an improvement - with all the trouble of updating all the extension, we could probably do a more proper solution, like ArticleFactory interface with some MW service implementing it. However, I am not sure we're ready to be doing something like this, and in general untrue of the future of the Article class.

Sat, May 2, 2:25 PM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Growth-Team, StructuredDiscussions, Core Platform Team Workboards (Contractor Workboard)
Pchelolo updated the task description for T239975: Complete WikiPage/Article split and deprecate Page interface.
Sat, May 2, 2:12 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Core Platform Team Workboards (Initiatives), Patch-For-Review, MediaWiki-General
Pchelolo updated the task description for T239975: Complete WikiPage/Article split and deprecate Page interface.
Sat, May 2, 2:08 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Core Platform Team Workboards (Initiatives), Patch-For-Review, MediaWiki-General
Pchelolo moved T231266: ApiQueryCheckUser should use a sensible default limit from External Code Review Completed to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.
Sat, May 2, 1:57 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Core Platform Team Workboards (External Code Reviews), User-DannyS712, CheckUser
Pchelolo moved T251278: Cleanup deprecated calls in production from In Progress/In Review to Blocked on the Core Platform Team Workboards (Contractor Workboard) board.

All the instances of deprecated calls mentioned in this task have been cleaned up, except AbuseFilter. There it seems like the code is correct, but we've been using a cached serialized variable - thus calling on Article. Let's see if it resurrects next week.

Sat, May 2, 12:42 AM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), AbuseFilter, Patch-For-Review, Core Platform Team Workboards (Contractor Workboard), MediaWiki-General
Pchelolo updated the task description for T251278: Cleanup deprecated calls in production.
Sat, May 2, 12:37 AM · MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), AbuseFilter, Patch-For-Review, Core Platform Team Workboards (Contractor Workboard), MediaWiki-General

Fri, May 1

Pchelolo edited projects for T249672: Watchlist Expiry: Enforce maximum expiry length when watching pages [medium], added: Core Platform Team Workboards (External Code Reviews); removed Core Platform Team Workboards (Clinic Duty Team).
Fri, May 1, 5:28 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Core Platform Team Workboards (External Code Reviews), Community-Tech (Kanban-2019-20-Q4), TCB-Team, Expiring-Watchlist-Items
Pchelolo added a comment to T229863: Refactor EventBus mediawiki configuration.

So, one thing that's touching the code around it is: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventBus/+/590471 - not very related, just fyi.

Fri, May 1, 4:55 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Analytics, CPT Initiatives (Modern Event Platform (TEC2)), Analytics-EventLogging, Event-Platform
Pchelolo moved T250209: [Bug] mobile-html cache not invalidated when associated wikidata item is edited from Waiting for Review to Waiting for deployment on the Core Platform Team Workboards (Clinic Duty Team) board.

Ok, heh.. the fix wasn't actually deployed it seems. It's been merged, but not yet moved into production. I'll ping you when it is.

Fri, May 1, 4:00 PM · Core Platform Team Workboards (Clinic Duty Team), Product-Infrastructure-Team-Backlog, Page Content Service
Pchelolo added a comment to T251599: (Postgres) Error: 42803 ERROR: column "temp_rev_user.revactor_actor" must appear in the GROUP BY clause or be used in an aggregate function.

@Pchelolo you said a while ago you might look into putting a postgres mode into MediaWikiDockerDev. Did you get around to doing that?

Fri, May 1, 2:21 PM · Core Platform Team Workboards (External Code Reviews), MediaWiki-General, Patch-For-Review, PostgreSQL

Thu, Apr 30

Pchelolo added a comment to T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n].

Complete stack trace:

Thu, Apr 30, 10:29 PM · MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Core Platform Team Workboards (Clinic Duty Team), User-brennen, Wikidata-Campsite, Wikimedia-production-error, Wikimedia-Rdbms, Wikidata
Pchelolo added a comment to T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n].

It's PageEditStash. See my comment above.

Thu, Apr 30, 8:51 PM · MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Core Platform Team Workboards (Clinic Duty Team), User-brennen, Wikidata-Campsite, Wikimedia-production-error, Wikimedia-Rdbms, Wikidata
Pchelolo added a comment to T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n].

The other associated log actually gives more insight on which lock is making the transaction timeout:

Thu, Apr 30, 8:45 PM · MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Core Platform Team Workboards (Clinic Duty Team), User-brennen, Wikidata-Campsite, Wikimedia-production-error, Wikimedia-Rdbms, Wikidata
Pchelolo added a comment to T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n].

@daniel I don't think this is that lock showing up here. Reading the code, it seems like if that lock was taken, we should've seen a bunch more queries in this transaction, like some deletes, read from the archive table etc.

Thu, Apr 30, 7:27 PM · MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Core Platform Team Workboards (Clinic Duty Team), User-brennen, Wikidata-Campsite, Wikimedia-production-error, Wikimedia-Rdbms, Wikidata
Pchelolo added a comment to T250209: [Bug] mobile-html cache not invalidated when associated wikidata item is edited.

The content that was already stored will not be regenerated right away after this change. If you want to regenerate all the content, I guess we'd have to truncate mobile-html table, or do a dump or bump the mobile-html version

Thu, Apr 30, 7:17 PM · Core Platform Team Workboards (Clinic Duty Team), Product-Infrastructure-Team-Backlog, Page Content Service
Pchelolo added a comment to T251457: LoadBalancer: Transaction spent [n] second(s) in writes, exceeding the limit of [n].

Looking at the requestId of one of these errors, the following log messages are found: https://logstash.wikimedia.org/goto/3e387a16e01ae0f02e72b413d6691539

Thu, Apr 30, 6:48 PM · MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Core Platform Team Workboards (Clinic Duty Team), User-brennen, Wikidata-Campsite, Wikimedia-production-error, Wikimedia-Rdbms, Wikidata
Pchelolo closed T249770: Inconsistent caching/staleness of mobile-html responses for certain articles as Resolved.

Seems like all the mysteries here have been resolved. Additinally, I verified we're purging mobile-html in the same cases when we purge the old mobile-sections, so we should be good.

Thu, Apr 30, 6:39 PM · Traffic, Operations, Core Platform Team Workboards (Clinic Duty Team), RESTBase, Product-Infrastructure-Team-Backlog
Pchelolo closed T96113: Set up dedicated local-dc runners for 'enqueue' router jobs as Invalid.

We do not use enqueue job anymore in the wikimedia job queue.

Thu, Apr 30, 6:20 PM · Core Platform Team, Sustainability (MediaWiki-MultiDC), WMF-JobQueue