Page MenuHomePhabricator

Pchelolo
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 24 2015, 10:23 AM (233 w, 1 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Pchelolo [ Global Accounts ]

Recent Activity

Fri, Dec 6

Pchelolo committed rGRBDc2bab5d191ba: Update restbase to 8068d7a (authored by Pchelolo).
Update restbase to 8068d7a
Fri, Dec 6, 10:45 PM

Thu, Dec 5

Pchelolo added a comment to T230842: Contributor creates a page.

Given that EditPage is undergoing massive refactoring, are we not going to be writing code to immediately through it away soon?

Thu, Dec 5, 9:38 PM · Core Platform Team Workboards (Green), Story, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T239743: Provide cached access to Parsoid PHP within core.

@Pchelolo but we can rely on a library in core, right? Could we just depend on the Parsoid/PHP library, not the Parsoid/PHP MW extension?

Thu, Dec 5, 9:04 PM · User-ArielGlenn, Parsoid-PHP, Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T239743: Provide cached access to Parsoid PHP within core.

We can't rely on Parsoid while it's an extension from within core, so this logic will go into the extension now ad will be moved over when Parsoid is not an extension anymore.

Thu, Dec 5, 9:02 PM · User-ArielGlenn, Parsoid-PHP, Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T239843: Reader gets list of contributors to a page.

Ummmmm... duh. Should we change this to user name instead? It's mostly for segmenting the list, rather than clients caring that much. The order of editors is arbitrary and up to the implementation.

Thu, Dec 5, 7:00 PM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T239843: Reader gets list of contributors to a page.

@WDoranWMF I wonder if we could get data from analytics about this?

Thu, Dec 5, 6:56 PM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Wed, Dec 4

Pchelolo added a comment to T239743: Provide cached access to Parsoid PHP within core.

A couple more questions I have after digging a bit into the parsoid php code, I have a bunch more questions:

Wed, Dec 4, 7:03 PM · User-ArielGlenn, Parsoid-PHP, Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T239843: Reader gets list of contributors to a page.

These contributors should only be users who've made edits on the shortest path in the edit history.

Wed, Dec 4, 5:56 PM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Tue, Dec 3

Pchelolo added a comment to T229663: Contributor gets page source.

Yeah, that's why the definition was changed to

Tue, Dec 3, 11:04 PM · Patch-For-Review, Core Platform Team Workboards (Green), MediaWiki-REST-API, Story, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T238374: Client Developer uses client-side cache.

@Pchelolo Thank you for writing this up. I would agree with initially going with 1 minute as the default for now. But I'm curious how can we track and tune it long term? Is there data captured on what "normal" is?

Tue, Dec 3, 10:24 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo created T239753: Figure out a way to inject/request a current user from REST API handlers.
Tue, Dec 3, 8:58 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo updated the task description for T236172: Implement get language links endpoint.
Tue, Dec 3, 8:26 PM · Patch-For-Review, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo moved T236172: Implement get language links endpoint from Done to Ready on the Core Platform Team Workboards (Green) board.
Tue, Dec 3, 8:25 PM · Patch-For-Review, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo moved T235782: Specify Canonical Version of MW REST API URI from Ready to Backlog on the Core Platform Team Workboards (Green) board.
Tue, Dec 3, 8:23 PM · CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo added a comment to T239742: Should npm packages maintained by Wikimedia be scoped or unscoped?.

We haven't been using scoped packages in the past because Debian Jessie npm version was too old to support them, but nowadays that's not a problem anymore

Tue, Dec 3, 7:16 PM · Readers-Web-Backlog (Tracking), Release-Engineering-Team-TODO, Front-end-Standards-Group, Core Platform Team, Product-Infrastructure-Team-Backlog
Pchelolo created T239743: Provide cached access to Parsoid PHP within core.
Tue, Dec 3, 7:14 PM · User-ArielGlenn, Parsoid-PHP, Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T238374: Client Developer uses client-side cache.

There was some misunderstanding about what 'cache-control' role in here.

Tue, Dec 3, 6:58 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T238376: System Administrator uses object cache to lower database traffic.

Depending on the target performance. I think it will perform pretty well as is. Purging this cache will not be very complicated, but I doubt the benefit/complexity ratio

Tue, Dec 3, 5:42 PM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T238374: Client Developer uses client-side cache.

Yeah :) We can probably add some staleness for the client-side caching. As for revalidation headers - I don't see a way to do it more efficient then reloading the whole response. Can do that to save up a bit on data transfer.

Tue, Dec 3, 5:32 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T229663: Contributor gets page source.

This is a "MUST", so we really don't have a lot of options.

Tue, Dec 3, 5:08 PM · Patch-For-Review, Core Platform Team Workboards (Green), MediaWiki-REST-API, Story, CPT Initiatives (Core REST API in PHP)
Pchelolo moved T237430: Add object caching and PoolCounter to minor edit count endpoint from Waiting for Review to Done on the Core Platform Team Workboards (Green) board.
Tue, Dec 3, 4:07 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Performance Issue, Core Platform Team Workboards (Green), MediaWiki-REST-API
Pchelolo added a comment to T229663: Contributor gets page source.

contributors: array of User objects for the contributors to the page, each with these properties
id: user ID
name: user name

Tue, Dec 3, 2:35 AM · Patch-For-Review, Core Platform Team Workboards (Green), MediaWiki-REST-API, Story, CPT Initiatives (Core REST API in PHP)
Pchelolo updated subscribers of T238374: Client Developer uses client-side cache.

Also important is making sure we flush the Varnish cache when an object is edited, deleted, or undeleted.

Tue, Dec 3, 2:15 AM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T236113: API developer creates automated documentation.

A couple more thoughts:

Tue, Dec 3, 12:57 AM · Core Platform Team Workboards (Green), Story, CPT Initiatives (Core REST API in PHP)
Pchelolo updated subscribers of T238376: System Administrator uses object cache to lower database traffic.

I guess we eventually would want to get rid of this?

Tue, Dec 3, 12:37 AM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Mon, Dec 2

Pchelolo added a comment to T236113: API developer creates automated documentation.

There was a lot of resistance to the idea of having an endpoint for OpenAPI 3.0 definitions of the (other) endpoints.

Mon, Dec 2, 11:47 PM · Core Platform Team Workboards (Green), Story, CPT Initiatives (Core REST API in PHP)
Pchelolo moved T237562: Curator reads minor flag of a revision from Next Sprint to Done on the Core Platform Team Workboards (Green) board.
Mon, Dec 2, 9:53 PM · Core Platform Team Workboards (Green), MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T236113: API developer creates automated documentation.

https://github.com/zircote/swagger-php is a tool worths looking at.

Mon, Dec 2, 8:54 PM · Core Platform Team Workboards (Green), Story, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T230495: Partition CirrusSearch mediawiki jobs by cluster.

Seems like after the last deploy the jobs are being partitioned according to the cluster correctly.

Mon, Dec 2, 5:33 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Discovery-Search (Current work), Core Platform Team Workboards (Clinic Duty Team), Cloud-Services, Elasticsearch, Discovery

Wed, Nov 27

Pchelolo closed T219548: restbase-mod-table-* simplification and improvements as Declined.
Wed, Nov 27, 7:10 PM · Core Platform Team (Needs Cleaning - Cassandra Operational), RESTBase
Pchelolo removed a project from T239087: Remove mocha-eslint in graphoid: Core Platform Team (Needs Cleaning - Services Operations).
Wed, Nov 27, 7:10 PM · Graphoid, User-Clarakosi

Tue, Nov 26

Pchelolo closed T239135: Create partitioned CirrusSearchElasticaWrite topic, a subtask of T230495: Partition CirrusSearch mediawiki jobs by cluster, as Resolved.
Tue, Nov 26, 8:02 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Discovery-Search (Current work), Core Platform Team Workboards (Clinic Duty Team), Cloud-Services, Elasticsearch, Discovery
Pchelolo closed T239135: Create partitioned CirrusSearchElasticaWrite topic as Resolved.

Done.

Tue, Nov 26, 8:02 PM · Analytics, Cloud-Services, Elasticsearch, Discovery-Search, Discovery

Mon, Nov 25

Pchelolo added a comment to T239135: Create partitioned CirrusSearchElasticaWrite topic.

DISCLAIMER: I assume that the .partitioned. name was discussed and decided, don't want to get into the naming bikeshedding in here :D

Mon, Nov 25, 6:00 PM · Analytics, Cloud-Services, Elasticsearch, Discovery-Search, Discovery
Pchelolo added a comment to T239135: Create partitioned CirrusSearchElasticaWrite topic.

I believe these should do it?

Mon, Nov 25, 5:47 PM · Analytics, Cloud-Services, Elasticsearch, Discovery-Search, Discovery
Pchelolo created T239135: Create partitioned CirrusSearchElasticaWrite topic.
Mon, Nov 25, 5:39 PM · Analytics, Cloud-Services, Elasticsearch, Discovery-Search, Discovery
Pchelolo added a comment to T237854: Client Developer knows semantic version of API.

Ok, I can live with the coredev thing.

Mon, Nov 25, 2:41 PM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Fri, Nov 22

Pchelolo reassigned T236168: Implement basic search endpoint from nnikkhoui to apaskulin.
Fri, Nov 22, 6:57 PM · Patch-For-Review, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo updated the task description for T236168: Implement basic search endpoint.
Fri, Nov 22, 6:56 PM · Patch-For-Review, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo closed T204754: HyperSwitch parameter validation allows empty string params as Declined.
Fri, Nov 22, 5:59 PM · Core Platform Team, User-Clarakosi, good first task, RESTBase, HyperSwitch
Pchelolo closed T179374: Use one keyspace per storage group as Declined.
Fri, Nov 22, 5:58 PM · Core Platform Team, Cassandra, RESTBase
Pchelolo closed T202300: RESTBase passes through the user-agent as Declined.
Fri, Nov 22, 5:58 PM · Core Platform Team, User-Clarakosi, RESTBase, good first task
Pchelolo moved T199431: Consider the possibility of separating ChangeProp and JobQueue on Kafka level from Services Tech Debt to Icebox on the Core Platform Team board.
Fri, Nov 22, 5:58 PM · Core Platform Team, Analytics, Wikimedia-Incident, ChangeProp, MediaWiki-JobQueue, Operations
Pchelolo added a comment to T199431: Consider the possibility of separating ChangeProp and JobQueue on Kafka level.

It's still a viable idea, but I don't think we have the capacity to work on it now. Icebox.

Fri, Nov 22, 5:58 PM · Core Platform Team, Analytics, Wikimedia-Incident, ChangeProp, MediaWiki-JobQueue, Operations
Pchelolo moved T182827: Support X-Wikimedia-Debug header for services from Services Tech Debt to Icebox on the Core Platform Team board.
Fri, Nov 22, 5:57 PM · Core Platform Team, Mobile-Content-Service, Parsoid, Product-Infrastructure-Team-Backlog
Pchelolo closed T229487: Deprecate and remove support for x-request/setup-handler as Declined.
Fri, Nov 22, 5:57 PM · Core Platform Team, RESTBase
Pchelolo moved T201526: Simplify change-propagation configuration from Services Tech Debt to Icebox on the Core Platform Team board.
Fri, Nov 22, 5:57 PM · Core Platform Team, Dependency-Tracking, User-mobrovac
Pchelolo closed T182259: Create scripts to estimate Kafka queue size per wiki as Declined.
Fri, Nov 22, 5:57 PM · Core Platform Team (Needs Cleaning - Services Operations), MediaWiki-JobQueue, Event-Platform, Analytics
Pchelolo closed T175874: RESTBase's and Parsoid's configs in MW-Vagrant don't contain additional domains as Declined.

Given that we're planning to get rid of JS parsoid and RESTBase, I'm declining this.

Fri, Nov 22, 5:56 PM · Core Platform Team (Needs Cleaning - Services Operations), RESTBase, Parsoid, MediaWiki-Vagrant
Pchelolo closed T191900: /data/lists is enabled everywhere but ReadingLists is not as Declined.

Given that there's an idea to move reading lists rest api into PHP, I'm declining this.

Fri, Nov 22, 5:56 PM · Core Platform Team (Needs Cleaning - Services Operations), RESTBase-API, RESTBase, Product-Infrastructure-Team-Backlog, Reading List Service
Pchelolo moved T202001: Don't include requests from automated checks in stats from Needs Cleaning - Services Operations to Icebox on the Core Platform Team board.
Fri, Nov 22, 5:55 PM · Core Platform Team, Citoid
Pchelolo added a comment to T202001: Don't include requests from automated checks in stats.

This is still a viable idea, but I don't think we have the capacity to work on it right now. Maybe after migrating to prometheus.

Fri, Nov 22, 5:55 PM · Core Platform Team, Citoid
Pchelolo moved T182372: Make Kafka JobQueue use Special:RunSingleJob from Needs Cleaning - Services Operations to Icebox on the Core Platform Team board.
Fri, Nov 22, 5:54 PM · Core Platform Team, MediaWiki-JobQueue, User-mobrovac, ChangeProp, Analytics, Event-Platform
Pchelolo removed a project from T133001: Decom legacy ex-parsoidcache cxserver, citoid, and restbase service hostnames: Core Platform Team (Needs Cleaning - Services Operations).

Nothing to do here for the core platform team anymore.

Fri, Nov 22, 5:53 PM · Patch-For-Review, CX-cxserver, VisualEditor, Citoid, RESTBase, Traffic, Operations
Pchelolo closed T140049: Maximum number of redirects reached / error message returned even when doi is available as Declined.

Given that there's been no activity since 2017, I'll close this.

Fri, Nov 22, 5:52 PM · Core Platform Team (Needs Cleaning - Services Operations), Citoid
Pchelolo closed T219923: Move graphoid logging to new logging pipeline, a subtask of T211125: Move service-runner to new logging infrastructure, as Declined.
Fri, Nov 22, 5:52 PM · observability, Core Platform Team Legacy (Watching / External), Patch-For-Review, service-runner, Wikimedia-Logstash, Operations
Pchelolo closed T219923: Move graphoid logging to new logging pipeline as Declined.

Graphoid is likely going away, so we shouldn't work on this.

Fri, Nov 22, 5:52 PM · observability, Core Platform Team (Needs Cleaning - Services Operations), service-runner, Wikimedia-Logstash, Operations
Pchelolo closed T183586: Separate ChangeProp and JobQueue Redis, a subtask of T157088: [EPIC] Develop a JobQueue backend based on EventBus, as Declined.
Fri, Nov 22, 5:52 PM · WMF-JobQueue, Core Platform Team Workboards (Done with CPT), Services (done), MediaWiki-JobQueue, Epic, User-mobrovac, Analytics, ChangeProp, Event-Platform
Pchelolo closed T183586: Separate ChangeProp and JobQueue Redis as Declined.

the idea is still solid, but I don't think there's a pressing need to do it now.

Fri, Nov 22, 5:51 PM · Core Platform Team (Needs Cleaning - Services Operations), Kubernetes, Analytics, MediaWiki-JobQueue, User-mobrovac, ChangeProp, Event-Platform
Pchelolo edited projects for T196591: Unable to install Math as "mathoid" role on MediaWiki-Vagrant on labs, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team (Needs Cleaning - Services Operations).

I will verify if it's still the case

Fri, Nov 22, 5:51 PM · Core Platform Team Workboards (Clinic Duty Team), Math, Mathoid, MediaWiki-Vagrant
Pchelolo closed T210460: Eliminate usage of mocha-eslint as Resolved.

I've created individual tickets for the services still not addressed. Closing this umbrella ticket.

Fri, Nov 22, 5:48 PM · Core Platform Team (Needs Cleaning - Services Operations), User-Clarakosi
Pchelolo created T238937: Eliminate usage of mocha-eslint from eventstreams.
Fri, Nov 22, 5:48 PM · Analytics-Kanban, Analytics, Event-Platform, Wikimedia-Stream
Pchelolo created T238936: Eliminate usage of mocha-eslint from cxserver.
Fri, Nov 22, 5:47 PM · CX-cxserver
Pchelolo created T238935: Eliminate usage of mocha-eslint from proton.
Fri, Nov 22, 5:45 PM · patch-welcome, Technical-Debt, good first task, Proton, Product-Infrastructure-Team-Backlog

Thu, Nov 21

Pchelolo moved T235666: REST: Add 'from' and 'to' parameters to historycount endpoint. from Ready to Done on the Core Platform Team Workboards (Green) board.
Thu, Nov 21, 9:44 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Pchelolo placed T235666: REST: Add 'from' and 'to' parameters to historycount endpoint. up for grabs.
Thu, Nov 21, 9:44 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Pchelolo assigned T235666: REST: Add 'from' and 'to' parameters to historycount endpoint. to apaskulin.
Thu, Nov 21, 9:42 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Pchelolo moved T237430: Add object caching and PoolCounter to minor edit count endpoint from Doing to Waiting for Review on the Core Platform Team Workboards (Green) board.
Thu, Nov 21, 9:41 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Performance Issue, Core Platform Team Workboards (Green), MediaWiki-REST-API
Pchelolo added a comment to T238849: Post switchover to Parsoid/PHP on private wikis, VE edit saves on officewiki responded with a HTTP 412.

The if-unmodified-since in RESTBase is used for an optimization, but it almost never kicks in for external requests, mostly it's relevant for change-prop. So I think we can just remove this header from the client request

Thu, Nov 21, 9:13 PM · User-Ryasmeen, Patch-For-Review, Parsoid-PHP, VisualEditor
Pchelolo moved T235666: REST: Add 'from' and 'to' parameters to historycount endpoint. from Ready to Waiting for Review on the Core Platform Team Workboards (Green) board.
Thu, Nov 21, 6:57 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T238846: Prod compare endpoint missing offset object (with from & to keys) on diff items.

No surprise. @jijiki has deployed 1.10 to labs machines as indicated in the parent task, but not yet on prod machines, pending verification that it works correctly in labs.

Thu, Nov 21, 5:45 PM · serviceops, Operations, wikidiff2, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo moved T237430: Add object caching and PoolCounter to minor edit count endpoint from Ready to Doing on the Core Platform Team Workboards (Green) board.
Thu, Nov 21, 2:58 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Performance Issue, Core Platform Team Workboards (Green), MediaWiki-REST-API

Wed, Nov 20

Pchelolo added a comment to T236963: Deploy version 1.10.0 of wikidiff2 to production.

Hehe... @jijiki could you do deployment-parsoid as well please?

Wed, Nov 20, 10:16 PM · serviceops, Operations, wikidiff2, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo claimed T235782: Specify Canonical Version of MW REST API URI.
Wed, Nov 20, 10:08 PM · CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Pchelolo claimed T237430: Add object caching and PoolCounter to minor edit count endpoint.
Wed, Nov 20, 10:05 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Performance Issue, Core Platform Team Workboards (Green), MediaWiki-REST-API
Pchelolo added a comment to T237854: Client Developer knows semantic version of API.

The core REST API is already a part of MediaWiki core and MW has it's own versioning scheme. Introducing one more version will create a lot of confusion. Installing MW LTS release v1.xx - which core REST API minor version do I get? Where do I look it up? What does the semantic REST API version give me? Can I install a specific version on top of a different MW release? All of these are rithorical questions for the purpose of the ticket. TLDR: If core REST was implemented as an extension, this could make sense. Since it's a part of the core, it should follow the core versioning scheme.

Wed, Nov 20, 4:04 PM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Thu, Nov 14

Pchelolo added a comment to T238377: Minor edit count endpoint is failing.

This is hitting the revision limit that was specified in the task when we implemented it. So it's a feature not a bug.

Thu, Nov 14, 10:26 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP), MediaWiki-REST-API
Pchelolo added a comment to T230845: Reader gets media links.

It's implemented in the mobile-content-service. https://gerrit.wikimedia.org/r/admin/projects/mediawiki/services/mobileapps

Thu, Nov 14, 2:40 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)

Nov 10 2019

Pchelolo added a comment to T237577: Curator undoes a revision.

Because the distinction is made in our Web UI. It's a user-level abstraction, and we should support both.

Nov 10 2019, 3:46 PM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Nov 8 2019

Pchelolo closed T237568: Deduplicate REST error messages as Resolved.
Nov 8 2019, 8:13 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo closed T237568: Deduplicate REST error messages, a subtask of T237565: REST API Infrastructure in MediaWiki, as Resolved.
Nov 8 2019, 8:13 PM · Core Platform Team Workboards (Epics), Epic, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Nov 7 2019

Pchelolo updated the task description for T237692: Proposal: introduce RESTEntityFormatter.
Nov 7 2019, 10:03 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo created T237692: Proposal: introduce RESTEntityFormatter.
Nov 7 2019, 9:59 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T237670: Fatal when trying to undo Commons edits: InvalidArgumentException "Unsaved old revision passed" from RevisionStore.

Seems to be a duplicate of T236320

Nov 7 2019, 8:59 PM · MediaWiki-Page-editing, Core Platform Team, MediaWiki-Revision-backend, Wikimedia-production-error
Pchelolo added a comment to T237577: Curator undoes a revision.

One more thing to consider after reading the documentation https://en.wikipedia.org/wiki/Help:Reverting#Undo - it seems like undo on MW has a bit of a different process then revert - a contributor is presented with a diff to review before committing the action. In both of the proposed endpoints there's no way of following the same process for undoing - the compare endpoint wouldn't be able to provide a diff like that. So, if we DO want to support the same process as the core, we need additional endpoints.

Nov 7 2019, 7:11 PM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T237562: Curator reads minor flag of a revision.

The patch above adds minor flag to both /revision/{id}/bare and /page/{title}/history endpoints.

Nov 7 2019, 6:39 PM · Core Platform Team Workboards (Green), MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T229663: Contributor gets page source.

I'd really like the GET and PUT URLs to be the same.

Nov 7 2019, 6:33 PM · Patch-For-Review, Core Platform Team Workboards (Green), MediaWiki-REST-API, Story, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T235241: Curator reads a revision online.

200 – this is the page
404 – revision does not exist (never created or deleted)

Nov 7 2019, 6:22 PM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo closed T237646: Get sample of Kafka message types processed by ChangeProp as Resolved.

There's 100.000 resource_change events here https://people.wikimedia.org/~ppchelko/resource_change_events

Nov 7 2019, 6:14 PM
Pchelolo added a comment to T221167: REST API Client Developer uses Gzip content encoding.

There's no HTTP standard for gzipped request bodies, as far as I know. Is there a standard?

Nov 7 2019, 6:09 PM · CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (User Stories), MediaWiki-REST-API
Pchelolo added a comment to T235072: Curator reverts to a previous revision.

I have posted the first round of comments about this story in the undo story T237577#5645099cause they are very similar. I have more comments about this one, but we first need to go through the first round, that might make the rest of the comments not relevant.

Nov 7 2019, 6:00 PM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T237577: Curator undoes a revision.

This endpoint is quite similar to rollback endpoint T235072 and a lot of comments/questions/ideas would apply to both or are cross-cutting between them, so I will comment once here, but please be aware that it mostly applies to both.

Nov 7 2019, 5:54 PM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo moved T237115: Curator gets limited revision count from Needs Review to Done! on the Core Platform Team Workboards (User Stories) board.

The patch was merged. Nothing to do here, making an integration test to check that 1001 revisions are not queried doesn't seem feasible.

Nov 7 2019, 2:34 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (User Stories), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Nov 6 2019

Pchelolo added a comment to T237115: Curator gets limited revision count.

Updated the patch to set the limit to 1000.

Nov 6 2019, 10:26 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (User Stories), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T236930: API Developer supports different request media types.

Should we consider deprecating sending non-json input?

Nov 6 2019, 10:22 PM · Patch-For-Review, Core Platform Team Workboards (Green), Story, CPT Initiatives (Parsoid REST API in PHP (CDP2)), MediaWiki-REST-API, Parsoid-PHP
Pchelolo added a comment to T233634: Modern Event Platform: Stream Configuration: Implementation.

yeah, I understand. I mean, once in eventuate you have the map, you'd need pretty much the same code as you'd need in the stream config extension to map the actual stream name to the config. Thus, loosing the array ordering will make it possibly inconsistent

Nov 6 2019, 8:33 PM · Core Platform Team Workboards (Clinic Duty Team), Analytics-Kanban, Product-Infrastructure-Team-Backlog (Kanban), MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, Performance-Team (Radar), Better Use Of Data, CPT Initiatives (Modern Event Platform (TEC2)), Goal, Services (watching), Analytics-EventLogging, Event-Platform, Analytics
Pchelolo added a comment to T230845: Reader gets media links.

I know reading infrastructure were using https://en.wikipedia.org/wiki/User:BSitzmann_(WMF)/MCS/Test/Frankenstein as a page with a lot of different weird characteristics.

Nov 6 2019, 8:29 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T233634: Modern Event Platform: Stream Configuration: Implementation.

mmm... if we convert the array into a key-value map, we loose the ordering of the array. Thus, we can't do that thing when stream matching works for the first match in the array.

Nov 6 2019, 8:26 PM · Core Platform Team Workboards (Clinic Duty Team), Analytics-Kanban, Product-Infrastructure-Team-Backlog (Kanban), MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, Performance-Team (Radar), Better Use Of Data, CPT Initiatives (Modern Event Platform (TEC2)), Goal, Services (watching), Analytics-EventLogging, Event-Platform, Analytics
Pchelolo created T237568: Deduplicate REST error messages.
Nov 6 2019, 7:06 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Pchelolo added a comment to T230846: Reader gets language links.

It's "almost" standard https://www.mediawiki.org/wiki/Manual:Language#Language_code

Nov 6 2019, 4:54 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)