Pchelolo
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 24 2015, 10:23 AM (91 w, 1 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Pchelolo

Recent Activity

Yesterday

Pchelolo created T161255: Modify RESTBase blacklist to take regexes.
Thu, Mar 23, 9:20 PM · Services (doing), RESTBase
Pchelolo added a comment to T160573: Special:LintErrors page had not been updated more than 90 mins after a page has been edited to fix errors.

Here's the event from Kafka that was processed:

{  
   "comment":"Lint errors",
   "database":"mediawikiwiki",
   "meta":{  
      "domain":"www.mediawiki.org",
      "dt":"2017-03-21T13:56:40+00:00",
      "id":"35735e8f-0e3e-11e7-9813-b083fecf0c72",
      "request_id":"54e949da-94aa-49ee-a487-f5110a9668f6",
      "schema_uri":"mediawiki/revision/create/1",
      "topic":"mediawiki.revision-create",
      "uri":"https://www.mediawiki.org/wiki/Extension:UploadLogo"
   },
   "page_id":636946,
   "page_is_redirect":false,
   "page_namespace":102,
   "page_title":"Extension:UploadLogo",
   "performer":{  
      "user_groups":[  
         "sysop",
         "translationadmin",
         "*",
         "user",
         "autoconfirmed"
      ],
      "user_id":472859,
      "user_is_bot":false,
      "user_text":"Shirayuki"
   },
   "rev_content_format":"wikitext",
   "rev_content_model":"wikitext",
   "rev_id":2427878,
   "rev_len":1866,
   "rev_minor_edit":false,
   "rev_parent_id":2382189,
   "rev_sha1":"qi27jrcf6nn0webnlfelkkmbeorasex",
   "rev_timestamp":"2017-03-21T13:56:40Z"
}
Thu, Mar 23, 4:38 AM · ChangeProp, MediaWiki-extensions-Linter

Wed, Mar 22

Pchelolo added a comment to T149331: Node 6 upgrade planning.

Vagrant was updated to node 6 as well.

Wed, Mar 22, 11:48 PM · User-Ryasmeen, Services (done), Reading-Web-Trending-Service, Language-Engineering October-December 2016, ContentTranslation-Deployments, ContentTranslation, ContentTranslation-CXserver, Analytics, ChangeProp, Citoid, Graphoid, VisualEditor, Mobile-Content-Service, User-mobrovac, Parsing-Team, Operations
Pchelolo added a comment to T161127: Error: Could not apply complete catalog: Found 1 dependency cycle.

And I'm on OS X Sierra if that helps as well.

Wed, Mar 22, 11:17 PM · User-bd808, User-zeljkofilipin, MediaWiki-Vagrant
Pchelolo added a comment to T161127: Error: Could not apply complete catalog: Found 1 dependency cycle.

That is happening for me as well, but only if nfs_share is enabled. If it's disabled - not happening.

Wed, Mar 22, 11:15 PM · User-bd808, User-zeljkofilipin, MediaWiki-Vagrant
Pchelolo committed rMSER6a3ed5d77034: Use node 4.6 for building the deploy repo (authored by mobrovac).
Use node 4.6 for building the deploy repo
Wed, Mar 22, 10:51 PM
Pchelolo committed rMSERa2493a89d392: Upgrade to Node v6.9.1 (authored by Pchelolo).
Upgrade to Node v6.9.1
Wed, Mar 22, 10:51 PM
Pchelolo committed rMSERdd5383461d45: Add files needed for the build process and ignore Dockerfile (authored by mobrovac).
Add files needed for the build process and ignore Dockerfile
Wed, Mar 22, 10:51 PM
Pchelolo committed rMSER3f0e9a03fef7: Add .gitreview (authored by QChris).
Add .gitreview
Wed, Mar 22, 10:51 PM
Pchelolo added a comment to T160764: Update electron render service.

https://gerrit.wikimedia.org/r/#/c/344223/ Updates it to 0.10.0 - the latest tagged version.

Wed, Mar 22, 10:03 PM · Services (next)
Pchelolo edited projects for T158702: Page properties-change event is rejected if page was deleted, added: Services (done); removed Patch-For-Review, Services (next).

Patch merged. Moving to 'done' until it gets deployed.

Wed, Mar 22, 8:55 PM · Services (done), MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), EventBus, Analytics
Pchelolo closed T160208: Cannot read property 'process' of undefined, a subtask of T150354: Implement Node6 support for Kartotherian/Tilerator, as "Resolved".
Wed, Mar 22, 6:30 PM · Patch-For-Review, Interactive-Sprint, Maps (Kartotherian), Discovery
Pchelolo closed T160208: Cannot read property 'process' of undefined as "Resolved".

I guess after production was updated to node 6 and this didn't happen any more I can resolve this task.

Wed, Mar 22, 6:30 PM · Services (done), User-mobrovac, Interactive-Sprint, service-runner, Maps (Kartotherian)

Mon, Mar 20

Pchelolo committed rMSTEDe05b4864b880: Set 'trends_at' property for the purge_strategy (authored by Pchelolo).
Set 'trends_at' property for the purge_strategy
Mon, Mar 20, 10:44 PM
Pchelolo committed rMSTEDe4fa9b895464: Config: Set 'trends_at' property for the purge_strategy (authored by Pchelolo).
Config: Set 'trends_at' property for the purge_strategy
Mon, Mar 20, 10:44 PM
Pchelolo committed rMSTED5d3eb7f66e35: Update trending-edits to 7ef7176 (authored by Pchelolo).
Update trending-edits to 7ef7176
Mon, Mar 20, 10:44 PM
Pchelolo added a comment to T159615: [spec] Active-active setup for ORES across datacenters (eqiad, codfw).

Hm, that would activate CP for the whole ensemble of messages for the other DC.

Mon, Mar 20, 10:09 PM · Services (designing), User-mobrovac, ORES, Operations, Revision-Scoring-As-A-Service-Backlog
Pchelolo added a comment to T159615: [spec] Active-active setup for ORES across datacenters (eqiad, codfw).

How about replicating the precaching redis instance across DCs? Would that be feasible? It seems slightly less spaghetti-like than sending double requests in CP, which would be feasible, but ugly as we would need to replicate the current ORES portion of the config for the second DC, i.e. create a new rule for it.

Mon, Mar 20, 9:46 PM · Services (designing), User-mobrovac, ORES, Operations, Revision-Scoring-As-A-Service-Backlog
Pchelolo added a comment to T160942: Create mediawiki.page-restrictions-change event.

One minor problem: normally in our events for changed properties we would have old values and new values, but the ArticleProtectionComplete hook provides only the new values, but there's no way to get old values. We can add a way to get them, but since we don't have a use-case for old values, I guess we could skip that and not add them right now. What do you think?

Mon, Mar 20, 7:50 PM · Patch-For-Review, Services (next), Analytics, EventBus
Pchelolo added a comment to T154899: Protected pages should be excluded from trending results.

Made a subtask to track EventBus changes. Will try to poke around the schema and see what data can we get from the hook.

Mon, Mar 20, 7:26 PM · Reading-Web-Trending-Service
Pchelolo created T160942: Create mediawiki.page-restrictions-change event.
Mon, Mar 20, 7:25 PM · Patch-For-Review, Services (next), Analytics, EventBus
Pchelolo added a comment to T154899: Protected pages should be excluded from trending results.

@mobrovac Hm... The page-properties are a well defined concept in MediaWiki and it's pretty separate from the page-restrictions, they're even stored in a separate table. The properties are a map with string key and unspecified value, while restrictions are an array.. Also, restrictions can have additional properties like expiry and cascading, so if we add a separate schema for the we'd probably be able to make a better more restrictive schema.. But I'm ok with trying to put it to the properties schema as well, just don't quite see the benefit.

Mon, Mar 20, 7:13 PM · Reading-Web-Trending-Service
Pchelolo updated subscribers of T154899: Protected pages should be excluded from trending results.

Looking to the code, it seems like the page protection is not a page_property, so it's not accessible via the properties-change event and changing it doesn't emit a new event.

Mon, Mar 20, 6:29 PM · Reading-Web-Trending-Service

Fri, Mar 17

Pchelolo created T160764: Update electron render service.
Fri, Mar 17, 4:27 PM · Services (next)

Thu, Mar 16

Pchelolo added a project to T158617: npm install fails for changeprop service in MW-Vagrant jessie-migration: Services (watching).

Change-Prop depends on a native kafka driver that in turn depends on librdkafka library. The binary build of the library is what's causing the problems there, but in production we depend on a shared librdkafka package installed on the host and skip building the library from sources. I will investigate if we could do the same in Vagrant.

Thu, Mar 16, 8:22 PM · Services (watching), MediaWiki-Vagrant
Pchelolo edited projects for T160208: Cannot read property 'process' of undefined, added: Services (done); removed Services (doing).

Nothing to do here on our side any more. Moving to done pending @MaxSem verification and closing.

Thu, Mar 16, 7:33 PM · Services (done), User-mobrovac, Interactive-Sprint, service-runner, Maps (Kartotherian)

Wed, Mar 15

Pchelolo closed T159883: Topics are created lazily and it's a problem for CP as "Resolved".

Since our upgrade to node-rdkafka 0.8.0 and librdkafka 0.9.4 this is not an issue any more. Consumers now periodically recheck metadata and when the topic is eventually created they start fetching messages. See https://github.com/Blizzard/node-rdkafka/issues/140#issuecomment-286572468

Wed, Mar 15, 10:18 PM · Patch-For-Review, Services (later), ChangeProp, MediaWiki-Vagrant
Pchelolo added a comment to T101153: Link preview sometimes shows wikitext markup and "Edit".

@Jdlrobson Will deploy the fix later today, yes. But we can't mass-purge Varnish, so will have to wait a bit until wrong content falls out of Varnish.

Wed, Mar 15, 5:07 PM · Services (done), Reading-Web-Sprint-94, Android-app-Bugs, Wikipedia-Android-App-Backlog, Reading-Web-Backlog, TextExtracts
Pchelolo committed rMSTED85be19060b90: Update trending-edits to 17a2b4f (authored by Pchelolo).
Update trending-edits to 17a2b4f
Wed, Mar 15, 4:53 PM
Pchelolo added a comment to T101153: Link preview sometimes shows wikitext markup and "Edit".

We've fixed it in RESTBase by https://github.com/wikimedia/restbase/pull/771 (not deployed yet).

Wed, Mar 15, 12:31 AM · Services (done), Reading-Web-Sprint-94, Android-app-Bugs, Wikipedia-Android-App-Backlog, Reading-Web-Backlog, TextExtracts

Tue, Mar 14

Pchelolo edited projects for T101153: Link preview sometimes shows wikitext markup and "Edit", added: Services (next); removed Services.
Tue, Mar 14, 10:01 PM · Services (done), Reading-Web-Sprint-94, Android-app-Bugs, Wikipedia-Android-App-Backlog, Reading-Web-Backlog, TextExtracts
Pchelolo added a comment to T101153: Link preview sometimes shows wikitext markup and "Edit".

Should we just add the exintro=true parameter to the RESTBase /page/summary endpoint and to the apps (maybe web, too)?

Tue, Mar 14, 10:00 PM · Services (done), Reading-Web-Sprint-94, Android-app-Bugs, Wikipedia-Android-App-Backlog, Reading-Web-Backlog, TextExtracts
Pchelolo added a comment to T159476: Replay/mirror update requests to RESTBase dev environment.

I'm not very familiar with change-propagation, but having separate knobs for items 1-3 above seems a little weird. Would it make sense to encapsulate all of this behind a mirror_mode, or dev_mode boolean? Is there any value in having them separately configurable?

Tue, Mar 14, 9:41 PM · Services, Cassandra
Pchelolo added a comment to T159379: Upgrade librdkafka 0.9.4 on SCB and Varnishes.

@faidon The librdkafka changelog explicitly warns that C++ API are not ABI safe and users of the C++ API have to recompile the application. node-rdkafka is based on C++ API, so we've had to recompile all node services that use kafka. varnishkafka is base on C API, thus no recompiling.

Tue, Mar 14, 4:06 PM · Services (done), Analytics-Kanban, Operations, ChangeProp, Reading-Web-Trending-Service

Mon, Mar 13

Pchelolo added a comment to T160208: Cannot read property 'process' of undefined.

It is already fixed in the current service-runner, it's been a mess up with versions, so rebuilding with a correct service-runner and redeploying should fix the problem. Leaving it open until @MaxSem confirms.

Mon, Mar 13, 6:56 PM · Services (done), User-mobrovac, Interactive-Sprint, service-runner, Maps (Kartotherian)

Fri, Mar 10

Pchelolo added a comment to T159883: Topics are created lazily and it's a problem for CP.

However, I think that we should automate that process. Perhaps have Puppet run the script every time the config file changes?

Fri, Mar 10, 6:20 PM · Patch-For-Review, Services (later), ChangeProp, MediaWiki-Vagrant
Pchelolo updated subscribers of T159883: Topics are created lazily and it's a problem for CP.

Hm, so after talking a bit to the driver maintainer, we've came to a conclusion that it's definitely wrong for the driver to fail like this silently, but he's on the edge whether to include a check into the library or leave it for the clients to implement. There's definitely no clear way to dynamically recheck topic existence and update the subscription inside the driver code, so if we wanna do that, we'd need write it on our own (which is not that complex, but it does disrupt the startup process quite a bit)

Fri, Mar 10, 6:06 PM · Patch-For-Review, Services (later), ChangeProp, MediaWiki-Vagrant
Pchelolo renamed T160000: Drop support for node <4 in service-runner from "Drop support for node <4 inn service-runner" to "Drop support for node <4 in service-runner".
Fri, Mar 10, 5:49 PM · Services (next), service-runner
Pchelolo committed rMSTEDa5716b931715: Update trending-edits to e2a957f (authored by Pchelolo).
Update trending-edits to e2a957f
Fri, Mar 10, 12:23 AM

Thu, Mar 9

Pchelolo added a comment to T156411: Compute the trending articles over a period of 24h rather than 1h.

@Jdlrobson What you could do for quick testing of ideas and outputs is the following:

Thu, Mar 9, 8:04 PM · Patch-For-Review, Reading Epics (Trending Edits), Unplanned-Sprint-Work, EventBus, User-mobrovac, Services (doing), Analytics, Reading-Web-Trending-Service
Pchelolo added a comment to T160000: Drop support for node <4 in service-runner.

@GWicke I already have a patch. Just waiting till April 1 when Parsoid officially drops support for 0.10

Thu, Mar 9, 4:02 AM · Services (next), service-runner
Pchelolo added a comment to T160030: old revision length missing in /v2/stream/recentchange.

Em. That's weird. When I go to https://stream.wikimedia.org/v2/stream/recentchange I see proper value in "old" property. I only see "old":null for pages that's just been created, which is understandable.

Thu, Mar 9, 2:18 AM · Analytics, Wikimedia-Stream

Wed, Mar 8

Pchelolo created T160000: Drop support for node <4 in service-runner.
Wed, Mar 8, 11:17 PM · Services (next), service-runner
Pchelolo moved T159998: No content returned errors from doing to next on the Services board.
Wed, Mar 8, 11:04 PM · Services (next), RESTBase
Pchelolo edited the description of T159998: No content returned errors.
Wed, Mar 8, 11:04 PM · Services (next), RESTBase
Pchelolo created T159998: No content returned errors.
Wed, Mar 8, 11:00 PM · Services (next), RESTBase
Pchelolo renamed T159379: Upgrade librdkafka 0.9.4 on SCB and Varnishes from "Build and Install librdkafka 0.9.4 on SCB" to "Upgrade librdkafka 0.9.4 on SCB and Varnishes".
Wed, Mar 8, 10:52 PM · Services (done), Analytics-Kanban, Operations, ChangeProp, Reading-Web-Trending-Service
Pchelolo closed T158451: Kafka logs are not pruned on vagrant as "Resolved".
Wed, Mar 8, 9:28 PM · Services (done), Analytics-Cluster, EventBus, Analytics, MediaWiki-Vagrant
Pchelolo renamed T159883: Topics are created lazily and it's a problem for CP from "Change-Prop in Vagrant: topics are created lazily and it's a problem" to "Topics are created lazily and it's a problem for CP".
Wed, Mar 8, 8:29 PM · Patch-For-Review, Services (later), ChangeProp, MediaWiki-Vagrant
Pchelolo added a comment to T159883: Topics are created lazily and it's a problem for CP.

Poked librdkafka and the driver around this issue a bit. Create https://github.com/Blizzard/node-rdkafka/issues/140 to discuss an issue with driver maintainer, let's see what he has in mind.

Wed, Mar 8, 8:26 PM · Patch-For-Review, Services (later), ChangeProp, MediaWiki-Vagrant
Pchelolo closed T156680: Allow API consumer to express a timeframe in hours as "Resolved".

RB deployed, new parameter is live: https://en.wikipedia.org/api/rest_v1/#!/Feed/trendingEdits

Wed, Mar 8, 5:53 PM · Services (done), Reading-Web-Sprint-91-🐔🍔, Unplanned-Sprint-Work, Reading-Web-Backlog, User-mobrovac, Reading-Web-Trending-Service
Pchelolo added a comment to T159883: Topics are created lazily and it's a problem for CP.

Or, instead of failling if a topic doesn't exist, change-prop could try again every few minutes.

Wed, Mar 8, 5:01 PM · Patch-For-Review, Services (later), ChangeProp, MediaWiki-Vagrant
Pchelolo added a comment to T156680: Allow API consumer to express a timeframe in hours.

And here's the PR for public part: https://github.com/wikimedia/restbase/pull/770

Wed, Mar 8, 1:22 AM · Services (done), Reading-Web-Sprint-91-🐔🍔, Unplanned-Sprint-Work, Reading-Web-Backlog, User-mobrovac, Reading-Web-Trending-Service
Pchelolo added a comment to T156411: Compute the trending articles over a period of 24h rather than 1h.

Yup, making a PR as we speak.

Wed, Mar 8, 12:44 AM · Patch-For-Review, Reading Epics (Trending Edits), Unplanned-Sprint-Work, EventBus, User-mobrovac, Services (doing), Analytics, Reading-Web-Trending-Service

Tue, Mar 7

Pchelolo edited projects for T159883: Topics are created lazily and it's a problem for CP, added: Services (later); removed Services (next).
Tue, Mar 7, 10:30 PM · Patch-For-Review, Services (later), ChangeProp, MediaWiki-Vagrant
Pchelolo renamed T159883: Topics are created lazily and it's a problem for CP from "Change-Prop in Vagrant: topics are created lazily" to "Change-Prop in Vagrant: topics are created lazily and it's a problem".
Tue, Mar 7, 10:20 PM · Patch-For-Review, Services (later), ChangeProp, MediaWiki-Vagrant
Pchelolo created T159883: Topics are created lazily and it's a problem for CP.
Tue, Mar 7, 10:11 PM · Patch-For-Review, Services (later), ChangeProp, MediaWiki-Vagrant
Pchelolo added a comment to T159252: SyntaxError in Mobile-Content-Service.

@bearND You can still reproduce by going on an sub node and requesting the page locally:

curl http://localhost:8888/ur.wikipedia.org/v1/page/mobile-sections/%D8%A2%D8%A6%DB%8C%D9%88%D8%B1%DB%8C_%DA%A9%D9%88%D8%B3%D9%B9
Tue, Mar 7, 9:45 PM · Patch-For-Review, Mobile-Content-Service (Kanban), Services (watching)
Pchelolo added a comment to T159252: SyntaxError in Mobile-Content-Service.

@bearND Hm, the page wasn't edited recently, so perhaps some template it uses was edited? Not sure how to find it any more..

Tue, Mar 7, 6:31 PM · Patch-For-Review, Mobile-Content-Service (Kanban), Services (watching)
Pchelolo added a comment to T159476: Replay/mirror update requests to RESTBase dev environment.

[ ... ]

  1. Switch off log stash logging and metrics.

Do they need to be switched off? Couldn't we just do something to put them under a different namespace?

Tue, Mar 7, 3:53 PM · Services, Cassandra
Pchelolo added a comment to T159476: Replay/mirror update requests to RESTBase dev environment.

A couple things are also required for the testing CP to work properly:

  1. We need to be able to switch-off event production from change-prop completely by a config stanza in the sys/kafka module
  2. We need to be able to configure the prefix for the consumer groups - currently it's static and it's change-prop-${rule.name}. The dev instance of change-prop should have a different prefix to avoid messing with production consumer groups.
  3. Currently, when CP starts up, it starts processing where it's left, or if nothing was committed, it fallbacks to the latest offset in each topic via auto.offset.reset=latest property. We've discussed, that going through the backlog of events wouldn't allow us to test properly, because of the do not write if html is the same optimization in RESTBase. This means, to make proper testing we need to follow the life stream of events, but the test-CP wouldn't run continuously, so when we stop and restart it, we don't want it to process backlogs. I propose to switch off commits in the test-CP instance completely via one more config stanza.
  4. Switch off log stash logging and metrics.
Tue, Mar 7, 12:51 AM · Services, Cassandra

Mon, Mar 6

Pchelolo added a comment to T159379: Upgrade librdkafka 0.9.4 on SCB and Varnishes.

There's no need to have downtime at all for the upgrade - we have multiple hosts for these services and have to upgrade them one by one anyway.

Mon, Mar 6, 8:55 PM · Services (done), Analytics-Kanban, Operations, ChangeProp, Reading-Web-Trending-Service
Pchelolo added a comment to T153029: EventBus logs don't show up in logstash.

The https://phabricator.wikimedia.org/T150106#2777178 should've been resolved by https://github.com/wikimedia/change-propagation/pull/133

Mon, Mar 6, 8:22 PM · Services (watching), Analytics, EventBus
Pchelolo added a comment to T159379: Upgrade librdkafka 0.9.4 on SCB and Varnishes.

After some testing of driver-librdkafka compatibility, here's the deal:

  1. Currently we are using node-rdkafka v0.6.5 and librdkafka v0.9.1 and want to upgrade to node-rdkafka v0.8.0 and librdkafka v0.9.4
  2. The old driver works with a new version of the package, but it requires recompiling the driver itself. So when we upgrade the librdkafka package, services will not be able to restart the workers - the respawned workers will just die - until we redeploy the services.
  3. There're already patches for all 3 services on SCB that use the Kafka driver, change-prop, trending-edits and event streams
  4. I propose to do a coordinated deployment of all services right after we install the new librdkafka
Mon, Mar 6, 6:57 PM · Services (done), Analytics-Kanban, Operations, ChangeProp, Reading-Web-Trending-Service

Fri, Mar 3

Pchelolo added a comment to T159585: HyperSwitch module caching doesn't work.

Hm.. Although, I'm not entirely sure I understand what's going on.. The subtree sharing does work, while sharing of individual modules doesn't

Fri, Mar 3, 11:52 PM · RESTBase, Services (next)
Pchelolo created T159585: HyperSwitch module caching doesn't work.
Fri, Mar 3, 11:43 PM · RESTBase, Services (next)
Pchelolo edited projects for T159479: Sampled rate-limiting for logger, added: Services (doing); removed Services (next).

PR Is here: https://github.com/wikimedia/service-runner/pull/158

Fri, Mar 3, 9:31 PM · Services (doing), service-runner

Thu, Mar 2

Pchelolo created T159479: Sampled rate-limiting for logger.
Thu, Mar 2, 8:44 PM · Services (doing), service-runner
Pchelolo added a comment to T158975: Consistently upgrade stored Parsoid HTML to the latest stable spec version.

After the latest deploy of Parsoid where they've changed the styles, we're seeing very low rates of re-renders with the same HTML, because every page was affected by the change. So the issue is getting much less pressing now.

Thu, Mar 2, 6:29 PM · RESTBase, Services (next)

Wed, Mar 1

Pchelolo edited projects for T158451: Kafka logs are not pruned on vagrant, added: Services (doing); removed Services (watching).
Wed, Mar 1, 11:23 PM · Services (done), Analytics-Cluster, EventBus, Analytics, MediaWiki-Vagrant
Pchelolo created D585: Updated node-rdkafka version to 0.8.0.
Wed, Mar 1, 9:45 PM
Pchelolo created T159379: Upgrade librdkafka 0.9.4 on SCB and Varnishes.
Wed, Mar 1, 8:38 PM · Services (done), Analytics-Kanban, Operations, ChangeProp, Reading-Web-Trending-Service
Pchelolo edited projects for T159144: Cap Ex needs for Mobile SSR and Connection Management Project, added: Services (watching); removed Services.
Wed, Mar 1, 7:26 PM · Services (watching), Reading Epics (Mobile Web SSR and Connection Management), Reading-Web-Backlog
Pchelolo added a comment to T122245: REST API entry point web request statistics at the Varnish level.

I've put a very WIP solutions that uses change-prop here: https://github.com/wikimedia/change-propagation/pull/165
The solution re-uses the router code we've wrote for RESTBase and should be pretty efficient, but I didn't test it much yet.. My main worry is that CP wouldn't keep up with the rate of events from Kafka. Anyway, it should be considered as a temporary hack until analytics has a better way to do stream processing.

Wed, Mar 1, 1:25 AM · Services, RESTBase, Analytics

Tue, Feb 28

Pchelolo added a comment to T122245: REST API entry point web request statistics at the Varnish level.

@Nuria Could you explain a bit on what's the difference between refined data and raw data in this context? All we need here is URIs that we can filter and map against the spec.

Tue, Feb 28, 8:03 PM · Services, RESTBase, Analytics
Pchelolo added a comment to T112648: enable restbase syslog/file logging.

I've put the patch for puppet SWAT on March 02.

Tue, Feb 28, 7:55 PM · Patch-For-Review, User-mobrovac, service-runner, Services (doing), Operations, RESTBase
Pchelolo created T159252: SyntaxError in Mobile-Content-Service.
Tue, Feb 28, 6:02 PM · Patch-For-Review, Mobile-Content-Service (Kanban), Services (watching)
Pchelolo created T159200: Update to node-rdkafka 0.8.0.
Tue, Feb 28, 12:24 AM · User-mobrovac, ChangeProp, Reading-Web-Trending-Service, Services (next)

Mon, Feb 27

Pchelolo updated subscribers of T153029: EventBus logs don't show up in logstash.

Ok, apparently @bd808 temporarily disabled logging in https://gerrit.wikimedia.org/r/#/c/320016/2 Can that be reverted now?

Mon, Feb 27, 10:34 PM · Services (watching), Analytics, EventBus
Pchelolo closed T158139: Randomise the checker script delay as "Declined".

On the second thought, it's not too much of a load to bother, and having monitoring is always good.

Mon, Feb 27, 10:05 PM · Services (later)
Pchelolo closed T156662: Drop old mobile apps tables as "Resolved".

It took some time, but I've finally dropped all the old key spaces. Resolving.

Mon, Feb 27, 9:03 PM · RESTBase, Services (later)
Pchelolo added a comment to T157132: Add ORES WP10 data to summaries?.

Thanks for the context @Tgr. Sounds convincing that it's better to do it in two steps in RESTBase instead of mangling ORES API.

Mon, Feb 27, 1:28 AM · Reading Epics, Revision-Scoring-As-A-Service, ORES, Services (designing), RESTBase-API, Mobile-Content-Service

Sun, Feb 26

Pchelolo added a comment to T157132: Add ORES WP10 data to summaries?.

@Pchelolo, just to clarify, you want ORES to send a request to api.php and look up the most recent rev_id for a give page_title and then generate a score for you? I'm not sure that this would be a good thing for ORES to support.

Sun, Feb 26, 10:38 PM · Reading Epics, Revision-Scoring-As-A-Service, ORES, Services (designing), RESTBase-API, Mobile-Content-Service

Fri, Feb 24

Pchelolo closed T158338: Set up DNS caching for node services as "Resolved".

Ok, that's now done. Resolving.

Fri, Feb 24, 11:17 PM · Services (done), service-runner, codfw-rollout, codfw-rollout-Jan-Mar-2016
Pchelolo closed T158338: Set up DNS caching for node services, a subtask of T127976: Graphite DC fail-over / per-DC setup, as "Resolved".
Fri, Feb 24, 11:17 PM · Patch-For-Review, codfw-rollout, codfw-rollout-Jan-Mar-2016
Pchelolo closed T158602: RESTBase logs disappeared from logstash as "Resolved".

After restarting Elasticsearch the logs are back. The reason is still not clear, but the issue is magically resolved. Thank you @EBernhardson

Fri, Feb 24, 9:10 PM · Wikimedia-Logstash, Services (watching)
Pchelolo added a comment to T158602: RESTBase logs disappeared from logstash.

Em... Starting at 20:52 UTC the logs are back. No idea what happened..

Fri, Feb 24, 9:06 PM · Wikimedia-Logstash, Services (watching)
Pchelolo added a comment to T158602: RESTBase logs disappeared from logstash.

Hm... The only difference is that the latter contains _message key while the former does not.. Lemme try to mangle the code in staging to make it emit the message too and see if that helps

Fri, Feb 24, 8:57 PM · Wikimedia-Logstash, Services (watching)
Pchelolo added a comment to T157132: Add ORES WP10 data to summaries?.

I don't think ORES will have any serious capacity concerns for this. We already generate scores for every edit as it is saved. Generating the "wp10" score on top of the "damaging" score requires trivial (effectively zero) additional resources.

Fri, Feb 24, 8:35 PM · Reading Epics, Revision-Scoring-As-A-Service, ORES, Services (designing), RESTBase-API, Mobile-Content-Service
Pchelolo claimed T158437: Change ORES rules to send all events to new "/precache" endpoint.
Fri, Feb 24, 8:15 PM · Services (blocked), Revision-Scoring-As-A-Service-Backlog, ORES, ChangeProp

Thu, Feb 23

Pchelolo closed T157845: Updates to mobile content might not be working as "Invalid".

After switching to new backend tables I've checked again - all's good. Resolving.

Thu, Feb 23, 11:44 PM · Services (next)
Pchelolo closed T157845: Updates to mobile content might not be working, a subtask of T155070: Clicking on references is broken., as "Invalid".
Thu, Feb 23, 11:44 PM · ChangeProp, RESTBase, Mobile-Content-Service (Kanban), Android-app-Bugs, Patch-For-Review, Wikipedia-Android-App-Backlog (Kanban)
Pchelolo added a comment to T158100: Deprecate and remove the public title/{title} endpoint.

Deprecation was announced

Thu, Feb 23, 11:34 PM · Services (blocked), RESTBase-API, RESTBase
Pchelolo moved T158100: Deprecate and remove the public title/{title} endpoint from doing to blocked on the Services board.
Thu, Feb 23, 11:32 PM · Services (blocked), RESTBase-API, RESTBase
Pchelolo moved T158128: Deprecate and delete mobile-text endpoint from doing to blocked on the Services board.
Thu, Feb 23, 11:32 PM · Services (blocked), RESTBase-API, Mobile-Content-Service
Pchelolo edited projects for T158902: Test Performance of the React Prototype (SSR CapEX), added: Services (watching); removed Services.
Thu, Feb 23, 9:16 PM · Services (watching), Reading-Web-Backlog
Pchelolo added a comment to T148714: Create generalized "precache" endpoint for ORES.

Is there a ChangeProp in labs that will allow us to track the production wikis?

Thu, Feb 23, 7:20 PM · User-Ladsgroup, Revision-Scoring-As-A-Service, Analytics, Services (watching), User-mobrovac, EventBus, ChangeProp
Pchelolo added a comment to T148714: Create generalized "precache" endpoint for ORES.

Just quickly noting that it seems we still have a memory leak in ores precached (the utility that runs in labs because ChangeProp isn't there)

Thu, Feb 23, 7:04 PM · User-Ladsgroup, Revision-Scoring-As-A-Service, Analytics, Services (watching), User-mobrovac, EventBus, ChangeProp
Pchelolo added a project to T158221: Enable RESTBase in stage 0 wikis: Services (watching).
Thu, Feb 23, 5:32 PM · Reading-Web-Sprint-94, Patch-For-Review, Reading-Web-Sprint-93-🔍🔍🔍🔍🔍, Services (watching), Wikimedia-Site-requests, Reading-Web-Sprint-92-🍜

Wed, Feb 22

Pchelolo claimed T158822: RESTBase/Parsoid responding with 404 in Vagrant for Main Page.

Ok, the reason is that we've move the CSP headers generation out into a filter and forgot to update RESTBase config in Vagrant. The above patch should take care of that and fix your problem.

Wed, Feb 22, 11:55 PM · Patch-For-Review, Services (doing), Parsoid, RESTBase, MediaWiki-Vagrant