Page MenuHomePhabricator

Pchelolo
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 24 2015, 10:23 AM (302 w, 4 d)
Availability
Available
LDAP User
Ppchelko
MediaWiki User
PPchelko (WMF) [ Global Accounts ]

Recent Activity

Wed, Apr 7

Pchelolo added a comment to T278591: Make PageRecord::getLanguage() behave consistently with Title::getPageLanguage() .

None of the deployed extensions actually write or read page_lang field. The only wiki I managed to find that actually does have the field set is commons, with 136 pages where page_lang is not null - and all of them are main pages.

Wed, Apr 7, 4:37 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Platform Team Workboards (MW Expedition)

Tue, Apr 6

Pchelolo added a comment to T278906: Change cpjobqueue "processing" time metrics from pre-aggregated quantile to native Prometheus histogram bucket.

Change-prop metrics goes through a series of transformations...

Tue, Apr 6, 9:05 PM · observability, WMF-JobQueue, Platform Engineering
Pchelolo closed T272421: Make WikiPage a PageRecord, a subtask of T195069: Factor PageStore and PageRecord out of WikiPage, as Resolved.
Tue, Apr 6, 5:39 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), MediaWiki-Revision-backend, Platform Team Workboards (MW Expedition), Epic, Patch-For-Review, Code-Health-Objective
Pchelolo closed T272421: Make WikiPage a PageRecord as Resolved.
Tue, Apr 6, 5:39 PM · MediaWiki-Revision-backend, Platform Team Workboards (MW Expedition)
Pchelolo closed T272422: Introduce PageRecord and ExistingPageRecord interfaces as Resolved.
Tue, Apr 6, 5:39 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), MediaWiki-Revision-backend, Patch-For-Review, Platform Team Workboards (MW Expedition)
Pchelolo closed T272422: Introduce PageRecord and ExistingPageRecord interfaces, a subtask of T272421: Make WikiPage a PageRecord, as Resolved.
Tue, Apr 6, 5:39 PM · MediaWiki-Revision-backend, Platform Team Workboards (MW Expedition)
Pchelolo reopened T272421: Make WikiPage a PageRecord, a subtask of T195069: Factor PageStore and PageRecord out of WikiPage, as Open.
Tue, Apr 6, 5:39 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), MediaWiki-Revision-backend, Platform Team Workboards (MW Expedition), Epic, Patch-For-Review, Code-Health-Objective
Pchelolo reopened T272421: Make WikiPage a PageRecord as "Open".
Tue, Apr 6, 5:39 PM · MediaWiki-Revision-backend, Platform Team Workboards (MW Expedition)
Pchelolo closed T272421: Make WikiPage a PageRecord, a subtask of T195069: Factor PageStore and PageRecord out of WikiPage, as Resolved.
Tue, Apr 6, 5:39 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), MediaWiki-Revision-backend, Platform Team Workboards (MW Expedition), Epic, Patch-For-Review, Code-Health-Objective
Pchelolo closed T272421: Make WikiPage a PageRecord as Resolved.
Tue, Apr 6, 5:38 PM · MediaWiki-Revision-backend, Platform Team Workboards (MW Expedition)
Pchelolo added a comment to T275602: Avoid using User ::isIP, ::getOptions.

If all deployed extesions were updated then it's ready for a patch to hard deprecate the methods.

Tue, Apr 6, 5:37 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Social-Tools, MediaWiki-extensions-OnlineStatusBar, MediaWiki-extensions-Sudo, SocialProfile, MediaWiki-extensions-Other, LookupUser, MediaWiki-extensions-LDAPUserInfo, MediaWiki-extensions-MediaWikiAuth, MediaWiki-extensions-BreadCrumbs, BlueSpice, RegexBlock, Editing-team (Tracking), Patch-For-Review, GrowthExperiments, Notifications, MediaWiki-extensions-LdapAuthentication, VisualEditor, Wikibase, MediaWiki-extensions-WikimediaIncubator, MinervaNeue, Nostalgia, Community-Tech, MediaWiki-extensions-GlobalPreferences, Growth-Team, Technical-Debt (Deprecation process), Platform Team Workboards (MW Expedition)
Pchelolo closed T274151: Clean up Title deprecated methods as Resolved.
Tue, Apr 6, 5:15 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Technical-Debt (Deprecation process), Platform Team Workboards (MW Expedition)
Pchelolo moved T275531: Make RevisionRecord return a ProperPageIdentity from Waiting for Review to Blocked on the Platform Team Workboards (MW Expedition) board.
Tue, Apr 6, 5:15 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, MediaWiki-Revision-backend, Platform Team Workboards (MW Expedition)
Pchelolo closed T276853: Convert RecentChange to UserIdentity and ActorStore, a subtask of T274179: Deprecate and remove UserIdentity::getActorId() , as Resolved.
Tue, Apr 6, 4:54 PM · MW-1.36-release, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management
Pchelolo closed T276853: Convert RecentChange to UserIdentity and ActorStore, a subtask of T276412: Replace RecentChange::getPerformer with RecentChange::getPerformerIdentity., as Resolved.
Tue, Apr 6, 4:54 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Platform Team Workboards (MW Expedition)
Pchelolo closed T276853: Convert RecentChange to UserIdentity and ActorStore as Resolved.
Tue, Apr 6, 4:54 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Platform Team Workboards (MW Expedition)
Pchelolo moved T276986: Pass IDatabase to ActorNormalization methods from On the train to Waiting for Review on the Platform Team Workboards (MW Expedition) board.
Tue, Apr 6, 4:48 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management
Pchelolo moved T276986: Pass IDatabase to ActorNormalization methods from Waiting for Review to On the train on the Platform Team Workboards (MW Expedition) board.
Tue, Apr 6, 4:47 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management
Pchelolo added a comment to T273287: UserIdentityValue should require a Wiki ID to be passed to the constructor..

Waiting for https://gerrit.wikimedia.org/r/c/mediawiki/core/+/665546

Tue, Apr 6, 4:44 PM · Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management
Pchelolo closed T278125: TitleFormatter (implemented in MediaWikiTitleCodec) should accept PageIdentity as argument as Resolved.
Tue, Apr 6, 4:41 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (MW Expedition)
Pchelolo moved T278125: TitleFormatter (implemented in MediaWikiTitleCodec) should accept PageIdentity as argument from Waiting for release to On the train on the Platform Team Workboards (MW Expedition) board.
Tue, Apr 6, 4:41 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (MW Expedition)
Pchelolo closed T275509: Saving edits should not require a User object, a UserIdentity should be sufficient. as Resolved.
Tue, Apr 6, 4:39 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MediaWiki-Decoupling, MediaWiki-Page-editing, Platform Team Workboards (MW Expedition)
Pchelolo added a comment to T277829: Understand or mitigate duplicate ParserCache fetches in the same request.

@Krinkle you're totally right, caching negatives is wrong in this case. The above patch implements in-process caching for metadata only.

Tue, Apr 6, 4:15 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), MediaWiki-Parser
Pchelolo moved T277818: Avoid using User::setOption() from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.
Tue, Apr 6, 2:28 PM · Platform Team Workboards (MW Expedition), MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Patch-For-Review, MediaWiki-User-management, good first task, User-Zabe, Technical-Debt (Deprecation process)
Pchelolo added a project to T277818: Avoid using User::setOption(): Platform Team Workboards (MW Expedition).
Tue, Apr 6, 2:28 PM · Platform Team Workboards (MW Expedition), MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Patch-For-Review, MediaWiki-User-management, good first task, User-Zabe, Technical-Debt (Deprecation process)
Pchelolo moved T277600: Prepare User option methods for hard deprecation from Unsorted pile to Doing on the Platform Team Workboards (MW Expedition) board.
Tue, Apr 6, 2:27 PM · Platform Team Workboards (MW Expedition), MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), MediaWiki-User-management, Patch-For-Review, User-Zabe, Technical-Debt (Deprecation process)
Pchelolo added a project to T277600: Prepare User option methods for hard deprecation: Platform Team Workboards (MW Expedition).
Tue, Apr 6, 2:27 PM · Platform Team Workboards (MW Expedition), MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), MediaWiki-User-management, Patch-For-Review, User-Zabe, Technical-Debt (Deprecation process)
Pchelolo updated the task description for T279433: Make BacklinksCache a service.
Tue, Apr 6, 2:00 PM · Platform Team Workboards (MW Expedition)
Pchelolo created T279433: Make BacklinksCache a service.
Tue, Apr 6, 1:58 PM · Platform Team Workboards (MW Expedition)

Mon, Apr 5

Pchelolo added a comment to T278376: Constructing RevisionRecord for a page that can't exist: Special:MyLanguage/Main Page [Called from MediaWiki\Revision\MutableRevisionRecord::__construct].

I have *NOT* followed all this discussion closely, but can someone answer as to what extent do these issues translate over to Parsoid?

Mon, Apr 5, 8:10 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-Revision-backend, Parsoid, Wikimedia-production-error

Fri, Apr 2

Pchelolo closed T269393: Remove Parser::VERSION check in CacheTime as Resolved.

Resolved long time ago

Fri, Apr 2, 9:01 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Platform Team Workboards (Green), MediaWiki-Parser
Pchelolo added a comment to T278376: Constructing RevisionRecord for a page that can't exist: Special:MyLanguage/Main Page [Called from MediaWiki\Revision\MutableRevisionRecord::__construct].

The problem is, that they *are*. We create the new revision record *before* it is stored in the database, in order to support {{REVISIONID}} on a newly-saved page, etc. And VE stashing/etc also deal with revisions-that-will-be-but-aren't-quite-yet. That's actually a very useful abstraction I'd be very reluctant to give up.

Fri, Apr 2, 7:37 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-Revision-backend, Parsoid, Wikimedia-production-error
Pchelolo created T279153: PageArchive::undeleteAsUser has to become a command.
Fri, Apr 2, 4:00 PM · Platform Team Workboards (MW Expedition)

Thu, Apr 1

Pchelolo added a comment to T279100: Have some dedicated jobrunners that aren't active videoscalers.

On the change-prop side we already route all video scaling jobs to videoscaler.discovery.wmnet and all other jobs to jobrunner.discovery.wmnet so no change needed there.

Thu, Apr 1, 8:53 PM · WMF-JobQueue, Sustainability (Incident Followup), SRE, serviceops
Pchelolo updated subscribers of T279063: DBAccessBase is difficult to use with dependency injection.

cc @daniel as original author.

Thu, Apr 1, 2:34 PM · Platform Team Workboards (Clinic Duty Team), Wikibase Service Migration, wdwb-tech, Wikidata, Wikimedia-Rdbms
Pchelolo added a comment to T279063: DBAccessBase is difficult to use with dependency injection.

I think we can go even further and just eliminate the class entirely. It provides no value - it has 3 lines of very simple code in it, no other classes seem to have methods typed with "DBConnectionBase" - zero value.

Thu, Apr 1, 2:33 PM · Platform Team Workboards (Clinic Duty Team), Wikibase Service Migration, wdwb-tech, Wikidata, Wikimedia-Rdbms
Pchelolo lowered the priority of T278376: Constructing RevisionRecord for a page that can't exist: Special:MyLanguage/Main Page [Called from MediaWiki\Revision\MutableRevisionRecord::__construct] from Unbreak Now! to Medium.

Rollbacks were deployed, it's not a UBN anymore

Thu, Apr 1, 2:08 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-Revision-backend, Parsoid, Wikimedia-production-error

Wed, Mar 31

Krinkle awarded T277795: User not found by actor ID: [id] a Orange Medal token.
Wed, Mar 31, 2:28 AM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Performance-Team (Radar), Platform Team Workboards (MW Expedition), Growth-Team, User-brennen, MediaWiki-Recent-changes, Wikimedia-production-error

Tue, Mar 30

Pchelolo closed T277795: User not found by actor ID: [id] as Resolved.

Doesn't seem to happen anymore on wmf.36

Tue, Mar 30, 9:22 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Performance-Team (Radar), Platform Team Workboards (MW Expedition), Growth-Team, User-brennen, MediaWiki-Recent-changes, Wikimedia-production-error
Pchelolo closed T277795: User not found by actor ID: [id], a subtask of T274940: 1.36.0-wmf.36 deployment blockers, as Resolved.
Tue, Mar 30, 9:22 PM · Patch-For-Review, Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), Release, Train Deployments
Pchelolo edited projects for T278735: The given PageIdentity does not represent a proper page, added: Platform Team Workboards (MW Expedition); removed Platform Team Workboards (Clinic Duty Team).
Tue, Mar 30, 9:03 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Platform Team Workboards (MW Expedition), MediaWiki-API, Wikimedia-production-error
Pchelolo added a comment to T265944: Make class WatchAction a real action class and move helper function to own service.

Oh, I resolved it by mistake. Mostly wanted to CC Cindy since she's working on this area.

Tue, Mar 30, 9:00 PM · Platform Team Workboards (MW Expedition), User-DannyS712, MediaWiki-Watchlist, Growth-Team, MediaWiki-General, Dependency injection
Pchelolo closed T265944: Make class WatchAction a real action class and move helper function to own service, a subtask of T259960: Inject services into API modules and special pages, as Resolved.
Tue, Mar 30, 8:51 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Patch-For-Review, User-DannyS712, Dependency injection, MediaWiki-Special-pages, MediaWiki-API
Pchelolo closed T265944: Make class WatchAction a real action class and move helper function to own service as Resolved.
Tue, Mar 30, 8:51 PM · Platform Team Workboards (MW Expedition), User-DannyS712, MediaWiki-Watchlist, Growth-Team, MediaWiki-General, Dependency injection
Pchelolo reassigned T218395: Create RestrictionStore service from Vedmaka to Peter.ovchyn.
Tue, Mar 30, 5:11 PM · Platform Team Workboards (MW Expedition), MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, Platform Team Initiatives (Decoupling (CDP2))
Pchelolo added a comment to T278376: Constructing RevisionRecord for a page that can't exist: Special:MyLanguage/Main Page [Called from MediaWiki\Revision\MutableRevisionRecord::__construct].

Ok, created https://gerrit.wikimedia.org/r/c/mediawiki/core/+/675737 to revert the deprecation.

Tue, Mar 30, 2:49 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-Revision-backend, Parsoid, Wikimedia-production-error

Mon, Mar 29

Pchelolo added a comment to T278655: Appservers latency spike / parser cache growth 2021-03-28.

ParserCache is split on action=render, so none of the action=render pages are usually cached. See T263581 for more details.

Mon, Mar 29, 5:52 PM · Sustainability (Incident Followup), Performance-Team (Radar), DBA, Platform Engineering, SRE

Thu, Mar 25

Pchelolo added a comment to T274940: 1.36.0-wmf.36 deployment blockers.

Blocker T277795 - should finally be solved by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/674836

Thu, Mar 25, 10:07 PM · Patch-For-Review, Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), Release, Train Deployments
Pchelolo added a comment to T277795: User not found by actor ID: [id].

In this case we actually have all the data in the row since we've joined it with actor when fetching RecentChange, so we can just instantiate UserIdentityValue directly.

Thu, Mar 25, 9:33 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Performance-Team (Radar), Platform Team Workboards (MW Expedition), Growth-Team, User-brennen, MediaWiki-Recent-changes, Wikimedia-production-error
Pchelolo added a comment to T277795: User not found by actor ID: [id].
15:17 Pchelolo: Krinkle: what do you think about this theory: RefreshLinks is a loooong running job, so we establish a master connection when we begin. At some point, we read RecentChanges from a 'recentchanges' group replica - it's well caught up. Then we try to read 'actor' form a replica from another group - that one is not caught up, we fail. The we fallback to master connection, but it was opened looong time ago, and we read repeatable read s
15:17 Pchelolo: napshot - not find anything as well
15:17 Pchelolo: and thus we crash entirely.
15:18 Krinkle: Pchelolo: is ActorStore in master same as this weeks' wmf branch?
15:18 Pchelolo: same
15:18 Krinkle: k
15:20 Krinkle: Pchelolo: yeah, that seems plausible
Thu, Mar 25, 9:32 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Performance-Team (Radar), Platform Team Workboards (MW Expedition), Growth-Team, User-brennen, MediaWiki-Recent-changes, Wikimedia-production-error
Pchelolo added a comment to T277795: User not found by actor ID: [id].

I went over a few instances of this.

Thu, Mar 25, 9:13 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Performance-Team (Radar), Platform Team Workboards (MW Expedition), Growth-Team, User-brennen, MediaWiki-Recent-changes, Wikimedia-production-error
Pchelolo created T278458: Undeprecate NamespaceInfo::getRestrictionLevels.
Thu, Mar 25, 5:26 PM · Platform Team Workboards (MW Expedition)
Pchelolo added a comment to T278141: cxserver missing important metrics after service-runner 2.8.1 upgrade.

Oh right, it's still in the branch in the template. You can use this code https://github.com/wikimedia/service-template-node/pull/148 to see what needs to be done.

Thu, Mar 25, 2:35 PM · Patch-For-Review, Language-Team (Language-2021-April-June), CX-cxserver

Wed, Mar 24

Pchelolo removed a subtask for T274940: 1.36.0-wmf.36 deployment blockers: T278376: Constructing RevisionRecord for a page that can't exist: Special:MyLanguage/Main Page [Called from MediaWiki\Revision\MutableRevisionRecord::__construct].
Wed, Mar 24, 8:24 PM · Patch-For-Review, Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), Release, Train Deployments
Pchelolo edited parent tasks for T278376: Constructing RevisionRecord for a page that can't exist: Special:MyLanguage/Main Page [Called from MediaWiki\Revision\MutableRevisionRecord::__construct], added: T278343: 1.36.0-wmf.37 deployment blockers; removed: T274940: 1.36.0-wmf.36 deployment blockers.
Wed, Mar 24, 8:24 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-Revision-backend, Parsoid, Wikimedia-production-error
Pchelolo added a subtask for T278343: 1.36.0-wmf.37 deployment blockers: T278376: Constructing RevisionRecord for a page that can't exist: Special:MyLanguage/Main Page [Called from MediaWiki\Revision\MutableRevisionRecord::__construct].
Wed, Mar 24, 8:24 PM · Patch-For-Review, Release-Engineering-Team-TODO (2021-01-01 to 2021-03-31 (Q3)), Release, Train Deployments
Pchelolo added a comment to T278376: Constructing RevisionRecord for a page that can't exist: Special:MyLanguage/Main Page [Called from MediaWiki\Revision\MutableRevisionRecord::__construct].

@hashar it's a deprecation warning, so it only shows in the logs, no user impact whatsoever. I propose to drop it from the list of blockers, we'll have a look at it this week and try to get into the next week train.

Wed, Mar 24, 8:20 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-Revision-backend, Parsoid, Wikimedia-production-error
Pchelolo lowered the priority of T278376: Constructing RevisionRecord for a page that can't exist: Special:MyLanguage/Main Page [Called from MediaWiki\Revision\MutableRevisionRecord::__construct] from Unbreak Now! to Medium.
Wed, Mar 24, 8:19 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-Revision-backend, Parsoid, Wikimedia-production-error
Pchelolo added a comment to T278376: Constructing RevisionRecord for a page that can't exist: Special:MyLanguage/Main Page [Called from MediaWiki\Revision\MutableRevisionRecord::__construct].

Also, just a note, this is a deprecation warning, not an exception, it's not affecting the users at all, so I'm not sure a UBN train blocker status is fair in this case.

Wed, Mar 24, 8:04 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-Revision-backend, Parsoid, Wikimedia-production-error
Pchelolo added a comment to T278376: Constructing RevisionRecord for a page that can't exist: Special:MyLanguage/Main Page [Called from MediaWiki\Revision\MutableRevisionRecord::__construct].

It's possible the RevisionRecord code changed in wmf.36? I'll look into it.

Wed, Mar 24, 8:03 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-Revision-backend, Parsoid, Wikimedia-production-error
Pchelolo created T278382: Clean up CirrusSearch job retries.
Wed, Mar 24, 7:51 PM · CirrusSearch, WMF-JobQueue, Platform Team Workboards (Clinic Duty Team), Discovery-Search
Pchelolo added a comment to T278367: The given PageIdentity does not represent a proper page.

This happened when an editor mistakenly make a redirect like this:

Wed, Mar 24, 6:34 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (MW Expedition), Wikimedia-production-error
Pchelolo edited projects for T278367: The given PageIdentity does not represent a proper page, added: Platform Team Workboards (MW Expedition); removed Platform Team Workboards (Clinic Duty Team).
Wed, Mar 24, 6:28 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (MW Expedition), Wikimedia-production-error
Pchelolo added a comment to T215001: Revisions missing from mediawiki_revision_create.

Would it be possible to get EditResult or whatever info is needed into RevisionRecordInserted we need?

Wed, Mar 24, 6:15 PM · Analytics-Kanban, Growth-Team, Product-Analytics, Analytics
Pchelolo added a comment to T215001: Revisions missing from mediawiki_revision_create.

Ok. Houston, we do have an implementation problem. I'm fairly certain sending the event from RevisionRecordInserted hook would mitigate the missing revisions problem. However, we don't have the EditResult object there, which is used for rev_is_revert as other revert-related data..

Wed, Mar 24, 5:18 PM · Analytics-Kanban, Growth-Team, Product-Analytics, Analytics
Pchelolo added a comment to T215001: Revisions missing from mediawiki_revision_create.

I think I know what the issue is.

Wed, Mar 24, 4:53 PM · Analytics-Kanban, Growth-Team, Product-Analytics, Analytics
Pchelolo added a comment to T278141: cxserver missing important metrics after service-runner 2.8.1 upgrade.

Did you update the entire service-template-node or just updated the service-runner? You need this patch to be present in service-template-node: https://github.com/wikimedia/service-template-node/pull/127

Wed, Mar 24, 12:41 PM · Patch-For-Review, Language-Team (Language-2021-April-June), CX-cxserver
Pchelolo updated the task description for T278284: RevisionRenderer should set ParserOutput timestamp and revision ID.
Wed, Mar 24, 3:18 AM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (MW Expedition)
Pchelolo created T278284: RevisionRenderer should set ParserOutput timestamp and revision ID.
Wed, Mar 24, 3:17 AM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (MW Expedition)

Tue, Mar 23

Pchelolo committed rGRBD531c474ab962: Update restbase to 51dbf87d (authored by Pchelolo).
Update restbase to 51dbf87d
Tue, Mar 23, 7:14 PM
Pchelolo created T278254: Rename where* methods in UserSelectQueryBuilder.
Tue, Mar 23, 6:58 PM · Platform Team Workboards (MW Expedition)
Pchelolo edited projects for T218395: Create RestrictionStore service, added: Platform Team Workboards (MW Expedition); removed Platform Team Workboards (Clinic Duty Team).
Tue, Mar 23, 2:00 PM · Platform Team Workboards (MW Expedition), MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, Platform Team Initiatives (Decoupling (CDP2))

Mon, Mar 22

Pchelolo added a comment to T276322: Avoid using User ::getNewtalk, ::getNewMessageLinks, ::getNewMessageRevisionId, ::setNewtalk.

Ready for hard for a patch adding hard deprecations.

Mon, Mar 22, 11:00 PM · MediaWiki-skins-Tempo, BlueSky, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Nostalgia, Technical-Debt (Deprecation process), Platform Team Workboards (MW Expedition)
Pchelolo closed T271977: Convert EditConstraint system to use Authority, a subtask of T271975: Convert EditPage to Authority, as Resolved.
Mon, Mar 22, 10:57 PM · Patch-For-Review, Platform Team Workboards (MW Expedition)
Pchelolo closed T271977: Convert EditConstraint system to use Authority as Resolved.
Mon, Mar 22, 10:57 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), User-DannyS712, Platform Team Workboards (MW Expedition)
Pchelolo closed T272039: Convert BlockPermissionChecker and BlockPermissionCheckerFactory to use Authority, a subtask of T231930: Introduce Authority objects to represent the user performing a given action, as Resolved.
Mon, Mar 22, 10:57 PM · Epic, Platform Team Workboards (MW Expedition), Platform Team Initiatives (Decoupling (CDP2)), User-Daniel, MediaWiki-User-management
Pchelolo closed T272039: Convert BlockPermissionChecker and BlockPermissionCheckerFactory to use Authority as Resolved.
Mon, Mar 22, 10:57 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Platform Team Workboards (MW Expedition), Platform Team Initiatives (Decoupling (CDP2)), MediaWiki-User-management
Pchelolo moved T272039: Convert BlockPermissionChecker and BlockPermissionCheckerFactory to use Authority from Waiting for Review to On the train on the Platform Team Workboards (MW Expedition) board.
Mon, Mar 22, 10:56 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Platform Team Workboards (MW Expedition), Platform Team Initiatives (Decoupling (CDP2)), MediaWiki-User-management
Pchelolo claimed T276610: Hard-deprecate AbstractBlock::getTarget and introduce AbstractBlock::getTargetIdentity.
Mon, Mar 22, 10:55 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, MediaWiki-Blocks, Platform Team Workboards (MW Expedition)
Pchelolo moved T273284: Make RevisionRecord::getPageId() take a wiki ID from Waiting for Review to Waiting for release on the Platform Team Workboards (MW Expedition) board.
Mon, Mar 22, 10:55 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, MediaWiki-Revision-backend, Platform Team Workboards (MW Expedition)
Pchelolo added a comment to T277795: User not found by actor ID: [id].

Status update: we expect https://gerrit.wikimedia.org/r/674131 to completely mitigate the issue once deployed.
There's some followups we would like to make maybe, but they're not required to unblock the train.

Mon, Mar 22, 10:52 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Performance-Team (Radar), Platform Team Workboards (MW Expedition), Growth-Team, User-brennen, MediaWiki-Recent-changes, Wikimedia-production-error
Pchelolo closed T275482: Avoid using UserIdentity::getUserId. Use UserIdentity::getId instead. as Resolved.

What was the reasoning for this back and forth? I can't find much of an explanation anywhere.

Mon, Mar 22, 1:56 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Growth-Team (Current Sprint), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management

Fri, Mar 19

Pchelolo added a comment to T277829: Understand or mitigate duplicate ParserCache fetches in the same request.

I think I know the reason for idoptions.

Fri, Mar 19, 2:25 AM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), MediaWiki-Parser

Thu, Mar 18

Pchelolo added a comment to T277795: User not found by actor ID: [id].

try harder to look up actors by falling back to master of the ID isn't found. Since an actor with a known ID should always exist, this should be rarely needed, so we could always try it when an ID isn't found. We do something similar in RevisionStore.

Thu, Mar 18, 8:29 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Performance-Team (Radar), Platform Team Workboards (MW Expedition), Growth-Team, User-brennen, MediaWiki-Recent-changes, Wikimedia-production-error
Pchelolo added a comment to T277795: User not found by actor ID: [id].

It seems like it happens for recent changes for anons who just made their first contribution. Before the patch referenced above we were using User::newFromAnyId which would just instantiate a new User no matter whether it's found in the DB or not, and then upon ->load it will just show the user defaults, while now we hard-crash if the actor is not found in the actor table.

Thu, Mar 18, 8:26 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Performance-Team (Radar), Platform Team Workboards (MW Expedition), Growth-Team, User-brennen, MediaWiki-Recent-changes, Wikimedia-production-error
Pchelolo added a comment to T277795: User not found by actor ID: [id].

Interesting. Definitely a fallout of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/669946/16/includes/changes/RecentChange.php#1226

Thu, Mar 18, 8:15 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Performance-Team (Radar), Platform Team Workboards (MW Expedition), Growth-Team, User-brennen, MediaWiki-Recent-changes, Wikimedia-production-error
Pchelolo edited projects for T277795: User not found by actor ID: [id], added: Platform Team Workboards (MW Expedition); removed Platform Engineering.
Thu, Mar 18, 7:56 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Performance-Team (Radar), Platform Team Workboards (MW Expedition), Growth-Team, User-brennen, MediaWiki-Recent-changes, Wikimedia-production-error

Wed, Mar 17

Pchelolo added a comment to T277693: ForeignDBFile attempts to load users in the context of the wrong wiki.

Yeah, we've done much progress with converting everything to UserIdentity/ActorStore and thus supporting better cross-wiki users, but haven't touched the File yet, mostly cause it's a very large class hierarchy, so it's hard and didn't qualify as a low hanging fruit.

Wed, Mar 17, 8:03 PM · Platform Team Workboards (MW Expedition), Patch-For-Review, Commons, MediaWiki-File-management
Pchelolo added a project to T277693: ForeignDBFile attempts to load users in the context of the wrong wiki: Platform Team Workboards (MW Expedition).
Wed, Mar 17, 7:59 PM · Platform Team Workboards (MW Expedition), Patch-For-Review, Commons, MediaWiki-File-management
Pchelolo added a comment to T277687: Deprecated cross-wiki access to User. Expected: 'eswiki', Actual: the local wiki. Pass expected $wikiId. [Called from User::getId].

Ok, I see what's going on.. Sneaky CentralAuth trying to pass around cross-wiki user as a User object... The patch above will not fix it right away, but is a necessary step before we can resolve this one.

Wed, Mar 17, 6:35 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Platform Team Workboards (MW Expedition), User-brennen, MediaWiki-extensions-CentralAuth, Wikimedia-production-error
Pchelolo edited projects for T277687: Deprecated cross-wiki access to User. Expected: 'eswiki', Actual: the local wiki. Pass expected $wikiId. [Called from User::getId], added: Platform Team Workboards (MW Expedition); removed Platform Engineering.
Wed, Mar 17, 6:27 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, Platform Team Workboards (MW Expedition), User-brennen, MediaWiki-extensions-CentralAuth, Wikimedia-production-error

Tue, Mar 16

Pchelolo added a comment to T275067: CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user: … (via SpecialImportFile).

Some more log context when this happens:

Tue, Mar 16, 1:53 PM · Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management, MediaWiki-Revision-backend, Move-Files-To-Commons, Release-Engineering-Team (Logspam), Wikimedia-production-error
Pchelolo moved T275509: Saving edits should not require a User object, a UserIdentity should be sufficient. from Waiting for Review to On the train on the Platform Team Workboards (MW Expedition) board.
Tue, Mar 16, 1:49 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MediaWiki-Decoupling, MediaWiki-Page-editing, Platform Team Workboards (MW Expedition)
Pchelolo edited projects for T234921: Factor group membership management out of User class, added: Platform Team Workboards (MW Expedition); removed Platform Team Workboards (Clinic Duty Team).
Tue, Mar 16, 1:45 PM · Platform Team Workboards (MW Expedition), MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), Patch-For-Review, MediaWiki-User-management, Platform Team Initiatives (Decoupling (CDP2))
Pchelolo moved T275482: Avoid using UserIdentity::getUserId. Use UserIdentity::getId instead. from Waiting for Review to On the train on the Platform Team Workboards (MW Expedition) board.
Tue, Mar 16, 1:43 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Growth-Team (Current Sprint), Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management
Pchelolo closed T276387: SearchNearMatcher: The given PageIdentity does not represent a proper page as Resolved.
Tue, Mar 16, 1:41 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Platform Team Workboards (MW Expedition), MediaWiki-Search, Wikimedia-production-error, Discovery-Search

Mon, Mar 15

Pchelolo claimed T252934: Hard deprecate manually constructing MovePage objects.
Mon, Mar 15, 5:41 PM · Platform Team Workboards (MW Expedition), MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-Renameuser, PageCuration, Cognate, MediaWiki-extensions-CentralAuth, MediaWiki-extensions-Translate, User-DannyS712, StructuredDiscussions, Wikidata, Technical-Debt (Deprecation process), Growth-Team, MediaWiki-Page-rename
Pchelolo added a comment to T277334: Deprecate and remove UserLoadFromDatabase hook.

Sounds good. Not used indeed and IMHO the hook is way too intrusive

Mon, Mar 15, 12:54 AM · Platform Team Workboards (Clinic Duty Team), User-DannyS712, Technical-Debt (Deprecation process)

Sun, Mar 14

Pchelolo added a comment to T276610: Hard-deprecate AbstractBlock::getTarget and introduce AbstractBlock::getTargetIdentity.

Yup, the patch is incorrect. We only need to return UserOdentity when previously User was returned. String for the ip range should still be returned

Sun, Mar 14, 3:42 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Patch-For-Review, MediaWiki-Blocks, Platform Team Workboards (MW Expedition)

Mar 5 2021

Pchelolo added a comment to T275030: Avoid using User ::isUsableName, ::isCreatableName, ::getCanonicalName.

Yes. Seems like all usages in extensions were removed.

Mar 5 2021, 6:36 PM · MediaWiki-extensions-Translate, MediaWiki-extensions-Other, MediaWiki-extensions-Auth_remoteuser, MediaWiki-extensions-Approved-Revs, RegexBlock, BlueSpice, MediaWiki-extensions-LdapAuthentication, Notifications, ConfirmEdit (CAPTCHA extension), AbuseFilter, MediaWiki-extensions-OpenStackManager, MediaWiki-extensions-FlaggedRevs, Growth-Team, MediaWiki-extensions-CentralAuth, MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Technical-Debt (Deprecation process), Platform Team Workboards (MW Expedition)