Page MenuHomePhabricator

Pchelolo
Disabled

User Details

User Since
Jun 24 2015, 10:23 AM (372 w, 4 d)
Roles
Disabled
LDAP User
Ppchelko
MediaWiki User
PPchelko (WMF) [ Global Accounts ]
This account has been disabled.

Recent Activity

Apr 11 2022

Daimona awarded T283766: Refactor SpecialPage execution checks to use Authority a Like token.
Apr 11 2022, 1:36 PM · Patch-For-Review, MediaWiki-Special-pages, Platform Team Workboards (MW Expedition)

Feb 9 2022

Pchelolo reopened T265846: Turn RESTBase tests for /html and /transform endpoints into api-testing integration tests, a subtask of T264669: Move VE API from RESTBase into core., as Open.
Feb 9 2022, 4:22 PM · Patch-For-Review, Epic, Platform Team Workboards (MW Expedition), User-xSavitar, API Platform, Code-Health-Objective, VisualEditor, Platform Engineering Roadmap, Platform Engineering Roadmap Decision Making
Pchelolo reopened T265846: Turn RESTBase tests for /html and /transform endpoints into api-testing integration tests as "Open".

The experiment was a success imho, so we need to actually do it now.

Feb 9 2022, 4:22 PM · Platform Team Workboards (Clinic Duty Team)
Pchelolo updated the task description for T264669: Move VE API from RESTBase into core..
Feb 9 2022, 4:09 PM · Patch-For-Review, Epic, Platform Team Workboards (MW Expedition), User-xSavitar, API Platform, Code-Health-Objective, VisualEditor, Platform Engineering Roadmap, Platform Engineering Roadmap Decision Making
Pchelolo created T301372: Core HTML REST API should follow redirects.
Feb 9 2022, 4:08 PM · Epic, Platform Team Workboards (MW Expedition), Code-Health-Objective, VisualEditor, Platform Engineering Roadmap
Pchelolo created T301371: Preemptively warm caches for Parsoid output.
Feb 9 2022, 4:04 PM · MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), Platform Team Workboards (MW Expedition), Parsoid (Tracking), Patch-For-Review, VisualEditor, serviceops, Performance-Team (Radar), Platform Engineering Roadmap
Pchelolo created T301370: Move transform endpoints from RESTBase to MediaWiki.
Feb 9 2022, 3:58 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), MediaWiki-REST-API, Platform Team Workboards (MW Expedition), VisualEditor, Platform Engineering Roadmap
Pchelolo updated the task description for T264669: Move VE API from RESTBase into core..
Feb 9 2022, 3:56 PM · Patch-For-Review, Epic, Platform Team Workboards (MW Expedition), User-xSavitar, API Platform, Code-Health-Objective, VisualEditor, Platform Engineering Roadmap, Platform Engineering Roadmap Decision Making
Pchelolo updated the task description for T264669: Move VE API from RESTBase into core..
Feb 9 2022, 3:53 PM · Patch-For-Review, Epic, Platform Team Workboards (MW Expedition), User-xSavitar, API Platform, Code-Health-Objective, VisualEditor, Platform Engineering Roadmap, Platform Engineering Roadmap Decision Making
Pchelolo closed T263587: CAPEX for ParserCache for Parsoid as Resolved.

ParserCache has been expanded under a separate project. This ticket is obsolete.

Feb 9 2022, 3:37 PM · Parsoid (Tracking), Data-Persistence (Consultation), serviceops, MediaWiki-Parser
Pchelolo closed T263587: CAPEX for ParserCache for Parsoid, a subtask of T262604: Reader quickly reads a wiki page, as Resolved.
Feb 9 2022, 3:37 PM · Parsoid (Tracking), Platform Team Workboards (Green), Story, MediaWiki-Parser
Pchelolo assigned T301346: Searching for special pages with REST API: The given PageIdentity Special:AbuseFilter does not represent a proper page to nnikkhoui.
Feb 9 2022, 2:30 PM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), MediaWiki-REST-API, affects-translatewiki.net, Platform Engineering

Feb 1 2022

Pchelolo added a comment to T249564: Determine purpose of GlobalVarConfig-backend entries in ConfigFactory (via wgConfigRegistry).

From what I've seen, there is nothing in those plans that suggests a separate source of config per extension, nor a specific use case or need for it.

Feb 1 2022, 11:57 PM · Performance-Team (Radar), good first task, Technical-Debt, MediaWiki-SettingsBuilder, Platform Engineering, MediaWiki-Configuration

Dec 1 2021

Pchelolo added a comment to T296684: SettingsLoader: add finalize method.

Yeah, finalize instead of unset. I'm already removing the unset in some of the other patches. $wgSettings is useful to have access to in tests.

Dec 1 2021, 3:35 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MediaWiki-SettingsBuilder

Nov 30 2021

Pchelolo created T296774: GlobalConfigSink fatals in PHP 8.1.
Nov 30 2021, 7:35 PM · PHP 8.1 support, MediaWiki-SettingsBuilder
Pchelolo added a comment to T274359: Mobile REST API delivers year old+ content for very select pages.

Pages were added to the list for multiple reasons:

Nov 30 2021, 3:59 PM · User-TheresNoTime, Platform Engineering, Page Content Service, Product-Infrastructure-Team-Backlog, Wikipedia-Android-App-Backlog, RESTBase-API, affects-Kiwix-and-openZIM

Nov 29 2021

Pchelolo created T296684: SettingsLoader: add finalize method.
Nov 29 2021, 9:08 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MediaWiki-SettingsBuilder
Pchelolo moved T295883: "Allow $wgSettings to be used in LocalSettings.php" breaks SMW from Ideas to Done on the MediaWiki-SettingsBuilder board.
Nov 29 2021, 9:06 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, MediaWiki-SettingsBuilder, affects-translatewiki.net, Platform Engineering
Pchelolo moved T296045: SettingsBuilder could expose a default config from Ideas to Doing on the MediaWiki-SettingsBuilder board.
Nov 29 2021, 9:06 PM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), MediaWiki-SettingsBuilder
Pchelolo moved T296647: MediaWiki YAML config documentation rendering from Ideas to Doing on the MediaWiki-SettingsBuilder board.
Nov 29 2021, 9:06 PM · MediaWiki-SettingsBuilder
Pchelolo moved T294748: SettingsLoader: implement caching from Doing to Done on the MediaWiki-SettingsBuilder board.
Nov 29 2021, 9:06 PM · MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), MediaWiki-SettingsBuilder
Pchelolo moved T294751: SettingsLoader: Add YAML support from Doing to Done on the MediaWiki-SettingsBuilder board.
Nov 29 2021, 9:06 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MediaWiki-SettingsBuilder
Pchelolo moved T294752: SettingsLoader: support ini-settings from Doing to Done on the MediaWiki-SettingsBuilder board.
Nov 29 2021, 9:06 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MediaWiki-SettingsBuilder
Pchelolo claimed T296045: SettingsBuilder could expose a default config.
Nov 29 2021, 9:05 PM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), MediaWiki-SettingsBuilder
Pchelolo renamed T296671: MediaWiki REST API Search results should resolve redirects from RESTBase Search results should resolve redirects to MediaWiki REST API Search results should resolve redirects.
Nov 29 2021, 8:04 PM · MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), MediaWiki-REST-API, API Platform, Desktop Improvements, WVUI
Pchelolo updated subscribers of T296647: MediaWiki YAML config documentation rendering.
Nov 29 2021, 4:31 PM · MediaWiki-SettingsBuilder
Pchelolo created T296647: MediaWiki YAML config documentation rendering.
Nov 29 2021, 4:31 PM · MediaWiki-SettingsBuilder
Pchelolo moved T296367: eslint-config-wikimedia should lint YAML from Ideas to Doing on the MediaWiki-SettingsBuilder board.
Nov 29 2021, 3:50 PM · MediaWiki-SettingsBuilder

Nov 26 2021

Pchelolo added a comment to T296508: ERROR @wdio/sync: Error: socket hang up.

Yup, reverting the patch mentioned by @thiemowmde will certainly fix this. I'll re-do the patch slightly differently later on, reverting is the right move now.

Nov 26 2021, 4:58 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, User-zeljkofilipin, ci-test-error, Release-Engineering-Team, Browser-Tests, GrowthExperiments, Growth-Team

Nov 24 2021

Pchelolo added a comment to T296367: eslint-config-wikimedia should lint YAML.

Patch https://github.com/wikimedia/eslint-config-wikimedia/pull/426

Nov 24 2021, 3:52 PM · MediaWiki-SettingsBuilder
Pchelolo created T296367: eslint-config-wikimedia should lint YAML.
Nov 24 2021, 5:11 AM · MediaWiki-SettingsBuilder
Pchelolo added a comment to T296331: Install php-yaml for use by SettingsLoader.

We will need to upload packages of php-yaml to our php72 and php74 sections on apt.wm.o. When did you want to have this available in production by?

Nov 24 2021, 4:42 AM · serviceops, Patch-For-Review, MW-on-K8s, Continuous-Integration-Config, MediaWiki-SettingsBuilder
Pchelolo closed T295718: Feedback request: SettingsLoader: move DefaultSettings.php to YAML as Resolved.

We've consulted with stakeholders identified in the Tech forum proposal and haven't seen too much opposition to the idea of YAML. It probably will not be the final destination, but it seems like an ok intermediate step in cleaning up the configs. I'm resolving this ticket.

Nov 24 2021, 4:40 AM · Performance-Team, Platform Team Workboards (MW Expedition), MediaWiki-SettingsBuilder

Nov 23 2021

Pchelolo added a comment to T296331: Install php-yaml for use by SettingsLoader.
In T296331#7524691, @Majavah wrote:

Will 3rd party MW installations require php-yaml in the future?

Nov 23 2021, 8:30 PM · serviceops, Patch-For-Review, MW-on-K8s, Continuous-Integration-Config, MediaWiki-SettingsBuilder
Pchelolo created T296314: SettingsLoader: settings files should have a schema.
Nov 23 2021, 4:54 PM · MediaWiki-SettingsBuilder
Pchelolo claimed T294751: SettingsLoader: Add YAML support.
Nov 23 2021, 4:30 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MediaWiki-SettingsBuilder
Pchelolo moved T294751: SettingsLoader: Add YAML support from Todo to Doing on the MediaWiki-SettingsBuilder board.
Nov 23 2021, 4:30 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MediaWiki-SettingsBuilder
Pchelolo moved T294749: Make SettingsLoader available in LocalSettings.php from Doing to Done on the MediaWiki-SettingsBuilder board.
Nov 23 2021, 3:57 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MediaWiki-SettingsBuilder
Pchelolo moved T295501: Implement relevant merge strategies from Doing to Done on the MediaWiki-SettingsBuilder board.
Nov 23 2021, 3:57 PM · MediaWiki-SettingsBuilder
Pchelolo added a comment to T296288: API Gateway needs a dual logging solution.

I don't think access logging in logstash would be very useful. It would be useful to send regular envoy logs to logstash, but filter on error level.

Nov 23 2021, 3:07 PM · Platform Team Workboards (Platform Engineering Reliability), Platform Team Initiatives (API Gateway)

Nov 22 2021

Pchelolo closed T94006: Remove AjaxDispatcher use from FlaggedRevs as Resolved.
Nov 22 2021, 9:25 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, Technical-Debt, MediaWiki-extensions-FlaggedRevs
Pchelolo closed T94006: Remove AjaxDispatcher use from FlaggedRevs, a subtask of T42786: Remove AjaxDispatcher from MediaWiki core, as Resolved.
Nov 22 2021, 9:25 PM · User-notice-archive, MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), User-Ladsgroup, Technical-Debt (Deprecation process), MW-1.27-release-notes, JavaScript, MediaWiki-General

Nov 19 2021

Ladsgroup awarded T292302: CommonsMetadata extension causes every page on commons to be always parsed twice a Love token.
Nov 19 2021, 3:16 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Performance-Team (Radar), CommonsMetadata, Platform Team Workboards (MW Expedition), MediaWiki-Parser
Pchelolo closed T292302: CommonsMetadata extension causes every page on commons to be always parsed twice as Resolved.

This worked :)

Nov 19 2021, 3:09 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Performance-Team (Radar), CommonsMetadata, Platform Team Workboards (MW Expedition), MediaWiki-Parser
Pchelolo closed T292302: CommonsMetadata extension causes every page on commons to be always parsed twice, a subtask of T292300: Eliminate unnecessary duplicate parses, as Resolved.
Nov 19 2021, 3:09 PM · MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), Patch-For-Review, Performance-Team (Radar), Platform Team Workboards (MW Expedition), MediaWiki-Parser

Nov 18 2021

Pchelolo created T296045: SettingsBuilder could expose a default config.
Nov 18 2021, 11:51 PM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), MediaWiki-SettingsBuilder
Pchelolo added a comment to T296023: Parsoid needs a LazyLinkTarget factory.

Note that LinkTarget knows nothing about page IDs. LinkTarget is a parsed full title string. Why exactly page IDs are involved is probably an optimization - Parser already resolved the page IDs for redlink rendering so we set them in ParserOutput to not waste good batch database result lookup.

Nov 18 2021, 11:47 PM · Parsoid-Read-Views (Phase 2 - testwiki Main namespace support), Parsoid
Pchelolo added a comment to T265775: Retire TitleExists hook.

Having fake RevisionRecord imho is not great - we are trying to all more and more invariants to it. Like we want RevisionRecord::getPage to return a PageIdentity, meaning that RevisionRecord can only exist for pages that potentially can exist. Doing that for example will break things like parsing in the context of the special page, which we do.

Nov 18 2021, 6:54 PM · Platform Team Workboards (MW Expedition), MediaWiki-Core-Hooks
Pchelolo added a comment to T295718: Feedback request: SettingsLoader: move DefaultSettings.php to YAML.

@Legoktm I've tried out converting our existing DefaultSettings into TOML. With introduction of config schemas the general structure for each key would be something like this in YAML:

Nov 18 2021, 5:08 PM · Performance-Team, Platform Team Workboards (MW Expedition), MediaWiki-SettingsBuilder

Nov 17 2021

Pchelolo added a comment to T295931: Wikimedia\Assert\ParameterAssertionException: Bad value for parameter $pageId: must be greater than zero.

So, the code that's asserting is

Nov 17 2021, 9:15 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Wikimedia-production-error
Pchelolo added a comment to T295883: "Allow $wgSettings to be used in LocalSettings.php" breaks SMW .

https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/5136 should fix the immediate issue on translatewiki.

Nov 17 2021, 8:41 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, MediaWiki-SettingsBuilder, affects-translatewiki.net, Platform Engineering
Pchelolo added a comment to T246371: Move job traffic from rpc/RunSingleJob to REST endpoint.

I fail to see the connection to k8s to be honest. Care to elaborate?

Nov 17 2021, 5:09 PM · serviceops-radar, ChangeProp, Platform Team Workboards (Clinic Duty Team), WMF-JobQueue, MediaWiki-Core-JobQueue
Pchelolo added a comment to T295883: "Allow $wgSettings to be used in LocalSettings.php" breaks SMW .

Ok, from reading all the tickets posted by @Reedy it seems like SemanticMediawiki supports installing via composer (e.g. it's code is pulled via composer). It's not (should not) be enabled by default though, there's enableSemantics function for that.

Nov 17 2021, 3:57 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, MediaWiki-SettingsBuilder, affects-translatewiki.net, Platform Engineering
Pchelolo added a comment to T295883: "Allow $wgSettings to be used in LocalSettings.php" breaks SMW .

What the path above did was to move composer autoloading before loading DefaultSettings.php. Which should not have mattered - composer dependencies shouldn't really depend on MediaWiki.

Nov 17 2021, 2:58 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, MediaWiki-SettingsBuilder, affects-translatewiki.net, Platform Engineering

Nov 16 2021

Pchelolo assigned T294739: remove configuration access via global variables in core to tchin.
Nov 16 2021, 7:02 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Patch-For-Review, MediaWiki-SettingsBuilder
Pchelolo moved T294741: SettingsLoader: export config to global variables from Doing to Done on the MediaWiki-SettingsBuilder board.
Nov 16 2021, 6:57 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), MediaWiki-SettingsBuilder
Pchelolo moved T295500: Create ConfigSink from Doing to Done on the MediaWiki-SettingsBuilder board.
Nov 16 2021, 6:57 PM · MediaWiki-SettingsBuilder
Pchelolo closed T291398: Turn usage of AJAX interface to API Modules (1) as Resolved.
Nov 16 2021, 3:35 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, Platform Engineering Code Jam, Platform Team Workboards (MW Expedition), Technical-Debt, Readers-Web-Backlog (Tracking), Collection
Pchelolo closed T291398: Turn usage of AJAX interface to API Modules (1), a subtask of T94005: Remove AjaxDispatcher use from Collection, as Resolved.
Nov 16 2021, 3:35 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Patch-For-Review, Technical-Debt, Readers-Web-Backlog (Tracking), Collection

Nov 15 2021

Pchelolo updated the task description for T295718: Feedback request: SettingsLoader: move DefaultSettings.php to YAML.
Nov 15 2021, 9:32 PM · Performance-Team, Platform Team Workboards (MW Expedition), MediaWiki-SettingsBuilder
Pchelolo created T295718: Feedback request: SettingsLoader: move DefaultSettings.php to YAML.
Nov 15 2021, 7:17 PM · Performance-Team, Platform Team Workboards (MW Expedition), MediaWiki-SettingsBuilder

Nov 11 2021

Pchelolo closed T269234: Eliminate the split between canonical and non-canonical ParserOptions as Resolved.

Yeah. ParserOptions still need a lot of love, but we can love them independently of this ticket.

Nov 11 2021, 4:44 PM · Platform Team Workboards (MW Expedition), MediaWiki-Parser

Nov 10 2021

Pchelolo placed T295504: ExtensionRegistry must not be instantiated in extensions up for grabs.
Nov 10 2021, 8:19 PM · Social-Tools, SocialProfile, MediaWiki-extensions-MediaWikiFarm, Growth-Team, StructuredDiscussions, MediaWiki-SettingsBuilder
Pchelolo created T295504: ExtensionRegistry must not be instantiated in extensions.
Nov 10 2021, 8:17 PM · Social-Tools, SocialProfile, MediaWiki-extensions-MediaWikiFarm, Growth-Team, StructuredDiscussions, MediaWiki-SettingsBuilder
Pchelolo moved T294744: SettingsLoader: activate extensions from Todo to Doing on the MediaWiki-SettingsBuilder board.
Nov 10 2021, 8:02 PM · Patch-For-Review, MediaWiki-SettingsBuilder

Nov 9 2021

Pchelolo added a comment to T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set.

ok. I guess I agree. let's squash them together.

Nov 9 2021, 3:51 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Wikidata-Campsite (Team A Hearth 🏰🔥), MediaWiki-Parser, Wikidata
Pchelolo added a comment to T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set.

Hm... Indeed you're right, it did remove it by making the content uncacheable. But it was a bad thing.
I still stand firm in my believe that it's a problem with tests, not with the patch :)

Nov 9 2021, 3:13 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Wikidata-Campsite (Team A Hearth 🏰🔥), MediaWiki-Parser, Wikidata
Pchelolo added a comment to T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set.

'disablelimitreport' is a different thing 'saved in parser cache' comment. These are 2 completely different comments from different systems. The reason 'saved in parser cache' started showing up is because we can not save more things in parser cache, and I guess one of your tests now has content that can be saved. There's never been a way to remove 'saved in parser cache' comment from the output.

Nov 9 2021, 2:57 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Wikidata-Campsite (Team A Hearth 🏰🔥), MediaWiki-Parser, Wikidata
Pchelolo added a comment to T295357: Parse API returns “saved in parser cache” comment even with disablelimitreport set.

But isn’t this something that should be avoided?

Nov 9 2021, 2:50 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Wikidata-Campsite (Team A Hearth 🏰🔥), MediaWiki-Parser, Wikidata

Nov 8 2021

Pchelolo added a comment to T295301: Access to undeclared static property: Http::$httpEngine .

only happened once, perhaps during pulling of the change... if you look at the stack trace, HttpRequestFactory.php line 98 doesn't have a reference to Http:$httpEngine anymore.

Nov 8 2021, 5:23 PM · Beta-Cluster-reproducible

Nov 5 2021

Pchelolo added a comment to T291967: Regression: Redirects from moves no longer tagged as new redirects.

Not on Friday unfortunately. No deployments on Fridays.

Nov 5 2021, 3:56 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), MW-1.38-release, Platform Team Workboards (MW Expedition), MediaWiki-Redirects, MediaWiki-Page-rename, Regression
Pchelolo closed T291967: Regression: Redirects from moves no longer tagged as new redirects as Resolved.
Nov 5 2021, 3:18 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), MW-1.38-release, Platform Team Workboards (MW Expedition), MediaWiki-Redirects, MediaWiki-Page-rename, Regression
Pchelolo assigned T295110: PHP Deprecated: Use of AbstractContent::getParserOutput was deprecated in MediaWiki 1.38. [Called from ContentHandler::callDeprecatedContentGPO] to roman-stolar.
Nov 5 2021, 2:39 PM · Platform Team Workboards (MW Expedition), affects-translatewiki.net

Nov 4 2021

Pchelolo closed T219279: Some pages will become completely unreachable after PHP7 update due to Unicode changes as Resolved.

Ok, fixed all the stuck renames. Done.

Nov 4 2021, 8:59 PM · User-notice-archive, MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), serviceops, SRE, PHP 7.2 support, MediaWiki-General
Pchelolo closed T219279: Some pages will become completely unreachable after PHP7 update due to Unicode changes, a subtask of T254470: Cannot create an actor for a usable name that is not an existing user: user_id=0 user_name="Ჯუღაშვილი", as Resolved.
Nov 4 2021, 8:59 PM · MediaWiki-Internationalization, MediaWiki-Core-Snapshots, User-RhinosF1
Pchelolo closed T295055: snapshot1010: PHP Warning: failed to get text for revid * as Resolved.

Done.

Nov 4 2021, 5:18 PM · Platform Engineering, Dumps-Generation, Wikimedia-production-error
Pchelolo added a comment to T295055: snapshot1010: PHP Warning: failed to get text for revid *.
mwscript findBadBlobs.php --wiki zhwiki --revisions 9530800
Scanning 1 ids
	! Found bad blob on revision 9530800 from 20090309212445 (main slot): content_id=8862958, address=<tt:9375723>, error='Bad data in text row 9375723. Use findBadBlobs.php to remedy.', type='MediaWiki\Storage\BlobAccessException'. ID9530800
	- Scanned a batch of 1 revisions
Nov 4 2021, 5:14 PM · Platform Engineering, Dumps-Generation, Wikimedia-production-error
Pchelolo added a comment to T295055: snapshot1010: PHP Warning: failed to get text for revid *.

This also affects simple page views: https://zh.wikipedia.org/wiki/Delon_Thamrin

Nov 4 2021, 4:55 PM · Platform Engineering, Dumps-Generation, Wikimedia-production-error
Pchelolo closed T294936: RESTBase deployment fails with scap internal error as Resolved.

Success! Thank you @dancy

Nov 4 2021, 3:55 PM · Release-Engineering-Team (Doing), serviceops, Scap

Nov 3 2021

Pchelolo added a comment to T294936: RESTBase deployment fails with scap internal error.

Actually, different result, now it's UndefinedError instead of AttributeError..

Nov 3 2021, 10:53 PM · Release-Engineering-Team (Doing), serviceops, Scap
Pchelolo added a comment to T294936: RESTBase deployment fails with scap internal error.

@Legoktm just tried to deploy again, same result.

Nov 3 2021, 10:51 PM · Release-Engineering-Team (Doing), serviceops, Scap
Pchelolo added a comment to T294743: SettingsLoader: expose bootstrap config for servie wiring.

Currently initialization of MWServices is quite a mess.

Nov 3 2021, 4:07 PM · MediaWiki-SettingsBuilder
Pchelolo created T294936: RESTBase deployment fails with scap internal error.
Nov 3 2021, 3:23 PM · Release-Engineering-Team (Doing), serviceops, Scap
Pchelolo moved T285389: Make Title use PageStore to access the page table from Waiting for Review to On the train on the Platform Team Workboards (MW Expedition) board.
Nov 3 2021, 3:14 PM · MediaWiki-Core-Revision-backend, Platform Team Workboards (MW Expedition)

Nov 2 2021

Pchelolo closed T287158: Move Content::getParserOutput method that don't belong in Content to ContentHandler, a subtask of T287116: Move Content methods that don't belong in Content to ContentHandler, as Resolved.
Nov 2 2021, 3:59 PM · Platform Team Workboards (MW Expedition)
Pchelolo closed T287158: Move Content::getParserOutput method that don't belong in Content to ContentHandler as Resolved.
Nov 2 2021, 3:59 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, Platform Team Workboards (MW Expedition)
Pchelolo added a comment to T293293: ReverseChronologicalPager::checkdate warns "PHP Notice: A non well formed numeric value encountered".

If we look at the URLs in logstash we can see something like /w/index.php?contribs=user&limit=50&month=1&namespace=&tagfilter=&target=127.0.0.1&title=Special:Contributions&year=3cCnJTIY'%20OR%20486=(SELECT%20486%20FROM%20PG_SLEEP(12)) - the 'year' parameter is garbage, someone is trying to do a little SQL injection here.

Nov 2 2021, 1:27 AM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Platform Engineering, MediaWiki-Comment-store, Wikimedia-production-error

Nov 1 2021

Pchelolo closed T292797: CommentFormatter: TypeError: Argument 1 passed to MediaWiki\CommentFormatter\CommentParser::preprocess() must be of the type string, null given as Resolved.
Nov 1 2021, 10:37 PM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), affects-translatewiki.net, MediaWiki-Comment-store, User-brennen, Platform Engineering, Wikimedia-production-error

Oct 28 2021

Pchelolo added a comment to T291120: MediaWiki Event Carried State Transfer - Problem Statement.

The format of "problem statement first, solutions later" is very hard to follow, since I feel immediate urge jump to solutions, I'll try to stick to the problem.

Oct 28 2021, 10:51 PM · Platform Engineering, Data-Engineering, Event-Platform Value Stream, tech-decision-forum

Oct 27 2021

Pchelolo added a comment to T245128: Remove deprecated code from SpecialPageFactory.

yes this can be removed.

Oct 27 2021, 8:02 PM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), Technical-Debt (Deprecation process), MediaWiki-Special-pages

Oct 26 2021

Pchelolo closed T284955: Remove LinkCache::addGoodLinkObj() as Resolved.
Oct 26 2021, 3:47 PM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Technical-Debt (Deprecation process), MediaWiki-General, Platform Team Workboards (MW Expedition)
Pchelolo reassigned T272557: Convert blocks to PageIdentity from vadim-kovalenko to Vlad.shapik.
Oct 26 2021, 12:46 PM · Patch-For-Review, Platform Team Workboards (MW Expedition)

Oct 25 2021

Pchelolo closed T284354: Should UserOptionsManager::saveOptions() be @internal ? as Resolved.
Oct 25 2021, 10:29 PM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Platform Team Workboards (MW Expedition), User-DannyS712, MediaWiki-Core-Preferences
Pchelolo closed T284354: Should UserOptionsManager::saveOptions() be @internal ? as Resolved.
Oct 25 2021, 3:05 PM · MW-1.38-notes (1.38.0-wmf.6; 2021-10-26), Platform Team Workboards (MW Expedition), User-DannyS712, MediaWiki-Core-Preferences

Oct 19 2021

Pchelolo claimed T293783: ImageInfo iiprop=comment query returns empty comment as hidden.
Oct 19 2021, 4:59 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), MW-1.37-notes, Patch-For-Review, Platform Team Workboards (MW Expedition), MW-1.37-release, Regression, MediaWiki-Action-API
Pchelolo edited projects for T293783: ImageInfo iiprop=comment query returns empty comment as hidden, added: Platform Team Workboards (MW Expedition); removed Platform Engineering.
Oct 19 2021, 4:47 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), MW-1.37-notes, Patch-For-Review, Platform Team Workboards (MW Expedition), MW-1.37-release, Regression, MediaWiki-Action-API
Pchelolo closed T281890: extensions/InviteSignup - Use UserGroupManager instead of User group methods, a subtask of T275148: Prepare User group methods for hard deprecation, as Resolved.
Oct 19 2021, 3:18 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Technical-Debt (Deprecation process), MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (MW Expedition)
Pchelolo closed T281890: extensions/InviteSignup - Use UserGroupManager instead of User group methods as Resolved.
Oct 19 2021, 3:18 AM · Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-extensions-InviteSignup, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-notes (1.36.0-wmf.37; 2021-03-30)
Pchelolo closed T281870: extensions/HAWelcome - Use UserGroupManager instead of User group methods, a subtask of T275148: Prepare User group methods for hard deprecation, as Resolved.
Oct 19 2021, 3:18 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Technical-Debt (Deprecation process), MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (MW Expedition)
Pchelolo closed T281870: extensions/HAWelcome - Use UserGroupManager instead of User group methods as Resolved.
Oct 19 2021, 3:18 AM · Platform Team Workboards (MW Expedition), HAWelcome, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-notes (1.36.0-wmf.37; 2021-03-30)