Pchelolo
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 24 2015, 10:23 AM (180 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Pchelolo [ Global Accounts ]

Recent Activity

Fri, Dec 7

Pchelolo added projects to T211461: Section edit endpoints in RESTBase: Still needed?: Services (blocked), Core Platform Team Backlog (Later).

From the RESTBase perspective, it means deleting a huge chunk of complicated code and a lot of simplification. If there are no plans to use these in the future, I would love to get rid of these.

Fri, Dec 7, 10:59 PM · Core Platform Team Backlog (Later), Services (blocked), Parsoid, VisualEditor, RESTBase
Pchelolo moved T211453: Remove dependency on WDQS for the recommendation API's morelike endpoint from Backlog to watching on the Services board.
Fri, Dec 7, 9:57 PM · Patch-For-Review, Services (watching), Recommendation-API, Research
Pchelolo added a comment to T210548: gzip-encoded page properties can't be exported from the API.

We have had to deal with this in EventBus as well, thes page properties are not JSON-encodable. We ended up with a hack like this.

Fri, Dec 7, 9:51 PM · Patch-For-Review, Core Platform Team Kanban (Waiting for Review), Maps (Kartographer), MediaWiki-API
Pchelolo added a comment to T211397: Recommendation API in beta labs doesn't work.

The one that I've posted I think is not easily replaceable with MW API, however, I think it's possible with a bit of code and might be faster than going to WDQS.

Fri, Dec 7, 9:21 PM · Core Platform Team Backlog (Next), Services (next), Beta-Cluster-reproducible, Recommendation-API, Research
Pchelolo added a comment to T211397: Recommendation API in beta labs doesn't work.

The exact query that's being used:

Fri, Dec 7, 8:36 PM · Core Platform Team Backlog (Next), Services (next), Beta-Cluster-reproducible, Recommendation-API, Research
Pchelolo added a comment to T211397: Recommendation API in beta labs doesn't work.

I think we have a consensus here. @Smalyshev would you agree with my proposal?

Fri, Dec 7, 8:29 PM · Core Platform Team Backlog (Next), Services (next), Beta-Cluster-reproducible, Recommendation-API, Research
Pchelolo added a comment to T211397: Recommendation API in beta labs doesn't work.

We use WDQS when we need to get article titles in a set of languages give a Wikidata item ID.

Fri, Dec 7, 8:20 PM · Core Platform Team Backlog (Next), Services (next), Beta-Cluster-reproducible, Recommendation-API, Research
Pchelolo updated subscribers of T211397: Recommendation API in beta labs doesn't work.

First things first, article 'Libro' does not exist in the beta Spanish wiki.

Fri, Dec 7, 7:50 PM · Core Platform Team Backlog (Next), Services (next), Beta-Cluster-reproducible, Recommendation-API, Research
Pchelolo added a comment to T211125: Move service-runner to new logging infrastructure.

There's not that much logging happening in beta services, I would guess we should start big, so deployment-restbase0[1,2]?

Fri, Dec 7, 2:57 PM · Core Platform Team Backlog (Next), Services (next), service-runner, Wikimedia-Logstash, Operations
Pchelolo added a comment to T211397: Recommendation API in beta labs doesn't work.

It is setup on deployment-sca, but I could not make it work. Needs more investigation why.

Fri, Dec 7, 12:08 AM · Core Platform Team Backlog (Next), Services (next), Beta-Cluster-reproducible, Recommendation-API, Research

Thu, Dec 6

Pchelolo committed rMSRD299b26800c21: Update recommendation-api to 19ac3d8 (authored by Pchelolo).
Update recommendation-api to 19ac3d8
Thu, Dec 6, 11:53 PM
Pchelolo added a comment to T211386: RESTBase x-amples test started failing for citoid in beta cluster due to zotero being disabled..

I can just remove the expectation of specific itemType, but let's see what @mobrovac has in mind.

Thu, Dec 6, 11:02 PM · Core Platform Team Kanban (Done with CPT), Services (done), Citoid, RESTBase
Pchelolo added a comment to T211386: RESTBase x-amples test started failing for citoid in beta cluster due to zotero being disabled..

Probably related to https://phabricator.wikimedia.org/T211088

Thu, Dec 6, 10:57 PM · Core Platform Team Kanban (Done with CPT), Services (done), Citoid, RESTBase
Pchelolo added a comment to T211386: RESTBase x-amples test started failing for citoid in beta cluster due to zotero being disabled..

Production is correct. @mobrovac disabled zotero in beta cluster. The problem only manifests in beta cluster.

Thu, Dec 6, 10:39 PM · Core Platform Team Kanban (Done with CPT), Services (done), Citoid, RESTBase
Pchelolo created T211386: RESTBase x-amples test started failing for citoid in beta cluster due to zotero being disabled..
Thu, Dec 6, 10:31 PM · Core Platform Team Kanban (Done with CPT), Services (done), Citoid, RESTBase
Pchelolo committed rMSCDf675fcc18fa9: Update change-propagation to eb1d7c9 (authored by Pchelolo).
Update change-propagation to eb1d7c9
Thu, Dec 6, 9:34 PM
Pchelolo committed rMSCP57ee2626d04c: Added performer to the revision-scores event (authored by Pchelolo).
Added performer to the revision-scores event
Thu, Dec 6, 9:27 PM
Pchelolo added a comment to T201868: Merge ORES precaching with ORESFetchScoreJob.

As we're finally emitting the revision-score events and will make them publically accessible soon, I would like to bring this up again.

Thu, Dec 6, 1:04 AM · ORES, Scoring-platform-team, Services (designing)
Pchelolo triaged T211267: ORES preaching seem to not understand it's own config as Normal priority.
Thu, Dec 6, 12:48 AM · Core Platform Team Backlog (Watching / External), Services (watching), ORES, Scoring-platform-team

Wed, Dec 5

Pchelolo added a comment to T206889: Develop a library for JSON schema backwards incompatibility detection.

Ping @Ottomata @Pchelolo is this work we are iaming to do for next quarter (january onwards) as we are also working on dockerization?

Wed, Dec 5, 10:29 PM · Core Platform Team Backlog (Later), Core Platform Team (Modern Event Platform (TEC2)), Services (watching), Analytics-EventLogging, EventBus, Analytics
Pchelolo added a comment to T211125: Move service-runner to new logging infrastructure.

Oh.... Apparently, apple have broken syslog in newer OSX versions, so I'm most certainly not the best persong to tackle this task. Supposedly, if we support receiving logs over UDP everything should work out of the box. If you're not too opposed to UDP transport, we could test it in beta almost immediately.

Wed, Dec 5, 10:07 PM · Core Platform Team Backlog (Next), Services (next), service-runner, Wikimedia-Logstash, Operations
Pchelolo updated subscribers of T211125: Move service-runner to new logging infrastructure.

So, currently we only support sending to syslog via UDP using the node-bunyan-syslog-upd package created by @mobrovac It's pure-js implementation since we want to avoid native bindings.

Wed, Dec 5, 8:35 PM · Core Platform Team Backlog (Next), Services (next), service-runner, Wikimedia-Logstash, Operations
Pchelolo lowered the priority of T199427: Separate dev Change-Prop from production Kafka cluster from Normal to Low.

We're currently not using CP in the dev cluster since we have no new major RESTBase features in work, so the CP was stopped there and thus the priority of this became lower.

Wed, Dec 5, 12:44 AM · Analytics, Wikimedia-Incident, ChangeProp, Operations, Services (designing)

Tue, Dec 4

Pchelolo added a comment to T197242: Transition citoid to use Zotero's translation-server-v2.

Seems like after this has been done the citation alerts started flapping much more then they used to. Also, the mean latency for citations endpoint went up from seconds to minutes.

Tue, Dec 4, 8:19 PM · Patch-For-Review, Services (done), VisualEditor (Current work), Citoid, Operations
Pchelolo committed rMSCDe1aeb273da4d: Update change-propagation to 1f06bff (authored by Pchelolo).
Update change-propagation to 1f06bff
Tue, Dec 4, 5:48 PM
Pchelolo added a project to T210465: Refinery Spark HiveExtensions schema merge should support merging of arrays with struct elements: Services (done).

Everything looks perfect from CP side. Please close whenever you feel like it.

Tue, Dec 4, 12:30 AM · Analytics-Kanban, Services (done), Patch-For-Review, Analytics

Mon, Dec 3

Pchelolo added a comment to T211026: [FEATURE REQUEST] Endpoint that renders user edit previews in the same format as mobile-html.

@bearND Currently MCS (PCS) only talks to MW and RB. Adding Parsoid into the mix would not be my preferred way to go. Adding an endpoint to MCS (PCS) where we can POST the HTML and get all the transformations done would feel more natural. We eventually can even change everything in MCS(PCS) to do POST based API - it will be more efficient then what we're doing now. One less round trip, one less load up of HTML from storage => less latency.

Mon, Dec 3, 10:12 PM · Services (watching), Reading-Infrastructure-Team-Backlog
Pchelolo added a comment to T211026: [FEATURE REQUEST] Endpoint that renders user edit previews in the same format as mobile-html.

@Pchelolo Yeah, that's why I think this new endpoint would probably be similar to /transform/wikitext/to/html{/title}{/revision}.

Mon, Dec 3, 9:53 PM · Services (watching), Reading-Infrastructure-Team-Backlog
Pchelolo added a project to T211026: [FEATURE REQUEST] Endpoint that renders user edit previews in the same format as mobile-html: Services (watching).
Mon, Dec 3, 9:30 PM · Services (watching), Reading-Infrastructure-Team-Backlog
Pchelolo added a comment to T211026: [FEATURE REQUEST] Endpoint that renders user edit previews in the same format as mobile-html.

Also, it's gonna be interesting to implement this. MCS output is based on Parsoid HTML, and the HTML is not POSTed to MCS, it GETs it from storage. So in order to implement the transform endpoint, we will need MCS to support a completely different request flow. Not that it is impossible, it just might be a bit more work than expected.

Mon, Dec 3, 9:30 PM · Services (watching), Reading-Infrastructure-Team-Backlog
Pchelolo committed rMSCDf13cd39623d0: Update change-propagation to 8092cf9 (authored by Pchelolo).
Update change-propagation to 8092cf9
Mon, Dec 3, 8:19 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rMSCD7470c85eff09: Merge "Revert "TEMP: stop producing the revision-score events."" (authored by Pchelolo).
Merge "Revert "TEMP: stop producing the revision-score events.""
Mon, Dec 3, 8:19 PM
Pchelolo committed rMSCPe9fe6e23585e: Move the errors out of the scores (authored by Pchelolo).
Move the errors out of the scores
Mon, Dec 3, 8:18 PM
Pchelolo committed rMSCD9cd79638f8a4: Revert "TEMP: stop producing the revision-score events." (authored by Pchelolo).
Revert "TEMP: stop producing the revision-score events."
Mon, Dec 3, 8:16 PM
Pchelolo added a reverting change for rMSCD867c5717aa23: TEMP: stop producing the revision-score events.: rMSCD9cd79638f8a4: Revert "TEMP: stop producing the revision-score events.".
Mon, Dec 3, 8:16 PM
Pchelolo committed rMSCD867c5717aa23: TEMP: stop producing the revision-score events. (authored by Pchelolo).
TEMP: stop producing the revision-score events.
Mon, Dec 3, 8:16 PM
Pchelolo added a comment to T210741: EventStreams process occasionally OOMs.

Mm.. I will not be that certain the deserialization of JSON is the issue here. We deserialize much much bigger messages in the job queue and have no problems with OOMs. I'm not opposed to the proposed patch, just saying I have a gut feeling it will not help to solve the problem. Since EventStreams is powered by service-runner, we can take a heap dump from prod with kill -SIGUSR2 and analyze the heap. I just don't have the sudo powers for that.

Mon, Dec 3, 6:36 PM · Patch-For-Review, Services, Wikimedia-Stream, Analytics

Fri, Nov 30

Pchelolo closed T210031: Create alert on EventBus 400 error rate as Resolved.

The alert has been created and tested.

Fri, Nov 30, 4:12 PM · Services (done), EventBus, Analytics
Pchelolo added a comment to T206785: Modern Event Platform: Stream Intake Service: Implementation.

my 2 cents: EventGate is awesome, GH is the best place for this piece of code.

Fri, Nov 30, 4:32 AM · Core Platform Team Backlog (Watching / External), Services (watching), Analytics-EventLogging, EventBus, Analytics

Tue, Nov 27

Pchelolo added a comment to T210451: Kafka eqiad.mediawiki.page-delete topic is empty.

Do you need the events for the last month to be replayed?

Tue, Nov 27, 6:06 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Core Platform Team Kanban (Done with CPT), Services (done), WMF-JobQueue, Wikimedia-Incident, Analytics, Wikidata, Wikidata-Query-Service, EventBus, Operations
Pchelolo added a comment to T210451: Kafka eqiad.mediawiki.page-delete topic is empty.

Not to be worried. We have all the failed events stored since 2018-04-18. If needed, I will fetch all the missing page deletes tomorrow.

Tue, Nov 27, 12:19 AM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Core Platform Team Kanban (Done with CPT), Services (done), WMF-JobQueue, Wikimedia-Incident, Analytics, Wikidata, Wikidata-Query-Service, EventBus, Operations

Mon, Nov 26

Pchelolo added a comment to T210393: Correctly encode titles in RB/CP for purges.

Hm... Tried testing this in beta and apparently Varnish purging is broken in beta cluster. Needs investigation.

Mon, Nov 26, 11:23 PM · RESTBase, ChangeProp, Core Platform Team Backlog (Next), Services (next)
Pchelolo added a comment to T210031: Create alert on EventBus 400 error rate.

So here's the plan: tomorrow I will test some alerts manually, if all goes well - we will add analytics into the contactgroup for eventbus dashboard.

Mon, Nov 26, 10:45 PM · Services (done), EventBus, Analytics
Pchelolo added a comment to T210031: Create alert on EventBus 400 error rate.

The ones we have for RESTBase doesn't go to IRC, but I think for analytics it should appear on IRC judging by https://github.com/wikimedia/puppet/blob/ce74f598509d2b448fc1252a3cd7c8241cc7b2c2/modules/nagios_common/files/contactgroups.cfg#L7

Mon, Nov 26, 10:41 PM · Services (done), EventBus, Analytics
Pchelolo added a comment to T210031: Create alert on EventBus 400 error rate.

@Nuria yes.

Mon, Nov 26, 10:37 PM · Services (done), EventBus, Analytics
Pchelolo edited projects for T210460: Eliminate usage of mocha-eslint, added: Services (later), Core Platform Team Backlog (Later), User-Clarakosi; removed Services.
Mon, Nov 26, 10:32 PM · User-Clarakosi, Core Platform Team Backlog (Later), Services (later)
Pchelolo added a comment to T210031: Create alert on EventBus 400 error rate.

Currently, if the alerts will be enabled, the emails will go to only to services mailing list should we add Analytics there as well?

Mon, Nov 26, 10:30 PM · Services (done), EventBus, Analytics
Pchelolo renamed T210031: Create alert on EventBus 400 error rate from Create alert on EventBus 400error rate to Create alert on EventBus 400 error rate.
Mon, Nov 26, 10:27 PM · Services (done), EventBus, Analytics
Pchelolo added projects to T210459: Explore adding validation alarms to eventbus using logstash : Services (watching), EventBus.

If I understand the proposal correctly, it's easier to do it using grafana alerts which I'm proposing in T210031

Mon, Nov 26, 10:26 PM · EventBus, Services (watching), Analytics
Pchelolo added a comment to T210451: Kafka eqiad.mediawiki.page-delete topic is empty.

Yes, the fix has not been deployed yet.

Mon, Nov 26, 9:28 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Core Platform Team Kanban (Done with CPT), Services (done), WMF-JobQueue, Wikimedia-Incident, Analytics, Wikidata, Wikidata-Query-Service, EventBus, Operations
GitHub <noreply@github.com> committed rMSCP1cb58ded8d0a: Mentioned Redis requirement in testing instruction (authored by Pchelolo).
Mentioned Redis requirement in testing instruction
Mon, Nov 26, 8:37 PM
GitHub <noreply@github.com> committed rMSCP8a9f54affde4: Updated testing instructions to the latest current (authored by Pchelolo).
Updated testing instructions to the latest current
Mon, Nov 26, 8:37 PM
GitHub <noreply@github.com> committed rMSCP3dcb95b20613: Properly reference $KAFKA_HOME in readme (authored by Pchelolo).
Properly reference $KAFKA_HOME in readme
Mon, Nov 26, 8:37 PM
GitHub <noreply@github.com> committed rMSCP82c2ae5c6c5b: Updated install instructions for required Kafka version (authored by Pchelolo).
Updated install instructions for required Kafka version
Mon, Nov 26, 8:37 PM
Pchelolo added a comment to T210426: Replace `json-stable-stringify` with `fast-json-stable-stringify`.

The fast-json-stable-stringify library is indeed 20% faster than the one we're using and it does not have any dependencies. Even though we do not use this lib in critical for performance code paths, I think replacing is still a good idea.

Mon, Nov 26, 7:50 PM · Core Platform Team Backlog (Later), User-Clarakosi, RESTBase, Services (later)
Pchelolo closed T197000: Modify revision-score schema so that model probabilities won't conflict as Resolved.

Ok. The events with the new schema are being emitted, there are no rejections on the EventBus service side, no errors in ChangeProp since the last patch was deployed. I believe we can finally resolve this task 🎉

Mon, Nov 26, 6:47 PM · Services (done), Scoring-platform-team, Analytics-Kanban, User-Ladsgroup, ORES, Analytics, EventBus
Pchelolo closed T197000: Modify revision-score schema so that model probabilities won't conflict, a subtask of T195979: Invalid field names in ORES models causing downstream Hive ingestion to fail, as Resolved.
Mon, Nov 26, 6:47 PM · User-Ladsgroup
Pchelolo committed rMSCDc89bff55e0bc: Update change-propagation to 4fa4d38 (authored by Pchelolo).
Update change-propagation to 4fa4d38
Mon, Nov 26, 6:38 PM
Gerrit Code Review <gerrit@wikimedia.org> committed rMSCD77be2c66cbaf: Merge "Revert "TEMP: Stop emitting revision-score event for schema change."" (authored by Pchelolo).
Merge "Revert "TEMP: Stop emitting revision-score event for schema change.""
Mon, Nov 26, 6:32 PM
Pchelolo committed rMSCD1dcb84b5c23f: Revert "TEMP: Stop emitting revision-score event for schema change." (authored by Pchelolo).
Revert "TEMP: Stop emitting revision-score event for schema change."
Mon, Nov 26, 6:32 PM
Pchelolo added a reverting change for rMSCDb97e8eb14277: TEMP: Stop emitting revision-score event for schema change.: rMSCD1dcb84b5c23f: Revert "TEMP: Stop emitting revision-score event for schema change.".
Mon, Nov 26, 6:32 PM
Pchelolo committed rMSCD42a119b5d8e4: Update change-propagation to 1cb58de (authored by Pchelolo).
Update change-propagation to 1cb58de
Mon, Nov 26, 6:32 PM
Pchelolo closed T210105: Cassandra JSON fields getting reversed as Invalid.
Mon, Nov 26, 6:10 PM · Services
Pchelolo created T210426: Replace `json-stable-stringify` with `fast-json-stable-stringify`.
Mon, Nov 26, 6:02 PM · Core Platform Team Backlog (Later), User-Clarakosi, RESTBase, Services (later)
Pchelolo added a comment to T210105: Cassandra JSON fields getting reversed.

Relying on the order of things in JSON was clearly a bug and it's nice that it's been fixed. However, I do not think json-stable-stringify was the one to blame - it's not used anywhere on the actual response data - it's used more on various metadata to compile hashes of, for example, table schemas. I do not quite understand which exact change has made the JSON properties reverse order, but since it's not specifyed, it could be literally anything. I'm inclined to close the task as Invalid.

Mon, Nov 26, 6:00 PM · Services
Pchelolo added a comment to T210393: Correctly encode titles in RB/CP for purges.

This is by design. REST API is supposed to be accessed when the whole {title} parameter is URI-encoded since that's how they're referenced by Varnish. We redirect to URI-encoded paths as well.

Mon, Nov 26, 2:46 PM · RESTBase, ChangeProp, Core Platform Team Backlog (Next), Services (next)

Tue, Nov 20

Pchelolo created T210031: Create alert on EventBus 400 error rate.
Tue, Nov 20, 11:25 PM · Services (done), EventBus, Analytics
Pchelolo edited projects for T210013: EventBus extension started emitting rev_count as a string, added: Services (doing); removed Services (later).

The argument is for some reason not documented

Tue, Nov 20, 11:16 PM · Patch-For-Review, Services (done), Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Analytics, EventBus
Pchelolo added a comment to T208922: PHP Fatal Error: Class undefined: JobExecutor (jobrunners try to run labswiki jobs).

Ok, I understand what's happening here. The BounceHandler extension sends the job cross-wiki, in this particular case to the wikitech wiki queue. However, JobQueueGroup::singleton()->get() uses global $wgJobTypeConf, which is different for all wikis except wikitech. That's how the event ends up in kafka and obviously fails cause wikitech doesn't support kafka job queue.

Tue, Nov 20, 10:31 PM · Performance-Team (Radar), Core Platform Team Kanban (Doing), Services (doing), WMF-JobQueue, Wikimedia-production-error
Pchelolo added a comment to T208922: PHP Fatal Error: Class undefined: JobExecutor (jobrunners try to run labswiki jobs).

Actually, I believe there's an easier way to find out the events that cause it: https://logstash.wikimedia.org/goto/2519c6383201ddf651de7e3effed92b9

Tue, Nov 20, 10:13 PM · Performance-Team (Radar), Core Platform Team Kanban (Doing), Services (doing), WMF-JobQueue, Wikimedia-production-error
Pchelolo created T210013: EventBus extension started emitting rev_count as a string.
Tue, Nov 20, 10:10 PM · Patch-For-Review, Services (done), Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Analytics, EventBus
Pchelolo added a project to T209890: Memory consumption in Redis 3.2 vs Redis 2.8 : Services (watching).
Tue, Nov 20, 8:50 PM · Services (watching), User-jijiki, SCB, ChangeProp, Operations
Pchelolo added a comment to T209890: Memory consumption in Redis 3.2 vs Redis 2.8 .

There actually is something wrong here. The average TTL for redis_misc in codfw is 0, which, I believe, indicate there's no TTL set at all in codfw.

Tue, Nov 20, 8:43 PM · Services (watching), User-jijiki, SCB, ChangeProp, Operations

Fri, Nov 16

Pchelolo closed T206048: Eliminate Parsoid section.offsets table from Cassandra as Resolved.

Yay!!! Since the keyspaces have been actually deleted, we can close the task now. Congrats @Clarakosi

Fri, Nov 16, 12:13 AM · Services (done), User-Clarakosi, goodfirstbug, RESTBase

Thu, Nov 15

Pchelolo added a comment to T207329: Clear watchlist on enwiki only removes 50 items at a time.

@Ottomata Let's try again? https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/EventBus/+/472189/

Thu, Nov 15, 7:52 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Growth-Team, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Core Platform Team Kanban (Blocked Externally), Services (blocked), Patch-For-Review, Analytics, EventBus, WMF-JobQueue, MediaWiki-Watchlist

Wed, Nov 14

Pchelolo added a comment to T206824: Decide whether to use schema references in the schema registry.

A quick update here.

Wed, Nov 14, 8:59 PM · Core Platform Team Backlog (Designing), Services (designing), Core Platform Team (Modern Event Platform (TEC2)), Analytics-EventLogging, EventBus, Analytics
Pchelolo added a comment to T206889: Develop a library for JSON schema backwards incompatibility detection.

So, some search results. I will not include only things that are remotely applicable to us:

Wed, Nov 14, 8:50 PM · Core Platform Team Backlog (Later), Core Platform Team (Modern Event Platform (TEC2)), Services (watching), Analytics-EventLogging, EventBus, Analytics
Pchelolo added a comment to T208616: Drop section-offsets keyspaces.

LGTM

Wed, Nov 14, 5:14 PM · Services (done), RESTBase

Tue, Nov 13

Pchelolo added projects to T176693: Cannot override basePath in the Swagger spec: Services (later), Core Platform Team Backlog (Later).

There should be a way to set basePath somewhere in config.*.yaml and get it merged into the Swagger spec.

Tue, Nov 13, 8:15 PM · Core Platform Team Backlog (Later), Services (later), HyperSwitch

Nov 9 2018

Pchelolo added a comment to T158829: Deprecate MediaWiki configurative variable, $wgObjectCacheSessionExpiry.

Oh, I've missed the use via config->get! I guess that means we need to support this in the multi-master session store if it's really used.

Nov 9 2018, 9:59 PM · Services (blocked), Technical-Debt, MediaWiki-Configuration
Pchelolo added a comment to T209070: Allow BBPromise cancellation.

A link to Slack? I don't have it, could you please copy-paste what you meant @Jdlrobson ?

Nov 9 2018, 5:37 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Done with CPT), Services (done), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Proton, service-runner
Pchelolo created T209164: Follow RFC7807 for all services error responses.
Nov 9 2018, 5:25 PM · HyperSwitch, service-template-node, RESTBase, Core Platform Team Backlog (Later), User-Clarakosi, Services (later)
Pchelolo reopened T158829: Deprecate MediaWiki configurative variable, $wgObjectCacheSessionExpiry as "Open".

Right now we're deciding on the interface for the multi-master session store and we're trying to decide how exactly to configure the TTL for sessions, and coming across this setting I started looking into the current codebase and failed to find any use of the config variable. It seems like in MW 1.27 change

Nov 9 2018, 5:10 PM · Services (blocked), Technical-Debt, MediaWiki-Configuration

Nov 8 2018

Pchelolo removed a project from T179682: Resolve issues with a volunteer pull request for html-metadata library: User-Clarakosi.
Nov 8 2018, 8:57 PM · Services (watching), goodfirstbug, Google-Code-in-2017
Pchelolo removed a project from T129503: Enable test coverage for mathoid: User-Clarakosi.
Nov 8 2018, 8:57 PM · Services (later), goodfirstbug, Mathoid
Pchelolo added a comment to T209070: Allow BBPromise cancellation.

I've proposed the env variable solution, but after sleeping on it I do not think it's a great one, it's more like a workaround. Env variables are supposed to be a configuration and in this case, cancellable promises are a requirement for the software to even work.

Nov 8 2018, 4:32 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Done with CPT), Services (done), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Proton, service-runner

Nov 7 2018

Pchelolo added a comment to T207329: Clear watchlist on enwiki only removes 50 items at a time.

Since T207817 got closed I guess we can make one more attempt to fix this.

Nov 7 2018, 4:41 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Growth-Team, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Core Platform Team Kanban (Blocked Externally), Services (blocked), Patch-For-Review, Analytics, EventBus, WMF-JobQueue, MediaWiki-Watchlist

Nov 5 2018

Pchelolo added a comment to T208616: Drop section-offsets keyspaces.

The code has been deployed. This could be applied in production now.

Nov 5 2018, 10:31 PM · Services (done), RESTBase
Pchelolo closed T207904: RESTBase doesn't check title normalization for wiktionary as Resolved.

Fix has been deployed

Nov 5 2018, 10:30 PM · Services (done), goodfirstbug, RESTBase
Pchelolo closed T207324: RESTBase adds duplicated `accept-language` entry in Vary header as Resolved.

fix has been deployed.

Nov 5 2018, 10:29 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Done with CPT), Services (done), goodfirstbug, RESTBase
Pchelolo added a comment to T208679: eventlogging Dockerfile doesn't work.

@Ottomata is a much better person to ping

Nov 5 2018, 5:19 PM · Analytics, Analytics-EventLogging

Nov 2 2018

Pchelolo added a comment to T201068: Modern Event Platform: Stream Intake Service.

heh, so it seems our beautiful idea for the API have just crashed into the rocks of reality @Ottomata

Nov 2 2018, 8:27 PM · Services (watching), Analytics-EventLogging, EventBus, Analytics-Kanban
Pchelolo edited projects for T208616: Drop section-offsets keyspaces, added: Services (doing); removed goodfirstbug, Services (later).
Nov 2 2018, 6:40 PM · Services (done), RESTBase

Oct 30 2018

Pchelolo added a comment to T208361: Make schemas use required $schema property with absolute path (not absolute URL) to the schema.

Some related conversations I was able to find https://github.com/json-schema/json-schema/issues/220#issuecomment-210152816 and I agree with the idea in that comment - by including the schema in any property within the data we already assume a certain format for the data (the fact it's JSON, the fact that $schema property exist, the fact it's pointing to the schema). It's really easy to verify, but logically it's wrong.

Oct 30 2018, 11:12 PM · Analytics, Core Platform Team Backlog (Later), Services (later), Analytics-EventLogging, EventBus
Pchelolo triaged T208361: Make schemas use required $schema property with absolute path (not absolute URL) to the schema as Normal priority.
Oct 30 2018, 9:47 PM · Analytics, Core Platform Team Backlog (Later), Services (later), Analytics-EventLogging, EventBus

Oct 26 2018

Pchelolo added a comment to T206824: Decide whether to use schema references in the schema registry.

I think by now we've all reached the agreement to use references.

Oct 26 2018, 4:55 PM · Core Platform Team Backlog (Designing), Services (designing), Core Platform Team (Modern Event Platform (TEC2)), Analytics-EventLogging, EventBus, Analytics

Oct 25 2018

Pchelolo added a comment to T207329: Clear watchlist on enwiki only removes 50 items at a time.

@Etonkovidova sorry I didn't update this ticket.. We've had an outage caused by the fix to it so it was reverted this morning. We will continue working on this - we know what the problem is, just need more time

Oct 25 2018, 11:50 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Growth-Team, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Core Platform Team Kanban (Blocked Externally), Services (blocked), Patch-For-Review, Analytics, EventBus, WMF-JobQueue, MediaWiki-Watchlist
Pchelolo added a comment to T207994: revision-create events are sometimes emitted in a secondary DC.

We can keep theorizing about this, but we need more information before we could make any real theory.

Oct 25 2018, 10:24 PM · User-Elukey, Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Backlog (Later), Analytics, EventBus, Services (later)
Pchelolo added a comment to T207994: revision-create events are sometimes emitted in a secondary DC.

Things I've checked so far:

  • There are no logs anywhere associated with these events.
  • All the events are legitimate edits, they exist in DB, they show up in the page history.
  • I did not find anything common between the events, it's just a completely random sample.
  • Events related to these edits are not present in eqiad.
Oct 25 2018, 9:45 PM · User-Elukey, Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Backlog (Later), Analytics, EventBus, Services (later)
Pchelolo added a comment to T207994: revision-create events are sometimes emitted in a secondary DC.

Nope. The events are all legitimate edits, just random portion of them. Here's an example:

Oct 25 2018, 9:18 PM · User-Elukey, Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Backlog (Later), Analytics, EventBus, Services (later)