Page MenuHomePhabricator

Pchelolo
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jun 24 2015, 10:23 AM (208 w, 5 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Pchelolo [ Global Accounts ]

Recent Activity

Today

Pchelolo closed T226109: Jobs not being executed on 1.34.0-wmf.10 as Resolved.

The fix to mw-config has been deployed, we should be good now.

Mon, Jun 24, 4:16 PM · Analytics, EventBus, Services (done), Core Platform Team Kanban (Done with CPT), Operations, WMF-JobQueue, MassMessage
Pchelolo closed T226109: Jobs not being executed on 1.34.0-wmf.10, a subtask of T220735: 1.34.0-wmf.10 deployment blockers, as Resolved.
Mon, Jun 24, 4:16 PM · Patch-For-Review, Release-Engineering-Team (Kanban), Release, Train Deployments
Pchelolo closed T226109: Jobs not being executed on 1.34.0-wmf.10, a subtask of T220736: 1.34.0-wmf.11 deployment blockers, as Resolved.
Mon, Jun 24, 4:16 PM · Release, Train Deployments
Pchelolo added a comment to T226109: Jobs not being executed on 1.34.0-wmf.10.

The above patch to mediawiki-config will fix it. This is another instance of having code in multiple places biting us hard. Given that it affects production, this config change has to be deployed ASAP

Mon, Jun 24, 3:59 PM · Analytics, EventBus, Services (done), Core Platform Team Kanban (Done with CPT), Operations, WMF-JobQueue, MassMessage
Pchelolo added a comment to T226109: Jobs not being executed on 1.34.0-wmf.10.

I do not have a solid theory of what's happening yet, but just throwing in some bits and pieces.

Mon, Jun 24, 3:21 PM · Analytics, EventBus, Services (done), Core Platform Team Kanban (Done with CPT), Operations, WMF-JobQueue, MassMessage

Thu, Jun 20

Pchelolo created T226198: Prepare change-prop to consume new-style messages.
Thu, Jun 20, 4:46 PM · Core Platform Team Kanban (Doing), Services (next), EventBus, Analytics-Kanban
Pchelolo added a comment to T211248: Modern Event Platform: Stream Intake Service: Migrate Mediawiki Eventbus events to eventgate-main.

Apparently, change-prop is not prepared for the new event schemas.

Thu, Jun 20, 4:28 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Core Platform Team Backlog (Watching / External), Services (watching), Analytics-EventLogging, EventBus, Analytics-Kanban

Mon, Jun 17

Pchelolo added a project to T216504: page-links-change stream is assigning template propagation events to the wrong edits: Services (watching).

So, the event is based on LinksUpdate hook. the LinksUpdate has getTriggeredRevision method which we use to assign a revision ID to the page. If it's null - we use the latest revId of the page. I believe that (logically, needs to be verified) the LinksUpdate object triggered by a template propagation will have null triggering rev id and thus we'd be able to distinguish the events.

Mon, Jun 17, 9:32 PM · Services (watching), The-Wikipedia-Library, MediaWiki-extensions-WikimediaEvents, Internet-Archive
Pchelolo added a comment to T211248: Modern Event Platform: Stream Intake Service: Migrate Mediawiki Eventbus events to eventgate-main.

Ok, I think this could be the list of remaining events from lowest to the highest risk, events that are coming from EventBus extension. The events coming from other sources (RB/ChangeProp) are not considered here as they are the highest risk.

Mon, Jun 17, 8:57 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Core Platform Team Backlog (Watching / External), Services (watching), Analytics-EventLogging, EventBus, Analytics-Kanban

Fri, Jun 14

Pchelolo added a comment to T225837: Fix npm installation of appservice wmflabs instance.

We should probably also recreate the VM as stretch as now it's running jessie.

Fri, Jun 14, 4:41 PM · Services, Reading-Infrastructure-Team-Backlog

Tue, Jun 11

Pchelolo edited projects for T225516: Page summary may not be purged/regenerated after revert, added: Services (doing), Core Platform Team Kanban (Doing), Core Platform Team (Code Health (TEC13)); removed Services.
Tue, Jun 11, 2:38 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Doing), Services (doing), ChangeProp, Page Content Service, Reading-Infrastructure-Team-Backlog
Pchelolo edited projects for T225443: Media endpoint does not refresh structured captions, added: Services (watching); removed Services.
Tue, Jun 11, 12:10 PM · Reading-Infrastructure-Team-Backlog (Kanban), ChangeProp, Services (watching), Page Content Service, WikimediaEditorTasks
Pchelolo added a comment to T224375: JSON validation in REST API.

OpenAPI 3 (which we want to be able to express our API specifications in) uses draft 5 with some extensions.

Tue, Jun 11, 12:10 PM · Reading-Infrastructure-Team-Backlog (Kanban), Core Platform Team Kanban (Doing), Core Platform Team (Parsoid REST API in PHP (CDP2)), MediaWiki-REST-API
Pchelolo added a comment to T225443: Media endpoint does not refresh structured captions.

We do track image usage in change-prop and rerender pages when images get updated, but indeed it's only done for local usage. Having the same mechanism for global usage is possible, even though we would miss some usages, but I support @Mholloway in his concern regarding the scalability of this.

Tue, Jun 11, 6:23 AM · Reading-Infrastructure-Team-Backlog (Kanban), ChangeProp, Services (watching), Page Content Service, WikimediaEditorTasks

Mon, Jun 10

Pchelolo created T225449: Enhance service-runner unhandledRejection reporting.
Mon, Jun 10, 5:58 PM · Core Platform Team Backlog (Later), Services (later), service-runner
Pchelolo closed T224462: Remove dependency from restbase-mod-table-cassandra to core-js as Resolved.

The PR was merged, thank you @holger.knust

Mon, Jun 10, 9:08 AM · Core Platform Team Kanban (Done with CPT), Services (done), RESTBase
Pchelolo closed T216191: Replace Istanbul with nyc as Resolved.

I'm sure we've forgot something, but it's ok, the remaining will be replaced as it goes.

Mon, Jun 10, 7:06 AM · Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (Security, stability, performance and scalability (TEC1))
Pchelolo updated the task description for T216191: Replace Istanbul with nyc.
Mon, Jun 10, 7:05 AM · Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (Security, stability, performance and scalability (TEC1))

Thu, Jun 6

Pchelolo added projects to T225228: Add standard Blubber config: Core Platform Team Backlog, Services.
Thu, Jun 6, 4:37 PM · Core Platform Team Backlog (Next), Services (next), service-template-node
Pchelolo added a comment to T220246: Session storage service Cassandra schema.

One thought - currently the syntax of the table_properties.yaml is something like JSON-path-stile pointers to configurations we need to replace in the original shema.cql. What if instead we allowed templating of the schema.cql and provided the configurations in a yaml similar to values.yaml we use in scap?

Thu, Jun 6, 8:38 AM · Core Platform Team (Session Management Service (CDP2)), User-Clarakosi, Core Platform Team Backlog (Next), User-Eevans

Wed, Jun 5

Pchelolo added a comment to T220246: Session storage service Cassandra schema.

I've removed the comment since the previous comment got be confused regarding terminology of schema vs configuration here.

Wed, Jun 5, 5:29 PM · Core Platform Team (Session Management Service (CDP2)), User-Clarakosi, Core Platform Team Backlog (Next), User-Eevans
Pchelolo added a comment to T220246: Session storage service Cassandra schema.
Wed, Jun 5, 4:28 PM · Core Platform Team (Session Management Service (CDP2)), User-Clarakosi, Core Platform Team Backlog (Next), User-Eevans
Pchelolo added projects to T225097: "JobExecutor not loaded" error for BounceHandlerJob on wikitech.wikimedia.org: Services (next), Core Platform Team Backlog (Next).

Wikitech should not be using kafka job queue at all per T192361#4139799

Wed, Jun 5, 3:44 PM · Core Platform Team Backlog (Next), Services (next), MediaWiki-extensions-BounceHandler, WMF-JobQueue, wikitech.wikimedia.org, Wikimedia-production-error
Pchelolo created T225066: User MCS in beta cluster for RESTBase testing.
Wed, Jun 5, 9:23 AM · Mobile-Content-Service, Reading-Infrastructure-Team-Backlog, Core Platform Team Kanban, Services (next)
Pchelolo closed T99883: Make "Response Messages" collapsed by default in API help as Invalid.
Wed, Jun 5, 8:27 AM · Core Platform Team Kanban (Done with CPT), Services (done)
Pchelolo added a comment to T99883: Make "Response Messages" collapsed by default in API help.

After upgrading to swagger-ui 3 everything is collapsed by default, so this is no longer a valid issue.

Wed, Jun 5, 8:26 AM · Core Platform Team Kanban (Done with CPT), Services (done)
Pchelolo closed T193773: Improvements to the new storage deletion mechanism as Invalid.

We have eliminated the timeline-based storage semantics alltogether, so this is no longer a valid issue.

Wed, Jun 5, 8:24 AM · Core Platform Team Kanban (Done with CPT), Services (done), RESTBase-Cassandra, RESTBase
Pchelolo updated the task description for T218217: Make services swagger specs standard compliant.
Wed, Jun 5, 8:22 AM · serviceops-radar, Core Platform Team (Security, stability, performance and scalability (TEC1)), Reading-Infrastructure-Team-Backlog, Proton, Graphoid, CX-cxserver, Citoid, Mathoid, Recommendation-API, Core Platform Team Backlog (Later), Services (later), Mobile-Content-Service, RESTBase-API, Operations
Pchelolo closed T168481: req.uri is sometimes a String and sometimes a URI in hyperswitch as Resolved.

This has been solved by https://github.com/wikimedia/swagger-router/pull/62

Wed, Jun 5, 8:21 AM · Core Platform Team Kanban (Done with CPT), Services (done), HyperSwitch, RESTBase
Pchelolo closed T219520: Replace online validator with swagger-cli as Resolved.

We have switched to using openapi-schema-validator so I believe this issue is resolved. Thank you @Clarakosi

Wed, Jun 5, 8:19 AM · Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (RESTBase Split (CDP2)), RESTBase-API, RESTBase
Pchelolo edited projects for T173447: Generalized rate limiting, deduplication, and job scheduling module, added: Services (done), Core Platform Team Kanban (Done with CPT); removed Core Platform Team Backlog (Later), Services (later).
Wed, Jun 5, 7:26 AM · Core Platform Team Kanban (Done with CPT), Services (done), EventBus, MediaWiki-JobQueue, Analytics, ChangeProp
Pchelolo closed T173447: Generalized rate limiting, deduplication, and job scheduling module as Declined.

I believe our current approach has proved to work well for us, I'm inclined to close this ticket

Wed, Jun 5, 7:25 AM · Core Platform Team Kanban (Done with CPT), Services (done), EventBus, MediaWiki-JobQueue, Analytics, ChangeProp
Pchelolo closed T222822: Make EventBus extension support configurable per-event/stream EventServiceName as Resolved.

The event destinations are configurable now, we can resolve this.

Wed, Jun 5, 7:23 AM · Patch-For-Review, Core Platform Team Kanban (Done with CPT), Services (done), MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Core Platform Team (Modern Event Platform (TEC2)), EventBus, Analytics
Pchelolo closed T222822: Make EventBus extension support configurable per-event/stream EventServiceName, a subtask of T211248: Modern Event Platform: Stream Intake Service: Migrate Mediawiki Eventbus events to eventgate-main, as Resolved.
Wed, Jun 5, 7:23 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Core Platform Team Backlog (Watching / External), Services (watching), Analytics-EventLogging, EventBus, Analytics-Kanban
Pchelolo closed T219385: Remove SIG* listeners in service runner on stop as Resolved.

Merged, published and tested. Resolving. Thank you @holger.knust

Wed, Jun 5, 5:45 AM · Core Platform Team Kanban (Done with CPT), Services (done), service-runner

Tue, Jun 4

Pchelolo edited projects for T223427: Make change-prop use test server provided by service-runner, added: Services (done), Core Platform Team Kanban (Done with CPT); removed Core Platform Team Backlog (Later), Services (later).
Tue, Jun 4, 2:47 PM · Core Platform Team Kanban (Done with CPT), Services (done), ChangeProp
Pchelolo added a comment to T210651: Switch all PDF render traffic to new Proton service.

The original issue report message was before the switch to the new PDF renderer, so it is 100% not related. The Electron renderer was experiencing some issues before we switched to proton, might be related to that.

Tue, Jun 4, 11:13 AM · User-notice, Patch-For-Review, Reading-Infrastructure-Team-Backlog, Core Platform Team Backlog (Later), Services (next), Readers-Web-Backlog (Tracking), Proton

Mon, Jun 3

Pchelolo added a comment to T214093: Modern Event Platform: Schema Guidelines and Conventions.

Hm. On one hand I would agree given that additional properties is basically a go for anything, so it can easily break refinery for example. On the other hand having additional properties: false makes it much harder to add new fields - we need to first add field as optional, then start producing it and then make it required if it is required. However, I think it's a minor problem.

Mon, Jun 3, 5:43 PM · Analytics, Better Use Of Data, Patch-For-Review, Product-Analytics, Core Platform Team Backlog (Watching / External), Core Platform Team (Modern Event Platform (TEC2)), Goal, Services (watching), Analytics-EventLogging, EventBus

Thu, May 30

Pchelolo added a watcher for Core Platform Team: Pchelolo.
Thu, May 30, 9:20 PM

Wed, May 29

Pchelolo added a comment to T224487: Make RESTBase take full request template for Parsoid requests.

Yes, but the paths are probably gonna be different as well..

Wed, May 29, 5:01 AM · Core Platform Team Backlog (Designing), Core Platform Team (RESTBase Split (CDP2)), Services (next), RESTBase

Tue, May 28

Pchelolo created T224487: Make RESTBase take full request template for Parsoid requests.
Tue, May 28, 3:28 PM · Core Platform Team Backlog (Designing), Core Platform Team (RESTBase Split (CDP2)), Services (next), RESTBase
Pchelolo added a comment to T221173: Resolve domains in path of endpoints for Parsoid REST API.

In theory that logic could be amended to handle Parsoid REST URLs with domains in them, but it would be confusing, would add extra complexity for no good reason, and would not work for third parties

Tue, May 28, 3:26 PM · MediaWiki-REST-API
Pchelolo updated the task description for T224462: Remove dependency from restbase-mod-table-cassandra to core-js.
Tue, May 28, 12:03 PM · Core Platform Team Kanban (Done with CPT), Services (done), RESTBase
Pchelolo created T224462: Remove dependency from restbase-mod-table-cassandra to core-js.
Tue, May 28, 10:30 AM · Core Platform Team Kanban (Done with CPT), Services (done), RESTBase

May 24 2019

Pchelolo added a comment to T223998: Remove old (a.k.a NG) Parsoid tables.

LGTM, but let's not execute it until next week?

May 24 2019, 6:44 AM · Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (RESTBase Split (CDP2)), Cassandra, RESTBase-Cassandra, RESTBase

May 23 2019

Pchelolo added a comment to T224222: Some citoid requests aren't timing out and are pending indefinitely.

Couple of notes:

May 23 2019, 2:25 PM · Core Platform Team Backlog (Watching / External), RESTBase-API, Services (watching), Citoid

May 21 2019

Pchelolo moved T222966: > 2% of API wall time spent generating UUIDs from Inbox to Doing on the Core Platform Team Kanban board.
May 21 2019, 1:08 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Core Platform Team Kanban (Doing), EventBus, Core Platform Team (Modern Event Platform (TEC2)), Services-next, Analytics, Performance
Pchelolo edited projects for T222966: > 2% of API wall time spent generating UUIDs, added: Core Platform Team Kanban; removed Patch-For-Review, Core Platform Team Backlog (Next).
May 21 2019, 1:08 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Core Platform Team Kanban (Doing), EventBus, Core Platform Team (Modern Event Platform (TEC2)), Services-next, Analytics, Performance
Pchelolo moved T223326: JS mediawiki-title library has wrong max length from Inbox to Ready on the Core Platform Team Kanban board.
May 21 2019, 1:06 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban, Services (next)
Pchelolo edited projects for T223326: JS mediawiki-title library has wrong max length, added: Core Platform Team Kanban, Core Platform Team (Security, stability, performance and scalability (TEC1)); removed Core Platform Team Backlog (Next).
May 21 2019, 1:06 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban, Services (next)
Pchelolo moved T223345: Zotero container: Production is running candidate version, last production version is broken due to lack of ca-certificates package from Next to Watching / External on the Core Platform Team Backlog board.
May 21 2019, 1:00 PM · Core Platform Team Backlog (Watching / External), Beta-Cluster-reproducible, Editing-team, Services (next), serviceops
Pchelolo added a comment to T223998: Remove old (a.k.a NG) Parsoid tables.

LGTM

May 21 2019, 12:35 PM · Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (RESTBase Split (CDP2)), Cassandra, RESTBase-Cassandra, RESTBase
Pchelolo created T223989: PCS errors on media endpoint.
May 21 2019, 11:38 AM · Page Content Service, Reading-Infrastructure-Team-Backlog (Kanban), Core Platform Team Backlog (Watching / External), Services (watching)

May 18 2019

mobrovac awarded T223690: Replace Cassandra-uuid with uuid a 100 token.
May 18 2019, 2:52 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Backlog (Later), Services (later)
Pchelolo triaged T223690: Replace Cassandra-uuid with uuid as Lowest priority.
May 18 2019, 9:06 AM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Backlog (Later), Services (later)
Pchelolo created T223690: Replace Cassandra-uuid with uuid.
May 18 2019, 9:06 AM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Backlog (Later), Services (later)
Pchelolo edited projects for T223637: Rerenders happen every time Parsoid request is made with revision parameter, added: Services (designing); removed Services.

This is a result of how we're treating the storage of Parsoid data now. Older revisions are not stored anymore unless you provide ?stash=true parameter and a matching html/data-parsoid can only be fetched if you provide a TID.

May 18 2019, 7:42 AM · Services (designing), Parsoid, Reading-Infrastructure-Team-Backlog

May 16 2019

Pchelolo placed T222795: Re-evaluate service-runner's (ab)use of statsd timing metric for nodejs GC stats up for grabs.
May 16 2019, 9:40 AM · serviceops-radar, Patch-For-Review, Services (later), service-runner, Operations
Pchelolo triaged T219425: preq emits unhandled rejection on socket timeout as Normal priority.
May 16 2019, 9:22 AM · Core Platform Team Backlog (Later), Services (later), RESTBase
Pchelolo claimed T216203: RESTBase content-negotiation tests are broken.
May 16 2019, 9:20 AM · RESTBase, Parsoid, Services (later)
Pchelolo triaged T219385: Remove SIG* listeners in service runner on stop as Normal priority.
May 16 2019, 9:19 AM · Core Platform Team Kanban (Done with CPT), Services (done), service-runner
Pchelolo claimed T204295: EventBus should make better use of DI.
May 16 2019, 9:18 AM · Patch-For-Review, Analytics, Core Platform Team Backlog (Later), good first bug, Services (later), EventBus
Pchelolo merged T219386: Use service-runner test service in change-prop tests into T223427: Make change-prop use test server provided by service-runner.
May 16 2019, 9:17 AM · Core Platform Team Kanban (Done with CPT), Services (done), ChangeProp
Pchelolo merged task T219386: Use service-runner test service in change-prop tests into T223427: Make change-prop use test server provided by service-runner.
May 16 2019, 9:17 AM · Core Platform Team Backlog (Later), ChangeProp, Services (later)
Pchelolo triaged T223427: Make change-prop use test server provided by service-runner as Low priority.
May 16 2019, 9:16 AM · Core Platform Team Kanban (Done with CPT), Services (done), ChangeProp
Pchelolo created T223427: Make change-prop use test server provided by service-runner.
May 16 2019, 9:16 AM · Core Platform Team Kanban (Done with CPT), Services (done), ChangeProp
Pchelolo triaged T219427: Use service-runner provided test server in service-template as Low priority.
May 16 2019, 9:15 AM · Core Platform Team Backlog (Later), Services (later), service-template-node
Pchelolo triaged T221720: Remove mwUtil.decodeBody as Low priority.

Since I have finished refactoring and reshuffling code in parsoid.js module this can now be picked up and worked on.

May 16 2019, 9:12 AM · Core Platform Team Backlog (Later), Services (later), RESTBase
Pchelolo triaged T223326: JS mediawiki-title library has wrong max length as Low priority.
May 16 2019, 9:11 AM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban, Services (next)

May 15 2019

Pchelolo added projects to T98995: Extension and transclusion content is no longer being reused from cache for parse jobs from the job queue: Services (watching), Core Platform Team Backlog (Watching / External).

Currently we also are supplying original HTML and Data-Parsoid for wikitext/to/html transformations. This caused a bug in RESTBase when the transformation was failing if the original was not present and attempt to fetch it was failing with a 404. Currently, the optimization is disabled in Parsoid, we will stop fetching the original to save some roundtrips to cassandra. When(if) the optimization is reintroduced, we will need to start fetching the original again, but make sure we gracefully handle the case when it's not there.

May 15 2019, 4:30 PM · Core Platform Team Backlog (Watching / External), Services (watching), Parsoid
Pchelolo moved T222520: Unable to expand /page/definition endpoint docs from blocked to doing on the Services board.
May 15 2019, 6:20 AM · Core Platform Team Kanban (Done with CPT), Services (done), Reading-Infrastructure-Team-Backlog, Page Content Service
Pchelolo moved T222520: Unable to expand /page/definition endpoint docs from watching to blocked on the Services board.
May 15 2019, 6:20 AM · Core Platform Team Kanban (Done with CPT), Services (done), Reading-Infrastructure-Team-Backlog, Page Content Service
Pchelolo added a comment to T222520: Unable to expand /page/definition endpoint docs.

The definitions docs had incorrect referencing and apparently swagger 3 is not as chill about it as swagger 2, https://github.com/wikimedia/restbase/pull/1133 fixes it

May 15 2019, 6:20 AM · Core Platform Team Kanban (Done with CPT), Services (done), Reading-Infrastructure-Team-Backlog, Page Content Service

May 14 2019

Pchelolo assigned T223326: JS mediawiki-title library has wrong max length to holger.knust.

Good point. So, we need to replace the .length with Buffer.byteLength with 'utf8' encoding and provide some tests.

May 14 2019, 8:11 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban, Services (next)
Pchelolo added a comment to T223281: [{exception_id}] {exception_url} ErrorException from line 599 of /srv/mediawiki/php-1.34.0-wmf.4/extensions/VisualEditor/includes/ApiVisualEditor.php: PHP Notice: Undefined variable: restbaseHeaders.

I believe https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/503651 is the reason.

May 14 2019, 3:07 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), User-Ryasmeen, VisualEditor-MediaWiki, Patch-For-Review, VisualEditor, RESTBase, Release-Engineering-Team (Kanban), Train Deployments
Pchelolo moved T222966: > 2% of API wall time spent generating UUIDs from Inbox to Next on the Core Platform Team Backlog board.
May 14 2019, 1:06 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Core Platform Team Kanban (Doing), EventBus, Core Platform Team (Modern Event Platform (TEC2)), Services-next, Analytics, Performance
Pchelolo added a comment to T222966: > 2% of API wall time spent generating UUIDs.

What is this mediawiki.api-request data ultimately for and why does it require a UUID?

May 14 2019, 11:02 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Core Platform Team Kanban (Doing), EventBus, Core Platform Team (Modern Event Platform (TEC2)), Services-next, Analytics, Performance

May 13 2019

Pchelolo added a comment to T222795: Re-evaluate service-runner's (ab)use of statsd timing metric for nodejs GC stats.

The caveat would be we would have to update all dashboards for all services residing on the same host cluster (scb being the problem here) pretty much on the same timeframe, mostly due to the fact statsd configuration is the same for all services on the same host.

May 13 2019, 12:33 PM · serviceops-radar, Patch-For-Review, Services (later), service-runner, Operations
Pchelolo closed T222639: VisualEditor should request Parsoid HTML with ?stash=true query parameter as Resolved.

The patch has been SWATted, so now VE provides an appropriate query parameter and the responses are not cached. This particular one is done. Resolving.

May 13 2019, 11:48 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team Kanban (Done with CPT), Services (done), VisualEditor (Current work), Core Platform Team (RESTBase Split (CDP2)), User-mobrovac, Parsoid, RESTBase
Pchelolo closed T222639: VisualEditor should request Parsoid HTML with ?stash=true query parameter, a subtask of T215956: Consider stashing data-parsoid for VE , as Resolved.
May 13 2019, 11:48 AM · User-Ryasmeen, Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (RESTBase Split (CDP2)), User-Eevans, User-mobrovac, Parsoid, VisualEditor, RESTBase
Pchelolo assigned T222795: Re-evaluate service-runner's (ab)use of statsd timing metric for nodejs GC stats to holger.knust.

Thank you for an impressive level of details :) There's a bunch of other places where we abuse the timing metric within services exactly for the reason that we've needed to have percentiles, so the decision we make here should probably be adopted elsewhere.

May 13 2019, 11:11 AM · serviceops-radar, Patch-For-Review, Services (later), service-runner, Operations
Pchelolo moved T222384: Enable storage and pre-generation for PCS endpoints from Backlog to later on the Services board.
May 13 2019, 10:59 AM · Services (later), Reading-Infrastructure-Team-Backlog, Core Platform Team Backlog (Later), Page Content Service, ChangeProp, RESTBase

May 12 2019

Pchelolo added projects to T222966: > 2% of API wall time spent generating UUIDs: Services-next, Core Platform Team Backlog, Core Platform Team (Modern Event Platform (TEC2)), EventBus.

We have been using UUID v1 in EventBus events for a while now with no problem, but I guess for other events it did not really matter since they're much lower volume and are created within already very heavy code paths.

May 12 2019, 3:44 AM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Core Platform Team Kanban (Doing), EventBus, Core Platform Team (Modern Event Platform (TEC2)), Services-next, Analytics, Performance

May 9 2019

Pchelolo assigned T222841: Incorrect links to source maps in Swagger-UI to Clarakosi.

Clearly, the links are incorrect, the /api/rest_v1/ is missing. I think it's related to how we're replacing paths in swaggerUI.js in hyperswitch. @Clarakosi was working on it a lot recently, she should be able to have a look.

May 9 2019, 3:58 PM · RESTBase-API, HyperSwitch, Core Platform Team Kanban (Done with CPT), Services (done)
Pchelolo moved T222520: Unable to expand /page/definition endpoint docs from Backlog to watching on the Services board.
May 9 2019, 3:54 PM · Core Platform Team Kanban (Done with CPT), Services (done), Reading-Infrastructure-Team-Backlog, Page Content Service
Pchelolo edited projects for T222822: Make EventBus extension support configurable per-event/stream EventServiceName, added: Services (doing), Core Platform Team Kanban (Doing), Core Platform Team (Modern Event Platform (TEC2)); removed Services.
May 9 2019, 3:41 PM · Patch-For-Review, Core Platform Team Kanban (Done with CPT), Services (done), MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Core Platform Team (Modern Event Platform (TEC2)), EventBus, Analytics

May 7 2019

Pchelolo added a comment to T206029: VE does not provide If-Match for html/to/wikitext transforms sometimes.

It's is still the case sometimes. It's not severe, but we actually have a hack to insert an artificial meta tag with an article TID into Parsoid HTML in order to workaround this issue. It was added as temporary workaround many years ago and is becoming a permanent workaround, which is not good.

May 7 2019, 3:24 PM · Core Platform Team Backlog (Watching / External), Services (watching), RESTBase-API, VisualEditor, RESTBase

May 6 2019

Pchelolo added a comment to T222639: VisualEditor should request Parsoid HTML with ?stash=true query parameter.

(a) this should actually be documented in the API docs (swagger?) alongwith the implications of what happens if a client doesn't comply

May 6 2019, 4:41 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team Kanban (Done with CPT), Services (done), VisualEditor (Current work), Core Platform Team (RESTBase Split (CDP2)), User-mobrovac, Parsoid, RESTBase
Pchelolo renamed T222639: VisualEditor should request Parsoid HTML with ?stash=true query parameter from VisualEditor should request Parsed HTML with ?stash=true query parameter to VisualEditor should request Parsoid HTML with ?stash=true query parameter.
May 6 2019, 4:34 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team Kanban (Done with CPT), Services (done), VisualEditor (Current work), Core Platform Team (RESTBase Split (CDP2)), User-mobrovac, Parsoid, RESTBase
Pchelolo created T222639: VisualEditor should request Parsoid HTML with ?stash=true query parameter.
May 6 2019, 4:34 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Core Platform Team Kanban (Done with CPT), Services (done), VisualEditor (Current work), Core Platform Team (RESTBase Split (CDP2)), User-mobrovac, Parsoid, RESTBase
Pchelolo moved T222457: Turn node-service-template libs into a common npm library for services from Backlog to later on the Services board.
May 6 2019, 3:31 PM · Services (later)
Pchelolo added a comment to T213193: Migrate changeprop to kubernetes.

changeprop has not been moved to k8s, so no, it can not be marked as resolved.

May 6 2019, 3:16 PM · Release-Engineering-Team, Release-Engineering-Team-TODO, Services (watching), Release Pipeline, serviceops, ChangeProp

May 2 2019

Pchelolo moved T222377: Move kartotherian/tilerator logging to new logging pipeline from Inbox to Watching / External on the Core Platform Team Backlog board.
May 2 2019, 6:09 PM · Core Platform Team Backlog (Watching / External), Services (watching), Maps, Reading-Infrastructure-Team-Backlog, service-runner, Wikimedia-Logstash, Operations
Pchelolo updated the task description for T219385: Remove SIG* listeners in service runner on stop.
May 2 2019, 6:01 PM · Core Platform Team Kanban (Done with CPT), Services (done), service-runner
Pchelolo moved T222377: Move kartotherian/tilerator logging to new logging pipeline from Backlog to watching on the Services board.
May 2 2019, 5:59 PM · Core Platform Team Backlog (Watching / External), Services (watching), Maps, Reading-Infrastructure-Team-Backlog, service-runner, Wikimedia-Logstash, Operations
Pchelolo created T222384: Enable storage and pre-generation for PCS endpoints.
May 2 2019, 4:52 PM · Services (later), Reading-Infrastructure-Team-Backlog, Core Platform Team Backlog (Later), Page Content Service, ChangeProp, RESTBase

Apr 30 2019

Pchelolo reassigned T221720: Remove mwUtil.decodeBody from Holger to holger.knust.
Apr 30 2019, 7:33 PM · Core Platform Team Backlog (Later), Services (later), RESTBase

Apr 29 2019

Pchelolo added a comment to T216636: Consider deprecating section editing API in RESTBase.

After adding the warn logging, there were 15 requests recorded for getSections all in a span of a few minutes, from a browser, so I believe that was someone playing with it from the docs UI. I think we can safely remove the endpoints and the code.

Apr 29 2019, 10:31 PM · User-Ryasmeen, Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (RESTBase Split (CDP2)), VisualEditor, RESTBase
Pchelolo closed T220661: EventGate service runner worker occasionally killed, usually during higher load as Resolved.

I believe that this can be closed after we are easily sustaining almost 7k events per second in prod.

Apr 29 2019, 8:00 PM · Services (done), Analytics-Kanban, EventBus, Analytics
Pchelolo closed T220661: EventGate service runner worker occasionally killed, usually during higher load, a subtask of T206785: Modern Event Platform: Stream Intake Service (EventGate): Implementation, as Resolved.
Apr 29 2019, 8:00 PM · Analytics-Kanban, Patch-For-Review, Core Platform Team Backlog (Watching / External), Services (watching), Analytics-EventLogging, EventBus, Analytics