Page MenuHomePhabricator

Petar.petkovic (Petar Petković)
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 20 2017, 9:26 AM (129 w, 3 d)
Availability
Available
LDAP User
Petar.petkovic
MediaWiki User
PPetkovic (WMF) [ Global Accounts ]

Recent Activity

Mon, Dec 9

Petar.petkovic created T240190: Error when transferring image.
Mon, Dec 9, 9:17 AM · ContentTranslation

Wed, Dec 4

Petar.petkovic added a comment to T234323: Load a single section in Content translation's editor.

Please let me know whether the following is correct:

  • It is possible to make the page title to be non-editable and adjust the styling to be presented differently (e.g., in a smaller size as the proposed design)
  • It is hard for the section title to be presented above the language indicators (i.e., "English - view page. Tagalog" line)

So the new design you are asking for can adjust the style but not change the placement of elements. Is that correct? Is that a hard limitation or something that can be refined as part of follow-up tickets?

Making target title read-only is possible. We already do that for source title. Text can be styled to be smaller as well.

Wed, Dec 4, 6:01 PM · Patch-For-Review, Language-Team (Language-2019-October-December), CX-boost
Petar.petkovic added a comment to T234323: Load a single section in Content translation's editor.

Let me write a roundup of current state of changes made for section translation support and ask questions coming out of it. Work is not merged, so this is preliminary.

Wed, Dec 4, 10:14 AM · Patch-For-Review, Language-Team (Language-2019-October-December), CX-boost

Tue, Dec 3

Petar.petkovic added a comment to T204084: Horizontal shift when scrollbar appears as you transition between states in Minerva and Vector.

This change has added visible scrollbar to all pages on Vector, regardless of page needing scrollbar or not. What @matmarex wrote above.

Tue, Dec 3, 11:27 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), patch-welcome, Readers-Web-Backlog (Tracking), MinervaNeue, Vector
Petar.petkovic moved T236615: Reference by name shown as missing despite successful adaptation from In Review to Needs QA on the Language-Team (Language-2019-October-December) board.
Tue, Dec 3, 8:14 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Language-Team (Language-2019-October-December), ContentTranslation

Thu, Nov 21

Petar.petkovic added a comment to T238811: False warning about 'Article exists' in target wiki.

I tried loading this same translation in production, but you still hold onto it. Can you still see the problem if you load the draft?

Thu, Nov 21, 10:05 PM · Language-Team (Language-2019-October-December), ContentTranslation

Wed, Nov 20

Petar.petkovic moved T217585: CX2: ISBN doubled, one correctly formatted with {{ISBN}}, another incorrectly formatted with [[Special:BookSources]] from In Review to Needs QA on the Language-Team (Language-2019-October-December) board.
Wed, Nov 20, 3:32 PM · Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic updated the task description for T217585: CX2: ISBN doubled, one correctly formatted with {{ISBN}}, another incorrectly formatted with [[Special:BookSources]].
Wed, Nov 20, 3:25 PM · Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic added a comment to T236615: Reference by name shown as missing despite successful adaptation.

The warning which can be seen is not expanded, but it still says "Missing reference", whereas no reference is missing.

Wed, Nov 20, 1:31 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Language-Team (Language-2019-October-December), ContentTranslation

Nov 13 2019

Petar.petkovic added a comment to T234323: Load a single section in Content translation's editor.

server-side section editing will give you less performance gains than you might think (if you are using attachedRoot instead): T206228#5330185. Parsoid HTML download is usually not a bottleneck, and more time is spent building and rendering the CE tree than the DM.

Does attachedRoot allow to use multiple adjacent <section>s or we need to wrap those which define a range between two <h2> headers?

Nov 13 2019, 1:07 AM · Patch-For-Review, Language-Team (Language-2019-October-December), CX-boost

Nov 12 2019

Petar.petkovic moved T234323: Load a single section in Content translation's editor from In Progress to In Review on the Language-Team (Language-2019-October-December) board.
Nov 12 2019, 10:53 PM · Patch-For-Review, Language-Team (Language-2019-October-December), CX-boost
Petar.petkovic added a comment to T230195: MT stops translating "randomly".

Are there any articles where this behavior is reproducible? I tried (locally) en:Tensor_product, which is mentioned in the description, but it works fine (using Google and Yandex), without 548956.

Nov 12 2019, 1:17 PM · Language-Team (Language-2019-October-December), CX-cxserver

Nov 11 2019

Petar.petkovic created T238000: Context items in dialogs are no longer displayed in tools column.
Nov 11 2019, 4:25 PM · Regression, ContentTranslation
Petar.petkovic moved T236906: Sentences don't get highlighted in some articles from In Review to Needs QA on the Language-Team (Language-2019-October-December) board.
Nov 11 2019, 3:12 PM · Language-Team (Language-2019-October-December), Regression, ContentTranslation
Petar.petkovic added a comment to T206443: The lang and directionality attributes of the source selector is not updated when language changed.

lang and dir attributes of source page title are still not updated and wrong when switching source language.

Nov 11 2019, 1:06 PM · RTL, I18n, ContentTranslation
Petar.petkovic closed T154788: Accept and explain publish API errors as Resolved.

Content Translation treats some API publish errors specifically, like:

  • spamblacklist
  • abusefilter
  • invalidtitle
  • badtoken
  • assertuserfailed
  • titleblacklist-forbidden
  • readonly
Nov 11 2019, 9:34 AM · ContentTranslation
Petar.petkovic closed T70287: Should not load full GuidedTour module unconditionally for all logged in users as Resolved.

Guided Tour was removed from Content Translation in 502671 and 500811.

Nov 11 2019, 9:30 AM · WorkType-Maintenance, ContentTranslation

Nov 7 2019

Petar.petkovic updated the task description for T237607: Invite for translation when creating a new article not showing for new users.
Nov 7 2019, 9:07 AM · MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), ContentTranslation, Language-Team (Language-2019-October-December)

Nov 5 2019

Petar.petkovic removed a project from T235938: Add femiwiki skin and extensions to Translatewiki.net: Patch-For-Review.
Nov 5 2019, 10:27 AM · Language-Team (Language-2019-October-December), translatewiki.net
Petar.petkovic removed a project from T234614: Setup i18n and TWN for KaiOS Wikipedia app: Patch-For-Review.
Nov 5 2019, 10:26 AM · Language-Team (Language-2019-October-December), translatewiki.net, Inuka-Team (Kanban), KaiOS-Wikipedia-app
Petar.petkovic updated the task description for T237354: "bigram" instance for Language team.
Nov 5 2019, 9:38 AM · Language-Team (Language-2019-October-December), Cloud-Services, cloud-services-team
Petar.petkovic added a comment to T234323: Load a single section in Content translation's editor.

@Petar.petkovic Can you clarify why we need to fetch a single section from cxserver? Don't we need to fetch full article as I explained in above comment?

We don't necessary need to load full article. There is still no REST API which returns only one section using parsoid and maybe their team had a valid reason not to include such option.
There is a simpler version catered to mobile devices, which I wanted to try out. Loading whole article seems lazy to me. There are some challenges with cross-section content, like named references, but they can be expanded to full definition for that one section.

Nov 5 2019, 8:43 AM · Patch-For-Review, Language-Team (Language-2019-October-December), CX-boost

Nov 1 2019

Petar.petkovic claimed T234323: Load a single section in Content translation's editor.
Nov 1 2019, 8:01 AM · Patch-For-Review, Language-Team (Language-2019-October-December), CX-boost

Oct 27 2019

Petar.petkovic added a comment to T236136: Translator try to charge saved translation of an article and never stop .

Can you please try again with your browser console open (by pressing F 12 key on your keyboard) and put the output here?

Oct 27 2019, 10:06 PM · ContentTranslation
Petar.petkovic updated the task description for T236245: Abuse filter error appears when it shouldn't.
Oct 27 2019, 10:01 PM · AbuseFilter, ContentTranslation

Oct 25 2019

Petar.petkovic added a comment to T234632: Wikimedia Technical Conference 2019 Session: Local development environment - MediaWiki core.

@Petar.petkovic maybe your article with the installation instructions will be useful here?

I don't think this ticket is about creating tutorials. We already have that for Mediawiki core, which seems to be focus of this ticket.

Oct 25 2019, 4:51 PM · International-Developer-Events, Wikimedia-Technical-Conference-2019

Oct 23 2019

Petar.petkovic added a comment to T89707: Encourage users to publish old inactive unpublished translations.

@Petar.petkovic can you tell me how to test this on local?

You need to run a script located at core/extensions/ContentTranslation/scripts.
When you are in that directory, run php purge-unpublished-drafts.php. You also need to pass some command line option to your script:

  • age-in-days - This option was existing before changes made to the script for the purposes of this task. It determines how old are the drafts which are being removed from DB.
  • notify-age-in-days - This option was introduced for this task. It determines how old are drafts that you notify users to "continue their translations before they get deleted"
  • really - Unless this option is included, you get log of drafts which users are notified about or which get purged and actions are not performed really. Without this option is what we call "dry run".

You can use something like php purge-unpublished-drafts.php --notify-age-in-days=1 --really to notify users to continue their drafts which are one day old. I'm using one day since you probably don't have older drafts available locally. You can also use other parameters and tweak you calendar date on your OS to test this.

Oct 23 2019, 10:58 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), Schema-change, CX-boost, Growth-Team, WorkType-NewFunctionality, Collaboration-Team-Triage, Notifications
Petar.petkovic added a comment to T232372: Update invite for translation when creating a new article.

Check self::isPotentialTranslator( $user ) looks if user ever started any translation using CX

This means the invite should only show to users that have NOT started any translation using CX, right?
Right now the invite is showing for users (example user: Testpitanormal) with translations done using CX, maybe the logic is inverted?

The name of the method is isPotentialTranslator. As name explains, method checks if user is a potential translator, to which we should show invites. @Pginer-WMF we're talking specific invite here. Anyway, the method can confirm that user is potential translator in two ways:

  1. User has made some translations with CX before
  2. User has edited more than one Wikipedia

Your Testpitanormal meets the first criteria, that is why you see the invite.

Oct 23 2019, 9:22 AM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)

Oct 22 2019

Petar.petkovic added a comment to T188634: Allow to keep for later any article selected in the new translation dialog.

Issues found:

  • removing article from "new translation" doesn't update list - needs reloading of the page video, the same for adding to the list, requires reloading

When you have Suggestions view open, adding/removing items using bookmark icon will require refresh. Popup notice with message saying that article is added for later is what we settled for. If you perform same actions when your In progress or Published lists are opened, and then navigate to Suggestions without reload, those new additions will show.

  • T194476 happens on this feature as well - if we change the target language on the "new translation" the bookmarked article doesn't show on the bookmarks: example video

The reason is that article you selected exists in Catalan and when you reload, Catalan is selected as target language. Thus, article is considered as existing and removed from the list of favorites. Patch 537781 is meant to deal with this problem.

Oct 22 2019, 4:12 PM · Patch-For-Review, Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), CX-boost, Design, CX-TranslationList
Petar.petkovic added a comment to T232372: Update invite for translation when creating a new article.

It was reported by @Jpita that new users on Javanese Wikipedia (on which CX is out of beta) are not seeing invite. I instructed him to edit articles on some non-Javanese Wikipedia and try again. The invite was not showing after that, so we did some investigation. Without a clear cause, I went on to investigate on my own.

Oct 22 2019, 4:01 PM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)
Petar.petkovic added a comment to T232020: Articles published with Content Translation are no longer linked to Wikidata.

I have double checked and Wikidata linking is working automatically after publishing again.

Oct 22 2019, 9:59 AM · Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Regression, ContentTranslation

Oct 21 2019

Petar.petkovic moved T188634: Allow to keep for later any article selected in the new translation dialog from Pending input for QA to In Review on the Language-Team (Language-2019-October-December) board.
Oct 21 2019, 7:46 AM · Patch-For-Review, Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), CX-boost, Design, CX-TranslationList

Oct 18 2019

Petar.petkovic added a comment to T234417: Option to start from scratch results in a scroll jump and "Machine translation failed" error.

Also tried steps with different articles and language pairs on both production and localhost. @Jpita, @Pginer-WMF can you recheck if jump still happens? I also saw some jumps happening in the past, but I don't know when the last time was.

The jump does no longer happen for me. I selected different options on the MT card with the viewport at different positions and was not able to reproduce the jump. Before it was very hard not to find it, so I guess it no longer happens. But @Jpita, feel free to do further checks.

I also did checks using various viewport positions and MT options.

Oct 18 2019, 11:36 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Regression, Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic created T235850: UI elements misaligned and misplaced.
Oct 18 2019, 11:32 AM · Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic added a comment to T188634: Allow to keep for later any article selected in the new translation dialog.

@Petar.petkovic were you able to see this working on local?
on cx2-testing and prod I see the bookmark button but nothing is added to the for later list

Yes, I tested quite extensively on localhost during development.
Now I checked in production as well, using Serbian Wikipedia. First, while I was on dashboard suggestion view, I opened New translation dialog, found some random article which is missing in Serbian and bookmarked it. Popup message appeared. Page needed to be reloaded to see the changes.

Oct 18 2019, 11:01 AM · Patch-For-Review, Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), CX-boost, Design, CX-TranslationList
Petar.petkovic moved T217585: CX2: ISBN doubled, one correctly formatted with {{ISBN}}, another incorrectly formatted with [[Special:BookSources]] from In Progress to In Review on the Language-Team (Language-2019-October-December) board.
Oct 18 2019, 9:50 AM · Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic claimed T209274: CX2: Adding a link to a non-existent article, shows the link as blue instead of red in the translation interface.
Oct 18 2019, 8:29 AM · Language-Team (Language-2019-October-December), ContentTranslation

Oct 15 2019

Petar.petkovic updated the task description for T235579: cxserver error prevents adding a paragraph: Rejecting items in subqueue from BatchedAPIRequest.
Oct 15 2019, 11:28 PM · CX-cxserver
Petar.petkovic created T235580: Infobox missing at the start of the article.
Oct 15 2019, 11:27 PM · Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic updated the task description for T235579: cxserver error prevents adding a paragraph: Rejecting items in subqueue from BatchedAPIRequest.
Oct 15 2019, 11:26 PM · CX-cxserver
Petar.petkovic created T235579: cxserver error prevents adding a paragraph: Rejecting items in subqueue from BatchedAPIRequest.
Oct 15 2019, 11:25 PM · CX-cxserver
Petar.petkovic moved T234417: Option to start from scratch results in a scroll jump and "Machine translation failed" error from In Review to In Progress on the Language-Team (Language-2019-October-December) board.
Oct 15 2019, 10:27 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Regression, Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic removed a project from T224721: Integrate template parameter alignments in Content Translation to improve automatic template support: Patch-For-Review.
Oct 15 2019, 10:27 PM · Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic updated subscribers of T234417: Option to start from scratch results in a scroll jump and "Machine translation failed" error.

I tried the same steps from the description and only got Javascript errors being logged in console.
Message "Machine translation failed" was not shown and jump did not happen.

Oct 15 2019, 10:24 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Regression, Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic merged T235386: Adding red links is not possible into T209274: CX2: Adding a link to a non-existent article, shows the link as blue instead of red in the translation interface.
Oct 15 2019, 12:10 AM · Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic merged task T235386: Adding red links is not possible into T209274: CX2: Adding a link to a non-existent article, shows the link as blue instead of red in the translation interface.
Oct 15 2019, 12:10 AM · ContentTranslation
Petar.petkovic merged T235387: ContentTranslation don't link page with Wikidata after save into T232020: Articles published with Content Translation are no longer linked to Wikidata.
Oct 15 2019, 12:08 AM · Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Regression, ContentTranslation
Petar.petkovic merged task T235387: ContentTranslation don't link page with Wikidata after save into T232020: Articles published with Content Translation are no longer linked to Wikidata.
Oct 15 2019, 12:08 AM · ContentTranslation
Petar.petkovic moved T234417: Option to start from scratch results in a scroll jump and "Machine translation failed" error from Priority backlog to In Review on the Language-Team (Language-2019-October-December) board.
Oct 15 2019, 12:06 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Regression, Language-Team (Language-2019-October-December), ContentTranslation

Oct 14 2019

Petar.petkovic added a comment to T232372: Update invite for translation when creating a new article.

I have looked this up, and there is a protein in human body called GATA4, which is also known as ASD2. We got this suggestion from GATA4 having ASD2 alias on Wikidata.
English Wikipedia page also lists ASD2 as an alias to GATA4. This is valid suggestion.

Oct 14 2019, 10:16 PM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)
Petar.petkovic moved T89707: Encourage users to publish old inactive unpublished translations from In Review to Needs QA on the Language-Team (Language-2019-October-December) board.
Oct 14 2019, 10:06 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), Schema-change, CX-boost, Growth-Team, WorkType-NewFunctionality, Collaboration-Team-Triage, Notifications
Petar.petkovic updated the task description for T234417: Option to start from scratch results in a scroll jump and "Machine translation failed" error.
Oct 14 2019, 8:07 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Regression, Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic claimed T234417: Option to start from scratch results in a scroll jump and "Machine translation failed" error.
Oct 14 2019, 8:05 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Regression, Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic removed a project from T204937: CX2: Don't add block templates to the translation if equivalent template is missing: Patch-For-Review.
Oct 14 2019, 7:58 AM · Language-Team (Language-2019-October-December), VisualEditor, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), ContentTranslation

Oct 11 2019

Petar.petkovic moved T235058: Adjust default paragraph limit for MT from 80% to 85% from In Review to Needs QA on the Language-Team (Language-2019-October-December) board.
Oct 11 2019, 8:07 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic moved T232020: Articles published with Content Translation are no longer linked to Wikidata from Priority backlog to Needs QA on the Language-Team (Language-2019-October-December) board.
Oct 11 2019, 12:04 AM · Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Regression, ContentTranslation
Petar.petkovic moved T235058: Adjust default paragraph limit for MT from 80% to 85% from Priority backlog to In Review on the Language-Team (Language-2019-October-December) board.
Oct 11 2019, 12:02 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), ContentTranslation

Oct 10 2019

Petar.petkovic moved T217585: CX2: ISBN doubled, one correctly formatted with {{ISBN}}, another incorrectly formatted with [[Special:BookSources]] from In Review to Needs QA on the Language-Team (Language-2019-October-December) board.

@Jpita, the fix is not yet deployed to cxserver.

Oct 10 2019, 11:58 PM · Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic added a comment to T229242: Explore ways to restrict suggestions to a given knowledge area.

With discarding feature, we have following workflow: 1) Load CX, 2) Open suggestions, 3) Discard unwated, 4) Open CX next time, 5) If nothing changed for seed articles, we get same suggestions, minus discarded one.
Without discard feature, when we get same set of articles, we need to reload all to get rid of some that we don't want to see. Maybe the behavior where we see a lot of the same suggestions is the problem here, but it annoyed me as a user.
What I propose is try to have discard for free or with minimal effort inside new suggestion system. If it requires more effort to modify than to remove (removing also takes some effort, usually minimal), abandon the feature.

Oct 10 2019, 11:53 PM · Language-Team (Language-2019-October-December), CX-boost, WorkType-NewFunctionality
Petar.petkovic claimed T235058: Adjust default paragraph limit for MT from 80% to 85%.
Oct 10 2019, 11:01 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic moved T216500: Surface the article the user is trying to create when suggesting to translate from In Review to Needs QA on the Language-Team (Language-2019-October-December) board.
Oct 10 2019, 9:34 PM · Language-Team (Language-2019-October-December), MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), CX-boost
Petar.petkovic moved T232372: Update invite for translation when creating a new article from In Review to Needs QA on the Language-Team (Language-2019-October-December) board.
Oct 10 2019, 8:41 PM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)

Oct 9 2019

Petar.petkovic added a comment to T232372: Update invite for translation when creating a new article.

I have made required changes. Here are the results:

Suggestion with imageSuggestion with no image

I would like to point out that for title "Incumbent", proposed article is a disambiguation page - Titulaire. Description says "We may want to filter out disambiguation pages, not showing them as a suggestion". @Pginer-WMF, you may want to create separate ticket to capture this. API introduced in T227571 offers disambiguation page as suggestion, this ticket is just about presentation.

Oct 9 2019, 9:38 PM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)
Petar.petkovic added a comment to T234323: Load a single section in Content translation's editor.

@Pginer-WMF have you considered allowing users to choose where their published section translations should end up? In your mock ups, there was a way to choose which section to translate from source. Similar to that, we may enable users to choose between which sections in target article to insert newly translated one.

Oct 9 2019, 8:47 PM · Patch-For-Review, Language-Team (Language-2019-October-December), CX-boost
Petar.petkovic updated the task description for T234323: Load a single section in Content translation's editor.
Oct 9 2019, 8:43 PM · Patch-For-Review, Language-Team (Language-2019-October-December), CX-boost
Petar.petkovic updated the task description for T235058: Adjust default paragraph limit for MT from 80% to 85%.
Oct 9 2019, 8:42 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic added a comment to T229242: Explore ways to restrict suggestions to a given knowledge area.

I used to make some efforts personally to determine articles with most languages that are missing in Serbian, regardless of topic. Tried Wikidata first, but without any additional filtering, query would timeout every time. Then, I started querying with instanceof and similar properties, which yielded some results. Some topics with large amount of items would still timeout, like movies, actors, etc. Many others complete successfully, like entrepreneur or bank.
I tried modifying your query slightly, most notably adding ORDER BY DESC(?linkcount) and running it for all categories you defined in topics.json. Some topics returned low quality (and quantity) suggestions, like Q1071 (Geography). Others worked nicely.
I see this approach could be useful. It depends strongly on Wikidata inter-item connections. We will need to make additional efforts to make some topics usable, maybe combining multiple categories.
Also, there is a question of how generic or specific we want our topics to be and how many of them. Do we want them configurable? Those are questions for @Pginer-WMF.

Oct 9 2019, 12:16 AM · Language-Team (Language-2019-October-December), CX-boost, WorkType-NewFunctionality

Oct 8 2019

Petar.petkovic closed T188769: Discarding and selecting new page for translation gives wrong image as Resolved.
Oct 8 2019, 3:54 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), ContentTranslation
Petar.petkovic moved T188634: Allow to keep for later any article selected in the new translation dialog from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.
Oct 8 2019, 3:52 PM · Patch-For-Review, Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), CX-boost, Design, CX-TranslationList

Oct 7 2019

Petar.petkovic added a comment to T232372: Update invite for translation when creating a new article.

After updating the patch to match @Pginer-WMF's design, I did additional checks to verify all the specs are in place.
@Pginer-WMF, once you verify above screenshots look good and following two items are acceptable, I'm merging the patch:

  • The invite does not go away after user starts typing inside the editor
  • Blue dot and invite could be shown simultaneously:

Oct 7 2019, 11:31 PM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)
Petar.petkovic added a comment to T232020: Articles published with Content Translation are no longer linked to Wikidata.

I just translated this article and is still not linking to wikidata
https://pt.wikipedia.org/wiki/Marianne_(serie_de_televis%C3%A3o)
https://www.wikidata.org/wiki/Q67521330

got this message a few hours after creating the article

, this was done manually by that user, right?

Yes, another user linked your new article to Wikidata item.
Patch 539222 to fix this problem for the second time was deployed with 1.34.0-wmf.25 and Wikidata linking is still not working.

Oct 7 2019, 7:42 PM · Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Regression, ContentTranslation

Oct 4 2019

Petar.petkovic added a comment to T232372: Update invite for translation when creating a new article.

I have made some visual adjustments to the patch from @santhosh. Here are some shots:

Generic inviteSuggestion with no imageSpecific suggestion with image
Oct 4 2019, 12:51 AM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)

Oct 2 2019

Petar.petkovic moved T232372: Update invite for translation when creating a new article from In Progress to In Review on the Language-Team (Language-2019-July-September) board.
Oct 2 2019, 11:48 PM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)

Sep 30 2019

Petar.petkovic closed T232934: "Content translation failed to load due to internal error" is hardcoded and not translatable as Resolved.
Sep 30 2019, 10:54 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), I18n, ContentTranslation
Petar.petkovic removed a project from T101815: Bar overlaps in Special:CXStats: Patch-For-Review.
Sep 30 2019, 10:46 PM · WMF-deploy-2015-06-09_(1.26wmf9), ContentTranslation-Release5, LE-Sprint-87, ContentTranslation
Petar.petkovic added a comment to T205429: CX2: Uncaught TypeError: Cannot read property 'element' of null at VeCeCXTransclusionInlineNode.ve.ce.View.initialize (ve.ce.View.js?9c8a2:109).

Petar, can you create the ticket? When checking the comments above the context seems to be a bit split through several comments and other tickets. So maybe you can collect the different pieces and put them together more easily.
Thanks!

I was not able to reproduce same errors, but actually got different one reported in T234220. Whether that cxserver error covers TypeError: Cannot read property 'shallowCloneFromRange' of null, when translating first paragraph of en:Vantaa to Spanish, is unclear.

Sep 30 2019, 2:27 PM · Language-Team (Language-2019-July-September), ContentTranslation
Petar.petkovic moved T234220: cxserver error prevents translation of a section: Cannot read property 'replace' of undefined from Backlog to Other on the CX-cxserver board.
Sep 30 2019, 2:17 PM · CX-cxserver
Petar.petkovic edited projects for T234220: cxserver error prevents translation of a section: Cannot read property 'replace' of undefined, added: CX-cxserver; removed ContentTranslation.
Sep 30 2019, 2:17 PM · CX-cxserver
Petar.petkovic created T234220: cxserver error prevents translation of a section: Cannot read property 'replace' of undefined.
Sep 30 2019, 2:15 PM · CX-cxserver
Petar.petkovic added a comment to T206237: Progress bar calculation counts sections that excluded from MT abuse.

@Petar.petkovic, @santhosh, you worked in this area, is this ticket still relevant given the adjustments made to exclude content that we don't expect users to change?

Progress bar is displayed on dashboard. We take number of translated sections and divide that with total number of source sections, which includes those excluded from MT validation. Of that total progress, we mark percentage coming from MT. This calculation excludes sections blacklisted for MT validation.

Sep 30 2019, 9:33 AM · ContentTranslation
Petar.petkovic moved T232020: Articles published with Content Translation are no longer linked to Wikidata from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.
Sep 30 2019, 9:04 AM · Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Regression, ContentTranslation
Petar.petkovic removed a project from T231707: Add new validator to validate existence of newlines in source and translation: Patch-For-Review.
Sep 30 2019, 9:04 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Language-Team (Language-2019-July-September), MediaWiki-extensions-Translate
Petar.petkovic removed a project from T231658: Switch to using the new validator framework for Dissemin project: Patch-For-Review.
Sep 30 2019, 9:03 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Language-Team (Language-2019-July-September), translatewiki.net
Petar.petkovic removed a project from T231657: Switch to using the new validator framework for iNaturalist project: Patch-For-Review.
Sep 30 2019, 9:03 AM · Language-Team (Language-2019-July-September), translatewiki.net
Petar.petkovic removed a project from T200328: CX2: Uncaught ReferenceError: specialPageWhitelist is not defined: Language-Team (Language-2019-July-September).
Sep 30 2019, 9:02 AM · ContentTranslation

Sep 27 2019

Petar.petkovic added a comment to T205429: CX2: Uncaught TypeError: Cannot read property 'element' of null at VeCeCXTransclusionInlineNode.ve.ce.View.initialize (ve.ce.View.js?9c8a2:109).

Final verdict: Problem with errors when clicking on reference is gone, but there are other errors when adding paragraphs. Should be fixed as part of a separate ticket.

@Petar.petkovic @Pginer-WMF is there a ticket for this?

Not that I know of.

Sep 27 2019, 7:02 AM · Language-Team (Language-2019-July-September), ContentTranslation

Sep 26 2019

Petar.petkovic updated subscribers of T89707: Encourage users to publish old inactive unpublished translations.

We need to notify users about old drafts in 15 day windows. In order to avoid notifying same user twice or missing some draft, we decided to save timestamp of last notified draft in that run. That avoids saving and updating info per draft as well.
For purpose of saving this timestamp of last notified draft, new database table is introduced. Since this involves schema changes, by following guidelines, I've added Schema-change tag. Separate task will be created after patch is merged.
Patch which introduces this table can be merged before table is created, as new table usage is behind configuration.

Sep 26 2019, 2:13 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), Schema-change, CX-boost, Growth-Team, WorkType-NewFunctionality, Collaboration-Team-Triage, Notifications
Petar.petkovic added a project to T89707: Encourage users to publish old inactive unpublished translations: Schema-change.
Sep 26 2019, 1:58 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), Schema-change, CX-boost, Growth-Team, WorkType-NewFunctionality, Collaboration-Team-Triage, Notifications

Sep 25 2019

Petar.petkovic added a comment to T232020: Articles published with Content Translation are no longer linked to Wikidata.

The fix has landed with 1.34.0-wmf.24 (deployed on 18 Sep for group 1 wikis like Catalan Wikipedia), but linking to Wikidata is still not working.
Check out some of translations made on 25th of September. Timestamps of when article is created with Content Translation and when that article is linked to Wikidata are not matching. In the two examples, different user has added Wikidata link.

By looking at one of the last articles published before 1.34.0-wmf.20 was deployed, we see that time and author of article creation and Wikidata linking are the same.

Sep 25 2019, 9:16 AM · Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Regression, ContentTranslation

Sep 19 2019

Petar.petkovic renamed T232986: Enable all possible language pairs in cxserver, apply wiki specific configuration in the wiki from Enable all possible language pairs in cxserver, apply wiki specific confguration in the wiki to Enable all possible language pairs in cxserver, apply wiki specific configuration in the wiki.
Sep 19 2019, 8:15 AM · Language-Team (Language-2019-October-December), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), ContentTranslation
Petar.petkovic closed T223472: Draft namespace not showing as publish option for some wikis as Resolved.
Sep 19 2019, 1:33 AM · Chinese-Sites, ContentTranslation
Petar.petkovic removed a project from T232331: Reference adapted as empty with no apparent reason: Language-Team (Language-2019-July-September).
Sep 19 2019, 1:15 AM · ContentTranslation

Sep 17 2019

Petar.petkovic moved T232020: Articles published with Content Translation are no longer linked to Wikidata from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.
Sep 17 2019, 11:58 AM · Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Regression, ContentTranslation
Petar.petkovic moved T224880: Gray interlanguage link dialog is misplaced from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.
Sep 17 2019, 7:59 AM · CX-boost, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Language-Team (Language-2019-July-September)

Sep 15 2019

Petar.petkovic moved T205429: CX2: Uncaught TypeError: Cannot read property 'element' of null at VeCeCXTransclusionInlineNode.ve.ce.View.initialize (ve.ce.View.js?9c8a2:109) from Priority backlog to Needs QA on the Language-Team (Language-2019-July-September) board.

I've tried reproducing this. Started translation of en:Vantaa to Spanish and added paragraphs starting with "Vantaa is bordered by Helsinki" and "The largest airport in Finland". Waited for save and reloaded the page. Clicked on only reference to see no error. Reference card was empty.

Sep 15 2019, 10:10 AM · Language-Team (Language-2019-July-September), ContentTranslation

Sep 13 2019

matmarex awarded T232600: Some Phabricator boards do not load cards anymore in Chrome 77 a The World Burns token.
Sep 13 2019, 10:57 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
RHo awarded T232600: Some Phabricator boards do not load cards anymore in Chrome 77 a Yellow Medal token.
Sep 13 2019, 8:30 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
mmodell awarded T232600: Some Phabricator boards do not load cards anymore in Chrome 77 a Mountain of Wealth token.
Sep 13 2019, 8:02 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
Petar.petkovic added a comment to T232583: Adjust Content Translation to changes in AbuseFilter and SpamBlacklist systems.

@Petar.petkovic any hints on how to test this?

There were changes in how Abuse Filter sends data when publishing is prevented due to some filter being hit. Due to good communication, the changes were brought to our attention in time, before changes in Abuse Filter ended up in production. The changes are rolling out in 1.34.0-wmf.23.
We reacted and adapted our code to changes. That means, there is no environment (besides local) where you can see what would happen if we didn't adapt to changes.

Sep 13 2019, 9:26 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Language-Team (Language-2019-July-September), ContentTranslation

Sep 12 2019

Petar.petkovic moved T224880: Gray interlanguage link dialog is misplaced from In Progress to In Review on the Language-Team (Language-2019-July-September) board.
Sep 12 2019, 2:21 PM · CX-boost, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Language-Team (Language-2019-July-September)