Page MenuHomePhabricator

Petar.petkovic (Petar Petković)
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jun 20 2017, 9:26 AM (122 w, 1 d)
Availability
Available
LDAP User
Petar.petkovic
MediaWiki User
PPetkovic (WMF) [ Global Accounts ]

Recent Activity

Today

Petar.petkovic added a comment to T89707: Encourage users to publish old inactive unpublished translations.

@Petar.petkovic can you tell me how to test this on local?

You need to run a script located at core/extensions/ContentTranslation/scripts.
When you are in that directory, run php purge-unpublished-drafts.php. You also need to pass some command line option to your script:

  • age-in-days - This option was existing before changes made to the script for the purposes of this task. It determines how old are the drafts which are being removed from DB.
  • notify-age-in-days - This option was introduced for this task. It determines how old are drafts that you notify users to "continue their translations before they get deleted"
  • really - Unless this option is included, you get log of drafts which users are notified about or which get purged and actions are not performed really. Without this option is what we call "dry run".

You can use something like php purge-unpublished-drafts.php --notify-age-in-days=1 --really to notify users to continue their drafts which are one day old. I'm using one day since you probably don't have older drafts available locally. You can also use other parameters and tweak you calendar date on your OS to test this.

Wed, Oct 23, 10:58 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), Schema-change, CX-boost, Growth-Team, WorkType-NewFunctionality, Collaboration-Team-Triage, Notifications
Petar.petkovic added a comment to T232372: Update invite for translation when creating a new article.

Check self::isPotentialTranslator( $user ) looks if user ever started any translation using CX

This means the invite should only show to users that have NOT started any translation using CX, right?
Right now the invite is showing for users (example user: Testpitanormal) with translations done using CX, maybe the logic is inverted?

The name of the method is isPotentialTranslator. As name explains, method checks if user is a potential translator, to which we should show invites. @Pginer-WMF we're talking specific invite here. Anyway, the method can confirm that user is potential translator in two ways:

  1. User has made some translations with CX before
  2. User has edited more than one Wikipedia

Your Testpitanormal meets the first criteria, that is why you see the invite.

Wed, Oct 23, 9:22 AM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)

Yesterday

Petar.petkovic added a comment to T188634: Allow to keep for later any article selected in the new translation dialog.

Issues found:

  • removing article from "new translation" doesn't update list - needs reloading of the page video, the same for adding to the list, requires reloading

When you have Suggestions view open, adding/removing items using bookmark icon will require refresh. Popup notice with message saying that article is added for later is what we settled for. If you perform same actions when your In progress or Published lists are opened, and then navigate to Suggestions without reload, those new additions will show.

  • T194476 happens on this feature as well - if we change the target language on the "new translation" the bookmarked article doesn't show on the bookmarks: example video

The reason is that article you selected exists in Catalan and when you reload, Catalan is selected as target language. Thus, article is considered as existing and removed from the list of favorites. Patch 537781 is meant to deal with this problem.

Tue, Oct 22, 4:12 PM · Patch-For-Review, Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), CX-boost, Design, CX-TranslationList
Petar.petkovic added a comment to T232372: Update invite for translation when creating a new article.

It was reported by @Jpita that new users on Javanese Wikipedia (on which CX is out of beta) are not seeing invite. I instructed him to edit articles on some non-Javanese Wikipedia and try again. The invite was not showing after that, so we did some investigation. Without a clear cause, I went on to investigate on my own.

Tue, Oct 22, 4:01 PM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)
Petar.petkovic added a comment to T232020: Articles published with Content Translation are no longer linked to Wikidata.

I have double checked and Wikidata linking is working automatically after publishing again.

Tue, Oct 22, 9:59 AM · Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Regression, ContentTranslation

Mon, Oct 21

Petar.petkovic moved T188634: Allow to keep for later any article selected in the new translation dialog from Pending input for QA to In Review on the Language-Team (Language-2019-October-December) board.
Mon, Oct 21, 7:46 AM · Patch-For-Review, Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), CX-boost, Design, CX-TranslationList

Fri, Oct 18

Petar.petkovic added a comment to T234417: Option to start from scratch results in a scroll jump and "Machine translation failed" error.

Also tried steps with different articles and language pairs on both production and localhost. @Jpita, @Pginer-WMF can you recheck if jump still happens? I also saw some jumps happening in the past, but I don't know when the last time was.

The jump does no longer happen for me. I selected different options on the MT card with the viewport at different positions and was not able to reproduce the jump. Before it was very hard not to find it, so I guess it no longer happens. But @Jpita, feel free to do further checks.

I also did checks using various viewport positions and MT options.

Fri, Oct 18, 11:36 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Regression, Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic created T235850: UI elements misaligned and misplaced.
Fri, Oct 18, 11:32 AM · ContentTranslation
Petar.petkovic added a comment to T188634: Allow to keep for later any article selected in the new translation dialog.

@Petar.petkovic were you able to see this working on local?
on cx2-testing and prod I see the bookmark button but nothing is added to the for later list

Yes, I tested quite extensively on localhost during development.
Now I checked in production as well, using Serbian Wikipedia. First, while I was on dashboard suggestion view, I opened New translation dialog, found some random article which is missing in Serbian and bookmarked it. Popup message appeared. Page needed to be reloaded to see the changes.

Fri, Oct 18, 11:01 AM · Patch-For-Review, Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), CX-boost, Design, CX-TranslationList
Petar.petkovic moved T217585: CX2: ISBN doubled, one correctly formatted with {{ISBN}}, another incorrectly formatted with [[Special:BookSources]] from In Progress to In Review on the Language-Team (Language-2019-October-December) board.
Fri, Oct 18, 9:50 AM · Patch-For-Review, Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic claimed T209274: CX2: Adding a link to a non-existent article, shows the link as blue instead of red in the translation interface.
Fri, Oct 18, 8:29 AM · Language-Team (Language-2019-October-December), ContentTranslation

Tue, Oct 15

Petar.petkovic updated the task description for T235579: cxserver error prevents adding a paragraph: Rejecting items in subqueue from BatchedAPIRequest.
Tue, Oct 15, 11:28 PM · CX-cxserver
Petar.petkovic created T235580: Infobox missing at the start of the article.
Tue, Oct 15, 11:27 PM · ContentTranslation
Petar.petkovic updated the task description for T235579: cxserver error prevents adding a paragraph: Rejecting items in subqueue from BatchedAPIRequest.
Tue, Oct 15, 11:26 PM · CX-cxserver
Petar.petkovic created T235579: cxserver error prevents adding a paragraph: Rejecting items in subqueue from BatchedAPIRequest.
Tue, Oct 15, 11:25 PM · CX-cxserver
Petar.petkovic moved T234417: Option to start from scratch results in a scroll jump and "Machine translation failed" error from In Review to In Progress on the Language-Team (Language-2019-October-December) board.
Tue, Oct 15, 10:27 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Regression, Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic removed a project from T224721: Integrate template parameter alignments in Content Translation to improve automatic template support: Patch-For-Review.
Tue, Oct 15, 10:27 PM · Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic updated subscribers of T234417: Option to start from scratch results in a scroll jump and "Machine translation failed" error.

I tried the same steps from the description and only got Javascript errors being logged in console.
Message "Machine translation failed" was not shown and jump did not happen.

Tue, Oct 15, 10:24 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Regression, Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic merged T235386: Adding red links is not possible into T209274: CX2: Adding a link to a non-existent article, shows the link as blue instead of red in the translation interface.
Tue, Oct 15, 12:10 AM · Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic merged task T235386: Adding red links is not possible into T209274: CX2: Adding a link to a non-existent article, shows the link as blue instead of red in the translation interface.
Tue, Oct 15, 12:10 AM · ContentTranslation
Petar.petkovic merged T235387: ContentTranslation don't link page with Wikidata after save into T232020: Articles published with Content Translation are no longer linked to Wikidata.
Tue, Oct 15, 12:08 AM · Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Regression, ContentTranslation
Petar.petkovic merged task T235387: ContentTranslation don't link page with Wikidata after save into T232020: Articles published with Content Translation are no longer linked to Wikidata.
Tue, Oct 15, 12:08 AM · ContentTranslation
Petar.petkovic moved T234417: Option to start from scratch results in a scroll jump and "Machine translation failed" error from Priority backlog to In Review on the Language-Team (Language-2019-October-December) board.
Tue, Oct 15, 12:06 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Regression, Language-Team (Language-2019-October-December), ContentTranslation

Mon, Oct 14

Petar.petkovic added a comment to T232372: Update invite for translation when creating a new article.

I have looked this up, and there is a protein in human body called GATA4, which is also known as ASD2. We got this suggestion from GATA4 having ASD2 alias on Wikidata.
English Wikipedia page also lists ASD2 as an alias to GATA4. This is valid suggestion.

Mon, Oct 14, 10:16 PM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)
Petar.petkovic moved T89707: Encourage users to publish old inactive unpublished translations from In Review to Needs QA on the Language-Team (Language-2019-October-December) board.
Mon, Oct 14, 10:06 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), Schema-change, CX-boost, Growth-Team, WorkType-NewFunctionality, Collaboration-Team-Triage, Notifications
Petar.petkovic updated the task description for T234417: Option to start from scratch results in a scroll jump and "Machine translation failed" error.
Mon, Oct 14, 8:07 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Regression, Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic claimed T234417: Option to start from scratch results in a scroll jump and "Machine translation failed" error.
Mon, Oct 14, 8:05 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Regression, Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic removed a project from T204937: CX2: Don't add block templates to the translation if equivalent template is missing: Patch-For-Review.
Mon, Oct 14, 7:58 AM · Language-Team (Language-2019-October-December), VisualEditor, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), ContentTranslation

Fri, Oct 11

Petar.petkovic moved T235058: Adjust default paragraph limit for MT from 80% to 85% from In Review to Needs QA on the Language-Team (Language-2019-October-December) board.
Fri, Oct 11, 8:07 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic moved T232020: Articles published with Content Translation are no longer linked to Wikidata from Priority backlog to Needs QA on the Language-Team (Language-2019-October-December) board.
Fri, Oct 11, 12:04 AM · Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Regression, ContentTranslation
Petar.petkovic moved T235058: Adjust default paragraph limit for MT from 80% to 85% from Priority backlog to In Review on the Language-Team (Language-2019-October-December) board.
Fri, Oct 11, 12:02 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), ContentTranslation

Thu, Oct 10

Petar.petkovic moved T217585: CX2: ISBN doubled, one correctly formatted with {{ISBN}}, another incorrectly formatted with [[Special:BookSources]] from In Review to Needs QA on the Language-Team (Language-2019-October-December) board.

@Jpita, the fix is not yet deployed to cxserver.

Thu, Oct 10, 11:58 PM · Patch-For-Review, Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic added a comment to T229242: Explore ways to restrict suggestions to a given knowledge area.

With discarding feature, we have following workflow: 1) Load CX, 2) Open suggestions, 3) Discard unwated, 4) Open CX next time, 5) If nothing changed for seed articles, we get same suggestions, minus discarded one.
Without discard feature, when we get same set of articles, we need to reload all to get rid of some that we don't want to see. Maybe the behavior where we see a lot of the same suggestions is the problem here, but it annoyed me as a user.
What I propose is try to have discard for free or with minimal effort inside new suggestion system. If it requires more effort to modify than to remove (removing also takes some effort, usually minimal), abandon the feature.

Thu, Oct 10, 11:53 PM · Language-Team (Language-2019-October-December), CX-boost, WorkType-NewFunctionality
Petar.petkovic claimed T235058: Adjust default paragraph limit for MT from 80% to 85%.
Thu, Oct 10, 11:01 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic moved T216500: Surface the article the user is trying to create when suggesting to translate from In Review to Needs QA on the Language-Team (Language-2019-October-December) board.
Thu, Oct 10, 9:34 PM · Language-Team (Language-2019-October-December), MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), CX-boost
Petar.petkovic moved T232372: Update invite for translation when creating a new article from In Review to Needs QA on the Language-Team (Language-2019-October-December) board.
Thu, Oct 10, 8:41 PM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)

Wed, Oct 9

Petar.petkovic added a comment to T232372: Update invite for translation when creating a new article.

I have made required changes. Here are the results:

Suggestion with imageSuggestion with no image

I would like to point out that for title "Incumbent", proposed article is a disambiguation page - Titulaire. Description says "We may want to filter out disambiguation pages, not showing them as a suggestion". @Pginer-WMF, you may want to create separate ticket to capture this. API introduced in T227571 offers disambiguation page as suggestion, this ticket is just about presentation.

Wed, Oct 9, 9:38 PM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)
Petar.petkovic added a comment to T234323: Load a single section in Content translation's editor.

@Pginer-WMF have you considered allowing users to choose where their published section translations should end up? In your mock ups, there was a way to choose which section to translate from source. Similar to that, we may enable users to choose between which sections in target article to insert newly translated one.

Wed, Oct 9, 8:47 PM · Language-Team (Language-2019-October-December), CX-boost
Petar.petkovic updated the task description for T234323: Load a single section in Content translation's editor.
Wed, Oct 9, 8:43 PM · Language-Team (Language-2019-October-December), CX-boost
Petar.petkovic updated the task description for T235058: Adjust default paragraph limit for MT from 80% to 85%.
Wed, Oct 9, 8:42 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), ContentTranslation
Petar.petkovic added a comment to T229242: Explore ways to restrict suggestions to a given knowledge area.

I used to make some efforts personally to determine articles with most languages that are missing in Serbian, regardless of topic. Tried Wikidata first, but without any additional filtering, query would timeout every time. Then, I started querying with instanceof and similar properties, which yielded some results. Some topics with large amount of items would still timeout, like movies, actors, etc. Many others complete successfully, like entrepreneur or bank.
I tried modifying your query slightly, most notably adding ORDER BY DESC(?linkcount) and running it for all categories you defined in topics.json. Some topics returned low quality (and quantity) suggestions, like Q1071 (Geography). Others worked nicely.
I see this approach could be useful. It depends strongly on Wikidata inter-item connections. We will need to make additional efforts to make some topics usable, maybe combining multiple categories.
Also, there is a question of how generic or specific we want our topics to be and how many of them. Do we want them configurable? Those are questions for @Pginer-WMF.

Wed, Oct 9, 12:16 AM · Language-Team (Language-2019-October-December), CX-boost, WorkType-NewFunctionality

Tue, Oct 8

Petar.petkovic closed T188769: Discarding and selecting new page for translation gives wrong image as Resolved.
Tue, Oct 8, 3:54 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), ContentTranslation
Petar.petkovic moved T188634: Allow to keep for later any article selected in the new translation dialog from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.
Tue, Oct 8, 3:52 PM · Patch-For-Review, Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), CX-boost, Design, CX-TranslationList

Mon, Oct 7

Petar.petkovic added a comment to T232372: Update invite for translation when creating a new article.

After updating the patch to match @Pginer-WMF's design, I did additional checks to verify all the specs are in place.
@Pginer-WMF, once you verify above screenshots look good and following two items are acceptable, I'm merging the patch:

  • The invite does not go away after user starts typing inside the editor
  • Blue dot and invite could be shown simultaneously:

Mon, Oct 7, 11:31 PM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)
Petar.petkovic added a comment to T232020: Articles published with Content Translation are no longer linked to Wikidata.

I just translated this article and is still not linking to wikidata
https://pt.wikipedia.org/wiki/Marianne_(serie_de_televis%C3%A3o)
https://www.wikidata.org/wiki/Q67521330

got this message a few hours after creating the article

, this was done manually by that user, right?

Yes, another user linked your new article to Wikidata item.
Patch 539222 to fix this problem for the second time was deployed with 1.34.0-wmf.25 and Wikidata linking is still not working.

Mon, Oct 7, 7:42 PM · Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Regression, ContentTranslation

Fri, Oct 4

Petar.petkovic added a comment to T232372: Update invite for translation when creating a new article.

I have made some visual adjustments to the patch from @santhosh. Here are some shots:

Generic inviteSuggestion with no imageSpecific suggestion with image
Fri, Oct 4, 12:51 AM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)

Wed, Oct 2

Petar.petkovic moved T232372: Update invite for translation when creating a new article from In Progress to In Review on the Language-Team (Language-2019-July-September) board.
Wed, Oct 2, 11:48 PM · CX-boost, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December)

Mon, Sep 30

Petar.petkovic closed T232934: "Content translation failed to load due to internal error" is hardcoded and not translatable as Resolved.
Mon, Sep 30, 10:54 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), I18n, ContentTranslation
Petar.petkovic removed a project from T101815: Bar overlaps in Special:CXStats: Patch-For-Review.
Mon, Sep 30, 10:46 PM · WMF-deploy-2015-06-09_(1.26wmf9), ContentTranslation-Release5, LE-Sprint-87, ContentTranslation
Petar.petkovic added a comment to T205429: CX2: Uncaught TypeError: Cannot read property 'element' of null at VeCeCXTransclusionInlineNode.ve.ce.View.initialize (ve.ce.View.js?9c8a2:109).

Petar, can you create the ticket? When checking the comments above the context seems to be a bit split through several comments and other tickets. So maybe you can collect the different pieces and put them together more easily.
Thanks!

I was not able to reproduce same errors, but actually got different one reported in T234220. Whether that cxserver error covers TypeError: Cannot read property 'shallowCloneFromRange' of null, when translating first paragraph of en:Vantaa to Spanish, is unclear.

Mon, Sep 30, 2:27 PM · Language-Team (Language-2019-July-September), ContentTranslation
Petar.petkovic moved T234220: cxserver error prevents translation of a section: Cannot read property 'replace' of undefined from Backlog to Other on the CX-cxserver board.
Mon, Sep 30, 2:17 PM · CX-cxserver
Petar.petkovic edited projects for T234220: cxserver error prevents translation of a section: Cannot read property 'replace' of undefined, added: CX-cxserver; removed ContentTranslation.
Mon, Sep 30, 2:17 PM · CX-cxserver
Petar.petkovic created T234220: cxserver error prevents translation of a section: Cannot read property 'replace' of undefined.
Mon, Sep 30, 2:15 PM · CX-cxserver
Petar.petkovic added a comment to T206237: Progress bar calculation counts sections that excluded from MT abuse.

@Petar.petkovic, @santhosh, you worked in this area, is this ticket still relevant given the adjustments made to exclude content that we don't expect users to change?

Progress bar is displayed on dashboard. We take number of translated sections and divide that with total number of source sections, which includes those excluded from MT validation. Of that total progress, we mark percentage coming from MT. This calculation excludes sections blacklisted for MT validation.

Mon, Sep 30, 9:33 AM · ContentTranslation
Petar.petkovic moved T232020: Articles published with Content Translation are no longer linked to Wikidata from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.
Mon, Sep 30, 9:04 AM · Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Regression, ContentTranslation
Petar.petkovic removed a project from T231707: Add new validator to validate existence of newlines in source and translation: Patch-For-Review.
Mon, Sep 30, 9:04 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Language-Team (Language-2019-July-September), MediaWiki-extensions-Translate
Petar.petkovic removed a project from T231658: Switch to using the new validator framework for Dissemin project: Patch-For-Review.
Mon, Sep 30, 9:03 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Language-Team (Language-2019-July-September), translatewiki.net
Petar.petkovic removed a project from T231657: Switch to using the new validator framework for iNaturalist project: Patch-For-Review.
Mon, Sep 30, 9:03 AM · Language-Team (Language-2019-July-September), translatewiki.net
Petar.petkovic removed a project from T200328: CX2: Uncaught ReferenceError: specialPageWhitelist is not defined: Language-Team (Language-2019-July-September).
Mon, Sep 30, 9:02 AM · ContentTranslation

Fri, Sep 27

Petar.petkovic added a comment to T205429: CX2: Uncaught TypeError: Cannot read property 'element' of null at VeCeCXTransclusionInlineNode.ve.ce.View.initialize (ve.ce.View.js?9c8a2:109).

Final verdict: Problem with errors when clicking on reference is gone, but there are other errors when adding paragraphs. Should be fixed as part of a separate ticket.

@Petar.petkovic @Pginer-WMF is there a ticket for this?

Not that I know of.

Fri, Sep 27, 7:02 AM · Language-Team (Language-2019-July-September), ContentTranslation

Thu, Sep 26

Petar.petkovic updated subscribers of T89707: Encourage users to publish old inactive unpublished translations.

We need to notify users about old drafts in 15 day windows. In order to avoid notifying same user twice or missing some draft, we decided to save timestamp of last notified draft in that run. That avoids saving and updating info per draft as well.
For purpose of saving this timestamp of last notified draft, new database table is introduced. Since this involves schema changes, by following guidelines, I've added Schema-change tag. Separate task will be created after patch is merged.
Patch which introduces this table can be merged before table is created, as new table usage is behind configuration.

Thu, Sep 26, 2:13 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), Schema-change, CX-boost, Growth-Team, WorkType-NewFunctionality, Collaboration-Team-Triage, Notifications
Petar.petkovic added a project to T89707: Encourage users to publish old inactive unpublished translations: Schema-change.
Thu, Sep 26, 1:58 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), Schema-change, CX-boost, Growth-Team, WorkType-NewFunctionality, Collaboration-Team-Triage, Notifications

Wed, Sep 25

Petar.petkovic added a comment to T232020: Articles published with Content Translation are no longer linked to Wikidata.

The fix has landed with 1.34.0-wmf.24 (deployed on 18 Sep for group 1 wikis like Catalan Wikipedia), but linking to Wikidata is still not working.
Check out some of translations made on 25th of September. Timestamps of when article is created with Content Translation and when that article is linked to Wikidata are not matching. In the two examples, different user has added Wikidata link.

By looking at one of the last articles published before 1.34.0-wmf.20 was deployed, we see that time and author of article creation and Wikidata linking are the same.

Wed, Sep 25, 9:16 AM · Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Regression, ContentTranslation

Sep 19 2019

Petar.petkovic renamed T232986: Enable all possible language pairs in cxserver, apply wiki specific configuration in the wiki from Enable all possible language pairs in cxserver, apply wiki specific confguration in the wiki to Enable all possible language pairs in cxserver, apply wiki specific configuration in the wiki.
Sep 19 2019, 8:15 AM · Language-Team (Language-2019-October-December), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), ContentTranslation
Petar.petkovic closed T223472: Draft namespace not showing as publish option for some wikis as Resolved.
Sep 19 2019, 1:33 AM · Chinese-Sites, ContentTranslation
Petar.petkovic removed a project from T232331: Reference adapted as empty with no apparent reason: Language-Team (Language-2019-July-September).
Sep 19 2019, 1:15 AM · ContentTranslation

Sep 17 2019

Petar.petkovic moved T232020: Articles published with Content Translation are no longer linked to Wikidata from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.
Sep 17 2019, 11:58 AM · Language-Team (Language-2019-October-December), MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Regression, ContentTranslation
Petar.petkovic moved T224880: Gray interlanguage link dialog is misplaced from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.
Sep 17 2019, 7:59 AM · CX-boost, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Language-Team (Language-2019-July-September)

Sep 15 2019

Petar.petkovic moved T205429: CX2: Uncaught TypeError: Cannot read property 'element' of null at VeCeCXTransclusionInlineNode.ve.ce.View.initialize (ve.ce.View.js?9c8a2:109) from Priority backlog to Needs QA on the Language-Team (Language-2019-July-September) board.

I've tried reproducing this. Started translation of en:Vantaa to Spanish and added paragraphs starting with "Vantaa is bordered by Helsinki" and "The largest airport in Finland". Waited for save and reloaded the page. Clicked on only reference to see no error. Reference card was empty.

Sep 15 2019, 10:10 AM · Language-Team (Language-2019-July-September), ContentTranslation

Sep 13 2019

matmarex awarded T232600: Some Phabricator boards do not load cards anymore in Chrome 77 a The World Burns token.
Sep 13 2019, 10:57 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
RHo awarded T232600: Some Phabricator boards do not load cards anymore in Chrome 77 a Yellow Medal token.
Sep 13 2019, 8:30 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
mmodell awarded T232600: Some Phabricator boards do not load cards anymore in Chrome 77 a Mountain of Wealth token.
Sep 13 2019, 8:02 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
Petar.petkovic added a comment to T232583: Adjust Content Translation to changes in AbuseFilter and SpamBlacklist systems.

@Petar.petkovic any hints on how to test this?

There were changes in how Abuse Filter sends data when publishing is prevented due to some filter being hit. Due to good communication, the changes were brought to our attention in time, before changes in Abuse Filter ended up in production. The changes are rolling out in 1.34.0-wmf.23.
We reacted and adapted our code to changes. That means, there is no environment (besides local) where you can see what would happen if we didn't adapt to changes.

Sep 13 2019, 9:26 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Language-Team (Language-2019-July-September), ContentTranslation

Sep 12 2019

Petar.petkovic moved T224880: Gray interlanguage link dialog is misplaced from In Progress to In Review on the Language-Team (Language-2019-July-September) board.
Sep 12 2019, 2:21 PM · CX-boost, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Language-Team (Language-2019-July-September)
Petar.petkovic added a comment to T225118: Math formula should not be checked for unmodified content issues.

@Pginer-WMF the one with the dot at the end still has the issue (it counts for MT abuse), should we fix it on this ticket or open a new one?

I created a separate ticket: T232718: Inline templates should not bypass the minimum length consideration for unmodified content issues
I tried to describe the more general issue as I understood it (not just specific to math formulas followed by a dot). @Jpita, @Petar.petkovic feel free to add further details there if I missed something. Thanks!

Same problem can happen without math formulas, so it's good that your task tries to be generic.

Sep 12 2019, 1:14 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), ContentTranslation
Petar.petkovic removed a project from T204568: Extend message checker framework to support errors that prevent saving: Patch-For-Review.
Sep 12 2019, 12:06 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Language-Team (Language-2019-July-September), User-abi_, translatewiki.net, MediaWiki-extensions-Translate
Petar.petkovic moved T232583: Adjust Content Translation to changes in AbuseFilter and SpamBlacklist systems from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.
Sep 12 2019, 12:03 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Language-Team (Language-2019-July-September), ContentTranslation
Petar.petkovic added a comment to T232683: Update ContentTranslation for changes in AbuseFilter and SpamBlacklist API error responses.

I don't see what need to be changed in AbuseFilterCheckTest.php. The rest is changed as part of T232583.

Sep 12 2019, 9:04 AM · ContentTranslation

Sep 11 2019

Petar.petkovic moved T218184: Update apertium-nno-nob, apertium-swe-dan, apertium-swe-nor and apertium-dan-nor packages from In Progress to In Review on the Language-Team (Language-2019-July-September) board.
Sep 11 2019, 11:07 PM · Language-Team (Language-2019-July-September), CX-deployments
Petar.petkovic moved T230230: CX puts unnecessary burden on many page views from In Review to Needs QA on the Language-Team (Language-2019-July-September) board.

@Jpita let me clarify what you should look after in next release.

Sep 11 2019, 11:04 PM · CX-boost, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Language-Team (Language-2019-July-September)
Petar.petkovic added a comment to T232600: Some Phabricator boards do not load cards anymore in Chrome 77.

Spooky territory – incognito doesn't work for me either:

Incognito not working for me. Checked that before reporting the ticket, but forgot to write it down.

Sep 11 2019, 3:41 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
Petar.petkovic claimed T232583: Adjust Content Translation to changes in AbuseFilter and SpamBlacklist systems.
Sep 11 2019, 3:32 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Language-Team (Language-2019-July-September), ContentTranslation
Petar.petkovic added a comment to T232600: Some Phabricator boards do not load cards anymore in Chrome 77.

I don't see cards on Growth-Team board, just like @RHo reported.

For me it locks up the tab so badly that I can't even get developer tools to work.

I cannot open DevTools as well. But if I open DevTools while some other site is open and then go to URL for Language-Team (Language-2019-October-December) board, I see some requests are pending forever. Screenshot below. Could not export HAR file.

Sep 11 2019, 2:29 PM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
Petar.petkovic updated the task description for T232600: Some Phabricator boards do not load cards anymore in Chrome 77.
Sep 11 2019, 11:48 AM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
Petar.petkovic created T232600: Some Phabricator boards do not load cards anymore in Chrome 77.
Sep 11 2019, 11:46 AM · Release-Engineering-Team-TODO (201909), Upstream, Phabricator (Upstream), Browser-Support-Google-Chrome
Petar.petkovic added a comment to T206310: CX2: Highlight references with a template that is missing mandatory parameters after being adapted.

I want to point out that warning is shown because সাময়িকী (periodicals in target template) is empty, not because "Journal" is not mapped. Even if target template had equivalent field named exactly the same (Journal), সাময়িকী would still not be mapped and warning would be shown.

Yes, the warning is shown because সাময়িকী is empty, but if CX were able to copy the info ("The Journal of Politics") from Journal into সাময়িকী, then সাময়িকী won't be empty and the warning won't be shown. Is that correct? Here I'm assuming that সাময়িকী and "Journal" are equivalent parameters since both of them seem to be about the name of the publication in each template.

Yes, if "Journal" were to be mapped to সাময়িকী, the warning would not be shown. I just don't know if those two are equivalent.

Sep 11 2019, 9:34 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), ContentTranslation
Petar.petkovic added a comment to T206310: CX2: Highlight references with a template that is missing mandatory parameters after being adapted.

I want to point out that warning is shown because সাময়িকী (periodicals in target template) is empty, not because "Journal" is not mapped. Even if target template had equivalent field named exactly the same (Journal), সাময়িকী would still not be mapped and warning would be shown.

Sep 11 2019, 8:56 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), ContentTranslation
Petar.petkovic added a comment to T206310: CX2: Highlight references with a template that is missing mandatory parameters after being adapted.

So it seems that in the example, the "Periodicals" parameter from the source was not copied over, causing a mandatory parameter in the target template (labelled as "periodicals") to be empty. As a result the warning is shown, as expected, for the user to fill the mandatory parameter. Is my interpretation correct, @Jpita, @Petar.petkovic?

On screenshots @Jpita posted, source is on the right and target is on the left. Target is in Bengali, but translated to English. Source does not have "Periodicals" param. That is translation of সাময়িকী param in Bengali Wikipedia's Cite journal. Since nothing can be mapped to সাময়িকী from source due to lack of English aliases, and that param is mandatory, warning is shown.

Sep 11 2019, 8:37 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), ContentTranslation

Sep 10 2019

Petar.petkovic added a comment to T89707: Encourage users to publish old inactive unpublished translations.

I'd expect it to select the translations started in the range [3 months ago, 3months ago + 15days].

@Pginer-WMF what about first run? Should we notify users about all drafts older than three months and than target 15 day windows or should we start with 15 days window for the first run as well?

Sep 10 2019, 5:05 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Language-Team (Language-2019-October-December), Schema-change, CX-boost, Growth-Team, WorkType-NewFunctionality, Collaboration-Team-Triage, Notifications
Petar.petkovic added a comment to T224880: Gray interlanguage link dialog is misplaced.

@Pginer-WMF is this behavior acceptable according to how small the width is, or should we fix this?

If I understand it correctly, for screens/windows narrower than 690px the dialog is unreachable.
I think this needs to be fixed, but I'm ok capturing it on a separate ticket about adapting to small screens if you prefer.

Yes, dialog is unreachable on screens smaller than 690px. Separate ticket is not needed, problem can be tackled right here.

Sep 10 2019, 11:34 AM · CX-boost, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Language-Team (Language-2019-July-September)
Petar.petkovic added a comment to T206310: CX2: Highlight references with a template that is missing mandatory parameters after being adapted.

&page=Incumbent&from=en&to=bn


side by side comparison of both templates

I see target template on the left and source on the right. Looks like Chrome's "Translate to English" is applied. Since it can be seen that mandatory param is missing and warning is shown, I assume your comment is positive.
You could try some more cases with Cite journal template which I described in T206310#5416676 or find some other example. I've seen Esperanto Wikipedia also having some templates with non-English param names.

Sep 10 2019, 11:15 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), ContentTranslation
Petar.petkovic added a comment to T232218: Infobox Presse écrite should not be translated to a table.

Ok, even without {{Titre en italique}} at the top, source article is rendered as a table and wrapped with additional "Modèle:Infobox Presse écrite".

Sep 10 2019, 9:11 AM · ContentTranslation, Language-Team (Language-2019-July-September)
Petar.petkovic added a comment to T206310: CX2: Highlight references with a template that is missing mandatory parameters after being adapted.

@Pginer-WMF @Petar.petkovic can't find any example for this, do you have any?

Yes, I wrote an example in T206310#5416676.

Sep 10 2019, 7:56 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), ContentTranslation

Sep 8 2019

Petar.petkovic claimed T230230: CX puts unnecessary burden on many page views.
Sep 8 2019, 10:40 PM · CX-boost, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Language-Team (Language-2019-July-September)
Petar.petkovic updated subscribers of T232218: Infobox Presse écrite should not be translated to a table.

Source template is table as well. I think the problem is that first two templates Titre en italique and Infobox Presse écrite end up under the same section.
Such metadata and formatting templates used at the beginning of articles usually cause empty sections (T200327) and problem like this.

Sep 8 2019, 1:13 PM · ContentTranslation, Language-Team (Language-2019-July-September)

Sep 5 2019

Petar.petkovic removed a project from T231270: Failing build process: Variadic params with type constraints are not supported in non-Hack files: Patch-For-Review.
Sep 5 2019, 8:28 AM · Language-Team (Language-2019-July-September), MediaWiki-extensions-TwnMainPage
Petar.petkovic removed a project from T206310: CX2: Highlight references with a template that is missing mandatory parameters after being adapted: Patch-For-Review.
Sep 5 2019, 8:27 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), ContentTranslation
Petar.petkovic removed a project from T229946: Issue with reference: Language-Team (Language-2019-July-September).
Sep 5 2019, 8:26 AM · ContentTranslation
Petar.petkovic removed a project from T231835: Some math formulas still counting for MT abuse: Language-Team (Language-2019-July-September).
Sep 5 2019, 8:25 AM · ContentTranslation
Petar.petkovic added a comment to T206310: CX2: Highlight references with a template that is missing mandatory parameters after being adapted.

@Jpita The patch is now deployed, you may proceed with testing.

Sep 5 2019, 8:25 AM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), Language-Team (Language-2019-July-September), ContentTranslation