Petar.petkovic (Petar Petković)
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 20 2017, 9:26 AM (44 w, 2 d)
Availability
Available
LDAP User
Petar.petkovic
MediaWiki User
Unknown

Recent Activity

Today

Petar.petkovic removed a project from T191508: CX2: Styling toolbar menus hidden behind content: Language-2018-Apr-June.
Thu, Apr 26, 9:20 AM · ContentTranslation
Petar.petkovic removed a project from T189869: CX2: Show introduction card only when relevant: Patch-For-Review.
Thu, Apr 26, 9:16 AM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic moved T190203: CX2: Hidden categories are adapted and displayed from Backlog to Parsing and annotation on the ContentTranslation-CXserver board.
Thu, Apr 26, 8:20 AM · Language-2018-Apr-June, ContentTranslation-CXserver, ContentTranslation
Petar.petkovic removed a project from T190203: CX2: Hidden categories are adapted and displayed: Patch-For-Review.
Thu, Apr 26, 8:00 AM · Language-2018-Apr-June, ContentTranslation-CXserver, ContentTranslation

Yesterday

Petar.petkovic removed a project from T190908: CX2: Paragraphs remain highlighted after adding them to the translation: Patch-For-Review.
Wed, Apr 25, 11:18 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic claimed T190908: CX2: Paragraphs remain highlighted after adding them to the translation.
Wed, Apr 25, 5:12 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic updated subscribers of T56203: Core-ify the CleanChanges extension's intent (to filter and declutter RecentChanges).

FYI: T167224: Implement 'User' filters and filter menu in the new UI will be worked on in the context of GSoC

Wed, Apr 25, 4:32 PM · Wikimedia-Hackathon-2018, MediaWiki-extensions-CleanChanges, User-Nikerabbit, Design, MediaWiki-Recent-changes
Petar.petkovic removed a project from T189488: CX2: Show translation issues: Patch-For-Review.
Wed, Apr 25, 2:15 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Language-2018-Apr-June, Design, ContentTranslation
Petar.petkovic added a comment to T190907: CX2: Styling adjustments for paragraph highlighting.
  • Paragraph highlight and "Add translation" placeholder should have the same size.

In T190907#4141717, @Etonkovidova wrote:
cx2-testing: Highlighted paragraph and 'Add translation' match in size.

Wed, Apr 25, 12:39 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic created T193016: CX2: Section highlights have unbalanced padding.
Wed, Apr 25, 12:28 PM · Language-2018-Apr-June, ContentTranslation

Tue, Apr 24

Petar.petkovic closed T191370: CX2: Long category names overflow oo-ui-labelElement-label as Resolved.

Since @Etonkovidova would need to wait for next release of OOUI to do QA, I have checked the article from the description and captured following screenshot:


Thanks @matmarex for dealing with this.

Tue, Apr 24, 7:45 PM · OOUI (OOUI-0.26.5), Language-2018-Apr-June, ContentTranslation
Petar.petkovic closed T191370: CX2: Long category names overflow oo-ui-labelElement-label, a subtask of T188605: CX2: Category support, as Resolved.
Tue, Apr 24, 7:45 PM · Language-2018-Apr-June, Epic, ContentTranslation
Petar.petkovic removed a project from T191370: CX2: Long category names overflow oo-ui-labelElement-label: Patch-For-Review.
Tue, Apr 24, 7:32 PM · OOUI (OOUI-0.26.5), Language-2018-Apr-June, ContentTranslation
Petar.petkovic added a comment to T190907: CX2: Styling adjustments for paragraph highlighting.

I think we want to get both of these issues fixed. For CX1 we don't want to cause regressions, and for CX2 this does not look as intended. I think @Petar.petkovic had some ideas on how to adjust the highlight to solve this.

If you're referring to the discussion two of us had during recent daily meeting, then I was talking about how these highlights relate to section issue indicator, which is about to be introduced for T189488.

Comparing cx-testing and cx2-testing (for the same article)
(1) cx-testing

  • highlighted paragraph and 'Add translation' do not match in size

(2) cx2-testing

  • highlighted paragraph and 'Add translation' match in size

Proposed solution in the description of this ticket says: "Expand the "Add translation" placeholder 4px to align in size with the highlight areas next to it". @Pginer-WMF, did you change your mind about this? Or there is a regression in CX1? Not sure what's wrong here.

Comparing cx-testing and cx2-testing (for the same article)
(1) cx-testing

  • the bottom padding for highlighted paragraph is present

(2) cx2-testing

  • the bottom padding for highlighted paragraph is not present

This is already pointed out in T190907#4110421. I advise to create new ticket for this, although it looks related to what was the scope of this ticket.

Tue, Apr 24, 4:43 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic added a project to T175834: TranslatablePageMoveJob commit while in atomic sections: Patch-For-Review.
Tue, Apr 24, 9:15 AM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Language-2018-Apr-June, Language-Team, MediaWiki-extensions-Translate, Wikimedia-log-errors
Petar.petkovic removed a project from T175834: TranslatablePageMoveJob commit while in atomic sections: Patch-For-Review.
Tue, Apr 24, 7:06 AM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Language-2018-Apr-June, Language-Team, MediaWiki-extensions-Translate, Wikimedia-log-errors

Mon, Apr 23

Petar.petkovic moved T189488: CX2: Show translation issues from In Progress to In Review on the Language-2018-Apr-June board.
Mon, Apr 23, 4:32 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Language-2018-Apr-June, Design, ContentTranslation
Petar.petkovic moved T191349: No error messages for unsuccessful publishing with invalid target title from In Review to QA on the Language-2018-Apr-June board.
Mon, Apr 23, 3:11 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic removed a project from T123909: Validate the translation titles against the abusefilter rules in target wiki: Patch-For-Review.
Mon, Apr 23, 11:16 AM · MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), LE-CX8-Sprint 3, Design, WorkType-NewFunctionality, ContentTranslation, ContentTranslation-Release8

Thu, Apr 19

Petar.petkovic created T192545: Error loading table with broken wikitext syntax.
Thu, Apr 19, 12:20 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor (Current work), VisualEditor-ContentEditable, ContentTranslation
Petar.petkovic moved T190203: CX2: Hidden categories are adapted and displayed from Backlog to In Review on the Language-2018-Apr-June board.
Thu, Apr 19, 11:42 AM · Language-2018-Apr-June, ContentTranslation-CXserver, ContentTranslation
Petar.petkovic moved T190254: Remove irrelevant sections from source article for translation from QA to In Review on the Language-2018-Apr-June board.
Thu, Apr 19, 11:31 AM · Patch-For-Review, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Language-2018-Apr-June, ContentTranslation, ContentTranslation-CXserver
Petar.petkovic placed T190038: CX2: Warning when page title already exists up for grabs.
Thu, Apr 19, 10:28 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation

Wed, Apr 18

Petar.petkovic claimed T189488: CX2: Show translation issues.
Wed, Apr 18, 9:20 PM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Language-2018-Apr-June, Design, ContentTranslation
Petar.petkovic moved T162768: CX2: Basic translation publishing and error handling from QA to Done on the Language-2018-Apr-June board.
Wed, Apr 18, 9:19 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Language-2018-Apr-June, Language-2017-July-Sept, ContentTranslation-FY2017-18, Language-team April-June 2017 (Language-2017 Sprint 9), ContentTranslation
Petar.petkovic added a comment to T190249: "[CX] Invalid target title" error for any translated article title.

I cannot reproduce this on cx-testing and cx2-testing. @Etonkovidova, does this happen for all language pairs and any edit to target article title? I have tried opening some recommended articles for en->es and sr->en language pairs on cx-testing and cx2-testing. Changing target title works as expected and no errors are logged in console.

Wed, Apr 18, 9:06 PM · ContentTranslation-CXserver, ContentTranslation
Petar.petkovic added a comment to T189766: CX2: Show the captcha confirmation dialog when the target wiki requests it.

I think we can do the following:

  • Show an error box. When the captcha fails, we could add an error message box inline ("Your answer does not seem correct. Please, try again."). From your comments, it is not clear whether this is a valid and technically simple option. Another option could be to show the messages based on time.
Wed, Apr 18, 2:26 PM · Patch-For-Review, Language-2018-Apr-June, ContentTranslation
Petar.petkovic moved T189488: CX2: Show translation issues from Priority backlog to In Progress on the Language-2018-Apr-June board.
Wed, Apr 18, 11:05 AM · MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Language-2018-Apr-June, Design, ContentTranslation

Tue, Apr 17

Petar.petkovic updated subscribers of T187985: CX2: Open in-progress translations with the same editor version they were created.

This should already be working. @Nikerabbit, is this done with T187770?

Tue, Apr 17, 8:12 PM · Language-2018-Apr-June, ContentTranslation
Petar.petkovic updated the task description for T192144: CX2: Communicate that publishing is only allowed to experienced editors.
Tue, Apr 17, 8:01 PM · Language-2018-Apr-June, ContentTranslation
Petar.petkovic moved T189766: CX2: Show the captcha confirmation dialog when the target wiki requests it from In Progress to In Review on the Language-2018-Apr-June board.
Tue, Apr 17, 7:42 PM · Patch-For-Review, Language-2018-Apr-June, ContentTranslation
Petar.petkovic moved T188247: CX2: Automatic Translation card to adjust MT options from In Progress to In Review on the Language-2018-Apr-June board.
Tue, Apr 17, 7:34 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic added a comment to T189766: CX2: Show the captcha confirmation dialog when the target wiki requests it.

I have some questions about the introductory text ("To edit this page, please answer the question that appears below (more info):":

  • Does this come from the Captcha itself or is something that we can customise. I'm concerned about the "to edit this page", and would like to have a more specific message (using "publish" instead).

CAPTCHA system is implemented in ConfirmEdit extension and everything in my demo dialog from last comment is coming from that extension, including the messages ("CAPTCHA" message in dialog header and introductory text "To edit this page...") and the content of CAPTCHA (question, image, math equation...). So, the messages are defined in ConfirmEdit extension, but we're controlling what is used in dialog and we can introduce new messages for this use case.
That will also remove the dependency on UI messages which are coming from non-CX extension. You can specify entirely different introductory sentence if you want, but keep in mind that different types of CAPTCHA may require different introductory sentences. You have the list of CAPTCHA types on extension mediawiki page (on the end of this comment, there are messages for these different types). Or, we can try to come up with universal intro sentence.

Tue, Apr 17, 5:58 PM · Patch-For-Review, Language-2018-Apr-June, ContentTranslation
Petar.petkovic removed a project from T189671: CX2: Confirm publishing when warnings exist: Language-2018-Apr-June.
Tue, Apr 17, 2:50 PM · ContentTranslation
Petar.petkovic added a comment to T189766: CX2: Show the captcha confirmation dialog when the target wiki requests it.
In T189766, @Pginer-WMF wrote:

As the first step of this task, we may want to check how it is provided in VE and CX1 currently (feel free to add screenshots to the ticket).

Here is how CX1 handles QuestyCaptcha:


As you can see, problem from T161333 exists in LTR wikis as well.

Tue, Apr 17, 11:21 AM · Patch-For-Review, Language-2018-Apr-June, ContentTranslation
Petar.petkovic claimed T189766: CX2: Show the captcha confirmation dialog when the target wiki requests it.
Tue, Apr 17, 12:26 AM · Patch-For-Review, Language-2018-Apr-June, ContentTranslation

Mon, Apr 16

Petar.petkovic removed a project from T190038: CX2: Warning when page title already exists: Patch-For-Review.
Mon, Apr 16, 6:52 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation

Fri, Apr 13

Petar.petkovic removed a project from T174400: [wmf.15] Featured articles do not display their 'Featured' label when moved to 'For later' : User-Petar.petkovic.
Fri, Apr 13, 10:07 PM · ContentTranslation
Petar.petkovic removed a project from T121230: Adjust ContentTranslation suggestion refresh transition: User-Petar.petkovic.
Fri, Apr 13, 10:06 PM · ContentTranslation, Design, WorkType-NewFunctionality
Petar.petkovic removed a project from T178152: Adjust appearing transition for the new translation dialog: User-Petar.petkovic.

Related comment - T111094#3586689.

Fri, Apr 13, 10:06 PM · ContentTranslation
Petar.petkovic removed a project from T96165: Learn from user corrections to avoid editing the same term again and again: User-Petar.petkovic.
Fri, Apr 13, 10:05 PM · WorkType-NewFunctionality, ContentTranslation
Petar.petkovic removed a project from T155767: Better suport Content translation on small screens and touch: User-Petar.petkovic.
Fri, Apr 13, 10:05 PM · ContentTranslation
Petar.petkovic removed a project from T120067: Adjust ContentTranslation suggestion discard workflow: User-Petar.petkovic.
Fri, Apr 13, 10:05 PM · WorkType-NewFunctionality, Design, ContentTranslation
Petar.petkovic moved T189858: [cx2-testing] Math formulas not displayed from QA to Done on the Language-2018-Apr-June board.
Fri, Apr 13, 9:51 PM · Language-2018-Apr-June, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), ContentTranslation
Petar.petkovic moved T189291: CX2: Communicate publishing is in progress from QA to Done on the Language-2018-Apr-June board.
Fri, Apr 13, 9:39 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic moved T188247: CX2: Automatic Translation card to adjust MT options from Priority backlog to In Progress on the Language-2018-Apr-June board.
Fri, Apr 13, 1:36 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Language-2018-Apr-June, ContentTranslation

Thu, Apr 12

Petar.petkovic removed a project from T191292: Release MLEB 2018.04: Patch-For-Review.
Thu, Apr 12, 9:37 PM · Language-Team, MediaWiki Language Extension Bundle, Language-2018-Apr-June
Petar.petkovic moved T190038: CX2: Warning when page title already exists from QA to In Review on the Language-2018-Apr-June board.
Thu, Apr 12, 9:34 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic removed a project from T190441: Deprecate and remove 'userActive', as it's a duplicate of 'userAvatar': Patch-For-Review.
Thu, Apr 12, 4:54 PM · OOUI
Petar.petkovic removed a project from T189113: 'userInactive' icon not available on Apex theme – add 'userAnonymous' and deprecate 'userInactive': Patch-For-Review.
Thu, Apr 12, 4:54 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), UI-Standardization, OOUI
Petar.petkovic added a comment to T162768: CX2: Basic translation publishing and error handling.

@santhosh and @Pginer-WMF The issues seem to be kind of out of the overall scope of this task. Should be there separate tickets?

There actually is a separate ticket for everything listed.

(1) When "[CX] Invalid target title" Console error is shown, there is no indication to a user that the title needs to be corrected. The article will be published with the previous valid title or defaults to the title of the article being translated.

I'm dealing with this in T191349, which is meant to restore what we have in CX1 - when user tries to publish with invalid target title, error is displayed. T190804 is set to indicate which characters are wrong and prohibit publishing if there are invalid characters in target title.

(2) Another case for error handling - when a user session is expired. The Publish icon remains active but no action can be performed:

There was no ticket for this specific case at the time you wrote the comment, but @Pginer-WMF created T192066 after that.

Thu, Apr 12, 11:48 AM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Language-2018-Apr-June, Language-2017-July-Sept, ContentTranslation-FY2017-18, Language-team April-June 2017 (Language-2017 Sprint 9), ContentTranslation
Petar.petkovic removed a project from T188072: CX-VE integration framework should have a way to use tools container for tools: Patch-For-Review.
Thu, Apr 12, 11:19 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), Language-2018-Apr-June, ContentTranslation
Petar.petkovic removed a project from T190907: CX2: Styling adjustments for paragraph highlighting: Patch-For-Review.
Thu, Apr 12, 11:14 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic added a comment to T191349: No error messages for unsuccessful publishing with invalid target title.

This patch is restoring what we have in CX1. When user tries to publish with invalid target title, publishing fails and error message is shown. After T190804, publishing the page with invalid character in the title will be impossible.

Thu, Apr 12, 11:12 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic moved T191349: No error messages for unsuccessful publishing with invalid target title from Backlog to In Review on the Language-2018-Apr-June board.
Thu, Apr 12, 11:10 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic renamed T191349: No error messages for unsuccessful publishing with invalid target title from [cx2-testing] No error messages for unsuccessful publishing to No error messages for unsuccessful publishing with invalid target title.
Thu, Apr 12, 11:10 AM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic removed a project from T192049: Tools column responsiveness with VE Context tools minimum width : Patch-For-Review.
Thu, Apr 12, 10:48 AM · Language-2018-Apr-June, MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor, Design, ContentTranslation

Wed, Apr 11

Petar.petkovic closed T171906: [wmf.11] Make 'Refresh suggestions' work smoother when only few suggested articles are present on the list of suggested articles as Resolved.

This blinking no longer happens, but T156324 is still there.

Wed, Apr 11, 3:46 PM · ContentTranslation
Petar.petkovic removed a project from T189291: CX2: Communicate publishing is in progress: Patch-For-Review.

In latest patch publish settings and section/sentence highlighting are disabled while publishing is in progress.

Wed, Apr 11, 2:45 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic moved T189291: CX2: Communicate publishing is in progress from In Progress to In Review on the Language-2018-Apr-June board.
Wed, Apr 11, 1:32 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic updated the task description for T189291: CX2: Communicate publishing is in progress.
Wed, Apr 11, 1:26 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic added a comment to T191474: Hard-coded checkmarks need to be replaced by IconWidget.

Another example from VE on enwiki beta.

Wed, Apr 11, 1:22 PM · OOUI (OOUI-0.26.3)
Petar.petkovic added a comment to T189291: CX2: Communicate publishing is in progress.

Moving back to 'In Progress' for addressing the missing requirement.

  • highlighting of paragraph(s) is available during puvlishing
  • 'View page' is active

Btw, 'All translation' is disabled, I think.

Wed, Apr 11, 1:02 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic added a comment to T191474: Hard-coded checkmarks need to be replaced by IconWidget.

I think patches linked to this ticket are the reason for these checkmarks on CX "New translation" dialog:

Wed, Apr 11, 10:58 AM · OOUI (OOUI-0.26.3)
Petar.petkovic moved T188072: CX-VE integration framework should have a way to use tools container for tools from In Progress to In Review on the Language-2018-Apr-June board.
Wed, Apr 11, 10:11 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), VisualEditor (Current work), Language-2018-Apr-June, ContentTranslation
Petar.petkovic added a comment to T191124: CX2: Content isn't properly divided into sections.

I could not try the example. @Petar.petkovic, can you confirm the issue still happens?

Wed, Apr 11, 9:17 AM · Language-2018-Apr-June, ContentTranslation
Petar.petkovic removed a project from T190038: CX2: Warning when page title already exists: Patch-For-Review.
Wed, Apr 11, 9:09 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation

Tue, Apr 10

Petar.petkovic removed a project from T190957: MWException from line 154 of /srv/mediawiki/php-1.31.0-wmf.26/extensions/Translate/utils/MessageHandle.php: called before isValid: Patch-For-Review.
Tue, Apr 10, 10:59 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Language-2018-Apr-June, MediaWiki-extensions-Translate, Wikimedia-log-errors
Petar.petkovic removed a project from T190254: Remove irrelevant sections from source article for translation: Patch-For-Review.
Tue, Apr 10, 10:59 PM · Patch-For-Review, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Language-2018-Apr-June, ContentTranslation, ContentTranslation-CXserver
Petar.petkovic removed a project from T191594: CX2: Support <poem>: Patch-For-Review.
Tue, Apr 10, 4:03 PM · ContentTranslation
Petar.petkovic removed a project from T189858: [cx2-testing] Math formulas not displayed : Patch-For-Review.
Tue, Apr 10, 4:02 PM · Language-2018-Apr-June, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), ContentTranslation
Petar.petkovic removed a project from T191390: CX: Support Timeline content: Patch-For-Review.
Tue, Apr 10, 4:02 PM · Language-2018-Apr-June, ContentTranslation
Petar.petkovic removed a project from T162114: CX2: Template adaptation: Patch-For-Review.
Tue, Apr 10, 4:01 PM · Language-2018-Apr-June, Language-2017-July-Sept, ContentTranslation-FY2017-18, ContentTranslation
Petar.petkovic added a comment to T188617: CX2: Adjust the empty state of the categories list.

(filed as T191825: RTL support for Categories section ) @Petar.petkovic One questions - in RTL languages the icon overlaps the label - is it some limitation in cx2-testing environment or more support of RTL is needed?

Tue, Apr 10, 3:51 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic moved T188617: CX2: Adjust the empty state of the categories list from QA to Done on the Language-2018-Apr-June board.
Tue, Apr 10, 6:58 AM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic moved T188733: CX2: Confirm translation was published successfully from QA to Done on the Language-2018-Apr-June board.
Tue, Apr 10, 6:56 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Language-2018-Apr-June, ContentTranslation

Fri, Apr 6

Petar.petkovic added a comment to T190907: CX2: Styling adjustments for paragraph highlighting.

You may want to address the unbalanced padding caused by paragraphs only having bottom-margin:

Fri, Apr 6, 11:43 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic moved T162114: CX2: Template adaptation from Backlog to In Review on the Language-2018-Apr-June board.
Fri, Apr 6, 10:03 AM · Language-2018-Apr-June, Language-2017-July-Sept, ContentTranslation-FY2017-18, ContentTranslation
Petar.petkovic removed a project from T189563: Translate incompatible with MW 1.29: Patch-For-Review.
Fri, Apr 6, 7:05 AM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Language-2018-Apr-June, MediaWiki Language Extension Bundle, MediaWiki-extensions-Translate

Thu, Apr 5

Petar.petkovic moved T190907: CX2: Styling adjustments for paragraph highlighting from Priority backlog to In Review on the Language-2018-Apr-June board.
Thu, Apr 5, 3:40 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic claimed T190907: CX2: Styling adjustments for paragraph highlighting.
Thu, Apr 5, 2:24 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic added a comment to T190038: CX2: Warning when page title already exists.

In case it wasn't clear from my above comment, once this ticket goes through QA for "Publish anyway" dialog, it should be moved back to "Priority backlog".
My assignment can be removed, so some other person becomes able to work on rest of the specs.

Thu, Apr 5, 8:22 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic removed a project from T162768: CX2: Basic translation publishing and error handling: Patch-For-Review.
Thu, Apr 5, 8:05 AM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Language-2018-Apr-June, Language-2017-July-Sept, ContentTranslation-FY2017-18, Language-team April-June 2017 (Language-2017 Sprint 9), ContentTranslation

Wed, Apr 4

Petar.petkovic updated the task description for T141801: OOUI/WikimediaUI icon inventory (tracking).
Wed, Apr 4, 11:29 PM · Tracking, UI-Standardization-Kanban, UI-Standardization, WMF-Design, Design, OOUI
Petar.petkovic added a comment to T189291: CX2: Communicate publishing is in progress.

Errors are generally caught, but not processed properly. Some parts are set to improve after T162768.

Since errors are hard to reproduce, it would be good to have examples to cover more of the different errors that may happen.

There is one error which is easy to reproduce, just insert invalid character in target title. But, it's not handled yet, and reason I wrote "some parts" in above sentence. It will be handled separately, probably very soon.

For this ticket, what I want us to make sure is that in the case of any error, the user does not get to a blocked state. That is, that even if the publishing process fails for whichever reason, the user goes back to a working editing state with the publish button available. This is not happening currently as I tried this in CX2 test servers for the Paneer article. I click on publish and everything got blocked forever, without the possibility to continue editing or retry:

What you observed is not publishing error, it's JavaScript error. When you click "Publish", target title is checked for availability. If there is existing page with same title, dialog to "Publish anyway" should be shown. At that point JS throws error, and you're stuck endlessly. This patch deals with that.

Another distracting aspect is that the content still seems to react to on hover interactions. Showing the "Add translation" placeholder and highlighting paragraphs. It would be preferred those interactions not to happen in the disabled state, in order to avoid showing an invitation for an action we don't allow at that point.

Maybe it'd be good to add that as check item in the description.

Wed, Apr 4, 11:11 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic moved T190038: CX2: Warning when page title already exists from Priority backlog to In Review on the Language-2018-Apr-June board.
Wed, Apr 4, 10:32 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic added a comment to T190038: CX2: Warning when page title already exists.

Patch 424153 only shows the dialog when page with target title already exists, to allow user to publish anyway. Rest of the things this ticket specifies are going to be done separately, because we need more robust warnings and errors system in place.

Wed, Apr 4, 10:32 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic moved T190387: CX2: Prevent to navigate away to source wiki when clicking on image from QA to Done on the Language-2018-Apr-June board.
Wed, Apr 4, 7:24 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic moved T109276: CX2: Suggest parent categories for those not available in target Wiki from Bugs and suggestions to CX2 on the ContentTranslation board.
Wed, Apr 4, 11:13 AM · Language-2018-Apr-June, WorkType-NewFunctionality, ContentTranslation
Petar.petkovic moved T191370: CX2: Long category names overflow oo-ui-labelElement-label from Backlog to CX2 on the ContentTranslation board.
Wed, Apr 4, 10:18 AM · OOUI (OOUI-0.26.5), Language-2018-Apr-June, ContentTranslation
Petar.petkovic updated subscribers of T191370: CX2: Long category names overflow oo-ui-labelElement-label.

This should probably be resolved in OOUI. By looking at the code, one can observe that .oo-ui-tagItemWidget is preventing wrapping and its only child, .oo-ui-labelElement-label, is trying to add ellipsis, but that fails.

Wed, Apr 4, 9:33 AM · OOUI (OOUI-0.26.5), Language-2018-Apr-June, ContentTranslation

Tue, Apr 3

Petar.petkovic moved T189632: CX2: Avoid gaps below the category controls when they have different height from QA to Done on the Language-2018-Apr-June board.
Tue, Apr 3, 11:44 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic added a comment to T189291: CX2: Communicate publishing is in progress.

So far I saw only three cases of warnings

In current state, error handling is poor, which is set to improve after T162768. Although not everything will be handled after that ticket is resolved, especially easiest way to cause fail message to be displayed, which is to use invalid characters in target title. When user types invalid character, that is recognized, but variable which stores target title isn't actually changed. That means when you try publishing after that, you will succeed. Some parts of invalid characters in target title are covered by T190804, but that doesn't cover publishing.

If publishing failed or warnings were shown, the publishing button will become enabled, allowing to try to publish again without the need for making further changes.

I think what is meant to be covered by this ticket is captured in first part of the sentence: enable the button when publish fails. Although, @Pginer-WMF maybe had different idea.

In cases like (2) when specific cause of errors is given, there is a little value in 'Publish' button become active immediately after the failure. A user should address the cause and then proceed with publishing.

There are some mocks showing future framework for displaying warnings and errors - T189488. More information should be provided about the specificity of errors and ideally "Fix this" button will resolve the issue, enabling user to publish without errors. It is up to @Pginer-WMF to decide whether publish button should be immediately enabled after failure, but it may be useful to quickly retry publishing. Some errors may be recoverable, and some may be unrecoverable, where publish button would probably be disabled.

In cases like (3) it might be beneficial to work on specifying the cause of error in the message.

Yes, displaying just the word "error" really look useless, and I hope we will dedicate time to improve that end of error handling as well. There is one ticket to explore common errors with abuse filters (T189475) and we should do the same for other errors, providing better info to the users about what went wrong.

@Pginer-WMF Should the above spec be part of this ticket? It has not been implemented.
Since T188733: CX2: Confirm translation was published successfully is only about publishing success, I filed T191349: No error messages for unsuccessful publishing with invalid target title.

Title of that bug is covered in T162768, but actual description mentions errors with invalid characters while publishing, which should be dealt with separately and your ticket can be used for that. So, title of the ticket may need to be changed.

Tue, Apr 3, 10:38 PM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic moved T188617: CX2: Adjust the empty state of the categories list from Priority backlog to In Review on the Language-2018-Apr-June board.
Tue, Apr 3, 9:54 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic added a comment to T189291: CX2: Communicate publishing is in progress.

I let @Etonkovidova to check remaining points in the description after QA process.

Tue, Apr 3, 11:15 AM · MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic removed a project from T188733: CX2: Confirm translation was published successfully: Patch-For-Review.
Tue, Apr 3, 10:50 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic added a comment to T188238: Adapted categories are not saved along with translation.

Why do categories need to be stored in a separate table? Can't they be stored in the DOM using the Parsoid DOM spec for categories (or some extension of it)?

https://www.mediawiki.org/wiki/Specs/HTML/1.6.x#Category_links

Tue, Apr 3, 9:01 AM · Patch-For-Review, Language-2018-Apr-June, ContentTranslation
Petar.petkovic reopened T189087: Maintenance script for purging old translation drafts that can be run manually by deployers as "Open".

Please move back to Maintenance Backlog (or Blocked) once verified for the last part.

Tue, Apr 3, 8:27 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Language-2018-Apr-June, ContentTranslation
Petar.petkovic reopened T189087: Maintenance script for purging old translation drafts that can be run manually by deployers, a subtask of T183890: Remove very old translation drafts from CX database, as Open.
Tue, Apr 3, 8:27 AM · Language-2018-Apr-June, Epic, ContentTranslation
Petar.petkovic reopened T158835: make Interlanguage links statistics collection more automatic as "Open".
Tue, Apr 3, 7:52 AM · Language-2018-Jan-Mar, Language-2017-Oct-Dec, Language-2017-July-Sept, Language-team April-June 2017 (Language-2017 Sprint 9), Language-2017 Sprint 4, Language-2017 Sprint 3, WorkType-NewFunctionality, ContentTranslation, ContentTranslation-Analytics, Language-team January-March 2017