Page MenuHomePhabricator

Peter (Peter Hedenskog)
Software Engineer, Wikimedia Foundation

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 17 2015, 6:48 PM (353 w, 8 h)
Availability
Available
IRC Nick
phedenskog
LDAP User
Unknown
MediaWiki User
PHedenskog (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Peter added a subtask for T309041: Create and verify the full image: T279582: Continuously run tests using Firefox .
Mon, May 23, 5:33 PM · Performance-Team, Performance-Device-Lab
Peter added a parent task for T279582: Continuously run tests using Firefox : T309041: Create and verify the full image.
Mon, May 23, 5:33 PM · Performance-Team, Performance-Device-Lab
Peter added a parent task for T279581: Continuously run tests using Chrome : T309041: Create and verify the full image.
Mon, May 23, 5:33 PM · Performance-Team, Performance-Device-Lab
Peter added a subtask for T309041: Create and verify the full image: T279581: Continuously run tests using Chrome .
Mon, May 23, 5:33 PM · Performance-Team, Performance-Device-Lab
Peter moved T279582: Continuously run tests using Firefox from Inbox to Next: Goal-oriented on the Performance-Device-Lab board.
Mon, May 23, 5:32 PM · Performance-Team, Performance-Device-Lab
Peter moved T309041: Create and verify the full image from Inbox to Next: Goal-oriented on the Performance-Device-Lab board.
Mon, May 23, 5:30 PM · Performance-Team, Performance-Device-Lab
Peter created T309042: Create and verify the full image.
Mon, May 23, 5:30 PM
Peter created T309041: Create and verify the full image.
Mon, May 23, 5:30 PM · Performance-Team, Performance-Device-Lab
Peter moved T279572: Evaluate doing Android performance test using a Raspberry Pi from Inbox to Next: Goal-oriented on the Performance-Device-Lab board.
Mon, May 23, 5:26 PM · Performance-Team, Performance-Device-Lab
Peter moved T279581: Continuously run tests using Chrome from Inbox to Next: Goal-oriented on the Performance-Device-Lab board.
Mon, May 23, 5:26 PM · Performance-Team, Performance-Device-Lab
Peter moved T285203: Run mobile performance tests on demand from Inbox to Next: Goal-oriented on the Performance-Device-Lab board.
Mon, May 23, 5:26 PM · Performance-Team, Performance-Device-Lab
Peter moved T269201: Test running Samsung Internet browser performance tests from Inbox to Backlog: Maintenance on the Performance-Device-Lab board.
Mon, May 23, 5:02 PM · Upstream, Performance-Team, Performance-Device-Lab
Peter moved T305550: Emulated mobile vs running on real devices from Inbox to Backlog: Maintenance on the Performance-Device-Lab board.
Mon, May 23, 5:02 PM · Performance-Device-Lab, Performance-Team
Peter moved T267555: Create a better warning system for performance regressions from Inbox to Backlog: Future Goals on the Performance-Device-Lab board.
Mon, May 23, 4:59 PM · WebPageTest, WebPageReplay, Performance-Device-Lab, Performance-Team
Peter moved T282516: Try to remove "Save password" popup for Android phones when logged in from Inbox to Backlog: Maintenance on the Performance-Device-Lab board.
Mon, May 23, 4:58 PM · Performance-Device-Lab, Performance-Team
Peter moved T263753: Investigate how the Chrome team runs their performance tests in Android from Inbox to Backlog: Maintenance on the Performance-Device-Lab board.
Mon, May 23, 4:57 PM · Performance-Team, Performance-Device-Lab
Peter added a member for Performance-Device-Lab: Peter.
Mon, May 23, 4:52 PM
Peter created T309026: Add Firefox WebPageReplay alerts.
Mon, May 23, 2:06 PM · WebPageReplay, Performance-Team
Peter closed T308305: Increase screenshots in filmstrip view as Resolved.
Mon, May 23, 11:53 AM · Performance-Team, WebPageReplay

Sun, May 22

Peter added a comment to T308889: ECONNREFUSED error when running Selenium tests on M1 Mac.

Hi, I've been using M1 arm64 for a while and the workaround --platform linux/amd64 almost never works (at least for me) I think we need to have arm64 builds. I've rebuilt my projects that used Chrome and Firefox to build both amd/arm containers.

Sun, May 22, 11:30 AM · User-zeljkofilipin, Performance-Team, Fresh
Peter added a comment to T301538: Include performance bucketing in Growth analytics schemas.

Hi @kostajh cool let us talk about this in our weekly meeting on Tuesday and get back to you.

Sun, May 22, 11:20 AM · Performance-Team, Growth-Team

Tue, May 17

Peter created T308548: Add saving plan for Graphite synthetic testing machine.
Tue, May 17, 1:02 PM · Performance-Team
Peter added a comment to T299886: Upgrade to Chrome 97 increased first visual change metrics for synthetic testing.

Here's what happens with Largest Contentful Paint. Lets run it one more iteration and then revert the change.

Tue, May 17, 10:11 AM · Performance-Team (Radar), Upstream, WebPageReplay

Mon, May 16

Peter moved T307984: Sync TTFB for synthetic tests with data from the Chrome User Experience report from Inbox to Backlog: Maintenance on the Performance-Team board.
Mon, May 16, 6:38 PM · Performance-Team
Peter closed T307946: Peter reach out to bitBar to check for pricing as Resolved.

Meeting done.

Mon, May 16, 5:41 PM · Performance-Device-Lab, Performance-Team
Peter moved T308305: Increase screenshots in filmstrip view from Inbox to Backlog: Maintenance on the Performance-Team board.
Mon, May 16, 4:02 PM · Performance-Team, WebPageReplay

Fri, May 13

Krinkle awarded T308305: Increase screenshots in filmstrip view a Orange Medal token.
Fri, May 13, 8:39 AM · Performance-Team, WebPageReplay
Peter created T308305: Increase screenshots in filmstrip view.
Fri, May 13, 6:51 AM · Performance-Team, WebPageReplay

Thu, May 12

Peter closed T308237: Replace the WebPageReplay enwiki on AWS as Resolved.
Thu, May 12, 2:12 PM · WebPageReplay, Performance-Team
Peter created T308237: Replace the WebPageReplay enwiki on AWS.
Thu, May 12, 12:18 PM · WebPageReplay, Performance-Team

Tue, May 10

Peter created T307984: Sync TTFB for synthetic tests with data from the Chrome User Experience report.
Tue, May 10, 8:29 AM · Performance-Team
Peter added a comment to T307946: Peter reach out to bitBar to check for pricing.

Sent the email earlier today. Lets keep this open until we get an answer.

Tue, May 10, 8:16 AM · Performance-Device-Lab, Performance-Team
Peter moved T307946: Peter reach out to bitBar to check for pricing from Doing: Prio Interrupt to Doing: Goal-oriented on the Performance-Team board.
Tue, May 10, 8:15 AM · Performance-Device-Lab, Performance-Team

Mon, May 9

Peter moved T307446: Move to bare metal servers for performance tests from Doing: Goal-oriented to Next: Goal-oriented on the Performance-Team board.
Mon, May 9, 6:07 PM · Performance-Team
Peter moved T307446: Move to bare metal servers for performance tests from Inbox to Doing: Goal-oriented on the Performance-Team board.
Mon, May 9, 6:07 PM · Performance-Team
Peter moved T307946: Peter reach out to bitBar to check for pricing from Inbox to Doing: Prio Interrupt on the Performance-Team board.
Mon, May 9, 6:07 PM · Performance-Device-Lab, Performance-Team
Peter closed T306976: WebPageTest alert 2022-04-27 as Resolved.

I pushed a new version this weekend where the base image is based on Ubuntu 20 and that works.

Mon, May 9, 7:22 AM · WebPageTest, Performance-Team

Fri, May 6

Peter added a comment to T306976: WebPageTest alert 2022-04-27.

I haven't been able to fix/understand the root cause. The difference is that the base Docker container uses latest Ubuntu 22 (instead of 20). However it works on my machine and other cloud hosts.

Fri, May 6, 11:57 AM · WebPageTest, Performance-Team
Peter closed T307567: Add TTFB and interaction to next paint in the Chrome User Experience dashboard as Resolved.
Fri, May 6, 11:40 AM · Performance-Team
Peter added a comment to T307446: Move to bare metal servers for performance tests.

I think what I need to know if if we can have servers running in our dc on an isolated network, maybe you know this @dpifke ? Those servers needs to be able to connect to internet but we do not want them to be connected in any way with the rest of our servers.

Fri, May 6, 11:17 AM · Performance-Team

Wed, May 4

Peter created T307567: Add TTFB and interaction to next paint in the Chrome User Experience dashboard.
Wed, May 4, 12:42 PM · Performance-Team
Peter added a comment to T305426: Remove alerts and tests for Firefox on WebPageReplay enwiki.

Adding some more screenshots. This is what it looked like for the Sweden article for Firefox on WebPageReplay:

Screenshot 2022-05-04 at 12.42.55.png (1×2 px, 1 MB)

Wed, May 4, 10:46 AM · Performance-Team, WebPageReplay

Tue, May 3

Peter created T307446: Move to bare metal servers for performance tests.
Tue, May 3, 11:37 AM · Performance-Team
Peter closed T307097: The running disk for the synthetic test Graphite instance is 99% full as Resolved.

Emptied old logs and we are down to 76%, I think that is ok for now.

Tue, May 3, 7:32 AM · Performance-Team
Peter added a comment to T307079: phedenskog uses the same SSH key(s) in WMCS and production.

Thanks a lot @fgiunchedi !!!!

Tue, May 3, 7:12 AM · SRE

Mon, May 2

Peter moved T306976: WebPageTest alert 2022-04-27 from Inbox to Doing: Prio Interrupt on the Performance-Team board.
Mon, May 2, 11:17 AM · WebPageTest, Performance-Team
Peter closed T307093: Create dashboard for first view vs warm cache view as Resolved.

https://grafana.wikimedia.org/d/gVqgE_Q7z/first-view-vs-warm-cache-view

Mon, May 2, 11:16 AM · Performance-Team
Peter moved T307097: The running disk for the synthetic test Graphite instance is 99% full from Inbox to Doing: Prio Interrupt on the Performance-Team board.
Mon, May 2, 11:16 AM · Performance-Team
Peter added a comment to T307079: phedenskog uses the same SSH key(s) in WMCS and production.

What's the preferred way to send the public key?

Mon, May 2, 6:14 AM · SRE

Fri, Apr 29

Peter added a comment to T307079: phedenskog uses the same SSH key(s) in WMCS and production.

Thanks @fgiunchedi and @Dzahn I'll do that first thing next week.

Fri, Apr 29, 12:16 PM · SRE

Thu, Apr 28

Peter added a comment to T307093: Create dashboard for first view vs warm cache view.

The names in Graphite and the tests are renamed. Gonna let them tun through and verify that they are correct and then lets make the dashboard.

Thu, Apr 28, 1:21 PM · Performance-Team
Peter added a comment to T307097: The running disk for the synthetic test Graphite instance is 99% full.

I've took this down to 85% and then moved on with T307093. Let me continue to look when I'm done with the new dashboard.

Thu, Apr 28, 12:51 PM · Performance-Team
Peter created T307097: The running disk for the synthetic test Graphite instance is 99% full.
Thu, Apr 28, 11:54 AM · Performance-Team
Peter created T307093: Create dashboard for first view vs warm cache view.
Thu, Apr 28, 11:20 AM · Performance-Team

Wed, Apr 27

Krinkle awarded T306954: Add more second view (warmcache) tests a Orange Medal token.
Wed, Apr 27, 3:23 PM · Performance-Team
Peter added a comment to T306976: WebPageTest alert 2022-04-27.

Actually the trigger job stopped working, When I upgraded to Chrome 101 also the container was updated to latest Ubuntu at it get these errors:

Wed, Apr 27, 12:43 PM · WebPageTest, Performance-Team
Peter created T306976: WebPageTest alert 2022-04-27.
Wed, Apr 27, 11:35 AM · WebPageTest, Performance-Team
Peter closed T306954: Add more second view (warmcache) tests as Resolved.
Wed, Apr 27, 11:30 AM · Performance-Team
Peter created T306954: Add more second view (warmcache) tests.
Wed, Apr 27, 6:30 AM · Performance-Team

Tue, Apr 26

Peter closed T304583: Add meta data from the run to the page drill down pages as Resolved.

Thank you @colewhite !!!

Tue, Apr 26, 7:35 AM · Performance-Team

Mon, Apr 25

Peter closed T306775: False alerts for WebPageTest in Grafana as Resolved.

All was fixed by recreating the alerts.

Mon, Apr 25, 11:36 AM · WebPageTest, Performance-Team
Peter created T306775: False alerts for WebPageTest in Grafana.
Mon, Apr 25, 6:58 AM · WebPageTest, Performance-Team

Apr 21 2022

Peter closed T306596: Decrease timeout time for WebPageReplay/sitespeed.io tests as Resolved.
Apr 21 2022, 7:19 AM · WebPageReplay, Performance-Team
Peter created T306596: Decrease timeout time for WebPageReplay/sitespeed.io tests.
Apr 21 2022, 6:42 AM · WebPageReplay, Performance-Team

Apr 19 2022

Peter added a comment to T303782: Potential navtiming_responseStart regression as of 13 Mar 2022.

I'll just check Chrome vs Safari on mobile. When 100 rolled out I saw this https://phabricator.wikimedia.org/T305122#7838322 on WebPageTest, probably because of the hidden Chrome bug (https://bugs.chromium.org/p/chromium/issues/detail?id=1293151 ) about optimise AI.

Apr 19 2022, 6:15 PM · serviceops, SRE, Traffic, Performance-Team
Peter added a comment to T304583: Add meta data from the run to the page drill down pages.

@colewhite thank you I missed that. Changed so we proxy http to http.

Apr 19 2022, 5:22 PM · Performance-Team

Apr 11 2022

Peter moved T305547: Pull rate limit hit for synthetic tests from Inbox to Backlog: Maintenance on the Performance-Team board.
Apr 11 2022, 6:47 PM · WebPageReplay, WebPageTest, Performance-Team

Apr 8 2022

Peter added a comment to T305122: Increased Largest Contentful Paint for enwiki emulated mobile with Chrome 100.

There's an upstream bug (that I do not have access to) https://bugs.chromium.org/p/chromium/issues/detail?id=1293151 and then there's some info in this thread: https://twitter.com/_tbansal/status/1493335460331933696

Apr 8 2022, 11:09 AM · WebPageTest, Performance-Team
Peter closed T305681: Chrome User Experience data missing 2022-04-08 as Resolved.
Apr 8 2022, 9:11 AM · Performance-Team
Peter created T305681: Chrome User Experience data missing 2022-04-08.
Apr 8 2022, 9:11 AM · Performance-Team
Peter closed T305122: Increased Largest Contentful Paint for enwiki emulated mobile with Chrome 100 as Resolved.

As reported in T305572 I could see that Chrome makes multiple requests to optimizationguide-pa,googleapis.com. In Browsertime/sitespeed.io those requests are blocked but since we haven't done any update to WebPageTest in a year or more, WebPageTest missed the Chrome flag to turn it off. I can also see that people reported that the requests happen even with the flag enabled so I just added that domain to blocking.

Apr 8 2022, 6:47 AM · WebPageTest, Performance-Team
Peter closed T305572: Desktop performance graph jumped significantly as Resolved.

That fixed the problem:

blocking.jpg (1×2 px, 248 KB)

Apr 8 2022, 6:24 AM · WebPageTest, Performance-Team

Apr 7 2022

Peter added a comment to T305572: Desktop performance graph jumped significantly.

I did push the change now. The Chrome flag I added was --disable-fetching-hints-at-navigation-start and I also blocked that domain to be 100% sure. I'll have a look later tonight and check if it fixed the problem.

Apr 7 2022, 3:35 PM · WebPageTest, Performance-Team
Peter claimed T305572: Desktop performance graph jumped significantly.

I found the root cause by looking at the waterfall graph (the waterfall graph explains how request/responses are handled):

Screenshot 2022-04-07 at 16.23.11.png (1×2 px, 257 KB)

Apr 7 2022, 2:32 PM · WebPageTest, Performance-Team
Peter added a comment to T305122: Increased Largest Contentful Paint for enwiki emulated mobile with Chrome 100.

I could also find a jump in responseEnd but only for emulated mobile:

Screenshot 2022-04-07 at 16.19.57.png (1×2 px, 434 KB)

Apr 7 2022, 2:20 PM · WebPageTest, Performance-Team
Peter added a comment to T305572: Desktop performance graph jumped significantly.

Hi @cjming that seems to correlate when Chrome 100 rolled out on WebPageTest. I found that by using the drill down dashboard for WebPageTest:
https://grafana.wikimedia.org/d/000000057/webpagetest-drilldown?orgId=1&from=1648564576262&to=1648596853128&var-base=sitespeed_io&var-path=webpagetest&var-group=en_wikipedia_org&var-page=_wiki_Barack_Obama&var-browser=&var-location=us-east-chrome&var-connectivity=cable&var-view=firstView and then I zoomed into the time when the change first appeared. Then I click "Show each test" and wait a second. Then the meta data for each test run will load and you will see green vertical line, if you hover on them, you will see a screenshot and browser version (browser version is at the top right). The tests before that test used Chrome 99:

chrome-100.jpg (1×1 px, 216 KB)

Apr 7 2022, 2:01 PM · WebPageTest, Performance-Team
Peter moved T305550: Emulated mobile vs running on real devices from Inbox to Backlog: Maintenance on the Performance-Team board.
Apr 7 2022, 1:51 PM · Performance-Device-Lab, Performance-Team
Peter closed T304882: Add synthetic test from Cape Town as Resolved.

The tests are up and running: https://grafana.wikimedia.org/d/IvAfnmLMk/page-drilldown?orgId=1&var-base=sitespeed_io&var-path=desktopSouthAfrica&var-testtype=firstView&var-group=en_wikipedia_org&var-page=_wiki_Barack_Obama&var-browser=chrome&var-connectivity=native&var-function=median&var-s3path=https:%2F%2Fsynthetic-tests-result-wikimedia.s3.amazonaws.com

Apr 7 2022, 12:34 PM · WebPageTest, Performance-Team
Peter added a comment to T304882: Add synthetic test from Cape Town.

I also added mobile version of those two pages. Let me verify that the tests continues to run through the day and then this is done.

Apr 7 2022, 9:13 AM · WebPageTest, Performance-Team
Peter added a comment to T304882: Add synthetic test from Cape Town.

I deployed a server this morning, we send the result to Graphite and AWS. At the moment we tests https://zu.wikipedia.org/wiki/Ikhasi_Elikhulu https://en.wikipedia.org/wiki/Barack_Obama on native (data centre speed) and cable + I added the login journey so we can see the difference against running in US. I'll also add some emulated desktop tests for completeness.

Apr 7 2022, 8:35 AM · WebPageTest, Performance-Team
Peter changed the status of T279572: Evaluate doing Android performance test using a Raspberry Pi from Open to Stalled.

Needs T278172 to be able to move on.

Apr 7 2022, 7:05 AM · Performance-Team, Performance-Device-Lab
Peter closed T269665: Setup performance alerts in Grafana for tests running on the performance device lab as Resolved.

That was done for Kobiton.

Apr 7 2022, 7:03 AM · Performance-Team, Performance-Device-Lab
Peter added a comment to T269201: Test running Samsung Internet browser performance tests.

And I've pinged them again.

Apr 7 2022, 7:03 AM · Upstream, Performance-Team, Performance-Device-Lab
Peter closed T267005: Search on mobile sometimes pick up too early first visual change as Declined.

I think this was something wrong with Kobitons setup, this works just fine on my own setup and for Mozilla.

Apr 7 2022, 7:02 AM · Performance-Team, Performance-Device-Lab
Peter closed T264317: Review performance tests outcome as Resolved.

That was done when things where running on Kobiton.

Apr 7 2022, 7:01 AM · Performance-Team, Performance-Device-Lab
Peter closed T263285: Write test result to tmp dir as Declined.

No need to fix this until we have something up and running again.

Apr 7 2022, 7:00 AM · Performance-Team, Performance-Device-Lab
Peter closed T252013: Compare stability in performance metrics using a rooted vs normal device as Declined.

Lets do this if we are feel running with our root get us to unstable metrics.

Apr 7 2022, 6:56 AM · Performance-Device-Lab, Performance-Team
Peter closed T251873: Document how to setup your phone for performance testing as Declined.

I created https://www.sitespeed.io/documentation/sitespeed.io/mobile-phones/#on-your-phone a couple of years ago. When we push a new device lab, we can add our own docs following that example.

Apr 7 2022, 6:55 AM · Performance-Device-Lab, Documentation, Performance-Team

Apr 6 2022

Peter added a comment to T305544: WebPageTest tests stopped working 2022-04-05.

Also I got the alarm email but I missed it.

Apr 6 2022, 1:52 PM · WebPageTest, Performance-Team
Peter created T305550: Emulated mobile vs running on real devices.
Apr 6 2022, 1:40 PM · Performance-Device-Lab, Performance-Team
Peter created T305547: Pull rate limit hit for synthetic tests.
Apr 6 2022, 11:20 AM · WebPageReplay, WebPageTest, Performance-Team
Peter closed T305544: WebPageTest tests stopped working 2022-04-05 as Resolved.
Apr 6 2022, 11:16 AM · WebPageTest, Performance-Team
Peter added a comment to T305544: WebPageTest tests stopped working 2022-04-05.

The problem is the worker that kicks off the jobs:

Apr 6 2022, 11:02 AM · WebPageTest, Performance-Team
Peter created T305544: WebPageTest tests stopped working 2022-04-05.
Apr 6 2022, 10:54 AM · WebPageTest, Performance-Team
Peter closed T248603: Add WebPageTest agent and open for submitting tests through the GUI as Declined.

We will not do this now since the change of license.

Apr 6 2022, 7:15 AM · WebPageTest, Performance-Team
Peter closed T263838: Fix 7 days limits in search for WebPageTest as Resolved.

I hacked this again setting the limit to 100 days. I don't think we should do an upstream fix,

Apr 6 2022, 7:15 AM · WebPageTest, Performance-Team
Peter closed T298945: Investigate false WebPageTest LCP alerts as Declined.

This has been fixed but nothing done at our side.

Apr 6 2022, 7:07 AM · Performance-Team (Radar), WebPageTest
Peter closed T265519: Verify bulk test documentation as Declined.

Lets do this if its ever needed again, no need to spend time on that now.

Apr 6 2022, 7:06 AM · Documentation, WebPageTest, Performance-Team
Peter closed T262962: Move the WebPageTest server in-house as Declined.

Since the change of the license of WebPageTest to a non open source license, this is nothing we want to do.

Apr 6 2022, 7:05 AM · Patch-For-Review, Performance-Team, WebPageTest
Peter closed T242544: Investigate increase for start render enwiki mobile 2020-01-09 as Declined.

Long time overdue, nothing to do here now.

Apr 6 2022, 7:04 AM · WebPageTest, Performance-Team