Page MenuHomePhabricator

Peter (Peter Hedenskog)
Software Engineer, Wikimedia Foundation

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 17 2015, 6:48 PM (217 w, 2 d)
Availability
Available
IRC Nick
phedenskog
LDAP User
Unknown
MediaWiki User
PHedenskog (WMF) [ Global Accounts ]

Recent Activity

Today

Peter triaged T235647: Document the new Graphite setup as Normal priority.
Thu, Oct 17, 8:05 AM · Documentation, Performance-Team
Peter triaged T235729: CORS and use HTTPS endpoint for the new setup as Normal priority.
Thu, Oct 17, 8:05 AM · Performance-Team
Peter added a comment to T235729: CORS and use HTTPS endpoint for the new setup.

I've setup CORS for grafana.wikimedia.org, compare.sitespeed.io (do we want to host our own version?) and the temporary Grafana instance that I've been using to test the setup.

Thu, Oct 17, 7:57 AM · Performance-Team
Peter added a comment to T235729: CORS and use HTTPS endpoint for the new setup.

I've changed configuration and restarted the tests, let me test later today that it really woks.

Thu, Oct 17, 7:17 AM · Performance-Team
Peter renamed T235729: CORS and use HTTPS endpoint for the new setup from CORRS and use HTTPS endpoint for the new setup to CORS and use HTTPS endpoint for the new setup.
Thu, Oct 17, 6:33 AM · Performance-Team
Peter created T235729: CORS and use HTTPS endpoint for the new setup.
Thu, Oct 17, 6:31 AM · Performance-Team

Yesterday

Peter created T235647: Document the new Graphite setup.
Wed, Oct 16, 1:25 PM · Documentation, Performance-Team
Peter triaged T235595: Test running Firefox performance tests on Android as Low priority.
Wed, Oct 16, 11:33 AM · Performance-Team
Peter added a comment to T235595: Test running Firefox performance tests on Android.

I did a quick try with the extra parameters in the release doc, but no luck, it seems that Geckodriver can't connect. Lets wait until Mozilla add some more examples to the documentation.

Wed, Oct 16, 8:19 AM · Performance-Team
Peter triaged T235604: Send errors to IRC for the new synthetic testing setup as Normal priority.
Wed, Oct 16, 8:17 AM · WebPageReplay, WebPageTest, Performance-Team
Peter created T235604: Send errors to IRC for the new synthetic testing setup.
Wed, Oct 16, 8:17 AM · WebPageReplay, WebPageTest, Performance-Team
Peter created T235601: Compress and change image format on photos on wikimediafoundation.org.
Wed, Oct 16, 7:50 AM · wikimediafoundation.org
Peter added a comment to T235195: Fresnel 0.5.0 release and deploy.

I think in the future we should aim for updating the browser without any code changes. Even though we test the change against the same browser version, I think it would be cool to separate release since the browser changes is out of our control. We can just roll out the new browser version when its released?

Wed, Oct 16, 6:37 AM · Performance-Team, Fresnel
Peter created T235595: Test running Firefox performance tests on Android.
Wed, Oct 16, 6:24 AM · Performance-Team

Tue, Oct 15

Peter claimed T235195: Fresnel 0.5.0 release and deploy.
Tue, Oct 15, 8:05 PM · Performance-Team, Fresnel
Peter added a comment to T233789: Investigate inconsistent server response time in WebPageReplay.

I looked at the graphs and it looks like this happens when we run emulated mobile both using WebPageReplay and without replaying (so the problem is not WebPageReplay). We use tc in both cases (but for WPR we only use latency on localhost). I couldn't see anything in the desktop tests.

Tue, Oct 15, 7:00 PM · Performance-Team, WebPageReplay
Peter added a comment to T230708: Performance review of new foundation website design.

First Visual Change looks ok, we had some higher metrics that correlates to higher TTFB:

Tue, Oct 15, 5:53 PM · Performance-Team
Peter triaged T234838: Test out small variance (2%) in latency for our test as Normal priority.
Tue, Oct 15, 4:41 PM · WebPageReplay, Performance-Team
Peter closed T235407: Search from Google using Firefox doesn't work in the new test setup as Resolved.

This works now:

Tue, Oct 15, 9:33 AM · Performance-Team
Peter closed T235407: Search from Google using Firefox doesn't work in the new test setup, a subtask of T234414: Measure user journeys, as Resolved.
Tue, Oct 15, 9:33 AM · Performance-Team

Mon, Oct 14

Peter added a comment to T231870: Add new Graphite instance in Grafana.

If we could get help to fix that would be super (its hard for me to know how much work it is)? When it's done we can proceed and add automatic performance alerts for all the wikis we test and we also need to redo the dashboards we have but the good thing is that it will give us more insights.

Mon, Oct 14, 12:30 PM · Patch-For-Review, observability, Performance-Team
Peter added a comment to T235407: Search from Google using Firefox doesn't work in the new test setup.

I pushed this now it works on my local machine but lets make sure it works on our test server until I close the issue.

Mon, Oct 14, 12:17 PM · Performance-Team
Peter created T235407: Search from Google using Firefox doesn't work in the new test setup.
Mon, Oct 14, 7:56 AM · Performance-Team
Peter added a comment to T235092: Visible glitch when switching page (flushCssBuffer makes the page blink at every page change).

I'm not sure but on WebPageTest we got the full screen donate at around the same time so maybe it's related?

Mon, Oct 14, 6:45 AM · Readers-Web-Backlog, Performance-Team (Radar), MobileFrontend
Peter closed T235367: Investigate grey area on mobile as Resolved.

We catched that on some runs on WebPageReplay using last visual change:

Mon, Oct 14, 6:37 AM · Performance-Team

Sun, Oct 13

Peter added a comment to T235367: Investigate grey area on mobile.

I've tested it some more and could reproduce (added my info in T235092). We could have seen this looking at Last Visual Change, but we have no alerts on that. Let me look into that more tomorrow. Then after that we can close this as an duplicate.

Sun, Oct 13, 6:52 PM · Performance-Team
Peter added a comment to T235092: Visible glitch when switching page (flushCssBuffer makes the page blink at every page change).

I could reproduce this on my Mac on Safari (13.0.2) on https://en.m.wikipedia.org/wiki/Barack_Obama and also on Firefox 70.0b14. Attaching a video of what it looks like.

Sun, Oct 13, 6:50 PM · Readers-Web-Backlog, Performance-Team (Radar), MobileFrontend
Peter created T235367: Investigate grey area on mobile.
Sun, Oct 13, 7:04 AM · Performance-Team

Fri, Oct 11

Peter closed T235256: WebPageTest tests stopped working 5 Oct as Resolved.

It works now. I've enabled network traffic alerts, so if there's no traffic going out from the machine during two hours, the alert will fire.

Fri, Oct 11, 8:13 PM · Performance-Team, WebPageTest
Peter added a comment to T233571: Get MediaWiki version in synthetic testing.

Yes thanks, it's the same as the generator tag right? I've added that but hasn't pushed it yet.

Fri, Oct 11, 8:11 PM · WebPageTest, WebPageReplay, Performance-Team
Peter added a comment to T235256: WebPageTest tests stopped working 5 Oct.

Now it works again:

Fri, Oct 11, 12:03 PM · Performance-Team, WebPageTest
Peter added a comment to T235256: WebPageTest tests stopped working 5 Oct.

Tests come through but no data:

Fri, Oct 11, 11:11 AM · Performance-Team, WebPageTest
Peter added a comment to T235256: WebPageTest tests stopped working 5 Oct.

Right after I emptied the queue we got 200 new jobs, that seems like very many, I don't how they got there? I could see though that a job went through. I emptied the queue again.

Fri, Oct 11, 10:30 AM · Performance-Team, WebPageTest
Peter added a comment to T235256: WebPageTest tests stopped working 5 Oct.

Couldn't see any change in the commits for WPT around that time (and one agent work). The queue:

Fri, Oct 11, 10:17 AM · Performance-Team, WebPageTest
Peter created T235256: WebPageTest tests stopped working 5 Oct.
Fri, Oct 11, 10:13 AM · Performance-Team, WebPageTest

Thu, Oct 10

Peter added a comment to T214460: Add synthetic testing for editing process (save timing).

I've started this again, trying to make a more sane script that works. I can go through the full scenario on beta and we need to find a way to get the important metric(s).

Thu, Oct 10, 9:29 AM · Performance-Team
Peter moved T214460: Add synthetic testing for editing process (save timing) from Backlog: Future Goals to Doing on the Performance-Team board.
Thu, Oct 10, 6:39 AM · Performance-Team

Mon, Oct 7

Peter moved T234838: Test out small variance (2%) in latency for our test from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Mon, Oct 7, 7:57 PM · WebPageReplay, Performance-Team
Peter moved T234414: Measure user journeys from Inbox to Doing on the Performance-Team board.
Mon, Oct 7, 7:37 PM · Performance-Team
Peter created T234838: Test out small variance (2%) in latency for our test.
Mon, Oct 7, 4:57 PM · WebPageReplay, Performance-Team
Peter added a comment to T218618: Consider disabling Chrome Lite pages for Wikipedia on Chrome on mobile with Cache-Control: no-transform.

Wanted to add one concern that I raised in the upstream issue for Chromium: There's a risk that the lite pages gives our user worse performance and lock in the user in the Google universe. Let me explain.

Mon, Oct 7, 7:13 AM · Performance-Team (Radar), WMF-Legal, Security-Team, Privacy

Fri, Oct 4

Jdlrobson awarded T234599: Flash of MinervaNeue empty main menu animation on page load a Orange Medal token.
Fri, Oct 4, 10:23 PM · Performance-Team (Radar), Readers-Web-Backlog, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), WebPageReplay
Peter closed T234599: Flash of MinervaNeue empty main menu animation on page load as Resolved.

The Speed Index is back to normal

and no grey flash in the screenshots.

Fri, Oct 4, 9:47 PM · Performance-Team (Radar), Readers-Web-Backlog, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), WebPageReplay
Peter added a comment to T234599: Flash of MinervaNeue empty main menu animation on page load.

It looks good now, thank you @Jdlrobson for fixing it so fast!

Fri, Oct 4, 9:45 PM · Performance-Team (Radar), Readers-Web-Backlog, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), WebPageReplay
Peter added a comment to T234599: Flash of MinervaNeue empty main menu animation on page load.

FYI: I could reproduce this in both Safari and Chrome. Using devtools in Chrome I could record a timeline and then see the grey box in the screenshots in the trace.

Fri, Oct 4, 9:41 AM · Performance-Team (Radar), Readers-Web-Backlog, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), WebPageReplay
Peter created T234599: Flash of MinervaNeue empty main menu animation on page load.
Fri, Oct 4, 7:05 AM · Performance-Team (Radar), Readers-Web-Backlog, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), WebPageReplay

Thu, Oct 3

Peter triaged T226182: Alerts fired for SpeedIndex on mobile even though we should check for mwCentralNoticeBanner as Normal priority.
Thu, Oct 3, 11:29 AM · Performance-Team, WebPageTest
Peter triaged T225987: Create runbook on what to do when we get an alert as Normal priority.
Thu, Oct 3, 11:29 AM · WebPageTest, WebPageReplay, Performance-Team
Peter triaged T225416: Unify synthetic testing scripts as High priority.
Thu, Oct 3, 11:29 AM · Patch-For-Review, WebPageReplay, WebPageTest, Performance-Team
Peter triaged T224896: Deploy and test WebPageTest agent in Cape Town (early 2020) as Normal priority.
Thu, Oct 3, 11:28 AM · Performance-Team, WebPageTest
Peter triaged T224427: Compare performance against Alexa top 10 as Normal priority.
Thu, Oct 3, 11:28 AM · Performance-Team
Peter triaged T223103: Make it easy for developers to add new URLs to continously test as Normal priority.
Thu, Oct 3, 11:28 AM · WebPageTest, WebPageReplay, Performance-Team
Peter closed T223101: Measure most common use case for users as Resolved.

Implemented in T234414

Thu, Oct 3, 11:28 AM · WebPageTest, Performance-Team
Peter closed T222565: Throttle the CPU for mobile testing as Resolved.

This is done for the new setup.

Thu, Oct 3, 11:27 AM · WebPageReplay, Performance-Team
Peter triaged T233191: Images on upload aren't replayed correctly on WebPageReplay as Normal priority.
Thu, Oct 3, 11:26 AM · Patch-For-Review, WebPageReplay, Performance-Team
Peter triaged T233417: Deploy a version of navtiming or coal as Normal priority.
Thu, Oct 3, 11:26 AM · Performance-Team
Peter triaged T233571: Get MediaWiki version in synthetic testing as Normal priority.
Thu, Oct 3, 11:26 AM · WebPageTest, WebPageReplay, Performance-Team
Peter triaged T233712: Compare performance between a low spec Android Go phone and a recent iPhone as Normal priority.
Thu, Oct 3, 11:26 AM · Performance-Team
Peter triaged T233789: Investigate inconsistent server response time in WebPageReplay as Normal priority.
Thu, Oct 3, 11:26 AM · Performance-Team, WebPageReplay
Peter triaged T233686: Update WebPageReplay to latest versions as Normal priority.
Thu, Oct 3, 11:25 AM · Upstream, Performance-Team, WebPageReplay
Peter triaged T233803: Really late Last Visual Change for some URLs on emulated mobile WebPageReplay as Normal priority.
Thu, Oct 3, 11:25 AM · WebPageReplay, Performance-Team
Peter triaged T234138: Page size and DOM note count missing for some WPT runs (wikidatawiki & beta) as Normal priority.
Thu, Oct 3, 11:25 AM · WebPageTest, Performance-Team
Peter triaged T234414: Measure user journeys as Normal priority.
Thu, Oct 3, 11:10 AM · Performance-Team
Peter added a comment to T231870: Add new Graphite instance in Grafana.

Thank you @CDanis . I need to open up traffic for the Graphite server security group on AWS, what would be the correct IP to open for? Is that enough security or should I add something more?

Thu, Oct 3, 9:34 AM · Patch-For-Review, observability, Performance-Team

Wed, Oct 2

Peter updated subscribers of T231870: Add new Graphite instance in Grafana.

@CDanis I wanna try add an external Graphite data source but I don't have sufficient privileges in Grafana admin to add data a sources. I would wanna try it that way so I can see that it works (need to fine tune the security group for that instance so traffic can come through). Can you give me access or what's the correct way to do it?

Wed, Oct 2, 1:18 PM · Patch-For-Review, observability, Performance-Team
Peter created T234414: Measure user journeys.
Wed, Oct 2, 7:42 AM · Performance-Team

Mon, Sep 30

Peter moved T233686: Update WebPageReplay to latest versions from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Mon, Sep 30, 8:24 PM · Upstream, Performance-Team, WebPageReplay
Peter moved T233712: Compare performance between a low spec Android Go phone and a recent iPhone from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Mon, Sep 30, 8:23 PM · Performance-Team
Peter moved T233789: Investigate inconsistent server response time in WebPageReplay from Inbox to Doing on the Performance-Team board.
Mon, Sep 30, 8:17 PM · Performance-Team, WebPageReplay
Peter moved T233803: Really late Last Visual Change for some URLs on emulated mobile WebPageReplay from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Mon, Sep 30, 8:17 PM · WebPageReplay, Performance-Team
Peter moved T234103: Try performance tune one of the AWS instances from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Mon, Sep 30, 8:06 PM · WebPageReplay, Performance-Team
Peter moved T234138: Page size and DOM note count missing for some WPT runs (wikidatawiki & beta) from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Mon, Sep 30, 8:06 PM · WebPageTest, Performance-Team
Peter added a comment to T234138: Page size and DOM note count missing for some WPT runs (wikidatawiki & beta).

I couldn't see anything on the server side when I looked earlier today. I'm trying to finish off the move to the new setup and then it will work, hopefully I can finish that this week and then starting to change server by server.

Mon, Sep 30, 6:47 PM · WebPageTest, Performance-Team
Peter closed T234177: How to trigger WebPageTest runs, a subtask of T225416: Unify synthetic testing scripts, as Resolved.
Mon, Sep 30, 11:10 AM · Patch-For-Review, WebPageReplay, WebPageTest, Performance-Team
Peter closed T234177: How to trigger WebPageTest runs as Resolved.

I've deployed a small instance earlier today and it seems to work fine.

Mon, Sep 30, 11:10 AM · WebPageTest, Performance-Team
Peter created T234177: How to trigger WebPageTest runs.
Mon, Sep 30, 7:02 AM · WebPageTest, Performance-Team
Peter added a comment to T234103: Try performance tune one of the AWS instances.

It didn't make our WebPageReplay metrics more stable, rather it introduced higher standard deviation (the blue vertical line is when I did the change):

Mon, Sep 30, 6:36 AM · WebPageReplay, Performance-Team

Sun, Sep 29

Peter added a comment to T233746: Add device memory usage metric to Fresnel reports.

I've been tracking JSHeap for a while (but I haven't looked at it) and it looks like it will hard to use to see any changes because the metrics is going up and down. Here's two examples one for mobile and one desktop and I guess if we do a change it needs to big for us to see it.

Sun, Sep 29, 8:10 AM · Fresnel, Performance-Team

Sat, Sep 28

Peter added a comment to T234138: Page size and DOM note count missing for some WPT runs (wikidatawiki & beta).

I think this is a problem with how we send the data through statsv. When I did the update, we started to send more metrics because that pull enabled "hero" metrics again.

Sat, Sep 28, 8:28 PM · WebPageTest, Performance-Team
Peter claimed T234138: Page size and DOM note count missing for some WPT runs (wikidatawiki & beta).

Hmm that match when I updated the server the last time (running git pull), let me look into it.

Sat, Sep 28, 8:20 PM · WebPageTest, Performance-Team
Peter added a comment to T233789: Investigate inconsistent server response time in WebPageReplay.

No the throttling was not the cause, we still get the same after the change:

Sat, Sep 28, 11:40 AM · Performance-Team, WebPageReplay
Peter added a comment to T234103: Try performance tune one of the AWS instances.

I've added these settings for now:

Sat, Sep 28, 8:39 AM · WebPageReplay, Performance-Team

Fri, Sep 27

Peter created T234103: Try performance tune one of the AWS instances.
Fri, Sep 27, 9:16 PM · WebPageReplay, Performance-Team

Thu, Sep 26

Peter moved T233417: Deploy a version of navtiming or coal from Backlog: Small & Maintenance to Doing on the Performance-Team board.
Thu, Sep 26, 7:31 PM · Performance-Team
Peter added a comment to T148047: Desktop MediaWiki should be able to lazy load images.

I think it would be really interesting to try this on one wiki for a short while and measure what kind of win it will make in number of bytes. If we can show the numbers, it would be easier to talk to Chrome to put prio on the solution for printing?

Thu, Sep 26, 2:17 PM · Performance-Team (Radar), Readers-Web-Backlog (Tracking), MediaWiki-Parser, Epic
Peter added a comment to T233712: Compare performance between a low spec Android Go phone and a recent iPhone.

I ordered a Android Go phone today and can start run some tests early next week.

Thu, Sep 26, 11:46 AM · Performance-Team

Wed, Sep 25

Peter created T233803: Really late Last Visual Change for some URLs on emulated mobile WebPageReplay.
Wed, Sep 25, 12:35 PM · WebPageReplay, Performance-Team
Peter closed T233726: Collect and graph stdev for all timing metrics, a subtask of T225416: Unify synthetic testing scripts, as Resolved.
Wed, Sep 25, 12:22 PM · Patch-For-Review, WebPageReplay, WebPageTest, Performance-Team
Peter closed T233726: Collect and graph stdev for all timing metrics as Resolved.

It's there now for both Browsertime and WebPageTest

Wed, Sep 25, 12:22 PM · WebPageReplay, WebPageTest, Performance-Team
Peter closed T233799: WebPageTest missed out on Hero timings, a subtask of T225416: Unify synthetic testing scripts, as Resolved.
Wed, Sep 25, 12:20 PM · Patch-For-Review, WebPageReplay, WebPageTest, Performance-Team
Peter closed T233799: WebPageTest missed out on Hero timings as Resolved.
Wed, Sep 25, 12:20 PM · WebPageTest, Performance-Team
Peter added a comment to T233799: WebPageTest missed out on Hero timings.

Fixed:

Wed, Sep 25, 12:19 PM · WebPageTest, Performance-Team
Peter added a comment to T233799: WebPageTest missed out on Hero timings.

So our old instance was also missing out on them. I checked the new config (you can turn them on now) and it was there. I've updated the WebPageTest server that hasn't been updated in a while, lets see if that fixes things.

Wed, Sep 25, 12:02 PM · WebPageTest, Performance-Team
Peter created T233799: WebPageTest missed out on Hero timings.
Wed, Sep 25, 11:35 AM · WebPageTest, Performance-Team
Peter added a comment to T231854: Prepare speak for WeLoveSpeed.

https://speakerdeck.com/soulislove/keeping-wikipedia-fast-welovespeed

Wed, Sep 25, 11:33 AM · Performance-Team
Peter closed T231854: Prepare speak for WeLoveSpeed as Resolved.
Wed, Sep 25, 11:32 AM · Performance-Team
Peter added a comment to T233746: Add device memory usage metric to Fresnel reports.

So we should be able to use Chrome devtools protocol to get that, there we have JSHeapUsedSize and .JSHeapTotalSize. Or what do you think @Krinkle ?

Wed, Sep 25, 11:14 AM · Fresnel, Performance-Team
Peter added a project to T233686: Update WebPageReplay to latest versions: Upstream.

Upstream: https://github.com/cpuguy83/go-md2man/issues/54

Wed, Sep 25, 10:15 AM · Upstream, Performance-Team, WebPageReplay
Peter added a project to T233789: Investigate inconsistent server response time in WebPageReplay: Performance-Team.
Wed, Sep 25, 9:55 AM · Performance-Team, WebPageReplay
Peter added a comment to T233789: Investigate inconsistent server response time in WebPageReplay.

This only happens on the mobile tests, not dekstop. We set the same latency so I guess then it shouldn't be tc that's the problem. Maybe not even WebPageReplay. One thing that is different is that we run Chromes "CPU Throttle" at rate 5 for mobile, we don't do that for desktop. That's the only difference I can come up with.

Wed, Sep 25, 9:50 AM · Performance-Team, WebPageReplay