Peter (Peter Hedenskog)
Software Engineer, Wikimedia Foundation

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 17 2015, 6:48 PM (152 w, 6 d)
Availability
Available
IRC Nick
phedenskog
LDAP User
Unknown
MediaWiki User
PHedenskog (WMF) [ Global Accounts ]

Recent Activity

Fri, Jun 29

Peter committed rPPER0f5acd3f9909: Move perfromance to our own git repo (authored by Peter).
Move perfromance to our own git repo
Fri, Jun 29, 5:26 AM
Peter moved T195232: Blog post: How we use WebPageTest from Doing to Next-up on the Performance-Team board.
Fri, Jun 29, 5:15 AM · WebPageTest, Performance-Team
Peter moved T195231: Blog post: Explain synthetic testing from Doing to Next-up on the Performance-Team board.
Fri, Jun 29, 5:15 AM · Performance-Team
Peter moved T159668: WebPageTest private server loads assets from Google from Doing to Next-up on the Performance-Team board.
Fri, Jun 29, 5:15 AM · Performance-Team, Upstream, WebPageTest
Peter moved T196600: Move browsertime/WebPageReplay repos to Wikimedia from Doing to Next-up on the Performance-Team board.
Fri, Jun 29, 5:15 AM · Performance-Team
Peter closed T196899: [Bug] Missing WebPagetest metrics after June 5th 17:00 as Resolved.
Fri, Jun 29, 5:14 AM · Patch-For-Review, WebPageTest, Performance-Team, Readers-Web-Backlog (Tracking), Regression
Peter added a comment to T197847: Collect performance metrics from a mobile over time.

Checked our current runs with WPT (https://www.webpagetest.org/results.php?test=180629_3X_4f6991429e1eef066370d00dfe773740&medianRun=fastest&medianMetric=SpeedIndex)

Fri, Jun 29, 5:13 AM · Performance-Team
Peter committed rPPER610903dcd569: Move perfromance to our own git repo (authored by Peter).
Move perfromance to our own git repo
Fri, Jun 29, 5:00 AM
Peter committed rPPER5f4b4c1a2e4d: Move perfromance to our own git repo (authored by Peter).
Move perfromance to our own git repo
Fri, Jun 29, 4:55 AM
Peter committed rPPER7190769a1460: Move perfromance to our own git repo (authored by Peter).
Move perfromance to our own git repo
Fri, Jun 29, 4:55 AM
Peter closed T197799: Add performance test for more wikis than enwiki as Resolved.

Added alerts for beta, group 0 and group 1. Let me follow up with T198287.

Fri, Jun 29, 4:35 AM · Performance-Team
Peter moved T198287: Add alerts for all Browsertime/WebPageReplay wikis from Inbox to Next-up on the Performance-Team board.
Fri, Jun 29, 4:34 AM · Performance-Team
Peter added a comment to T198287: Add alerts for all Browsertime/WebPageReplay wikis.

I can do this after the vacation, lets think about, could there be a smarter way to do the alerts, instead of creating a dashboard for each? Templates aren't supported for alerts at the moment in Grafana.

Fri, Jun 29, 4:19 AM · Performance-Team
Peter updated the task description for T198287: Add alerts for all Browsertime/WebPageReplay wikis.
Fri, Jun 29, 4:18 AM · Performance-Team
Peter added a comment to T198287: Add alerts for all Browsertime/WebPageReplay wikis.

We have alerts for enwiki, beta, group 0 and group 1.

Fri, Jun 29, 4:14 AM · Performance-Team

Thu, Jun 28

Peter created T198394: Change viewport for desktop tests (Browsertime and WebPageTest).
Thu, Jun 28, 12:43 PM · WebPageTest, Performance-Team
Peter added a comment to T198287: Add alerts for all Browsertime/WebPageReplay wikis.

Updated today and will add the last one tomorrow. Updated the docs: https://wikitech.wikimedia.org/wiki/Performance/WebPageReplay/Alerts

Thu, Jun 28, 12:35 PM · Performance-Team

Wed, Jun 27

Peter moved T144786: Switch fetching image size to use ResourceTiming API from Inbox to Radar on the Performance-Team board.
Wed, Jun 27, 9:17 AM · Performance-Team (Radar), Upstream, PerformanceInspector
Peter triaged T198287: Add alerts for all Browsertime/WebPageReplay wikis as Normal priority.
Wed, Jun 27, 9:08 AM · Performance-Team
Peter added a comment to T197983: Update design/look and feel on WebPageReplay results.

First part of this is fixed, let me close this task when I push the repo and then I can add follow ups for more ideas.

Wed, Jun 27, 9:06 AM · Performance-Team

Tue, Jun 26

Peter added a comment to T144786: Switch fetching image size to use ResourceTiming API.

No I was actually wrong: 304 works but if they are in the cache and no request is done, nothing happens.

Tue, Jun 26, 6:47 AM · Performance-Team (Radar), Upstream, PerformanceInspector
Peter added a comment to T144786: Switch fetching image size to use ResourceTiming API.

I tested now and it it seems to work in the FF60, I'll ping the upstream issue.

Tue, Jun 26, 6:44 AM · Performance-Team (Radar), Upstream, PerformanceInspector

Sat, Jun 23

Peter closed T198001: Update documentation for the new Browsertime/WebPageReplay setup as Resolved.

Updated https://wikitech.wikimedia.org/wiki/Performance/WebPageReplay

Sat, Jun 23, 1:55 PM · Documentation, Performance-Team
Peter closed T198001: Update documentation for the new Browsertime/WebPageReplay setup, a subtask of T197799: Add performance test for more wikis than enwiki, as Resolved.
Sat, Jun 23, 1:55 PM · Performance-Team
Peter added a comment to T197948: Missing (all) us east metrics in WebPageTest.

Also I added alarms if there are no network traffic for the instance, that should let us know if this happens again.

Sat, Jun 23, 9:12 AM · Performance-Team, WebPageTest
Peter created T198001: Update documentation for the new Browsertime/WebPageReplay setup.
Sat, Jun 23, 7:44 AM · Documentation, Performance-Team

Jun 22 2018

Peter added a comment to T197983: Update design/look and feel on WebPageReplay results.

We could also try to incorporate https://chromedevtools.github.io/timeline-viewer/?loadTimelineFromURL=https://webpagereplay-wikimedia.s3.us-east-1.amazonaws.com/zhwiki/mobile/chrome/50/Stockholm/2018-06-22-19-49/trace-5.json.gz (but it seems it cant handle zipped files).

Jun 22 2018, 8:22 PM · Performance-Team
Peter created T197983: Update design/look and feel on WebPageReplay results.
Jun 22 2018, 8:15 PM · Performance-Team
Peter moved T197799: Add performance test for more wikis than enwiki from Inbox to Doing on the Performance-Team board.
Jun 22 2018, 8:12 PM · Performance-Team
Peter closed T197761: Make better use of WebPageTest mobile tests as Resolved.

Done let us keep a close watch on https://grafana.wikimedia.org/dashboard/db/webpagetest-drilldown?orgId=1&var-wiki=enwiki-mobile&var-users=anonymous&var-page=Facebook&var-location=Dulles&var-browser=Motorola_G_-_Chrome&var-view=firstView

Jun 22 2018, 8:11 PM · Patch-For-Review, Performance-Team, WebPageTest
Peter closed T197788: Add tests for beta on WebPageReplay as Resolved.

Fixed this yesterday and also adding group0 and group1 https://grafana.wikimedia.org/dashboard/db/webpagereplay

Jun 22 2018, 8:10 PM · Performance-Team
Peter added a comment to T197799: Add performance test for more wikis than enwiki.

I've did this today. 3 URLs on desktop, 3 on mobile testing with Chrome and emulated mobile. Not using Firefox at the moment but lets see it looks like we can turn that on too.

Jun 22 2018, 8:09 PM · Performance-Team
Peter closed T175240: Set up a second permanent WebPageTest agent as Resolved.

I've installed to new c4.large and pushed beta/group0/group1 on one and five country wikis in the other, but using browsertime/webpagereplay to better pinpoint problems and I think that if we have some regional problem, we catch that with RUM.

Jun 22 2018, 8:06 PM · WebPageTest, Performance-Team
Peter created T197950: Upgrade WebPageTest server.
Jun 22 2018, 1:12 PM · WebPageTest, Performance-Team
Peter closed T197948: Missing (all) us east metrics in WebPageTest as Resolved.

I've stopped it, waiting for it to really stop, then starting it again and it works again.

Jun 22 2018, 1:09 PM · Performance-Team, WebPageTest
Peter triaged T197948: Missing (all) us east metrics in WebPageTest as High priority.
Jun 22 2018, 1:05 PM · Performance-Team, WebPageTest
Peter added a comment to T197948: Missing (all) us east metrics in WebPageTest.

On Jenkins we get errors like this:

12:23:39 Failing test: { Error: read ECONNRESET
12:23:39     at exports._errnoException (util.js:1018:11)
12:23:39     at TCP.onread (net.js:568:26)
12:23:39   cause: 
12:23:39    { Error: read ECONNRESET
12:23:39        at exports._errnoException (util.js:1018:11)
12:23:39        at TCP.onread (net.js:568:26) code: 'ECONNRESET', errno: 'ECONNRESET', syscall: 'read' },
12:23:39   isOperational: true,
12:23:39   code: 'ECONNRESET',
12:23:39   errno: 'ECONNRESET',
12:23:39   syscall: 'read' }
Jun 22 2018, 12:52 PM · Performance-Team, WebPageTest
Peter created T197948: Missing (all) us east metrics in WebPageTest.
Jun 22 2018, 12:50 PM · Performance-Team, WebPageTest

Jun 21 2018

Peter closed T104902: Refactor Navigation Timing gathering to produce reliable stackable measures as Resolved.

I've changed to medians and changed all navigation timing dashboards to use navtiming2 instead of navtiming.

Jun 21 2018, 9:50 AM · MediaWiki-extensions-NavigationTiming, Performance-Team
Peter closed T104902: Refactor Navigation Timing gathering to produce reliable stackable measures, a subtask of T99060: Create a dashboard of key user-centric performance metrics, as Resolved.
Jun 21 2018, 9:50 AM · Performance-Team
Peter created T197847: Collect performance metrics from a mobile over time.
Jun 21 2018, 8:29 AM · Performance-Team

Jun 20 2018

Peter added a comment to T193719: Pick up DOMComplete and send to Graphite.

So the message looked like this:

Jun 20 2018, 2:56 PM · Performance-Team, WebPageTest
Peter created T197799: Add performance test for more wikis than enwiki.
Jun 20 2018, 2:25 PM · Performance-Team
Peter triaged T197788: Add tests for beta on WebPageReplay as Normal priority.
Jun 20 2018, 11:47 AM · Performance-Team
Peter created T197788: Add tests for beta on WebPageReplay.
Jun 20 2018, 11:47 AM · Performance-Team
Peter triaged T196600: Move browsertime/WebPageReplay repos to Wikimedia as Normal priority.
Jun 20 2018, 10:36 AM · Performance-Team
Peter triaged T196242: Chrome 67 performance regression as Normal priority.
Jun 20 2018, 10:36 AM · Performance-Team (Radar), Upstream
Peter triaged T196312: Fine tune WebPageTest alerts as Normal priority.
Jun 20 2018, 10:35 AM · WebPageTest, Performance-Team
Peter triaged T197761: Make better use of WebPageTest mobile tests as Normal priority.
Jun 20 2018, 8:41 AM · Patch-For-Review, Performance-Team, WebPageTest
Peter added a comment to T197761: Make better use of WebPageTest mobile tests.

For future reference:


Jun 20 2018, 8:10 AM · Patch-For-Review, Performance-Team, WebPageTest
Peter created T197761: Make better use of WebPageTest mobile tests.
Jun 20 2018, 8:02 AM · Patch-For-Review, Performance-Team, WebPageTest

Jun 14 2018

Peter added a comment to T191617: Mobile performance testing alternatives.

I tried this some more but I couldn't get that to work, so this is something we need to address if we want to implement something like doing mobile performance tests on commits.

Jun 14 2018, 7:24 AM · Performance-Team
Peter closed T195248: Test out performance testing on Saucelabs as Resolved.

I never got any answers from sales at SauceLabs :(

Jun 14 2018, 7:24 AM · Performance-Team
Peter closed T195248: Test out performance testing on Saucelabs, a subtask of T191617: Mobile performance testing alternatives, as Resolved.
Jun 14 2018, 7:24 AM · Performance-Team
Peter added a comment to T196242: Chrome 67 performance regression.

@Gilles wonderful :D

Jun 14 2018, 6:58 AM · Performance-Team (Radar), Upstream

Jun 13 2018

Peter added a comment to T191617: Mobile performance testing alternatives.

I've been testing out to run multiple devices using Docker but from Mac today following the Appium setup: https://github.com/appium/appium-docker-android

Jun 13 2018, 2:42 PM · Performance-Team

Jun 12 2018

Peter added a comment to T196899: [Bug] Missing WebPagetest metrics after June 5th 17:00.

Thanks @Niedzielski for filing this, I've missed that it broke some metrics. It looks better now when I reverted but please have a look you to before we close it.

Jun 12 2018, 12:40 PM · Patch-For-Review, WebPageTest, Performance-Team, Readers-Web-Backlog (Tracking), Regression
Peter added a comment to T187858: Chrome bug makes us miss collecting Navigation Timing metrics for redirects..

Tested it manually in 67 (67.0.3396.79) and it seems to work correct now. Lets when we can see thing in the RUM metrics.

Jun 12 2018, 7:41 AM · MediaWiki-extensions-NavigationTiming, Upstream, Performance-Team
Peter added a comment to T196899: [Bug] Missing WebPagetest metrics after June 5th 17:00.

I rolled back the change and hopefully it will just work from the next run. I'll add so we log the data we send to statsv so we can debug whats wrong and then lets also look for adding alerts if data is missing (the problem before has been that Graphite sometimes fail delivering a query = false alerts) but maybe we can do the queries smarter.

Jun 12 2018, 4:42 AM · Patch-For-Review, WebPageTest, Performance-Team, Readers-Web-Backlog (Tracking), Regression

Jun 11 2018

Peter reopened T193719: Pick up DOMComplete and send to Graphite, a subtask of T192623: ResourceLoader 2018 Review, as Open.
Jun 11 2018, 8:19 PM · Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), MediaWiki-ResourceLoader, Performance-Team
Peter reopened T193719: Pick up DOMComplete and send to Graphite as "Open".

Reopening since this is rollbacked in https://gerrit.wikimedia.org/r/#/c/performance/WebPageTest/+/439654/

Jun 11 2018, 8:19 PM · Performance-Team, WebPageTest
Peter claimed T196899: [Bug] Missing WebPagetest metrics after June 5th 17:00.
Jun 11 2018, 8:02 PM · Patch-For-Review, WebPageTest, Performance-Team, Readers-Web-Backlog (Tracking), Regression
Peter added a project to T196899: [Bug] Missing WebPagetest metrics after June 5th 17:00: WebPageTest.
Jun 11 2018, 7:31 PM · Patch-For-Review, WebPageTest, Performance-Team, Readers-Web-Backlog (Tracking), Regression
Peter added a comment to T196899: [Bug] Missing WebPagetest metrics after June 5th 17:00.

I've checked Jenkins and everything looks good there (at least no errors from when we send the metrics).

Jun 11 2018, 7:31 PM · Patch-For-Review, WebPageTest, Performance-Team, Readers-Web-Backlog (Tracking), Regression
Peter updated subscribers of T196899: [Bug] Missing WebPagetest metrics after June 5th 17:00.

Hmm, it match when we pushed DOMLoaded, then it is something probably something wrong with statsv, like we hit a limit? Adding @Krinkle . I can see that some metrics are missing on numerous dashboards.

Jun 11 2018, 7:25 PM · Patch-For-Review, WebPageTest, Performance-Team, Readers-Web-Backlog (Tracking), Regression
Peter added a comment to T195292: Enable HAR for Firefox on Browsertime/WebPageReplay.

Enabled the HAR for Firefox today and documenting the overhead it gives on a c4.large instance on AWS:

Jun 11 2018, 11:40 AM · Upstream, Performance-Team
Peter added a comment to T196242: Chrome 67 performance regression.

Our RUM data has started alerting now:

Jun 11 2018, 6:08 AM · Performance-Team (Radar), Upstream

Jun 7 2018

Peter committed rGERRITDEPLOY07ec76188c22: Fix for issue 2016 ssh keys not flushed (authored by Peter Bruin <peterbruin68@gmail.com>).
Fix for issue 2016 ssh keys not flushed
Jun 7 2018, 6:53 PM
Peter updated subscribers of T193221: Mobile doesn't render until full HTML is downloaded.

Adding an example as what it looks like on iOS Safari after discussing with @Jhernandez
https://webpagetest.org/result/180607_7X_89696060282ad9321ec2a3846b893d33/1/details/#waterfall_view_step1

Jun 7 2018, 12:58 PM · Upstream, Performance-Team
Peter updated the task description for T196242: Chrome 67 performance regression.
Jun 7 2018, 11:52 AM · Performance-Team (Radar), Upstream
Peter updated the task description for T196600: Move browsertime/WebPageReplay repos to Wikimedia.
Jun 7 2018, 5:46 AM · Performance-Team
Peter created T196600: Move browsertime/WebPageReplay repos to Wikimedia.
Jun 7 2018, 5:46 AM · Performance-Team

Jun 6 2018

Peter added a comment to T123328: [GOAL] Lazy load references in mobile skin.

T193221 is our own task for the Chrome upstream bug.

Jun 6 2018, 10:00 AM · Readers-Web-Backlog, Epic, Goal, Reading-Web-Planning, Reading-Admin

Jun 5 2018

Peter added a comment to T104902: Refactor Navigation Timing gathering to produce reliable stackable measures.

@Krinkle I tried to validate the example events with https://github.com/soulgalore/wikimedia-tools/blob/master/validate-navtiming/validate.js and I got two events there that doesn't match in total vs loadEventEnd but it could be that I just missed something in the validation. I'll dig into it tomorrow again.

Jun 5 2018, 1:45 PM · MediaWiki-extensions-NavigationTiming, Performance-Team
Peter added a comment to T191617: Mobile performance testing alternatives.

There are actually only one alternative and that is hosting the mobile phones ourselves. I'll list pro and cons and then we can discuss this on the next offsite.

Jun 5 2018, 11:02 AM · Performance-Team
Peter triaged T193221: Mobile doesn't render until full HTML is downloaded as Normal priority.
Jun 5 2018, 10:46 AM · Upstream, Performance-Team
Peter added a project to T193221: Mobile doesn't render until full HTML is downloaded: Upstream.

I created an upstream issue in Chrome for this: https://bugs.chromium.org/p/chromium/issues/detail?id=849106

Jun 5 2018, 10:46 AM · Upstream, Performance-Team
Peter added a comment to T195248: Test out performance testing on Saucelabs.

The thing is: I contacted SauceLabs firs through the generic contact, then got sent to support and then from customer support to sales. I think they don't see the potential for using SauceLabs for performance test. I'll contact sales as a last thing and then close this.

Jun 5 2018, 10:35 AM · Performance-Team

Jun 4 2018

Peter added a comment to T104902: Refactor Navigation Timing gathering to produce reliable stackable measures.

Here's the latest version: https://grafana.wikimedia.org/dashboard/db/performance-metrics?refresh=5m&panelId=30&fullscreen&orgId=1

Jun 4 2018, 12:45 PM · MediaWiki-extensions-NavigationTiming, Performance-Team
Peter added a comment to T196242: Chrome 67 performance regression.

This is interesting. Our alerts didn't fire because all pages aren't affected:

Jun 4 2018, 6:49 AM · Performance-Team (Radar), Upstream

Jun 3 2018

Peter added a comment to T196242: Chrome 67 performance regression.

Need more users on 67 to see it in RUM: https://grafana.wikimedia.org/dashboard/db/navigation-timing-by-browser?refresh=5m&orgId=1&var-metric=firstPaint&var-browserFamily=Chrome&var-browserVersion=66&var-browserVersion=67&var-m=median

Jun 3 2018, 4:42 PM · Performance-Team (Radar), Upstream
Peter edited projects for T196242: Chrome 67 performance regression, added: Upstream; removed WebPageTest.

Created an upstream issue: https://bugs.chromium.org/p/chromium/issues/detail?id=849108

Jun 3 2018, 4:37 PM · Performance-Team (Radar), Upstream
Peter added a comment to T196242: Chrome 67 performance regression.

Yep checking the metrics on Browrsertime, first visual change increase with 33 ms or so. I'll add the graphs when we have more data.

Jun 3 2018, 4:34 PM · Performance-Team (Radar), Upstream
Peter renamed T196312: Fine tune WebPageTest alerts from Finetune WebPageTest alerts to Fine tune WebPageTest alerts.
Jun 3 2018, 3:40 PM · WebPageTest, Performance-Team
Peter created T196312: Fine tune WebPageTest alerts.
Jun 3 2018, 3:39 PM · WebPageTest, Performance-Team
Peter added a comment to T196242: Chrome 67 performance regression.

I've pushed 67 on Browsertime/WebPageReplay and will just wait to see if we get the same thing there (I get it on the sitespeed.io servers so we should too). I'll create an upstream issue and then I need to go through our alert setups for WebPageTest since it didn't fire.

Jun 3 2018, 3:37 PM · Performance-Team (Radar), Upstream

Jun 2 2018

Peter renamed T196242: Chrome 67 performance regression from Chome 67 regression to Chome 67 performance regression.
Jun 2 2018, 6:25 PM · Performance-Team (Radar), Upstream
Peter created T196242: Chrome 67 performance regression.
Jun 2 2018, 6:24 PM · Performance-Team (Radar), Upstream

May 24 2018

Peter added a comment to T195248: Test out performance testing on Saucelabs.

I got some answer. First reached out using the contact form, then the support:

May 24 2018, 1:52 PM · Performance-Team

May 23 2018

Peter added a comment to T159668: WebPageTest private server loads assets from Google.

Adding this for reference: https://techblog.bozho.net/tracking-cookies-gdpr/

May 23 2018, 7:36 AM · Performance-Team, Upstream, WebPageTest
Peter changed the status of T195292: Enable HAR for Firefox on Browsertime/WebPageReplay from Open to Stalled.

The new version works, you can get the HAR without it and on AWS C4.large it makes pages render 50-100 ms faster in FF but the HAR that is created is missing content size field, so the HAR isn't following the HAR spec.

May 23 2018, 6:09 AM · Upstream, Performance-Team

May 22 2018

Peter triaged T195292: Enable HAR for Firefox on Browsertime/WebPageReplay as Normal priority.
May 22 2018, 12:43 PM · Upstream, Performance-Team
Peter created T195292: Enable HAR for Firefox on Browsertime/WebPageReplay.
May 22 2018, 12:43 PM · Upstream, Performance-Team
Peter triaged T195230: Blog post series about synthetic testing as Normal priority.
May 22 2018, 11:23 AM · Performance-Team
Peter triaged T194639: Pick up Navigation Timing metrics with WebPageTest as Normal priority.
May 22 2018, 11:22 AM · Performance-Team, WebPageTest
Peter triaged T195231: Blog post: Explain synthetic testing as Normal priority.
May 22 2018, 11:22 AM · Performance-Team
Peter triaged T195232: Blog post: How we use WebPageTest as Normal priority.
May 22 2018, 11:22 AM · WebPageTest, Performance-Team
Peter triaged T195233: Blog post: Explain how we use Browsertime/WebPageReplay as Normal priority.
May 22 2018, 11:21 AM · Performance-Team
Peter added a comment to T195248: Test out performance testing on Saucelabs.

Yep I included it when I asked them about the plans to set connectivity. Just posted the question.

May 22 2018, 11:21 AM · Performance-Team
Peter triaged T195248: Test out performance testing on Saucelabs as Normal priority.
May 22 2018, 11:14 AM · Performance-Team