Page MenuHomePhabricator

Peter (Peter Hedenskog)
Software Engineer, Wikimedia Foundation

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 17 2015, 6:48 PM (224 w, 5 d)
Availability
Available
IRC Nick
phedenskog
LDAP User
Unknown
MediaWiki User
PHedenskog (WMF) [ Global Accounts ]

Recent Activity

Today

Peter closed T238756: WebPageTest search don't work as Resolved.

The private thing fixed it. I've also hardcoded so you can search 31 days back in time.

Sun, Dec 8, 12:25 PM · Patch-For-Review, Performance-Team, WebPageTest
Peter added a comment to T239780: Test enwiki configuration with minimal WebDriver impact .

This done now, but I cannot see any change for Firefox. One thing left todo is to use verify that FF doesn't any extra requests during loading the page, I've only verified that on Mac not Linux.

Sun, Dec 8, 12:24 PM · Performance-Team, WebPageReplay
Peter added a comment to T238756: WebPageTest search don't work.

Two problems here: When I changed to the new setup all tests runs as private by default. I think that hides them from the search. The other is that I've updated the code to run the same as the upstream repo but theres limit there to search only for the last 7 days. That should have been made configurable but it hasn't.

Sun, Dec 8, 11:20 AM · Patch-For-Review, Performance-Team, WebPageTest
Peter removed a project from T238756: WebPageTest search don't work: Upstream.
Sun, Dec 8, 11:18 AM · Patch-For-Review, Performance-Team, WebPageTest
Peter created T240095: Downtime WebPageReplay 2019-12-07.
Sun, Dec 8, 7:42 AM · Performance-Team, WebPageReplay

Yesterday

Peter created T240089: WebPageTest tests stopped running.
Sat, Dec 7, 11:55 PM · WebPageTest, Performance-Team
Peter created T240088: Collecting Visual Metrics stopped working for search on emulated mobile.
Sat, Dec 7, 11:27 PM · Performance-Team
Peter created T240086: Arabic Wikipedia fails collecting visual metrics.
Sat, Dec 7, 11:22 PM · Performance-Team, WebPageReplay
Peter added a comment to T238756: WebPageTest search don't work.

T213833 was the last time this happens, let me go through it again.

Sat, Dec 7, 5:59 PM · Patch-For-Review, Performance-Team, WebPageTest

Wed, Dec 4

Peter created T239780: Test enwiki configuration with minimal WebDriver impact .
Wed, Dec 4, 7:38 AM · Performance-Team, WebPageReplay

Tue, Dec 3

Peter moved T233417: Deploy a version of navtiming or coal from Next In This Quarter to Backlog: Small & Maintenance on the Performance-Team board.
Tue, Dec 3, 7:15 AM · Performance-Team
Peter moved T233789: Investigate inconsistent server response time in WebPageReplay from Next In This Quarter to Backlog: Small & Maintenance on the Performance-Team board.
Tue, Dec 3, 7:15 AM · Patch-For-Review, Performance-Team, WebPageReplay
Peter added a comment to T239662: Compare waterfalls between ATS and nginx.

See https://github.com/WPO-Foundation/wptagent/issues/284 for the tracking-protection URLs when we compare using Firefox.

Tue, Dec 3, 12:27 AM · Performance-Team

Mon, Dec 2

Peter added a comment to T239662: Compare waterfalls between ATS and nginx.

There's no way to run from an Android device in EU, but I'm gonna do a manual testing tomorrow.

Mon, Dec 2, 9:38 PM · Performance-Team
Peter added a comment to T239662: Compare waterfalls between ATS and nginx.

Compare: https://webpagetest.org/video/compare.php?tests=191202_02_a5854d822511780a53a199c133c20b79,191202_60_532288fb438a800af3460859af628a2e

Mon, Dec 2, 9:32 PM · Performance-Team
Peter added a comment to T239662: Compare waterfalls between ATS and nginx.

ATS: https://webpagetest.org/result/191202_02_a5854d822511780a53a199c133c20b79/
nginx: https://webpagetest.org/result/191202_60_532288fb438a800af3460859af628a2e/

Mon, Dec 2, 9:30 PM · Performance-Team
Peter created T239662: Compare waterfalls between ATS and nginx.
Mon, Dec 2, 9:27 PM · Performance-Team
Peter moved T238182: Alerts do not fire for WebPageReplay from Inbox to Doing on the Performance-Team board.
Mon, Dec 2, 9:13 PM · Performance-Team, WebPageReplay
Peter closed T237308: Feedback on new alert setup as Resolved.

Feedback received at the offsite.

Mon, Dec 2, 9:07 PM · WebPageReplay, Performance-Team
Peter added a comment to T237308: Feedback on new alert setup.

@Krinkle I created a new dashboard and missed update Icinga.

Mon, Dec 2, 9:07 PM · WebPageReplay, Performance-Team
Peter moved T238549: Measure the click on the menu on mobile from Inbox to Next In This Quarter on the Performance-Team board.
Mon, Dec 2, 9:04 PM · Performance-Team
Peter moved T238549: Measure the click on the menu on mobile from Next In This Quarter to Inbox on the Performance-Team board.
Mon, Dec 2, 9:03 PM · Performance-Team
Peter moved T238742: Wrongly tagged annotation with both native and cable connectivity from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Mon, Dec 2, 9:02 PM · Performance-Team, WebPageTest
Peter moved T238756: WebPageTest search don't work from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Mon, Dec 2, 9:02 PM · Patch-For-Review, Performance-Team, WebPageTest
Peter moved T233789: Investigate inconsistent server response time in WebPageReplay from Doing to Next In This Quarter on the Performance-Team board.
Mon, Dec 2, 8:58 PM · Patch-For-Review, Performance-Team, WebPageReplay
Peter moved T230708: Performance review of new foundation website design from Doing to Next In This Quarter on the Performance-Team board.
Mon, Dec 2, 8:58 PM · Performance-Team
Peter moved T232174: 1st Sept 2019: Regression in start render/last visual change (desktop and mobile)? from Doing to Next In This Quarter on the Performance-Team board.
Mon, Dec 2, 8:58 PM · Performance-Team
Peter moved T233417: Deploy a version of navtiming or coal from Doing to Next In This Quarter on the Performance-Team board.
Mon, Dec 2, 8:58 PM · Performance-Team
Peter moved T239339: Write performance calendar blog post about first input delay for Wikipedia from Inbox to Doing on the Performance-Team board.
Mon, Dec 2, 8:57 PM · Performance-Team
Peter renamed T239472: Instrument number of processes running on the WebPageReplay servers from Instrument WebPageReplay servers to Instrument number of processes running on the WebPageReplay servers.
Mon, Dec 2, 8:50 PM · WebPageReplay, Performance-Team
Peter moved T239472: Instrument number of processes running on the WebPageReplay servers from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Mon, Dec 2, 8:49 PM · WebPageReplay, Performance-Team
Peter added a comment to T239472: Instrument number of processes running on the WebPageReplay servers.

The interesting thing is number of processes running on the server from Annie Sullivans performance.now() talk.

Mon, Dec 2, 8:49 PM · WebPageReplay, Performance-Team
Peter awarded T239579: Collect 1 or more normalised RUM metrics a Love token.
Mon, Dec 2, 1:20 PM · Performance-Team

Fri, Nov 29

Peter created T239472: Instrument number of processes running on the WebPageReplay servers.
Fri, Nov 29, 1:32 PM · WebPageReplay, Performance-Team
Peter added a comment to T225213: Main Menu should work without JavaScript to be more accessible and a better user experience.

I've made some tests so we have some data to compare with. I've accessed https://en.m.wikipedia.org/wiki/Barack_Obama on my Alcatel One (using my office wifi) and then clicking on the navigation to open it, and measure that input delay using the Chrome API First Input Delay. The click always happens after onload.

Fri, Nov 29, 1:06 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Jdlrobson, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Wed, Nov 27

Peter created T239339: Write performance calendar blog post about first input delay for Wikipedia.
Wed, Nov 27, 2:02 PM · Performance-Team
Peter closed T238186: Measure FID in synthetic testing, a subtask of T238056: Investigate Google Search Console Speed report trends, as Resolved.
Wed, Nov 27, 7:39 AM · Readers-Web-Backlog (Tracking), Performance-Team
Peter closed T238186: Measure FID in synthetic testing as Resolved.

When getting FID on a server, setting the Chrome CPUThrottlingRate doesn't help. It will not change the FID result emulating a slower device, so we need to do this on a real mobile phone in the future. Let TBT and maxPotentialFid be it for now.

Wed, Nov 27, 7:39 AM · Performance-Team

Tue, Nov 26

Peter added a comment to T238056: Investigate Google Search Console Speed report trends.

@Gilles I've did some testing. First I tried google.com on my Alacatel One phone. Just accessing the URL and measuring the maxPotentialFID. The thing is Google ship quite much JavaScript, it was different between runs but something like 700-800kb unpacked. For five runs the maxPotentialFid on that phone was: 462, 512, 502, 493, 590 ms.

Tue, Nov 26, 12:19 PM · Readers-Web-Backlog (Tracking), Performance-Team

Mon, Nov 25

Peter closed T234138: Page size and DOM note count missing for some WPT runs (wikidatawiki & beta) as Resolved.

The missing data problem has been solved since I moved the tests to the new Graphite setup. I've manual updated the dashboard a couple of weeks ago to use the new datasource.

Mon, Nov 25, 9:52 PM · WebPageTest, Performance-Team
Peter awarded T220838: Upgrade grafana to 6.4.4 a Yellow Medal token.
Mon, Nov 25, 8:34 PM · Patch-For-Review, Performance-Team (Radar), observability, Operations
Peter added a comment to T238056: Investigate Google Search Console Speed report trends.

Yes I could that. The way I'm thinking will be the parse time of JavaScript (so long tasks/max potential fid), is that how you think too?. So I'm gonna do a simple page with a lot of HTML + one with only limited JS and run them with Alacatel phone. I'll do that tomorrow.

Mon, Nov 25, 1:47 PM · Readers-Web-Backlog (Tracking), Performance-Team
Peter reopened T210911: Request on mobile isn't recorded in the replay proxy as "Open".

Re-opening because I still this on some pages: https://s3.amazonaws.com/synthetic-tests-result-wikimedia/ar.m.wikipedia.org/2019-11-25-10-46-36/pages/ar.m.wikipedia.org/wiki/---------/index.html#waterfall

Mon, Nov 25, 1:41 PM · WebPageReplay, Performance-Team
Peter added a comment to T238495: Late last visual change caused by rotating banner.

I've updated to a new version that should fix this but lets see what happens with the graph.

Mon, Nov 25, 4:36 AM · WebPageReplay, Performance-Team
Peter closed T210911: Request on mobile isn't recorded in the replay proxy as Resolved.
Mon, Nov 25, 4:34 AM · WebPageReplay, Performance-Team
Peter closed T238760: Run enwiki performance tests more often as Resolved.
Mon, Nov 25, 4:30 AM · Performance-Team, WebPageReplay
Peter added a comment to T238756: WebPageTest search don't work.

Made an upstream issue: https://github.com/WPO-Foundation/webpagetest/issues/1313

Mon, Nov 25, 4:04 AM · Patch-For-Review, Performance-Team, WebPageTest
Peter added a project to T238756: WebPageTest search don't work: Upstream.

I've checked the server and the search logs looks ok. It's setup as it should, I think something changed upstream.

Mon, Nov 25, 3:49 AM · Patch-For-Review, Performance-Team, WebPageTest

Wed, Nov 20

Peter added a comment to T210911: Request on mobile isn't recorded in the replay proxy.

This is fixed in the next update.

Wed, Nov 20, 8:15 PM · WebPageReplay, Performance-Team
Peter added a comment to T233191: Images on upload aren't replayed correctly on WebPageReplay.

I still see this (and get 404 in the test log). https://s3.amazonaws.com/synthetic-tests-result-wikimedia/en.m.wikipedia.org/2019-11-20-17-42-33/pages/en.m.wikipedia.org/wiki/Barack_Obama/index.html#waterfall

Wed, Nov 20, 5:52 PM · Patch-For-Review, WebPageReplay, Performance-Team
Peter created T238760: Run enwiki performance tests more often.
Wed, Nov 20, 5:00 PM · Performance-Team, WebPageReplay
Peter created T238756: WebPageTest search don't work.
Wed, Nov 20, 4:24 PM · Patch-For-Review, Performance-Team, WebPageTest
Peter closed T238743: Missing render in the graph as Resolved.

The render line was hidden in the overrides

Wed, Nov 20, 1:52 PM · Performance-Team, WebPageTest
Peter created T238743: Missing render in the graph.
Wed, Nov 20, 1:37 PM · Performance-Team, WebPageTest
Peter closed T238741: Both annotations for Firefox and Chrome is picked up (but only one is chosen in the drop down) as Resolved.

The annotation was missing the $location field fixed now.

Wed, Nov 20, 1:35 PM · Performance-Team, WebPageTest
Peter created T238742: Wrongly tagged annotation with both native and cable connectivity.
Wed, Nov 20, 1:33 PM · Performance-Team, WebPageTest
Peter created T238741: Both annotations for Firefox and Chrome is picked up (but only one is chosen in the drop down).
Wed, Nov 20, 1:30 PM · Performance-Team, WebPageTest
Peter added a comment to T214460: Add synthetic testing for editing process (save timing).

Discussed with @Krinkle on our offsite: let us get the metrics in the backend for our user and lets add two tests: One new page in the user space for enwiki where we just add a new date for every save and then in beta we do a save on a large article where change/insert a date in the beginning of the article.

Wed, Nov 20, 12:55 PM · Performance-Team

Mon, Nov 18

Peter created T238549: Measure the click on the menu on mobile.
Mon, Nov 18, 2:05 PM · Performance-Team
Peter added a comment to T225213: Main Menu should work without JavaScript to be more accessible and a better user experience.

FYI: I've finally got around to measure the CPU time when clicking on the navigation button on mobile. These seems like a perfect opportunity to measure before and after the switch. I haven't added that to our test servers yet so it happens automatically but I can do that. But the best way to measure it is on a real phone. I got a Alcatel One that is perfect for this. When I get back home I'll collect some metrics + look at measure it continuously.

Mon, Nov 18, 2:02 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Jdlrobson, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Accessibility, Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture), MinervaNeue

Sun, Nov 17

Peter updated subscribers of T238056: Investigate Google Search Console Speed report trends.
Sun, Nov 17, 10:24 PM · Readers-Web-Backlog (Tracking), Performance-Team
Peter added a comment to T238056: Investigate Google Search Console Speed report trends.

Adding the "new" limits we have them:

Sun, Nov 17, 3:23 PM · Readers-Web-Backlog (Tracking), Performance-Team
Peter created T238495: Late last visual change caused by rotating banner.
Sun, Nov 17, 2:08 PM · WebPageReplay, Performance-Team

Sat, Nov 16

Peter added a comment to T238056: Investigate Google Search Console Speed report trends.

When I look at the ones on desktop that has a slow First Contentful Paint, most of the example URLs are on the are from ar.wikipedia.org. One example URL is https://ar.wikipedia.org/wiki/فيسبوك

Sat, Nov 16, 11:25 PM · Readers-Web-Backlog (Tracking), Performance-Team
Peter created T238472: Review mobile device detection.
Sat, Nov 16, 1:43 PM · Performance-Team

Thu, Nov 14

Peter added a comment to T238186: Measure FID in synthetic testing.

I've pushed a change so we measure TBT and maxPotentialFid and see what kind of metrics we get from the AWS machines.But I this thing really pushes the need for our performance mobile lab.

Thu, Nov 14, 11:27 AM · Performance-Team
Peter added a comment to T238186: Measure FID in synthetic testing.

I did some tests on the Obama article. Tested on both Alacatel and Moto G5 and it depends, but I've seen times where it 200-288 ms, so really close. And definitely put us on the yellow/orange section. I need more time to test, but its definitely one thing that also do not work in our favor.

Thu, Nov 14, 11:17 AM · Performance-Team
Peter added a comment to T238186: Measure FID in synthetic testing.

Let me try out opening sections as you proposed @Gilles

Thu, Nov 14, 10:58 AM · Performance-Team
Peter added a comment to T238186: Measure FID in synthetic testing.

We can get the trace log and have a look to be 100% sure but I'm pretty convinced its parsing the JavaScript? Since maxPotentialFid takes long tasks after contentful paint and then we parse the JS since we aren't depending on JS to render.

Thu, Nov 14, 10:58 AM · Performance-Team
Peter added a comment to T238186: Measure FID in synthetic testing.

Ok. I've spent some more time on this. The Chrome team also uses something called "Max potential First Input Delay" and that is a CPU long task that happens after first contentful paint, with the idea that the user potentially want to interact with the screen since we show something.

Thu, Nov 14, 9:06 AM · Performance-Team

Wed, Nov 13

Peter added a comment to T238186: Measure FID in synthetic testing.

I've spent the day investigating how we can measure FID. It works for me with clicking on a key or mouse click (or finger or mobile). I cannot get it to work with swiping mobile though. I've concentrated measuring FID when everything has downloaded.

Wed, Nov 13, 2:02 PM · Performance-Team
Peter created T238186: Measure FID in synthetic testing.
Wed, Nov 13, 9:09 AM · Performance-Team
Peter created T238182: Alerts do not fire for WebPageReplay.
Wed, Nov 13, 5:45 AM · Performance-Team, WebPageReplay

Tue, Nov 12

Peter moved T237359: Smarter AWS alerts from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Tue, Nov 12, 9:00 PM · WebPageTest, WebPageReplay, Performance-Team
Peter added a comment to T238091: We should track First Input Delay (FID) in our RUM metrics.

If we just care about Chrome we can use the performance observer for
first-input, I've used it here - it supports buffered too so we don't have to add things in head.

Tue, Nov 12, 6:34 PM · Performance-Team
Peter added a comment to T238056: Investigate Google Search Console Speed report trends.

If I remember correctly i saw different patterns from the synthetic testing. Some URLs slower, some faster. The good thing when I pushed our new setup we are still running 77, so let me update to 78 to see if can get some more help there.

Tue, Nov 12, 1:28 PM · Readers-Web-Backlog (Tracking), Performance-Team
Peter created T238087: Add documentation for user journeys .
Tue, Nov 12, 1:26 PM · Documentation, Performance-Team
Peter moved T214460: Add synthetic testing for editing process (save timing) from Doing to Next In This Quarter on the Performance-Team board.
Tue, Nov 12, 9:56 AM · Performance-Team
Peter moved T238051: Update WebPageTest documentation from Inbox to Doing on the Performance-Team board.
Tue, Nov 12, 9:56 AM · Documentation, WebPageTest, Performance-Team
Peter triaged T238051: Update WebPageTest documentation as Medium priority.
Tue, Nov 12, 9:56 AM · Documentation, WebPageTest, Performance-Team
Peter created T238051: Update WebPageTest documentation.
Tue, Nov 12, 9:55 AM · Documentation, WebPageTest, Performance-Team
Peter added a comment to T233789: Investigate inconsistent server response time in WebPageReplay.

Did a test using running WPT with native connectivity looking at the stdev:

Tue, Nov 12, 9:04 AM · Patch-For-Review, Performance-Team, WebPageReplay
Peter updated the task description for T219496: [Meta] Next level of synthetic testing.
Tue, Nov 12, 8:58 AM · Performance-Team
Peter closed T225416: Unify synthetic testing scripts, a subtask of T219496: [Meta] Next level of synthetic testing, as Resolved.
Tue, Nov 12, 8:58 AM · Performance-Team
Peter closed T225416: Unify synthetic testing scripts as Resolved.

The old setup is stopped and we only use the new now.

Tue, Nov 12, 8:58 AM · Patch-For-Review, WebPageReplay, WebPageTest, Performance-Team
Peter closed T237521: Change WebPageTest dashboards and alerts to the new setup, a subtask of T225416: Unify synthetic testing scripts, as Resolved.
Tue, Nov 12, 8:56 AM · Patch-For-Review, WebPageReplay, WebPageTest, Performance-Team
Peter closed T237521: Change WebPageTest dashboards and alerts to the new setup as Resolved.

All the alerts are moved too now and I turned off the old setup.

Tue, Nov 12, 8:56 AM · WebPageTest, Performance-Team

Mon, Nov 11

Peter added a comment to T237521: Change WebPageTest dashboards and alerts to the new setup.

Finished mobile-2g so now its only the actual alerts that needs to be fixed, then we can turn off the old runs.

Mon, Nov 11, 5:22 PM · WebPageTest, Performance-Team
Peter added a comment to T237521: Change WebPageTest dashboards and alerts to the new setup.

Got half of https://grafana.wikimedia.org/d/000000205/mobile-2g to be done and the https://grafana.wikimedia.org/d/000000318/webpagetest-alerts

Mon, Nov 11, 1:52 PM · WebPageTest, Performance-Team
Peter moved T237521: Change WebPageTest dashboards and alerts to the new setup from Inbox to Doing on the Performance-Team board.
Mon, Nov 11, 12:50 PM · WebPageTest, Performance-Team
Peter added a comment to T237521: Change WebPageTest dashboards and alerts to the new setup.

Converted:
https://grafana.wikimedia.org/d/000000057/webpagetest-drilldown
https://grafana.wikimedia.org/d/000000209/wikidata-webpagetest
https://grafana.wikimedia.org/d/000000146/webpagetest-portals
https://grafana.wikimedia.org/d/000000130/mobile-webpagetest

Mon, Nov 11, 12:50 PM · WebPageTest, Performance-Team

Nov 8 2019

Peter triaged T237521: Change WebPageTest dashboards and alerts to the new setup as High priority.
Nov 8 2019, 11:35 AM · WebPageTest, Performance-Team
Peter closed T237515: webpagereplay grafana alerts UNKNOWN as Resolved.

I think is fixed, it was caused because I removed some dashboard and forgot to update Icinga.

Nov 8 2019, 11:29 AM · Performance-Team
Peter closed T237510: Update WebPageReplay documention as Resolved.

And https://wikitech.wikimedia.org/wiki/Performance/Regressions
https://wikitech.wikimedia.org/wiki/Performance/WebPageReplay/Alerts
https://wikitech.wikimedia.org/wiki/Performance/Metrics#WebPageReplay

Nov 8 2019, 11:27 AM · Documentation, WebPageReplay, Performance-Team
Peter added a comment to T237510: Update WebPageReplay documention.

Done:
https://wikitech.wikimedia.org/wiki/Performance/WebPageReplay
https://wikitech.wikimedia.org/wiki/Performance/Runbook/WebPageReplay

Nov 8 2019, 10:52 AM · Documentation, WebPageReplay, Performance-Team

Nov 6 2019

Peter updated the task description for T237308: Feedback on new alert setup.
Nov 6 2019, 3:05 PM · WebPageReplay, Performance-Team
Peter added a comment to T237515: webpagereplay grafana alerts UNKNOWN.

Ah I see now, ok so the alerts we sent have a connection to the dashboard? I forgot about that. Let me update that.

Nov 6 2019, 3:00 PM · Performance-Team
Peter moved T233191: Images on upload aren't replayed correctly on WebPageReplay from Doing to Backlog: Small & Maintenance on the Performance-Team board.
Nov 6 2019, 11:49 AM · Patch-For-Review, WebPageReplay, Performance-Team
Peter created T237521: Change WebPageTest dashboards and alerts to the new setup.
Nov 6 2019, 11:48 AM · WebPageTest, Performance-Team
Peter removed a subtask for T225416: Unify synthetic testing scripts: T235604: Send errors to IRC for the new synthetic testing setup.
Nov 6 2019, 11:46 AM · Patch-For-Review, WebPageReplay, WebPageTest, Performance-Team