Peter (Peter Hedenskog)
Software Engineer, Wikimedia Foundation

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 17 2015, 6:48 PM (183 w, 1 d)
Availability
Available
IRC Nick
phedenskog
LDAP User
Unknown
MediaWiki User
PHedenskog (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Peter removed a project from T204345: Wrong images are picked up in Browsertime/WebPageReplay on Mobile: Upstream.

Let me just fix that.

Tue, Feb 19, 9:54 PM · Performance-Team, WebPageReplay
Peter moved T204345: Wrong images are picked up in Browsertime/WebPageReplay on Mobile from Blocked to Backlog: Small & Maintenance on the Performance-Team board.
Tue, Feb 19, 9:54 PM · Performance-Team, WebPageReplay
Peter closed T190504: Last Visual Change is wrong for emulated mobile on Browsertime/WebPageReplay as Resolved.

This was fixed in T215160

Tue, Feb 19, 9:43 PM · Performance-Team, WebPageReplay, Upstream
Peter updated subscribers of T215489: [Investigate] Measure time spent as a logged in user from different locations.

I need your input on this @aaron @Krinkle and @Gilles before I start to collect metrics. Am I doing it correct? Anything I should change?

Tue, Feb 19, 1:49 PM · Performance-Team

Mon, Feb 18

Peter added a comment to T215489: [Investigate] Measure time spent as a logged in user from different locations.

I've started with today. I've added tests running from Sweden and Mumbai as a start. My plan is like: If everything looks ok I'll start by documenting the setup tomorrow, and the Thursday close down the test and collect and so a summary of the result. Lets do a full run down at Wikitech, so we have the data for the future and then do a more light weight blog post about it.

Mon, Feb 18, 1:58 PM · Performance-Team
Peter moved T214027: Collect mobile phone statistics and send them to Graphite from Doing to Backlog: Small & Maintenance on the Performance-Team board.
Mon, Feb 18, 1:56 PM · Performance-Team
Peter moved T215489: [Investigate] Measure time spent as a logged in user from different locations from Backlog: Small & Maintenance to Doing on the Performance-Team board.
Mon, Feb 18, 1:56 PM · Performance-Team
Peter closed T215160: Wrong last visual change on WebPageReplay mobile as Resolved.

This looks good now. Mobile changed like this for all URLs I checked:

Mon, Feb 18, 6:49 AM · WebPageReplay, Performance-Team

Sun, Feb 17

Peter added a comment to T215160: Wrong last visual change on WebPageReplay mobile.

Looks much better!

Sun, Feb 17, 7:11 PM · WebPageReplay, Performance-Team
Peter added a comment to T215160: Wrong last visual change on WebPageReplay mobile.

I did some more changes and now uses 0.05% diff that's ok, that made it work so it runs in the servers now. Let me have a look tomorrow that everything is ok and then close.

Sun, Feb 17, 6:44 PM · WebPageReplay, Performance-Team
Peter added a comment to T215160: Wrong last visual change on WebPageReplay mobile.

No that didn't help, there is still something like 13 s last visual change happening for Obama on mobile. I've changed so that we look a 0.01% of the pixels can differ (that worked locally) but it seems that the diff is too small. Let me increase it a little and try again tomorrow.

Sun, Feb 17, 6:17 PM · WebPageReplay, Performance-Team
Peter added a comment to T215160: Wrong last visual change on WebPageReplay mobile.

I've pushed the fix now (with an annotation), I'll check that it really works before I close it.

Sun, Feb 17, 6:11 PM · WebPageReplay, Performance-Team

Fri, Feb 15

Peter added a comment to T215160: Wrong last visual change on WebPageReplay mobile.

There's two ways to fix this: when visual metrics removes frames from the end, it uses a fuzz factor of 10% (that's default that is used all over) and then compares pixel by pixel and the there must be zero pixels diff, for making sure that the screenshots are the same. However when looking for Visual Elements, the element also uses a 10 % fuzz but a 2% of pixels that can differs.

Fri, Feb 15, 5:58 AM · WebPageReplay, Performance-Team
Peter added a comment to T215160: Wrong last visual change on WebPageReplay mobile.

Adding an example file. Running default visual change gives last visual change something like 11 seconds but the "real" one should be more like 6 seconds.

Fri, Feb 15, 5:37 AM · WebPageReplay, Performance-Team

Mon, Feb 11

Peter moved T215498: Better performance with Firefox 65? from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Mon, Feb 11, 9:25 PM · WebPageTest, WebPageReplay, Performance-Team
Peter added a comment to T215160: Wrong last visual change on WebPageReplay mobile.

Hmm this was really annoying. I've been trying to backtrack/understand how this works. I've been trying with two images that is generated with a diff with VisualMetrics:


Mon, Feb 11, 2:04 PM · WebPageReplay, Performance-Team
Peter moved T214460: Try measuring save timings with synthetic testing from Doing to Backlog: Small & Maintenance on the Performance-Team board.
Mon, Feb 11, 1:40 PM · Performance-Team
Peter moved T215160: Wrong last visual change on WebPageReplay mobile from Backlog: Small & Maintenance to Doing on the Performance-Team board.
Mon, Feb 11, 1:40 PM · WebPageReplay, Performance-Team

Fri, Feb 8

Peter added a comment to T215087: Add automatic performance testing for all live banners.

Let me know if you need any help with it!

Fri, Feb 8, 2:21 PM · Fundraising Sprint Bert and Ernie's Excellent Adventure, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Peter moved T214027: Collect mobile phone statistics and send them to Graphite from Next in FY1819Q3 (Jan-Mar) to Doing on the Performance-Team board.
Fri, Feb 8, 11:21 AM · Performance-Team

Thu, Feb 7

Peter created T215498: Better performance with Firefox 65?.
Thu, Feb 7, 11:14 AM · WebPageTest, WebPageReplay, Performance-Team
Peter created T215489: [Investigate] Measure time spent as a logged in user from different locations.
Thu, Feb 7, 9:28 AM · Performance-Team
Peter added a comment to T215088: Update page performance tests to use null banner parameter.

Cool, thanks @Niedzielski FYI I added one annotation to that dashboard:

Thu, Feb 7, 5:57 AM · Performance-Team (Radar), Readers-Web-Backlog

Wed, Feb 6

Peter moved T214027: Collect mobile phone statistics and send them to Graphite from Doing to Next in FY1819Q3 (Jan-Mar) on the Performance-Team board.
Wed, Feb 6, 8:19 AM · Performance-Team
Peter added a comment to T215088: Update page performance tests to use null banner parameter.

If its ok to make it possible to disable it, then do it.

Wed, Feb 6, 8:15 AM · Performance-Team (Radar), Readers-Web-Backlog

Tue, Feb 5

Peter closed T215257: Enable visual elements for WebPageTest as Resolved.

Enabling them by setting:

Tue, Feb 5, 11:54 AM · Performance-Team, WebPageTest
Peter closed T215166: Add documentation for all synthetic metrics as Resolved.

I've added them here: https://wikitech.wikimedia.org/wiki/Performance/Metrics#Synthetic_metrics

Tue, Feb 5, 11:49 AM · WebPageReplay, WebPageTest, Performance-Team
Peter created T215257: Enable visual elements for WebPageTest.
Tue, Feb 5, 11:40 AM · Performance-Team, WebPageTest
Peter closed T215167: Increase instance size for WebPageTest agent as Resolved.
Tue, Feb 5, 7:11 AM · WebPageTest, Performance-Team
Peter added a comment to T215167: Increase instance size for WebPageTest agent.

Upgraded to c5.xlarge. There's an annotation in Grafana:

Tue, Feb 5, 7:11 AM · WebPageTest, Performance-Team
Peter moved T215167: Increase instance size for WebPageTest agent from Backlog: Small & Maintenance to Doing on the Performance-Team board.
Tue, Feb 5, 6:31 AM · WebPageTest, Performance-Team

Mon, Feb 4

Peter moved T215160: Wrong last visual change on WebPageReplay mobile from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Mon, Feb 4, 9:24 PM · WebPageReplay, Performance-Team
Peter moved T215166: Add documentation for all synthetic metrics from Inbox to Doing on the Performance-Team board.
Mon, Feb 4, 9:23 PM · WebPageReplay, WebPageTest, Performance-Team
Peter moved T215167: Increase instance size for WebPageTest agent from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Mon, Feb 4, 9:23 PM · WebPageTest, Performance-Team
Peter created T215167: Increase instance size for WebPageTest agent.
Mon, Feb 4, 2:33 PM · WebPageTest, Performance-Team
Peter created T215166: Add documentation for all synthetic metrics.
Mon, Feb 4, 2:30 PM · WebPageReplay, WebPageTest, Performance-Team
Peter added projects to T215160: Wrong last visual change on WebPageReplay mobile: Performance-Team, WebPageReplay.
Mon, Feb 4, 1:32 PM · WebPageReplay, Performance-Team
Peter created T215160: Wrong last visual change on WebPageReplay mobile.
Mon, Feb 4, 1:32 PM · WebPageReplay, Performance-Team

Wed, Jan 30

Peter updated subscribers of T214460: Try measuring save timings with synthetic testing.

Had a go today and I could go through the full flow. Now we just need to decide what to measure :)

Wed, Jan 30, 2:56 PM · Performance-Team
Peter moved T214460: Try measuring save timings with synthetic testing from Inbox to Doing on the Performance-Team board.
Wed, Jan 30, 2:52 PM · Performance-Team

Tue, Jan 29

Peter renamed T214026: Create a list of what's needed for getting the mobile phone performance lab running from Setup list to Create a list of what's needed for getting the mobile phone performance lab running.
Tue, Jan 29, 9:15 AM · Performance-Team
Peter updated the task description for T214026: Create a list of what's needed for getting the mobile phone performance lab running.
Tue, Jan 29, 9:13 AM · Performance-Team

Fri, Jan 25

Peter closed T214622: Assets not correctly uploaded to S3 as Resolved.

This is cleaned up now.

Fri, Jan 25, 5:33 AM · Performance-Team, WebPageReplay
Peter closed T214582: Update WebPageTest alerts to act on ms instead of % as Resolved.

Updated all the alerts.

Fri, Jan 25, 5:30 AM · WebPageTest, Performance-Team
Peter added a comment to T214622: Assets not correctly uploaded to S3.

Argh that didn't kick in, but manually removing old entries work, so I'll do that for the three beta mobile URLs so we can easily get to the interesting runs and then check again on Monday that the rest is ok.

Fri, Jan 25, 4:54 AM · Performance-Team, WebPageReplay

Thu, Jan 24

Peter added a comment to T214622: Assets not correctly uploaded to S3.

Ok, I've made a mistake when I setup the delete rules on S3 and only matched them to a couple of the folders, so beta hasn't been deleted since I added it. I've added rules for all folders and hopefully this will self-heal when older ones are automatically deleted so I'll have a look first thing tomorrow.

Thu, Jan 24, 7:47 PM · Performance-Team, WebPageReplay
Peter created T214622: Assets not correctly uploaded to S3.
Thu, Jan 24, 6:46 PM · Performance-Team, WebPageReplay
Peter created T214582: Update WebPageTest alerts to act on ms instead of %.
Thu, Jan 24, 1:35 PM · WebPageTest, Performance-Team
Peter closed T175931: Add alert for authenticated users (SpeedIndex/firstVisualChange) as Resolved.

I've activated them again for authenticated in Chrome, it looks good now at least, taking avg over a large time span and we can find a 40 ms change.

Thu, Jan 24, 1:33 PM · WebPageTest, Performance-Team
Peter added a comment to T213398: Move performance team dashboards to /performance/ folder in Grafana.

Tested now and it seems that subfolders isn't supported (I couldn't find in the GUI how to do it) and no one else has done any. No mentioning about it http://docs.grafana.org/reference/dashboard_folders/

Thu, Jan 24, 9:50 AM · Performance-Team
Peter closed T214353: Alert on missing performance data as Resolved.

I've changed on WebPageReplay desktop/WebPageReplay mobile and WebPageTest to alert on missing metrics.

Thu, Jan 24, 8:54 AM · WebPageTest, WebPageReplay, Performance-Team

Wed, Jan 23

Peter created T214460: Try measuring save timings with synthetic testing.
Wed, Jan 23, 7:29 AM · Performance-Team

Tue, Jan 22

Peter moved T214026: Create a list of what's needed for getting the mobile phone performance lab running from Inbox to Doing on the Performance-Team board.
Tue, Jan 22, 9:19 PM · Performance-Team
Peter moved T214027: Collect mobile phone statistics and send them to Graphite from Inbox to Doing on the Performance-Team board.
Tue, Jan 22, 9:19 PM · Performance-Team
Peter moved T214353: Alert on missing performance data from Inbox to Doing on the Performance-Team board.
Tue, Jan 22, 9:07 PM · WebPageTest, WebPageReplay, Performance-Team
Peter added a comment to T214353: Alert on missing performance data.

I've changed to If no data or all values are null SET STATE TO ALERT on https://grafana.wikimedia.org/d/000000490/webpagereplay-mobile-alerts?orgId=1 first visual change and Speed Index and let try that for a while.

Tue, Jan 22, 10:18 AM · WebPageTest, WebPageReplay, Performance-Team
Peter closed T214354: Update to latest Browsertime 4 as Resolved.
Tue, Jan 22, 8:45 AM · Performance-Team, WebPageReplay
Peter added a comment to T214354: Update to latest Browsertime 4.

This is running all servers now, it looks ok. Some small changes in some SpeedIndex and FirstVisual change and I think the reason is that the default view port on desktop has been changed in this release.

Tue, Jan 22, 8:45 AM · Performance-Team, WebPageReplay
Peter added a comment to T214354: Update to latest Browsertime 4.

I've pushed this on the Firefox instance and let me verify that it works there before I push it on the other instances.

Tue, Jan 22, 8:18 AM · Performance-Team, WebPageReplay
Peter created T214354: Update to latest Browsertime 4.
Tue, Jan 22, 7:48 AM · Performance-Team, WebPageReplay
Peter created T214353: Alert on missing performance data.
Tue, Jan 22, 7:46 AM · WebPageTest, WebPageReplay, Performance-Team

Jan 17 2019

Peter triaged T214027: Collect mobile phone statistics and send them to Graphite as Normal priority.
Jan 17 2019, 11:53 AM · Performance-Team
Peter triaged T214026: Create a list of what's needed for getting the mobile phone performance lab running as Normal priority.
Jan 17 2019, 11:52 AM · Performance-Team

Jan 16 2019

Peter closed T213676: Update Chrome using ADB as Resolved.

As I understands it, the only way to install is to have a full package file (apk) but that are not available for download for Chrome.

Jan 16 2019, 3:28 PM · WebPageReplay, Performance-Team
Peter closed T213676: Update Chrome using ADB, a subtask of T197847: Collect performance metrics from a mobile over time, as Resolved.
Jan 16 2019, 3:28 PM · Performance-Team
Peter closed T213833: 403 on http://wpt.wmftest.org as Resolved.

Number 1 will be made configurable (introduced 7 months ago!). Number 2 has been reverted.

Jan 16 2019, 3:15 PM · Upstream, WebPageTest, Performance-Team
Peter added projects to T213833: 403 on http://wpt.wmftest.org: WebPageTest, Upstream.

I fixed it now by doing some code changes on our local instance.

Jan 16 2019, 7:02 AM · Upstream, WebPageTest, Performance-Team
Peter added a comment to T213833: 403 on http://wpt.wmftest.org.

Argh this morning the start test URL is also failing: http://wpt.wmftest.org/testlog/1/

Jan 16 2019, 6:37 AM · Upstream, WebPageTest, Performance-Team

Jan 15 2019

Peter added a comment to T213833: 403 on http://wpt.wmftest.org.

I've updated the code to the latest version but no luck. I'll dig through the logs tomorrow.

Jan 15 2019, 7:07 PM · Upstream, WebPageTest, Performance-Team
Peter added a comment to T213833: 403 on http://wpt.wmftest.org.

Hmm trying manually a couple of days work http://wpt.wmftest.org/testlog.php?days=4&filter=&all=on but http://wpt.wmftest.org/testlog.php?days=30&filter=&all=on do not.

Jan 15 2019, 6:58 PM · Upstream, WebPageTest, Performance-Team
Peter added a comment to T175931: Add alert for authenticated users (SpeedIndex/firstVisualChange).

Let me try this out to see what kind of regression % we can catch.

Jan 15 2019, 1:06 PM · WebPageTest, Performance-Team
Peter moved T175931: Add alert for authenticated users (SpeedIndex/firstVisualChange) from Next in FY1819Q3 (Jan-Mar) to Doing on the Performance-Team board.
Jan 15 2019, 1:06 PM · WebPageTest, Performance-Team
Peter added a comment to T198287: Add alerts for all Browsertime/WebPageReplay wikis.

We don't have a good way to do to add a lot of alerts (since templating doesn't work in Grafana). That means that to setup alerts for a new Wikipedia we probably should create a new dashboard so we don't overlap the current one. Let us wait for a while and see which is the best way forward.

Jan 15 2019, 1:05 PM · Russian-Sites, Chinese-Sites, WebPageReplay, Performance-Team
Peter moved T198287: Add alerts for all Browsertime/WebPageReplay wikis from Next in FY1819Q3 (Jan-Mar) to Backlog: Future Goals on the Performance-Team board.
Jan 15 2019, 1:03 PM · Russian-Sites, Chinese-Sites, WebPageReplay, Performance-Team
Peter closed T209025: Drive a Moto G5 Chrome from a Raspberry Pi as Declined.

So I spent a lot of time on this with no luck. The problem at the moment is the ARM structure, that means we need to have a completely other Docker setup (installing versions compiled for ARM), and that will add overhead that I don't want at the moment. Also Chrome and Chromedriver do not have any official ARM builds (but that may change since Edge moves to Chromium and Windows uses ARM). Let close this for now and take it up again if we get a Chrome setup that automatically works on ARM.

Jan 15 2019, 1:02 PM · Performance-Team
Peter closed T209025: Drive a Moto G5 Chrome from a Raspberry Pi, a subtask of T197847: Collect performance metrics from a mobile over time, as Declined.
Jan 15 2019, 1:02 PM · Performance-Team

Jan 14 2019

Peter moved T207251: Test out different trace settings for Chrome from Doing to Blocked on the Performance-Team board.
Jan 14 2019, 9:49 PM · Browser-Support-Google-Chrome, WebPageReplay, Performance-Team
Peter moved T213261: Investigate difference in firstPaint/firstVisualChange using WebPageReplay compared to not using it from Inbox to Backlog: Small & Maintenance on the Performance-Team board.
Jan 14 2019, 8:56 PM · WebPageReplay, Performance-Team
Peter moved T213398: Move performance team dashboards to /performance/ folder in Grafana from Inbox to Doing on the Performance-Team board.
Jan 14 2019, 8:55 PM · Performance-Team
Peter claimed T213398: Move performance team dashboards to /performance/ folder in Grafana.
Jan 14 2019, 8:55 PM · Performance-Team
Peter moved T213676: Update Chrome using ADB from Inbox to Doing on the Performance-Team board.
Jan 14 2019, 8:51 PM · WebPageReplay, Performance-Team
Peter added a project to T213676: Update Chrome using ADB: WebPageReplay.
Jan 14 2019, 7:48 AM · WebPageReplay, Performance-Team
Peter triaged T213676: Update Chrome using ADB as Normal priority.
Jan 14 2019, 7:48 AM · WebPageReplay, Performance-Team
Peter added a comment to T213674: Possible first paint regression on mobile.

Added compare to last week graphs (scroll down):
https://grafana.wikimedia.org/d/000000572/webpagereplay-drilldown?orgId=1

Jan 14 2019, 7:21 AM · Performance-Team
Peter created T213674: Possible first paint regression on mobile.
Jan 14 2019, 7:02 AM · Performance-Team

Jan 11 2019

Peter added a comment to T213398: Move performance team dashboards to /performance/ folder in Grafana.

I'll like folders because it makes things more accessible for new users that comes to our dashboards. I've just started by adding a Performance dashboard and moved the WebPageTest/WebPageReplay dashboards there.

Jan 11 2019, 10:33 AM · Performance-Team
Peter closed T211352: Add info boxes on each graph/dashboard for WebPageReplay as Resolved.

All WebPageReplay dashboards are now updated.

Jan 11 2019, 7:15 AM · Performance-Team, WebPageReplay

Jan 10 2019

Peter renamed T213047: Add info boxes to the WebPageTest drilldown dashboard from Add info boxes to the WebPageTets drilldown dashboard to Add info boxes to the WebPageTest drilldown dashboard.
Jan 10 2019, 10:57 AM · WebPageTest, Performance-Team
Peter closed T213047: Add info boxes to the WebPageTest drilldown dashboard as Resolved.

Added info boxes with definition of each metrics that makes it easier to understand what we are showing in the graphs.

Jan 10 2019, 10:57 AM · WebPageTest, Performance-Team
Peter closed T211851: Remove unused keys in Graphite for WebPageReplay/WebPageTest as Resolved.

I've cleaned up all old WebPageTest data (WebPageRelay most where ok). Two things: we have tested from different locations (most when we tried out the new Linux versions) and there must have been a glitch somewhere where metrics keys where sent in lower case only, created double metrics. All these are fixed now.

Jan 10 2019, 8:48 AM · Patch-For-Review, WebPageTest, Performance-Team, WebPageReplay
Peter created T213398: Move performance team dashboards to /performance/ folder in Grafana.
Jan 10 2019, 8:33 AM · Performance-Team

Jan 9 2019

Peter added a comment to T211851: Remove unused keys in Graphite for WebPageReplay/WebPageTest.

I've updated https://grafana.wikimedia.org/d/000000095/webpagetest-drilldown and it looks good for enwiki and enwiki-mobile. Let me have a look for the rest and when they are cleaned up we can close this!

Jan 9 2019, 1:11 PM · Patch-For-Review, WebPageTest, Performance-Team, WebPageReplay
Peter added a comment to T211851: Remove unused keys in Graphite for WebPageReplay/WebPageTest.

And all URLs have been from these locations that we should not use:

  • eu-central-1
  • us-east-1-hosted-linux
  • us-east-1-linux
Jan 9 2019, 12:38 PM · Patch-For-Review, WebPageTest, Performance-Team, WebPageReplay
Peter closed T211747: Graphite generates a lot of 502 in Grafana as Resolved.

I cannot reproduce now, seems to be fixed, thank you @CDanis and @fgiunchedi !

Jan 9 2019, 12:28 PM · Performance-Team (Radar), monitoring, Graphite, Operations
Peter added a comment to T211851: Remove unused keys in Graphite for WebPageReplay/WebPageTest.

For browsertime we had one on the second key that was wrong *mobile* removed that too.

Jan 9 2019, 12:23 PM · Patch-For-Review, WebPageTest, Performance-Team, WebPageReplay
Peter added a comment to T211851: Remove unused keys in Graphite for WebPageReplay/WebPageTest.

We currently have these for WebPageTest in Graphite as second key:

Jan 9 2019, 12:14 PM · Patch-For-Review, WebPageTest, Performance-Team, WebPageReplay
Peter closed T211579: Test on multiple phones using one server as Resolved.
Jan 9 2019, 11:17 AM · Performance-Team
Peter added a comment to T211579: Test on multiple phones using one server.

No couldn't get reverse tethering to work on those phones. But I don't think we need that.

Jan 9 2019, 11:17 AM · Performance-Team
Peter triaged T213261: Investigate difference in firstPaint/firstVisualChange using WebPageReplay compared to not using it as Normal priority.
Jan 9 2019, 11:07 AM · WebPageReplay, Performance-Team
Peter closed T212485: Automatically match phone with bus/devnum as Resolved.

This seems to work fine.

Jan 9 2019, 11:02 AM · Performance-Team