Page MenuHomePhabricator

PeterBodifee
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 28 2017, 11:34 PM (249 w, 1 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
PeterBodifee [ Global Accounts ]

Recent Activity

May 16 2017

PeterBodifee renamed T165438: Extension MsCatSelect uses deprecated wgTitle in JavaScript code from Extension MsCatSelect won't add category to a page in MW 1.27 to Extension MsCatSelect uses deprecated wgTitle in JavaScript code.
May 16 2017, 6:03 PM · Technical-Debt, MediaWiki-extensions-MsCatSelect
PeterBodifee added a comment to T165438: Extension MsCatSelect uses deprecated wgTitle in JavaScript code.

After running runJobs.php the job queue was emptied in my test wiki (had 2944 entries, oops!) and the pages showed up on the category page. So that problem is gone.

May 16 2017, 6:01 PM · Technical-Debt, MediaWiki-extensions-MsCatSelect
PeterBodifee added a comment to T165438: Extension MsCatSelect uses deprecated wgTitle in JavaScript code.

I have removed the mscatselect extension for additional testing to see if there are no issues with adding categories to a page, and I do have this issue, even without mscatselect. According to here https://www.mediawiki.org/wiki/Topic:T8jd8uxlq4jqb0np the issue maybe with a backlog on the job queue (which I currently have).
Will report back later (or withdraw the bug report here).

May 16 2017, 1:01 AM · Technical-Debt, MediaWiki-extensions-MsCatSelect

May 15 2017

PeterBodifee created T165438: Extension MsCatSelect uses deprecated wgTitle in JavaScript code.
May 15 2017, 10:49 PM · Technical-Debt, MediaWiki-extensions-MsCatSelect

Apr 15 2017

PeterBodifee renamed T163056: [MassEditRegex] When more then 3 categories are specified, a database error occurs from When more then 3 categories are specified in MassEditRegex, an database error occurs to When more then 3 categories are specified in MassEditRegex, a database error occurs.
Apr 15 2017, 10:38 PM · MediaWiki-extensions-MassEditRegex
PeterBodifee created T163056: [MassEditRegex] When more then 3 categories are specified, a database error occurs.
Apr 15 2017, 10:38 PM · MediaWiki-extensions-MassEditRegex

Apr 14 2017

PeterBodifee added a comment to T162264: [new] and [reply] links on each section head not generating working URLs.

Thank you @Reedy for putting in the code changes in Gerrit. As I said before I am new to contributing to open source. Learning along the way, while helping my client.

Apr 14 2017, 5:21 PM · Patch-For-Review, MediaWiki-extensions-DiscussionThreading

Apr 13 2017

PeterBodifee added a comment to T162264: [new] and [reply] links on each section head not generating working URLs.

@Reedy Not familiar yet with the process, is there something I can do to update the code on github (see above)? Also note that I had to change it to manifest_version 1 as my wiki on 1.27.1 didn't like version 2.

Well, in that case, you're obviously using the incorrect branch/version of the extension to go with your MediaWiki version. It's generally not expected that random (older or newer) versions of an extension will work with random versions of MediaWiki

REL1_27 doesn't have an extension.json https://github.com/wikimedia/mediawiki-extensions-DiscussionThreading/tree/REL1_27 commit f9cc186

Apr 13 2017, 5:19 PM · Patch-For-Review, MediaWiki-extensions-DiscussionThreading
PeterBodifee added a comment to T162264: [new] and [reply] links on each section head not generating working URLs.

Also the addOnloadHook in the javaScript to select the text to be replaced is obsolete and needs to be replaced with jQuery (and elseif is not proper JS)

Apr 13 2017, 6:23 AM · Patch-For-Review, MediaWiki-extensions-DiscussionThreading
PeterBodifee updated subscribers of T162264: [new] and [reply] links on each section head not generating working URLs.

@Reedy Not familiar yet with the process, is there something I can do to update the code on github (see above)? Also note that I had to change it to manifest_version 1 as my wiki on 1.27.1 didn't like version 2.

Apr 13 2017, 5:40 AM · Patch-For-Review, MediaWiki-extensions-DiscussionThreading
PeterBodifee closed T162264: [new] and [reply] links on each section head not generating working URLs as Resolved.

First updated to 1.6.0 (b9da420)

Apr 13 2017, 5:35 AM · Patch-For-Review, MediaWiki-extensions-DiscussionThreading

Apr 12 2017

PeterBodifee added a comment to T162264: [new] and [reply] links on each section head not generating working URLs.

The warnings are caused by not setting $hint on line 34 in DiscussionThreading.class.php with an array value.

Apr 12 2017, 1:13 AM · Patch-For-Review, MediaWiki-extensions-DiscussionThreading

Apr 6 2017

PeterBodifee closed T162359: MsUpload 12.0 doesn't add upload icon nor drag&drop area when not using WikiEditor as Invalid.

Using the WikiEditor extension the icons and drag&drop area are added.

Apr 6 2017, 11:21 PM · MediaWiki-extensions-MsUpload
PeterBodifee added a comment to T161964: use of importScript in Special:MyPage/common.js fails in 1.27.1.

@Krinkle: cool! I suggest you update https://en.wikipedia.org/wiki/Template:Navpop as well (if appropriate) as it is referenced in the documentation.

Apr 6 2017, 10:04 PM · MediaWiki-ResourceLoader
PeterBodifee added a comment to T161964: use of importScript in Special:MyPage/common.js fails in 1.27.1.

@Krinkle Agree, and find that also in other extensions the documentation should stay better up to date. Now we as ' mediawiki deployments outside wikipedia' maintainers could certainly contribute, however the mentioned page is protected, so is my only option to provide additional information (e.g. that the manual installation method isn't working since 1.27+ and the resource loader options are specified in MediaWiki:Gadgets-definition) on the talk page?

Apr 6 2017, 9:44 PM · MediaWiki-ResourceLoader
PeterBodifee created T162359: MsUpload 12.0 doesn't add upload icon nor drag&drop area when not using WikiEditor.
Apr 6 2017, 1:22 PM · MediaWiki-extensions-MsUpload
PeterBodifee added a comment to T161964: use of importScript in Special:MyPage/common.js fails in 1.27.1.

@Aklapper I wasn't using any custom version importScript. My use of importScript in common.js worked flawlessly in 1.26.2 and not in 1.27.1 (where it caused an error). Not sure if we can conclude if there is no issue in the MediaWiki code. Or I am completely not understanding what I ran into.

Apr 6 2017, 12:51 PM · MediaWiki-ResourceLoader
PeterBodifee added a comment to T161964: use of importScript in Special:MyPage/common.js fails in 1.27.1.

@Krinkle I don't see any errors. It was late last night, forgot to clear cache on my browser. I have it working!

Apr 6 2017, 7:16 AM · MediaWiki-ResourceLoader

Apr 5 2017

PeterBodifee added a comment to T161964: use of importScript in Special:MyPage/common.js fails in 1.27.1.

@Krinkle Turned out the extension Gadgets was on the server, but not loaded in LocalSettings.php. So added the load statement.
Also corrected MediaWiki:Gadgets-definition per your description, added page MediaWiki:Gadget-Navigation popups and I do now have the Gadgets tab on my preferences, and checked the 'Navigation Popup' . Special pages Gadgets and GadgetUsage exist and work properly. So assuming extension Gadgets is set up properly.

Apr 5 2017, 8:00 PM · MediaWiki-ResourceLoader
PeterBodifee added a comment to T161964: use of importScript in Special:MyPage/common.js fails in 1.27.1.

@Krinkle I found navigation popups on Wikipedia at a time when I had no shell access and couldn't install extensions (luckily that has somewhat changed!)
So I copied the content on MediaWiki:Gadget-popups.js and MediaWiki:Gadget-navpop.css (I do have edit right for this namespace) from Wikipedia and used the 'manual installation' as described in section Installation here.
It worked fine on our production MW 1.26.2. Prepping now to upgrade to 1.27.1 on our test environment where I run into the issue as described above. But I have received shell access on our test env so I can now install the Gadget extension.
Will report back.

Apr 5 2017, 6:19 PM · MediaWiki-ResourceLoader
PeterBodifee added a comment to T161964: use of importScript in Special:MyPage/common.js fails in 1.27.1.

@Krinkle Not 100% sure if I understood you correctly. I added the page below. Still getting the reference error on importScript.

Screen Shot 2017-04-05 at 16.18.41 .jpg (158×989 px, 44 KB)

Apr 5 2017, 2:17 PM · MediaWiki-ResourceLoader
PeterBodifee created T162264: [new] and [reply] links on each section head not generating working URLs.
Apr 5 2017, 2:06 PM · Patch-For-Review, MediaWiki-extensions-DiscussionThreading

Apr 3 2017

PeterBodifee added a comment to T162071: Use of templates in #info: doesn't display properly in 'edit with from' (since SMW 2.5.0).

Opened this issue on Github for SMW: https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/2392

Apr 3 2017, 10:02 PM · MediaWiki-extensions-Page_Forms
PeterBodifee added a comment to T162071: Use of templates in #info: doesn't display properly in 'edit with from' (since SMW 2.5.0).

Good question!

Apr 3 2017, 9:32 PM · MediaWiki-extensions-Page_Forms
PeterBodifee updated the task description for T162071: Use of templates in #info: doesn't display properly in 'edit with from' (since SMW 2.5.0).
Apr 3 2017, 6:27 PM · MediaWiki-extensions-Page_Forms
PeterBodifee updated the task description for T162071: Use of templates in #info: doesn't display properly in 'edit with from' (since SMW 2.5.0).
Apr 3 2017, 5:21 PM · MediaWiki-extensions-Page_Forms
PeterBodifee updated the task description for T162071: Use of templates in #info: doesn't display properly in 'edit with from' (since SMW 2.5.0).
Apr 3 2017, 5:21 PM · MediaWiki-extensions-Page_Forms
PeterBodifee created T162071: Use of templates in #info: doesn't display properly in 'edit with from' (since SMW 2.5.0).
Apr 3 2017, 5:20 PM · MediaWiki-extensions-Page_Forms
PeterBodifee added a comment to T124978: Sort out PdfBook extension fork situation: Disable Wikimedia repo; link to GitHub/Gitlab repo.

I understood the actions above were for us to be able to clone just extension PdfBook from Organic Designs' Github, however the "clone or download" link is at the top-level of their complete Repo including even non-mediawiki code.

Apr 3 2017, 3:58 PM · Developer-Advocacy (Jan-Mar-2017), Patch-For-Review
PeterBodifee reopened T124978: Sort out PdfBook extension fork situation: Disable Wikimedia repo; link to GitHub/Gitlab repo as "Open".

Unfortunately

git clone https://github.com/OrganicDesign/extensions/tree/master/MediaWiki/PdfBook

results in

fatal: repository 'https://github.com/OrganicDesign/extensions/tree/master/MediaWiki/PdfBook' not found.

Am I missing something?

Apr 3 2017, 10:44 AM · Developer-Advocacy (Jan-Mar-2017), Patch-For-Review
PeterBodifee added a comment to T161729: input type=text with Autocomplete and input type=tree broken in Safari.

YES! Both Safari (Mac) and IE 11 (on Win7) are now working as well for autocomplete.
input type=tree is also good. Case can be closed.

Apr 3 2017, 8:56 AM · Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, MediaWiki-extensions-Page_Forms

Apr 1 2017

PeterBodifee added a project to T161729: input type=text with Autocomplete and input type=tree broken in Safari: Browser-Support-Internet-Explorer.
Apr 1 2017, 8:32 PM · Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, MediaWiki-extensions-Page_Forms
PeterBodifee added a comment to T161729: input type=text with Autocomplete and input type=tree broken in Safari.

Unfortunately it didn't. Still no autocomplete in Safari and IE. Maybe because the 'offending' line is still in the code (now on line 100)?

Apr 1 2017, 8:29 PM · Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, MediaWiki-extensions-Page_Forms
PeterBodifee created T161964: use of importScript in Special:MyPage/common.js fails in 1.27.1.
Apr 1 2017, 7:46 PM · MediaWiki-ResourceLoader

Mar 31 2017

PeterBodifee added a comment to T161729: input type=text with Autocomplete and input type=tree broken in Safari.

Still puzzled why 'importScript' gives me error in my TEST wiki (1.27.1). In my Production wiki (1.26.2) also using PageForms 4.1(22cc121) , I don't see this error. And this is consistent over the various browsers I have. Any pointers where I can post this bug?

Mar 31 2017, 9:26 PM · Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, MediaWiki-extensions-Page_Forms
PeterBodifee added a comment to T161729: input type=text with Autocomplete and input type=tree broken in Safari.

This is what "&debug=true" gives me: (Qqqq is the title of the test page with the form failing).

Mar 31 2017, 7:34 PM · Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, MediaWiki-extensions-Page_Forms
PeterBodifee added a comment to T161729: input type=text with Autocomplete and input type=tree broken in Safari.

Adding ?debug=true doesn't provide additional information on the console as far as I can see.

Mar 31 2017, 2:17 PM · Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, MediaWiki-extensions-Page_Forms
PeterBodifee added a comment to T161729: input type=text with Autocomplete and input type=tree broken in Safari.

Mar 9 and Mar 29 code exhibits same problem in IE 11.0.9600.

Mar 31 2017, 11:16 AM · Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, MediaWiki-extensions-Page_Forms

Mar 29 2017

PeterBodifee added a comment to T161729: input type=text with Autocomplete and input type=tree broken in Safari.

This is what I see when I start deleting characters in the field with autocomplete (Editor):

Screen Shot 2017-03-30 at 0.07.48 .jpg (665×1 px, 184 KB)

Mar 29 2017, 10:10 PM · Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, MediaWiki-extensions-Page_Forms
PeterBodifee added a comment to T161729: input type=text with Autocomplete and input type=tree broken in Safari.

See attached screen capture. Is this what you wanted to see?

Screen Shot 2017-03-30 at 0.04.36 .jpg (669×1 px, 178 KB)

Mar 29 2017, 10:05 PM · Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, MediaWiki-extensions-Page_Forms
PeterBodifee updated the task description for T161729: input type=text with Autocomplete and input type=tree broken in Safari.
Mar 29 2017, 5:47 PM · Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, MediaWiki-extensions-Page_Forms
PeterBodifee created T161729: input type=text with Autocomplete and input type=tree broken in Safari.
Mar 29 2017, 5:46 PM · Browser-Support-Internet-Explorer, Browser-Support-Apple-Safari, MediaWiki-extensions-Page_Forms

Mar 22 2017

PeterBodifee added a comment to T152153: simplesamlphp does not allow me to log in on Mediawiki 1.27.

Thank you Cindy, the debug statements helped me to see that there were errors made both in the parameter as well as in the value in LocalSettings.php. Have it now working that it will login.
You got to love interpreted code without syntax and type checking...

Mar 22 2017, 6:57 PM · MediaWiki-extensions-SimpleSAMLphp
PeterBodifee added a comment to T152153: simplesamlphp does not allow me to log in on Mediawiki 1.27.

We finally got the debug information to be logged; this is from a full cycle of mediawiki login (Aanmelden) to the external IdP host and back. The message in the red box we get on the mediawiki login screen reads: "Authentication or authorization failure."
Attached is de MediaWiki debug log file as well as the simplesamlphp log file.
We applied all the suggestions we could find around caching and sessions, but are now stuck. Any help/pointers are appreciated!

Mar 22 2017, 3:14 PM · MediaWiki-extensions-SimpleSAMLphp

Mar 14 2017

PeterBodifee closed T160007: mandatory is not recognized when input type=tree (Page Forms 4.1) as Resolved.

Thanks Yaron for your help. The suggested patch works!

Mar 14 2017, 8:25 PM · MediaWiki-extensions-Page_Forms

Mar 9 2017

PeterBodifee added a comment to T160007: mandatory is not recognized when input type=tree (Page Forms 4.1).

I have a suspicion the person who downloaded the code didn't activate(?) it properly. If I look Special:Version, am I supposed to see a something like " 4.1. (xxxxxx) Mar 8, 2017 " in the version column. I only see "4.1."

Mar 9 2017, 11:10 PM · MediaWiki-extensions-Page_Forms
PeterBodifee reopened T160007: mandatory is not recognized when input type=tree (Page Forms 4.1) as "Open".

I had the latest version of Page Forms downloaded as instructed. I also had verified that the code changes are indeed on our test site but I see no change in behaviour. The site is accessible from the internet but username/password protected. I can grant you access, email me at pbodifee@bauhaus.nl. I will also point you to my specific test where you are free to play around. Thanks for the help!

Mar 9 2017, 3:46 PM · MediaWiki-extensions-Page_Forms
PeterBodifee added a comment to T160007: mandatory is not recognized when input type=tree (Page Forms 4.1).

Thanks Yoran, but I need some help in instructing my technical application support person to download/install this fix, so I can test it on our test wiki. I am a n00b to this part of the game :-)

Mar 9 2017, 3:27 AM · MediaWiki-extensions-Page_Forms

Mar 8 2017

PeterBodifee renamed T160007: mandatory is not recognized when input type=tree (Page Forms 4.1) from mandatory is not recognized when input type=tree to mandatory is not recognized when input type=tree (Page Forms 4.1).
Mar 8 2017, 11:51 PM · MediaWiki-extensions-Page_Forms
PeterBodifee updated the task description for T160007: mandatory is not recognized when input type=tree (Page Forms 4.1).
Mar 8 2017, 11:50 PM · MediaWiki-extensions-Page_Forms
PeterBodifee created T160007: mandatory is not recognized when input type=tree (Page Forms 4.1).
Mar 8 2017, 11:49 PM · MediaWiki-extensions-Page_Forms

Feb 28 2017

PeterBodifee added a comment to T152153: simplesamlphp does not allow me to log in on Mediawiki 1.27.

I am wondering how we can map a SAML attribute (Group) we get from ADFS to a Mediawiki group. Is this possible with this extension, if yes, how?

Feb 28 2017, 11:39 PM · MediaWiki-extensions-SimpleSAMLphp