Page MenuHomePhabricator

Petrb (Petr Bena)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2014, 5:18 PM (366 w, 6 h)
Availability
Available
IRC Nick
petan
LDAP User
Petrb
MediaWiki User
Petrb [ Global Accounts ]

Hello, I am Petr Bena also known as Petrb (my SUL). I am a volunteer developer working on multiple projects, including Huggle, wm-bot and many others

Recent Activity

Fri, Oct 22

Petrb created T294090: Duplicate RFPP reports.
Fri, Oct 22, 10:17 AM · Huggle

Thu, Oct 14

Petrb triaged T293336: Speedy form message flow is fundamentally broken as High priority.
Thu, Oct 14, 9:17 AM · Huggle
Petrb created T293336: Speedy form message flow is fundamentally broken.
Thu, Oct 14, 9:17 AM · Huggle

Aug 13 2021

Petrb added a comment to T288104: Error "Result returned Aborted NeedToken expected" on edit.

also keep in mind that querydump may contain data that some people consider sensitive (their on-wiki activity obviously and some tokens, that are most likely expired), so make sure you inspect whatever you are about to send. If you hit this bug, I will need just last few queries, here is example of querydump from my PC:

Aug 13 2021, 9:14 PM · Huggle
Petrb added a comment to T288104: Error "Result returned Aborted NeedToken expected" on edit.

ok guys, it would really help if you could provide the querydump - I don't know which platform you are on, but if it's Windows, then you can just copy or modify Huggle shortcut and add --qd on end of it, then also change the working path to whatever path you want querydump to be stored in. You can also add a full path after like --qd C:\Temp\huggle.txt just make sure that huggle process will be able to write there.

Aug 13 2021, 9:09 PM · Huggle

Aug 12 2021

Petrb added a comment to T288104: Error "Result returned Aborted NeedToken expected" on edit.

btw you can try give it some absolute path instead like --qd /home/tobefree/snap/huggle/2773/.local/share/Wikimedia/Huggle/dump

Aug 12 2021, 8:01 AM · Huggle
Petrb added a comment to T288104: Error "Result returned Aborted NeedToken expected" on edit.

That's because you are running it via snap, so it's running inside a container, therefore huggle is not allowed to create any files on real filesystem, it creates the dump in container overlay FS which is cleaned up by the snapd when it exits. You would need to run it natively without any such restrictions.

Aug 12 2021, 7:59 AM · Huggle

Aug 6 2021

Petrb added a comment to T288104: Error "Result returned Aborted NeedToken expected" on edit.

Also I would like to stretch out that Huggle is very specific in its error messages, what you see is product of https://github.com/huggle/huggle3-qt-lx/blob/a57125fca76d1f5daa98896e3a3c00f146b2e555/src/huggle_ui/reloginform.cpp#L146

Aug 6 2021, 9:21 PM · Huggle
Petrb added a comment to T288104: Error "Result returned Aborted NeedToken expected" on edit.

Relogin form itself is triggered by function Configuration::Logout(WikiSite *site) which is called on multiple places, mostly when MW returns error code badtoken

Aug 6 2021, 8:54 PM · Huggle
Petrb added a comment to T288104: Error "Result returned Aborted NeedToken expected" on edit.

Now to the bug itself - this is a very old bug that I am trying to fix, which is actually reason why many of debug switches were implemented. I don't really know if it's somewhere in MediaWiki or Huggle itself.

Aug 6 2021, 8:46 PM · Huggle
Petrb added a comment to T288104: Error "Result returned Aborted NeedToken expected" on edit.

First of all, regarding the console outputs - these work only in console (--help etc) you won't see any output if you start the application using link from desktop, these switches are more useful on UNIX systems, here is example:

Aug 6 2021, 8:42 PM · Huggle

Jul 4 2021

Petrb triaged T286151: Fix queue icon for users who get blocked - it remains same after blocking user. as Medium priority.
Jul 4 2021, 11:53 AM · Huggle
Petrb created T286151: Fix queue icon for users who get blocked - it remains same after blocking user..
Jul 4 2021, 11:52 AM · Huggle

Jun 29 2021

Petrb removed a project from T285753: Improve developer manual for scripting interface in Huggle: good first task.
Jun 29 2021, 10:53 AM · Huggle
Petrb added a project to T285753: Improve developer manual for scripting interface in Huggle: good first task.
Jun 29 2021, 10:52 AM · Huggle
Petrb created T285753: Improve developer manual for scripting interface in Huggle.
Jun 29 2021, 10:52 AM · Huggle

Jun 28 2021

Petrb renamed T285565: Add banner to wm-bot's freenode logs browser that notifies about new Libera Chat logs browser from Make wm-bot browser read Libera Chat logs instead of Freenode logs to Add banner to wm-bot's freenode logs browser that notifies about new Libera Chat logs browser.
Jun 28 2021, 8:14 AM · wikimedia-irc-libera, WM-Bot
Petrb reopened T285565: Add banner to wm-bot's freenode logs browser that notifies about new Libera Chat logs browser, a subtask of T283249: Migrate wm-bot to libera.chat, as Open.
Jun 28 2021, 8:12 AM · wikimedia-irc-libera, WM-Bot
Petrb reopened T285565: Add banner to wm-bot's freenode logs browser that notifies about new Libera Chat logs browser as "Open".
Jun 28 2021, 8:12 AM · wikimedia-irc-libera, WM-Bot

Jun 14 2021

bd808 awarded T283249: Migrate wm-bot to libera.chat a Love token.
Jun 14 2021, 4:05 PM · wikimedia-irc-libera, WM-Bot

Jun 13 2021

Petrb closed T283249: Migrate wm-bot to libera.chat as Resolved.

ok I think this is done

Jun 13 2021, 9:47 AM · wikimedia-irc-libera, WM-Bot
Petrb closed T283249: Migrate wm-bot to libera.chat, a subtask of T283213: Move technical Wikimedia IRC bots from freenode to Libera Chat, as Resolved.
Jun 13 2021, 9:47 AM · User-bd808, Release-Engineering-Team (Radar), User-brennen, wikimedia-irc-libera, WMF-General-or-Unknown

Jun 3 2021

Petrb added a comment to T283249: Migrate wm-bot to libera.chat.

recent changes notifications were all migrated but you may need to run @recentchanges-on to get them enabled

Jun 3 2021, 8:57 PM · wikimedia-irc-libera, WM-Bot
Petrb updated the task description for T283249: Migrate wm-bot to libera.chat.
Jun 3 2021, 8:56 PM · wikimedia-irc-libera, WM-Bot
Petrb updated the task description for T283249: Migrate wm-bot to libera.chat.
Jun 3 2021, 8:55 PM · wikimedia-irc-libera, WM-Bot
Petrb updated the task description for T283249: Migrate wm-bot to libera.chat.
Jun 3 2021, 8:53 PM · wikimedia-irc-libera, WM-Bot
Petrb updated the task description for T283249: Migrate wm-bot to libera.chat.
Jun 3 2021, 8:53 PM · wikimedia-irc-libera, WM-Bot

Jun 2 2021

Petrb added a comment to T283249: Migrate wm-bot to libera.chat.

I appreciate your swiftness but I am not sure if everyone else does ;) it took me few days to notice what is going on with freenode, and I am fairly active in IRC world, I assume it will take months to realize this for others. Also running wm-bot on freenode costs us nothing, so unless new freenode staff starts causing us some serious issues with bot operation, I'd keep it.

Jun 2 2021, 7:22 PM · wikimedia-irc-libera, WM-Bot

May 24 2021

Petrb added a comment to T283249: Migrate wm-bot to libera.chat.

I created a new plugin that allows bridging freenode and libera - basically if you are admin in both channels, you can just run @bridge-on and bot will mirror messages in channel to second network. It's possible to create one way bridge as well (just don't run @bridge-on on other network). This works only if bot is present in same channel on both networks and if channel names are same.

May 24 2021, 5:58 PM · wikimedia-irc-libera, WM-Bot

May 23 2021

Petrb triaged T283249: Migrate wm-bot to libera.chat as Medium priority.
May 23 2021, 10:44 AM · wikimedia-irc-libera, WM-Bot
Petrb updated the task description for T283249: Migrate wm-bot to libera.chat.
May 23 2021, 10:43 AM · wikimedia-irc-libera, WM-Bot
Petrb added a comment to T283249: Migrate wm-bot to libera.chat.

I made a hack that will forward github messages via netcat to both instances of bot, but its still working with MySQL DB of freenode instance, so that's where the configuration of webhooks take place.

May 23 2021, 10:41 AM · wikimedia-irc-libera, WM-Bot
Petrb added a comment to T283249: Migrate wm-bot to libera.chat.

everyone has read access and everyone can submit pull requests, people who can merge pull requests:

May 23 2021, 10:23 AM · wikimedia-irc-libera, WM-Bot

May 22 2021

Petrb updated the task description for T283249: Migrate wm-bot to libera.chat.
May 22 2021, 3:33 PM · wikimedia-irc-libera, WM-Bot
Petrb updated the task description for T283249: Migrate wm-bot to libera.chat.
May 22 2021, 3:31 PM · wikimedia-irc-libera, WM-Bot
Petrb updated the task description for T283249: Migrate wm-bot to libera.chat.
May 22 2021, 11:34 AM · wikimedia-irc-libera, WM-Bot
Petrb added a comment to T283249: Migrate wm-bot to libera.chat.

I copied the old infobot DB's for all channels, including channels that bot is not in right now, that means when you @join the bot to these channels, their DB will prefill with freenode values.

May 22 2021, 11:33 AM · wikimedia-irc-libera, WM-Bot
Petrb updated the task description for T283249: Migrate wm-bot to libera.chat.
May 22 2021, 11:18 AM · wikimedia-irc-libera, WM-Bot

May 21 2021

Petrb updated the task description for T283249: Migrate wm-bot to libera.chat.
May 21 2021, 10:13 PM · wikimedia-irc-libera, WM-Bot
Petrb updated the task description for T283249: Migrate wm-bot to libera.chat.
May 21 2021, 10:12 PM · wikimedia-irc-libera, WM-Bot
Petrb added a comment to T283249: Migrate wm-bot to libera.chat.

also regarding "lack of maintainers" - I was never opposing having more maintainers of wm-bot (we actually have quite a team for such a small service) - if anyone can be trusted, has the necessary skills (knows GNU/Linux and IRC) and wants to help to maintain the bot, I am happy to give you access. Technical documentation is here: https://wikitech.wikimedia.org/wiki/Wm-bot I try to keep everything documented, and bot itself is fully open sourced: github.com/benapetr/wikimedia-bot

May 21 2021, 10:08 PM · wikimedia-irc-libera, WM-Bot
Petrb added a comment to T283249: Migrate wm-bot to libera.chat.

just few updates:

May 21 2021, 10:06 PM · wikimedia-irc-libera, WM-Bot
Petrb added a comment to T283249: Migrate wm-bot to libera.chat.

ok perhaps what would help me with deciding is knowing how urgent is this issue - do we need to fix it ASAP? if yes, I would just run another instance on same infrastructure, then we can migrate it later.

May 21 2021, 8:05 PM · wikimedia-irc-libera, WM-Bot
Petrb added a comment to T283249: Migrate wm-bot to libera.chat.

they are on "debian-10.0-buster (deprecated 2020-10-16) ", I don't mind installing them again, despite I am going to lose that nice hostname

May 21 2021, 7:48 PM · wikimedia-irc-libera, WM-Bot
Petrb added a comment to T283249: Migrate wm-bot to libera.chat.

@Legoktm I added you to horizon

May 21 2021, 7:45 PM · wikimedia-irc-libera, WM-Bot
Petrb added a comment to T283249: Migrate wm-bot to libera.chat.

ok, I am wondering if we keep them both on same VM, or just create a new one for libera, perhaps we could name it wm-bot-libera? From what I remember we also had dedicated postgre instance, but maybe postgre is now available as a service in cloud environment? that would be even better I think.

May 21 2021, 7:39 PM · wikimedia-irc-libera, WM-Bot
Petrb added a comment to T283249: Migrate wm-bot to libera.chat.

ok well, that's really sad news to me, I liked the old freenode. I am definitely going to support this new network that old staffers moved to. I already registered my nickname petan there.

May 21 2021, 7:37 PM · wikimedia-irc-libera, WM-Bot
Petrb added a comment to T283249: Migrate wm-bot to libera.chat.

Hello guys, sorry didn't notice this at all, I have no problems sharing the maintainer access to wm-bot with anyone, lots of people already asked in the past and I gave access to all of them (at least the trusted ones).

May 21 2021, 7:21 PM · wikimedia-irc-libera, WM-Bot

Nov 2 2020

Dzahn awarded T37947: Enable IPv6 on CloudVPS a Barnstar token.
Nov 2 2020, 7:06 PM · Epic, cloud-services-team (Kanban), SRE, IPv6, Cloud-VPS

Oct 5 2020

Petrb added a comment to T260105: Enable Huggle on viwiki.

Also if you already have other templates that could be used, you just need to change the template names in the yaml file, you can easily find them when you search for huggle/warn-

Oct 5 2020, 8:56 PM · Huggle
Petrb added a comment to T260105: Enable Huggle on viwiki.

Hello, sorry for coming so late to the party, what exactly do you need help with right now? I can already login to viwiki using Huggle, but obviously in read-only. If you want to enable write mode, I recommend translating the edit summaries in configuration file and importing / creating the warning templates:

Oct 5 2020, 8:52 PM · Huggle
Petrb added a comment to T262153: Document how to add new projects.

Hello, yes, but where?

Oct 5 2020, 8:47 PM · Documentation, Huggle
Petrb added a comment to T260120: [[Huggle:Shortcut-forward/vi]] translation issue.

I guess my answer resolved this?

Oct 5 2020, 8:44 PM · Huggle, I18n
Petrb added a comment to T260120: [[Huggle:Shortcut-forward/vi]] translation issue.

Ah yes, it's essentially tool tip for a forward button, which works just like in your web browser.

Oct 5 2020, 8:44 PM · Huggle, I18n

Jul 29 2020

Petrb closed T259012: Huggle cannot connect to XMLRCS feed on eswiki as Resolved.
Jul 29 2020, 7:46 AM · Huggle
Petrb added a comment to T259012: Huggle cannot connect to XMLRCS feed on eswiki.

It seems that xmlrcsd crashed on wmflabs, I don't really know why. It's restarted.

Jul 29 2020, 7:46 AM · Huggle

Jul 22 2020

Petrb claimed T249460: Deal with rvslots deprecation warning.
Jul 22 2020, 1:34 PM · Huggle
Petrb triaged T258553: Update Debian Linux installation of Huggle to latest version as Low priority.
Jul 22 2020, 1:34 PM · Huggle
Petrb added a comment to T251049: Make extension directory more easily configurable at compile time.

I am wondering how we could implement this, so that this path can be specified on one place only. Because it needs to be defined both in Huggle source code somehow (so that Huggle knows where to look for extensions) as well as CMake so that it knows where to write the compiled extensions.

Jul 22 2020, 1:33 PM · Huggle
Petrb triaged T251049: Make extension directory more easily configurable at compile time as Medium priority.
Jul 22 2020, 1:30 PM · Huggle
Petrb added a comment to T258553: Update Debian Linux installation of Huggle to latest version.

there is currently no maintainer for debian package format, it was replaced with snap format which is built automatically via Canonical's build farm. Unless someone takes over maintaining the .deb packages, I think we should obsolete it.

Jul 22 2020, 1:29 PM · Huggle

Apr 25 2020

Petrb added a comment to T250961: Snapcraft listing needs an update.

I'd like to at least connect beta releases to edge channel is there a way to do that?

Apr 25 2020, 2:19 PM · Huggle

Apr 24 2020

Petrb closed T250961: Snapcraft listing needs an update as Resolved.

I updated it to latest but I'd like to know how to automate this

Apr 24 2020, 9:28 PM · Huggle
Petrb added a comment to T250961: Snapcraft listing needs an update.

how can I change everyone to edge? I just know how to update to specific version

Apr 24 2020, 9:05 PM · Huggle

Apr 13 2020

Petrb lowered the priority of T157970: Huggle for wikispecies from Medium to Lowest.

lowering down since almost everything that devs are needed for was done, if you need any further help, please let me know

Apr 13 2020, 3:06 PM · Huggle
Petrb lowered the priority of T194607: Implement support for UWP from Medium to Lowest.
Apr 13 2020, 2:56 PM · Huggle

Apr 9 2020

Petrb closed T241250: Huggle uses deprecated `rvparse` as Resolved.

ok I couldn't find any issue after I removed it, I believe it's resolved now, this version with fix was not released yet, and even when it is, old versions of Huggle will still be used for a while though.

Apr 9 2020, 5:26 PM · Technical-Debt, Huggle
Petrb closed T246292: "This is not the latest revision" popup persists beyond edits as Resolved.
Apr 9 2020, 5:17 PM · Huggle
Petrb added a comment to T246292: "This is not the latest revision" popup persists beyond edits.

I can't really reproduce this, it seems it's not happening on Mac, but this should probably fix it: https://github.com/huggle/huggle3-qt-lx/commit/c6f964f60b2ba519e2643e21d060d61f7c6eebac

Apr 9 2020, 5:17 PM · Huggle

Apr 6 2020

Petrb added a comment to T249460: Deal with rvslots deprecation warning.

So the proposed fix should be implemented as this:

Apr 6 2020, 3:09 PM · Huggle

Apr 5 2020

Petrb added a comment to T249418: Exception When Clicking Rev Link.

The thing is I don't understand how could the stack jump from DisplayRevid to PostProcessEdit(), the function DisplayRevid doesn't have any call to that in it:

Apr 5 2020, 8:57 PM · Huggle
Petrb lowered the priority of T249418: Exception When Clicking Rev Link from High to Medium.

it isn't easy to repoduce, my guess it happened once only and never since?

Apr 5 2020, 8:53 PM · Huggle
Petrb triaged T249418: Exception When Clicking Rev Link as High priority.
Apr 5 2020, 8:38 PM · Huggle
Petrb updated the task description for T249418: Exception When Clicking Rev Link.
Apr 5 2020, 8:38 PM · Huggle
Petrb updated the task description for T249460: Deal with rvslots deprecation warning.
Apr 5 2020, 8:32 PM · Huggle
Petrb triaged T249460: Deal with rvslots deprecation warning as Medium priority.
Apr 5 2020, 8:31 PM · Huggle
Petrb created T249460: Deal with rvslots deprecation warning.
Apr 5 2020, 8:31 PM · Huggle

Mar 31 2020

Petrb added a comment to T199500: Show label and description in native or fallback languages instead of ID on Wikidata.

I see

Mar 31 2020, 10:21 PM · Wikidata, Huggle
Petrb added a comment to T241250: Huggle uses deprecated `rvparse`.

I mean, try to get some inspiration from UNIX, it was invented around 1970 and most of old C code from that time still compile on modern UNIXes... that's what I call a stable API :P

Mar 31 2020, 9:48 PM · Technical-Debt, Huggle
Petrb added a comment to T241250: Huggle uses deprecated `rvparse`.

There are multiple problems with this, it's burried in very old code that I wrote so long time ago I am not sure about the logic anymore. This commit removes it - https://github.com/huggle/huggle3-qt-lx/commit/8638b179899ff92b2a3ef2defcb6d17de511a791 but it needs some intensive testing, because I literally just removed the rvparse from API call and now I am observing what it broke.

Mar 31 2020, 9:47 PM · Technical-Debt, Huggle
Petrb added a comment to T199500: Show label and description in native or fallback languages instead of ID on Wikidata.

but is that something very specific only to wikidata? I am not sure if there is parsedcomment in other wikis? Or is there?

Mar 31 2020, 10:06 AM · Wikidata, Huggle

Mar 29 2020

Petrb closed T199633: Huggle added user warning in a discussion section not under a "month warning section" as Resolved.

https://github.com/huggle/huggle3-qt-lx/commit/25069ac9e6915f7e466341f36cddff1728b1c0c5

Mar 29 2020, 1:06 PM · WorkType-Maintenance, User-Josve05a, Huggle
Petrb closed T248433: Huggle edit-warring with itself when reverting edits on user talk pages as Resolved.

Really curious what else did I break while fixing this bug :)

Mar 29 2020, 12:27 PM · Huggle
Petrb added a comment to T248433: Huggle edit-warring with itself when reverting edits on user talk pages.

So I investigated this and found the reason, it's related to flow of current message system in connection with reverting:

Mar 29 2020, 11:22 AM · Huggle
Petrb closed T229190: Size of the false diff. as Invalid.

note this bug is not "invalid" there is just no better closure reason, such as "unreproducible"

Mar 29 2020, 10:44 AM · Huggle
Petrb added a comment to T229190: Size of the false diff..

I have to close this task as it's impossible to reproduce for me, if you run to this issue again, please have a look which feed provider is active - XmlRcs, IRC or API. Also please copy paste full system log from Huggle. That's very important for me.

Mar 29 2020, 10:34 AM · Huggle
Petrb added a comment to T229190: Size of the false diff..

this task is very hard to reproduce

Mar 29 2020, 10:32 AM · Huggle
Petrb triaged T229190: Size of the false diff. as Lowest priority.
Mar 29 2020, 10:32 AM · Huggle

Mar 27 2020

Petrb added a comment to T234082: Different definitions of "recently warned" for IP editors and registered editors are required.

Sorry to be late to the party - regarding "undocumented options", we keep documentation for options on place that not every one is probably aware of, here: https://www.mediawiki.org/wiki/Manual:Huggle/Deploying/DefaultConfig.yaml and even the options you claim to be undocumented, are in fact there ;)

Mar 27 2020, 9:23 PM · Huggle
Petrb triaged T234082: Different definitions of "recently warned" for IP editors and registered editors are required as Medium priority.
Mar 27 2020, 9:20 PM · Huggle
Petrb triaged T238877: Write Huggle labels to Jade as Medium priority.
Mar 27 2020, 9:19 PM · Huggle, Jade, Machine-Learning-Team
Petrb triaged T246292: "This is not the latest revision" popup persists beyond edits as Medium priority.
Mar 27 2020, 9:19 PM · Huggle
Petrb closed T248669: Make it possible to change default diff background and text colors as Resolved.
Mar 27 2020, 8:56 PM · Huggle
Petrb added a comment to T248669: Make it possible to change default diff background and text colors.

https://github.com/huggle/huggle3-qt-lx/commit/5607ec16236fdf2f1af17c0938ea1d7ca1275186

Mar 27 2020, 8:56 PM · Huggle
Petrb placed T166717: Huggle Revert and Warn Shortcuts Wrong in Mac up for grabs.
Mar 27 2020, 7:26 PM · Huggle
Petrb placed T70502: look for new messages on all projects up for grabs.
Mar 27 2020, 7:25 PM · patch-welcome, Google-Code-In-2016, WorkType-Maintenance, good first task, Huggle
Petrb placed T74433: MW API should allow Huggle to patrol edits when they are reverted up for grabs.
Mar 27 2020, 7:25 PM · Platform Engineering, WorkType-Maintenance, MediaWiki-API, Huggle
Petrb placed T225928: UI refactoring: Visual signals are hard to interpret up for grabs.
Mar 27 2020, 7:25 PM · Huggle
Petrb placed T225929: UI refactoring: Some helpful aspects are hard to identify up for grabs.
Mar 27 2020, 7:25 PM · Huggle
Petrb placed T232125: Using @translate without language parameters but with a multi-word translation string results in an exception up for grabs.
Mar 27 2020, 7:24 PM · WM-Bot