Petrb (Petr Bena)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2014, 5:18 PM (135 w, 4 d)
Availability
Available
IRC Nick
petan
LDAP User
Petrb
MediaWiki User
Petrb

Hello, I am Petr Bena also known as Petrb (my SUL). I am a volunteer developer working on multiple projects, including Huggle, wm-bot and many others

Recent Activity

Yesterday

Petrb added a project to T166465: Tab switching is not consistently re-enabling UI buttons: Huggle.
Sun, May 28, 11:30 AM · Huggle
Petrb created T166466: New tab should contain some built-in web page that explains how tab works in Huggle.
Sun, May 28, 11:30 AM · Huggle
Petrb created T166465: Tab switching is not consistently re-enabling UI buttons.
Sun, May 28, 11:29 AM · Huggle
Petrb added a comment to T166079: Allow to have something other than a cat when queue is empty.

I also commented out your call to Render() which I am not sure what would do, that function is used to render / display a WikiEdit in Huggle, it also refreshes all toolbars and so on, I think it could do something unwanted in case that CurrentEdit is not a null pointer (which it probably was when you tested this), if you know what you are doing, feel free to revert that

Sun, May 28, 9:38 AM · WorkType-NewFunctionality, Huggle
Petrb added a comment to T166079: Allow to have something other than a cat when queue is empty.

https://github.com/huggle/huggle3-qt-lx/commit/be96fc11b1da0c0105f41703d55df2e99b5ad4a3

Sun, May 28, 9:35 AM · WorkType-NewFunctionality, Huggle
Petrb added a comment to T166079: Allow to have something other than a cat when queue is empty.

I merged it but you might also want to add this to preferences form, so that user doesn't need to hack their own config page and can change this easily. I also think there should be information that this page can be modified in HG preferences on the default version.

Sun, May 28, 9:17 AM · WorkType-NewFunctionality, Huggle
Petrb added a comment to T166027: Huggle Crash Report [Null pointer exception]: The variable you referenced (edit->User) had null value..

Does it happen every time you login to hrwiki?

Sun, May 28, 9:02 AM · WorkType-Maintenance, Huggle

Thu, May 25

Petrb added a comment to T166079: Allow to have something other than a cat when queue is empty.

what someone doesn't like my cat D:

Thu, May 25, 12:52 PM · WorkType-NewFunctionality, Huggle

Tue, May 23

Petrb triaged T166106: Problems when reverting a talk page which belongs to user who is also receiving the warning as Normal priority.
Tue, May 23, 7:53 AM · Huggle
Petrb added a comment to T166106: Problems when reverting a talk page which belongs to user who is also receiving the warning.

It probably is related to talk page buffer which contains the source code of the page, it should be flushed but it's not for some reason

Tue, May 23, 7:53 AM · Huggle
Petrb created T166106: Problems when reverting a talk page which belongs to user who is also receiving the warning.
Tue, May 23, 7:52 AM · Huggle

Mon, May 22

Petrb added a project to T166044: sudo make install should install libraries to proper locations that actually work in most of distros: Huggle.
Mon, May 22, 10:59 AM · Huggle
Petrb created T166044: sudo make install should install libraries to proper locations that actually work in most of distros.
Mon, May 22, 10:59 AM · Huggle
Petrb created T166043: Fix the problems with Ubuntu launchpad or migrate to a different platform.
Mon, May 22, 10:57 AM · Huggle

Sun, May 21

Petrb created T165993: Cleanup the localization file en.xml.
Sun, May 21, 12:44 PM · Huggle

Sat, May 20

Petrb updated the task description for T165908: Enable Huggle on ta.wikipedia.org.
Sat, May 20, 6:02 PM · Tamil-Sites, Huggle
Petrb updated subscribers of T165908: Enable Huggle on ta.wikipedia.org.
Sat, May 20, 4:40 PM · Tamil-Sites, Huggle
Petrb created T165908: Enable Huggle on ta.wikipedia.org.
Sat, May 20, 4:40 PM · Tamil-Sites, Huggle
Petrb created T165890: Add new icons to huggle repo.
Sat, May 20, 2:28 PM · Huggle
Petrb created T165874: Implement queue filter that allows people to specify range of score of edits they want to see.
Sat, May 20, 1:01 PM · WorkType-NewFunctionality, Huggle
Petrb created T165873: Implement preferences option to change the queue size.
Sat, May 20, 1:00 PM · Easy, Huggle
Petrb created T165871: Implement refresh.
Sat, May 20, 12:56 PM · WorkType-NewFunctionality, Huggle
Petrb added a comment to T165858: Implement YAML parser and change config pages to it.

I am not sure though how would it look on wiki, we might check if page starts with <code> tag and trim it, so that config files look awesome on wiki as well, so the config pages would not be pure yaml, but yaml wrapped in wiki code, that we would unwrap before actually parsing it: https://test.wikipedia.org/wiki/Wikipedia:Huggle/Config.yml

Sat, May 20, 10:40 AM · Huggle
Petrb merged T165130: Make it possible to escape commas in configuration parser into T165858: Implement YAML parser and change config pages to it.
Sat, May 20, 10:28 AM · Huggle
Petrb merged task T165130: Make it possible to escape commas in configuration parser into T165858: Implement YAML parser and change config pages to it.
Sat, May 20, 10:28 AM · Huggle
Petrb created T165858: Implement YAML parser and change config pages to it.
Sat, May 20, 10:27 AM · Huggle

Fri, May 19

Petrb closed T165803: Login API shouldn't lock you out in case you make too many correct logins as Invalid.
Fri, May 19, 8:33 PM · MediaWiki-Authentication-and-authorization
Petrb added a comment to T165803: Login API shouldn't lock you out in case you make too many correct logins.

It's happening in parallel, I can try doing it in serial though.

Fri, May 19, 8:32 PM · MediaWiki-Authentication-and-authorization
Petrb created T165803: Login API shouldn't lock you out in case you make too many correct logins.
Fri, May 19, 7:35 PM · MediaWiki-Authentication-and-authorization
EddieGP awarded T112390: senseless edits of the huggle config a Like token.
Fri, May 19, 6:16 PM · WorkType-Maintenance, Huggle
Petrb closed T112390: senseless edits of the huggle config as Resolved.

Ths should fix it https://github.com/huggle/huggle3-qt-lx/commit/fff2f776131274ac97b474c1f2e4cd9b468e5246

Fri, May 19, 5:56 PM · WorkType-Maintenance, Huggle
Petrb closed T108240: Character encoding issue with wm-bot's *.txt files as Resolved.

Yay just 2 years to fix this!

Fri, May 19, 5:44 PM · WM-Bot
Petrb closed T137956: wmbot command for@seen should ignore trailing spaces after user name as Resolved.

I think it works already, I can't reproduce this

Fri, May 19, 5:28 PM · WM-Bot
Petrb closed T139419: Proxy configuration for wm-bot and botbot is wrong as Resolved.

So, I dropped botbot I don't really think there was anyone using it

Fri, May 19, 5:23 PM · WM-Bot
Petrb added a comment to T158464: Wm-bot recent changes is not visible from IRC.

Dumping anything to a channel doesn't sound like a best idea to me :( there are very strict limits set by freenode which require bot to send max 1 message per second. Given that it's already in almost 400 channels, it makes it really big problem for mq to stay low.

Fri, May 19, 5:19 PM · WM-Bot
Petrb closed T164776: Fallback to read-only mode in case user doesn't match requirements to enter project as Resolved.
Fri, May 19, 3:23 PM · Huggle
Petrb closed T138060: Supporting ORES on Huggle as Resolved.

In case there is some ORES feature that needs to be implemented, please give me specs, either reopen this or make a new task, thanks!

Fri, May 19, 2:14 PM · Scoring-platform-team, ORES, WorkType-NewFunctionality, Huggle
Petrb added a comment to T138060: Supporting ORES on Huggle.

I am just wondering, can we close this task? Huggle /does/ support ORES for long time, if there is a specific feature of ORES that isn't implemented in Huggle, then that would need to be specified in task description, right now I have absolutely no idea what to fix.

Fri, May 19, 2:13 PM · Scoring-platform-team, ORES, WorkType-NewFunctionality, Huggle
Petrb closed T155994: Huggle doesn't follow "default-summary" of huggle3.css personal config file as Resolved.
Fri, May 19, 2:11 PM · Huggle
Petrb added a comment to T115106: [Huggle] Picture Bug, when Queue is empty.

@Josve05a are you still having this problem, even with last beta: https://petr.insw.cz/huggle/huggle_3.2.0_beta2.exe

Fri, May 19, 2:09 PM · WorkType-Maintenance, Huggle
Petrb closed T89242: Fix XmlRcs convertor script - replace with EventStreams (es2r) as Resolved.
Fri, May 19, 2:08 PM · WorkType-Maintenance, Upstream, WM-Bot, Huggle
Petrb closed T112372: Color highlighting in diff window glitches as Resolved.

Fixed by @Isarra

Fri, May 19, 2:02 PM · CSS, WorkType-Maintenance, Huggle
Petrb renamed T89242: Fix XmlRcs convertor script - replace with EventStreams (es2r) from Fix XmlRcs convertor script to Fix XmlRcs convertor script - replace with EventStreams (es2r).
Fri, May 19, 12:02 PM · WorkType-Maintenance, Upstream, WM-Bot, Huggle

Mon, May 15

Framawiki awarded T165306: Hackathon session for Huggle devs - setting up build environment for huggle, intro to extensions and core development a Like token.
Mon, May 15, 4:17 PM · Wikimedia-Hackathon-2017, Huggle
Petrb added a comment to T112372: Color highlighting in diff window glitches.

this is example dump: http://petr.insw.cz/tmp/huggle.htm

Mon, May 15, 11:18 AM · CSS, WorkType-Maintenance, Huggle
Petrb closed T165022: Fix source code retrieval for webengine as Resolved.

15543390b61e2bd1bd60d5d0d15205233175c930

Mon, May 15, 11:14 AM · Huggle
Petrb triaged T165306: Hackathon session for Huggle devs - setting up build environment for huggle, intro to extensions and core development as Normal priority.
Mon, May 15, 10:48 AM · Wikimedia-Hackathon-2017, Huggle
Petrb moved T165306: Hackathon session for Huggle devs - setting up build environment for huggle, intro to extensions and core development from Backlog to Skill Share on the Wikimedia-Hackathon-2017 board.
Mon, May 15, 10:47 AM · Wikimedia-Hackathon-2017, Huggle
Petrb created T165306: Hackathon session for Huggle devs - setting up build environment for huggle, intro to extensions and core development.
Mon, May 15, 10:45 AM · Wikimedia-Hackathon-2017, Huggle

Fri, May 12

Petrb added a comment to T165130: Make it possible to escape commas in configuration parser.

https://github.com/jbeder/yaml-cpp

Fri, May 12, 7:48 AM · Huggle
Petrb added a comment to T165130: Make it possible to escape commas in configuration parser.

at some point we might eventually rethink whole configuration file schema, maybe we could simply make whole another config format that would be based on some open formats, like YAML

Fri, May 12, 7:46 AM · Huggle
Petrb created T165130: Make it possible to escape commas in configuration parser.
Fri, May 12, 7:45 AM · Huggle

Thu, May 11

Petrb closed T164870: Cannot start HG on fawiki: "Special:MyPage/huggle3.css is missing" as Resolved.

@Framawiki probably because your wiki requires it in Huggle config, check if require-config on your wiki

Thu, May 11, 10:00 AM · Huggle
Petrb created T165022: Fix source code retrieval for webengine.
Thu, May 11, 9:58 AM · Huggle

Mon, May 8

Petrb changed the status of T150100: Huggle doesn't mark good edits as patrolled from Open to Stalled.

try to update the config and let me know about the result!

Mon, May 8, 8:48 PM · Huggle
Petrb added a comment to T161820: Enable Huggle on bn.wikipedia.org.

Whitelist created

Mon, May 8, 6:58 PM · Bengali-Sites, Huggle
Petrb updated the task description for T161820: Enable Huggle on bn.wikipedia.org.
Mon, May 8, 6:58 PM · Bengali-Sites, Huggle
Petrb created T164776: Fallback to read-only mode in case user doesn't match requirements to enter project.
Mon, May 8, 6:12 PM · Huggle
Petrb triaged T160626: investigate weird edit (cross edit from spanish -> simple wiki) / memory corruption or struct inconsistency? as Normal priority.
Mon, May 8, 6:08 PM · Huggle
Petrb triaged T141451: Warning level on frwiki as Normal priority.
Mon, May 8, 6:07 PM · Huggle
Petrb triaged T161797: Document all site config options as Normal priority.
Mon, May 8, 6:07 PM · Easy, Need-volunteer, Huggle
Petrb triaged T164775: Implement language dialog in welcome screen as Normal priority.
Mon, May 8, 6:06 PM · Easy, Huggle
Petrb created T164775: Implement language dialog in welcome screen.
Mon, May 8, 6:06 PM · Easy, Huggle
Petrb triaged T158700: Enable Huggle for hr.wiki, bs.wiki, sr.wiki and sh.wiki as Normal priority.
Mon, May 8, 6:02 PM · Huggle
Petrb changed the status of T156627: UAA for eswiki from Open to Stalled.

You can get latest builds of huggle here: https://petr.insw.cz/huggle/

Mon, May 8, 5:53 PM · Spanish-Sites, Huggle
MusikAnimal awarded T164758: Allow admins to choose which branch(es) are said by wm-bot on IRC a Like token.
Mon, May 8, 4:06 PM · WM-Bot

Tue, May 2

Petrb added a comment to T141451: Warning level on frwiki.

There is a syntax error in warning-template-tags: it needs to contains a dictionary of items if this format:

Tue, May 2, 2:14 PM · Huggle

Mon, May 1

Petrb added a comment to T158700: Enable Huggle for hr.wiki, bs.wiki, sr.wiki and sh.wiki.

testing on production sites of anything is never welcome, you can run huggle in a dry mode if you need to test stuff (start huggle in debug mode, then help -> debug -> dry).

Mon, May 1, 8:24 PM · Huggle

Sat, Apr 29

Petrb added a comment to T161939: Remove wm-bot as the founder of ##MarcosDias-ops.

btw running telnet to bot and executing "send PRIVMSG chanserv: whatever command you wanted to execute" would probably work in this case

Sat, Apr 29, 1:17 PM · WM-Bot

Apr 21 2017

Petrb closed T155334: Add option to queue filter to filter out registered users as Resolved.

2ee3ebab066bd9bdc1f1c89d3289d0e29f1e26e4

Apr 21 2017, 12:49 PM · Huggle
Petrb added a comment to T155334: Add option to queue filter to filter out registered users.

Also right now there are filters for both "IP" and "Registered" which is redundant I think

Apr 21 2017, 11:57 AM · Huggle
Petrb added a comment to T155334: Add option to queue filter to filter out registered users.

Yes there seem to be some skeleton in the class itself, but the actual code that would make it work is missing

Apr 21 2017, 11:55 AM · Huggle
Petrb added a comment to T149290: Enable Huggle on Commons.

I don't remember, but it's possible, however I fairly sure the configuration wasn't finished otherwise this task wouldn't be still open. I think that warning templates and commons specific configuration is missing.

Apr 21 2017, 10:51 AM · Commons, Huggle

Apr 12 2017

Petrb reopened T105560: Add a publisher as "Stalled".

Declining a task doesn't solve it.

Apr 12 2017, 11:42 AM · WorkType-NewFunctionality, Huggle

Apr 9 2017

Petrb raised the priority of T112372: Color highlighting in diff window glitches from Lowest to High.
Apr 9 2017, 3:09 PM · CSS, WorkType-Maintenance, Huggle
Petrb closed T114710: Huggle antivandalism network should make a tone, when someone writes something as Resolved.
Apr 9 2017, 3:08 PM · Google-Code-In-2015, Easy, WorkType-NewFunctionality, Huggle
Petrb closed T114710: Huggle antivandalism network should make a tone, when someone writes something, a subtask of T155570: Implement cross platform audio system, as Resolved.
Apr 9 2017, 3:08 PM · Huggle

Apr 4 2017

Petrb added a comment to T162120: Huggle randomly sends warnings for reverts that didn't happen.

it works to me: https://en.wikipedia.org/wiki/Special:Contributions/Petrb

Apr 4 2017, 2:04 PM · Huggle
Krenair awarded T162120: Huggle randomly sends warnings for reverts that didn't happen a The World Burns token.
Apr 4 2017, 11:18 AM · Huggle
Petrb closed T162120: Huggle randomly sends warnings for reverts that didn't happen as Resolved.

https://github.com/huggle/huggle3-qt-lx/commit/13e64040557588fedf3fe4431b2c29b0639cbc84

Apr 4 2017, 9:36 AM · Huggle
Petrb added a comment to T162120: Huggle randomly sends warnings for reverts that didn't happen.

This commit caused it https://github.com/huggle/huggle3-qt-lx/commit/ebecb24fa4bc8974a0b5c3cdfd5aa4d8cb8382ed

Apr 4 2017, 9:32 AM · Huggle
Petrb added a comment to T162120: Huggle randomly sends warnings for reverts that didn't happen.

The problem is caused by possible change in revert logic in mainwindow.cpp (I don't know which commit caused this though) it seems that now for some reason we jump to next edit right after call to Revert() and subsequent WarnUser call work with this->CurrentEdit, which in that moment points to next edit in queue (or nullptr in case there is no more).

Apr 4 2017, 9:26 AM · Huggle
Petrb added a comment to T162120: Huggle randomly sends warnings for reverts that didn't happen.

To reproduce you can revert and warn anything, huggle obviously use next edit as dependency for rollback

Apr 4 2017, 9:12 AM · Huggle
Petrb added a comment to T162120: Huggle randomly sends warnings for reverts that didn't happen.

It might be also useful if someone could try to identify all users who use this version of huggle (3.2.0) either by scanning the edit summaries or huggle3.css and then notify these users about this issue

Apr 4 2017, 9:08 AM · Huggle
Petrb added a comment to T162120: Huggle randomly sends warnings for reverts that didn't happen.

Is there any simple step to reproduce this?

Apr 4 2017, 8:58 AM · Huggle
Petrb triaged T162120: Huggle randomly sends warnings for reverts that didn't happen as Unbreak Now! priority.
Apr 4 2017, 8:57 AM · Huggle
Petrb added a comment to T162120: Huggle randomly sends warnings for reverts that didn't happen.

Mentioned commit id is irrelevant though could be anywhere from 3.1.21

Apr 4 2017, 8:57 AM · Huggle
Petrb created T162120: Huggle randomly sends warnings for reverts that didn't happen.
Apr 4 2017, 8:56 AM · Huggle

Mar 31 2017

Petrb added a comment to T157970: Huggle for wikispecies.

Huggle was configured for wikispecies, but I set it to be read only until warning templates for it are created

Mar 31 2017, 1:12 PM · Huggle
Petrb updated the task description for T157970: Huggle for wikispecies.
Mar 31 2017, 1:12 PM · Huggle
Petrb updated the task description for T157970: Huggle for wikispecies.
Mar 31 2017, 12:52 PM · Huggle
Petrb updated the task description for T157970: Huggle for wikispecies.
Mar 31 2017, 12:50 PM · Huggle
Petrb updated the task description for T157970: Huggle for wikispecies.
Mar 31 2017, 12:50 PM · Huggle
Petrb closed T155332: Queue / UI: Play a sound when new item is added to queue as Resolved.

2e596042ad27 adds this

Mar 31 2017, 12:46 PM · Huggle
Petrb closed T155332: Queue / UI: Play a sound when new item is added to queue, a subtask of T155570: Implement cross platform audio system, as Resolved.
Mar 31 2017, 12:46 PM · Huggle
Petrb triaged T155333: Tag filter in preferences removes white space for some reason as High priority.
Mar 31 2017, 11:42 AM · Huggle
Petrb updated the task description for T161820: Enable Huggle on bn.wikipedia.org.
Mar 31 2017, 11:41 AM · Bengali-Sites, Huggle
Petrb triaged T161820: Enable Huggle on bn.wikipedia.org as High priority.
Mar 31 2017, 11:40 AM · Bengali-Sites, Huggle
Petrb closed T154284: [[Huggle:Query-execute-drymode/en-gb]] i18n issue as Resolved.

I removed this string from localization now

Mar 31 2017, 11:40 AM · Huggle, I18n
Petrb triaged T150089: Document all missing keys in translate docs as Low priority.
Mar 31 2017, 11:37 AM · Need-volunteer, Easy, I18n, Huggle