Page MenuHomePhabricator

Phispi
User

Projects

User does not belong to any projects.

Today

  • No visible events.

Tomorrow

  • No visible events.

Thursday

  • No visible events.

User Details

User Since
Dec 11 2014, 8:18 PM (595 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Phispi [ Global Accounts ]

Recent Activity

Jun 10 2024

Phispi added a comment to T351610: Support minification of ES2020 Nullish operator syntax.

A big thank you to everybody working on this! @Krinkle: I'll follow your recommendation to include the slint-config-wikimedia package, thanks.

Jun 10 2024, 6:34 PM · MediaWiki-Platform-Team, MediaWiki-Engineering, Wikimedia-Minify

Nov 20 2023

Phispi added a comment to T351613: "string literal contains an unescaped line break" after minification.

Thank you for looking into this and sorry that I have caused work by creating a bug report for a behavior that is not supported by design. To my defense: I did check at https://doc.wikimedia.org/mediawiki-libs-Minify/master/ (the README.md file) whether any restriction in supported Ecmascript versions is listed. Thanks for pointing to the commonly agreed eslint configuration disallowing certain new features in the MediaWiki universe - I didn't know that.

Nov 20 2023, 6:11 PM · MediaWiki-Platform-Team, Wikimedia-Minify

Nov 19 2023

Phispi added a comment to T351613: "string literal contains an unescaped line break" after minification.

Thank you! I just tested whether the newest master branch (cfe7568b) fixes the problem by copying the content to the MediaWiki 1.39.5 vendor/wikimedia/minify folder and purging a page. I'm still getting the Uncaught SyntaxError: "" string literal contains an unescaped line break error.

Nov 19 2023, 10:18 PM · MediaWiki-Platform-Team, Wikimedia-Minify
Phispi updated the task description for T351610: Support minification of ES2020 Nullish operator syntax.
Nov 19 2023, 9:36 PM · MediaWiki-Platform-Team, MediaWiki-Engineering, Wikimedia-Minify
Phispi added a comment to T351610: Support minification of ES2020 Nullish operator syntax.

Adding /*@nomin*/ close to the end of the file to prevent minification helps as workaround.

Nov 19 2023, 9:33 PM · MediaWiki-Platform-Team, MediaWiki-Engineering, Wikimedia-Minify
Phispi added a comment to T351613: "string literal contains an unescaped line break" after minification.

I can imagine that it's quite hard to write a fast minifier that can cope with alreay minified complex input, it might be an alternative to reconsider https://phabricator.wikimedia.org/T346701 .

Nov 19 2023, 9:17 PM · MediaWiki-Platform-Team, Wikimedia-Minify
Phispi created T351613: "string literal contains an unescaped line break" after minification.
Nov 19 2023, 9:13 PM · MediaWiki-Platform-Team, Wikimedia-Minify
Phispi renamed T351610: Support minification of ES2020 Nullish operator syntax from Minifyer insert line break between `return` and returned value in Javascript to Minifier insert line break between `return` and returned value in Javascript.
Nov 19 2023, 8:45 PM · MediaWiki-Platform-Team, MediaWiki-Engineering, Wikimedia-Minify
Phispi added a comment to T351610: Support minification of ES2020 Nullish operator syntax.

The bug report https://phabricator.wikimedia.org/T277161 might be related but as it is marked resolved in an earlier version I assume it's something else.

Nov 19 2023, 8:38 PM · MediaWiki-Platform-Team, MediaWiki-Engineering, Wikimedia-Minify
Phispi added a comment to T351610: Support minification of ES2020 Nullish operator syntax.
Nov 19 2023, 6:48 PM · MediaWiki-Platform-Team, MediaWiki-Engineering, Wikimedia-Minify
Phispi created T351610: Support minification of ES2020 Nullish operator syntax.
Nov 19 2023, 6:47 PM · MediaWiki-Platform-Team, MediaWiki-Engineering, Wikimedia-Minify

Nov 4 2023

Phispi closed T57526: $parser->recursiveTagParse($input) does not escape & consistently. as Resolved.
Nov 4 2023, 8:54 PM · MediaWiki-Parser
Phispi added a comment to T57526: $parser->recursiveTagParse($input) does not escape & consistently..

To follow up on my old bug report I re-checked the functionality in MediaWiki 1.39. Function recursiveTagParse( $text, $frame = false ) still doesn't escape the ampersands but the function description clearly says that it only returns "half-parsed HTML". In contrast, the function recursiveTagParseFully( $text, $frame = false ) returns "fully parsed HTML" and I can confirm that this function does encode ampersands correctly. So I propose to close this task.

Nov 4 2023, 8:54 PM · MediaWiki-Parser

Mar 29 2022

Phispi created T304993: Bots cannot change contentmodel ('editcontentmodel' not in $wgGrantPermissions).
Mar 29 2022, 8:30 PM · MW-1.35-notes, MW-1.35-release, MediaWiki-User-management

Jan 10 2020

Phispi added a comment to T50767: Support 'utf8mb4' character set in MySQL 5.5 and above.

I stumbled upon this report when trying to solve my MediaWiki 1.31 utf8 issues with emojis. My MariaDB tables mostly had the utf8 (utf8mb3) encoding active causing the problem. I realized that the decision was made to recommend/support binary encodings of text column for MariaDB/MySQL only (containing UFT-8 raw data). Despite I would have preferred to switch to utf8mb4, I will stick to that recommendation and changed my columns to the up-to-date MediaWiki SQL schema.

Jan 10 2020, 8:29 PM · MediaWiki-libs-Rdbms

Apr 11 2017

Phispi added a comment to T152050: "de-formal" is no valid HTML language code.

For me, the following fix works (although I admit it's not a very general solution):

Apr 11 2017, 8:04 PM · MediaWiki-General, MediaWiki-Internationalization

Nov 30 2016

Phispi created T152050: "de-formal" is no valid HTML language code.
Nov 30 2016, 10:26 PM · MediaWiki-General, MediaWiki-Internationalization

Dec 11 2014

Phispi created T78333: API warning: Too many values supplied for parameter "pageids". The limit is 50..
Dec 11 2014, 9:00 PM · Pywikibot