In T263664#6572984, @ifried wrote:

… However, as we discussed it, it seemed to make sense to leave the clock icon (striked out upon unwatch), since everything else is also striked out (and it would be visually jarring to remove it).

Pinging @Prtksxna, just in case I missed something/my logic is off. Thanks!

In T266262#6572394, @ifried wrote:

@Prtksxna The engineers have discussed that this would be much easier to implement if we prevent users from leaving the page, rather than allowing the download pop-up to continue if they go to another page. What do you think? Is this okay?

Thanks @dom_walden.
@Niharika, so the only thing left here is the nice to have scroll to reveal feature.

In T261646#6528889, @Tchanders wrote:

@Prtksxna @Niharika How important is highlight on keyboard focus vs the ability to select text?

In T264773#6529688, @ifried wrote:

@Prtksxna Do you have any recommendations for how this should be handled? Thanks in advance!

In T260217#6517008, @dom_walden wrote:

Have these been fixed in T261651?

In T263540#6509637, @Niharika wrote:

We can remove it three weeks after we have launched the new feature everywhere. Does that sound okay?

@dom_walden could you look at this task description and tell us what from this not happening at the moment?

Some issues that I am seeing:

• When you tab to a Username cell, the ellipsis button is hidden and you can't tab to it (or its menu)
• When something is pinned, no other cells show the ellipsis button when focussed

@dom_walden, is the 'tab-stuck' behaviour happening on all skins?

In T261430#6514197, @ifried wrote:

• The scenario described in the second bulletpoint sounds okay, if I understand it correctly, since the user has completed the watch selection and can then can at least continue tabbing through the page. Curious to hear Prateek's opinion.

Sounds good, thanks @Volker_E. We'll stick to changing only the opacity for now :)

Volker, I was under the impression that using a color instead of opacity would be better because:

1. We won't be introducing a new gray, and will be limited to what is defined in the style guide.
2. On different background colors (especially darker ones) the black icon with opacity won't be visible, but gray would.

In T261415#6490318, @Samwilson wrote:

Is it possible to create differently-colored icon images? The existing normal/progressive/destructive are created at OOUI build time, I think. Or should we duplicate the clock icon and change it for this?

In T261415#6485978, @Samwilson wrote:

@ifried Should the clock be grey and smaller in Minerva, to match how it is in other skins? Or is it meant to be larger and black?

In T260239#6483578, @Volker_E wrote:

In T260239#6477685, @Prtksxna wrote:

• Success / Warning / Error / Info notices

Would you expand on that under light of https://design.wikimedia.org/style-guide/components/messages.html

In T263412#6479278, @Aklapper wrote:

Given the many disputed territories on this planet, and in some territories also de-facto governments and their preferred flags, which actual problem is solved by adding potentially controversial flags, and how does the solution outweigh the additional tension introduced?

Probably low priority, but would like to propose:

• Panels / Fieldsets
• Dialog - Hover cards / Page previews
• Success / Warning / Error / Info notices

Wow, that was fast!

In T262862#6475363, @dmaza wrote:

@Prtksxna Can you confirm that the animation transitions we agreed on are the following?

Hey @Jdlrobson 🙋🏾‍♂️! We are trying to figure out how the star animation would work with temporary watching. In conversation, @dmaza just pointed out that on mobile, when a page is watched, the star rotates every time the page is refreshed. I wanted to know if this was intentional and what the reason behind this was.

In T261990#6466708, @MusikAnimal wrote:

Note also the dropdown itself either needs to be full-width or centered.

In T261178#6453854, @Tchanders wrote:

• I find sometimes I can reveal more of the drawer's content when I scroll. Is this deliberate? Is this T261178#6439649?

This isn't deliberate - it's also not the suggestion from that comment (@Prtksxna will file that separately).

In T259055#6436881, @ifried wrote:

2. In all other cases, does the success message round down rather than up? My personal opinion is that it's probably better to round down, since users don't want to miss out on a page expiring earlier than they expected (basically, "better safe than sorry"). I think we discussed this in the past, but perhaps this wasn't recorded in a Phabricator ticket. Do you agree with this analysis, @Prtksxna?

In T261178#6434950, @dbarratt wrote:

@Prtksxna What do you think? Do you like it exposing it on "See More" or should it scroll?

This is what I see on mobile at the moment:

Yep, getting rid of #7 makes sense. I mostly see #2 or #6 spinning any way. The only way to see #7 (for me on Chrome on MacOS) is to click the star so that it starts spinning and click somewhere else so that it loses focus.

In T261088#6427073, @dom_walden wrote:

Now, when you hover over a cell all matching rows also have the faded yellow background.

In T261178#6420830, @dbarratt wrote:

@Prtksxna Is this ready to be implemented?

The watchlist popup’s elment isn’t added right after the star icon (in the DOM of the page). This means that there are several elements that the user has to tab through (in 5 seconds) to be able to reach the dropdown. This is not good for keyboard accessibility.

In T253932#6410183, @ifried wrote:

1. How do you suggest that we handle scenarios in which the text for "XX days left" will cut off and go to the next line? Should the entire text be one unit, so that it is only on the same line as the title or directly below?

@Samwilson What do you make of the PDF downloads? I thought the current PDF link goes to Electron, and there is no way to get a PDF except by using the tool directly. Could these be coming from French and Bengali?

In T259775#6407514, @Tchanders wrote:

Three buttons might not work as well for languages with longer words:

Thanks @JJMC89 and @Tchanders 🙏🏽

In T260217#6402731, @dom_walden wrote:

• It is possible to use the keyboard to open (and use) the Filters menu, but it does not always show any indication that it has focus (e.g. a dotted border).

In T259755#6401601, @dbarratt wrote:

Making this change puts the page in the fixed position, and the drawer in the scrollable (static) position. Then the block drawer could include a message like "See the reason for the block below" (with an upside down triangle?). The user would scroll the drawer upward revealing the block reason. They can scroll all the way to the top to "hide" it.

All rows with same matching UA/IP are highlighted (not just the one cell). The cell being highlighted in darker yellow (#fc3?) and the rest of the cells in the row are the lighter shade (#fef6e7?)

Here is the half filled star.

Updated T259775: Improve call to action in block drawer with the corresponding actions.

The button Take me to another page would go to Special:Random. I am not happy with that label. Suggestions are welcome!

Updated T259774: Improve messaging of block drawer with these changes.

Yeah, I agree @Tchanders. Let's go with IP address.

In T260216#6393913, @Tchanders wrote:

@Prtksxna What do you think of connection vs network?

Thank you so much for doing this @Tchanders 🙏🏽This is really helping me understand all the permutations.

In T260217#6393488, @Tchanders wrote:

@Prtksxna I think we should avoid focusing the cell on click (I've suggested a fix on the patch), since it creates some confusing behaviour.

T255644: CU 2.0: Implement a GuidedTour for Special:Investigate onboarding

Video on commons - https://commons.wikimedia.org/wiki/File:Introduction_to_Special_Investigate.webm
English subtitles - https://commons.wikimedia.org/wiki/TimedText:Introduction_to_Special_Investigate.webm.en.srt

Noting some of the resources I am looking at (so that I don't lose track of them):

• https://www.w3.org/TR/wai-aria-practices/#alertdialog
• https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/alertdialog.html
• https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_alert_role
• https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions
• https://www.w3.org/TR/WCAG20-TECHS/ARIA19.html
• https://www.w3.org/TR/wai-aria-practices-1.1/examples/alert/alert.html
• https://www.carbondesignsystem.com/components/notification/accessibility/
• https://inclusive-components.design/notifications/

In T259647#6375256, @dom_walden wrote:

Yes. I think Harumi is working on it in T258662#6352761.

@ifried has created T260184: Watchlist Expiry: indicate days left for temporary watch upon delete/move

@dom_walden can you help me note down the current behavior of the popup. Looking at test.wiki on Chrome, I see:

• If you don't do anything the popup disappears in ~5 seconds
  • The popup disappears when hovering over it (I could swear it sometimes stays when you hover)
  • The popup disappears when the dropdown is open (I could swear it sometimes stays when the dropdown is open)
  • The popup disappears when a link or form element is in focus
• Clicking outside the popup doesn't dismiss it
• Clicking on the popup (anywhere but the link or the dropdown) dismisses it

Is this what you see too?

1. the user has selected temporary watch for a reason & can see the temporary watch status on the page already,

Yes. The status of their selection isn't visible in the form and dropdown. This selection could have been made a long time ago, thus the confusion.

Based on @cwylo's findings I suppose we'll have to have all the search functionality that CU has right now.

• We'll need to OOUI-ify the form
• The initiator and target radio is a bit confusing, especially since clicking initiator doesn't change the first text fields label

Thanks for sharing the screenshots @dom_walden. This looks good.

In today's engineering meeting we discussed:

1. We should keep the drawer
   1. It should show a text version of the reason if its available.
   2. If a text reason is not available we'll show a link to see the full reason. We didn't decide whether the link will take the user to a new page or an expanded version of the drawer
2. The reason field doesn't always have a reason, for example the template for anonblock.
3. As @Esanders points out in his comment it is important to tell the user what actions they can take.

Would disabling pointer events on the overlay help? I don't know how the event stuff works though.

In T256280#6359499, @Tchanders wrote:

@Prtksxna I have a few questions:

• What icons should we put on the contribs and checks links?

In T256586#6357499, @dbarratt wrote:

@Prtksxna I added 4px of space (to the right of the buttons) and moved them down by 2px so they would better align with the help link. What do you think?

In T256586#6352646, @dbarratt wrote:

@Prtksxna Does this look good?