Prtksxna (Prateek Saxena)
Landstander

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 9 2014, 1:53 AM (133 w, 1 h)
Availability
Available
IRC Nick
prtksxna
LDAP User
Prtksxna
MediaWiki User
Unknown

Recent Activity

Yesterday

Prtksxna added a comment to T158494: Figure out which parts of OOjs UI documentation should be improved, and where they should live.

From today's Front-end-Standards-Group meeting, we agree to

Wed, Apr 26, 7:17 PM · Front-end-Standards-Group, Documentation, OOjs-UI

Mon, Apr 24

Prtksxna added a comment to T123359: Provide WikimediaUI Base's base.less in MW core.

The problem is that this code is fundamentally a lie.
"WikimediaUI repository provides stylesheets with variables containing Wikimedia Foundation wide user interface basic style values." – but these values aren't inherited by any bit of OOUI or any non-OOUI tool.
When https://phabricator.wikimedia.org/source/wikimedia-ui-base/ is used by the agreed front-end library (OOUI) then it can (and definitely should) be pulled through in that versioned release process. Doing things ad-hoc that maybe-kinda work is pure tech debt.

Mon, Apr 24, 11:30 AM · WikimediaUI Style Guide, WMF-Design, Design, Patch-For-Review, MediaWiki-Interface, UI-Standardization, UI-Standardization-Kanban
Prtksxna added a comment to T163652: HorizontalLayout should provide widgets with label.
From the description:

HorizontalLayout, as of v0.21.1, doesn't provide a clear label for screen readers.

Mon, Apr 24, 10:34 AM · Accessibility, OOjs-UI
Prtksxna closed T148597: MediaWiki-Vagrant role for FileAnnotations extension as "Resolved".
Mon, Apr 24, 9:38 AM · FileAnnotations, MediaWiki-Vagrant, Multimedia
Prtksxna assigned T124856: NumberInputWidget is not actually an InputWidget to Mooeypoo.

@Prtksxna Are there considerations from your side about the latest patch, that might not have been resolved as https://gerrit.wikimedia.org/r/#/c/284168/ (I94e35de4dbd92d76605895b8b559ca5d25b72819) hasn't got merged yet?

Mon, Apr 24, 7:17 AM · OOjs-UI (OOjs-UI-0.21.2)
Prtksxna created T163654: PopupTagMultiselectWidget: Popup position not updated when height changes.
Mon, Apr 24, 6:06 AM · OOjs-UI (OOjs-UI-0.21.2), JavaScript

Sun, Apr 23

Prtksxna placed T124856: NumberInputWidget is not actually an InputWidget up for grabs.
Sun, Apr 23, 2:36 PM · OOjs-UI (OOjs-UI-0.21.2)
Prtksxna added a comment to T163189: Make build process with automatic SVG creation out of resources.

Is this to be run locally by people contributing to the style guide? Not by some CI, right?

Sun, Apr 23, 2:32 PM · WMF-Design, Design, WikimediaUI Style Guide
Prtksxna updated the name of F7722275: hilarious-combobox from "Screen Shot 2017-04-23 at 5.09.19 PM.png" to "hilarious-combobox".
Sun, Apr 23, 11:40 AM
Prtksxna added a comment to T161612: Buttons in MMV are not really buttons and are thus not semantic.

@Prtksxna would it be sufficient to add role=button et al. to make these accessible in the usual way? It's not clear what specific issue you're looking to solve.

Sun, Apr 23, 11:02 AM · Easy, JavaScript, Accessibility, MediaWiki-extensions-MultimediaViewer

Sat, Apr 22

Prtksxna awarded T149654: ComboBoxInput- & CapsuleMultiSelectWidget's role=combobox is missing required ARIA children listbox a Cup of Joe token.
Sat, Apr 22, 11:43 AM · OOjs-UI (OOjs-UI-0.21.2), UI-Standardization, Accessibility, UI-Standardization-Kanban
Prtksxna added a comment to T159987: DateInputWidget isn't highlighted when <tab>-ing through a form.

@Volker_E, sounds good, updated patch.

Sat, Apr 22, 8:43 AM · Patch-For-Review, Accessibility, MediaWiki-Interface, UI-Standardization

Thu, Apr 20

Prtksxna added a comment to T150071: Why do we allow indicator-only buttons?.

I think disallowing these is pointless. It costs us almost nothing to support ButtonWidget with only 'indicator': it mostly works naturally (same as a ButtonWidget with only 'label' or 'icon'), and the little customization that it needs is already implemented.

Thu, Apr 20, 10:23 AM · Patch-For-Review, Design, WikimediaUI Style Guide, OOjs-UI

Wed, Apr 19

Prtksxna updated subscribers of T159987: DateInputWidget isn't highlighted when <tab>-ing through a form.

@Volker_E, @Pginer-WMF, thoughts?

Wed, Apr 19, 12:23 PM · Patch-For-Review, Accessibility, MediaWiki-Interface, UI-Standardization
Prtksxna added a comment to T129372: gallery syntax claims to require 'px' for widths/heights attributes, but actually discards all strings after the number.

@matmarex, wow, thanks for the script! Do you think the same bot could be run for both pl and de?

Wed, Apr 19, 11:52 AM · Patch-For-Review, MediaWiki-Gallery
Prtksxna updated subscribers of T129372: gallery syntax claims to require 'px' for widths/heights attributes, but actually discards all strings after the number.
Wed, Apr 19, 11:46 AM · Patch-For-Review, MediaWiki-Gallery

Tue, Apr 18

Prtksxna edited the description of T149502: ToggleButtonWidget inherits `aria-checked="true"` which is wrong.
Tue, Apr 18, 11:54 AM · UI-Standardization, Accessibility, OOjs-UI

Mon, Apr 17

Prtksxna created T163104: OOjs UI: Mediawiki theme: MenuOption: Adding an icon misaligns the option with the rest.
Mon, Apr 17, 11:17 AM · Design, OOjs-UI
Prtksxna added a comment to T162965: Clarify & streamline user experience of TagMultiselectWidget variants.
From the description:

Captured screens in the wild of (CapsuleMultiselectWidget) shortcomings:

That looks like a screenshot of ve.ui.WMCategoryWidget, not mw.widgets.CategorySelector.

Mon, Apr 17, 11:09 AM · UI-Standardization, UI-Standardization-Kanban, OOjs-UI
Prtksxna added a comment to T162965: Clarify & streamline user experience of TagMultiselectWidget variants.

See also T147811: Unify mw.widgets.CategorySelector and ve.ui.MWCategoryWidget.

Mon, Apr 17, 11:07 AM · UI-Standardization, UI-Standardization-Kanban, OOjs-UI
Prtksxna updated subscribers of T155473: Improve documentation of OOjs UI.
Mon, Apr 17, 5:29 AM · Developer-Relations, Documentation, OOjs-UI, Developer-Wishlist (2017)
Prtksxna updated subscribers of T158494: Figure out which parts of OOjs UI documentation should be improved, and where they should live.
Mon, Apr 17, 5:16 AM · Front-end-Standards-Group, Documentation, OOjs-UI

Thu, Apr 13

Prtksxna claimed T87835: OptionWidget has icon: 'check' in default settings for all themes, but only Apex needs this.
Thu, Apr 13, 4:45 PM · OOjs-UI (OOjs-UI-0.21.1), Technical-Debt
Prtksxna claimed T101560: OO.ui.MenuOptionWidget's icons are hidden in the mediawiki theme in the selected state and can't be used.
Thu, Apr 13, 4:45 PM · OOjs-UI (OOjs-UI-0.21.1)
Prtksxna added a comment to T162667: Special:Move throws "TypeError: this.namespace is undefined".

Thanks for taking care of this @matmarex

Thu, Apr 13, 12:29 PM · MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), MW-1.29-release-notes, MediaWiki-Special-pages

Wed, Apr 12

Prtksxna claimed T162667: Special:Move throws "TypeError: this.namespace is undefined".
Wed, Apr 12, 7:31 PM · MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), MW-1.29-release-notes, MediaWiki-Special-pages
Prtksxna edited the description of T162667: Special:Move throws "TypeError: this.namespace is undefined".
Wed, Apr 12, 7:11 PM · MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), MW-1.29-release-notes, MediaWiki-Special-pages

Tue, Apr 11

Prtksxna added a comment to T153417: Align the style for lists of pages.

I don't think that the width change produced by the font weight change would cause much disruption here (compared to changing it on hover, where it can become annoying, for example). In this context, as the user types, some results in the list would disappear completely, others will appear, and others will change their position in the list (as a result of the former).

Tue, Apr 11, 8:53 AM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization
Prtksxna added a comment to T153417: Align the style for lists of pages.

Another aspect worth discussing is how to style the "matching part of the title".
I think it is better to use bold (or color contrast) instead of underline, for the following reasons…

Tue, Apr 11, 8:43 AM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization
Prtksxna added a comment to T162219: Words incorrectly concatenated due to too simple removing of spaces.

We should really look into the I18n aspect of it before reverting, or fixing anything.

Tue, Apr 11, 8:23 AM · Reading-Web-Backlog, Page-Previews
Prtksxna awarded T162219: Words incorrectly concatenated due to too simple removing of spaces a Mountain of Wealth token.
Tue, Apr 11, 8:22 AM · Reading-Web-Backlog, Page-Previews
Prtksxna added a comment to T128550: Ensure we're fully demoing OOUI in the demos.

@Volker_E I now understand and agree with you. I am very confused about the relation between the title and the description of the task though. @Jdforrester-WMF, could you clarify?

Tue, Apr 11, 8:15 AM · Documentation, Technical-Debt, OOjs-UI
Prtksxna added a comment to T162487: [styleguide] Improve content hierarchy in page title.

I think keeping only the Colors heading and removing the Visual style makes senses. It would become even more easier of the user to figure out where they are if the sidebar were fixed. Repeating the main heading every time seems a bit redundant.

Tue, Apr 11, 8:08 AM · WikimediaUI Style Guide
Prtksxna added a comment to T153417: Align the style for lists of pages.

The illustrations capture a lot of the attention, and I worry they may distract the users from their initial query. I started to think the illustration should be put secondary in the presentation.

Tue, Apr 11, 7:17 AM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization

Mon, Apr 10

Prtksxna added a comment to T149654: ComboBoxInput- & CapsuleMultiSelectWidget's role=combobox is missing required ARIA children listbox.

1diff --git a/combobox.html b/combobox.html
2index b75cbd9..971df74 100644
3--- a/combobox.html
4+++ b/combobox.html
5@@ -1,25 +1,25 @@
6-<div class="oo-ui-comboBoxInputWidget-field">
7- <input type="text" tabindex="0" aria-disabled="false" class="oo-ui-inputWidget-input" autocomplete="off" role="combobox" aria-autocomplete="list" id="oojsui-31">
8+</div><div class="oo-ui-comboBoxInputWidget-field">
9+ <input type="text" tabindex="0" aria-disabled="false" class="oo-ui-inputWidget-input" autocomplete="off" role="combobox" aria-autocomplete="list" id="oojsui-31" aria-owns="oojsui-32" aria-activedescendant="oojsui-33">
10​ <span class="oo-ui-comboBoxInputWidget-dropdownButton oo-ui-widget oo-ui-widget-enabled oo-ui-buttonElement oo-ui-buttonElement-framed oo-ui-indicatorElement oo-ui-buttonWidget" aria-disabled="false">
11​ <a class="oo-ui-buttonElement-button" role="button" tabindex="0" aria-disabled="false" rel="nofollow">
12​ <span class="oo-ui-iconElement-icon"></span><span class="oo-ui-labelElement-label"></span><span class="oo-ui-indicatorElement-indicator oo-ui-indicator-down"></span>
13​ </a>
14​ </span>
15​ </div>
16-<div class="oo-ui-widget oo-ui-widget-enabled oo-ui-selectWidget oo-ui-selectWidget-depressed oo-ui-clippableElement-clippable oo-ui-menuSelectWidget oo-ui-floatableElement-floatable oo-ui-floatingMenuSelectWidget oo-ui-textInputMenuSelectWidget" aria-disabled="false" role="menu">
17- <div class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-optionWidget oo-ui-decoratedOptionWidget oo-ui-menuOptionWidget" aria-disabled="false" tabindex="-1" role="menuitem" aria-selected="false">
18- <span class="oo-ui-labelElement-label">Option 1</span>
19- </div>
20- <div class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-optionWidget oo-ui-decoratedOptionWidget oo-ui-menuOptionWidget" aria-disabled="false" tabindex="-1" role="menuitem" aria-selected="false">
21+<div class="oo-ui-widget oo-ui-widget-enabled oo-ui-selectWidget oo-ui-selectWidget-depressed oo-ui-clippableElement-clippable oo-ui-menuSelectWidget oo-ui-floatableElement-floatable oo-ui-floatingMenuSelectWidget oo-ui-textInputMenuSelectWidget" aria-disabled="false" role="listbox" id="oojsui-32">
22+ <div class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-optionWidget oo-ui-iconElement oo-ui-decoratedOptionWidget oo-ui-menuOptionWidget oo-ui-optionWidget-selected" aria-disabled="false" tabindex="-1" role="option" aria-selected="true" id="oojsui-33">
23+ <span class="oo-ui-labelElement-label">Option 1</span>
24+ </div>
25+ <div class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-optionWidget oo-ui-decoratedOptionWidget oo-ui-menuOptionWidget" aria-disabled="false" tabindex="-1" role="option" aria-selected="false" id="oojsui-34">
26​ <span class="oo-ui-labelElement-label">Option 2</span>
27​ </div>
28- <div class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-optionWidget oo-ui-decoratedOptionWidget oo-ui-menuOptionWidget" aria-disabled="false" tabindex="-1" role="menuitem" aria-selected="false">
29+ <div class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-optionWidget oo-ui-decoratedOptionWidget oo-ui-menuOptionWidget" aria-disabled="false" tabindex="-1" role="option" aria-selected="false" id="oojsui-35">
30​ <span class="oo-ui-labelElement-label">Option 3</span>
31​ </div>
32- <div class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-optionWidget oo-ui-decoratedOptionWidget oo-ui-menuOptionWidget" aria-disabled="false" tabindex="-1" role="menuitem" aria-selected="false">
33+ <div class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-optionWidget oo-ui-decoratedOptionWidget oo-ui-menuOptionWidget" aria-disabled="false" tabindex="-1" role="option" aria-selected="false" id="oojsui-36">
34​ <span class="oo-ui-labelElement-label">Option 4</span>
35​ </div>
36- <div class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-optionWidget oo-ui-decoratedOptionWidget oo-ui-menuOptionWidget" aria-disabled="false" tabindex="-1" role="menuitem" aria-selected="false">
37+ <div class="oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-optionWidget oo-ui-decoratedOptionWidget oo-ui-menuOptionWidget" aria-disabled="false" tabindex="-1" role="option" aria-selected="false" id="oojsui-37">
38​ <span class="oo-ui-labelElement-label">Option 5</span>
39​ </div>
40-</div>
41​\ No newline at end of file
42+</div>

Mon, Apr 10, 1:24 PM · OOjs-UI (OOjs-UI-0.21.2), UI-Standardization, Accessibility, UI-Standardization-Kanban
Prtksxna updated the title for P5234 Diff of combobox markup from untitled to Diff of combobox markup.
Mon, Apr 10, 1:23 PM · OOjs-UI
Prtksxna edited P5234 Diff of combobox markup.
Mon, Apr 10, 1:22 PM · OOjs-UI
Prtksxna created P5234 Diff of combobox markup.
Mon, Apr 10, 1:19 PM · OOjs-UI
Prtksxna added a comment to T160593: Streamline IconElement/IndicatorElement handling.

See also T161938: Icons/Indicators should be set to `display: none` by default and only be visible when set.

Mon, Apr 10, 1:12 PM · OOjs-UI, UI-Standardization, UI-Standardization-Kanban
Prtksxna added a comment to T161938: Icons/Indicators should be set to `display: none` by default and only be visible when set.

@matmarex does doing this (always visible) make a certain aspect of the code easier?

Mon, Apr 10, 12:12 PM · OOjs-UI
Prtksxna added a comment to T153417: Align the style for lists of pages.

Do we have consensus on this - http://codepen.io/anon/pen/aJQjao?

Mon, Apr 10, 12:07 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization
Prtksxna added a comment to T128550: Ensure we're fully demoing OOUI in the demos.

@Volker_E, I am either unable to understand what you're saying, or you've commented on and closed the wrong task. Could you please clarify?

Mon, Apr 10, 8:46 AM · Documentation, Technical-Debt, OOjs-UI

Tue, Apr 4

Prtksxna added a comment to T156907: OOjs UI documentation: Improve docs for $overlay config parameter.

Thanks @matmarex!

Tue, Apr 4, 7:07 AM · Patch-For-Review, Documentation, OOjs-UI

Mon, Apr 3

Prtksxna added a comment to T152901: Provide jquery.ui.dialog API OOjsUI-backed shim.

…there is OO.ui.alert() / OO.ui.confirm() (which apparently are not really documented other than https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui-method-alert, whoops)…

Mon, Apr 3, 7:14 AM · OOjs-UI

Thu, Mar 30

Prtksxna added a comment to T161829: Page-Previews is dependent on BetaFeatures.

That patch gets rid of the error for me. But I still cant get the extension to work. It blanks out the title attribute but doesn't show the card. Surely not related to this issue, but @Jdlrobson a little help?

Thu, Mar 30, 8:04 PM · MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), Reading-Web-Sprint-94, Reading-Web-Backlog, Patch-For-Review, Page-Previews
Prtksxna created T161829: Page-Previews is dependent on BetaFeatures.
Thu, Mar 30, 6:49 PM · MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), Reading-Web-Sprint-94, Reading-Web-Backlog, Patch-For-Review, Page-Previews
Prtksxna added a comment to T106924: Consider using the Badges application for a few special roles to highlight those users' comments.

Honestly I think it would be cool if badges only showed on a user's profile and not on their comments. Maybe we should patch phabricator to display them next to the "role" thing on user profiles and hide them on avatars.

Thu, Mar 30, 5:19 PM · Phabricator
Prtksxna awarded T106924: Consider using the Badges application for a few special roles to highlight those users' comments a Dislike token.
Thu, Mar 30, 3:53 PM · Phabricator
Prtksxna added a comment to T106924: Consider using the Badges application for a few special roles to highlight those users' comments.

Userboxes are used in many Wikimedia projects, and they accomplish a similar function. Today anyone can see in @hashar's post above that he is one of several SWAT Deployers. Imagine badges for "Catalan speakers", "Lua lovers", "Possible mentors"...

Userboxes are pretty different IMO. They're only on your profile page, not every time you make a comment. But more importantly users can create their own userboxes, and choose themselves whether to use them.

Thu, Mar 30, 3:52 PM · Phabricator
Prtksxna added a comment to Tea Lover.

One day, when things are different, I will earn this badge, and truly enjoy, a cup, of tea.

Thu, Mar 30, 3:38 PM
Prtksxna added a comment to T92452: MenuSectionOptionWidget not behaving correctly in DropdownWidget. It also needs to be added to demos.

I am not convinced by this, nor can I find a suitable precedent (examples here would help me).

Thu, Mar 30, 3:22 PM · Design, OOjs-UI
Prtksxna added a comment to T161798: VE > Insert > Template > Show options: Sidebar has unnecessary scroll on FF.

And the separating line between the list and the form doesn't show up for me in Chrome. Should I file a separate task for that? They could be related.

Thu, Mar 30, 3:18 PM · Browser-Support-Firefox, OOjs-UI, VisualEditor
Prtksxna added a comment to T161798: VE > Insert > Template > Show options: Sidebar has unnecessary scroll on FF.

Did something change in OOjs UI? This code in VE hasn't changed in ~4 years.

Thu, Mar 30, 3:17 PM · Browser-Support-Firefox, OOjs-UI, VisualEditor
Prtksxna added a comment to T61693: Submit button text displays in wrong language.

Wow! Thanks a ton @EddieGP!

Thu, Mar 30, 2:58 PM · I18n, MediaWiki-extensions-InputBox
Prtksxna added a comment to T61693: Submit button text displays in wrong language.

Yep. That makes sense! Software and caching sometimes works is mysterious ways, so I just wanted to be sure :)

Thu, Mar 30, 2:25 PM · I18n, MediaWiki-extensions-InputBox
Prtksxna added a comment to T161601: Consider square icon-only buttons or toolbar tools.

It may be that the rectangular buttons make sense for horizontal button groups, but this a vertical button group (see zoom in/out controls), which doesn't exist yet. That said a labelled vertical button group should probably have the same padding as normal buttons...

Thu, Mar 30, 2:17 PM · OOjs-UI
Prtksxna added a comment to T61693: Submit button text displays in wrong language.

As this was opened more than 3 years and two people weren't able to reproduce this as of now, I'd tend to close this bug.

Thu, Mar 30, 2:04 PM · I18n, MediaWiki-extensions-InputBox
Prtksxna created T161798: VE > Insert > Template > Show options: Sidebar has unnecessary scroll on FF.
Thu, Mar 30, 2:01 PM · Browser-Support-Firefox, OOjs-UI, VisualEditor
Prtksxna added a comment to T61693: Submit button text displays in wrong language.

I am not able to replicate this. Could be because I am not following the steps correctly? Can someone please confirm this issue.

Thu, Mar 30, 1:41 PM · I18n, MediaWiki-extensions-InputBox
Prtksxna added a comment to T139351: Rules for Wikimedia icon additions .

Another aspect to consider is how we expect to apply icons to UI elements such as buttons and how that affects their size. I created some examples with buttons that use 8px and 16px for padding and 16px for font-size size for the cases of 24x24px canvas, 20x20px canvas, and just text.

Thu, Mar 30, 11:06 AM · RfC, WMF-Design, UI-Standardization, WikimediaUI Style Guide, Design
Prtksxna added a comment to T153417: Align the style for lists of pages.

Another question from a style guide perspective, should the thumbnails feature rounded borders?

Thu, Mar 30, 10:50 AM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization
Prtksxna added a comment to T126882: Allow using namespaces indexes instead of names when creating a search InputBox.
From the description:

...problem with add 'Main' namespace in non-english language.

Thu, Mar 30, 6:24 AM · I18n, MediaWiki-extensions-InputBox
Prtksxna renamed T126882: Allow using namespaces indexes instead of names when creating a search InputBox from "Namespaces for search InputBox" to "Allow using namespaces indexes instead of names when creating a search InputBox".
Thu, Mar 30, 6:20 AM · I18n, MediaWiki-extensions-InputBox
Prtksxna added a comment to T159591: Castor: mediawiki-core-qunit-jessie node_modules cache ineffective.

On my usual working directory of OOjs-UI, on a MacBook Air with a 4Mbps connection:

Thu, Mar 30, 5:39 AM · Patch-For-Review, Continuous-Integration-Config

Wed, Mar 29

Prtksxna added a comment to T153417: Align the style for lists of pages.

Following (and forking) @Pginer-WMF's lead on T92452, I've created a sample on codepen. This has more whitespace between thumbnails, and doesn't use gray for :hover.

Wed, Mar 29, 8:32 PM · RelatedArticles, WMF-Design, Design, Discovery, Wikimedia-Portals, VisualEditor, UI-Standardization
Prtksxna added a comment to T92452: MenuSectionOptionWidget not behaving correctly in DropdownWidget. It also needs to be added to demos.

I created some examples of menus using the current color palette. Options C and B look good to me. Maybe you could fork and extend the example if you are proposing a different option.

Wed, Mar 29, 7:56 PM · Design, OOjs-UI
Prtksxna edited the description of T92452: MenuSectionOptionWidget not behaving correctly in DropdownWidget. It also needs to be added to demos.
Wed, Mar 29, 7:46 PM · Design, OOjs-UI
Prtksxna edited the description of T92452: MenuSectionOptionWidget not behaving correctly in DropdownWidget. It also needs to be added to demos.
Wed, Mar 29, 7:25 PM · Design, OOjs-UI
Prtksxna added a comment to T159591: Castor: mediawiki-core-qunit-jessie node_modules cache ineffective.

@hashar I am curious to know if such a change could be implemented on per-repository basis.

Wed, Mar 29, 7:08 PM · Patch-For-Review, Continuous-Integration-Config
Prtksxna added a subtask for T34284: Update Echo Notifications in real time without page reloads: T113125: Investigate using service workers to provide real-time Echo notifications in the browser (push notifications).
Wed, Mar 29, 6:31 PM · Collaboration-Team-Triage, Notifications
Prtksxna added a parent task for T113125: Investigate using service workers to provide real-time Echo notifications in the browser (push notifications): T34284: Update Echo Notifications in real time without page reloads.
Wed, Mar 29, 6:30 PM · Notifications, Collaboration-Team-Triage
matmarex awarded T155483: Speed up oojs/ui Jenkins jobs a Doubloon token.
Wed, Mar 29, 6:03 PM · OOjs-UI (OOjs-UI-0.20.1), Continuous-Integration-Infrastructure (Little Steps Sprint), Continuous-Integration-Config
Prtksxna added a comment to T159591: Castor: mediawiki-core-qunit-jessie node_modules cache ineffective.

I am willing to try caching node_modules, as a trial on the few repositories that have long install time (eg: oojs/ui). Ideally with a way for developers to clear the cache on demand.

Wed, Mar 29, 6:02 PM · Patch-For-Review, Continuous-Integration-Config
Prtksxna removed a project from T155483: Speed up oojs/ui Jenkins jobs: Patch-For-Review.
Wed, Mar 29, 5:34 PM · OOjs-UI (OOjs-UI-0.20.1), Continuous-Integration-Infrastructure (Little Steps Sprint), Continuous-Integration-Config
Prtksxna moved T155483: Speed up oojs/ui Jenkins jobs from Doing to OOjs-UI-0.20.1 on the OOjs-UI board.
Wed, Mar 29, 5:34 PM · OOjs-UI (OOjs-UI-0.20.1), Continuous-Integration-Infrastructure (Little Steps Sprint), Continuous-Integration-Config
Prtksxna added a comment to T155483: Speed up oojs/ui Jenkins jobs.

@hashar Is it possible to have a number on how many seconds/minutes we are saving per patch after these changes?

Wed, Mar 29, 5:33 PM · OOjs-UI (OOjs-UI-0.20.1), Continuous-Integration-Infrastructure (Little Steps Sprint), Continuous-Integration-Config
Prtksxna moved T155483: Speed up oojs/ui Jenkins jobs from Backlog to Doing on the OOjs-UI board.
Wed, Mar 29, 7:55 AM · OOjs-UI (OOjs-UI-0.20.1), Continuous-Integration-Infrastructure (Little Steps Sprint), Continuous-Integration-Config
Prtksxna added a comment to T155483: Speed up oojs/ui Jenkins jobs.

I tried to make changes in jjb/oojs.yaml and zuul/layout.yaml as well, but couldn't figure out what needed to be done.

Wed, Mar 29, 7:52 AM · OOjs-UI (OOjs-UI-0.20.1), Continuous-Integration-Infrastructure (Little Steps Sprint), Continuous-Integration-Config
Prtksxna claimed T106999: Implement HTMLSelectAndOtherField and HTMLSelectOrOtherField in OOUIHTMLForm.
Wed, Mar 29, 5:46 AM · MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-25_(1.29.0-wmf.21)), Patch-For-Review, MediaWiki-HTMLForm
Prtksxna awarded T100896: Allow skins to use different, custom OOUI themes a Like token.
Wed, Mar 29, 1:05 AM · OOjs-UI (OOjs-UI-0.20.1), MediaWiki-Interface
Prtksxna claimed T161285: CategorySelector should be renamed CategoryMultiselectWidget.
Wed, Mar 29, 12:53 AM · MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), MW-1.29-release-notes, MediaWiki-General-or-Unknown
Prtksxna added a comment to T161285: CategorySelector should be renamed CategoryMultiselectWidget.

@matmarex I don't think there are any other instances of CategorySelector that need to be replaced. Even so, till what time should we keep the deprecated class and RL module?

Wed, Mar 29, 12:52 AM · MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), MW-1.29-release-notes, MediaWiki-General-or-Unknown

Tue, Mar 28

Prtksxna created T161612: Buttons in MMV are not really buttons and are thus not semantic.
Tue, Mar 28, 3:15 PM · Easy, JavaScript, Accessibility, MediaWiki-extensions-MultimediaViewer
Prtksxna closed T58471: Close and zoom buttons have no tooltips or speakable title (title attribute) as "Resolved".
Tue, Mar 28, 3:08 PM · MW-1.29-release (WMF-deploy-2017-03-28_(1.29.0-wmf.18)), Patch-For-Review, Need-volunteer, MW-1.27-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), Google-Code-In-2016, Easy, Reading-Web-Backlog, Accessibility, MediaWiki-extensions-MultimediaViewer
Prtksxna closed T58471: Close and zoom buttons have no tooltips or speakable title (title attribute), a subtask of T152476: mw.language unittest cleanup failing, as "Resolved".
Tue, Mar 28, 3:08 PM · User-Nikerabbit, MediaWiki-Internationalization
Prtksxna accepted D609: build: Bump dev dependencies to latest.
Tue, Mar 28, 11:01 AM
Prtksxna renamed T161285: CategorySelector should be renamed CategoryMultiselectWidget from "CategorySelector should be renamed CategorySelectorWidget" to "CategorySelector should be renamed CategoryMultiselectWidget".
Tue, Mar 28, 8:12 AM · MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), MW-1.29-release-notes, MediaWiki-General-or-Unknown
Prtksxna accepted D608: Rename "wmui-base.*" files to "wikimedia-ui-base.*".
Tue, Mar 28, 7:14 AM

Mar 27 2017

Prtksxna awarded T155483: Speed up oojs/ui Jenkins jobs a The World Burns token.
Mar 27 2017, 5:19 PM · OOjs-UI (OOjs-UI-0.20.1), Continuous-Integration-Infrastructure (Little Steps Sprint), Continuous-Integration-Config
Prtksxna added a comment to T158610: BookletLayout/booklet dialog: Safari 10/OSX doesn't show vertical scrollbar.

@Prtksxna Continuous outlined booklet dialog is showing scrollbar on my Chrome/Firefox per default.
Process dialog (medium, long) shows scrollbar in Chrome/Firefox/Safari per default.
If you disable the transform property, it becomes immediately visible in Safari as well. With it enabled, it's never visible.

Mar 27 2017, 8:53 AM · Browser-Support-Apple-Safari, OOjs-UI
Prtksxna added a comment to T152484: Simplify Menu creation.

Thanks @hashar and @Zppix! My question was more to @Volker_E though, in that if he is planning to, or has setup something like this.

Mar 27 2017, 8:47 AM · UI-Standardization, WikimediaUI Style Guide
Prtksxna added a comment to T92452: MenuSectionOptionWidget not behaving correctly in DropdownWidget. It also needs to be added to demos.

@Volker_E, in F7015760, are you proposing to get rid of the indentation altogether? That would be against all the examples we've seen and make it harder to glance through the list.

Mar 27 2017, 8:35 AM · Design, OOjs-UI
Prtksxna added a comment to T152484: Simplify Menu creation.

Is there some CI that the menus are the same across pages or are we relying on humans?

Mar 27 2017, 8:14 AM · UI-Standardization, WikimediaUI Style Guide
Prtksxna updated subscribers of T87835: OptionWidget has icon: 'check' in default settings for all themes, but only Apex needs this.

@Esanders what would be your preferred solution? Is adding the check through CSS in Apex okay?

Mar 27 2017, 7:59 AM · OOjs-UI (OOjs-UI-0.21.1), Technical-Debt
Prtksxna renamed T101560: OO.ui.MenuOptionWidget's icons are hidden in the mediawiki theme in the selected state and can't be used from "OO.ui.MenuOptionWidget's icons are hidden and can't be used" to "OO.ui.MenuOptionWidget's icons are hidden in the mediawiki theme in the selected state and can't be used".
Mar 27 2017, 7:40 AM · OOjs-UI (OOjs-UI-0.21.1)
Prtksxna edited the description of T87835: OptionWidget has icon: 'check' in default settings for all themes, but only Apex needs this.
Mar 27 2017, 7:37 AM · OOjs-UI (OOjs-UI-0.21.1), Technical-Debt

Mar 25 2017

Prtksxna edited the description of T67114: Hovercards: Show cards for references.
Mar 25 2017, 12:28 PM · Reading-Web-Backlog (Design), Design, Patch-For-Review, Page-Previews
Prtksxna added a comment to T71550: Move code in enwiki MediaWiki:Common.js and Gadgets to MediaWiki software.
From the description:
  • MediaWiki:Gadget-featured-articles-links.js, used by a few wikis to add icons to the sidebar links to featured/good articles in other languages
Mar 25 2017, 9:58 AM · JavaScript, Wikimedia-General-or-Unknown
Prtksxna edited the description of T71550: Move code in enwiki MediaWiki:Common.js and Gadgets to MediaWiki software.
Mar 25 2017, 6:19 AM · JavaScript, Wikimedia-General-or-Unknown

Mar 24 2017

Prtksxna added a comment to T161298: mw.widgets.CategorySelector: Height changes erraticaly when typing.

I don't think this has anything to do with T160270: CapsuleMultiselectWidget: updateInputSize in not called when adding/removing items through JS, but linking anyway.

Mar 24 2017, 10:39 AM · JavaScript, OOjs-UI, MediaWiki-General-or-Unknown