In T282690#7084912, @STran wrote:

I just wanted to confirm that the gist of this was ok.

Thanks @dom_walden! Will look at this with T281364.

In T279556#6983336, @Tchanders wrote:

1. Can we keep the action checkboxes in a single column? Some languages have quite long labels, e.g. Polish:

In T263638#6975831, @STran wrote:

@Prtksxna Someone pointed out that "Username" is the correct casing. I assume then that both Special:Block and Special:Investigate: should be updated to reflect this?

Hey @STran the help popups are only meant for the box that shows up on Special:Contributions. This popup is eventually meant to have only on-wiki information and won't need any help text (T268657).

In T277277#6963214, @STran wrote:

@Prtksxna a few things came up:

• Both the duplicate and csrf columns use the icon. Should the csrf column also just use text? 'CSRF'?

Thanks for catching this @Tchanders. You are right, the message was an update to the inline help text, and wasn't meant to be added to the top of the page.

@Tchanders and I met and decided that:

• The Dup row shouldn't have any icon and just have the text 'Duplicate' written in it.
• The down arrow icon should be moved to the end of the sentence. It should be a ButtonWidget with the downTriangle icon and text "See this warning".
• The warning icon should use the OOUI alert icon, in the color #fc3 .

You're right. Do you know the process of moving something to Wikimedia's Github? Should I request a Gerrit repo first and get it mirrored?
We'd also need to find out how Shopify is deploying it and if it relies on the prtksxna URL (I don't think it does).

the box is being added conditionally now, so not for the unencrypted elections.

@Tchanders, yep this is looking great, exactly what I had in mind. A few notes:

1. Do you think it is warranted to bring more attention to the 'alert'? If yes, we could use the yellow variant for it. If not, this is good.
2. The GPG decryption key textarea would still be there, right?

In T275533#6918096, @DLynch wrote:

I tried enabling the script, and when hovering over an IP address on RecentChanges I just got this error: Uncaught (in promise) TypeError: Failed to fetch. This turned out to be because my adblocker dislikes ipinfo.io.

If we want to keep it as close as possible to the existing UI: F34155362 seems replaceable with a close or trash icon in the color #d33. For the first image in F34155367 we could use expand or the down (indicator) in color #36c. And for the last we have alert in color #fc3.

In T276763#6907336, @DLynch wrote:

@Prtksxna bumping this back into design review so you can say whether you're okay with this.

My primary concern is that the basic layout of the voting interface remains the same, and it doesn't take up more vertical space than it needs to (especially as the number of candidates can easily be over 10). So, I'd be against (1).

Should showing and hiding the wikitext also regenerate the wikitext? This might be useful in cases where someone has changed the sorting of the table and wants the wikitext of that version.

Using something like a ButtonSelectWidget might reduce the vertical space the radios are taking up. Would that be possible on a page like this?

In T273043#6900140, @Tchanders wrote:

In T268800#6898079, @Tchanders wrote:

@Prtksxna I'm finding the shared label with the sitewide/partial blocked checkboxes looks a bit confusing, since it's not clear whether it applies to all four checkboxes.

In T273043#6897569, @Tchanders wrote:

• The labels for the inputs don't automatically get changed from "n" to "+n" when you add a negative column value (bit confusing, see screenshots below). However, this difference is purely aesthetic.

@Prtksxna Should we raise a ticket about this? I think it looks a bit odd to see -1, 0, 1, 2, +3:

Might it be better either always to have the + or never to have it?

In T272412#6883983, @Tchanders wrote:

@Xover, thank you so much for this explanation!

This is looking good @nayoub. I have two thoughts:

1. Do we need to run this by legal?
2. Do we need to mention the exactly CC license that is being used? (Another question for legal)

In T272916#6856203, @dom_walden wrote:

I am not sure what I think about the new form. It seems to give a lot of prominence to the "Select a file" input, and I am not sure how many users will properly read the greyed out text underneath it. Deferring to @Prtksxna.

This look good @ifried. We should layout the checkboxes one below the other (instead of next to each other) now that we'll have three of them.

@STran, both these decisions make sense to me, thank you.

In T271674#6837307, @Tchanders wrote:

@dom_walden I assume the Organization is only needed in the infobox as per the task description, but @Prtksxna could confirm?

In T273976#6835112, @STran wrote:

Should this filter be disabled if "All SecurePoll logs" is selected?

In T274568#6828009, @STran wrote:

So if the user does not have js enabled should they be allowed to add "User_A"? I thought so because it's a valid representation of the username but for comparison, if you try to make an account with username "user_a", it will automatically normalize it to "User A." I also thought it would be jarring to type in "User_A" and when you navigated back to the page, to see "User A" but again, create account does it out of the gate and all of our logs normalize the username as well.

In T273976#6827016, @Tchanders wrote:

@Prtksxna What should happen if 'Admin log' is selected and neither of the 'Admin type' checkboxes are checked?

Prateek saw:
िहद वराज

In T271869#6814594, @Samwilson wrote:

Actually "Pick a format".

Sorry! I was going off the Figma specs. Should we change it?

Yep, changing to just (username) in the brackets make sense. Thanks for pointing it out.

@Tchanders I was thinking it could follow the same functioning and label as Special:Log, 'From date (and earlier):'. Is there something different in SecurePollLog that would benefit from '(and later)'?

Is it alright to have a link to a mediawiki.org help page in the help text? If so, the help text could be generic like "For more information, see Help:Downloading account data". We could then give more details on single project and wiki-farm setups there.

The help text at the top might need some updating.

The election record has been encrypted, but the decryption key is available. You can choose to either tally the results present in the database, or to tally encrypted results from an uploaded file

In T272763#6787149, @ifried wrote:

@Prtksxna: What do you think of this idea? And, if we go ahead with it, do you have an image file for the Wikisource logo that you recommend we use?

In T271869#6767885, @Samwilson wrote:

Why is MOBI described as being for Calibre? I would've thought EPUB would be closer to Calibre's "default" format.

@Tchanders merging the two forms sounds like a good idea. What do you think about not adding the radio, and instead processing using the file if its uploaded, and otherwise processing whats in the database? We could have some inlineHelp with the File input to explain this.

In T271830#6748774, @Tchanders wrote:

We're hoping this won't be the case after T271824: Improve the efficiency of vote decryption during tallying - would it be OK for us to do this as a separate task if it is still a problem?
…
Similar to the above, we're hoping that it will be like a normal form submission with results loading quickly. So it would work like any form - if you leave after submitting, you'll have to go back and resubmit. As above, could we move this to a future task if still a problem?

In T271279#6747585, @Tchanders wrote:

@Prtksxna Would there be value in being able to see all the logs of any type for an election in one go? If so, could we combine the pages into one, for example by having 3 checkboxes (Voters viewed, Admin added, Admin removed) and the Target input disabled if nether Admin added/removed are checked?

Thanks for the screenshots and explanation, @STran. We aren't using the pattern of having submit button both on the top and bottom in MediaWiki. We could make it work but it might require more design and subsequently development work. I'd suggest we go with option 2.

In T271354#6745339, @Tchanders wrote:

@Prtksxna Would it be possible to make another task if we want to restyle the error? It appears in quite a few places and is currently unstyled like the standard permissions error, as per @STran's screenshot.

@STran I thinks it's alright to use the same error text. Is there a default error style we can use here? Something from HTMLForm or OOUI?

We can add a text input to enter the key and decrypt the page

@STran could you share a screenshot of the page? Would it be possible to move the button to the bottom of the form?

From the description

@Prtksxna Do you think this feature would belong on the log page or somewhere else?