LGTM 👍🏽

In T207214#4994900, @jmatazzoni wrote:

• How wide can the menu extend?

UI elements look good 👍🏽

I am hoping we don't use this for too long.

In T208889#4991311, @jmatazzoni wrote:

@Prtksxna, @aezell things this download process might take some time. Do we have a standard "working" animation we can add to the UX here? Would you mind adding showing a concept for that? I will add it to the Description.

In T187992#4969314, @Eugene233 wrote:

@srishakatux Please what is the state of this project? Can this be sent to GSoC '19?

Making the Items per page dropdown narrower and adding a new Type dropdown there makes sense. It's good that it doesn't increase the size of the filter section either.

In T215184#4957235, @aezell wrote:

If we share these on-wiki but then go with a solution like a browser extension, is that going to be a confusing shift?

In T214452#4944800, @Niharika wrote:

Looks pretty good! @Prtksxna You have any design changes you'd like to see here? See https://tools.wmflabs.org/svgtranslate-test/File:Speech_bubbles.svg

These are the mocks that I've been working on:

Oops, had forgotten to push the code. The prototype should be updated now.

In T212892#4944350, @TBolliger wrote:

The current UI element on multiple special pages (Block, Recent Changes) is not a button…

Sounds good to me!

In T213101#4944347, @Tchanders wrote:

Only thing that strikes me is that the "(learn more)" after editing might be overkill now, with all the inline help messages?

This is what I had in mind, smaller help texts that can fit in just one line and links out to documentation wherever needed. Would something like this work?

We can use the feedback icon from the interactions pack in OOUI:

Would 15 February be alright? Let me know if you'll need it sooner 🙂

In T210564#4904238, @Samwilson wrote:

Is there a working prototype of the banner?

In T206819#4900547, @MusikAnimal wrote:

@jmatazzoni Just a note... we're already showing "files uploaded" and "file usage" in the interface now, so we will need to continue to do that after this is implemented. But, it's kinda weird to show "Files uploaded: 0" when your event is only for say, en.wikipedia, and you don't care about files at all. So I'm thinking, if Commons is not included as part of the event, we will only show Files Uploaded/Usage if at least one file was uploaded. That sound okay?

That work is now being tracked under JSDoc WMF theme.

In T213292#4866792, @TBolliger wrote:

Exactly. Unless this checkbox is causing major issues and needs to be re-considered I say we keep it and move on.

Agree with @Volker_E and @Tchanders 👍🏽

@Tchanders from your previous comment I understand that its going to be tricky to add help text (tooltip, or inline) on the radio options. I wanted to ask if its going to be possible at all, or should we be thinking of other solutions?

In T202773#4855693, @Tchanders wrote:

• The existing labels haven't been changed to the labels shown in the design (e.g. "Prevent account creation" etc), because I can imagine there being some opposition to changing them.

In T210218#4858043, @Niharika wrote:

@Prtksxna We do need another design for this ticket in the event that a user directly lands on the translation page for an image using a link and the image does not have any labels for translation. In that case, we should show them the image and a message.

In T117794#4850819, @Volker_E wrote:

@Prtksxna Did you get to any start code-wise here?

In T212294#4851057, @Niharika wrote:

I've been thinking about this and its a bit tricky. A solid gray border looks odd on images that already have a border

@Prtksxna I think the number of images already having a border is really low.

In T211373#4854362, @Niharika wrote:

I like Leaflet, if that's the one you have in mind. Is that the one we're talking about?

In T210564#4836095, @Samwilson wrote:

I was imagining that the upload process would be a standard form-submission, i.e. that the browser would indicate progress, and that navigating away before it'd finished (not that it'll take very long, hopefully) would abort the process.

I think we can have the same design with different wordings. The user might get a bit confused by seeing an empty translation interface.

That makes sense @Niharika. I think that we should revise the text and sub-text though, maybe remove the links from there at least?

In T212293#4849794, @aezell wrote:

@Prtksxna I think we fixed the Docker stuff at the offsite unless it has broken again. I'll give it a try shortly and see if it's working with the current master.

In T212294#4848098, @Niharika wrote:

@Prtksxna Do we also want to add a border for images? A bunch of images have white backgrounds which can make it hard to tell how much space is available for labels until it hits the edge.

Are we able to tell the difference between images that have text that cannot be translated and images that just don't have text? Is this a special case of T210218: Show message when loading an SVG with no translations, or something completely different?

In T212293#4848081, @Niharika wrote:

@Prtksxna If you prefer, you could also directly submit PRs for minor design fixes.

That looks about right. I think the only difference left is to reduce the vertical margin of the loading indicator. On the prototype you can see the modal by going to the Event Page → Download Report → Wikidata Contributions. I think our markup is the same.

After discussing this with @jmatazzoni, here is an option that keeps the saves what we can immediately, and keeps the unsaved changes in the textarea and shows the error indicator there.

Initial	Adding new items	After hitting save

In T207776#4833168, @MusikAnimal wrote:

Sorry about that. I'm not sure what font sizes should be used, or the widths. To me it looked like Prateek's screenshots were taken when the viewport was smaller, hence the modals were too. Right now I'm using the default Bootstrap styles. I would recommend a wider modal if the viewport allows, as Bootstrap provides for us. Overriding the Bootstrap responsive design could be a bit involved, but Prateek might already have the CSS coded up.

In T210872#4835045, @Samwilson wrote:

Do you want the untranslated all lower-case like that, or with an upper-case U?

In T6995#4832856, @TBolliger wrote:

1. Yes, other field values are retained if a user switches.

👍🏽

2. Our understanding is that hide/show is not part of the supported style guide, and that active/inactive is the preferred treatment. Is this not the case?

Yep, we don't use that pattern anywhere else, was just wondering if we considered it for this. Happy to go ahead the way it is 🙂

@Samwilson, you had mentioned that we'd be able to do something like Leaflet? It'd be cool if that is possible 🙂If not we could use the ButtonGroupWidget with the + and - icons being overlaid on the image. We would also want to show the ✋mouse cursor on hover to let the user pan around.

A quick question about your comment on our doc — we'll need the upload progress state to completely block all other interactions, right?

I think we can make the text #000 here. What do yo think about the subtext, @Niharika?

Can we make a minor change in the design? Prefixing Untranslated before every label might be cumbersome for the user to read through every time. Can we move it to the bottom and make it smaller?

Yep @Samwilson's idea makes sense, let's go with that.

In T206712#4812172, @Niharika wrote:

Looks good to me! @Prtksxna take a look and we can open follow up tickets for any more design fixes we want.

Will we be able to reliably do this for different sizes of images?

In T210133#4824296, @Esanders wrote:

Why is $element not a link? I note on https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui.mixin.ClippableElement that $clippable and $clippableContainer are links. Shouldn't we be fixing $element to be a link, rather than unlinking it?

In T208889#4812583, @jmatazzoni wrote:

@Prtksxna, the engineers have noted that the alignment of the help link here is not possible/standard. It will be aligned left under the Account Data left label, unless you have some better idea.

In T6995#4779710, @TBolliger wrote:

• The defaults for the pages and namespaces input fields are empty, so the default for other actions (upload, create page, etc.) should also be empty/unselected.

Thanks for your work on this, @Stibba

Hey @Sochin67, thanks for raising the ticket. Unfortunately, I am not working on this anymore, so I've added some people who might be able to help.

@MusikAnimal, is it possible to have the dropdown be wider than the input field?

Possibly happening because the fonts have been defined as HelveticaNeue-Bold, Helvetica Neue which are pre-installed on MacOS. It shows up in the default font on other OS's. Should add sans-serif here.

See also: T210349: JSDoc WMF theme: Fix JS and CSS linting issues

Thanks for posting this discussion @Volker_E and @Mooeypoo 👍🏽

In T209902#4763042, @cscott wrote:

Well, I added you as co-owner of the jsdoc-wmf-theme group. That should do it, I hope?

Thank you for working on this @Arcayn

In T208889#4763113, @Niharika wrote:

@Prtksxna I believe that's what Joe meant -

the downloadable report will be available from the "User profile" tab of Preferences

It will not be a new special page.

I guess 2000 should be fine, we can ask @Mooeypoo to test once this is done and adjust later if we feel the need 💻

In T207711#4767176, @Samwilson wrote:

I agree with both of you. Although, @Prtksxna did you mean to have different strings inside the zh and ja examples?