Page MenuHomePhabricator

RazeSoldier (星耀晨曦)
Bug Fixer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 3 2017, 12:47 PM (110 w, 6 d)
Availability
Available
IRC Nick
razesoldier
LDAP User
星耀晨曦
MediaWiki User
星耀晨曦 [ Global Accounts ]

A car mechanic.

My profile picture from https://www.pixiv.net/member_illust.php?mode=medium&illust_id=63852184 painted by Lpip, fair use it.

Recent Activity

Sun, Mar 17

RazeSoldier removed a project from T187628: runJobs.php not output anything when job queue is empty: Patch-For-Review.
Sun, Mar 17, 2:51 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-Maintenance-scripts

Tue, Mar 5

RazeSoldier added a comment to T213595: Release 1.32.1 as a maintenance release.

What is blocking the release?

Tue, Mar 5, 4:41 PM · Release-Engineering-Team (Kanban), MW-1.32-notes, MW-1.32-release
RazeSoldier merged T217555: Chinese wikivoyage pagebanner cannot automatically convert simplified or traditional Chinese using "pgname" and "caption" parameters into T217501: Page banner of Wikivoyage can not automatically convert the problem of tranditional or simplified Chinese.
Tue, Mar 5, 5:08 AM · Language-Team, Readers-Web-Backlog (Tracking), Reading-Web-Local-Wiki-Issues, Wikidata-Page-Banner, Chinese-Sites
RazeSoldier merged task T217555: Chinese wikivoyage pagebanner cannot automatically convert simplified or traditional Chinese using "pgname" and "caption" parameters into T217501: Page banner of Wikivoyage can not automatically convert the problem of tranditional or simplified Chinese.
Tue, Mar 5, 5:08 AM · MediaWiki-Language-converter, Wikidata, Wikidata-Page-Banner, Chinese-Sites

Feb 17 2019

RazeSoldier created T216345: Unrecognized option 'max_muxing_queue_size'.
Feb 17 2019, 7:23 AM · TimedMediaHandler

Feb 16 2019

RazeSoldier added a comment to T212919: Adding transwiki source, Adding ailias to namespaces and creating "Experiment" and "Lesson" namespaces in Chinese Wikiversity.

@Wang_Qiliang The current process is that there are already patch. Next, patch need to be scheduled to https://wikitech.wikimedia.org/wiki/Deployments and need a watcher to assist the deployment. More help see https://wikitech.wikimedia.org/wiki/SWAT_deploys#How_to_submit_a_patch_for_SWAT.

Feb 16 2019, 2:08 PM · Patch-For-Review, Wikimedia-Site-requests, Chinese-Sites

Feb 14 2019

RazeSoldier added a comment to T215566: MediaWiki 1.32.0 Installation Error: "Could not select database".

This issue already fixed in REL1_32 and included in MW 1.32.1 (coming soon).

Feb 14 2019, 9:43 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), MediaWiki-Database, MW-1.32-release, MediaWiki-Installer
RazeSoldier added a comment to T209423: Installer fails due to a Call Stack.

May be we should change the restriction in PHPVersionCheck.php and composer.json?

Feb 14 2019, 6:12 AM · MW-1.31-release-notes, Patch-For-Review, MW-1.32-notes, MW-1.32-release, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Multi-Content-Revisions, MediaWiki-Installer

Feb 13 2019

RazeSoldier added a comment to T213595: Release 1.32.1 as a maintenance release.

I think we should wait for T215566.

Feb 13 2019, 3:30 AM · Release-Engineering-Team (Kanban), MW-1.32-notes, MW-1.32-release

Feb 11 2019

RazeSoldier claimed T215566: MediaWiki 1.32.0 Installation Error: "Could not select database".
Feb 11 2019, 12:10 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), MediaWiki-Database, MW-1.32-release, MediaWiki-Installer

Feb 10 2019

RazeSoldier updated subscribers of T215566: MediaWiki 1.32.0 Installation Error: "Could not select database".

@aaron Ping the patch author.

Feb 10 2019, 7:16 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), MediaWiki-Database, MW-1.32-release, MediaWiki-Installer
RazeSoldier moved T215566: MediaWiki 1.32.0 Installation Error: "Could not select database" from Backlog to libs/rdbms on the MediaWiki-Database board.
Feb 10 2019, 6:52 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), MediaWiki-Database, MW-1.32-release, MediaWiki-Installer
RazeSoldier added a project to T215566: MediaWiki 1.32.0 Installation Error: "Could not select database": MediaWiki-Database.
Feb 10 2019, 6:52 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), MediaWiki-Database, MW-1.32-release, MediaWiki-Installer
RazeSoldier moved T215566: MediaWiki 1.32.0 Installation Error: "Could not select database" from Backlog to Blockers on the MW-1.32-release board.
Feb 10 2019, 6:47 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), MediaWiki-Database, MW-1.32-release, MediaWiki-Installer
RazeSoldier added a comment to T215566: MediaWiki 1.32.0 Installation Error: "Could not select database".

I think fe0af6cad578 caused this problem. In DatabaseMysqli::doSelectDomain(), if mysqli::select_db() return FALSE will manual throw the exception(DBExpectedError). This will definitely prevent a new installation.

Feb 10 2019, 6:45 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), MediaWiki-Database, MW-1.32-release, MediaWiki-Installer

Jan 29 2019

RazeSoldier removed a parent task for T210724: Math test 'Class undefined: Wikibase\DataModel\Entity\ItemId' failing in CI build: T198564: Misleading error message "Mathoid cli /path/to/cli.js is not executable.".
Jan 29 2019, 10:34 AM · Continuous-Integration-Config, Wikidata, Math
RazeSoldier removed a subtask for T198564: Misleading error message "Mathoid cli /path/to/cli.js is not executable.": T210724: Math test 'Class undefined: Wikibase\DataModel\Entity\ItemId' failing in CI build.
Jan 29 2019, 10:34 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Math
RazeSoldier closed T198564: Misleading error message "Mathoid cli /path/to/cli.js is not executable." as Resolved.

1.32 already released. The reason for my backporting does not exist anymore.

Jan 29 2019, 10:22 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Math
RazeSoldier removed a project from T214881: Page cannot be marked as patrolled if moved from User: namespace to Main namespace: MediaWiki-extensions-Patroller.

We didn't use this extension.

Jan 29 2019, 9:15 AM · MediaWiki-Patrolling, Chinese-Sites

Jan 23 2019

RazeSoldier placed T204954: Uncaught MWException: SpecialEditWatchlistTest::tearDown() must call parent::tearDown() up for grabs.
Jan 23 2019, 7:34 PM · MediaWiki-Core-Testing, MediaWiki-Special-pages

Jan 21 2019

RazeSoldier added a comment to T207621: Improve maintainability and scalability of Mail component.

@daniel What do we need to test? Mail content?

Jan 21 2019, 5:38 PM · Core Platform Team Kanban (Waiting for Review), MediaWiki-Decoupling, Core Platform Team (Code Health (TEC13)), TechCom, Patch-For-Review, MediaWiki-Email
RazeSoldier added a comment to T214296: VisualEditor citation tool can't load the template data at zhwiki.

May be related T213953, since I see a HTTP 500 error.

Jan 21 2019, 1:28 PM · VisualEditor-EditingTools, TemplateData, VisualEditor, Chinese-Sites
RazeSoldier added a comment to T214296: VisualEditor citation tool can't load the template data at zhwiki.

Unable to reproduce, {{Cite web}} and {{Cite news}} work well to me via VE.

Jan 21 2019, 1:17 PM · VisualEditor-EditingTools, TemplateData, VisualEditor, Chinese-Sites

Jan 16 2019

RazeSoldier added a comment to T212919: Adding transwiki source, Adding ailias to namespaces and creating "Experiment" and "Lesson" namespaces in Chinese Wikiversity.

The code does not meet standard. See my comment in the patch.

Jan 16 2019, 6:53 AM · Patch-For-Review, Wikimedia-Site-requests, Chinese-Sites
RazeSoldier renamed T209159: fread() blocked wfShellExecTest::testT69870() under Windows from PHPUnit test job under Windows blocked by wfShellExec() to fread() blocked wfShellExecTest::testT69870() under Windows.
Jan 16 2019, 6:20 AM · MediaWiki-Shell, MediaWiki-Core-Testing

Jan 12 2019

RazeSoldier claimed T77127: Add Special:Users as a synonym for Special:ListUsers.
Jan 12 2019, 5:21 PM · Patch-For-Review, good first bug, MediaWiki-User-management

Jan 10 2019

RazeSoldier awarded Blog Post: Code Health Metrics and SonarQube a Like token.
Jan 10 2019, 4:39 PM · Code-Health-Metrics, Release-Engineering-Team

Jan 8 2019

RazeSoldier added a comment to T212272: Assign "suppressredirect" to patroller on Chinese Wikivoyage.

Any process for this task?

Jan 8 2019, 5:27 AM · Patch-For-Review, Wikimedia-Site-requests, Chinese-Sites
RazeSoldier updated the task description for T212919: Adding transwiki source, Adding ailias to namespaces and creating "Experiment" and "Lesson" namespaces in Chinese Wikiversity.
Jan 8 2019, 5:23 AM · Patch-For-Review, Wikimedia-Site-requests, Chinese-Sites

Jan 4 2019

RazeSoldier moved T212919: Adding transwiki source, Adding ailias to namespaces and creating "Experiment" and "Lesson" namespaces in Chinese Wikiversity from Backlog to Site configuration on the Chinese-Sites board.
Jan 4 2019, 5:27 AM · Patch-For-Review, Wikimedia-Site-requests, Chinese-Sites

Dec 22 2018

RazeSoldier updated the task description for T212272: Assign "suppressredirect" to patroller on Chinese Wikivoyage.
Dec 22 2018, 8:26 AM · Patch-For-Review, Wikimedia-Site-requests, Chinese-Sites
RazeSoldier reassigned T39159: sqlite: DatabaseBase::delete and DatabaseBase::update return ResultWrapper object from RazeSoldier to aaron.
Dec 22 2018, 7:28 AM · Performance-Team, good first bug, SQLite, MediaWiki-Database
RazeSoldier updated the task description for T129499: Move ZhConversion conversion tables from static class to array file.
Dec 22 2018, 6:39 AM · Chinese-Sites, MediaWiki-Language-converter, MediaWiki-Internationalization
RazeSoldier added a comment to T129499: Move ZhConversion conversion tables from static class to array file.

It seems that this task is a bit complicated to implement for me, because we need to rebuild the maintenance script written in python. Maybe we can coding a php wrapper that wraps the python script first.

Dec 22 2018, 5:14 AM · Chinese-Sites, MediaWiki-Language-converter, MediaWiki-Internationalization

Dec 21 2018

RazeSoldier added a comment to T129499: Move ZhConversion conversion tables from static class to array file.

@Krinkle So the focus of this task should actually be to dump the static properties of the class into one/multiple php array files instead of json?

Dec 21 2018, 12:24 AM · Chinese-Sites, MediaWiki-Language-converter, MediaWiki-Internationalization

Dec 19 2018

RazeSoldier added a comment to T212272: Assign "suppressredirect" to patroller on Chinese Wikivoyage.

@BJ6123C7BTD Why also have rollbacker here? I don't seem to see a discussion about rollbacker.

Dec 19 2018, 9:52 AM · Patch-For-Review, Wikimedia-Site-requests, Chinese-Sites

Dec 18 2018

RazeSoldier added a comment to T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.

RazeSoldier added a subtask: T207100: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3.

Dec 18 2018, 12:31 AM · MediaWiki-Debian, MediaWiki-Releasing, PHP 7.3 support, MW-1.31-release
RazeSoldier added a parent task for T207100: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3: T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.
Dec 18 2018, 12:28 AM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, PHP 7.3 support, MediaWiki-Internationalization
RazeSoldier added a subtask for T206988: MediaWiki 1.31.x should be compatible with PHP 7.3: T207100: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3.
Dec 18 2018, 12:28 AM · MediaWiki-Debian, MediaWiki-Releasing, PHP 7.3 support, MW-1.31-release

Dec 17 2018

RazeSoldier added a comment to T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.

MediaWiki 1.32.x should be compatible with PHP 7.3? If should, may be add MW-1.32-release.

Dec 17 2018, 3:43 PM · MediaWiki-Debian, MediaWiki-Releasing, PHP 7.3 support, MW-1.31-release

Dec 10 2018

RazeSoldier closed T207127: Publish wikimedia/less.php on Packagist as Resolved.

Looks like already done.

Dec 10 2018, 3:48 PM · PHP 7.3 support, Composer
RazeSoldier closed T207127: Publish wikimedia/less.php on Packagist, a subtask of T206975: vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php triggers warnings in PHP 7.3, as Resolved.
Dec 10 2018, 3:48 PM · MW-1.31-release-notes, MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MW-1.32-release, MW-1.31-release, Patch-For-Review, PHP 7.3 support, Upstream, MediaWiki-Vendor

Dec 9 2018

RazeSoldier closed T206975: vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php triggers warnings in PHP 7.3 as Resolved.
Dec 9 2018, 3:33 PM · MW-1.31-release-notes, MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MW-1.32-release, MW-1.31-release, Patch-For-Review, PHP 7.3 support, Upstream, MediaWiki-Vendor
RazeSoldier closed T206975: vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php triggers warnings in PHP 7.3, a subtask of T206988: MediaWiki 1.31.x should be compatible with PHP 7.3, as Resolved.
Dec 9 2018, 3:33 PM · MediaWiki-Debian, MediaWiki-Releasing, PHP 7.3 support, MW-1.31-release

Nov 29 2018

RazeSoldier added a comment to T198564: Misleading error message "Mathoid cli /path/to/cli.js is not executable.".

@RazeSoldier I got the impression that backporting changes is unusual. I think we have to wait for the 1.33 release. If you find someone to review your backport change I have no objections to it. I am not just knowledgeable enough myself to oversee the consequences.

Nov 29 2018, 1:37 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Math
RazeSoldier awarded T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set" a Like token.
Nov 29 2018, 1:21 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks
RazeSoldier added a subtask for T198564: Misleading error message "Mathoid cli /path/to/cli.js is not executable.": T210724: Math test 'Class undefined: Wikibase\DataModel\Entity\ItemId' failing in CI build.
Nov 29 2018, 1:19 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Math
RazeSoldier added a parent task for T210724: Math test 'Class undefined: Wikibase\DataModel\Entity\ItemId' failing in CI build: T198564: Misleading error message "Mathoid cli /path/to/cli.js is not executable.".
Nov 29 2018, 1:19 PM · Continuous-Integration-Config, Wikidata, Math
RazeSoldier created T210724: Math test 'Class undefined: Wikibase\DataModel\Entity\ItemId' failing in CI build.
Nov 29 2018, 1:19 PM · Continuous-Integration-Config, Wikidata, Math
RazeSoldier added a comment to T207125: If Zlib extension is not loaded, the Zlib related tests should be skipped.

Also https://codesearch.wmflabs.org/core/?q=gzdeflate&i=nope&files=&repos=.

Nov 29 2018, 12:09 AM · MediaWiki-Core-Testing

Nov 22 2018

RazeSoldier moved T198564: Misleading error message "Mathoid cli /path/to/cli.js is not executable." from Incoming to Doing on the Math board.
Nov 22 2018, 10:35 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Math

Nov 20 2018

RazeSoldier triaged T198564: Misleading error message "Mathoid cli /path/to/cli.js is not executable." as Normal priority.
Nov 20 2018, 10:23 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Math
RazeSoldier claimed T198564: Misleading error message "Mathoid cli /path/to/cli.js is not executable.".
Nov 20 2018, 10:23 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Math
RazeSoldier merged T209928: Error message for Math extension is not clear when failed to execute mathoid/cli.js into T198564: Misleading error message "Mathoid cli /path/to/cli.js is not executable.".
Nov 20 2018, 10:21 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Math
RazeSoldier merged task T209928: Error message for Math extension is not clear when failed to execute mathoid/cli.js into T198564: Misleading error message "Mathoid cli /path/to/cli.js is not executable.".
Nov 20 2018, 10:21 AM · good first bug, Math
RazeSoldier added a project to T209928: Error message for Math extension is not clear when failed to execute mathoid/cli.js: good first bug.
Nov 20 2018, 10:07 AM · good first bug, Math
RazeSoldier created T209928: Error message for Math extension is not clear when failed to execute mathoid/cli.js.
Nov 20 2018, 10:06 AM · good first bug, Math

Nov 19 2018

RazeSoldier added a comment to T209756: IPSet tests fail on PHP 7.3.

So, checks the method return value instead of check the warning triggered would be better?

Nov 19 2018, 12:03 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), MW-1.31-release-notes, MW-1.32-notes, Patch-For-Review, IPSet, PHP 7.3 support

Nov 18 2018

RazeSoldier claimed T209756: IPSet tests fail on PHP 7.3.
Nov 18 2018, 8:55 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), MW-1.31-release-notes, MW-1.32-notes, Patch-For-Review, IPSet, PHP 7.3 support
RazeSoldier added a comment to T209756: IPSet tests fail on PHP 7.3.

For my test, the warning is not only triggered once. trigger_error() (https://github.com/wikimedia/IPSet/blob/master/src/IPSet.php#L126) and inet_pton() will trigger a warning. This looks very messy. We may need to improve the test logic before fixing this compatibility issue.

Nov 18 2018, 5:42 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), MW-1.31-release-notes, MW-1.32-notes, Patch-For-Review, IPSet, PHP 7.3 support
RazeSoldier added a comment to T209756: IPSet tests fail on PHP 7.3.
Nov 18 2018, 5:29 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), MW-1.31-release-notes, MW-1.32-notes, Patch-For-Review, IPSet, PHP 7.3 support
RazeSoldier added a comment to T209756: IPSet tests fail on PHP 7.3.
Nov 18 2018, 5:29 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), MW-1.31-release-notes, MW-1.32-notes, Patch-For-Review, IPSet, PHP 7.3 support
RazeSoldier moved T209756: IPSet tests fail on PHP 7.3 from Backlog to Other on the PHP 7.3 support board.
Nov 18 2018, 4:56 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), MW-1.31-release-notes, MW-1.32-notes, Patch-For-Review, IPSet, PHP 7.3 support

Nov 16 2018

RazeSoldier claimed T207116: CentralAuth/maintenance/migrateAccount.php triggers warnings on PHP 7.3.
Nov 16 2018, 1:47 PM · Patch-For-Review, PHP 7.3 support, MediaWiki-extensions-CentralAuth

Nov 15 2018

RazeSoldier closed T206976: LocalisationUpdate/includes/QuickArrayReader.php triggers warnings in PHP 7.3 as Resolved.
Nov 15 2018, 11:56 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), MW-1.31-release, MW-1.32-release, PHP 7.3 support, MediaWiki-extensions-LocalisationUpdate
RazeSoldier closed T206976: LocalisationUpdate/includes/QuickArrayReader.php triggers warnings in PHP 7.3, a subtask of T206988: MediaWiki 1.31.x should be compatible with PHP 7.3, as Resolved.
Nov 15 2018, 11:56 PM · MediaWiki-Debian, MediaWiki-Releasing, PHP 7.3 support, MW-1.31-release
RazeSoldier closed T207255: Notice: compact(): Undefined variable: ... in /workspace/src/extensions/LabeledSectionTransclusion/LabeledSectionTransclusion.class.php as Resolved.
Nov 15 2018, 11:56 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), PHP 7.3 support, MediaWiki-extensions-LabeledSectionTransclusion

Nov 10 2018

RazeSoldier claimed T207255: Notice: compact(): Undefined variable: ... in /workspace/src/extensions/LabeledSectionTransclusion/LabeledSectionTransclusion.class.php.
Nov 10 2018, 8:05 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), PHP 7.3 support, MediaWiki-extensions-LabeledSectionTransclusion
RazeSoldier claimed T206976: LocalisationUpdate/includes/QuickArrayReader.php triggers warnings in PHP 7.3.
Nov 10 2018, 6:59 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), MW-1.31-release, MW-1.32-release, PHP 7.3 support, MediaWiki-extensions-LocalisationUpdate

Nov 9 2018

RazeSoldier moved T209159: fread() blocked wfShellExecTest::testT69870() under Windows from Inbox to PHPUnit on the MediaWiki-Core-Testing board.
Nov 9 2018, 4:02 PM · MediaWiki-Shell, MediaWiki-Core-Testing
RazeSoldier created T209159: fread() blocked wfShellExecTest::testT69870() under Windows.
Nov 9 2018, 4:02 PM · MediaWiki-Shell, MediaWiki-Core-Testing

Nov 8 2018

RazeSoldier closed T204954: Uncaught MWException: SpecialEditWatchlistTest::tearDown() must call parent::tearDown() as Resolved.
Nov 8 2018, 2:30 PM · MediaWiki-Core-Testing, MediaWiki-Special-pages
RazeSoldier added a comment to T207122: Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3.

REL1_32 patch still need to merge.

Nov 8 2018, 2:10 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, PHP 7.3 support, StructuredDiscussions, Growth-Team

Nov 7 2018

RazeSoldier added a comment to T204954: Uncaught MWException: SpecialEditWatchlistTest::tearDown() must call parent::tearDown().

Also REL1_31 without this problem.

Nov 7 2018, 3:09 PM · MediaWiki-Core-Testing, MediaWiki-Special-pages
RazeSoldier added a comment to T204954: Uncaught MWException: SpecialEditWatchlistTest::tearDown() must call parent::tearDown().

9fbbce85 already include in REL1_32. I don't know why this will fix the problem. But the problem has actually been solved, so we should mark this task as resolved.

Nov 7 2018, 10:36 AM · MediaWiki-Core-Testing, MediaWiki-Special-pages
RazeSoldier added a comment to T204954: Uncaught MWException: SpecialEditWatchlistTest::tearDown() must call parent::tearDown().

For my test (run P7769), I find 0c4b5ca fix this problem.

Nov 7 2018, 10:12 AM · MediaWiki-Core-Testing, MediaWiki-Special-pages
RazeSoldier edited P7769 To find Uncaught MWException: SpecialEditWatchlistTest::tearDown() must call parent::tearDown().
Nov 7 2018, 9:47 AM
RazeSoldier created P7769 To find Uncaught MWException: SpecialEditWatchlistTest::tearDown() must call parent::tearDown().
Nov 7 2018, 2:21 AM

Nov 5 2018

RazeSoldier updated the task description for T204954: Uncaught MWException: SpecialEditWatchlistTest::tearDown() must call parent::tearDown().
Nov 5 2018, 6:00 PM · MediaWiki-Core-Testing, MediaWiki-Special-pages
RazeSoldier added a comment to T204954: Uncaught MWException: SpecialEditWatchlistTest::tearDown() must call parent::tearDown().

I noticed the discussion in the patch. I want to report:

  1. This task title looks wrong, may be Uncaught MWException: SpecialEditWatchlistTest::tearDown() must call parent::tearDown() would be best, because the exception actually no interrupt test and just show text in the test report end.
  2. I can't reproduce this problem at the current HEAD commit (6ac8c49). But when I checkout to 27cb4c5, I can reproduce.
Nov 5 2018, 5:58 PM · MediaWiki-Core-Testing, MediaWiki-Special-pages

Nov 3 2018

RazeSoldier added a parent task for T200595: [PHP 7.3] Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?: T206988: MediaWiki 1.31.x should be compatible with PHP 7.3.
Nov 3 2018, 3:51 PM · MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review, MediaWiki-General-or-Unknown, PHP 7.3 support
RazeSoldier added a subtask for T206988: MediaWiki 1.31.x should be compatible with PHP 7.3: T200595: [PHP 7.3] Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?.
Nov 3 2018, 3:51 PM · MediaWiki-Debian, MediaWiki-Releasing, PHP 7.3 support, MW-1.31-release

Oct 31 2018

RazeSoldier added a comment to T207541: php mail() to argument is MailAddress Object instead of string.

@Reedy Can we mark resolved?

Oct 31 2018, 4:48 AM · MW-1.27-release-notes, MW-1.30-release-notes, MW-1.31-release-notes, MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), MW-1.31-release, MediaWiki-Email

Oct 28 2018

RazeSoldier added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

@RazeSoldier, can you comment more details why you say it is not resolved?
Note that this fix is not yet deployed in production.

Oct 28 2018, 2:37 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks
RazeSoldier added a comment to T191442: 'Send thanks' button fails on Flow thanks page: "The postid parameter must be set".

Looks like not solved.

Oct 28 2018, 8:43 AM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team, Mobile, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Thanks

Oct 22 2018

RazeSoldier added a comment to T207621: Improve maintainability and scalability of Mail component.

Since I am working on a design-related task for the first time, it would be nice if someone came to verify the intention or provide help of this task.

Oct 22 2018, 3:12 AM · Core Platform Team Kanban (Waiting for Review), MediaWiki-Decoupling, Core Platform Team (Code Health (TEC13)), TechCom, Patch-For-Review, MediaWiki-Email
RazeSoldier created T207621: Improve maintainability and scalability of Mail component.
Oct 22 2018, 3:09 AM · Core Platform Team Kanban (Waiting for Review), MediaWiki-Decoupling, Core Platform Team (Code Health (TEC13)), TechCom, Patch-For-Review, MediaWiki-Email

Oct 21 2018

RazeSoldier added projects to T207578: TypeError: Argument 1 passed to MediaWiki\Linker\LinkRenderer::makeLink() must implement interface MediaWiki\Linker\LinkTarget, null given, called in Flow/includes/Formatter/AbstractFormatter.php on line 309: MW-1.31-release, MW-1.32-release.

Because this issue affects backport changes, I added these tags.

Oct 21 2018, 5:38 AM · MW-1.32-release, MW-1.31-release, Growth-Team, StructuredDiscussions
RazeSoldier created T207578: TypeError: Argument 1 passed to MediaWiki\Linker\LinkRenderer::makeLink() must implement interface MediaWiki\Linker\LinkTarget, null given, called in Flow/includes/Formatter/AbstractFormatter.php on line 309.
Oct 21 2018, 5:10 AM · MW-1.32-release, MW-1.31-release, Growth-Team, StructuredDiscussions
RazeSoldier added a project to T207577: Create a Special:NewSection page: MediaWiki-Special-pages.
Oct 21 2018, 4:02 AM · MediaWiki-Special-pages

Oct 20 2018

RazeSoldier updated the task description for T207563: count(): Parameter must be an array or an object that implements Countable in Flow/includes/TemplateHelper.php.
Oct 20 2018, 6:11 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Growth-Team, PHP 7.2 support, StructuredDiscussions
RazeSoldier updated the task description for T207563: count(): Parameter must be an array or an object that implements Countable in Flow/includes/TemplateHelper.php.
Oct 20 2018, 6:10 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Growth-Team, PHP 7.2 support, StructuredDiscussions
RazeSoldier created T207563: count(): Parameter must be an array or an object that implements Countable in Flow/includes/TemplateHelper.php.
Oct 20 2018, 6:09 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Growth-Team, PHP 7.2 support, StructuredDiscussions

Oct 17 2018

RazeSoldier reopened T207122: Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3 as "Open".

Some changes can't merge due test failure.

Oct 17 2018, 5:23 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, PHP 7.3 support, StructuredDiscussions, Growth-Team
RazeSoldier reopened T207122: Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3, a subtask of T204884: Run MediaWiki tests on PHP 7.3, as Open.
Oct 17 2018, 5:23 PM · PHP 7.3 support, Core Platform Team Kanban (Doing), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), Continuous-Integration-Infrastructure
RazeSoldier moved T207255: Notice: compact(): Undefined variable: ... in /workspace/src/extensions/LabeledSectionTransclusion/LabeledSectionTransclusion.class.php from Backlog to Wikimedia production on the PHP 7.3 support board.
Oct 17 2018, 12:40 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), PHP 7.3 support, MediaWiki-extensions-LabeledSectionTransclusion
RazeSoldier claimed T207122: Flow/includes/Formatter/RevisionFormatter.php triggers warnings on PHP 7.3.
Oct 17 2018, 3:25 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, PHP 7.3 support, StructuredDiscussions, Growth-Team
RazeSoldier added a comment to T204884: Run MediaWiki tests on PHP 7.3.

Are we planning to add PHP 7.3 to our travis CI?

Oct 17 2018, 3:12 AM · PHP 7.3 support, Core Platform Team Kanban (Doing), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), Continuous-Integration-Infrastructure

Oct 16 2018

RazeSoldier moved T207125: If Zlib extension is not loaded, the Zlib related tests should be skipped from Inbox to PHPUnit on the MediaWiki-Core-Testing board.
Oct 16 2018, 4:13 AM · MediaWiki-Core-Testing
RazeSoldier created T207125: If Zlib extension is not loaded, the Zlib related tests should be skipped.
Oct 16 2018, 4:13 AM · MediaWiki-Core-Testing