Reedy (Sam Reed)Administrator
Breaker of Wikis

Projects (22)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Sep 24 2014, 6:58 PM (186 w, 2 d)
Roles
Administrator
Availability
Available
IRC Nick
Reedy
LDAP User
Reedy
MediaWiki User
Reedy

Recent Activity

Today

Reedy triaged T192705: Special:GlobalUserRights does not have a value in username field when access /USERNAME as Low priority.

How you get this? means If I am a simple user then I will simply go Special:GlobalUserRights and then just type the username. and got Special:GlobalUserRights?user=rxy like url. So where you get Special:GlobalUserRights/$par?

Sat, Apr 21, 10:15 AM · Patch-For-Review, User-Jayprakash12345, MediaWiki-extensions-CentralAuth, Stewards-and-global-tools
Reedy added a comment to T188821: PasswordBlacklist unit tests fails on 32 bit machine.

@Umherirrender Poke :)

Sat, Apr 21, 10:03 AM · Patch-For-Review, Security-Team, MediaWiki-User-login-and-signup

Yesterday

Reedy closed T192670: Run initSiteStats.php for lfnwiki, inhwiki, gorwiki and euwikisource as Resolved.
Fri, Apr 20, 6:21 PM · Wikimedia-Site-requests, User-Urbanecm, Wikimedia-maintenance-script-run
Reedy added a comment to T192670: Run initSiteStats.php for lfnwiki, inhwiki, gorwiki and euwikisource.

Is this because of imports?

Fri, Apr 20, 5:18 PM · Wikimedia-Site-requests, User-Urbanecm, Wikimedia-maintenance-script-run
Reedy added a comment to T192668: wgRateLimits in ar.wikipedia.
reedy@tin:~$ mwscript eval.php arwiki
> var_dump( $wgRateLimits );
array(14) {
  ["move"]=>
  array(2) {
    ["newbie"]=>
    array(2) {
      [0]=>
      int(2)
      [1]=>
      int(120)
    }
    ["user"]=>
    array(2) {
      [0]=>
      int(8)
      [1]=>
      int(60)
    }
  }
  ["edit"]=>
  array(2) {
    ["ip"]=>
    array(2) {
      [0]=>
      int(8)
      [1]=>
      int(60)
    }
    ["newbie"]=>
    array(2) {
      [0]=>
      int(8)
      [1]=>
      int(60)
    }
  }
  ["badcaptcha"]=>
  array(3) {
    ["ip"]=>
    array(2) {
      [0]=>
      int(15)
      [1]=>
      int(60)
    }
    ["newbie"]=>
    array(2) {
      [0]=>
      int(15)
      [1]=>
      int(60)
    }
    ["user"]=>
    array(2) {
      [0]=>
      int(30)
      [1]=>
      int(60)
    }
  }
  ["mailpassword"]=>
  array(1) {
    ["ip"]=>
    array(2) {
      [0]=>
      int(5)
      [1]=>
      int(3600)
    }
  }
  ["emailuser"]=>
  array(3) {
    ["ip"]=>
    array(2) {
      [0]=>
      int(5)
      [1]=>
      int(86400)
    }
    ["newbie"]=>
    array(2) {
      [0]=>
      int(5)
      [1]=>
      int(86400)
    }
    ["user"]=>
    array(2) {
      [0]=>
      int(20)
      [1]=>
      int(86400)
    }
  }
  ["rollback"]=>
  array(3) {
    ["user"]=>
    array(2) {
      [0]=>
      int(10)
      [1]=>
      int(60)
    }
    ["newbie"]=>
    array(2) {
      [0]=>
      int(5)
      [1]=>
      int(120)
    }
    ["rollbacker"]=>
    array(2) {
      [0]=>
      int(100)
      [1]=>
      int(60)
    }
  }
  ["purge"]=>
  array(2) {
    ["ip"]=>
    array(2) {
      [0]=>
      int(30)
      [1]=>
      int(60)
    }
    ["user"]=>
    array(2) {
      [0]=>
      int(30)
      [1]=>
      int(60)
    }
  }
  ["linkpurge"]=>
  array(2) {
    ["ip"]=>
    array(2) {
      [0]=>
      int(30)
      [1]=>
      int(60)
    }
    ["user"]=>
    array(2) {
      [0]=>
      int(30)
      [1]=>
      int(60)
    }
  }
  ["renderfile"]=>
  array(2) {
    ["ip"]=>
    array(2) {
      [0]=>
      int(700)
      [1]=>
      int(30)
    }
    ["user"]=>
    array(2) {
      [0]=>
      int(700)
      [1]=>
      int(30)
    }
  }
  ["renderfile-nonstandard"]=>
  array(2) {
    ["ip"]=>
    array(2) {
      [0]=>
      int(70)
      [1]=>
      int(30)
    }
    ["user"]=>
    array(2) {
      [0]=>
      int(70)
      [1]=>
      int(30)
    }
  }
  ["cxsave"]=>
  array(2) {
    ["ip"]=>
    array(2) {
      [0]=>
      int(10)
      [1]=>
      int(30)
    }
    ["user"]=>
    array(2) {
      [0]=>
      int(10)
      [1]=>
      int(30)
    }
  }
  ["urlshortcode"]=>
  array(3) {
    ["ip"]=>
    array(2) {
      [0]=>
      int(10)
      [1]=>
      int(120)
    }
    ["newbie"]=>
    array(2) {
      [0]=>
      int(10)
      [1]=>
      int(120)
    }
    ["user"]=>
    array(2) {
      [0]=>
      int(50)
      [1]=>
      int(120)
    }
  }
  ["thanks-notification"]=>
  array(1) {
    ["user"]=>
    array(2) {
      [0]=>
      int(10)
      [1]=>
      int(60)
    }
  }
  ["badoath"]=>
  array(2) {
    ["&can-bypass"]=>
    bool(false)
    ["user"]=>
    array(2) {
      [0]=>
      int(10)
      [1]=>
      int(60)
    }
  }
}
Fri, Apr 20, 4:33 PM · Patch-For-Review, User-Urbanecm, Wikimedia-Site-requests
Reedy removed a project from T192668: wgRateLimits in ar.wikipedia: MediaWiki-extension-requests.
Fri, Apr 20, 4:32 PM · Patch-For-Review, User-Urbanecm, Wikimedia-Site-requests
Reedy added a comment to T72597: Jenkins Gearman plugin has deadlock on executor threads (was: Beta Cluster stopped receiving code updates (beta-update-databases-eqiad hung).

This happens once in a while. It's some sort of deadlock in Jenkins itself. Here's how I generally try to resolve it:

Fri, Apr 20, 3:15 PM · Patch-For-Review, Release-Engineering-Team (Watching / External), Upstream, Jenkins, Continuous-Integration-Infrastructure
Reedy triaged T171013: Clarify populateSitesTable.php instructions in Add a Wiki as Unbreak Now! priority.

Can we get all this fixed up please? This and https://gerrit.wikimedia.org/r/#/c/339144/

Fri, Apr 20, 1:23 PM · Wikimedia-General-or-Unknown, Documentation, Wikidata
Reedy added a comment to T183561: Create Wikipedia Lingua Franca Nova 2.

We need to ask Wikidata team to run the populate scripts

Fri, Apr 20, 1:20 PM · User-Urbanecm, Wiki-Setup (Create), Patch-For-Review
Reedy removed projects from T142120: Remove UnitTestsList hook subscribers, move tests to be autodiscovered for extensions that have been converted to extension registration: MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), MW-1.28-release (WMF-deploy-2016-08-09_(1.28.0-wmf.14)), Patch-For-Review.
Fri, Apr 20, 9:08 AM · Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MediaWiki-Core-Tests, MediaWiki-extensions-General
Reedy added a comment to T172165: Require either PHP 7.0+ or HHVM in MW 1.31.

PHP 7.0 will be supported until December of this year: http://php.net/archive/2018.php#id2018-01-04-1

The task should be changed from "7.0+" to "7.1+", and the support end-year should be corrected from "Dec 2019" to "Dec 2018"

Fri, Apr 20, 8:08 AM · MW-1.31-release-notes, MW-1.31-release, Patch-For-Review, TechCom-RFC (TechCom-Approved), MediaWiki-General-or-Unknown
Reedy added a comment to T172165: Require either PHP 7.0+ or HHVM in MW 1.31.

What exactly is blocking master to require PHP 7, if even 1.31 is already requiring it?

Fri, Apr 20, 7:36 AM · MW-1.31-release-notes, MW-1.31-release, Patch-For-Review, TechCom-RFC (TechCom-Approved), MediaWiki-General-or-Unknown

Thu, Apr 19

Reedy added projects to T192609: Search backend error during sending {numBulk} documents to the {index} index(s) after {tookMs}: {error_message}: Discovery-Search, CirrusSearch.
Thu, Apr 19, 10:47 PM · Discovery-Search (Current work), MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)), MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, Discovery, CirrusSearch, Wikimedia-log-errors
Reedy updated the task description for T47822: More composer php extension dependencies.
Thu, Apr 19, 10:28 PM · MediaWiki-Installer
Reedy added a comment to T172165: Require either PHP 7.0+ or HHVM in MW 1.31.

Should we have a formal list/guidelines of what is allowed and what is not, once the switch is done, somewhere on wiki? At least for the period when hhvm support is still required.

Thu, Apr 19, 9:02 PM · MW-1.31-release-notes, MW-1.31-release, Patch-For-Review, TechCom-RFC (TechCom-Approved), MediaWiki-General-or-Unknown
Reedy closed T192590: Wikibase broken under tests in REL1_28 as Declined.

We don't care about 1.28

Thu, Apr 19, 7:46 PM · Wikidata
Reedy closed T192587: phpcs fail under REL1_28 as Declined.

Meh, just abandon the patches then :)

Thu, Apr 19, 7:45 PM · MW-1.28-release
Reedy updated the task description for T192590: Wikibase broken under tests in REL1_28.
Thu, Apr 19, 7:44 PM · Wikidata
Reedy closed T192589: Vinesh Phogat - 2018 Gold Coast as Resolved.

Wikipedia is a wiki, anyone can edit it.

Thu, Apr 19, 7:38 PM
Reedy created T192590: Wikibase broken under tests in REL1_28.
Thu, Apr 19, 7:35 PM · Wikidata
Reedy updated the task description for T192587: phpcs fail under REL1_28.
Thu, Apr 19, 7:31 PM · MW-1.28-release
Reedy created T192587: phpcs fail under REL1_28.
Thu, Apr 19, 7:25 PM · MW-1.28-release
Reedy added a comment to T139012: Use index on rc_this_oldid.

These ones indirectly use rc_timestamp index to get faster results: (Per source code RecentChange::newFromConds passes conds to db query.) It seems rc_timestamp is not used and it's there just for sake of the index. Note that in these cases rc_timestamp is used once. Search for it.

  1. On Article.php
Thu, Apr 19, 7:12 PM · TechCom-RFC (TechCom-Approved), MediaWiki-Database, Schema-change
Reedy added a comment to T192584: Error occurs in file page for Own uploaded files@1.31.0-wmf.30 (e8360e8).

From Article.php...

Thu, Apr 19, 7:00 PM · MW-1.27-release-notes, MW-1.30-release-notes, MW-1.29-release-notes, MW-1.31-release-notes, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review
Reedy added a comment to T192203: Reword documentation to suggest PHP/MySQL versions, rather than making minimum version prominent.

Is there anywhere else?

Thu, Apr 19, 6:42 PM · Documentation, MediaWiki-Documentation
Reedy updated the task description for T192453: Remove requirement for security review of well maintained third party libraries.
Thu, Apr 19, 12:59 PM · MediaWiki-Documentation, MediaWiki-Vendor, MediaWiki-General-or-Unknown, RfC, Security, Security-Team, Documentation
Reedy added a comment to T192484: No way to specify a php version XOR hhvm version in composer.json.

[04:13:05] <legoktm> I suggested php >= 5.6.99
[04:13:14] <legoktm> that'll work with HHVM and require PHP 7

Thu, Apr 19, 10:42 AM · Composer, MediaWiki-General-or-Unknown

Wed, Apr 18

Reedy added a comment to T192472: Requesting access to analytics servers for mepps.

Victoria then? Unless there's someone else in between. Needs to go up the chain for approval

Wed, Apr 18, 8:10 PM · Patch-For-Review, Operations, Ops-Access-Requests
Reedy created P7011 (An Untitled Masterwork).
Wed, Apr 18, 7:42 PM
Reedy created T192484: No way to specify a php version XOR hhvm version in composer.json.
Wed, Apr 18, 6:52 PM · Composer, MediaWiki-General-or-Unknown
Reedy merged T192470: Scap syntax error on beta into T191921: mwscript rebuildLocalisationCache.php takes 40 minutes.
Wed, Apr 18, 5:20 PM · Operations, Release-Engineering-Team (Kanban), Scap
Reedy merged task T192470: Scap syntax error on beta into T191921: mwscript rebuildLocalisationCache.php takes 40 minutes.
Wed, Apr 18, 5:20 PM · Scap, Beta-Cluster-Infrastructure
Reedy reopened T192469: `scap update-interwiki-cache` broken as "Open".

Wrong one

Wed, Apr 18, 5:19 PM · Scap
Reedy updated subscribers of T192472: Requesting access to analytics servers for mepps.

You'll want approval from @K4-713 :)

Wed, Apr 18, 5:19 PM · Patch-For-Review, Operations, Ops-Access-Requests
Reedy added a project to T192472: Requesting access to analytics servers for mepps: Ops-Access-Requests.
Wed, Apr 18, 5:17 PM · Patch-For-Review, Operations, Ops-Access-Requests
Reedy committed rETSTe5da5c0c186c: Update wikimedia/css-sanitizer to ~1.0.6 (authored by Reedy).
Update wikimedia/css-sanitizer to ~1.0.6
Wed, Apr 18, 5:16 PM
Reedy merged T192469: `scap update-interwiki-cache` broken into T191921: mwscript rebuildLocalisationCache.php takes 40 minutes.
Wed, Apr 18, 4:51 PM · Operations, Release-Engineering-Team (Kanban), Scap
Reedy merged task T192469: `scap update-interwiki-cache` broken into T191921: mwscript rebuildLocalisationCache.php takes 40 minutes.
Wed, Apr 18, 4:51 PM · Scap
Reedy created T192470: Scap syntax error on beta.
Wed, Apr 18, 4:43 PM · Scap, Beta-Cluster-Infrastructure
Reedy created T192469: `scap update-interwiki-cache` broken.
Wed, Apr 18, 4:40 PM · Scap
Reedy closed T192468: MassMessage fatal in addWiki.php as Resolved.
Wed, Apr 18, 4:30 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MediaWiki-extensions-WikimediaMaintenance, MassMessage
Reedy triaged T192468: MassMessage fatal in addWiki.php as High priority.
Wed, Apr 18, 4:20 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MediaWiki-extensions-WikimediaMaintenance, MassMessage
Reedy created T192468: MassMessage fatal in addWiki.php.
Wed, Apr 18, 4:19 PM · MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), MediaWiki-extensions-WikimediaMaintenance, MassMessage
Reedy added a comment to T192458: Enable search result ranking in MySQL full text search.

Why would you use a sub string? Wouldn't it make more sense to change the SQL being returned by parseQuery?

Wed, Apr 18, 3:54 PM · Discovery-Search, Discovery, MediaWiki-Search
Reedy updated the task description for T192460: Create mediawiki/extension-tooling meta project.
Wed, Apr 18, 3:14 PM · MediaWiki-extensions-General, Technical-Debt
Reedy added a subtask for T192460: Create mediawiki/extension-tooling meta project: T192448: Add PHP Magic Number Detector.
Wed, Apr 18, 3:05 PM · MediaWiki-extensions-General, Technical-Debt
Reedy added a parent task for T192448: Add PHP Magic Number Detector: T192460: Create mediawiki/extension-tooling meta project.
Wed, Apr 18, 3:05 PM · Technical-Debt, MediaWiki-General-or-Unknown
Reedy renamed T192460: Create mediawiki/extension-tooling meta project from Create mediawiki/extension-tooling to Create mediawiki/extension-tooling meta project.
Wed, Apr 18, 3:05 PM · MediaWiki-extensions-General, Technical-Debt
Reedy created T192460: Create mediawiki/extension-tooling meta project.
Wed, Apr 18, 3:04 PM · MediaWiki-extensions-General, Technical-Debt
Reedy edited projects for T192448: Add PHP Magic Number Detector, added: Technical-Debt; removed Code-Health.
Wed, Apr 18, 2:40 PM · Technical-Debt, MediaWiki-General-or-Unknown
Reedy removed a project from T187037: Update at-ease calls in extensions: MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)).
Wed, Apr 18, 2:34 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, Easy, at-ease
Reedy committed rETSTce81668170e2: Update wikimedia/css-sanitizer to ~1.0.6 (authored by Reedy).
Update wikimedia/css-sanitizer to ~1.0.6
Wed, Apr 18, 2:25 PM
Reedy committed rETSTe6314c4df51c: Update wikimedia/css-sanitizer to ~1.0.6 (authored by Reedy).
Update wikimedia/css-sanitizer to ~1.0.6
Wed, Apr 18, 2:25 PM
Reedy committed rETST2f97a064b5eb: Update wikimedia/css-sanitizer to ~1.0.6 (authored by Reedy).
Update wikimedia/css-sanitizer to ~1.0.6
Wed, Apr 18, 2:25 PM
Reedy added a comment to T191638: Security review of symfony/validator library.

FWIW, T192453 filed as a discussion/TODO as to whether we actually need to do a security review for libraries from well known developers like Symfony

Wed, Apr 18, 2:16 PM · Security-Reviews, Wikidata, Lexicographical data
Reedy updated the task description for T192453: Remove requirement for security review of well maintained third party libraries.
Wed, Apr 18, 1:59 PM · MediaWiki-Documentation, MediaWiki-Vendor, MediaWiki-General-or-Unknown, RfC, Security, Security-Team, Documentation
Reedy updated the task description for T192453: Remove requirement for security review of well maintained third party libraries.
Wed, Apr 18, 1:50 PM · MediaWiki-Documentation, MediaWiki-Vendor, MediaWiki-General-or-Unknown, RfC, Security, Security-Team, Documentation
Reedy created T192453: Remove requirement for security review of well maintained third party libraries.
Wed, Apr 18, 1:48 PM · MediaWiki-Documentation, MediaWiki-Vendor, MediaWiki-General-or-Unknown, RfC, Security, Security-Team, Documentation
Reedy committed rCSSS0989586efaed: Replace mediawiki/at-ease with wikimedia/at-ease (authored by Reedy).
Replace mediawiki/at-ease with wikimedia/at-ease
Wed, Apr 18, 1:22 PM
Reedy committed rCSSS8998e5d95cb1: Replace mediawiki/at-ease with wikimedia/at-ease (authored by Reedy).
Replace mediawiki/at-ease with wikimedia/at-ease
Wed, Apr 18, 1:22 PM
Reedy added a project to T192448: Add PHP Magic Number Detector: Code-Health.
Wed, Apr 18, 12:53 PM · Technical-Debt, MediaWiki-General-or-Unknown
Reedy created T192448: Add PHP Magic Number Detector.
Wed, Apr 18, 12:49 PM · Technical-Debt, MediaWiki-General-or-Unknown
Reedy added a comment to T188821: PasswordBlacklist unit tests fails on 32 bit machine.

Can you upload the generated file you have from your 32bit machine? I'll make some changes to the library to do support it

Wed, Apr 18, 12:40 PM · Patch-For-Review, Security-Team, MediaWiki-User-login-and-signup

Mon, Apr 16

Reedy updated the task description for T192295: Can't upload SVG files?.
Mon, Apr 16, 3:00 PM · TCB-Team, Move-Files-To-Commons
Reedy renamed T192263: Expiry time for group invalid on Special:UserRights from Expiry time invalid on Special:UserRights to Expiry time invalid on createAndPromote.php.
Mon, Apr 16, 11:05 AM · MediaWiki-General-or-Unknown
Reedy added a comment to T192252: Change default collation for WMF projects from uppercase to uca-default-u-kn.

If you ask Operations they should be able to give an indication of how long this will take to run the script over all the wikis (see T189295: ICU 57 migration for wikis using non-default collation}

Mon, Apr 16, 9:17 AM · Wikimedia-Site-requests, MediaWiki-Categories

Sun, Apr 15

Reedy added a project to T192241: Abuse filters cannot be edited without javascript: Regression.
Sun, Apr 15, 8:44 PM · Patch-For-Review, CodeEditor, Regression, AbuseFilter
Reedy removed a project from T147778: Switch MediaWiki coverage job from PHP 5 to PHP 7: Patch-For-Review.
Sun, Apr 15, 7:55 PM · Patch-For-Review, Test-Coverage, Release-Engineering-Team (Someday), Continuous-Integration-Config
Reedy renamed T192236: Add tag filter to Special:ListFiles from Add tag filter to Special:ListFiles on Wikimedia Commons to Add tag filter to Special:ListFiles.
Sun, Apr 15, 6:11 PM · MediaWiki-Change-tagging, MediaWiki-Special-pages, Commons, Multimedia
Reedy edited projects for T192236: Add tag filter to Special:ListFiles, added: MediaWiki-Special-pages; removed UploadWizard.
Sun, Apr 15, 5:56 PM · MediaWiki-Change-tagging, MediaWiki-Special-pages, Commons, Multimedia
MarcoAurelio awarded T69811: CheckUsers "Get users" output formatting is weird a Evil Spooky Haunted Tree token.
Sun, Apr 15, 9:33 AM · Stewards-and-global-tools, CheckUser

Sat, Apr 14

Reedy added a comment to T180278: Expand our usage of FriendsOfPHP/security-advisories.

Another is https://github.com/sensiolabs/security-checker too

Sat, Apr 14, 2:47 PM · Security-Team, Composer, Librarization, Security-General, Continuous-Integration-Config, Security
Reedy created T192207: Security related Static Analysis.
Sat, Apr 14, 2:08 PM · MediaWiki-Codesniffer, Security, Security-Team
Reedy updated the task description for T192204: WordPress ServeHappy (aka UPGRADE YO PHP).
Sat, Apr 14, 11:30 AM · Documentation, MediaWiki-Documentation
Reedy closed T192202: Images Aren't Loading as Invalid.

You need to report this to encyclopediadramatica and they might need to speak to CloudFlare

Sat, Apr 14, 11:28 AM · Multimedia, MediaWiki-extensions-MultimediaViewer
Reedy created T192204: WordPress ServeHappy (aka UPGRADE YO PHP).
Sat, Apr 14, 11:25 AM · Documentation, MediaWiki-Documentation
Reedy updated the task description for T192203: Reword documentation to suggest PHP/MySQL versions, rather than making minimum version prominent.
Sat, Apr 14, 11:19 AM · Documentation, MediaWiki-Documentation
Reedy created T192203: Reword documentation to suggest PHP/MySQL versions, rather than making minimum version prominent.
Sat, Apr 14, 11:17 AM · Documentation, MediaWiki-Documentation
Reedy added a comment to T188520: Use a more complex password for WikiAdmin in selenium tests.

Works for me, yeah. Obviously (you mention a cleanup commit) it'll need the password changing in master, as when the T151425 gets merged (depending on defaults chosen), so it doesn't break tests everywhere :)

Sat, Apr 14, 9:09 AM · Release-Engineering-Team (Kanban), User-zeljkofilipin, Patch-For-Review, MediaWiki-Core-Tests, Continuous-Integration-Config
Reedy closed T192196: Corrections are not showing up in review your changes visual on Wiki user page as Invalid.
Sat, Apr 14, 8:55 AM
Reedy closed T192184: Category:Year of death missing - not sorting properly when using TOC as Declined.

See also T189295, it'll get fixed eventually

Sat, Apr 14, 8:47 AM

Fri, Apr 13

Reedy added a comment to T180278: Expand our usage of FriendsOfPHP/security-advisories.

https://github.com/Roave/SecurityAdvisories is another potential variant of the FriendsOfPHP stuff....

Fri, Apr 13, 2:54 PM · Security-Team, Composer, Librarization, Security-General, Continuous-Integration-Config, Security

Thu, Apr 12

Reedy added a comment to T191638: Security review of symfony/validator library.

Isn't that .gitattributes job?

Thu, Apr 12, 12:55 PM · Security-Reviews, Wikidata, Lexicographical data

Wed, Apr 11

Reedy added a comment to T191638: Security review of symfony/validator library.

The test files are excluded from class map and should not be reachable by autoloading.

Wed, Apr 11, 4:13 PM · Security-Reviews, Wikidata, Lexicographical data
Reedy added a comment to T191638: Security review of symfony/validator library.

I note for naive purposes... On master his is a lot of code (even if it does include tests, though those have been know to cause problems in the past, for example for non executed code like we had with phpunit T180231) (slightly less in older branches)

Wed, Apr 11, 3:52 PM · Security-Reviews, Wikidata, Lexicographical data
Reedy changed the status of T121837: 1.23.12 fails "make phpunit" from Open to Stalled.

Is this still an issue?

Wed, Apr 11, 3:48 PM · MediaWiki-Core-Tests

Tue, Apr 10

Reedy added a comment to T191800: Restore CSS/JS cache clearing hint.

And the bit in Article.php. Just inline the parts of the function you actually want...

Tue, Apr 10, 3:03 PM · MW-1.30-release-notes, MW-1.31-release-notes, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), Patch-For-Review, MW-1.30-release, MW-1.31-release, Regression, Easy, MediaWiki-General-or-Unknown

Mon, Apr 9

Reedy added a project to T191804: Allow to store files between 4 and 5 Gb: media-storage.
Mon, Apr 9, 3:59 PM · media-storage, MediaWiki-File-management, Commons, Multimedia

Sat, Apr 7

Reedy updated the task description for T191691: Collect IPs for pingback.
Sat, Apr 7, 9:33 PM · WMF-Legal, Analytics-EventLogging, Privacy, MediaWiki-General-or-Unknown, Analytics
Reedy added a project to T191706: It's not possible to undo edits from the revision history or diff in "Mobile" mode: Mobile.
Sat, Apr 7, 9:32 PM · Readers-Web-Backlog (Design), MediaWiki-History-or-Diffs, MobileFrontend

Thu, Apr 5

Reedy added a comment to T191514: Allow definition of `scripts` in `composer.local.json`.

Yeah, it wasn't clear what exactly you were modifying in composer.json :P

Thu, Apr 5, 11:28 AM · Patch-For-Review, Composer, MediaWiki-Configuration
Reedy added a project to T191512: PHP fatal error: [] operator not supported for strings @ group0 and group1: Wikimedia-log-errors.
Thu, Apr 5, 10:39 AM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), Technical-Debt, Regression, Patch-For-Review, Wikimedia-log-errors, AbuseFilter
Reedy added a comment to T191514: Allow definition of `scripts` in `composer.local.json`.

Are you sure this doesn't work?

Thu, Apr 5, 10:39 AM · Patch-For-Review, Composer, MediaWiki-Configuration
Reedy added a project to T191514: Allow definition of `scripts` in `composer.local.json`: Composer.
Thu, Apr 5, 10:37 AM · Patch-For-Review, Composer, MediaWiki-Configuration
Reedy added a project to T191514: Allow definition of `scripts` in `composer.local.json`: MediaWiki-Configuration.
Thu, Apr 5, 10:35 AM · Patch-For-Review, Composer, MediaWiki-Configuration
Reedy added a comment to T108557: Review and deploy UrlShortener extension to Wikimedia wikis.

You tell us? You're the one claiming that there's actual strict rules/procedures here to follow, so your book should also tell you what the next steps are...

Thu, Apr 5, 10:32 AM · Availability (MediaWiki-MultiDC), Patch-For-Review, MediaWiki-extensions-UrlShortener, Wikimedia-Extension-setup
Reedy added a comment to T108557: Review and deploy UrlShortener extension to Wikimedia wikis.

Who decides if it needs a product/design review?

Thu, Apr 5, 9:53 AM · Availability (MediaWiki-MultiDC), Patch-For-Review, MediaWiki-extensions-UrlShortener, Wikimedia-Extension-setup

Wed, Apr 4

Reedy added a comment to T108557: Review and deploy UrlShortener extension to Wikimedia wikis.

Create the page then? ;)

Wed, Apr 4, 7:05 PM · Availability (MediaWiki-MultiDC), Patch-For-Review, MediaWiki-extensions-UrlShortener, Wikimedia-Extension-setup
Reedy closed T191378: api.php?action=app&subcmd=article&format=json returns steps in HTML on wikihow.com as Invalid.

They're running a really old version of MediaWiki... https://www.wikihow.com/Special:Version which isn't supported by us anymore

Wed, Apr 4, 1:24 PM

Tue, Apr 3

Reedy added a comment to T191279: Wikivoyage not blocked in Turkey, but actually fails because it relies on www.wikipedia.org/search-redirect.php which is blocked.

Actually, based on https://github.com/wikimedia/portals#overview it's the usage on https://meta.wikimedia.org/wiki/Www.wikivoyage.org_template that it comes from... Which then needs to pull in to the repos and pushed through for deploying..

Tue, Apr 3, 12:12 PM · Wikimedia-Portals, Discovery