Page MenuHomePhabricator

Reedy (Sam Reed)
Breaker of WikisAdministrator

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 24 2014, 6:58 PM (271 w, 3 d)
Roles
Administrator
Availability
Available
IRC Nick
Reedy
LDAP User
Reedy
MediaWiki User
Reedy [ Global Accounts ]

Recent Activity

Fri, Dec 6

Reedy added a project to T240050: New namespace aliases for spanish wikisource: Wikimedia-Site-requests.
Fri, Dec 6, 8:44 PM · Spanish-Sites, Patch-For-Review, Google-Code-in-2019, Wikimedia-Site-requests
Reedy added a project to T70174: securepoll-votereligibility-list-* messages should be documented in comments: good first task.
Fri, Dec 6, 8:07 PM · good first task, Core Platform Team, I18n, MediaWiki-extensions-SecurePoll
Reedy closed T209656: Cannot create new poll on votewiki as Resolved.

FTR this is fixed if I force the system to PHP7 via x-Wikimedia-Debug

Fri, Dec 6, 8:05 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), MediaWiki-extensions-SecurePoll
Reedy closed T212027: Maintenance scripts no longer accept options as Resolved.

Dejavu T239968: `cli/dump.php` does not accept the --votes modifier

Fri, Dec 6, 8:03 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), MediaWiki-extensions-SecurePoll, MediaWiki-Maintenance-scripts
Reedy updated the task description for T50976: Update SecurePoll to use ResourceLoader.
Fri, Dec 6, 7:33 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MediaWiki-extensions-SecurePoll
Reedy updated the task description for T50976: Update SecurePoll to use ResourceLoader.
Fri, Dec 6, 7:14 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MediaWiki-extensions-SecurePoll
Reedy added a comment to T50976: Update SecurePoll to use ResourceLoader.

this formerly global function becomes a local function when loaded with RL because every file becomes closure scoped.
Presumably it is references from somewhere in a way that assumes it to be global, possibly outside this file. This kind of UI code generally is hard to port and requires more than just packaging.

Fri, Dec 6, 7:14 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MediaWiki-extensions-SecurePoll
Reedy added a comment to T50976: Update SecurePoll to use ResourceLoader.

Reverted, shizz broken

Fri, Dec 6, 2:27 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MediaWiki-extensions-SecurePoll
Reedy closed T239968: `cli/dump.php` does not accept the --votes modifier as Resolved.

Still needs merging on master

Fri, Dec 6, 2:15 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team, MediaWiki-extensions-SecurePoll
Reedy renamed T239968: `cli/dump.php` does not accept the --votes modifier from `extensions/SecurePoll/cli/dump.php` does not accept the --votes modifier to `cli/dump.php` does not accept the --votes modifier.
Fri, Dec 6, 1:14 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team, MediaWiki-extensions-SecurePoll
Reedy moved T239962: Security Issue Access Request for HMonroy from Incoming to In Progress on the Security-Team board.
Fri, Dec 6, 12:10 AM · Security-Team, Security
Reedy triaged T239962: Security Issue Access Request for HMonroy as Medium priority.
Fri, Dec 6, 12:10 AM · Security-Team, Security
Reedy added a comment to T239962: Security Issue Access Request for HMonroy.

As per https://www.mediawiki.org/wiki/Security/SOP/Access_to_Phabricator_Security_Issues this needs your manager to sign off too

Fri, Dec 6, 12:09 AM · Security-Team, Security
Reedy added a project to T239962: Security Issue Access Request for HMonroy: Security-Team.
Fri, Dec 6, 12:07 AM · Security-Team, Security
Reedy added a project to T239959: Improper Access Control on accounts.wmflabs.org: Striker.

I am a security researcher and i found out a critical file on your website that shouldn't be visible to users. Please fix it.

Fri, Dec 6, 12:04 AM · Striker, Security
Reedy updated subscribers of T239958: Improper Access Control on swis.wmflabs.org.

File is open source and can be viewed in the git repo at https://github.com/Slevinski/swis/blob/master/js/keyISWA.js - So this isn't an issue

Fri, Dec 6, 12:02 AM · Security

Thu, Dec 5

Reedy added a comment to T239928: jerkins-bot should not post on IRC for Gerrit changes marked 'WIP'.

jerkins is out to cause people misery

Thu, Dec 5, 4:32 PM · Release-Engineering-Team (CI & Testing services), Jenkins, Release-Engineering-Team-TODO
Reedy added a project to T239925: Non-free content on Ingush Wikipedia: Wikimedia-Site-requests.
Thu, Dec 5, 3:52 PM · Patch-For-Review, Wikimedia-Site-requests
Reedy added a comment to T239036: OBB-1022554 XSS in not-in-the-other-language.

Yes Sir, I did clear out my cache and cookies as well. But its not on the URL which i mention in my report its new but on the same website.

Thu, Dec 5, 2:15 PM · Tools, Vuln-XSS, Toolforge-standards-committee, cloud-services-team, Security-Team, Security
Reedy added a project to T239860: Cross Site Scripting on accounts.wmflabs.org: Tools.
Thu, Dec 5, 2:45 AM · VPS-Projects, Security-Team, Vuln-XSS, Security
Reedy added a comment to T236153: Show tpt-duplicate error message only once for a translation unit.

This feels like it was almost too easy for a GCI task, given how little time it took me to code.

Thu, Dec 5, 2:39 AM · Patch-For-Review, Google-Code-in-2019, good first task, MediaWiki-extensions-Translate

Wed, Dec 4

Reedy closed T238977: Add operations/software/censorship-monitoring.git to CI as Resolved.
Wed, Dec 4, 3:36 PM · Patch-For-Review, Continuous-Integration-Config
Reedy added a subtask for T238977: Add operations/software/censorship-monitoring.git to CI: T238950: Please create a repository for censorship monitoring.
Wed, Dec 4, 3:17 PM · Patch-For-Review, Continuous-Integration-Config
Reedy added a parent task for T238950: Please create a repository for censorship monitoring: T238977: Add operations/software/censorship-monitoring.git to CI.
Wed, Dec 4, 3:17 PM · User-MarcoAurelio, Repository-Admins
Reedy removed a subtask for T238950: Please create a repository for censorship monitoring: T238977: Add operations/software/censorship-monitoring.git to CI.
Wed, Dec 4, 3:17 PM · User-MarcoAurelio, Repository-Admins
Reedy removed a parent task for T238977: Add operations/software/censorship-monitoring.git to CI: T238950: Please create a repository for censorship monitoring.
Wed, Dec 4, 3:17 PM · Patch-For-Review, Continuous-Integration-Config
Reedy changed the visibility for T239813: Cross Site Scripting on Swis.wmflabs.org.
Wed, Dec 4, 3:10 PM · Vuln-XSS, Upstream, Cloud-VPS, Security
Reedy closed T239813: Cross Site Scripting on Swis.wmflabs.org as Resolved.

Thanks for the report. It's been fixed now by upstream

Wed, Dec 4, 3:09 PM · Vuln-XSS, Upstream, Cloud-VPS, Security
Reedy added projects to T239817: Cross Site Scripting on tools.wmflabs.org/multidesc: Vuln-XSS, Tools.
Wed, Dec 4, 2:18 PM · Security-Team, Tools, Vuln-XSS, Security
Reedy added a project to T239813: Cross Site Scripting on Swis.wmflabs.org: Vuln-XSS.
Wed, Dec 4, 2:16 PM · Vuln-XSS, Upstream, Cloud-VPS, Security
Reedy added a comment to T239813: Cross Site Scripting on Swis.wmflabs.org.

Like {T46619} this seemingly needs reporting at https://github.com/Slevinski/swis#readme
Will contact them

Wed, Dec 4, 2:16 PM · Vuln-XSS, Upstream, Cloud-VPS, Security
Reedy added a project to T239813: Cross Site Scripting on Swis.wmflabs.org: Upstream.

Like {T46619} this seemingly needs reporting at https://github.com/Slevinski/swis#readme

Wed, Dec 4, 2:11 PM · Vuln-XSS, Upstream, Cloud-VPS, Security
Reedy added a project to T239813: Cross Site Scripting on Swis.wmflabs.org: Cloud-VPS.
Wed, Dec 4, 2:10 PM · Vuln-XSS, Upstream, Cloud-VPS, Security
Reedy moved T237476: Update elasticsearch/elasticsearch and ruflin/elastica from Backlog to Needs review on the MediaWiki-Vendor board.
Wed, Dec 4, 1:56 AM · Discovery, CirrusSearch, Elasticsearch, Discovery-Search, MediaWiki-Vendor
Reedy added a comment to T239259: Security Review for whichbrowser/parser.

I note, but not necessarily a blocker, that the Developer(s) don't seem very active based on https://github.com/WhichBrowser/Parser-PHP and the issues/pull requests. Handful of bugs and reports etc that have gone without response to for months

Wed, Dec 4, 1:56 AM · Security-Team-Reviews, MediaWiki-Vendor, Anti-Harassment, CheckUser

Tue, Dec 3

Reedy added a project to T239760: WikibaseLib is not compatible with PHP7.4: Wikidata-Campsite.
Tue, Dec 3, 11:59 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Wikidata-Campsite, Wikidata, Wikibase-Quality-Constraints, PHP 7.4 support
Reedy added a project to T239761: Wikibase is not compatible with PHP7.4: Wikidata-Campsite.
Tue, Dec 3, 11:59 PM · Patch-For-Review, Wikidata-Campsite, Wikidata, PHP 7.4 support
Reedy added a project to T239759: TimedMediaHandler is not compatible with PHP7.4: Upstream.

https://github.com/JamesHeinrich/getID3/issues/210 and https://github.com/JamesHeinrich/getID3/commit/75454e8b19c7b1b041382b91906574fe484f605b should fix get_magic_quotes_runtime on 7.4 and therefore tick a few off the list

Tue, Dec 3, 10:07 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, Upstream, TimedMediaHandler, PHP 7.4 support
Reedy added a comment to T239734: Deprecated: Function Redis::lSize() is deprecated in /srv/mediawiki/w/includes/libs/redis/RedisConnRef.php on line 131.

https://github.com/phpredis/phpredis/blob/8ee4abbc3fbc47201f20a2a48ccee6f6f765952b/redis.c#L456

Tue, Dec 3, 6:03 PM · MW-1.34-notes, MW-1.32-notes, MW-1.31-release-notes, MW-1.33-notes, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MediaWiki-General
Reedy updated the task description for T232023: Release MW 1.34.
Tue, Dec 3, 2:44 AM · Core Platform Team, MediaWiki-Releasing, MW-1.34-notes, MW-1.34-release
Reedy added a comment to T231866: Circular dependency when creating service! ContentLanguage.

Do we know if anything else is outstanding here?

Tue, Dec 3, 2:30 AM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Performance-Team (Radar), Language-Team, MW-1.34-release, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ResourceLoader, MediaWiki-extensions-Gadgets, MediaWiki-ServiceContainer
Reedy added a project to T235769: Add before execute hook into Special:Import and ApiImport: Core Platform Team.
Tue, Dec 3, 2:06 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, User-Rxy, MediaWiki-Export-or-Import
Reedy updated subscribers of T239672: Many special pages missing from pageview_hourly dataset starting on July 23, 2019.
Tue, Dec 3, 12:26 AM · Analytics, Product-Analytics
Reedy added a comment to T239672: Many special pages missing from pageview_hourly dataset starting on July 23, 2019.

https://gerrit.wikimedia.org/r/#/c/analytics/refinery/source/+/520671/ I'm betting to fix T226730

Tue, Dec 3, 12:23 AM · Analytics, Product-Analytics

Mon, Dec 2

Reedy closed T239561: maintenance script addSite.php with options fails always as Resolved.
Mon, Dec 2, 11:46 PM · MW-1.33-notes, MW-1.32-notes, MW-1.31-release-notes, MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MediaWiki-Maintenance-scripts
Reedy updated the task description for T227461: PHPRedis module >= 5.0.0 throws deprecation warnings for delete()..
Mon, Dec 2, 10:54 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MW-1.31-release-notes, MW-1.32-notes, MW-1.33-notes, Patch-For-Review, MediaWiki-Cache
Reedy added a comment to T239639: Add filtering to list=allimages for feature parity with Special:NewFiles.

It'd be useful if we had some sort of "mapping" between special pages and api modules as a method of increasing visability

Mon, Dec 2, 7:04 PM · Core Platform Team, MediaWiki-API
Reedy updated the task description for T239648: Document mapping between Special Pages and API modules.
Mon, Dec 2, 7:03 PM · Documentation, MediaWiki-Special-pages, Core Platform Team, MediaWiki-API
Reedy created T239648: Document mapping between Special Pages and API modules.
Mon, Dec 2, 7:03 PM · Documentation, MediaWiki-Special-pages, Core Platform Team, MediaWiki-API
Reedy renamed T239639: Add filtering to list=allimages for feature parity with Special:NewFiles from Add API for Special:NewFiles to Add filtering to list=allimages for feature parity with Special:NewFiles.
Mon, Dec 2, 7:00 PM · Core Platform Team, MediaWiki-API
Reedy added a comment to T239639: Add filtering to list=allimages for feature parity with Special:NewFiles.

I note Special:NewFiles seems almost the same as the existing list=allimages with aisort=timestamp. Missing features are the media type filters and an equivalent to the "Hide patrolled uploads" checkbox. The best thing to do would probably be to add those features to the existing module.

Mon, Dec 2, 6:59 PM · Core Platform Team, MediaWiki-API
Reedy added a comment to T239638: Access to Wikimedia GitHub org/account.

As an aside, as per T198810: Enforce 2FA for GitHub members, anyone added as an owner/member needs 2FA enabling

Mon, Dec 2, 6:38 PM · GitHub-Mirrors, Product-Analytics
Reedy added a comment to T239259: Security Review for whichbrowser/parser.

I note, but not necessarily a blocker, that the Developer(s) don't seem very active based on https://github.com/WhichBrowser/Parser-PHP and the issues/pull requests. Handful of bugs and reports etc that have gone without response to for months

Mon, Dec 2, 6:31 PM · Security-Team-Reviews, MediaWiki-Vendor, Anti-Harassment, CheckUser
Reedy created T239639: Add filtering to list=allimages for feature parity with Special:NewFiles.
Mon, Dec 2, 5:56 PM · Core Platform Team, MediaWiki-API
Reedy updated the task description for T239259: Security Review for whichbrowser/parser.
Mon, Dec 2, 5:05 PM · Security-Team-Reviews, MediaWiki-Vendor, Anti-Harassment, CheckUser
Reedy renamed T239036: OBB-1022554 XSS in not-in-the-other-language from OBB-1022554 tools.wmflabs.org XSS vulnerability report to OBB-1022554 XSS in not-in-the-other-language.
Mon, Dec 2, 2:16 PM · Tools, Vuln-XSS, Toolforge-standards-committee, cloud-services-team, Security-Team, Security
Reedy merged Restricted Task into T239036: OBB-1022554 XSS in not-in-the-other-language.
Mon, Dec 2, 2:15 PM · Tools, Vuln-XSS, Toolforge-standards-committee, cloud-services-team, Security-Team, Security
Reedy added a comment to T220719: Standardize return type hint spacing.

Can we avoid having the discussion in two places, please? There’s already a lot more arguments on the mw.org talk page (also linked in the task description).

Mon, Dec 2, 11:55 AM · MediaWiki-Documentation, MediaWiki-Codesniffer
Reedy updated the task description for T220719: Standardize return type hint spacing.
Mon, Dec 2, 11:54 AM · MediaWiki-Documentation, MediaWiki-Codesniffer

Sun, Dec 1

Reedy triaged T239549: Cannot open image(s) on office.wikimedia.org: "Error: readapidenied" in MediaViewer as Lowest priority.
Sun, Dec 1, 10:17 PM · MediaViewer, Wikimedia-Site-requests, MediaWiki-File-management, Wikimedia-General-or-Unknown
Reedy edited projects for T239549: Cannot open image(s) on office.wikimedia.org: "Error: readapidenied" in MediaViewer, added: Wikimedia-General-or-Unknown, MediaWiki-File-management; removed Office-IT.
Sun, Dec 1, 10:08 PM · MediaViewer, Wikimedia-Site-requests, MediaWiki-File-management, Wikimedia-General-or-Unknown
Reedy edited Description on MW-1.34-release.
Sun, Dec 1, 6:46 PM
Reedy triaged T232023: Release MW 1.34 as High priority.

This is due to be released November 2019.

Sun, Dec 1, 6:06 PM · Core Platform Team, MediaWiki-Releasing, MW-1.34-notes, MW-1.34-release
Reedy closed T229601: When installer fails, an extra message is shown: Service disabled: DBLoadBalancerFactory while CLI installation failed as Resolved.

Merged (well, C+2'd). Will do RELEASE-NOTES in separate commit tidying up

Sun, Dec 1, 6:01 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-release, MediaWiki-Installer, MediaWiki-ServiceContainer

Fri, Nov 29

Reedy updated subscribers of T235844: Collect tasks related code and security review.
Fri, Nov 29, 3:38 PM · Wikispeech-jobrunner (Sprint), User-Sebastian_Berlin-WMSE, WMSE-Wikispeech-Speech-Data-Collector-2019
DannyS712 awarded T187617: Add security.txt to Wikimedia sites? a Like token.
Fri, Nov 29, 11:02 AM · Security-team-backlog, Documentation, Wikimedia-General-or-Unknown, Security
Bawolff awarded T187617: Add security.txt to Wikimedia sites? a Love token.
Fri, Nov 29, 9:55 AM · Security-team-backlog, Documentation, Wikimedia-General-or-Unknown, Security

Thu, Nov 28

Reedy added a comment to T234114: Update extension.json files to manifest_version 2 to use description instead of @globalname documentation.
Targets
    Occurrences of '"@' in directory /Users/reedy/PhpstormProjects/mediawiki/extensions with mask 'extension.json'
Found Occurrences  (128 usages found)
    Usage in string constants  (128 usages found)
        mediawiki  (128 usages found)
            extensions/AzharAuth  (8 usages found)
                extension.json  (8 usages found)
                    36 "description": "@var boolean Determines if a link to the Azhàr intranet homepage should be added."
                    40 "description": "@var boolean If true, only allows authentication through Azhàr and disables regular login/logout. Otherwise, Azhàr is an extra option to login."
                    44 "description": "@var boolean If true, creates a new account if the user doesn't exist in the database."
                    50 "@v
                    54 "description": "@var string The Azhàr login URL"
                    58 "description": "@var string The Azhàr main intranet URL"
                    62 "description": "@var string The Azhàr product name. If omitted, [[MediaWiki:defaultproductname]] is used."
                    70 "@v
            extensions/BlueSpiceArticlePreviewCapture  (3 usages found)
                extension.json  (3 usages found)
                    26 "@configDefinitions": {}
                    62 "@note": "Defaults to $wgServer",
                    66 "@note": "If you need to add command line variable before command set this to false",
            extensions/BlueSpiceBookshelfUI  (1 usage found)
                extension.json  (1 usage found)
                    43 "bs-bookshelf-navtab-icon-active": "@bs-color-tertiary",
            extensions/BlueSpiceExpiry  (1 usage found)
                extension.json  (1 usage found)
                    40 "@AlertProviderRegistry": {
            extensions/BlueSpiceFoundation  (5 usages found)
                extension.json  (5 usages found)
                    806 "@note0": "Key is the full extension attribute name, e.g. `BlueSpiceFoundationLessVarsRegistry`",
                    807 "@note1": "Value is a array that supports three keys:",
                    808 "@note2": "`set`: Contains an associative array that completely replaces the original value of the attribute.",
                    809 "@note3": "`merge`: Contains an associative array the will be merged with the original value of the attribute. Will not be evaluated if `set` is defined.",
                    810 "@note4": "`remove`: Contains a indexed array of keys that should be removed from the original value of the attribute. Will not be evaluated if `set` is defined.",
            extensions/BlueSpicePageAssignments  (1 usage found)
                extension.json  (1 usage found)
                    63 "bs-pageassignments-icon-specialeveryone-color": "@bs-color-tertiary"
            extensions/BlueSpiceSocial  (3 usages found)
                extension.json  (3 usages found)
                    77 "bs-color-header-information-link": "@bs-primary-light-subelement-border",
                    80 "bs-color-social-link-dark": "@bs-primary-light-subelement-border",
                    81 "navigation-tab-color": "@bs-color-primary",
            extensions/BlueSpiceVisualEditorConnector  (2 usages found)
                extension.json  (2 usages found)
                    348 "@note": "Usage described in docs/custom_text_colors.md",
                    368 "@note": "Usage described in docs/custom_text_colors.md",
            extensions/CentralAuth  (1 usage found)
                extension.json  (1 usage found)
                    418 "@doc": "see CentralAuth.php",
            extensions/Cognate  (4 usages found)
                extension.json  (4 usages found)
                    35 "@CognateDb": "The database to use for storing Cognate data. The default is to use the db of the current site.",
                    37 "@CognateCluster": "The cluster to use for storing Cognate data. The default is to use the cluster / server of the current site. See $wgLBFactoryConf.",
                    39 "@C
                    41 "@CognateNamespaces": "The namespace IDs to run Cognate for. For links to work between sites these IDs must be the same across sites.",
            extensions/CollaborationKit  (2 usages found)
                extension.json  (2 usages found)
                    101 "@fixme": "Does having ext.CollaborationKit.list.styles as a dependency double load from addModuleStyles?",
                    102 "@todo FIXME": "Should this actually load oojs-ui-core, or something else",
            extensions/ConfirmEdit  (1 usage found)
                extension.json  (1 usage found)
                    2 "@doc": "Please read README.md",
            extensions/ContentTranslation  (9 usages found)
                extension.json  (9 usages found)
                    140 "@C
                    142 "@ContentTranslationAsBetaFeature": "Whether to have CX available only as a beta feature and only shown to the users who have enabled the beta feature.",
                    144 "@ContentTranslationTargetNamespace": "Target namespace to publish articles. Values can be valid namespace ids. Example: 0 for Main, 2 for User namespace",
                    160 "@ContentTranslationEnableMT": "Whether Machine Translation services are enabled for this target wiki",
                    162 "@RecommendToolAPIURL": "Web API URL for translation recommendation tool",
                    165 "@C
                    167 "@C
                    181 "@C
                    182 "@DraftMaxAge": "Maximum age of unpublished drafts before they're purged from DB. Expressed in days and defaults to approximate value of 15 months.",
            extensions/DataTransfer  (1 usage found)
                extension.json  (1 usage found)
                    2 "@Note": "When updating this file please also update DataTransfer.php with the same changes.",
            extensions/DisableAccount  (1 usage found)
                extension.json  (1 usage found)
                    2 "@doc": "Written by Andrew Garrett, 2010-12-02",
            extensions/GPGMail  (1 usage found)
                extension.json  (1 usage found)
                    18 "@GpgMailUsePgpMime": "true: use PGP/MIME, false: use inline encryption",
            extensions/Ids  (1 usage found)
                extension.json  (1 usage found)
                    24 "@doc": "https://www.mediawiki.org/wiki/Extension:Ids",
            extensions/InterwikiSorting  (3 usages found)
                extension.json  (3 usages found)
                    18 "@InterwikiSortingSort": "The default sort order to use. 'code' is build in and orders alphabetically by interwiki code.",
                    20 "@InterwikiSortingSortPrepend": "Codes that should appear at the start of the list of interwiki links.",
                    22 "@I
            extensions/Lingo  (1 usage found)
                extension.json  (1 usage found)
                    10 "@descriptionmsg": "The description message is set by Lingo\\Hooks::setCredits().",
            extensions/LinkedWiki  (2 usages found)
                extension.json  (2 usages found)
                    13 "@doc": "NamespaceRelations with NS_MAIN",
                    20 "@doc": "NamespaceRelations with NS_USER",
            extensions/LocalisationUpdate  (1 usage found)
                extension.json  (1 usage found)
                    2 "@note": "This file must be kept in sync with LocalisationUpdate.php",
            extensions/NSFileRepo  (2 usages found)
                extension.json  (2 usages found)
                    79 "@note NamespaceThreshold": "This should probably be 3000 as recommended by MediaWiki. But for backwards compatibility we'll stick with this default",
                    81 "@note NamespaceBlacklist": "There are some widespread extensions that create namespaces. E.g. SemanticMediaWiki, PageForms, Widgets, Scribunto, ...",
            extensions/OAuthAuthentication  (1 usage found)
                extension.json  (1 usage found)
                    46 "@doc": "see OAuthAuthentication.php",
            extensions/OpenLayers  (1 usage found)
                extension.json  (1 usage found)
                    2 "@Note": "When updating this file please also update OpenLayers.php with the same changes.",
            extensions/PageForms  (2 usages found)
                extension.json  (2 usages found)
                    2 "@Note": "When updating this file please also update PageForms.php with the same changes.",
                    546 "@note": "See PF_DefaultInputSettings.php for allowed values",
            extensions/PageImages  (4 usages found)
                extension.json  (4 usages found)
                    42 "@doc": "Images <120px are usually from maintenace or stub templates; >600px are panoramas, less suitable.",
                    90 "@doc": "Temporary feature flag - Whether page images should be restricted to those in section id 0.",
                    91 "@fixme": "Please remove a month after it has defaulted to true on the cluster (T152115)",
                    95 "@d
            extensions/Popups  (12 usages found)
                extension.json  (12 usages found)
                    65 "@PopupsVirtualPageViews": "@var bool: Whether the extension should log virtual pageviews.",
                    67 "@PopupsHideOptInOnPreferencesPage": "@var bool: Whether the option to enable/disable Page Previews should be hidden on Preferences page. False by default",
                    69 "@PopupsOptInDefaultState": "@var string:['1'|'0'] Default Page Previews visibility for old accounts. Has to be a string as a compatibility with beta feature settings. For more info see @T191888",
                    71 "@PopupsOptInStateForNewAccounts": "@var string:['1'|'0'] Default Page Previews visibility for newly created accounts (from Q2 2018). For more info see @T191888",
                    73 "@PopupsConflictingNavPopupsGadgetName": "@var string: Navigation popups gadget name",
                    75 "@PopupsGateway": "Which gateway to use for fetching Popups data. Available options: [mwApiPlain|restbasePlain|restbaseHTML]. Full and always up to date list is available in src/gateway/index.js",
                    77 "@PopupsRestGatewayEndpoint": "Specify a REST endpoint where summaries should be sourced from. Endpoint must meet the spec at https://www.mediawiki.org/wiki/Specs/Summary/1.2.0",
                    79 "@PopupsReferencePreviews": "Temporary feature flag to disable reference previews during developement.",
                    81 "@PopupsReferencePreviewsBetaFeature": "Make Reference Previews a Beta feature.",
                    83 "@PopupsEventLogging": "Whether we should log events. Note if this is enabled without using that variable events will be logged for all users without any sampling! Be careful!",
                    85 "@PopupsStatsvSamplingRate": "Sampling rate for logging performance data to statsv.",
                    87 "@P
            extensions/QuickSurveys  (19 usages found)
                extension.json  (19 usages found)
                    123 "@name": "survey name",
                    125 "@type": "internal or external link survey",
                    127 "@question": "survey question message key",
                    129 "@description": "The message key of the description of the survey. Displayed immediately below the survey question.",
                    131 "@answers": "possible answer message keys for positive, neutral, and negative",
                    137 "@freeformTextLabel": "label for the optional free form text",
                    139 "@enabled": "whether the survey is enabled",
                    141 "@coverage": "percentage of users that will see the survey",
                    143 "@platforms": "for each platform (desktop, mobile), which version of it is targeted (stable, beta)",
                    150 "@name": "survey name",
                    152 "@type": "internal or external link survey",
                    154 "@question": "survey question message key",
                    156 "@description": "the i18n key of the description of the survey",
                    158 "@link": "external link to the survey",
                    160 "@instanceTokenParameterName": "parameter to add to link",
                    162 "@privacyPolicy": "The i18n key of the privacy policy text.",
                    164 "@enabled": "whether the survey is enabled",
                    166 "@coverage": "percentage of users that will see the survey",
                    168 "@platforms": "for each platform (desktop, mobile), which version of it is targeted (stable, beta)",
            extensions/RelatedArticles  (3 usages found)
                extension.json  (3 usages found)
                    146 "@R
                    150 "@RelatedArticlesDescriptionSource": "Source to get the page description from (string, or false to not fetch the description). Possible values: wikidata, textextracts, pagedescription.",
                    152 "@RelatedArticlesFooterWhitelistedSkins": "List of skin names (e.g. 'minerva') where related articles will be shown in the footer.",
            extensions/SiteMatrix  (5 usages found)
                extension.json  (5 usages found)
                    53 "@SiteMatrixFile": "A file with the list of language codes used by the wikifarm (one per line).",
                    55 "@S
                    59 "@SiteMatrixPrivateSites": "dbname list of private wikis.",
                    61 "@SiteMatrixFishbowlSites": "dbname list of fishbowl wikis.",
                    63 "@SiteMatrixClosedSites": "dbname list of closed wikis.",
            extensions/TinyMCE  (1 usage found)
                extension.json  (1 usage found)
                    2 "@Note": "When updating this file please also update TinyMCE.php with the same changes.",
            extensions/TwoColConflict  (1 usage found)
                extension.json  (1 usage found)
                    19 "@TwoColConflictBetaFeature": "Make the TwoColConflict feature a BetaFeature. Setting this requires the BetaFeature extension and requires each user to enable the BetaFeature.",
            extensions/UniversalLanguageSelector  (17 usages found)
                extension.json  (17 usages found)
                    61 "@U
                    63 "@U
                    65 "@ULSEnableAnon": "Equivalent to $wgULSEnable for anonymous users only. Does not have any effect if $wgULSEnable is false.",
                    67 "@U
                    69 "@U
                    71 "@ULSIMEEnabled": "Enable the input methods feature for all users by default. Can be controlled by the user.",
                    73 "@ULSWebfontsEnabled": "Enable the webfonts feature for all users by default. Can be controlled by the user. @since 2014.02",
                    75 "@ULSMobileWebfontsEnabled": "Set whether webfont support is loaded within the mobile interface (via the MobileFrontend extension).",
                    77 "@U
                    79 "@ULSEventLogging": "Whether to use EventLogging. The EventLogging extension must be installed if this option is enabled. @since 2013.06",
                    81 "@ULSImeSelectors": "Array of jQuery selectors of elements on which IME should be enabled. @since 2013.11",
                    89 "@ULSNoImeSelectors": "Array of jQuery selectors of elements on which IME must not be enabled. @since 2013.07",
                    95 "@U
                    99 "@ULSFontRepositoryBasePath": "Base path of ULS font repository. If not set, will be set to 'UniversalLanguageSelector/data/fontrepo/fonts/', relative to $wgExtensionAssetsPath. @since 2013.10",
                    102 "@ULSCompactLanguageLinksBetaFeature": "Set compact interlanguage links as beta feature or not. If set false, compact interlanguage links will be available by default to all users.",
                    104 "@ULSCompactLinksForNewAccounts": "Enable compact interlanguage links for new user accounts.",
                    106 "@ULSCompactLinksEnableAnon": "Enable compact interlanguage links for anonymous users."
            extensions/Variables  (1 usage found)
                extension.json  (1 usage found)
                    25 "@example": "$egVariablesDisabledFunctions = [ 'var_final', 'vardefineecho' ]; // to disable '#var_final' and '#vardefineecho' functions",
            extensions/WebDAV  (3 usages found)
                extension.json  (3 usages found)
                    88 "@HINT": "HINT: http://sabre.io/dav/character-encoding/",
                    92 "@HINT": "30 Minutes",
                    96 "@HINT": "24 Hours",
            extensions/WikibaseCirrusSearch  (1 usage found)
                extension.json  (1 usage found)
                    20 "@note": "The values below are mirrors of old Wikibase values. TODO: once Wikibase values are gone, put proper defaults here.",
            extensions/WikidataPageBanner  (1 usage found)
                extension.json  (1 usage found)
                    97 "@doc": "https://www.mediawiki.org/wiki/Extension:WikidataPageBanner#Configuration_parameters_for_the_extension",
            extensions/WikimediaEvents  (2 usages found)
                extension.json  (2 usages found)
                    111 "@ResourceModules": {
                    112 "@": [
Thu, Nov 28, 9:37 PM · Google-Code-in-2019, Patch-For-Review, MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Technical-Debt, MediaWiki-extensions-General
Reedy added a comment to T105230: Use last commit date in versionName.

Hi @Reedy - you'll notice this is a ticket from 2015. We are closing tickets that are so old as to be invalid, because processes have changed since the ticket was created.

Thu, Nov 28, 7:19 PM · Technical-Debt, Wikipedia-Android-App-Backlog
Reedy updated subscribers of T105230: Use last commit date in versionName.

Hi @Charlotte, can you please advise why you closed the bug as invalid without any comment? It's generally unhelpful for anyone to know what's going on in cases like this. As it's not like there was previous discussion suggesting it's invalid...

Thu, Nov 28, 7:01 PM · Technical-Debt, Wikipedia-Android-App-Backlog
Reedy added a comment to T234114: Update extension.json files to manifest_version 2 to use description instead of @globalname documentation.

I cannot find any more extension that needs this. Please add again if there's need.

Thu, Nov 28, 5:38 PM · Google-Code-in-2019, Patch-For-Review, MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Technical-Debt, MediaWiki-extensions-General
Reedy closed T239425: 8127a1eb9c492a45810ca34896d8b4ce9382e70f broke beta as Resolved.
Thu, Nov 28, 4:24 PM · Wikidata-Campsite, Wikidata, Beta-Cluster-Infrastructure
Reedy updated the task description for T239425: 8127a1eb9c492a45810ca34896d8b4ce9382e70f broke beta.
Thu, Nov 28, 3:36 PM · Wikidata-Campsite, Wikidata, Beta-Cluster-Infrastructure
Reedy triaged T239425: 8127a1eb9c492a45810ca34896d8b4ce9382e70f broke beta as High priority.
Thu, Nov 28, 3:36 PM · Wikidata-Campsite, Wikidata, Beta-Cluster-Infrastructure
Reedy created T239425: 8127a1eb9c492a45810ca34896d8b4ce9382e70f broke beta.
Thu, Nov 28, 3:36 PM · Wikidata-Campsite, Wikidata, Beta-Cluster-Infrastructure
Zerbey awarded T231866: Circular dependency when creating service! ContentLanguage a Like token.
Thu, Nov 28, 5:01 AM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Performance-Team (Radar), Language-Team, MW-1.34-release, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ResourceLoader, MediaWiki-extensions-Gadgets, MediaWiki-ServiceContainer

Tue, Nov 26

Reedy closed T238984: importdump warning: call_user_func() expects parameter 1 to be a valid callback, cannot access private method BackupReader::reportPage() in WikiImporter.php as Resolved.
Tue, Nov 26, 5:36 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MediaWiki-Maintenance-scripts, Regression, MediaWiki-Export-or-Import
Reedy added a comment to T234450: Some Special:Contributions requests cause "Error: 0" from database or WMFTimeoutException.

We might want to tune the parameters a bit to make it a bit more strict.
We were hit again by this today on enwiki, (interestingly again when one of the special slaves was depooled for maintenance).
The IP of the request was coming from the same place as the one described at T234514#5543966. We had to ban two IPs of that range for a few days till this was worked out (we also emailed their abuse@ but with no answer).
Same query and same patterns that were seeing at T234514

Tue, Nov 26, 2:26 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, User-notice, Core Platform Team Workboards (Clinic Duty Team), Vuln-DoS, Security, Performance Issue, MediaWiki-Special-pages, Wikimedia-production-error
Reedy added a comment to T239150: username/password pair for SUL account on enwiki mysteriously stopped working.

Is there a good person to assign this to?

Tue, Nov 26, 2:25 PM · Trust-and-Safety, MediaWiki-User-login-and-signup, Wikimedia-General-or-Unknown
Reedy added a comment to T239212: UserGroupMembershipTest::testGetLink failing on travis.

Confirmed fixes on travis too https://travis-ci.org/wikimedia/mediawiki/builds/617164170

Tue, Nov 26, 11:58 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-DannyS712, MediaWiki-General
Reedy closed T239212: UserGroupMembershipTest::testGetLink failing on travis as Resolved.

Thanks!

Tue, Nov 26, 11:44 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-DannyS712, MediaWiki-General
Reedy added a project to T239213: Conflicting timestamp in file history: MW-1.34-release.

It's caused by the fix for T221812: Some ApiQueryImageInfo queries consistently fail with a fatal BadMethodCallException from LocalFile.php in bdc6b4e378c6872a20f6fb5842f1a49961af91b4 (only in 1.34 and newer)

Tue, Nov 26, 11:14 AM · Core Platform Team Workboards (Clinic Duty Team), Pywikibot-Commons, MW-1.34-release, MediaWiki-API, Pywikibot, MediaWiki-File-management, Commons
Reedy added a comment to T239213: Conflicting timestamp in file history.

And in the case of the API... It's due to $exists being used in a few places as a guard to the output

Tue, Nov 26, 10:56 AM · Core Platform Team Workboards (Clinic Duty Team), Pywikibot-Commons, MW-1.34-release, MediaWiki-API, Pywikibot, MediaWiki-File-management, Commons
Reedy added projects to T239213: Conflicting timestamp in file history: Pywikibot, MediaWiki-API.

Looks like there's some discrepency between what the API returns, and what the file page displays:

Tue, Nov 26, 10:47 AM · Core Platform Team Workboards (Clinic Duty Team), Pywikibot-Commons, MW-1.34-release, MediaWiki-API, Pywikibot, MediaWiki-File-management, Commons
Reedy added a comment to T239212: UserGroupMembershipTest::testGetLink failing on travis.

That test was one of a few just added in T234921: Factor group membership management out of User class - is it the only one that is failing?

Tue, Nov 26, 10:35 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-DannyS712, MediaWiki-General
Reedy added a project to T239213: Conflicting timestamp in file history: MediaWiki-File-management.

On querying the file history, I get 'FileInfo' object has no attribute 'timestamp'.

Tue, Nov 26, 10:28 AM · Core Platform Team Workboards (Clinic Duty Team), Pywikibot-Commons, MW-1.34-release, MediaWiki-API, Pywikibot, MediaWiki-File-management, Commons
Reedy updated subscribers of T239209: XSS in Visual Editor via Copy&Paste.

CC'ing @Securitymb as reporter

Tue, Nov 26, 10:27 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work), Security-Team, VisualEditor-CopyPaste, Vuln-XSS, Security
Reedy updated subscribers of T239212: UserGroupMembershipTest::testGetLink failing on travis.

Ping T234921 and add @Vedmaka

Tue, Nov 26, 10:16 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-DannyS712, MediaWiki-General
Reedy created T239212: UserGroupMembershipTest::testGetLink failing on travis.
Tue, Nov 26, 10:16 AM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), User-DannyS712, MediaWiki-General
Reedy created T239211: HP SSD Failure Firmware Fix.
Tue, Nov 26, 10:13 AM · ops-eqiad, ops-codfw, Operations, DC-Ops
Reedy added projects to T239209: XSS in Visual Editor via Copy&Paste: Vuln-XSS, VisualEditor, VisualEditor-CopyPaste.
Tue, Nov 26, 10:03 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work), Security-Team, VisualEditor-CopyPaste, Vuln-XSS, Security
Reedy created T239209: XSS in Visual Editor via Copy&Paste.
Tue, Nov 26, 10:02 AM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), VisualEditor (Current work), Security-Team, VisualEditor-CopyPaste, Vuln-XSS, Security

Mon, Nov 25

Reedy added a project to T239150: username/password pair for SUL account on enwiki mysteriously stopped working: Wikimedia-General-or-Unknown.
Mon, Nov 25, 7:11 PM · Trust-and-Safety, MediaWiki-User-login-and-signup, Wikimedia-General-or-Unknown
Reedy added a comment to T239150: username/password pair for SUL account on enwiki mysteriously stopped working.

Without telling us what your password actually is... Is it possible it doesn't meet the password policies we enforce?

Mon, Nov 25, 7:11 PM · Trust-and-Safety, MediaWiki-User-login-and-signup, Wikimedia-General-or-Unknown

Sat, Nov 23

Reedy added a comment to T238415: Add structured data on Commons to newly uploaded files during the Tech Storm.

I created an ISA campaign if people wanted to do this

Sat, Nov 23, 11:42 AM · Wiki-Techstorm-2019
Reedy closed T238838: Disabling old AWB versions as Resolved.

Done. Only 6.1.0.1 enabled as "stable" now

Sat, Nov 23, 9:21 AM · AutoWikiBrowser

Fri, Nov 22

Reedy closed T238944: Update Herald (H187) to include project 4273 as Resolved.

Done

Fri, Nov 22, 11:24 PM · Phabricator, Wikipedia-iOS-App-Backlog
Reedy added a comment to T238955: Please add webservices.picturae.com to $wgCopyUploadsDomains.

@siebrand Why not use GWToolSet instead?

What?

GlamWiki Toolset extension. It allows GLAMs to automatically upload large batches of digital versions of their content to Wikimedia Commons. It would be much faster if you use it. See https://commons.wikimedia.org/wiki/Commons:GLAMwiki_Toolset

Fri, Nov 22, 10:32 PM · Wiki-Techstorm-2019, Commons, Wikimedia-Site-requests
Reedy added a comment to T238955: Please add webservices.picturae.com to $wgCopyUploadsDomains.

@siebrand Why not use GWToolSet instead?

Fri, Nov 22, 10:00 PM · Wiki-Techstorm-2019, Commons, Wikimedia-Site-requests
Reedy closed T238955: Please add webservices.picturae.com to $wgCopyUploadsDomains as Resolved.
Fri, Nov 22, 9:58 PM · Wiki-Techstorm-2019, Commons, Wikimedia-Site-requests