Page MenuHomePhabricator

Reedy (Sam Reed)
Breaker of WikisAdministrator

Projects (26)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 24 2014, 6:58 PM (238 w, 5 d)
Roles
Administrator
Availability
Available
IRC Nick
Reedy
LDAP User
Reedy
MediaWiki User
Reedy [ Global Accounts ]

Recent Activity

Today

Reedy renamed T221671: Retrieve history information in Scribunto API from Enable to retrieve history information in Scribunto API to Retrieve history information in Scribunto API.
Tue, Apr 23, 4:54 PM · MediaWiki-extensions-Scribunto
Reedy closed T221627: sq.wikiquote.org shows different time when you're logged in and when you're logged out as Resolved.
Tue, Apr 23, 4:07 PM · Wikimedia-Site-requests
Reedy added a comment to T221627: sq.wikiquote.org shows different time when you're logged in and when you're logged out.

Yes, thats right. Thank you :)

Tue, Apr 23, 3:59 PM · Wikimedia-Site-requests
Reedy added a comment to T221627: sq.wikiquote.org shows different time when you're logged in and when you're logged out.

A quick look... sqwiki and sqwikinews have a timezone set of Europe/Berlin. Nothing for sqwikiquote. So it's in UTC...

Tue, Apr 23, 3:52 PM · Wikimedia-Site-requests
Reedy added a comment to T221627: sq.wikiquote.org shows different time when you're logged in and when you're logged out.

I see, then lets make it to show the right time when we are logged in. Would be nice to show the right time because of the banners and quote of the day. Its around one hour early as far as I can understand, which is not a big deal. If its too much work from the team that has to work on this, then we can skip it for now.

Tue, Apr 23, 3:48 PM · Wikimedia-Site-requests
Reedy added a project to T220955: MediawikiEditEntity::checkEditPermissions fatals with unknown message 'no-permission': Wikidata-Campsite.
Tue, Apr 23, 3:38 PM · Wikidata-Campsite, Wikidata
Reedy added a comment to T221627: sq.wikiquote.org shows different time when you're logged in and when you're logged out.

Yes, the current time now. Im updating the description.

Tue, Apr 23, 3:28 PM · Wikimedia-Site-requests
Reedy renamed T221627: sq.wikiquote.org shows different time when you're logged in and when you're logged out from [Bug] sq.wikiquote.org shows different time when you're logged in and when you're logged out to sq.wikiquote.org shows different time when you're logged in and when you're logged out.
Tue, Apr 23, 2:52 PM · Wikimedia-Site-requests
Reedy added a comment to T221627: sq.wikiquote.org shows different time when you're logged in and when you're logged out.

What time is it supposed to show? The current time now?

Tue, Apr 23, 2:52 PM · Wikimedia-Site-requests
Reedy added projects to T221617: Automatic edit summaries on page creation should consider the full allowable edit summary length: MediaWiki-Logging, MediaWiki-Special-pages.
Tue, Apr 23, 12:56 PM · MediaWiki-Special-pages, MediaWiki-Logging, MediaWiki-Comment-backend
Reedy added a project to T221576: Password length requirement error shown twice: MediaWiki-User-login-and-signup.
Tue, Apr 23, 12:29 PM · MediaWiki-User-login-and-signup, Security-Team, Anti-Harassment
Reedy updated subscribers of T221619: Error running update.php on shared db.

Fixing part of this would also fix T221616: Error running update.php on shared db with PostgreSQL (at least where INSERT IGNORE is concerned)

Tue, Apr 23, 12:27 PM · PostgreSQL, MediaWiki-Installer, MediaWiki-Maintenance-scripts
Reedy added a project to T221619: Error running update.php on shared db: PostgreSQL.
Tue, Apr 23, 12:22 PM · PostgreSQL, MediaWiki-Installer, MediaWiki-Maintenance-scripts
Reedy added projects to T221619: Error running update.php on shared db: MediaWiki-Maintenance-scripts, MediaWiki-Installer.
Tue, Apr 23, 12:22 PM · PostgreSQL, MediaWiki-Installer, MediaWiki-Maintenance-scripts
Reedy closed T216692: Security review for WikibaseSchema as Resolved.

As far as I'm concerned, this is good to go. A little bit of cleaning up, but nothing security specifically

Tue, Apr 23, 11:08 AM · Security-Team-Review-Active, Shape Expressions, Wikidata
Reedy closed T216692: Security review for WikibaseSchema, a subtask of T216957: deploy WikibaseSchema to beta, as Resolved.
Tue, Apr 23, 11:08 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Shape Expressions

Yesterday

Reedy added a project to T221567: Watchlist star indicator inconsistent after editing article: MediaWiki-Watchlist.
Mon, Apr 22, 10:18 PM · Growth-Team, MediaWiki-Watchlist
Reedy added a comment to T221560: Searches with hyphens yield a database query error.

Needs extra quoting...

Mon, Apr 22, 8:36 PM · Discovery-Search, MediaWiki-Search
Reedy added a project to T221560: Searches with hyphens yield a database query error: MediaWiki-Search.
Mon, Apr 22, 8:10 PM · Discovery-Search, MediaWiki-Search
Reedy renamed T221557: LDAP and search icon doesn't let you just tap on it from LDAP and search icon doesn't let you just tap on it (phab, mobile) to LDAP and search icon doesn't let you just tap on it.
Mon, Apr 22, 5:58 PM · Mobile, Phabricator
Reedy added a project to T221526: Explain on Special:UrlShortener that it can only be used on Meta-Wiki: MediaWiki-extensions-UrlShortener.
Mon, Apr 22, 5:49 PM · Patch-For-Review, MediaWiki-extensions-UrlShortener, WikimediaMessages
Reedy added a project to T221511: Possible full scan query ApiQueryUserContribs::execute for revision_actor_temp table on commonswiki: Performance.
Mon, Apr 22, 5:48 PM · Performance, Core Platform Team, MediaWiki-Database
Reedy added a comment to T189434: Fake email about @tools.wmflabs.org email.

@Reedy that might be a good idea, since I'm now getting email that's being spoofed (eg, it says it's to security@tools.wmflabs.org but I somehow got the email).

Mon, Apr 22, 5:46 PM · Mail, cloud-services-team
Reedy removed a subtask for T38220: The stashimageinfo module shouldn't be a prop querymodule (it doesn't accept titles and doesn't work with generators): T89971: ApiQueryImageInfo is crufty, needs rewrite.
Mon, Apr 22, 4:58 PM · MediaWiki-API
Reedy removed a parent task for T89971: ApiQueryImageInfo is crufty, needs rewrite: T38220: The stashimageinfo module shouldn't be a prop querymodule (it doesn't accept titles and doesn't work with generators).
Mon, Apr 22, 4:58 PM · Developer-Wishlist (2017), Technical-Debt, MediaWiki-API
Reedy added a comment to T221449: Redesign querycache* tables.

And for amusement, the boardvote tables on enwikibooks use 100MB+

Mon, Apr 22, 3:11 PM · MediaWiki-Database
Reedy added a comment to T221449: Redesign querycache* tables.

The tables are fairly big in small wikis (a wiki that was made last week and has 7k articles, has 57k rows in querycache making it 8th biggest table there while it's 70th largest table in enwiki), taking lots of storage for s3

Mon, Apr 22, 3:09 PM · MediaWiki-Database
Reedy added a comment to T221449: Redesign querycache* tables.

I’d imagine a large chunk of the data, at least on older wikis probably wouldn’t be migrated

Mon, Apr 22, 11:45 AM · MediaWiki-Database
Reedy added a comment to T221449: Redesign querycache* tables.

Oh and T174513: Maintenance script to cleanup querycache

Mon, Apr 22, 11:44 AM · MediaWiki-Database
Reedy added a comment to T221449: Redesign querycache* tables.

See also T146571: Add a primary key to querycache for some of the duplicates and crap that’s been left behind...

Mon, Apr 22, 11:41 AM · MediaWiki-Database

Sat, Apr 20

Reedy closed T121119: Unable to save a CV/resume with some configurations as Resolved.
Sat, Apr 20, 1:34 AM · MediaWiki-extensions-ConfirmAccount

Fri, Apr 19

Reedy added a comment to T221461: "Rollback with confirmation should offer rollback options for admin users" test flaky.
Fri, Apr 19, 4:22 PM · MediaWiki-Core-Testing
Reedy added projects to T220767: Some special pages are not properly displaying parenthesis and other seperators around user links: Growth-Team, UI-Standardization.
Fri, Apr 19, 4:05 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), UI-Standardization, Growth-Team, Patch-For-Review, MW-1.34-release, MW-1.33-release, Regression, MediaWiki-Special-pages, CheckUser
Reedy added a comment to T220767: Some special pages are not properly displaying parenthesis and other seperators around user links.

Confirmed fixed on Special:CheckUser (get users) too

Fri, Apr 19, 3:56 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), UI-Standardization, Growth-Team, Patch-For-Review, MW-1.34-release, MW-1.33-release, Regression, MediaWiki-Special-pages, CheckUser
Reedy created T221461: "Rollback with confirmation should offer rollback options for admin users" test flaky.
Fri, Apr 19, 3:51 PM · MediaWiki-Core-Testing
Reedy added a comment to T220767: Some special pages are not properly displaying parenthesis and other seperators around user links.

Hmm. So it seems there's no train next week... I think I'll cherry pick @Urbanecm's patch into .1, but leave it out of master, in the hope that @Catrope and/or @Jdlrobson (or anyone else on a responsible team) can deal with it in master before 1.34.0-wmf.3 is branched... There's about a week of working time after easter, but before the branch. Should be sufficient

Fri, Apr 19, 3:17 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), UI-Standardization, Growth-Team, Patch-For-Review, MW-1.34-release, MW-1.33-release, Regression, MediaWiki-Special-pages, CheckUser
Reedy added a comment to T221456: Mail server email.wikimedia.de is probably down.

I also tried to telephone to WMDE but they aren't at work so maybe smb. knows the phone number of their IT.

Fri, Apr 19, 3:16 PM · WMDE-Tech-Communication
Reedy edited projects for T220767: Some special pages are not properly displaying parenthesis and other seperators around user links, added: MW-1.34-notes (1.34.0-wmf.1; 2019-04-16); removed MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).
Fri, Apr 19, 3:10 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), UI-Standardization, Growth-Team, Patch-For-Review, MW-1.34-release, MW-1.33-release, Regression, MediaWiki-Special-pages, CheckUser
Reedy added a comment to T220767: Some special pages are not properly displaying parenthesis and other seperators around user links.

Of course, this also affects MW-1.33-release and we should be careful backports/fixes end up there too

Fri, Apr 19, 3:07 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), UI-Standardization, Growth-Team, Patch-For-Review, MW-1.34-release, MW-1.33-release, Regression, MediaWiki-Special-pages, CheckUser
Reedy added a comment to T220767: Some special pages are not properly displaying parenthesis and other seperators around user links.

Change 505242 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] Set $useParentheses to true in userToolLinksRedContribs

https://gerrit.wikimedia.org/r/505242

@Reedy This might be an easier solution. I'm not sure if this isn't breaking something else, but according to my local testing, it isn't causing anything like double parentheses or similar.

Fri, Apr 19, 2:50 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), UI-Standardization, Growth-Team, Patch-For-Review, MW-1.34-release, MW-1.33-release, Regression, MediaWiki-Special-pages, CheckUser
Reedy added a project to T221456: Mail server email.wikimedia.de is probably down: WMDE-Tech-Communication.
Fri, Apr 19, 2:45 PM · WMDE-Tech-Communication
Reedy added a comment to T220767: Some special pages are not properly displaying parenthesis and other seperators around user links.

Change 505242 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@master] Set $useParentheses to true in userToolLinksRedContribs

https://gerrit.wikimedia.org/r/505242

@Reedy This might be an easier solution. I'm not sure if this isn't breaking something else, but according to my local testing, it isn't causing anything like double parentheses or similar.

Fri, Apr 19, 2:05 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), UI-Standardization, Growth-Team, Patch-For-Review, MW-1.34-release, MW-1.33-release, Regression, MediaWiki-Special-pages, CheckUser
Reedy removed a project from T219348: RecentChanges should be fully skinnable - use pseudo elements for separating elements: Patch-For-Review.

Change 499364 merged by jenkins-bot:
[mediawiki/core@master] RecentChanges updated to use pseudo elements for presentation

https://gerrit.wikimedia.org/r/499364

Fri, Apr 19, 2:02 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Growth-Team, UI-Standardization, MediaWiki-Recent-changes, User-Jdlrobson
Reedy added a comment to T220767: Some special pages are not properly displaying parenthesis and other seperators around user links.

I maybe did in T221253.

Fri, Apr 19, 1:48 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), UI-Standardization, Growth-Team, Patch-For-Review, MW-1.34-release, MW-1.33-release, Regression, MediaWiki-Special-pages, CheckUser

Thu, Apr 18

Reedy added a project to T221368: cdnPurge and other jobs fail completely to execute: MediaWiki-JobQueue.
Thu, Apr 18, 2:37 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (Security, stability, performance and scalability (TEC1)), WMF-JobQueue, Performance-Team, MediaWiki-JobQueue, Wikimedia-production-error
Reedy merged task T221365: MassMessage not delivering into T221368: cdnPurge and other jobs fail completely to execute.
Thu, Apr 18, 2:33 PM · Patch-For-Review, MassMessage, Operations
Reedy merged T221365: MassMessage not delivering into T221368: cdnPurge and other jobs fail completely to execute.
Thu, Apr 18, 2:33 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (Security, stability, performance and scalability (TEC1)), WMF-JobQueue, Performance-Team, MediaWiki-JobQueue, Wikimedia-production-error
sbassett awarded T221354: l10n-update on beta breaks due to: ExtensionDependencyError TranslationNotifications requires Translate to be installed. a Like token.
Thu, Apr 18, 2:11 PM · MediaWiki-extensions-TranslationNotifications, Beta-Cluster-Infrastructure
Reedy closed T221354: l10n-update on beta breaks due to: ExtensionDependencyError TranslationNotifications requires Translate to be installed. as Resolved.
Thu, Apr 18, 1:11 PM · MediaWiki-extensions-TranslationNotifications, Beta-Cluster-Infrastructure
Reedy closed T221354: l10n-update on beta breaks due to: ExtensionDependencyError TranslationNotifications requires Translate to be installed., a subtask of T201794: phan-taint-check-plugin should ignore /extensions/ folder, as Resolved.
Thu, Apr 18, 1:11 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, MediaWiki-extensions-TranslationNotifications, Continuous-Integration-Config, phan-taint-check-plugin
Reedy added a comment to T221354: l10n-update on beta breaks due to: ExtensionDependencyError TranslationNotifications requires Translate to be installed..

So I guess the load order is wrong somewhere in operatons/mediawiki-config

Thu, Apr 18, 12:46 PM · MediaWiki-extensions-TranslationNotifications, Beta-Cluster-Infrastructure

Wed, Apr 17

Reedy added a comment to T220767: Some special pages are not properly displaying parenthesis and other seperators around user links.

Just wondering - is anyone working on this? Has anyone been able to validate what the breaking change was?

Wed, Apr 17, 10:17 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), UI-Standardization, Growth-Team, Patch-For-Review, MW-1.34-release, MW-1.33-release, Regression, MediaWiki-Special-pages, CheckUser
Reedy added a project to T221224: showJobs.php maintenance script useless and misleading in production: WMF-JobQueue.
Wed, Apr 17, 11:51 AM · Analytics, WMF-JobQueue, Wikimedia-General-or-Unknown, MediaWiki-Maintenance-scripts, EventBus
Reedy added a project to T221224: showJobs.php maintenance script useless and misleading in production: Wikimedia-General-or-Unknown.
Wed, Apr 17, 11:50 AM · Analytics, WMF-JobQueue, Wikimedia-General-or-Unknown, MediaWiki-Maintenance-scripts, EventBus
Reedy added a comment to T161248: Installation instructions of OAuthAuthentication are useless.

Dear @Reedy I see this task is currently unassigned and open for quite some time now.
As I already worked a bit to improve documentation, does it make sense that I claim it and and work with the userbase to update the instructions to a satisfactory level for admin and users as well?

I am sorry I am fairly new to the whole system, so I am not 100% sure if I am allowed to do this and what standards should I met.
I am willing to help nonetheless as I am working to make this extension work anyway for my own project, so I would put my experience at other users' service, if this can help.

Wed, Apr 17, 10:10 AM · MediaWiki-Documentation, Documentation, MediaWiki-extensions-OAuthAuthentication
Reedy added a comment to T25227: Use token when logging out.

"Rebased" @Bawolff's 3+ year-old patch (T25227#2013640) on master, tested locally. Talked about this with the Security-Team today - fine with just pushing it publicly in gerrit. If there are no objections, I'll create a patch set from the attached: F28682008.

Awesome! thanks. One thing in the patch, it uses the old array() system. That's my only note. Once it's in gerrit, add me as reviewer so I help (btw. Can we write tests for this?)

Wed, Apr 17, 9:35 AM · MediaWiki-Authentication-and-authorization, Patch-For-Review, Vuln-DoS, Security
Reedy added a comment to T216692: Security review for WikibaseSchema.

From my side I'd like the review to happen asap because otherwise it's getting into my vacation and I can't help deal with the feedback and requests from the editors. For that to work out we'd need to have everything ready for deployment on 24th of April.

Wed, Apr 17, 9:19 AM · Security-Team-Review-Active, Shape Expressions, Wikidata

Tue, Apr 16

Reedy placed T221142: Willy Pao onboarding up for grabs.
Tue, Apr 16, 9:34 PM · Patch-For-Review, Operations, DC-Ops
Reedy removed a project from T220623: Unable to view certain pages on incubator.wikimedia.org (Fatal error: operator not supported): Patch-For-Review.
Tue, Apr 16, 6:00 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-WikimediaIncubator, Wikimedia-production-error
Reedy removed a project from T220623: Unable to view certain pages on incubator.wikimedia.org (Fatal error: operator not supported): MediaWiki-extensions-Translate.
Tue, Apr 16, 5:25 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-WikimediaIncubator, Wikimedia-production-error
Reedy added a comment to T220623: Unable to view certain pages on incubator.wikimedia.org (Fatal error: operator not supported).

Ha, so it's actually an empty string by default. Interesting. Yeah, so Incubator just needs a patch then to ignore that and simply assign plainly like other hook handlers do…

Tue, Apr 16, 5:16 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-WikimediaIncubator, Wikimedia-production-error
Reedy added a member for Security: JFishback_WMF.
Tue, Apr 16, 4:51 PM
Reedy added a member for WMF-NDA: JFishback_WMF.
Tue, Apr 16, 4:38 PM
Reedy added a member for Security-Team: JFishback_WMF.
Tue, Apr 16, 4:28 PM
Reedy added a member for Trusted-Contributors: JFishback_WMF.
Tue, Apr 16, 4:28 PM

Mon, Apr 15

Reedy added a comment to T220623: Unable to view certain pages on incubator.wikimedia.org (Fatal error: operator not supported).
2019-04-15 19:22:52 [XLTaDApAAEMAAENpQwoAAABT] mw1272 incubatorwiki 1.33.0-wmf.25 fatal ERROR: [XLTaDApAAEMAAENpQwoAAABT] /wiki/Wp/roa-rup   PHP Fatal Error from line 402 of /srv/mediawiki/php-1.33.0-wmf.25/extensions/WikimediaIncubator/includes/WikimediaIncubator.php: Uncaught Error: [] operator not supported for strings in /srv/mediawiki/php-1.33.0-wmf.25/extensions/WikimediaIncubator/includes/WikimediaIncubator.php:402
Stack trace:
#0 /srv/mediawiki/php-1.33.0-wmf.25/includes/Hooks.php(174): WikimediaIncubator::onGetUserPermissionsErrors(Object(Title), Object(User), 'read', '')
#1 /srv/mediawiki/php-1.33.0-wmf.25/includes/Hooks.php(202): Hooks::callHook('getUserPermissi...', Array, Array, NULL)
#2 /srv/mediawiki/php-1.33.0-wmf.25/includes/Permissions/PermissionManager.php(302): Hooks::run('getUserPermissi...', Array)
#3 /srv/mediawiki/php-1.33.0-wmf.25/includes/Permissions/PermissionManager.php(258): MediaWiki\Permissions\PermissionManager->checkPermissionHooks('read', Object(User), Array, 'quick', true, Object(Title))
#4 /srv/mediawiki/php-1.33.0-wmf.25/includes/Permissions/PermissionManager.php(111): MediaWiki\Permissions\PermissionManager->getPermissionErrorsInternal('read', Object(User), Object(Title), 'quick', true)
#5 /srv/mediawiki/php-1.33.0-wmf.25/includes/Title {"fatal_exception":{"class":"ErrorException","message":"PHP Fatal Error: Uncaught Error: [] operator not supported for strings in /srv/mediawiki/php-1.33.0-wmf.25/extensions/WikimediaIncubator/includes/WikimediaIncubator.php:402
Stack trace:
#0 /srv/mediawiki/php-1.33.0-wmf.25/includes/Hooks.php(174): WikimediaIncubator::onGetUserPermissionsErrors(Object(Title), Object(User), 'read', '')
#1 /srv/mediawiki/php-1.33.0-wmf.25/includes/Hooks.php(202): Hooks::callHook('getUserPermissi...', Array, Array, NULL)
#2 /srv/mediawiki/php-1.33.0-wmf.25/includes/Permissions/PermissionManager.php(302): Hooks::run('getUserPermissi...', Array)
#3 /srv/mediawiki/php-1.33.0-wmf.25/includes/Permissions/PermissionManager.php(258): MediaWiki\\Permissions\\PermissionManager->checkPermissionHooks('read', Object(User), Array, 'quick', true, Object(Title))
#4 /srv/mediawiki/php-1.33.0-wmf.25/includes/Permissions/PermissionManager.php(111): MediaWiki\\Permissions\\PermissionManager->getPermissionErrorsInternal('read', Object(User), Object(Title), 'quick', true)
#5 /srv/mediawiki/php-1.33.0-wmf.25/includes/Title","code":1,"file":"/srv/mediawiki/php-1.33.0-wmf.25/extensions/WikimediaIncubator/includes/WikimediaIncubator.php","line":402,"trace":"#0 [internal function]: MWExceptionHandler::handleFatalError()
Mon, Apr 15, 10:15 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-WikimediaIncubator, Wikimedia-production-error
Reedy added a comment to T220623: Unable to view certain pages on incubator.wikimedia.org (Fatal error: operator not supported).

I note the stack trace is out of date....

Mon, Apr 15, 10:11 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-WikimediaIncubator, Wikimedia-production-error
Reedy added a comment to T220623: Unable to view certain pages on incubator.wikimedia.org (Fatal error: operator not supported).
	/**
	 * Prohibit creation of the pages that are part of our namespaces but have not been explicitly
	 * allowed. Bad capitalization is due to "userCan" hook name
	 * @param Title &$title
	 * @param User &$user
	 * @param string $action
	 * @param null &$result
	 * @return bool
	 */
	public static function onuserCan(
		/** @noinspection PhpUnusedParameterInspection */
		&$title, &$user, $action, &$result = null
	) {
		if ( !self::jsonConfigIsStorage() ) {
			return true;
		}
Mon, Apr 15, 9:51 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-WikimediaIncubator, Wikimedia-production-error
Reedy added a comment to T220623: Unable to view certain pages on incubator.wikimedia.org (Fatal error: operator not supported).

It looks like the problem is a faulty hook parameter, which might actually originate from other extensions in production that hook into the same event.

https://codesearch.wmflabs.org/deployed/?q=function.%2BetUserPermissionsErrors&i=nope&files=&repos=

Some set a string here (such as Flow). Which seems actually valid according to the docs.

&$result: … $result can be returned as a single error message key (string), or an array of error message keys …

So, looks like Incubator is in error after all.

EDIT: Except whenever it is set to a string, the hook should return false which would end the callback sequence. If Incubator is getting a string, that must mean a previous caller declared a permission error without returning false?

Mon, Apr 15, 9:49 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-WikimediaIncubator, Wikimedia-production-error
Reedy added a project to T220623: Unable to view certain pages on incubator.wikimedia.org (Fatal error: operator not supported): MediaWiki-extensions-Translate.
	 * Prevent patrol links from appearing on translation pages.
	 * Hook: getUserPermissionsErrors
	 *
	 * @param Title $title
	 * @param User $user
	 * @param string $action
	 * @param mixed &$result
	 *
	 * @return bool
	 */
	public static function preventPatrolling( Title $title, User $user, $action, &$result ) {
		if ( $action !== 'patrol' ) {
			return true;
		}
Mon, Apr 15, 9:43 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-WikimediaIncubator, Wikimedia-production-error
Reedy added a comment to T220623: Unable to view certain pages on incubator.wikimedia.org (Fatal error: operator not supported).
reedy@deploy1001:~$ mwscript eval.php incubatorwiki
> var_dump( $wgHooks['getUserPermissionsErrors'] );
array(2) {
  [0]=>
  string(46) "WikimediaIncubator::onGetUserPermissionsErrors"
  [1]=>
  string(39) "PageTranslationHooks::preventPatrolling"
}
Mon, Apr 15, 9:40 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-extensions-WikimediaIncubator, Wikimedia-production-error
Reedy renamed T221045: Possible dead code in ConfigRepository.php from Possible dead code in /includes/config/ConfigRepository.php to Possible dead code in ConfigRepository.php.
Mon, Apr 15, 9:24 PM · MediaWiki-Configuration
Reedy updated the task description for T221045: Possible dead code in ConfigRepository.php.
Mon, Apr 15, 9:20 PM · MediaWiki-Configuration
Krinkle awarded T187045: Decide on future of Extension:ShortUrl on Wikimedia Wikis a Orange Medal token.
Mon, Apr 15, 9:20 PM · Code-Stewardship-Reviews, MediaWiki-extensions-ShortUrl
Reedy closed T217498: Can we bump DonationInterface's required MW version? as Resolved.
Mon, Apr 15, 8:47 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), fundraising-tech-ops, Fundraising-Backlog, MediaWiki-extensions-DonationInterface
Reedy added a comment to T220998: Native spelling of Pali on www.wikipedia.org is wrong.

This should be updated on translatewiki, it will then be exported and go live within a week or so

Mon, Apr 15, 5:11 PM · User-DannyS712, Wikimedia-Portals
Reedy added a comment to T217543: incrementals of punjabi.wikimedia.org fail.

Placeholder mainpage created

Mon, Apr 15, 12:34 PM · Dumps-Generation
Reedy added a comment to T217543: incrementals of punjabi.wikimedia.org fail.

I can do, yeah. I'm curious how it doesn't even have a main page (do we just blame addWiki probably being broken?)

Mon, Apr 15, 12:31 PM · Dumps-Generation

Sun, Apr 14

Reedy merged T220929: Links to "talk" and "contribs" on Special:ListUsers no longer visually distinct from username links into T220767: Some special pages are not properly displaying parenthesis and other seperators around user links.
Sun, Apr 14, 11:56 PM · MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), UI-Standardization, Growth-Team, Patch-For-Review, MW-1.34-release, MW-1.33-release, Regression, MediaWiki-Special-pages, CheckUser
Reedy merged task T220929: Links to "talk" and "contribs" on Special:ListUsers no longer visually distinct from username links into T220767: Some special pages are not properly displaying parenthesis and other seperators around user links.
Sun, Apr 14, 11:56 PM
Reedy added a comment to T220929: Links to "talk" and "contribs" on Special:ListUsers no longer visually distinct from username links.

This is a dupe

Sun, Apr 14, 11:55 PM
Reedy updated the task description for T220927: PHP fatal error in Elastica extension.
Sun, Apr 14, 9:53 PM · Wikimedia-production-error, Discovery-Search, Elasticsearch
Reedy added a project to T220927: PHP fatal error in Elastica extension: Wikimedia-production-error.
Sun, Apr 14, 9:51 PM · Wikimedia-production-error, Discovery-Search, Elasticsearch
Reedy added a comment to T219440: Flaky wdio test "Rollback with confirmation: should offer a way to cancel".

More fails

Sun, Apr 14, 9:44 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), WMDE-FUN-Sprint-2019-04-01, WMDE-FUN-Sprint-2019-03-18, WMDE-FUN-Team, Confirmation prompt for rollback action, Wikimedia-production-error (Shared Build Failure)
Reedy changed the edit policy for T25227: Use token when logging out.
Sun, Apr 14, 8:41 PM · MediaWiki-Authentication-and-authorization, Patch-For-Review, Vuln-DoS, Security
Reedy changed the visibility for T25227: Use token when logging out.
Sun, Apr 14, 8:40 PM · MediaWiki-Authentication-and-authorization, Patch-For-Review, Vuln-DoS, Security
Reedy added a project to T220923: URL Shortener Should Not Mystery Meat Important Links: MediaWiki-extensions-UrlShortener.
Sun, Apr 14, 8:13 PM · MediaWiki-extensions-UrlShortener
Reedy added a subtask for T202470: phpunit-patch-coverage fails if a file was renamed: T220917: Update quibble jobs to use phpunit-patch-coverage 0.0.10.
Sun, Apr 14, 4:54 PM · phpunit-patch-coverage
Reedy added a parent task for T220917: Update quibble jobs to use phpunit-patch-coverage 0.0.10: T202470: phpunit-patch-coverage fails if a file was renamed.
Sun, Apr 14, 4:54 PM · Continuous-Integration-Infrastructure, Release-Engineering-Team
Reedy edited projects for T220917: Update quibble jobs to use phpunit-patch-coverage 0.0.10, added: Release-Engineering-Team, Continuous-Integration-Infrastructure; removed Continuous-Integration-Config.
Sun, Apr 14, 4:53 PM · Continuous-Integration-Infrastructure, Release-Engineering-Team
Reedy triaged T220917: Update quibble jobs to use phpunit-patch-coverage 0.0.10 as High priority.
Sun, Apr 14, 4:52 PM · Continuous-Integration-Infrastructure, Release-Engineering-Team
Reedy created T220917: Update quibble jobs to use phpunit-patch-coverage 0.0.10.
Sun, Apr 14, 4:52 PM · Continuous-Integration-Infrastructure, Release-Engineering-Team
Reedy added a comment to T202470: phpunit-patch-coverage fails if a file was renamed.

Re-opening for now as reminder to release/deploy. (Sorry)

Sun, Apr 14, 4:47 PM · phpunit-patch-coverage
Reedy created T220898: Removing ApiErrorFormatter_BackCompat.
Sun, Apr 14, 12:25 AM · Technical-Debt (Deprecation), MediaWiki-API

Sat, Apr 13

Reedy added a comment to T220779: Add test to check existence of action- messages.

This came up in MediaWikiAuth because there we have a permission that all it does is return early and not keep checking other things if they have it; there is no special action associated with it to begin with. While we may add an actual action later in this particular case, for quite a few other extensions that's definitely not going to happen: for instance HAWelcome runs a job behind the scenes and just skips it with its right...

Sat, Apr 13, 8:47 PM · I18n, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-Core-Testing
Reedy renamed T220870: [[MediaWiki:Editaccount-usage/en]] etc. use "email" instead of "e-mail" from [[MediaWiki:Editaccount-usage/en]] etc. contain "e-mail" instead of "email" to [[MediaWiki:Editaccount-usage/en]] etc. use "email" instead of "e-mail".
Sat, Apr 13, 1:46 AM · Patch-For-Review, User-DannyS712, MediaWiki-extensions-Other, I18n
Reedy added a project to T220871: [[MediaWiki:Log-action-filter-newusers-byemail/en]] contains "e-mail" instead of "email": MediaWiki-Internationalization.
Sat, Apr 13, 1:46 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), User-DannyS712, Patch-For-Review, MediaWiki-Internationalization, I18n

Fri, Apr 12

Reedy renamed T220864: Google Translate adds extra spaces for templates from Google Trasnlate adds extra spaces for templates to Google Translate adds extra spaces for templates.
Fri, Apr 12, 11:42 PM · Language-Team (Language-2019-April-June), ContentTranslation
Reedy added a comment to T220779: Add test to check existence of action- messages.

Structure tests should be enable after fixing the extensions and not produce something like "Unbreak now"

Fri, Apr 12, 11:39 PM · I18n, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), MediaWiki-Core-Testing
Reedy committed rELDB4d0f30657b97: Code cleanup (authored by Reedy).
Code cleanup
Fri, Apr 12, 8:49 PM