Page MenuHomePhabricator

RheingoldRiver (Megan "River" Cutrofello)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 6 2015, 5:56 PM (346 w, 5 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
RheingoldRiver [ Global Accounts ]

Recent Activity

Thu, Jun 23

RheingoldRiver updated subscribers of T309051: DisplayTitle shows nothing when linking to an anchor on a page with the same display as its anchor.

Oh @cicalese should I go ahead and do that last-resort patch?

Thu, Jun 23, 6:22 PM · MediaWiki-extensions-DisplayTitle

Sat, Jun 11

RheingoldRiver created T310417: Gantt charts fail when they contain a GROUP BY query.
Sat, Jun 11, 2:04 PM · MediaWiki-extensions-Cargo

Thu, Jun 9

RheingoldRiver created T310306: Add two hooks to Scribunto so that Module pages can be changed based on a "branch" parameter set in an invoke.
Thu, Jun 9, 6:06 PM · MediaWiki-extensions-Scribunto

May 23 2022

RheingoldRiver created T309051: DisplayTitle shows nothing when linking to an anchor on a page with the same display as its anchor.
May 23 2022, 8:31 PM · MediaWiki-extensions-DisplayTitle

May 1 2022

RheingoldRiver updated the task description for T307313: Jenkins doesn't have CSS-specific whitepsace rules regarding parentheses.
May 1 2022, 9:38 PM · ci-test-error
RheingoldRiver created T307313: Jenkins doesn't have CSS-specific whitepsace rules regarding parentheses.
May 1 2022, 9:37 PM · ci-test-error

Apr 19 2022

RheingoldRiver committed rEDPT780b9da41b82: Add config option for changing redirect display (authored by RheingoldRiver).
Add config option for changing redirect display
Apr 19 2022, 5:52 PM
RheingoldRiver created T306459: The notice "redirected from" shouldn't be affected by displaytitle.
Apr 19 2022, 5:44 PM · MediaWiki-extensions-DisplayTitle

Apr 12 2022

RheingoldRiver added a comment to T260998: Introduction of a template "Used by" at mediawiki.org.

I like this! It'll help to find example uses in addition to showing "stability" of the extension, I've always appreciated the "wikis using Cargo" page to find examples of Cargo tables. For standardization, maybe the template should have a list of farms and generate the sentence?

Apr 12 2022, 1:40 AM · WMF-General-or-Unknown

Mar 8 2022

RheingoldRiver added a comment to T183099: Provide a button for quickly reactivating filters.

That seems like a reasonable option to me, especially if:

Mar 8 2022, 3:17 AM · AbuseFilter

Feb 24 2022

RheingoldRiver added a comment to T183099: Provide a button for quickly reactivating filters.

However, the filter might still get throttled until the 24 hours (or whatever the configured value is) will have passed.

Feb 24 2022, 8:30 AM · AbuseFilter

Feb 20 2022

RheingoldRiver created T302179: Add the ability to unthrottle an abuse filter without updating its age.
Feb 20 2022, 6:56 PM · AbuseFilter

Sep 24 2021

RheingoldRiver added a comment to T250963: Replace use of deprecated hook InternalParseBeforeSanitize.

Echoing @Revansx , here's my primary use case:

Sep 24 2021, 2:38 AM · Patch-For-Review, ci-test-error, MediaWiki-extensions-Variables

Apr 30 2021

Pcj awarded T281608: Rename Bot Passwords to Authentication Tokens or Access Tokens a Yellow Medal token.
Apr 30 2021, 9:06 PM · MediaWiki-Authentication-and-authorization, MediaWiki-User-management
RheingoldRiver created T281608: Rename Bot Passwords to Authentication Tokens or Access Tokens.
Apr 30 2021, 8:53 PM · MediaWiki-Authentication-and-authorization, MediaWiki-User-management

Apr 25 2021

RheingoldRiver added a comment to T281050: Edit API with appendtext & a contentmodel change gives an internal api error.

afaik the plan is for us to start updating regularly - we're not on forked MediaWiki anymore, but we are behind on versions for sure. I have no idea what the plan for updates is though, just that they're supposed to happen.

Apr 25 2021, 7:29 PM · Platform Team Workboards (Clinic Duty Team), MediaWiki-ContentHandler, MediaWiki-Action-API
RheingoldRiver added a comment to T281050: Edit API with appendtext & a contentmodel change gives an internal api error.

Ah, I didn't realize changecontentmodel existed since we're on 1.33 still, sorry.

Apr 25 2021, 7:15 PM · Platform Team Workboards (Clinic Duty Team), MediaWiki-ContentHandler, MediaWiki-Action-API
RheingoldRiver added a comment to T281050: Edit API with appendtext & a contentmodel change gives an internal api error.

I think it should allow both changes because it's possible for a script to encounter a page that was initialized with the wrong contentmodel, then want to append text to it & fix the contentmodel.

Apr 25 2021, 6:46 PM · Platform Team Workboards (Clinic Duty Team), MediaWiki-ContentHandler, MediaWiki-Action-API
RheingoldRiver created T281050: Edit API with appendtext & a contentmodel change gives an internal api error.
Apr 25 2021, 5:20 AM · Platform Team Workboards (Clinic Duty Team), MediaWiki-ContentHandler, MediaWiki-Action-API

Dec 6 2020

RheingoldRiver created T269515: Categories added via "MediaWiki:" system messages and {{int:}} magic word show incorrectly in translated languages.
Dec 6 2020, 5:40 AM · MediaWiki-Categories

May 25 2020

RheingoldRiver renamed T253500: Moving a reviewed page to a non-FlaggedRevs namespace without redirect leaves behind an unchecked page from [FlaggedRevs] Using review API on all revisions of a page doesn't review the page itself to [FlaggedRevs] Moving a reviewed page to a non-FlaggedRevs namespace without redirect leaves behind an unchecked page.
May 25 2020, 8:14 AM · MediaWiki-extensions-FlaggedRevs
RheingoldRiver added a comment to T253500: Moving a reviewed page to a non-FlaggedRevs namespace without redirect leaves behind an unchecked page.

Okay so I've found a workaround for my own purposes, which is to leave behind a redirect in the move and then delete the redirect afterwards. This suppresses the "unchecked page." But it's still kind of weird:

  1. Create page - you have an unchecked page at OriginalLocation
  2. Check page - no unchecked page
  3. Move page WITH redirect - now you have a page which exists at OriginalLocation and is not unchecked, but says it's unchecked in Recent Changes
  4. Delete OriginalLocation - no unchecked page anymore
May 25 2020, 8:09 AM · MediaWiki-extensions-FlaggedRevs
RheingoldRiver updated the task description for T253500: Moving a reviewed page to a non-FlaggedRevs namespace without redirect leaves behind an unchecked page.
May 25 2020, 7:44 AM · MediaWiki-extensions-FlaggedRevs
RheingoldRiver renamed T253500: Moving a reviewed page to a non-FlaggedRevs namespace without redirect leaves behind an unchecked page from Using review API on all revisions of a page doesn't review the page itself to [FlaggedRevs] Using review API on all revisions of a page doesn't review the page itself.
May 25 2020, 7:37 AM · MediaWiki-extensions-FlaggedRevs
RheingoldRiver created T253500: Moving a reviewed page to a non-FlaggedRevs namespace without redirect leaves behind an unchecked page.
May 25 2020, 7:37 AM · MediaWiki-extensions-FlaggedRevs

Nov 6 2019

RheingoldRiver added a comment to T237490: Collect feedback from module and gadget authors for Developer Productivity & onwiki tooling techconf session.

Hi,

  1. I'm the lead admin of https://lol.gamepedia.com/League_of_Legends_Esports_Wiki. I do a lot of work with Lua and Cargo.
Nov 6 2019, 8:03 AM · Wikimedia-Technical-Conference-2019

May 14 2019

RheingoldRiver added a comment to T205817: AphrontCountQueryException when trying to visit my Profile in Phabricator.

Oh, now I'm able to remove - when I opened the ticket, I got the same error come up when I attempted to delete, but now it let me unlink successfully - if that's something you fixed, thanks!

May 14 2019, 11:53 AM · Phabricator

Apr 10 2019

RheingoldRiver added a comment to T205817: AphrontCountQueryException when trying to visit my Profile in Phabricator.

Hi sorry just wanted to follow up on this

Apr 10 2019, 11:29 AM · Phabricator

Nov 15 2018

RheingoldRiver added a comment to T209543: Cargo causes a DBTransactionStateError when attempting to store when a table does not exist..

I sync a lot of code across wikis, and sometimes the newer wiki doesn't have all the tables created yet, having the page completely error can make it pretty hard to figure out what needs to be created. Also with such a large number of wikis & tables, I don't always create everything unless I need it. There's a separate issue which is that (at least in the past) the recreate data api action could only REcreate tables, and not create them in the first place, which contributes to the lag in creating all tables on new wikis, since it's a manual process for each one; regardless, I don't think erroring the entire page is the best behavior when a table doesn't exist.

Nov 15 2018, 5:02 AM · MediaWiki-extensions-Cargo

Oct 19 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Ok! I just had a conversation with @Alianin about all this, and I'll write here when I have an update.

Oct 19 2018, 7:05 PM · MediaWiki-extensions-Approved-Revs

Oct 18 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

So does everything seem good now?

Oct 18 2018, 9:34 PM · MediaWiki-extensions-Approved-Revs

Oct 9 2018

RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Oct 9 2018, 7:28 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Yeah unapprovable vs no current approved revision is important, since no current approved revision will be a "scary" warning message that the page is completely unreviewed by staff. I'll remove 2e then.

Oct 9 2018, 7:28 PM · MediaWiki-extensions-Approved-Revs

Oct 8 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.
  • ah, my mistake in the later part, this doesn't depend on 1b, only 1a
Oct 8 2018, 8:51 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Oct 8 2018, 8:50 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Oct 8 2018, 8:47 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Oh yeah....Ok re-renumbered, and updated sub-part numbers as well as references.

Oct 8 2018, 11:08 AM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Oct 8 2018, 11:07 AM · MediaWiki-extensions-Approved-Revs

Oct 7 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Hah, yeah I was debating between temporarily doing Part 0.5 and that...Relabeled now. If anyone is following the discussion and confused, here is the old numbering/lettering. Hopefully I didn't miss any changes.

Oct 7 2018, 4:07 AM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Oct 7 2018, 4:06 AM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Oct 7 2018, 4:03 AM · MediaWiki-extensions-Approved-Revs

Oct 6 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Ok updated a bit, and I switched some things around in order. I still haven't renamed stuff but if everything still seems good I'll do that next to have a final description that looks nice. And for 1 b and d, as long as the URL actions and classes are defined, it doesn't matter to me at all if this is built in.

Oct 6 2018, 5:06 AM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Oct 6 2018, 5:04 AM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Yeah, I think everything here seems good, though there's still the question about whether 1b and/or d are going to be added to the extension or something I do in js/css provided the classes are added (which tbh I think they should be regardless, just for extra custom styling)

Oct 6 2018, 4:55 AM · MediaWiki-extensions-Approved-Revs

Oct 2 2018

RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Oct 2 2018, 6:39 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Oct 2 2018, 6:35 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Oct 2 2018, 6:31 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Ah, yeah that would work too. FR doesn't, but I'll make a note of it in the overview. And 1(b) potentially has the same issue too, but could also be fixed the same way by adding a class to the overall page.

Oct 2 2018, 6:29 PM · MediaWiki-extensions-Approved-Revs

Oct 1 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Ok I made a couple more small edits. One thing for 1d - I realized I wasn't clear about this before, that link should only be in RC if there actually are post-approval/pending changes present for that page. (Since the link also serves as a visual indicator that a page has pending changes that need to be checked.) So maybe not as easy to do in JS.

Oct 1 2018, 8:53 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Oct 1 2018, 8:51 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Oct 1 2018, 6:27 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

That's how FR does it - If you click "accept revision" (or alt+shift+S) here it just processes it without navigating away, it's just a lot faster to go through a lot of pages that way, since there's no waiting for the page to reload. I think that's the only FR action that you can do without any page navigation.

Oct 1 2018, 6:26 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver created T205817: AphrontCountQueryException when trying to visit my Profile in Phabricator.
Oct 1 2018, 7:19 AM · Phabricator
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Oct 1 2018, 6:27 AM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Oct 1 2018, 6:27 AM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Yeah, that's correct - though of course I would prefer to do as little JS as possible since we already have a crazy amount of JS all over the place.

Oct 1 2018, 6:20 AM · MediaWiki-extensions-Approved-Revs

Sep 30 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Okay, I kind of do like the idea of having that action available, but it would definitely be not at all important, as long as the extension has a built-in hotkey on the current version of the page & any diff of (any older version to current) that set current version as approved (mirrors FR behavior, where alt+shift+S does this).

Sep 30 2018, 7:18 AM · MediaWiki-extensions-Approved-Revs

Sep 28 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Oh sorry. Monitor how much I actually need the [pending changes] (or action=diffapprovedtolatest) links vs the regular diff link in RC. A lot of the time, they aren't the same link & I really did need the one provided by FR. So basically, 1(d) is actually as important as I thought it was.

Sep 28 2018, 6:45 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Sorry, I don't think I understand this. What is the "diff" you're talking about - the standard MediaWiki "diff" link, or some link from FR? If it's the latter, I don't understand.

Sep 28 2018, 5:16 AM · MediaWiki-extensions-Approved-Revs

Sep 27 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Ok I updated the task with the diffapprovedtolatest URL action in b and d, and removed c since that's part of b now (after everything I'll re-letter but that's probably too confusing for now).

Sep 27 2018, 5:26 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Sep 27 2018, 5:17 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Sep 27 2018, 5:16 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Now I think I fully understand the issue - in your case, you want an approval to happen as quickly as possible, even if the latest revision is not 100% perfect, as long as it doesn't contain any obvious flaws. You want to approve in haste and correct in leisure, to coin a phrase.

Yeah, exactly this. I view AR/FR as something I really don't want to have, and we only use it out of necessity to avoid super incorrect things that are put live every now and then either through user error or vandalism. So our approval process is a very minimal and quick review just to make sure nothing is blatantly false. This is also why the permissions thing is such a big deal to me, I want a lot of people to bypass this review altogether, and we'll just monitor via patrols what has actually been carefully inspected or not.

Sep 27 2018, 6:06 AM · MediaWiki-extensions-Approved-Revs

Sep 26 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

No, I always want that link regardless of number of users. Even if I did want to check the history in that case, I'd still first look at the net diff just to have consistency in workflow. Patrol is this. Basically approving an edit via FR/AR = "this edit is not wrong and so it can be live" - this needs to be as fluid as possible to happen, and happen quickly. Patrolling is a much more leisurely and careful thing, and would avoid the issue that you're describing being problematic.

Sep 26 2018, 7:33 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Sep 26 2018, 6:39 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

@Alianin could answer about FR being phased out, I'm not sure the details about it.

Sep 26 2018, 6:37 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Ah and re: 1b), what if it was on every view of the page? That would fix 1c and provide more consistency in doing so.

Sep 26 2018, 5:26 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Sep 26 2018, 5:26 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

No, I almost never bother looking at page history before clicking to a net pending diff. It's almost always irrelevant to the change made on the page. My wiki is basically a news site, so page edits are usually the addition of new information that didn't exist in the previous version of the page because it hadn't happened yet. I guess this is different from most wikis which might be the reason for a lot of our disconnect.

Sep 26 2018, 5:24 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Wait in 1(b) - would that link be at the top of every single view of the page? My understanding was that was only when viewing current version of the page, but it sounds like it would be on edit/history/viewing diffs/viewing old versions/etc ? If so then we can strike 1(c) no problem, although I would still like to keep 1(d) (that link that FR provides from RC is super important).

Sep 26 2018, 4:45 AM · MediaWiki-extensions-Approved-Revs

Sep 25 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Now, what if that revision turned out not to be good?

Sep 25 2018, 3:35 PM · MediaWiki-extensions-Approved-Revs

Sep 23 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

The warning would be enough to curtail user error. So I guess there's 2 totally unrelated reasons for wanting this link (or both), which may be why it seems weird.

Sep 23 2018, 9:57 AM · MediaWiki-extensions-Approved-Revs

Sep 22 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Hm, now that I think about it actually there are 2 potential diffs you might want to look at from that page - either (earlier of this diff to most recent) or (approved to most recent), the former is probably the more useful of the two, but either would work.

Sep 22 2018, 4:41 AM · MediaWiki-extensions-Approved-Revs

Sep 21 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Could it be a warning with a link? If that text had after it, "Click here to see diff to most recent." it would be perfect, and a lot better than FR version even.

Sep 21 2018, 6:11 AM · MediaWiki-extensions-Approved-Revs

Sep 20 2018

RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Sep 20 2018, 10:58 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

(1c) So in RC it will link both to the net diff (approved to current) and also to the diff of that particular revision. If you click on the latter, and set the newer one of those 2 as approved, you may think you had actually gone to the net diff and approved most recent.

Sep 20 2018, 10:58 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

(3) ah okay, yeah if it's not easy/doable no problem - and yeah, I wouldn't want there to be 500+ entries in RC (or a log) when someone changes a setting in a template...so it would only be worth it if it could be combined into a single line, which is starting to sound like it might be complicated. Maybe I could accomplish something via some workaround with AbuseFilter's ability to check diffs, if I always warn when either approvable_by or NOAPPROVAL is added.

Sep 20 2018, 10:07 AM · MediaWiki-extensions-Approved-Revs

Sep 18 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

(3) yeah that's fine. Maybe there could be a separate log for additions or removals of approvable_by or NOAPPROVAL to pages? I'm going to hide the "set as approved revision" log messages from my recent changes (assuming that's possible) but it would be nice to have a log for these show up in RC.

Sep 18 2018, 3:22 AM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Sep 18 2018, 12:00 AM · MediaWiki-extensions-Approved-Revs

Sep 17 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

(3) Oh, I guess anyone can add it, but the revision has to actually be approved by someone who was already able to approve it prior to the change being made in order to have any effect.

Sep 17 2018, 11:59 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Well, okay, but the same thing is true for everything before the approved revision.

Sep 17 2018, 4:05 AM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Sep 17 2018, 4:02 AM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Oh, yeah having that class helps a lot, I wanted to style something like this in addition to having the two texts there. I guess I could just do everything with css then,

Sep 17 2018, 3:14 AM · MediaWiki-extensions-Approved-Revs

Sep 16 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

I just really want to preserve the concept of edits being "pending" - actually I might use "Approve [pending]" and "Set as approved" as the two texts. (One other possible option could be to do it visually with arrows in opposite directions after the text "approve".) When I first looked at AR on the one wiki we installed it on, I was really confused looking at the page history for about 10-15 minutes before realizing what was going on with there being only one approved edit at a time, and I think if I was confused a bit then other users will be way more confused, particularly those who are used to the FR concept. Also this seems like relatively minor change to implement in order to significantly increase compatibility with the other paradigm, unless I'm wrong.

Sep 16 2018, 8:07 AM · MediaWiki-extensions-Approved-Revs

Sep 14 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

1f, 2c) updated description again.

Sep 14 2018, 9:27 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Sep 14 2018, 9:19 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

1c) Oops try now, I rewrote again.

Sep 14 2018, 4:33 AM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Sep 14 2018, 4:32 AM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

btw for 1(g) I think it's fine if they default to both say "approve," as long as there's the possibility to locally change them to be different, particularly for wikis that are switching away from FR.

Sep 14 2018, 12:54 AM · MediaWiki-extensions-Approved-Revs

Sep 13 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Okay, updated/clarified in the post.

Sep 13 2018, 10:44 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Sep 13 2018, 10:38 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Sep 13 2018, 7:50 AM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Sep 13 2018, 7:24 AM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Okay, done. Can you check and make sure I didn't miss anything?

Sep 13 2018, 7:23 AM · MediaWiki-extensions-Approved-Revs
RheingoldRiver updated the task description for T203730: Adding some FlaggedRevs features to Approved Revs.
Sep 13 2018, 7:23 AM · MediaWiki-extensions-Approved-Revs

Sep 12 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Sure, self-approvers works.

Sep 12 2018, 10:34 PM · MediaWiki-extensions-Approved-Revs

Sep 9 2018

RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

Wait I'm sorry I got confused in 2(f) because of what reviewers means. Editors would not be able to do that, no. Only approvers. Editors would only have their own page creations approved, not be able to approve others.

Sep 9 2018, 10:04 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

(1d) Honestly no, it's easy to not realize you aren't looking at most recent changes. Also when used in conjunction with "hide patrolled edits" filter very frequently you aren't because there will have been some patrolled edit more recent than the unpatrolled one that you need to check. Maybe this could be done via a setting though, "alwaysShowNetARDiffs" or something.

Sep 9 2018, 9:30 PM · MediaWiki-extensions-Approved-Revs
RheingoldRiver added a comment to T203730: Adding some FlaggedRevs features to Approved Revs.

(1d) Yeah, that's what FR does - the idea is, "there is a change to this page that involves edits later than the approved revision. either you can view the diff by pressing the diff button, or alternatively here's a shortcut to view the entire diff between approved and current" Using that button next to new edits made by people without editor right is the primary workflow for FR, it's probably the most important of all of the requests that I have.

Sep 9 2018, 7:34 AM · MediaWiki-extensions-Approved-Revs

Sep 7 2018

RheingoldRiver created T203849: AphrontCountQueryException on my Profile Page (T75720).
Sep 7 2018, 9:21 PM · Phabricator