Page MenuHomePhabricator

Ryan10145
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Dec 13 2017, 2:13 AM (84 w, 2 h)
Availability
Available
LDAP User
Unknown
MediaWiki User
Ryan10145 [ Global Accounts ]

Recent Activity

Jun 9 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rEBSQ692aa21e2da8: Update patch set 2 (authored by Ryan10145).
Update patch set 2
Jun 9 2018, 9:33 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSQ07f21390bd3d: Update patch set 2 (authored by Ryan10145).
Update patch set 2
Jun 9 2018, 9:33 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSQ8d0a21a31736: Create patch set 2 (authored by Ryan10145).
Create patch set 2
Jun 9 2018, 9:33 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEBSQf16a51d99d95: Create change (authored by Ryan10145).
Create change
Jun 9 2018, 9:33 AM

Jan 18 2018

Ryan10145 removed a project from T182522: imagecopy does not support its -cc option: Patch-For-Review.
Jan 18 2018, 4:05 AM · good first bug, Pywikibot

Jan 17 2018

Ryan10145 claimed T182522: imagecopy does not support its -cc option.
Jan 17 2018, 3:05 AM · good first bug, Pywikibot

Jan 16 2018

Ryan10145 added a comment to T179000: Blog about your GCI experience (findings and learnings) with Wikimedia [recurring].

Hi, I wrote my blog post in English here. I have also posted it on the wiki page, and I hope you enjoy reading it :) Thank you for all for the incredible experience this year!

Jan 16 2018, 3:35 AM · Google-Code-in-2017

Jan 13 2018

Ryan10145 removed a project from T183664: download_dump.py: Add a progress bar: Patch-For-Review.
Jan 13 2018, 2:10 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
Ryan10145 removed a project from T183675: download_dump.py: Make download process atomic: Patch-For-Review.
Jan 13 2018, 2:10 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
Ryan10145 removed a project from T183898: ListToggle class does not have PHPUnit tests: Patch-For-Review.
Jan 13 2018, 2:10 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Google-Code-in-2017, MediaWiki-Core-Testing
Ryan10145 removed a project from T183900: ContentModelLogFormatter does not have PHPUnit tests: Patch-For-Review.
Jan 13 2018, 2:10 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Google-Code-in-2017, MediaWiki-Core-Testing, MediaWiki-Logging

Jan 12 2018

Ryan10145 claimed T183810: [Unit testing] Unit test `getNewsletter` in `includes/NewsletterDb.php`.
Jan 12 2018, 11:46 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
Ryan10145 removed a project from T183899: ComposerInstalled class does not have PHPUnit tests: Patch-For-Review.
Jan 12 2018, 10:52 PM · Google-Code-in-2017, MediaWiki-Core-Testing
Ryan10145 removed a project from T183811: [Unit testing] Unit test `getNewsletterFromName` in newsletters `includes/NewsletterDb.php`: Patch-For-Review.
Jan 12 2018, 10:51 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
Ryan10145 closed T183811: [Unit testing] Unit test `getNewsletterFromName` in newsletters `includes/NewsletterDb.php` as Resolved.
Jan 12 2018, 10:16 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
Ryan10145 closed T183811: [Unit testing] Unit test `getNewsletterFromName` in newsletters `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Jan 12 2018, 10:16 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter

Jan 11 2018

Ryan10145 added a comment to T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension.

Changed some of the description, since the merged changes made the line numbers incorrect

Jan 11 2018, 2:51 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
Ryan10145 updated the task description for T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension.
Jan 11 2018, 2:50 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
Ryan10145 claimed T183811: [Unit testing] Unit test `getNewsletterFromName` in newsletters `includes/NewsletterDb.php`.
Jan 11 2018, 1:33 AM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Google-Code-in-2017, MediaWiki-extensions-Newsletter

Jan 10 2018

Ryan10145 closed T183899: ComposerInstalled class does not have PHPUnit tests as Resolved.
Jan 10 2018, 6:06 AM · Google-Code-in-2017, MediaWiki-Core-Testing

Jan 8 2018

Ryan10145 claimed T183899: ComposerInstalled class does not have PHPUnit tests.
Jan 8 2018, 1:12 AM · Google-Code-in-2017, MediaWiki-Core-Testing

Jan 7 2018

Ryan10145 closed T183900: ContentModelLogFormatter does not have PHPUnit tests as Resolved.
Jan 7 2018, 11:27 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Google-Code-in-2017, MediaWiki-Core-Testing, MediaWiki-Logging
Ryan10145 added a comment to T183900: ContentModelLogFormatter does not have PHPUnit tests.

Thank you for the information!

Jan 7 2018, 9:58 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Google-Code-in-2017, MediaWiki-Core-Testing, MediaWiki-Logging
Ryan10145 added a comment to T183900: ContentModelLogFormatter does not have PHPUnit tests.

I noticed that the other tests in tests/phpunit/includes/logging have the comment

/**
 * Provide different rows from the logging table to test
 * for backward compatibility.
 * Do not change the existing data, just add a new database row
 */

Do I have to add multiple rows to the tests I am writing for ContentModelLogFormatter?

Jan 7 2018, 9:32 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Google-Code-in-2017, MediaWiki-Core-Testing, MediaWiki-Logging
Ryan10145 claimed T183900: ContentModelLogFormatter does not have PHPUnit tests.
Jan 7 2018, 9:31 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Google-Code-in-2017, MediaWiki-Core-Testing, MediaWiki-Logging
Ryan10145 placed T183897: ProxyLookup class does not have PHPUnit tests up for grabs.
Jan 7 2018, 9:31 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-Core-Testing
Ryan10145 added a comment to T183897: ProxyLookup class does not have PHPUnit tests.

Oops, claimed the wrong task.

Jan 7 2018, 9:31 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-Core-Testing
Ryan10145 claimed T183897: ProxyLookup class does not have PHPUnit tests.
Jan 7 2018, 7:31 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-Core-Testing

Jan 5 2018

Ryan10145 committed rEBSQ67f1aebea631: Added Minus-X Support (authored by Ryan10145).
Added Minus-X Support
Jan 5 2018, 9:40 PM
Ryan10145 updated the task description for T175794: Add MinusX to MediaWiki extensions and PHP library repos.
Jan 5 2018, 3:44 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, Continuous-Integration-Config, MinusX
Ryan10145 committed rEBSQ80b3fb83ce39: Added Minus-X Support (authored by Ryan10145).
Added Minus-X Support
Jan 5 2018, 3:41 AM
Ryan10145 closed T183898: ListToggle class does not have PHPUnit tests as Resolved.
Jan 5 2018, 12:55 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Google-Code-in-2017, MediaWiki-Core-Testing

Jan 3 2018

Ryan10145 claimed T183898: ListToggle class does not have PHPUnit tests.
Jan 3 2018, 11:36 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), Google-Code-in-2017, MediaWiki-Core-Testing

Jan 2 2018

Ryan10145 added a comment to T183675: download_dump.py: Make download process atomic.

Good point, it is probably best to avoid recursion and to instead use or. However, I feel that the while loop implementation is still somewhat difficult to understand, especially for a newer programmer. @Framawiki, what are your thoughts on which one to use?

Jan 2 2018, 10:03 PM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017

Jan 1 2018

Ryan10145 added a comment to T183675: download_dump.py: Make download process atomic.

@zhuyifei1999 I was thinking of something along the lines of

Jan 1 2018, 6:19 PM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
Ryan10145 added a comment to T183675: download_dump.py: Make download process atomic.

@Framawiki I can work on it, but I'm not sure if it would be right to do it at this moment, since the patches for T183664 and T183667 would be affected. I'll try to get this done when there aren't any open patches affecting download_dump.py

Jan 1 2018, 6:44 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
Ryan10145 added a comment to T183664: download_dump.py: Add a progress bar.

I discovered the error, I was running the script incorrectly. I was using python scripts/maintenance/download_dump.py -filename instead of python pwb.py maintenance/download_dump.py
pywikibot.comms.http.fetch('https://dumps.wikimedia.org/idwiki/latest/idwiki-latest-abstract.xml', stream=True) works as intended when ran correctly.

Jan 1 2018, 2:00 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
Ryan10145 added a comment to T183664: download_dump.py: Add a progress bar.

I was experimenting with the location of a test script, and I found something interesting. I used the following test script.

import sys
import pywikibot
Jan 1 2018, 1:40 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017

Dec 31 2017

Ryan10145 added a comment to T183664: download_dump.py: Add a progress bar.

I downloaded the patch that was supposed to fix the streaming issue, but I am still running into issues with the streaming. First of all, when I test the functionality of pywikibot.comms.http.fetch(url, stream=True) from the pywikibot shell, it works as intended. I tested it using

def test_fetch():
    resp = pywikibot.comms.http.fetch('https://dumps.wikimedia.org/idwiki/latest/idwiki-latest-abstract.xml', stream=True)
    for data in resp.data.iter_content(100 * 1024):
         sys.stdout.write('asd')
         sys.stdout.flush()

This produced the string 'asd' gradually as it began downloading the file.
However, when I go into download_dump.py, and I have the below code, it does not work.

response = fetch(url, stream=True)
for data in response.data.iter_content(100 * 1024):
    sys.stdout.write('asd')
    sys.stdout.flush()

What happens instead is that there is a ~10 second pause, and then the string 'asd' is printed many times, nearly instantaneously.
This leads me to believe that for some strange reason, fetch(url, stream=True) is still not streaming the data.
I don't know why this is occurring, and help would be greatly appreciated.

Dec 31 2017, 9:14 PM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
Ryan10145 added a comment to T183664: download_dump.py: Add a progress bar.

@eflyjason I tried it, and the none of the messages printed until the download completed.

Dec 31 2017, 5:23 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
Ryan10145 added a comment to T183664: download_dump.py: Add a progress bar.

I'm running into a problem with this task. From the line response = fetch(url, stream=True), I assumed that the file is not being downloaded on that line, and rather it will wait until the data is accessed to begin downloading it. Therefore, I thought that I could put any download bar code inside of

for data in response.data.iter_content(100 * 1024):
    result_file.write(data)

To test this, I put pywikibot.output('test') right after result_file.write(data)
However, when I did this and ran the script, the console stopped for ~10 seconds, and then printed my test code multiple times extremely rapidly.

Dec 31 2017, 4:06 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
Ryan10145 claimed T183664: download_dump.py: Add a progress bar.
Dec 31 2017, 2:13 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
Ryan10145 closed T183675: download_dump.py: Make download process atomic as Resolved.
Dec 31 2017, 2:11 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
Ryan10145 closed T183675: download_dump.py: Make download process atomic, a subtask of T183663: Improve the maintenance script that download Wikimedia database dump, as Resolved.
Dec 31 2017, 2:11 AM · Pywikibot-Scripts, Pywikibot

Dec 29 2017

Ryan10145 added a comment to T183675: download_dump.py: Make download process atomic.

I just submitted a patch, but I'll try to make the change.

Dec 29 2017, 12:04 AM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017

Dec 28 2017

Ryan10145 added a comment to T183675: download_dump.py: Make download process atomic.

Thank you for the help, I didn't see this before because my web browser would automatically correct the slashes when I clicked on it.

Dec 28 2017, 10:45 PM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
Ryan10145 added a comment to T183675: download_dump.py: Make download process atomic.

I'm trying to run this script on my computer so I can do this task, but whenever I try to download the abstract.xml file, I get a Http reponse status 404 error. I am using a computer running Windows 7.
This is my console output without -v:

python scripts/maintenance/download_dump.py -filename
abstract.xml
Dec 28 2017, 10:28 PM · Pywikibot-Scripts, Pywikibot, Google-Code-in-2017
Ryan10145 closed T118636: Add scraping of PRISM tags to html-metadata node library as Resolved.
Dec 28 2017, 6:53 AM · User-Ryasmeen, Google-Code-in-2017, VisualEditor, Citoid
Ryan10145 closed T118636: Add scraping of PRISM tags to html-metadata node library, a subtask of T76225: Add Highwire Press, Eprints, BE Press, to html-metadata lib, as Resolved.
Dec 28 2017, 6:53 AM · User-Ryasmeen, VisualEditor, Citoid
Ryan10145 added a comment to T183637: [GCI][Unit testing] Unit test condition "The main page should be unique per newsletter" in NewsletterCreate.

Oops, made a typo with the bug number, sorry.

Dec 28 2017, 4:21 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter

Dec 26 2017

Ryan10145 added a comment to T183638: [GCI][Unit testing] Unit test condition "The newsletter name should be unique" in NewsletterCreate.

I'm having difficulties with being able to create 2 different newsletters with the same name. Whenever I try to input a new newsletter, it gives me an error saying that the mainpage is either in use or nonexistent. What can I put in Title::newFromText( ' ' )->getBaseText() in order to successfully submit 2 different newsletters?

Dec 26 2017, 6:43 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter

Dec 24 2017

Ryan10145 updated the task description for T175794: Add MinusX to MediaWiki extensions and PHP library repos.
Dec 24 2017, 6:13 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, Continuous-Integration-Config, MinusX

Dec 21 2017

Ryan10145 committed rEMCO5351e3f1cda0: Added MinusX Support (authored by Ryan10145).
Added MinusX Support
Dec 21 2017, 12:07 AM
Ryan10145 committed rEMCOb7e290c8411d: Added MinusX Support (authored by Ryan10145).
Added MinusX Support
Dec 21 2017, 12:07 AM

Dec 20 2017

Ryan10145 added a comment to T94020: The labels and numbers in CX translation trend graph are not localized.

Is there any way for me to get any more information about which dates in particular are causing an error with moment.js? I have tried setting up the extension on my own computer in order to see the problems for myself and try to fix them, but I have been having technical difficulties.

Dec 20 2017, 11:44 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Language-2018-Jan-Mar, Google-Code-in-2017, WorkType-Maintenance, I18n, good first bug, ContentTranslation
Ryan10145 updated the task description for T175794: Add MinusX to MediaWiki extensions and PHP library repos.
Dec 20 2017, 11:17 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, Continuous-Integration-Config, MinusX

Dec 13 2017

Ryan10145 added a comment to T94020: The labels and numbers in CX translation trend graph are not localized.

I don't understand how to format the date on the X-axis. If I have a variable that holds the date in the format "2001-1-1", how would I go about converting this into the wanted format?

Dec 13 2017, 2:27 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Language-2018-Jan-Mar, Google-Code-in-2017, WorkType-Maintenance, I18n, good first bug, ContentTranslation