In T220633#5244499, @matmarex wrote:

This doesn't seem to consistently work for the link inspector (…anymore?), because it changes the selection from collapsed to expanded when closing.

To reproduce the problem:

• Place a collapsed selection inside a link annotation
• Open link inspector
• Click "Done" to close link inspector
  
  Expected: deactivated expanded selection covering the link. Actual: it is activated.
  
  It also works correctly if you start from an expanded selection covering the link, or use the "Back" button to close the inspector.

@Esanders: So I checked it today after the fix, it seems to be working when you select a text anywhere in the document except the first line which I understand is tricky to handle since there is no more content at the top, there is just no place to scroll up to to make space for the context menu. So, assuming this is a special case, I am fine closing this ticket unless we want to handle that now.

Refreshing the page resolves the issue though.

@ppelberg: Sure! I am using iPhone 5s, safari.

In T221311#5259641, @Esanders wrote:

In T221311#5258166, @ppelberg wrote:

== Edit Card cut off ==
@Ryasmeen, during our initial testing, there was an instance where parts of the Edit Card were cut off. See how the link label, "Elizabeth f. Bennet", runs the "Change label" text off-screen in Screenshot A below?

I have not yet been able to reproduce this, but I wanted you to be aware of this potential issue.

I could reproduce this on smaller devices, and should be fixed in latest patches deployed to prototype.

@Esanders: I checked it on en.wiki

So the issue of cursor hiding behind the keyboard also happens if you just open link inspector and close it. You will loose the previous cursor position since the page abruptly scrolls down and will have to scroll down to find that position. Here is a screen capture showing that behavior:

@Esanders: Checked on a long article, still behaves the same.

Moving this to PM review, assuming the design question will be handled by @iamjessklein on Editing Design board.

In T223798#5209359, @waldyrious wrote:

@Ryasmeen please let me know if you need any details of my setup to be able to reproduce this issue. I'm happy to assist however I can.

I think this should be UBN since it blocks opening the editor, feel free to change the priority if you think otherwise.

@Esanders: when a user is switching from Wikitext editor to mobile VE, is it supposed to show the warning again?

I can't replicate this issue on Beta cluster.

@JTannerWMF: Nope, this is fine being on "Product own review", the regression was fixed a month ago. We were just talking about this retrospectively.

In T211240#5182701, @DLynch wrote:

@Ryasmeen -- Hard to discover that clicking the box will do something, you mean? Or hard to work out what the options within will do?

On mobile we only have this popup now -- I suggested removing the context item from desktop as well, for consistency and avoiding duplication, but Ed preferred removing it from mobile only. I figured that we could always remove it from desktop as well later, if we desired.

Also, with this change on desktop, now we have two ways to go into the Table properties dialog. Is that something useful for users or confusing?

Looks good functionality wise! :)

In T196839#5108151, @Neil_P._Quinn_WMF wrote:

In T196839#5108112, @Esanders wrote:

Deployed on prototype server: https://visualeditor-prototype.wmflabs.org/wiki/Pride_and_Prejudice

There is still a slight flicker whenever the cursor is placed anwhere past the first page of the document, but it is usually almost unnoticeable.

At least on my device (the Moto Z Play, a roughly three year old midrange phone), the flicker was fairly noticeable. But it absolutely works, and that's plenty considering the use share.

Thanks, @Esanders!

In T222489#5157048, @ppelberg wrote:

In T222489#5157031, @Ryasmeen wrote:

@ppelberg: Could you specify which article you were editing? I can't reproduce this on my sandbox on production, so assuming this is not a generic issue.

For sure – it was this article: https://en.m.wikipedia.org/wiki/List_of_regions_of_the_United_States (updated the task's description as well).

@ppelberg: Could you specify which article you were editing? I can't reproduce this on my sandbox on production, so assuming this is not a generic issue.

Thanks @Jdforrester-WMF!

This is now fixed! \o/

This hasn't been backported yet?

@Esanders: Found a new regression today on table cell selection while testing this: T221901