In T291307#7641789, @ppelberg wrote:

In T291307#7635168, @ppelberg wrote:

@Ryasmeen: please disregard the question I posed in T291307#7630898 for now.

Before we do any further testing of the bucketing criteria, @DLynch, @MNeisler, and I are making sure we have a shared understanding of what's been implemented to date. More context in Slack.

Alright, after talking with @DLynch and @MNeisler offline [i], I can confirm no changes are needed to the bucketing criteria that's currently been implemented.

I've updated the task description's ===Requirements > Bucketing Criteria section [ii] so that it matches what's been implemented.

---

i. https://wikimedia.slack.com/archives/G01625LGGQZ/p1642636849000100
ii. T291307#7641776

The original page that was mentioned on the task has been archived. So, clicking on the reply links for the talk page owner's comment does not open the Reply tool. But the reply link is appearing now which previously was not.
Also, checked on this page: https://en.wikipedia.org/wiki/User_talk:Czar, where the reply links are also appearing next to the the talk page owner's signature and the Reply tool is opening up when you click on them.

In T299114#7626981, @matmarex wrote:

That's an old demo and it can't be updated, can you test on the beta cluster instead? e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein?useskinversion=2&vectorstickyheader=1&vectorstickyheaderedit=1

Re-tested this. After the last two patches:

Tested at: https://patchdemo.wmflabs.org/wikis/557db5804f/w/index.php?title=Special:UserLogin&returnto=Douglas+Adams
This is still happening when I press the browser's back button in step 5.

In T295946#7574216, @matmarex wrote:

In T295946#7538905, @Ryasmeen wrote:

I assume, this approach would also avoid button text/label overflow when it's translated in some other languages?

Yes, I had to change how the text is laid out to fit "Edit preferences" on one line (it is now allowed to overlap the image slightly), which will also affect other languages. We shouldn't count on that though (users might use different fonts and text sizes), and everything is flexible so the dialog still looks okay with longer text.

Just to illustrate, I highlighted in pink the areas where the text is laid out:

Before	After

Example screenshot of the German translation, which has longer text:

Before	After

In T284836#7571423, @ppelberg wrote:

In T284836#7557854, @Ryasmeen wrote:

@ppelberg: FYI, the outstanding issues that are left fixing to close this task before next week's target of T295428 are:
T295946 and T295950.

Excellent and understood, @Ryasmeen.

Would it be accurate for us to think "1." and "2." below are accurate? If yes, I'm thinking we can resolve this task considering the additional work on the issues you've identified will happen in separate tickets (T295946 and T295950 ) and no remaining sub-tasks of this ticket remain open.

1. Automatic Topic Subscriptions QA review has been completed
2. QA has verified Automatic Topic Subscriptions are working as expected, save for the issues identified in T295946 and T295950

This has been reviewed as part of T284836, there is one design change that has been suggested by QA which is being tracked here: T295946. So, we can close this one.

Lowering the priority since we decided not to deploy it before the end of year break.

1. Users are getting bucketed to "control" or "test".
2. Accounts which used the new topic tool before, are not getting assigned to any buckets.

@ppelberg: FYI, the outstanding issues that are left fixing to close this task before next week's target of T295428 are:
T295946 and T295950.

In T295945#7513815, @matmarex wrote:

The bug was caused by a conflict between the patches for mobile support and the patches for auto topic subscriptions. We merged the mobile stuff first, and it changed the order of some operations after creating new talk page to work better on the mobile site, but the auto topic subscription stuff relied on the previous order and I didn't notice the issue before we merged that.

In T295945#7513762, @matmarex wrote:

I've ran into this today, the popup doesn't appear when creating a new page that did not exist before!

This matches with what Rummana wrote when reporting this initially:

Did not receive the pop-up that I got auto-subscribed after posting a new discussion on someone else's page for the first time after enabling automatic topic subscription.

…although "for the first time" was ambiguous, I assumed then that you meant that it was the first topic you posted anywhere after enabling the pref,

Now I'm hoping you meant that it was the first topic on a page that didn't exist, and that the issue I've seen is the same ;)

In T295946#7538425, @ppelberg wrote:

Going to move forward with "B."

@ppelberg: It was mentioned as intentional behavior on the team slack channel, when I raised it there.

In T293719#7499121, @alexhollender wrote:

@Ryasmeen thanks for your thorough review here

QA Review Status: