In T411114#11412142, @Esanders wrote:

The same applies on desktop. I think at some point we made this happen deliberately as we were planning on the revising state of the card being significantly different to the inital state, but we ended up with the two states being nearly identical but for the first button. Given that it probably makes sense to switch the card to the revising state as soon as the user starts typing.

@medelius: Indeed, it is.

Yeah, I figured it out later, thanks for updating the documentation.

@medelius : Could you share how the config file should be formatted to see this. I am not sure if I am setting it correctly here: https://en.wikipedia.beta.wmcloud.org/wiki/MediaWiki:Editcheck-config.json

@medelius: I was checking this on Beta cluster today. I am noticing every time I select an action (accept, dismiss, etc.) in the TextMatchEditCheck dialog, I see along with suggestion-action-delete, lot of other events with action: suggestion-shown-midedit being emitted again for other existing TextMatchEditCheck that's on the page.

Verified that the ignored-paste-[source] appears when paste-check is not activated in both a/b test and non a/b test wiki where the pasted content was long enough but source is currently one of googleDocs, libreOffice, microsoftOffice, plainText, and visualEditor.

This is really confusing as it gives no clue on where exactly is the error. Here is a screenshot of this scenario: after clicking on "Revise" from pre-save, it changes the button to "Recheck", no blue highlight for state state either on the paragraph which needs revising, the "Publish Changes" button is also disabled at this time.

Understood, thanks!

In T407301#11329908, @medelius wrote:

QA: I’ve been keeping this doc updated with notes on TextMatch. The Testing/Demoing instructions section might be particularly helpful for you. Please let me know if you have any questions that aren’t covered there.

The code normalizes both map-based queries (words + replacements) and array-based queries at the start, so I don't anticipate any behavioral difference between the two. However, testing both types is probably a good idea.

ah I see, that might be it.

Checked the following in en.wiki:

In T408436#11352391, @DLynch wrote:

If you have a config file that contains e.g.:

{
    "addReference": { enabled: true },
    "*": { enabled: false }
}

Then the add reference check should still be enabled. I'd need to see the exact version of the config file you were working with to comment on other possible causes.

Issue #3 : When I paste some content from external source that is also tone violating. If I don't move my cursor away from that paragraph (so, no Tone check get's triggered) but rather click on "Publish Changes", in the Pre-Save mode I see "Reference Check" and "Tone Check", but then when I click the back button I only see the "Paste Check".

In T402828#11164152, @DLynch wrote:

"In the same paragraph" is expected, because that's how declining works.

or, it might be happening if the pasted content is also tone violating, which my pasted content in the task description is. Your example is only activating paste check. I just checked with another example which does not trigger both tone check and paste check, and I don't see it happening there.

ok.. I see it. The difference is you are clicking on one of the reasons immediately after step 5. In my case, I waited a second and it was changing the state of both the buttons to disabled.

In T406164#11352281, @DLynch wrote:

Those seem like they'd be unrelated, and the other tickets exist already anyway, so either way we might as well close this one if you're satisfied with the basic "paste check shows immediately after a paste" behavior.

@DLynch: I noticed on Beta cluster that when I am adding this configuration "*": { enabled: false } it disables all the checks including the Reference Check which was (explicitly?) enabled in the config. Is the "explicitly enabled" in the task description meant checks that are made "Default-on"?

Is it fixed? I am still seeing only the pre-amble paragraph being highlighted as needing a reference :

@DLynch: Would you say the two issues filed above surfaced as a result of this fix, or should we close this?

Hmm, I am still seeing this. Are you going straight to "Undo" in step 4 after tapping on "No, remove it" in step 3? Because, if you tap somewhere else on the page to trigger tone check then this does not happen.

In T407543#11330136, @DLynch wrote:

@Ryasmeen Sorry, I must have misspoken there -- you need to have clicked a button in the check dialog to make it be considered "interacted".

The behavior has been now changed, testing notes has been updated to reflect the change that Paste Check will now appear in Pre-Save mode.

Also, T407426: On mobile: The pagination arrows disappear after undoing the removal of a pasted content

Found and filed an issue : https://phabricator.wikimedia.org/T407089, while testing this.

Checked the following in de.wiki and pl.wiki:

Chrome

I can still reproduce this the same way the screen capture shows. Make a selection as shown in the screenshot, Press delete which will remove the selection, press delete again which should remove the letter t, press delete again now it removes the letter t

This was tested via https://phabricator.wikimedia.org/T404914 & https://phabricator.wikimedia.org/T403768. David Lynch confirmed that the only thing that can’t currently be tested is the interaction with the a/b test, which should be overriding the on-wiki config.

In T402828#11164152, @DLynch wrote:

"In the same paragraph" is expected, because that's how declining works.

Checked both for Adverb Usage and Paste Check, no more stale/revising state with blue borders while revising, stays yellow instead.

I checked the fix for some scenarios that involves both mid-edit and pre-save trigger of tone check and verified that the tag editcheck-tone-shown is getting applied for both mid-edit and pre-save.

In T404661#11183134, @DLynch wrote:

Observe that in the Pre-Save stage there are three checks now.

I only see one check. Can you provide more details here?