Thu, Aug 16
Wed, Aug 15
So it seems the second issue of up arrow skipping the cells in between and moving to the caption field or to the preceding content is almost fixed. I see a flickering cursor in those positions still but that's negligible I suppose or not :) I am marking this issue verified from my side anyways.
Tue, Aug 14
Thu, Aug 9
@matmarex: I don't think it's a major issue but I still feel slightly odd about this design having a textfield with focus highlight and a disabled action button right next to it. I did like @DLynch's third suggestion which makes the button look like part of a same unit at-least.
Verified on Beta cluster.
@Jdlrobson: I see, yeah that makes sense. There was indeed no search results when I typed the first two characters fast, and therefore I got only 1 api request for watchstar and 1 for results, even though I typed three characters.
Wed, Aug 8
@matmarex: Ah! This is about OWE. Thanks for clarifying that :)
@Jdlrobson: Was checking this on Beta cluster. Couple of questions:
I can't reproduce this anywhere Beta cluster/production following the steps mentioned. So not sure how can I verify the fix in this case.
@ovasileva: Sure, check these two articles for instance: https://en.m.wikipedia.beta.wmflabs.org/wiki/Bear or https://en.m.wikipedia.beta.wmflabs.org/wiki/Bearded_seal
Tue, Aug 7
Followed the steps mentioned in T199011 to verify this, not getting this error anymore.
Checked and verified that no more slugs appearing in the space for caption and the highlight is covering the entire gallery. Same for non gallery images.
@ABorbaWMF: Just wanted to mention that this seems to be not working on Beta cluster yet, some of the articles on Beta still has infobox as the first thing instead of the lead paragraph. So, I don't know if the fix has landed on Beta yet, but I was going to mark it as "Done" after verifying it on all other environments. Do you move tasks to Done column as soon as it's working on staging or when it is verified on all environments? Also, if/when you do verify tasks in other environments, how do you usually keep track of which environments it's been tested on?
Fri, Aug 3
@Jdlrobson: Tested the fix on the articles mentioned under QA steps in staging environment. As for checking it on some random articles, on staging I am finding it difficult to find one with lead paragraph/infobox in it. Is it on Beta cluster yet? I could then search for some more random articles and check on those.
Verified on these articles: http://reading-web-staging.wmflabs.org/wiki/Copenhagen and http://reading-web-staging.wmflabs.org/wiki/Albert_Einstein. Good to go.
Wed, Aug 1
@matmarex: No worries! :) Just tested this. Seems fixed for all cases. Thanks!
This issue also got fixed with T196521.
Tue, Jul 31
@matmarex: It's alright :)
I am still getting the error on this page though: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:RYasmeen_(WMF)/sandbox&oldid=382759
@ovasileva: Tested it on a iPhone5s following the steps mentioned. Seems to be working fine for me, that section link does redirect to the correct section of the article.
@matmarex: is this ready for testing on Beta cluster?
Mon, Jul 30
Yup, got fixed it seems.
Sat, Jul 28
I tried to reproduce this in other environments but couldn't. However, this is happening consistently on my sandbox here: https://en.wikipedia.beta.wmflabs.org/wiki/User:RYasmeen_(WMF)?veaction=edit
Fri, Jul 27
Checked it on this page: https://readers-web-master.wmflabs.org/wiki/Syracuse,_Sicily. Looks good to me.
Thu, Jul 26
Okay, this time I finally got bucketed to get "page issues" link rendered under the heading. So marking it as verified.
@matmarex: Can you try it on this page: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:RYasmeen_(WMF)/sandbox&redirect=no&veaction=edit
@matmarex: Actually I can't even add any text there even if I click on them directly. There is just no cursor to insert anything.
See this screenshot without the blue highlight preventing it.
Wed, Jul 25
Sat, Jul 21
Thu, Jul 19
@Jdlrobson: So I see now http://reading-web-staging.wmflabs.org/wiki/Talk:Sandwich has "About this Page" link and it takes me to issues page and there is no empty rows on that issues page.
@Jdlrobson: I don't see this Mobile Preferences option in the user preferences - appearance section on reading-web-staging or on beta cluster, where should I test it?
Checked all the acceptance criteria except the last one, and they are passing.
Jul 18 2018
Jul 17 2018
Happens on the media search panel too, while inserting an image.
I see a different error now though while doing the same and in fact now it does not even switch to the option "Don't use machine translation" anymore.
@Deskana: Just checked this on production, and from my own first time user experience, I initially thought that the "Change label" button was not working because the context menu stayed open without any visual change. It feels that the text selection being enabled in the document is so subtle to notice, compared to an open dialog.
Jul 16 2018
Jul 13 2018
Verified this issue on production. Looks good to me. However, found another issue with page previews while testing this, filed as T199508.