In T343183#9682706, @cchen wrote:

In wikistories_consumption_event, referrer_type = "shared_link" if the story view or story impression is from a shared link

• No events were found in the table using the following query. and the referrer_type column is NULL for all the events.

In T356529#9692035, @SGautam_WMF wrote:

In T356529#9669000, @SBisson wrote:

@SGautam_WMF what do you think about the icon contrast issue reported above?

Sorry for late reply, is it possible for us to invert it or shall I provide dark mode friendly icon for this case?

@SGautam_WMF what do you think about the icon contrast issue reported above?

@cchen The schema change is here: https://gerrit.wikimedia.org/r/1006060 Please review so it can eventually be merged and deployed. Thanks!

Yes. I saw those classes but I wasn't sure if they were too "internal" for us to use.

@Jdlrobson What if we need to hardcode different custom colors for day and night modes, what would be the preferred way?

I approve but I am not @GMikesell-WMF's manager. That woul probably be @Jrbranaa

@Jdlrobson is there an official mechanism for us to specify light and dark colors for those special cases where we're not using existing variables? The yellow highlighting above is one such example.

@SGautam_WMF this is what the text highlight currently looks like in day and night modes:

Hi @Jdlrobson, we have a notice component with background-color: @background-color-notice-subtle. This is what it looks like in day and night reading modes:

In T343183#9573633, @cchen wrote:

@SBisson can we keep both dt and meta.dt?

So, pending @cchen opinion, the proposed changes would be

• add activity_session_id to the contribution schema and keep it populated in the code
• Add dt to the contribution schema and let it be populated by MetricsClient
• Stop populating meta.dt on the client since this is supposed to be server time
• Possibly add dt to the consumption schema and disallow additional properties to follow the guidelines

@mpopov Thanks for the troubleshooting!

@SGautam_WMF what do you think of the various wordmarks in the images above? If you think they are OK we can resolve this task.

In T356529#9565782, @Jdlrobson wrote:

@SBisson is this something your team can pick up once we get you some advice about how to address the icon problem? (I'm hoping to have a solution by the end of the week).

Indeed this looks better but I see a number of things that aren't quite right in the story viewer and builder. Mostly white text on white background. I'll troubleshoot it locally and make sure we are using all the right design tokens at the right place.
The other thing I see is icons that would need to be inverted. Is there a built-in solution that we can opt into? What is the preferred solution?

The gallery is indeed surprisingly broken when the window is resized. I think this is worth figuring out why and fixing the CSS a little.

I would like us to revisit this issue.

We don't have the (i) icon anymore so this is moot

Hi @cchen, I just tried the share option from the story viewer and I could see the event going out. However, due to the use of the hasty parameter I don't know if it was properly accepted by the backend. Is there a place you can check for events that failed schema validation?

@SGautam_WMF The documentation seem to indicate that it should be possible to set the commands dynamically and for each users individually to add/remove the unsubscribe option based on the status of the user but I cannot get it to work. However, it would be simple to change the /unsubscribe response message based on if the user was active or not. Do you think that would help?

https://github.com/wikimedia/wikipediapreview-wordpress/pull/106

https://github.com/wikimedia/wikipediapreview-wordpress/pull/108

https://github.com/wikimedia/wikipediapreview-wordpress/pull/107

In T345056#9536647, @SGautam_WMF wrote:

Do we have a list of languages for which we are using local wordmarks? As of now I have only provided one for the english one but can do the same for other languages too.

https://github.com/wikimedia/wikipediapreview-wordpress/pull/105

This is how I added a custom post type to reproduce the issue:

function wpwpp_custom_post_type() {
	register_post_type('wpwpp_product',
		array(
			'labels'      => array(
				'name'          => __('Products', 'textdomain'),
				'singular_name' => __('Product', 'textdomain'),
			),
			'public'      => true,
			'has_archive' => true,
			'excerpt', 'comments',
			'show_in_rest' => true,
			'supports' => array( 'title', 'editor', 'author', 'thumbnail', 'excerpt', 'comments')
		)
	);
}
add_action('init', 'wpwpp_custom_post_type');

Regression only please

Done and deployed

Can't find a way to know that the chant has been delete so I just implemented an explicit /unsubscribe command

In T352325#9434740, @SGautam_WMF wrote:

This works as expected. Dropping some comments related to the improvements of the task.

• Can we fix some styles to increase the visibility of search interface?

FAQ section has been updated and deployed: https://wordpress.org/plugins/wikipedia-preview/

Parking this in "code review" until I can schedule and execute the config deployment

The default language of the UI is english but you can use the spanish data by adding the lang=es url param: https://wiki-sub-rec.toolforge.org/?lang=es

Hi @sbassett I see in the Wikipedia Preview analysis that a "Policy/Methods for reporting security issues" is missing and that is listed as medium. Could you advice on how to address this?