Page MenuHomePhabricator

SBisson (Stephane Bisson)
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 6 2015, 8:49 PM (223 w, 3 d)
Availability
Available
IRC Nick
stephanebisson
LDAP User
Unknown
MediaWiki User
Sbisson (WMF) [ Global Accounts ]

Recent Activity

Yesterday

SBisson moved T228417: RevisionFormatter.php: Unknown content format from Incoming to Code Review on the Growth-Team (Current Sprint) board.
Thu, Jul 18, 4:15 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Growth-Team (Current Sprint), StructuredDiscussions, Wikimedia-production-error
SBisson edited projects for T228417: RevisionFormatter.php: Unknown content format, added: Growth-Team (Current Sprint); removed Growth-Team.
Thu, Jul 18, 4:15 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Growth-Team (Current Sprint), StructuredDiscussions, Wikimedia-production-error
SBisson merged task T228406: TopicListBlock.php sort order params into T211798: [{exception_id}] {exception_url} Flow\Exception\FlowException from line 397 of /srv/mediawiki/php-1.33.0-wmf.8/extensions/Flow/includes/Block/TopicListBlock.php: The `newest` sort order does not allow the `offset` parameter. Please use `offset-id`.
Thu, Jul 18, 3:49 PM · StructuredDiscussions, Growth-Team, Wikimedia-production-error
SBisson merged T228406: TopicListBlock.php sort order params into T211798: [{exception_id}] {exception_url} Flow\Exception\FlowException from line 397 of /srv/mediawiki/php-1.33.0-wmf.8/extensions/Flow/includes/Block/TopicListBlock.php: The `newest` sort order does not allow the `offset` parameter. Please use `offset-id`.
Thu, Jul 18, 3:49 PM · Growth-Team, StructuredDiscussions
SBisson added a comment to T228406: TopicListBlock.php sort order params.

This is probably a duplicate of T211798, right?

Thu, Jul 18, 3:48 PM · StructuredDiscussions, Growth-Team, Wikimedia-production-error
SBisson added a comment to T228425: User.php: Cannot create a user with no name, no ID, and no actor ID.

So after all, maybe the exception is reported because the parameter has been deprecated.

Thu, Jul 18, 2:36 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Recent-changes, MediaWiki-API, Wikimedia-production-error
SBisson added a comment to T228425: User.php: Cannot create a user with no name, no ID, and no actor ID.

I don't know what's happening here but the rctoken parameter is deprecated.

Thu, Jul 18, 2:29 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Recent-changes, MediaWiki-API, Wikimedia-production-error
SBisson added a comment to T228406: TopicListBlock.php sort order params.

This is strangely similar to T228417: RevisionFormatter.php: Unknown content format

Thu, Jul 18, 1:15 PM · StructuredDiscussions, Growth-Team, Wikimedia-production-error
SBisson added a comment to T228417: RevisionFormatter.php: Unknown content format.

Correction: This is not an API call but the GET request to start editing a topic title in the non-javascript experience.

Thu, Jul 18, 1:01 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Growth-Team (Current Sprint), StructuredDiscussions, Wikimedia-production-error
SBisson claimed T228417: RevisionFormatter.php: Unknown content format.

The request URL above is invalid. I'll investigate whether this is wrongly generated by the UI or if someone or something is sending garbage. In any case, this should be rejected at the API layer and not go this deep into the Flow stack.

Thu, Jul 18, 12:33 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Growth-Team (Current Sprint), StructuredDiscussions, Wikimedia-production-error

Tue, Jul 16

SBisson moved T212433: Help panel: adapt for StructuredDiscussions from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Jul 16, 6:17 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
SBisson moved T227109: Homepage: mobile start preview word length issues from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Jul 16, 10:42 AM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Growth-Team (Current Sprint), I18n, GrowthExperiments, GrowthExperiments-Homepage
SBisson moved T226681: EchoMentionInSummaryPresentationModel: PHP error "Cannot access property on non-object" from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Jul 16, 10:42 AM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Growth-Team (Current Sprint), Patch-For-Review, Notifications, Wikimedia-production-error
SBisson moved T151391: Flow\ReferenceClarifier::getObjectLink: Unknown $objectType: post-summary from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Jul 16, 10:42 AM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Growth-Team (Current Sprint), StructuredDiscussions
SBisson assigned T151391: Flow\ReferenceClarifier::getObjectLink: Unknown $objectType: post-summary to Catrope.
Tue, Jul 16, 10:42 AM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Growth-Team (Current Sprint), StructuredDiscussions

Mon, Jul 15

SBisson moved T227535: Homepage Mentorship - issues with parsing mentor added descriptions from Code Review to QA on the Growth-Team (Current Sprint) board.
Mon, Jul 15, 7:38 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Growth-Team (Current Sprint), GrowthExperiments
SBisson moved T205191: AbstractFormatter.php: Undefined index: time from Code Review to QA on the Growth-Team (Current Sprint) board.
Mon, Jul 15, 7:21 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Growth-Team (Current Sprint), StructuredDiscussions, Wikimedia-production-error
SBisson moved T227762: Homepage: add module icons to desktop version of the homepage (desktop) from Code Review to QA on the Growth-Team (Current Sprint) board.
Mon, Jul 15, 6:51 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Desktop, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson updated subscribers of T228087: Archive the Copyvio extension.
Mon, Jul 15, 6:31 PM · Growth-Team, MediaWiki-extensions-Other, Other-skins, GitHub-Mirrors, Repository-Admins, Cleanup
SBisson added a comment to T228087: Archive the Copyvio extension.

I was starting to think about all the places that need to be cleaned up... I'm glad there's a template!

Mon, Jul 15, 6:31 PM · Growth-Team, MediaWiki-extensions-Other, Other-skins, GitHub-Mirrors, Repository-Admins, Cleanup
SBisson awarded T228087: Archive the Copyvio extension a Like token.
Mon, Jul 15, 6:30 PM · Growth-Team, MediaWiki-extensions-Other, Other-skins, GitHub-Mirrors, Repository-Admins, Cleanup
SBisson added a comment to T227983: [Copyvio] RecentChangesHookHandlerTest::testHandle_hookForceCheck failing.

This extension was started but then abandoned in favor of a simpler approach to Copyvio in PageTriage. It should be archived.

Mon, Jul 15, 6:24 PM · ci-test-error, MediaWiki-extensions-Other

Fri, Jul 12

SBisson moved T226113: Homepage: make username blue when rewired to redirect to the Homepage from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Fri, Jul 12, 7:23 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Growth-Team (Current Sprint), GrowthExperiments-Homepage, Desktop, GrowthExperiments- HomepageDiscovery
SBisson claimed T226113: Homepage: make username blue when rewired to redirect to the Homepage.
Fri, Jul 12, 7:08 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Growth-Team (Current Sprint), GrowthExperiments-Homepage, Desktop, GrowthExperiments- HomepageDiscovery
SBisson claimed T225560: Homepage: mobile preview when calculating.
Fri, Jul 12, 6:01 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Mobile, GrowthExperiments, Growth-Team (Current Sprint)
SBisson assigned T205191: AbstractFormatter.php: Undefined index: time to Catrope.
Fri, Jul 12, 5:55 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Growth-Team (Current Sprint), StructuredDiscussions, Wikimedia-production-error
SBisson assigned T227575: Homepage: link from Special:Contributions (mobile) to Catrope.
Fri, Jul 12, 5:55 PM · MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Mobile, GrowthExperiments- HomepageDiscovery, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson claimed T227819: [wmf.13] Impact module: the tooltip displayed cut off.
Fri, Jul 12, 2:12 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), GrowthExperiments- ImpactModule , GrowthExperiments, Growth-Team (Current Sprint), GrowthExperiments-Homepage
SBisson added a comment to T227819: [wmf.13] Impact module: the tooltip displayed cut off.

This could do the job:

.empty-pageviews {
    white-space: normal;
    text-align: left;
}

It does! This is a relic of when we had "--" instead of the icon. We needed to make sure it was pushed to the right and that both dashes were on the same line. Both are irrelevant now that we have the icon. Also the values above are default for those properties so removing them completely works fine.

Fri, Jul 12, 2:08 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), GrowthExperiments- ImpactModule , GrowthExperiments, Growth-Team (Current Sprint), GrowthExperiments-Homepage
SBisson merged task T227229: Homepage: impact tooltip cut off in Arabic into T227819: [wmf.13] Impact module: the tooltip displayed cut off.
Fri, Jul 12, 2:05 PM · GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson merged T227229: Homepage: impact tooltip cut off in Arabic into T227819: [wmf.13] Impact module: the tooltip displayed cut off.
Fri, Jul 12, 2:05 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), GrowthExperiments- ImpactModule , GrowthExperiments, Growth-Team (Current Sprint), GrowthExperiments-Homepage
SBisson added a comment to T220146: Growth: help users understand where to find responses (desktop).

According to the history for the "Help desk alerts" message, it was translated on Tuesday July 9th at 11:04, which is too late to make the train. It should have been done on the Monday.

Fri, Jul 12, 1:26 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), Wikimedia-Hackathon-2019 (Newcomer friendly), GrowthExperiments

Thu, Jul 11

SBisson moved T212433: Help panel: adapt for StructuredDiscussions from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Thu, Jul 11, 2:58 PM · MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments

Fri, Jul 5

SBisson moved T226076: Homepage: "Invalid parameters" for Pageviews from Impact module from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Fri, Jul 5, 7:33 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), GrowthExperiments-Homepage
SBisson added a comment to T226076: Homepage: "Invalid parameters" for Pageviews from Impact module.

@MusikAnimal Thanks for enhancing the pageviews tools this way! This is really helpful and simplifies the way we build the URLs.

Fri, Jul 5, 7:33 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), GrowthExperiments-Homepage

Thu, Jul 4

SBisson moved T225668: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89 from Code Review to QA on the Growth-Team (Current Sprint) board.
Thu, Jul 4, 5:45 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), Mobile, GrowthExperiments-StartModule, GrowthExperiments-Homepage
SBisson moved T220145: Homepage Mentorship: allow mentors to configure their presentation from Code Review to QA on the Growth-Team (Current Sprint) board.
Thu, Jul 4, 1:50 PM · GrowthExperiments- MentorshipModule, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), Wikimedia-Hackathon-2019, GrowthExperiments
SBisson moved T225668: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89 from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Thu, Jul 4, 1:47 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), Mobile, GrowthExperiments-StartModule, GrowthExperiments-Homepage

Wed, Jul 3

SBisson moved T226076: Homepage: "Invalid parameters" for Pageviews from Impact module from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
Wed, Jul 3, 5:25 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), GrowthExperiments-Homepage
SBisson moved T225668: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89 from Code Review to In Progress on the Growth-Team (Current Sprint) board.
Wed, Jul 3, 4:25 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), Mobile, GrowthExperiments-StartModule, GrowthExperiments-Homepage

Fri, Jun 21

SBisson claimed T226076: Homepage: "Invalid parameters" for Pageviews from Impact module.
Fri, Jun 21, 2:31 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), GrowthExperiments-Homepage
SBisson claimed T225668: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89.
Fri, Jun 21, 2:14 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), Mobile, GrowthExperiments-StartModule, GrowthExperiments-Homepage
SBisson moved T222833: Mobile Homepage: Show module details in a mobile overlay from In Progress to Code Review on the Growth-Team (Current Sprint) board.

Thanks, @Cntlsn. That alignment is not a blocker for release, but is an important design element that we should fix. I am moving this to "In Progress".

Fri, Jun 21, 1:59 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson assigned T226112: Homepage: mobile homepage and user page auto scroll down (on iOS Safari 10 and iOS Chrome 60.0.3112.89) to Catrope.

@Catrope do you want to tweak your patch to also address T223142#5270492?

Fri, Jun 21, 1:49 PM · Mobile, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson moved T226147: Homepage: impact clock icon issues on mobile from Ready for Development to Code Review on the Growth-Team (Current Sprint) board.
Fri, Jun 21, 1:45 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Mobile, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson added a comment to T223142: Homepage: mobile tab scrolling.

You could try storing the page's Y scroll offset then immediately restoring it after the tab scroll.

Fri, Jun 21, 12:40 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Mobile, GrowthExperiments-Homepage, Growth-Team (Current Sprint)

Thu, Jun 20

SBisson moved T225661: Homepage: link to "Guidelines for user pages" leads to desktop version from Code Review to Needs PM Review on the Growth-Team (Current Sprint) board.
Thu, Jun 20, 7:34 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments-StartModule, Mobile
SBisson moved T226208: Homepage: do not log HomepageVisit when handling tutorial visit POST requests from Code Review to QA on the Growth-Team (Current Sprint) board.
Thu, Jun 20, 7:34 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments
SBisson added a comment to T225661: Homepage: link to "Guidelines for user pages" leads to desktop version.

@Cntlsn and I tested this together and the patch above (or some other solution) is needed for the link to correctly land on the mobile version on his phone.

Thu, Jun 20, 3:59 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments-StartModule, Mobile
SBisson added a comment to T223142: Homepage: mobile tab scrolling.

The dynamic scrolling of the tab area is fragile. It worked with the devices I tested but seem to cause T226112 on @Cntlsn's phone.

Thu, Jun 20, 2:44 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Mobile, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson added a comment to T226147: Homepage: impact clock icon issues on mobile.

@Volker_E Thanks for clarifying. This question comes up all the time.

Thu, Jun 20, 1:55 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Mobile, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson added a comment to T226146: Homepage: minor mobile instrumentation issues.

When I clicked the button to start the tutorial in the tutorial module, I got a link-click event in the HomepageModule schema, and I also got a HomepageVisit event with referer_route = 'other'. This happened both times I tried it. And another time, I clicked browser refresh on the start module overlay, and I got a HomepageVisit event with referer_route = 'personaltoolslink'.

Thu, Jun 20, 1:53 PM · GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson added a comment to T225660: Homepage: recent questions links on mobile go to desktop site.
Thu, Jun 20, 1:42 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson added a comment to T216220: Homepage: design for indicating that the user should check back for pageviews.

Is this still "In Progress"? Or have we kept it here because we still have open questions on whether it will be a dialog or a toast on mobile?

Exactly. Do we have a final decision on this? If not we can make a separate task and send it to be backlog.

Thu, Jun 20, 1:39 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, GrowthExperiments-Homepage, Growth-Team (Current Sprint)

Wed, Jun 19

SBisson added a comment to T225660: Homepage: recent questions links on mobile go to desktop site.

@Cntlsn and I tested this and he confirmed the fix on betalabs with his phone. New questions posted today correctly navigate to the mobile site while older questions (before the fix) redirect him to the desktop site.

Wed, Jun 19, 11:00 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson moved T225661: Homepage: link to "Guidelines for user pages" leads to desktop version from In Progress to Code Review on the Growth-Team (Current Sprint) board.

@Cntlsn and I tested this together and the patch above (or some other solution) is needed for the link to correctly land on the mobile version on his phone.

Wed, Jun 19, 10:56 AM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments-StartModule, Mobile

Jun 18 2019

SBisson moved T225659: Homepage: different paths to User talk depending on origin tab from In Progress to Code Review on the Growth-Team (Current Sprint) board.

@Catrope had the brilliant idea to use wgRelevantPageTitle for this. Let's hope it's acceptable on the Minerva side.

Jun 18 2019, 7:53 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson claimed T225659: Homepage: different paths to User talk depending on origin tab.
Jun 18 2019, 7:30 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson moved T226033: Fix loading icons for Start module from Ready for Development to Code Review on the Growth-Team (Current Sprint) board.
Jun 18 2019, 4:27 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), GrowthExperiments-Homepage
SBisson moved T225660: Homepage: recent questions links on mobile go to desktop site from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Jun 18 2019, 1:13 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson moved T222836: Mobile Homepage: instrumentation from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Jun 18 2019, 1:01 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson added a comment to T222836: Mobile Homepage: instrumentation.

Until yesterday we only had the basic server-side version of the mobile homepage so the instrumentation was complete.

Jun 18 2019, 10:40 AM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)

Jun 17 2019

SBisson moved T222833: Mobile Homepage: Show module details in a mobile overlay from In Progress to QA on the Growth-Team (Current Sprint) board.
Jun 17 2019, 7:38 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson added a comment to T225665: Homepage: open user and user talk in reading mode from mobile.

(2) Discussion tab - Talk page opens in editor:

This is what we usually call the "talk overlay"

Jun 17 2019, 5:06 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage

Jun 14 2019

SBisson moved T225661: Homepage: link to "Guidelines for user pages" leads to desktop version from Code Review to In Progress on the Growth-Team (Current Sprint) board.
Jun 14 2019, 7:20 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments-StartModule, Mobile
SBisson moved T225660: Homepage: recent questions links on mobile go to desktop site from Code Review to In Progress on the Growth-Team (Current Sprint) board.
Jun 14 2019, 7:20 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson added a comment to T225659: Homepage: different paths to User talk depending on origin tab.

@MMiller_WMF Which one of the two options described in the task description do we want, navigating to the talk page (1st option) or opening the talk overlay (2nd option)?

Jun 14 2019, 5:47 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson moved T223142: Homepage: mobile tab scrolling from In Progress to Code Review on the Growth-Team (Current Sprint) board.

The patch above makes the tabs scrollable in Minerva. If this is undesirable in AMC in general, I can move this code to GrowthExperiments so it applies only when the Homepage is enabled in the userspace (homepage, userpage, talk).

Jun 14 2019, 5:44 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Mobile, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson claimed T223142: Homepage: mobile tab scrolling.
Jun 14 2019, 2:47 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Mobile, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson added a comment to T223142: Homepage: mobile tab scrolling.

If we can't easily get the initial scroll position right, based on the selected tab, another option is to force all tabs on one line but allow each tab label to wrap. Here's what it looks like in Czech:

Jun 14 2019, 12:57 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Mobile, GrowthExperiments-Homepage, Growth-Team (Current Sprint)

Jun 13 2019

SBisson moved T225665: Homepage: open user and user talk in reading mode from mobile from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Jun 13 2019, 8:44 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson claimed T225665: Homepage: open user and user talk in reading mode from mobile.
Jun 13 2019, 7:58 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson added a comment to T225665: Homepage: open user and user talk in reading mode from mobile.

Do we want to change this only for mobile? Do we want the desktop tabs to open the editor (like regular redlinks)?

Jun 13 2019, 7:55 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson added a comment to T216220: Homepage: design for indicating that the user should check back for pageviews.

@SBisson @kostajh -- please hold off on this task until we hear more from @Cntlsn, who is talking about it with some other designers.

Jun 13 2019, 6:00 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson added a comment to T225663: Homepage: add sub-header text about user longevity to mobile homepage.

@Niedzielski Thanks for the suggestion. I'm not sure adding isSpecialHomepage() to SkinMinerva is going to be a popular option though. Would adding a skin option showTagline be practical here? It would be similar to how we include the AMC tabs.

Jun 13 2019, 5:14 PM · Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson claimed T225666: Homepage: mobile header style.
Jun 13 2019, 5:11 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson closed T225346: Mobile homepage not fully responsive in Czech as Resolved.

Please re-open if you see it again.

Jun 13 2019, 2:53 PM · Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments, Mobile
SBisson closed T225346: Mobile homepage not fully responsive in Czech, a subtask of T215983: Homepage: mobile version, as Resolved.
Jun 13 2019, 2:53 PM · Patch-For-Review, Epic, GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson closed T225346: Mobile homepage not fully responsive in Czech, a subtask of T225676: Homepage: mobile MVP list, as Resolved.
Jun 13 2019, 2:53 PM · Epic, GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson added a comment to T225346: Mobile homepage not fully responsive in Czech.

I can't reproduce that on my phone or Chrome in mobile mode with various resolutions. @Urbanecm can you still reproduce the issue? If so, could you specify which browser and which resolution you used? Thanks

Jun 13 2019, 2:47 PM · Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments, Mobile
SBisson added a comment to T225668: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89.

@Cntlsn It is possible to connect from Safari on your composer to Safari on your phone to inspect the DOM (@kostajh can provide the details on how to do it). It would be great if you could have a look at what is going on there.

Jun 13 2019, 2:36 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), Mobile, GrowthExperiments-StartModule, GrowthExperiments-Homepage
SBisson updated subscribers of T225663: Homepage: add sub-header text about user longevity to mobile homepage.

Pinging @Jdlrobson, @Niedzielski, @pmiazga Is there a simple way to display the userpage "tagline" on Special:Homepage?

Jun 13 2019, 2:33 PM · Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson added a comment to T225661: Homepage: link to "Guidelines for user pages" leads to desktop version.

I'm not able to reproduce this on betalabs.

Jun 13 2019, 2:28 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Homepage, GrowthExperiments-StartModule, Mobile
SBisson added a comment to T225660: Homepage: recent questions links on mobile go to desktop site.

I'm not able to reproduce this on betalabs.

Jun 13 2019, 2:28 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson moved T225660: Homepage: recent questions links on mobile go to desktop site from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Jun 13 2019, 2:09 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson added a comment to T216220: Homepage: design for indicating that the user should check back for pageviews.

If the toast is more adherent to our design standards than the dialog, then I agree we should change to that (sorry about the changing specification here, @SBisson). The text should be: "Pageviews have not yet been calculated. Check back tomorrow!"

Jun 13 2019, 1:36 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Patch-For-Review, GrowthExperiments-Homepage, Growth-Team (Current Sprint)

Jun 12 2019

SBisson claimed T225660: Homepage: recent questions links on mobile go to desktop site.
Jun 12 2019, 8:29 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson edited projects for T225660: Homepage: recent questions links on mobile go to desktop site, added: Growth-Team (Current Sprint); removed Growth-Team.
Jun 12 2019, 8:28 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson added a comment to T225288: [mobile] Homepage UX/UI issues.

@MMiller_WMF I've updated the task description with links to all the tasks that I've created. Once you've triaged them, I think this task can be closed as invalid or something.

Jun 12 2019, 7:26 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Homepage
SBisson added a comment to T225669: Homepage: "ask a question" dialog and overlay issues.

In T225288#5254213, @JTannerWMF wrote:
It was recommended by @SBisson revisiting work on the Help Panel on desktop in interest of standardization during the Growth team Grooming session.

Jun 12 2019, 7:25 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Help panel, GrowthExperiments- MentorshipModule, GrowthExperiments- HelpModule, Mobile, GrowthExperiments-Homepage
SBisson updated subscribers of T225669: Homepage: "ask a question" dialog and overlay issues.

In T225288#5254200, @JTannerWMF wrote:
@Cntlsn will interlock with @Volker_E . @Catrope and @MMiller_WMF will strategize how to ensure modals align technically, which may include needing to meet with VE and/or Readers Web.

Jun 12 2019, 7:24 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Help panel, GrowthExperiments- MentorshipModule, GrowthExperiments- HelpModule, Mobile, GrowthExperiments-Homepage
SBisson updated the task description for T225288: [mobile] Homepage UX/UI issues.
Jun 12 2019, 7:22 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Homepage
SBisson created T225669: Homepage: "ask a question" dialog and overlay issues.
Jun 12 2019, 7:19 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments-Help panel, GrowthExperiments- MentorshipModule, GrowthExperiments- HelpModule, Mobile, GrowthExperiments-Homepage
SBisson added a comment to T225668: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89.

@kostajh Roan and I have android phones... could you have a quick look?

Jun 12 2019, 7:16 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), Mobile, GrowthExperiments-StartModule, GrowthExperiments-Homepage
SBisson created T225668: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89.
Jun 12 2019, 7:16 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Growth-Team (Current Sprint), Mobile, GrowthExperiments-StartModule, GrowthExperiments-Homepage
SBisson created T225667: Homepage: mobile submodule headers.
Jun 12 2019, 7:13 PM · Growth-Team (Current Sprint), GrowthExperiments-StartModule, Mobile, GrowthExperiments-Homepage
SBisson created T225666: Homepage: mobile header style.
Jun 12 2019, 7:12 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson created T225665: Homepage: open user and user talk in reading mode from mobile.
Jun 12 2019, 7:10 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson created T225663: Homepage: add sub-header text about user longevity to mobile homepage.
Jun 12 2019, 7:08 PM · Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage
SBisson created T225662: Homepage: tabbed menu should have border bottom.
Jun 12 2019, 7:07 PM · Growth-Team (Current Sprint), Mobile, GrowthExperiments-Homepage