SBisson (Stephane Bisson)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 6 2015, 8:49 PM (150 w, 3 d)
Availability
Available
IRC Nick
stephanebisson
LDAP User
Unknown
MediaWiki User
Sbisson (WMF)

Recent Activity

Today

SBisson moved T184952: [wmf.15] Related changes page: the warning "The given page title is invalid..." is out of sync with the page content from Code Review Started to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Fri, Feb 23, 1:14 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters

Yesterday

SBisson moved T170347: [minor] Page curation: 'Marked as reviewed' message should be truncated when displayed on Special:Notifications from Needs Review to Code Review Started on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

The patch above (which I've just +2) is truncating the 'note' during event production. It's great for the future and for storage but it leaves all the old notifications too long.

Thu, Feb 22, 11:44 AM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), MediaWiki-extensions-PageCuration, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collab-Notifications-Page

Wed, Feb 21

Vachovec1 awarded T187757: Thanks thanking the wrong edit a Cup of Joe token.
Wed, Feb 21, 9:28 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice, Thanks
SBisson moved T179626: [minor] Truncate/filter Tag filter descriptions from Code Review Started to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Wed, Feb 21, 1:07 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), User-notice-collaboration, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-RC-Page

Tue, Feb 20

Davey2010 awarded T187757: Thanks thanking the wrong edit a Cup of Joe token.
Tue, Feb 20, 11:09 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice, Thanks
Coffee awarded T187757: Thanks thanking the wrong edit a Cup of Joe token.
Tue, Feb 20, 11:06 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice, Thanks
SBisson moved T187757: Thanks thanking the wrong edit from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Tue, Feb 20, 6:23 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice, Thanks
SBisson added a comment to T187411: Get kartotherian/kartotherian@master working with its dependencies (kartotherian/*) @master.
packageprod versioncommits after prod version
@kartotherian/core0.0.238
@kartotherian/server0.0.175
@kartotherian/autogen0.0.100
@kartotherian/babel0.0.78
@kartotherian/cassandra0.0.126
@kartotherian/postgres0.0.101
@kartotherian/demultiplexer0.0.101
@kartotherian/layermixer0.0.80
@kartotherian/overzoom0.0.105
@kartotherian/substantial0.0.85
@kartotherian/tilelive-http0.12.10
@kartotherian/osm-bright-source0.0.50
@kartotherian/osm-bright-style2.1.40
@kartotherian/geoshapes0.0.130
@kartotherian/maki0.0.100
@kartotherian/snapshot0.3.41
@kartotherian/err0.0.31
@kartotherian/input-validator0.0.60
@kartotherian/module-loader0.0.41
Tue, Feb 20, 4:06 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps (Kartotherian)
SBisson moved T187757: Thanks thanking the wrong edit from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Tue, Feb 20, 2:13 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice, Thanks
SBisson claimed T187757: Thanks thanking the wrong edit.
Tue, Feb 20, 1:51 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice, Thanks
SBisson edited projects for T187757: Thanks thanking the wrong edit, added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Tue, Feb 20, 1:51 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice, Thanks

Fri, Feb 16

SBisson renamed T187411: Get kartotherian/kartotherian@master working with its dependencies (kartotherian/*) @master from Get kartotherian/server master branch working with kartotherian/kartotherian update-snapshot-dev branch to Get kartotherian/kartotherian@master working with its dependencies (kartotherian/*) @master.
Fri, Feb 16, 8:53 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps (Kartotherian)
SBisson claimed T187411: Get kartotherian/kartotherian@master working with its dependencies (kartotherian/*) @master.
Fri, Feb 16, 6:26 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps (Kartotherian)
SBisson added a comment to T187411: Get kartotherian/kartotherian@master working with its dependencies (kartotherian/*) @master.

kartotherian/core/lib/sources.js Sources.prototype.init was updated to accept a single 'conf' argument instead of 'variables' and 'sources' (commit from April 18, 2017).

Fri, Feb 16, 3:23 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps (Kartotherian)
SBisson added a comment to T187411: Get kartotherian/kartotherian@master working with its dependencies (kartotherian/*) @master.

For reference, this shrinkwrap file lists what's currently deployed to production.

Fri, Feb 16, 11:16 AM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps (Kartotherian)

Thu, Feb 15

SBisson added a comment to T187411: Get kartotherian/kartotherian@master working with its dependencies (kartotherian/*) @master.

Ideally, kartotherian/kartotherian@master should work with kartotherian/*@master

Thu, Feb 15, 5:55 PM · Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps (Kartotherian)

Wed, Feb 14

SBisson moved T187366: Create 'kartotherian' role in mediawiki-vagrant from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Wed, Feb 14, 7:45 PM · Patch-For-Review, Discovery, MediaWiki-Vagrant, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps
SBisson created T187366: Create 'kartotherian' role in mediawiki-vagrant.
Wed, Feb 14, 7:45 PM · Patch-For-Review, Discovery, MediaWiki-Vagrant, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collaboration-Feature-Rollouts (Collaboration-Maps), Maps

Tue, Feb 13

SBisson moved T186908: Array-to-string conversion in flow_block_topiclist_newtopic from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Tue, Feb 13, 4:31 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Wikimedia-log-errors
SBisson claimed T186908: Array-to-string conversion in flow_block_topiclist_newtopic.
Tue, Feb 13, 11:50 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Wikimedia-log-errors
SBisson edited projects for T186908: Array-to-string conversion in flow_block_topiclist_newtopic, added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Tue, Feb 13, 11:50 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, Wikimedia-log-errors
RandomDSdevel awarded T172636: [regression] Broken link in a user rights change notification email from Echo a Haypence token.
Tue, Feb 13, 2:36 AM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
RandomDSdevel awarded T184185: Hidden topics should be noindexed a Haypence token.
Tue, Feb 13, 2:36 AM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions
RandomDSdevel awarded T122119: Flow does not follow $wgNamespaceRobotPolicies a Haypence token.
Tue, Feb 13, 2:35 AM · User-notice-collaboration, Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions
RandomDSdevel awarded T183484: Related Changes page-name entry box does not show the entirety of long pagenames a Haypence token.
Tue, Feb 13, 2:30 AM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
RandomDSdevel awarded T172161: Integrate 'Related Changes' tools into the new UX a Grey Medal token.
Tue, Feb 13, 2:26 AM · User-notice, MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), User-notice-collaboration, Patch-For-Review, Edit-Review-Improvements-Integrated-Filters, Collaboration-Team-Triage (Collab-Team-This-Quarter)

Mon, Feb 12

SBisson moved T186909: Unknown input type to UUID class: array from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Mon, Feb 12, 7:01 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions, Wikimedia-log-errors
SBisson assigned T187059: "New filters for edit review" beta feature has an incorrect description to Deskana.
Mon, Feb 12, 6:59 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements
SBisson edited projects for T187059: "New filters for edit review" beta feature has an incorrect description, added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Mon, Feb 12, 6:59 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Edit-Review-Improvements
SBisson claimed T186909: Unknown input type to UUID class: array.
Mon, Feb 12, 6:55 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions, Wikimedia-log-errors
SBisson edited projects for T186909: Unknown input type to UUID class: array, added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Mon, Feb 12, 6:55 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions, Wikimedia-log-errors
SBisson added a comment to T186909: Unknown input type to UUID class: array.

No, I don't think it should be logged. As I said on wikitech-l a few months ago: I think exceptions for bad user input are a poor method of handling it. Users can give us all kinds of terrible input, but we shouldn't be logging it unless it's going to cause problems on our end. We should validate higher up and return an error to the user (and pretend it never happened to us).

Mon, Feb 12, 6:00 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions, Wikimedia-log-errors
SBisson added a comment to T187044: Navigation Popups remain when a link is hoovered on Recent Changes, using live update mode and Chrome.

Which wiki?

Mon, Feb 12, 4:48 PM · Edit-Review-Improvements-Integrated-Filters, Navigation-Popups, Collaboration-Team-Triage
SBisson claimed T186930: [wmf.20] Related changes - cannot use Saved filters for several articles .
Mon, Feb 12, 4:38 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
SBisson edited projects for T186930: [wmf.20] Related changes - cannot use Saved filters for several articles , added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Mon, Feb 12, 4:38 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters

Fri, Feb 9

SBisson added a comment to T186909: Unknown input type to UUID class: array.

This appears to be coming from some bot calling at (mostly) regular interval with an invalid URL parameter (header_newRevision[$acunetix]=1). It's an invalid request and an error is the correct response. Should it not be logged?

Fri, Feb 9, 9:01 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions, Wikimedia-log-errors
SBisson claimed T186911: Undefined index: content (in TopicList).
Fri, Feb 9, 8:21 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions, Wikimedia-log-errors
SBisson edited projects for T186911: Undefined index: content (in TopicList), added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Fri, Feb 9, 8:21 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions, Wikimedia-log-errors

Thu, Feb 8

SBisson added a comment to T165682: "unreachable code after return statement" in function _flowBoardComponentLoadMoreFeatureRenderTopics.

I don't know if it's related, but it doesn't let me edit the board's description (opens the editing box, but clicking in it does nothing).

Probably not related. See T185205: Cannot create board description (but can edit an existing one)
Should be fixed in wmf.20 but that doesn't seem to be deployed anywhere.

Thu, Feb 8, 11:22 AM · Patch-For-Review, StructuredDiscussions, Collaboration-Team-Triage
SBisson moved T179718: Revive ORES filters on Related Changes from Code Review Started to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Thu, Feb 8, 10:45 AM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, User-Ladsgroup, MediaWiki-Database
SBisson moved T182636: [betalabs] Fatal exception when clicking on deleted topics in View history (Flow\Model\AbstractRevision::getRecentChange) from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.

I believe this was fixed by the patch for T186077: 'undo' action on SD boards - Fatal exception of type "Wikimedia\Rdbms\DBQueryError"

Thu, Feb 8, 10:44 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions
SBisson moved T186077: 'undo' action on SD boards - Fatal exception of type "Wikimedia\Rdbms\DBQueryError" from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Thu, Feb 8, 10:43 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions

Wed, Feb 7

SBisson moved T179718: Revive ORES filters on Related Changes from QA Review to Code Review Started on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Wed, Feb 7, 2:09 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, User-Ladsgroup, MediaWiki-Database

Fri, Feb 2

SBisson moved T184733: "Notifications marked as read" confirmation dialog has icon overlapping with text from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Fri, Feb 2, 8:53 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications, MinervaNeue
SBisson reopened T184960: There is no license in topic pages of flow discussions as "Open".

The patch was reverted.

Fri, Feb 2, 11:21 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, WMF-Legal, StructuredDiscussions

Thu, Feb 1

SBisson added a comment to T165550: [minor] Bookmarking no-effect filters results in 'No active filters. All contributions are shown".

This is not worth a heroic effort. Shall I decline the ticket or move to Freezer?

Thu, Feb 1, 9:05 PM · Collaboration-Team-Triage, Edit-Review-Improvements-RC-Page
SBisson moved T184807: Flow ToC widget text not wrapped/ellipsized; overlaps with board description widget from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Thu, Feb 1, 7:25 PM · CSS, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions
SBisson added a comment to T177750: Structured discussions email notification about a change on a page description: change "view page" to "view changes" as the primary link.

From the discussion above, I gather that

Thu, Feb 1, 5:41 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications, StructuredDiscussions
SBisson added a comment to T181165: In chapter wikis can't see notifications from other wikis on Special:Notifications due to lack of CORS whitelisting.

Where would one find the official and complete list of chapters sites?

Thu, Feb 1, 5:35 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
SBisson added a comment to T183539: Notifications badge icon overlaps with other links.

@He7d3r I could not reproduce it locally. Could you provide the following details:

  • skin
  • browser
  • custom css
  • site (which wiki)

thanks!

Thu, Feb 1, 5:30 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications, CSS
SBisson added a comment to T174374: Use a mixed storage format, setting the system to slowly migrate over from HTML to wikitext storage.

Given the recent change of focus, do we want to keep this on the board?

Thu, Feb 1, 3:49 PM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions
SBisson renamed T174374: Use a mixed storage format, setting the system to slowly migrate over from HTML to wikitext storage from Use a mixed storage format, setting the system to slowly migrate over from HTML to wikitext storage (quarterly goal) to Use a mixed storage format, setting the system to slowly migrate over from HTML to wikitext storage.
Thu, Feb 1, 3:47 PM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions
SBisson updated the task description for T183725: Update language used in MediaWiki:Flow-edit-header-submit and similar for "publish" wikis.
Thu, Feb 1, 3:41 PM · Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions, MediaWiki-Internationalization
SBisson claimed T184807: Flow ToC widget text not wrapped/ellipsized; overlaps with board description widget.
Thu, Feb 1, 3:40 PM · CSS, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions
SBisson moved T181154: On some wikis, #jump-to-nav elements on Recent changes are overlapping the page title from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Thu, Feb 1, 3:25 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
SBisson moved T159302: Rephrase confusing "thanks" message on diff page from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Thu, Feb 1, 1:58 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), User-notice, Collaboration-Team-Triage (Collab-Team-This-Quarter), User-notice-collaboration, Thanks
SBisson moved T183710: Echo double-encodes URI 'fragment' part when removing the 'markasread' parameter from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Thu, Feb 1, 1:58 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications
SBisson moved T184733: "Notifications marked as read" confirmation dialog has icon overlapping with text from In Development to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Thu, Feb 1, 12:04 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications, MinervaNeue

Wed, Jan 31

SBisson claimed T184733: "Notifications marked as read" confirmation dialog has icon overlapping with text.
Wed, Jan 31, 11:59 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Notifications, MinervaNeue
SBisson added a comment to T186077: 'undo' action on SD boards - Fatal exception of type "Wikimedia\Rdbms\DBQueryError".

I think this is the same thing as T182636: [betalabs] Fatal exception when clicking on deleted topics in View history (Flow\Model\AbstractRevision::getRecentChange)

Wed, Jan 31, 11:31 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions

Tue, Jan 30

SBisson added a comment to T185205: Cannot create board description (but can edit an existing one).

This will be deployed with the train next week.

Tue, Jan 30, 12:13 AM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions
SBisson merged task T185966: StucturedDiscussions unable to edit description into T185205: Cannot create board description (but can edit an existing one).
Tue, Jan 30, 12:13 AM · Collaboration-Team-Triage, StructuredDiscussions
SBisson merged T185966: StucturedDiscussions unable to edit description into T185205: Cannot create board description (but can edit an existing one).
Tue, Jan 30, 12:13 AM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions

Mon, Jan 29

SBisson moved T185293: Fix flow-conversion-archive-flow-page-name-format for backwards compatibility from In Development to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Mon, Jan 29, 2:31 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions
SBisson claimed T185617: Call to a member function isHidden() on a non-object (null).
Mon, Jan 29, 11:43 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions
SBisson edited projects for T185617: Call to a member function isHidden() on a non-object (null), added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Mon, Jan 29, 11:42 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions
SBisson merged task T185856: Fatal exception of type "BadMethodCallException" when viewing deleted topic without action specified into T185617: Call to a member function isHidden() on a non-object (null).
Mon, Jan 29, 11:42 AM · Collaboration-Team-Triage, StructuredDiscussions
SBisson merged T185856: Fatal exception of type "BadMethodCallException" when viewing deleted topic without action specified into T185617: Call to a member function isHidden() on a non-object (null).
Mon, Jan 29, 11:42 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions

Thu, Jan 25

SBisson moved T179718: Revive ORES filters on Related Changes from Announce in next Collaboration Newsletter to Not ready to announce on the User-notice-collaboration board.
Thu, Jan 25, 10:32 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, User-Ladsgroup, MediaWiki-Database

Wed, Jan 24

SBisson updated subscribers of T179718: Revive ORES filters on Related Changes.

@Trizek-WMF please wait for this ticket to be resolved before announcing. This is currently in dark lunch (behind a private url flag) and we may need to revert if we find problems during testing.

Wed, Jan 24, 5:39 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, User-Ladsgroup, MediaWiki-Database
SBisson added a comment to T179718: Revive ORES filters on Related Changes.

The ORES filters on Related Changes are not visible by default. They are hidden behind a private URL parameter (experimental_ores_on_rcl=1) while we check for performance issues.

Wed, Jan 24, 5:35 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, User-Ladsgroup, MediaWiki-Database

Jan 24 2018

SBisson added a comment to T185617: Call to a member function isHidden() on a non-object (null).

Fixed in https://gerrit.wikimedia.org/r/#/c/405042/

Jan 24 2018, 1:18 AM · Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions

Jan 23 2018

SBisson claimed T184952: [wmf.15] Related changes page: the warning "The given page title is invalid..." is out of sync with the page content.
Jan 23 2018, 9:38 PM · MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters
SBisson moved T144630: [minor] Change Flow confirmation message to say 'post' instead of 'comments' (when posts are deleted/suppressed) from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Jan 23 2018, 9:32 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Easy, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions

Jan 22 2018

Liuxinyu970226 awarded T122119: Flow does not follow $wgNamespaceRobotPolicies a The World Burns token.
Jan 22 2018, 2:08 PM · User-notice-collaboration, Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions

Jan 19 2018

SBisson added a comment to T159489: Add a "live" option to the "days" feature that AJAX refreshes the page every N seconds (30?).

Is this different from the Live Update feature we have now?

Jan 19 2018, 4:35 PM · Collaboration-Team-Triage, Edit-Review-Improvements-RC-Page
SBisson added a comment to T179718: Revive ORES filters on Related Changes.

@jmatazzoni, @Catrope ORES filters are now available on RecentChangesLinked (aka RelatedChanges) everwhere when using a special URL parameter (experimental_ores_on_rcl=1)

Jan 19 2018, 3:33 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Edit-Review-Improvements-Integrated-Filters, User-Ladsgroup, MediaWiki-Database
SBisson added a comment to T184670: [wmf.16-regression] Fatal exception of type "Flow\Exception\InvalidDataException" for opting out from "Structured Discussions on user talk".

For completeness, here are all the unique errors I could find from logstash related to opt in/out in the last 30 days.

Jan 19 2018, 3:04 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression
SBisson claimed T185293: Fix flow-conversion-archive-flow-page-name-format for backwards compatibility.
Jan 19 2018, 1:32 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions
SBisson added a comment to T185293: Fix flow-conversion-archive-flow-page-name-format for backwards compatibility.

Here's the list of all translations for this message: https://translatewiki.net/w/i.php?title=Special%3ATranslations&message=flow-conversion-archive-flow-page-name-format&namespace=8

Jan 19 2018, 12:03 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), StructuredDiscussions
SBisson added a comment to T184670: [wmf.16-regression] Fatal exception of type "Flow\Exception\InvalidDataException" for opting out from "Structured Discussions on user talk".

[...]
There are not very many:

grep 'INCONSISTENT' FlowFixInconsistentBoards_all_2018-01-19_dry_run_force.txt
frwiki:  INCONSISTENT: Core title for 'tgno0jiutbg6zukj' is 'Discussion utilisateur:Zilant17', but Flow title is 'Discussion utilisateur:Zilant17/Structured Discussions Archive 1'
frwiki:  INCONSISTENT: Core title for 'u1uw91cj53ekrbvk' is 'Discussion utilisateur:Stephanecbisson', but Flow title is 'Discussion utilisateur:Stephanecbisson/Structured Discussions Archive 1'
testwiki:  INCONSISTENT: Core title for 'spfeq7tyt191zvvx' is 'User talk:Etonkovidova', but Flow title is 'User talk:Etonkovidova/Structured Discussions Archive 1'
testwiki:  INCONSISTENT: Core title for 'tgeds5mlkb0we4rv' is 'User talk:Zilant63', but Flow title is 'User talk:Zilant63/Structured Discussions Archive 1'
testwiki:  INCONSISTENT: Core title for 'u5tzvm8lv1hw6ve1' is 'User talk:Stephanecbisson', but Flow title is 'User talk:Stephanecbisson/Structured Discussions Archive 1'
zhwiki:  INCONSISTENT: Core title for 'u5uxvde8yqfxmywd' is 'User talk:DreamGuan', but Flow title is 'User talk:DreamGuan/结构式讨论 存档 1'
Jan 19 2018, 11:28 AM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression

Jan 18 2018

SBisson assigned T185205: Cannot create board description (but can edit an existing one) to Catrope.
Jan 18 2018, 8:33 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions
SBisson edited projects for T185205: Cannot create board description (but can edit an existing one), added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Jan 18 2018, 8:33 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions
SBisson assigned T184960: There is no license in topic pages of flow discussions to Catrope.
Jan 18 2018, 8:32 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, WMF-Legal, StructuredDiscussions
SBisson edited projects for T184960: There is no license in topic pages of flow discussions, added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Jan 18 2018, 8:32 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, WMF-Legal, StructuredDiscussions
SBisson added a comment to T184670: [wmf.16-regression] Fatal exception of type "Flow\Exception\InvalidDataException" for opting out from "Structured Discussions on user talk".

The Flow beta feature is now disabled everywhere but on testwiki.

Jan 18 2018, 7:07 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression
SBisson added a comment to T184670: [wmf.16-regression] Fatal exception of type "Flow\Exception\InvalidDataException" for opting out from "Structured Discussions on user talk".

[mediawiki/extensions/Flow@master] Trying to make Opt in/out atomic
https://gerrit.wikimedia.org/r/404988

Question for @aaron, I'm told you are the expert on this.

This patch tries to make the whole process transactional by using AtomicSectionUpdate. It works locally but many things work better against a single server.

The AtomicSectionUpdate constructor is given wfGetDB( DB_MASTER ) with the assumption that the move and edit WikiPage code will also request DB_MASTER and will receive the same connection in which the transaction is open. Does it make sense? Is there any problem you can spot in this patch?

Thanks!

Jan 18 2018, 4:02 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression
SBisson updated subscribers of T184670: [wmf.16-regression] Fatal exception of type "Flow\Exception\InvalidDataException" for opting out from "Structured Discussions on user talk".

[mediawiki/extensions/Flow@master] Trying to make Opt in/out atomic
https://gerrit.wikimedia.org/r/404988

Jan 18 2018, 2:25 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression
SBisson added a comment to T184670: [wmf.16-regression] Fatal exception of type "Flow\Exception\InvalidDataException" for opting out from "Structured Discussions on user talk".

It looks like opt-out breaks in the middle and leaves the talk page in an inconsistent state. The problem might be this exception:

PHP Error: Argument 1 passed to WikiPage::prepareContentForEdit() must implement interface Content, null given
#0 /srv/mediawiki/php-1.31.0-wmf.16/includes/page/WikiPage.php(2145): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.31.0-wmf.16/includes/page/WikiPage.php(2204): WikiPage->prepareContentForEdit(NULL, Revision, User, NULL, boolean)
#2 /srv/mediawiki/php-1.31.0-wmf.16/includes/MovePage.php(564): WikiPage->doEditUpdates(Revision, User, array)
#3 /srv/mediawiki/php-1.31.0-wmf.16/includes/MovePage.php(271): MovePage->moveToInternal(User, Title, string, boolean, array)
#4 /srv/mediawiki/php-1.31.0-wmf.16/extensions/Flow/includes/Import/OptInController.php(142): MovePage->move(User, string, boolean)
#5 /srv/mediawiki/php-1.31.0-wmf.16/extensions/Flow/includes/Import/OptInController.php(113): Flow\Import\OptInController->movePage(Title, Title, string)
#6 /srv/mediawiki/php-1.31.0-wmf.16/extensions/Flow/includes/Import/OptInUpdate.php(50): Flow\Import\OptInController->disable(Title)
#7 /srv/mediawiki/php-1.31.0-wmf.16/includes/deferred/DeferredUpdates.php(259): Flow\Import\OptInUpdate->doUpdate()
#8 /srv/mediawiki/php-1.31.0-wmf.16/includes/deferred/DeferredUpdates.php(210): DeferredUpdates::runUpdate(Flow\Import\OptInUpdate, Wikimedia\Rdbms\LBFactoryMulti, string, integer)
#9 /srv/mediawiki/php-1.31.0-wmf.16/includes/deferred/DeferredUpdates.php(131): DeferredUpdates::execute(array, string, integer)
#10 /srv/mediawiki/php-1.31.0-wmf.16/includes/MediaWiki.php(900): DeferredUpdates::doUpdates(string)
#11 /srv/mediawiki/php-1.31.0-wmf.16/includes/MediaWiki.php(720): MediaWiki->restInPeace(string, boolean)
#12 [internal function]: Closure$MediaWiki::doPostOutputShutdown()
#13 {main}
Jan 18 2018, 1:37 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression
SBisson created T185205: Cannot create board description (but can edit an existing one).
Jan 18 2018, 11:57 AM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, StructuredDiscussions
SBisson assigned T185042: [wmf.16-regression] testwiki - Attempting to post a topic without content will display icons overlaid by text to Catrope.
Jan 18 2018, 11:31 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Regression, StructuredDiscussions
SBisson edited projects for T185042: [wmf.16-regression] testwiki - Attempting to post a topic without content will display icons overlaid by text, added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.
Jan 18 2018, 11:31 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Regression, StructuredDiscussions
SBisson moved T184143: Special:Notifications page does not truncate long page titles from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Jan 18 2018, 11:27 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), User-notice-collaboration, Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Collab-Notifications-Page
SBisson added a comment to T184670: [wmf.16-regression] Fatal exception of type "Flow\Exception\InvalidDataException" for opting out from "Structured Discussions on user talk".

Hiding the preference until the fix may make sense.

wgHiddenPrefs should work.

There is a gotcha that hidden preferences are coerced to their default when reading... by default.

In this case, that's false. However, we only check the value on-save, and if it thinks both before and after are false, it should theoretically work bogus-ly (nothing to change).

I acknowledge that is kind of meh. In general, this can be solved with User->getOption $ignoreHidden. It would also have to be done in BetaFeatureUtil.php.

Jan 18 2018, 11:19 AM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression

Jan 17 2018

SBisson moved T184670: [wmf.16-regression] Fatal exception of type "Flow\Exception\InvalidDataException" for opting out from "Structured Discussions on user talk" from Untriaged to In Development on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Jan 17 2018, 8:00 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression
SBisson edited projects for T184670: [wmf.16-regression] Fatal exception of type "Flow\Exception\InvalidDataException" for opting out from "Structured Discussions on user talk", added: Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage (Collab-Team-Next-Quarter).
Jan 17 2018, 8:00 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression
SBisson added a comment to T184670: [wmf.16-regression] Fatal exception of type "Flow\Exception\InvalidDataException" for opting out from "Structured Discussions on user talk".

I see this in the logs on opt out but it doesn't make it fail. The whole process (optin, optout, optin, reset all (optout)) works for me locally now that my vagrant is fixed.

Jan 17 2018, 7:59 PM · User-notice-collaboration, MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Collaboration-Team-Triage (Collab-Team-This-Quarter), Regression
SBisson added a comment to T185114: Move ExternalStore table to main per-wiki database.

Well, the table does exist in the db named external but the code is looking for it in the current db. Some config must be wrong.

Jan 17 2018, 5:01 PM · Regression, MediaWiki-Vagrant
SBisson created T185114: Move ExternalStore table to main per-wiki database.
Jan 17 2018, 4:57 PM · Regression, MediaWiki-Vagrant
SBisson removed a project from T185113: service::node managed templates cannot see calling scope variables under Puppet4: Parsoid.

restbase and citoid systemd config files have the same issue (I didn't check any other ones)

Jan 17 2018, 4:24 PM · Patch-For-Review, MediaWiki-Vagrant