Page MenuHomePhabricator

SBisson (Stephane Bisson)
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 6 2015, 8:49 PM (215 w, 2 d)
Availability
Available
IRC Nick
stephanebisson
LDAP User
Unknown
MediaWiki User
Sbisson (WMF) [ Global Accounts ]

Recent Activity

Yesterday

SBisson added a comment to T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182.

The patches referenced in T224116#5204455 have changed the loading of the extension from synchronous in extensions/FlaggedRevs/FlaggedRevs.php to asynchronous (happening later when the ExtensionRegistry queue is processed).

Wed, May 22, 5:30 PM · Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, Wikimedia-Site-requests, Wikimedia-production-error
SBisson added a comment to T224116: operand type was used: expects array(s) or collection(s) in /srv/mediawiki/wmf-config/flaggedrevs.php on line 182.

I bet it's extension registration related...

Wed, May 22, 4:01 PM · Patch-For-Review, Growth-Team, MediaWiki-extensions-FlaggedRevs, Wikimedia-Site-requests, Wikimedia-production-error
SBisson merged T224123: [Echo] PHP Warning: htmlspecialchars() expects parameter 1 to be string, object given into T223741: Invalid message parameter CommentStoreComment from EventPresentationModel.php.
Wed, May 22, 2:44 PM · Growth-Team (Current Sprint), Patch-For-Review, Notifications, Wikimedia-production-error
SBisson merged task T224123: [Echo] PHP Warning: htmlspecialchars() expects parameter 1 to be string, object given into T223741: Invalid message parameter CommentStoreComment from EventPresentationModel.php.
Wed, May 22, 2:44 PM · Notifications, Wikimedia-production-error, Growth-Team

Tue, May 21

SBisson updated subscribers of T224039: HelpPanel schema: log actual error message in event_data for 'submit-failure' action.
Tue, May 21, 4:45 PM · GrowthExperiments-Homepage, GrowthExperiments-Help panel, Growth-Team (Current Sprint)
SBisson created T224039: HelpPanel schema: log actual error message in event_data for 'submit-failure' action.
Tue, May 21, 4:45 PM · GrowthExperiments-Homepage, GrowthExperiments-Help panel, Growth-Team (Current Sprint)
SBisson claimed T223741: Invalid message parameter CommentStoreComment from EventPresentationModel.php.

@Krinkle I think the patch above will fix the log spamming and prevent new Echo events from being created with a CommentStoreComment. Faulty events would stay in place but eventually expire and be deleted.

Tue, May 21, 3:52 PM · Growth-Team (Current Sprint), Patch-For-Review, Notifications, Wikimedia-production-error
SBisson edited projects for T223741: Invalid message parameter CommentStoreComment from EventPresentationModel.php, added: Growth-Team (Current Sprint); removed Growth-Team.
Tue, May 21, 3:45 PM · Growth-Team (Current Sprint), Patch-For-Review, Notifications, Wikimedia-production-error

Sat, May 18

Trizek-WMF awarded T220145: Homepage Mentorship: allow mentors to configure their presentation a Love token.
Sat, May 18, 10:14 AM · Growth-Team (Current Sprint), Patch-For-Review, Wikimedia-Hackathon-2019, GrowthExperiments

Thu, May 16

Tgr awarded T220123: Workshop on project ideas for new editors experiences a Like token.
Thu, May 16, 12:25 PM · User-Urbanecm, Wikimedia-Hackathon-2019

Wed, May 15

SBisson removed a watcher for Wikimedia-Hackathon-2019: SBisson.
Wed, May 15, 10:55 AM

Tue, May 14

SBisson moved T221163: Remove usage of deprecated Revision class from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, May 14, 1:39 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Growth-Team (Current Sprint), User-D3r1ck01, Patch-For-Review, Technical-Debt, Notifications

Wed, May 8

SBisson moved T222834: Mobile Homepage: Make the user option in the mobile menu go to the homepage from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Wed, May 8, 7:23 PM · GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson moved T222835: Mobile Homepage: tabs layout from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Wed, May 8, 7:23 PM · GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson moved T222833: Mobile Homepage: Show module details in a mobile overlay from Incoming to Ready for Development on the Growth-Team (Current Sprint) board.
Wed, May 8, 7:23 PM · GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson closed T117353: Change csslint to lesslint in echo as Declined.

Echo is now using stylelint, like most (or all) of the other repos.

Wed, May 8, 7:18 PM · Collaboration-Team-Triage, Notifications
SBisson moved T167336: Show current site name properly if cross-wiki notifications are not enabled from Code Review to In Progress on the Growth-Team (Current Sprint) board.

The patch that was merged was to fix a JS error that occurs on TWN.

Wed, May 8, 7:15 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Growth-Team (Current Sprint), Notifications
SBisson added a project to T215983: Homepage: mobile version: Epic.

I've created subtasks for the actual work. Making this an epic. Not sure where to put it on the board.

Wed, May 8, 6:56 PM · Epic, GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson moved T222832: Mobile Homepage: Basic server-side version from Incoming to In Progress on the Growth-Team (Current Sprint) board.
Wed, May 8, 6:55 PM · GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson created T222836: Mobile Homepage: instrumentation.
Wed, May 8, 6:55 PM · GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson created T222835: Mobile Homepage: tabs layout.
Wed, May 8, 6:54 PM · GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson created T222834: Mobile Homepage: Make the user option in the mobile menu go to the homepage.
Wed, May 8, 6:54 PM · GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson created T222833: Mobile Homepage: Show module details in a mobile overlay.
Wed, May 8, 6:54 PM · GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson created T222832: Mobile Homepage: Basic server-side version.
Wed, May 8, 6:53 PM · GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson updated the task description for T221151: Move Echo page-level data to something async (wgEchoInteractionLogging, wgEchoEventLoggingVersion).
Wed, May 8, 6:45 PM · Growth-Team, Notifications, Performance-Team (Radar)
SBisson added a comment to T202191: Cannot get rid of welcome message on translatewiki.net.

@Petar.petkovic Do you still have that notification stuck? If so, do you have an error in the JS console?

Wed, May 8, 2:53 PM · Growth-Team, Notifications, translatewiki.net
SBisson closed T102177: 'I am logged in as a new user with no notifications' doesn't always work on browser tests as Invalid.

This refers to the cucumber browser tests that don't exist anymore.

Wed, May 8, 2:49 PM · Browser-Tests, Collaboration-Team-Triage, Notifications
SBisson closed T126803: Update enwiki customizations for page triage notification as Invalid.

The ticket as written was invalid since we've introduced new messages that are not shadowed by local overrides.

Wed, May 8, 2:42 PM · Collaboration-Team-Triage, PageCuration, Notifications
SBisson closed T126803: Update enwiki customizations for page triage notification, a subtask of T125693: Update PageTriage notifications to new language and format, as Invalid.
Wed, May 8, 2:42 PM · MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), Patch-For-Review, PageCuration, Notifications, Collaboration-Team-Archive-2015-2016
SBisson closed T55479: Notification emails should embed icons as data URIs as Declined.

We've tried embedding SVGs as data-uri, both in text and base64. The markup is sane and works in browsers but gmail doesn't render them.

Wed, May 8, 1:59 PM · Growth-Team (Current Sprint), Technical-Debt, Notifications
SBisson moved T221164: Remove usage of deprecated database access code from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, May 8, 12:24 AM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Growth-Team (Current Sprint), User-D3r1ck01, Technical-Debt, Notifications

Tue, May 7

SBisson moved T221164: Remove usage of deprecated database access code from QA to Code Review on the Growth-Team (Current Sprint) board.
Tue, May 7, 8:25 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Growth-Team (Current Sprint), User-D3r1ck01, Technical-Debt, Notifications
SBisson moved T221164: Remove usage of deprecated database access code from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, May 7, 8:18 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Growth-Team (Current Sprint), User-D3r1ck01, Technical-Debt, Notifications
SBisson moved T222400: Homepage: users on mentors list who use Special:Homepage should not be assigned themselves as mentors from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, May 7, 10:21 AM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Growth-Team (Current Sprint), User-Urbanecm, Patch-For-Review, good first bug, GrowthExperiments, GrowthExperiments-Homepage

Mon, May 6

SBisson added a comment to T221266: Homepage: Deploy to target wikis in production.

Consider SWATing https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/507956 before enabling the experiment.

Mon, May 6, 1:12 PM · Patch-For-Review, GrowthExperiments-Homepage, Growth-Team (Current Sprint)

Fri, May 3

SBisson committed rEGRE93624bfe12c2: Homepage: Move start module subheaders to bodies, bodies to footers (authored by Catrope).
Homepage: Move start module subheaders to bodies, bodies to footers
Fri, May 3, 8:14 PM
SBisson committed rEGRE51af980f1927: Homepage: Use flexbox to align buttons in start module (authored by Catrope).
Homepage: Use flexbox to align buttons in start module
Fri, May 3, 7:53 PM
SBisson closed T222465: GrowthExperiments phan job fails on JsonSerializable as Resolved.

Now it's merged.

Fri, May 3, 6:42 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
SBisson committed rEGREd7aa31a4d9f0: Impact: No link to pageviews tool when data is not available (--) (authored by SBisson).
Impact: No link to pageviews tool when data is not available (--)
Fri, May 3, 6:32 PM
SBisson created T222469: MobileFrontend selenium test: "User:<username> Check user page is editable" blocking merges on GrowthExperiments extension.
Fri, May 3, 5:44 PM · Readers-Web-Backlog, MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, MobileFrontend
SBisson reopened T222465: GrowthExperiments phan job fails on JsonSerializable as "Open".

The patch failed to merge because of a MobileFrontend selenium test

Fri, May 3, 5:41 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
SBisson moved T222465: GrowthExperiments phan job fails on JsonSerializable from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Fri, May 3, 5:15 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
SBisson added a comment to T222465: GrowthExperiments phan job fails on JsonSerializable.

Apparently fixed in the library but not yet released: https://github.com/JakubOnderka/PHP-Parallel-Lint/issues/125

Fri, May 3, 5:15 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
SBisson committed rEGREb2cab6b65b40: Fix phan job: ignore line using JsonSerializable (authored by SBisson).
Fix phan job: ignore line using JsonSerializable
Fri, May 3, 5:10 PM
SBisson triaged T222465: GrowthExperiments phan job fails on JsonSerializable as High priority.
Fri, May 3, 5:00 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
SBisson created T222465: GrowthExperiments phan job fails on JsonSerializable.
Fri, May 3, 5:00 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments
SBisson moved T222405: Homepage: null pageviews should not be a link from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Fri, May 3, 1:49 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), GrowthExperiments-Homepage, Patch-For-Review, GrowthExperiments, Growth-Team (Current Sprint)
SBisson awarded T222042: Add sniff to require trailing commas in multiline arrays a Like token.
Fri, May 3, 1:36 PM · MediaWiki-Codesniffer
SBisson committed rEGRE0832b6e2f44e: Impact: No link to pageviews tool when data is not available (--) (authored by SBisson).
Impact: No link to pageviews tool when data is not available (--)
Fri, May 3, 1:23 PM
SBisson committed rEGRE100dde868979: Impact: No link to pageviews tool when data is not available (--) (authored by SBisson).
Impact: No link to pageviews tool when data is not available (--)
Fri, May 3, 1:11 PM
SBisson claimed T222405: Homepage: null pageviews should not be a link.
Fri, May 3, 12:30 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), GrowthExperiments-Homepage, Patch-For-Review, GrowthExperiments, Growth-Team (Current Sprint)

Thu, May 2

SBisson moved T221262: Actively delete echo_event rows when they become orphaned from Code Review to QA on the Growth-Team (Current Sprint) board.
Thu, May 2, 7:30 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Growth-Team (Current Sprint), Patch-For-Review, Notifications
SBisson committed rEGRE801ac2ee1a56: Start: light drop-shadow when the module is not completed (authored by SBisson).
Start: light drop-shadow when the module is not completed
Thu, May 2, 4:55 PM
SBisson moved T222123: Homepage: drop shadow on start module should disappear when all complete from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Thu, May 2, 4:53 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), GrowthExperiments, Patch-For-Review, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson reopened T222123: Homepage: drop shadow on start module should disappear when all complete as "Open".

I think I made a mistake here.

Thu, May 2, 4:47 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), GrowthExperiments, Patch-For-Review, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson reopened T222123: Homepage: drop shadow on start module should disappear when all complete, a subtask of T218966: Homepage: layout and UI details, as Open.
Thu, May 2, 4:47 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Growth-Team (Current Sprint)
SBisson moved T218724: MassMessage to email should show section header, not bot username from Inbox to Triaged but Future on the Growth-Team board.

Triaging to "future" for the Growth team but it's possible we'll get to it as part of the effort to reduce Echo's backlog.

Thu, May 2, 2:18 PM · Growth-Team, Notifications, MassMessage
SBisson updated subscribers of T215983: Homepage: mobile version.

Users will access their homepage by opening the side menu and tapping their username in the list.

@MMiller_WMF @SBisson I remember we said that this wasn't technically possible...Did I miss anything?

Thu, May 2, 1:19 PM · Epic, GrowthExperiments-Homepage, GrowthExperiments, Mobile, Growth-Team (Current Sprint)
SBisson committed rEGREe9478383b153: POC: Homepage on mobile (authored by SBisson).
POC: Homepage on mobile
Thu, May 2, 1:12 PM
SBisson committed rEGRE4ec4b32fb366: Recent questions: handle deleted page (authored by SBisson).
Recent questions: handle deleted page
Thu, May 2, 12:36 PM
SBisson merged T222350: Notification about new reply on my talk page displays some code, if reply starts with template into T219138: TemplateStyles CSS appears in notification text.
Thu, May 2, 10:35 AM · RemexHtml, Growth-Team, Notifications, TemplateStyles
SBisson merged task T222350: Notification about new reply on my talk page displays some code, if reply starts with template into T219138: TemplateStyles CSS appears in notification text.
Thu, May 2, 10:35 AM · Growth-Team, Notifications

Wed, May 1

SBisson committed rEGREb36a03094efa: Recent questions: handle deleted page (authored by SBisson).
Recent questions: handle deleted page
Wed, May 1, 8:48 PM
SBisson committed rEGREda8decc6bc35: Recent questions: handle deleted page (authored by SBisson).
Recent questions: handle deleted page
Wed, May 1, 7:54 PM
SBisson committed rEGRE60aa85ba0943: Recent questions: handle deleted page (authored by SBisson).
Recent questions: handle deleted page
Wed, May 1, 7:41 PM
SBisson committed rEGREb34714810f6e: Recent questions: handle deleted page (authored by SBisson).
Recent questions: handle deleted page
Wed, May 1, 7:41 PM
SBisson committed rEGREcf7c8c5c3adc: Recent questions: handle deleted page (authored by SBisson).
Recent questions: handle deleted page
Wed, May 1, 7:13 PM
SBisson edited projects for T218724: MassMessage to email should show section header, not bot username, added: Growth-Team; removed Growth-Team (Current Sprint).
Wed, May 1, 7:09 PM · Growth-Team, Notifications, MassMessage
MMiller_WMF awarded T222206: Homepage: If a talk page containing a question is deleted, it causes fatal error for all newbies a Yellow Medal token.
Wed, May 1, 4:53 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), GrowthExperiments, Growth-Team (Current Sprint), GrowthExperiments-Homepage
SBisson added a comment to T222239: Homepage: no "enter-question-text" event recorded.

Note: enter-question-text also fires when the dialog is re-opened after a question was successfully posted. I think this is a bug.

Right. I'll submit a fix for this.

Wed, May 1, 4:53 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, GrowthExperiments, Growth-Team (Current Sprint)
SBisson moved T222264: Reuse timestamp for question header and question storage from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, May 1, 4:41 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, GrowthExperiments-Homepage
SBisson added a comment to T222264: Reuse timestamp for question header and question storage.

This was deployed to production just now.

Wed, May 1, 4:41 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, GrowthExperiments-Homepage
SBisson added a comment to T222241: Homepage: missing "link-click" for mentorship module.

The fix for this was deployed to production just now.

Wed, May 1, 4:25 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, GrowthExperiments, Growth-Team (Current Sprint)
SBisson committed rEGRE2a7f866c0693: Ensure text exists before logging enter-question-text action (authored by kostajh).
Ensure text exists before logging enter-question-text action
Wed, May 1, 3:35 PM
SBisson committed rEGRE2bf667fb52c1: Start: remove drop-shadow when completed (authored by SBisson).
Start: remove drop-shadow when completed
Wed, May 1, 3:27 PM
SBisson created T222272: Homepage: Help and Mentorship question dialog should autofocus on the question textbox.
Wed, May 1, 3:18 PM · Growth-Team, GrowthExperiments, GrowthExperiments-Homepage
SBisson committed rEGREc99ec2351158: Re-use timestamp for section header and question storage (authored by kostajh).
Re-use timestamp for section header and question storage
Wed, May 1, 3:08 PM
SBisson committed rEGREfe9db0de2815: Start: remove drop-shadow when completed (authored by SBisson).
Start: remove drop-shadow when completed
Wed, May 1, 3:05 PM
SBisson claimed T222123: Homepage: drop shadow on start module should disappear when all complete.
Wed, May 1, 3:03 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), GrowthExperiments, Patch-For-Review, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson claimed T222206: Homepage: If a talk page containing a question is deleted, it causes fatal error for all newbies.
Wed, May 1, 2:53 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), GrowthExperiments, Growth-Team (Current Sprint), GrowthExperiments-Homepage
SBisson edited projects for T222206: Homepage: If a talk page containing a question is deleted, it causes fatal error for all newbies, added: Growth-Team (Current Sprint), GrowthExperiments; removed Growth-Team.
Wed, May 1, 2:53 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), GrowthExperiments, Growth-Team (Current Sprint), GrowthExperiments-Homepage
SBisson committed rEGREf3d4bc5720ea: Recent questions: handle deleted page (authored by SBisson).
Recent questions: handle deleted page
Wed, May 1, 2:52 PM
SBisson committed rEGRE6f986ce4b2d4: Mentorship module: Add data-link-id to mentor's talkpage link (authored by SBisson).
Mentorship module: Add data-link-id to mentor's talkpage link
Wed, May 1, 2:25 PM
SBisson moved T217105: Homepage: start module from Ready for Development to QA on the Growth-Team (Current Sprint) board.
Wed, May 1, 1:14 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, GrowthExperiments, Growth-Team (Current Sprint)
SBisson added a comment to T222119: Homepage: links open in new tab don't log link-click.

About the two pairs of hover in/out events, the browser considers that when a menu option is selected, the cursor is temporarily out of the HTML element and then on it again. This can be seen with option options like "copy", "save link as...", etc.

Wed, May 1, 1:12 PM · Growth-Team, GrowthExperiments, GrowthExperiments-Homepage
SBisson added a comment to T222119: Homepage: links open in new tab don't log link-click.

According to the browser, right click > "open in new tab" is not a "click" event. It's a "mousedown", followed by a "contextmenu", and the actual click to the menu option is a low level event not defined in Javascript. So we don't have access to it.

Wed, May 1, 12:56 PM · Growth-Team, GrowthExperiments, GrowthExperiments-Homepage
SBisson committed rEGRE322abb849c8e: Mentorship module: Add data-link-id to mentor's talkpage link (authored by SBisson).
Mentorship module: Add data-link-id to mentor's talkpage link
Wed, May 1, 12:49 PM
SBisson moved T222241: Homepage: missing "link-click" for mentorship module from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Wed, May 1, 12:46 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, GrowthExperiments, Growth-Team (Current Sprint)
SBisson moved T222241: Homepage: missing "link-click" for mentorship module from Incoming to In Progress on the Growth-Team (Current Sprint) board.

The link in question is missing the "data-link-id" attribute that is required for us to track it under a symbolic name. Adding now.

Wed, May 1, 12:45 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, GrowthExperiments, Growth-Team (Current Sprint)
SBisson moved T222223: Use thumb.php for impact image thumbnails from Code Review to QA on the Growth-Team (Current Sprint) board.
Wed, May 1, 12:38 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, GrowthExperiments, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson added a comment to T222239: Homepage: no "enter-question-text" event recorded.

enter-question-text is fired only when the textbox goes from empty to non-empty. If it already contains some text because an earlier question was drafted but not submitted, new changes to the text won't fire any event. This was defined as a rule for Help Panel so we know the textbox is interacted with but we don't fire too many events.

Wed, May 1, 12:37 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, GrowthExperiments, Growth-Team (Current Sprint)

Tue, Apr 30

SBisson committed rEGREcb4c76c17ce6: Homepage: UI fixes (authored by SBisson).
Homepage: UI fixes
Tue, Apr 30, 8:38 PM
SBisson merged task T222158: Homepage: On smaller screens, "Create userpage" button goes out of "Create userpage" tutorial step into T222122: Homepage: Czech button extends out of the start module.
Tue, Apr 30, 5:41 PM · GrowthExperiments-Homepage, Growth-Team
SBisson merged T222158: Homepage: On smaller screens, "Create userpage" button goes out of "Create userpage" tutorial step into T222122: Homepage: Czech button extends out of the start module.
Tue, Apr 30, 5:41 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, GrowthExperiments, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
Volker_E awarded T222122: Homepage: Czech button extends out of the start module a Like token.
Tue, Apr 30, 5:21 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, GrowthExperiments, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson added a comment to T222122: Homepage: Czech button extends out of the start module.

@SBisson
The link "Guidelines for user pages" is removed?

Tue, Apr 30, 5:14 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, GrowthExperiments, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson moved T222122: Homepage: Czech button extends out of the start module from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Apr 30, 3:45 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, GrowthExperiments, GrowthExperiments-Homepage, Growth-Team (Current Sprint)
SBisson added a comment to T218966: Homepage: layout and UI details.

Layout

  • modules header icon?
Tue, Apr 30, 3:45 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Growth-Team (Current Sprint)
SBisson added a comment to T206358: Request Sauce Labs access for niedzielski.

Haven't used it in years. Thanks for cleaning that up.

Tue, Apr 30, 3:41 PM · User-zeljkofilipin, Release-Engineering-Team (Kanban)
SBisson moved T222003: Homepage: widescreen homepage is stretched from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Apr 30, 1:17 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Growth-Team (Current Sprint), Patch-For-Review, GrowthExperiments