Page MenuHomePhabricator

SBisson (Stephane Bisson)
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 6 2015, 8:49 PM (378 w, 17 h)
Availability
Available
IRC Nick
stephanebisson
LDAP User
Unknown
MediaWiki User
Sbisson (WMF) [ Global Accounts ]

Recent Activity

Yesterday

SBisson moved T309771: Add a progress state while publishing a story from Code Review to QA on the Inuka-Team (Kanban) board.
Mon, Jul 4, 5:55 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson updated the task description for T311847: Localize Special:StoryBuilder to ID language.
Mon, Jul 4, 5:52 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson updated the task description for T311846: Make Story/Story_talk namespaces localizable and localized to ID language.
Mon, Jul 4, 5:49 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson updated the task description for T311847: Localize Special:StoryBuilder to ID language.
Mon, Jul 4, 5:48 PM · Wikistories (R2), Inuka-Team (Kanban)

Fri, Jul 1

SBisson committed rEWST4f4044327119: Remove unused wikistories param from link (authored by SBisson).
Remove unused wikistories param from link
Fri, Jul 1, 4:41 PM
SBisson updated the task description for T311846: Make Story/Story_talk namespaces localizable and localized to ID language.
Fri, Jul 1, 3:23 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson moved T311849: Localize no-js edit form from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.
Fri, Jul 1, 2:59 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson created T311849: Localize no-js edit form.
Fri, Jul 1, 2:59 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson created T311848: Don't hardcode restbase base url in production.
Fri, Jul 1, 2:57 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson moved T311847: Localize Special:StoryBuilder to ID language from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.
Fri, Jul 1, 2:54 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson moved T311846: Make Story/Story_talk namespaces localizable and localized to ID language from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.
Fri, Jul 1, 2:54 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson created T311847: Localize Special:StoryBuilder to ID language.
Fri, Jul 1, 2:53 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson created T311846: Make Story/Story_talk namespaces localizable and localized to ID language.
Fri, Jul 1, 2:52 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson added a project to T311834: Wrong search result for MediaSearch in Commons, used in Wikistories: Inuka-Team.
Fri, Jul 1, 12:37 PM · Inuka-Team, SDAW-MediaSearch, Commons, Wikistories, Structured-Data-Backlog
SBisson created T311826: Support wikitext links in story text.
Fri, Jul 1, 10:53 AM · Inuka-Team, Wikistories
SBisson closed T311143: Deploy Wikistories to production as Resolved.
Fri, Jul 1, 12:06 AM · Wikistories (MVP), Inuka-Team (Kanban)
SBisson updated the task description for T311143: Deploy Wikistories to production.
Fri, Jul 1, 12:06 AM · Wikistories (MVP), Inuka-Team (Kanban)

Thu, Jun 30

SBisson removed a project from T310889: Unhandled exception when StoryBuilder is accessed without a valid subpage: Patch-For-Review.
Thu, Jun 30, 7:35 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson committed rEWST50ef358fd73d: Reword invalid subpage message (authored by SBisson).
Reword invalid subpage message
Thu, Jun 30, 7:34 PM
SBisson committed rEWST74df407d3318: Prevent potential prototype polution (authored by SBisson).
Prevent potential prototype polution
Thu, Jun 30, 7:34 PM
SBisson moved T311257: [StoryBuilder] Image attribution information is not updated when an image is replaced from Code Review to QA on the Inuka-Team (Kanban) board.
Thu, Jun 30, 1:20 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson moved T311141: Handle EndCall key from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
Thu, Jun 30, 1:17 PM · KaiOS-Wikipedia-app (Jio2), Inuka-Team (Kanban)
SBisson assigned T311141: Handle EndCall key to hueitan.
Thu, Jun 30, 1:17 PM · KaiOS-Wikipedia-app (Jio2), Inuka-Team (Kanban)

Wed, Jun 29

SBisson triaged T311257: [StoryBuilder] Image attribution information is not updated when an image is replaced as Medium priority.
Wed, Jun 29, 7:04 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson moved T311150: Show image attribution on Story page (no-js) from Backlog to R2 on the Wikistories board.
Wed, Jun 29, 2:45 PM · Wikistories (R2), Inuka-Team
SBisson added a project to T311284: Wikistories logo: Inuka-Team (Kanban).
Wed, Jun 29, 2:40 PM · Inuka-Team (Kanban), Logos, Wikistories
SBisson moved T308247: It is hard to tell what the CTA to create a WikiStory informs a user to do from MVP to R2 on the Wikistories board.
Wed, Jun 29, 12:31 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson moved T310329: On a story viewer, improve the design of read next story option from MVP to R2 on the Wikistories board.
Wed, Jun 29, 12:31 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson moved T310038: Improve Wikistories text rendering from MVP to R2 on the Wikistories board.
Wed, Jun 29, 12:31 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson moved T308255: Have a way to provide feedback about Wikistories in the StoryBuilder and/or StoryViewer from MVP to R2 on the Wikistories board.
Wed, Jun 29, 12:31 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson moved T311257: [StoryBuilder] Image attribution information is not updated when an image is replaced from MVP to R2 on the Wikistories board.
Wed, Jun 29, 12:30 PM · Wikistories (R2), Inuka-Team (Kanban)

Tue, Jun 28

SBisson moved T309771: Add a progress state while publishing a story from Code Review to QA on the Inuka-Team (Kanban) board.
Tue, Jun 28, 6:07 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson added a comment to T307682: Wikistories section (stories and CTA) makes the article content jump down.

@EUdoh-WMF the shift is caused by the change of styling of the line that says "Last edited 5 days ago...". This is caused by MobileFrontend and not us.

Tue, Jun 28, 3:39 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson committed rEWSTa5ead1febdc7: Localisation updates from https://translatewiki.net. (authored by L10n-bot).
Localisation updates from https://translatewiki.net.
Tue, Jun 28, 3:31 PM
SBisson moved T307682: Wikistories section (stories and CTA) makes the article content jump down from Dev to QA on the Inuka-Team (Kanban) board.

@EUdoh-WMF I'm not seeing any jump visually or with the Performance Insights dev tools. Could you double-check and let me know what you are seeing in details?

Tue, Jun 28, 3:02 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson added a comment to T296783: Re-order story pages.

Testing:

I have noticed some weird behaviour with this on my android device, using Chrome. Sometimes, it seems as though the page I want to move goes behind other pages and thus, does not get re-positioned. Here is a recording of the experience.

Tue, Jun 28, 2:51 PM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Wikistories (MVP), Inuka-Team (Kanban)
SBisson moved T307682: Wikistories section (stories and CTA) makes the article content jump down from QA to Dev on the Inuka-Team (Kanban) board.

Testing

@SBisson
The text at the bottom of the page is still pushed down slightly[...]

Tue, Jun 28, 2:50 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson moved T311257: [StoryBuilder] Image attribution information is not updated when an image is replaced from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.
Tue, Jun 28, 1:57 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson updated the task description for T311143: Deploy Wikistories to production.
Tue, Jun 28, 1:45 PM · Wikistories (MVP), Inuka-Team (Kanban)
SBisson placed T308247: It is hard to tell what the CTA to create a WikiStory informs a user to do up for grabs.

@eamedina it's all yours

Tue, Jun 28, 12:59 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson updated the task description for T311143: Deploy Wikistories to production.
Tue, Jun 28, 12:57 PM · Wikistories (MVP), Inuka-Team (Kanban)

Mon, Jun 27

SBisson moved T311249: Wikistories beta feature from Code Review to QA on the Inuka-Team (Kanban) board.
Mon, Jun 27, 7:23 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson triaged T311007: [Story Viewer] The text area should have a defined maximum height as Medium priority.
Mon, Jun 27, 7:20 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson updated the task description for T311143: Deploy Wikistories to production.
Mon, Jun 27, 5:24 PM · Wikistories (MVP), Inuka-Team (Kanban)
SBisson committed rEWSTe2238c448ec8: Show stories only on minerva (authored by SBisson).
Show stories only on minerva
Mon, Jun 27, 4:42 PM
SBisson edited projects for T310156: Configuration to enable/disable stories on articles, added: Wikistories, Inuka-Team; removed Wikistories (MVP), Inuka-Team (Kanban).
Mon, Jun 27, 2:15 PM · Inuka-Team, Wikistories
SBisson added a comment to T309128: Horizontally scroll thumbnail section to show newly added image.

@SGautam_WMF can this task be resolved?

Mon, Jun 27, 2:13 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Wikistories (MVP), Inuka-Team (Kanban)
SBisson moved T311143: Deploy Wikistories to production from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
Mon, Jun 27, 2:08 PM · Wikistories (MVP), Inuka-Team (Kanban)
SBisson updated the task description for T311143: Deploy Wikistories to production.
Mon, Jun 27, 2:08 PM · Wikistories (MVP), Inuka-Team (Kanban)
SBisson added a comment to T310889: Unhandled exception when StoryBuilder is accessed without a valid subpage.

I tried to put the title of a story(Meow) to edit but it resulted into the same error message instead of opening the story builder to allow me to edit the story.

Mon, Jun 27, 1:15 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson added a comment to T301134: Edit a story.

@SBisson Is it possible to open the story builder with story page on which a user has clicked on the edit button? As of now, it starts with the first story page.

Mon, Jun 27, 1:13 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Wikistories (MVP), Inuka-Team (Kanban)

Fri, Jun 24

SBisson committed rEWST6602aef9224c: Beta feature to show stories on article pages (authored by SBisson).
Beta feature to show stories on article pages
Fri, Jun 24, 5:13 PM
SBisson updated the task description for T311249: Wikistories beta feature.
Fri, Jun 24, 1:20 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson moved T311249: Wikistories beta feature from Dev to Code Review on the Inuka-Team (Kanban) board.
Fri, Jun 24, 1:20 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson added a comment to T308012: [StoryViewer] Navigating to a previous (and next) story frame.

It looks like we cannot use this feature on non-touch screens narrower than 1000px.

Fri, Jun 24, 1:01 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson moved T310889: Unhandled exception when StoryBuilder is accessed without a valid subpage from Code Review to QA on the Inuka-Team (Kanban) board.
Fri, Jun 24, 12:31 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson moved T311142: Disable experimental code from Code Review to QA on the Inuka-Team (Kanban) board.
Fri, Jun 24, 12:31 PM · KaiOS-Wikipedia-app (Engagement-1), Inuka-Team (Kanban)
SBisson moved T307682: Wikistories section (stories and CTA) makes the article content jump down from Code Review to QA on the Inuka-Team (Kanban) board.
Fri, Jun 24, 12:11 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson assigned T311142: Disable experimental code to hueitan.
Fri, Jun 24, 12:11 PM · KaiOS-Wikipedia-app (Engagement-1), Inuka-Team (Kanban)
SBisson triaged T311278: Log Event only when user close the viewer or moving to the next story as High priority.
Fri, Jun 24, 12:11 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson assigned T311298: story_view.story_frames_viewed is wrong to hueitan.
Fri, Jun 24, 12:11 PM · Wikistories (MVP), Inuka-Team (Kanban)
SBisson committed rEWSTc0a90f4f77c2: Load discover section progressively (authored by SBisson).
Load discover section progressively
Fri, Jun 24, 11:21 AM
SBisson triaged T311298: story_view.story_frames_viewed is wrong as High priority.
Fri, Jun 24, 10:32 AM · Wikistories (MVP), Inuka-Team (Kanban)
SBisson created T311298: story_view.story_frames_viewed is wrong.
Fri, Jun 24, 10:32 AM · Wikistories (MVP), Inuka-Team (Kanban)

Thu, Jun 23

SBisson triaged T311142: Disable experimental code as Medium priority.
Thu, Jun 23, 5:49 PM · KaiOS-Wikipedia-app (Engagement-1), Inuka-Team (Kanban)
SBisson claimed T311249: Wikistories beta feature.
Thu, Jun 23, 5:45 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson added a comment to T311249: Wikistories beta feature.

Don't forget to add the beta feature to the "BetaFeaturesWhitelist" config

Thu, Jun 23, 5:42 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson committed rEWST4524786632f4: Invalidate stories cache when related aticle changes (authored by SBisson).
Invalidate stories cache when related aticle changes
Thu, Jun 23, 5:35 PM
SBisson moved T309716: Changing 'fromArticle' field should update links from Code Review to QA on the Inuka-Team (Kanban) board.
Thu, Jun 23, 5:32 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson moved T308012: [StoryViewer] Navigating to a previous (and next) story frame from Code Review to QA on the Inuka-Team (Kanban) board.
Thu, Jun 23, 3:31 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson created T311249: Wikistories beta feature.
Thu, Jun 23, 3:27 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson triaged T309771: Add a progress state while publishing a story as High priority.

Thanks @SGautam_WMF I can see the images now.

Thu, Jun 23, 2:16 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson removed a project from T311186: Log event error for logStoryBuilderOpen: Patch-For-Review.
Thu, Jun 23, 1:58 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson moved T311186: Log event error for logStoryBuilderOpen from Code Review to QA on the Inuka-Team (Kanban) board.
Thu, Jun 23, 1:58 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson committed rEWSTe5ece8fa0250: Special:StoryBuilder: validate subpage (authored by SBisson).
Special:StoryBuilder: validate subpage
Thu, Jun 23, 7:50 AM
SBisson committed rEWSTab823da8bec4: Validate that the fromArticle field contains a valid article title (authored by SBisson).
Validate that the fromArticle field contains a valid article title
Thu, Jun 23, 7:49 AM

Wed, Jun 22

SBisson moved T301345: Preview shows "undefined" instead of the article preview for 2 pages from Code Review to QA on the Inuka-Team (Kanban) board.
Wed, Jun 22, 7:34 PM · Inuka-Team (Kanban), Wikipedia-Preview
SBisson moved T309668: Call to undefined method ForeignDBFile::getExtendedMetadata() from Code Review to QA on the Inuka-Team (Kanban) board.
Wed, Jun 22, 7:20 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Inuka-Team (Kanban), Wikistories (MVP), Beta-Cluster-Infrastructure
SBisson attached a referenced file: F35265126: localhost_8080_w_index.php_title=Boat&wikistories=1.png.
Wed, Jun 22, 5:31 PM · Wikistories (MVP), Performance-Team, Inuka-Team
SBisson added a comment to T301393: Performance review of Wikistories.

@Peter / @Krinkle we're currently reworking the loading process of stories on article pages and we don't really like any of the solutions we looked at. Wondering if you have any recommendations.

Wed, Jun 22, 5:30 PM · Wikistories (MVP), Performance-Team, Inuka-Team
SBisson updated subscribers of T311143: Deploy Wikistories to production.

@UOzurumba can you tell us which sites should receive Wikistories and if they are ready to receive it?

Wed, Jun 22, 3:44 PM · Wikistories (MVP), Inuka-Team (Kanban)
SBisson created T311150: Show image attribution on Story page (no-js).
Wed, Jun 22, 2:55 PM · Wikistories (R2), Inuka-Team
SBisson edited projects for T310157: Show only "validated" stories on articles, added: Inuka-Team; removed Inuka-Team (Kanban).
Wed, Jun 22, 2:54 PM · Inuka-Team, Wikistories
SBisson claimed T311143: Deploy Wikistories to production.
Wed, Jun 22, 2:34 PM · Wikistories (MVP), Inuka-Team (Kanban)
SBisson created T311143: Deploy Wikistories to production.
Wed, Jun 22, 2:34 PM · Wikistories (MVP), Inuka-Team (Kanban)
SBisson created T311142: Disable experimental code.
Wed, Jun 22, 2:30 PM · KaiOS-Wikipedia-app (Engagement-1), Inuka-Team (Kanban)
SBisson created T311141: Handle EndCall key.
Wed, Jun 22, 2:28 PM · KaiOS-Wikipedia-app (Jio2), Inuka-Team (Kanban)
SBisson added a comment to T305945: Admin page banner asking users for plugin reviews.

@SBisson

  1. The background colour of Button 2 is #f6f7f7 which is not really white (#fff).
  2. There should be some padding at the bottom of the buttons, which would be the same padding at the top before the text.
Wed, Jun 22, 2:05 PM · Wikipedia-Preview, Inuka-Team (Kanban)
SBisson added a comment to T309771: Add a progress state while publishing a story.

@SGautam_WMF all the image files used in the task description appears to be restricted (private to you) so I cannot view them. Can you look into that?

Wed, Jun 22, 2:01 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson added a comment to T309771: Add a progress state while publishing a story.

@SGautam_WMF all the image files used in the task description appears to be restricted (private to you) so I cannot view them. Can you look into that?

Wed, Jun 22, 12:34 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Wikistories (MVP), Inuka-Team (Kanban)
SBisson edited projects for T310157: Show only "validated" stories on articles, added: Wikistories; removed Wikistories (R2).

Thanks @Hillun for your feedback

Wed, Jun 22, 12:28 PM · Inuka-Team, Wikistories

Tue, Jun 21

SBisson added a comment to T306663: Incorrect popup positioning when the target is in the lower half of the screen.

It would be good to test this on the site where it was discovered - https://gorhambury.org/

Tue, Jun 21, 11:50 PM · Wikipedia-Preview, Inuka-Team (Kanban)

Mon, Jun 20

SBisson moved T308247: It is hard to tell what the CTA to create a WikiStory informs a user to do from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
Mon, Jun 20, 12:54 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson claimed T308247: It is hard to tell what the CTA to create a WikiStory informs a user to do.
Mon, Jun 20, 12:53 PM · Wikistories (R2), Inuka-Team (Kanban)

Sun, Jun 19

SBisson committed rEWST95637d8ba8ff: Commit composer.lock (authored by SBisson).
Commit composer.lock
Sun, Jun 19, 4:47 PM
SBisson triaged T308247: It is hard to tell what the CTA to create a WikiStory informs a user to do as Medium priority.
Sun, Jun 19, 4:41 PM · Wikistories (R2), Inuka-Team (Kanban)
SBisson triaged T308010: Show story title in story viewer as Medium priority.
Sun, Jun 19, 4:40 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Patch-For-Review, Wikistories (MVP), Inuka-Team (Kanban)

Sat, Jun 18

SBisson merged task T294631: disambiguation page preview is not looking great after publishing into T293594: [Suggestion] Show disambiguation extract in preview instead of redirect disambiguation suggested text when available.
Sat, Jun 18, 1:08 AM · Inuka-Team (Kanban), Wikipedia-Preview
SBisson merged T294631: disambiguation page preview is not looking great after publishing into T293594: [Suggestion] Show disambiguation extract in preview instead of redirect disambiguation suggested text when available.
Sat, Jun 18, 1:08 AM · Wikipedia-Preview, Inuka-Team (Kanban)

Fri, Jun 17

SBisson moved T296757: Can we make article text highlight better? from Kanban to Backlog on the Inuka-Team board.
Fri, Jun 17, 7:26 PM · Inuka-Team, Wikistories