Page MenuHomePhabricator

SBisson (Stephane Bisson)
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 6 2015, 8:49 PM (251 w, 1 d)
Availability
Available
IRC Nick
stephanebisson
LDAP User
Unknown
MediaWiki User
Sbisson (WMF) [ Global Accounts ]

Recent Activity

Today

SBisson updated the task description for T243904: Support popup positioning on small desktop screens.
Wed, Jan 29, 2:38 PM · Inuka-Team, Wikipedia-Previews
SBisson created T243904: Support popup positioning on small desktop screens.
Wed, Jan 29, 2:32 PM · Inuka-Team, Wikipedia-Previews

Mon, Jan 27

SBisson claimed T234435: Article title page.
Mon, Jan 27, 8:53 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson added a comment to T242553: Support article redirects.

The previous case found when article preview, here's one example on the search page

  1. search for fassale
  2. scroll down to the last item Fässler, Marcel
  3. read the article
  4. it should redirect to the canonical title Marcel_Fässler, but currently it doesn't
Mon, Jan 27, 8:48 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson updated the task description for T243774: Replace unfetch with XMLHTTPRequest.
Mon, Jan 27, 3:46 PM · Inuka-Team, Wikipedia-Previews
SBisson created T243774: Replace unfetch with XMLHTTPRequest.
Mon, Jan 27, 3:33 PM · Inuka-Team, Wikipedia-Previews

Fri, Jan 24

SBisson moved T241171: Empty state for Search when user's device is offline from Dev to Code Review on the Inuka-Team (Kanban) board.

https://github.com/wikimedia/wikipedia-kaios/pull/106

Fri, Jan 24, 9:13 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson moved T236897: Offline mode from Dev to Code Review on the Inuka-Team (Kanban) board.

https://github.com/wikimedia/wikipedia-kaios/pull/105

Fri, Jan 24, 8:38 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson updated the task description for T236897: Offline mode.
Fri, Jan 24, 6:04 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson updated the task description for T236897: Offline mode.
Fri, Jan 24, 6:03 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson removed a subtask for T236897: Offline mode: T241171: Empty state for Search when user's device is offline.
Fri, Jan 24, 6:03 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson removed a parent task for T241171: Empty state for Search when user's device is offline: T236897: Offline mode.
Fri, Jan 24, 6:03 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson moved T234619: Article quick facts from Dev to Code Review on the Inuka-Team (Kanban) board.
Fri, Jan 24, 1:55 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Thu, Jan 23

SBisson removed a watcher for GrowthExperiments: SBisson.
Thu, Jan 23, 1:46 PM
SBisson removed a member for GrowthExperiments-Homepage: SBisson.
Thu, Jan 23, 1:46 PM
SBisson added a comment to T238029: Code for InukaPageView instrumentation.

@nshahquinn-wmf I was able to test on betalabs. I discovered and fixed two issues: 1) there was a typo in the "client_type" field in the schema, 2) the referring_domain was mandatory but there are valid cases where the is just no referrer so I made it optional.

Thu, Jan 23, 1:27 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Traffic, Operations, Performance-Team (Radar), Inuka-Team (Kanban)
SBisson added a comment to T238029: Code for InukaPageView instrumentation.

Please do search on wikitech where all analytics docs are: https://wikitech.wikimedia.org/wiki/Analytics/Systems/EventLogging/TestingOnBetaCluster

Thu, Jan 23, 1:22 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Traffic, Operations, Performance-Team (Radar), Inuka-Team (Kanban)

Wed, Jan 22

SBisson added a comment to T238029: Code for InukaPageView instrumentation.

@nshahquinn-wmf This is enabled in betalabs. After hacking my GeoIP cookie to make it look like I'm in India, I was able to see the events being sent from the browser. Do you happen to know where the betalabs events end up?

Wed, Jan 22, 1:34 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Traffic, Operations, Performance-Team (Radar), Inuka-Team (Kanban)

Tue, Jan 21

SBisson placed T234435: Article title page up for grabs.
Tue, Jan 21, 3:24 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson moved T238029: Code for InukaPageView instrumentation from Code Review to QA on the Inuka-Team (Kanban) board.

A very special thanks to @phuedx for reviewing and merging the patch!!

Tue, Jan 21, 11:40 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Traffic, Operations, Performance-Team (Radar), Inuka-Team (Kanban)
SBisson moved T238028: Create InukaPageView schema from Code Review to QA on the Inuka-Team (Kanban) board.

This is for @nshahquinn-wmf to check and resolve.

Tue, Jan 21, 11:37 AM · Inuka-Team (Kanban)
SBisson moved T234619: Article quick facts from Code Review to Dev on the Inuka-Team (Kanban) board.
Tue, Jan 21, 2:55 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Mon, Jan 20

SBisson moved T234619: Article quick facts from Dev to Code Review on the Inuka-Team (Kanban) board.
Mon, Jan 20, 7:37 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Fri, Jan 17

SBisson added a comment to T242358: Record InukaPageView from KaiOS app.

I think the only remaining point is the os field; I suggest we rename it client_type, with allowable values of android-web, ios-web, kaios-web, and kaios-app.

Fri, Jan 17, 3:41 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Thu, Jan 16

SBisson added a comment to T242763: /page/summary/<title> often returns type: 'no-extract'.

Here's something I can reliably reproduce:

Thu, Jan 16, 4:02 PM · RESTBase, Page Content Service, MediaWiki-REST-API, Product-Infrastructure-Team-Backlog
SBisson added a comment to T242763: /page/summary/<title> often returns type: 'no-extract'.

Yes, it looks related to CORS. Is it possible that

Thu, Jan 16, 1:59 PM · RESTBase, Page Content Service, MediaWiki-REST-API, Product-Infrastructure-Team-Backlog
SBisson added a comment to T242553: Support article redirects.

@saper Thanks for reporting this issue. I think what you are seeing is a direct consequence of this issue: the correct (redirected) title is not propagated to other API calls.

Thu, Jan 16, 11:35 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Wed, Jan 15

SBisson added a comment to T209462: Moved notification leads to the old location.

Is this still relevant after T203941?

Wed, Jan 15, 8:53 PM · Google-Code-in-2019, MediaWiki-Email, Notifications, Growth-Team
SBisson updated the task description for T242553: Support article redirects.
Wed, Jan 15, 8:24 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson added a comment to T242763: /page/summary/<title> often returns type: 'no-extract'.

This is happening for me on all the browsers or devices I try it on but not for other people. Can it be wrongly cached near me?

Wed, Jan 15, 11:46 AM · RESTBase, Page Content Service, MediaWiki-REST-API, Product-Infrastructure-Team-Backlog

Tue, Jan 14

SBisson added a comment to T242763: /page/summary/<title> often returns type: 'no-extract'.

Strangely, if you go to https://en.wikipedia.org/wiki/Cat and hover over the word "carnivorous" in the first paragraph (with Page Previews enabled) it also gets a "no-extract" response and the popup shows an error message.

Tue, Jan 14, 7:22 PM · RESTBase, Page Content Service, MediaWiki-REST-API, Product-Infrastructure-Team-Backlog
SBisson moved T242082: Article Preview Adjustment from QA to Code Review on the Inuka-Team (Kanban) board.
Tue, Jan 14, 7:04 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson moved T242082: Article Preview Adjustment from Code Review to QA on the Inuka-Team (Kanban) board.
Tue, Jan 14, 7:04 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson added a comment to T242358: Record InukaPageView from KaiOS app.

@mpopov I just read this from the doc

Tue, Jan 14, 6:24 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson added a comment to T242358: Record InukaPageView from KaiOS app.

We do have support for sendBeacon. So you're suggesting we craft the request just like what the server expects and send it to the right URL? Works for me!

Tue, Jan 14, 6:20 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson added a comment to T242763: /page/summary/<title> often returns type: 'no-extract'.

Hi @Mholloway, thanks for looking into this!

Tue, Jan 14, 6:13 PM · RESTBase, Page Content Service, MediaWiki-REST-API, Product-Infrastructure-Team-Backlog
SBisson updated subscribers of T242358: Record InukaPageView from KaiOS app.

Open question: is there a javascript component we can use to send data from the KaiOS app to eventlogging? Is it what T228181 is?

Tue, Jan 14, 4:00 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson created T242763: /page/summary/<title> often returns type: 'no-extract'.
Tue, Jan 14, 3:56 PM · RESTBase, Page Content Service, MediaWiki-REST-API, Product-Infrastructure-Team-Backlog
SBisson added a watcher for Product-Infrastructure-Team-Backlog (Kanban): SBisson.
Tue, Jan 14, 3:27 PM
SBisson moved T234622: Article text size from Code Review to QA on the Inuka-Team (Kanban) board.

https://github.com/wikimedia/wikipedia-kaios/pull/82

Tue, Jan 14, 1:09 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Mon, Jan 13

SBisson updated the task description for T236322: Article styling elements.
Mon, Jan 13, 7:18 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson updated the task description for T236302: Image view and gallery.
Mon, Jan 13, 7:16 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson renamed T242553: Support article redirects from Detect redirect 304 page to Support article redirects.
Mon, Jan 13, 7:15 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson updated the task description for T241066: Video/Media of the day in search carousel.
Mon, Jan 13, 7:03 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson moved T242350: Empty state for Search and Article Change language page from Code Review to QA on the Inuka-Team (Kanban) board.

https://github.com/wikimedia/wikipedia-kaios/pull/83

Mon, Jan 13, 3:16 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson merged task T241054: Create "No results found" error when Search returns no results into T242350: Empty state for Search and Article Change language page.
Mon, Jan 13, 3:15 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson merged T241054: Create "No results found" error when Search returns no results into T242350: Empty state for Search and Article Change language page.
Mon, Jan 13, 3:15 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson edited projects for T234627: Article progress indicator, added: Inuka-Team; removed Inuka-Team (Kanban).
Mon, Jan 13, 2:27 PM · Inuka-Team, KaiOS-Wikipedia-app
SBisson moved T242082: Article Preview Adjustment from Backlog to Ready on the Inuka-Team (Kanban) board.
Mon, Jan 13, 2:25 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson closed T241720: Video not showing on device as Invalid.

Support for video will be implemented in T241066: Video/Media of the day in search carousel

Mon, Jan 13, 2:20 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson moved T242403: Article Footer - Suggested Article Section & Legal Section from Backlog to Dev on the Inuka-Team (Kanban) board.
Mon, Jan 13, 2:09 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson changed the subtype of T242429: Article - Empty content in <a> element from "Task" to "Bug Report".
Mon, Jan 13, 2:08 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson changed the subtype of T242553: Support article redirects from "Task" to "Bug Report".
Mon, Jan 13, 2:06 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson claimed T234619: Article quick facts .
Mon, Jan 13, 2:04 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson moved T234619: Article quick facts from Backlog to Dev on the Inuka-Team (Kanban) board.
Mon, Jan 13, 2:04 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Fri, Jan 10

SBisson added a comment to T242350: Empty state for Search and Article Change language page.

Note that the article API output contains languagecount to indicate in how many other languages the article is available. When this is 0, we could hide or disable the article language menu option so we don't have to deal with an empty state on that screen.

Fri, Jan 10, 1:44 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson added a comment to T242082: Article Preview Adjustment.

Remove title description

Fri, Jan 10, 1:42 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Thu, Jan 9

SBisson created T242364: Cleanup style (LESS files).
Thu, Jan 9, 7:59 PM · KaiOS-Wikipedia-app, Inuka-Team
SBisson created T242361: Generate Quick Facts (similar to infobox) from wikidata.
Thu, Jan 9, 7:12 PM · KaiOS-Wikipedia-app, Inuka-Team
SBisson moved T242358: Record InukaPageView from KaiOS app from Backlog to Kanban on the Inuka-Team board.
Thu, Jan 9, 6:57 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson updated the task description for T242358: Record InukaPageView from KaiOS app.
Thu, Jan 9, 6:21 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson created T242358: Record InukaPageView from KaiOS app.
Thu, Jan 9, 6:15 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson moved T234622: Article text size from Dev to QA on the Inuka-Team (Kanban) board.
Thu, Jan 9, 5:59 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson updated the task description for T242350: Empty state for Search and Article Change language page.
Thu, Jan 9, 5:34 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson updated the task description for T240886: Produce app zip file from CI.
Thu, Jan 9, 4:10 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson moved T240952: encode search key when opening preview from Dev to Code Review on the Inuka-Team (Kanban) board.

https://github.com/wikimedia/wikipedia-kaios/pull/76

Thu, Jan 9, 3:26 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson added a comment to T234628: Select language to read an article.

When an article doesn't exist in any other language (en/Line of succession to the British throne) there an error in the console and the language list is empty. Not sure what should happen, maybe a message.

Thu, Jan 9, 3:22 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson claimed T240952: encode search key when opening preview.
Thu, Jan 9, 2:58 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson added a comment to T240952: encode search key when opening preview.

yet another cases when the title has :
go to http://localhost:8080/#/article/en/Cat/External%20links, then click on the cat and Cat on first page.

Thu, Jan 9, 2:57 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson created T242342: Support interwiki links.
Thu, Jan 9, 2:57 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Wed, Jan 8

SBisson moved T241423: Go to Previous Article from Article Menu page from Code Review to QA on the Inuka-Team (Kanban) board.
Wed, Jan 8, 6:32 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson moved T242192: Error when loading article - History of Russia (1721-96) from Code Review to QA on the Inuka-Team (Kanban) board.
Wed, Jan 8, 1:58 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson claimed T242192: Error when loading article - History of Russia (1721-96).

https://github.com/wikimedia/wikipedia-kaios/pull/73

Wed, Jan 8, 11:59 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)

Tue, Jan 7

SBisson moved T240888: Better article loading experience from Code Review to QA on the Inuka-Team (Kanban) board.
Tue, Jan 7, 7:21 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson changed the subtype of T240878: Echo email notifications not bundling properly from "Bug Report" to "Feature Request".
Tue, Jan 7, 7:05 PM · Growth-Team, Notifications, MachineVision, Structured-Data-Backlog (Current Work)
SBisson added a comment to T240878: Echo email notifications not bundling properly.

@egardner Thanks for documenting your need here. It's now up to the Growth-Team to figure if/when they can work on it.

Tue, Jan 7, 7:05 PM · Growth-Team, Notifications, MachineVision, Structured-Data-Backlog (Current Work)

Mon, Jan 6

SBisson added a comment to T236301: Article footer and read more.

What should be the text of the table of content entry that leads to the footer section?

Mon, Jan 6, 3:25 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson moved T241364: Missing "goto" Section in article links pagination from Code Review to QA on the Inuka-Team (Kanban) board.
Mon, Jan 6, 3:21 PM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson added a comment to T240878: Echo email notifications not bundling properly.

Does email notification bundling only happen when users have set their preferences to daily or weekly digests? I has assumed that digests and notification bundles were not related.

Mon, Jan 6, 2:08 PM · Growth-Team, Notifications, MachineVision, Structured-Data-Backlog (Current Work)

Wed, Jan 1

SBisson moved T234628: Select language to read an article from Code Review to QA on the Inuka-Team (Kanban) board.
Wed, Jan 1, 6:42 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson moved T240992: sections menu doesn't take into account section I'm currently reading from Code Review to QA on the Inuka-Team (Kanban) board.
Wed, Jan 1, 6:42 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Dec 23 2019

SBisson assigned T236266: Article page menu to hueitan.

This task is for the menu itself. The items will come one at a time as the features are being developed.

Dec 23 2019, 3:47 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson claimed T241171: Empty state for Search when user's device is offline.
Dec 23 2019, 3:45 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson moved T241171: Empty state for Search when user's device is offline from Backlog to Dev on the Inuka-Team (Kanban) board.
Dec 23 2019, 3:45 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Dec 22 2019

SBisson added a comment to T241171: Empty state for Search when user's device is offline.

If possible: tapping 'Refresh' should be equivalent of refreshing a browser page

Dec 22 2019, 7:56 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson moved T236897: Offline mode from Backlog to Dev on the Inuka-Team (Kanban) board.
Dec 22 2019, 7:50 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson claimed T236897: Offline mode.
Dec 22 2019, 7:50 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Dec 21 2019

SBisson moved T241231: Article link spanning more than one page from Ready to Code Review on the Inuka-Team (Kanban) board.
Dec 21 2019, 2:42 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson claimed T241231: Article link spanning more than one page.
Dec 21 2019, 2:42 AM · KaiOS-Wikipedia-app, Inuka-Team (Kanban)
SBisson edited projects for T236898: Load i18n files through webpack instead of ajax, added: Inuka-Team; removed Inuka-Team (Kanban).

This is a nice optimization but we've found that fetching language files is actually fast enough on real devices.

Dec 21 2019, 2:38 AM · Inuka-Team, KaiOS-Wikipedia-app
SBisson claimed T240938: Don't show popup links.

This is done in PR 42

Dec 21 2019, 2:11 AM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Dec 20 2019

SBisson moved T234625: Select links within an article from Dev to Code Review on the Inuka-Team (Kanban) board.
Dec 20 2019, 7:20 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson edited projects for T234625: Select links within an article, added: Inuka-Team (Kanban); removed Inuka-Team.
Dec 20 2019, 7:20 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson renamed T241159: The "Sections" view is broken when there are no sections from the view is broken when section is empty to The "Sections" view is broken when there are no sections.
Dec 20 2019, 7:18 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson updated subscribers of T234628: Select language to read an article.

@cmadeo @AMuigai : @Amire80 is proposing to retitle the first popup "Language settings" (plural) for consistency with other apps. What do you think?

Dec 20 2019, 6:50 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app

Dec 19 2019

SBisson added a comment to T236322: Article styling elements.

See en/List of United States cities by population for an article that displays particularly badly.

Dec 19 2019, 7:06 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson added a comment to T234436: Article pagination.

The article footer should be a part of the 'About this article' section and should not be represented as an individual section in the TOC.

"About this article" is not a real article section. It is made up in the apps. My understanding now is that we DO want to create a special footer section available in the TOC.

Dec 19 2019, 4:16 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson added a comment to T236322: Article styling elements.

@SBisson On inline images, let's experiment with your idea of a small image icon, slightly larger than the one in search results, that pops out into an image viewer. If the image viewer could allow for descriptive text/captions of the image, that'd be great.

Dec 19 2019, 2:53 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson added a comment to T234436: Article pagination.

No, work is yet to be started on the article footer

Dec 19 2019, 1:52 PM · Inuka-Team (Kanban), KaiOS-Wikipedia-app
SBisson added a comment to T234627: Article progress indicator.

[...] can we fade out the first sentence or statement from the next page as shown in the mock here, so that the user understands to scroll down for more?

Dec 19 2019, 1:49 PM · Inuka-Team, KaiOS-Wikipedia-app