Page MenuHomePhabricator

SD0001
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 9 2018, 4:09 PM (277 w, 2 d)
Availability
Available
LDAP User
SD0001
MediaWiki User
SD0001 [ Global Accounts ]

Recent Activity

Sat, Mar 2

SD0001 added a comment to T358946: Peast complains about backslash that is part of a regex in valid JS code.

This is about the Peast validator used by ResourceLoader at serve-time.

Sat, Mar 2, 10:19 AM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader, JavaScript, MediaWiki-extensions-Gadgets

Wed, Feb 28

SD0001 added a comment to T357197: Allow ES8 (ES2017) code in gadgets.

It's not that simple I'm afraid. To diverge browser support in Gadgets from the rest of MediaWiki in this way you'd need customisation for mw.loader, for startup.js,

No customisation is required when gadgets are in a separate group. If any of them contain an ES8 feature which is not supported in the browser, the bundle doesn't work – which at the maximum can only cause other gadgets to not load, which seems like a reasonable tradeoff considering that no one so far has brought up a single example of a Grade A browser that doesn't support ES8. Even if one exists, gadgets are optional enhancements without which the site still works. Quoting from the frontend best practises: "Embrace that every page starts with basic HTML and CSS, and that JavaScript adds optional layers that may or may not arrive. Its eventual arrival depends on numerous factors, and may vary over time even for the same person"

Wed, Feb 28, 9:30 AM · MediaWiki-Platform-Team (Radar), MediaWiki-extensions-Gadgets

Sun, Feb 25

SD0001 closed T354023: Remove Gadget namespace (at least from search) as Resolved.

The namespaces have been removed globally in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Gadgets/+/980519/, see T31272#9574686.

Sun, Feb 25, 1:58 AM · MediaWiki-extensions-Gadgets

Sat, Feb 24

SD0001 reopened T347435: Warn when adding a URL that matches blocked external domains in the 2010 editor as "Open".

I think it's still a reasonable idea for future consideration, so it's worth keeping the ticket open.

Sat, Feb 24, 5:55 AM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), AbuseFilter, Wikimedia Wishathon, Community-Wishlist-Survey-2023

Fri, Feb 23

SD0001 created T358341: Allow localising content model names where model id includes uppercase chars.
Fri, Feb 23, 2:04 PM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Patch-For-Review, MediaWiki-ContentHandler

Wed, Feb 14

SD0001 added a comment to T66460: Dynamically generate files with Scribunto.

There are still several extensions able to display graphs; see the list. At least for one of them,

Yes but none of them are deployed on Wikimedia wikis.

Wed, Feb 14, 6:29 AM · Patch-Needs-Improvement, Scribunto

Tue, Feb 13

SD0001 added a comment to T66460: Dynamically generate files with Scribunto.

Now that graphs are no more, is there any interest in reviving the patch? Making pie charts, bar graphs etc are already possible by generating the HTML and inline styles through lua. I'm not familiar with SVGs - is there an advantage to using it instead?

Tue, Feb 13, 4:55 PM · Patch-Needs-Improvement, Scribunto
SD0001 placed T6469: Provide per-namespace site notices up for grabs.
Tue, Feb 13, 3:01 PM · Patch-Needs-Improvement, MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), MediaWiki-Core-Skin-Architecture, MediaWiki-User-Interface
SD0001 added a comment to T356159: Performance review for PageNotice extension.

Yeah exactly, the idea is that we just don't and let it get regenerated with refreshlinks/edits/expiry. I don't think page notices are time sensitive (similar to templates). I could be wrong though.

Well, when a namespace notice is created (or updated), one would expect to see it on all pages – not just on newly edited ones. I think it will be very confusing otherwise.

Tue, Feb 13, 12:40 PM · Wikimedia-Extension-setup, MediaWiki-extensions-PageNotice

Sat, Feb 10

SD0001 added a comment to T357197: Allow ES8 (ES2017) code in gadgets.

... if allowed even once, immediately breaks all code in many browsers that we still support.

Sat, Feb 10, 3:30 AM · MediaWiki-Platform-Team (Radar), MediaWiki-extensions-Gadgets
SD0001 added a comment to T277675: Add native support for ES2016-ES2020 or higher versions.

Let's continue the discussion on Gadgets in T357197, since it is indeed off-topic (or only tangentially related) to this task.

Sat, Feb 10, 3:27 AM · MediaWiki-Platform-Team, Wikimedia-Minify, Performance-Team, JavaScript, MediaWiki-ResourceLoader
SD0001 updated subscribers of T357197: Allow ES8 (ES2017) code in gadgets.

Discussion continued from T277675:

Sat, Feb 10, 3:26 AM · MediaWiki-Platform-Team (Radar), MediaWiki-extensions-Gadgets
SD0001 created T357197: Allow ES8 (ES2017) code in gadgets.
Sat, Feb 10, 3:25 AM · MediaWiki-Platform-Team (Radar), MediaWiki-extensions-Gadgets

Fri, Feb 9

SD0001 added a comment to T356159: Performance review for PageNotice extension.

The part of PageNotice extension that provides page-specific notices is not planned to be used in WMF prod, but only the namespace-level notices. They can use variables like {{PAGENAME}} so a cache strategy like that of core sitenotices (which are parsed once and reused across all pages) doesn't work. @daniel Can you confirm if parser caching is still workable? I am at a loss to understand how cache invalidation would work:

  • When a namespace notice is updated, we can't purge the PC of all pages in the namespace as that could be in the millions.
  • We could instead store the rev_id of the notice in the page's PC, and in the ArticleViewHeaderHook, check if the cached rev_id is still the latest. If not, ignore the cached notice and parse the notice now. In a deferred update, purge the page so that a cached notice would be available the next time.
    • However, this only works for logged-in views. For anonymous views, the entire HTML which includes the notices are served from the CDN cache, so users would see stale notices on pages which haven't been edited/purged after the notice update.
Fri, Feb 9, 4:09 PM · Wikimedia-Extension-setup, MediaWiki-extensions-PageNotice
SD0001 added a comment to T356159: Performance review for PageNotice extension.

@daniel @Ladsgroup Does this mean we should switch PageNotices to be in the page content language? Not sure if it's possible to put userlang stuff in PC. Right now they are rendered in user language but should be fine to switch to content language as it's a new feature.

Fri, Feb 9, 7:13 AM · Wikimedia-Extension-setup, MediaWiki-extensions-PageNotice

Jan 14 2024

SD0001 added a comment to T178356: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015).

(ES2018) for await - Firefox 58+, Safari 11.1+, Chrome 63+, Opera 50+, Edge 18+

For the record: This is incorrect. Both async and await comes with ES2017/ES8. See e.g.: https://flaviocopes.com/es2017/#async-functions and also https://262.ecma-international.org/8.0/

Jan 14 2024, 1:42 PM · MediaWiki-Platform-Team, User-notice-archive, MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Front-end Modernization, MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Browser-Support-Internet-Explorer, Performance-Team, JavaScript, MediaWiki-ResourceLoader
SD0001 updated subscribers of T277675: Add native support for ES2016-ES2020 or higher versions.
  • async function methods.
Jan 14 2024, 7:35 AM · MediaWiki-Platform-Team, Wikimedia-Minify, Performance-Team, JavaScript, MediaWiki-ResourceLoader
SD0001 added a comment to T75714: Update JavaScript syntax checker for gadgets and user-scripts for ES6 and later.
In T75714#9458179, @Nux wrote:

I'm confused. So which version of ES is supported e.g. without using requiresES6?

Jan 14 2024, 7:22 AM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ), Patch-For-Review, MediaWiki-Platform-Team, Design-System-Team, MediaWiki-ResourceLoader

Jan 11 2024

SD0001 created T354890: Expose cached query page outputs to lua.
Jan 11 2024, 5:45 PM · MediaWiki-Special-pages, Scribunto

Jan 7 2024

SD0001 added a comment to T75714: Update JavaScript syntax checker for gadgets and user-scripts for ES6 and later.

...

I'm unable to reproduce this result. In my benchmarks Peast is about 8% (or 0.08x) slower, not 200% (or 2.0x) slower.

My code and Peast version are part of https://gerrit.wikimedia.org/r/962739.

Jan 7 2024, 7:36 AM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ), Patch-For-Review, MediaWiki-Platform-Team, Design-System-Team, MediaWiki-ResourceLoader

Jan 5 2024

SD0001 claimed T354385: Some Gadgets are broken after 1.42.0-wmf.12 update with incorrect error message.
Jan 5 2024, 6:16 PM · MediaWiki-Platform-Team, MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), Wikimedia-production-error, MediaWiki-extensions-Gadgets

Jan 2 2024

SD0001 closed T353174: Specify all source pages in a single array in gadget definitions, a subtask of T31272: Implement Gadgets 2.0, as Resolved.
Jan 2 2024, 9:35 AM · User-notice, Gadgets-2.0, MediaWiki-extensions-Gadgets
SD0001 closed T353174: Specify all source pages in a single array in gadget definitions as Resolved.
Jan 2 2024, 9:34 AM · MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), MediaWiki-extensions-Gadgets

Dec 31 2023

SD0001 added a comment to T272297: User script on user subpage doesn't work after user rename.

We could probably allow loading orphaned javascript pages as long as they are redirects, those are already protected against editing.

Dec 31 2023, 12:21 PM · Patch-For-Review, GlobalRename, MediaWiki-extensions-CentralAuth, JavaScript, MediaWiki-User-rename, MediaWiki-General, SecTeam-Processed, Vuln-DoS
SD0001 added a comment to T110014: Make gadgets easily customizable (merge Gadgets' branch "gadgetprefs" from GSoC 2011).

The key advantage of having a built-in way to customise gadgets appears to be that gadgets wouldn't need to implement their own GUIs for this.

Dec 31 2023, 8:44 AM · MediaWiki-Core-Preferences, JavaScript, MediaWiki-extensions-Gadgets

Dec 25 2023

SD0001 updated subscribers of T353076: Deprecate and then drop mw.Map, obviated now we require ES6.

I thought mw.Map probably isn't covered by the frontend stable interface policy since it's a private class, but I realized that mw.messages, mw.user.options, and mw.user.tokens all use mw.Map. When the time comes that we shift those to using native JavaScript Maps, we will break a lot of gadgets which call .exists. We should tread carefully when executing this deprecation.

Dec 25 2023, 12:42 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Wikidata, MediaWiki-extensions-WikibaseClient, PageTriage, Patch-For-Review, Front-end-Standards-Group, MediaWiki-General

Dec 23 2023

SD0001 closed T349957: Allow bot credentials to be scoped to edit specific pages only as Resolved.
Dec 23 2023, 7:40 AM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), MediaWiki-Platform-Team, MediaWiki-Core-AuthManager, MediaWiki-extensions-OAuth

Dec 18 2023

SD0001 added a comment to T353617: Gadget definition extends beyond the viewport.

Yes, this is better to fix onwiki. I don't know why the enwiki page is formatted the way it is. There really should be spaces before and after every |, [, ], = and ,.

Dec 18 2023, 8:11 AM · MediaWiki-extensions-Gadgets

Dec 13 2023

SD0001 claimed T353174: Specify all source pages in a single array in gadget definitions.
Dec 13 2023, 10:40 AM · MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), MediaWiki-extensions-Gadgets
SD0001 claimed T331222: Don't persist default settings in gadget definition pages.
Dec 13 2023, 10:39 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-extensions-Gadgets
SD0001 added a comment to T348407: Create db user for Quarry with readonly access to public ToolsDB databases.

Hi @fnegri, did you get a chance to get to this? Thanks!

Dec 13 2023, 7:27 AM · cloud-services-team (FY2023/2024-Q3-Q4), Data-Services, Quarry

Dec 12 2023

Krinkle awarded T353174: Specify all source pages in a single array in gadget definitions a Like token.
Dec 12 2023, 1:13 PM · MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), MediaWiki-extensions-Gadgets
SD0001 reopened T298334: Validations for gadget definitions as "Open".

Not fully resolved I think. The merged patch shows warnings on Special:Gadgets. For the JSON definitions format, we can additionally surface them on preview or before save.

Dec 12 2023, 12:51 PM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team (Radar), MediaWiki-extensions-Gadgets

Dec 11 2023

SD0001 created T353174: Specify all source pages in a single array in gadget definitions.
Dec 11 2023, 5:15 PM · MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), MediaWiki-extensions-Gadgets

Dec 10 2023

SD0001 added a comment to T347435: Warn when adding a URL that matches blocked external domains in the 2010 editor.

The patch seems to be making an action=raw call to fetch MediaWiki:BlockedExternalDomains.json. If I'm reading correctly, that would fetch the JSON every time any page is opened for editing. Ideally, ResourceLoaderWikiModule should be used which can effectively cache the JSON on the client localStorage and also invalidate it in about 5 minutes when the json page is edited onwiki.

Dec 10 2023, 12:55 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), AbuseFilter, Wikimedia Wishathon, Community-Wishlist-Survey-2023
SD0001 added a comment to T254636: mysqldump is not present in Kubernetes container images.

@MusikAnimal Surely the mysqldump command needs a --host argument? The error message indicates it's trying to connect to the local mysql socket, but there's no mariadb/mysql running on the container itself, so it errors out.

Dec 10 2023, 11:06 AM · User-bd808, Toolforge (Software install/update)

Dec 8 2023

SD0001 closed T353047: CSV files not being written in UTF-8 as Invalid.

The text/csv response does specify chatset=utf-8.

Screenshot 2023-12-08 at 2.57.58 PM.png (744×1 px, 193 KB)

Dec 8 2023, 9:29 AM · Quarry

Dec 7 2023

SD0001 closed T298834: Create separate user right for editing json files in gadget namespace as Resolved.
Dec 7 2023, 3:55 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), MediaWiki-extensions-Gadgets

Dec 6 2023

Pppery awarded T298834: Create separate user right for editing json files in gadget namespace a Love token.
Dec 6 2023, 1:43 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), MediaWiki-extensions-Gadgets

Nov 20 2023

SD0001 added a comment to T351610: JavaScriptMinifier must not insert line break between `return` and returned value.

Reproducible on current master, when the entire original.js file is taken as input (not reproducible with just the function snippet given in task).

Nov 20 2023, 6:37 PM · MediaWiki-Engineering, Wikimedia-Minify

Nov 18 2023

SD0001 placed T270959: Expose more language data through the API up for grabs.
Nov 18 2023, 5:21 AM · Patch-Needs-Improvement, I18n, MediaWiki-Action-API
SD0001 created T351580: Creation of dynamic property Wikimedia\Rdbms\DatabaseMySQL::$_originalTablePrefix is deprecated.
Nov 18 2023, 5:08 AM · MediaWiki-Core-Tests, MediaWiki-libs-Rdbms

Nov 14 2023

SD0001 updated the task description for T344647: Named users should be able to Mute a temp account .
Nov 14 2023, 7:16 PM · Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)), MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Growth-Team, Temporary accounts, IP-Masking-Growth-Team
SD0001 reopened T344647: Named users should be able to Mute a temp account , a subtask of T326877: [Epic] Update Growth Team-owned products that may be affected by IP Masking, as Open.
Nov 14 2023, 7:16 PM · Growth-Team, IP-Masking-Growth-Team, Epic, Temporary accounts
SD0001 reopened T344647: Named users should be able to Mute a temp account as "Open".

Still a desirable feature even though the original assumption for filing was incorrect. The equivalent task for muting IPs now has a patch up for review.

Nov 14 2023, 7:16 PM · Trust and Safety Product Sprint (Sprint Lute (11th Dec. - 22nd Dec. 2023)), MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Growth-Team, Temporary accounts, IP-Masking-Growth-Team

Nov 13 2023

SD0001 added a comment to T207659: Allow 'Muted users' notification preference to support IP ranges.

Muting IP ranges would probably add a lot of complexity. T351091: Allow muting all non-permanent users filed today is a slightly different but probably still effective solution.

Nov 13 2023, 6:52 PM · Patch-For-Review, Growth-Team-Filtering, Anti-Harassment, Growth-Team, Notifications
SD0001 added a comment to T207659: Allow 'Muted users' notification preference to support IP ranges.

Brought up on enwiki village pump recently: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Why_can.27t_I_stop_IPs_using_the_ping_feature_to_abuse_me.3F. Not allowing users to mute IPs enables harassment.

Nov 13 2023, 4:47 PM · Patch-For-Review, Growth-Team-Filtering, Anti-Harassment, Growth-Team, Notifications

Nov 6 2023

SD0001 added a comment to T349032: Deploy magnum cluster for quarry.

The gunicorn migration sounds like an unlikely culprit, since it's the db connections referenced here - which are managed by pymysql in any case.

Nov 6 2023, 1:14 PM · Quarry

Nov 4 2023

SD0001 claimed T349957: Allow bot credentials to be scoped to edit specific pages only.
Nov 4 2023, 6:14 PM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), MediaWiki-Platform-Team, MediaWiki-Core-AuthManager, MediaWiki-extensions-OAuth

Nov 1 2023

SD0001 added a comment to T349957: Allow bot credentials to be scoped to edit specific pages only.

Okay. So I implemented the backend updates by including the serialized MWRestrictions in session metadata. The tricky part however seems to be the UI. HTMLRestrictionsField extends HTMLTextAreaField, and is also marked stable to extend (although there is no external use except for OAuth). I suppose we would change it to extend HTMLFormElement instead, but is there a precedence for an HTMLFormElement to actually represent two inputs?

Nov 1 2023, 6:33 PM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), MediaWiki-Platform-Team, MediaWiki-Core-AuthManager, MediaWiki-extensions-OAuth

Oct 31 2023

SD0001 added a comment to T349032: Deploy magnum cluster for quarry.

@rook This is due to misconfigured db config. I can see config.yaml has REPLICA_DOMAIN: '' which could be overriding the valid value provided a few lines above it.

Oct 31 2023, 8:33 PM · Quarry
SD0001 added a comment to T349957: Allow bot credentials to be scoped to edit specific pages only.

Thanks for the inputs @Tgr. I missed userCan(). MWRestrictions however seems to checked only at session creation, rather than at action level.

Oct 31 2023, 4:22 PM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), MediaWiki-Platform-Team, MediaWiki-Core-AuthManager, MediaWiki-extensions-OAuth

Oct 30 2023

SD0001 added a comment to T349957: Allow bot credentials to be scoped to edit specific pages only.

This could be implemented as follows:

  • Modify PermissionManager userHasRight() to take an optional third parameter which is the page id.
  • Add getAllowedPages() in PermissionManager and invoke it in userHasRight() if page id is passed. This function would call
    • getAllowedPages() in Session, which calls
      • getAllowedPages() in SessionBackend, which in turn calls
        • getAllowedPages() in SessionProvider, which is overridden by the provider implementation that checks if page id is allowed per the provider metadata
          • getAllowedPages() in BotPasswordSessionProvider
          • getAllowedPages() in SessionProvider in extensions/OAuth
  • Modify callers of userHasRight() to pass the page id for page-specific actions like edit, move, delete, and undelete.
  • Add bp_pages blob field to bot_passwords table (similar to bp_grants which is an array saved as blob). Modify SpecialBotPasswords, BotPassword and BotPasswordStore classes to handle the UI and db persistence.
  • Modify BotPasswordSessionProvider newSessionForRequest() to persist the pageids in session metadata.
Oct 30 2023, 7:27 PM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), MediaWiki-Platform-Team, MediaWiki-Core-AuthManager, MediaWiki-extensions-OAuth
SD0001 awarded T343499: Add minification support for async-await (ES2017) a Barnstar token.
Oct 30 2023, 4:48 PM · Wikimedia-Minify, MediaWiki-Platform-Team, MediaWiki-ResourceLoader

Oct 29 2023

SD0001 claimed T298334: Validations for gadget definitions.
Oct 29 2023, 9:54 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team (Radar), MediaWiki-extensions-Gadgets

Oct 28 2023

Pppery awarded T349957: Allow bot credentials to be scoped to edit specific pages only a Like token.
Oct 28 2023, 2:42 PM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), MediaWiki-Platform-Team, MediaWiki-Core-AuthManager, MediaWiki-extensions-OAuth
SD0001 created T349957: Allow bot credentials to be scoped to edit specific pages only.
Oct 28 2023, 2:15 PM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), MediaWiki-Platform-Team, MediaWiki-Core-AuthManager, MediaWiki-extensions-OAuth

Oct 27 2023

SD0001 added a comment to T347347: Make "Quick" MW install a thing.

Cloning mediawiki/core and mediawiki/skins/Vector, running composer update, and running php -S localhost:4000 does indeed get a MediaWiki running in about 15-20 minutes, with bulk of the time spent in cloning the repos.

Oct 27 2023, 5:21 AM · MW-1.42-notes (1.42.0-wmf.12; 2024-01-02), User-zeljkofilipin, MediaWiki-Platform-Team, MediaWiki-Documentation

Oct 26 2023

SD0001 added a comment to T291316: 'purge' permission is not checked for action=purge.

Discussion on Gadgets split off to T349792.

Oct 26 2023, 9:37 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), MW-1.41-notes, MediaWiki-Core-AuthManager
SD0001 updated subscribers of T349792: Gadget definition syntax should allow restricting a gadget to logged in users only.

Adding some context behind the ticket:

Oct 26 2023, 9:36 AM · Patch-For-Review, MediaWiki-extensions-Gadgets
SD0001 added a comment to T349690: Move away from nfs?.

Would be good to consolidate discussion in T178520: Find somewhere else (not NFS) to store Quarry's resultsets - maybe we could switch directly to object storage.

Oct 26 2023, 3:34 AM · Quarry
SD0001 added a watcher for Quarry: SD0001.
Oct 26 2023, 3:13 AM

Oct 25 2023

SD0001 added a comment to T349654: Allow gadgets to target change list pages .

Technically, are history pages even considered change list pages? ChangesListSpecialPage is only extended by Watchlist, RecentChanges and RecentChangesLinked. Apart from including the RL module mediawiki.special.changeslist, HistoryAction class makes no references to change lists.

Oct 25 2023, 4:45 PM · MediaWiki-extensions-Gadgets

Oct 24 2023

SD0001 closed T303194: Gadgets extensions should not cache serialized PHP objects as Resolved.
Oct 24 2023, 9:48 AM · MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Technical-Debt, MediaWiki-extensions-Gadgets

Oct 18 2023

Nardog awarded T338176: mw.notify() has a non-intuitive return value a Barnstar token.
Oct 18 2023, 8:20 PM · MediaWiki-Platform-Team, MW-1.41-notes (1.41.0-wmf.12; 2023-06-06), patch-welcome, JavaScript, MediaWiki-ResourceLoader, Performance-Team

Oct 17 2023

SD0001 added a comment to T348407: Create db user for Quarry with readonly access to public ToolsDB databases.

but I also want to consider another thing before opening this access: do we know of any tool that is currently storing any form of private/sensitive data in ToolsDB? For example, I imagine some tools might be using ToolsDB to store information related to user interactions with the tool itself, which I'm not sure we should make publicly available.

Oct 17 2023, 10:37 AM · cloud-services-team (FY2023/2024-Q3-Q4), Data-Services, Quarry

Oct 16 2023

SD0001 added a project to T348943: Add access control for Toolforge Elasticsearch: Elasticsearch.
Oct 16 2023, 4:09 AM · Elasticsearch, Toolforge
SD0001 created T348943: Add access control for Toolforge Elasticsearch.
Oct 16 2023, 4:04 AM · Elasticsearch, Toolforge

Oct 15 2023

SD0001 added a member for Quarry: SD0001.
Oct 15 2023, 7:34 PM

Oct 13 2023

SD0001 added a comment to T348762: IABot sometimes corrupts data due to an undetected edit conflict.

Yes, compared to the other API params. It was added in March 2020. Use of basetimestamp nowadays is almost-but-not-quite deprecated.

Oct 13 2023, 5:42 AM · InternetArchiveBot

Oct 12 2023

SD0001 added a comment to T348762: IABot sometimes corrupts data due to an undetected edit conflict.

This could be resolved by passing the baserevid param instead of basetimestamp. Self-conflicts are ignored only in case of basetimestamp.

Oct 12 2023, 4:46 PM · InternetArchiveBot
SD0001 added a comment to T348762: IABot sometimes corrupts data due to an undetected edit conflict.

T175745: Do not overwrite edits when conflicting with self

Oct 12 2023, 4:39 PM · InternetArchiveBot

Oct 10 2023

SD0001 added a comment to T348184: Add maintainers to quarry.

Thanks for the details. I had figured out the manual deployment process but had been confused about the role of Puppet – we don't use Puppet at all for this project?

Oct 10 2023, 1:05 PM · Quarry

Oct 8 2023

SD0001 created T348407: Create db user for Quarry with readonly access to public ToolsDB databases.
Oct 8 2023, 5:37 PM · cloud-services-team (FY2023/2024-Q3-Q4), Data-Services, Quarry

Oct 7 2023

SD0001 added a comment to T348184: Add maintainers to quarry.

@rook Are there any docs on how to do deployments once a GitHub PR gets merged?

Oct 7 2023, 5:45 PM · Quarry
SD0001 added a comment to T137179: Setup an easy way to have Quarry dump information / results on a wiki page.

Since last year, enwiki has a bot for this: https://en.wikipedia.org/wiki/Template:Database_report (it doesn't interact with Quarry - the bot runs the query directly on toolforge and dumps the results onwiki).

Oct 7 2023, 3:01 PM · Quarry
SD0001 added a comment to T151158: Support queries against Quarry's own database and ToolsDB.

I think letting users query public toolsdb databases has clear value (but not sure of the utility of querying quarry's internal db).

Oct 7 2023, 10:21 AM · cloud-services-team, Quarry
SD0001 added a comment to T289943: Quarry suggests invalid database names, and doesn't suggest some valid database names.

All of the invalid database names can be removed from the suggestions if we limit them to only include db names against which successful queries have been run in the past. This doesn't seem to significantly increase the internal query runtime.

Oct 7 2023, 9:52 AM · Quarry

Oct 6 2023

SD0001 added a comment to T348184: Add maintainers to quarry.

The networking limitation is overcome with an ssh tunnel. However, the code in replica.py to create the replica host URL is rather weird:

repl_host = (
    f"{self.database_name}.{self.config['REPLICA_DOMAIN']}"
    if self.config["REPLICA_DOMAIN"]
    else self.database_name
)
Oct 6 2023, 9:18 PM · Quarry
SD0001 added a comment to T348184: Add maintainers to quarry.

@rook Is there any staging/beta/QA environment as well for quarry? Never mind, got it: https://quarry-dev.wmflabs.org/

Oct 6 2023, 7:34 PM · Quarry

Oct 5 2023

SD0001 added a comment to T348184: Add maintainers to quarry.

Confirming that I got the invite. (And am able to login to the instances now.) Thanks.

Oct 5 2023, 4:36 PM · Quarry
SD0001 added a comment to T348184: Add maintainers to quarry.

My github id is siddharthvp. Also, how do we login to the instances where quarry runs? Doesn't seem to be documented on wikitech.

Oct 5 2023, 1:22 PM · Quarry

Sep 27 2023

SD0001 added a comment to T342960: Help migrate SDZeroBot to Lift Wing.

If multiple rev ids in a single call is not possible, what would be a reasonable concurrency level to make LW requests in parallel?

Sep 27 2023, 5:30 PM · ORES, Machine-Learning-Team
SD0001 added a comment to T342960: Help migrate SDZeroBot to Lift Wing.

Have merged the above PR so the 400 errors should be resolved now.

Sep 27 2023, 5:28 PM · ORES, Machine-Learning-Team

Sep 26 2023

SD0001 added a comment to T63007: Allow specifying when a gadget should load (action, namespace, content model).

@Quiddity Done.

Sep 26 2023, 7:43 PM · Patch-For-Review, User-notice, MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Wikimedia-Performance-recommendation, Wikimedia-Israel-Hackers, MediaWiki-extensions-Gadgets

Sep 22 2023

SD0001 added a project to T63007: Allow specifying when a gadget should load (action, namespace, content model): Patch-For-Review.

The next patch in the pipeline is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Gadgets/+/922062.

Sep 22 2023, 7:14 AM · Patch-For-Review, User-notice, MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Wikimedia-Performance-recommendation, Wikimedia-Israel-Hackers, MediaWiki-extensions-Gadgets
SD0001 added a comment to T63007: Allow specifying when a gadget should load (action, namespace, content model).

@Quiddity That is pretty much spot on! However, would suggest changing will only load when the viewed page is in one of the required namespaces -> will only load on pages in the given namespaces for simplicity.

Sep 22 2023, 7:13 AM · Patch-For-Review, User-notice, MW-1.41-notes (1.41.0-wmf.28; 2023-09-26), Wikimedia-Performance-recommendation, Wikimedia-Israel-Hackers, MediaWiki-extensions-Gadgets

Sep 15 2023

SD0001 removed a project from T346419: mw.loader.using should warn to the console when loading an unknown module: MediaWiki-extensions-Gadgets.

It does return a rejected promise if non-existent modules are requested:

> await mw.loader.using(['mediawiki.util', 'jquery.ui', 'ext.gadget.morebits'])
Uncaught Error: Unknown module: ext.gadget.morebits
    at sortDependencies (load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:6:804)
    at Object.resolve (load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector-2022:7:488)
    at mw.loader.using
    at <anonymous>:1:17
Sep 15 2023, 11:28 AM · MediaWiki CodeJam Dec 2023, MediaWiki-Engineering-Group-onboarding, MediaWiki-ResourceLoader, MediaWiki-Platform-Team

Sep 10 2023

SD0001 added a comment to T288161: Enable CodeMirror's Syntax Highlighting on English Wikipedia by default.

To take this forward, I think we need an RfC with consensus to enable this by default for all users (not just for new users – that's not happening).

Sep 10 2023, 6:55 AM · MediaWiki-extensions-CodeMirror, Wikimedia-Site-requests

Sep 7 2023

SD0001 moved T341421: Changing mobile gadget preferences disables gadgets that don't support Minerva from Backlog to Preferences tab on the MediaWiki-extensions-Gadgets board.
Sep 7 2023, 4:33 AM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6), Moderator-Tools-Team, MediaWiki-Core-Preferences, MediaWiki-extensions-Gadgets

Aug 22 2023

SD0001 added a comment to T344638: Abilty to load compacted versions of javascript and css pages.

The core use-case would be solved by T36958.

Aug 22 2023, 3:51 AM · MediaWiki-Platform-Team (Radar), MediaWiki-General

Aug 16 2023

SD0001 changed the status of T135964: Force pages to be fully re-parsed occasionally from In Progress to Open.

Task is to force the purges from the server level. Using a bot to purge pages through the API, as noted in the task description, is "an effective, but hackish and silly, workaround that seems to be awfully discouraged," although doing it is still welcome until a satisfactory solution to the problem is implemented.

Aug 16 2023, 11:39 AM · MediaWiki-Core-HTTP-Cache, MediaWiki-Parser
SD0001 changed the status of T135964: Force pages to be fully re-parsed occasionally, a subtask of T157670: Periodically run refreshLinks.php on production sites., from In Progress to Open.
Aug 16 2023, 11:39 AM · Platform Engineering Roadmap Decision Making, MediaWiki-Parser, MediaWiki-Page-editing, Parsing-Team--ARCHIVED

Jul 15 2023

Remagoxer awarded T36958: User-level gadget repositories a Love token.
Jul 15 2023, 11:17 AM · Patch-Needs-Improvement, MediaWiki-Platform-Team (Radar), SecTeam-Processed, Security-Team, MediaWiki-ResourceLoader, Proposal, MediaWiki-extensions-Gadgets, JavaScript

Jul 9 2023

SD0001 edited projects for T341421: Changing mobile gadget preferences disables gadgets that don't support Minerva, added: MediaWiki-Core-Preferences; removed MobileFrontend.

It's because Twinkle's gadget definition excludes it from minerva skin. So any pref changes made in minerva skin will reset preferences of non-minerva gadgets to the default value.

Jul 9 2023, 10:40 AM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6), Moderator-Tools-Team, MediaWiki-Core-Preferences, MediaWiki-extensions-Gadgets

Jun 27 2023

SD0001 added a comment to T340567: TypeError: Argument 1 passed to MediaWiki\Extension\Gadgets\Gadget::__construct() must be of the type array, object given.

Gadgets seems to also be using MainWANObjectCache (which is not per-host and not wiped on deployments), so you need to bump the cache version (the GADGET_CLASS_VERSION constant in this case) when changing the data format.

Jun 27 2023, 7:37 PM · User-brennen, MediaWiki-extensions-Gadgets, Wikimedia-production-error
SD0001 added a comment to T340567: TypeError: Argument 1 passed to MediaWiki\Extension\Gadgets\Gadget::__construct() must be of the type array, object given.

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Gadgets/+/826943

Jun 27 2023, 7:02 PM · User-brennen, MediaWiki-extensions-Gadgets, Wikimedia-production-error

Jun 24 2023

SD0001 updated subscribers of T75714: Update JavaScript syntax checker for gadgets and user-scripts for ES6 and later.

@Legoktm pointed out that page properties are an artifact of parsing and should only be modified within the parse, so instead of validating post-save we'd have to validate synchronously during the save – which I suppose is just about fine. The other option would be to do it post-save but store the result in some cache or a new db table.

Jun 24 2023, 3:27 PM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ), Patch-For-Review, MediaWiki-Platform-Team, Design-System-Team, MediaWiki-ResourceLoader

Jun 23 2023

SD0001 added a comment to T58362: Allow users to create custom notifications onwiki.

Coming back to this, I'm not sure if logging is a good idea. The closest MW function to this is email which is also not logged (except for the private CheckUser logging which identifies just the sender). Regarding the harassment possibility, I think we can ignore the concern as the same holds for email as well (to a bigger extent - emails don't have size limits and are available to all users than just bots, and even blocked users can send emails!).

Jun 23 2023, 5:57 PM · Patch-For-Review, Growth-Team-Filtering, Growth-Team, StructuredDiscussions, Notifications

Jun 22 2023

Framawiki awarded T58362: Allow users to create custom notifications onwiki a 100 token.
Jun 22 2023, 6:25 PM · Patch-For-Review, Growth-Team-Filtering, Growth-Team, StructuredDiscussions, Notifications