Page MenuHomePhabricator

SD0001
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 9 2018, 4:09 PM (190 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
SD0001 [ Global Accounts ]

Recent Activity

Mon, Jun 13

SD0001 awarded T306211: Echo oneself using API a Like token.
Mon, Jun 13, 5:18 PM · Patch-For-Review, Security-Team, Notifications, MediaWiki-Action-API, Growth-Team

Tue, Jun 7

SD0001 added a comment to T310007: Design explorations that make user preferences accessible to mobile web editors.

I think A or C make the most sense. B seems problematic as the tabs not visible without scrolling horizontally will be less discoverable.

Tue, Jun 7, 3:00 PM · Design, MediaWiki-Core-Preferences, Mobile, Moderator-Tools-Team

Apr 22 2022

Lens0021 awarded T303681: RL targets for gadget definition pages a Like token.
Apr 22 2022, 3:15 PM · MediaWiki-extensions-Gadgets

Apr 18 2022

SD0001 added a comment to T76204: Enforce JavaScript syntax check when editing user/site script pages.

The JSMinplus validator does not even support ES6 ( T75714). Even when it does, it's unlikely it would be constantly updated to support the latest ES variant of the day.

Apr 18 2022, 1:01 PM · Patch-For-Review, JavaScript, MediaWiki-ContentHandler
SD0001 added a comment to T75714: Update JavaScript syntax checker for gadgets and user-scripts for ES6.

I think validating on save and saving the result as a page property is a pretty good approach.

Apr 18 2022, 12:47 PM · Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader

Apr 7 2022

SD0001 added a comment to T298010: Querying ProcseeBot's user logs results in internal_api_error_DBQueryError.

I disabled the check for ProcseeBot's activity.

Apr 7 2022, 8:51 AM · MediaWiki-Action-API

Apr 3 2022

SD0001 added a comment to T253582: Let ResourceLoader only register skin modules for the current skin.

Now that ResourceLoaderModule::getSkins() patch has merged, possible approaches to move forward with this:

Apr 3 2022, 3:35 AM · MediaWiki-ResourceLoader, Performance-Team

Mar 19 2022

SD0001 added a comment to T300454: Edit Request Wizard.

@Ankur0710 Please review https://www.mediawiki.org/wiki/New_Developers#Some_general_communication_tips and https://www.gerv.net/hacking/how-to-ask-good-questions/. In short, to get further guidance you should mention what you've tried so far and where exactly you're stuck.

Mar 19 2022, 7:47 PM · VisualEditor, Google-Summer-of-Code (2022), Outreach-Programs-Projects

Mar 13 2022

SD0001 created T303681: RL targets for gadget definition pages .
Mar 13 2022, 1:08 PM · MediaWiki-extensions-Gadgets

Mar 12 2022

SD0001 added a comment to T302282: Real Time Preview performance safeguards.

Have we thought about coupling parse requests with the action=stashedit requests? The latter is also "real-time" with a debounce of 3 seconds IIRC. Instead of sending the full wikitext twice, how about creating a single API endpoint that does parse + stashedit? Or maybe modify either of those APIs to add an option to also do the other operation?

Mar 12 2022, 10:11 AM · Community-Tech (CommTech-Sprint-24), MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), Patch-For-Review, Performance-Team, Realtime-Preview-Wish-2021

Mar 6 2022

SD0001 added a comment to T303124: Special:NewPagesFeed times incorrectly show as 1 hour ahead.

@Novem_Linguae What timezone have you set in Special:Preferences?

Mar 6 2022, 10:37 AM · Growth-Team, PageCuration

Feb 27 2022

SD0001 added a comment to T294778: ApiQueryAllUsers with activeusers=1 excludes some clearly active users.

See also: T263931: Special:ActiveUsers misses some active users on some(?) wikis, T261290: Number of active users from ApiQueryAllUsers grossly different from Special:Statistics page

Feb 27 2022, 2:46 PM · MediaWiki-User-management
SD0001 added a project to T302669: ApiOptionsHook should allow modifying options: MediaWiki-Core-Preferences.

Couldn't SaveUserOptionsHook be used instead, as that's abortable?

Feb 27 2022, 2:35 PM · MediaWiki-Core-Preferences, MediaWiki-Action-API

Feb 26 2022

SD0001 added a comment to T241524: Parser function for loading gadgets.

This also serves the purpose of tracking which pages will be using the gadget.

Feb 26 2022, 5:39 AM · Patch-For-Review, MediaWiki-extensions-Gadgets

Feb 18 2022

Volker_E awarded T300000: Use capitallinkoverride for gadget namespace a Party Time token.
Feb 18 2022, 6:16 PM · MediaWiki-extensions-Gadgets

Feb 14 2022

Jdlrobson awarded T272904: PageTriage extension causes TypeError: format.replace is not a function in randomToken function im SearchSatisfaction schema a Mountain of Wealth token.
Feb 14 2022, 7:13 PM · Patch-For-Review, Unstewarded-production-error, Growth-Team, PageCuration, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), JavaScript, Wikimedia-production-error
Krinkle awarded T251994: Add hook that allows extensions to prevent preferences from getting exported to client-side a Orange Medal token.
Feb 14 2022, 1:27 PM · MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), Contributors-Team, MediaWiki-Core-Preferences, Performance-Team (Radar), MediaWiki-ResourceLoader

Feb 12 2022

SD0001 added a comment to T299537: ResourceLoader JS validator fails to recognize complex regex.

Do you perhaps have wgResourceLoaderValidateJS set to false?

Feb 12 2022, 2:06 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Performance-Team, MediaWiki-ResourceLoader

Feb 4 2022

SD0001 added a comment to T241524: Parser function for loading gadgets.

That said, I remain in the position that on-click interaction with supportsUrlLoad already fits 95% of the use cases ...

Feb 4 2022, 4:28 AM · Patch-For-Review, MediaWiki-extensions-Gadgets

Jan 31 2022

Remagoxer awarded T300000: Use capitallinkoverride for gadget namespace a Party Time token.
Jan 31 2022, 11:55 PM · MediaWiki-extensions-Gadgets

Jan 26 2022

IN awarded T300000: Use capitallinkoverride for gadget namespace a Party Time token.
Jan 26 2022, 10:41 AM · MediaWiki-extensions-Gadgets

Jan 25 2022

hashar awarded T300000: Use capitallinkoverride for gadget namespace a Love token.
Jan 25 2022, 10:15 PM · MediaWiki-extensions-Gadgets
SD0001 created T300000: Use capitallinkoverride for gadget namespace .
Jan 25 2022, 9:30 AM · MediaWiki-extensions-Gadgets

Jan 23 2022

SD0001 added a comment to T36958: User-level gadget repositories.

Preferences of enabled user gadgets are public. This helps with caching of the gadget startup module (group=user which enables them to be cached, unlike group=private which adds them to the HTML on every page load). I think this is fine regardless of the caching benefit as it mirrors the public nature of personal common.js pages, enabling technical editors to help others and identify use of malicious scripts.

Jan 23 2022, 5:05 PM · MediaWiki-ResourceLoader, Performance-Team (Radar), Patch-For-Review, Proposal, MediaWiki-extensions-Gadgets, JavaScript
SD0001 added a comment to T36958: User-level gadget repositories.

After doing some more extensive research, I figured out a better approach (see linked patch, ready for review) that does not involve embedding modules on the page. This approach enables user gadgets to exist as normal modules, triggered by a user-level startup module. The issues with the earlier approaches are resolved, and only trivial resourceloader changes are needed. Contrary to bullet 5 in T36958#7594392, user gadgets can be loaded adhoc via load.php?modules=ext.usergadget.p12345 (where the number is the pageid of the definition page) though this would not be considered officially supported.

Jan 23 2022, 5:04 PM · MediaWiki-ResourceLoader, Performance-Team (Radar), Patch-For-Review, Proposal, MediaWiki-extensions-Gadgets, JavaScript
SD0001 added a comment to T36958: User-level gadget repositories.

@Nux This task is essentially about T36958#387742, though I believe setting position is no longer an explicit RL feature (any module with just styles load without flicker).

Jan 23 2022, 2:37 PM · MediaWiki-ResourceLoader, Performance-Team (Radar), Patch-For-Review, Proposal, MediaWiki-extensions-Gadgets, JavaScript
SD0001 added a comment to T6469: Provide per-namespace site notices.

@Ammarpad I forgot that sitenotices on enwiki were dismissable. In testing on my localhost wiki, they were persistent – as MW core doesn't have a dismiss capability. Which is the extension that makes them dismissable? I think the usecases are for persistent namespace notices, so maybe we could change the extension to not work on ns notices.

Jan 23 2022, 3:31 AM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), MediaWiki-Core-Skin-Architecture, MediaWiki-Interface

Jan 20 2022

SD0001 awarded T299677: Provide public API to know whether an ES6 module can be loaded a Like token.
Jan 20 2022, 6:40 PM · MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Performance-Team, MediaWiki-ResourceLoader
SD0001 added a comment to T75714: Update JavaScript syntax checker for gadgets and user-scripts for ES6.

A hacky alternative to provide ES6 support in gadgets would be:

  • Introduce a new reserved group which disables validation.
  • Gadgets which mark themselves as es6-only are put in that group - so they are retrieved in a separate request than other gadgets and core/extension-loaded JS.

This means that if any one of these ES6-only gadgets contains a syntax error, all other enabled ES6-only gadgets would also fail, but core/extension-loaded modules and non-ES6 gadgets would work as usual. That seems like a reasonable compromise. Thoughts?

Jan 20 2022, 5:39 PM · Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader

Jan 19 2022

SD0001 added a comment to T298386: ResourceLoader minifier mangles unicode regex to produce invalid JavaScript.

Thanks @Krinkle for investigating this.

Jan 19 2022, 4:51 PM · Performance-Team (Radar), JavaScript, MediaWiki-ResourceLoader
SD0001 added a comment to T299537: ResourceLoader JS validator fails to recognize complex regex.

However, the odd thing is that it works correctly on my localhost wiki (running on git master). But not on testwiki or even on beta cluster.

Jan 19 2022, 4:08 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Performance-Team, MediaWiki-ResourceLoader
SD0001 added a comment to T298386: ResourceLoader minifier mangles unicode regex to produce invalid JavaScript.

In webpack.config.js file, uncomment the line terserOptions: { output: { ascii_only: true } } for a unicode-free build. This adds 4kb to the size, but it now works fine as a gadget.

Jan 19 2022, 4:04 PM · Performance-Team (Radar), JavaScript, MediaWiki-ResourceLoader
SD0001 created T299537: ResourceLoader JS validator fails to recognize complex regex.
Jan 19 2022, 4:03 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Performance-Team, MediaWiki-ResourceLoader

Jan 18 2022

SD0001 added a comment to T299365: Specifying submit action won't actually load gadgets on action=submit.

What is the usecase for specifying action=submit? If you're trying to target just the preview screens, note that if users have Live preview enabled, the previews are also displayed on the action=edit page. It's better to specify edit which loads the gadget on both edit and submit actions.

Jan 18 2022, 11:44 AM · MediaWiki-extensions-Gadgets

Jan 17 2022

Krinkle awarded T299071: Hidden gadget "preferences" being exported in mw.user.options a Orange Medal token.
Jan 17 2022, 10:52 PM · MW-1.38-notes (1.38.0-wmf.18; 2022-01-17), MediaWiki-Core-Preferences, MediaWiki-extensions-Gadgets
SD0001 added a project to T36958: User-level gadget repositories: MediaWiki-ResourceLoader.

So far I've been able to get user gadgets to work with group=user and group=private, but with two major limitations:

  1. Dependencies don't load. It appears that both group=user and group=private embed modules in the page rather than link them, and both don't support dependencies (or just behave weirdly with them, see T299288)
  2. If the docs are to be believed, in group=user caches aren't shared with other users – which is bad because a single user gadget is same for all users so caches should be shared. In group=private I think they aren't cached at all.
Jan 17 2022, 8:25 PM · MediaWiki-ResourceLoader, Performance-Team (Radar), Patch-For-Review, Proposal, MediaWiki-extensions-Gadgets, JavaScript
SD0001 added a comment to T288161: Enable CodeMirror's Syntax Highlighting on English Wikipedia by default.

This seems like an enwiki-specific workaround since for a missing feature (changing default preferences based on registration date) in core, not sure if extensions/CodeMirror is the best place for this or if it should be implemented somewhere else

Jan 17 2022, 3:54 PM · Patch-For-Review, MediaWiki-extensions-CodeMirror, Wikimedia-Site-requests

Jan 16 2022

SD0001 closed T290838: ApiQueryTokens should allow retrieval of all types of available tokens as Resolved.
Jan 16 2022, 5:44 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), MediaWiki-Action-API
SD0001 added a comment to T62973: Make Draft namespace visually distinct from articles.

T6469: Provide per-namespace site notices would help with this.

Jan 16 2022, 5:41 PM · WorkType-NewFunctionality, Design, WMF-General-or-Unknown
Legoktm awarded T298844: Link entries on Gadget definition pages a Orange Medal token.
Jan 16 2022, 8:57 AM · MW-1.38-notes (1.38.0-wmf.18; 2022-01-17), MediaWiki-extensions-Gadgets
SD0001 created T299303: Changing content model of a gadget definition page gives an internal error: Exception: Tried to save non-GadgetDefinitionContent.
Jan 16 2022, 8:50 AM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), MediaWiki-extensions-Gadgets
SD0001 added a comment to T299288: ResourceLoaderWikiModule with dependencies and group=user not loading.

Also if I change GadgetResourceLoaderModule's getGroup() to return 'user', now the gadgets do load and run but without their dependencies.

Jan 16 2022, 4:46 AM · Performance-Team (Radar), MediaWiki-ResourceLoader

Jan 15 2022

SD0001 closed T298844: Link entries on Gadget definition pages as Resolved.

Along with linking scripts, styles and datas from the original patch, linking of messages, the category, peers and gadget dependencies have also been implemented in the revised patch.

Jan 15 2022, 7:47 PM · MW-1.38-notes (1.38.0-wmf.18; 2022-01-17), MediaWiki-extensions-Gadgets
SD0001 renamed T298844: Link entries on Gadget definition pages from Make script/styles/data entries on Gadget definition pages links to Link entries on Gadget definition pages .
Jan 15 2022, 7:45 PM · MW-1.38-notes (1.38.0-wmf.18; 2022-01-17), MediaWiki-extensions-Gadgets
SD0001 created T299288: ResourceLoaderWikiModule with dependencies and group=user not loading.
Jan 15 2022, 6:24 PM · Performance-Team (Radar), MediaWiki-ResourceLoader
SD0001 added a comment to T151682: Add a new MediaWiki system message as a content header inside #mw-content-text.

Regarding the relationship with T6469 – that adds a namespace-specific sitenotice, which would be cached once per namespace view so is very performant. But the caching implies that we cannot use {{PAGENAME}} or other magic words whose value differ between pages in the namespace.

Jan 15 2022, 9:30 AM · Platform Engineering, Patch-For-Review, patch-welcome, MediaWiki-General

Jan 14 2022

SD0001 added a comment to T204201: Extend MediaWiki:Gadgets-definition capabilities.

BTW, you will need two URL calls, one for JavaScript and one for CSS.

No, unless you use &only=scripts or &only=styles filters, the same call includes JS, CSS and JSON (and messages).

Well, I am to retrieve for appropriate content model:

  • mw.loader.load( URL&only=scripts" );
  • mw.loader.load( URL&only=styles", "text/css" );
Jan 14 2022, 3:50 PM · Patch-For-Review, MediaWiki-extensions-Gadgets
SD0001 added a project to T288161: Enable CodeMirror's Syntax Highlighting on English Wikipedia by default: MediaWiki-extensions-CodeMirror.

Can't we use the LocalUserCreated hook to enable the feature for new users going forward? DiscussionTools uses this for enabling email notifications (for new messages in subscribed sections) for new users. This would require adding a config option so that only interested projects enable it, so re-adding the project tag.

Jan 14 2022, 9:42 AM · Patch-For-Review, MediaWiki-extensions-CodeMirror, Wikimedia-Site-requests

Jan 13 2022

SD0001 reopened T6469: Provide per-namespace site notices as "Open".

Re-opening as I could try to file a patch and there are strong use cases for it – on enwiki there have been multiple discussions about showing a banner on top of draft pages. See latest discussion at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(idea_lab)#Universal_notice_for_draftspace

Jan 13 2022, 6:18 PM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), MediaWiki-Core-Skin-Architecture, MediaWiki-Interface

Jan 12 2022

SD0001 created T299071: Hidden gadget "preferences" being exported in mw.user.options .
Jan 12 2022, 5:01 PM · MW-1.38-notes (1.38.0-wmf.18; 2022-01-17), MediaWiki-Core-Preferences, MediaWiki-extensions-Gadgets
SD0001 added a comment to T204201: Extend MediaWiki:Gadgets-definition capabilities.

And please correct me if I am wrong, but from my experience load.php?modules= does not include or request dependencies nor messages

Jan 12 2022, 4:10 PM · Patch-For-Review, MediaWiki-extensions-Gadgets
SD0001 added a comment to T29766: Allow loading gadget module by URL query parameter.

This is, unfortunately, wishful thinking. I have been reviewing gadgets on enwiki over the last few weeks, and have found XSS vulnerabilities in two of them.

Jan 12 2022, 6:37 AM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), User-notice, Security-Team, MediaWiki-extensions-Gadgets

Jan 11 2022

SD0001 created T298996: VisualEditor should load gadgets configured for action=edit.
Jan 11 2022, 8:11 PM · VisualEditor, VisualEditor-Initialisation, VisualEditor-MediaWiki
SD0001 added a comment to T29766: Allow loading gadget module by URL query parameter.

While it's obviously not risk-free, I don't think it adds any more risk than what exists already with unmaintained and antiquated gadgets in wide usage. By default, I think gadgets should be treated as safe. It doesn't make sense to consider trustworthiness of gadgets when anyway they can be edited by just interface-admins. Many wikis are already using withJS and withCSS so for those sites nothing much changes (other than the delivery being RL-optimised). Communities where it's possible to get interface-admins to gadgetize vulnerable/malicious code likely have larger problems to worry about.

Jan 11 2022, 4:32 PM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), User-notice, Security-Team, MediaWiki-extensions-Gadgets
SD0001 added projects to T251994: Add hook that allows extensions to prevent preferences from getting exported to client-side: Community-Tech, MediaWiki-Core-Preferences.

Tagging CommTech as steward of Preferences.

Jan 11 2022, 4:03 PM · MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), Contributors-Team, MediaWiki-Core-Preferences, Performance-Team (Radar), MediaWiki-ResourceLoader
SD0001 claimed T251994: Add hook that allows extensions to prevent preferences from getting exported to client-side.
Jan 11 2022, 7:08 AM · MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), Contributors-Team, MediaWiki-Core-Preferences, Performance-Team (Radar), MediaWiki-ResourceLoader
SD0001 claimed T68598: mw.loader state of module stuck at "loading" if request was aborted.
Jan 11 2022, 7:06 AM · Patch-For-Review, Performance-Team (Radar), patch-welcome, JavaScript, MediaWiki-ResourceLoader

Jan 9 2022

SD0001 created T298844: Link entries on Gadget definition pages .
Jan 9 2022, 3:56 AM · MW-1.38-notes (1.38.0-wmf.18; 2022-01-17), MediaWiki-extensions-Gadgets

Jan 8 2022

Sakretsu awarded T198758: Load .json configuration files via ResourceLoaderWikiModule a Like token.
Jan 8 2022, 5:53 PM · User-notice, MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), Performance-Team, MediaWiki-extensions-Gadgets, MediaWiki-ResourceLoader
Sakretsu awarded T29766: Allow loading gadget module by URL query parameter a Like token.
Jan 8 2022, 5:50 PM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), User-notice, Security-Team, MediaWiki-extensions-Gadgets
SD0001 created T298834: Create separate user right for editing json files in gadget namespace.
Jan 8 2022, 4:37 PM · MediaWiki-extensions-Gadgets
SD0001 added a comment to T75714: Update JavaScript syntax checker for gadgets and user-scripts for ES6.

https://github.com/mck89/peast looks like the only php library available that can validate JS syntax with modes for different ES versions. However, the benchmarks are:

Jan 8 2022, 2:46 PM · Patch-For-Review, Performance-Team, MediaWiki-ResourceLoader
SD0001 added a comment to T241524: Parser function for loading gadgets.

All things being considered, I think a parser function for loading gadgets would be a net positive, and better than having gadget definitions based on templates because (per the comments here and at T204201):

  1. If the template is moved, the gadget loading behaviour should move with it
  2. The gadget should also load on template sandboxes to facilitate development
Jan 8 2022, 1:11 PM · Patch-For-Review, MediaWiki-extensions-Gadgets
SD0001 added a comment to T297708: Set max execution time for several expensive mediawiki actions.

This is also sometimes causing the API to emit status code 500, apart from internal_api_errors (which have status 200).

Jan 8 2022, 7:25 AM · MW-1.36-notes, MW-1.37-notes, MW-1.35-notes, User-notice, MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), User-Ladsgroup, Platform Engineering, Sustainability (Incident Followup), DBA

Jan 7 2022

Ammarpad awarded T298561: Allow files from other wikis in gadget definitions a Like token.
Jan 7 2022, 5:26 PM · MediaWiki-extensions-Gadgets
SD0001 closed T29766: Allow loading gadget module by URL query parameter, a subtask of T71550: Move code in enwiki MediaWiki:Common.js and Gadgets to MediaWiki software, as Resolved.
Jan 7 2022, 2:11 PM · JavaScript, WMF-General-or-Unknown
SD0001 closed T29766: Allow loading gadget module by URL query parameter as Resolved.

Gadgets can now be loaded with ?withgadget= URL parameter. This is live in production wikis.

Jan 7 2022, 2:11 PM · MW-1.38-notes (1.38.0-wmf.19; 2022-01-24), User-notice, Security-Team, MediaWiki-extensions-Gadgets

Jan 6 2022

SD0001 added a comment to T297708: Set max execution time for several expensive mediawiki actions.

Per T298010, the API is currently returning errors that look like this: internal_api_error_DBQueryError: [12099b97-17b0-42c5-883d-464328a6e662] Caught exception of type Wikimedia\Rdbms\DBQueryError I suggest a more informative error message be used in case of timeouts.

Jan 6 2022, 6:16 PM · MW-1.36-notes, MW-1.37-notes, MW-1.35-notes, User-notice, MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), User-Ladsgroup, Platform Engineering, Sustainability (Incident Followup), DBA
SD0001 added a comment to T298704: Request for interface admin permission on en beta cluster.

Yes

Jan 6 2022, 4:19 PM · Beta-Cluster-Infrastructure
SD0001 created T298704: Request for interface admin permission on en beta cluster.
Jan 6 2022, 4:17 PM · Beta-Cluster-Infrastructure

Jan 4 2022

SD0001 added a comment to T298334: Validations for gadget definitions.

Adjusted description to focus on the problem, and also consider other approaches.

Jan 4 2022, 8:53 PM · MediaWiki-extensions-Gadgets
SD0001 renamed T298334: Validations for gadget definitions from Show gadget definition validation warnings in Special:Gadgets to Validations for gadget definitions.
Jan 4 2022, 8:53 PM · MediaWiki-extensions-Gadgets
SD0001 added a comment to T298561: Allow files from other wikis in gadget definitions.

Yes I realised allowing files from multiple wikis in the same gadget could be complex. This is where the alternative/equivalent suggestion ("it should be possible to define a gadget which is entirely loaded from another wiki – essentially a "pointer" gadget") comes in – precisely based on what GlobalCssJs does. In terms of meeting the usecases, this is equivalent to the original suggestion as we can always create another gadget that uses it as dependency and adds the extra local files.

Jan 4 2022, 8:26 PM · MediaWiki-extensions-Gadgets
SD0001 added a comment to T36958: User-level gadget repositories.

There is a one and only global name (but perhaps localized??) as page identifier and just one Gadgets-definition per user. Similar to Special:MyPage/Common.css which has a globally unique meaning. Well, better no localization but Special:MyPage/Gadgets-definition for all gadgets.

Jan 4 2022, 7:53 PM · MediaWiki-ResourceLoader, Performance-Team (Radar), Patch-For-Review, Proposal, MediaWiki-extensions-Gadgets, JavaScript
SD0001 added a comment to T298561: Allow files from other wikis in gadget definitions.

The usecases are same as that of global gadgets (T22153), but this is more moderate proposal, and could be more easily realisable. Apart from the technical complexity, truly global gadgets raise difficult questions – such as which community would maintain or edit the gadgets. In the absence of a sane code review workflow (T71445) and the very high access level (int-admin) required for editing, it will be difficult for users to maintain a gadget on a central foreign wiki.

Jan 4 2022, 7:48 PM · MediaWiki-extensions-Gadgets
SD0001 created T298561: Allow files from other wikis in gadget definitions.
Jan 4 2022, 7:46 PM · MediaWiki-extensions-Gadgets

Jan 3 2022

SD0001 claimed T36958: User-level gadget repositories.
  1. User-script authors define modules in their userspace, with page title having a .gadget suffix. These pages get the GadgetDefinition content model. Definitions are in the same format as the existing Gadget definition namespace (with some changes like not having a "default" and "hidden" keys).
  2. Users can save their list of enabled user modules (created by themselves or by others) via a titlesmultiselect field in gadgets tab of Special:Preferences.
  3. ResourceLoader modules are dynamically registered based on the current user. For contexts like load.php where there is no concept of a "current user", no user gadgets are registered.
  4. Dependencies and peers between user gadgets can be expressed using the titles of the definition pages (instead of the usual RL module ids).
  5. The above setup means that a user gadget is loaded only if you enable it from Preferences or if it's a dependency/peer of another enabled user gadget. Adhoc loading via mw.loader.load/using is NOT possible (but of course the individual scripts/stylesheets can be loaded that way). edit: It would be possible, see T36958#7643239
Jan 3 2022, 3:56 PM · MediaWiki-ResourceLoader, Performance-Team (Radar), Patch-For-Review, Proposal, MediaWiki-extensions-Gadgets, JavaScript

Jan 2 2022

SD0001 updated the task description for T298010: Querying ProcseeBot's user logs results in internal_api_error_DBQueryError.
Jan 2 2022, 6:04 PM · MediaWiki-Action-API

Jan 1 2022

SD0001 added a comment to T253582: Let ResourceLoader only register skin modules for the current skin.

The patch for T236603 adds a getSkins() methods to ResourceLoaderModule. If merged, skin modules can override it to provide the current skin name, solving this issue. This also gives skins the flexibility to allow certain modules to be exposed to other skins, if needed, such as for the usecase mentioned above (for use in a dependant skin).

Jan 1 2022, 4:29 AM · MediaWiki-ResourceLoader, Performance-Team
SD0001 updated the task description for T298419: Show indicator for new edits made while viewing page history.
Jan 1 2022, 4:20 AM · MediaWiki-Page-history
SD0001 created T298419: Show indicator for new edits made while viewing page history.
Jan 1 2022, 4:19 AM · MediaWiki-Page-history
SD0001 added a project to T295225: Show "Next edit" link on the latest diff if a new edit is made while user is viewing the diff: Revision-Slider.

If you were after a small overlay message which could say something like "Page has been edited in the meantime." or so, maybe that's an option.

Jan 1 2022, 4:06 AM · Revision-Slider, MediaWiki-Page-diffs

Dec 30 2021

SD0001 created T298386: ResourceLoader minifier mangles unicode regex to produce invalid JavaScript.
Dec 30 2021, 9:38 AM · Performance-Team (Radar), JavaScript, MediaWiki-ResourceLoader

Dec 27 2021

SD0001 created T298334: Validations for gadget definitions.
Dec 27 2021, 3:51 PM · MediaWiki-extensions-Gadgets

Dec 24 2021

SD0001 added a comment to T198758: Load .json configuration files via ResourceLoaderWikiModule.

Notes on testing the patch:

Dec 24 2021, 6:09 PM · User-notice, MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), Performance-Team, MediaWiki-extensions-Gadgets, MediaWiki-ResourceLoader

Dec 19 2021

SD0001 changed the subtype of T298010: Querying ProcseeBot's user logs results in internal_api_error_DBQueryError from "Bug Report" to "Production Error".
Dec 19 2021, 3:08 PM · MediaWiki-Action-API
SD0001 created T298010: Querying ProcseeBot's user logs results in internal_api_error_DBQueryError.
Dec 19 2021, 3:07 PM · MediaWiki-Action-API
SD0001 added a comment to T290838: ApiQueryTokens should allow retrieval of all types of available tokens.

Bot frameworks generally build token caches to allow the user to write API calls like: api.post({ ...., token: tokenCache.get('csrf') }), so they don't have to fetch a token before each request. It's easier to refresh this cache in one request rather than go through the more complicated flow mentioned in OP.

Dec 19 2021, 9:57 AM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), MediaWiki-Action-API

Dec 17 2021

SerDIDG awarded T198758: Load .json configuration files via ResourceLoaderWikiModule a Love token.
Dec 17 2021, 3:16 AM · User-notice, MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), Performance-Team, MediaWiki-extensions-Gadgets, MediaWiki-ResourceLoader

Nov 14 2021

SD0001 added a comment to T295502: Add skipFunction support for gadgets.

So my idea may be more hacky than I'd realised and different from the purpose of skipFunction. I was expecting such a feature could be used by gadgets which are applications, not libraries. They wouldn't be depended on by other gadgets, either via gadgets-definition or by mw.loader.using(). So arguably the dependency management isn't important for them.

Nov 14 2021, 10:04 AM · Performance-Team, MediaWiki-extensions-Gadgets

Nov 13 2021

SD0001 added a comment to T241404: Implement a way to retain draft comments.

Convenient-Discussions has this feature – WIP comments are saved in localStorage, a feature I've found really useful not just because it saves them from browser crashes, but also because it reduces the tendency for impulsive comments and gives you the freedom of letting the comment sit, think things through, and come back to the page at a later date to finish the reply.

Nov 13 2021, 12:25 PM · DiscussionTools

Nov 10 2021

SD0001 created T295502: Add skipFunction support for gadgets.
Nov 10 2021, 7:35 PM · Performance-Team, MediaWiki-extensions-Gadgets

Nov 7 2021

SD0001 added a comment to T295225: Show "Next edit" link on the latest diff if a new edit is made while user is viewing the diff.

Can you explain it would have a significant performance overhead? The total data transfer for checking the latest revid of a page is https://en.wikipedia.org/w/api.php?action=query&format=json&prop=revisions&titles=Barack%20Obama&rvprop=ids, which is tiny. There are several other tasks for real-time update features in mediawiki, notably T34284.

Nov 7 2021, 12:21 PM · Revision-Slider, MediaWiki-Page-diffs

Nov 6 2021

SD0001 added a comment to T295225: Show "Next edit" link on the latest diff if a new edit is made while user is viewing the diff.

Using JavaScript to query the latest revid of the page, say every 5 seconds, and checking if it matches the one client is seeing. To optimize this, the polling could be done only when that particular tab/window is active. Maybe it could be done using a web worker.

Nov 6 2021, 3:59 PM · Revision-Slider, MediaWiki-Page-diffs
SD0001 renamed T295225: Show "Next edit" link on the latest diff if a new edit is made while user is viewing the diff from Show a "Next diff" link for the latest revision if a new edit is made while user is viewing the diff to Show "Next edit" link on the latest diff if a new edit is made while user is viewing the diff.
Nov 6 2021, 2:58 PM · Revision-Slider, MediaWiki-Page-diffs
SD0001 created T295225: Show "Next edit" link on the latest diff if a new edit is made while user is viewing the diff.
Nov 6 2021, 2:54 PM · Revision-Slider, MediaWiki-Page-diffs

Nov 4 2021

SD0001 added a comment to T229168: Add a help link to Thanks confirmation & remove the confusing word "publicly".

The "Publicly send thanks?" prompt is created using the jQuery.confirmable plugin which only supports two buttons. It doesn't look as if adding a third generalizes well for the plugin.

Nov 4 2021, 4:18 PM · Growth-Team-Filtering, patch-welcome, Growth-Team, Thanks

Nov 2 2021

SD0001 awarded T113125: Investigate using service workers to provide real-time Echo notifications in the browser (push notifications) a Love token.
Nov 2 2021, 2:37 PM · Growth-Team-Filtering, User-notice, User-Jdlrobson, Wikimedia-Hackathon-2019, Growth-Team, Product-Infrastructure-Team-Backlog, Patch-For-Review, Push-Notification-Service, Notifications

Nov 1 2021

SD0001 added a comment to T289707: TemplateSandbox should support /sandbox subpages.

The ability is already available at the backend layer, both via the TemplateSandbox API as well as from normal webrequests. This can be invoked from scripts, eg. https://en.wikipedia.org/wiki/User:Jackmcbarn/advancedtemplatesandbox.js.

Nov 1 2021, 7:32 PM · MediaWiki-extensions-TemplateSandbox
SD0001 claimed T236603: Only register gadgets client-side from startup if relevant for the current skin.
Nov 1 2021, 2:15 PM · Performance-Team-publish, MW-1.39-notes (1.39.0-wmf.5; 2022-03-28), User-TheDJ, MediaWiki-extensions-Gadgets, Performance-Team (Radar)